This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] tty: improving the ttyspy example
David Smith wrote:
> On 10/21/2009 08:31 AM, Breno Leitao wrote:
>> David Smith wrote:
>>> In general, the tapset and testcase look fine. There are two questions
>>> I have that I've asked about below.
>>>
>>> But, I'm not sure these changes improves the ttyspy.stp example. I've
>>> never actually run it, but I believe your changes will display data that
>>> the existing probes have already printed (and disrupt the output
>>> formatting).
>> Yes. That is true. What is your suggestion here ?
>
> I guess I wouldn't change ttyspy.stp. If you'd like, create your own
> example script that shows off the tty tapset.
Ok. I just changed ttyspy.stp because Frank has asked me to put
there my "new" receive and write probes.
So, with those other fixes and without touching the ttyspy.stp, can I
push my patches ?