This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency
- From: Andrew Morton <akpm at linux-foundation dot org>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Hidehiro Kawai <hidehiro dot kawai dot ez at hitachi dot com>, Oleg Nesterov <oleg at redhat dot com>, Roland McGrath <roland at redhat dot com>
- Date: Fri, 13 Nov 2009 15:09:04 -0800
- Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency
- References: <20091113225226.15079.90813.stgit@harusame>
On Fri, 13 Nov 2009 17:52:27 -0500
Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Pass mm->flags to binfmt core_dump for bitflag consistency.
> Since mm->flags bit flags is not protected by locks, it will be
> changed while dumping core. This patch copies mm->flags to a
> mm_flags local variable at the beginning of do_coredump() and
> use it while dumping. mm_flags also includes dump_filter which
> filters elf sections from core file in elf_core_dump().
> So, this patch also passes mm_flags to each binfmt->core_dump().
I can kind-of guess the answer, but it would be much more reliable if
we were to hear this from yourself:
Why did you write this patch? What problem is being observed?