This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency
- From: Roland McGrath <roland at redhat dot com>
- To: Ingo Molnar <mingo at elte dot hu>
- Cc: Masami Hiramatsu <mhiramat at redhat dot com>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Hidehiro Kawai <hidehiro dot kawai dot ez at hitachi dot com>, Andrew Morton <akpm at linux-foundation dot org>, Oleg Nesterov <oleg at redhat dot com>
- Date: Fri, 13 Nov 2009 15:29:59 -0800 (PST)
- Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency
- References: <20091113225226.15079.90813.stgit@harusame> <20091113231602.2DD2C100E@magilla.sf.frob.com> <20091113232307.GB21666@elte.hu>
> this would fix the (probably harmless) race too, but isnt the whole
> approach taken by the patch more robust, i.e. to take a snapshot of
> mm->flags value and pass it along coredump processing?
Yes, I think it is a fine thing to do. I'm just being explicit about what
I think the (only) concrete issues are motivating a change.
> we should probably introduce a coredump parameter struct, and pass that
> along:
Also sounds fine to me.
Thanks,
Roland