This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 0/3] tracepoint: Add signal events
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: Roland McGrath <roland at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, Oleg Nesterov <oleg at redhat dot com>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>
- Date: Wed, 18 Nov 2009 11:32:34 -0500
- Subject: Re: [PATCH -tip 0/3] tracepoint: Add signal events
- References: <20091117234117.30589.61311.stgit@dhcp-100-2-132.bos.redhat.com> <20091118030706.EB93EA8C@magilla.sf.frob.com>
Roland McGrath wrote:
I would add the siginfo_t * argument to each of these tracepoints.
I see. Is it OK to record only si_errno and si_code? because si_signo
might be as same as sig.
In 2/3 this comment:
+ /* Trace the actual delivered signals including SIG_IGN.*/
might be slightly misleading. In most cases SIG_IGN signals won't make it
this far. The same is true of SIG_DFL signals whose default action is to
ignore. So one should be clear that trace_signal_deliver() is by no means
expected to get all SIG_IGN signals that are otherwise eligible for delivery.
Ah, thank you for noticing. I'll remove the last words.
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com