This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug translator/10690] need way to produce bigger procfs output


------- Additional Comments From jistone at redhat dot com  2010-02-09 00:05 -------
(In reply to comment #7)
> To build up bigger procfs output, I had assumed we'd use the string
> concatenation operator '.='.
> [...]
> From looking at var_expanding_visitor::visit_assignment() in tapsets.cxx, this
> is explicitly denied, with the following comment:
> 
>   // FIXME: for the time being, we only support plan $foo = bar,            
>   // not += or any other op= variant. This is fixable, but a bit            
>   // ugly.                                                                  
> 
> It might be time to fix this problem.

Well, the most general way I would fix that is to transform into an explicit
read-modify-write, which doesn't help if these procfs strings are oversized.

But in this specific case, I think we can just specialize visit_assignment() in
procfs_var_expanding_visitor, mapping ".=" to a new _procfs_value_append()
instead of _procfs_value_set().

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10690

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]