This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC] [PATCH 2.6.37-rc5-tip 8/20] 8: uprobes: mmap and fork hooks.
- From: Steven Rostedt <rostedt at goodmis dot org>
- To: Peter Zijlstra <peterz at infradead dot org>
- Cc: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, Ingo Molnar <mingo at elte dot hu>, Linux-mm <linux-mm at vger dot kernel dot org>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Christoph Hellwig <hch at infradead dot org>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Oleg Nesterov <oleg at redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, SystemTap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Andi Kleen <andi at firstfloor dot org>, Andrew Morton <akpm at linux-foundation dot org>, "Paul E. McKenney" <paulmck at linux dot vnet dot ibm dot com>
- Date: Tue, 25 Jan 2011 15:05:26 -0500
- Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 8/20] 8: uprobes: mmap and fork hooks.
- References: <20101216095714.23751.52601.sendpatchset@localhost6.localdomain6> <20101216095848.23751.73144.sendpatchset@localhost6.localdomain6> <1295957741.28776.719.camel@laptop>
On Tue, 2011-01-25 at 13:15 +0100, Peter Zijlstra wrote:
> On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:
> > +static void search_within_subtree(struct rb_node *n, struct inode *inode,
> > + struct list_head *tmp_list)
> > +{
> > + struct rb_node *p;
> > +
> > + if (p)
> > + __search_within_subtree(p, inode, tmp_list);
> > +
> > + p = n->rb_right;
> > + if (p)
> > + __search_within_subtree(p, inode, tmp_list);
> > +}
>
> Whee recursion FTW!, you just blew your kernel stack :-)
>
> Since you sort inode first, offset second, I think you can simply look
> for the first matching inode entry and simply rb_next() until you don't
> match.
Not to mention that p is uninitialized. Did this code ever work?
-- Steve