[Bug tapsets/12471] Support wait4 *status printing

["dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=12471

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-02-09 17:19:01 UTC ---
(In reply to comment #0)
> Created attachment 5232 [details]
> wait4 *status printing
> 
> probe syscall.wait4.return { printf ("%s(%s)=%s\n", name, argstr, retstr) }
> 
> then prints nice:
> wait4(-1, N/A, WNOHANG|__WCLONE, 0x0)=-10 (ECHILD)
> wait4(-1, WSTOPSIG=SIGTRAP, WNOHANG, 0x0)=9319
> 
> The problem is we need argstr from the .return function.
> Could we start providing argstr in all the syscall.return tapset hook?
> 
> This patch is on top of Bug 12470.
> 
> I do not understand where everywhere the code should be, it works here but
> there is a massive duplication of all the wait* syscall hooks.

I'm not too fond of this change: it changes the meaning of 'argstr' and we
don't really have access to entry arguments in return probes (it works, because
we add a hidden entry probe to cache the values).

Perhaps adding a new variable called 'statusstr' or 'status_str' that just gets
the value of _wait_status_str() is a better idea.

We could also provide the user with WIFEXITED/WEXITSTATUS/etc. functions if
anyone thinks that would be a good idea.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.