This is the mail archive of the
mailing list for the systemtap project.
Re: Fixed PR13146 by not allowing memory allocations to sleep
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Josh Stone <jistone at redhat dot com>
- Cc: Mark Wielaard <mjw at redhat dot com>, systemtap at sourceware dot org, dsmith at redhat dot com
- Date: Tue, 25 Oct 2011 08:06:53 -0400
- Subject: Re: Fixed PR13146 by not allowing memory allocations to sleep
- References: <email@example.com> <firstname.lastname@example.org> <4E82481E.email@example.com>
> I agree, those contexts which can sleep, should. Not only does this
> make it more likely we'll get the memory we want, but also makes us
> better citizens with the rest of the kernel.
Unfortunately, that's not quite sound policy either. The memory
allocation aggressiveness pendulum has swung too far with the new
code, and now large data structures are allocated with plain
GFP_KERNEL. On small-memory machines, this is found to OOM the
system, rather than let the stap module give up early.
An intermediate approach is needed; maybe __GFP_REPEAT & !__GFP_NOWAIT.