This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug runtime/14057] ERROR: Your privilege credentials (stapsys) are insufficient to run this module (stapdev required).


http://sourceware.org/bugzilla/show_bug.cgi?id=14057

--- Comment #5 from Mark Wielaard <mjw at redhat dot com> 2012-05-03 19:12:12 UTC ---
So to "fix" this the following patch works:

diff --git a/runtime/staprun/staprun.c b/runtime/staprun/staprun.c
index e01ba3f..46346b2 100644
--- a/runtime/staprun/staprun.c
+++ b/runtime/staprun/staprun.c
@@ -300,7 +300,7 @@ void disable_kprobes_optimization()

 int init_staprun(void)
 {
-       privilege_t user_credentials;
+       privilege_t user_credentials = 0;
        int rc;
        dbug(2, "init_staprun\n");


Then if we are root (getuid() == 0) we send zero, which seems to be what the
module expects. But I am somewhat reluctant to check this in without someone
who actually knows this code (and the security implications!) double checks.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]