This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[PATCH] Removed unneeded access().
- From: Pasi Savanainen <pasi dot savanainen at nixu dot com>
- To: systemtap at sourceware dot org
- Date: Wed, 13 Jun 2012 15:01:01 +0300
- Subject: [PATCH] Removed unneeded access().
* ctl.c: access() is not needed because previous open() will fail
if user has no read write accees to a command channel file.
Actually existance of access() check generates a misleading error:
"Error, 'stap_26013' (stap_26013) is not a zombie systemtap module."
when stap is runned by regular user (stapusr group)
and /sys/kernel/debug is mounted as 0700.
---
runtime/staprun/ctl.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/runtime/staprun/ctl.c b/runtime/staprun/ctl.c
index 1ffc8e3..96c140d 100644
--- a/runtime/staprun/ctl.c
+++ b/runtime/staprun/ctl.c
@@ -30,15 +30,6 @@ int init_ctl_channel(const char *name, int verb)
control_channel = open(buf, O_RDWR);
dbug(2, "Opened %s (%d)\n", buf, control_channel);
-/* It's actually safe to do this check before the open(),
- * as the file we're trying to access connot be modified
- * by a typical user.
- */
- if (access(buf, R_OK|W_OK) != 0){
- close(control_channel);
- return -5;
- }
-
if (control_channel < 0) {
if (verb) {
if (attach_mod && errno == ENOENT)
--
1.7.5.4