This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug tapsets/14642] pfiles.stp doesn't compile anymore because of missing FD_ISSET
- From: "jistone at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sourceware dot org
- Date: Fri, 28 Sep 2012 17:51:29 +0000
- Subject: [Bug tapsets/14642] pfiles.stp doesn't compile anymore because of missing FD_ISSET
- Auto-submitted: auto-generated
- References: <bug-14642-6586@http.sourceware.org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=14642
Josh Stone <jistone at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jistone at redhat dot com
--- Comment #1 from Josh Stone <jistone at redhat dot com> 2012-09-28 17:51:29 UTC ---
(In reply to comment #0)
> pfiles.stp doesn't compile anymore with my current kernel 3.5.4-1.fc17.x86_64
> It is complaining:
>
> error: implicit declaration of function âFD_ISSETâ
> [-Werror=implicit-function-declaration]
>
> I think this has something to do with this bug report:
> "__NFDBITS conflict between sys/select.h and linux/posix_types.h"
> https://bugzilla.redhat.com/show_bug.cgi?id=837641
>
> But this is for a kernel space script, and that report is for user land code.
It's true, that commit 8ded2bbc removed the FD_ISSET macro from the kernel.
Even before that though, it was simply a wrapper for __FD_ISSET, which was
removed earlier in commit cf420048.
> What should pfiles.stp include to get the correct FD_* definitions?
The previous __FD_ISSET was very simple:
static inline int __FD_ISSET(unsigned long __fd, const __kernel_fd_set
*__fdsetp)
{
return test_bit(__fd, __fdsetp->fds_bits);
}
It should be fine for pfiles.stp to use test_bit the same way.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.