This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip ] [BUGFIX] kprobes: Fix arch_prepare_kprobe to handle copy insn failures
- From: Jonathan Lebon <jlebon at redhat dot com>
- To: Steven Rostedt <rostedt at goodmis dot org>
- Cc: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Ingo Molnar <mingo at redhat dot com>, linux-kernel at vger dot kernel dot org, Ingo Molnar <mingo at kernel dot org>, "Frank Ch. Eigler" <fche at redhat dot com>, systemtap at sourceware dot org, yrl pp-manager tt <yrl dot pp-manager dot tt at hitachi dot com>
- Date: Fri, 7 Jun 2013 17:18:24 -0400 (EDT)
- Subject: Re: [PATCH -tip ] [BUGFIX] kprobes: Fix arch_prepare_kprobe to handle copy insn failures
- References: <20130605031216 dot 15285 dot 2001 dot stgit at mhiramat-M0-7522> <1370552806 dot 9844 dot 50 dot camel at gandalf dot local dot home>
Tested-by: Jonathan Lebon <jlebon@redhat.com>
Stress-tested overnight in a VM with no problems.
Jonathan
----- Original Message -----
From: "Steven Rostedt" <rostedt@goodmis.org>
To: "Masami Hiramatsu" <masami.hiramatsu.pt@hitachi.com>
Cc: "Ingo Molnar" <mingo@redhat.com>, linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Frank Ch. Eigler" <fche@redhat.com>, systemtap@sourceware.org, "yrl pp-manager tt" <yrl.pp-manager.tt@hitachi.com>
Sent: Thursday, June 6, 2013 5:06:46 PM
Subject: Re: [PATCH -tip ] [BUGFIX] kprobes: Fix arch_prepare_kprobe to handle copy insn failures
On Wed, 2013-06-05 at 12:12 +0900, Masami Hiramatsu wrote:
> Fix arch_prepare_kprobe() to handle failures in copy instruction
> correctly. This fix is related to the previous fix: 8101376
> which made __copy_instruction return an error result if failed,
> but caller site was not updated to handle it. Thus, this is the
> other half of the bugfix.
>
> This fix is also related to the following bug-report:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=910649
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Frank Ch. Eigler <fche@redhat.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> Cc: Ingo Molnar <mingo@kernel.org>
> ---
> arch/x86/kernel/kprobes/core.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>