This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug tapsets/15617] user_string_n_quoted() does not truncate properly
- From: "jlebon at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sourceware dot org
- Date: Thu, 13 Jun 2013 18:27:40 +0000
- Subject: [Bug tapsets/15617] user_string_n_quoted() does not truncate properly
- Auto-submitted: auto-generated
- References: <bug-15617-6586 at http dot sourceware dot org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=15617
Jonathan Lebon <jlebon at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Jonathan Lebon <jlebon at redhat dot com> ---
Fixed in this commit:
http://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=d03bc68e1f7050ba5dfeabbe3e40c43b24f1f283
The 'len' parameter passed to _stp_text_str() was incorrectly set to 1 higher
than need be. The function _stp_text_str() does not count the trailing NULL. In
contrast, the function _stp_strncpy_from_user() does, which is also used in
this tapset, in which case 'len' should indeed be incremented (see e.g.
user_string_n()). This may have been the source of the confusion.
--
You are receiving this mail because:
You are the assignee for the bug.