This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist
- From: Ingo Molnar <mingo at kernel dot org>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: "Frank Ch. Eigler" <fche at redhat dot com>, linux-arch at vger dot kernel dot org, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, x86 at kernel dot org, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, virtualization at lists dot linux-foundation dot org, systemtap at sourceware dot org, "David S. Miller" <davem at davemloft dot net>
- Date: Thu, 21 Nov 2013 08:29:38 +0100
- Subject: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist
- Authentication-results: sourceware.org; auth=none
- References: <20131120042148 dot 15296 dot 88360 dot stgit at kbuild-fedora dot novalocal> <y0mvbznxi6k dot fsf at fche dot csb> <20131120153801 dot GA9743 at gmail dot com> <20131120173600 dot GK8993 at redhat dot com> <528D6C9F dot 8050809 at hitachi dot com>
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> (2013/11/21 2:36), Frank Ch. Eigler wrote:
[ ... ]
> > one needs to resort to something like:
> >
> > # cat /proc/kallsyms | grep ' [tT] ' | while read addr type symbol; do
> > perf probe $symbol
> > done
> >
> > then wait for a few hours for that to finish. Then, or while the loop
> > is still running, run
> >
> > # perf record -e 'probe:*' -aR sleep 1
> >
> > to take a kernel down.
>
> Um, indeed, current blacklist is not perfect. [...]
Then it needs to be fixed ASAP!
> [...] As I reported in this series, I've found 2 more patterns. I
> guess there still have some others.
>
> But anyway, I don't think it is good to fix all such bugs in this
> series.
Fixing these bugs is far more important than any cleanup work.
We can apply the fixes together with your cleanup series to make it
all simpler, but the bug fixing absolutely needs to happen right now.
Thanks,
Ingo