This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v4 0/6] kprobes: introduce NOKPROBE_SYMBOL() and fixes crash bugs
- From: Ingo Molnar <mingo at kernel dot org>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, x86 at kernel dot org, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, systemtap at sourceware dot org, "David S. Miller" <davem at davemloft dot net>
- Date: Wed, 4 Dec 2013 09:45:51 +0100
- Subject: Re: [PATCH -tip v4 0/6] kprobes: introduce NOKPROBE_SYMBOL() and fixes crash bugs
- Authentication-results: sourceware.org; auth=none
- References: <20131204012841 dot 22118 dot 82992 dot stgit at kbuild-fedora dot novalocal>
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> Hi,
> Here is the version 4 of NOKPORBE_SYMBOL series.
>
> In this version, I removed the cleanup patches and
> add bugfixes I've found, since those bugs will be
> critical.
>
> Rest of the cleanup and visible blacklists will be proposed later in
> another series.
Ok, let me make it clear: we need _both_ the conceptual cleanups and
the bug fixes.
Right now kprobes are restricted to root, and they are unsafe and
buggy, and rather fundamentally so, because probing cannot be done
safely without potentially crashing the kernel. So there's no
'regression' to be fixed, it's mostly about pre-existing bugs - so
there's no requirement for them to come before maintainability
cleanups.
So we need both a maintainable and a sane/safe solution, and I'd like
to apply the whole thing at once and be at ease that the solution is
round. We should have done this years ago.
So could you please send a whole series that I can apply to -tip as a
work in progress tree, and then we can see what is left to be solved?
Thanks,
Ingo