This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v5 13/18] notifier: Use NOKPROBE_SYMBOL macro in notifier
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Ingo Molnar <mingo at kernel dot org>
- Cc: linux-arch at vger dot kernel dot org, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, x86 at kernel dot org, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, systemtap at sourceware dot org, "David S. Miller" <davem at davemloft dot net>
- Date: Wed, 11 Dec 2013 12:04:38 +0900
- Subject: Re: [PATCH -tip v5 13/18] notifier: Use NOKPROBE_SYMBOL macro in notifier
- Authentication-results: sourceware.org; auth=none
- References: <20131209104717 dot 13397 dot 8864 dot stgit at kbuild-fedora dot novalocal> <20131209104748 dot 13397 dot 52431 dot stgit at kbuild-fedora dot novalocal> <52A7D4C0 dot 7060700 at hitachi dot com>
(2013/12/11 11:58), Masami Hiramatsu wrote:
> (2013/12/09 19:47), Masami Hiramatsu wrote:
>> Use NOKPROBE_SYMBOL macro to protect functions from
>> kprobes instead of __kprobes annotation in notifier.
>
> Ah, this must just removes __kprobes since we don't use notify_die
> for kprobes anymore...
Oops, NO. kprobes generically still using the exception notifier to handle
GPF in the handler even on x86... For safety, I'd like to keep it as it is
until all dependency is removed.
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com