This is the mail archive of the xconq7@sources.redhat.com mailing list for the Xconq project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: tkconq.tcl


This is a response to a private email which I have quoted at the
bottom of this message.

What does the ".scores.main.text configure -state normal" do?  I
tried opening the scores window, resigning (to create a new entry),
and it seemed to show up normally.  I think that setting the state to
normal is only needed when you are getting user input, not when you
are sending output from xconq (although I'm far from a tcl/tk expert
and the text(n) manpage doesn't seem to be very clear on the subject).

As for -pad, I don't know perl well enough to parse your suggested
change.  Can you send as a diff?  Or an English description or what
you propose to change?  (I'm using tcl and tk 8.3.3, as shipped in Red
Hat Linux 7.2, so I'm not seeing the problem myself).

mniw@sol.dti.ne.jp writes:

Sorry, I sent the previous patch wihout heavy testing.
There is another spot that has to be fixed.

and, I compiled Xconq with Tcl/Tk8.4a4 and noticed that The "-pad" option in tkconq.tcl causes a error.
This line seems to work.
perl -n -e 's/(-pad)(\s\S+)/$1x$2 $1y$2/; print' < tkconq.tcl.orig > tkconq.tcl

--- tcltk/tkconq.tcl.orig	Wed Mar 13 21:51:19 2002
+++ tcltk/tkconq.tcl	Wed Mar 13 22:04:50 2002
@@ -3382,8 +3382,10 @@
     if { "[ winfo exists .scores ]" } {
 	wm deiconify .scores
 	# Refresh the scores list each time.
+        .scores.main.text configure -state normal
 	.scores.main.text delete 1.0 end
 	.scores.main.text insert end [ get_scores ]
+        .scores.main.text configure -state disabled
 	return
     }
 
@@ -3393,7 +3395,9 @@
     scrolled_textbox .scores.main
     pack .scores.main -side top -fill both -expand true
 
+    .scores.main.text configure -state normal
     .scores.main.text insert end [ get_scores ]
+    .scores.main.text configure -state disabled
 
     button .scores.close -text "Close" -command { dismiss_scores }
     pack .scores.close


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]