]> cygwin.com Git - cygwin-apps/setup.git/blame - ChangeLog
* PickView.h (PickView::total_delta_x): New int member.
[cygwin-apps/setup.git] / ChangeLog
CommitLineData
0baffe9a
DK
12009-07-01 Dave Korn <dave.korn.cygwin@gmail.com>
2
3 * PickView.h (PickView::total_delta_x): New int member.
4 (PickView::set_header_column_order): Add prototype.
5 * PickView.cc (PickView::set_header_column_order): New function,
6 broken out from ...
7 (PickView::set_headers): ... here. Call it.
8 (PickView::init_headers): Apply total_delta_x to last_col width.
9 (PickView::PickView): Initialise new total_delta_x member to zero.
10 (PickView::WindowProc): Use set_header_column_order to find and
11 adjust final column for both sets of headers.
12
ca2b7505
CF
132009-06-29 Christopher Faylor <me+cygwin@cgf.cx>
14
15 * SourceSetting.cc (SourceSetting::SourceSetting): Restore proper
16 remembrane of last source setting.
17 * choose.cc (ChooserPage::ChooserPage): Potentially retrieve dialog
18 placement info.
19 (ChooserPage::~ChooserPage): Save geometry settings if the user moved
20 or resized the page.
21 (ChooserPage::PlaceDialog): Rename from MaximizeDialog. Accommodate
22 changed user placement settings.
23 (ChooserPage::OnActivate): MaximizeDialog -> PlaceDialog.
24 (ChooserPage::OnNext): Ditto.
25 * choose.h (ChooserPage::~ChooserPage): Define.
26 (ChooserPage::cmd_show): Delete.
27 (ChooserPage::saved_geom): New field.
28 (ChooserPage::window_placement): Ditto.
29 (ChooserPage::pre_chooser_placement): Ditto.
30 (ChooserPage::PlaceDialog): Rename from MaximizeDialog.
31
7c863922
CF
322009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
33
34 * ConnectionSetting.cc (ConnectionSetting::ConnectionSetting): Remove
35 old code which no longer makes sense when run from a constructor.
36 * SourceSetting.cc (SourceSetting::SourceSetting): Ditto.
37 * localdir.cc (LocalDirSetting::LocalDirSetting): Ditto. Fix typo
38 which caused saved settings to be ignored.
39
127febea
CF
402009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
41
42 * UserSettings.cc (UserSettings::UserSettings): settings.rc -> setup.rc.
43
e36b0f1e
CV
442009-06-28 Corinna Vinschen <corinna@vinschen.de>
45
46 * desktop.cc (DesktopSetupPage::OnInit): Drop CoInitialize call here.
47 * main.cc (main_display): Use InitCommonControlsEx rather than
48 InitCommonControls per MSDN. Call CoInitializeEx and create IShellLink
49 instance here to workaround a problem on Windows 7. Release IShellLink
50 instance and call CoUninitialize on exit.
51 * mklink.cc (sl): Change to global variable. Drop call to
52 CoCreateInstance here. Check if sl is valid before using it.
53
f26f525f
CF
542009-06-27 Christopher Faylor <me+cygwin@cgf.cx>
55
56 Preliminary option handling revamp.
57 Throughout, change load/save methods to constructors/destructors which
58 use new UserSettings methods. Do not inherit from UserSetting class.
59 * KeysSetting.cc (ExtraKeysSetting *ExtraKeysSetting::global): Define.
60 (ExtraKeysSetting::ExtraKeysSetting): Initialize some class members use
61 new UserSettings methods.
62 (ExtraKeysSetting::~ExtraKeysSetting): Use new UserSettings method.
63 * Makefile.am (setup_SOURCES): Eliminate UserSetting.h and
64 UserSetting.cc.
65 * UserSettings.cc: Complete rewrite. Implements new UserSettings
66 class methods.
67 * UserSettings.h: Complete rewrite. Defines new UserSettings class
68 methods.
69 * crypto.cc (ExtraKeys): Delete.
70 (add_key_from_sexpr): Use ExtraKeysSetting::instance rather than
71 ExtraKeys.
72 (verify_ini_file_sig): Ditto.
73 * io_stream.h (io_stream): Define virtual << operators.
74 * localdir.cc (localDir): Delete.
75 * main.cc: Include headers which declar new dynamically invoked
76 classes.
77 (main_display): New function. Controls order of option setting and
78 property page setup. Add new class invocations to force option setting
79 initializtion.
80 (main): Invoke new UserSettings class constructor to populate new
81 settings class. Call main_display() to do most of the setup work.
82 Call Settings.save () to save all settings.
83 * net.cc (theSetting): Delete.
84 * site.cc (SiteSetting::save): Record whether we've saved the
85 information already.
86 (get_site_list): Just use value returned from new UserSettings method
87 rather than parsing a file.
88 (SiteSetting::getSavedSites): Ditto.
89 (write_cache_list): Use UserSettings operator to store mirror cache.
90 (save_cache_file): Ditto.
91 * source.cc (theSetting): Delete.
92
93 * win32.h: gcc-4 accommodation.
94
9d0a3d8a
DK
952009-06-26 Dave Korn <dave.korn.cygwin@gmail.com>
96
97 * res.rc (SETUP_STANDARD_DIALOG_W, SETUP_STANDARD_DIALOG_H,
98 SETUP_SMALL_DIALOG_W, SETUP_SMALL_DIALOG_H): Add constant defines
99 for dialog sizes.
100 (SETUP_STANDARD_DIALOG_DIMS, SETUP_SMALL_DIALOG_DIMS): Add helper
101 macros for (W,H) pairs of dimensions.
102 (SETUP_HEADICON_X): New global constant define.
103 (IDD_SOURCE, IDD_VIRUS, IDD_LOCAL, IDD_ROOT, IDD_SITE, IDD_NET,
104 IDD_INSTATUS, IDD_PROXY_AUTH, IDD_NET_AUTH, IDD_DESKTOP,
105 IDD_FTP_AUTH DIALOG, IDD_DROPPED): Use the above for dialog sizes,
106 horizontal rules and icon positioning.
107 (SETUP_KPCE_W): New define for radio-button size.
108 (SETUP_VIEWCAP_W, SETUP_VIEWCAP_X, SETUP_VIEW_W, SETUP_VIEW_X,
109 SETUP_EXP_X, SETUP_CURR_X, SETUP_PREV_X, SETUP_KEEP_X): Add defines
110 for right-aligned controls.
111 (SETUP_SEARCH_X, SETUP_SEARCH_W, SETUP_SEARCHTEXT_X,
112 SETUP_SEARCHTEXT_W, SETUP_CLEAR_X, SETUP_CLEAR_W): Likewise defines
113 for left-aligned controls.
114 (IDD_CHOOSE): Use all the above, and reformat with whitespace
115 between args for clarity.
116
1789ef54
CV
1172009-06-26 Corinna Vinschen <corinna@vinschen.de>
118
119 * Makefile.am (setup_LDADD): Add -lshlwapi.
120 * PickView.cc: Include shlwapi.h.
121 (PickView::setViewMode): Compare package name with search string
122 case-insensitive.
123 (PickView::insert_category): Ditto.
124
557b4e65
CV
1252009-06-26 Corinna Vinschen <corinna@vinschen.de>
126
127 * script.cc (init_run_script): Don't set $HOME to /tmp. It breaks
128 mkpasswd -c.
129
46cf12cd
CV
1302009-06-25 Corinna Vinschen <corinna@vinschen.de>
131
132 * script.cc (init_run_script): Reinstantiate accidentally removed
133 setting of sh.
134
b56d411d
CF
1352009-06-22 Christopher Faylor <me+cygwin@cgf.cx>
136
137 * script.cc (init_run_script): Revert to initializing cmd based on OS
138 type.
139
c14feb84
CV
1402009-06-22 Corinna Vinschen <corinna@vinschen.de>
141
142 * script.cc (Script::run): Start bash without -c option.
143
00fa5f6c
CF
1442009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
145
146 * threebar.cc (ThreeBarProgressPage::ins_dialog): Move variable to more
147 appropriate class.
148 (ThreeBarProgressPage::MaximizeDialog): Move function to more
149 appropriate class.
150 (ThreeBarProgressPage::OnMessageApp): Remove MaximizeDialog calls.
151 * threebar.h: Remove maximize handling.
152 * choose.cc (ChooserPage::ins_dialog): New variable.
153 (ChooserPage::MaximizeDialog): New function.
154 (ChooserPage::ChooserPage): Remove unneeded handling of nCmdShow.
155 (ChooserPage::OnActivate): Maximize chooser page via MaximizeDialog.
156 (ChooserPage::OnNext): Revert chooser page to normal before returning.
157 * main.cc (main): Don't pass cmd_show to ChooserPage.
158 * propsheet.cc (PropSheetProc): Accommodate change in class for
159 SetHwndDialog.
160
5a85457b
CF
1612009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
162
163 * script.cc (shells): Delete.
164 (cmd): Just assign to "cmd.exe" since we're always running on NT now.
165 (sanitize_PATH ): New function.
166 (init_run_script): Ensure that we're only called once. Strip
167 environment of non-pertinent stuff. Call sanitize_PATH to remove
168 non-standard stuff from the PATH. Set up a few standard environment
169 variables.
170
b0bb51b4
CV
1712009-06-16 Corinna Vinschen <corinna@vinschen.de>
172
173 * mount.cc (create_install_root): Don't load mount table again.
174 (read_mounts_nt): Don't break loop, rather continue when not being
175 able to open "Cygwin" registry key.
176
ed1f007a
CF
1772009-06-03 Ralph Hempel <rhempel@bmts.com>
178
179 * source.cc: Add support for both -D and -L on the command line.
180
7cb7c06e
CV
1812009-06-03 Corinna Vinschen <corinna@vinschen.de>
182
183 * filemanip.cc (unlink): Rename from DeleteFileW. Take additional
184 parameter to indicate file type to unlink. Use in flags given to
185 NtCreateFile.
186 (DeleteFileW): Just call unlink from here with FILE_NON_DIRECTORY_FILE
187 flag.
188 (RemoveDirectoryW): Ditto with FILE_DIRECTORY_FILE flag.
189
1eb4caec
CW
1902009-05-30 Charles Wilson <cygwin@cwilson.fastmail.fm>
191
192 * script.cc (Script::run): Really start bash with --norc
193 --noprofile options.
194
b7940eb5
CV
1952009-05-13 Corinna Vinschen <corinna@vinschen.de>
196
197 * script.cc (Script::run): Start bash with --norc --noprofile options.
198
94f52d39
CV
1992009-05-13 Corinna Vinschen <corinna@vinschen.de>
200
201 * filemanip.cc (struct _FILE_RENAME_INFORMATION): Remove definition.
202 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Set
203 default permission for .exe files to 0755.
204 (io_stream_cygfile::mklink): Try to create real hardlink first. Add
205 comment.
206 * mklink2.cc (mkcyghardlink): New function to create real hardlink.
207 * mklink2.h (mkcyghardlink): Declare.
208 * mount.cc (from_fstab_line): Set got_usr_bin and got_usr_lib flags
209 if /usr/bin and /usr/lib mount points exist in /etc/fstab.
210 (add_usr_mnts): Only create mounts if corresponding got_usr_bin and
211 got_usr_lib flags are not set.
212 (read_mounts_nt): Initialize got_usr_bin and got_usr_lib to false.
213 Always call add_usr_mnts, even if from_fstab succeeded.
214 * ntdll.h: Include ddk/ntifs.h.
215
b4473ece
CV
2162009-05-12 Corinna Vinschen <corinna@vinschen.de>
217
218 * filemanip.cc (GetFileAttributesW): Add accidentally omited
219 OBJ_CASE_INSENSITIVE when creating OBJECT_ATTRIBUTES.
220 (SetFileAttributesW): Ditto.
221 (MoveFileW): Ditto.
222 (DeleteFileW): Ditto.
223 (RemoveDirectoryW): Ditto.
224 (nt_wfopen): Ditto.
225
e0fd9bd3
CF
2262009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
227
228 * localdir.cc (load_dialog): Choose description string based on install
229 type.
230 * res.rc (IDD_LOCAL_DIR): Replace static description text with
231 IDC_LOCAL_DIR_DESC.
232 * resource.h (IDS_LOCAL_DIR_DOWNLOAD): New string resource id.
233 (IDS_LOCAL_DIR_INSTALL): Likewise.
234 (IDC_LOCAL_DIR_DESC): New text control resource id.
235
2362009-05-11 Christopher Faylor <me+cygwin@cgf.cx>
237
238 * main.cc (set_cout): Simplify code a little.
239
18d74072
CV
2402009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
241
242 * choose.cc (ChooserPage::OnMessageCmd): Clear search filter when
243 clear button clicked.
244 * res.rc (IDD_CHOOSE_DIALOG): Add IDC_CHOOSE_CLEAR_SEARCH button.
245 * resource.h (IDC_CHOOSE_CLEAR_SEARCH): New button resource ID.
246
6dcfeb7d
CV
2472009-05-11 Corinna Vinschen <corinna@vinschen.de>
248
249 * UserSettings.cc (UserSettings::settingFileForLoad): Fix local load
250 path strings.
251 (UserSettings::settingFileForSave): Never store in cwd.
252 * autoload.c (ntdll): Autoload ntdll.dll functions here.
253 * desktop.cc (make_cygwin_bat): Use GetFileAttributesW rather than
254 _waccess. Use nt_wfopen instead of _wfopen.
255 (save_icon): Ditto.
256 * filemanip.cc (get_file_size): Call io_stream::open with empty mode
257 string to avoid opening file twice.
258 (GetFileAttributesW): New function to replace Win32 function with
259 equivalent function opening files with backup intent.
260 (SetFileAttributesW): Ditto.
261 (MoveFileW): Ditto.
262 (DeleteFileW): Ditto.
263 (RemoveDirectoryW): Ditto.
264 (nt_wfopen): New function to replace _wfopen with equivalent function
265 opening files with backup intent.
266 * filemanip.h (nt_wfopen): Declare.
267 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Initalize
268 lasterr to 0. Allow empty mode and don't open file, if so. Call
269 nt_wfopen rather than _wfopen.
270 (io_stream_cygfile::exists): Use GetFileAttributesW rather than
271 _waccess.
272 (io_stream_cygfile::get_size): Use CreateFileW/GetFileSize to get
273 file size on NT.
274 * io_stream_file.cc (io_stream_file::io_stream_file): Initalize lasterr
275 to 0. Allow empty mode and don't open file, if so. Call nt_wfopen
276 rather than _wfopen.
277 (io_stream_file::exists): Use GetFileAttributesW rather than _waccess.
278 (io_stream_file::remove): Don't try to remove non-existant file.
279 (io_stream_file::get_size): Use CreateFileW/GetFileSize to get
280 file size on NT. Add comment to keep track of 2GB border.
281 * mkdir.cc: Remove function pointers for ntdll functions.
282 (init_ntfuncs): Remove function.
283 (mkdir_p): Drop call to init_ntfuncs. Call ntdll functions directly
284 rather than over local function pointers.
285 * ntdll.h: New file.
286 * postinstall.cc (do_postinstall_reflector): Switch to admins group
ca2b7505 287 as primary group after postinstall scripts have been written.
6dcfeb7d
CV
288 Explain why.
289 (do_postinstall): Add comment.
290 * res.rc: Bump copyright date.
291 * win32.h (class TokenGroupCollection): Remove.
292 * win32.cc (TokenGroupCollection::populate): Remove.
293 (TokenGroupCollection::find): Remove.
294 (NTSecurity::setDefaultSecurity): Drop reading token groups. Just
295 try to switch to admins group as primary group.
296
4b47445f
CV
2972009-05-07 Corinna Vinschen <corinna@vinschen.de>
298
299 * package_db.cc (ConnectedLoopFinder::doIt): Revert patch from
300 2008-08-29. Add dumb hardcoded algorithm to make sure base-cygwin
301 and base-passwd are always the first packages in the postinstall
302 executable order.
303
8752dea2
CV
3042009-05-06 Corinna Vinschen <corinna@vinschen.de>
305
306 * install.cc (Installer::StandardDirs): Add /home with 1777 perms.
307 * main.cc (main): Drop setting $CYGWIN to nontsec.
308
059906b3
DK
3092009-04-24 Andrew Punch <andrew@magneticbooks.com.au>
310
311 * PickView.h: Add #include <string>.
312 (PickView::SetPackageFilter): Add new function.
313 (PickView::packageFilterString): Add new string data member.
314 * PickView.cc (PickView::setViewMode): Use it to filter names.
315 (PickView::insert_category): Likewise.
316 (PickView::PickView): Initialise packageFilterString to blank.
317 * res.rc (IDD_CHOOSE): Add IDC_CHOOSE_SEARCH_EDIT and
318 IDC_CHOOSE_SEARCH_LABEL controls.
319 (IDS_SEARCH_TOOLTIP): Add new string resource.
320 * resource.h (IDS_SEARCH_TOOLTIP): New string resource ID.
321 (IDC_CHOOSE_SEARCH_EDIT): New edit control ID.
322 (IDC_CHOOSE_SEARCH_LABEL): Mew static text control ID.
323 * choose.cc (ChooserControlsInfo[]): Add IDC_CHOOSE_SEARCH_LABEL
324 and IDC_CHOOSE_SEARCH_EDIT controls to auto-resize list.
325 (ChooserPage::OnInit): Add tooltip to search edit box.
326 (ChooserPage::OnMessageCmd): Handle EN_CHANGE event from
327 IDC_CHOOSE_SEARCH_EDIT.
328
6bfd5236
DK
3292009-04-24 Dave Korn <dave.korn.cygwin@gmail.com>
330
331 * propsheet.cc (PropSheetWndProc): Re-enable hasMinRect.
332
d29a864d
CV
3332009-04-23 Corinna Vinschen <corinna@vinschen.de>
334
335 * win32.h (NTSecurity::primaryGroupSID): Convert to a structure for
336 direct usage in GetTokenInformation.
337 (NTSecurity::osid): Remove.
338 (NTSecurity::setAdminGroup): Declare.
339 * win32.cc (NTSecurity::resetPrimaryGroup): Accommodate change to
340 primaryGroupSID. Add log output.
341 (NTSecurity::setAdminGroup): New method.
342 (NTSecurity::setDefaultSecurity): Use local structures for getting
343 TOKEN_USER and setting TOKEN_OWNER information. Accommodate change to
344 primaryGroupSID. Slightly enhance log output.
345 Only set primary group to Administrators group when installing for
346 all users. Call setAdminGroup to do it.
347
770e3aed
CV
3482009-04-22 Corinna Vinschen <corinna@vinschen.de>
349
350 * mklink2.cc (mkcygsymlink_nt): Allow 4K chars in symlink. Use strncat
351 rather than strcat.
352 * postinstall.cc (do_postinstall): Reset user token to original
353 primary group.
d29a864d 354 * win32.cc (NTSecurity::resetPrimaryGroup): New method.
770e3aed
CV
355 (NTSecurity::setDefaultSecurity): Store original primary group in
356 new NTSecurity member primaryGroupSID. Set primary group in user token
357 to Administrators group for admin users. Align comment.
358 * win32.h (class NTSecurity): Add member primaryGroupSID.
359 (NTSecurity::resetPrimaryGroup): Declare.
360
a03b43ad
CF
3612009-04-09 Christopher Faylor <me+cygwin@cgf.cx>
362
363 * main.cc (set_cout): Load AttachConsole dynamically to avoid using it
364 on older Windows which don't support it.
365
c8356810
CF
3662009-03-21 Christopher Faylor <me+cygwin@cgf.cx>
367
368 * LogFile.cc (LogFile::endEntry): Output messages to stdout.
369 * main.cc (set_cout): New function. Sets stdout to console if one
370 exists.
371 (main): Redirect stdout to console if unattended_mode or help option is
372 specified and no stdout is available.
373
3742009-03-21 Terry Fleming <terrynfleming@gmail.com>
375 Christopher Faylor <me+cygwin@cgf.cx>
376
377 * propsheet.cc (PropSheetWndProc): Detect a Window closing event and
378 issue an "Are you sure" message.
379
a2488a3c
CV
3802008-08-29 Corinna Vinschen <corinna@vinschen.de>
381
382 * package_db.cc (ConnectedLoopFinder::doIt): Add code to get a basic
383 order into the dependency list. Add comment to explain why.
384
ef3be327
BD
3852008-08-22 Brian Dessent <brian@dessent.net>
386
387 * KeysSetting.cc: Include string.h for memcpy et al.
388 * filemanip.cc: Include stdlib.h for for mbstowcs.
389 * io_stream_cygfile.h: Update cygmkdir_p prototype for mode_t.
390 * mount.cc (conv_fstab_spaces): Silence gcc 4.3 warning ("parentheses
391 around assignment used as truth value").
392
e0a4fb63
CV
3932008-08-20 Corinna Vinschen <corinna@vinschen.de>
394
395 * install.cc (Installer::StandardDirs): Additionally create /var/log
396 dir. Set mode of /var/log and /var/run to 01777.
397 * localdir.cc (LocalDirSetting::save): Create /var/log with 01777
398 permissions before creating setup.log files.
399
be617b59
CV
4002008-08-20 Corinna Vinschen <corinna@vinschen.de>
401
402 * io_stream_cygfile.cc (io_stream_cygfile::set_mtime_and_mode):
403 Accommodate SetPosixPerms being method of nt_sec.
404 * mkdir.cc (mkdir_p): Ditto.
405 * mklink2.cc (mkcygsymlink_nt): Ditto.
406 * win32.cc: Slightly rearrange.
407 (NTSecurity::SetPosixPerms): Make SetPosixPerms method of NTSecurity
408 rather than stand-alone function. Remove dynamic allocation for
409 security descriptors in favor of static allocation. Drop out
410 preliminary if well-known SIDs are not initialized. Slightly change
411 and rearrange comments. Add creating NULL SID ACE for special
412 permissions.
413 (NTSecurity::initialiseWellKnownSIDs): New function, replacing
414 NTSecurity::initialiseEveryOneSID. Initialize all well-known SIDs
415 here. Set wellKnownSIDsinitialized to true on success.
416 (NTSecurity::setDefaultDACL): Don't call initialiseEveryOneSID. Change
417 comment. Drop setting failed. Don't open process token here.
418 (NTSecurity::setBackupPrivileges): New function.
419 (NTSecurity::setDefaultSecurity): Call initialiseWellKnownSIDs.
420 Open process token here. Disable setting primary group. Add comment
421 to explain why.
422 * win32.h (SetPosixPerms): Move to NTSecurity.
423 (class NTSecurity): Add SetPosixPerms method. Make all SIDs private
424 again. Make NoteFailedAPI private. Add setBackupPrivileges method.
425 Rename usid to UsersSID. Remove failed method and _failed member.
426 Add wellKnownSIDsinitialized accessors and _wellKnownSIDsinitialized
427 member.
428
b41c2908
CV
4292008-08-19 Corinna Vinschen <corinna@vinschen.de>
430
431 * install.cc (struct std_dirs_t): New type.
432 (class Installer): Change type of StandardDirs to std_dirs_t.
433 (Installer::StandardDirs): Store filename and mode.
434 (do_install_thread): Call io_stream::mkpath_p with name and mode from
435 Installer::StandardDirs.
436 * main.cc (main): Call setDefaultSecurity on global nt_sec.
437 * IOStreamProvider.h (IOStreamProvider::mkdir_p): Add mode parameter.
438 * LogFile.cc (LogFile::log_save): Call io_stream::mkpath_p with 0755
439 mode.
440 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
441 * desktop.cc (make_link): Ditto.
442 * download.cc (download_one): Ditto.
443 * ini.cc (do_remote_ini): Ditto.
444 (do_ini_thread): Ditto.
445 * package_db.cc (packagedb::flush): Ditto.
446 * archive.cc (archive::extract_file): Ditto. Call set_mtime_and_mode
447 with mode from archive. Add code to handle directory permissions as
448 well.
449 * archive_tar.cc (archive_tar::get_mtime): Return time_t. Reformat.
450 (archive_tar::get_mode): New method.
451 * archive_tar.h (class archive_tar_file): Fix prototypes. Replace
452 prototype for set_mtime with prototype for set_mtime_and_mode.
453 (class archive_tar): Ditto.
454 * archive_tar_file.cc (archive_tar_file::get_mtime): Return time_t.
455 (archive_tar_file::get_mode): New method returning mode from tar header.
456 * compress_bz.cc (compress_bz::set_mtime_and_mode): Replace set_mtime.
457 (compress_bz::get_mtime): Return time_t.
458 (compress_bz::get_mode): New function.
459 * compress_gz.cc: Ditto.
460 * compress_lzma.cc: Ditto.
461 * io_stream.cc (io_stream::mkpath_p): Take additional file mode.
462 Call mkdir_p with additional file mode.
463 * io_stream_cygfile.cc (CygFileProvider::mkdir_p): Take additional file
464 mode.
465 (cygmkdir_p): Ditto. Call mkdir_p with additional file mode.
466 (io_stream_cygfile::set_mtime_and_mode): Replace set_mtime. Call
467 SetPosixPerms.
468 * io_stream_file.cc (FileProvider::mkdir_p): Take additional file mode.
469 (io_stream_file::set_mtime_and_mode): Replace set_mtime.
470 * mkdir.cc (init_ntfuncs): New function to initialize function pointers
471 from ntdll.dll.
472 (mkdir_p): Take additional file mode. On NT, use NT functions to create
473 directory. Call SetPosixPerms.
474 * compress_bz.h: Change prototypes accordingly.
475 * compress_gz.h: Ditto.
476 * compress_lzma.h: Ditto.
477 * io_stream.h: Ditto.
478 * io_stream_cygfile.h: Ditto.
479 * io_stream_file.h: Ditto.
480 * io_stream_memory.h: Ditto.
481 * mkdir.h: Ditto.
482 * mklink2.cc (mkcygsymlink_nt): Open file with STANDARD_RIGHTS_ALL
483 access and FILE_FLAG_BACKUP_SEMANTICS flag. Call SetPosixPerms.
484 * mount.cc (from_fstab): Open file with FILE_FLAG_BACKUP_SEMANTICS.
485 * script.cc (OutputLog::OutputLog): Call io_stream::mkpath_p with 0755
486 mode. Open file with FILE_FLAG_BACKUP_SEMANTICS.
487 * win32.cc (SetPosixPerms): New function to set POSIX-like permissions.
488 (nt_sec): New global NTSecurity variable.
489 (NTSecurity::setDefaultDACL): Open token with TOKEN_ADJUST_PRIVILEGES.
490 (NTSecurity::setDefaultSecurity): Enable SE_BACKUP_NAME and
491 SE_RESTORE_NAME privileges if available.
492 * win32.h (SetPosixPerms): Add prototype.
493 (class NTSecurity): Make everyOneSID and administratorsSID public.
494 (nt_sec): Declare.
495
65288dc7
CV
4962008-08-14 Corinna Vinschen <corinna@vinschen.de>
497
498 * mount.cc (unconvert_slashes): New inline function.
499 (skip_ws): New inline function.
500 (find_ws): New inline function.
501 (conv_fstab_spaces): New inline function.
502 (from_fstab_line): New function to read single line from fstab file.
503 (from_fstab): New function to read /etc/fstab file and fill mount
504 table.
505 (read_mounts_nt): Call from_fstab after getting setup/rootdir from
506 registry. Only call add_usr_mnts if no fstab file found.
507
1ae1adf7
CV
5082008-08-13 Corinna Vinschen <corinna@vinschen.de>
509
510 * install.cc (Installer::installOne): Skip 46 bytes type tar package
511 silently.
512
53d33c5d
CV
5132008-08-13 Corinna Vinschen <corinna@vinschen.de>
514
515 * install.cc (Installer::installOne): Use MoveFileExW on NT. Special
516 case for bug in Windows 2000.
517 * package_meta.cc (packagemeta::uninstall): Use wide char file functions
518 on NT.
519 * win32.h (VersionInfo::major): New method.
520 (VersionInfo::minor): New method.
521 (OSMajorVersion): Define.
522 (OSMinorVersion): Define.
523
2f0315ad
CV
5242008-08-12 Corinna Vinschen <corinna@vinschen.de>
525
526 Revamp for Cygwin 1.7.
527 * desktop.cc (make_cygwin_bat): Use wide char file functions on NT.
528 (save_icon): Ditto.
529 * filemanip.cc (tfx_chars): New char table for wide char transformation
530 of reserved FS chars to UNICODE private use area.
531 (transform_chars): New static function.
532 (mklongpath): New function to convert multibyte path to wide char
533 path with long path prefix.
534 * filemanip.h (mklongpath): Declare.
535 * ini.h (SETUP_INI_FILENAME): Use setup.ini filenames as defined in
536 real life (setup-2.ini/setup.ini).
537 (SETUP_BZ2_FILENAME): Ditto.
538 * install.cc (do_install_thread): Don't create registry mount points
539 on NT, rather create setup/rootdir entry.
540 * io_stream_cygfile.cc: Throughout use wide char file functions on NT.
541 (io_stream_cygfile::w_str): New method to create wide char path.
542 * io_stream_cygfile.h (class io_stream_cygfile): Remove lmode member.
543 Add wname member and w_str method.
544 * io_stream_file.cc: Throughout use wide char file functions on NT.
545 (io_stream_file::w_str): New method to create wide char path.
546 * io_stream_file.h (class io_stream_file): Remove lmode member.
547 Add wname member and w_str method.
548 * mkdir.cc (mkdir_p): Use wide char file functions on NT.
549 * mklink2.cc (mkcygsymlink_9x): Rename from mkcygsymlink. Make static.
550 (mkcygsymlink_nt): New static function.
551 (mkcygsymlink): Just call mkcygsymlink_9x or mkcygsymlink_nt dependent
552 on OS.
553 * mount.cc (CYGWIN_INFO_CYGWIN_SETUP_REGISTRY_NAME): Define.
554 (remove1): Move to earlier point in file to avoid declaration.
555 (remove_mount): Ditto. Make static.
556 (create_install_root): New function to create setup/rootdir registry
557 value on NT.
558 (read_mounts_9x): Rename from read_mounts. Make static. Conditionalize
559 for OS.
560 (add_usr_mnts): New static function.
561 (read_mounts_nt): Ditto, to read mounts on NT.
562 (read_mounts): Just call read_mounts_nt or read_mounts_9x dependent on
563 OS.
564 (set_root_dir): On NT, call read_mounts.
565 (cygpath): Only add slash for non-root mount to avoid multiple slashes
566 in resulting path (invalid in long path names).
567 * mount.h (find_mount): Drop declaration.
568 (remove_mount): Ditto.
569 (create_install_root): Add declaration.
570 (read_mounts): Accommodate new parameter.
571 * package_db.cc (chosen_db_task): New global variable.
572 * package_db.h (chosen_db_task): Declare.
573 * root.cc (check_if_enable_next): Don't use get_root_dir here to
574 avoid having to call save_dialog in RootPage::OnMessageCmd.
575 (GetDlgItemRect): New static inline function.
576 (SetDlgItemRect): Ditto.
577 (load_dialog): On NT, stretch "Install For" block to full dialog width
578 and hide "Default Text File Type" block.
579 (save_dialog): On NT set root_text always to IDC_ROOT_BINARY.
580 (RootPage::OnMessageCmd): Remove call to save_dialog.
581 (RootPage::OnNext): Initialize packagedb here the first time, to
582 avoid fetching wrong data from different previous installation.
583 * source.cc (save_dialog): Don't initialize packagedb here, rather
584 just memorize setting in chosen_db_task for the deferred initialization
585 in RootPage::OnNext.
586
0407753c
DK
5872008-08-07 Dave Korn <dave.korn.cygwin@gmail.com>
588
589 Implement command-line selection of packages to install and make
590 unattended mode deal with any dialogs that might arise. A joint
591 effort synthesized from contributions by:
592
593 Dr. Frank Lee <rl201@cam.ac.uk>
594 Bryan Thrall <bryan.thrall@flightsafety.com>
595 Kohsuke Kawaguchi <kk@kohsuke.org>
596 Dave Korn <dave.korn.cygwin@gmail.com>
597
598 * install.cc (rebootneeded): Don't define statically here.
599 (do_install_thread): Let exit_msg reflect rebootneeded.
600 * main.cc (main): If rebootneeded, log it when exiting.
601 * msg.cc (mbox): In unattended_mode, choose and log default answer.
602 * package_db.cc (packagedb::fillMissingCategory): Iterate over all
603 packages adding those selected by packagemeta::isManuallyWanted to
604 base category so that command-line selections are installed.
605 * package_meta.cc (PackageOption): Add new StringOption to allow
606 command-line selection of packages to add to base install.
607 (packagemeta::isManuallyWanted): New function tests if package was
608 selected on command-line.
ca2b7505 609 (packagemeta::addToCategoryBase): New function adds package to
0407753c
DK
610 "base" category.
611 * state.cc (rebootneeded): Define here non-static.
612 * state.h (rebootneeded): Declare here with extern linkage.
613 * threebar.cc (ThreeBarProgressPage::MaximizeDialog): Don't change
614 size when running in unattended mode.
615
da60e4b2
CF
6162008-08-05 Christopher Faylor <me+cygwin@cgf.cx>
617
618 * UserSettings.cc (UserSettings::settingFileForLoad): Look locally for
619 settings before looking outside of current directory.
620 * choose.cc (ChooserPage::ChooserPage): Record the property sheet's
621 current show state via new passed in parameter.
622 * choose.h (ChooserPage::ChooserPage): Reflect change in argument list.
623 (ChooserPage::nCmdShow): Define new element.
624 * main.cc (main): Send current show state to Chooser.
625 * package_version.cc (packageversion::set_requirements): Increase
626 recursion check from 5 to 30.
627 * propsheet.cc (PropSheetWndProc): Register hwndDlg with
628 ThreeBarProgressPage.
629 * threebar.cc (ControlAdjuster::ControlInfo): Initialize cmd_show_set.
630 (ThreeBarProgressPage::MaximizeDialog): New function.
631 (ThreeBarProgressPage::OnMessageApp): Call MaximizeDialog to maximize
632 package selection screen and restore when done.
633 * threebar.h (ThreeBarProgressPage::MaximizeDialog): Declare function.
634 (ThreeBarProgressPage::cmd_show_set): Declare variable.
635 (ThreeBarProgressPage::cmd_show): Declare variable.
636 (ThreeBarProgressPage::ins_dialog): Declare variable.
637 (ThreeBarProgressPage::SetHwndDialog): Define function.
638
5bb88929
CW
6392008-07-22 Charles Wilson <cygwin@cwilson.fastmail.fm>
640
641 Add support for .tar.lzma files (decompress only).
642
643 * Makefile.am: Add new files.
644 * compress.cc (compress::decompress): add support
645 for compress_lzma.
646 * compress_lzma.h: new file.
647 * compress_lzma.cc: new file.
648 * filemanip.cc (find_tar_ext): add support for
649 .tar.lzma files.
650 * install.cc (Installer::installOne): update comments.
651 * lzma-sdk/LzmaDec.h: new file.
652 * lzma-sdk/LzmaDec.c: new file.
653 * lzma-sdk/Types.h: new file.
654
5bc84ff1
CW
6552008-07-08 Charles Wilson <cygwin@cwilson.fastmail.fm>
656
657 * compress.cc (compress::decompress): clean up concrete
658 decompressor objects on failure -- but in that case, do
659 NOT destroy original io_stream.
660 * compress_bz.h (compress_bz::release_original): new method.
661 (owns_original): new member variable.
662 * compress_bz.cc (compress_bz::release_original): new method.
663 (compress_bz::compress_bz): take ownership of parent by default.
ca2b7505 664 (compress_bz::~compress_bz): only delete original if
5bc84ff1
CW
665 owns_original is true.
666 * compress_gz.h (compress_gz::release_original): new method.
667 (owns_original): new member variable.
668 * compress_gz.cc (compress_gz::release_original): new method.
669 (compress_gz::construct): take ownership of parent by default.
ca2b7505 670 (compress_gz::~compress_gz): only delete original if
5bc84ff1
CW
671 owns_original is true.
672
fe25359c
DK
6732008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
674
675 * configure.in, gpg-error-config-fake: Revert previous removal.
676
586f2b08
DK
6772008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
678
679 * net.cc: Correct stray CRLF.
680
8f016701
DK
6812008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
682
683 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Remove nasty hack.
684 * gpg-error-config-fake: Delete file obsoleted by de-hackification.
685
1cc1fad4
CF
6862008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
687
688 * configure.in: Disable shared library builds.
689
be6622c0
CF
6902008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
691
692 * Makefile.am: Make and install libraries into common location and use
693 them from there.
694 * configure.in: Find gpg-error-config in the libgpg-error/src
695 subdirectory rather than using the host system's version. Set the
696 prefix and exec_prefix to a common location for the subdirs so that
697 useful files will be installed in a common location.
698
dbfe3c19
DK
6992008-06-22 Dave Korn <dave.korn.cygwin@gmail.com>
700
be6622c0
CF
701 Merged across diffs between setup_crypto_branch_branchpoint and
702 setup_crypto_branch_mergepoint2 from setup_crypto_branch.
dbfe3c19
DK
703
704 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
705 KeysSetting.h, gpg-error-config-fake, cygwin.pub, cyg-pubkey.h,
be6622c0 706 gpg-key-to-s-expr.sh: New files.
dbfe3c19 707 * ini.cc, ini.h, resource.h, res.rc, netio.cc, Makefile.am,
be6622c0 708 configure.ac, libgetopt++/src/OptionSet.cc: Modified files.
dbfe3c19
DK
709
710 2008-06-21 Dave Korn <dave.korn.cygwin@gmail.com>
711
ca2b7505 712 * ini.cc (do_remote_ini): Revert misbegotten removal of
dbfe3c19
DK
713 not-always-superfluous-after-all added slash in URLs.
714
715 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
716
717 * gpg-packet.h (GPG_KEY_SEXPR_BUF_SIZE): Move from here ...
718 * crypto.h (GPG_KEY_SEXPR_BUF_SIZE): ... to here.
719 (GPG_KEY_MAX_COEFF_SIZE): Add related definition.
720
721 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
722
723 * gpg-packet.cc (walk_packets_1): Check packet length field is
724 valid sane and possible to avoid malicious manipulation.
725 * ChangeLog: Corrected date on previous commit.
726
727 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
728
ca2b7505 729 * crypto.cc (add_key_from_sexpr): Use real buffer size, not debug
dbfe3c19
DK
730 constant size.
731
732 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
733
734 * crypto.cc (verify_ini_file_sig): Actually set init-once flag!
735
736 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
737
738 * crypto.cc (KeepUntrustedKeysOption): Fix helpstring punctuation.
739
740 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
741
742 * crypto.cc (verify_ini_file_sig): Fix two minor logic errors.
743
744 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
745
746 * ini.h (current_ini_sig_name): Declare extern.
747 * ini.cc (current_ini_sig_name): New variable.
748 (NoVerifyOption): New boolean option.
749 (do_remote_ini): If sig verification not disabled, attempt to
750 download the matching sig file for any setup.bz2 or setup.ini
751 and use it to verify or discard the download.
752
753 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
754
755 * resource.h (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Reserve IDs for
756 two new message strings.
757 * res.rc (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Define the text.
758
759 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
760
761 * Makefile.am (setup_SOURCES): Add new files crypto.cc, crypto.h,
762 cyg-pubkey.h, gpg-packet.cc, gpg-packet.h. KeysSetting.cc and
763 KeysSetting.h to the build.
764 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
765 KeysSetting.h: New files. Adds gpg sig verification support.
766
767 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
768
769 * Makefile.am (DIST_SUBDIRS, SUBDIRS): Add libgpg-error and
770 libgcrypt subdirs.
771 (AM_CPPFLAGS): Add -I paths to generated headers in both and to
772 shipped headers in libgcrypt.
773 (setup_LDADD): Add libgpg-error.a and libgcrypt.a to final link.
774
775 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Preload into cache
776 to fake out libgcrypt configure process.
777 (AC_CONFIG_SUBDIRS): Add libgpg-error/ and libgcrypt/
778
779 * gpg-error-config-fake: New shell script to redirect libgcrypt
780 sub-configure into looking for newly-built libgpg-error.
781
782 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
783
784 * setup/libgpg-error/: Fresh import of upstream sources of
785 libgpg-error-1.6.tar.bz2 from http://www.gnupg.org/
786 * setup/libgcrypt/: Fresh import of upstream sources of
787 libgcrypt-1.4.1.tar.bz2 from http://www.gnupg.org/
788
789 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
790
791 * netio.cc (NetIO::set_url): Avoid double-free bug on delete
792 by setting path to a strdup of url rather than using the same
793 pointer value twice.
794
795 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
796
797 * cygwin.pub: Add reference copy of Cygwin setup signing key.
798 * gpg-key-to-s-expr.sh: New bash script. Outputs textual
799 representation of public key in s-expr format.
800 * cyg-pubkey.h: New header generated by the above from Cygwin
801 setup signing key. Currently needs manual regeneration if key
802 ever updated.
803
2cae901b
BD
8042008-04-16 Brian Dessent <brian@dessent.net>
805
806 * mount.cc: Include malloc.h.
807 (is_admin): Use alloca instead of a VLA in case
808 GetTokenInformation is sensitive to alignment.
809
784414bf
BD
8102008-04-15 Brian Dessent <brian@dessent.net>
811
812 * mount.cc (is_admin): Get explicit size of required buffer by
813 calling GetTokenInformation first with NULL.
814
9d44d4f7
BD
8152008-04-10 Brian Dessent <brian@dessent.net>
816
817 * Makefile.am (setup_LDFLAGS): Make sure static libbz2 and zlib
818 are used.
819
1db74bf0
BD
8202008-04-09 Brian Dessent <brian@dessent.net>
821
822 * README: flex and bison are required when building from CVS.
823
09aa7d89
BD
8242008-04-08 Brian Dessent <brian@dessent.net>
825
826 * Makefile.am (snapshot): Provide default value of ${cygwinsite}
827 if not set.
828
60dfa7aa
BD
8292008-04-08 Brian Dessent <brian@dessent.net>
830
831 * Makefile.am (release): Use -f so that "make release" works
832 when existing binaries of the same name exist.
833
33ef69a7
BD
8342008-04-08 Brian Dessent <brian@dessent.net>
835
836 * res.rc (IDD_SPLASH): Update copyright years on splash page.
837
51325df5
BD
8382008-04-08 Brian Dessent <brian@dessent.net>
839
840 * CHANGES: Update.
841 * install.cc (Installer::installOne): Cope with compressed
842 0-byte dummy packages. Fix progress bar update bug introduced
843 in earlier refactoring.
844
2e0aaec9
BD
8452008-04-08 Brian Dessent <brian@dessent.net>
846
847 * CHANGES: Update.
848
8492008-04-08 Brian Dessent <brian@dessent.net>
850
851 Various warning/header cleanups necessary for clean gcc 4.3 build.
852 * ConnectionSetting.cc: Include stdlib.h.
853 * LogFile.cc: Ditto.
854 * Makefile.am: Don't hardcode paths to MinGW libz and libbz2.
855 * PickView.cc: Include limits.h.
856 * String++.cc: Include string.h.
857 * archive_tar.cc (archive_tar::next_file_name): Silence nested-if
858 warning.
859 * autoload.c: Switch back to .text section before emiting
860 autoload_common.
861 * choose.cc: Include stdlib.h and algorithm.
862 * compress_gz.cc: Include memory.h and malloc.h.
863 * filemanip.cc: Include string.h.
864 (parse_filename): Silence nested-if warning.
865 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Silence warning.
866 * package_db.cc: Include algorithm.
867 * site.cc (get_site_list): Silence warning.
868 * win32.cc: Include memory.
869 * csu_util/MD5Sum.cc: Include string.h.
870
d0355815 8712008-03-02 Dave Korn <dave.korn@artimi.com>
4e6c8d9e 872
d0355815 873 * install.cc (Installer::installOne): Accept new HWND argument
4e6c8d9e
DK
874 from caller and pass it to MessageBox calls so that MB_TASKMODAL
875 can work.
876 (check_for_old_cygwin): Likewise.
877 (do_install_thread): Pass owner's HWND (from thread context) when
878 calling them.
879
84ea7bd6
DK
8802008-02-23 Dave Korn <dave.korn@artimi.com>
881
882 * cygpackage.cc (cygpackage::getfirstfile): Guard against trying to
883 construct std::string from NULL returned by io_stream::gets when the
884 stream decompressor fails on a corrupt *.lst.gz file.
885
22ade75c
DK
8862008-02-21 Dave Korn <dave.korn@artimi.com>
887
888 * geturl.cc (progress): Correct SI unit notation.
889
b612bff1
DK
8902008-02-01 Vincent Privat <vincent.privat@gmail.com>
891
892 * net.cc (OnInit): New StringOption (ProxyOption)
893 This new option (-p) allows to call setup.exe with a proxy
894 in its command-line arguments.
895
a81fbc25
BD
8962007-07-31 Brian Dessent <brian@dessent.net>
897
898 * ini.cc (do_remote_ini): Fix crash due to double free of ini_file.
899
92ef6cf8
BD
9002007-07-30 Brian Dessent <brian@dessent.net>
901
902 * CHANGES: Update.
903 * configure.in (AM_INIT_AUTOMAKE): Enable more automake warnings.
904 * Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
905 (CLEANFILES): Add. Minor portability tweaks.
906 * tests/Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
907 * archive.cc (archive::extract): Try to be more compatible when
908 opening tar files.
909 * compress_bz.cc: Fix whitespace throughout.
910 (compress_bz::~compress_bz): Ensure that underlying io_stream's dtor is
911 also run.
912 * install.cc (Installer::installOne): Refactor.
913 * package_db.cc (ConnectedLoopFinder::doIt): Move some log spewage into
914 setup.log.full from setup.log.
915 (packagedb::connectedBegin): Ditto. Consolidate log output to one line.
916
0a0203db
BD
9172007-07-02 Brian Dessent <brian@dessent.net>
918
919 * CHANGES: Update.
920
475ee6a3
BD
9212007-06-26 Brian Dessent <brian@dessent.net>
922
923 * Makefile.am (release): Drop inconsistent use of $(EXEEXT). Leave an
924 untouched copy of setup.exe so that later make invocations don't
925 unnecessarily rebuild it.
926 (snapshot): Fix typo.
927 * install.cc (md5_one): Don't try to check packages whose
928 pkgsource.Cached () is NULL, as with those whose download failed.
929
12dea33a
BD
9302007-06-26 Brian Dessent <brian@dessent.net>
931
932 * CHANGES: Update to reflect release branch.
933
9342007-06-26 Brian Dessent <brian@dessent.net>
812cdd92
BD
935
936 * CHANGES: Make current.
937
feee2f2b
BD
9382007-05-30 Brian Dessent <brian@dessent.net>
939
940 * find.h (class Find): Make _start_dir non-const.
941 * find.cc (Find::Find): Append a trailing slash to _start_dir only if
942 it does not already contain one.
943 (Find::accept): Use the previously stored value of _start_dir rather
944 than unconditionally appending a slash.
945
b941c8be
BD
9462007-05-29 Brian Dessent <brian@dessent.net>
947
948 * Makefile.am: No need to specify the default value of --preprocessor
949 to windres. Rework the automatic version extraction rules so that the
950 source tarball is generated with the proper name and directory instead
951 of setup-0. Update snapshot rule to also upload a copy of the binary
952 with debugging symbols still present.
953
dacb1ebd
BD
9542007-05-29 Brian Dessent <brian@dessent.net>
955
956 This is a general tidying up/modernization of the build infrastructure.
957 Renaming the lexer and parser to .ll and .yy allows using automake's
958 builtin support for flex and bison with C++ sources, and libinilex is a
959 slightly cleaner way of omitting -Werror.
960
961 * Makefile.am (AUTOMAKE_OPTIONS): Move to AM_INIT_AUTOMAKE.
962 (AM_YFLAGS): Define.
963 (AM_LFLAGS): Define.
964 (INCLUDES): Remove redundant mingw directory.
965 (EXTRA_DIST): Adjust for newly named lexer/parser.
966 (BUILT_SOURCES): Ditto.
967 (inilint_LDADD): Ditto.
968 (inilint_SOURCES): Ditto.
969 (setup_LDADD): Ditto.
970 (setup_SOURCES): Ditto.
971 (iniparse.cc): Remove custom rules.
972 (inilex.cc): Ditto.
973 * configure.in: Update quoting and use modern form of AC_INIT and
974 AM_INIT_AUTOMAKE.
975 * inilex.l: Rename from this ...
976 * inilex.ll: ... to this.
977 * iniparse.y: Rename from this ...
978 * iniparse.yy: ... to this.
979
eb20d728
BD
9802007-05-29 Brian Dessent <brian@dessent.net>
981
982 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
983 Remove error_buf and error_count initializers.
984 (IniParseFindVisitor::visitFile): Store filename in current_ini_name.
985 Use yyerror_count and yyerror_messages in place of removed error_count
986 and error_buf members.
987 * IniParseFindVisitor.h (class IniParseFindVisitor): Remove error_buf
988 and error_count members.
989 * ini.cc: Include io_stream_memory.h. Remove file static variables
990 error_buf, error_count, and ini_filename.
991 (GuiParseFeedback::progress): Remove some verbose log spam.
992 (do_remote_ini): Recode .ini-fetching logic to properly display parse
993 errors, and to account for corrupt bzip2 files.
994 (yyerror): Moved elsewhere.
995 (fprintf): Delete unused function.
996 * ini.h: Remove useless __cplusplus guard. Declare extern variables
997 current_ini_name, yyerror_messages, and yyerror_count.
998 * inilex.l: Add current_ini_name, yyerror_messages, and
999 yyerror_count.
1000 (ini_init): Initialize new variables.
1001 (yybol): Delete.
1002 (yyerror): Reimplement using std::string and relocate from ini.cc.
1003 * io_stream.cc (io_stream::copy): Add clarifying comment.
1004
6c8daadf
IP
10052007-05-04 Igor Peshansky <pechtcha@cs.nyu.edu>
1006
1007 * resource.h (IDC_STATIC_HEADER): New control id.
1008 * res.rc (IDD_SPLASH): Adjust the copyright.
1009 (IDD_DESKTOP): Make header text accessible as a separate control.
1010 * desktop.cc (set_status): Use eset() instead of SetWindowText().
1011 (load_dialog): Disable checkboxes and change dialog text in
1012 download-only mode.
1013 (DesktopSetupPage::OnInit): Disable checkboxes in download-only
1014 mode.
1015 * threebar.cc (ThreeBarProgressPage::OnMessageApp): Deprecate the
1016 default fallthrough.
1017 * download.cc (do_download_thread): Explicitly return the next
1018 dialog.
1019
f8dcce01
MB
10202007-04-19 Max Bowsher <maxb1@ukf.net>
1021
1022 * configure.in: Turn inilint default build off again, since I cannot
1023 get it to work.
1024
6b457e67
MB
10252007-04-19 Max Bowsher <maxb1@ukf.net>
1026
54ac354e
MB
1027 * configure.in: Make inilint built by default.
1028
10292007-04-19 Max Bowsher <maxb1@ukf.net>
1030
1031 * inilintmain.cc: Fix multiple compile errors.
6b457e67 1032
86e53214
MB
10332007-04-19 Max Bowsher <maxb1@ukf.net>
1034
1035 * Makefile.am: Make inilint use same warnonly-inilex workaround that
1036 setup already does.
1037
7b21a88e
IP
10382007-03-29 Igor Peshansky <pechtcha@cs.nyu.edu>
1039
1040 * LogFile.cc (LogFile::exit): Write exit_msg directly to log, without
1041 the message box.
1042 * resource.h (IDC_DESKTOP_SEPARATOR,IDC_STATUS_HEADER,IDC_STATUS): New
1043 control ids.
1044 * res.rc (IDD_DESKTOP): Change the caption. Add status information.
1045 * desktop.h (DesktopSetupPage::DesktopSetupPage): Define constructor
1046 in the implementation.
1047 * desktop.cc (DesktopControlsInfo): Position specifiers for status
1048 information items.
1049 (DesktopSetupPage::DesktopSetupPage): Register position specifiers.
1050 (set_status): New static method.
1051 (load_dialog): Set status information, if available.
1052 (DesktopSetupPage::OnInit): Set status header font.
1053
909f5cf9
BD
10542007-03-01 Brian Dessent <brian@dessent.net>
1055
1056 * ini.h (SETUP_INI_FILENAME): Rename setup_9x.ini to setup_legacy.ini.
1057 (SETUP_BZ2_FILENAME): Likewise.
1058
5072c0bb
BD
10592007-02-27 Brian Dessent <brian@dessent.net>
1060
1061 * ini.h (SETUP_INI_FILENAME): Add define.
1062 (SETUP_BZ2_FILENAME): Add define.
1063 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use
1064 above macros to parameterize setup.ini filename.
1065 * fromcwd.cc (SetupFindVisitor::visitFile): Ditto.
1066 * ini.cc (do_remote_ini): Ditto.
1067 * Makefile.am (setup_SOURCES): Add win32.cc.
1068 * autoload.c: Include windows.h directly instead of win32.h so that
1069 win32.h can contain C++.
1070 * desktop.cc (verinfo): Delete.
1071 (make_link): Use IsWindowsNT to check for NT instead of verinfo.
1072 (DesktopSetupPage::OnInit): Likewise.
1073 * mount.cc (is_admin): Likewise.
1074 * script.cc (init_run_script): Likewise.
1075 * main.cc (class SIDWrapper, SIDWrapper::SIDWrapper,
1076 SIDWrapper::~SIDWrapper, SIDWrapper::theSID, class HANDLEWrapper,
1077 HANDLEWrapper::HANDLEWrapper, HANDLEWrapper::~HANDLEWrapper,
1078 HANDLEWrapper::theHANDLE, class TokenGroupCollection,
1079 TokenGroupCollection::TokenGroupCollection,
1080 TokenGroupCollection::~TokenGroupCollection,
1081 TokenGroupCollection::populate, TokenGroupCollection::find,
1082 class NTSecurity, set_default_sec, NTSecurity::NoteFailedAPI,
1083 NTSecurity::NTSecurity, NTSecurity::failed,
1084 NTSecurity::initialiseEveryOneSID, NTSecurity::setDefaultDACL,
1085 NTSecurity::setDefaultSecurity): Remove implementation of these
1086 classes from this file and into new file win32.cc and existing win32.h.
1087 (main): Fix whitespace and formatting per GNU coding standards.
1088 * res.rc (IDS_SETUPINI_MISSING): Parameterize filename with %s.
1089 * win32.cc: New file containing methods removed from main.cc as well
1090 as new class VersionInfo methods.
1091 * win32.h: Include <string> for std::string.
1092 (class SIDWrapper, class HANDLEWrapper, class TokenGroupCollection,
1093 class NTSecurity): Add classes removed from main.cc.
1094 (class VersionInfo): Add new class.
1095 (GetVer): Declare.
1096 (IsWindowsNT): Define.
1097
5cc32375
BD
10982007-02-20 Brian Dessent <brian@dessent.net>
1099
1100 * README: Modernize list of required packages, and mention doconfigure.
1101
5ef77c46
BD
11022007-02-17 Cesar Strauss <cstrauss@cea.inpe.br>
1103
3c1254b9
MB
1104 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
1105 Initialize the version and operator fields of the newly created
1106 PackageSpecification object, so setup can pick the correct source
1107 version later on.
5ef77c46 1108
a875b471
BD
11092007-02-17 Brian Dessent <brian@dessent.net>
1110
1111 * script.cc (Script::run): Check for existance of script file and
1112 return without doing anything if it does not exist.
1113
3a694862
MB
11142006-12-26 Max Bowsher <maxb1@ukf.net>
1115
1116 * IniDBBuilder.h (IniDBBuilder): Make this class abstract.
1117 * IniDBBuilder.cc: Delete file.
1118 * Makefile.am (inilint_SOURCES, setup_SOURCES): Remove IniDBBuilder.cc.
1119
be8736e4
MB
11202006-12-26 Max Bowsher <maxb1@ukf.net>
1121
1122 Add a shell script that documents/centralizes the standard configure
1123 command line.
1124
1125 * doconfigure: New file.
1126 * Makefile.am (EXTRA_DIST): Add doconfigure.
1127
cafda414
IP
11282006-11-28 Igor Peshansky <pechtcha@cs.nyu.edu>
1129
1130 * install.cc (Installer::installOne): If file is in use, ask the user
1131 to stop processes and retry.
1132 (MB_RETRYCONTINUE, IDCONTINUE): New macros.
1133 (hMsgBoxHook): New static field.
1134 (CBTProc): New window hook function.
1135 (_custom_MessageBox): New function.
1136 * CHANGES: Update with the above.
1137
effce34d
IP
11382006-10-12 Igor Peshansky <pechtcha@cs.nyu.edu>
1139
1140 * desktop.cc (make_cygwin_bat,save_icon): Capitalize filename.
1141
7dc7a0a4
BD
11422006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1143
1144 * package_version.cc (packageversion::scan): Catch and handle
1145 validation exception.
1146
0ec7cbc9
BD
11472006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1148
1149 * cygpackage.h (filesize): Remove unused field.
1150 (cygpackage::createInstance): Ditto.
1151 * cygpackage.cc (cygpackage::createInstance): Ditto.
1152 * package_db.cc (packagedb::packagedb): Remove unused variables.
1153 Simplify parsing of installed.db.
1154
c861f482
BD
11552006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1156
1157 * desktop.cc (DesktopSetupPage::OnInit): Remove stray MessageBox.
1158
3d4c5ebb
IP
11592006-05-24 Igor Peshansky <pechtcha@cs.nyu.edu>
1160
1161 * PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView.
1162 * PickView.h (PickView::DrawIcon): Move from PickPackageLine.
1163 (PickView::icon_dc,PickView::bm_icon): New instance field.
1164 (PickView::rect_icon,PickView::bg_fg_brush): Ditto.
1165 * PickCategoryLine.cc (PickCategoryLine::paint): Use
1166 PickView::DrawIcon() instead of BitBlt().
1167 * PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView.
1168 (PickPackageLine::paint): Use PickView::DrawIcon().
1169 * PickView.cc (PickView::~PickView): Delete GDI objects.
1170 (PickView::init): Create icon drawing context.
1171 (PickView::DrawIcon): New function. Use system default colors to
1172 draw bitmaps.
1173 (PickView::paint): Set background color instead of using transparent
1174 mode. Create system-colored brush.
1175
ba2559db
BD
11762006-04-25 Brian Dessent <brian@dessent.net>
1177
1178 * COPYING: New file (GPL).
1179 * Makfile.am (EXTRA_DIST): Add COPYING.
1180
5f9ac473
MB
11812006-04-17 Max Bowsher <maxb1@ukf.net>
1182
1183 * String++.cc, String++.h: Finally, it's time for the long-awaited
1184 departure of 'class String' from this world. setup.exe can now
1185 happily claim to follow the sane path of using just one general
1186 purpose string class throughout :-)
1187
02d06553
MB
11882006-04-17 Max Bowsher <maxb1@ukf.net>
1189
1190 * cygpackage.cc, cygpackage.h, package_version.cc, package_version.h:
1191 Do some String to std::string migration.
1192
1eb2461a
MB
11932006-04-17 Max Bowsher <maxb1@ukf.net>
1194
1195 * package_meta.cc, package_meta.h, package_source.cc,
1196 package_source.h: Do some String to std::string migration.
1197 * package_db.cc: Small tweak to assist with the above.
1198
d19f12fd
MB
11992006-04-17 Max Bowsher <maxb1@ukf.net>
1200
1201 * PickView.cc, PickView.h, package_db.cc, package_db.h:
1202 Do some String to std::string migration.
1203 * package_meta.h: Change a couple of types to assist with the above.
1204
9b0876b3
MB
12052006-04-17 Max Bowsher <maxb1@ukf.net>
1206
1207 * IniDBBuilder.cc, IniDBBuilder.h, IniDBBuilderPackage.cc,
1208 IniDBBuilderPackage.h, PickLine.h, PickPackageLine.cc:
1209 Do some String to std::string migration.
1210
fd93eff9
MB
12112006-04-16 Max Bowsher <maxb1@ukf.net>
1212
1213 * FindVisitor.cc, FindVisitor.h, IniParseFindVisitor.cc,
1214 IniParseFindVisitor.h, ScanFindVisitor.cc, ScanFindVisitor.h, find.cc,
1215 find.h, fromcwd.cc, ini.cc, ini.h, iniparse.y, postinstall.cc:
1216 Do some String to std::string migration.
1217
a3a02820
MB
12182006-04-16 Max Bowsher <maxb1@ukf.net>
1219
1220 * IOStreamProvider.h, archive.cc, archive.h, archive_tar.cc,
1221 archive_tar.h, io_stream.cc, io_stream.h, io_stream_cygfile.cc,
1222 io_stream_cygfile.h, io_stream_file.cc, io_stream_file.h:
1223 Do some String to std::string migration.
1224
2bba98e8
MB
12252006-04-16 Max Bowsher <maxb1@ukf.net>
1226
1227 * desktop.cc, download.cc, install.cc, mount.cc, mount.h, script.cc,
1228 script.h: Do some String to std::string migration.
1229
ee4ad3a7
MB
12302006-04-16 Max Bowsher <maxb1@ukf.net>
1231
1232 * category.cc: Remove source file that contained no code!
1233 * category.h: Delete, moving the single useful line to...
1234 * package_meta.h: ...here. Remove category.h include.
1235 * choose.cc, package_db.h, package_meta.cc: Remove category.h include.
1236 * Makefile.am: Remove references to removed files.
1237
08678720
MB
12382006-04-15 Max Bowsher <maxb1@ukf.net>
1239
1240 * ConnectionSetting.cc, ConnectionSetting.h, Exception.cc,
1241 Exception.h, IniParseFeedback.cc, IniParseFeedback.h, LogFile.cc,
1242 LogFile.h, LogSingleton.h, PackageSpecification.cc,
1243 PackageSpecification.h, SourceSetting.cc, SourceSetting.h,
1244 UserSettings.cc, UserSettings.h, dialog.cc, dialog.h, diskfull.cc,
1245 diskfull.h, filemanip.cc, filemanip.h, inilintmain.cc, localdir.cc,
1246 main.cc, nio-file.cc, nio-http.cc, prereq.cc, prereq.h, proppage.cc,
1247 proppage.h, site.cc, site.h, splash.cc, state.cc, state.h, window.cc,
1248 window.h: Do some String to std::string migration.
1249
cb026227
MB
12502006-04-15 Max Bowsher <maxb1@ukf.net>
1251
1252 * String++.cc, String++.h
1253 (new_cstr_char_array, format_1000s): Migrate String to std::string.
ca2b7505 1254 (casecompare_lt_op, std::string operator+): New.
cb026227 1255
470f4928
MB
12562006-04-06 Max Bowsher <maxb1@ukf.net>
1257
1258 * String++.h, String++.cc
1259 (String::replace): Remove - usused.
1260 (String::find): Remove - semantics do not match std::string.
1261
1262 * root.cc (directory_is_rootdir): Switch to std::string.find().
1263 * script.cc (Script::baseName): Rewrite use of String.find().
1264
2b791966
MB
12652006-03-30 Max Bowsher <maxb1@ukf.net>
1266
1267 * String++.cc (replace): New function to take the place of one form
1268 of String::replace method.
1269 * String++.h (replace): Declare.
1270 (String::replace): Make private.
1271
1272 * desktop.cc (make_cygwin_bat): Use new function.
1273 * filemanip.cc (backslash): Use simple loop in place of
1274 String::replace.
1275 * filemanip.h (backslash): Change signature to use std::string in
1276 place of String.
1277
afa76033
MB
12782006-03-30 Max Bowsher <maxb1@ukf.net>
1279
1280 * String++.cc, String++.h (casecompare): New function replacing
1281 String.casecompare to increase parity with std::string.
1282 (String::casecompare): Make private.
1283
1284 * ConnectionSetting.cc, IniDBBuilderPackage.cc,
1285 IniParseFindVisitor.cc, LogFile.cc, PackageSpecification.cc,
1286 PickView.cc, SourceSetting.cc, String++.cc, String++.h, fromcwd.cc,
1287 io_stream.cc, mount.cc, package_db.cc, package_source.h,
1288 package_version.cc, prereq.h, script.cc:
1289 Use casecompare in place of String::casecompare.
1290
8300be9c
MB
12912006-03-30 Max Bowsher <maxb1@ukf.net>
1292
1293 * String++.cc, String++.h: Remove String(int) constructor, which
1294 was causing dangerously bizarre implicit conversions, and was a point
1295 of disparity between String and std::string.
1296 (stringify): New function to replace functionality removed above.
1297
1298 * PickView.cc (PickView::init_headers),
1299 archive_tar.cc (archive_tar::next_file_name),
1300 cygpackage.cc (cygpackage::setCanonicalVersion):
1301 Make explicit and call out with a FIXME some bizarre behaviour.
1302
1303 * ScanFindVisitor.cc (ScanFindVisitor::visitFile),
1304 filemanip.cc (base), iniparse.y,
1305 threebar.cc (ThreeBarProgressPage::SetBar2):
1306 Make simple adaptations to the changed API.
1307
7c593196
IP
13082006-03-14 Igor Peshansky <pechtcha@cs.nyu.edu>
1309
1310 * PickView.cc (PickView::setViewMode): Auto-expand category if
1311 its name starts with a dot.
1312
3dbb54fc
DK
13132006-03-14 Dave Korn <dave.korn@artimi.com>
1314
1315 * String++.cc (new_cstr_char_array): Handle null input correctly.
1316
e5e2eba8
CF
13172006-03-10 Christopher Faylor <cgf@timesys.com>
1318
1319 * res.rc: Update copyright.
1320 (IDS_MIRROR_LST): Use cygwin.com for mirror list, not
1321 sources.redhat.com.
e5e2eba8 1322 * site.cc (NOSAVE1): Use preferred name of sourceware site.
4f41c01c 1323 (NOSAVE2): sourceware.cygnus.com -> sources.redhat.com.
e5e2eba8
CF
1324 (NOSAVE1_LEN): Use just-defined name to determine length.
1325 (NOSAVE2_LEN): Ditto.
1326 (NOSAVE3_LEN): Ditto.
1327
13282006-03-10 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1329
1330 * res.rc (IDD_DROPPED): New dialog.
1331 * resource.h (IDD_DROPPED): New dialog-id.
1332 (IDC_DROP_MIRRORS, IDC_DROP_NOWARN): New control-ids.
1333 * site.cc: Add enum for response on dropped mirrors.
1334 (cache_is_usable, cache_needs_writing): New bools.
1335 (cache_warn_urls): New string.
1336 (cached_site-list, dropped_site_list): New SiteLists.
1337 (site_list_type::init, site_list_type::site_list_type): Change to four
1338 parameter form.
1339 (site_list_type::site_list_type, site_list_type::operator=) Copy
1340 servername, area and location.
1341 (load_site_list): New function, broken out of get_site_list. Support
1342 four-parameter site_list_type.
1343 (get_site_list): Break out load_site_list. Move reading cache earlier.
1344 Don't write new cache. Set flags to record cache state. Load both
1345 all_site_list and cached_site_list.
1346 (SiteSetting::registerSavedSite): Use four-parameter site_list_type.
1347 (drop_proc, check_dropped_mirrors, write_cache_list, save_cache_file):
1348 New functions.
1349 (SitePage::OnNext): Check for dropped mirrors and save cache as
1350 appropriate.
1351 (SitePage::OnMessageCmd): Use four-parameter site_list_type.
1352 * site.h
1353 (site_list_type::init, site_list_type::site_list_type): Change to four
1354 parameter form.
1355 (site_list_type): Add servername, area and location members.
1356
b2b35a6e
IP
13572006-03-09 Igor Peshansky <pechtcha@cs.nyu.edu>
1358
1359 * script.cc (Script::run): Fix inverted test for abnormal exit.
1360
966a9815
MB
13612006-03-09 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1362 Max Bowsher <maxb1@ukf.net>
1363
1364 Provide indication of site that a file is being downloaded from.
1365
1366 * geturl.cc: Use std::string instead of String throughout.
1367 (init_dialog): Put more information into GUI.
1368 Remove unused 'owner' parameter and change all callers.
1369 (progress): Remove spurious \n characters from GUI.
1370 * geturl.h: Use std::string instead of String throughout.
1371 * res.rc (IDD_INSTATUS): Use SS_ENDELLIPSIS.
1372
8e91c2fb
MB
13732006-03-09 Max Bowsher <maxb1@ukf.net>
1374
1375 * Makefile.am (EXTRA_DIST): Add tree-minus.bmp and tree-plus.bmp.
1376
bb810dd8
DK
13772006-01-20 Bryan Thrall <bryan.thrall@flightsafety.com>
1378
1379 * source.cc (SourcePage::OnActivate): Command line takes precedence
1380 over last user selection.
1381
253585ba
MB
13822005-11-30 Max Bowsher <maxb1@ukf.net>
1383
1384 * res.rc (IDD_ROOT, IDD_LOCAL_DIR): Rearrange some controls a little,
1385 in response to suggestion from Carl Karsten.
1386
d60832c6
MB
13872005-11-30 Max Bowsher <maxb1@ukf.net>
1388
1389 * site.h, site.cc: Use std::string in preference to String.
1390 (site_list_type::init): Convert some painful raw C string work to
1391 STL std::string work. Stop totally ignoring the result of this
1392 calculation, implementing the (somewhat weird) sort order for sites
1393 that was apparently indented for ages.
1394
3d3c6047
IP
13952005-10-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1396
1397 * io_stream.cc (url_scheme_not_registered): New macro.
1398 (io_stream::open): Better log message on error.
1399 (io_stream::mkpath_p,io_stream::remove,io_stream::mklink): Ditto.
1400 (io_stream::move,io_stream::exists): Ditto.
1401
b059e20b
IP
14022005-10-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1403
1404 * site.cc (get_site_list): Default to empty mirror list if
1405 server unavailable and none cached, to allow using preferred
1406 mirrors anyway.
1407
82573872
IP
14082005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1409
1410 * package_db.cc (packagedb::packagedb): Remember missing package
1411 database file.
1412
9237e1bb
IP
14132005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1414
1415 * site.cc (get_site_list): Store mirror list locally.
1416 Use local copy if unable to download.
1417
a8be3f13
IP
14182005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1419
1420 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
1421 Better log message on error.
1422
2a8125be
IP
14232005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1424
bd3a38c7 1425 * script.cc (Script::isAScript): Fix string comparison.
2a8125be 1426
01b9378a
IP
14272005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1428
1429 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Reconnect on FTP timeout.
1430
65ce9baf
BD
14312005-09-11 Masayuki FUJII <boochang@m4.kcn.ne.jp>
1432
1433 * package_meta.cc (packagemeta::ScanDownloadedFiles): Don't use an
1434 invalid iterator. Fix whitespace.
1435
3f6926b1
BD
14362005-09-09 Brian Dessent <brian@dessent.net>
1437
1438 * CHANGES: Document recent updates.
1439 * choose.cc (ChooserPage::OnInit): Add new tooltip.
1440 * res.rc (IDD_CHOOSE): Remove 'administrative' from description.
1441 (IDS_HIDEOBS_TOOLTIP): Add new string for tooltip.
1442 * resource.h (IDS_HIDEOBS_TOOLTIP): Define.
1443 * window.cc (Window::ActivateTooltips): Fix whitespace. Set tooltip
1444 delay to 30 seconds.
1445
9dda7744
BD
14462005-09-09 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1447
1448 * PickView.cc (PickView::paint): Set background mode to transparent.
1449 * PickCategoryLine.cc (PickCategoryLine::paint): Use bitwise AND to
1450 blit bitmaps.
1451 * PickPackageLine.cc (PickPackageLine::paint): Ditto.
1452
534c25cc
BD
14532005-09-01 Brian Dessent <brian@dessent.net>
1454
1455 * package_meta.cc (packagemeta::uninstall): Remove support for
1456 undocumented and dangerous postremove script.
1457
14582005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1459
1460 * script.cc (run): Change to return the exit code or negative error.
1461 (Script::run): Ditto.
1462 (try_run_script): Receive both filename and extension and run only
1463 one script. Also return the exit code.
1464 * script.h (try_run_script): Change signature.
1465 (Script::run): Ditto.
1466 * postinstall.cc (RunScript::operator()): Change to return the exit
1467 code or negative error.
1468 * install.cc (Installer::preremoveOne): Pass extension to
1469 try_run_script().
1470
14712005-09-01 Eric Blake <ebb9@byu.net>
1472
1473 * script.cc (shells): Use /bin/bash, not sh, to allow upgrades to
1474 /bin/sh.
1475
0ac305ec
BD
14762005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1477
1478 * PickView.h (PickView::size_col): New instance variable.
1479 * PickView.cc (pkg_headers, cat_headers): Add size column.
1480 (PickView::set_headers): Initialize size_col.
1481 (PickView::init_headers): Include width of size column.
1482 * PickPackageLine.cc (PickPackageLine::paint): Handle size_col.
1483 * String++.cc (format_1000s): New function.
1484 * String++.h (format_1000s): Declare new function.
1485
aa62e0f3
BD
14862005-09-01 Brian Dessent <brian@dessent.net>
1487
1488 * Makefile.am (BASECXXFLAGS): Add -Wno-uninitialized to work around
1489 spurious warnings with gcc 3.4.4.
1490
687dd890
BD
14912005-05-22 Brian Dessent <brian@dessent.net>
1492
1493 * res.rc (IDD_CHOOSE): Change description to include administrative
1494 packages in addition to obsolete.
1495
82306ac2
BD
14962005-05-21 Brian Dessent <brian@dessent.net>
1497
1498 * prereq.cc: New file.
1499 * prereq.h: Ditto.
1500 * tree-minus.bmp: Ditto.
1501 * tree-plus.bmp: Ditto.
1502 * Makefile.am: Add prereq.cc and prereq.h to build.
1503 * PickCategoryLine.cc (PickCategoryLine::paint): Add new parameter and
1504 refactor. Use bitmap for '+' and '-' indicators. Draw package lines
1505 column-wise for better drawing efficiency.
1506 (PickCategoryLine::click): Use previously calculated x value.
1507 * PickCategoryLine.h (PickCategoryLine::paint): Update prototype. Add
1508 'spin_x' member.
1509 * PickLine.h (PickLine:paint): Update prototype.
1510 * PickPackageLine.cc (PickPackageLine::DrawCheck): Remove.
1511 (PickPackageLine::DrawIcon): New function.
1512 (PickPackageLine::paint): Add parameter. Refactor completely for more
1513 efficient painting.
1514 * PickPackageLine.h (PickPackageLine::DrawIcon): Add prototype.
1515 (PickPackageLine::paint): Update prototype.
1516 (PickPackageLine::DrawCheck): Remove.
ca2b7505 1517 * PickView.cc (pkg_headers): Remove unused 'slen' field, add new
82306ac2 1518 'needs_clip' field to signify if clipping is necessary for this column.
ca2b7505 1519 (PickView::note_width): Fold long line. Refactor slightly for
82306ac2
BD
1520 simplicity.
1521 (PickView::set_view_mode): Remove.
1522 (PickView::cycleViewMode): New function.
1523 (PickView::setViewMode): Refactor completely. Incorporate functionality
1524 of clear_view() here instead. Simplify package selection into a single
1525 'for' loop rather than repeating code for each type.
1526 (isObsolete): New function, with second overloaded version.
1527 (PickView::setObsolete): New function.
1528 (PickView::insert_pkg): Do not show obsolete packages. Move
1529 declaration of 'db' lower. Fix whitespace.
1530 (PickView::insert_category): Do not show obsolete packages.
ca2b7505 1531 (PickView::clear_view): Remove. Moved logic into 'setViewMode'.
82306ac2
BD
1532 (PickView::scroll): Add additional parameter 'howmany' with default
1533 value of 1. Scroll by 'howmany' lines for SB_LINEDOWN and SB_LINEUP.
1534 (NUM_CATEGORY_COL_WIDTH): Define.
1535 (PickView::init_headers): Fix whitespace. Add comments. Ignore
1536 obsolete packages in width calculations. Add functionality to size
1537 'Category' column so that at least NUM_CATEGORY_COL_WIDTH categories
1538 are displayed for every package. Ensure that 'new_col' takes into
1539 account all possible labels.
1540 (PickView::PickView): Initialize showObsolete to false.
1541 (PickView::init): Remove unused bitmap bm_rtarrow. Add new bitmaps
1542 bm_treeplus and bm_treeminus. Use a macro for better readability.
1543 Fix whitespace formatting. Remove header computation from here, call
1544 refresh() instead.
1545 (PickView::registerWindowClass): Remove unnecessary background brush.
1546 (PickView::WindowProc): Add support for WM_MOUSEWHEEL message
1547 processing. Fix indentation. Reformat for readability.
1548 (PickView::paint): Get the update region before calling BeginPaint.
1549 Fill the update region with the default colors. Do not do clipping
1550 here. Pass update region to the PickLine paint function instead.
1551 Free the update region when finished.
1552 (PickView::Create): Fix indentation.
1553 (PickView::defaultTrust): Ditto.
1554 (PickView::refresh): Add column recalculation logic here.
1555 * PickView.h: Fix indentation.
1556 (RTARROW_WIDTH): Remove unused define.
1557 (NEW_COL_SIZE_SLOP): Ditto.
1558 (TREE_INDENT): Define.
1559 (PickView::get_view_mode): Remove.
1560 (PickView::set_view_mode): Rename to setViewMode for consistency.
1561 (PickView::cycleViewMode): Add new function.
1562 (PickView::setObsolete): Ditto.
1563 (PickView::clear_view): Remove.
1564 (PickView::bm_treeplus): Define new member.
1565 (PickView::bm_treeminus): Ditto.
1566 (PickView::scroll): Add parameter.
1567 (PickView::Header::slen): Remove unused member.
1568 (PickView::Header::needs_clip): Define new member.
1569 (PickView::showObsolete): Ditto.
1570 (isObsolete): Add prototype, and for overloaded version as well.
1571 * choose.cc: Add include.
1572 (ChooserControlsInfo): Allow new checkbox to be resized.
1573 (ChooserPage::OnInit): Start dialog with 'Hide obsolete' checked.
1574 (ChooserPage::OnNext): Call the dependency checker, act accordingly.
1575 (ChooserPage::changeTrust): Notify dependency checker of current trust
1576 level when it changes.
1577 (ChooserPage::OnMessageCmd): Just call cycleViewMode instead when
1578 changing the view. Update the chooser when the user toggles the
1579 'hide obsolete' checkbox.
1580 (ChooserPage::OnMouseWheel): New function. Pass mouse wheel message
1581 on to chooser.
1582 * choose.h (OnMouseWheel): Add prototype.
1583 * main.cc: Add include.
1584 (main): Define and initialize the PrereqPage object. Add it into
1585 the property sheet list.
1586 * PropPage.cc (PropertyPage::DialogProc): Add support for WM_MOUSEWHEEL
1587 message processing in derived classes.
1588 (PropertyPage::OnMouseWheel): New function.
1589 * PropPage.h (PropertyPage::OnMouseWheel): Add prototype.
1590 * res.rc (IDD_LOCAL_DIR): Shorten edit box so that pushbutton is not
1591 crowded.
1592 (IDD_SITE): Provide static text with an ID so that it can be resized
1593 properly. Move pushbutton slightly to right so that it doesn't crowd
1594 edit box.
1595 (IDD_SPLASH): Change copyright displayed on spash screen to be generic
1596 since the actual list of contributors is long.
1597 (IDD_CHOOSE): Add checkbox. Resize other controls to accomodate.
1598 (IDD_PREREQ): New dialog.
1599 (SPIN): Delete duplicated bitmap resource.
1600 (IDB_RTARROW): Remove unused bitmap resource.
1601 (IDB_TREE_PLUS): Add.
1602 (IDB_TREE_MINUS): Ditto.
1603 (IDS_TRUSTPREV_TOOLTIP): Revise wording to be more concise.
1604 (IDS_TRUSTCURR_TOOLTIP): Ditto.
1605 (IDS_TRUSTEXP_TOOLTIP): Ditto.
1606 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
1607 * resource.h (IDD_PREREQ): Define.
1608 (IDB_RTARROW): Remove.
1609 (IDB_TREE_PLUS): Add, and renumber.
1610 (IDB_TREE_MINUS): Ditto.
1611 (IDC_SITE_USERURL): Define.
1612 (IDC_CHOOSE_HIDE): Ditto.
1613 (IDC_PREREQ_TEXT): Ditto.
1614 (IDC_PREREQ_EDIT): Ditto.
1615 (IDC_PREREQ_CHECK): Ditto.
1616 * site.cc (SiteControlsInfo): Ensure that 'User URL' static text is
1617 properly resized.
1618
846e099d
MB
16192005-05-14 Max Bowsher <maxb@ukf.net>
1620
1621 "Type" field of packageversions was not even being filled in. Fix.
1622
1623 * cygpackage.h, cygpackage.cc (cygpackage::createInstance):
1624 Make "type" a mandatory parameter of the constructor.
1625 * IniDBBuilderPackage.cc: Adjust callers.
1626
c1352375
MB
16272005-05-14 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1628
1629 Fix behaviour of hardlinks in source packages.
1630
1631 * archive.cc (archive::extract_file):
1632 Use prefixPath for link target on hardlinks.
1633
403f1027
MB
16342005-05-14 Max Bowsher <maxb@ukf.net>
1635
1636 Hopefully, solve the "preremove DLL dependency" bug, by running all
1637 preremove scripts before actually removing any files.
1638
ca2b7505 1639 * install.cc
403f1027
MB
1640 (Installer::preremoveOne): New method. Run preremove scripts here.
1641 (Installer::replaceOne): Remove method.
1642 (num_replacements): Remove variable.
1643 (do_install_thread): Significantly rewrite.
1644 * package_meta.cc (packagemeta::uninstall):
1645 Do not run preremove script here.
1646
f916c374
MB
16472005-05-14 Max Bowsher <maxb@ukf.net>
1648
1649 * download.cc (do_download_thread):
1650 Do not use packageversion::changeRequested().
1651 * package_version.cc (packageversion::Type):
1652 Implement declared but previously unimplemented method.
1653 (packageversion::changeRequested, _packageversion::changeRequested):
1654 Remove.
1655 * package_version.h
1656 (packageversion::changeRequested, _packageversion::changeRequested):
1657 Remove.
1658 * install.cc (Installer::replaceOne): Simplify, return void, not int.
1659 (installOneSource): Rename to...
403f1027 1660 (installOne): ...this. Change arguments and return type. Refactor.
f916c374
MB
1661 (install_one): Remove.
1662 (do_install_thread): Tidying up.
1663
655310ed
MB
16642005-05-07 Max Bowsher <maxb@ukf.net>
1665
1666 * download.cc (validateCachedPackage): Remove all MD5 checking code.
1667 It is not acceptable to check MD5 sums as part of simply answering
1668 whether a package exists in the local cache or not. It is too slow.
1669 MD5 sums always have been - and will continue to be - checked at
1670 install time.
1671 (NoMD5Option): Remove this option, as the code it controls has been
1672 removed.
1673
61a9e487
MB
16742005-05-07 Max Bowsher <maxb@ukf.net>
1675
1676 * install.cc (md5_one): Make the MD5 checking done at install time
1677 display a progess GUI, as the MD5 checking done at other times does.
1678
4c90a532
MB
16792005-05-07 Max Bowsher <maxb@ukf.net>
1680
1681 * resource.h, res.rc: Followup to recent de-MSVC-ification of
1682 resource.h, by removing a lot from res.rc, and the last few bits
1683 from resource.h.
1684
9a8a04fc
BD
16852005-05-05 Brian Dessent <brian@dessent.net>
1686
37f49caf
BD
1687 * choose.cc (ChooserPage::OnInit): Initialize tooltips for this
1688 dialog.
1689
1690 * proppage.h (PropertyPage::makeClickable): Update prototype to
1691 reflect same argument name as function.
1692
1693 * proppage.cc (PropertyPage::DialogProc): Remove redundant 'break'
ca2b7505 1694 statements that follow 'return's. Add missing braces to case
37f49caf
BD
1695 statements. Call handler for TTN_GETDISPINFO.
1696
1697 * res.rc (IDS_TRUSTKEEP_TOOLTIP): Add new STRINGTABLE entry for
1698 tooltip text.
1699 (IDS_TRUSTPREV_TOOLTIP): Ditto.
ca2b7505 1700 (IDS_TRUSTCURR_TOOLTIP): Ditto.
37f49caf
BD
1701 (IDS_TRUSTEXP_TOOLTIP): Ditto.
1702 (IDS_TRUSTPREV_TOOLTIP): Ditto.
1703 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
1704
1705 * resource.h: Likewise, add identifiers for tooltip resources.
1706
1707 * window.h: Add includes.
1708 (Window::TooltipHandle): Add new private data structure.
1709 (Window::TooltipStrings): Ditto.
1710 (Window::ActivateTooltips): Define new function to support tooltip
1711 functionality.
1712 (Window::SetTooltipState): Ditto.
1713 (Window::AddTooltip): Ditto.
322281d3 1714 (Window::TooltipNotificationHandler): Ditto.
37f49caf
BD
1715
1716 * window.cc (Window::Window): Initialize handle to NULL.
1717 (Window::~Window): Call DestroyWindow on tooltip control if it was
1718 activated.
1719 (Window::ActivateTooltips): New function to activate the tooltip
1720 control.
1721 (Window::SetTooltipState): New function to allow toggling of
1722 tooltips.
1723 (Window::AddTooltip): New function that adds a tooltip to a given
1724 control in a given window. Also implement overloaded versions that
1725 provide simpler interface and the ability to use a string resource.
1726 (Window::TooltipNotificationHandler): New function to handle
1727 TTN_GETDISPINFO notification messages.
1728
17292005-05-05 Brian Dessent <brian@dessent.net>
4c90a532 1730
9a8a04fc
BD
1731 * resource.h: Reorganize. Group by type, and give each its own
1732 range of IDs. Regenerate IDs accordingly.
1733 (IDD_CHOOSER): Remove obsolete and unused symbol.
1734
9e6e3c68
BD
17352005-05-05 Brian Dessent <brian@dessent.net>
1736
1737 * root.h (class RootPage): Add missing virtual to OnMessageCmd.
1738
746fff8d
BD
17392005-05-05 Brian Dessent <brian@dessent.net>
1740
1741 * root.cc (dialog_cmd): Remove. Use OnMessageCmd instead.
1742 (RootPage::Create): Accomodate above change.
1743
1744 * root.h (class RootPage): Add prototype for OnMessageCmd.
1745
1746 * res.rc (IDD_ROOT): Fix broken button groups. Correct the order of
ca2b7505 1747 the controls and use of WS_GROUP so that the radio buttons act
746fff8d
BD
1748 correctly.
1749
d2a3615c
MB
17502005-05-05 Max Bowsher <maxb@ukf.net>
1751
1752 Bulk rename of String++ member cstr_oneuse () to c_str () for
1753 similarity to std::string.
1754
1755 * Exception.cc
1756 * IniDBBuilderPackage.cc
1757 * IniParseFindVisitor.cc
1758 * LogFile.cc
1759 * PickCategoryLine.cc
1760 * PickPackageLine.cc
1761 * PickView.cc
1762 * String++.cc
1763 * String++.h
1764 * archive.cc
1765 * cygpackage.cc
1766 * desktop.cc
1767 * dialog.cc
1768 * diskfull.cc
1769 * download.cc
1770 * filemanip.cc
1771 * find.cc
1772 * geturl.cc
1773 * ini.cc
1774 * install.cc
1775 * io_stream.cc
1776 * io_stream_cygfile.cc
1777 * io_stream_file.cc
1778 * localdir.cc
1779 * mount.cc
1780 * nio-http.cc
1781 * package_db.cc
1782 * package_meta.cc
1783 * package_source.h
1784 * postinstall.cc
1785 * proppage.cc
1786 * root.cc
1787 * script.cc
1788 * site.cc
1789 * splash.cc
1790 * threebar.cc
1791 * window.cc
1792
3a8630fd
MB
17932005-05-05 Max Bowsher <maxb@ukf.net>
1794
1795 Some String++ refactoring, setting out in the general direction of
1796 eventually just using the STL std::string, not our own class.
1797
1798 * String++.cc (String::cstr, String::cstr () const): Remove.
1799 (new_cstr_char_array): New function.
1800 * String++.h: Sync with above.
1801 Remove irrelevant "class io_stream;" declaration.
1802
1803 * cygpackage.h: Add "class io_stream;" declaration, now no longer
1804 being supplied by side-effect.
1805
1806 * filemanip.cc: Remove unneeded includes, add "using namespace std;".
1807 (parse_filename): Exchange some awkward pointer manipulation for
1808 std::string usage. Use new_cstr_char_array ().
1809 * filemanip.h: Sync with above.
1810 (fileparse): Improve style of declaration.
1811
1812 * io_stream_cygfile.cc (io_stream_cygfile::normalise):
1813 Use new_cstr_char_array ().
1814 * site.cc (site_list_type::init, get_site_list): Ditto.
1815
daab12c7
BD
18162005-05-05 Brian Dessent <brian@dessent.net>
1817
03e84729
MB
1818 * ControlAdjuster.h (enum ControlPosition): Declare new resizing
1819 methods CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, and their
1820 TOP/BOTTOM aliases.
daab12c7 1821
03e84729
MB
1822 * ControlAdjuster.cc (ControlAdjuster::ControlInfo::adjust):
1823 Implement CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, which are
1824 designed to resize elements in a two-column layout.
daab12c7 1825
03e84729
MB
1826 * localdir.h (class LocalDirPage): Remove constructor implementation
1827 from here...
daab12c7 1828
03e84729
MB
1829 * localdir.cc (LocalDirPage::LocalDirPage): ...to here, and call
1830 AddControlsInfo on initialization.
1831 (static LocaldirControlsInfo): Add. Define sizing rules for dialog
daab12c7
BD
1832 elements.
1833
03e84729
MB
1834 * proppage.h: Add includes.
1835 (PropertyPage::ClickableURL):
1836 Declare new storage type for internal use by class.
1837 (PropertyPage::urls): Likewise.
1838 (PropertyPage::urlWinProc): Add declaration.
daab12c7
BD
1839 (PropertyPage::makeClickable): Likewise.
1840
03e84729
MB
1841 * proppage.cc: Add includes.
1842 (PropertyPage::DialogProc): Implement handler for WM_CTLCOLORSTATIC
1843 message. Supports static controls that have been turned into
1844 clickable hyperlinks.
1845 (static PropertyPage::urls): Declare.
1846 (PropertyPage::makeClickable): Implement new member function that
1847 provides user interface for making text into clickable URLs.
1848 (PropertyPage::urlWinProc): Implement new private member function used
1849 as a windowproc for subclassing a static control.
1850
1851 * resource.h (IDC_SPLASH_URL, IDC_FILEMODES_LINK, IDC_ROOTDIR_GRP,
1852 IDC_INSTALLFOR_GRP, IDC_ALLUSERS_TEXT, IDC_JUSTME_TEXT, IDC_MODE_GRP,
1853 IDC_MODE_TEXT, IDC_MODE_BIN, IDC_LOCALDIR_GRP, IDC_SPLASH_TEXT,
1854 IDC_SPLASH_ICON, IDC_SPLASH_COPYR): Add. Replaces anonymous
daab12c7
BD
1855 IDC_STATIC ids, so that controls can be referenced by the resizer.
1856
03e84729
MB
1857 * res.rc (IDD_LOCAL_DIR): Rearrange controls to match top-down order
1858 in the dialog. Fold long lines. Replace anonymous IDC_STATIC ids.
1859 (IDD_ROOT): Reorder in same manner. Replace anonymous IDC_STATIC ids.
1860 Add descriptive text of each option, and hyperlink for more
1861 information. Mark suggested choice as "(RECOMMENDED)". Swap order of
1862 'unix'/'dos' radio buttons so that recommended choice is first in both
1863 columns.
1864 (IDD_SPLASH): Reorder elements to match top-down order of dialog, fold
1865 long lines. Add descriptive paragraph, remove anonymous ids. Update
1866 copyright text, replace sources.redhat.com with cygwin.com.
daab12c7 1867
03e84729 1868 * root.h (class RootPage): Remove constructor implementation from
daab12c7
BD
1869 here...
1870
03e84729
MB
1871 * root.cc: ...to here, and call AddControlInfo.
1872 (static RootControlsInfo): Add. Populate with resizing data.
daab12c7
BD
1873 (RootPage::OnInit): Make text a clickable hyperlink.
1874
03e84729 1875 * splash.h (class SplashPage): Likewise, move constructor from
daab12c7
BD
1876 here...
1877
03e84729
MB
1878 * splash.cc: ...to here. Call AddControlInfo.
1879 (static SplashControlsInfo): Add and populate.
1880 (SplashPage::Create): Make link on splash page a clickable hyperlink.
daab12c7 1881
03e84729
MB
1882 * window.h: Add include.
1883 (class Window): Store allocated fonts with a vector instead of fixed
1884 array. Change indentation of setParent to be consistent.
daab12c7 1885
03e84729
MB
1886 * window.cc (Window::Window): Remove FontCounter.
1887 (Window::~Window): Likewise. Iterate over vector of fonts instead.
1888 (Window::SetDlgItemFont): Use vector.
daab12c7 1889
042d83f9
MB
18902005-05-05 Max Bowsher <maxb@ukf.net>
1891
1892 * Makefile.am (EXTRA_DIST, inilint_SOURCES):
1893 Sync with several recent changes.
1894
a38fde1a
BD
18952005-05-05 Brian Dessent <brian@dessent.net>
1896
03e84729 1897 * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Include section
a38fde1a
BD
1898 comment.
1899
dd267526
BD
19002005-05-05 Brian Dessent <brian@dessent.net>
1901
1902 * res.rc: (IDC_CHOOSE): Widen 'view' button by 6px horizontally and
1903 4px vertically. Adjust other controls to accomodate.
1904 (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that manifest is
1905 included in the binary.
1906
1907 * setup.exe.manifest: New file. Results in common controls with
1908 themed appearance on modern versions of Windows.
1909
83524e5b
MB
19102005-05-05 Brian Dessent <brian@dessent.net>
1911
03e84729 1912 * main.cc (WinMain): Change conditional to avoid spurious error
83524e5b 1913 message on success. Include reason for failure in log message.
96f50f64 1914
071f7af3
MB
19152005-05-04 Max Bowsher <maxb@ukf.net>
1916
1917 * state.cc, state.h (net_method, net_proxy_host, net_proxy_port,)
1918 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
1919 Inet_ftp_user, net_ftp_passwd):
1920 Move these global variables to be static variables of the NetIO class.
1921
1922 * netio.h, netio.cc (net_method, net_proxy_host, net_proxy_port,)
1923 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
1924 net_ftp_user, net_ftp_passwd):
1925 As above.
1926
1927 * ConnectionSetting.cc, net.cc:
1928 Change include, refer to variables in new location.
1929
0a49fe44
MB
19302005-05-04 Max Bowsher <maxb@ukf.net>
1931
1932 * PickLine.cc: Remove file - redundant.
1933 * Makefile.am (setup_SOURCES): Adjust.
1934
7f3324d2
MB
19352005-05-04 Max Bowsher <maxb@ukf.net>
1936
1937 * package_version.h (packageversion::set_requirements):
1938 Remove deftrust argument default value.
1939
19402005-05-04 Max Bowsher <maxb@ukf.net>
2ef95e81
MB
1941
1942 * package_version.cc (DependencyProcessor): Remove trivial class.
1943 (select, processOneDependency): Do not use DependencyProcessor, just
1944 pass parameters normally.
1945
d20a2e29
MB
19462005-05-04 Brian Dessent <brian@dessent.net>
1947
1948 Fix bug #820: Clicking Curr, etc., causes some dependencies to not
1949 be installed.
1950
1951 * choose.cc (ChooserPage::changeTrust):
1952 Add a missing "packagedb.markUnVisited ()".
1953
9bd063e0
MB
19542005-05-03 Max Bowsher <maxb@ukf.net>
1955
1956 * PickCategoryLine.cc (PickCategoryLine::click):
1957 * PickPackageLine.cc (PickPackageLine::click):
1958 Abandon use of trivial packagemeta::PrepareForVisit() wrapper.
1959
1960 * package_meta.h (packagemeta::PrepareForVisit): Remove.
1961 * package_meta.cc (packagemeta::PrepareForVisit): Remove.
1962
97b50ad7
MB
19632005-05-03 Max Bowsher <maxb@ukf.net>
1964
1965 * choose.h (ChooserPage::ifChecked): Remove.
1966 (ChooserPage::changeTrust): Convert from template to ordinary function.
1967 * choose.cc (ChooserPage::changeTrust): As above, plus avoid the use
1968 of custom class SetRequirement, when bind2nd(mem_fun(...),...) can
1969 achieve the same effect.
1970 * package_meta.h (SetRequirement): Remove, now unused.
1971
98b84622
MB
19722005-05-03 Max Bowsher <maxb@ukf.net>
1973
1974 * package_meta.h (packagemeta::set_requirements):
1975 Remove default argument which seems inappropriate.
1976 * PickPackageLine.cc (PickPackageLine::click):
1977 Make an argument explicit, and not that it seems like the wrong value.
1978
7c86285f
MB
19792005-05-03 Brian Dessent <brian@dessent.net>
1980
1981 Fix part of bug #853 - proxy port not remembered.
1982
1983 * net.cc (doing_loading): New static boolean.
1984 (load_dialog): Use the boolean to prevent save_dialog() from taking
1985 action due to field changes due to initialization.
1986 (save_dialog): Check the boolean and respond appropriately.
1987
9ad9a0b0
MB
19882005-04-19 Max Bowsher <maxb@ukf.net>
1989
1990 * postinstall.cc (RunFindVisitor::visitFile): Fix crash on
1991 encountering a postinstall script with a name of 4 characters or less.
1992 Bug introduced on 2004-12-25.
1993
946198be
MB
19942005-04-05 Max Bowsher <maxb@ukf.net>
1995
1996 The Big Cleanup: Phase "rfc1738"
1997
1998 * rfc1738.cc, rfc1738.h: Delete.
1999 * csu_util/rfc1738.cc: Reimport latest version from upstream source.
2000 Make thread-safe. Rewrite C++ wrapper in terms of std::string.
2001 Document the divergences from the upstream source.
2002 * csu_util/rfc1738.h: Recreate for the std::string version of the
2003 C++ wrapper.
2004
2005 * Makefile.am (setup_SOURCES): Sync with added/removed files.
2006 * IniParseFindVisitor.cc: Modify #includes.
2007 (IniParseFindVisitor::visitFile): Change function name, as the new
2008 C++ wrapper does not contain an irregularity that the old one did.
2009 * download.cc: Modify #includes.
2010 * ini.cc: Modify #includes.
2011
e76de0f5
MB
20122005-04-05 Max Bowsher <maxb@ukf.net>
2013
2014 Remove setup's internal compression libraries, instead relying on the
2015 mingw-foo packages which have been part of the Cygwin net distribution
2016 for some time now. At the same time, reorganize the README file to
2017 inform about the change, and make some additional tidy-ups there whilst
2018 working there.
2019
2020 * GUIDELINES: Remove, contents transferred to README.
2021 * README: Add build instructions. Delete unconfirmed and fixed bugs
2022 sections. Incorporate the former contents of GUIDELINES.
2023
2024 * bz2lib/: Remove.
2025 * zlib/: Remove.
ca2b7505 2026 * Makefile.am (DIST_SUBDIRS, SUBDIRS):
e76de0f5
MB
2027 * configure.in: Remove AC_CONFIG_SUBDIRS for removed subdirs.
2028 * compress_bz.h: Remove complex _WIN32 preprocessor conditional.
2029 * compress_gz.h: Fix #include file name.
2030 * archive_tar_file.cc: Remove unused #include.
2031 * install.cc: Remove unused #include.
2032
069a187a
MB
20332005-01-27 Max Bowsher <maxb@ukf.net>
2034
2035 Set CYGWIN=nontsec, for postinstall scripts.
2036
2037 * main.cc (main): putenv("CYGWIN=nontsec").
2038
b4cf6208
MB
20392005-01-27 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
2040
2041 Fix corrupt display of ini parse percentage in log file.
2042
2043 * ini.cc (GuiParseFeedback): Use a sensible data type for lastpct.
2044
eff7a094
MB
20452004-12-29 Max Bowsher <maxb@ukf.net>
2046
2047 * site.cc (get_site_list): Filter the incoming mirrors list to contain
2048 only URL schemes that we can read.
2049
2c539780
MB
20502004-12-28 Max Bowsher <maxb@ukf.net>
2051
2052 The Big Cleanup: Phase "hash"
2053
2054 * hash.cc, hash.h: Delete.
2055 * Makefile.am (setup_SOURCES): Sync with deleted files.
2056
2057 * package_mets: Modify includes.
2058 (standard_dirs): Remove.
2059 (hash::add_subdirs): Remove.
2060 (packagemeta::uninstall): Re-implement using STL set instead of
2061 homebrew hash.
2062
4abaa9f9
MB
20632004-12-28 Max Bowsher <maxb@ukf.net>
2064
2065 * String++.h (operator std::string): Take care to never do
2066 std::string((char*)NULL) - it causes a hang!
2067
a77b6167
MB
20682004-12-27 Max Bowsher <maxb@ukf.net>
2069
2070 The Big Cleanup: Phase "log"
2071
2072 * log.cc, log.h: Delete old C-style compatibility wrapper around the
2073 logging subsystem.
2074 * Makefile.am (setup_SOURCES): Sync with deleted files.
2075
2076 * AntiVirus.cc, archive_tar_file.cc, ini.cc, install.cc,
2077 * io_stream_cygfile.cc, localdir.cc, msg.cc, net.cc, netio.cc,
2078 * netio.h, nio-ftp.cc, nio-ftp.h, root.cc, source.cc:
2079 Throughout, refine includes, and update code using the old
2080 compatibility wrapper to C++ streams style code.
2081
b16e07fc
MB
20822004-12-27 Max Bowsher <maxb@ukf.net>
2083
2084 * compress.cc: Refine includes. Remove placeholder function
2085 definitions. Make destructor an empty function.
2086 * compress.h: Refine includes. Make placeholder functions pure
2087 virtual. Add missing const on buffer argument to write function,
2088 to match derived classes.
2089 * compress_bz.cc, compress_gz.cc: Refine includes. Throw exception,
2090 rather than logging and returning an error, when an unimplemented
2091 function is called.
2092 * compress_bz.h, compress_gz.h: Refine includes.
2093
2b734ec7
MB
20942004-12-26 Max Bowsher <maxb@ukf.net>
2095
2096 The Big Cleanup: Phase "version"
2097
2098 * String++.h (operator std::string): Add.
2099 * desktop.cc, fromcwd.cc: Remove irrelevant include.
2100
2101 * version.cc, version.h: Delete, replacing all functionality in new
2102 files.
2103
2104 * setup_version.h: Add, taking over declaration of generated version
2105 symbol functionality.
2106
2107 * Makefile.am (setup_SOURCES): Sync with new/deleted files.
2108 (setup_version.c): Rename the symbol 'version' to 'setup_version'.
2109 * main.cc: Modify includes.
2110 (main): Adapt to setup_version rename.
2111 * splash.cc: Modify includes.
2112 (SplashPage::OnInit): Adapt to setup_version rename.
2113
2114 * csu_util/version_compare.cc, csu_util/version_compare.h: Add,
2115 containing a completely rewritten replacement for canonical_version().
2116
2117 * IniDBBuilderPackage.cc: Modify includes.
2118 (IniDBBuilderPackage::buildVersion): Use new version_compare API.
2119 * ini.cc: Modify includes.
2120 (setup_version): Rename...
2121 (ini_setup_version): ...to this.
2122 (do_local_ini, do_remote_ini): Adapt to above change.
2123 (do_ini_thread): Adapt to above change. Use new version_compare API.
2124
0f45aabe
MB
21252004-12-25 Max Bowsher <maxb@ukf.net>
2126
2127 * install.cc (Installer::installOneSource): Remove a stray "break;"
2128 left over from the switch-case -> if-else conversion in the previous
2129 change.
2130
4875ac88
MB
21312004-12-25 Max Bowsher <maxb@ukf.net>
2132
2133 The Big Cleanup: Phase "win32"
2134
2135 * win32.h: Major overhaul. Document why we use _WIN32_IE. Move out
2136 fragment dealing with alloca() to the single file in which it is used.
2137 Remove fragment dealing with _MAX_PATH, and convert all uses of it
2138 elsewhere to MAX_PATH. Remove random include of <stdarg.h>. Remove
2139 NOCOMATTRIBUTE, as setup contains no code which it affects. Remove
2140 includes of <wininet.h> and <windowsx.h> - see later in this log.
2141 (IsWindowsNT): New inline function, a much simpler implementation of
2142 Win32::OS().
2143
2144 * win32.cc: Delete.
2145
2146 * Makefile.am (setup_SOURCES): Remove "win32.cc".
2147
2148 * AntiVirus.cc (detect), PickPackageLine.cc (PickPackageLine::paint),
2149 * install.c (Installer::installOneSource):
2150 Use IsWindowsNT(), not Win32::OS().
2151 * main.cc (main): Use IsWindowsNT(), not locally defined iswinnt.
2152
2153 * PickView.cc (PickView::WindowProc), netio.cc (auth_proc),
2154 * proppage.cc (PropertyPage::DialogProc):
2155 Avoid using obfuscating macros from <windowsx.h>.
2156
2157 * archive.cc: Include or #define alloca() in the only file in which
2158 it is used.
2159
2160 * nio-ie5.h: Include <wininet.h> here, where it is actually needed,
2161 rather than in "win32.h" which is included almost everywhere.
2162
2163 * archive_tar.cc, archive_tar.h, cygpackage.cc, cygpackage.h,
2164 * desktop.cc, find.cc, install.cc, main.cc, mklink2.c, mount.cc,
2165 * script.cc: Use MAX_PATH, not _MAX_PATH.
2166
f4a981ab
MB
21672004-12-25 Max Bowsher <maxb@ukf.net>
2168
2169 Remove some overcomplications.
2170
2171 * Makefile.am (setup_SOURCES): Remove FilterVisitor.{cc,h}.
2172 * FilterVisitor.cc, FilterVisitor.h: Delete.
2173 * String++.cc (strmatch, String::matches): Remove.
2174 * String++.h (String::matches): Remove.
2175 * postinstall.cc: Do not include "FilterVisitor.h".
2176 (RunFindVisitor): Exclude items with the extension ".done".
2177 (do_postinstall_thread): Remove overcomplicated exclusion of items
2178 with the extension ".done".
2179
768d880e
MB
21802004-12-24 Max Bowsher <maxb@ukf.net>
2181
2182 * String++.cc, String++.h: Remove unused and incomplete code.
2183 * LogFile.cc (LogFile::log_save): Don't leak memory.
2184 * filemanip.cc, geturl.cc, root.cc, version.cc:
2185 Don't pointlessly create temporary copies strings.
2186
db165a9a
MB
21872004-12-23 Max Bowsher <maxb@ukf.net>
2188
2189 * choose.cc (ChooserPage::OnNext): Relegate some overly verbose
2190 logging to an #ifdef DEBUG section.
2191 * geturl.h (dismiss_url_status_dialog): Remove stale function
2192 declaration, for which there is no definition.
2193 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
2194 Motivated by the recent unexplained hang bug, add some extra logging.
2195
0229b1d7
MB
21962004-11-22 Max Bowsher <maxb@ukf.net>
2197
2198 * MD5++.cc, MD5++.h: Remove this class.
2199 * csu_util/MD5Sum.cc, csu_util/MD5Sum.h: New more complete MD5 class.
2200 * Makefile.am (setup_SOURCES): Adjust to new files.
2201 * download.cc (validateCachedPackage): Simplify, using the new class.
2202 * install.cc (md5_one): Ditto.
2203 * package_source.h (packagesource::md5): Change to be an object of the
2204 new class.
2205
2c4261a8
MB
22062004-11-22 Max Bowsher <maxb@ukf.net>
2207
ba102d1c
MB
2208 * main.cc (main): Fix bug in one of the 2004-11-19 commits.
2209 Avoid referring to the theLog pointer before it is set.
2c4261a8 2210
9132ff16
MB
22112004-11-20 Max Bowsher <maxb@ukf.net>
2212
2213 * res.rc (IDD_SOURCE): Clarify the radio-button option descriptions.
2214 Re-layout the radio buttons.
2215
6beebaa3
MB
22162004-11-20 Max Bowsher <maxb@ukf.net>
2217
2218 Repair the broken detection of wrongly-sized package files.
2219
2220 * download.cc (validateCachedPackage): Make static, since not used
2221 elsewhere. Improve logging. Migrate file-size tests to here, alongside
2222 the MD5 tests.
2223 (check_for_cached): Remove broken testing of file-size, now covered by
2224 the above. Code cleanups.
2225
54ff37c8
MB
22262004-11-19 Max Bowsher <maxb@ukf.net>
2227
2228 * package_version.cc (dumpAndList): Make dependencies much more
2229 readable in full log output.
2230
4d7a6eeb
MB
22312004-11-19 Max Bowsher <maxb@ukf.net>
2232
2233 * proppage.cc (PropertyPage::DialogProc): Wrap in a TOPLEVEL_CATCH
2234 block, since allowing exceptions to unwind into the guts of Windows is
2235 quite disasterous.
2236
c66b9174
MB
22372004-11-19 Max Bowsher <maxb@ukf.net>
2238
2239 * main.cc (main): Move option parsing code earlier - it must execute
2240 before any significant object creations, which might test options in
2241 their initialization.
2242
82b64f8a
MB
22432004-11-19 Max Bowsher <maxb@ukf.net>
2244
2245 * main.cc (main): Remove some junk code - either commented out, or
2246 contained within unreachable preprocessor conditional sections.
2247
4fa49408
MB
22482004-11-19 Max Bowsher <maxb@ukf.net>
2249
2250 * install.cc (Installer::installOneSource): Avoid leaking the open
2251 file handles of every tarball that is installed.
2252
0e9a5c4f
MB
22532004-11-19 Max Bowsher <maxb@ukf.net>
2254
2255 * package_source.h (packagesource::Canonical, packagesource::Base)
2256 (packagesource::Filename): Add "const" specification to accessor
2257 methods.
2258
6b68e703
MB
22592004-11-18 Max Bowsher <maxb@ukf.net>
2260
2261 * archive.h (archive::~archive): Define a pure virtual destructor to
2262 enforce the abstract nature of this class.
2263 * archive.cc (archive::~archive): Pure virtual destructors require an
2264 implementation! Add one.
2265 * io_stream.h (io_stream::destroyed): Remove this severely
2266 brain-damaged implementation of a weakly-enforced abstract class.
2267 The pure virtual destructor was strongly enforcing the abstract nature
2268 anyway.
2269 * io_stream.cc (io_stream::~io_stream): Empty out horribly pointless
2270 code from the pure virtual destructor.
2271 * archive_tar.cc (archive_tar::~archive_tar): Remove all
2272 reference to the removed "destroyed" member.
2273 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
2274 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
2275 * compress_gz.cc (compress_gz::~compress_gz): Ditto.
2276 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Ditto.
2277 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
2278 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
2279
51200ef2
MB
22802004-11-17 Max Bowsher <maxb@ukf.net>
2281
2282 * mount.cc (create_mount): Fix operator precedence error introduced in
2283 first 2004-11-11 commit - warned of by gcc 3.3.3 but not 3.4.1 !
2284
f5d45c3b
MB
22852004-11-13 Max Bowsher <maxb@ukf.net>
2286
2287 Miscellaneous cleanup.
2288
2289 * geturl.cc (getUrlToStream): Make static.
2290 * geturl.h (getUrlToStream): Remove declaration.
2291
2292 * geturl.cc, geturl.h, netio.cc, netio.h, nio-ftp.cc, nio-ftp.h,
2293 nio-http.cc, nio-http.h:
2294 Remove unused "allow_ftp_auth" flag throughout.
2295
f4d80c3f
MB
22962004-11-11 Max Bowsher <maxb@ukf.net>
2297
2298 * libmd5-rfc: New directory, to hold code imported from the libmd5-rfc
2299 project in a clearly delineated fashion.
2300 * libmd5-rfc/README: New file.
2301 * md5.c, md5.h: Delete...
2302 * libmd5-rfc/md5.c, libmd5-rfc/md5.h: ...and replace with pristine
2303 versions from upstream (only change is restoration of upstream CVS
2304 keyword expansions).
2305 * libmd5-rfc/md5main.c: New file.
2306 * Makefile.ami (setup_SOURCES): Edit file paths.
2307 * download.cc, install.cc: Edit include paths.
2308
68d49419
MB
23092004-11-11 Max Bowsher <maxb@ukf.net>
2310
2311 * dialog.cc (fatal): Make capable of handling a passed-in error code,
2312 as an alternative to calling GetLastError().
2313 * dialog.h (fatal): Adjust prototype as above.
2314 * mount.cc (create_mount): Use the above to correctly report errors.
2315
af111c7d
MB
23162004-10-28 Max Bowsher <maxb@ukf.net>
2317
2318 * LogFile.cc (LogFile::getFileName), splash.cc (SplashPage::Create),
2319 threebar.cc (ThreeBarProgressPage::SetBar2):
2320 Migrate from cistring and string resources
2321 to String and string literals.
2322 * localdir.cc: Remove unneeded #include of "cistring.h".
2323 * cistring.cc, cistring.h: Remove this now-redundant class.
2324 * Makefile.am: Remove mention of the above removed files.
2325 * res.rc, resource.h: Remove obsolete strings and IDs, both those
2326 obseleted by and obselete before the above changes.
2327 * res.rc: Merge the 2 adjacent STRINGTABLEs.
2328
8a264069
MB
23292004-10-27 Max Bowsher <maxb@ukf.net>
2330
2331 * Makefile.am (setup_SOURCES): Add "RECTWrapper.h". It was missing.
2332
b4b8ab8d
MB
23332004-10-25 Bas van Gompel <cygsup-patch.buzz@bavag.tmfweb.nl>
2334
2335 * package_source.cc (packagesource::set_canonical):
2336 Fix one-off in 'base' when ini is in same dir as package.
2337
49560a44
MB
23382004-10-25 Max Bowsher <maxb@ukf.net>
2339
2340 * main.cc (next_dialog): Remove this legacy global variable.
2341 * download.cc (do_download_thread): Return a value instead of setting
2342 a global variable, then returning void.
2343 (do_download_reflector): Look for the next dialog code as a return
2344 value instead of a global variable.
2345
99ff5a8b
MB
23462004-10-25 Max Bowsher <maxb@ukf.net>
2347
2348 * port.h: Remove this redundant file - all contained definitions are
2349 duplicated in "win32.h".
2350 * Makefile.am, UserSetting.cc, UserSettings.cc, archive.cc,
2351 archive_tar.cc, archive_tar_file.cc, choose.cc, compress.cc,
2352 compress_bz.cc, compress_gz.cc, desktop.cc, find.cc, fromcwd.cc,
2353 iniparse.y, install.cc, io_stream_cygfile.cc, io_stream_file.cc,
2354 main.cc, netio.cc, site.cc, version.cc:
2355 Remove all references to "port.h".
2356
46d04e97
MB
23572004-10-25 Max Bowsher <maxb@ukf.net>
2358
2359 Fix compilation with w32api 3.1 and later.
2360
2361 * ControlAdjuster.h, RECTWrapper.h, cistring.h, propsheet.h,
2362 window.cc, window.h: Include "win32.h" not <windows.h> directly.
2363 * win32.h (WINBASEAPI): Define to empty string.
2364
5524909e
IP
23652004-09-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2366
2367 * script.cc (run): Kill stdin when running scripts.
2368
84b9cc5e
MB
23692004-09-01 Max Bowsher <maxb@ukf.net>
2370
2371 * Makefile.am: Oops. Unwanted keyword expansion ate the code of the
2372 previous commit. Restore the code, escaped to not look like a keyword.
2373
012374fe
MB
23742004-09-01 Max Bowsher <maxb@ukf.net>
2375
2376 * Makefile.am: Simplify the shell incantation for getting the revision
2377 of ChangeLog from grep-and-sed to just sed.
2378
b4113ac0
MB
23792004-08-31 Max Bowsher <maxb@ukf.net>
2380
2381 Attain GCC 3.4 compatibility.
2382
2383 * PackageSpecification.h (PackageSpecification): Make the
2384 unnecessarily private copy-constructor public.
2385
fc2ba841
MB
23862004-08-30 Max Bowsher <maxb@ukf.net>
2387
2388 Rework the implementation of not including -Werror for specific files,
2389 to a way that does not require hardcoding modified automake output back
2390 into its input.
2391
2392 * Makefile.am (AM_CXXFLAGS, BASECXXFLAGS): Seperate out -Werror.
2393 (autoload.o): Drop this rule, -finline-functions is no longer required
2394 and -Werror is acceptable here now we have __attribute__ ((used)).
2395 (WARNONLY_CFLAGS, inilex.o): Drop these.
2396 (EXTRA_PROGRAMS): Add a fake "warnonly" program.
2397 (warnonly_CXXFLAGS): Set to the $(BASECXXFLAGS).
2398 (warnonly_SOURCES): Set to "inilex.cc".
2399 (EXTRA_setup_SOURCES): Set to $(warnonly_SOURCES).
2400 (setup_SOURCES): Remove "inilex.cc".
2401 (setup_LDADD): Add "warnonly-inilex.o".
2402
d3c2a043
MB
24032004-08-30 Max Bowsher <maxb@ukf.net>
2404
2405 Move closer to GCC 3.4 compatibility.
2406
2407 * IOStreamProvider.h, io_stream_cygfile.cc, io_stream_cygfile.h,
2408 io_stream_file.cc: Do not incorrectly use "enum" after it has been
2409 hidden inside a typedef.
2410 * archive.h: In "virtual func() = 0;", the 0 is a language construct,
2411 not some symbol that might evaluate to 0, and gcc 3.4 enforces this.
2412 * autoload.c (DllInfo.name): Silence warning by making const.
2413 (DLL, autoload_common): __attribute__ ((used)) is now required to
2414 prevent gcc being over-eager in it's optimization, and removing these
2415 seemingly-unused (used only from assembly) functions.
2416 Silences some warnings, too.
2417 * Makefile.am (AM_CXXFLAGS, AM_CFLAGS): The options
2418 -Wstrict-prototypes -Wmissing-prototypes do not apply to C++ and
2419 g++ 3.4 complains about them.
2420
072fb49a
MB
24212004-08-29 Max Bowsher <maxb@ukf.net>
2422
ca2b7505 2423 * Exception.h: Reformatting, #include more, remove incorrect and
072fb49a
MB
2424 less-than-useful comments.
2425 (TOPLEVEL_CATCH): New preprocessor macro.
2426
2427 * LogFile.cc (LogFile::operator()): Throw an exception object, not a
2428 char* string.
2429
2430 Wrap the top-level of each thread (including the main thread) in a
2431 try...catch block, in order to display a useful error message if an
2432 exception is not caught.
2433 * download.cc (do_download_reflector): Here ...
2434 * ini.cc (do_ini_thread_reflector): ... and here ...
2435 * install.cc (do_install_reflector: ... and here ...
2436 * main.cc (main): ... and here ...
2437 * postinstall.cc (do_postinstall_thread): ... and here ...
2438 * site.cc (do_download_site_info_thread): ... and here!
2439
2440 * msg.h: Include a missing header requirement.
2441 * res.rc (IDS_UNCAUGHT_EXCEPTION, IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO):
2442 New strings.
2443 * resource.h (IDS_UNCAUGHT_EXCEPTION)
2444 (IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO): New IDs.
2445
56c41dda
MB
24462004-08-28 Max Bowsher <maxb@ukf.net>
2447
2448 * res.rc (IDS_WINDOW_INIT_BADMSG): New string.
2449 * resource.h (IDS_WINDOW_INIT_BADMSG): New string resource ID.
2450 * window.cc (Window::FirstWindowProcReflector): Convert an abort()
2451 into a descriptive error.
2452
abdd4b38
MB
24532004-08-24 Max Bowsher <maxb@ukf.net>
2454
2455 The Doug Lee replacement malloc was no longer hooked up with the
2456 buildsystem in any way. Pruning the remaining unused file.
2457
2458 * dlmalloc.c: Removed.
2459
24649384
MB
24602004-08-18 Max Bowsher <maxb@ukf.net>
2461
ca2b7505 2462 "librsync is not wire-compatible with rsync 2.x, and is not likely
24649384
MB
2463 to be in the future." -- librsync.sourceforge.net
2464
2465 So, it is of no practical use to setup. Therefore, removing all
2466 rsync related files and code from setup.
2467
2468 * rsync: Directory removed.
2469 * Makefile.am: Remove rsync support from the buildsystem.
2470 * configure.in: Ditto.
2471 * README: Since it seems vanishingly unlikely that it will ever happen,
2472 remove rsync support from the wishlist.
2473 * io_stream_rsync.cc: Remove.
2474 * io_stream_rsync.h: Remove.
2475
2800a92a
RC
24762004-04-25 Robert Collins <rbtcollins@hotmail.com>
2477
24649384
MB
2478 * package_meta.cc (packagemeta::set_requirements): fix problem with
2479 libpcre0 not being pulled in automatically.
2800a92a 2480
304e9816
RC
24812004-04-25 Robert Collins <rbtcollins@hotmail.com>
2482
24649384
MB
2483 * IniDBBuilderPackage.cc (dumpAndList):
2484 Move out to packageversion for reuse.
304e9816 2485 * package_meta.cc (packagemeta::logAllVersions): log dependencies.
24649384
MB
2486 * package_version.cc (packageversion::depends):
2487 provide a const accessor.
304e9816
RC
2488 (dumpAndList): Moved from INIDBBuilder.cc.
2489 * package_version.h: declare new method and function.
2490
5419ce48
RC
24912003-12-21 Robert Collins <rbtcollins@hotmail.com>
2492
2493 * main.cc (main): Update to head libgetopt++ syntax.
2494
201741b7
RC
24952003-11-2 Robert Collins <rbtcollins@hotmail.com>
2496
2497 * ControlAdjuster.h (ControlPosition::CP_MIDDLE): Rename to
2498 CP_CENTERED.
2499 * ControlAdjuster.cc: Ditto.
2500
081bf320
RC
25012003-10-31 Frank Richter <frichter@gmx.li>
2502
ca2b7505
CF
2503 * localdir.cc (OnNext): When SelectDirectoryA() fails, display a
2504 message with the error returned from the system instead of just
081bf320
RC
2505 'could not change dir'. Also, offer the user to 'Retry', 'Ignore' the
2506 error or 'Abort' the directory change.
2507
4b6e5406
RC
25082003-10-31 Frank Richter <frichter@gmx.li>
2509
2510 * propsheet.cc (PropSheetWndProc): Don't do child resizing if a the
2511 window gets minimized. Otherwise some glitches (e.g. wrong child
2512 sizes) occur.
2513 Added support for WM_GETMINMAXINFO. Prevents the property sheet from
2514 getting smaller than the original size.
2515
576a2b0b
RC
25162003-11-1 Robert Collins <rbtcollins@hotmail.com>
2517
2518 * ControlAdjuster.h (ControlDimension): Add.
2519 (ControlAdjuster): Factor adjust functionality into ControlInfo.
2520 * ControlAdjuster.cc (ControlAdjuster::adjust): Ditto.
2521 (ControlAdjuster::ControlInfo::adjust): Ditto.
2522
a8d753b6
RC
25232003-10-31 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2524
2525 * ControlAdjuster.h (ControlPosition): New enum type.
2526 (ControlInfo::horizontalPos, ControlInfo::verticalPos): New
2527 instance variables.
2528 (ControlInfo::anchorLeft, ControlInfo::anchorTop,
2529 ControlInfo::anchorRight, ControlInfo::anchorBottom): Remove.
2530 * ControlAdjuster.cc (ControlAdjuster::AdjustControls): Switch to
2531 using position specifiers instead of anchors.
2532 * choose.cc (ChooserControlsInfo): Ditto.
2533 * proppage.cc (DefaultControlsInfo): Ditto.
2534 * propsheet.cc (PropSheetControlsInfo): Ditto.
2535 * site.cc (SiteControlsInfo): Position specifiers for site
2536 selection dialog controls.
2537 * threebar.cc (ThreeBarControlsInfo): Position specifiers for
2538 progress dialog controls.
2539
c9feb168
RC
25402003-10-27 Ralf Habacker <ralf.habacker@freenet.de>
2541
2542 * main.cc (HelpOption): New instance.
2543 (main): Added help command line option handling.
2544 * localdir.cc (LocalDirOption): New instance.
2545 (LocalDirSetting::load): allow setting localdir from command line.
2546
ee91d9be
RC
25472003-10-16 Frank Richter <frichter@gmx.li>
2548
ca2b7505
CF
2549 * ControlAdjuster.cc: New file, helper to move elements of a dialog
2550 along when the it's resized.
ee91d9be
RC
2551 * ControlAdjuster.h: Ditto.
2552 * Makefile.am: Add new source files.
2553 * proppage.cc (PropertyPage::DialogProc): Adjust some common
2554 controls (Cygwin icon top right, separator below) when a page is
2555 resized.
2556 (PropertyPage::PropertyPage): Dito.
2557 * propsheet.cc (IsDialog): New. Test whether a window is a dialog.
2558 Used internally by resize logic.
2559 (EnumPages): New. Used internally by resize logic: resizes the
2560 property sheet's individual pages.
2561 (PropSheetWndProc): New. Hook for the propery sheet window proc.
2562 (PropSheetProc): More style tweaks, add maximize box and thick border
2563 as well. Hook into the property sheet's window proc.
2564 (PropSheet::AdjustPageSize): New. Adjust the metrics of a single page
2565 to fit nicely into the property sheet. Part of resize logic.
2566 * res.rc (All dialogs): The top-right Cygwin icon and top separator
ca2b7505 2567 now have IDs distinct from IDC_STATIC, so their metrics can be
ee91d9be
RC
2568 adjusted upon a resize. Also, all those Cygwin icons are at the exact
2569 same spot now.
ca2b7505 2570 * choose.cc (ChooserPage::ChooserPage): Now the controls on the
ee91d9be
RC
2571 chooser page move/size when the page size is changed.
2572 * choose.h: Dito.
2573
1622a084
RC
25742003-10-23 Jerry D. Hedden <jerry@hedden.us>
2575
2576 * ConnectionSetting.cc (ConnectionSetting::load): Load proxysettings.
2577 (ConnectionSetting::save): Save proxy settings.
2578
7f6de8c0
RC
25792003-10-07 Robert Collins <rbtcollins@hotmail.com>
2580
2581 * proppage.h (PropertyPage::wantsActivation): const correctness fix.
2582
587a67fc
MB
25832003-08-19 Max Bowsher <maxb@ukf.net>
2584
2585 * win32.h: Define NOMINMAX only if not already defined - because
2586 libstdc++-v3 3.3.1 defines NOMINMAX itself.
2587
58b12a06
MB
25882003-08-03 Max Bowsher <maxb@ukf.net>
2589
2590 * ChangeLog: Fix broken line-wrapping throughout. Clarify that
2591 "Ran automake" in 2003-07-26 entry was in bz2lib and zlib subdirs.
2592
56a7c49e
MB
25932003-08-03 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2594
2595 * propsheet.cc (Copyright): Update copyright dates.
2596 (PropSheet::PropSheet): Remove NumPropPages initialization.
2597 (PropSheet::CreatePages): Use PropertyPages.size() instead of
2598 NumPropPages.
2599 (PropSheet::Create): Ditto.
2600 (PropSheet::AddPage): Change to use new PropertyPages std::vector<>.
2601 * propsheet.h (Copyright): Update copyright dates.
2602 (File Scope): Include <vector>.
2603 (PropSheet::PropertyPages): Change from array to vector<>.
2604 (PropSheet::NumPropPages): Remove.
2605
25130a4d
MB
26062003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2607
2608 Changes modified by Max Bowsher <maxb@ukf.net>
2609 * splash.cc (Copyright): Update copyright dates.
2610 (SplashPage::OnInit): Remove call to SetDlgItemFont(). Now handled in
2611 base class.
2612 * proppage.h (PropertyPage::setTitleFont): Declare.
2613 * proppage.cc (Copyright): Update copyright dates.
2614 (PropertyPage::DialogProc WM_INITDIALOG): Move all font setting code,
2615 including that from splash.cc into new function...
2616 (PropertyPage::setTitleFont): Create, using moved code. Change font
2617 "MS Sans Serif" to "MS Shell Dlg" in line with recent res.rc change.
2618 Set font for IDC_STATIC_WELCOME_TITLE here, to allow easy re-use of
2619 style for future "Finished" page.
2620
62489576
MB
26212003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2622
2623 * propsheet.cc: Include "resource.h".
2624 (PropSheet::Create): Add the Cygwin icon in the left of the title bar.
2625
106d8160
MB
26262003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2627
2628 * proppage.cc (PropertyPage::FirstDialogProcReflector): Modify comment.
2629
5296fc07
MB
26302003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2631
2632 * proppage.h (Copyright): Update copyright dates.
2633 (PropertyPage): Document OnNext and OnBack.
2634
5039f845
MB
26352003-07-31 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2636
2637 * proppage.cc (PropertyPage::Create): Use more self-documenting
2638 MAKEINTRESOURCE() instead of cast to LPCSTR.
2639
672d28ad
RC
26402003-07-31 Robert Collins <rbtcollins@hotmail.com>
2641
2642 * README: Mark completed items complete.
2643
c59b8da6
MB
26442003-07-31 Pierre Humblet <pierre.humblet@ieee.org>
2645
2646 * main.cc (set_default_sec): Set token owner from token user.
2647 Always try to set the token primary group to Users or Admins.
2648
25e21380
IP
26492003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2650
2651 * String++.h (String::replace): New instance functions.
2652 * String++.cc (String::replace): Implement.
2653 * filemanip.cc (backslash): Change to use String::replace.
2654 * desktop.cc (make_cygwin_bat): Escape '%' in path.
2655
346627e7
IP
26562003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2657
2658 * String++.h (TOSTRING): New macro.
2659 * UserSettings.cc (UserSettings::deRegisterSetting): Fix
2660 erroneous __LINE__/__FILE__ usage.
2661 * download.cc (validateCachedPackage, check_for_cached): Ditto.
2662 * geturl.cc (getUrlToStream): Ditto.
2663 * install.cc (md5_one): Ditto.
2664
d9f4a2ba
MB
26652003-07-30 Max Bowsher <maxb@ukf.net>
2666
2667 * ini.cc (do_ini_thread): Return bool.
2668 (do_ini_thread_reflector): Put returned bool in lParam.
2669 * threebar.cc (WM_APP_SETUP_INI_DOWNLOAD_COMPLETE): Rework for new
2670 meaning of lParam. Replace erroneous use of do_fromcwd with
2671 SetActivePageByID (IDD_SOURCE).
2672
39b42ff3
RC
26732003-07-30 Robert Collins <rbtcollins@hotmail.com>
2674
2675 * ConnectionSetting.cc: New file, persist connection type selection.
2676 * ConnectionSetting.h: Ditto.
2677 * net.cc: Hold a ConnectionSetting instance to trigger the logic.
2678 (NetPage::OnInit): Don't force net_method to any value.
2679 * Makefile.am: Add new source files.
2680
6ff96351
RC
26812003-07-30 Robert Collins <rbtcollins@hotmail.com>
2682
2683 * SourceSetting.cc: New file, persist source selection.
2684 * SourceSetting.h: Ditto.
2685 * source.cc: Hold a Source setting instance to trigger the logic.
2686 * Makefile.am: Add new source files.
2687
f0fd8856
RC
26882003-07-30 Robert Collins <rbtcollins@hotmail.com>
2689
2690 * UserSettings.h (UserSettings::settingFileForLoad): Extracted method
2691 from LocalDirSetting::load().
2692 * UserSettings.cc (UserSettings::settingFileForLoad): Ditto.
2693 * UserSettings.h (UserSettings::settingFileForSave): Extracted method
2694 from LocalDirSetting::save().
2695 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
2696 * localdir.cc (LocalDirSetting::load): Extract location logic to
2697 UserSettings.
2698 (LocalDirSetting::save): Extract location logic to UserSettings.
2699 * site.cc (SiteSetting::getSavedSites): Use
2700 UserSettings::settingFileForLoad.
2701 (SiteSetting::save): Use UserSettings::settingFileForSave.
2702
bb8e2353
RC
27032003-07-30 Robert Collins <rbtcollins@hotmail.com>
2704
ca2b7505 2705 * PickView.cc: Adjust ::GetClientRect(..) to the inherited one
bb8e2353
RC
2706 throughout.
2707
b28e9f01
MB
27082003-07-29 Max Bowsher <maxb@ukf.net>
2709
2710 Based on a patch by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
2711 * AntiVirus.cc (AntiVirusPage::wantsActivation): Define.
2712 * AntiVirus.h (AntiVirusPage::wantsActivation): Declare.
2713 * localdir.cc (LocalDirPage::OnBack): Remove logic subsumed by
2714 RootPage::wantsActivation.
2715 * proppage.cc (PropertyPage::DialogProc): Call wantsActivation(),
2716 and skip to next page in sequence if activation is refused.
2717 * proppage.h (PropertyPage::wantsActivation): Default implementation.
2718 * root.cc (RootPage::wantsActivation): Define.
2719 * root.h (RootPage::wantsActivation): Declare.
2720 * source.cc: Don't include "AntiVirus.h".
2721 (SourcePage::OnNext): Remove logic subsumed by
2722 RootPage::wantsActivation.
2723 (SourcePage::OnBack): Remove logic subsumed by
2724 AntiVirusPage::wantsActivation.
2725 * splash.cc: Don't include "AntiVirus.h" or "dialog.h".
2726 (SplashPage::OnNext): Remove - subsumed by
2727 AntiVirusPage::wantsActivation.
2728 * splash.h (SplashPage::OnNext): Remove declaration.
2729
ec2dbbf0
RC
27302003-07-29 Robert Collins <rbtcollins@hotmail.com>
2731
2732 * PickView.h (PickView::refresh): New method.
2733 * PickView.cc (PickView::refresh): Extracted from various
2734 ChooserPage callers.
2735 * choose.cc: Use PickView::refresh wherever possible.
2736
bc16bb7d
RC
27372003-07-29 Robert Collins <rbtcollins@hotmail.com>
2738
2739 * choose.h (ChooserPage::createListView): Remove last parameter.
2740 (ChooserPage::getDefaultListViewSize): Extracted method.
2741 * choose.cc (ChooserPage::createListView): Remove last parameter.
2742 (ChooserPage::getDefaultListViewSize): Extracted method.
2743
952ea3fe
RC
27442003-07-29 Robert Collins <rbtcollins@hotmail.com>
2745
ca2b7505 2746 * choose.cc (ChooserPage::createListView): Remove unneeded
952ea3fe
RC
2747 parameter.
2748 * choose.h: Ditto.
2749
55c6e691
MB
27502003-07-29 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2751
2752 * dialog.h (do_fromcwd): Change function declaration.
2753 * fromcwd.cc (do_fromcwd): Change return type to bool. Eliminate
2754 use of next_dialog, return true or false instead.
2755 * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
2756 value instead of next_dialog.
2757
2f18f94d
RC
27582003-07-29 Robert Collins <rbtcollins@hotmail.com>
2759
2760 * package_db.h (packagedb::fillMissingCategory): Move from ChooserPage.
2761 * choose.h (ChooserPage::fillMissingCategory): Delete.
2762 * package_db.cc (packagedb::fillMissingCategory): Move from ChooserPage.
ca2b7505 2763 * choose.cc (ChooserPage::fillMissingCategory): Delete and adjust
2f18f94d
RC
2764 callers.
2765
525531ca
RC
27662003-07-29 Robert Collins <rbtcollins@hotmail.com>
2767
2768 * PickView.h (CATEGORY_EXPANDED): Move from choose.h
2769 (CATEGORY_COLLAPSED): Move from choose.cc.
2770 (PickView::setViewMode): Move from ChooserPage.
2771 * choose.h (CATEGORY_EXPANDED): Delete.
2772 (CATEGORY_COLLAPSED): Delete.
2773 (ChooserPage::setViewMode): Delete.
2774 * PickView.cc (PickView::setViewMode): Move from ChooserPage.
2775 * chooser.cc (ChooserPage::setViewMode): Delete, and adjust callers
2776 throughout.
2777
0f61a6a4
MB
27782003-07-28 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2779
2780 * AntiVirus.cc (AntiVirusPage::OnNext): Do not explicitly specify the
2781 page to display next, since it follows in the default page ordering
2782 anyway.
2783
6d751ec8
MB
27842003-07-28 Max Bowsher <maxb@ukf.net>
2785
2786 * dialog.h: (NEXT): Remove obsolete macro.
2787 * site.cc (save_dialog): Remove use of NEXT(), and non-functional
2788 unnecessary error handler.
2789
358712d8
RC
27902003-07-28 Robert Collins <rbtcollins@hotmail.com>
2791
2792 * package_meta.h (packagemeta::addToCategoryAll): Declare.
ca2b7505 2793 * package_meta.cc (packagemeta::addToCategoryAll): New method,
358712d8
RC
2794 separated to allow clear iteration.
2795 * choose.cc (ChooserPage::fillMissingCategory): BUGFIX: "all" is
2796 meant to be added unconditionally.
2797
31f0ccce
RC
27982003-07-27 Robert Collins <rbtcollins@hotmail.com>
2799
2800 * Generic.h: New file, home for generic programming tools.
2801 (visit_if): Move here from package_meta.cc.
2802 Adjust to be fully parameterised.
ca2b7505 2803 * package_meta.h (packagemeta::hasNoCategories): Query for generic
31f0ccce
RC
2804 programming.
2805 (packagemeta::setDefaultCategories): set categories for packages
2806 with none.
ca2b7505 2807 * package_meta.cc: Move visit_if out. Adjust users for
31f0ccce
RC
2808 full paramterised operation.
2809 (packagemeta::hasNoCategories): Implement.
2810 (packagemeta::setDefaultCategories): Implement.
2811 * choose.cc (ChooserPage::fillMissingCategory): Use visit_if to
2812 reduce duplicate code.
2813 (ChooserPage::setExistence): Delete.
ca2b7505 2814 * choose.h (ChooserPage::setExistence): Rename to
31f0ccce
RC
2815 packagedb::setExistence.
2816 * package_db.h (packagedb::setExistence): Declare.
2817 * package_db.cc (packagedb::setExistence): Copy from choose.cc
2818
dbdc1d9d
RC
28192003-07-27 Robert Collins <rbtcollins@hotmail.com>
2820
2821 * localdir.h (LocalDirPage::OnInit): Remove.
2822 * localdir.cc (LocalDirPage::OnInit): Move to LocalDirSetting
2823 ::load().
2824 (LocalDirSetting::load): Copied from LocalDirPage::OnInit.
2825 * site.h (SitePage::OnInit): Remove.
2826 (SitePage::getSavedSites): New member, replaces get_saved_sites.
ca2b7505 2827 (SitePage::registerSavedSite): New member, replaces
dbdc1d9d
RC
2828 register_saved_site.
2829 * site.cc (SitePage::OnInit): Move to SiteSetting::load().
2830 (SiteSetting::load): Copied from SitePage::OnInit.
2831 (SitePage::getSavedSites): Renamed from get_saved_sites.
2832 (SitePage::registerSavedSite): Renamed from register_saved_site.
2833 (do_download_site_info_thread): Don't look at the list size for
2834 determining if the download was successful.
2835
22120c90
RC
28362003-07-27 Robert Collins <rbtcollins@hotmail.com>
2837
ca2b7505 2838 * choose.h (ChooserPage::setViewMode): Remove HWND from
22120c90
RC
2839 signature.
2840 (ChooserPage::defaultTrust): Ditto.
2841 Move to PickView.
ca2b7505 2842 (ChooserPage::ifChecked): Use Window helper function
22120c90
RC
2843 IsButtonChecked.
2844 * choose.cc (ChooserPage::setViewMode): Use chooser->GetHWND()
2845 throughout.
2846 Update all callers with new signature.
2847 (ChooserPage::defaultTrust): Ditto.
2848 Move to PickView.
2849 * PickView.h (PickView::defaultTrust): Declare.
2850 * PickView.cc (PickView::defaultTrust): Copy from chooser.cc.
2851
9c9cfce7
RC
28522003-07-27 Robert Collins <rbtcollins@hotmail.com>
2853
2854 * PickView.h (PickView::lv): Eliminate.
2855 * PickView.cc (PickView::init): Replace use of lv with
2856 GetHWND().
ca2b7505 2857 (PickView::list_click): Ditto.
9c9cfce7
RC
2858 * choose.h (ChooserPage::lv): Eliminate.
2859 * choose.cc: Replace lv with chooser->GetHWND()
2860 throughout.
2861
d2be933d
RC
28622003-07-27 Robert Collins <rbtcollins@hotmail.com>
2863
2864 * PickView.h (PickView::chooser): Eliminate.
2865 (PickView::list_vscroll): Make non-static.
2866 (PickView::list_hscroll): Ditto.
2867 (PickView::list_click): Ditto.
2868 (PickView::paint): Ditto.
2869 * PickView.cc (PickView::list_vscroll): Eliminate use
2870 of PickView::chooser.
2871 (PickView::list_hscroll): Ditto.
2872 (PickView::list_click): Ditto.
2873 (PickView::paint): Ditto.
2874 * choose.cc (Chooser::createListView): Eliminate use
2875 of PickView::chooser.
2876
693916f8
RC
28772003-07-27 Robert Collins <rbtcollins@hotmail.com>
2878
2879 * PickView.h (PickView): Inherit from Window.
2880 (PickView::RegisterWindows): Move from ChooserPage.
2881 (PickView::listview_proc): Likewise.
2882 (PickView::paint): Ditto.
2883 (PickView::list_click): Ditto.
2884 (PickView::list_hscroll): Ditto.
2885 (PickView::list_vscroll): Ditto.
2886 (PickView::lv): Ditto.
2887 (PickView::chooser): Ditto.
2888 (PickView::Create): Override Windows::Create as we migrate.
2889 (PickView::registerWindowClass): Renamed RegisterWindows.
2890 (PickView::WindowClassAtom): Prevent double registration.
2891 (PickView::init): Declare.
2892 * PickView.cc: Adjust for new inheritance.
2893 (PickView::RegisterWindows): Move from ChooserPage.
2894 (PickView::listview_proc): Likewise.
2895 (PickView::paint): Ditto.
2896 (PickView::list_click): Ditto.
2897 (PickView::list_hscroll): Ditto.
2898 (PickView::list_vscroll): Ditto.
2899 (PickView::lv): Ditto.
2900 (PickView::chooser): Ditto.
2901 (PickView::Create): Introduce stub.
2902 (PickView::RegisterWindows): Rename
2903 (PickView::init): Extracted from constructor to allow
2904 reordering.
ca2b7505 2905 * chooser.h (ChooserPage::registerWindows): Rename to
693916f8
RC
2906 PickView::RegisterWindows.
2907 (ChooserPage::listview_proc): Likewise.
2908 (ChooserPage::paint): Ditto.
2909 (ChooserPage::list_click): Ditto.
2910 (ChooserPage::list_hscroll): Ditto.
2911 (ChooserPage::list_vscroll): Ditto.
ca2b7505 2912 (ChooserPage::lv): Duplicate into PickView, observe
693916f8
RC
2913 as non-static.
2914 (ChooserPage::chooser): Ditto.
2915 * chooser.cc (ChooserPage::registerWindows): Delete.
2916 (ChooserPage::listview_proc): Ditto.
2917 (ChooserPage::paint): Ditto.
2918 (ChooserPage::list_click): Ditto.
2919 (ChooserPage::list_hscroll): Ditto.
2920 (ChooserPage::list_vscroll): Ditto.
2921 (ChooserPage::createListView): Create() on PickView.
ca2b7505 2922 * window.h (Window::RegisterWindowClass): Make virtual
693916f8
RC
2923 to allow Create to become a Template Method, and rename
2924 to registerWindowClass as it's not static.
2925 * window.cc (Window::registerWindowClass): Ditto.
2926 (Window::FirstWindowProcReflector): BUGFIX: Set window
2927 handle to prevent races with the window procedure.
2928
724c2956
RC
29292003-07-27 Robert Collins <rbtcollins@hotmail.com>
2930
2931 * choose.cc (set_view_mode): Rename to ChooserPage::setViewMode.
2932 (default_trust): Rename to ChooserPage::defaultTrust.
2933 (fill_missing_category): Rename to ChooserPage::fillMissingCategory.
2934 (set_existence): Rename to ChooserPage::setExistence.
2935 (register_windows): Rename to ChooserPage::registerWindows.
2936 (listview_proc): Rename to ChooserPage::listview_proc.
2937 (paint): Rename to ChooserPage::paint.
2938 (list_click): Rename to ChooserPage::list_click.
2939 (list_hscroll): Rename to ChooserPage::list_hscroll.
2940 (list_vscroll): Rename to ChooserPage::list_vscroll.
2941 (lv): Rename to ChooserPage::lv.
2942 (chooser): Rename to ChooserPage::chooser.
2943 * choose.h (ChooserPage::setViewMode): Declare.
2944 (ChooserPage::defaultTrust): Declare.
2945 (ChooserPage::fillMissingCategory): Declare.
2946 (ChooserPage::setExistence): Declare.
2947 (ChooserPage::registerWindows): Declare.
2948 (ChooserPage::listview_proc): Declare.
2949 (ChooserPage::paint): Declare.
2950 (ChooserPage::list_click): Declare.
2951 (ChooserPage::list_hscroll): Declare.
2952 (ChooserPage::list_vscroll): Declare.
2953 (ChooserPage::lv): Declare.
2954 (ChooserPage::chooser): Declare.
2955
d05ae76a
RC
29562003-07-27 Robert Collins <rbtcollins@hotmail.com>
2957
ca2b7505 2958 * choose.cc (create_listview): Use for_each instead of explicit
d05ae76a
RC
2959 iteration.
2960 (create_listview): Rename to ChooserPage::createListview.
2961 * package_meta.h (packagemeta::set_requirements): Explicitly separate
2962 the 1 and 2 parameter versions.
2963
29642003-07-27 Robert Collins <rbtcollins@hotmail.com>
69711722
RC
2965
2966 * String++.h (String::operator !=): Declare for char * and String.
2967 * String++.cc (String::operator !=): Implement.
2968 * package_meta.cc(StringConcatenator): Move above all users.
2969 (_visit_if): Predicate support for visitors.
ca2b7505 2970 (packagemeta::getReadableCategoryList): Refactor to use
69711722
RC
2971 StringConcatenator with a predicate.
2972 * choose.h: Remove unneeded c++ guards.
2973
cda26207
RC
29742003-07-26 Robert Collins <rbtcollins@hotmail.com>
2975
58b12a06
MB
2976 * choose.cc (scan_downloaded_files): Rename to
2977 packagemeta::ScanDownloadedFiles.
cda26207
RC
2978 (scanAVersion): Rename to packageversion::scan.
2979 (GetParentRect): Rename to ChooserPage::getParentRect.
2980 * choose.h (ChooserPage::getParentRect): Declare.
2981 * package_meta.h (packagemeta::ScanDownloadedFiles): Declare.
2982 * package_version.h (packageversion::scan): Declare.
2983 * package_version.cc (packageversion::scan): Move from choose.cc
58b12a06
MB
2984 * package_meta.cc (packagemeta::ScanDownloadedFiles): Move from
2985 choose.cc
cda26207 2986
edc3c6fc
RC
29872003-07-26 Robert Collins <rbtcollins@hotmail.com>
2988
2989 * choose.cc (ChooserPage::OnNext): log before starting activity threads.
2990 (ChooserPage::OnInit): Remove temporary variable frame.
2991 (ChooserPage::setPrompt): Extract method from OnInit.
2992 (choose_inst_text): Remove unused variable.
2993 * choose.h(ChooserPage::setPrompt): Declare
2994 * res.rc (IDD_CHOOSE): Bugfix: the chooser was setting a non-present
2995 caption.
2996
d55e14fe
RC
29972003-07-26 Robert Collins <rbtcollins@hotmail.com>
2998
2999 Remove package specific code from choose.cc.
3000 Update copyrights where appropriate.
3001 * choose.cc(ChooserPage::OnNext): Extract logging to
3002 packagemeta::logSelectionStatus.
3003 * package_meta.cc(packagemeta::logSelectionStatus): Extract from
3004 ChooserPage::OnNext.
3005 (StringConcatenator): helper for logSelectionStatus.
3006 (action_caption): Make const.
3007 * package_meta.h(packagemeta): Declare logSelectionStatus.
3008 (packagemeta::action_caption): Make const.
3009 * package_version.cc(packageversion::sourcePackage): Make const.
3010 * package_version.h(packageversion::sourcePackage): Make const.
3011
12f8ac69
RC
30122003-07-26 Robert Collins <rbtcollins@hotmail.com>
3013
3014 * choose.cc: Update copyright.
3015 (ChooserPage::keepClicked): Extracted from OnMessageCmd.
3016 (ChooserPage::changeTrust): Ditto.
3017 * choose.h (ChooserPage): Declare keepClicked and changeTrust.
3018 (ChooserPage::ifChecked): Extracted from OnMessageCmd.
58b12a06
MB
3019 * package_meta.h (SetRequirement): Adapter for visiting package
3020 collections.
12f8ac69 3021
93d7e783
MB
30222003-07-26 Max Bowsher <maxb@ukf.net>
3023
3024 * tests/.cvsignore: New file, listing Makefile.in.
3025
dea6cc21
RC
30262003-07-26 Robert Collins <rbtcollins@hotmail.com>
3027
3028 Save used local cache dir from initial run of setup, so the user doesn't
3029 need to retype it.
58b12a06
MB
3030 * localdir.h (LocalDirSetting): UserSetting class for the local cache
3031 dir.
3032 * localdir.cc (LocalDirSetting::save): Replace save_local_dir, and
3033 update callers.
dea6cc21 3034
0df9be37
RC
30352003-07-26 Robert Collins <rbtcollins@hotmail.com>
3036
ca2b7505 3037 Save used site from initial run of setup, so the user doesn't need to
0df9be37
RC
3038 retype it.
3039 * main.cc (main): Load and save all user settings.
3040 * site.cc (SiteSetting::save): Migrate logic from save_site_url.
58b12a06
MB
3041 (SitePage::OnNext): Use ChosenSites.save() to remove uneeded
3042 save_site_url call.
0df9be37
RC
3043 (save_site_url): Delete.
3044 * site.h (save_site_url): Remove declaration.
3045 * .cvsignore: Update autoconf generated files.
3046
bf137801
RC
30472003-07-26 Robert Collins <rbtcollins@hotmail.com>
3048
3049 * tests/Makefile.am: Driver for test suite.
3050 * tests/UserSettingTest.cc: Test UserSetting interface.
3051 * tests/UserSettingsTest.cc: Test UserSettings interface.
3052 * Makefile.am: Add the tests dir to recurse into.
3053 * configure.in: Ditto.
58b12a06
MB
3054 * UserSetting.h: Add load and save methods to allow global
3055 serialisation.
bf137801
RC
3056 Add explicit copy and assignment operators to prevent synthetics.
3057 Make the constructor protected to prevent direct instantiation.
3058 * UserSettings.h (UserSettings::loadAllSettings): New method.
3059 (UserSettings::savedAllSettings): New method.
3060 * UserSettings.cc: Implement new methods.
3061 * site.cc: Implement stubs for new required UserSetting methods.
3062 * site.h (ChosenSite): Ditto.
58b12a06
MB
3063 * bz2lib/: Ran automake.
3064 * zlib/: Ran automake.
bf137801 3065
3d5a4f16
MB
30662003-07-23 Max Bowsher <maxb@ukf.net>
3067
3068 * desktop.cc (DesktopSetupPage::OnBack): Remove obsolete use of NEXT().
3069 * root.cc (RootPage::OnNext): Ditto.
3070 (RootPage::OnBack): Ditto.
3071 * install.cc (do_install_thread): Remove obsolete use of next_dialog.
3072 * main.cc (main): Ditto.
3073 * postinstall.cc (do_postinstall_thread): Ditto.
3074
7108d406
MB
30752003-07-23 Max Bowsher <maxb@ukf.net>
3076
3077 * dialog.h (do_choose, do_desktop, do_local_dir, do_net, do_other)
3078 (do_root, do_site, do_source, do_splash): Remove declarations, since
3079 these functions no longer exist.
3080
b1c23913
MB
30812003-07-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3082
3083 * choose.cc (initialized): Remove obsolete file scope variable.
3084
d52a6cc8
MB
30852003-07-18 Max Bowsher <maxb@ukf.net>
3086
3087 * res.rc: Make caption of every dialog page begin with "Cygwin Setup".
3088 This aids recognition when minimized.
3089 Prompted by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
3090
9d53f045
MB
30912003-07-10 Jeremy White <jwhite@codeweavers.com>
3092
3093 * mount.cc, root.cc, site.cc: Make StringOptions required,
3094 thereby making --longopt <parm> behave as a newbie would expect.
3095
12e726c4
MB
30962003-07-08 Max Bowsher <maxb@ukf.net>
3097
3098 * LogFile.h, cistring.h, dialog.h, diskfull.h, filemanip.h, geturl.h,
3099 hash.h, log.h, mkdir.h, mklink2.h, mount.h, msg.h, netio.h, nio-file.h,
3100 nio-ftp.h, nio-http.h, nio-ie5.h, port.h, simpsock.h, state.h,
3101 version.h: Add inclusion guard.
3102 * root.h: Standardize naming of inclusion guard.
3103
c93bc6d0
MB
31042003-06-23 Max Bowsher <maxb@ukf.net>
3105
3106 * AntiVirus.h, Exception.h, FilterVisitor.h, FindVisitor.h,
3107 IOStreamProvider.h, IniDBBuilder.h, IniDBBuilderPackage.h,
3108 IniParseFeedback.h, IniParseFindVisitor.h, LogSingleton.h, MD5++.h,
3109 PackageSpecification.h, PackageTrust.h, PickCategoryLine.h, PickLine.h,
3110 PickPackageLine.h, PickView.h, RECTWrapper.h, ScanFindVisitor.h,
3111 String++.h, UserSetting.h, UserSettings.h, archive.h, archive_tar.h,
3112 category.h, choose.h, compress.h, compress_bz.h, compress_gz.h,
3113 cygpackage.h, desktop.h, download.h, find.h, ini.h, io_stream.h,
3114 io_stream_cygfile.h, io_stream_file.h, io_stream_memory.h,
3115 io_stream_rsync.h, localdir.h, net.h, package_db.h, package_meta.h,
3116 package_source.h, package_version.h, proppage.h, propsheet.h, script.h,
3117 site.h, source.h, splash.h, threebar.h, win32.h, window.h:
3118 Standardize naming and placement of inclusion guards.
3119
4a2af5fb
MB
31202003-06-22 Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>
3121
3122 * res.rc (all dialogs): Change font from "MS Sans Serif" to
3123 "MS Shell Dlg".
3124
8b726ef6
MB
31252003-06-22 Max Bowsher <maxb@ukf.net>
3126
3127 * Makefile.am: Clarify comment.
3128 Derive AM_CFLAGS from AM_CXXFLAGS, rather than the other way around.
3129 (AM_CXXFLAGS): Remove -Wmissing-declarations - it is a C-only warning.
3130 (AM_CFLAGS): Add -Winline, and -Wmissing-declarations.
3131
1e9ebf8a
MB
31322003-06-22 Max Bowsher <maxb@ukf.net>
3133
3134 * rfc1738.cc (rfc1738_do_escape): Eliminate redundant conditional.
3135
0a539fe4
MB
31362003-06-05 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3137
3138 * window.h (SETUP_WINDOW_H): Rename multi-include guard.
3139 (Copyright): Update.
3140 (RECTWrapper): New forward declaration.
3141 (Window::Create): Move.
3142 (Window::MoveWindow): New overload declaration.
3143 * window.cc: (RECTWrapper.h) Include.
3144 (Copyright): Update.
3145 (Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
3146 of C-style casts.
3147 (Window::MoveWindow): New overload.
3148
3c0ca7aa
MB
31492003-05-31 Max Bowsher <maxb@ukf.net>
3150
3151 * res.rc: Resize title controls to fully fill available width.
3152
e0d021d0
MB
31532003-05-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3154
3155 * RECTWrapper.h: New file.
3156
1e3b2ad4
RC
31572003-04-12 Robert Collins <rbtcollins@hotmail.com>
3158
3159 * script.cc (Script::extension): Extract method from Script::run.
3160 (Script::run): Extract extension generation to Script::extension.
3161 * script.h (Script::extension): Declare.
3162
2533f348
RC
31632003-04-12 Robert Collins <rbtcollins@hotmail.com>
3164
3165 * script.cc (run_script): Remove.
3166 (try_run_script): Inline method run_script.
3167 * script.h (run_script): Remove.
3168
34ea5b6d
RC
31692003-04-12 Robert Collins <rbtcollins@hotmail.com>
3170
3171 * postinstall.cc (RunScript::operator()): Use new run syntax.
3172 * script.h (Script::run): Eliminate to_log parameter.
3173 * script.cc (Script::run): Ditto.
3174 (run_script): Use new run syntax.
3175
9f27ab95
RC
31762003-04-12 Robert Collins <rbtcollins@hotmail.com>
3177
3178 * script.cc (Script::run): Eliminate temp variable 'f2'.
3179 Rename temp variable 'f2' to 'windowsName' for increased clarity.
3180
783ed9c5
RC
31812003-04-12 Robert Collins <rbtcollins@hotmail.com>
3182
3183 * script.cc (Script::run): Eliminate temp variable 'fname'.
3184
0900bd5b
RC
31852003-04-12 Robert Collins <rbtcollins@hotmail.com>
3186
3187 * script.cc (Script::run): Eliminate temp variable 'dir'.
3188
294e5067
RC
31892003-04-12 Robert Collins <rbtcollins@hotmail.com>
3190
3191 * script.cc (run_script): Always pass TRUE to Script::run.
3192 * script.h (run_script): Remove optional to_log parameter.
3193
a0e56f67
RC
31942003-04-12 Robert Collins <rbtcollins@hotmail.com>
3195
3196 * script.cc (run_script): Move functionality into Script.
3197 (Script::run): Absorb run_script.
3198
8c242540
RC
31992003-04-12 Robert Collins <rbtcollins@hotmail.com>
3200
3201 * PickCategoryLine.cc (PickCategoryLine::click): Tell packagemeta we
3202 are about to perform a visit.
3203 * PickPackageLine.cc (PickPackageLine::click): Tell packagemeta we
3204 are about to perform a visit.
ca2b7505 3205 * package_db.cc (packagedb::markUnVisited): Convenience wrapper -
8c242540
RC
3206 mark all packages as unvisited.
3207 * package_db.h (packagedb::markUnVisited): Declare.
3208 * package_meta.cc (packagemeta::PrepareForVisit): New static method
3209 to prepare for a loop-free visit.
3210 (packagemeta::packagemeta): Adjust for new member.
3211 (packagemeta::set_requirements): Only visit a node once.
3212 (packagemeta::visited): Get and Set methods for new member visited_.
3213 * package_meta.h (packagemeta::PrepareForVisit): Declare.
3214 (packagemeta::visited): Declare.
3215 (packagemeta::visited_): Declare.
3216
5f4b0e57
MB
32172003-04-07 Max Bowsher <maxb@ukf.net>
3218
3219 * download.cc: Add command line option to suppress MD5 checks.
3220 (validateCachedPackage): Test option and possibly skip.
3221
e46e15bf
RC
32222003-04-02 Robert Collins <rbtcollins@hotmail.com>
3223
3224 Merge in setup-200303-troubleshooting fixes.
3225
32262003-04-02 Robert Collins <rbtcollins@hotmail.com>
3227
3228 * main.cc (NTSecurity::setDefaultDACL): Reinstate commented code.
3229 (NTSecurity::setDefaultSecurity): Ditto.
3230
32312003-04-02 Robert Collins <rbtcollins@hotmail.com>
3232
3233 * main.cc (NTSecurity::setDefaultDACL): Use MS calculations for ACL
3234 buffer sizing.
3235
32362003-04-02 Robert Collins <rbtcollins@hotmail.com>
3237
3238 * main.cc (NTSecurity::setDefaultDACL): Sanity check memory allocation.
3239
32402003-04-02 Robert Collins <rbtcollins@hotmail.com>
3241
58b12a06
MB
3242 * main.cc (NTSecurity::setDefaultDACL): Adjust commented code for
3243 auto_ptr use.
e46e15bf
RC
3244
32452003-04-02 Robert Collins <rbtcollins@hotmail.com>
3246
3247 * main.cc (NTSecurity::NoteFailedAPI): Helper function.
3248 Use throughout NTSecurity routines.
3249 (NTSecurity::setDefaultDACL): Use dynamic memory for ACL storage.
3250
32512003-04-02 Robert Collins <rbtcollins@hotmail.com>
3252
58b12a06
MB
3253 * main.cc (NTSecurity::setDefaultDACL): Disable ~ 50% of remaining
3254 active code.
e46e15bf
RC
3255
32562003-04-02 Robert Collins <rbtcollins@hotmail.com>
3257
3258 * main.cc (NTSecurity::GroupInfo): Extract group query code.
3259 (NTSecurity::setDefaultDACL): Disable ~ 50% of code.
3260
32612003-04-02 Robert Collins <rbtcollins@hotmail.com>
3262
58b12a06
MB
3263 * main.cc (NTSecurity::setDefaultSecurity): Disable ~ 50% of security
3264 code.
e46e15bf
RC
3265
32662003-04-01 Robert Collins <rbtcollins@hotmail.com>
3267
58b12a06
MB
3268 * main.cc (NTSecurity::setDefaultSecurity): Remove double declaration of
3269 sz. User TokenGroupCollection to abstract token searching logic,
3270 eliminate isadmin and isuser temporary variables.
e46e15bf
RC
3271 (TokenGroupCollection): New class for querying token group information.
3272
32732003-04-01 Robert Collins <rbtcollins@hotmail.com>
3274
3275 * main.cc (NTSecurity::setDefaultSecurity): Extract esid initialisation.
3276 Move local variables to just before first use.
3277 SetTokenInformationFailures where being handled inconsistently.
3278 Remove assignments from if statements.
3279 (NTSecurity::esid): Rename to everyOneSID.
3280 (NTSecurity::initialiseEveryOneSID): new method.
3281 (NTSecurity::setDefaultDACL): Extract method for default DACL logic.
3282
32832003-04-01 Robert Collins <rbtcollins@hotmail.com>
3284
3285 * main.cc (SIDWrapper): Manage SID memory.
3286 (HANDLEWrapper): Likewise for HANDLES.
3287 (NTSecurity): Worker class for set_default_sec().
3288 (set_default_sec): Move body into NTSecurity::setDefaultSecurity().
58b12a06
MB
3289 (NTSecurity::setDefaultSecurity): Eliminate goto out: via memory
3290 managing objects.
e46e15bf 3291
da0b54f3
MB
32922003-04-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3293
3294 * cygwin.ico: Added two new resolutions, 64x64 and 72x72.
3295
3baca7c9
RC
32962003-03-29 Robert Collins <rbtcollins@hotmail.com>
3297
3298 * GUIDELINES: New file documenting code guidelines.
3299
11e37aca
MB
33002003-03-26 Max Bowsher <maxb@ukf.net>
3301
3302 * .cvsignore: Add cfgaux.
3303
18a3405d
RC
33042003-03-26 Robert Collins <rbtcollins@hotmail.com>
3305
11e37aca
MB
3306 * package_version.cc (_defaultversion::accessible): Override and make
3307 always false.
3308 (_packageversion::accessible): Fix a couple of logic bugs resulting in
3309 incorrect trues.
18a3405d
RC
3310 * package_version.h (_packageversion::accessible): Make virtual.
3311
39ba3555
MB
33122003-03-25 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3313
3314 * threebar.h (WM_APP_START_POSTINSTALL): New message.
3315 (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message.
3316 * threebar.cc (ThreeBarProgressPage::OnMessageApp):
3317 Add handling for WM_APP_START_POSTINSTALL and
3318 WM_APP_POSTINSTALL_THREAD_COMPLETE.
3319 * install.cc (do_install_thread): Set next_dialog to
3320 IDD_S_POSTINSTALL.
3321 * desktop.cc (DesktopSetupPage::OnFinish): Move the
3322 do_postinstall call to ThreeBarProgressPage::OnMessageApp.
3323 * script.h (Script::fullName): New member function.
3324 (Script::run): New member function.
3325 (Script::ETCPostinstall): New static member constant.
3326 * script.cc (Script::fullName): Implement.
3327 (Script::run): Implement.
3328 (Script::ETCPostinstall): Define.
3329 (Script::isAScript): Use ETCPostinstall instead of a
3330 hardcoded string constant.
3331 (run): Enable "#if 0"'d code.
3332 * postinstall.cc (Progress): New extern variable.
3333 (RunFindVisitor::visitFile): Add script to vector
3334 instead of running.
3335 (RunFindVisitor::_scripts): New member variable.
3336 (RunScript): New helper class for use in for_each.
3337 (do_postinstall_thread): Rename do_postinstall to. Add
3338 Progress bar and text setting. Add package count.
3339 (do_postinstall_reflector): New static function.
3340 (do_postinstall): Rename to do_postinstall_thread.
3341 Create a thread instead.
3342
1069407c
MB
33432003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3344
3345 * script.cc (run): Add file_out parameter.
3346 Redirect output of subprocess to file, creating the
3347 path if necessary. Minimize the script window.
3348 (run_script): Add optional to_log boolean parameter.
3349 If to_log, redirect output to temporary file and then
3350 import it into LOG_BABBLE.
3351 (OutputLog): New helper class.
3352 (operator<<): New operation on OutputLog.
3353 * script.h (run_script): Add optional to_log parameter.
3354 * postinstall.cc (RunFindVisitor::visitFile): Instruct
3355 run_script() to log script output.
3356 (do_postinstall): Ditto.
3357
84fd41a9
RC
33582003-03-20 Robert Collins <rbtcollins@hotmail.com>
3359
ca2b7505 3360 * package_meta.cc (packagemeta::set_action): The logic
84fd41a9
RC
3361 test for the default action was reversed.
3362
864a5ec1
MB
33632003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3364
3365 * postinstall.cc (do_postinstall): Filter out '*.done'.
3366 * FilterVisitor.h: New header file. Declare the
3367 FilterVisitor, Filter, and ExcludeNameFilter classes.
3368 * FilterVisitor.cc: New file. Implement FilterVisitor,
3369 Filter, and ExcludeNameFilter.
3370 * String++.h (String::matches): New instance function.
3371 * String++.cc (String::matches): Implement.
3372 (strmatch) Import and adapt for <buf,len> strings.
3373 * Makefile.am (setup_SOURCES): Add FilterVisitor.cc and
3374 FilterVisitor.h to value.
3375
560ac5e2
MB
33762002-03-18 Max Bowsher <maxb@ukf.net>
3377
3378 * LogFile.cc (LogFile::exit): Use CRT exit() instead of ExitProcess().
3379 Use passed exit_code even if been_here.
3380 Remove incorrect _CYGWIN_ preprocessor conditional.
3381
ad646f43
RC
33822003-03-16 Robert Collins <rbtcollins@hotmail.com>
3383
e0312c44
RC
3384 * package_db.h (PackageDBConnectedIterator): Typedef
3385 for connected loop detection collection iterator.
ca2b7505
CF
3386 * package_db.cc (ConnectedLoopDetector): An
3387 implementation of R.E. Tarjans strongly connected
e0312c44
RC
3388 set visitor algorithm.
3389 * postinstall.cc (do_postinstall): Use the new iterator
3390 for visiting postinstall scripts.
ad646f43
RC
3391
33922003-03-16 Robert Collins <rbtcollins@hotmail.com>
3393
3394 * install.cc: Introduce Installer class.
3395 (init_dialog): Rename to Installer::initDialog.
3396 (progress): Rename to Installer::progress.
3397 (standard_dirs): Rename to Installer::StandardDirs.
3398 (uninstall_one): Rename to Installer::uninstallOne.
3399 (replace_one): Rename to Installer::replaceOne.
ca2b7505 3400 (log_ror_failure): Rename to
e0312c44 3401 Installer::replaceOnRebootFailed.
ca2b7505 3402 (log_ror_success): Rename to
e0312c44 3403 Installer::replaceOnRebootSucceeded.
ad646f43
RC
3404 (install_one_source): Rename to Installer::installOneSource.
3405 Note script files as they are installed.
3406 * package_version.cc (packageversion::addScript): Implement.
3407 (packageversion::scripts): Implement.
ca2b7505 3408 * package_version.h (packageversion::addScript): Record the
e0312c44 3409 presence of a script.
ad646f43 3410 * script.h (Script): New class to track scripts.
e0312c44
RC
3411 * postinstall.cc (do_postinstall): Iterate through the
3412 package listed scripts before searching for scripts.
ca2b7505 3413 * String++.cc (String::substr): Second argument needed to
e0312c44 3414 be signed.
ca2b7505 3415 * String++.h (String::substr): Second argument needed to
e0312c44 3416 be signed.
ad646f43 3417
c0a46d04
MB
34182003-03-16 Max Bowsher <maxb@ukf.net>
3419
3420 * .cvsignore: Create, to ignore configure, aclocal.m4, Makefile.in and
3421 autom4te.cache.
3422
3d7ae5a2
MB
34232003-03-16 Max Bowsher <maxb@ukf.net>
3424
3425 * UserSettings.cc (UserSettings::Instance): Remove premature return.
3426
92f9402a
RC
34272003-03-15 Robert Collins <rbtcollins@hotmail.com>
3428
3429 * script.cc (run): Rename variable b to createSucceeded.
3430
34312003-03-15 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3432
3433 * script.cc (run): Close unneeded handles.
3434
b49f570f
RC
34352003-03-15 Robert Collins <rbtcollins@hotmail.com>
3436
3437 * configure: Remove.
3438 * aclocal.m4: Remove.
3439 * Makefile.in: Remove.
3440 * cfgaux: Remove.
3441 * cfgaux/compile: Remove.
3442 * cfgaux/config.guess: Remove.
3443 * cfgaux/config.sub: Remove.
3444 * cfgaux/depcomp: Remove.
3445 * cfgaux/install-sh: Remove.
3446 * cfgaux/ltmain.sh: Remove.
3447 * cfgaux/missing: Remove.
3448 * cfgaux/mkinstalldirs: Remove.
3449
b6001c0d
MB
34502003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3451
3452 * install.cc (replace_one): Clear Text3.
3453
46ccc05f
MB
34542003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3455
3456 * install.cc (install_one_source): Add logging for successful
3457 replace-on-reboot scheduling. Factor out duplicate code.
3458 Set rebootneeded on Win9x.
3459 (log_ror_failure): New static function.
3460 (log_ror_success): New static function.
3461
c27b09ba
RC
34622003-03-14 Robert Collins <rbtcollins@hotmail.com>
3463
ca2b7505 3464 * choose.cc (ChooserPage::OnNext): Fix iterator bug. Reported by
c27b09ba
RC
3465 Igor Pechtchanski <pechtcha@cs.nyu.edu>.
3466
a081d4ff
MB
34672003-03-13 Max Bowsher <maxb@ukf.net>
3468
3469 * Update included zlib to 1.1.4.
3470
f430003c
RC
34712003-03-13 Robert Collins <rbtcollins@hotmail.com>
3472
46ccc05f
MB
3473 * install.cc (do_install_thread): Use a query method rather than temp
3474 variable do_skip.
f430003c 3475
46ccc05f 34762003-03-09 Pavel Tsekov <ptsekov@gmx.net>
f430003c 3477
ca2b7505 3478 * install.cc (do_install_thread): Use IDS_SKIP_PACKAGE
f430003c
RC
3479 instead of IDS_CORRUPT_PACKAGE when asking the user to take
3480 action if the hash verification check fails for a source package.
3481 Do not increase the value of 'total_bytes' variable if the
3482 user chooses to skip over a package, which failed the hash
3483 verification.
3484
48c7d667
MB
34852003-03-10 Max Bowsher <maxb@ukf.net>
3486
3487 * Makefile.am: Add foreign to AUTOMAKE_OPTIONS.
3488
aaeee283
RC
34892003-03-10 Robert Collins <rbtcollins@hotmail.com>
3490
3491 * UserSettings.cc (UserSettings::init): Really initialize all members.
3492
ead15931
RC
34932003-03-10 Robert Collins <rbtcollins@hotmail.com>
3494
3495 * Exception.h: Add a logic error exception id.
3496 * Makefile.am: Add new sources.
3497 * UserSettings.cc: New file.
3498 * UserSettings.h: New file.
3499 * UserSetting.cc: New file.
3500 * UserSetting.h: New file.
3501 * site.h: Add a SiteSetting as example of a UserSetting.
46ccc05f
MB
3502 * site.cc (ChosenSites): Add a instance of SiteSetting to trigger
3503 registration.
ead15931 3504
c1754473
RC
35052003-03-10 Robert Collins <rbtcollins@hotmail.com>
3506
46ccc05f
MB
3507 * compress_bz.cc (compress_bz::read): Adjust incorrect assignment of
3508 lasterr.
c1754473
RC
3509 (compress_bz::error): Return lasterr which will indicate any error.
3510
52620058
RC
35112003-03-10 Robert Collins <rbtcollins@hotmail.com>
3512
3513 * choose.h (ChooserPage): Override OnActivate.
46ccc05f
MB
3514 * choose.cc (ChooserPage::OnActivate): Refresh the current view when
3515 activating the dialog.
52620058 3516
6e754226
RC
35172003-03-09 Robert Collins <rbtcollins@hotmail.com>
3518
46ccc05f
MB
3519 * package_version.cc (_defaultversion::pick(bool)): Override this and
3520 do nothing.
3521 (packageversion::pick(bool): Use a mutator function rather than direct
3522 member access.
3523 * package_version.h (_packageversion::pick(bool)): Move method from
3524 _packageversion.
6e754226 3525
970149e8
RC
35262003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3527
ca2b7505 3528 * install.cc (install_one_source): Remove the MD5 verification
970149e8
RC
3529 code.
3530 Delay the creation of the package listing file.
ca2b7505 3531 (do_install_thread): Check the hashes for packages which need
970149e8
RC
3532 to be installed before the uninstall step. Allow the user to
3533 skip over packages, which fail the hash verification.
3534 (md5_one): Define new function.
3535 * res.rc (IDS_SKIP_PACKAGE): New string resource.
3536 * resource.h (IDS_SKIP_PACKAGE): New macro definition.
3537
f37b36a3
RC
35382003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3539
3540 * Exception.h: Declare new constructor.
3541 (Exception::_message): Change the type from 'const char *' to
3542 'class String'.
3543 (Exception::~Exception): Implement destructor (make gcc shut up).
3544 * Exception.cc: Implement new constructor.
3545 (Exception::what): Use String::cstr_oneuse ().
3546 * download.cc (validateCachedPackage): Use the constructor, which
3547 takes String& as its second argument, when throwing objects
3548 of type Exception.
3549 (check_for_cached): Ditto.
3550 * install.cc (install_one_source): Ditto.
3551
eef9ea26
RC
35522003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3553
3554 * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
3555 log filename to %s.
3556 (IDS_MISSING_LOG): New string resource.
3557 * resource.h (IDS_MISSING_LOG): New resource.
3558 * LogFile.cc (LogFile::exit): Pass log filename for
3559 LOG_BABBLE to note().
3560 (LogFile::getFileName): New function.
3561 * LogFile.h (LogFile::getFileName): New function.
3562
514b100e
RC
35632003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3564
3565 * String++.cc: Don't include concat.h.
3566 * Makefile.am: Remove concat.cc and concat.h references.
3567 * concat.h: Remove.
3568 * concat.cc: Remove.
3569
56c60dcc
MB
35702003-03-09 Max Bowsher <maxb@ukf.net>
3571
3572 * bootstrap.sh: Add sanity check of current directory.
3573 Recurse into libgetopt++ if needed.
3574
4f4b9def
RC
35752003-03-09 Robert Collins <rbtcollins@hotmail.com>
3576
3577 * Update readme of bugs and wishes.
3578
ed6137e5
MB
35792003-03-05 Max Bowsher <maxb@ukf.net>
3580
3581 * netio.cc (save_dialog): Allocate an empty string if the password is
3582 null, so that an empty password is accepted elsewhere in setup.
3583 (check_if_enable_ok): An empty password is OK.
3584
e0aec95e
MB
35852003-03-05 Brian Keener <bkeener@thesoftwaresource.com>
3586
ed6137e5 3587 * PickView.cc (PickView::views): Add two new views for Skipped
e0aec95e
MB
3588 packages and Installed Packages not requiring update.
3589 (PickView::set_headers () ): Ditto.
3590 (PickView::clear_view (void) ): Ditto.
3591 (PickView::views::caption () ): Add two new captions for the new
3592 views added for Skipped and Installed Packages.
3593 (PickView::scroll () ): Modify Scroll Bar property to Disable
ed6137e5 3594 instead of disappearing when there is nothing to Scroll.
e0aec95e
MB
3595 * PickView.h: Add two new views for Skipped packages and Installed
3596 packages to public class view.
3597 * choose.cc (list_click () ): Modify Scroll Bar property to Disable
ed6137e5 3598 instead of disappearing when there is nothing to Scroll.
e0aec95e
MB
3599 (listview_proc () ): Ditto.
3600 (set_view_mode): Add two new views for Skipped Packages and Installed
3601 Packages not requiring update. Modify Scroll Bar property to Disable
3602 instead of disappearing when there is nothing to scroll.
3603 * res.rc (IDD_CHOOSE): Reposition Radio Buttons, View Selection
3604 Button and View Button Caption to make room for longer captions.
3605
c7fb2f36
MB
36062003-03-04 Max Bowsher <maxb@ukf.net>
3607
3608 * compress_gz.cc (compress_gz::construct):
3609 Fix broken checkin dated 2002-07-03.
3610
d5be1d23
MB
36112003-02-28 Max Bowsher <maxb@ukf.net>
3612
3613 * main.cc (set_default_sec): Add logging.
3614
adaa168a
MB
36152003-02-28 Pierre Humblet <pierre.humblet@ieee.org>
3616
3617 * main.cc (set_default_dacl): Replace with set_default_sec.
3618 (set_default_sec): Attempt to change the default group to
3619 Users or Administrators if it is None, in addition to setting
3620 Everyone in the default DACL.
3621 (main): Call set_default_sec instead of set_default_dacl.
3622
3a8d1127
MB
36232003-01-31 Max Bowsher <maxb@ukf.net>
3624
3625 * install.cc (install_one_source): Fix spacing in log message.
3626
c7230a28
MB
36272003-01-19 Max Bowsher <maxb@ukf.net>
3628
3629 * resource.h (IDC_CHOOSE_KEEP): Define.
3630 * res.rc (IDD_CHOOSE): Add radio button IDC_CHOOSE_KEEP.
3631 * choose.cc (create_listview): Add IDC_CHOOSE_KEEP to ta[].
3632 (ChooserPage::OnMessageCmd): Handle new IDC_CHOOSE_KEEP button.
3633
ac949c48
MB
36342003-01-15 Max Bowsher <maxb@ukf.net>
3635
3636 * mkdir.cc [_CYGWIN_]: Implement what was pseudocode.
3637 * io_stream.h [__CYGWIN__]: Don't typedef ssize_t.
3638 * proppage.h: Include "win32.h" instead of <windows.h>.
3639
4f618d88
MB
36402003-01-15 Max Bowsher <maxb@ukf.net>
3641
3642 * mount.cc [MAINTAINER_FEATURES]: Add --override-registry-name option.
3643
1606c4e9
MB
36442002-12-11 Abraham Backus <abraham@backus.com>
3645
3646 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Leave port out of Host header,
3647 unless non-default.
3648
c4e25cde
MB
36492002-12-11 Max Bowsher <maxb@ukf.net>
3650
3651 * package_meta.cc: Change 'endl' to 'endLog' as appropriate.
3652 * package_version.cc: Ditto.
3653
bfdf6ac2
MB
36542002-09-22 Max Bowsher <maxb@ukf.net>
3655
3656 * PickView.cc (pkg_headers): Rename column 'Category' to 'Categories'.
3657 * package_meta.h (packagemeta::getReadableCategoryList): Declare.
3658 * package_meta.cc (packagemeta::getReadableCategoryList): Implement.
3659 * PickPackageLine.cc (PickPackageLine::paint): Change to use
3660 getReadableCategoryList.
3661 Fix x2 argument to IntersectClipRect.
3662
63c82708
RC
36632002-11-25 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3664
3665 * window.h (Window::GetWindowRect): New method declaration.
3666 (Window::GetClientRect): Ditto.
3667 (Window::MoveWindow): Ditto.
3668 (Window::ScreenToClient): Ditto.
3669 * window.cc (REFLECTION_INFO): Remove.
3670 (ReflectionInfo): Remove.
3671 (Window::FirstWindowProcReflector): Use the WM_NCCREATE message instead
3672 of the horrid REFLECTION_INFO hack to hook the Window instance to the
3673 HWND instance.
3674 (Window::WindowProcReflector): Use GetWindowLongPtr() now that it's
3675 available.
3676 (Window::Create): Change to use new WM_NCCREATE reflection procedure
3677 above.
3678 (Window::GetWindowRect): New method.
3679 (Window::GetClientRect): New method.
3680 (Window::MoveWindow): New method.
3681 (Window::CenterWindow): Use new methods, also specify "::" for some non-
3682 member functions with the same names.
3683 (Window::ScreenToClient): New method.
3684
58983805
RC
36852002-11-26 Robert Collins <rbtcollins@hotmail.com>
3686
3687 * AntiVirus.cc: Change the short option again! It's now 'A'.
3688 * desktop.cc (etc_profile): Remove.
3689 (make_etc_profile): Remove.
3690 (uexists): Remove.
3691 (make_passwd_group): Remove.
3692 (do_desktop_setup): Don't call removed functions.
3693
b2028692
RC
36942002-11-26 Robert Collins <rbtcollins@hotmail.com>
3695
3696 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fix my botched application of
3697 Marcel's patch.
3698
2d8e4784
RC
36992002-07-08 Marcel Telka <marcel@telka.sk>
3700
b2028692 3701 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fixed decoding of the FTP
2d8e4784
RC
3702 reply (code 227) to the PASV command.
3703
3a87705e
RC
37042002-11-26 Robert Collins <rbtcollins@hotmail.com>
3705
3706 * IniDBBuilderPackage.cc (IniDBBuilderPackage::~IniDBBuilderPackage):
3707 Sort the packages db once all the new packages have been added.
3708 * IniDBBuilderPackage.h (IniDBBuilderPackage::~IniDBBuilderPackage):
3709 Declare this.
3710
bd4e91a7
RC
37112002-11-26 Robert Collins <rbtcollins@hotmail.com>
3712
3713 * choose.cc (ChooserPage::OnNext): Remove extracted comment.
3714 * package_version.cc (processOneDependency): Return once selecting
3715 a package (bugfix to prevous rework).
3716 Log if the default trust fails the package specification.
3717
f416a2b6
RC
37182002-11-26 Robert Collins <rbtcollins@hotmail.com>
3719
3720 * package_meta.h (packagemeta::logAllVersions): Declare.
3721 (packagemeta::trustLabel): Ditto.
ca2b7505 3722 * choose.cc (ChooserPage::OnNext): Get each package to log all it's
f416a2b6
RC
3723 versions.
3724 * package_meta.cc (packagemeta::logAllVersions): Implement.
3725 (packagemeta::trustLabel): Ditto.
3726
14485ab2
RC
37272002-11-25 Robert Collins <rbtcollins@hotmail.com>
3728
3729 * AntiVirus.cc: Change 'd' to 'D' to fix command line conflict.
3730
f9e903a3
RC
37312002-11-25 Robert Collins <rbtcollins@hotmail.com>
3732
3733 * AntiVirus.cc: New file.
3734 * AntiVirus.h: Ditto.
3735 * LogFile.cc: Include AntiVirus.h for class definition.
3736 (LogFile::exit): Trigger AntiVirus::AtExit().
3737 * MakeFile.am(setup_SOURCES): Add AntiVirus files.
3738 * autoload.c: Declare Service Control Manager related API's.
3739 * main.cc: Include AntiVirus.h for class definition.
3740 (main): Add the AntiVirus page in.
3741 * res.rc: Define IDD_VIRUS.
3742 * resource.h: Define IDD_VIRUS related control ID's.
3743 * splash.h: Override OnNext.
3744 * splash.cc: Only show AntiVirus page when one has been detected.
3745 * source.cc: Ditto.
3746
05c5b8a6
RC
37472002-11-25 Robert Collins <rbtcollins@hotmail.com>
3748
3749 * package_version.cc (DependencyProcessor): Create convenience class.
3750 (select): Extract version selection method.
3751 (processOneDependency): Check for a satisfactory trusted version
3752 first.
3753
37542002-11-10 Robert Collins <rbtcollins@hotmail.com>
15004270
RC
3755
3756 * main.cc (main): Use the factory for LogFile.
3757 * String++.cc: Update to use sstream.
58b12a06 3758 (String::String): Use a ostringstream for libC++ 3.2.
15004270
RC
3759 * LogFile.h (LogFile): Make createLogFile static.
3760
05c5b8a6 37612002-11-10 Robert Collins <rbtcollins@hotmail.com>
51629951
RC
3762
3763 * main.cc (main): Oops, pass LogSingleton a reference, not a pointer.
3764
666bf37d
RC
37652002-11-04 Max Bowsher <maxb@ukf.net>
3766
3767 * Exception.h (Exception::what): Add throw() specification,
3768 to agree with libstdc++-v3.
3769 * Exception.cc (Exception::what): Ditto.
3770 * IniDBBuilderPackage.h: Add 'std::' where needed.
3771 * PickCategoryLine.h: Ditto.
3772 * category.h: Ditto.
3773 * package_db.h: Ditto.
3774 * package_meta.h: Ditto.
3775 * package_source.h: Ditto.
3776 * package_version.h: Ditto.
3777 * site.h: Ditto.
3778 * win32.h: Define NOMINMAX before including <windows.h>.
3779 * package_meta.cc: Add 'using namespace std;'.
3780 (packagemeta::set_requirements): Remove default parameter values
3781 from definition (gcc3 likes them only in declaration).
3782 * package_version.cc: Add 'using namespace std;'.
3783 (packageversion::set_requirements): Remove default parameter
3784 values from definition (gcc3 likes them only in declaration).
3785
37decc22
RC
37862002-11-10 Robert Collins <rbtcollins@hotmail.com>
3787
3788 * compress_bz.cc: Don't include bzlib.h directly, the compress_bz.h
3789 header includes it.
3790
37912002-11-04 Max Bowsher <maxb@ukf.net>
3792
ca2b7505
CF
3793 * compress_bz.h: #undef small before including bzlib.h - if we are
3794 going to hide the fact that we are _WIN32 from bzlib, then we need
37decc22
RC
3795 to #undef small for it as well (bad windows.h clash).
3796
a55c8f45
RC
37972002-11-10 Robert Collins <rbtcollins@hotmail.com>
3798
3799 * localdir.cc: Update the extern LogFile to be a pointer.
3800 (save_local_dir): Change . to -> for the above.
3801 * main.cc (theFile): Change from an instance to a pointer.
3802 (main): Change . to -> for the above.
3803
c83c52d8
RC
38042002-11-10 Robert Collins <rbtcollins@hotmail.com>
3805
3806 * LogFile.cc: use 'std::' where needed throughout.
3807 (LogFile::createLogFile): Implement a factory for LogFile.
3808 (LogFile::LogFile): Update for use with the factory, and to
3809 handle the latest g++ library changes.
3810 (LogFile::operator()): Ditto.
3811 (LogFile::endEntry()): Ditto.
3812 * LogFile.h: Ditto.
3813 * LogSingleton.cc: Ditto.
3814 * LogSingleton.h: Ditto.
3815
318af134
RC
38162002-11-04 Max Bowsher <maxb@ukf.net>
3817
3818 * String++.h: Add 'std::' where needed.
3819
6625e635
RC
38202002-11-04 Max Bowsher <maxb@ukf.net>
3821
3822 * IniDBBuilderPackage.cc: Add 'using namespace std;'.
3823 * IniParseFindVisitor.cc: Ditto.
3824 * LogFile.cc: Ditto.
3825 * LogSingleton.cc: Ditto.
3826 * PickView.cc: Ditto.
3827 * String++.cc: Ditto.
3828 * choose.cc: Ditto.
3829 * download.cc: Ditto.
3830 * find.cc: Ditto.
3831 * install.cc: Ditto.
3832 * io_stream.cc: Ditto.
3833 * io_stream_file.cc: Ditto.
3834 * package_db.cc: Ditto.
3835 * root.cc: Ditto.
3836 * site.cc: Ditto.
3837
955bf437
RC
38382002-11-04 Max Bowsher <maxb@ukf.net>
3839
3840 * LogSingleton.h: Add 'std::' where needed.
3841
b34fb59f
RC
38422002-11-04 Max Bowsher <maxb@ukf.net>
3843
3844 * archive_tar_file.cc: Include <algorithm>.
3845 Change min(a,b) to std::min(a,b)
3846 * compress_bz.cc: Ditto.
3847 * compress_gz.cc: Ditto.
3848
326fbcb8
RC
38492002-11-04 Max Bowsher <maxb@ukf.net>
3850
3851 * res.rc: Change a #-comment (invalid) to a //-comment.
3852
4361306f
RC
38532002-11-04 Max Bowsher <maxb@ukf.net>
3854
3855 * Makefile.am (%.o: %.rc): Make windres use $(CC) not hardcoded gcc.
58b12a06
MB
3856 (inilint_LDADD): Remove -lstd++.
3857 (setup_LDADD): Ditto.
4361306f 3858
05d7b7f2
RC
38592002-09-22 Max Bowsher <maxb@ukf.net>
3860
3861 * IniDBBuilderPackage.cc: Update DEBUG code to current class
3862 layout.
3863
f2ff9838
RC
38642002-09-21 Robert Collins <rbtcollins@hotmail.com>
3865
3866 * choose.h: Add OnUnattended method.
3867 * desktop.cc (DesktopSetupPage::OnInit): Allow fine grained
3868 control via command line options.
3869 (DesktopSetupPage::OnUnattended): Implement.
3870 (DesktopSetupPage::OnMessageApp): Implement.
3871 * desktop.h (DesktopSetupPage::OnUnattended): declare.
3872 (DesktopSetupPage::OnMessageApp): Ditto.
3873 * download.cc (do_download_thread): Support unattended mode.
3874 * install.cc (do_install_thread): Ditto.
3875 * localdir.h: Ditto.
3876 * main.cc (main): Ditto.
3877 * net.cc (NetPage::OnUnattended): Ditto.
3878 * net.h (NetPage::OnUnattended): Declare.
3879 * proppage.cc (PropertyPage::DialogProc): Support unattended mode.
3880 * proppage.h (PropertyPage::OnUnattended): Declare.
3881 * root.cc (RootPage::OnInit): Support unattended mode.
3882 (RootPage::OnUnattended): Implement.
3883 * root.h (RootPage::OnUnattended): Declare.
3884 * site.cc (register_saved_site): Extract Method from get_saved_sites.
3885 (get_saved_sites): Remove common code for adding a site.
3886 (SitePage::OnInit): Support unattended mode.
3887 (SitePage::OnUnattended): Implement.
3888 * site.h (SitePage::OnUnattended): Declare.
3889 * source.cc (SourcePage::OnActivate): Support unattended mode.
3890 (SourcePage::OnUnattended): Implement.
3891 * source.h (SourcePage::OnUnattended): Declare.
3892 * splash.h (SplashPage::OnUnattended): Declare.
3893 * state.cc (unattended_mode): Declare.
3894 * state.h (unattended_mode): Declare.
3895 * threebar.h (ThreeBarProgressPage::OnUnattended): New method.
3896
707f3d66
RC
38972002-09-21 Robert Collins <rbtcollins@hotmail.com>
3898
3899 * res.rc: Commit Harry Johnston's dialog caption patch. From July.
3900
ec13f13c
RC
39012002-07-15 Robert Collins <rbtcollins@hotmail.com>
3902
3903 * package_version.cc (packageversion::sources): Implement this.
3904 * download.cc (do_download_thread): Support multiple files per package.
3905
e5662e0a
RC
39062002-07-15 Robert Collins <rbtcollins@hotmail.com>
3907
3908 * package_version.h (packageversion::sources): Support multiple files in
3909 a single package version.
3910 * package_version.cc (_packageversion::accessible): Ditto.
3911 (packageversion::source): Ditto.
3912
60daae94
RC
39132002-07-15 Robert Collins <rbtcollins@hotmail.com>
3914
3915 * iniparse.y: Implement support for multiple source files for a source
3916 package.
3917 * IniDBBuilder.h (IniDBBuilder::buildSourceFile): Ditto.
3918 * IniDBBuilderPackage.h (IniDBBuilder::buildSourceFile): Ditto.
3919 * IniDBBuilder.cc (IniDBBuilder::buildSourceFile): Ditto.
ca2b7505 3920 * IniDBBuilderPackage.cc (IniDBBuilder::buildSourceFile): Implement a
60daae94
RC
3921 stub as preparation.
3922
4f591f9d
RC
39232002-07-13 Robert Collins <rbtcollins@hotmail.com>
3924
ca2b7505 3925 * PickPackageLine.cc (PickPackageLine::click): Set requirements for
4f591f9d
RC
3926 packages under all circumstances - slightly higher overheader, simpler
3927 code.
ca2b7505 3928 * download.cc (do_download_thread): Correctly download source
4f591f9d
RC
3929 packages.
3930 * package_meta.cc (checkForInstalled): Remove.
3931 (checkForUpgradeable): Ditto.
3932 (checkForSatisfiable): Ditto.
3933 (processOneDependency): Ditto.
3934 (packagemeta::set_requirements): Move guts to packageversion.
3935 * package_version.cc (checkForInstalled): Copied from package_meta.cc.
3936 (checkForUpgradeable): Ditto.
3937 (checkForSatisfiable): Ditto.
3938 (processOneDependency): Ditto.
3939 (packageversion::set_requirements): Ditto.
3940 * package_version.h (packageversion::set_requirements): Declare.
3941
b1ff53ed
RC
39422002-07-13 Robert Collins <rbtcollins@hotmail.com>
3943
3944 * IniDBBuilder.cc (IniDBBuilder::buildBeginBuildDepends): Implement.
3945 (IniDBBuilder::buildBeginBinary): Implement.
3946 * IniDBBuilder.h (IniDBBuilder::buildBeginBuildDepends): Declare.
3947 (IniDBBuilder::buildBeginBinary): Ditto.
3948 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildBeginBuildDepends):
3949 Implement.
3950 (IniDBBuilderPackage::buildBeginBinary): Ditto.
3951 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildBeginBuildDepends):
3952 Declare.
3953 (IniDBBuilderPackage::buildBeginBinary): Ditto.
3954 * inilex.l: Recognise Build-Depends-Indep, [,], >, < and remove
3955 T_UNKNOWN.
3956 * iniparse.y: Full support for parsing a debian Sources file in-line in
3957 setup.ini.
3958 * package_version.cc (packageversion::binaries): Implement.
3959 * package_version.h (packageversion::binaries): Declare list of what
3960 packages are created from a given source package.
3961 (_packageversion::binaries): Ditto.
3962
233a3e17
RC
39632002-07-10 Robert Collins <rbtcollins@hotmail.com>
3964
3965 * iniparse.y: Add basis for support for parsing a debian Sources file.
3966 * inilex.l: Ditto.
3967
cfae3b8d
RC
39682002-07-09 Robert Collins <rbtcollins@hotmail.com>
3969
3970 Change custom container code for packagedb::packages to STL containers
3971 throughout.
3972 * IniDBBuilderPackage.cc: Ditto.
3973 * PickView.cc: Ditto.
3974 * choose.cc: Ditto.
3975 * desktop.cc: Ditto.
3976 * download.cc: Ditto.
3977 * install.cc: Ditto.
3978 * package_db.cc: Ditto.
3979 * package_db.h: Ditto.
3980 * Makefile.am: Remove list.h references.
3981 * list.h: Remove.
3982
09130e58
RC
39832002-07-08 Max Bowsher <maxb@ukf.net>
3984
3985 * PickView.cc (PickView::PickView): Set font of package list header to
3986 the same as used in the rest of the package list.
3987
a75ed5ce
RC
39882002-07-08 Robert Collins <rbtcollins@hotmail.com>
3989
3990 * install.cc (NoReplaceOnReboot): New command line option to prevent
3991 replacing in use files.
3992 (install_one_source): Check the option and use it.
3993 * README: Update TODO lists.
3994
0cf68afd
RC
39952002-07-08 Robert Collins <rbtcollins@hotmail.com>
3996
ca2b7505 3997 * PickCategoryLine.cc: Change bucket to use STL container syntax
0cf68afd
RC
3998 throughout.
3999 (PickCategoryLine::paint): Use new Category type syntax.
ca2b7505 4000 * PickCategoryLine.h: Use STL vectors rather than custom containers
0cf68afd
RC
4001 throughout.
4002 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageCategory):
4003 Use new add_category syntax.
4004 * PickView.cc (PickView::insert_pkg): Use new Category type syntax.
4005 (PickView::insert_category): Ditto.
4006 (PickView::init_headers): Ditto.
4007 * category.cc: Trim obsolete code.
ca2b7505 4008 * category.h: Replace interconnecting class with a typedef to
0cf68afd
RC
4009 facilitate leveraging STL maps.
4010 * choose.cc (fill_missing_category): Use updated pkg.add_category
4011 syntax.
4012 (default_trust): Use new Category type syntax.
4013 (set_view_mode): Ditto.
4014 (create_listview): Ditto.
4015 * package_db.cc (categories): Ditto.
4016 * package_db.h: Update headers list to include needed headers.
4017 (packagedb::categories): Replace custom list with STL map.
4018 * package_meta.cc: Use new Category type syntax throughout.
4019 (packagemeta::add_category): Implement new syntax.
4020 * package_meta.h: Remove commented out source.
4021 (packagemeta::add_category): Update syntax to decouple interface from
4022 packagedb.
4023
89374d4a
CF
40242002-07-06 Christopher Faylor <cgf@redhat.com>
4025
4026 * site.cc (do_download_site_info_thread): Correct spelling error.
4027
405d7186
RC
40282002-07-06 Robert Collins <rbtcollins@hotmail.com>
4029
4030 * PickCategoryLine.h: Include required header list.h.
4031 * PickPackageLine.cc (PickPackageLine::paint): Adjust to use STL
4032 containers for listing of packages per category and vice verca.
4033 * PickView.cc (PickView::insert_pkg): Ditto.
4034 (PickView::insert_category): Ditto.
4035 * String++.h (String::caseless): STL helper to allow trivial containers
4036 of Strings with case insensitive comparisons.
4037 * category.h: Adjust to use STL containers for listing of packages per
4038 category and vice verca.
4039 * choose.cc (fill_missing_category): Ditto.
4040 (default_trust): Ditto.
4041 (ChooserPage::OnNext): Ditto.
4042 * package_meta.cc (CategoryPackage::~CategoryPackage): Remove.
4043 (packagemeta::packagemeta): Adjust for new category list name.
4044 (packagemeta::~packagemeta): Adjust to use STL containers for listing
4045 of packages per category and vice verca.
4046 (packagemeta::set_action): Ditto.
4047 * package_meta.h (CategoryPackage): Remove.
4048 (packagemeta): Adjust to use STL containers for listing of packages per
4049 category and vice verca.
4050
080bec6e
RC
40512002-07-05 Robert Collins <rbtcollins@hotmail.com>
4052
4053 * io_stream.cc: Use STL containers rather than custom ones.
4054 (io_stream::registerProvider): Ditto.
4055 (findProvider): Ditto.
4056
3f34f364
RC
40572002-07-05 Robert Collins <rbtcollins@hotmail.com>
4058
4059 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4060 Use STL collections for download site collections.
4061 (IniDBBuilderPackage::add_correct_version): Ditto.
4062 (IniDBBuilderPackage::process_src): Ditto.
4063 * PickPackageLine.cc (PickPackageLine::click): Use the packageversion
4064 accessible() call to abstract package availability.
ca2b7505 4065 * choose.cc (scanAVersion): Use STL collections for download site
3f34f364
RC
4066 collections.
4067 * download.cc (check_for_cached): Ditto.
4068 (download_one): Ditto.
4069 * package_meta.cc (packagemeta::set_action): Use the packageversion
4070 accessible() call to abstract package availability.
4071 * package_source.h: Use STL containers rather than custom containers.
4072 (site): Create a == operator to allow STL container use.
4073 (packagesource::sites): Use STL containers rather than custom
4074 containers.
4075 * package_version.cc (_packageversion::accessible): Use STL containers
4076 for download site containers.
4077
e2cdf72c
RC
40782002-07-05 Robert Collins <rbtcollins@hotmail.com>
4079
4080 * LogFile.cc: Use STL containers rather than custom containers.
4081 (filedef): Create == and < operators for STL use.
4082 (files): Convert to an STL set.
4083 (LogFile::setFile): Use STL operations on files.
4084 (LogFile::exit): Ditto.
4085
3bac26a1
RC
40862002-07-05 Robert Collins <rbtcollins@hotmail.com>
4087
4088 * ini.cc (do_remote_ini): Use STL collection for site collection.
4089 * site.cc: Include site.h first to ensure it's parsable standalone.
4090 Use STL algorithms.
4091 (site_list): Convert to an STL container.
4092 (all_site_list): Ditto.
4093 (site_list_type::site_list_type): Implement copy constructor.
4094 (site_list_type::operator=): Implement assignment operator.
4095 (site_list_type::operator ==): Implement.
4096 (site_list_type::operator <): Ditto.
4097 (save_dialog): Use STL collection calls for site collection.
4098 (save_site_url): Ditto.
4099 (get_site_list): Ditto.
4100 (get_saved_sites): Ditto.
4101 (do_download_site_info_thread): Ditto.
4102 (SitePage::OnNext): Ditto.
4103 (SitePage::PopulateListBox): Ditto.
4104 (SitePage::OnMessageCmd): Ditto.
4105 * site.h: Use STL vectors instead of custom code.
4106 (site_list_type::site_list_type): Declare.
4107 (site_list_type::operator=): Ditto.
4108 (site_list_type::operator ==): Ditto.
4109 (site_list_type::operator !=): Ditto.
4110 (site_list_type::operator <): Ditto.
4111 (site_list_type::operator <=): Ditto.
4112 (site_list_type::operator >): Ditto.
4113 (site_list_type::operator >=): Ditto.
4114 (site_list): Convert to an STL container.
4115 (all_site_list): Ditto.
4116
528a8edb
RC
41172002-07-05 Robert Collins <rbtcollins@hotmail.com>
4118
4119 * choose.cc (default_trust): Check package accessibility before
4120 triggering an install. (Suggested by Pavel).
4121
41222002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4123
4124 * compress_gz.cc (compress_gz::construct): Always initialize key members
4125 to ensure the destructor does the right thing.
4126
4e868a01
RC
41272002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4128
4129 * filemanip.cc (parse_filename): Do not try to parse empty
4130 strings (filenames).
4131 * package_db.cc (packagedb::packagedb): For each line check if sscanf()
4132 extracted good package name and filename.
4133
7f2b9277
RC
41342002-07-03 Robert Collins <rbtcollins@hotmail.com>
4135
4136 * package_meta.cc (packagemeta::set_requirements): Automatically select
ca2b7505 4137 version of dependent packages that satisfies the requirements.
7f2b9277
RC
4138 Use processOneDependency to trigger the install of those packages.
4139 (checkForInstalled): Check that the package remains installed.
4140 (processOneDependency): Helper function for dependent packages.
4141 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackage): Add more
4142 debug information.
4143 Clear out all current state on new packages.
ca2b7505 4144 (IniDBBuilderPackage::add_correct_version): Copy the dependency list
7f2b9277
RC
4145 across.
4146
84c4f5d1
RC
41472002-07-02 Robert Collins <rbtcollins@hotmail.com>
4148
4149 * Makefile.am (inilint_SOURCES): Add PackageSpecification sources.
4150 nb: inilint is still incomplete, as the packageversion code is not
4151 ready for database-less linking.
4152 * site.cc (get_site_list): When the same site is reentered by the user
4153 replace the old one. (Suggested by John Marshall).
4154
64cd7f94
RC
41552002-07-02 Robert Collins <rbtcollins@hotmail.com>
4156
4157 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4158 Clear out package selections when generating implicit source packages.
4159 * PackageSpecification.cc (PackageSpecification::satisfies): Implement.
4160 (PackageSpecification::_operators::satisfies): Implement.
4161 * PackageSpecification.h (PackageSpecification::_operators::satisfies):
4162 Worker function for testing versions.
4163
3c196821
RC
41642002-07-01 Robert Collins <rbtcollins@hotmail.com>
4165
4166 * IniDBBuilder.cc (IniDBBuilder::buildPackageRequirement): Remove.
4167 * IniDBBuilder.h (IniDBBuilder::buildPackageRequirement): Ditto.
4168 * IniDBBuilderPackage.cc: Use the STL algorithms.
4169 Change cpv to cbpv throughout. Adjust -> to ., and use the new accessor
4170 functions for the same variable throughout.
4171 (IniDBBuilderPackage::IniDBBuilderPackage): Initialise new members.
4172 (IniDBBuilderPackage::buildPackage): Use new cygpackage syntax,
4173 and set an empty source package.
4174 (IniDBBuilderPackage::buildPackageInstall): Use the new source member
4175 to record an install package.
4176 (IniDBBuilderPackage::buildPackageSource): Move source package logic
4177 out from process_src, as it now occurs at separate times.
4178 (IniDBBuilderPackage::buildPackageRequirement): Remove.
ca2b7505 4179 (IniDBBuilderPackage::buildSourceName): Use renamed package
3c196821
RC
4180 specifiation accessor for clarity.
4181 (IniDBBuilderPackage::buildSourceNameVersion): Ditto.
4182 (IniDBBuilderPackage::add_correct_version): Use STL iterators rather
4183 than custom code.
4184 Remove source package references.
4185 (IniDBBuilderPackage::process_src): Remove source package code as it's
4186 now handled separately.
4187 Set Path information before merging versions, to prevent dangling
4188 pointers.
4189 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildPackageRequirement):
4190 Remove.
4191 (IniDBBuilderPackage::cpv): Remove.
4192 (IniDBBuilderPackage::cbpv): New generic binary working variable.
4193 (IniDBBuilderPackage::cspv): Ditto, but for source packages.
4194 (IniDBBuilderPackage::csp): Source package variable for disjoint
4195 source packages.
4196 * Makefile.am (AM_CFLAGS): Remove -Winline to allow stl set code
4197 to compile. If it compiles cleanly in gcc 3.1, then reinstate.
4198 * PickPackageLine.cc: Adjust packageversion accessors to the new
4199 reference calls. (i.e. -> to .) throughout.
4200 (PickPackageLine::paint): Use accessible() for clarity.
4201 Use new split out source package logic.
4202 (PickPackageLine::click): Ditto.
4203 * PickView.cc (PickView::init_headers): Adjust packageversion accessors
4204 to the new reference calls. (i.e. -> to .) throughout.
4205 Use new split out source package logic.
4206 * choose.cc: Don't depend on a specific package type.
ca2b7505 4207 Adjust packageversion accessors to the new reference calls. (i.e. -> to
3c196821
RC
4208 .) throughout.
4209 (set_existence): Use accessible () for clarity.
4210 (default_trust): Simplify a little.
ca2b7505 4211 (scanAVersion): Factored out code from scan_downloaded_files for
3c196821
RC
4212 clarity.
4213 (scan_downloaded_files): Factor out inner loop for clarity.
4214 (ChooserPage::OnNext): Don't dump the dependency list,
ca2b7505 4215 it's parsing is robust now!.
3c196821
RC
4216 * cygpackage.cc (createInstance): Use a factory method to create new
4217 objects.
4218 (cygpackage::cygpackage): Make this private for use by the factory.
4219 (cygpackage::setCanonicalVersion): Renamed from set_canonical_version.
4220 Remove key usage as it's obsolete.
4221 * cygpackage.h (cygpackage): Inherit from _packageversion, not
4222 packageversion.
4223 (cygpackage::createInstance): New factory.
4224 (cygpackage::cygpackage): Make private.
4225 * desktop.cc (make_passwd_group): Use new packageversion reference.
4226 * download.cc (do_download_thread): Use changeRequested() for clarity.
4227 Use new packageversion reference calls.
4228 * iniparse.y (REQUIRES): Reuse the packageList code and dump the one-off
4229 requires code.
4230 * install.cc: Adjust -> to ., and use the new accessor functions for
4231 packageversion throughout.
4232 * package_db.cc: Adjust -> to ., and use the new accessor functions for
4233 packageversion throughout.
4234 (packagedb::packagedb): Use the new cygpackage factory.
4235 (packagedb::flush): Leverage String to remove buffer overflow chance in
4236 sprintf.
4237 (packagedb::findBinary): Find a binary meta package that has a version
4238 matching a given specification.
4239 (packagedb::findSource): Ditto, but for source.
4240 * package_db.h (packagedb::findBinary): Declare.
4241 (packagedb::findSource): Ditto.
4242 * package_meta.cc: Adjust packageversion accessors to the new
4243 reference calls. (i.e. -> to .) throughout.
4244 Include the package_meta header first to ensure it parses standalone.
4245 Use the STL algorithms.
4246 (packagemeta::packagemeta): Create a copy constructor to allowing
4247 cloning binary package metadata to source package metadata.
ca2b7505 4248 (packagemeta::~packagemeta): Use the STL coleltion code rather than
3c196821
RC
4249 custom collection code.
4250 (packagemeta::add_version): Ditto.
4251 (packagemeta::set_installed): Ditto.
4252 (packagemeta::SDesc): Ditto.
4253 (hasSDesc): Helper function for find_if.
4254 (checkForInstalled): Ditto.
4255 (checkForUpgradeable): Ditto.
4256 (checkForSatisfiable): Ditto.
4257 (packagemeta::action_caption): Update for split out source packages.
4258 (packagemeta::set_action): Ditto.
4259 (packagemeta::set_requirements): Support multi-valued dependency
4260 lists - a|b & c|d - with versioned package specifications.
4261 (packagemeta::accessible): Helper member to improve abstraction.
4262 (packagemeta::sourceAccessible): Ditto.
4263 * package_meta.h: Adjust packageversion accessors to the new
4264 reference calls. (i.e. "->" to "." and"*" to "" ) throughout.
58b12a06 4265 (packagemeta::packagemeta): Declare copy constructor.
3c196821
RC
4266 Remove self initialising members.
4267 (packagemeta::set_action): Update parameters for new packageversion.
4268 (packagemeta::trustp): Ditto.
4269 (packagemeta::versions): Becomes an STL set.
4270 * package_source.h (packagesource::Cached): Const correctness change.
4271 * package_version.cc: Rewrite the packageversion interface to remove
4272 the cygpackage nonvirtual members, and provide a copy by value,
4273 pointer semantics reference counting wrapper class to ease use and
4274 comparison of packageversions.
4275 Change existing packageversion class to _packageversion throughout.
4276 (_defaultversion): A trivial concrete class to prevent specialcasing
4277 the default constructor for packageversion;
4278 (packageversion::packageversion): Implement.
4279 (packageversion::~packageversion): Ditto.
4280 (packageversion::operator=): Ditto.
4281 (packageversion::operator !): Ditto.
4282 (packageversion::operator bool): Ditto.
4283 (packageversion::operator ==): Ditto.
4284 (packageversion::operator !=): Ditto.
4285 (packageversion::operator <): Ditto.
4286 (packageversion::Name): Ditto.
4287 (packageversion::Canonical_version): Ditto.
4288 (packageversion::setCanonicalVersion): Ditto.
4289 (packageversion::getfirstfile): Ditto.
4290 (packageversion::getnextfile): Ditto.
4291 (packageversion::SDesc): Ditto.
4292 (packageversion::set_sdesc): Ditto.
4293 (packageversion::LDesc): Ditto.
4294 (packageversion::set_ldesc): Ditto.
4295 (packageversion::sourcePackage): Ditto.
4296 (packageversion::sourcePackageSpecification): Ditto.
4297 (packageversion::setSourcePackageSpecification): Ditto.
4298 (packageversion::depends): Ditto.
4299 (packageversion::predepends): Ditto.
4300 (packageversion::recommends): Ditto.
4301 (packageversion::suggests): Ditto.
4302 (packageversion::replaces): Ditto.
4303 (packageversion::conflicts): Ditto.
4304 (packageversion::provides): Ditto.
4305 (packageversion::picked): Ditto.
4306 (packageversion::pick): Ditto.
4307 (packageversion::changeRequested): Ditto.
4308 (packageversion::uninstall): Ditto.
4309 (packageversion::source): Ditto.
4310 (packageversion::accessible): Ditto.
4311 (_packageversion::sourcePackage): Ditto.
4312 (_packageversion::accessible): Ditto.
4313 (_packageversion::changeRequested): Ditto.
4314 * package_version.h: Rewrite the packageversion interface to remove
4315 the cygpackage nonvirtual members, and provide a copy by value,
4316 pointer semantics reference counting wrapper class to ease use and
4317 comparison of packageversions.
4318 Change existing packageversion class to _packageversion throughout.
4319 (Dependency): Remove.
4320 (packageversion): New wrapper class.
4321 (_packageversion): Renamed from packageversion.
4322 (_packageversion::setCanonicalVersion): New method.
4323 (_packageversion::sourcePackage): Ditto.
4324 (_packageversion::sourcePackageSpecification): Ditto.
4325 (_packageversion::setSourcePackageSpecification): Ditto.
4326 (_packageversion::changeRequested): Ditto.
4327 (_packageversion::bin): Rename to source.
4328 (_packageversion::src): Remove.
4329 (_packageversion::accessible): New method.
4330 (_packageversion::references): Allow reference counting.
ca2b7505 4331 (_packageversion::sourceVersion): Cached the best-match source
3c196821
RC
4332 package version.
4333
387cb501
RC
43342002-06-27 Robert Collins <rbtcollins@hotmail.com>
4335
4336 * compress_bz.h (compress_bz::position): Track how much has been read.
4337 * compress_bz.cc (compress_bz::compress_bz): And initialise it.
4338 (compress_bz::read): Track amount read by the client.
4339 (compress_bz::tell): And report it when asked.
4340
7d702af3
RC
43412002-06-27 Robert Collins <rbtcollins@hotmail.com>
4342
4343 * Makefile.am (snapshot): Automate snapshot creation some more.
4344
08cd08c3
RC
43452002-06-27 Robert Collins <rbtcollins@hotmail.com>
4346
4347 * msg.cc (msg): Use vsnprintf to avoid buffer overflows.
4348 (mbox): Ditto.
4349 * ini.cc (fprintf): Ditto.
4350 * log.cc (log): Ditto.
4351 * package_db.cc (packagedb::sourcePackages): Split out source packages
4352 from binary packages.
4353 * package_db.h: Ditto.
4354
aa1e3b4d
RC
43552002-06-27 Robert Collins <rbtcollins@hotmail.com>
4356
4357 * PackageSpecification.h: New file. Abstracts the ability to refer
4358 to another package, by name, or name and version.
4359 * PackageSpecification.cc: Ditto.
4360 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Simplify.
4361 (IniDBBuilder::buildPackageSource): Ditto.
4362 (IniDBBuilder::buildBeginDepends): New method for versioned
4363 dependencies.
4364 (IniDBBuilder::buildBeginPreDepends): Likewise, for dependencies to be
4365 satisfied before pre-install.
4366 (IniDBBuilder::buildPriority): New method, for getting the package
4367 Priority.
4368 (IniDBBuilder::buildInstalledSize): How much disk space does it need?
4369 (IniDBBuilder::buildMaintainer): Who maintains the package?
4370 (IniDBBuilder::buildArchitecture): What platform is it for?
4371 (IniDBBuilder::buildInstallSize): How big is the binary download?
4372 (IniDBBuilder::buildInstallMD5): Whats the MD5 on the binary?
4373 (IniDBBuilder::buildSourceMD5): Whats the MD5 on the source package?
4374 (IniDBBuilder::buildBeginRecommends): What other packages are
4375 recommended with this one?
4376 (IniDBBuilder::buildBeginSuggests): And suggested?
4377 (IniDBBuilder::buildBeginReplaces): What packages does this replace?
4378 (IniDBBuilder::buildBeginConflicts): And collide with?
4379 (IniDBBuilder::buildBeginProvides): What virtual packages (or obsolete
4380 package names) does this provide?
4381 (IniDBBuilder::buildDescription): Grab a multi line description one
4382 line at a time.
4383 (IniDBBuilder::buildSourceName): What source package should be used to
4384 install the source for this binary package?
4385 (IniDBBuilder::buildSourceNameVersion): Is a specific version needed?
ca2b7505 4386 (IniDBBuilder::buildPackageListAndNode): Add another AND clause to a
aa1e3b4d
RC
4387 list of package specifications.
4388 (IniDBBuilder::buildPackageListOrNode): Add another OR clause.
4389 (IniDBBuilder::buildPackageListOperator): Add a versioning operator
4390 to the current specification.
4391 (IniDBBuilder::buildPackageListOperatorVersion): What version does the
4392 operator act on?
4393 * IniDBBuilder.h: Declare all the IniDBBuilder.cc changes.
4394 * IniDBBuilderPackage.cc: As for IniDBBuilder.cc.
4395 (IniDBBuilderPackage::IniDBBuilderPackage): Iniitialize new members.
ca2b7505 4396 (IniDBBuilderPackage::process_src): Streamline and split out
aa1e3b4d
RC
4397 functionality.
4398 (IniDBBuilderPackage::setSourceSize): From process_src.
4399 * IniDBBuilderPackage.h: Declare the IniDBBuilderPackage.cc changes.
4400 (IniDBBuilderPackage::currentSpec): Track the in-progress specifiation.
4401 (IniDBBuilderPackage::currentOrList): Track the current Or list.
4402 (IniDBBuilderPackage::currentAndList): Track the current And list.
4403 * IniParseFeedback.cc (IniParseFeedback::progress): Provide completion
349bd18c 4404 progress on parsing.
aa1e3b4d
RC
4405 (IniParseFeedback::iniName): Tell what ini filename we are currently
4406 processing.
4407 * IniParseFeedback.h: Declare IniParseFeedback.cc changes.
ca2b7505 4408 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
aa1e3b4d
RC
4409 Make the feedback object non-const to allow mutating methods which are
4410 needed when the object has state.
4411 (IniParseFindVisitor::visitFile): Tell the caller the name of each
4412 .ini found.
4413 Initialise the parser with the feedback object to allow it to tell of
4414 progress.
4415 * IniParseFindVisitor.h: Declare IniParseFindVisitor.cc changes.
4416 * Makefile.am (inilinst_SOURCES): Add more requisite classes.
4417 (setup_SOURCES): Add the new PackageSpecification sources.
4418 * ScanFindVisitor.cc (ScanFindVisitor::visitFile): Use the new
4419 builder syntax to setup binary package details.
4420 * choose.cc: Use the LogSingleton calls throughout.
4421 * configure.in: Create the INILINT substitution correctly for recent
4422 autotool configurations.
4423 * cygpackage.cc (cygpackage::getfirstfile): Return an empty String
4424 rather than a string built from an int. Thanks to Pavel Tsekov for
4425 identifying the bug.
4426 (cygpackage::getnextfile): Ditto.
4427 * download.cc: Use LogSIngletion calls throughout.
ca2b7505 4428 (validateCachedPackage): A refactoring of the
aa1e3b4d
RC
4429 check_for_cached code to eliminate duplciation.
4430 (check_for_cached): Use validateCachedPackage to check packages.
ca2b7505 4431 * ini.cc (GuiParseFeedback): Provide gui feedback on ini name and
aa1e3b4d
RC
4432 parsing progress.
4433 (do_remote_ini): Ditto.
4434 * ini.h (ini_init): Pass a IniParseFeedback to the parser, to allow
4435 progress reporting.
4436 * inilex.l: Identify new symbols - operators, and multi line plain text.
4437 Releases files.
4438 * inilintmain.cc (show_help): Provide basic infomation on inilint.
4439 * iniparse.y: Adjust for the new builder syntax, and process debian
4440 Release files.
4441 * io_stream_file.cc: Always include mkdir.h.
4442 * list.h: Factor index location into a private routine.
4443 (list::findindex): Implement this.
ca2b7505 4444 * mkdir.cc (mkdir_p): Make the use of WIN32 code conditional on mingw
aa1e3b4d
RC
4445 builds. NB: This breaks cygwin build functionality still.
4446 * package_meta.cc: Use the LogSingleton calls throughout.
4447 (packagemeta::set_requirements): Adjust for object changes in
4448 dependencies.
4449 * package_meta.h (packagemeta::packagemeta): Initialise new members.
ca2b7505 4450 (packagemeta::architecture): What platform does this package run on?
aa1e3b4d 4451 This may need to move in the future to a per packagefile object.
58b12a06 4452 (packagemeta::priority): What priority does this package have?
aa1e3b4d
RC
4453 * package_source.h (packagesource::packagesource): Initialise new
4454 members.
4455 (packagesource::installedSize): How much space does the package need?
4456 (packagesource::setInstalledSize): Tell the amount.
4457 (packagesource::_installedSize): And store it.
ca2b7505 4458 * package_version.cc (packageversion::sourcePackage): return the
aa1e3b4d
RC
4459 source package.
4460 (packageversion::setSourcePackage): And set it.
4461 * package_version.h: Declare the package_version.cc changes.
4462 (packageversion::depends): New package specification AND list.
4463 (packageversion::predepends): Ditto.
4464 (packageversion::recommends): Ditto.
4465 (packageversion::suggests): Ditto.
4466 (packageversion::replaces): Ditto.
4467 (packageversion::conflicts): Ditto.
4468 (packageversion::provides): Ditto.
4469 (packageversion::sourcePackage): What source package is needed?
4470 * threebar.cc (ThreeBarProgressPage::SetText4): Set the label beside
4471 the bottom bar.
4472 * threebar.h: Declare the threebar.cc change.
4473
44742002-06-27 John Marshall <johnm@falch.net>
4475
4476 * res.rc (SETUPINI_MISSING): Make trailing spaces visible.
4477 * site.cc (SitePage::OnMessageCmd): Ditto
4478
2a994e0b
RC
44792002-06-15 Robert Collins <rbtcollins@hotmail.com>
4480
4481 * nio-ie5.cc (NetIO_IE5::NetIO_IE): Allow cached data.
4482
ceff7035
RC
44832002-06-15 Robert Collins <rbtcollins@hotmail.com>
4484
4485 * package_meta.cc (packagemeta::set_action): When installing packages
4486 with no binaries, choose the source package.
4487
9bd27040
RC
44882002-06-10 Robert Collins <rbtcollins@hotmail.com>
4489
4490 * IniParseFindVisitor (IniParseFindVisitor::visitFile): Apply Max
ca2b7505 4491 Bowshers fix for the crash with a root level setup.ini.
9bd27040
RC
4492 * README: Update todos.
4493
1dcff4a0
RC
44942002-05-26 Ralf Habacker <ralf.habacker@freenet.de>
4495
4496 * archive_tar.cc (archive_tar::next_file_name()): fixed broken
4497 GNU long name extension support.
349bd18c 4498
0773e4f2
RC
44992002-05-27 Robert Collins <rbtcollins@hotmail.com>
4500
ca2b7505 4501 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Don't
0773e4f2
RC
4502 unescape 0 length strings.
4503
a828d772
RC
45042002-05-20 Robert Collins <rbtcollins@hotmail.com>
4505
4506 * package_meta.cc (packagemeta::set_action): Don't allow reinstall
4507 when local with no cached file, and install the default source if the
4508 default version has no binary.
4509
67829ce0
RC
45102002-05-19 Robert Collins <rbtcollins@hotmail.com>
4511
4512 * IniDBBuilderPackage.cc (IniDBBuilderPackage::IniDBBuilderPackage): New
349bd18c 4513 method.
ca2b7505 4514 (IniDBBuilderPackage::buildVersion): Provide a warning when a newer
67829ce0
RC
4515 setup version created the ini file.
4516 * IniDBBuilderPackage.h (IniDBBuilderPackage::IniDBBuilderPackage): New
4517 method.
4518 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use the new
4519 feedback strategy.
4520 * IniParseFindVisitor.h (IniParseFindVisitor::IniParseFindVisitor):
4521 Require a feedback strategy.
4522 * Makefile.am (setup_SOURCES): Add IniParseFeedback sources.
4523 * Makefile.in: Regenerate.
4524
4849e2fc
RC
45252002-05-19 Robert Collins <rbtcollins@hotmail.com>
4526
4527 * io_stream_file.cc (io_stream_file::remove): Use the SetFileAttributes
4528 trick to delete read only files.
ca2b7505 4529 * io_stream_cygfile.cc (io_stream_cygfile::remove): Use file:// to
4849e2fc
RC
4530 remove files.
4531 * Makefile.am (release): Tweak to be more helpful.
4532 * Makefile.in: Regenerate.
4533
7cb35117
RC
45342002-05-19 Robert Collins <rbtcollins@hotmail.com>
4535
4536 * Makefile.am (release): Tweak to be more helpful.
4537 * Makefile.in: Regenerate.
7cb35117 4538
5090e3ce
RC
45392002-05-19 Robert Collins <rbtcollins@hotmail.com>
4540
4541 * Makefile.am (release): Tweak to be more helpful.
4542 * Makefile.in: Regenerate.
4543
9e9b881a
RC
45442002-05-19 Robert Collins <rbtcollins@hotmail.com>
4545
ca2b7505 4546 * choose.cc (scan_downloaded_files): When a non-installed version
9e9b881a
RC
4547 has neither bin nor src cached files for local installs,
4548 remove the version from availability.
4549
ea36e064
RC
45502002-05-19 Robert Collins <rbtcollins@hotmail.com>
4551
4552 * ini.cc (do_remote_ini): Save uncompressed ini's correctly.
4553
b401ef47
RC
45542002-05-19 Robert Collins <rbtcollins@hotmail.com>
4555
4556 * rsync: New support library, contains librsync. This is not (yet)
349bd18c 4557 rsync interoperable.
b401ef47
RC
4558 * configure.in: --with-rsync to enable rsync support. (Not complete).
4559 * Makefile.am: Enable building with rsync.
4560 * Makefile.in: Regenerate.
4561 * configure: Ditto.
4562 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Pass the md5 as
4563 an array.
4564 (IniDBBuilder::buildPackageSource): Ditto.
4565 * IniDBBuilder.h: Ditto.
4566 * IniDBBuilderPackage.cc: Ditto.
4567 * IniDBBuilderPackage.h: Ditto.
4568 * FindVisitor.cc: New file.
4569 * FindVisitor.h: New file, interface for visiting a file system
4570 aggregate.
4571 * IniParseFindVisitor.cc: New file.
ca2b7505 4572 * IniParseFindVisitor.h: New file, concrete FindVisitor that parses
b401ef47
RC
4573 found setup.ini's.
4574 * README: Update TODO's.
4575 * String++.cc (String::String): New constructor for <string> inter-
4576 operability.
4577 (String::substr): New method.
4578 * String++.h: Ditto.
4579 * choose.cc (scan2): Remove.
4580 (scan_downloaded_files): Simplify.
4581 * dialog.h: Include parsing pre-requirements.
4582 * download.cc (check_for_cached): Fullname was used incorrectly - fix.
4583 * filemanip.cc (parse_filename): -src packages where incorrectly parsed.
4584 * find.cc: Rewrite. Now uses a Visitor pattern and is re-entrant.
4585 * find.h: Ditto.
4586 * fromcwd.cc: Remove unneeded includes.
4587 (is_test_version): Remove.
4588 (found_file): Remove.
4589 (SetupFindVisitor): Trivial visitor to detect setup.ini's.
4590 (found_ini): Remove.
4591 (do_fromcwd): Remove commented code that has be replaced elsewhere.
4592 * ini.cc (local_ini): Remove.
4593 (findBuilder): Remove.
4594 (find_routine): Remove.
4595 (do_local_ini): Use new IniParseFindVisitor.
4596 * iniparse.y: Typecase MD5 arrays, as we know they are allocated as
4597 unsigned char.
4598 * postinstall.cc: Remove non-core includes.
4599 (run_script_in_postinstall): Remove.
4600 (RunFindVisitor): Trivial Visitor, runs each found script.
4601 (do_postinstall): Use new find syntax.
4602
0d4e0aad
CF
46032002-05-14 Christopher Faylor <cgf@redhat.com>
4604
4605 * ini.cc (find_routine): Don't clear buffer it it's NULL.
4606
46072002-05-14 Christopher Faylor <cgf@redhat.com>
4608
4609 * filemanip.h (trail): Declare.
4610 * filemanip.cc (trail): New function.
4611 (find_tar_ext): Use trail() instead of strstr().
4612 * fromcwd.cc (check_ini): Ditto.
4613 * ini.cc (find_routine): Ditto. Don't tack local_dir to path since it
4614 should now be fully qualified. Set ini_filename. Reset error_buf and
4615 error_count for any subsequent ini file parsing.
4616 (ini_filename): New static variable for parse error reporting.
4617 (yyerror): Use full path of setup.ini in error message. Subtract one
4618 from line number if at bol.
4619 * find.cc (found_part): Eliminate.
4620 (find_sub): Call for_each with full path found rather than just file
4621 component.
4622 (find): Don't calculate found_part.
4623 * inilex.l (ini_init): Flush input buffer and reset line number.
4624 (yybol): New function. Exports YY_AT_BOL.
4625 * iniparse.y: Increase stack depth to allow more tokens to be processed.
4626 (yyparse): Remove newline from error condition to allow subsequent
4627 per-line error processing to proceed normally.
4628
46292002-05-14 Christopher Faylor <cgf@redhat.com>
4630
4631 * find.cc (find_sub): Be more defensive in preserving trailing parts of
4632 components when doing recursive directory searches or calling user
4633 supplied for_each().
4634 * ini.cc (find_routine): Don't assume that any path name with
4635 "setup.ini" in it is actually a setup.ini file. Only honor trailing
4636 components. Copy path argument to temporary storage when unescaping
4637 to prevent nuking of argument.
4638
874c569a
RC
46392002-05-12 Robert Collins <rbtcollins@hotmail.com>
4640
4641 * CONTRIBUTORS: New file.
4642
f6a81f69
RC
46432002-04-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
4644
4645 * choose.cc: Run indent.
4646 (nextbutton): Remove static variable.
4647 (default_trust): Remove use of nextbutton.
4648 (set_view_mode): Ditto.
4649 (create_listview): Add IDC_CHOOSE_PREV and IDC_CHOOSE_NEXT to ta[] so
4650 rbset() sets the prev/next/curr radio buttons properly.
4651 (dialog_cmd): Delete function.
4652 (dialog_proc): Delete function. Move WM_INITDIALOG functionality to
4653 ChooserPage::OnInit.
4654 (do_choose): Delete function. Move pre-DialogBox() code to
4655 ChooserPage::OnInit(), post-DialogBox() code to ChooserPage::OnNext.
4656 (WM_APP_START_CHOOSE): Remove define.
4657 (WM_APP_CHOOSE_IS_FINISHED): Remove define.
4658 (do_choose_thread): Delete function.
4659 (ChooserPage::OnActivate): Delete method.
4660 (ChooserPage::OnMessageApp): Delete method.
4661 (ChooserPage::OnInit): New method.
4662 (ChooserPage::OnNext): New method.
4663 (ChooserPage::OnBack): New method.
4664 (ChooserPage::OnMessageCmd): New method.
4665 * choose.h: Run indent.
4666 (ChooserPage::OnMessageApp): Delete declaration.
4667 (ChooserPage::OnActivate): Ditto.
4668 (ChooserPage::OnMessageCmd): New declaration.
4669 (ChooserPage::OnInit): Ditto.
4670 (ChooserPage::OnNext): Ditto.
4671 (ChooserPage::OnBack): Ditto.
4672 * desktop.cc (DesktopSetupPage::OnBack): Replace use of IDD_CHOOSER
4673 with IDD_CHOOSE.
4674 * fromcwd.cc (do_fromcwd): Replace use of IDD_CHOOSER with IDD_CHOOSE.
4675 * ini.cc (do_ini_thread): Replace use of IDD_CHOOSER with IDD_CHOOSE.
4676 * res.rc (IDD_CHOOSE): Remove dialog template.
4677 (IDD_CHOOSER): Alter dialog template to fit wizard size and format.
4678
74617327
RC
46792002-05-12 Robert Collins <rbtcollins@hotmail.com>
4680
4681 * LogFile.cc (endLog): Work around an apparent libg++-3 bug causing
4682 corrupt log file entries.
4683 * geturl.cc: Convert to the new LogSingleton logging.
4684
3272d625
RC
46852002-05-12 Robert Collins <rbtcollins@hotmail.com>
4686
4687 * ini.cc (do_remote_ini): Use setup.bz2 if it exists in preference to
4688 setup.ini.
4689
fc687221
RC
46902002-05-12 Robert Collins <rbtcollins@hotmail.com>
4691
4692 * geturl.h: Declare getUrlToStream.
4693 * geturl.cc (getUrlToStream): New function.
4694 (get_url_to_membuf): Refactor to use getUrlToStream.
4695
902c8a3f
RC
46962002-05-11 Robert Collins <rbtcollins@hotmail.com>
4697
4698 * Makefile.am: Add a release target to automate some of the routine
4699 work.
4700 * Makefile.in: Regenerate.
4701
2ab26cdb
RC
47022002-05-11 Robert Collins <rbtcollins@hotmail.com>
4703
4704 * choose.cc (scan_downloaded_files): On local installs remove all
4705 mirror sites if no cached copy of a package is found.
4706
94852d65
RC
47072002-05-10 Robert Collins <rbtcollins@hotmail.com>
4708
4709 * Makefile.in: Regenerate.
58b12a06 4710 * iniparse.y: Use left recursion, not right in the lines rule to
94852d65
RC
4711 avoid stack overflows.
4712 * README: Update TODO's.
4713 * io_stream_file.cc: Native builds need to include sys/stat.h
4714
3548fbc3
RC
47152002-05-06 John Marshall <jmarshall@acm.org>
4716
4717 * site.cc (SitePage::OnMessageCmd): recalculate navigation
4718 button activation when "Add" is pressed.
4719 (SitePage::CheckControlsAndDisableAccordingly): tweak comment.
4720
47212002-05-07 Robert Collins <rbtcollins@hotmail.com>
2b48ecd0
RC
4722
4723 * Makefile.am (inlint_SOURCES): Add conditional objects to inilint
4724 depending on platform.
4725 Add file:// support.
4726 * configure.in: Set conditional MINGWTARGET if compiling against mingw
4727 libraries.
4728 * Makefile.in: Regenerate.
4729 * configure: Ditto.
4730 * io_stream_file.cc: Only use win32 calls when building for mingw.
4731
19911586
RC
47322002-05-05 Robert Collins <rbtcollins@hotmail.com>
4733
4734 * Makefile.am (noinst_PROGRAMS): Make inilint configurable.
4735 * configure.in: Ditto.
4736 Fix incorrect header checking syntax.
4737 * aclocal.m4: Regenerate.
4738 * configure: Regenerate.
4739 * Makefile.in: Regenerate.
4740 * io_stream.cc: Remove platform specific and provider specific code.
4741 (io_stream::registerProvider): New method, registers a Url provider with
4742 the io_stream code.
4743 Make all methods consistently throw invalid_argument exceptions when
4744 a provider that is requested is not present.
4745 (findProvider): New private function, finds a provider.
4746 * io_stream.h: Declare io_stream::registerProvider.
4747 * io_stream_cygfile.cc: Create a Provider class to register with
4748 io_stream.cc.
4749 * io_stream_file.cc: Ditto.
4750 * archive.cc: Remove unneeded includes.
4751 * archive_tar.cc: Remove unneeded includes.
4752 * archive_tar.h: Add required include.
4753 * archive_tar_file.cc: Remove unneded includes.
4754 * choose.cc: Remove unneeded includes:
4755
bf4ffcd9
RC
47562002-05-04 Robert Collins <rbtcollins@hotmail.com>
4757
4758 * io_stream.cc: Use the new log interface thruout.
4759
9f4a0c62
RC
47602002-05-04 Robert Collins <rbtcollins@hotmail.com>
4761
4762 * log.cc (log): Reimplement via LogSingleton.
4763 (log_save): Remove.
4764 (exit_setup): Remove.
4765 * log.h (log_save): Remove.
4766 (exit_setup): Remove.
4767 * LogSingleton.cc: New file.
4768 * LogSingleton.h: New file.
4769 * LogFile.cc: New file.
4770 * LogFile.h: New file.
4771 * Makefile.am (inilint_SOURCES): Add the new log interface.
4772 (setup_SOURCES): Add the new log interface and the concrete File
4773 implementation.
4774 * Makefile.in: Regenerate.
4775 * archive.cc: Use the new log interface thruout.
4776 * archive_tar.cc: Ditto.
4777 * main.cc: Ditto.
4778 * dialog.cc (fatal): Use the new log interface.
4779 * ini.cc (do_ini_thread): Use the log interface to exit.
4780 * isntall.cc (do_install_thread): Ditto.
4781 * netio.cc (auth_cmd): Ditto.
4782 * msg.cc (fatal): Ditto.
4783 * localdir.cc (save_local_dir): Save to different files depending on
4784 the mode, and if a root dir exists.
4785
076654e7
RC
47862002-05-04 Robert Collins <rbtcollins@hotmail.com>
4787
4788 * IniDBBuilder.cc: New file.
4789 * IniDBBuilder.h: New file.
4790 * IniDBBuilderPackage.cc: New file.
4791 * IniDBBuilderPackage.h: New file.
4792 * PackageTrust.h: New file.
4793 * IniState.h: Remove, wasn't thought out well enough.
4794 * Makefile.am (inilint_SOURCES): Add more requirements.
4795 (setup_SOURCES): Add new Builder base and concrete classes.
4796 * Makefile.in: Regenerate.
4797 * String++.cc (String::String): Implement int contructor.
4798 * String++.h (String): Declare int constructor.
4799 * archive_tar.cc (archive_tar::next_file_name): Return String() when
4800 no filename exists.
4801 * archive_tar.h (archive_tar_file): Remove get_next_filename method,
4802 it's not needed.
4803 * ini.cc: Replace IniState wuth IniDBBuilderPacakge.
4804 (find_routine): Use new IniDBBuilder to configure the parser.
4805 (do_local_ini): Ditto.
4806 (do_remote_ini): Ditto.
4807 * ini.h: Use IniDBBuilder to initialise parsing.
ca2b7505 4808 * inilex.l (MD5): Parse the MD5 string correctly, we had the nibbles
076654e7
RC
4809 swapped.
4810 (ini_init): Use an IniDBBuilder rather than static variables.
4811 * iniparse.y: Hand off all the object creation to a builder, rather
ca2b7505 4812 than hardcoding the behaviour. This allows run-time configured
076654e7 4813 behaviour.
ca2b7505 4814 * io_stream_cygfile.h (io_stream_cygfile): Remove get_next_filename
076654e7
RC
4815 method, it's not needed.
4816 * io_stream_file.h (io_stream_file): Ditto.
4817 * mount.cc (cygpath): Return String() for missing mounts.
4818 * package_meta.cc (packagemeta::SDesc): Return String() for blank
4819 descriptions.
4820 * package_meta.h (trusts): Remove - replaced by PackageTrust.h.
4821 (packagemeta::packagemeta): Fix incorrect syntax in String constructor
4822 usage.
ca2b7505 4823 * cygpackage.cc (cygpackage::cygpackage): Fix incorrect syntax in
076654e7
RC
4824 String constructor usage.
4825 * site.h (site_list_type): Ditto.
4826
6391823e
RC
48272002-05-03 Robert Collins <rbtcollins@hotmail.com>
4828
4829 * String++.h: Declare a << operator that accepts String objects.
4830 * String++.cc: We need iostream for..
4831 (operator <<): this. Provide a << operator that accepts String objects.
4832 * ini.cc (yyerror): Remove the "C" classifier - it's not needed.
4833 Change from vargs to a String parameter.
4834 * inilintmail.cc: Remove the gui related headers.
4835 (yyerror): Implement this for parsing.
4836 * iniparse.y: Use the new yyerror syntax.
4837
b92028a4
RC
48382002-05-03 Robert Collins <rbtcollins@hotmail.com>
4839
4840 * Makefile.am: Add IniState.h.
4841 * Makefile.in: Regenerate.
4842 * IniState.h: New file.
4843 * choose.cc: Don't include ini.h - it's not needed.
4844 * configure: Regenerate.
4845 * desktop.cc: Don't include ini.h - it's not needed.
4846 * download.cc: Ditto.
4847 * fromcwd.cc: Ditto.
4848 * ini.cc: Use IniState.h to track each parsing calling.
4849 (find_routine): Ditto.
4850 (do_remote_ini): Ditto.
4851 (do_ini_thread): Ditto.
4852 * ini.h (ini_init): Adjust parameters to include state object.
4853 * inilex.l: Declare parser state variable.
4854 (ini_init): Adjust parameters to include state object.
ca2b7505 4855 * iniparse.y: Remove obsolete setup_timestamp and setup_version
b92028a4
RC
4856 declarations.
4857 (setup_header): Use new state variable to track time and version.
4858 (add_correct_version): Ditto.
4859 * install.cc: Don't include ini.h - it's not needed.
4860
e0a4db64
RC
48612002-05-03 Robert Collins <rbtcollins@hotmail.com>
4862
4863 * nio-files.cc (NetIO): Use io_stream syntax for get_file_size.
4864 * io_stream_file.cc: Don't include filemanip.h.
4865 (io_stream_file::get_size): Implement here to remove filemanip
4866 dependency.
4867 * io_stream_cygfile.cc: Don't include filemanip.h.
4868 (io_stream_cygfile::get_size): Implement here to remove filemanip
4869 dependency.
4870 Implement a stat based version for when win32 is not available.
4871 * filemanip.h (get_file_size): Return size_t - it's more appropriate.
4872 * filemanip.cc: Don't include win32.h - be platform independent.
4873 Include strings.h and io_stream.h as part of that.
4874 (get_file_size): Leverage io_streams and remove win32 implementation.
4875 * download.cc (check_for_cached): Use io_stream syntax for
4876 get_file_size.
4877 (download_one): Ditto.
4878
48792002-05-02 Robert Collins <rbtcollins@hotmail.com>
ac65f5c5
RC
4880
4881 * configure.in: Correct a typo in last change.
4882 * configure: Regenerate.
4883 * Makefile.in: Regenerate.
4884
e0a4db64 48852002-05-02 Robert Collins <rbtcollins@hotmail.com>
e06ded88
RC
4886
4887 * configure.in: Check for string.h and string.
4888 * configure: Regenerate.
4889 * Makefile.in: Regenerate.
4890
1fd0694a
RC
48912002-05-01 Robert Collins <rbtcollins@hotmail.com>
4892
4893 * res.rc (IDD_SPLASH): Remove white box.
4894
89ca06c0
RC
48952002-05-01 Robert Collins <rbtcollins@hotmail.com>
4896
4897 Oops! forgot to list these in the last checkin.
4898 * inilintmain.cc: New file.
4899 * md5.h: New file - imported md5 source, BSD style licence.
4900 * md5.cc: New file - imported md5 source, BSD style licence.
4901 * Exception.cc: New file.
4902 * Exception.h: New file.
4903 * MD5++.cc: New file.
4904 * MD5++.h: New file.
4905
58ee6135
RC
49062002-05-01 Robert Collins <rbtcollins@hotmail.com>
4907
ca2b7505 4908 * Makefile.am (AM_CFLAGS): Remove -mwindows, it's a linker flag.
58ee6135
RC
4909 Remove -fno-rtti, we need it for exceptions.
4910 (AM_CXXFLAGS): Ditto.
4911 (WARNONLY_CFLAGS): Ditto.
4912 (EXTRA_PROGRAMS): Add with initial linter sources - not functional yet.
4913 (setup_LDFLAGS): Add and set to -mwindows.
4914 (setup_SOURCES): Add new sources.
4915 * Makefile.in: Regenerate.
4916 * README: Update TODO.
4917 * choose.cc (scan_downloaded_files): Use ini information if it's
4918 available.
4919 * configure: Regenerate.
4920 * download.cc (check_for_cached): Make reusable from elsewhere.
4921 Throw exceptions on errors (as opposed to failures).
4922 Check MD5 sum when it's known.
4923 (download_one): Never force a download.
4924 Handle corrupt package exceptions.
4925 * ini.cc (find_routine): Reverse escape the URL to correctly identify
4926 the site URL.
4927 * inilex.l (MD5): Provide a parsing rule (note: lowercase is required).
ca2b7505 4928 * iniparse.y: Allow calculation of MD5 sums, and allow src only
58ee6135
RC
4929 packages.
4930 (process_src): New helper function.
4931 * isntall.cc (install_one_source): Check MD5 sums when possible.
4932 Throw exceptions on errors.
4933 (do_install_thread): Handle exceptions for installation calls.
4934 * package_source.h: Store MD5 information.
4935 * propsheet.cc (PropSheet::Create): Add a useful comment.
4936 * res.rc (IDS_INSTALL_ERROR): Define.
4937 (IDS_CORRUPT_PACKAGE): Define.
4938 * resource.h (IDS_INSTALL_ERROR): Define.
4939 (IDS_CORRUPT_PACKAGE): Define.
4940 * rfc1738.cc (rfc1738_unescape_part): Implement.
4941 * rfc1738.h (rfc1738_unescape_part): Declare.
4942
45e01f23
RC
49432002-04-29 Robert Collins <rbtcollins@hotmail.com>
4944
4945 * Makefile.am: Remove dependecy rules that automake emits.
4946 Correct badly copied dependency info for manually compiled files.
58b12a06 4947 (setup_SOURCES): Add all used headers.
45e01f23
RC
4948 (EXTRA_DIST): Include non compilate but required sources.
4949 (setup_LDADD): Remove mingw32, it is autodetected.
4950 * Makefile.in: Regenerate.
4951 * String++.h: sys/types is a system header.
4952 * choose.cc (do_choose_thread): Make into a Win32 thread routine.
4953 Use ExitThread.
4954 (ChooserPage::OnMessageApp): Use Win32 threads. (_beginthread is not
4955 portable).
4956 * configure: Regenerate.
4957 * configure.in: Check for mingw32/cygwin specific headers and libraries.
ca2b7505 4958 * cygpackage.h: Include the win32.h header to get correct macro
45e01f23
RC
4959 definitions in all situations.
4960 * download.cc (do_download_reflector): Make into a Win32 thread routine.
4961 Use ExitThread.
4962 (do_download): Use Win32 threads.
4963 * ini.cc: Ditto.
4964 * install.cc: Ditto.
ca2b7505 4965 * (WinMain): Adjust to build valid command line using application
45e01f23 4966 under both mingw32 and cygwin.
ca2b7505 4967 * mount.cc (set)cygdrive_flags): Create new system flags if the
45e01f23
RC
4968 user requests system and the value does not exist.
4969 * nio-http.cc: Define a _strnicmp for cygwin.
4970 * package_db.cc: Include <errno.h> if it exists.
ca2b7505 4971 * site.cc (do_download_site_info_thread): Make into a Win32 thread
45e01f23
RC
4972 routine.
4973 Use ExitThread.
4974 (do_download_site-Info): Use Win32 threads.
ca2b7505 4975 * state.cc: Explicity declare variables to avoid header conflicts
45e01f23
RC
4976 caused by '#define extern" on cygwin.
4977 * win32.h: Include <alloca.h> if it exists.
4978 (_MAX_PATH): Define as MAX_PATH when not defined by windows.h.
4979 (_access): Define as access if not defined by windows.h.
4980
8bb9dad9
RC
49812002-04-27 Robert Collins <rbtcollins@hotmail.com>
4982
4983 * compress_gz.cc (compress_gz::error): EOF is not an error condition.
4984
6908b7d7
RC
49852002-04-27 Robert Collins <rbtcollins@hotmail.com>
4986
4987 * Makefile.am: Add libgetopt++ to the subdirs list.
4988 Search the libgetopt++ header directory.
4989 Link against libgetopt++.la.
4990 (setup_SOURCES): Remove GetOption.cc and getopt.c and Option.cc.
4991 (setup_LDADD): Explicitly include res.o.
4992 * Makefile.in: Regenerate.
4993 * aclocal.m4: Regenerate.
4994 * bootstrap.sh: Call libtoolize.
4995 * configure: Regenerate.
4996 * configure.in: Add libtool support and configure libgetopt++.
4997 * desktop.cc (NoShortcutsOption): Turn into a BoolOption.
4998 (DesktopSetupPage::OnInit): Use the simpler syntax.
4999 * desktop.h: Remove dependency on Option.h, and remove NoShortcustOption
5000 declaration.
5001 * main.cc: Include getopt++/GetOption.h.
5002 (main): Use simpler syntax.
5003 * cdefs.h: Remove.
5004 * getopt.h: Remove.
5005 * getopt.c: Remove.
5006 * GetOption.h: Remove.
5007 * GetOption.cc: Remove.
5008 * Option.h: Remove.
5009 * Option.cc: Remove.
5010
9063358a
RC
50112002-04-26 Robert Collins <rbtcollins@hotmail.com>
5012
5013 * Makefile.am: Add zlib and bz2lib to SUBDIRS.
5014
f6100b6f
RC
50152002-04-26 Robert Collins <rbtcollins@hotmail.com>
5016
5017 * aclocal.m4: New file, cached macros.
ca2b7505 5018 * bootstrap.sh: New file, calls required autotools in appropriate
f6100b6f
RC
5019 order.
5020 * Makefile.am: New file, input Makefile for automake.
5021 * Makefile,in: Now a generated file - regenerate.
5022 * configure: Regenerate.
5023 * configure.in: Add automake support.
5024 * inilex.l: Change VERSION to PACKAGEVERSION to avoid a collision with
5025 automake's VERSION define.
5026 * iniparse.y: Ditto.
5027
db04fc41
RC
50282002-04-26 Robert Collins <rbtcollins@hotmail.com>
5029
5030 * cdefs.h: New file, imported to allow getopt.c to build without
5031 cygwin headers.
5032 * getopt.h: New file, imported to allow building without cygwin headers.
5033 * getopt.c: Ditto.
5034 * bz2lib: New directory, contains copy of bz2lib.
5035 * cfgaux: New directory, contains autotool helper scripts.
ca2b7505 5036 * Makefile,in: Adjust library and target definitions for building
db04fc41
RC
5037 outside the sourceware tree.
5038 * compress_bz.h: Use new bz2lib header location.
5039 * mount.cc: Import key defines and enums to be independent of cygwin
5040 headers.
ca2b7505 5041 * configure.in: Update to autoconf 2.53, and to be sourceware
db04fc41
RC
5042 independent.
5043 * configure: Regenerate.
5044
931f2755
RC
50452002-04-12 Robert Collins <rbtcollins@hotmail.com>
5046
5047 * mklink2.cc (make_link_2): Tweak to work with current w32api
5048 headers.
5049
50502002-04-10 Pavel Tsekov <ptsekov@gmx.net>
5051
5052 * version.cc (canonicalize_version): Fix a call delete[]
5053 to delete the allocated address.
5054
50552002-03-29 Robert Collins <rbtcollins@hotmail.com>
5056
5057 * PickView.cc (PickView::set_headers): Set last_col correctly. Thanks
5058 to Ton van Overbeek for locating the bug area.
5059
49cf3899
RC
50602003-03-27 Robert Collins <rbtcollins@hotmail.com>
5061
5062 * PickView.cc (PickView::insert_pkg): Be more generic with
5063 object use.
5064 (PickView::insert_category): Ditto.
5065 (PickView::~PickView): Create.
5066 * PickView.h (PickView::~PickView): Declare.
5067
1be8f8fd
RC
50682003-03-27 Robert Collins <rbtcollins@hotmail.com>
5069
5070 * Makefile.in (OBJS): Add new commandline objects.
5071 * desktop.cc (NoShortCutsOption): New option code.
5072 (DesktopSetupPage::OnInit): Check whether to skip shortcuts.
5073 * desktop.h (NoShortCutsOption): New concrete command line option class.
5074 * main.cc (WinMain): Process command line options.
5075 * GetOption.h: New file, singleton command line class.
5076 * GetOption.cc: New file, implementation of the above.
5077 * Option.h : New file, abstract option for GetOption.
5078 * Option.cc: New file, implement constructor and destructor.
5079
f2e49cf8
RC
50802002-03-26 Pavel Tsekov <ptsekov@gmx.net>
5081
58b12a06 5082 * mkdir.cc (mkdir_p): Stop processing if the path is exhausted.
f2e49cf8
RC
5083
50842002-03-26 Ton van Overbeek <tvoverbe@cistron.nl>
5085
58b12a06
MB
5086 * PickPackageLine.cc (PickPackageline::paint): Adjust clipping rectangle
5087 to textheight, so large fonts work.
f2e49cf8
RC
5088
50892003-03-26 Robert Collins <rbtcollins@hotmail.com>
5090
58b12a06
MB
5091 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Don't translate
5092 symlinks.
f2e49cf8
RC
5093
50942003-03-26 Robert Collins <rbtcollins@hotmail.com>
5095
58b12a06
MB
5096 * io_stream_cygfile.cc (cwd): New static for cwd storage.
5097 (io_stream_cygfile::normalise): New method.
5098 (io_stream_cygfile::io_stream_cygfile): Use it.
5099 (io_stream_cygfile::exists): Ditto.
5100 (io_stream_cygfile::remove): Ditto.
5101 (io_stream_cygfile::mklink): And again.
5102 (cygmkdir_p): Yes, again.
5103 (io_stream_cygfile::move): And once more.
5104 * io_stream_cygfile.h (io_stream_cygfile::normalise): Declare.
5105 (io_stream_cygfile::cwd): Ditto.
f2e49cf8 5106
51ebb760
RC
51072003-03-26 Robert Collins <rbtcollins@hotmail.com>
5108
5109 * package_meta.cc (package_meta::~package_meta): Remove duplicate.
ca2b7505 5110 (CategoryPackage::~CategoryPackage): Ditto. (Thanks to Ton van
51ebb760
RC
5111 Overbeek for the report).
5112 * mklink2.cc: Moved from mklink2.c to avoid 'not a prototype error'.
5113 Make g++ compatible.
5114 * mklink2.c: Remove.
5115 * site.cc (site_list_type::init): Delete the correct memory addres.
5116 Thanks to Pavel Tsekov for tracking this down.
5117
e7d67c03
RC
51182002-03-20 Robert Collins <rbtcollins@hotmail.com>
5119
5120 * win32.h: Only define alloca if it's not already.
5121
2fa7c5a4
RC
51222002-03-20 Robert Collins <rbtcollins@hotmail.com>
5123
58b12a06
MB
5124 * package_meta.h (packamgemeta::trustp): Make 'test' choice leave
5125 installed packages alone.
2fa7c5a4
RC
5126 * README: Update with latest requests.
5127 * Various: MTC fixes from setup200202 branch.
5128
7bf13fc9
CF
51292002-03-19 Christopher Faylor <cgf@redhat.com>
5130
5131 * Makefile.in (setup_version.c): Add back magic which allows detection
5132 of setup.exe version number.
5133
2fa7c5a4
RC
51342002-03-17 Robert Collins <rbtcollins@hotmail.com>
5135
58b12a06 5136 * PickPackageLine.cc (PickPackageLine::paint): Fix incorrect clip region
2fa7c5a4
RC
5137 calculation on win9x systems.
5138
51392002-03-16 Robert Collins <rbtcollins@hotmail.com>
5140
58b12a06
MB
5141 * install.cc (install_one_source): Write the correct length of a string
5142 to the lst file (Thanks to Pavel Tsekov for reporting the bug).
2fa7c5a4
RC
5143
51442002-03-15 Robert Collins <rbtcollins@hotmail.com>
5145
5146 * choose.cc (list_click): Always refresh the entire chooser, as our
58b12a06
MB
5147 package state change mechanism is broken with the new improved list
5148 classes.
2fa7c5a4
RC
5149
51502002-03-15 Robert Collins <rbtcollins@hotmail.com>
5151
58b12a06
MB
5152 * desktop.cc (make_passwd_group): Check for .lnk suffix on /etc/passwd
5153 and /etc/group.
2fa7c5a4
RC
5154
51552002-03-15 Robert Collins <rbtcollins@hotmail.com>
5156
58b12a06
MB
5157 * PickPackageLine.cc (PickPackageLine::DrawCheck): New method factored
5158 out from paint().
5159 (PickPackageLine::paint): Use DrawCheck to draw the src tick box, and
5160 the new bin tickbox.
2fa7c5a4
RC
5161 (PickPackageLine::click): Handle the new bin tickbox.
5162 * PickPackageLine.h (PickPackageLine::DrawCheck): Declare this.
5163 * PickView.cc (pkg_headers): Add a Bin? column.
5164 (cat_headers): Ditto.
5165 (PickView::set_headers): Ditto.
5166 (PickView::init_headers): Ditto.
5167 * PickView.h (PickView): Ditto.
58b12a06
MB
5168 * choose.cc (list_click): Use the new name for src_col to set the clip
5169 rectangle.
2fa7c5a4
RC
5170
51712002-02-24 Michael A Chase <mchase@ix.netcom.com>
5172
5173 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Fix up Robert's
5174 fixup.
5175
51762002-02-24 Michael A Chase <mchase@ix.netcom.com>
5177
5178 * desktop.cc (make_link): Add "file://" prefix to io_stream::mkpath_p()
5179 call.
5180 (make_passwd_group): Ditto.
5181 * localdir.cc (save_local_dir): Ditto.
5182 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Wrap long lines.
5183 Add "cygfile://" prefix to io_stream::open() calls.
5184
204315f9
RC
51852002-02-24 Robert Collins <rbtcollins@hotmail.com>
5186
5187 * log.cc (log_save): Fix creating /var/log.
5188 * packate_meta.cc (standard_dirs): Remove duplicate '/''s.
5189
58db1046
RC
51902002-02-24 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5191
5192 * res.rc (STRINGTABLE): Add IDS_CYGWIN_SETUP and
5193 IDS_CYGWIN_SETUP_WITH_PROGRESS strings.
5194 * resource.h: Add IDS_CYGWIN_SETUP and
5195 IDS_CYGWIN_SETUP_WITH_PROGRESS IDs.
5196
5197 * splash.cc (OnInit): Qualify SetWindowText() call with global scope
5198 operator (::SetWindowText()).
5199
5200 * threebar.cc: Run indent.
5201 (cistring.h): Add include.
5202 (SetText1, SetText2, SetText3): Qualify SetWindowText() call with
5203 global scope operator.
5204 (SetBar2): Add logic for writing percent complete into window title.
5205
5206 * window.h: Run indent.
5207 (SetWindowText): New function.
5208 (String): Add forward declaration.
5209 * window.cc: Run indent.
5210 (String++.h): Add include.
5211 (SetWindowText): New function.
5212
490717ef
RC
52132002-02-24 Robert Collins <rbtcollins@hotmail.com>
5214
5215 * README: Update TODO list.
5216 * install.cc (install_one): Fix src package location.
5217 (do_install_thread): Fix creating directories.
5218
7c6ef2c3
RC
52192002-02-19 Robert Collins <rbtcollins@hotmail.com>
5220
5221 * choose.cc: Include cygpackage.h for scan2 use.
5222 (set_existence): Ignore setup.ini mirrors when installing from cwd.
5223 (scan2): Process any valid file.
58b12a06
MB
5224 Add cache entries when a file matching a setup.ini listed version is
5225 found.
7c6ef2c3
RC
5226 * filemanip.cc (parse_filename): Remove pkgtar - not used anywhere else.
5227 * filemanip.h (filemanip::pkgtar): Remove.
5228 * package_meta.cc (CategoryPackage::~CategoryPackage): New method.
5229 (packagemeta::~packagemeta): Move from package_meta.h
5230 Remove and delete all version and category information.
5231 * package_meta.h (CategoryPackage): Create a destructor.
5232 (packagemeta::~packagemeta): Move to .cc file.
5233
52342002-02-19 Robert Collins <rbtcollins@hotmail.com>
5235
5236 * install.cc (install_one_source): Make NULL cached package names cause
5237 errors.
5238
bb087dce
RC
52392002-02-18 Michael A Chase <mchase@ix.netcom.com>
5240
5241 * desktop.cc (make_passwd_group): Don't create passwd-grp.bat
5242 unnecessarily.
5243
52442002-02-18 Michael A Chase <mchase@ix.netcom.com>
5245
5246 * log.cc (log_save): Put "\n" at end of log lines instead of "'".
5247
c90bc3df
RC
52482002-02-19 Robert Collins <rbtcollins@hotmail.com>
5249
5250 * mount.cc (create_mount): Avoid a const char*->char* warning.
5251 (read_mounts): Ditto.
5252
3bab9a49
RC
52532002-02-05 Jason Tishler <jason@tishler.net>
5254
58b12a06 5255 * download.cc (do_download_thread): Fix off-by-one error.
3bab9a49 5256
1ac649ed
RC
52572002-02-19 Robert Collins <rbtcollins@hotmail.com>
5258
5259 * configure.in (CXXFLAGS): Substitute at configure time, not runtime.
5260 * configure (CXXFLAGS): Regenerate.
5261 * Makefile.in (iniparse.o): Build via default rules - no errors now.
5262 * README: TODO list updates.
5263
52642002-02-19 Michael A Chase <mchase@ix.netcom.com>
5265
5266 * String++.cc (String::concat):: Remove.
5267 (String::vconcat):: Ditto.
5268 * String++.h (String::concat):: Remove.
5269 (String::vconcat):: Ditto.
5270 * archive_tar.cc: Don't include concat.h.
5271 * archive_tar_file.cc: Don't include concat.h.
5272 * compress_bz.cc (compress_bz::peek): Don't log unneeded messages.
5273 (compress_bz::seek): Ditto.
5274 (compress_bz::~compress_bz): Ditto.
5275 * compress_gz.cc (compress_gz::peek): Ditto.
5276 (compress_gz::error): Ditto.
5277 (compress_gz::~compress_gz): Ditto.
5278 * concat.cc (vconcat): Remove.
5279 (concat): Ditto.
5280 * concat.h (vconcat): Remove.
5281 (concat): Ditto.
5282 * desktop.cc (desktop_icon): Use new cygpath.
5283 (make_etc_profile): Ditto.
5284 (uexists): Ditto.
5285 (make_passwd_group): Ditto.
5286 (save_icon): Ditto.
5287 (check_desktop): Remove concat use.
5288 (check_start_menu): Ditto.
5289 * download.cc (download_one): Use new mkpath_p correctly.
5290 Use LOG_PLAIN.
5291 * fromcwd.cc: Don't include concat.h.
5292 * geturl.cc (get_url_to_membuf): Use String log() call.
5293 (get_url_to_file): Ditto.
5294 * install.cc: Don't include concat.h.
5295 (uninstall_one): Use LOG_PLAIN.
5296 (replace_one): Ditto.
5297 (install_one_source): Ditto.
5298 (install_one): More char to String conversion.
5299 (do_install_thread): Use new cygpath.
5300 Use new create_mount.
5301 * io_stream.cc (io_stream::move): Use new log().
58b12a06
MB
5302 * io_stream_cygfile (io_stream_cygfile::io_stream_cygfile): Use new
5303 cygpath.
1ac649ed
RC
5304 (io_stream_cygfile::exists): Ditto.
5305 (io_stream_cygfile::remove): Ditto.
5306 (io_stream_cygfile::mklink): Ditto.
5307 (io_stream_cygfile::write): Ditto.
5308 (cygmkdir_p): Ditto.
5309 (io_stream_cygfile::move): Ditto.
5310 * io_stream_file.cc: Don't include log.h.
5311 (io_stream_file::write): Don't log unneeded messages.
5312 * localdir.cc: Don't include concat.h.
5313 (LocalDirPage::OnNext): Use LOG_PLAIN.
5314 * log.cc: Don't include log.h.
5315 (exit_setup): Use new cygpath.
5316 * log.h (log_level): Add new level LOG_PLAIN.
5317 * main.cc (WinMain): Use new log().
5318 * mount.cc (SLASH_P): New macro from concat.h.
5319 (cygpath): Make String version globally visible.
5320 Remove varargs version.
5321 * mount,h: Ditto.
5322 * msg.cc (mbox): Use LOG_PLAIN.
5323 * net.cc (NetPage::OnNext): Ditto.
5324 * nio-ftp.cc (ftp_line): Use new log().
5325 * nio-http.cc: Don't include log.h.
5326 (retry_get): Use alternative url variable.
5327 * package_db.cc: Don't include concat.h.
5328 (packagedb::flush): Don't use concat.
5329 * package_meta.cc: Don't include concat.h.
5330 (packagemeta::uninstall): Use new cygpath.
5331 * postinstall.cc (do_postinstall): Ditto.
5332 * root.cc (RootPage::OnNext): Use LOG_PLAIN.
5333 * script.cc: Don't include concat.h.
5334 (init_run_script): Use new cygpath.
5335 (run_script): More char * to String conversion.
5336 (try_run_script): Ditto.
5337 * site.cc: Don't include concat.h.
5338 (SitePage::OnNext): Use LOG_PLAIN.
5339 (SitePage::OnMessageCmd): Use new log().
5340 * source.cc (SourcePage::OnDeactivate): Use LOG_PLAIN.
5341
3c054baf
RC
53422002-02-19 Robert Collins <rbtcollins@hotmail.com>
5343
5344 * Makefile.in (OBJS): Add new object.
58b12a06
MB
5345 * PickCategoryLine.cc (PickCategoryLine::paint): Print a "+" before the
5346 name.
3c054baf
RC
5347 * PickCategoryLine.h (PickCategoryLine::bucket): Use the String class.
5348 * PickLine.h (Pickline::key): Change to a String to help plug leaks.
5349 (PickLine::Pickline): Accept a String for the key.
58b12a06
MB
5350 * PickPackageLine.cc (PickPackageLine::paint): Convert all char use to
5351 Strings.
5352 * PickPackageLine.h (PickPackageLine::PickPackageLine): The key is
5353 automatically initialised now.
3c054baf 5354 * PickView.cc (PickView::note_width): Convert all char * use to Strings.
58b12a06
MB
5355 (PickView::init_header): Move category length checking out of the inner
5356 loop for efficiency.
3c054baf
RC
5357 Convert all char use to Strings.
5358 * PickView.h: Include the String++ header.
5359 (PickView::note_width): Update the prototype.
5360 * String++.cc: New file, implements a reference counting string class.
5361 * String++.h: New file, declares a reference counting string class.
5362 * archive.cc: Include String++ instead of concat.
5363 (archive::extract_file): Convert char * usage to Strings.
5364 * archive.h: Inlude the String++ header.
5365 (archive::extract_file): Update prototype.
5366 (archive::next_file_name): Convert to a String.
5367 (archive::linktarget): Ditto.
5368 * archive_tar.cc (archive_tar::next_file_name): Convert to String usage.
5369 (archive_tar::linktarget): Ditto.
5370 * arhive_tar.h: Update the copyright.
5371 Explicitly include the relevant headers.
5372 (tar_map_result_type): Convert to String usage.
5373 (archive_tar::next_file_name): Update prototype.
5374 (archive_tar::linktarget): Ditto.
5375 * category.cc (Category::Category): Update initialisers.
5376 Convert to String usage.
5377 (Categorycmp): Update to String usage.
5378 * category.h: Include the String++ header.
5379 (Category::Category): Update to String usage.
5380 (Category::name): Ditto.
5381 (Category::key): Ditto.
5382 * choose.cc: Remove concat.h, it's not needed.
5383 (scan2): Update to String usage.
5384 (do_choose): Ditto.
5385 * cygpackage.cc: Update includes for use of String class.
5386 (cygpackage::cygpackage): Update for String usage.
5387 (cygpackage::set_canonical_version): Ditto.
5388 (cygpackage::destroy): Ditto.
5389 (cygpackage::getfirstfile): Ditto.
5390 (cygpackage::getnextfile): Ditto.
5391 (cygpackage::Name): Ditto.
5392 (cygpackage::Vendor_version): Ditto.
5393 (cygpackage::Package_version): Ditto.
5394 (cygpackage::Canonical_version): Ditto.
5395 (cygpackage::set_sdesc): Ditto.
5396 (cygpackage::set_ldesc): Ditto.
5397 * cygpackage.h: Include String++.h for parsing this file.
5398 (cygpackage::cygpackage): Update for String usage.
5399 (cygpackage::set_canonical_version): Ditto.
5400 (cygpackage::destroy): Ditto.
5401 (cygpackage::getfirstfile): Ditto.
5402 (cygpackage::getnextfile): Ditto.
5403 (cygpackage::Name): Ditto.
5404 (cygpackage::Vendor_version): Ditto.
5405 (cygpackage::Package_version): Ditto.
5406 (cygpackage::Canonical_version): Ditto.
5407 (cygpackage::set_sdesc): Ditto.
5408 (cygpackage::set_ldesc): Ditto.
5409 (cygpackage::name): Ditto.
5410 (cygpackage::vendor): Ditto.
5411 (cygpackage::packagev): Ditto.
5412 (cygpackage::canonical): Ditto.
5413 (cygpackage::fn): Ditto.
5414 (cygpackage::sdesc): Ditto.
5415 (cygpackage::ldesc): Ditto.
5416 * desktop.cc: Update includes for use of String class.
5417 (batname): Update for String usage.
5418 (iconname): Ditto.
5419 (make_link): Ditto.
5420 (start)menu): Ditto.
5421 (desktop_icon): Ditto.
5422 (make_cygwin_bat): Ditto.
5423 (make_etc_profile): Ditto.
5424 (uexists): Ditto.
5425 (make_passwd_group): Ditto.
5426 (save_icon): Ditto.
5427 (check_desktop): Ditto.
5428 (check_startmenu): Ditto.
5429 * dialog.cc (eget): Update for String usage.
5430 (egetString): New function.
5431 (eset): New variant for Strings.
5432 * dialog.h: Include String++.h for parsing this file.
5433 (egetString): New function.
5434 (eset): New variant for Strings.
5435 * diskfull.cc (diskfull): Update for String usage.
5436 * diskfull.h: Include String++.h for parsing this file.
5437 (diskfull): Update for String usage.
5438 * download.cc: Update includes for use of String class.
5439 (check_for_cached): Update for String usage.
5440 (download_one): Ditto.
5441 * filemanip.cc (get_file_size): Ditto.
5442 (base): Ditto.
5443 (parse_filename): Ditto.
5444 (backslash): Ditto.
5445 * filemanip.h: Include String++.h for parsing this file.
5446 (fileparse): Update for String usage.
5447 (base): Ditto.
5448 (parse_filename): Ditto.
5449 Don't consider '_' to be a separator.
5450 (backslash): Ditto.
5451 * find.cc: Update includes for use of String class.
5452 (find_sub): Make more flexible.
5453 (find): Update for String usage.
5454 * find.h (find): Use Strings.
5455 * fromcwd.cc (found_file): Update for String usage.
5456 * geturl.cc: Ditto.
5457 (init_dialog): Ditto.
5458 (get_url_to_membuf): Ditto.
5459 (get_url_to_string): Ditto.
5460 (get_url_to_file): Ditto.
5461 * geturl.h: Ditto.
5462 (get_url_to_membuf): Ditto.
5463 (get_url_to_string): Ditto.
5464 (get_url_to_file): Ditto.
5465 * hash.h: Ditto.
5466 (add_subdirs): Ditto.
5467 * ini.cc: Update includes for String usage.
5468 (find_routine): Update for String usage.
5469 (do_remote_ini): Ditto.
5470 (do_ini_thread): Ditto.
5471 * ini.h (ini_init): Ditto.
5472 * inilex.l: Update includes for String usage.
5473 (ini_init): Update for String usage.
5474 * iniparse.y: Ditto.
5475 (add_correct_version): Ditto.
5476 * install.cc: Update includes for String usage.
5477 (install_one_source): Update for String usage.
5478 (uninstall_one): Ditto.
5479 (replace_one): Ditto.
5480 (install_one_source): Ditto.
5481 (do_install_thread): Ditto.
5482 * io_stream.cc: Update includes for String usage.
5483 (io_stream::open): Update for String usage.
5484 (io_stream::mkpath_p): Ditto.
5485 (io_stream::remove): Ditto.
5486 (io_stream::mklink): Ditto.
5487 (io_stream::move_copy): Ditto.
5488 (io_stream::move): Ditto.
5489 (io_stream::exists): Ditto.
5490 * io_stream.h: Update includes to allow correct parsing.
5491 (io_stream::open): Update for String usage.
5492 (io_stream::mkpath_p): Ditto.
5493 (io_stream::remove): Ditto.
5494 (io_stream::mklink): Ditto.
5495 (io_stream::move_copy): Ditto.
5496 (io_stream::move): Ditto.
5497 (io_stream::exists): Ditto.
5498 * io_stream_cygfile.cc: Update includes for String usage.
5499 (get_root_dir_now): Update for String usage.
5500 (io_stream_cygfile::io_stream_cygfile): Ditto.
5501 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5502 (io_stream_cygfile::exists): Ditto.
5503 (io_stream_cygfile::remove): Ditto.
5504 (io_stream_cygfile::mklink): Ditto.
5505 (cygmkdir_p): Ditto.
5506 (io_stream_cygfile::set_mtime): Ditto.
5507 (io_stream_cygfile::move): Ditto.
5508 (io_stream_cygfile::get_size): Ditto.
5509 * io_stream_cygfile.h: Update includes for String usage.
5510 (io_stream_cygfile::io_stream_cygfile): Update for String usage.
5511 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5512 (io_stream_cygfile::exists): Ditto.
5513 (io_stream_cygfile::remove): Ditto.
5514 (io_stream_cygfile::mklink): Ditto.
5515 (cygmkdir_p): Ditto.
5516 (io_stream_cygfile::set_mtime): Ditto.
5517 (io_stream_cygfile::move): Ditto.
5518 (io_stream_cygfile::get_size): Ditto.
5519 (io_stream_cygfile::fname): Ditto.
5520 (io_stream_cygfile::lmode): Ditto.
5521 * io_stream_file.cc: Update includes for String usage.
5522 (io_stream_file::io_stream_file): Update for String usage.
5523 (io_stream_file::~io_stream_file): Ditto.
5524 (io_stream_file::exists): Ditto.
5525 (io_stream_file::remove): Ditto.
5526 (io_stream_file::mklink): Ditto.
5527 (io_stream_file::set_mtime): Ditto.
5528 (io_stream_file::move): Ditto.
5529 (io_stream_file::get_size): Ditto.
5530 * io_stream_file.h: Update includes for String usage.
5531 * io_stream_file.cc: Update includes for String usage.
5532 (io_stream_file::io_stream_file): Update for String usage.
5533 (io_stream_file::~io_stream_file): Ditto.
5534 (io_stream_file::exists): Ditto.
5535 (io_stream_file::remove): Ditto.
5536 (io_stream_file::mklink): Ditto.
5537 (io_stream_file::set_mtime): Ditto.
5538 (io_stream_file::move): Ditto.
5539 (io_stream_file::get_size): Ditto.
5540 (io_stream_file::fname): Ditto.
5541 (io_stream_file::lmode): Ditto.
5542 * localdir.cc: Update includes for String usage.
5543 (save_local_dir): Update for String usage.
5544 (check_if_enable_next): Ditto.
5545 (load_dialog): Ditto.
5546 (browse_cb): Ditto.
5547 (LocalDirPage::OnInit): Ditto.
5548 (LocalDirPage::OnNext): Ditto.
5549 * log.cc: Update includes for String usage.
5550 (struct LogEnt): Update for String usage.
5551 (log): Ditto.
5552 (log_save): Ditto.
5553 (exit_setup): Ditto.
5554 * log.h: Update includes for String usage.
5555 (log_level): Update for String usage.
5556 (log): Ditto.
5557 (log_save): Ditto.
5558 * main.cc (WinMain): Update for String usage.
5559 * mklink2.c (make_link_2): Update for String usage.
5560 * mklink2.h (make_link_2): Update for String usage.
5561 * mount.cc: Update includes for String usage.
5562 (mount_table): Update for String usage.
5563 (find2): Ditto.
5564 (create_mount): Ditto.
5565 (remove1): Ditto.
5566 (remove_mount): Ditto.
5567 (read_mounts): Ditto.
5568 (set_root_dir): Ditto.
5569 (get_root_dir): Ditto.
5570 (path_prefix_p): Ditto.
5571 (cygpath): Ditto.
5572 * mount.h: Update includes for String usage.
5573 (create_mount): Update for String usage.
5574 (remove_mount): Ditto.
5575 (cygpath): Ditto.
5576 (set_root_dir): Ditto.
5577 (get_root_dir): Ditto.
5578 * msg.cc (mbox): Ditto.
5579 * net.cc (NetPage::OnNext): Ditto.
5580 * package_db.cc (packagedb::flush): Ditto.
5581 (packagedb::packages): Ditto.
5582 (packagedb::categories): Ditto.
5583 * package_db.h: Update includes for String usage.
5584 (packagedb::packages): Update for String usage.
5585 (packagedb::categories): Ditto.
5586 * package_meta.cc: Update includes for String usage.
5587 (hash::add_subdirs): Update for String usage.
5588 (packagemeta::uninstall): Ditto.
5589 (packagemeta::SDesc): Ditto.
5590 (packagemeta::action_caption): Ditto.
5591 * package_meta.h: Update includes for String usage.
5592 (packagemeta::packagemeta): Update for String usage.
5593 (packagemeta::~packagemeta): Ditto.
5594 (packagemeta::uninstall): Ditto.
5595 (packagemeta::SDesc): Ditto.
5596 (packagemeta::action_caption): Ditto.
5597 (package_source.cc site::site): Ditto.
5598 (packagesource::set_canonical): Ditto.
5599 (packagesource::set_cached): Ditto.
5600 * package_source.h: Update includes for String usage.
5601 (site::site): Update for String usage.
5602 (packagesource::set_canonical): Ditto.
5603 (packagesource::set_cached): Ditto.
5604 (packagesource::packagesource): Ditto.
5605 (packagesource::sites): Ditto.
5606 (packagesource::cached): Ditto.
5607 * package_version.h: Update includes for String usage.
5608 (Dependency): Update for String usage.
5609 (packageversion): Ditto.
5610 * postinstall.cc: Update includes for String usage.
5611 (do_postinstall): Update for String usage.
5612 * res.rc (IDD_LOCAL_DIR): Fix typo again!
5613 * rfc1738.cc (rfc1738_escape_part): Update for String usage.
5614 * rfc1738.h: Update includes for String usage.
5615 (rfc1738_escape_part): Update for String usage.
5616 * root.cc: Update includes for String usage.
5617 (check_if_enable_next): Update for String usage.
5618 (save_dialog): Ditto.
5619 (browse_cb): Ditto.
5620 (directory_is_absolute): Ditto.
5621 (directory_is_rootdir): Ditto.
5622 (directory_has_spaces): Ditto.
5623 (RootPage::OnInit): Ditto.
5624 (RootPage::OnNext): Ditto.
5625 * script.cc: Update includes for String usage.
5626 (init_run_script): Update for String usage.
5627 (run): Ditto.
5628 (run_script): Ditto.
5629 (try_run_script): Ditto.
5630 * script.h: Update includes for String usage.
5631 (run_script): Update for String usage.
5632 (try_run_script): Ditto.
5633 * site.cc site_list): Ditto.
5634 (all_site_list): Ditto.
5635 (other_url): Eliminate.
5636 (site_list_type::init): Update for String usage.
5637 (site_list_type::site_list_type): Ditto.
5638 (get_site_list): Ditto.
5639 (get_saved_sites): Ditto.
5640 (do_download_site_info_thread): Ditto.
5641 (SitePage::OnNext): Ditto.
5642 (SitePage::OnActivate): Ditto.
5643 (SitePage::PopulateListBox): Ditto.
5644 (SitePage::OnMessageCmd): Handle empty url's.
5645 * site.h: Update includes for String usage.
5646 (site_list_type::site_list_type): Update for String usage.
5647 (site_list_type::init): Ditto.
5648 (site_list_type::~site_list_type): Ditto.
5649 (site_list_type::url): Ditto.
5650 (site_list_type::displayed_url): Ditto.
5651 (site_list_type::key): Ditto.
5652 * source.cc (SourcePage::OnDeactivate): Ditto.
5653 * state.h: Update includes for String usage.
5654 (local_dir): Update for String usage.
5655 (trust_level): Remove.
5656 * version.cc: Update includes for String usage.
5657 (canonicalize_version): Update for String usage.
5658 * version.h: Update includes for String usage.
5659 (canonicalize_version): Update for String usage.
5660
08233ec7
CF
56612002-02-15 Christopher Faylor <cgf@redhat.com>
5662
5663 * filemanip.c (parse_filename): Revert previous change.
5664
94dffbdd
CF
56652002-02-14 Christopher Faylor <cgf@redhat.com>
5666
5667 * filemanip.c (parse_filename): Don't treat '_' as a version number
5668 introducer.
5669
cef493d7
CF
56702002-01-29 Christopher Faylor <cgf@redhat.com>
5671
5672 * configure: Regenerate.
5673
57219197
RC
56742002-01-27 Robert Collins <rbtcollins@hotmail.com>
5675
94dffbdd
CF
5676 * res.rc (IDD_LOCAL_DIR): Fix typo reported by Rene
5677 <Hoeck@extern.lrz-muenchen.de>
57219197 5678
cc7493c3
RC
56792002-01-27 Robert Collins <rbtcollins@hotmail.com>
5680
5681 * README: Update Todo's.
5682 * list.h: Run indent.
5683 (list): New methods checksize and insert to reduce code duplication.
5684 (list::registerbykey): Use them.
5685 (list::registerbyobject): Ditto.
94dffbdd
CF
5686 (list::removebyindex): Copy each object individually - safe for non
5687 trivial objects.
cc7493c3
RC
5688 (list::checksize): Implement.
5689 (list::insert): Implement.
5690
a900d1fa
RC
56912002-01-27 Robert Collins <rbtcollins@hotmail.com>
5692
5693 * Makefile.in: Remove the dlmalloc object by default.
94dffbdd
CF
5694 * install.cc (do_install_thread): Remove the mallinfo call for 'working
5695 around' the crashing issue.
a900d1fa 5696 * package_db.h: Include <string.h> - it's needed to parse this.
94dffbdd 5697 * package_source.cc (site::site): Move here from the header file.
a900d1fa
RC
5698 * package_source.h (site): Stop the constructor being inlinable.
5699
9835fb4a
RC
57002002-01-26 Robert Collins <rbtcollins@hotmail.com>
5701
5702 * filemanip.cc (find_tar_ext): Add a descriptive comment.
5703
57042002-01-25 Michael A Chase <mchase@ix.netcom.com>
5705
5706 * filemanip.cc (find_tar_ext): Clean up tests for .tar.gz and .tar.
5707 * fromcwd.cc (do_fromcwd): Expand FIXME comment in source file check.
94dffbdd
CF
5708 * install.cc (install_one_source): Add space between words in log()
5709 call.
cef493d7 5710
77ba23d8
RC
57112002-01-22 Robert Collins <rbtcollins@hotmail.com>
5712
94dffbdd
CF
5713 * log.cc (exit_setup): When saving to the download dir, explicity
5714 specify the path.
77ba23d8 5715
6dc75764
RC
57162002-01-22 Robert Collins <rbtcollins@hotmail.com>
5717
94dffbdd
CF
5718 * archive.cc (extract_file): Separate out the prefix and the URL
5719 scheme.
6dc75764 5720 * archive.h (archive::extract_file): Ditto.
94dffbdd
CF
5721 * install.cc (install_one_source): Ditto. Use the new
5722 archive::extract_file syntax.
6dc75764
RC
5723 (replace_one): Use the new syntax.
5724 (io_stream.cc): Add some log info for links.
5725
7e8fc33c
RC
57262002-01-22 Robert Collins <rbtcollins@hotmail.com>
5727
5728 * PickCategoryLine.cc (PickCategoryLine::actiontext): Remove.
5729 (PickCategoryLine::paint): Use the new action method.
5730 (PickCategoryLine::click): Set the action for all children.
5731 (PickCategoryLine::set_action): New method.
5732 * PickCategoryLine.h (PickCategoryLine::-actions): Remove.
5733 (PickCategoryLine::current_default): Use packagemeta _actions class.
94dffbdd
CF
5734 * PickLine.h (PickLine::set_action): New abstract method that requires
5735 including package_meta.h.
7e8fc33c
RC
5736 * PickPackageLine.cc (PickPackageLine::set_action): New method.
5737 * PickPackageLine.h (PickPackageLine::set_action): Declare this.
5738 * list.h (getbykey): A const correctness fix.
5739 * package_meta.cc: Run indent.
5740 (packagemeta::Default_action): New const.
5741 (packagemeta::Install_action): Ditto.
5742 (packagemeta::Reinstall_action): Ditto.
5743 (packagemeta::Uninstall_action): Ditto.
5744 (packagemeta::_actions::caption): New method.
5745 (packagemeta::_actions::operator++): Ditto.
5746 (packagemeta::set_action): New overload.
5747 * package_meta.h (packagemeta::_actions): New class.
5748 (packagemeta::set_action): Declare this.
5749
2c9254b6
RC
57502002-01-22 Robert Collins <rbtcollins@hotmail.com>
5751
5752 * Makefile.in (OBJS): Remove supp.o - it appears accidental.
5753 * choose.cc: Don't define alloca anymore, it's done in win32.h
5754
97647369
RC
57552002-01-22 Robert Collins <rbtcollins@hotmail.com>
5756
5757 * PickPackageLine.cc: New file.
5758 * PickPackageLine.h: New file.
5759 * PickLine.cc: New file.
5760 * PickLine.h: New file.
5761 * PickCategoryLine.cc: New file.
5762 * PickCategoryLine.h: New file.
5763 * PickView.cc: New file.
5764 * PickView.h: New file.
5765 * Makefile.in: Add new objects to setup.exe.
5766 Backout -fno-exceptions option.
5767 * choose.cc: Include PickView.h.
5768 Remove view related defines and static variables.
5769 (_pkg_headers): Moved to PickView.cc.
5770 (_cat_headers): Ditto.
5771 (view::views::Unknown): Ditto.
5772 (view::views::PackageFull):
5773 (view::views::Package):
5774 (view::views::Category):
5775 (pkgtrustp): Moved to package_meta.cc.
5776 (add_required): Moved to package_meta.cc.
5777 (pick_category_line::empty): Moved to PickCategoryLine.cc
5778 (paint): Adjust for moved static variables.
5779 (view::scroll): Moved to PickView.cc.
5780 (list_vscroll): Adjust for moved static variables.
5781 (list_hscroll): Ditto.
5782 (list_click): Ditto.
5783 (note_width): Moved to PickView.cc.
5784 (view::view): Ditto.
5785 (view::set_view_mode): Ditto.
5786 (view::mode_caption): Ditto.
5787 (view::views::caption): Ditto.
5788 (view::set_headers): Ditto.
5789 (DoInsertItem): Ditto.
5790 (view::init_headers): Ditto.
5791 (view::insert_pkg): Ditto.
5792 (view::insert_category): Ditto.
5793 (view::clear_view): Ditto.
5794 (view::views::operator++): Ditto.
5795 (view::click): Ditto.
5796 (default_trust): Adjust for moved statics.
5797 (pick_pkg_line::paint): Moved to PickPackageLine.cc.
5798 (pick_pkg_line::click): Ditto.
5799 (pick_category_line::actiontext): Moved to PickCategoryLine.cc
5800 (pick_category_line::paint): Ditto.
5801 (pick_category_line::click): Ditto.
5802 (set_view_mode): Adjust for moved statics.
5803 (create_listview): Ditto.
58b12a06
MB
5804 * choose.h: Remove Category and packagemeta forward defines -
5805 not needed.
97647369
RC
5806 Don't include unneeded headers list and package_meta.
5807 (_header): Move to PickView.h.
5808 (pick_line): Move to PickLine.h.
5809 (pick_pkg_line): Move to PickPackageLine.h.
5810 (pick_category_line): Move to PickCategoryLine.h.
5811 (view): Move to PickView.h.
5812 * ini.h (trusts): Move to package_meta.h.
5813 * package_meta.h (trusts): New enum.
5814 (packagemeta::set_requirements): New helper method.
5815 (packagemeta::trustp): Ditto.
5816
b566778e
CF
58172002-01-21 Christopher Faylor <cgf@redhat.com>
5818
5819 * choose.h (view): Move forward declaration of views into public area
5820 or g++ v3 will complain.
5821
f71e9756
CF
58222002-01-21 Christopher Faylor <cgf@redhat.com>
5823
5824 * Makefile.in (CXXFLAGS): Add -fno-exceptions.
5825 * win32.h (alloca): Define as __builtin_alloca.
5826 * io_stream_memory.cc: Add include file.
5827
e9440f0f
RC
58282002-01-21 Robert Collins <rbtcollins@hotmail.com>
5829
58b12a06
MB
5830 * archive_tar.cc (archive_tar::~archive_tar): Mark the stream as
5831 destroyed.
e9440f0f
RC
5832 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
5833 * compress.cc (compress::~compress): Be less verbose.
5834 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
5835 Mark the stream as destroyed.
58b12a06
MB
5836 * compress_gz.cc (compress_gz::~compress_gz): Mark the stream as
5837 destroyed.
5838 * io_stream.cc (io_stream::~io_stream): Only warn when the stream is not
5839 marked as destroyed.
cef493d7 5840 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Mark the
e9440f0f
RC
5841 stream as destroyed.
5842 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
5843 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
cef493d7 5844
5e0464a1
RC
58452002-01-21 Robert Collins <rbtcollins@hotmail.com>
5846
5847 * Makefile.in (CFLAGS): Allow customisable malloc debug flags.
5848 (OBJS): Link in malloc objects.
5849 * category.cc (category): Use new char, not strdup.
5850 * choose.cc (pick_pkg_line::paint): Allow for the regionsize to shrink.
5851 (do_choose): Use new char, not malloc.
5852 * concat.cc (vconcat): Ditto.
5853 * cygpackage.cc (cygpackage): Use new char, not strdup.
5854 (set_canonical_version): Ditto.
5855 (cygpackage::destroy): Use delete[], not free.
5856 * desktop.cc (uexists): Ditto.
5857 * dialog.cc (egest): Use new char, not strdup.
5858 * dlmalloc.c: New file - Doug Lea's malloc 2.7.0
5859 * hash.cc (hash::hash): Use delete instead of free.
5860 (hash::add): Use new char, not strdup.
5861 * ini.cc (do_remote_ini): Use delete[] not free.
5862 * inilex.l: Use new char, not strdup.
5863 (ini_init): Ditto.
5864 * iniparse.y: Ditto.
5865 Use a local package_db rather than a static one.
5866 * install.cc (struct mallinfo): Workaround an apparent dlmalloc bug.
5867 (do_install_thread): Call mallinfo to force a consistency check. Appears
5868 to fix a 'inuse' error in -DDEBUG builds.
5869 Use delete[] for strings.
58b12a06
MB
5870 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Use new
5871 char, not strdup.
5e0464a1
RC
5872 (io_stream_cygfile::~io_stream_cygfile): Use delete[], not free.
5873 (io_stream_cygfile::remove): Use new char, not strdup.
58b12a06
MB
5874 * io_stream_file.cc (io_stream_file::io_stream_file): Use new char, not
5875 strdup.
5e0464a1
RC
5876 (io_stream_file::io_stream_file): Use delete[], not free.
5877 (io_stream_file::remove): Use new char, not strdup.
5878 * io_stream_memory.cc (memblock::~memblock): Use delete[], not free.
5879 * io_stream_memory.h (memblock): Use new char, not malloc.
5880 * localdir.cc (LocalDirPage::OnInit): Use new char, not strdup.
5881 * main.cc (WinMain): Use new char, not strdup.
5882 * mount.cc (find2): Use new char, not malloc.
5883 (read_mounts): Ditto.
5884 (cygpath): Use new char, not strdup.
5885 * netio.cc (NetIO::~NetIO): Use delete[], not free.
5886 (NetIO::set_url): Use new char, not strdup.
5887 (NetIO::get_ftp_auth): Use delete[], not free.
5888 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
5889 Use new char instead of strdup.
5890 * nio-http.cc (base64_encode): Use new char, not malloc.
5891 * package_meta.cc (hash::add_subdirs): Use new char instead of strdup.
5892 * package_source.h (~ packagesource): Use delete[] instead of delete.
5893 * port.h (strdup): Deprecate the use of strdup.
5894 * rfc1738.cc (rfc1738_do_escape): Use new char, not calloc.
5895 * script.cc (init_run_script): Us delete[], not free.
5896 (run_script): Ditto.
5897 * simpsock.cc (SimpleSocket::fill): Use new char, not malloc.
5898 (SimpleSocket::invalidate): Use delete[], not free.
5899 * site.cc (site_list_type::init): Use new char instead of strdup.
5900 * site.h (~site_list_type): Use delete[], not free.
5901
ad3c7385
RC
59022002-01-20 Robert Collins <rbtcollins@hotmail.com>
5903
5904 * Makefile.in (OBJS): Add win32.o - win32 support functions.
5905 * README: Update todos.
58b12a06
MB
5906 * archive.cc (extract_file): Support a suffix for appending to extracted
5907 files.
ad3c7385
RC
5908 * archive.h: Ditto.
5909 * choose.cc (set_view_mode): Use the new view::views class.
5910 (view::views::Unknown): New static for defaulting view::views variables.
5911 (view::views::PackageFull): New static for the current view.
5912 (view::views::Package): Ditto.
5913 (view::views::Category): Ditto.
5914 (topbucket::paint): Remove.
5915 (topbucket::empty): Rename to pick_category_line::empty.
5916 (topbucket::~topbucket): Remove.
5917 (paint): Use the new view::views class.
5918 Don't paint 'all' as a category when showing package categoies.
5919 (pick_category_line::actiontext): New method.
58b12a06
MB
5920 (pick_category_line::paint): Make showing the category optional, and
5921 show the 'category action'.
ad3c7385 5922 (pick_category_line::click): Make showing the category optional, and
58b12a06
MB
5923 differentiate between the name being clicked, and the action
5924 description.
ad3c7385
RC
5925 (view::view): Use the new view::views class.
5926 (view::set_view_mode): Ditto.
5927 (view::mode_caption): Ditto.
5928 (view::views::caption): New method.
5929 (view::set_headers): Use the new view::views class.
5930 (view::clear_view): Ditto.
cef493d7 5931 (viewsplusplus): Replaced by
ad3c7385
RC
5932 (view::views::operator++): New operator.
5933 (set_view_mode): Use the new view::views class.
5934 (create_listview): Ditto.
5935 (dialog_cmd): Ditto.
5936 * choose.h (actions): Remove.
5937 (views): Remove.
5938 (pick_line): Add a new convenience constructor.
5939 (top_bucket): Remove.
5940 (pick_category_line): Reparent under pick_line, and adsorb top_bucket.
5941 (view::views): New class.
5942 * ini.h: Don't include choose.h
5943 (is_download_action): Remove.
5944 (is_upgrade_action): Remove.
5945 (is_uninstall_action): Remove.
5946 (is_full_action): Remove.
5947 * install.cc (num_replacements): New static.
5948 (rebootneeded): Ditto.
5949 (replace_one): Handle upgrades separate from removal or new installs.
5950 (install_one_source): Handle in use files.
5951 (install_one): Don't repeat upgrades.
5952 (do_install_thread): Initialize new statics.
5953 Order actions as uninstall, replace, install.
5954 Warn about rebooting if needed.
5955 * res.rc (IDS_REBOOT_REQUIRED): New string.
5956 * resource.h (IDS_REBOOT_REQUIRED): Give value.
5957 * win32.h: Declare class Win32, and update copyright and intent message.
5958 * win32.cc: New file.
5959
edef4f57
CV
59602002-01-15 Corinna Vinschen <corinna@vinschen.de>
5961
5962 * io_stream.cc (io_stream::gets): Eliminate trailing new line chars.
5963 * package_meta.cc (packagemeta::uninstall): Check for additional
5964 Windows shortcut. Unset R/O file attribute before trying to delete
5965 file.
5966
21f325d7
RC
59672002-01-09 Robert Collins <rbtcollins@hotmail.com>
5968
58b12a06
MB
5969 * choose.cc (pkgtrustp): Fall back to installed if a package is not
5970 present in the current trust level. For prev, fall back via curr.
21f325d7
RC
5971 (set_existence): Allow sources with no sites, but cached files to be
5972 kept.
5973 (pick_category_line::paint): Start drawing clickable categories.
5974 * fromcwd.cc (found_file): Reinstate local file scanning.
5975
858f100d
RC
59762002-01-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5977
cef493d7 5978 * fromcwd.cc: Run indent.
858f100d
RC
5979 (do_fromcwd): Reverse sense of comment. Set next_dialog
5980 to IDD_CHOOSER instead of IDD_CHOOSE.
5981 * ini.cc (find_routine): Remove "/" from "/setup.ini".
cef493d7 5982
d343da15
RC
59832001-01-07 Robert Collins <rbtcollins@hotmail.com>
5984
5985 * category.cc (Categorycmp): Add a const safe version.
5986 * category.h (Categorycmp): Add a const safe version.
5987 (Category): Add operator ==.
5988 * choose.cc (fill_missing_category): Add every package to "All".
58b12a06
MB
5989 (pick_category_line::paint): Add support for hidden labels, and a tree
5990 depth.
d343da15
RC
5991 (pick_category_line::click): Ditto.
5992 (view::view): Pass in a top level category to use.
5993 (view::insert_pkg): Special case - skip category "All".
5994 (view::insert_category): Ditto.
5995 (view::clear_view): Set the contents label state.
5996 (create_listview): Pass in a top level category to view().
5997 * choose.h (topbucket): Make bucket available to derived classes.
5998 (pick_category_line): Add support for hidden labels, and a tree depth.
5999 Remove our second copy of bucket.
6000 (view): Pass in a top level category to the constructor.
6001 Use pick_category_line to allow three level display.
6002
bcf20115
RC
60032001-01-06 Robert Collins <rbtcollins@hotmail.com>
6004
6005 * cygpackage.h (cygpackage): Make set_[s|l]desc virtual.
6006 * iniparse.y (add_correct_version): Copy descriptions across.
58b12a06
MB
6007 * package_meta.cc (SDesc): Iterate through versions, return the first
6008 with a description.
bcf20115
RC
6009 * package_version.h (packageversion): Add new virtuals set_[l|s]desc.
6010
bc78a6d5
RC
60112001-01-04 Robert Collins <rbtcollins@hotmail.com>
6012
6013 * script.cc (run_script): Change cygpath:// to cygfile://.
6014 * install.cc (do_install_thread): Fix off-by-one errors.
6015
4f4e55c2
RC
60162001-01-04 Robert Collins <rbtcollins@hotmail.com>
6017
6018 * package_db.cc (packagedb::flush): Fix an off-by-one error.
6019
8e9aa511
RC
60202002-01-04 Jan Nieuwenhuizen <janneke@gnu.org>
6021
6022 * Makefile.in (realclean): more clean.
6023 (OBJS): Add script.o.
6024 * postinstall.cc (run_script_in_etc_postinstall): New function.
6025 (do_postinstall): Split off new funtion init_run_script ().
6026 (init_run_script):
6027 (run):
6028 (run_script): Move to script.cc. Replace some deprecated remove
6029 and move calls.
6030 * script.h:
6031 * script.cc: New file.
6032 * Forward port cygwin-20010707.jcn3.patch.
6033 * package_meta.cc (uninstall): Run pre- and postremove scripts.
6034 * install.cc: Typo fix.
6035 (do_install): Run script initialisation.
cef493d7 6036
b7301c43
RC
60372001-01-04 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6038
6039 * cistring.cc: Run d2u.
6040 * cistring.h: Run d2u.
6041
6042 * desktop.cc (etc_profile): Remove "test -f ./.bashrc && . ./.bashrc"
6043 from the generated /etc/profile. Bash will source this file
6044 automatically, and having this here merely results in .bashrc being
6045 executed twice. Run d2u.
6046 * desktop.h: Run d2u.
6047
6048 * propsheet.cc: Run d2u.
6049 (PropSheetProc): New function. Add minimize box here instead of in
6050 PropertyPage::DialogProc.
6051 (PropSheet::Create): Change to use creation callback PropSheetProc.
6052 (DLGTEMPLATEEX): Add 'hidden' Windows struct definition.
6053
6054 * propsheet.h: Run indent, d2u.
6055 * proppage.h: Run indent, d2u.
6056
6057 * proppage.cc: Run d2u.
6058 (PropertyPage::DialogProc): Remove minimize-box-adding
6059 functionality. Remove commented-out "PropSheet_SetWizButtons" calls.
6060 Add support for calling virtual OnMessageCmd. Add setting of fonts in
6061 WM_INITDIALOG handler.
6062 (resource.h): New include for resource IDs.
6063
6064 * res.rc: Resize and rearrange property page dialog templates
6065 to bring them in line with "Microsoft's Backward Compatible Wizard 97"
6066 specification. Run d2u.
6067 (IDD_SITE): Add an edit control and an "Add" button in order to
6068 combine the IDD_SITE and IDD_OTHER_URL functionality onto one page.
6069 (IDD_OTHER_URL): Remove dialog template.
6070 (IDD_DLSTATUS): Remove dialog template.
6071
6072 * site.cc: Run d2u.
6073 (SitePage::OnBack): Remove NEXT() macro invocation.
6074 (SitePage::OnActivate): New member function.
6075 (load_dialog): Remove. Functionality subsumed into
6076 SitePage::OnActivate.
6077 (save_dialog): Change to support both list and user URLs. Remove
6078 OTHER_IDX and mirror_idx logic.
6079 (SitePage::PopulateListBox): New member function.
6080 (SitePage::CheckControlsAndDisableAccordingly): New member function.
6081 (SitePage::OnMessageCmd): New override.
6082 (check_if_enable_next): Remove.
6083 (dialog_cmd): Remove.
6084 (do_download_site_info_thread): Remove calls to NEXT() macro.
6085 (SitePage::Create): Call the single-param PropertyPage::Create
6086 overload.
6087 (other_url): New static taken from other.cc.
6088 (SitePage::OnNext): Remove mirror_idx logic.
6089 (SitePage::OnInit): Remove "Other URL" entry from list box. Remove
6090 list box populating code, now handled in SitePage::PopulateListBox.
6091 (mirror_idx, NO_IDX, OTHER_IDX): Remove.
6092 (save_site_url): Fix potential buffer overflow problem. Switched to
6093 TCHAR in grossly premature preparation for multilingual support.
6094 * site.h: Run d2u.
6095 (SitePage::OnActivate): New member function.
6096 (SitePage::CheckControlsAndDisableAccordingly) New member.
6097 (SitePage::OnMessageCmd): New override.
6098 (do_download_site_info_thread): Add MessageBox call on failure to
6099 download site list.
6100
6101 * splash.cc: Run d2u.
6102 (SplashPage::OnInit): Set the font for the title.
6103 * splash.h: Run d2u.
6104
6105 * threebar.cc: Run d2u.
6106 * threebar.h: Run d2u.
6107
6108 * window.h: Run d2u.
6109 (Window::IsButtonChecked): New member function declaration.
6110 (Window::OnMessageCmd): New member function.
6111 (Window::SetDlgItemFont): New member function declaration.
6112 (Window::MAXFONTS, Window::Fonts, Window::FontCounter): New data
6113 members.
6114 * window.cc: Run d2u.
6115 (Window::IsButtonChecked): New member function definition.
6116 (Window::SetDlgItemFont): New member function definition.
6117 (Window::Window): Add initialization for FontCounter.
6118 (Window::~Window): Delete any fonts we created.
6119
6120 * geturl.cc: Run d2u.
6121 (progress): Remove the "3" field width from the "%3d"
6122 percent-complete format indicator. Causes line to not start at
6123 beginning of text box, and does little to help with "jumping", since
6124 the "bytes downloaded so far" field is variable-width anyway. Change
6125 kb/s format field to "%03.1" to 0-pad the kb/s number in the event of
6126 painfully slow connections, or temporary slowdowns in faster
6127 connections should such more-instantaneous functionality become
6128 available.
6129
6130 * net.h: Run d2u.
6131 (NetPage::OnMessageCmd): New member function declaration.
6132 (NetPage::CheckIfEnableNext): New member function declaration.
6133 * net.cc: Run d2u.
6134 (NetPage::OnMessageCmd): New member function definition.
6135 (dialog_cmd): Remove, subsumed into NetPage::OnMessageCmd.
6136 (check_if_enable_next): Remove.
6137 (NetPage::CheckIfEnableNext): New member function, subsumes
6138 check_if_enable_next.
6139 (propsheet.h): Add include.
6140 (NetPage::Init): Add call to CheckIfEnableNext.
6141 (load_dialog): Remove call to check_if_enable_next.
6142 (NetPage::Create): Call single-template-ID-parameter overload of
6143 PropertyPage::Create instead of three-parameter one.
6144
6145 * Makefile.in (OBJS): Remove other.o.
6146 * other.cc: Remove file.
6147
df62e023
RC
61482002-01-01 Robert Collins <rbtcollins@hotmail.com>
6149
6150 * README: Update TODO's.
6151 * choose.cc (set_existence): Delete non installed packages with no
6152 mirrors.
6153 (fill_missing_category): Fix an off-by-one error.
cef493d7 6154 (default_trust): Ditto. Also delete any unused categories.
df62e023
RC
6155 (view::init_headers): Fix an off-by-one error.
6156 (set_view_mode): Ditto.
6157 (set_view_mode): Ditto.
6158 (create_listview): Ditto.
6159 (dialog_cmd): Ditto.
6160 (do_choose): Ditto.
6161 * io_stream.cc: Indent.
6162 * io_stream.h: Ditto.
6163 * package_db.cc: Ditto.
6164 * package_meta.h: Const correctness for SDesc ();
6165 * proppage.cc: Run d2u and indent.
6166 * propsheet.cc: Run d2u and indent.
6167 * window.cc: Run d2u and indent.
6168 * window.h: Run d2u and indent.
6169
cec57ee1
CF
61702001-12-28 Christopher Faylor <cgf@redhat.com>
6171
e98c531e 6172 * Makefile.in (iniparse.o): Accommodate newer bisons.
cec57ee1 6173
ab57ceaa
RC
61742001-12-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6175
6176 * window.h (Window): New file, new class.
6177 * window.cc (Window): New file, new class.
6178
6179 * threebar.h (ThreeBarProgressPage): New file, new class.
6180 * threebar.cc (ThreeBarProgressPage): New file, new class.
6181
6182 * splash.h (SplashPage): New file, new class.
6183 * splash.cc (SplashPage): Replace file with implementation of new
6184 class.
6185
6186 * source.h (SourcePage): New file, new class.
6187 * source.cc: Run indent.
6188 (SourcePage): Add class implementation to this file.
6189 (do_source): Remove, functionality subsumed by SourcePage::Create()
6190 and SourcePage::OnDeactivate().
cef493d7 6191 (dialog_proc): Remove, functionality subsumed by
ab57ceaa
RC
6192 SourcePage::OnActivate().
6193
6194 * site.h: Run indent.
6195 (SitePage): Add class declaration.
6196 * site.cc: Run indent.
6197 (SitePage): Add class implementation.
6198 (do_download_site_info_thread): New function.
6199 (context): New var. Context info for do_download_site_info_thread().
6200 (do_download_site_info): New function.
6201 (SitePage::Create, SitePage::OnInit SitePage::OnNext)
6202 (SitePage::OnBack): SitePage class implementation..
6203 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers, now handled
6204 by SitePage members.
6205 (dialog_proc): Remove, now handled by SitePage::OnInit and base class
6206 functionality.
6207 (do_site): Remove, now handled by do_download_site_info_thread() and
6208 SitePage::OnNext functionality.
6209 (get_site_list): Remove dismiss_url_status_dialog() call.
6210
6211 * root.h (RootPage): New file, new class.
6212 * root.cc: Run indent.
6213 (dialog_cmd): Pass parent HWND parameter to note(), yesno().
6214 (dialog_proc): Remove.
6215 (do_root): Remove
6216 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL clauses from switch.
6217 (RootPage::OnInit): New member function. Move get_root_dir() logic to
6218 here from do_root().
6219 (RootPage::Create): New member function.
cef493d7 6220 (RootPage::OnNext): New member function. Move IDOK logic from
ab57ceaa
RC
6221 dialog_cmd() to here.
6222 (RootPage::OnBack): New member function.
6223
6224 * propsheet.h (PropSheet): New file, new class.
6225 * propsheet.cc (PropSheet): New file, new class.
6226
6227 * proppage.h (PropertyPage): New file, new class.
6228 * proppage.cc (PropertyPage): New file, new class.
6229
6230 * postinstall.cc (do_postinstall): Add owner parameter.
6231
6232 * other.cc (do_other): Add owner parameter.
6233
6234 * nio-file.cc (NetIO::Purl): Pass NULL parent param to note().
cef493d7 6235 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Pass NULL parent param to
ab57ceaa 6236 get_ftp_auth().
cef493d7 6237 * nio-http.cc (retry_get): Pass NULL parent param to get_auth(),
ab57ceaa
RC
6238 get_proxy_auth(),
6239 and get_ftp_auth().
cef493d7 6240 * nio-ie5.cc (NetIO::_url): Pass NULL parent param to note(),
ab57ceaa
RC
6241 get_auth(), get_proxy_auth().
6242
6243 * netio.h (get_auth, get_proxy_auth, get_ftp_auth): Add owner param.
cef493d7 6244 * netio.cc (auth_common, NetIO::get_auth, NetIO::get_proxy_auth,
ab57ceaa
RC
6245 NetIO::get_ftp_auth)
6246 (auth_common): Add owner param. Pass owner param to DialogBox.
cef493d7 6247 (NetIO::get_auth, NetIO::get_proxy_auth, NetIO::get_ftp_auth): Pass
ab57ceaa
RC
6248 owner param to auth_common().
6249
6250 * net.h (NetPage): New file, new class.
6251 * net.cc: Run indent.
6252 (net.h, threebar.h): Add includes.
6253 (Progress): Add extern.
6254 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, now handled by
6255 property sheet logic. Saved temporarily for reference.
cef493d7 6256 (NetPage::Create, NetPage::OnInit, NetPage::OnDeactivate,
ab57ceaa
RC
6257 NetPage::OnNext, NetPage::OnBack):
6258 New implementation of NetPage class members.
6259 (do_net): Remove.
6260 (dialog_proc): Remove.
6261
6262 * msg.h (fatal, note, yesno): Add owner param.
6263 * msg.c (fatal, note, yesno, mbox): Add owner param.
6264 (mbox): Remove MB_TOPMOST from MessageBox call. Unnecessary and wrong
6265 now that we have a parent.
6266
6267 * main.cc: Run indent.
cef493d7 6268 (commctrl.h, proppage.h, propsheet.h, splash.h, source.h)
ab57ceaa
RC
6269 (localdir.h, net.h, site.h, choose.h, threebar.h, desktop.h): Include
6270 headers.
6271 (root_dialog_proc): extern into this file.
6272 (Progress): Progress dialog defined here, used in several other files.
6273 (WinMain): Instantiate and create Splash, Source, Root, LocalDir, Net,
6274 Site, Chooser, Desktop pages and MainWindow sheet. Call
6275 InitCommonControls() to make sure Windows is set up for our use of
6276 property sheets. Add pages to sheet.
6277 Call MainWindow.Create() to "DoModal". Remove main loop, that logic is
6278 now handled by the PropSheet class.
6279 (root.h): Add include.
6280
6281 * log.cc (log_save): Pass NULL parent to fatal().
6282 (exit_setup): Pass NULL parent to note().
6283
6284 * localdir.h (LocalDirPage): New file, new class.
6285 * localdir.cc: Run indent.
6286 (localdir.h): New include.
6287 (threebar.h): New include.
6288 (Progress): extern into this file.
6289 (LocalDirPage::Create, LocalDirPage::OnInit, LocalDirPage::OnActivate)
cef493d7 6290 (LocalDirPage::OnNext, LocalDirPage::OnBack): Implementation of
ab57ceaa
RC
6291 LocalDirPage.
6292 (LocalDirPage::OnNext): Move log() call from do_local_dir() to here.
6293 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers.
6294 (do_local_dir): Remove.
6295 (dialog_proc): Remove.
6296 (cwd): Remove, not used by anything.
6297
6298 * install.cc: Run indent.
6299 (process.h, threebar.h): New includes.
6300 (Progress): extern into this file.
6301 (ins_dialog, ins_action, ins_pkgname, ins_filename, ins_pprogress)
6302 (ins_iprogress, ins_diskfull, init_event): Remove, now handled by
6303 ThreeBarProgressPage.
cef493d7 6304 (dialog_cmd, dialog_proc, dialog): Removed, handled in
ab57ceaa 6305 ThreeBarProgressPage.
cef493d7
CF
6306 (init_dialog): Remove all mention of the above ins_* handles. Now
6307 handled in ThreeBarProgressPage. Altered SetWindowText()s to call
ab57ceaa
RC
6308 ThreeBarProgressPage instance Progress directly.
6309 (progress): Alter bar update logic to call ThreeBarProgressPage
6310 instance Progress directly.
6311 (uninstall_one): Alter SetWindowText()s to call ThreeBarProgressPage
6312 instance Progress directly.
cef493d7 6313 (install_one_source): Alter SetWindowText()s to call
ab57ceaa
RC
6314 ThreeBarProgressPage
6315 instance Progress directly. Pass NULL parent to note().
cef493d7 6316 (do_install_thread): Rename from do_install(), added owner param.
ab57ceaa
RC
6317 Alter SetWindowText()s to call ThreeBarProgressPage instance Progress
6318 directly.
6319 Remove dismiss_url_status_dialog() call, no longer necessary. Remove
cef493d7 6320 ShowWindow(<hide>) call, also unnecessary now. Pass owner handle to
ab57ceaa
RC
6321 fatal().
6322 (do_install_reflector): New function.
6323 (do_install): New function.
6324
6325 * ini.cc (process.h, threebar.h): New includes.
6326 (Progress): externed into this file.
6327 (find_routine): Pass NULL parent to note().
6328 (do_local_ini): Add owner param.
cef493d7 6329 (do_remote_ini): Add owner param. Pass owner to get_url_to_membuf()
ab57ceaa
RC
6330 and note(). Remove call to dismiss_url_status_dialog().
6331 (do_ini_thread): Rename from do_ini(). Add owner param. Pass owner to
cef493d7 6332 do_local_ini(), do_remote_ini(), yesno(), and note(). Set next_dialog
ab57ceaa
RC
6333 to IDD_CHOOSER on exit.
6334 (do_ini_thread_reflector): New function.
6335 (context): New var. Context for do_ini_thread.
6336 (do_ini): New function.
6337
6338 * geturl.h (get_url_to_membuf, get_url_to_string, get_url_to_file): Add
6339 owner param.
cef493d7 6340 * geturl.cc (gw_dialog, gw_url, gw_rate, gw_progress, gw_pprogress,
ab57ceaa 6341 gw_iprogress)
cef493d7 6342 (gw_progress_text, gw_pprogress_text, gw_iprogress_text, init_event):
ab57ceaa
RC
6343 Removed.
6344 (threebar.h): New include.
6345 (Progress): externed into this file.
cef493d7 6346 (dialog_cmd, dialog_proc, dialog): Removed, handled by
ab57ceaa 6347 ThreeBarProgressPage now.
cef493d7 6348 (init_dialog): Remove "if (gw_dialog == 0)" clause. Alter
ab57ceaa 6349 SetWindowText()s
cef493d7 6350 and bar setting SendMessage()s to call ThreeBarProgressPage instance
ab57ceaa
RC
6351 Progress directly. Remove "one bar only" logic, this is now handled
6352 explicitly in the ThreeBarProgressPage class.
cef493d7 6353 (progress): Altered bar and text update logic to call
ab57ceaa
RC
6354 ThreeBarProgressPage instance Progress directly. Changed kbps
6355 calculation to floating point and now print out a single decimal
6356 place.
6357 (get_url_to_membuf): Add owner param. Pass it to init_dialog.
6358 (get_url_to_string): Add owner param. Pass it to get_url_to_membuf.
cef493d7 6359 (get_url_to_file): Add owner param. Pass it to init_dialog. Alter bar
ab57ceaa
RC
6360 update logic to call ThreeBarProgressPage instance Progress directly.
6361 (dismiss_url_status_dialog): Remove.
6362
6363 * fromcwd.cc (do_fromcwd): Add owner param. Initialize found_ini to
6364 false, was true.
6365
6366 * download.cc: Run indent.
6367 (process.h, threebar.h): New includes.
6368 (Progress): externed into this file.
6369 (download_one): Add owner param. Pass it to get_url_to_file().
6370 (do_download_thread): Renamed from do_download. Add owner param. When
6371 calculating total_download_bytes, take binpicked and srcpicked into
6372 account. Remove call to dismiss_url_status_dialog(), no longer needed.
6373 Pass owner handle to download_one() and yesno().
6374 (do_download_reflector, do_download): New functions.
6375 (context): New var. Context for do_download_thread().
6376
6377 * dialog.h (D(x)): Add owner param.
6378
6379 * desktop.h (DesktopSetupPage): New file, new class.
6380 * desktop.cc: Run indent.
6381 (desktop.h): Add include.
cef493d7 6382 (dialog_proc, do_desktop): Remove, now handled in
ab57ceaa
RC
6383 DesktopSetupPage::OnInit().
6384 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, handled in
6385 DesktopSetupPage::OnFinish(), DesktopSetupPage::OnBack(), and PropSheet
6386 resp.
6387 (DesktopSetupPage::Create, DesktopSetupPage::OnInit)
6388 (DesktopSetupPage::OnBack, DesktopSetupPage::OnFinish): Implementation
6389 of DesktopSetupPage.
6390
6391 * cistring.h: New file, new class.
6392 * cistring.cc: New file, new class.
6393
6394 * choose.h: Run indent.
6395 (Chooser): New class declaration.
6396 * choose.cc: Run indent.
cef493d7 6397 (do_choose): Add owner param. Pass it to DialogBox() and
ab57ceaa
RC
6398 fatal().
6399 (Chooser): New class implementation.
6400
6401 * res.rc (IDS_VERSION_INFO): New string.
6402 (IDD_SOURCE, IDD_LOCAL_DIR, IDD_ROOT, IDD_SITE, IDD_OTHER_URL)
6403 (IDD_DLSTATUS, IDD_INSTATUS, IDD_SPLASH, IDD_CHOOSE, IDD_DESKTOP):
6404 Change WS_POPUP to WS_CHILD. Numerous positioning/size changes
6405 throughout.
6406 (IDD_CHOOSE): Give template the WS_EX_CONTROLPARENT style to enable
6407 TAB control navigation etc. Give the controls a reasonable tab order.
6408 Grouped radio buttons. Something's still not right, can't tab away
6409 from back/next/cancel group reliably.
6410 * resource.h (IDD_CHOOSER): New dialog ID.
6411
6412 * Makefile.in (OBJS): Add cistring.o, proppage.o, propsheet.o,
6413 threebar.o, and window.o.
6414
cc41a057
RC
64152001-12-21 Robert Collins <rbtcollins@hotmail.com>
6416
58b12a06
MB
6417 * choose.cc (listview_proc): Update the scrollbar when the headers are
6418 dragged.
cc41a057
RC
6419 (pick_pkg_line::paint): Clip columns to prevent overlap.
6420
cbfc4215
RC
64212001-12-20 Robert Collins <rbtcollins@hotmail.com>
6422
6423 * Makefile.in: Add libcomctl32.a for setup.exe.
6424 * archive.h (archive): Prevent non-child direct creation of the class.
58b12a06
MB
6425 * archive_tar.h (archive_tar): Prevent inaccurate synthetic copy and
6426 assignment.
cbfc4215
RC
6427 * choose.cc: Include commctrl for the choose header.
6428 (NEW_COL_SIZE_SLOP): Define without magic numbers.
6429 (pkgtrustp): Convert to function.
6430 (set_action): Remove.
cef493d7 6431 (add_required, fill_missing_category,default_trust): Use list syntax for
cbfc4215
RC
6432 package list.
6433 Use new set_action.
6434 (choose_caption): Remove.
6435 (topbucket::paint): New method.
6436 (topbucket::empty): Ditto.
6437 (topbucket::click): Ditto.
6438 (topbucket::~topbucket): Ditto.
6439 (paint): Remove i,ii and p as they are obsolete.
6440 Remove header drawing code.
6441 Use new chooser method to paint the chooser.
6442 Use new chooser itemcount method.
6443 (scroll_common): Rename to view::scroll.
6444 Scroll the header window separately.
58b12a06
MB
6445 (list_vscroll, list_hscroll, list_click): Update for new chooser
6446 methods.
cbfc4215
RC
6447 (listview_proc): Look for header messages.
6448 (note_width): Accept stringless calls.
6449 (pick_line::set_line): Remove.
6450 (pick_line::paint): Remove.
58b12a06
MB
6451 (pick_pkg_line::paint): Paint this one line, using the header column
6452 widths.
6453 (pick_category_line::paint): Paint this category, and anything in the
6454 bucket.
cbfc4215
RC
6455 (pick_line::click): Remove.
6456 (pick_pkg_line::click): Handle a click.
6457 (pick_category_line::click): Handle a click.
6458 (_view): Rename all to view.
6459 (view::view): Initialise the control contents.
6460 (view::set_headers): Work with the header control.
6461 (view::init_headers): Use list syntax for package list.
6462 Rearrange the width logic a little.
6463 (view::insert_pkg): Update to use the hierarchy.
6464 (view::insert_category): Ditto.
6465 (view::insert_at, view::insert_under): Remove.
6466 (view::clear_view): Update to use the hierarchy.
6467 (view::click): Update to use the hierarchy.
6468 (set_view_mode): Use list syntax for package list.
6469 Update for new chooser methods.
6470 (DoInsertItem): New helper function. (Needs a home somewhere).
58b12a06
MB
6471 (create_listview): Remove choose control code and use the constructor
6472 instead.
cbfc4215
RC
6473 (dialog_cmd,scan2,do_choose): Use list syntax for package list.
6474 * choose.h: Include newly required headers list and package_meta.
6475 (_voew): Rename to view.
6476 (pick_line): Convert to an ABC.
6477 (pick_pkg_line): New class.
6478 (pick_catgory_line): New class.
6479 (topbucket): New class.
6480 (view::scroll): New method created from listview_scroll function.
6481 * desktop.cc (make_passwd_group): Use list syntax for package list.
6482 * download.cc (do_download): Use list syntax for package list.
6483 * fromcwd.cc (found_file): Use list syntax for package list.
6484 * iniparse.y (pacakges): Use list syntax for package list.
6485 * install.cc (uninstall_one): Use list syntax for package list.
6486 (do_install): Use list syntax for package list.
58b12a06
MB
6487 * io_stream.h (io_stream): Prevent non-child direct creation of the
6488 class.
cbfc4215
RC
6489 Prevent inaccurate synthetic copy and assignment.
6490 * list.h: Include required header stdlib.
6491 Work on const correctness.
6492 * package_db.cc (packagedb::getpackagebyname): Remove.
6493 (packagedb::packagedb): Remove custom list code, and make db a local.
6494 (packagedb::getfirstpackage): Remove.
6495 (packagedb::getnextpackage): Remove.
6496 (packagedb::addpackage): Remove.
6497 (flush): Remove custom list code.
6498 (packagedb::registerpackage): Remove.
6499 (packagedb::packages): New static member.
6500 (packagedb::task): New static member.
6501 * package_db.h (PackageDBActions): New enum.
6502 (packagedb): Remove getfirstpackage, getnextpackage, getpackagebyname,
6503 addpackage, registerpackage, packages, packagecount, curr_package, db.
6504 Add packages, task.
6505 * pacakge_meta.cc: Include package_db.h.
6506 (packagemeta::action_caption): New method.
6507 (packagemeta::set_action): New method.
6508 * package_meta.h (CategoryPackage): Initialise key.
6509 (packagemeta): Initialise key.
6510 Add set_action and action_caption methods.
6511 Prevent inaccurate synthetic copy and assignment.
6512 * resource.h (IDC_CHOOSE_LISTHEADER): New ID.
6513 * source.cc: Include package_db for db manipulation.
6514 (save_dialog): Set the db task.
58b12a06
MB
6515 * win32.h: Tell the w32 include headers what IE version to
6516 expect/require.
cbfc4215 6517
cd8e5750
RC
65182001-12-06 Robert Collins <rbtcollins@hotmail.com>
6519
6520 * README: Wishlist updates.
6521
5519d243
RC
65222001-12-04 Robert Collins <rbtcollins@hotmail.com>
6523
6524 * package_db.cc (getnextpackage): Don't overrun the array.
6525
de6a1a64
RC
65262001-12-04 Robert Collins <rbtcollins@hotmail.com>
6527
6528 * Makefile.in (OBJS): Add setup_version.o.
6529 (version.c): Rename to setup_version.
6530 * choose.cc (set_action): Prevent NULL pointer dereference.
6531 (package_sort): Remove.
6532 * fromcwd.cc (canonicalize_version): Moved to version.cc.
58b12a06
MB
6533 (check_ini): New function for use with find to see if there is a cached
6534 setup.ini.
de6a1a64
RC
6535 (do_fromcwd): Check for a cached setup.ini from any mirror site.
6536 * ini.cc (find_routine): New function, for finding cached setup.ini's.
6537 (do_local_ini): New function, drives parsing of local ini's.
58b12a06
MB
6538 (do_remote_ini): New function, drives parsing and caching of remote
6539 ini's.
de6a1a64
RC
6540 (do_ini): Move guts to do_remote_ini and do_local_ini.
6541 * list.h (removebyindex): New method.
6542 * other.cc (save_dialog): Use new site_list and all_site_list to add the
6543 new site to the site picklist.
6544 (dialog_cmd): Only save the dialog when exiting the dialog.
6545 * res.rc (IDD_SITE): Make IDC_URL_LIST a multiple-selection control.
6546 * site.cc (site_list_type): Move to site.h
6547 (site_list): New global, sites chosen by the user.
6548 (all_site_list): New global, all potential sites.
58b12a06
MB
6549 (site_list_type::init): New method, parses a mirror.lst URL string into
6550 a site_list_type object.
de6a1a64
RC
6551 (site_list_type::site_list_type): New method.
6552 (check_if_enable_next): Examine the control, not a local variable.
6553 (load_dialog): Select all the user chosen sites by default.
cef493d7 6554 (save_dialog): Adjust for multiple selection semantics.
de6a1a64 6555 (save_site_url): Save all user chosen sites.
58b12a06
MB
6556 (dialog_cmd): Don't save the dialog when the listbox recieves a message
6557 - thats not needed.
de6a1a64
RC
6558 Remove obsolete other_url reference.
6559 (dialog_proc): Use all_site_list instead of site_list.
6560 (site_sort): Remove.
6561 (get_site_list): Remove malloc use - use list template instead.
6562 Move site_list_type initialisation to site_list_type::init().
6563 (get_initial_list_idx): Renamed to ...
6564 (get_saved_sites): this. Also read in multiple sites to the site_list.
6565 (do_site): Use all_site_list not site_list.
6566 Log all chosen sites.
6567 * site.h: New file, defines site related class, functions and variables.
6568 * state.h: Add comment about use of state.h
6569 (mirror_site): Remove.
6570 (other_url): Remove.
6571 (MIRROR_SITE): Remove.
6572 * version.cc: New file, for version-handling and related functions.
6573
341988b9
RC
65742001-12-02 Robert Collins <rbtcollins@hotmail.com>
6575
6576 * Makefile.in: Add filemanip.o to setup.
6577 * archive.cc (archive::extract_file): Use new io_stream method 'copy'.
6578 * archive_tar.h (archive_tar_file): Implement get_size virtual.
6579 (archive_tar): Ditto.
58b12a06
MB
6580 * choose.cc (set_action): Use [] operator instead of getnth - its more
6581 readable.
341988b9
RC
6582 (paint): Ditto.
6583 (_view::init_headers): Ditto.
6584 (_view::insert_pkg): Ditto.
6585 (set_view_mode): Ditto.
6586 (scan2): Ditto.
6587 (do_choose): Ditto.
6588 (base): Moved to filemanip.cc.
6589 (find_tar_ext): Ditto.
6590 (parse_filename): Ditto.
6591 (_Info::_Info): Remove.
6592 * compress_bz.h (compress_bz): Implement get_size virtual.
6593 * compress_gz.h (compress_gz): Implement get_size virtual.
58b12a06
MB
6594 * cygpackage.cc (cygpackage::destroy): Use array delete for char *
6595 objects.
341988b9 6596 * download.cc (get_file_size): Move to filemanip.cc.
58b12a06
MB
6597 (check_for_cached): Use [] operator instead of getnth - its more
6598 readable.
341988b9
RC
6599 (download_one): Ditto.
6600 * filemanip.cc: New file.
58b12a06
MB
6601 * geturl.cc (init_dialog): Make url a pointer to const as it is not
6602 modified.
6603 (get_url_to_membuf): New function - contains get_url_to_string worker
6604 code.
341988b9
RC
6605 (get_url_to_string): Becomes a trivial wrapper to get_url_to_membuf.
6606 * geturl.h: Declare new prototype.
6607 * ini.cc (do_ini): Use get_url_to_membuf and pass ini_init an io_stream.
6608 Tidy up the error code a little.
6609 * ini.h: Remove __cplusplus protection for ini_init.
6610 (_Info): Remove.
6611 * inilex.l: Remove old globals.
6612 (ini_init): Use an io_stream for getting the characters.
6613 (ini_getchar): Ditto.
6614 * iniparse.y: Declare yylex as a C++ function.
58b12a06
MB
6615 (add_correct_version): Use [] operator instead of getnth - its more
6616 readable.
341988b9
RC
6617 * io_stream.cc (io_stream::move_copy): Use the copy method.
6618 (io_stream::copy): New method to simply copy from one stream to another.
58b12a06
MB
6619 * io_stream.h (io_stream): New static method copy, and virtual method
6620 get_size.
341988b9
RC
6621 * io_stream_cygfile.cc (io_stream_cygfile::get_size): Implement this.
6622 * io_stream_cygfile.h (io_stream_cygfile::get_size): Declare this.
6623 * io_stream_file.cc (io_stream_file::get_size): Implement this.
6624 * io_stream_file.h (io_stream_file::get_size): Declare this.
6625 * io_stream_memory.h: Include errno as it's neded to parse the header.
6626 (io_stream_memory::get_size): Implement this.
6627 (io_stream_memory::st_size): Delete this.
6628 * list.h: Change getnth into the [] operator.
58b12a06
MB
6629 * netio.cc (NetIO::NetIO): Change prototype to reflect Purl not being
6630 modified.
341988b9
RC
6631 (NetIO::set_url): Ditto.
6632 (NetIO::open): Ditto.
6633 * netio.h: As for netio.cc.
58b12a06
MB
6634 * nio-file.cc (NetIO_File::NetIO_File): Change prototype to reflect
6635 Purl not being modified.
341988b9
RC
6636 * nio-file.h: Ditto.
6637 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
6638 * nio-ftp.h (NetIO_FTP::NetIO_FTP): Ditto.
6639 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Ditto.
6640 * nio-http.h (NetIO_HTTP::NetIO_HTTP): Ditto.
6641 * nio-i5.cc (NetIO_IE5::NetIO_IE5): Ditto.
6642 * nio-i5.h (NetIO_IE5::NetIO_IE5): Ditto.
6643 * package_meta.cc (packagemeta::~packagemeta): Bugfix: use array delete.
6644 * package_source.cc (packagesource::set_canonical): Ditto.
6645 (packagesource::set_cached): Ditto.
6646 * package_source.h (site::~site): Ditto.
58b12a06
MB
6647 * site.cc: Change site_list_type to a class, and search and replace
6648 sort_key to key globally.
341988b9 6649
071c1c54
RC
66502001-12-01 Robert Collins <rbtcollins@hotmail.com>
6651
58b12a06
MB
6652 * package_source.cc (packagesource::set_canonical): Filename was out by
6653 one.
071c1c54 6654
4fe323f9
RC
66552001-11-30 Robert Collins <rbtcollins@hotmail.com>
6656
6657 * Makefile.in (OBJS): Remove category_list - it's not needed.
6658 * README: More wishlist updates.
6659 * category.cc (Category::Category): Initialise new members.
6660 (Categorycmp): New function.
6661 * category.h (Category): New member key for template use.
6662 * category_list.cc: Remove.
6663 * category_list.h: Remove.
6664 (Categorycmp): New function prototype.
6665 * choose.cc: Remove category_list - not needed.
cef493d7 6666 (set_action): Only show the 'source' option when the source is actually
4fe323f9
RC
6667 available.
6668 (add_required): Fix recursion limiter to 5.
6669 (fill_missing_category): Use list access.
6670 (default_trust): Ditto.
6671 (pick_line::paint): Ditto.
6672 (_view::init_headers): Ditto.
6673 (_view::insert_pkg): Ditto.
6674 (_view::insert_category): Ditto.
6675 (_view::click): Ditto.
6676 (set_view_mode): Ditto.
6677 (do_choose): Ditto.
6678 * cygpackage.h: Remove category_list - not needed.
6679 * geturl.cc (get_url_to_string): Fix null byte insertion.
6680 * inipatse.y: Remove category_list - not needed.
6681 (categories): Use list access.
6682 * package_db.cc: Ditto.
6683 * package_db.h: Remove category_list - not needed.
6684 (packagedb): Use the list template for categories.
6685 * package_meta.cc (add_category): Ditto.
6686 * package_meta.h (CategoryPackage): Link to the category as well.
cef493d7 6687 (packagemeta): Use a list of CategoryPackages instead of Categories
4fe323f9
RC
6688 for more memory efficient cross-referencing.
6689
7d66d192
RC
66902001-11-30 Robert Collins <rbtcollins@hotmail.com>
6691
58b12a06
MB
6692 * package_db.cc (packagedb::flush): Write a canonical version for all
6693 packages irrespective of the media they were installed from.
7d66d192 6694
bb849dbd
RC
66952001-11-29 Robert Collins <rbtcollins@hotmail.com>
6696
6697 * Makefile.in (OBJS): Add package_source and rfc1738.
6698 * README: Wishlist update.
6699 * category_list.cc (register_category): Use references.
6700 * category_list.h (CategoryList): Ditto.
6701 * choose.cc (isinstalled): Remove.
6702 (pkgtrustp): New macro.
6703 (set_action): Use packagemeta.
6704 (add_required): Ditto.
58b12a06
MB
6705 (choose_caption): Example package to choose caption, rather than state
6706 flags.
bb849dbd
RC
6707 (check_existence): Remove.
6708 (set_existence): Remove old code.
6709 (fill_missing_category): Use packagemeta.
6710 (keep_or_skip): Remove.
6711 (default_trust): Use packagemeta and set trust values directly.
6712 (pick_line::set_line): Use packagemeta.
6713 (_view::insert_pkg): Ditto.
6714 (_view::insert_category): Ditto.
6715 (_view::click): Ditto.
6716 (set_view_mode): Ditto. Also remove "exclude" code.
6717 (create_listview): Use packagemeta.
6718 (dialog_cmd): Ditto.
6719 (getpkgbyname): Remove
6720 (scan2): Use packagemeta. Temporarily comment out the holefinding code.
6721 (read_installed_db): Remove.
6722 (package_sort): Use packagemeta.
58b12a06
MB
6723 (do_choose): Use packagemeta. Don't sort the packages - the db does
6724 that.
bb849dbd
RC
6725 * choose.h: Use packagemeta.
6726 * cygpackage.cc (cygpackage::cygpackage): Initialise all variables.
6727 (cygpackage::cygpackage): Ditto.
6728 (cygpackage::set_canonical_version): Copy the passed string.
6729 (cygpackage::~cygpackage): Move cleanup code to destroy().
6730 (cygpackage::destroy): New function.
6731 (cygpackage::getfirstfile): Use a separate buffer.
6732 (cygpackage::getnextfile): Ditto.
6733 (cygpackage::Canonical_version): New function.
6734 (cygpackage::set_sdesc): Ditto.
6735 (cygpackage::set_ldesc): Ditto.
6736 * cygpackage.h (cygpackage::Canonical_version): New method.
6737 (cygpackage::set_sdesc): New method.
6738 (cygpackage::set_ldesc): New method.
6739 (cygpackage::SDesc): New method.
6740 (cygpackage::LDesc): New method.
6741 (cygpackage::set_canonical_version): New method.
6742 * desktop.cc: Include packagedb headers.
6743 (make_password_group): Use packagemeta.
6744 * download.cc: Include packagedb headers.
58b12a06
MB
6745 (check_for_cached): New method to find any cached file and fill out the
6746 database info.
bb849dbd
RC
6747 (download_one): Take a packagesource, support multiple mirrors.
6748 (do_download): Use packagemeta.
6749 * from cwd.cc: Include packagedb headers.
6750 (found_file): Use packagemeta.
6751 * ini.cc (do_ini): Beginning of multiple-mirror support.
6752 * ini.h (CategoryPackage): Remove.
6753 (Dependency): Remove.
6754 (Package): Remove.
58b12a06
MB
6755 (new_package,getpkgbyname,getpackagecategorybyname,add_category):
6756 Remove.
bb849dbd
RC
6757 * inilex.l: Support multiple mirrors.
6758 * iniparse.y: Include packagedb headers.
6759 (parser): Use packagemeta.
6760 (new_package): Remove.
6761 (add_correct_version): New function.
6762 (new_requirement): Remove.
6763 (add_category): Remove.
6764 * install.cc (uninstall_one): Use packagemeta.
6765 (install_one_source): New function.
6766 (install_one): Use packagemeta.
6767 (do_install): Use packagemeta.
6768 * io_stream.cc (io_stream::move): Bugfix on move/copy case.
58b12a06
MB
6769 * io_stream_cygfile.cc (io-stream_cygfile::set_mtime): Do not reopen the
6770 file after setting the mtime, it makes no sense, and results in 0 length
6771 files.
bb849dbd
RC
6772 * io_stream_file.cc (io-stream_file::set_mtime): Ditto.
6773 * list.h: New file, template class for a form of list.
6774 * package_db.cc (packagedb::registerpackage): New function.
6775 * package_db.h (packagedb::npackages ()): New method.
6776 * package_meta.cc (packagemeta::add_version): Use list template.
6777 (packagemeta::set_installed): Ditto.
6778 (packagemeta::add_category): New method.
6779 * package_meta.h: Include necessary headers to parse the class.
6780 (CategoryPackage): New class.
6781 (packagemeta): Initialise all members.
6782 (packagemeta::SDesc): New method.
6783 (packagemeta::Categories): New method.
6784 (packagemeta::add_category): Ditto.
6785 (packagemeta::versions): Change to be a list instance.
6786 * package_source.cc (packagesource::set_canonical): New method.
6787 (packagesource::set_cached): New method.
6788 * package_source.h: Include necessary headers to parse the class.
6789 (site): New class.
6790 (packagesource::packagesource): Initialize all members.
6791 (packagesource): Make this class non-abstract.
6792 * package_version.cc (packageversion::packageversion): New method.
6793 * package_version.h (Dependency): New class.
6794 (packageversion::Canonical_vesion): New method.
6795 (packageversion::SDesc): New method.
6796 (packageversion::LDesc): New method.
6797 (packageversion::new_requirement): Ditto.
6798 (packageversion::srcpicked, binpicked): What to install.
6799 (packageversion::src, bin): Installation source data.
6800 * rfc1738.cc: New file. Escapes special characters in URL's.
6801 * rfc1738.h: Ditto.
6802
90d14922
RC
68032001-11-26 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6804
6805 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Stop header parsing when
6806 SimpleSocket::gets() returns a zero-length string, so that we
6807 don't end up eating the entire stream thinking it's all header info.
6808
7c7034e8
RC
68092001-11-23 Robert Collins <rbtcollins@hotmail.com>
6810
6811 * install.cc (badrename): Remove.
58b12a06
MB
6812 (do_install): Use packagedb flush method to write
6813 /etc/setup/installed.db.
7c7034e8
RC
6814 * io_stream.cc (io_stream::move_copy): New method.
6815 (io_stream::move): New method.
6816 * io_stream.h (io_stream): New methods move and move_copy.
6817 * io_stream_cygfile.cc (io_stream_cygfile::move): New method.
6818 * io_stream_cygfile.h (io_stream_cygfile): New method move.
6819 * io_stream_file.cc (io_stream_file::move): New method.
6820 * io_stream_file.h (io_stream_file): New method move.
6821 * package_db.cc (packagedb::flush): New method.
6822 * package_db.h (packagedb): New method flush.
6823
fa0c0d10
RC
68242001-11-23 Robert Collins <rbtcollins@hotmail.com>
6825
6826 * Makefile.in (OBJS): Add package_version.
6827 * ategory.cc (Category::Category): Update constructors.
6828 * category_list.cc (CategoryList::register_category): Insert correctly.
6829 * choose.cc: Include package_version.h, not package.h.
6830 * cygpackage.cc: Ditto.
6831 (cygpackage::uninstall): New method.
6832 * cygpackage.h (cygpackage): Rename genericpackage to packageversion.
6833 New method uninstall.
6834 * hash.cc (add, has, enumerate): Change prototype to be accurate.
6835 * hash.h (hash): Change prototypes to be accurate.
6836 * ini.h (_Info): New parameterless constructor.
6837 (CategoryPackage): New constructor.
6838 (Package): Ditto.
6839 * install.cc: Don't include unneeded headers.
6840 Include package database headers.
6841 (hash::add_subdirs): Remove.
58b12a06
MB
6842 (uninstall_one): Use packagemeta->uninstall to perform the
6843 uninstallation. Don't uninstall source packages.
6844 (do_install): Just can uninstall_one once as we ignore source packages
6845 now. Don't copy the installed.old database accross, instead iterate
6846 through the packagedb packages list and write the installed packages
6847 out.
fa0c0d10
RC
6848 * package_db.cc: Include package_version.h, not package.h.
6849 (packagedb::packagedb): Never let db be undefined.
6850 Record the installation filename, so we can reconstruct installed.db.
6851 (packagedb::addpackage): Insert packages in alpha sorted order.
6852 (packagedb::categories): Initialise correctly.
6853 * package_meta.cc: Include win32 and mount headers as a workaround to
6854 current io_stream limitations. Include a TODO about that.
6855 (standard_dirs): New, from install.cc.
6856 (hash::add_subdirs): New, from install.cc.
6857 (packagemeta::set_installed): Rename genericpackage to packageversion.
6858 (packagemeta::uninstall): New method.
6859 * package_meta.h: Rename genericpackage to packageversion.
6860 (packagemeta): Update constructor.
6861 (add_version, set_installed): Rename genericpackage to packageversion.
6862 (uninstall): New method.
6863 (installed_from): New member.
6864 * package_source.cc: New file.
6865 * package_source.h: New file.
6866 * package_version.cc: New file.
6867 * package_version.h: New file.
6868 * package.cc: Removed.
6869 * package.h: Removed.
cef493d7 6870
7b606ae5
RC
68712001-11-21 Robert Collins <rbtcollins@hotmail.com>
6872
6873 * Makefile.in (OBJS): Add category.o and category_list.o.
6874 * category.h: New file.
6875 * category.cc: New file.
6876 * category_list.h: New file.
6877 * category_list.cc: New file.
6878 * choose.cc: Include category headers.
6879 (fill_missing_category): Use package_db to access global categories.
6880 (_view::insert_pkg): Ditto.
6881 (_view::insert_category): Ditto.
6882 (set_view_mode): Ditto.
6883 (getcategorybyname): Remove.
6884 * cygpackage.h: Include category_list.h to parse this correctly.
6885 (cygpackage): New virtual &Categories.
6886 * ini.h (_CategoryPackage): More C to C++ conversion.
6887 (Category): Remove.
6888 (getcategorybyname): Remove.
6889 (register_category): Remove.
6890 * iniparse.y: Include package db and category headers.
6891 (categories): Use package_db to access global categories.
6892 (category): Remove.
6893 (ncategories): Remove.
6894 (register_category): Remove.
6895 * package.h: New virtual &Categories.
58b12a06
MB
6896 * package_db.cc (packagedb::packagedb): Don't read the installed db
6897 twice.
7b606ae5 6898 (packagedb::categories): Declare.
58b12a06
MB
6899 * package_db.h (packagedb): New member categories for global categories
6900 list.
7b606ae5 6901
d0fa1c4e
RC
69022001-11-21 Robert Collins <rbtcollins@hotmail.com>
6903
6904 * choose.h: Don't include ini.h
6905 * ini.h: Allow pure c++ in the header file.
6906
24cbae7f
RC
69072001-11-21 Robert Collins <rbtcollins@hotmail.com>
6908
6909 * install.cc (do_install): Write a version 2 installed.db file.
58b12a06
MB
6910 * package_db.cc (packagedb::packagedb): Read version 1 and 2
6911 installed.db files.
24cbae7f 6912
7939f6d1
RC
69132001-11-21 Robert Collins <rbtcollins@hotmail.com>
6914
6915 * Makefile.in (OBJS): Add package abstraction objects.
6916 * choose.cc: Include package abstraction headers.
6917 (read_installed_db): Use packagedb class and ignore installed sources.
6918 * cygpackage.cc: New file.
6919 * cygpackage.h: New file.
6920 * filemanip.h (get_file_size): Use unixy types.
6921 * package.h: New file.
6922 * package.cc: New file.
6923 * package_db.cc: New file.
6924 * package_db.h: New file.
6925 * package_meta.cc: New file.
6926 * package_meta.h: New file.
6927
33bc0053
RC
69282001-11-21 Robert Collins <rbtcollins@hotmail.com>
6929
6930 * REAME: Updates to wishlist.
6931
12ccadc0
RC
69322001-11-16 Robert Collins <rbtcollins@hotmail.com>
6933
6934 * README: Updated and added my list of wishlist and todo items.
6935
ca9506cc
RC
69362001-11-14 Robert Collins <rbtcollins@hotmail.com>
6937
6938 * Makefile.in (OBJS): Include io_stream_memory in setup.exe.
6939 * archive_tar.cc (archive_tar::write): New prototype.
6940 (archive_tar::seek): New method.
6941 * archive.h (archive_tar_file): Update write() and add seek().
6942 (archive_tar): Ditto.
6943 * archive_tar_file.cc (archive_tar_file::write): New prototype.
6944 (archive_tar_file::seek): New method.
6945 * compress_bz.cc (compress_bz::write): New prototype.
6946 (compress_bz::seek): New function.
6947 * compress_bz.h (compress_bz): Update write() and add seek().
6948 * compress_gz.cc (compress_gz::write): New prototype.
6949 (compress_gz::seek): New function.
6950 * compress_gz.h (compress_gz): Update write() and add seek().
6951 * geturl.cc: Include io_stream headers.
6952 (GUBuf): Remove.
6953 (get_url_to_string): Use a io_stream_memory buffer instead of GUBuf.
6954 * io_stream.h (io_stream_seek_t): New enum.
6955 (io_stream): Update write() and add seek().
6956 * io_stream_cygfile.cc (io_stream_cygfile::write): New prototype.
6957 (io_stream_cygfile::seek): New function.
58b12a06
MB
6958 * io_stream_cygfile.h (io_stream_cygfile): Update write() and add
6959 seek().
ca9506cc
RC
6960 * io_stream_file.cc (io_stream_file::write): New prototype.
6961 (io_stream_file::seek): New function.
6962 * io_stream_file.h (io_stream_file): Update write() and add seek().
6963
2db33f10
RC
69642001-11-13 Brian Keener <bkeener@thesoftwaresource.com>
6965
6966 * localdir.cc: Add headers unistd.h and port.h.
cef493d7 6967 (save_local_dir): Expand search logic to include local directory for
2db33f10
RC
6968 location of file last-cache.
6969 (dialog_cmd): Skip IDD_ROOT when downloading and use Back button.
cef493d7 6970 (do_local_dir): Expand search logic to include local directory for file
2db33f10
RC
6971 last-cache.
6972 * res.rc (IDD_CHOOSE_DIALOG): Add hotkey to View button.
cef493d7 6973 * Source.cc (dialog_cmd): Skip IDD_ROOT if select Download from
2db33f10 6974 Internet.
cef493d7 6975 (do_source): Default to Install from Internet on first entry or
2db33f10
RC
6976 previous selection if backing up from IDD_ROOT or IDD_LOCAL_DIR.
6977
03a6c5b1
RC
69782001-11-13 Robert Collins <rbtcollins@hotmail.com>
6979
6980 * choose.cc (find_tar_ext): Only match at the end of the string.
6981 (getpkgbyname): Prevent NULL pointer dereference.
6982
b24c88b3
RC
69832001-11-13 Robert Collins <rbtcollins@hotmail.com>
6984
6985 * Makefile.in (CFLAGS): Add warnings and -Werr.
58b12a06
MB
6986 (WARNONLY_FLAGS): For sources that produce (harmless) errors no matter
6987 what.
b24c88b3
RC
6988 (OBJS): Add io_stream class' objects.
6989 (autoload.o): Use WARNONLY_FLAGS.
6990 (inilex.o): Ditto.
6991 (iniparse.o): Ditto.
6992 * archive.cc: New file.
6993 * archive.h: New file.
6994 * archive_tar.cc: New file.
6995 * archive_tar.h: New file.
6996 * archive_tar_file.cc: New file.
6997 * autoload.c: Fix compiler warnings (unused, deprecated conversion).
6998 * choose.cc: Use io_stream.h, not mount.h.
6999 Run indent.
58b12a06
MB
7000 (find_tar_ext): Rewritten to use strstr, and to accept .tar as an
7001 extension.
b24c88b3
RC
7002 (read_installed_db): Use io_streams.
7003 * choose.h: Run indent.
7004 * compress.cc: New file.
7005 * compress.h: New file.
7006 * compress_bz.cc: New file.
7007 * compress_bz.h: New file.
7008 * compress_gz.cc: New file.
7009 * compress_gz.h: New file.
7010 * concat.cc: Run indent.
7011 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7012 * concat.h: Run indent.
7013 * desktop.cc: Run indent.
7014 Include mklink2.h rather than redefining by hand.
7015 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7016 (etc_profile): Fix compiler warning (deprecated conversion).
7017 (make_link): Fix compiler warning (deprecated conversion).
7018 Tidy up use of args variable - consolidate into argbuf.
7019 (start_menu): Fix compiler warning (deprecated conversion).
7020 (desktop_icon): Fix compiler warning (deprecated conversion).
7021 (make_etc_profile): Fix compiler warning (deprecated conversion).
7022 (uexists): Fix compiler warning (deprecated conversion).
7023 (check_desktop): Fix compiler warning (deprecated conversion).
7024 (check_startmenu): Fix compiler warning (deprecated conversion).
7025 * dialog.cc: Run indent.
7026 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7027 (fatal): Fix compiler warning (deprecated conversion).
7028 * dialog.h: Run indent.
7029 * diskfull.cc: Run indent.
7030 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7031 * download.cc: Run indent.
7032 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7033 (download_one): Fix compiler warning (signed vs unsigned comparison).
7034 * filemanip.h: Run indent.
7035 * find.cc: Run indent.
7036 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7037 (find): Fix compiler warning (deprecated conversion).
7038 * find.h: Run indent.
7039 * fromcwd.cc: Run indent.
7040 * geturl.cc: Run indent.
7041 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7042 (dialog_cmd): Return a value.
7043 (dialog_proc): Remove unused variables.
7044 Return a value.
7045 (get_url_to_file): Fix compiler warning (deprecated conversion).
7046 * geturl.h: Run indent.
7047 * hash.cc: Run indent.
7048 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7049 * hash.h: Run indent.
7050 * ini.cc: Run indent.
7051 Use io_streams.
7052 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7053 (do_ini): Use io_streams for local io.
7054 * ini.h: Run indent.
7055 * inilex.l (ignore_line): Fix compiler warning (is not a prototype).
7056 Fix compiler warning (brackets for truth assignment).
7057 * install.cc: Run indent.
7058 Fix compiler warning (/* in comment).
7059 Use io_streams.
7060 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7061 (dialog_cmd): Return a value.
7062 (dialog_proc): Return a value.
7063 (start_tics): Deleted - was unused.
7064 (badrename): Fix compiler warnings (unused, deprecated conversion).
7065 (standard_dirs): Fix compiler warning (deprecated conversion).
7066 (exists): Remove.
7067 (uninstall_one): Convert to io_streams.
7068 (install_one): Convert to io_streams.
7069 (do_install): Convert to io_streans.
7070 Fix compiler warning (deprecated conversion).
7071 * io_stream.cc: New file.
7072 * io_stream.h: New file.
7073 * io_stream_cygfile.cc: New file.
7074 * io_stream_cygfile.h: New file.
7075 * io_stream_file.cc: New file.
7076 * io_stream_file.h: New file.
7077 * localdir.cc: Run indent.
7078 Use io_streams.
7079 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7080 (get_root_dir_now): Remove.
7081 (save_local_dir): Convert to io_streams.
7082 (dialog_cmd): Return a value.
7083 (do_local_dir): Convert to io_streams.
7084 (log.cc): Run indent.
7085 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7086 (log): Fix compiler warning (deprecated conversion).
7087 (log_save): Fix compiler warning (deprecated conversion).
7088 * log.h: Run indent.
7089 (log): Fix compiler warning (deprecated conversion).
7090 (log_save): Fix compiler warning (deprecated conversion).
7091 * main.cc: Run indent.
7092 Don't include "netio.h".
7093 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7094 (netio_test): Remove.
7095 (sid_auth): Fix compiler warning (partially bracketed initialiser).
7096 (WinMain): Return a value.
7097 * mkdir.cc: Run indent.
7098 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7099 * mklink2.c: Run indent.
7100 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7101 (mkcygsymlink): New function.
7102 * mklink2.h: New file.
7103 * mount.cc: Run indent.
7104 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7105 (create_mount): Remove unused variables.
7106 (cygpath): Fix compiler warning (signed vs unsigned comparison).
7107 * mount.h: Run indent.
7108 * msg.cc: Run indent.
7109 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7110 (msg): Fix compiler warning (deprecated conversion).
7111 (mbox): Fix compiler warning (deprecated conversion).
7112 * msg.h: Run indent.
7113 (msg): Fix compiler warning (deprecated conversion).
7114 * net.cc: Run indent.
7115 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7116 (dialog_cmd): Return a value.
7117 * netio.cc: Run indent.
7118 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7119 (auth_cmd): Return a value.
7120 * netio.h: Run indent.
7121 * nio-file.cc: Run indent.
7122 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7123 (NetIO_File::NetIO_File): Fix compiler warning (deprecated conversion).
7124 * nio-file.h: Run indent.
7125 * nio-ftp.cc: Run indent.
7126 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7127 * nio-ftp.h: Run indent.
7128 * nio-http.cc: Run indent.
7129 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7130 * nio-http.h: Run indent.
7131 * nio-ie5.cc: Run indent.
7132 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7133 * nio-ie5.h: Run indent.
7134 * other.cc: Run indent.
7135 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7136 (dialog_cmd): Return a value.
7137 * port.h: Run indent.
7138 * postinstall.cc: Run indent.
7139 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7140 (cmd): Fix compiler warning (deprecated conversion).
7141 (eun): Fix compiler warning (deprecated conversion).
7142 * root.cc: Run indent.
7143 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7144 * simpsock.cc: Run indent.
7145 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7146 * simpsock.h: Run indent.
7147 * site.cc: Run indent.
7148 Use io_streams.
7149 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7150 (get_root_dir_now): Remove.
7151 (save_site_url): Convert to io_streams.
7152 (dialog_cmd): Return 0.
7153 (get_initial_list_idx): Convert to io_streans.
7154 * source.cc: Run indent.
7155 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7156 (check_if_enable_next): Remove.
7157 (load_dialog): Remove unused variables.
7158 (save_dialog): Ditto.
7159 (dialog_cmd): Return a value.
7160 * splash.cc: Return a value.
7161 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7162 (dialog_cmd): Return a value.
7163 * state.cc: Run indent.
7164 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7165 * state.h: Run indent.
7166 * tar.h: Remove.
7167 * tar.cc: Remove.
7168
398dd7b2
CF
71692001-11-12 Christopher Faylor <cgf@redhat.com>
7170
7171 * desktop.cc (start_menu): Change start menu name to "Cygwin".
7172 (check_startmenu): Ditto.
7173
c29ee141
CF
71742001-11-11 Christopher Faylor <cgf@redhat.com>
7175
7176 * choose.cc (parse_filename): Finish reorganization by correctly
7177 decrementing p in memmove.
7178
3a8276de
CF
71792001-11-11 Christopher Faylor <cgf@redhat.com>
7180
7181 * choose.cc (parse_filename): Reorganize code to work around gcc
7182 optimization problem.
7183
6eea52fb
RC
71842001-11-09 Gareth Pearce <tilps@hotmail.com>
7185
7186 * choose.cc (set_action): Allow skip as an option for installed
7187 packages that have version number not listed in setup.ini.
7188
cf99b153
RC
71892001-11-10 Robert Collins <rbtcollins@hotmail.com>
7190
7191 * choose.cc (set_cation): Backout last change.
7192 (choose_caption): Ditto.
7193
55e204f6
RC
71942001-11-10 Robert Collins <rbtcollins@hotmail.com>
7195
7196 * ini.h (actions): Remove - transferred to choose.h.
7197 (views): Ditto.
7198 * choose.h: Protect class's from "C" compilers.
7199 (actions): New enum, from ini.h. This may not be the 'right' place
7200 but that place doesn't exist yet.
7201 (_views): New enum, from ini.h.
58b12a06
MB
7202 * choose.cc (set_action): Handle installed packages with a version not
7203 in setup.ini.
55e204f6
RC
7204 (choose_caption): Ditto.
7205 * iniparse.y: Rearrange header order to handle new ini.h.
7206
72072001-11-10 Robert Collins <rbtcollins@hotmail.com>
7208
7209 * ini.h (_Info): Fix compiler warnings (signed vs unsigned comparison).
7210 (registry_category): Fix compiler warning (deprecated conversion).
7211 * iniparse.y (registry_category): Ditto.
58b12a06
MB
7212 * choose.cc (cvsid): Fix compiler warnings (unused, deprecated
7213 conversion).
55e204f6
RC
7214 (add_requried): Remove unused variable.
7215 (choose_caption): Handle all enumeration values via a default.
7216 (paint): Fix compiler warnings (unused, deprecated conversion).
58b12a06
MB
7217 (scroll_common): Fix compiler warnings (unused, signed vs unsigned
7218 comparison).
55e204f6
RC
7219 (list_clicK): Fix compiler warnings (signed vs unsigned comparison).
7220 (note_width): Fix compiler warnings (deprecated conversion).
7221 (keep_or_skip): Fix compiler warnings (unused).
7222 (_view::mode_caption): Fix compiler warnings (deprecated conversion).
7223 (set_view_mode): Fix compiler warnings (unused).
58b12a06
MB
7224 (create_listview): Fix compiler warnings (unused, incorrect format,
7225 reaches end of function).
55e204f6 7226 (dialog_proc): Fix compiler warnings (unused).
58b12a06
MB
7227 (read_installed_db): Fix compiler warnings (unused, deprecated
7228 conversion).
55e204f6
RC
7229 * choose.h (_header): Fix compiler warnings (deprecated conversion).
7230 (_view): Ditto.
7231
67a55ad9 72322001-11-08 Pavel Tsekov <ptsekov@syntrex.com>
cef493d7 7233
67a55ad9
RC
7234 * simpsock.h (SimpleSocket::invalidate): Declare new method.
7235 * simpsock.cc (SimpleSocket::invalidate): Implement new method.
7236 (SimpleSocket::SimpleSocket): Initialize buf to zero. Do not allocate
7237 memory for buf in the constructor.
7238 (SimpleSocket::~SimpleSocket): Use SimpleSocket::invalidate().
7239 (SimpleSocket::printf): Use SimpleSocket::write() instead of send().
7240 (SimpleSocket::write): Check object consistency - return -1 on error.
7241 invalidate() the object on socket write error.
7242 (SimpleSocket::fill): Check object consistency - return -1 on error.
7243 invalidate() the object if socket read error is encountered and there
7244 is no more data available in the internal read buffer.
7245 Allocate memory for the internal read buffer.
7246 (SimpleSocket::gets): Return zero (NULL pointer) if error is encountered
7247 during fill() and no more data is available in the internal read buffer.
7248 (SimpleSocket::read): Check object consistency - return -1 on error.
7249 invalidate() the object if socket read error is encountered.
7250 * nio-ftp.cc (NetIO_FTP:NetIO_FTP): Allow 125 as valid response code to
7251 the RETR command (fix for MS IIS ftp server 5 - possibly others too).
7252 (NetIO_FTP::ok): Check if the SimpleSocket object is ok().
7253 (NetIO_FTP::read): Use NetIO_FTP::ok().
7254 * nio-http.cc: Check for valid return value of SimpleSocket::gets().
7255 (NetIO_HTTP::ok): Check if the SimpleSocket object is ok().
7256
5898e300
RC
72572001-11-09 Robert Collins <rbtcollins@hotmail.com>
7258
58b12a06
MB
7259 * simpsock.cc (cvsid): Avoid compiler warnings (not used, deprecated
7260 conversion).
7261 (SimpleSocket::SimpleSocket): Avoid compiler warnings (deprecated
7262 conversion).
5898e300
RC
7263 (SimpleSocket::printf): Ditto.
7264 (SimpleSocket::write): Ditto.
7265 * simpsock.h (SimpleSocket): Avoid compiler warnings for constructor,
7266 printf and write.
58b12a06
MB
7267 * nio-ftp.cc (cvsid): Avoid compiler warnings (not used, deprecated
7268 conversion).
5898e300 7269 (NetIO_FTP::NetIO_FTP): Remove unused variable done.
58b12a06
MB
7270 * nio-http.cc (cvsid): Avoid compiler warnings (not used, deprecated
7271 conversion).
5898e300 7272
8e58f8fd
RC
72732001-11-07 Charles Wilson <cwilson@ece.gatech.edu>
7274
7275 * geturl.cc (get_url_to_string): clean up memory leak
7276 (get_url_to_file): ditto
cef493d7 7277
4b4002ab
RC
72782001-11-06 Robert Collins <rbtcollins@hotmail.com>
7279
7280 * localdir.cc (dialog_cmd): Go back to IDD_ROOT in every case.
7281 * source.cc (dialog_cmd): Go forward to IDD_ROOT in every case.
7282
94525fd9
RC
72832001-11-06 Pavel Tsekov <ptsekov@syntrex.com>
7284
7285 * fromcwd.cc (found_file): Free() memory containing the version and
58b12a06
MB
7286 filepath information for a given package, before replacing the pointers
7287 which reference this memory.
94525fd9
RC
7288
72892001-11-06 Robert Collins <rbtcollins@hotmail.com>
ca83c665
RC
7290
7291 * fromcwd: Fix compiler warnings for cvsid.
7292 (canonicalize_version): Fix compilter warnings.
7293 (do_fromcwd): Ditto.
7294 * version.h: Fix compiler warnings for canonicalize_version.
7295
ce1f9ec2
RC
72962001-11-03 Robert Collins <rbtcollins@hotmail.com>
7297
7298 * res.rc (IDD_CHOOSE): Move the view caption to the right hand side.
7299
89d82ec7
RC
73002001-11-02 Robert Collins <rbtcollins@hotmail.com>
7301
7302 * res.rc (IDD_CHOOSE): Tweak for use on a 640x480 screen.
7303
c8fea72a
RC
73042001-11-02 Robert Collins <rbtcollins@hotmail.com>
7305
58b12a06
MB
7306 * choose.cc (set_action): Correctly allow skip for any uninstalled
7307 package.
8114d309
RC
7308
73092001-11-02 Robert Collins <rbtcollins@hotmail.com>
7310
58b12a06
MB
7311 * choose.cc (default_trust): Change the "Required" forced install
7312 category to "Base".
c8fea72a 7313
f557695e
RC
73142001-11-02 Robert Collins <rbtcollins@hotmail.com>
7315
7316 * choose.cc: Ran indent.
58b12a06
MB
7317 (set_action): When the requested trust level is missing and the level
7318 was not user requested, set the action to ACTION_SAME_CURR.
f557695e 7319
9a60dafc
CF
73202001-11-01 Christopher Faylor <cgf@redhat.com>
7321
cef493d7 7322 * Makefile.in (mingw_getopt.o): Fix typo in non-verbose compilation.
f557695e
RC
7323
73242001-11-02 Robert Collins <rbtcollins@hotmail.com>
7325
7326 * choose.cc (_view::init_headers): Resync with the paint logic.
9a60dafc 7327
878faffd
RC
73282001-11-02 Robert Collins <rbtcollins@hotmail.com>
7329
58b12a06
MB
7330 * choose.cc (add_required): Allow SKIP and SRC_ONLY for currently
7331 installed packages.
878faffd 7332
05bfdf26
RC
73332001-11-02 Robert Collins <rbtcollins@hotmail.com>
7334
58b12a06
MB
7335 * choose.cc (default_trust): Autoset currently installed packages per
7336 the user's selection of prev/curr/exp.
05bfdf26 7337
0b9af00c
RC
73382001-11-02 Robert Collins <rbtcollins@hotmail.com>
7339
7340 * splash.cc (dialog_proc): Return TRUE as specified in the WIN32 API.
7341
7cefe128
RC
73422001-11-02 Pavel Tsekov <ptsekov@syntrex.com>
7343
7344 * geturl.cc (is_showing): Remove.
7345 (is_local_install): New static variable. Controls whether the
7346 progress dialog and the supporting thread will be created.
58b12a06
MB
7347 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the WIN32
7348 API.
7cefe128 7349 (init_dialog): Remove usage of SetForegroundWindow and is_showing.
cef493d7 7350 This prevents the progress dialog to gain control over the
7cefe128
RC
7351 application and fixes the "setup.exe going to background" problem.
7352 (progress): Use is_local_install.
7353 (get_url_to_string): Set is_local_install.
7354 (dismiss_url_status_dialog): Use is_local_install.
7355 * install.cc (dialog_proc): Return TRUE as specified in WIN32 API.
7356 (init_dialog): Remove usage of SetForegroundWindow.
cef493d7 7357 This prevents the progress dialog to gain control over the
7cefe128
RC
7358 application and fixes the "setup.exe going to background" problem.
7359
42a99ed1
RC
73602001-11-02 Robert Collins <rbtcollins@hotmail.com>
7361
7362 * choose.cc (list_click): Change r to row for clarity.
7363 When we shrink the list below 1 page, scroll to the top of the list.
7364 (_view::click): Return the actual change for contractions.
58b12a06
MB
7365 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the Win32
7366 API.
42a99ed1 7367
45c2d7d3
RC
73682001-11-02 Robert Collins <rbtcollins@hotmail.com>
7369
58b12a06
MB
7370 * choose.cc (dialog_cmd): Swap cygwin root selection and local dir
7371 selection order.
45c2d7d3
RC
7372 * localdir.cc: Ran indent.
7373 (get_root_dir_now): New function.
7374 (save_local_dir): New function.
58b12a06
MB
7375 (dialog_cmd): Use it and swap cygwin root selection and local dir
7376 selection order.
45c2d7d3 7377 (do_local_dir): If there is a saved local dir, read it in.
58b12a06
MB
7378 * net.cc (dialog_cmd): Swap cygwin root selection and local dir
7379 selection order.
45c2d7d3
RC
7380 * root.cc (dialog_cmd): Ditto.
7381 * source.cc (dialog_cmd): Ditto.
7382
2399c54d
RC
73832001-11-01 Robert Collins <rbtcollins@hotmail.com>
7384
7385 * choose.cc(list_vscroll): Return 0 as required by win32.
7386 (list_hscroll): Ditto.
7387 (list_click): Ditto.
7388
8e4402a9
RC
73892001-11-01 Robert Collins <rbtcollins@hotmail.com>
7390
7391 * argv.cc: Remove.
7392 * argv.h: Remove.
7393 * main.cc(WinMain): Use __argv to retrieve command line parameters.
7394 * Makefile,in: Remove argv.o.
7395
c168185f
RC
73962001-11-01 Matt Hargett <matt@use.net>
7397
cef493d7
CF
7398 * geturl.cc (progress): Change int to unsigned int to eliminate
7399 lint warnings.
7400 * (get_url_to_string): Check for NULL pointer.
7401 * mount.cc (find2): Use free instead of delete for malloc'd
7402 memory.
7403 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.
c168185f 7404
f97a1ece
RC
74052001-10-31 Robert Collins <rbtcollins@hotmail.com>
7406
58b12a06
MB
7407 * choose.cc(_view::insert_under): Handle linen > nlines and lines[linen]
7408 with neither a package nor a category. The lines[linen] bug was reported
7409 by Matt (matt@usa.net).
7410 (read_installed_db): Bugfix for testing whether a package has a source
7411 tarball. Reported by Matt (matt@usa.net).
7412 * geturl.cc(dialog): Rename gw_dialog to local_gw_dialog to avoid
7413 programmer confusion and lint errors. Reported by Matt (matt@usa.net).
f97a1ece 7414
d52ed64b
RC
74152001-10-31 Robert Collins <rbtcollins@hotmail.com>
7416
58b12a06
MB
7417 * argv.cc: New file, converts arguments for -mwindows
7418 programs. (Simplified derivation from dcrt0.cc.)
d52ed64b
RC
7419 * argv.h: New file.
7420 * Makefile,in: Add argv.o and mingw_getopt.o to setup.exe object list.
7421 Add mingw_getopt.o build rule.
7422 * main.cc(WinMain): Initialise argv and argc for use by getopt.
7423
392ba1ba
CF
74242001-10-27 Christopher Faylor <cgf@redhat.com>
7425
7426 * res.rc: Rearrange info on top line slightly.
7427
31324d15
CF
74282001-10-27 Christopher Faylor <cgf@redhat.com>
7429
7430 * desktop.cc (make_passwd_group): Move file creation earlier in the
7431 process to ensure that passwd-grp.bat reflects desired operation.
7432
74332001-27-10 Trevor Forbes <t4bs@hotmail.com>
7434
7435 * postinstall.cc (each): Remove "*.done" file else rename will fail.
7436
ee411d77
CF
74372001-10-16 Christopher Faylor <cgf@redhat.com>
7438
7439 * res.rc: Oops. Take 640x480 screen size into account.
7440
e74944da
CF
74412001-10-16 Christopher Faylor <cgf@redhat.com>
7442
7443 * res.rc: Enlarge chooser screen.
7444
e368cfb9
CF
74452001-10-12 Christopher Faylor <cgf@redhat.com>
7446
7447 * Makefile.in: Accomodate changes to w32api_include macro.
7448
a6ba3670
CF
74492001-10-12 Christopher Faylor <cgf@redhat.com>
7450
7451 * Makefile.in: Use correct flags for windres.
7452
683e96f6
CF
74532001-10-12 Christopher Faylor <cgf@redhat.com>
7454
7455 * Makefile.in (CFLAGS): Remove -nostdinc from CFLAGS.
7456
2c18c00b
CF
74572001-10-12 Christopher Faylor <cgf@redhat.com>
7458
7459 * choose.cc (pick_line::paint): Reorganize after botched patch.
7460
0f61a05a
CF
74612001-10-12 Christopher Faylor <cgf@redhat.com>
7462
7463 * choose.cc (pick_line::paint): Add missing declaration.
7464
308d6f3e
CF
74652001-10-10 Ralf Habacker <Ralf.Habacker@freenet.de>
7466
7467 * choose.cc (pick_line::paint): Add package name to sdesc for display.
7468
3bcf85be
RC
7469Wed Sep 26 21:39:00 Robert Collins rbtcollins@hotmail.com
7470
7471 * choose.cc (_view::insert_pkg): Correctly exit loop.
7472 * iniparse.y (register_category): Always insert new categories.
7473
fb2cd8f6
CF
7474Fri Sep 21 13:56:32 2001 Christopher Faylor <cgf@cygnus.com>
7475
7476 * inilex.l (yylex): For comments, eat all characters up to, but not
7477 including newline.
7478
127b32e1
CF
7479Sun Aug 26 12:50:01 2001 John Marshall <jmarshall@acm.org>
7480
7481 * fromcwd.cc (found_file): Use correct package name when adding an
7482 unknown package rather than random stack garbage.
7483
2cd555aa
CF
7484Sun Aug 12 14:25:21 2001 Christopher Faylor <cgf@cygnus.com>
7485
7486 * desktop.cc (make_passwd_group): .bat files need \r\n endings.
7487
4254cc64
CF
7488Wed Aug 8 13:53:47 2001 Christopher Faylor <cgf@cygnus.com>
7489
7490 * desktop.cc (etc_profile): Leave environment variables untouched.
7491
acbae401
CV
74922001-08-07 Corinna Vinschen <corinna@vinschen.de>
7493
7494 * autoload.c: Add dynamic load statements for NT/W2K
7495 advapi32 functions not available in 9x/ME.
7496 * main.cc (set_default_dacl): New function.
7497 (WinMain): Call `set_default_dacl' if running on NT/W2K.
7498
969a294c
CF
7499Sat Aug 4 21:35:53 2001 Christopher Faylor <cgf@cygnus.com>
7500
7501 * ini.h (_CategoryPackage): Change pkg field to pkgname for
7502 consistency.
7503 * choose.cc: Use pkgname field when referencing _CategoryPackage
7504 throughout.
7505 (fill_missing_category): Don't add excluded packages.
7506 (default_trust): Ditto.
7507 (_view::insert_pkg): Ditto.
7508 * iniparse.y (register_category): Use consistent variable name.
7509
9eeb0e83
ED
75102001-07-09 Egor Duda <deo@logos-m.ru>
7511
7512 * choose.cc: Use system foreground color for text output.
7513
06560feb
CF
7514Sat Jul 7 00:40:28 2001 Christopher Faylor <cgf@cygnus.com>
7515
7516 * choose.cc (set_action): Use default trust for determining reinstall
7517 and source only.
7518 (default_trust): Set default trust.
7519 (pick_line::paint): Allow source selection when reinstalling or
7520 retrieving.
7521
1fb09149
CF
7522Fri Jul 6 18:08:49 2001 Christopher Faylor <cgf@cygnus.com>
7523
7524 * choose.cc (isinstalled): Modify to properly accomodate special case
7525 of "download only".
7526 (set_action): Check downloaded components, not installed components if
7527 "download only".
7528 (set_existence): Always include full list of files when "download
7529 only".
7530
14cfffa5
CF
7531Fri Jul 6 00:37:05 2001 Christopher Faylor <cgf@cygnus.com>
7532
7533 * choose.cc (pick_line::paint): Properly display "na" field when no
7534 source exists.
7535
f54385f6
CF
7536Thu Jul 5 00:34:23 2001 Christopher Faylor <cgf@cygnus.com>
7537
7538 * choose.cc (scan2): Ensure that older versions do not show up in
7539 "Test" slot.
7540
85b1fb54
CF
7541Mon Jul 2 15:47:59 2001 Christopher Faylor <cgf@cygnus.com>
7542
7543 * choose.cc (set_action): Allow "Skip" action if trust != installed.
7544 * res.rc: Fix copyright.
7545
2dada532
CF
7546Sat Jun 30 14:05:21 2001 Michael A Chase <mchase@ix.netcom.com>
7547
7548 * res.rc (IDD_LOCAL_DIR): Change caption to match the other dialog
7549 boxes.
06c6d195 7550 (IDD_CHOOSE): Adjust horizontal size so package names are visible.
2dada532
CF
7551
7552 * choose.cc: Restore some more changes from 2001-06-25, throughout.
7553 (paint): Wrap some excessively long lines.
7554 (pick_line::paint): Ditto. Move the arrow in the "Current" column
7555 right to where it belongs. Move the source checkbox slightly to the
7556 right.
7557 (do_choose): List categories and required packages in setup.log.full.
7558
7559Sat Jun 30 23:04:59 2001 Christopher Faylor <cgf@cygnus.com>
7560
58b12a06
MB
7561 * choose.cc (scan2): Restore source scanning eliminated by previous
7562 checkin.
2dada532 7563
1b13eeec
CF
7564Sat Jun 30 15:18:33 2001 Christopher Faylor <cgf@cygnus.com>
7565
7566 * ini.h (struct _Info): Add "derived" element.
7567 * choose.cc (scan2): Try to place unknown tar files into proper slot
7568 when package exists in setup.ini but tar file does not.
7569
9307254d
RC
7570Sat Jun 30 13:39:00 2001 Robert Collins <rbtcollins@hotmail.com>
7571
7572 * choose.cc (create_listview): Call set_view_mode with VIEW_CATEGORY.
7573 (do_choose): Log the first category name.
7574
3467d79f
CF
7575Fri Jun 29 23:07:44 2001 Christopher Faylor <cgf@cygnus.com>
7576
7577 *ini.h: Reapply 2001-06-25 changes.
7578 * choose.cc (add_required): Ditto. Default to "Keep" state if
7579 UNINSTALL and product is installed. Default to curr state if SKIP,
7580 etc.
7581 (keep_or_skip): New function. Returns skip or keep state depending on
7582 installed state of package.
7583 (default_trust): Use keep_or_skip to set state.
7584 (_view::insert_pkg): Use calloc to allocate lines.
7585 (set_view_mode): Adapt 2001-06-25 change to set_full_list here.
7586
8f53e82a
RC
7587Sat Jun 30 11:01:00 2001 Robert Collins <rbtcollins@hotmail.com>
7588
1fb09149 7589 * choose.cc: Remove globals full_list, headers, package_indexes and
8f53e82a
RC
7590 nindexes.
7591 Add globals cat_headers, pkg_headers and chooser.
7592 (add_required): New function.
7593 (paint): Use the chooser for header details.
7594 Call into the chooser to paint each line.
1fb09149 7595 (list_click): Use new global variables.
8f53e82a
RC
7596 Call into the chooser to handle the click.
7597 Repaint the entire view if packages have been added or removed.
7598 (note_width): Get passed a headers struct rather than using a global
7599 variable.
7600 (fill_missing_category): New function.
7601 (default_trust): Skip non-"Required" or "Misc" packages.
7602 (pick_line::set_line (Package *)): New function.
7603 (pick_line::set_line (Category *)): New function.
7604 (pick_line::paint): New function.
7605 (pick_line::click): New function.
7606 (_view::_view): New function.
7607 (_view::set_view_mode): New function.
7608 (_view::mode_caption): New function.
7609 (_view::set_headers): New function.
7610 (_view::init_header): New function.
7611 (_view::insert_pkg): New function.
7612 (_view::insert_category): New function.
7613 (_view::insert_at): New function.
7614 (_view::insert_under): New function.
7615 (_view::clear_view): New function.
7616 (viewsplusplus): New function.
7617 (_view::client): New function.
7618 (set_view_mode): Use new chooser functionality.
7619 (set_full_list): Use new global variables.
7620 (create_listview): Instantiate chooser.
7621 Remove all hardcoded headers[] code.
7622 (dialog_cmd): On trust changes, check dependencies.
7623 (getcategorybyname): New function.
7624 (getpackagecategorybyname): New function.
7625 (scan2): Use case-insensitive package comparison.
7626 (do_choose): Use fill_missing_category ().
7627 Show some category data.
7628 * ini.h: Protect against multiple inclusion.
7629 (views) New enum.
7630 (_CategoryPackage): New struct.
7631 (_Category): New struct.
7632 (_Package): Change category to Category * from char *.
7633 (extern Category category): New global variable.
7634 (extern in ncategories): Ditto.
7635 (getcategorybyname): New prototype.
7636 (catpackagecategorybyname): New prototype.
7637 (register_category): New prototype.
7638 (add_category): New prototype.
7639 * iniparse.y: Parse multiple categories per package.
2dada532
CF
7640 (category): New global variable.
7641 (ncategories): New global variable.
8f53e82a
RC
7642 (new_package): Compare package against NULL, not 0.
7643 (new_requirement): Source formatting fix.
7644 (register_category): New function.
7645 (add_category): New function.
7646 * res.rc: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
7647 IDC_CHOOSE_VIEWCAPTION: New control.
7648 * resource.h: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
7649 IDC_CHOOSE_VIEWCAPTION: New control.
7650 Increment _APS_NEXT_CONTROL_VALUE.
7651
26a27c14
CF
7652Mon Jun 25 00:56:37 2001 Michael A Chase <mchase@ix.netcom.com>
7653
e19ad6a3 7654 * choose.cc (paint): Wrap excessively long lines.
26a27c14
CF
7655 (list_click): Ditto.
7656 (create_listview): Ditto.
7657 (do_choose): Ditto. Replace TABs and remove CRs in lines written to
7658 setup.log.full. Allow "Yes" for source exists in setup.log.full when
7659 installing from local directories.
7660
97312777
CF
7661Mon Jun 25 00:56:37 2001 Christopher Faylor <cgf@cygnus.com>
7662
5f9f0d8d
CF
7663 * choose.cc (set_action): Only clear srcpicked when moving to next
7664 state. Allow source installation if it exists in the current "trust"
7665 state. Don't move to skip state when package is installed.
97312777
CF
7666 (list_click): Don't allow source clicking when no source is available.
7667 (set_full_list): Display package when not is_full_action.
7668 * ini.h (is_full_action): Define.
7669
72fd1d1e
CF
7670Sun Jun 17 12:06:14 2001 Christopher Faylor <cgf@cygnus.com>
7671
7672 * install.cc (check_for_old_cygwin): New function. First stab at
7673 checking for old cygwin versions.
7674 (do_install): Call check_for_old_cygwin if there were no errors during
7675 the install.
7676
41ac91b5 7677Sat Jun 16 11:33:51 2001 Michael A Chase <mchase@ix.netcom.com>
86202506
CF
7678
7679 * choose.cc (_Info::_Info): Test _source paramenter for non-NULL rather
7680 than zeroed "source" element.
7681
80429b97
CF
7682Fri Jun 15 20:54:43 2001 Christopher Faylor <cgf@cygnus.com>
7683
7684 * choose.cc (scan2): Insert unknown tar archives, found on disk, into
7685 the highest available "hole" in the trust array.
7686
654ea642
CF
7687Fri Jun 15 00:20:48 2001 Christopher Faylor <cgf@cygnus.com>
7688
7689 * choose.cc (set_existence): Use pointer method for indexing in trust
7690 array.
7691 (create_listview): Ditto.
7692 (scan2): Ditto. Also, use consistent variable name for indexing into
7693 trust array.
7694 * ini.h (Package): Reorganize info array for easier scanning.
7695
e98d90bd
CF
7696Fri Jun 15 00:01:51 2001 Christopher Faylor <cgf@cygnus.com>
7697
7698 * choose.cc (isinstalled): Eliminate special download only test.
7699 (set_action): Don't move to next state if in ACTION_SAME range and not
7700 incrementing.
7701 (choose_caption): Display "Retrieve" rather than "Reinstall" when just
7702 downloading.
7703 (do_choose): Sort packages after all packages have been read.
7704 Accomodate the fact that first element in trust array is empty so that
7705 log files don't report the wrong trust value.
7706 * iniparse.y (new_package): Malloc space for package name or suffer
7707 memory corruption.
7708
38c97581
CF
7709Thu Jun 14 22:43:59 2001 Robert Collins <rbtcollins@hotmail.com>
7710
7711 * ini.h (Dependency): New structure. Declare new function.
58b12a06
MB
7712 * inilex.l (yylex): Detect new setup.ini options - category and
7713 requires.
38c97581
CF
7714 * iniparse.y: Declare new setup.ini token values.
7715 (yyparse): Parse new token values.
7716 (new_requirement): New function.
7717
7718Thu Jun 14 22:43:26 2001 Christopher Faylor <cgf@cygnus.com>
7719
7720 * choose.cc (read_installed_db): Eliminate obsolete code.
7721
3ae6c15c
CF
7722Thu Jun 14 22:11:53 2001 Christopher Faylor <cgf@cygnus.com>
7723
7724 * choose.cc (set_action): Set trust on "redo".
7725 (_Info::_Info): New constructor.
7726 (read_installed_db): Use new constructor. Use trusts type for
7727 iterator.
7728 * ini.h (struct _Info): Label struct, add constructor.
7729 (Package): Make installed_ix a type 'trusts.'
7730 * install.cc (uninstall_one): Unset any installed info for current
7731 package.
7732 (install_one): Allocate new Info struct for installed reflecting new
7733 installed info.
7734 (do_install): Don't output line to installed.db if package is being
7735 uninstalled.
7736
9c0a9876
CF
7737Thu Jun 14 20:33:01 2001 Robert Collins <rbtcollins@hotmail.com>
7738
7739 * choose.cc (getpkgbyname): Use consistent method for scanning package
7740 array.
7741
68b27c12
CF
7742Wed Jun 13 23:33:08 2001 Christopher Faylor <cgf@cygnus.com>
7743
7744 * choose.cc: Add some comments.
7745 (getpkgbyname): Use strcasecmp for comparisons.
7746
07108cc2
CF
7747Wed Jun 13 16:07:00 2001 Christopher Faylor <cgf@cygnus.com>
7748
f0984dcb 7749 * install.cc (do_install): Avoid checking for download action if
07108cc2
CF
7750 package wasn't currently retrieved.
7751
c46a33a9
CF
7752Wed Jun 13 11:27:22 2001 Christopher Faylor <cgf@cygnus.com>
7753
7754 * choose.cc: Eliminate extra array throughout. Use element in package
7755 structure instead. Use pointers rather than array indexes where
7756 appropriate.
7757 (set_action): New function to set next action based on current.
7758 (choose_caption): New function. Returns display caption.
7759 (check_existence): Change arguments. Use pointer to 'info' structure.
7760 (set_existence): Use pointer rather than array index.
7761 (default_trust): Use trusts enum for second argument.
7762 (set_full_list): Honor exclude element in package structure.
7763 (build_labels): Eliminate.
7764 (base): Make global. Use const char * argument.
7765 (get_package_version): Eliminate.
7766 (getpkgbyname): New function.
7767 (read_installed_db): Use parse_filename to get version info.
7768 * desktop.cc (make_passwd_group): Use getpkgbyname function.
7769 * download.cc (get_file_size): const argument.
7770 (do_download): Use is_download_action to determine when something
7771 should be downloaded.
7772 * filemanip.h: Add some functions.
7773 * ini.cc (do_ini): Use NULL rather than 0 for pointer assignment.
7774 * ini.h: Use enums for actions and trusts.
7775 (is_download_action): New macro.
7776 (is_upgrade_action): Ditto.
7777 (is_uninstall_action): Ditto.
7778 (struct Package): Add new fields.
7779 * inilex.l (yylex): Detect new setup.ini options.
7780 * iniparse.y: Declare new tokens.
7781 (yyparse): Detect exclude keyword. Fill out version field even if
7782 version == 0.
7783 (new_package): Use greater granularity when allocating package array to
7784 avoid repeated calls to realloc.
7785 * install.cc (exists): const argument.
7786 (uninstall_one): Take pkg argument.
7787 (install_one): Ditto. Eliminate unneeded arguments which can be
7788 derived from package info.
7789 (do_install): Iterate over package array using a pointer. Use
7790 is_download_action to control when package should be downloaded.
7791 * tar.cc (tar_open): const argument.
7792 * tar.h: Refloect const argument.
7793
7cc06fd3
CF
77942001-05-31 Michael Chase mchase@ix.netcom.com
7795
7796 * main.cc (WinMain): Add setup version to starting setup.log entry
7797
9522028b
CF
7798Tue May 29 21:37:58 2001 Yukihiko Sohda <sohda@is.titech.ac.jp>
7799
7800 * inilex.l: Add + to list of valid string characters.
7801
e9b1aaa7
CF
7802Mon May 28 20:54:50 2001 Christopher Faylor <cgf@cygnus.com>
7803
7804 * Makefile.in: Remove more stuff in the clean target.
7805
8e1299fa
CF
7806Mon May 28 18:24:59 2001 Christopher Faylor <cgf@cygnus.com>
7807
7808 * Makefile.in: Correctly generate iniparse.h.
7809
85553593
CV
7810Tue Mar 6 19:14:00 2001 Corinna Vinschen <corinna@vinschen.de>
7811
7812 * geturl.cc (get_url_to_file): Add parameter `allow_ftp_auth'.
7813 * geturl.h: Change declaration of `get_url_to_file' accordingly.
7814 * netio.cc (NetIO::NetIO): Add parameter `allow_ftp_auth'.
7815 Set member `ftp_auth'.
7816 (NetIO::open): Add parameter `allow_ftp_auth'. Use it in calls
7817 to constructors of derived classes.
7818 (NetIO::get_ftp_auth): New method.
7819 * netio.h: Change class definition accordingly.
7820 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Add parameter `allow_ftp_auth'.
7821 Take global variables `net_ftp_user' and `net_ftp_passwd' into account.
7822 Add code for ftp authentication retry.
7823 * nio-ftp.h: Change class definition accordingly.
7824 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Add parameter `allow_ftp_auth'.
7825 Add code for ftp authentication retry in case of proxy connection.
7826 * nio-http.h: Change class definition accordingly.
7827 * res.rc: Add FTP authentication dialog.
7828 * resource.h: Add new constants used in res.rc.
7829 * state.h: Add variables `net_ftp_user' and `net_ftp_passwd'.
7830
c4174b9c
CF
7831Sun May 27 17:12:23 2001 Christopher Faylor <cgf@cygnus.com>
7832
7833 * res.rc (IDD_SPLASH): Add a copyright year.
7834
0af2d779
CF
7835Sun May 27 15:42:18 2001 Christopher Faylor <cgf@cygnus.com>
7836
7837 * Makefile.in: Make iniparse.y produce a c++ file.
7838 * choose.cc (set_existence): Revert 2001-05-27 change.
7839 * ini.cc: Remove "C" from declaration of yyparse.
7840 * iniparse.y (yyparse): Fill out version field by default when a binary
7841 install is detected and no version has been set yet.
7842 * install.cc (do_install): Mount things earlier so that we can use
7843 proper mount table settings. Don't remove mounts since they are now
7844 honored.
7845 * mount.cc (create_mount): Reread the mount table after establishing a
7846 new mount.
7847 (read_mounts): Explicitly clear root_here to allow multiple uses of
7848 this function. Ensure that there is no garbage in the table when we've
7849 exhausted all of the mounts in the registry.
7850 (cygpath): Accomodate ./ in path.
7851
85b43844
CF
7852Sun May 27 02:59:07 2001 Christopher Faylor <cgf@cygnus.com>
7853
0af2d779
CF
7854 Use parse_filename method to parse filenames throughout. Use
7855 get_root_dir to retrieve the current root directory throughout. Set
7856 const in argument list, where appropriate, throughout.
7857 * choose.cc (set_existence): Detect case of uninstalled package with no
7858 version.
85b43844
CF
7859 (parse_filename): New function.
7860 * filemanip.h (fileparse): New structure.
7861 * mount.cc (read_mounts): Remember where we found the root mount.
7862 (set_root_dir): New function.
7863 (get_root_dir): Ditto.
7864 * mount.h: Declare new functions.
7865 * site.cc (get_root_dir_now): Renamed from get_root_dir.
7866 (save_site_url): Use new function name.
7867 (get_initial_list_idx): Ditto.
7868
08f8c762
CF
7869Sat May 26 21:23:59 2001 Christopher Faylor <cgf@cygnus.com>
7870
7871 * choose.cc: Use a constant throughout to deal with chooser icon
7872 length.
7873 * res.rc (IDD_CHOOSE): Increase size of chooser box.
7874
47f8d8b3
CF
78752001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
7876
7877 * choose.cc (do_choose): Fix incorrect assignment of trust setting to
7878 use when Redownload or Sources Only selected.
7879
6a748750
CF
7880Thu May 10 22:35:59 2001 Christopher Faylor <cgf@cygnus.com>
7881
7882 Reformat file after botched patch formatting.
7883 * choose.cc (which_trust): Eliminate variable.
7884 (default_trust): Don't set which_trust.
7885 (do_choose): Use selected trust when reinstalling or installing source.
7886
a351e48c
CF
7887Thu May 10 21:04:18 2001 Christopher Faylor <cgf@cygnus.com>
7888
7889 Change concat to cygpath throughout.
7890 Change map_filename to cygpath throughout.
7891 * concat.cc (vconcat): New function.
7892 (concat): Use vconcat.
7893 * concat.h: Reflect above.
7894 * install.cc (map_filename): Eliminate.
7895 (install_one): Free dest_file.
7896 * mount.cc (find2): Expect input key to be pointing to mount record.
7897 (in_table): New function.
7898 (is_admin): Move from root.cc.
7899 (read_mounts): New function.
7900 (path_prefix_p): New function.
7901 (cygpath): New function.
7902 * mount.h: Define new functions and structure.
7903 * root.cc (in_table): Move to mount.cc.
7904 (do_root): Call read_mounts to initialize root stuff and mount table.
7905 * site.cc (get_root_dir): Ditto.
7906
e227ee24
CF
79072001-05-09 Matt Hargett <matt@use.net>
7908
7909 * Makefile.in: Remove *.rc from clean.
7910
25fd2965
CF
7911Tue May 8 23:33:38 2001 Christopher Faylor <cgf@cygnus.com>
7912
7913 * choose.cc (scan2): Fix incorrect setting of TRUST_CURR rather than
7914 TRUST_PREV which produced "0" versions.
7915
42bf5b92
CF
79162001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
7917
7918 * resource.h: Add new field IDC_CHOOSE_INST_TEXT. Modify
7919 _APS_NEXT_CONTROL_VALUE to account for addition of
7920 IDC_CHOOSE_INST_TEXT.
7921 * res.rc (IDD_CHOOSE): Modify choose dialog to use new field
7922 IDC_CHOOSE_INST_TEXT for screen text. Modify choose Dialog to allow
7923 hot keys to select Prev, Curr, Exp.
7924 * ini.h: Add new actions for ACTION_REDO and ACTION_SRC_ONLY. Modify
7925 define for LOOP_PACKAGES to include new actions ACTION_REDO and
7926 ACTION_SRC_ONLY.
7927 * choose.cc: Add new Trusts for TRUST_REDO and TRUST_SRC_ONLY.
7928 (paint): Modify to check TRUST_SRC_ONLY when determining Bitmap for
7929 source Checkbox to use.
7930 (build_labels): Add logic to allow for selection of Source only
7931 Download/ReDownload/Install/Reinstall and also to Redownload/Reinstall
7932 current version binary.
7933 (dialog_proc): Add conditional display for file selection prompt based
7934 on download vs install using IDC_CHOOSE_INST_TEXT.
7935 (do_choose): Add new logic for TRUST_REDO and TRUST_SRC_ONLY selection
7936 and modify logic for TRUST_UNINSTALL, TRUST_KEEP, and TRUST_NONE to
7937 handle the instance where Source Download/Install was selected. Modify
7938 log file to store appropriate information regarding Action selected and
7939 the new actions that were added (I.E.: ACTION_REDO and
7940 ACTION_SRC_ONLY).
7941 * download.cc: Add include for <unistd.h> and "port.h".
7942 (download_one): Modify parameter list to include the selected action
7943 for the file to be downloaded. Modify size check against expected size
7944 to include check for ACTION_REDO and ACTION_SRC_ONLY. Modify rename of
7945 .tmp file to also remove the destination file if exists due to ability
7946 to redownload source and binary now.
7947 (do_download): Modify to also use ACTION_REDO and ACTION_SRC_ONLY in
7948 calculation of Download Bytes. Modify to also use ACTION_REDO and
7949 ACTION_SRC_ONLY in determining files selected for download.
7950 * install.cc (uninstall_one): Add check to treat a Reinstall like an
7951 upgrade so current version will be uninstalled prior to reinstall.
7952 (do_install): Add logic to handle ACTION_REDO and ACTION_SRC_ONLY for
7953 uninstalling and installing binary and source packages.
7954 * desktop.cc (make_passwd_group): Modify logic to account for a Source
7955 only cygwin install when checking for cygwin to determine need for
7956 mkpasswd and mkgroup.
7957
7958Mon May 7 23:33:30 2001 Matt Hargett <matt@use.net>
8a09aa99
CF
7959
7960 * winsup/cinstall/res.rc: Added accelerators and improved focus order.
7961 Removed WS_DISABLED from "OK" buttons to accomodate default focus
7962 changes in net.cc and source.cc.
7963 * winsup/cinstall/net.cc (dialog_proc): If no radio button is selected,
7964 a default is selected.
7965 * winsup/cinstall/source.cc (dialog_proc): Ditto.
7966 (check_if_enable_next): Removed. No longer needed since a radio button
7967 will always be selected.
7968 (load_dialog): Removed call to check_if_enable_next.
7969 (dialog_cmd): Ditto. Also added default to switch.
7970
87bdba0c
CF
7971Tue Apr 24 23:42:02 2001 Christopher Faylor <cgf@cygnus.com>
7972
7973 * res.rc: Resize affected text.
7974
8293fc16
CF
7975Tue Apr 24 23:35:31 2001 Christopher Faylor <cgf@cygnus.com>
7976
7977 * net.cc (do_net): Default to direct download.
87bdba0c 7978 * res.rc: Move default selections to the top.
8293fc16 7979
ed96c6da
EB
79802001-04-18 Earnie Boyd <earnie@users.sourceforge.net>
7981
7982 * win32.h: Remove the definitions for _UNION_NAME and _STRUCT_NAME.
7983 Must now include <windows.h> and not the pieces.
7984 * choose.cc (create_listview): Clean up type mismatch problems.
7985 * dialog.h (NEXT(id)): Ditto.
7986 * geturl.cc (dialog): Ditto.
7987 * install.cc (dialog): Ditto.
7988 * splash.cc (load_dialog): Ditto.
7989
fe94cc29
CF
7990Wed Apr 18 18:59:21 2001 Christopher Faylor <cgf@cygnus.com>
7991
7992 * tar.cc (class gzbz): Define dummy virtual functions.
7993
fb087b80
CF
7994Wed Apr 18 16:01:21 2001 Christopher Faylor <cgf@cygnus.com>
7995
7996 * Makefile.in: Add bz2 include/library support.
7997 * filemanip.h: New file.
fe94cc29
CF
7998 * choose.cc (find_tar_ext): New function. Returns TRUE if .tar.gz or
7999 .tar.bz2 found.
fb087b80
CF
8000 (scan2): Reorganize to use find_tar_ext, accomodating .bz2 extension.
8001 (read_installed_db): Ditto.
8002 (do_choose): Ditto.
8003 * fromcwd.cc (found_file): Ditto.
8004 (do_fromcwd): Ditto.
8005 * tar.cc (class gzbz): New super class for uncompression support.
8006 (gz): New class for gzip support.
8007 (bz): New class for bzip2 support.
8008 (tar_open): Use gzbz class to control file opening.
8009 (tar_ftell): Ditto for returning position in file.
8010 (skip_file): Ditto for reading file.
8011 (tar_next_file): Ditto.
8012 (tar_read_file): Ditto.
8013 (tar_close): Ditto for close.
8014
8015 * zlib/configure.in: Force NM substitution.
8016
8017 * source.cc (do_source): Default to "Install from Internet".
8018
88bcaf07
CF
80192001-03-16 Brian Keener <bkeener@thesoftwaresource.com>
8020
8021 * nio-file.cc (NetIO_File::NetIO_File): Use `get_file_size' instead of
8022 `stat'.
8023 * choose.cc (list_click): Correct inability to select source code for
8024 download.
8025 (scan2): Modify to skip source tarballs when scanning disk for
8026 installable packages.
8027
ef45c299
CV
80282001-03-10 Chris Abbey <chris_abbey@yahoo.com>
8029
8030 * install.cc: install sources into /usr/src instead
8031 of /, also include the sizes of source tarballs
8032 in total_bytes.
8033 * download.cc: include sizes of source tarballs in
8034 total_download_bytes.
8035
9fe1181b
CV
8036Tue Mar 6 19:31:00 2000 Corinna Vinschen <corinna@vinschen.com>
8037
8038 * download.cc (get_file_size): Remove `static'.
8039
2bfdb848
CV
8040Tue Mar 6 19:11:00 2000 Corinna Vinschen <corinna@vinschen.com>
8041
8042 * tar.cc (tar_open): Use `get_file_size' instead of `stat'.
8043
60c632b3
CV
80442001-03-06 Brian Keener <bkeener@thesoftwaresource.com>
8045
8046 * choose.cc (paint): Modify message for nothing to download vs
8047 nothing to install/update based on installation method.
8048 (list_click): Modify to skip versions in selection process if
88bcaf07 8049 installing from local directory and installation file does not exist.
60c632b3
CV
8050 Also leaves Source Action set to N/A if the source file does not exist
8051 and installing from local directory.
8052 (check_existence): New method to check current existence of installation
8053 files based on selected installation method.
8054 (set_existence): New method to set the current existence of installation
8055 files based on selected installation method.
8056 (best_trust): Modify decision process for best trust to base decision on
8057 current trust selected (IE: Prev, Curr, or Test), existence of file and
8058 installation method selected.
8059 (default_trust): Add logic to capture the current trust level and the
8060 trust selected for the given package.
88bcaf07 8061 (set_full_list): Expand decision criteria for displaying a package in
60c632b3
CV
8062 the selection list to include file existence/non-existence and selected
8063 installation method.
8064 (build_labels): Modify criteria for label addition to include
8065 installation method and file existence/non-existence.
88bcaf07 8066 (create_listview): Modify to establish package trust level for each
60c632b3
CV
8067 package before setting up the display list. Also modification to set
8068 current trust button as the default.
88bcaf07 8069 (dialog_cmd): Set response for Prev, Curr, Test button push to perform
60c632b3
CV
8070 a reset of the selection list in addition to setting the default trust.
8071 (get_package_version): New method to provide reusable code for
8072 determining the package version from the file name for a specified
8073 trust.
8074 (scan2): Modify to use new method get_package_version and
8075 also enhance handling of the build for the structures package and
8076 extra.
8077 (read_installed_db): Modify to use the new method
8078 get_package_version and also enhance handling of the build for the
8079 structures package and extra.
88bcaf07 8080 (do_choose): Add additional initialization of package and extra
60c632b3
CV
8081 structures. Modify to use read_installed_db all the time despite
8082 install method. Modify output to setup.log.full log file to increase
8083 readability by adding additional spacing, expanded code and available
8084 versions.
8085 * ini.h: Add new fields install_exists, source_exists and
88bcaf07 8086 partial_list_display to the structure definition for package.
60c632b3
CV
8087 * res.rc (IDD_CHOOSE): Modify choose dialog Prev, Curr, and Test
8088 pushbuttons by replacing with Radio Buttons thus allowing the
8089 operator to better determine which is selected.
8090
2f9645a1
CV
80912001-02-20 Brian Keener <bkeener@thesoftwaresource.com>
8092
88bcaf07 8093 * download.cc (do_download): Add new variables total_download_bytes and
2f9645a1
CV
8094 total_download_bytes_sofar for download progress meter. Add loop
8095 to accumulate the total bytes to download from the selected packages.
8096 * geturl.cc: Add state.h and diskfull.h to include list. Add new
8097 variables gw_iprogress, gw_pprogress, gw_progress_text,
8098 gw_pprogress_text, and gw_iprogress_text to allow for addition of
8099 total packages download progress meter and disk full percent
8100 progress meter. Add variables total_download_bytes and
8101 total_download_bytes_sofar for use by progress meters.
88bcaf07
CF
8102 (dialog_proc): Add new variables gw_iprogress, gw_pprogress,
8103 gw_progress_text, gw_pprogress_text, and gw_iprogress_text to
8104 allow for addition of total packages download progress meter and disk
8105 full percent progress meter.
2f9645a1
CV
8106 (init_dialog): Ditto.
8107 (progress): Ditto.
8108 (get_url_to_file): Ditto.
8109 * geturl.h: Add external definition for total_download_bytes and
8110 total_download_bytes_sofar.
88bcaf07 8111 * res.rc: Add two additional progress meters (IDC_DLS_IPROGRESS)
2f9645a1
CV
8112 and (IDC_DLS_PPROGRESS) and three text objects (IDC_DLS_PROGRESS_TEXT)
8113 and (IDC_DLS_IPROGRESS_TEXT, IDC_DLS_PPROGRESS_TEXT) for use in the
8114 download meters.
88bcaf07 8115 * resource.h: Add new fields for progress meters and text and update
2f9645a1
CV
8116 _APS_NEXT_CONTROL_VALUE.
8117
b41962a3
CV
8118Wed Feb 21 13:05:00 2000 Corinna Vinschen <vinschen@redhat.com>
8119
8120 * download.cc (get_file_size): Check for INVALID_HANDLE_VALUE instead
8121 for NULL.
8122
8123Wed Feb 21 11:21:00 2000 Corinna Vinschen <vinschen@redhat.com>
01954c34
CV
8124
8125 * download.cc (download_one): Add missing parenthesis.
8126
88a77116
CV
8127Mon Feb 19 18:59:00 2000 Corinna Vinschen <vinschen@redhat.com>
8128
8129 * download.cc (get_file_size): New function. Eliminates the need
8130 to call `stat'.
8131 (download_one): Call `get_file_size' instead of `stat'. This
8132 workarounds a problem with mingw's `stat' call.
8133
577f35ed
EB
81342001-02-07 Earnie Boyd <earnie@users.sourceforge.net>
8135
8136 * Makefile.in: (%.o: %.rc): Specify --include-dir $(w32api_include).
8137 This is to allow cinstall to build with 2.95.2-7 and to make the
8138 use of headers consistent.
8139
38f5563e
DD
81402000-12-26 Earnie Boyd <earnie_boyd@yahoo.com>
8141
8142 * Makefile.in (autoload.o): Add target to specify -fno-inline-functions
8143
c0a7e0f2
DD
8144Tue Dec 26 03:46:00 2000 Matt Hargett <matt@use.net>
8145
8146 * winsup/cinstall/res.rc: Added accelerators and improved focus
8147 order.
8148
72826a5b
CF
81492000-12-10 Egor Duda <deo@logos-m.ru>
8150
8151 * choose.cc (paint): Use system background color for text output.
8152
8153Sun Dec 10 19:05:25 2000 Christopher Faylor <cgf@cygnus.com>
8154
8155 * Makefile.in: Use CXX for linking and for compiling .cc files.
8156 * configure.in: Find correct c++ compiler.
8157 * configure: Regenerate.
8158
67bebcb5
DD
81592000-11-17 DJ Delorie <dj@redhat.com>
8160
8161 * splash.cc (load_dialog): Make message more obvious.
8162 * res.rc: Ditto.
8163
25fb9139
CF
8164Fri Nov 17 17:15:21 2000 Christopher Faylor <cgf@cygnus.com>
8165
8166 * Makefile.in: Use g++ to link so that libstdc++.a gets used. This is
8167 necessary for newer compilers.
8168
ef2007fd
CV
8169Wed Nov 9 2:19:00 2000 Corinna Vinschen <vinschen@redhat.com>
8170
8171 * desktop.cc: Include "ini.h" and "version.h".
8172 (make_passwd_group): Skip the function on 9x/ME boxes when an
8173 older version of Cygwin has been installed which doesn't
8174 support mkpasswd/mkgroup on 9x/ME.
8175 * install.cc: Move the `LOOP_PACKAGES' and `pi' macros to...
8176 * ini.h: ...here.
8177
277b4d56
CV
8178Wed Nov 8 17:10:00 2000 Corinna Vinschen <vinschen@redhat.com>
8179
8180 * desktop.cc (make_passwd_group): Don't exit when started
8181 on 9x/ME since mkpasswd/mkgroup are usable on 9x/ME now.
8182
f8a6415f
DD
8183Sun Nov 5 12:51:42 2000 Jason Tishler <jt@dothill.com>
8184
8185 * install.cc (do_install): Add call to set_cygdrive_flags to sync
8186 the mount modes.
8187 * mount.cc (set_cygdrive_flags): New function.
8188 (get_cygdrive_flags): Ditto.
8189 (default_cygdrive): Ditto.
8190 (set_cygdrive_flags): Ditto.
8191 * mount.h: Add prototype for set_cygdrive_flags.
8192
3b9077d4
DD
81932000-10-23 DJ Delorie <dj@redhat.com>
8194
8195 * ini.h: add source actions
8196 * fromcwd.cc: check for available sources
8197 * res.rc: add checkbox bitmaps
8198 * resource.h: ditto
8199 * check-*.bmp: new
8200 * choose.cc: add source column
8201 * download.cc: download sources if called for
8202 * install.cc: [un]install sources too
8203
1b1b33ac
DD
82042000-10-22 DJ Delorie <dj@redhat.com>
8205
8206 * choose.cc (build_labels): Don't skip TRUST_PREV completely; only
8207 ignore it wrt full_list if there's already a version installed.
8208 (do_choose): Sort the list.
8209 (package_sort): New.
8210
2a1a01e0
DD
82112000-10-12 DJ Delorie <dj@redhat.com>
8212
8213 * res.rc: Add more error strings.
8214 * resource.h: Ditto.
8215 * iniparse.y (new_package): re-initialize if needed.
8216 * download.cc (do_download): Keep track of errors; notify and
8217 allow retry.
8218 * install.cc (do_install): Ditto.
8219
1a9886fe
DD
82202000-10-05 DJ Delorie <dj@redhat.com>
8221
8222 * Makefile.in: fix %.cc rule
8223
40aef45e
DD
82242000-10-04 DJ Delorie <dj@redhat.com>
8225
8226 * desktop.cc: quote HOME and USER, don't . ./.profile
8227
8228 * choose.cc (build_labels): don't include in partial list just
8229 because there's a *previous* version available.
8230
8231 * install.cc (do_install): if installing from local directory with
8232 setup.ini and the file isn't found, look in "." also. Note errors.
8233
dd3f7f9b
DD
82342000-10-02 DJ Delorie <dj@redhat.com>
8235
8236 * ini.cc (do_ini): save setup.ini locally
8237
82382000-10-02 Chris Abbey <cabbey@bresnanlink.net>
8239
8240 * desktop.cc: quote escapes in prompt
8241
fee2a8d0
DD
82422000-10-02 Jason Tishler <jt@dothill.com>
8243
8244 * root.cc (is_admin): New function.
8245 (read_mount_table): Check for administrative priviledges and set
8246 installation scope as appropriate.
8247
a03db251
DD
82482000-09-28 DJ Delorie <dj@redhat.com>
8249
8250 * nio-ftp.cc (ftp_line): handle continuations more robustly
8251
b151e01e 82522000-09-14 Brian Keener <bkeener@thesoftwaresource.com>
0b758d4c
DD
8253
8254 * res.rc: increased the size of the site dialog (IDD_SITE) & the
8255 corresponding list box to provide for more URL's to be listed.
8256 Modified the position of the Back, Next and Cancel buttons to
8257 correspond to the new size of the dialog.
8258
d07591a3
DD
82592000-09-13 DJ Delorie <dj@redhat.com>
8260
8261 * install.cc (do_install): update disk fullness once per package
8262 to improve performance
8263
8264 * choose.cc (create_listview): call ReleaseDC
8265
89725f30
DD
8266Mon Sep 11 22:40 2000 Harold L Hunt II <harold@compasstechnologies.com>
8267
8268 * mkdir.cc: Create directories when ERROR_FILE_NOT_FOUND is
8269 returned, as it seems Samba 2.0.6+ returns this instead of
8270 ERROR_PATH_NOT_FOUND
88bcaf07 8271
6fbc690d
CF
8272Mon Sep 11 19:35:24 2000 Christopher Faylor <cgf@cygnus.com>
8273
8274 * site.cc (get_initial_list_idx): Don't default to saved URL if it
8275 refers to sources.
8276
13d27274
DD
82772000-09-07 DJ Delorie <dj@redhat.com>
8278
8279 * splash.cc: use version.h, not local decl
8280 * res.rc: add "old version" message
8281 * resource.h: ditto
8282 * version.h: new
8283 * fromcwd.cc (canonicalize_version): make global
89725f30
DD
8284 * iniparse.y: add setup-version support, fix bug in blank line
8285 handling
8286
13d27274
DD
8287 * inilex.l: add [exp] as alias for [test], add setup-version
8288 * Makefile.in (version.c): add setup-version tag
8289
8290 * desktop.cc (do_desktop): remove 1.1 version number
8291 (do_desktop_setup): ditto
8292
8293 * ini.cc (do_ini): zero out package list just in case we redo it.
8294
8cfbc487
DD
82952000-09-07 Jeffrey Juliano <juliano@cs.unc.edu>
8296
8297 * choose.cc (list_click): Check for nindexes==0; if so, return.
8298
c92e1307
DD
82992000-09-06 Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru>
8300
8301 * localdir.cc: new, local package directory selection dialog; cd
8302 into selected directory
8303 * Makefile.in (OBJS): add localdir.o
8304 * dialog.h: add prototype for do_local_dir
8305 * main.cc (WinMain): initialize local_dir to cwd; add call to
8306 do_local_dir
8307 * net.cc (dialog_cmd): make DO_LOCAL_DIR next dialog
8308 * source.cc (dialog_cmd): ditto
8309 * res.rc: add DO_LOCAL_DIR dialog; remove "current directory" from
8310 presented choices in IDD_SOURCE; add IDS_ERR_CHDIR error string
8311 * resource.h: defines for DO_LOCAL_DIR dialog; define IDS_ERR_CHDIR
8312 * root.cc (dialog_cmd): make DO_LOCAL_DIR previous dialog
8313 * state.h: add local_dir variable
8314
83152000-09-06 Brian Keener <bkeener@thesoftwaresource.com>
50225eae
DD
8316
8317 * desktop.cc: added logic to handle to the new dialog and to
8318 default the setting for the new checkboxes based on whether the
8319 desktop icon or start menu link already exist.
8320 (desktop_icon): correction to desktop directories for desktop icon
8321 creation. Additional logic added for Win95 which does not appear
8322 to have Common Directories so if Common selected and null uses
8323 normal directory.
8324 (start_menu): Additional logic added for Win95 which does not
8325 appear to have Common Directories so if Common selected and null
8326 uses normal directory.
8327 (do_desktop_setup): moved the saving of the icon, creation of the
8328 bat file, profile, passwd, Start Menu link and desktop shortcut to
8329 this method from do_desktop. Made the creation of the desktop
8330 icon and start menu link conditional on settings of new dialog
8331 created for desktop.
8332 * install.cc (do_install): changed next from IDD_S_DESKTOP to
8333 IDD_DESKTOP.
8334 * main.cc (WinMain): changed case IDD_S_DESKTOP to IDD_DESKTOP.
8335 * res.rc: added new resource to create a desktop dialog with 2
8336 checkboxes for creating the desktop icon and start menu link.
8337 * resource.h: changed IDD_S_DESKTOP to IDD_DESKTOP and added two
8338 new controls: IDC_ROOT_MENU and IDC_ROOT_DESKTOP for new dialog.
8339 * state.h: added root_menu and root_desktop for use in dialog.
8340
4a83b7b0
DD
83412000-08-29 DJ Delorie <dj@redhat.com>
8342
8343 * choose.cc (scan_downloaded_files): scan for existing files, so
8344 that the user only sees new downloads.
8345
8346 * nio-ie5.cc (NetIO_IE5): pre-check for wininet.dll, enable dial-up
8347 * site.cc (do_site): if we can't download the mirror list, go back
8348 to the net setup box to choose another transport.
8349 * autoload.c: add more functions
8350 * Makefile.in (ALL_DEP_LDLIBS): remove wininet.a
8351 * resource.h: add WININET message
8352
8353 * net.cc (do_net): no longer default to IE5
8354 * simpsock.h (class SimpleSocket): new, simplify socket operations
8355 * simpsock.cc: ditto
8356 * nio-http.h: new, for direct http protocol
8357 * nio-http.cc: ditto
8358 * nio-ftp.h: new, for direct http protocol
8359 * nio-ftp.cc: ditto
8360 * netio.cc (set_url): move initialization here to handle redirections
8361 (open): add direct http/ftp
8362 * netio.h (NetIO::set_url): new
8363
8364 * log.cc (log_save): create directory for log if needed
8365
8366 * hash.cc, hash.h: new
8367 * Makefile: add hash.o
8368 * choose.cc: enable "uninstall" option
8369 * download.cc: invert action test to accomodate uninstalling
8370 * ini.h: add ACTION_UNINSTALL
8371 * install.cc: add uninstall functionality
8372 * res.rc: make install tag changeable
8373 * resource.h: add uninstall resources
8374
8375 * res.rc: update mirror list URL
88bcaf07 8376
50f64a4b
DD
83772000-08-24 DJ Delorie <dj@redhat.com>
8378
89b1a15b
DD
8379 * log.cc, log.h: new files
8380 * Makefile.in (OBJS): add log.o
8381 * tar.cc: use exit_setup instead of exit
8382 * dialog.cc (fatal): use exit_setup instead of ExitProcess
8383 * msg.cc (fatal): ditto
8384 * install.cc (dialog_cmd): ditto
8385 * ini.cc (do_ini): ditto
8386 * main.cc (main): add logging
8387 * source.cc (do_source): ditto
8388 * root.cc (do_source): ditto
8389 * site.cc (do_site): ditto
8390 * other.cc (do_other): ditto
8391 * net.cc (do_net): ditto
8392 * choose.cc (do_choose): ditto
8393 * download.cc (do_download): ditto
8394 * install.cc (do_install): ditto
8395 * msg.cc (fatal): ditto
8396
8397 * res.rc: mark password boxes as *being* password boxes.
8398
58b12a06
MB
8399 * fromcwd.cc (canonicalize_version): use multiple buffers so that
8400 multiple calls won't use the same buffer.
50f64a4b
DD
8401 * choose.cc (create_listview): don't default to full list if no changes
8402 (base): return computed value, not temporary :-(
8403 (do_choose): don't use installed.db if we're only downloading.
8404
348860fa
DD
84052000-08-23 DJ Delorie <dj@redhat.com>
8406
8407 * nio-ie5.cc (NetIO_IE5): Fix authentication logic
8408 * nio-ie5.h (flush_io): new
8409 * netio.cc (load_dialog): note when we're initializing the dialog
8410 box, and ignore changes to the edit fields then.
8411
5f48f258
DD
84122000-08-21 DJ Delorie <dj@redhat.com>
8413
8414 * README: Update
8415
8416 * fromcwd.cc (found_file): don't remember the canonicalized version
8417
8418 * choose.cc (paint): print "nothing to do" message when list is empty.
8419 (build_labels): Use version "0.0" if no version is available.
8420 (create_listview): default to full list if nothing to install/update.
8421 (base): new, returns basename of file
8422 (read_installed_db): compare base names, not full paths
8423
713bbe5f
DD
84242000-08-11 DJ Delorie <dj@redhat.com>
8425
8426 * choose.cc: add new chooser dialog
8427 * fromcwd.cc: use IDD_CHOOSE
8428 * ini.cc: use IDD_CHOOSE
8429 * main.cc: use IDD_CHOOSE
8430 * ini.h: cosmetic changes
8431 * res.rc: add choose dialog, bitmaps
8432 * choose-spin.bmp: new
8433 * choose-rtarrow.bmp: new
8434 * resource.h: add choose dialog controls
8435
8436 * mount.cc: remove debug statement
88bcaf07 8437
2e9cbac5
DD
84382000-08-08 DJ Delorie <dj@redhat.com>
8439
8440 * Makefile.in (version.c): make version checking more robust
8441 * splash.cc (load_dialog): handle case where there's no version
8442
8507f105
DD
84432000-08-07 DJ Delorie <dj@redhat.com>
8444
8445 * (all): add cvsid tags
8446 * Makefile.in: generate version.c from ChangeLog, add splash.o
8447 * splash.o: new
8448 * res.rc: add splash screen
88bcaf07 8449
f5d0464b
DD
84502000-08-02 DJ Delorie <dj@redhat.com>
8451
4e8ff53f
DD
8452 * net.cc: remove proxy password code
8453 * res.rc: remove proxy user/pass from net, add auth dialogs
8454 * netio.cc,h: add sys/proxy auth methods
8455 * nio-ie5: use them, check for http status codes
8456 * state.h: add system authorization
8457
f5d0464b
DD
8458 * concat.cc (concat): canonicalize x:// to x:/ (exception to ://
8459 meaning an url)
8460
76cbfa85
DD
84612000-08-02 Norman Vine <nhv@yahoo,com>
8462
8463 * msg.cc (mbox): added MB_TOPMOST to MessageBox type flags
8464
e92c4436
DD
84652000-08-01 DJ Delorie <dj@redhat.com>
8466
bf74c544
DD
8467 * postinstall.cc (each): don't rename files we ignore
8468 (do_postinstall): set CYGWINROOT to root_dir, chdir there
8469
e92c4436
DD
8470 * desktop.cc: have /etc/profile call ~/.profile and ~/.bashrc
8471
a6100861
DD
84722000-07-31 DJ Delorie <dj@redhat.com>
8473
8474 * desktop.cc: reverse PATH so /usr/bin precedes /bin
8475
b11b49f3
DD
84762000-07-18 DJ Delorie <dj@redhat.com>
8477
a99bdfd8
DD
8478 * autoload.c: new, autoload dlls that might not be available.
8479 * Makefile.in (OBJS): add autoload.o
8480
8481 * res.rc: rewrite root options (text/binary, system/user) to be
8482 more obvious.
8483
b5b282c4
DD
8484 * site.cc (get_site_list): trim displayed URL, sort by domain
8485
8486 * net.cc (do_net): make IE5 default to checked, for now
8487
b11b49f3
DD
8488 * choose.cc (do_choose): sort packages correctly
8489 * ini.cc (do_ini): handle parse errors more gracefully
8490 (yyerror): ditto
8491 (fprintf): line buffer output
b5b282c4 8492 (do_ini): if we can't load setup.ini, go back to the site list.
b11b49f3
DD
8493 * ini.h: add "unknown" trust level
8494 * inilex.l: absorb unknown trust levels and key/value pairs,
8495 add line number logic
8496 * iniparse.y: handle parse errors more gracefully.
8497 * install.cc: skip packages with no valid install entry
8498
1fd6d0a2
DD
84992000-07-17 DJ Delorie <dj@cygnus.com>
8500
8501 * coding standards fixups, many files
8502 * mkdir.cc: warn about deletions *before* deleting them
8503
ed3e8b9b
DD
85042000-07-17 Jeff Juliano <juliano@cs.unc.edu>
8505
8506 * res.rc (IDD_OTHER_URL): reorder to give default focus to entry
8507
8508 * other.cc (dialog_cmd): save download site URL
8509 * site.cc (get_root_dir): new
8510 (save_mirror_site): new
8511 (dialog_cmd): save download site URL
8512 (get_site_list): make list big enough to add prev site
8513 (get_initial_list_idx): new, read last-used URL from file and
8514 append it to site_list
8515 (do_site): call get_initial_list_idx
8516
8517 * concat.cc (concat): avoid segfault when first parm is null
88bcaf07 8518
f57c332f
DD
85192000-07-13 DJ Delorie <dj@cygnus.com>
8520
8521 * postinstall.cc: new
8522 * Makefile.in: add postinstall.o
8523 * concat.h: add backslash ()
8524 * concat.cc: ditto
8525 * desktop.cc (etc_profile): don't do postinstall
8526 (backslash): moved to concat.cc
8527 (uexists): new
8528 (make_postinstall_script): run directly
8529 (do_desktop): chain to do_postinstall
8530 * dialog.h: add exit_msg, do_postinstall
8531 * download.cc: use exit_msg
8532 * install.cc: ditto
8533 * main.cc: add postinstall, exit_msg
8534 * resource.h: add postinstall
d6cda811 8535 * README: add more to-do items
f57c332f 8536
3a8e3956
DD
85372000-07-12 DJ Delorie <dj@cygnus.com>
8538
8539 * desktop.cc: add /etc/postinstall/ support
1a18aed7 8540 * install.cc: add more "standard" directories
3a8e3956 8541
e0c3d906
DD
85422000-07-11 DJ Delorie <dj@cygnus.com>
8543
8544 * desktop.cc: create /etc/profile
ad09bcd9
DD
8545 * desktop.cc: fix include syntax
8546 * Makefile.in: add auto-dependencies
24e259bb
DD
8547 * root.cc: support system vs user
8548 * desktop.cc: ditto
8549 * mount.h: ditto
8550 * mount.cc: ditto
8551 * install.cc: ditto
8552 * res.rc: ditto
8553 * resource.h: ditto
8554 * state.h: ditto
84d58d4c 8555 * desktop.cc: make sure we use backslashes, not slashes.
bf1d5889
DD
8556 * desktop.cc: don't set PATH in cygwin.bat, create /etc/passwd
8557 * geturl.cc: change math for percentage to avoid overflow
8558 * install.cc: ditto
8559 * download.cc: post "download complete" message.
8560 * root.cc: pre-fill in defaults if needed, don't start
8561 browse at root_dir unless it's set.
a3f48e18 8562 * desktop.cc: quote $PATH in case it has spaces in it
88bcaf07 8563
904d24fe
DD
85642000-07-10 DJ Delorie <dj@cygnus.com>
8565
8566 * Makefile.in: add desktop.o and mklink2.o
8567 * dialog.h: add do_desktop
8568 * install.cc: create standard directories, call do_desktop
8569 * res.rc: add cygwin.ico as a file also
8570 * desktop.cc: new, do shortcuts, batch files, and icons
8571 * mklink2.c: new, for COM
1ab805b8 8572 * README: update to-do list
904d24fe 8573
04d6e06b
DD
85742000-07-10 DJ Delorie <dj@cygnus.com>
8575
8576 * ini.cc (do_ini): don't worry about timestamps if we're not
88bcaf07 8577 actually installing.
04d6e06b 8578
5601a13d
DD
85792000-07-09 DJ Delorie <dj@cygnus.com>
8580
8581 * Makefile.in: add -I$(srcdir) for ini.h
8582
23c9e63c
DD
85832000-07-06 DJ Delorie <dj@cygnus.com>
8584
8585 * Replace everything with a new GUI version
8586 * zlib/gzio.c: add gzctell() for progress displays
8587
85882000-06-22 DJ Delorie <dj@cygnus.com>
8589
8590 * setup.c (tarx): re-add call to write_pkg()
8591
aa32874b
DD
85922000-06-07 DJ Delorie <dj@cygnus.com>
8593
8594 * cygcalls.c: new, call cygwin1.dll functions directly
8595 * cygcalls.h: header for same
8596 * Makefile.in: add cygcalls.[ch], remove mount/cygpath/umount
8597 exes, fix cinstall.rc dependencies.
8598 * path.c: remove unneeded code
8599 * setup.c: use cygcalls instead of xcreate_process.
8600 uncompress embedded files with zlib
8601 add "-d" for "download only"
8602 add "-h" for help
8603 postpone mount changes until very end
8604 add download progress indicators
8605 pack multi-column listings more
8606 auto-delete temp files
8607 customize banner message according to options
8608 prompt user for text/binary mounts
8609 add warnings about empty setup directory, root installs, etc
8610
99d1bf2d
DD
86112000-05-24 DJ Delorie <dj@cygnus.com>
8612
8613 * tar.c: New file; built-in tar using zlib.
8614 * tar.h: New file; header for same.
8615 * ctar.c: New file; test program for same.
8616 * Makefile.in: add built-in tar, remove tar.exe and gzip.exe
58b12a06
MB
8617 * path.c (pathcat): convert slashes and canonicalize, instead of
8618 aborting
99d1bf2d
DD
8619 * setup.c (tarx): add support for built-in tar
8620 (main): accept unix-style slashes, check root dir for drive letters,
58b12a06
MB
8621 warn about installing in /, make sure cwd is empty for internet
8622 installs, defer mounts to end of install, support built-in tar.
99d1bf2d 8623
55650749
CF
8624Fri May 19 23:44:37 2000 Christopher Faylor <cgf@cygnus.com>
8625
8626 Fix compiler warnings throughout.
8627 * pkg.c (init_pkgs): Make static 'stuff' global_pkgstuff for use in
8628 get_pkg_stuff.
8629 * setup.c: Make 'root' global.
8630 (istargz): Return pointer to "stem" of matched .tar.gz file.
8631 (tarx): Special case cygwin-20000301 to == cygwin-1.1.0.tar.gz. Remove
8632 bogus check_for_installed check.
8633 (recurse_dirs): Add preliminary support for .bat file execution.
8634 (create_uninstall): Eliminate unneeded parameter.
8635 (do_start_menu): Ditto.
8636 (mkmount): Ditto.
8637 (get_pkg_stuff): Ditto. Check for currently installed cygwin by
8638 scanning for the version number. Eliminate unneeded argument to
8639 create_uninstall.
8640 (getdownloadsource): Add 'name' to list of names rather than url.
8641 (main): Eliminate unneeded argument in get_pkg_stuff. Eliminate
8642 unneeded argument in mkmount and do_start_menu.
8643
f4dda8f0
DD
86442000-05-18 DJ Delorie <dj@cygnus.com>
8645
8646 * setup.c (optionprompt): allow multi-column, clean up message
8647 about more options, be more robust about user input.
8648 (getdownloadsource): make the mirror URL a macro.
8649 (main): do mounts after done prompting user.
8650
62844d84
CF
8651Tue May 2 00:56:41 2000 Christopher Faylor <cgf@cygnus.com>
8652
8653 * setup.c (cleanup): Inverse order of deletion stands a better chance
8654 of deleting cygpath.exe. Still seems to suffer from occasional races,
8655 though.
8656 (cleanup_on_signal): Perform convoluted dance to accomodate win95 and
8657 w2k.
8658 (output_file): Defend against an unlikely handle leak.
8659 (main): Don't set up signal handling until we have something special to
8660 do.
8661
ad6749c8
CF
8662Mon May 1 17:56:32 2000 Christopher Faylor <cgf@cygnus.com>
8663
8664 * path.c (kill_cygpath): Delete function.
8665 (exit_cygpath): Make more defensive so that it can be called at any
8666 time.
8667 (cygpath_pipe): Don't set up signal here. Do it in main().
8668 * setup.c (istargz): New function.
8669 (recurse_dirs): Look for *.gz pattern rather than *tar.gz since *tar.gz
8670 inexplicably fails on samba mounted partitions. Use istargz to match
8671 tar.gz tail.
8672 (processdirlisting) Use istargz to match tar.gz tail.
8673 (cleanup): Renamed from filedel.
8674 (cleanup_on_signal): New function. Called on CTRL-C.
8675 (main): Record handle of main thread so that it can be suspended when
8676 CTRL-C occurs. Set up cleanup_on_signal signal handler.
8677
460cf7b6
CF
8678Mon May 1 11:05:07 2000 Christopher Faylor <cgf@cygnus.com>
8679
8680 * setup.c (do_start_menu): Don't concatenate paths to already built
8681 paths.
8682
9e76799c
CF
8683Sun Apr 30 22:37:34 2000 Christopher Faylor <cgf@cygnus.com>
8684
8685 * path.c (exit_cygpath): Wait for subprocess to exit before returning.
8686 (cygpath_pipe): Don't call exit_cygpath. Let main atexit routine do
8687 that.
8688 * pkg.c (init_pkgs): Accept root argument. Make registry key "cygwin
8689 root"-specific.
8690 * setup.c (filedel): Call exit_cygpath here so that we can be assured
8691 that cygpath subprocess has died. This allows us to delete cygpath.exe
8692 and cygwin1.dll.
8693 (optionprompt): Initialize response to -1 so that second screen of
8694 mirrors will appear.
8695 (get_pkg_stuff): Don't attempt to use HKCLU. Pass root to init_pkgs.
8696 * setup.h: Reflect init_pkgs prototype change.
8697
2cf65e6e
CF
8698Sat Apr 29 23:53:30 2000 Christopher Faylor <cgf@cygnus.com>
8699
8700 * pkg.c (init_pkgs): Accept an argument to control what root registry
8701 key should be used.
8702 * setup.c (get_pkg_stuff): Use HKCLU registry key if default fails.
8703 * setup.h: Reflect init_pkgs prototype change.
8704
8705Sat Apr 29 23:27:14 2000 Christopher Faylor <cgf@cygnus.com>
8706
8707 * error.c (winerror): Respond to gcc warning.
8708 * path.c (cygpath_pipe): Ditto.
8709 * setup.c (filedel): Call sa_cleanup on deleteme.
8710 (create_shortcut): Coerce argument to eliminate compiler warning.
8711 (tarx): Use installed version of cygwin1.dll, overriding tar file name.
8712 (refmatches): New function. Tests if ref is contained in a list of
8713 packages to install.
8714 (filematches): New function. Tests if filename matches one of a list
8715 of packages to install.
8716 (recurse_dirs): Accept list of packages to install. Generalize tar.gz
8717 test to accomodate _tar.gz.
8718 (prompt): Ensure that stdout is flushed prior to asking for input.
8719 (findhref): Initialize variables to quiet a compiler warning.
8720 (processdirlisting): Accept list of packages to install. Special case
8721 cygwin tar file version number.
8722 (downloaddir): Accept list of packages to install.
8723 (downloadfrom): Ditto.
8724 (create_uninstall): Eliminate unneeded variables. Quote arguments to
8725 regtool.
8726 (do_start_menu): Don't create uninstall bat file if updating or user
8727 specified a list of packages.
8728 (mkmount): Eliminate unneeded variables.
8729 (get_pkg_stuff): New function. Checks for previous unversioned
8730 installation.
8731 (main): Accept -u and -f options and package names on the command line.
8732 Use get_pkg_stuff to initialize package information. Umount /etc.
8733 Call recurse_dirs and downloadfrom with list of package to install.
8734 Ensure that all /usr/local directories are created. Output
8735 installation time to setup.log.
8736 * setup.h: Add some prototypes.
8737 * xsystem.c (xcreate_process): Eliminate unneeded variable.
8738
4cf88dd9
CF
8739Sat Apr 29 12:43:08 2000 Christopher Faylor <cgf@cygnus.com>
8740
8741 * setup.c (optionprompt): Don't overlap display of already seen options
8742 on next page.
8743 (geturl): Print name of site which we're connecting to rather than "ftp
8744 site".
8745 (processdirlisting): Avoid URLs that contain a /. or ./ . Is this
8746 test too simplistic?
8747 (do_start_menu): Use pathcat to build path to <root>\bin to avoid
8748 problems when user chooses x:\ as their root.
8749 (main): For now, default to "non-update" mode. Allow -u option to
8750 signify an update.
8751
36591a07
CF
8752Sat Apr 29 00:26:06 2000 Christopher Faylor <cgf@cygnus.com>
8753
8754 * pkg.c: New file.
8755 * setup.c (tarx): Skip already installed or older packages. Report
8756 when a package has been updated.
8757 (processdirlisting): Skip already installed or older packages.
8758 (main): Detect -f option for forced installation. Initialize pkg stuff
8759 if appropriate.
8760 * setup.h: Add pkg definitions.
8761
c298ea4a
CF
8762Thu Apr 27 14:21:30 2000 Christopher Faylor <cgf@cygnus.com>
8763
8764 * setup.c (findhref): Return NULL on empty string. Eat any trailing
8765 ";something".
8766 (processdirlisting): Attempt to limit recursively processing the same
8767 directory.
8768
f4cafa7e
CF
8769Thu Apr 27 11:42:23 2000 Christopher Faylor <cgf@cygnus.com>
8770
8771 * setup.c (filedel): New function.
8772 (output_file): Keep track of files extracted from setup.exe for
8773 subsequent deletion.
8774 (tarx): Close process handle of child tar process or suffer handle
8775 leak.
8776 (getdownloadsource): Close mirror file so that it can be unlinked.
8777 (processdirlisting): Return total number of files extracted.
8778 (main): Initialize array of files to delete. Ensure that files are
8779 closed on exit. Make the directory that setup.exe is started from ==
8780 the directory where temporary files are placed. Issue an error if no
8781 files were found to download.
8782 * xsystem.c (xcreate_process): Close the thread handle. Close the
8783 process handle if we waited for it to exit.
8784
cd475210
CF
8785Thu Apr 27 09:54:19 2000 Christopher Faylor <cgf@cygnus.com>
8786
8787 * setup.c (main): Change version number output.
8788
7dff5e71
CF
8789Thu Apr 27 09:23:17 2000 Christopher Faylor <cgf@cygnus.com>
8790
8791 * setup.c (tarx): Use full path name to tar executable.
8792 (main): Build full pathname to tar executable. Create /usr/local/etc
8793 by default.
8794
99437fdb
CF
8795Wed Apr 26 22:16:57 2000 Christopher Faylor <cgf@cygnus.com>
8796
8797 * setup.c (findhref): Change method for scanning for href= to choose
8798 the last one on the line. This is still not foolproof and probably
8799 will need to be changed eventually. Don't abort if no "size" field is
8800 evident.
8801 (processdirlisting): Fix boolean algebra.
8802
0f562d55
CF
8803Wed Apr 26 01:10:39 2000 Christopher Faylor <cgf@cygnus.com>
8804
8805 * main.c (tarx): Add some code for future task of unmounting
8806 directories encountered in tar file.
8807
4356382d
CF
8808Sat Apr 22 16:37:03 2000 Christopher Faylor <cgf@cygnus.com>
8809
8810 * setup.c (findhref): Decode file size, when appropriate.
8811 (needfile): New function. Returns 1 when file should be
8812 downloaded.
8813 (processdirlisting): Always download if file size does not
8814 match. Prompt when download fails for some reason.
8815 (getdownloadsource): Accomodate findhref argument changes.
8816
6ab1ce6c
CF
8817Sat Apr 22 15:13:42 2000 Christopher Faylor <cgf@cygnus.com>
8818
8819 Throughout, use global session handle rather than reinitializing for
8820 each connect. Don't pass session as an argument to setup.c functions.
8821 * setup.c (geturl): Only issue "Connecting to.." message when using
8822 http or first time for ftp since subsequent connections will be fast.
8823 (processdirlisting): Allocate space for "N" when user has specified
8824 "N"ever option so that it can be subsequently freed.
8825 (main): Abort if we can't get the list of mirrors.
8826
37ee316b
CF
8827Thu Apr 20 16:41:42 2000 Christopher Faylor <cgf@cygnus.com>
8828
8829 * setup.c (main): Umount /bin and /lib.
8830
a59fb4fa
CF
8831Wed Apr 19 13:34:44 2000 Christopher Faylor <cgf@cygnus.com>
8832
8833 * setup.c (main): Create an empty /var/run/utmp.
8834
75f4b861
CF
8835Tue Apr 18 19:16:56 2000 Christopher Faylor <cgf@cygnus.com>
8836
8837 * Makefile.in: Add umount to list of files to include in setup.exe.
8838 * setup.c (xumount): New function for unmounting directories.
8839 (main): Unmount /usr.
8840 (mkmount): Unmount "unix directory" before trying to figure out where
8841 to create the directory.
8842
d4a66789
CF
8843Tue Apr 18 17:28:55 2000 Christopher Faylor <cgf@cygnus.com>
8844
8845 * setup.c (mkmount): Use xcreate_process to start mount process,
8846 avoiding the shell.
8847 (main): Don't do buffering on stdout or prompts won't be displayed
8848 correctly if running in a cygwin shell with CYGWIN=tty.
8849
a6c3982d
CF
8850Tue Apr 18 15:35:19 2000 Christopher Faylor <cgf@cygnus.com>
8851
8852 * setup.c (main): Remove the CYGWIN environment variable before
8853 starting any cygwin programs.
8854
0ffd5e3b
CF
8855Mon Apr 17 19:20:52 2000 Vadim Egorov <egorovv@mailandnews.com>
8856
8857 * setup.c (geturl): Use alternative method for finding filename part of
8858 a URL.
8859 (processdirlisting): Accomodate strange output from non-MS ftp proxy.
8860 (downloaddir): Unlink file containing dir listing.
8861 (downloadfrom): Ditto.
8862
3e54bcf9
CF
8863Mon Apr 17 00:00:49 2000 Christopher Faylor <cgf@cygnus.com>
8864
8865 * setup.c (main): Disallow running setup.exe from the "root".
8866
005b73c4
CF
8867Sun Apr 16 18:50:58 2000 Christopher Faylor <cgf@cygnus.com>
8868
2cf65e6e 8869 Use "warning" function, where appropriate, to output warnings.
005b73c4
CF
8870 * setup.c (warning): New function -- outputs warning to console and log
8871 file.
8872 (tarx): Fix index used to reset file protection.
8873 (main): Open the log file earlier so that more stuff can be sent to it.
8874
36dc5fc8
CF
8875Sat Apr 15 20:05:33 2000 Christopher Faylor <cgf@cygnus.com>
8876
8877 * setup.c (processdirlisting): Make "N" option a little less aggressive.
8878
c73320de
CF
8879Fri Apr 14 11:11:29 2000 Christopher Faylor <cgf@cygnus.com>
8880
8881 * setup.c (tarx): Wait to after tar has completed to reset protections
8882 or suffer races with tar process.
8883
68cdfc92
CF
8884Thu Apr 13 12:51:19 2000 Christopher Faylor <cgf@cygnus.com>
8885
8886 * Makefile.in: Eliminate duplicate -nostdinc from CFLAGS.
8887 * setup.c (create_uninstall): Create the uninstall .bat file in the
8888 "root" so that we can remove the /bin directory. Add bin\cygwin.bat to
8889 list of files to be deleted. Fix directory detection for determining
8890 when to use 'rmdir'.
8891 (do_start_menu): Add /usr/local/bin to the path.
8892 (main): Add slop to files.array allocation so that we don't have to
8893 worry about reallocating the array when it grows too large when doing
8894 some trivial "pushes". Add /tmp and /usr/local/{bin,lib} to list of
8895 files.
8896
35d18861
CF
8897Thu Apr 13 01:59:44 2000 Christopher Faylor <cgf@cygnus.com>
8898
8899 * setup.c (processdirlisting): Fix handling of "A" for "A"lways
8900 download.
8901
20904de1
CF
8902Thu Apr 13 01:11:45 2000 Christopher Faylor <cgf@cygnus.com>
8903
8904 * path.c (kill_cygpath): New cleanup function.
8905 (exit_cygpath): New cleanup function.
8906 (cygpath_pipe): New function. Sets up cygpath in the background for
8907 translating filenames.
8908 (pathcvt): Use background cygpath for file translation.
8909 * setup.c (tarx): New function. Called to extract tar files, capture
8910 logging output, and translate it to Windows format.
8911 (recurse_dirs): Use 'tarx' function to extract files.
8912 (create_uninstall): Use file list built up by tarx rather than reading
8913 the log file.
8914 (mkmount): Add ability to mount root.
8915 (main): Track elapsed install time. Mount root.
8916 * starry.h: Add index field to strarry for tracking of tarx's usage of
8917 this structure.
8918 * xsystem.c (xcreate_process): Return proces handle when not waiting.
8919
c1246750
CF
8920Mon Apr 10 22:44:56 2000 Christopher Faylor <cgf@cygnus.com>
8921
8922 * path.c: New file.
8923 (pathfp): New function. Preliminary work for new -f cygpath
8924 functionality.
8925 * Makefile.in: Add new file.
8926 (pathcvt): Move to new file.
8927 (dtoupath): Ditto.
8928 (utodpath): Ditto.
8929 (pathcat): Ditto.
8930 * setup.c (processdirlisting): Always open file in text mode.
8931 (create_uninstall): Ditto.
8932 (getdownloadsource): Ditto.
8933 (main): Ditto.
8934
4b40edd0
CF
8935Mon Apr 10 20:33:40 2000 Christopher Faylor <cgf@cygnus.com>
8936
8937 * xsystem.c: New file.
8938 * Makefile.in: Accomodate new file.
8939 * setup.c (xsystem): Move to new file.
8940 (recurse_dirs): Accept handle to output log file. Don't use ">"
8941 redirection to trap tar output. Use supplied handle instead.
8942 (create_uninstall): Accept FILE pointer to opened log file. Don't
8943 unlink log file here.
8944 (do_start_menu): Accept FILE pointer to pass to create_uninstall.
8945 (main): Open log file here and pass it to various functions. Unlink
8946 when done.
8947
6f8e3b45
CF
8948Mon Apr 10 17:15:52 2000 Christopher Faylor <cgf@cygnus.com>
8949
8950 Change occurrences of .usr.bin to .bin throughout.
8951 * setup.c (geturl): Increase number of retries to 20. Let user know
8952 what's going on during long connects.
8953 (processdirlisting): Accept "A"lways and "N"ever as update options.
8954 (create_uninstall): Load cygwin1.dll from the current directory rather
8955 than \bin.
8956 (main): Add some expository text.
8957
2a907b70
CF
8958Sun Apr 9 20:59:15 2000 Christopher Faylor <cgf@cygnus.com>
8959
8960 * Makefile.in: Change method for compressing cygwin1.dll to avoid
8961 creating a cygwin1.dll in the current directory. Ensure the addition
8962 of -nostdinc to MINGW_CFLAGS.
8963
c4285a3c
CF
8964Sun Apr 9 02:15:47 2000 Christopher Faylor <cgf@cygnus.com>
8965
8966 * Makefile.in: Augment clean target.
8967
ea615d51
RP
8968Fri Apr 7 17:04:02 Ron Parker <rdparker@sourceware.cygnus.com>
8969
8970 * README: Added info about non-working mingw implementation
c1246750 8971 * gzip.exe.gz: Replace with a version from the same build as the other
ea615d51 8972 tools.
c1246750 8973 * tar.exe.gz: Replace with a version from the same build as the other
ea615d51 8974 tools.
c1246750 8975 * mount.exe.gz: Add to repository until, mingw can build setup.
ea615d51
RP
8976 * cygpath.exe.gz: ditto
8977 * cygwin1.dll.gz: ditto
c1246750
CF
8978 * setup.c: Overwrite /bin and /lib mounts. Generate working shortcut
8979 for Win9x. Display only a screenfull of options at a time. Call all
8980 tools with an absolute path.
8981 * setup.dsp: Restore the carriage returns, MS Developer Studio needs
8982 them.
ea615d51
RP
8983 * setup.dsw: ditto
8984 * zlib.dsw: ditto
8985
51954e74
CF
8986Thu Apr 6 19:15:27 2000 Christopher Faylor <cgf@cygnus.com>
8987
c1246750
CF
8988 * Makefile.in: Add "-nostdinc" to regular CFLAGS. Add target to grab
8989 cygwin1.dll from ../cygwin subdirectory.
51954e74
CF
8990 * gzip.exe.gz: Update.
8991 * tar.exe.gz: Update.
8992
7b777418
CF
8993Wed Apr 5 10:52:08 2000 Christopher Faylor <cgf@cygnus.com>
8994
8995 * Makefile.in: Use ZLIB variable as a target.
8996
4306b490
CF
8997Sat Apr 1 22:49:09 2000 Christopher Faylor <cgf@cygnus.com>
8998
5e7eb909
CF
8999 * Makefile.in: Eliminate traces of cygwinisms. Don't link with
9000 libmsvcrt.a. It's unneeded. Build .rc file on the fly from various
9001 sources.
4306b490
CF
9002 * configure.in: Locate correct objcopy.
9003 * configure: Regenerate.
9004
739457f4
CF
9005Sat Apr 1 20:48:09 2000 Christopher Faylor <cgf@cygnus.com>
9006
9007 * Makefile.in: New file.
9008 * configure.in: New file.
9009 * configure: New file.
9010 * zlib/Makefile.am: New file.
9011 * zlib/configure.in: New file.
9012 * zlib/aclocal.m4: New file.
9013 * zlib/acinclude.m4: New file.
9014 * zlib/configure: Regenerate from configure.in.
9015 * zlib/Makefile.in: Regenerate from Makefile.am
8507f105
DD
9016
9017%%% $Id$
9018$Revision$
This page took 1.149959 seconds and 5 git commands to generate.