]> cygwin.com Git - cygwin-apps/setup.git/blame - ChangeLog
* Makefile.am: Refresh to reflect Makefile.in changes.
[cygwin-apps/setup.git] / ChangeLog
CommitLineData
a3cc7986
CF
12010-03-14 Christopher Faylor <me+cygwin@cgf.cx>
2
3 * Makefile.am: Refresh to reflect Makefile.in changes.
4
671140f9
CW
52010-03-14 Charles Wilson <cygwin@cwilson.fastmail.fm>
6
7 Support xz and lzma decompression via liblzma
8 * Makefile.am: Add -DLZMA_API_STATIC to AM_CPPFLAGS,
9 -lzma to setup_LDADD, and -static-libtool-libs to
10 setup_LDFLAGS. Update setup_SOURCES.
11 * compress.cc: Update includes.
12 (compress::decompress): Use compress_xz rather than
13 compress_lzma; compress_xz supports both xz and lzma
14 decompression.
15 * compress_xz.h: New.
16 * compress_xz.cc: New.
17 * compress_lzma.h: Removed.
18 * compress_lzma.cc: Removed.
19 * lzma-sdk/LzmaDec.c: Removed.
20 * lzma-sdk/LzmaDec.h: Removed.
21 * lzma-sdk/Types.h: Removed.
22
f1c131f2
CV
232010-03-13 DJ Delorie <dj@redhat.com>
24
25 * nio-ftp.c (read): Read RETR status code on EOF to avoid
26 deadlock with PASV.
27
57bdd378
CF
282010-03-01 Christopher Faylor <me+cygwin@cgf.cx>
29
30 * Makefile.in: Output the name of the generated src target.
31
0333948c
CF
322010-03-01 Christopher Faylor <me+cygwin@cgf.cx>
33
34 * Makefile.in: Add a setup-src target.
35
08267187
CV
362010-03-01 Corinna Vinschen <corinna@vinschen.de>
37
38 * filemanip.cc (mklongpath): Skip "." and ".." path components to
39 avoid error messages.
40
26c8444e
CV
412010-02-15 Corinna Vinschen <corinna@vinschen.de>
42
43 * filemanip.cc (mklongpath): Simplify backslash folding.
44
6e2c72d0
CV
452010-02-15 Corinna Vinschen <corinna@vinschen.de>
46
47 * filemanip.cc (transform_chars): Drop function.
48 (mklongpath): Call mbrtowc in a loop rather than just mbstowcs.
49 Transform characters on the fly. Fold multiple backslashes into one.
50 Drop trailing backslash.
51
7a4e611a
DK
522010-02-15 Dave Korn <dave.korn.cygwin@gmail.com>
53
54 * choose.cc (ChooserPage::PlaceDialog): Only skip resizing window
55 in fully-unattended mode, not chooser-only mode.
56 (ChooserPage::OnUnattended): Return appropriate status to run page
57 or not according to kind of unattended mode.
58 * choose.h (ChooserPage::OnUnattended): Remove inline implementation
59 and retain prototype only.
60 * main.cc (PackageManagerOption): New boolean option.
61 (main): Take it into account when setting unattended_mode.
62 * proppage.cc (PropertyPage::DialogProc): Use new enum type when
63 setting unattended_mode.
64 * state.cc (unattended_mode): Change from bool to enum attend_mode.
65 * state.h (enum attend_mode): Declare new enum type.
66 (unattended_mode): Update extern declaration to use it.
67
2801c09c
CV
682010-02-04 Corinna Vinschen <corinna@vinschen.de>
69
70 * win32.cc (NTSecurity::GetPosixPerms): Return NULL security descriptor
71 if is_legacy is set.
72 (NTSecurity::SetPosixPerms): Remove.
73 * win32.h (NTSecurity::GetPosixPerms): Remove declaration.
74
d2a5fdfb
CV
752010-02-02 Corinna Vinschen <corinna@vinschen.de>
76
77 * desktop.cc (make_link): Use 0 default permissions when creating files
78 and directories.
79 * download.cc (download_one): Ditto.
80 * ini.cc (do_remote_ini): Ditto.
81 * localdir.cc (offer_to_create): Ditto.
82 * filemanip.cc (nt_wfopen): Use Windows default permissions if perms
83 is set to 0.
84 * mkdir.cc (mkdir_p): Ditto if mode is set to 0.
85
b67a5ea0
CF
862010-01-29 Christopher Faylor <me+cygwin@cgf.cx>
87
88 * mount.cc (read_mounts_9x): Preserve old way of doing things when
89 is_legacy.
90
558484cc
CF
912010-01-28 Christopher Faylor <me+cygwin@cgf.cx>
92
93 * desktop.cc (make_link): Preserve old way of doing things when
94 is_legacy.
95 (make_cygwin_bat): Ditto.
96 (save_icon): Ditto.
97 * mount.cc (read_mounts): Ditto.
98 (set_root_dir): Ditto.
99 * root.cc (load_dialog): Ditto.
100 (save_dialog): Ditto.
101 * install.cc (Installer::installOne): Don't install anything if there
102 is no canonical file associated with source.
103 (do_install_thread): Set up old-style registry entries if is_legacy
104 rather than just keying on whether this is Windows NT.
105 * io_stream_file.cc (io_stream_file::exists): Redefine "exists" to mean
106 "it's a file".
107
d0c6ddb9
CF
1082010-01-16 Christopher Faylor <me+cygwin@cgf.cx>
109
110 * archive_tar.c (archive_tar_file::read): Always set read_something
111 even for zero-length files.
112
bb000e11
CF
1132010-01-16 Christopher Faylor <me+cygwin@cgf.cx>
114
115 * archive_tar.h (archive_tar_file::read_something): New member.
116 * archive_tar_file.cc (archive_tar_file::archive_tar_file): Don't reset
117 state unless we've actually read something.
118 (archive_tar_file::read): Set read_something variable here to indicate
119 that we've read something from the tar file.
120
7c907c13
CF
1212010-01-13 Christopher Faylor <me+cygwin@cgf.cx>
122
123 * localdir.cc (LocalDirPage::OnNext): Strip trailing slashes.
124
89216328
CF
1252009-12-27 Christopher Faylor <me+cygwin@cgf.cx>
126
127 * main.cc (dyn_AttachConsole): Make static.
128 (dyn_GetLongPathName): New variable.
129 (set_dynaddr): New function.
130 (set_cout): Don't set dyn_AttachConsole here.
131 (set_legacy): Don't attempt to call function which does not exist in
132 older versions of NT.
133 (main): Call set_dynaddr to set dynamic load addresses.
134
4ea94dbb
CF
1352009-12-22 Christopher Faylor <me+cygwin@cgf.cx>
136
137 * ini.h: Use is_legacy to control setup.ini names.
138 * main.cc (set_legacy): New function.
139 (main): Call set_legacy with program name to determine if this is
140 supposed to be an installation of the legacy version of cygwin. Issue
141 a warning on attempt to install legacy on Windows NT class system.
142
84b04515
CF
1432009-12-22 Christopher Faylor <me+cygwin@cgf.cx>
144
145 * package_message (packagemessage::display): Avoid displaying a message
146 when in unattended mode.
147
4d10ec8c
CV
1482009-12-22 Corinna Vinschen <corinna@vinschen.de>
149
150 * win32.h (isdirsep): Define to replace local isslash definitions.
151 * UserSettings.cc (UserSettings::open_settings): Remove isslash.
152 Use isdirsep instead of isslash.
153 * filemanip.cc (mklongpath): Ditto.
154 * root.cc (directory_is_rootdir): Ditto.
155 * localdir.cc (LocalDirSetting::save): Avoid consecutive backslashes
156 in setup log file paths.
157 * main.cc (main): Ditto.
158
e305f965
CF
1592009-12-21 Christopher Faylor <me+cygwin@cgf.cx>
160
161 * choose.cc (ChooserPage::PlaceDialog): Put *correct* size in
162 WINDOWPLACEMENT length field.
163
26922cd2
CV
1642009-12-18 Corinna Vinschen <corinna@vinschen.de>
165
166 Throughout, revert prototypes and methods set_mtime_and_mode to
167 set_mtime and only care for the file timestamp.
168
169 Throughout, accommodate additional mode_t parameter in call to
170 io_stream::open.
171
172 * IOStreamProvider.h (IOStreamProvider::open): Add mode_t parameter.
173 * archive.cc (archive::extract_file): Reorder creation of in and tmp
174 to get the file mode from the tar archive earlier. Call io_stream::open
175 with additional mode from tar archive. Accommodate reversion to
176 set_mtime.
177 * filemanip.cc (nt_wfopen): Remove retry loop. Instead initialize
178 OBJECT_ATTRIBUTES with matching POSIX perms according to incoming
179 perms to create correct ACL on file creation. Remove subsequent call
180 to nt_sec.SetPosixPerms.
181 * io_stream.cc (io_stream::open): Take additional mode_t parameter
182 and connect through to IOStreamProvider's open.
183 * io_stream.h (io_stream::open): Add mode_t parameter.
184 * io_stream_cygfile.cc (CygFileProvider::open): Ditto.
185 (io_stream_cygfile::io_stream_cygfile): Ditto. Call nt_wfopen with
186 incoming mode_t parameter. Make sure .exe and .dll files always
187 have execute permissions set.
188 (io_stream_cygfile::set_mtime): Remove retry loop and open file with
189 just GENERIC_WRITE access.
190 * io_stream_cygfile.h (io_stream_cygfile::io_stream_cygfile): Add mode_t
191 parameter.
192 * io_stream_file.cc (FileProvider::open): Ditto.
193 (io_stream_file::io_stream_file): Ditto. Call nt_wfopen with incoming
194 mode_t parameter.
195 * io_stream_file.h (io_stream_file::io_stream_file): Add mode_t
196 parameter.
197 * io_stream_memory.h (class io_stream_memory): Remove mode member.
198 Just return 0 from get_mode.
199 * mkdir.cc (mkdir_p): Remove retry loop. Instead initialize
200 OBJECT_ATTRIBUTES with matching POSIX perms according to incoming
201 perms to create correct ACL on file creation. Remove subsequent call
202 to nt_sec.SetPosixPerms.
203 * mklink2.cc (mkcygsymlink_nt): Remove retry loop. Instead initialize
204 SECURITY_ATTRIBUTES with matching POSIX perms to create correct ACL on
205 file creation.
206 * win32.cc (NTSecurity::GetPosixPerms): New function to generate
207 POSIX ACL. Default to current owner and current primary group for
208 owner/group permissions.
209 (NTSecurity::SetPosixPerms): Let GetPosixPerms create the DACL.
210 (NTSecurity::setAdminGroup): Set groupSID to admins SID if successful.
211 (NTSecurity::setDefaultSecurity): Store user SID in ownerSID member.
212 Default groupSID to original primary group.
213 * win32.h (struct acl_t): Define here.
214 (class NTSecurity): Rename ownerSID and groupSID to cr_ownerSID and
215 cr_groupSID. Change throughout. Add members ownerSID and groupSID.
216 Declare new method GetPosixPerms.
217
7a332fb8
CV
2182009-12-17 Corinna Vinschen <corinna@vinschen.de>
219
220 * filemanip.cc (nt_wfopen): Only call nt_sec.SetPosixPerms if we have
221 WRITE_DAC access.
222 * mkdir.cc (mkdir_p): Ditto.
223
21aa9a8b
CV
2242009-12-17 Corinna Vinschen <corinna@vinschen.de>
225
226 * filemanip.cc (nt_wfopen): Fix requested access rights. Retry
227 without WRITE_DAC access on access denied. Add comment.
228 * io_stream_cygfile.cc (io_stream_cygfile::set_mtime_and_mode): Ditto.
229 * mkdir.cc (mkdir_p): Ditto.
230 * mklink2.cc (mkcygsymlink_nt): Ditto.
231
c459d893
CV
2322009-12-17 Corinna Vinschen <corinna@vinschen.de>
233
234 * localdir.cc (LocalDirSetting::save): Call mkdir_p with isadir set
235 since /var/log is a dir.
236
32049a60
CV
2372009-12-16 Corinna Vinschen <corinna@vinschen.de>
238
239 * UserSettings.cc (UserSettings::open_settings): Never add more than
240 one slash.
241 * filemanip.cc (tfx_chars): Align to Cygwin's transformation table.
242 * localdir.cc (LocalDirSetting::save): Call mkdir_p with DOS path.
243
ab9a95fc
CF
2442009-12-16 Christopher Faylor <me+cygwin@cgf.cx>
245
246 * package_message.h: New file.
247
f38044ff
CF
2482009-12-13 Christopher Faylor <me+cygwin@cgf.cx>
249
250 * IniDBBuilder.h (buildMessage): Define for base class.
251 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildMessage): Define.
252 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildMessage): Declare.
253 * PickPackageLine.cc: Pass pointer to package to "pick" throughout,
254 where appropriate.
255 * PickView.cc: Ditto.
256 * install.cc: Ditto.
257 * package_meta.cc: Ditto.
258 * prereq.cc: Ditto.
259 * package_version.cc: Ditto.
260 (packageversion::pick): Add pkg pointer as second argument. Display
261 message where appropriate.
262 * package_version.h (packageversion::pick): Add pkg pointer as second
263 argument.
264 * package_meta.h (packagemeta::mesage): Define.
265 (packagemeta::set_message): Define.
266 * inilex.ll: Properly return MESSAGE token.
267 * iniparse.yy: Handle message: keyword.
268
cc7a5bf5
DK
2692009-12-08 Dave Korn <dave.korn.cygwin@gmail.com>
270
271 * localdir.cc (offer_to_create): New function.
272 (browse_cb): Handle selection changed and validate failed
273 callbacks, and call offer_to_create where appropriate.
274 (browse): Set new dialog style flags in browser info.
275 (LocalDirPage::OnNext): Replace call to mkdir_p with offer to
276 create or error message dialog display, allow proceeding to
277 chooser even if local dir does not exist in unattend mode or
278 if user insists, and fix small memory leak.
279
280 * res.rc (IDS_MAYBE_MKDIR, IDS_CANT_MKDIR, IDS_NO_CWD): Define new
281 string resources.
282 * resource.h (IDS_MAYBE_MKDIR, IDS_CANT_MKDIR, IDS_NO_CWD): Define
283 corresponding resource ID numbers.
284
a5405502
CV
2852009-12-03 Corinna Vinschen <corinna@vinschen.de>
286
287 * main.cc (WinMain): Disable running on Windows 9x. Show message box
288 instead and exit.
289
98756d2f
DK
2902009-12-03 Dave Korn <dave.korn.cygwin@gmail.com>
291
292 (ChooserPage::createListview): When nothing is found in the "All"
293 category, pass an empty static dummy category object to the PickView
294 constructor, instead of trying to dereference not-found iterator.
295
f72d5840
CV
2962009-11-23 Corinna Vinschen <corinna@vinschen.de>
297
298 * io_stream_cygfile.cc (io_stream_cygfile::get_size): Don't try to
299 close invalid handle.
300 * io_stream_file.cc (io_stream_file::get_size): Ditto
301
e1751ab2
DK
3022009-11-22 Dave Korn <dave.korn.cygwin@gmail.com>
303
304 * threebar.cc (ThreeBarProgressPage::OnMessageApp): Don't loop forever
305 retrying ini file download/parse if it errors in unattended mode.
306
513f7781
DK
3072009-11-22 Dave Korn <dave.korn.cygwin@gmail.com>
308
309 * package_meta.cc (CategoryOption): New StringOption for '-C'.
310 (parseNames): New helper subroutine abstracts string parsing from ...
311 (packagemeta::isManuallyWanted): Use it, and check for category names
312 from CategoryOption as well as individual package names.
313 * package_db.cc (packagedb::fillMissingCategory): Don't check for
314 manually-wanted packages until after initialising all the categories.
315
2b94fe1e
DK
3162009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
317
318 * localdir.cc (LocalDirSetting::LocalDirSetting): Restore -l option.
319
da434346
DK
3202009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
321
322 * site.cc: Add #include of BoolOption header from libgetopt.
323 (OnlySiteOption): New BoolOption for command-line -O option.
324 (get_site_list): Respect BoolOption by not downloading mirror
325 list, nor using nor updating cached mirrors.
326
c7c7a4e0
DK
3272009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
328
329 * download.cc (do_download_thread): Only retry an incomplete download
330 a limited number of times in unattended mode.
331
9e11837b
DK
3322009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
333
334 * main.cc (main_display): Use apartment-, not multi- threading model
335 when initialiseing COM.
336
64cf790e
CV
3372009-11-04 Corinna Vinschen <corinna@vinschen.de>
338
339 * localdir.cc (browse): Make title text depend on what we do.
340 (LocalDirPage::OnNext): If we plan to download, try to create directory
341 before cd'ing into it.
342
89cc2408
CV
3432009-11-03 Corinna Vinschen <corinna@vinschen.de>
344
345 * mkdir.cc: Include sys/stat.h unconditionally.
346 (mkdir_p): Add S_IFDIR flag in call to nt_sec.SetPosixPerms.
347 * win32.cc: Include sys/stat.h.
348 (NTSecurity::SetPosixPerms): Add CREATOR OWNER, CREATOR GROUP, and
349 Everyone inheritance-only entries when setting a directory DACL.
350 (NTSecurity::initialiseWellKnownSIDs): Create SIDs for CREATOR OWNER and
351 CREATOR GROUP.
352 * win32.h (class NTSecurity): Add members ownerSID and groupSID.
353
3e805913
CV
3542009-10-03 Andy Koppe <andy.koppe@gmail.com>
355
356 * main.cc (main): Make sure C runtime uses same codepage as GUI.
357
0188fce5
CF
3582009-09-20 Christopher Faylor <me+cygwin@cgf.cx>
359
360 * main (set_cout): Really do attach to a console if stdout is "bad".
361
8bc8a102
CF
3622009-09-18 Andy Koppe <andy.koppe@gmail.com>
363
364 * root.cc (string orig_root_dir): New variable.
365 (check_if_enable_next): Show warning against installing Cygwin into
366 disk root only if the root directory has actually been changed.
367 * res.rc: Make the root dir warning a bit more meaningful, and refrain
368 from using uppercase.
369
3702009-09-18 Christopher Faylor <me+cygwin@cgf.cx>
371
372 * choose.cc (ChooserPage::OnBack): Revert to non-maximized when
373 returning to mirror from package selection.
374
ca09f44c
DK
3752009-09-18 Dave Korn <dave.korn.cygwin@gmail.com>
376
377 * site.cc (get_site_list): Use empty string if user settings
378 return NULL pointer for cached mirrors list.
379 (SiteSetting::getSavedSites): Do nothing if user settings return
380 NULL pointer for last mirror URL.
381
83ab685b
CF
3822009-08-21 Christopher Faylor <me+cygwin@cgf.cx>
383
384 * site.cc (SiteSetting::registerSavedSite): Fix comment.
385
0cbac692
CF
3862009-07-03 Christopher Faylor <me+cygwin@cgf.cx>
387
388 * main.cc (set_cout): Don't reset stdout if we already have a stdout.
389
7411af0f
CF
3902009-07-03 Christopher Faylor <me+cygwin@cgf.cx>
391
392 * choose.cc (ChooserPage::ChooserPage): Use more specific name for
393 saving window settings.
394 (ChooserPage::~ChooserPage): Ditto.
395
0baffe9a
DK
3962009-07-01 Dave Korn <dave.korn.cygwin@gmail.com>
397
398 * PickView.h (PickView::total_delta_x): New int member.
399 (PickView::set_header_column_order): Add prototype.
400 * PickView.cc (PickView::set_header_column_order): New function,
401 broken out from ...
402 (PickView::set_headers): ... here. Call it.
403 (PickView::init_headers): Apply total_delta_x to last_col width.
404 (PickView::PickView): Initialise new total_delta_x member to zero.
405 (PickView::WindowProc): Use set_header_column_order to find and
406 adjust final column for both sets of headers.
407
ca2b7505
CF
4082009-06-29 Christopher Faylor <me+cygwin@cgf.cx>
409
410 * SourceSetting.cc (SourceSetting::SourceSetting): Restore proper
411 remembrane of last source setting.
412 * choose.cc (ChooserPage::ChooserPage): Potentially retrieve dialog
413 placement info.
414 (ChooserPage::~ChooserPage): Save geometry settings if the user moved
415 or resized the page.
416 (ChooserPage::PlaceDialog): Rename from MaximizeDialog. Accommodate
417 changed user placement settings.
418 (ChooserPage::OnActivate): MaximizeDialog -> PlaceDialog.
419 (ChooserPage::OnNext): Ditto.
420 * choose.h (ChooserPage::~ChooserPage): Define.
421 (ChooserPage::cmd_show): Delete.
422 (ChooserPage::saved_geom): New field.
423 (ChooserPage::window_placement): Ditto.
424 (ChooserPage::pre_chooser_placement): Ditto.
425 (ChooserPage::PlaceDialog): Rename from MaximizeDialog.
426
7c863922
CF
4272009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
428
429 * ConnectionSetting.cc (ConnectionSetting::ConnectionSetting): Remove
430 old code which no longer makes sense when run from a constructor.
431 * SourceSetting.cc (SourceSetting::SourceSetting): Ditto.
432 * localdir.cc (LocalDirSetting::LocalDirSetting): Ditto. Fix typo
433 which caused saved settings to be ignored.
434
127febea
CF
4352009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
436
437 * UserSettings.cc (UserSettings::UserSettings): settings.rc -> setup.rc.
438
e36b0f1e
CV
4392009-06-28 Corinna Vinschen <corinna@vinschen.de>
440
441 * desktop.cc (DesktopSetupPage::OnInit): Drop CoInitialize call here.
442 * main.cc (main_display): Use InitCommonControlsEx rather than
443 InitCommonControls per MSDN. Call CoInitializeEx and create IShellLink
444 instance here to workaround a problem on Windows 7. Release IShellLink
445 instance and call CoUninitialize on exit.
446 * mklink.cc (sl): Change to global variable. Drop call to
447 CoCreateInstance here. Check if sl is valid before using it.
448
f26f525f
CF
4492009-06-27 Christopher Faylor <me+cygwin@cgf.cx>
450
451 Preliminary option handling revamp.
452 Throughout, change load/save methods to constructors/destructors which
453 use new UserSettings methods. Do not inherit from UserSetting class.
454 * KeysSetting.cc (ExtraKeysSetting *ExtraKeysSetting::global): Define.
455 (ExtraKeysSetting::ExtraKeysSetting): Initialize some class members use
456 new UserSettings methods.
457 (ExtraKeysSetting::~ExtraKeysSetting): Use new UserSettings method.
458 * Makefile.am (setup_SOURCES): Eliminate UserSetting.h and
459 UserSetting.cc.
460 * UserSettings.cc: Complete rewrite. Implements new UserSettings
461 class methods.
462 * UserSettings.h: Complete rewrite. Defines new UserSettings class
463 methods.
464 * crypto.cc (ExtraKeys): Delete.
465 (add_key_from_sexpr): Use ExtraKeysSetting::instance rather than
466 ExtraKeys.
467 (verify_ini_file_sig): Ditto.
468 * io_stream.h (io_stream): Define virtual << operators.
469 * localdir.cc (localDir): Delete.
470 * main.cc: Include headers which declar new dynamically invoked
471 classes.
472 (main_display): New function. Controls order of option setting and
473 property page setup. Add new class invocations to force option setting
474 initializtion.
475 (main): Invoke new UserSettings class constructor to populate new
476 settings class. Call main_display() to do most of the setup work.
477 Call Settings.save () to save all settings.
478 * net.cc (theSetting): Delete.
479 * site.cc (SiteSetting::save): Record whether we've saved the
480 information already.
481 (get_site_list): Just use value returned from new UserSettings method
482 rather than parsing a file.
483 (SiteSetting::getSavedSites): Ditto.
484 (write_cache_list): Use UserSettings operator to store mirror cache.
485 (save_cache_file): Ditto.
486 * source.cc (theSetting): Delete.
487
488 * win32.h: gcc-4 accommodation.
489
9d0a3d8a
DK
4902009-06-26 Dave Korn <dave.korn.cygwin@gmail.com>
491
492 * res.rc (SETUP_STANDARD_DIALOG_W, SETUP_STANDARD_DIALOG_H,
493 SETUP_SMALL_DIALOG_W, SETUP_SMALL_DIALOG_H): Add constant defines
494 for dialog sizes.
495 (SETUP_STANDARD_DIALOG_DIMS, SETUP_SMALL_DIALOG_DIMS): Add helper
496 macros for (W,H) pairs of dimensions.
497 (SETUP_HEADICON_X): New global constant define.
498 (IDD_SOURCE, IDD_VIRUS, IDD_LOCAL, IDD_ROOT, IDD_SITE, IDD_NET,
499 IDD_INSTATUS, IDD_PROXY_AUTH, IDD_NET_AUTH, IDD_DESKTOP,
500 IDD_FTP_AUTH DIALOG, IDD_DROPPED): Use the above for dialog sizes,
501 horizontal rules and icon positioning.
502 (SETUP_KPCE_W): New define for radio-button size.
503 (SETUP_VIEWCAP_W, SETUP_VIEWCAP_X, SETUP_VIEW_W, SETUP_VIEW_X,
504 SETUP_EXP_X, SETUP_CURR_X, SETUP_PREV_X, SETUP_KEEP_X): Add defines
505 for right-aligned controls.
506 (SETUP_SEARCH_X, SETUP_SEARCH_W, SETUP_SEARCHTEXT_X,
507 SETUP_SEARCHTEXT_W, SETUP_CLEAR_X, SETUP_CLEAR_W): Likewise defines
508 for left-aligned controls.
509 (IDD_CHOOSE): Use all the above, and reformat with whitespace
510 between args for clarity.
511
1789ef54
CV
5122009-06-26 Corinna Vinschen <corinna@vinschen.de>
513
514 * Makefile.am (setup_LDADD): Add -lshlwapi.
515 * PickView.cc: Include shlwapi.h.
516 (PickView::setViewMode): Compare package name with search string
517 case-insensitive.
518 (PickView::insert_category): Ditto.
519
557b4e65
CV
5202009-06-26 Corinna Vinschen <corinna@vinschen.de>
521
522 * script.cc (init_run_script): Don't set $HOME to /tmp. It breaks
523 mkpasswd -c.
524
46cf12cd
CV
5252009-06-25 Corinna Vinschen <corinna@vinschen.de>
526
527 * script.cc (init_run_script): Reinstantiate accidentally removed
528 setting of sh.
529
b56d411d
CF
5302009-06-22 Christopher Faylor <me+cygwin@cgf.cx>
531
532 * script.cc (init_run_script): Revert to initializing cmd based on OS
533 type.
534
c14feb84
CV
5352009-06-22 Corinna Vinschen <corinna@vinschen.de>
536
537 * script.cc (Script::run): Start bash without -c option.
538
00fa5f6c
CF
5392009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
540
541 * threebar.cc (ThreeBarProgressPage::ins_dialog): Move variable to more
542 appropriate class.
543 (ThreeBarProgressPage::MaximizeDialog): Move function to more
544 appropriate class.
545 (ThreeBarProgressPage::OnMessageApp): Remove MaximizeDialog calls.
546 * threebar.h: Remove maximize handling.
547 * choose.cc (ChooserPage::ins_dialog): New variable.
548 (ChooserPage::MaximizeDialog): New function.
549 (ChooserPage::ChooserPage): Remove unneeded handling of nCmdShow.
550 (ChooserPage::OnActivate): Maximize chooser page via MaximizeDialog.
551 (ChooserPage::OnNext): Revert chooser page to normal before returning.
552 * main.cc (main): Don't pass cmd_show to ChooserPage.
553 * propsheet.cc (PropSheetProc): Accommodate change in class for
554 SetHwndDialog.
555
5a85457b
CF
5562009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
557
558 * script.cc (shells): Delete.
559 (cmd): Just assign to "cmd.exe" since we're always running on NT now.
560 (sanitize_PATH ): New function.
561 (init_run_script): Ensure that we're only called once. Strip
562 environment of non-pertinent stuff. Call sanitize_PATH to remove
563 non-standard stuff from the PATH. Set up a few standard environment
564 variables.
565
b0bb51b4
CV
5662009-06-16 Corinna Vinschen <corinna@vinschen.de>
567
568 * mount.cc (create_install_root): Don't load mount table again.
569 (read_mounts_nt): Don't break loop, rather continue when not being
570 able to open "Cygwin" registry key.
571
ed1f007a
CF
5722009-06-03 Ralph Hempel <rhempel@bmts.com>
573
574 * source.cc: Add support for both -D and -L on the command line.
575
7cb7c06e
CV
5762009-06-03 Corinna Vinschen <corinna@vinschen.de>
577
578 * filemanip.cc (unlink): Rename from DeleteFileW. Take additional
579 parameter to indicate file type to unlink. Use in flags given to
580 NtCreateFile.
581 (DeleteFileW): Just call unlink from here with FILE_NON_DIRECTORY_FILE
582 flag.
583 (RemoveDirectoryW): Ditto with FILE_DIRECTORY_FILE flag.
584
1eb4caec
CW
5852009-05-30 Charles Wilson <cygwin@cwilson.fastmail.fm>
586
587 * script.cc (Script::run): Really start bash with --norc
588 --noprofile options.
589
b7940eb5
CV
5902009-05-13 Corinna Vinschen <corinna@vinschen.de>
591
592 * script.cc (Script::run): Start bash with --norc --noprofile options.
593
94f52d39
CV
5942009-05-13 Corinna Vinschen <corinna@vinschen.de>
595
596 * filemanip.cc (struct _FILE_RENAME_INFORMATION): Remove definition.
597 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Set
598 default permission for .exe files to 0755.
599 (io_stream_cygfile::mklink): Try to create real hardlink first. Add
600 comment.
601 * mklink2.cc (mkcyghardlink): New function to create real hardlink.
602 * mklink2.h (mkcyghardlink): Declare.
603 * mount.cc (from_fstab_line): Set got_usr_bin and got_usr_lib flags
604 if /usr/bin and /usr/lib mount points exist in /etc/fstab.
605 (add_usr_mnts): Only create mounts if corresponding got_usr_bin and
606 got_usr_lib flags are not set.
607 (read_mounts_nt): Initialize got_usr_bin and got_usr_lib to false.
608 Always call add_usr_mnts, even if from_fstab succeeded.
609 * ntdll.h: Include ddk/ntifs.h.
610
b4473ece
CV
6112009-05-12 Corinna Vinschen <corinna@vinschen.de>
612
613 * filemanip.cc (GetFileAttributesW): Add accidentally omited
614 OBJ_CASE_INSENSITIVE when creating OBJECT_ATTRIBUTES.
615 (SetFileAttributesW): Ditto.
616 (MoveFileW): Ditto.
617 (DeleteFileW): Ditto.
618 (RemoveDirectoryW): Ditto.
619 (nt_wfopen): Ditto.
620
e0fd9bd3
CF
6212009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
622
623 * localdir.cc (load_dialog): Choose description string based on install
624 type.
625 * res.rc (IDD_LOCAL_DIR): Replace static description text with
626 IDC_LOCAL_DIR_DESC.
627 * resource.h (IDS_LOCAL_DIR_DOWNLOAD): New string resource id.
628 (IDS_LOCAL_DIR_INSTALL): Likewise.
629 (IDC_LOCAL_DIR_DESC): New text control resource id.
630
6312009-05-11 Christopher Faylor <me+cygwin@cgf.cx>
632
633 * main.cc (set_cout): Simplify code a little.
634
18d74072
CV
6352009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
636
637 * choose.cc (ChooserPage::OnMessageCmd): Clear search filter when
638 clear button clicked.
639 * res.rc (IDD_CHOOSE_DIALOG): Add IDC_CHOOSE_CLEAR_SEARCH button.
640 * resource.h (IDC_CHOOSE_CLEAR_SEARCH): New button resource ID.
641
6dcfeb7d
CV
6422009-05-11 Corinna Vinschen <corinna@vinschen.de>
643
644 * UserSettings.cc (UserSettings::settingFileForLoad): Fix local load
645 path strings.
646 (UserSettings::settingFileForSave): Never store in cwd.
647 * autoload.c (ntdll): Autoload ntdll.dll functions here.
648 * desktop.cc (make_cygwin_bat): Use GetFileAttributesW rather than
649 _waccess. Use nt_wfopen instead of _wfopen.
650 (save_icon): Ditto.
651 * filemanip.cc (get_file_size): Call io_stream::open with empty mode
652 string to avoid opening file twice.
653 (GetFileAttributesW): New function to replace Win32 function with
654 equivalent function opening files with backup intent.
655 (SetFileAttributesW): Ditto.
656 (MoveFileW): Ditto.
657 (DeleteFileW): Ditto.
658 (RemoveDirectoryW): Ditto.
659 (nt_wfopen): New function to replace _wfopen with equivalent function
660 opening files with backup intent.
661 * filemanip.h (nt_wfopen): Declare.
662 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Initalize
663 lasterr to 0. Allow empty mode and don't open file, if so. Call
664 nt_wfopen rather than _wfopen.
665 (io_stream_cygfile::exists): Use GetFileAttributesW rather than
666 _waccess.
667 (io_stream_cygfile::get_size): Use CreateFileW/GetFileSize to get
668 file size on NT.
669 * io_stream_file.cc (io_stream_file::io_stream_file): Initalize lasterr
670 to 0. Allow empty mode and don't open file, if so. Call nt_wfopen
671 rather than _wfopen.
672 (io_stream_file::exists): Use GetFileAttributesW rather than _waccess.
673 (io_stream_file::remove): Don't try to remove non-existant file.
674 (io_stream_file::get_size): Use CreateFileW/GetFileSize to get
675 file size on NT. Add comment to keep track of 2GB border.
676 * mkdir.cc: Remove function pointers for ntdll functions.
677 (init_ntfuncs): Remove function.
678 (mkdir_p): Drop call to init_ntfuncs. Call ntdll functions directly
679 rather than over local function pointers.
680 * ntdll.h: New file.
681 * postinstall.cc (do_postinstall_reflector): Switch to admins group
ca2b7505 682 as primary group after postinstall scripts have been written.
6dcfeb7d
CV
683 Explain why.
684 (do_postinstall): Add comment.
685 * res.rc: Bump copyright date.
686 * win32.h (class TokenGroupCollection): Remove.
687 * win32.cc (TokenGroupCollection::populate): Remove.
688 (TokenGroupCollection::find): Remove.
689 (NTSecurity::setDefaultSecurity): Drop reading token groups. Just
690 try to switch to admins group as primary group.
691
4b47445f
CV
6922009-05-07 Corinna Vinschen <corinna@vinschen.de>
693
694 * package_db.cc (ConnectedLoopFinder::doIt): Revert patch from
695 2008-08-29. Add dumb hardcoded algorithm to make sure base-cygwin
696 and base-passwd are always the first packages in the postinstall
697 executable order.
698
8752dea2
CV
6992009-05-06 Corinna Vinschen <corinna@vinschen.de>
700
701 * install.cc (Installer::StandardDirs): Add /home with 1777 perms.
702 * main.cc (main): Drop setting $CYGWIN to nontsec.
703
059906b3
DK
7042009-04-24 Andrew Punch <andrew@magneticbooks.com.au>
705
706 * PickView.h: Add #include <string>.
707 (PickView::SetPackageFilter): Add new function.
708 (PickView::packageFilterString): Add new string data member.
709 * PickView.cc (PickView::setViewMode): Use it to filter names.
710 (PickView::insert_category): Likewise.
711 (PickView::PickView): Initialise packageFilterString to blank.
712 * res.rc (IDD_CHOOSE): Add IDC_CHOOSE_SEARCH_EDIT and
713 IDC_CHOOSE_SEARCH_LABEL controls.
714 (IDS_SEARCH_TOOLTIP): Add new string resource.
715 * resource.h (IDS_SEARCH_TOOLTIP): New string resource ID.
716 (IDC_CHOOSE_SEARCH_EDIT): New edit control ID.
717 (IDC_CHOOSE_SEARCH_LABEL): Mew static text control ID.
718 * choose.cc (ChooserControlsInfo[]): Add IDC_CHOOSE_SEARCH_LABEL
719 and IDC_CHOOSE_SEARCH_EDIT controls to auto-resize list.
720 (ChooserPage::OnInit): Add tooltip to search edit box.
721 (ChooserPage::OnMessageCmd): Handle EN_CHANGE event from
722 IDC_CHOOSE_SEARCH_EDIT.
723
6bfd5236
DK
7242009-04-24 Dave Korn <dave.korn.cygwin@gmail.com>
725
726 * propsheet.cc (PropSheetWndProc): Re-enable hasMinRect.
727
d29a864d
CV
7282009-04-23 Corinna Vinschen <corinna@vinschen.de>
729
730 * win32.h (NTSecurity::primaryGroupSID): Convert to a structure for
731 direct usage in GetTokenInformation.
732 (NTSecurity::osid): Remove.
733 (NTSecurity::setAdminGroup): Declare.
734 * win32.cc (NTSecurity::resetPrimaryGroup): Accommodate change to
735 primaryGroupSID. Add log output.
736 (NTSecurity::setAdminGroup): New method.
737 (NTSecurity::setDefaultSecurity): Use local structures for getting
738 TOKEN_USER and setting TOKEN_OWNER information. Accommodate change to
739 primaryGroupSID. Slightly enhance log output.
740 Only set primary group to Administrators group when installing for
741 all users. Call setAdminGroup to do it.
742
770e3aed
CV
7432009-04-22 Corinna Vinschen <corinna@vinschen.de>
744
745 * mklink2.cc (mkcygsymlink_nt): Allow 4K chars in symlink. Use strncat
746 rather than strcat.
747 * postinstall.cc (do_postinstall): Reset user token to original
748 primary group.
d29a864d 749 * win32.cc (NTSecurity::resetPrimaryGroup): New method.
770e3aed
CV
750 (NTSecurity::setDefaultSecurity): Store original primary group in
751 new NTSecurity member primaryGroupSID. Set primary group in user token
752 to Administrators group for admin users. Align comment.
753 * win32.h (class NTSecurity): Add member primaryGroupSID.
754 (NTSecurity::resetPrimaryGroup): Declare.
755
a03b43ad
CF
7562009-04-09 Christopher Faylor <me+cygwin@cgf.cx>
757
758 * main.cc (set_cout): Load AttachConsole dynamically to avoid using it
759 on older Windows which don't support it.
760
c8356810
CF
7612009-03-21 Christopher Faylor <me+cygwin@cgf.cx>
762
763 * LogFile.cc (LogFile::endEntry): Output messages to stdout.
764 * main.cc (set_cout): New function. Sets stdout to console if one
765 exists.
766 (main): Redirect stdout to console if unattended_mode or help option is
767 specified and no stdout is available.
768
7692009-03-21 Terry Fleming <terrynfleming@gmail.com>
770 Christopher Faylor <me+cygwin@cgf.cx>
771
772 * propsheet.cc (PropSheetWndProc): Detect a Window closing event and
773 issue an "Are you sure" message.
774
a2488a3c
CV
7752008-08-29 Corinna Vinschen <corinna@vinschen.de>
776
777 * package_db.cc (ConnectedLoopFinder::doIt): Add code to get a basic
778 order into the dependency list. Add comment to explain why.
779
ef3be327
BD
7802008-08-22 Brian Dessent <brian@dessent.net>
781
782 * KeysSetting.cc: Include string.h for memcpy et al.
783 * filemanip.cc: Include stdlib.h for for mbstowcs.
784 * io_stream_cygfile.h: Update cygmkdir_p prototype for mode_t.
785 * mount.cc (conv_fstab_spaces): Silence gcc 4.3 warning ("parentheses
786 around assignment used as truth value").
787
e0a4fb63
CV
7882008-08-20 Corinna Vinschen <corinna@vinschen.de>
789
790 * install.cc (Installer::StandardDirs): Additionally create /var/log
791 dir. Set mode of /var/log and /var/run to 01777.
792 * localdir.cc (LocalDirSetting::save): Create /var/log with 01777
793 permissions before creating setup.log files.
794
be617b59
CV
7952008-08-20 Corinna Vinschen <corinna@vinschen.de>
796
797 * io_stream_cygfile.cc (io_stream_cygfile::set_mtime_and_mode):
798 Accommodate SetPosixPerms being method of nt_sec.
799 * mkdir.cc (mkdir_p): Ditto.
800 * mklink2.cc (mkcygsymlink_nt): Ditto.
801 * win32.cc: Slightly rearrange.
802 (NTSecurity::SetPosixPerms): Make SetPosixPerms method of NTSecurity
803 rather than stand-alone function. Remove dynamic allocation for
804 security descriptors in favor of static allocation. Drop out
805 preliminary if well-known SIDs are not initialized. Slightly change
806 and rearrange comments. Add creating NULL SID ACE for special
807 permissions.
808 (NTSecurity::initialiseWellKnownSIDs): New function, replacing
809 NTSecurity::initialiseEveryOneSID. Initialize all well-known SIDs
810 here. Set wellKnownSIDsinitialized to true on success.
811 (NTSecurity::setDefaultDACL): Don't call initialiseEveryOneSID. Change
812 comment. Drop setting failed. Don't open process token here.
813 (NTSecurity::setBackupPrivileges): New function.
814 (NTSecurity::setDefaultSecurity): Call initialiseWellKnownSIDs.
815 Open process token here. Disable setting primary group. Add comment
816 to explain why.
817 * win32.h (SetPosixPerms): Move to NTSecurity.
818 (class NTSecurity): Add SetPosixPerms method. Make all SIDs private
819 again. Make NoteFailedAPI private. Add setBackupPrivileges method.
820 Rename usid to UsersSID. Remove failed method and _failed member.
821 Add wellKnownSIDsinitialized accessors and _wellKnownSIDsinitialized
822 member.
823
b41c2908
CV
8242008-08-19 Corinna Vinschen <corinna@vinschen.de>
825
826 * install.cc (struct std_dirs_t): New type.
827 (class Installer): Change type of StandardDirs to std_dirs_t.
828 (Installer::StandardDirs): Store filename and mode.
829 (do_install_thread): Call io_stream::mkpath_p with name and mode from
830 Installer::StandardDirs.
831 * main.cc (main): Call setDefaultSecurity on global nt_sec.
832 * IOStreamProvider.h (IOStreamProvider::mkdir_p): Add mode parameter.
833 * LogFile.cc (LogFile::log_save): Call io_stream::mkpath_p with 0755
834 mode.
835 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
836 * desktop.cc (make_link): Ditto.
837 * download.cc (download_one): Ditto.
838 * ini.cc (do_remote_ini): Ditto.
839 (do_ini_thread): Ditto.
840 * package_db.cc (packagedb::flush): Ditto.
841 * archive.cc (archive::extract_file): Ditto. Call set_mtime_and_mode
842 with mode from archive. Add code to handle directory permissions as
843 well.
844 * archive_tar.cc (archive_tar::get_mtime): Return time_t. Reformat.
845 (archive_tar::get_mode): New method.
846 * archive_tar.h (class archive_tar_file): Fix prototypes. Replace
847 prototype for set_mtime with prototype for set_mtime_and_mode.
848 (class archive_tar): Ditto.
849 * archive_tar_file.cc (archive_tar_file::get_mtime): Return time_t.
850 (archive_tar_file::get_mode): New method returning mode from tar header.
851 * compress_bz.cc (compress_bz::set_mtime_and_mode): Replace set_mtime.
852 (compress_bz::get_mtime): Return time_t.
853 (compress_bz::get_mode): New function.
854 * compress_gz.cc: Ditto.
855 * compress_lzma.cc: Ditto.
856 * io_stream.cc (io_stream::mkpath_p): Take additional file mode.
857 Call mkdir_p with additional file mode.
858 * io_stream_cygfile.cc (CygFileProvider::mkdir_p): Take additional file
859 mode.
860 (cygmkdir_p): Ditto. Call mkdir_p with additional file mode.
861 (io_stream_cygfile::set_mtime_and_mode): Replace set_mtime. Call
862 SetPosixPerms.
863 * io_stream_file.cc (FileProvider::mkdir_p): Take additional file mode.
864 (io_stream_file::set_mtime_and_mode): Replace set_mtime.
865 * mkdir.cc (init_ntfuncs): New function to initialize function pointers
866 from ntdll.dll.
867 (mkdir_p): Take additional file mode. On NT, use NT functions to create
868 directory. Call SetPosixPerms.
869 * compress_bz.h: Change prototypes accordingly.
870 * compress_gz.h: Ditto.
871 * compress_lzma.h: Ditto.
872 * io_stream.h: Ditto.
873 * io_stream_cygfile.h: Ditto.
874 * io_stream_file.h: Ditto.
875 * io_stream_memory.h: Ditto.
876 * mkdir.h: Ditto.
877 * mklink2.cc (mkcygsymlink_nt): Open file with STANDARD_RIGHTS_ALL
878 access and FILE_FLAG_BACKUP_SEMANTICS flag. Call SetPosixPerms.
879 * mount.cc (from_fstab): Open file with FILE_FLAG_BACKUP_SEMANTICS.
880 * script.cc (OutputLog::OutputLog): Call io_stream::mkpath_p with 0755
881 mode. Open file with FILE_FLAG_BACKUP_SEMANTICS.
882 * win32.cc (SetPosixPerms): New function to set POSIX-like permissions.
883 (nt_sec): New global NTSecurity variable.
884 (NTSecurity::setDefaultDACL): Open token with TOKEN_ADJUST_PRIVILEGES.
885 (NTSecurity::setDefaultSecurity): Enable SE_BACKUP_NAME and
886 SE_RESTORE_NAME privileges if available.
887 * win32.h (SetPosixPerms): Add prototype.
888 (class NTSecurity): Make everyOneSID and administratorsSID public.
889 (nt_sec): Declare.
890
65288dc7
CV
8912008-08-14 Corinna Vinschen <corinna@vinschen.de>
892
893 * mount.cc (unconvert_slashes): New inline function.
894 (skip_ws): New inline function.
895 (find_ws): New inline function.
896 (conv_fstab_spaces): New inline function.
897 (from_fstab_line): New function to read single line from fstab file.
898 (from_fstab): New function to read /etc/fstab file and fill mount
899 table.
900 (read_mounts_nt): Call from_fstab after getting setup/rootdir from
901 registry. Only call add_usr_mnts if no fstab file found.
902
1ae1adf7
CV
9032008-08-13 Corinna Vinschen <corinna@vinschen.de>
904
905 * install.cc (Installer::installOne): Skip 46 bytes type tar package
906 silently.
907
53d33c5d
CV
9082008-08-13 Corinna Vinschen <corinna@vinschen.de>
909
910 * install.cc (Installer::installOne): Use MoveFileExW on NT. Special
911 case for bug in Windows 2000.
912 * package_meta.cc (packagemeta::uninstall): Use wide char file functions
913 on NT.
914 * win32.h (VersionInfo::major): New method.
915 (VersionInfo::minor): New method.
916 (OSMajorVersion): Define.
917 (OSMinorVersion): Define.
918
2f0315ad
CV
9192008-08-12 Corinna Vinschen <corinna@vinschen.de>
920
921 Revamp for Cygwin 1.7.
922 * desktop.cc (make_cygwin_bat): Use wide char file functions on NT.
923 (save_icon): Ditto.
924 * filemanip.cc (tfx_chars): New char table for wide char transformation
925 of reserved FS chars to UNICODE private use area.
926 (transform_chars): New static function.
927 (mklongpath): New function to convert multibyte path to wide char
928 path with long path prefix.
929 * filemanip.h (mklongpath): Declare.
930 * ini.h (SETUP_INI_FILENAME): Use setup.ini filenames as defined in
931 real life (setup-2.ini/setup.ini).
932 (SETUP_BZ2_FILENAME): Ditto.
933 * install.cc (do_install_thread): Don't create registry mount points
934 on NT, rather create setup/rootdir entry.
935 * io_stream_cygfile.cc: Throughout use wide char file functions on NT.
936 (io_stream_cygfile::w_str): New method to create wide char path.
937 * io_stream_cygfile.h (class io_stream_cygfile): Remove lmode member.
938 Add wname member and w_str method.
939 * io_stream_file.cc: Throughout use wide char file functions on NT.
940 (io_stream_file::w_str): New method to create wide char path.
941 * io_stream_file.h (class io_stream_file): Remove lmode member.
942 Add wname member and w_str method.
943 * mkdir.cc (mkdir_p): Use wide char file functions on NT.
944 * mklink2.cc (mkcygsymlink_9x): Rename from mkcygsymlink. Make static.
945 (mkcygsymlink_nt): New static function.
946 (mkcygsymlink): Just call mkcygsymlink_9x or mkcygsymlink_nt dependent
947 on OS.
948 * mount.cc (CYGWIN_INFO_CYGWIN_SETUP_REGISTRY_NAME): Define.
949 (remove1): Move to earlier point in file to avoid declaration.
950 (remove_mount): Ditto. Make static.
951 (create_install_root): New function to create setup/rootdir registry
952 value on NT.
953 (read_mounts_9x): Rename from read_mounts. Make static. Conditionalize
954 for OS.
955 (add_usr_mnts): New static function.
956 (read_mounts_nt): Ditto, to read mounts on NT.
957 (read_mounts): Just call read_mounts_nt or read_mounts_9x dependent on
958 OS.
959 (set_root_dir): On NT, call read_mounts.
960 (cygpath): Only add slash for non-root mount to avoid multiple slashes
961 in resulting path (invalid in long path names).
962 * mount.h (find_mount): Drop declaration.
963 (remove_mount): Ditto.
964 (create_install_root): Add declaration.
965 (read_mounts): Accommodate new parameter.
966 * package_db.cc (chosen_db_task): New global variable.
967 * package_db.h (chosen_db_task): Declare.
968 * root.cc (check_if_enable_next): Don't use get_root_dir here to
969 avoid having to call save_dialog in RootPage::OnMessageCmd.
970 (GetDlgItemRect): New static inline function.
971 (SetDlgItemRect): Ditto.
972 (load_dialog): On NT, stretch "Install For" block to full dialog width
973 and hide "Default Text File Type" block.
974 (save_dialog): On NT set root_text always to IDC_ROOT_BINARY.
975 (RootPage::OnMessageCmd): Remove call to save_dialog.
976 (RootPage::OnNext): Initialize packagedb here the first time, to
977 avoid fetching wrong data from different previous installation.
978 * source.cc (save_dialog): Don't initialize packagedb here, rather
979 just memorize setting in chosen_db_task for the deferred initialization
980 in RootPage::OnNext.
981
0407753c
DK
9822008-08-07 Dave Korn <dave.korn.cygwin@gmail.com>
983
984 Implement command-line selection of packages to install and make
985 unattended mode deal with any dialogs that might arise. A joint
986 effort synthesized from contributions by:
987
988 Dr. Frank Lee <rl201@cam.ac.uk>
989 Bryan Thrall <bryan.thrall@flightsafety.com>
990 Kohsuke Kawaguchi <kk@kohsuke.org>
991 Dave Korn <dave.korn.cygwin@gmail.com>
992
993 * install.cc (rebootneeded): Don't define statically here.
994 (do_install_thread): Let exit_msg reflect rebootneeded.
995 * main.cc (main): If rebootneeded, log it when exiting.
996 * msg.cc (mbox): In unattended_mode, choose and log default answer.
997 * package_db.cc (packagedb::fillMissingCategory): Iterate over all
998 packages adding those selected by packagemeta::isManuallyWanted to
999 base category so that command-line selections are installed.
1000 * package_meta.cc (PackageOption): Add new StringOption to allow
1001 command-line selection of packages to add to base install.
1002 (packagemeta::isManuallyWanted): New function tests if package was
1003 selected on command-line.
ca2b7505 1004 (packagemeta::addToCategoryBase): New function adds package to
0407753c
DK
1005 "base" category.
1006 * state.cc (rebootneeded): Define here non-static.
1007 * state.h (rebootneeded): Declare here with extern linkage.
1008 * threebar.cc (ThreeBarProgressPage::MaximizeDialog): Don't change
1009 size when running in unattended mode.
1010
da60e4b2
CF
10112008-08-05 Christopher Faylor <me+cygwin@cgf.cx>
1012
1013 * UserSettings.cc (UserSettings::settingFileForLoad): Look locally for
1014 settings before looking outside of current directory.
1015 * choose.cc (ChooserPage::ChooserPage): Record the property sheet's
1016 current show state via new passed in parameter.
1017 * choose.h (ChooserPage::ChooserPage): Reflect change in argument list.
1018 (ChooserPage::nCmdShow): Define new element.
1019 * main.cc (main): Send current show state to Chooser.
1020 * package_version.cc (packageversion::set_requirements): Increase
1021 recursion check from 5 to 30.
1022 * propsheet.cc (PropSheetWndProc): Register hwndDlg with
1023 ThreeBarProgressPage.
1024 * threebar.cc (ControlAdjuster::ControlInfo): Initialize cmd_show_set.
1025 (ThreeBarProgressPage::MaximizeDialog): New function.
1026 (ThreeBarProgressPage::OnMessageApp): Call MaximizeDialog to maximize
1027 package selection screen and restore when done.
1028 * threebar.h (ThreeBarProgressPage::MaximizeDialog): Declare function.
1029 (ThreeBarProgressPage::cmd_show_set): Declare variable.
1030 (ThreeBarProgressPage::cmd_show): Declare variable.
1031 (ThreeBarProgressPage::ins_dialog): Declare variable.
1032 (ThreeBarProgressPage::SetHwndDialog): Define function.
1033
5bb88929
CW
10342008-07-22 Charles Wilson <cygwin@cwilson.fastmail.fm>
1035
1036 Add support for .tar.lzma files (decompress only).
1037
1038 * Makefile.am: Add new files.
1039 * compress.cc (compress::decompress): add support
1040 for compress_lzma.
1041 * compress_lzma.h: new file.
1042 * compress_lzma.cc: new file.
1043 * filemanip.cc (find_tar_ext): add support for
1044 .tar.lzma files.
1045 * install.cc (Installer::installOne): update comments.
1046 * lzma-sdk/LzmaDec.h: new file.
1047 * lzma-sdk/LzmaDec.c: new file.
1048 * lzma-sdk/Types.h: new file.
1049
5bc84ff1
CW
10502008-07-08 Charles Wilson <cygwin@cwilson.fastmail.fm>
1051
1052 * compress.cc (compress::decompress): clean up concrete
1053 decompressor objects on failure -- but in that case, do
1054 NOT destroy original io_stream.
1055 * compress_bz.h (compress_bz::release_original): new method.
1056 (owns_original): new member variable.
1057 * compress_bz.cc (compress_bz::release_original): new method.
1058 (compress_bz::compress_bz): take ownership of parent by default.
ca2b7505 1059 (compress_bz::~compress_bz): only delete original if
5bc84ff1
CW
1060 owns_original is true.
1061 * compress_gz.h (compress_gz::release_original): new method.
1062 (owns_original): new member variable.
1063 * compress_gz.cc (compress_gz::release_original): new method.
1064 (compress_gz::construct): take ownership of parent by default.
ca2b7505 1065 (compress_gz::~compress_gz): only delete original if
5bc84ff1
CW
1066 owns_original is true.
1067
fe25359c
DK
10682008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
1069
1070 * configure.in, gpg-error-config-fake: Revert previous removal.
1071
586f2b08
DK
10722008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
1073
1074 * net.cc: Correct stray CRLF.
1075
8f016701
DK
10762008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
1077
1078 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Remove nasty hack.
1079 * gpg-error-config-fake: Delete file obsoleted by de-hackification.
1080
1cc1fad4
CF
10812008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
1082
1083 * configure.in: Disable shared library builds.
1084
be6622c0
CF
10852008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
1086
1087 * Makefile.am: Make and install libraries into common location and use
1088 them from there.
1089 * configure.in: Find gpg-error-config in the libgpg-error/src
1090 subdirectory rather than using the host system's version. Set the
1091 prefix and exec_prefix to a common location for the subdirs so that
1092 useful files will be installed in a common location.
1093
dbfe3c19
DK
10942008-06-22 Dave Korn <dave.korn.cygwin@gmail.com>
1095
be6622c0
CF
1096 Merged across diffs between setup_crypto_branch_branchpoint and
1097 setup_crypto_branch_mergepoint2 from setup_crypto_branch.
dbfe3c19
DK
1098
1099 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
1100 KeysSetting.h, gpg-error-config-fake, cygwin.pub, cyg-pubkey.h,
be6622c0 1101 gpg-key-to-s-expr.sh: New files.
dbfe3c19 1102 * ini.cc, ini.h, resource.h, res.rc, netio.cc, Makefile.am,
be6622c0 1103 configure.ac, libgetopt++/src/OptionSet.cc: Modified files.
dbfe3c19
DK
1104
1105 2008-06-21 Dave Korn <dave.korn.cygwin@gmail.com>
1106
ca2b7505 1107 * ini.cc (do_remote_ini): Revert misbegotten removal of
dbfe3c19
DK
1108 not-always-superfluous-after-all added slash in URLs.
1109
1110 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
1111
1112 * gpg-packet.h (GPG_KEY_SEXPR_BUF_SIZE): Move from here ...
1113 * crypto.h (GPG_KEY_SEXPR_BUF_SIZE): ... to here.
1114 (GPG_KEY_MAX_COEFF_SIZE): Add related definition.
1115
1116 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
1117
1118 * gpg-packet.cc (walk_packets_1): Check packet length field is
1119 valid sane and possible to avoid malicious manipulation.
1120 * ChangeLog: Corrected date on previous commit.
1121
1122 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
1123
ca2b7505 1124 * crypto.cc (add_key_from_sexpr): Use real buffer size, not debug
dbfe3c19
DK
1125 constant size.
1126
1127 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1128
1129 * crypto.cc (verify_ini_file_sig): Actually set init-once flag!
1130
1131 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1132
1133 * crypto.cc (KeepUntrustedKeysOption): Fix helpstring punctuation.
1134
1135 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1136
1137 * crypto.cc (verify_ini_file_sig): Fix two minor logic errors.
1138
1139 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1140
1141 * ini.h (current_ini_sig_name): Declare extern.
1142 * ini.cc (current_ini_sig_name): New variable.
1143 (NoVerifyOption): New boolean option.
1144 (do_remote_ini): If sig verification not disabled, attempt to
1145 download the matching sig file for any setup.bz2 or setup.ini
1146 and use it to verify or discard the download.
1147
1148 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1149
1150 * resource.h (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Reserve IDs for
1151 two new message strings.
1152 * res.rc (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Define the text.
1153
1154 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1155
1156 * Makefile.am (setup_SOURCES): Add new files crypto.cc, crypto.h,
1157 cyg-pubkey.h, gpg-packet.cc, gpg-packet.h. KeysSetting.cc and
1158 KeysSetting.h to the build.
1159 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
1160 KeysSetting.h: New files. Adds gpg sig verification support.
1161
1162 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1163
1164 * Makefile.am (DIST_SUBDIRS, SUBDIRS): Add libgpg-error and
1165 libgcrypt subdirs.
1166 (AM_CPPFLAGS): Add -I paths to generated headers in both and to
1167 shipped headers in libgcrypt.
1168 (setup_LDADD): Add libgpg-error.a and libgcrypt.a to final link.
1169
1170 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Preload into cache
1171 to fake out libgcrypt configure process.
1172 (AC_CONFIG_SUBDIRS): Add libgpg-error/ and libgcrypt/
1173
1174 * gpg-error-config-fake: New shell script to redirect libgcrypt
1175 sub-configure into looking for newly-built libgpg-error.
1176
1177 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1178
1179 * setup/libgpg-error/: Fresh import of upstream sources of
1180 libgpg-error-1.6.tar.bz2 from http://www.gnupg.org/
1181 * setup/libgcrypt/: Fresh import of upstream sources of
1182 libgcrypt-1.4.1.tar.bz2 from http://www.gnupg.org/
1183
1184 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1185
1186 * netio.cc (NetIO::set_url): Avoid double-free bug on delete
1187 by setting path to a strdup of url rather than using the same
1188 pointer value twice.
1189
1190 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1191
1192 * cygwin.pub: Add reference copy of Cygwin setup signing key.
1193 * gpg-key-to-s-expr.sh: New bash script. Outputs textual
1194 representation of public key in s-expr format.
1195 * cyg-pubkey.h: New header generated by the above from Cygwin
1196 setup signing key. Currently needs manual regeneration if key
1197 ever updated.
1198
2cae901b
BD
11992008-04-16 Brian Dessent <brian@dessent.net>
1200
1201 * mount.cc: Include malloc.h.
1202 (is_admin): Use alloca instead of a VLA in case
1203 GetTokenInformation is sensitive to alignment.
1204
784414bf
BD
12052008-04-15 Brian Dessent <brian@dessent.net>
1206
1207 * mount.cc (is_admin): Get explicit size of required buffer by
1208 calling GetTokenInformation first with NULL.
1209
9d44d4f7
BD
12102008-04-10 Brian Dessent <brian@dessent.net>
1211
1212 * Makefile.am (setup_LDFLAGS): Make sure static libbz2 and zlib
1213 are used.
1214
1db74bf0
BD
12152008-04-09 Brian Dessent <brian@dessent.net>
1216
1217 * README: flex and bison are required when building from CVS.
1218
09aa7d89
BD
12192008-04-08 Brian Dessent <brian@dessent.net>
1220
1221 * Makefile.am (snapshot): Provide default value of ${cygwinsite}
1222 if not set.
1223
60dfa7aa
BD
12242008-04-08 Brian Dessent <brian@dessent.net>
1225
1226 * Makefile.am (release): Use -f so that "make release" works
1227 when existing binaries of the same name exist.
1228
33ef69a7
BD
12292008-04-08 Brian Dessent <brian@dessent.net>
1230
1231 * res.rc (IDD_SPLASH): Update copyright years on splash page.
1232
51325df5
BD
12332008-04-08 Brian Dessent <brian@dessent.net>
1234
1235 * CHANGES: Update.
1236 * install.cc (Installer::installOne): Cope with compressed
1237 0-byte dummy packages. Fix progress bar update bug introduced
1238 in earlier refactoring.
1239
2e0aaec9
BD
12402008-04-08 Brian Dessent <brian@dessent.net>
1241
1242 * CHANGES: Update.
1243
12442008-04-08 Brian Dessent <brian@dessent.net>
1245
1246 Various warning/header cleanups necessary for clean gcc 4.3 build.
1247 * ConnectionSetting.cc: Include stdlib.h.
1248 * LogFile.cc: Ditto.
1249 * Makefile.am: Don't hardcode paths to MinGW libz and libbz2.
1250 * PickView.cc: Include limits.h.
1251 * String++.cc: Include string.h.
1252 * archive_tar.cc (archive_tar::next_file_name): Silence nested-if
1253 warning.
1254 * autoload.c: Switch back to .text section before emiting
1255 autoload_common.
1256 * choose.cc: Include stdlib.h and algorithm.
1257 * compress_gz.cc: Include memory.h and malloc.h.
1258 * filemanip.cc: Include string.h.
1259 (parse_filename): Silence nested-if warning.
1260 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Silence warning.
1261 * package_db.cc: Include algorithm.
1262 * site.cc (get_site_list): Silence warning.
1263 * win32.cc: Include memory.
1264 * csu_util/MD5Sum.cc: Include string.h.
1265
d0355815 12662008-03-02 Dave Korn <dave.korn@artimi.com>
4e6c8d9e 1267
d0355815 1268 * install.cc (Installer::installOne): Accept new HWND argument
4e6c8d9e
DK
1269 from caller and pass it to MessageBox calls so that MB_TASKMODAL
1270 can work.
1271 (check_for_old_cygwin): Likewise.
1272 (do_install_thread): Pass owner's HWND (from thread context) when
1273 calling them.
1274
84ea7bd6
DK
12752008-02-23 Dave Korn <dave.korn@artimi.com>
1276
1277 * cygpackage.cc (cygpackage::getfirstfile): Guard against trying to
1278 construct std::string from NULL returned by io_stream::gets when the
1279 stream decompressor fails on a corrupt *.lst.gz file.
1280
22ade75c
DK
12812008-02-21 Dave Korn <dave.korn@artimi.com>
1282
1283 * geturl.cc (progress): Correct SI unit notation.
1284
b612bff1
DK
12852008-02-01 Vincent Privat <vincent.privat@gmail.com>
1286
1287 * net.cc (OnInit): New StringOption (ProxyOption)
1288 This new option (-p) allows to call setup.exe with a proxy
1289 in its command-line arguments.
1290
a81fbc25
BD
12912007-07-31 Brian Dessent <brian@dessent.net>
1292
1293 * ini.cc (do_remote_ini): Fix crash due to double free of ini_file.
1294
92ef6cf8
BD
12952007-07-30 Brian Dessent <brian@dessent.net>
1296
1297 * CHANGES: Update.
1298 * configure.in (AM_INIT_AUTOMAKE): Enable more automake warnings.
1299 * Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
1300 (CLEANFILES): Add. Minor portability tweaks.
1301 * tests/Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
1302 * archive.cc (archive::extract): Try to be more compatible when
1303 opening tar files.
1304 * compress_bz.cc: Fix whitespace throughout.
1305 (compress_bz::~compress_bz): Ensure that underlying io_stream's dtor is
1306 also run.
1307 * install.cc (Installer::installOne): Refactor.
1308 * package_db.cc (ConnectedLoopFinder::doIt): Move some log spewage into
1309 setup.log.full from setup.log.
1310 (packagedb::connectedBegin): Ditto. Consolidate log output to one line.
1311
0a0203db
BD
13122007-07-02 Brian Dessent <brian@dessent.net>
1313
1314 * CHANGES: Update.
1315
475ee6a3
BD
13162007-06-26 Brian Dessent <brian@dessent.net>
1317
1318 * Makefile.am (release): Drop inconsistent use of $(EXEEXT). Leave an
1319 untouched copy of setup.exe so that later make invocations don't
1320 unnecessarily rebuild it.
1321 (snapshot): Fix typo.
1322 * install.cc (md5_one): Don't try to check packages whose
1323 pkgsource.Cached () is NULL, as with those whose download failed.
1324
12dea33a
BD
13252007-06-26 Brian Dessent <brian@dessent.net>
1326
1327 * CHANGES: Update to reflect release branch.
1328
13292007-06-26 Brian Dessent <brian@dessent.net>
812cdd92
BD
1330
1331 * CHANGES: Make current.
1332
feee2f2b
BD
13332007-05-30 Brian Dessent <brian@dessent.net>
1334
1335 * find.h (class Find): Make _start_dir non-const.
1336 * find.cc (Find::Find): Append a trailing slash to _start_dir only if
1337 it does not already contain one.
1338 (Find::accept): Use the previously stored value of _start_dir rather
1339 than unconditionally appending a slash.
1340
b941c8be
BD
13412007-05-29 Brian Dessent <brian@dessent.net>
1342
1343 * Makefile.am: No need to specify the default value of --preprocessor
1344 to windres. Rework the automatic version extraction rules so that the
1345 source tarball is generated with the proper name and directory instead
1346 of setup-0. Update snapshot rule to also upload a copy of the binary
1347 with debugging symbols still present.
1348
dacb1ebd
BD
13492007-05-29 Brian Dessent <brian@dessent.net>
1350
1351 This is a general tidying up/modernization of the build infrastructure.
1352 Renaming the lexer and parser to .ll and .yy allows using automake's
1353 builtin support for flex and bison with C++ sources, and libinilex is a
1354 slightly cleaner way of omitting -Werror.
1355
1356 * Makefile.am (AUTOMAKE_OPTIONS): Move to AM_INIT_AUTOMAKE.
1357 (AM_YFLAGS): Define.
1358 (AM_LFLAGS): Define.
1359 (INCLUDES): Remove redundant mingw directory.
1360 (EXTRA_DIST): Adjust for newly named lexer/parser.
1361 (BUILT_SOURCES): Ditto.
1362 (inilint_LDADD): Ditto.
1363 (inilint_SOURCES): Ditto.
1364 (setup_LDADD): Ditto.
1365 (setup_SOURCES): Ditto.
1366 (iniparse.cc): Remove custom rules.
1367 (inilex.cc): Ditto.
1368 * configure.in: Update quoting and use modern form of AC_INIT and
1369 AM_INIT_AUTOMAKE.
1370 * inilex.l: Rename from this ...
1371 * inilex.ll: ... to this.
1372 * iniparse.y: Rename from this ...
1373 * iniparse.yy: ... to this.
1374
eb20d728
BD
13752007-05-29 Brian Dessent <brian@dessent.net>
1376
1377 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
1378 Remove error_buf and error_count initializers.
1379 (IniParseFindVisitor::visitFile): Store filename in current_ini_name.
1380 Use yyerror_count and yyerror_messages in place of removed error_count
1381 and error_buf members.
1382 * IniParseFindVisitor.h (class IniParseFindVisitor): Remove error_buf
1383 and error_count members.
1384 * ini.cc: Include io_stream_memory.h. Remove file static variables
1385 error_buf, error_count, and ini_filename.
1386 (GuiParseFeedback::progress): Remove some verbose log spam.
1387 (do_remote_ini): Recode .ini-fetching logic to properly display parse
1388 errors, and to account for corrupt bzip2 files.
1389 (yyerror): Moved elsewhere.
1390 (fprintf): Delete unused function.
1391 * ini.h: Remove useless __cplusplus guard. Declare extern variables
1392 current_ini_name, yyerror_messages, and yyerror_count.
1393 * inilex.l: Add current_ini_name, yyerror_messages, and
1394 yyerror_count.
1395 (ini_init): Initialize new variables.
1396 (yybol): Delete.
1397 (yyerror): Reimplement using std::string and relocate from ini.cc.
1398 * io_stream.cc (io_stream::copy): Add clarifying comment.
1399
6c8daadf
IP
14002007-05-04 Igor Peshansky <pechtcha@cs.nyu.edu>
1401
1402 * resource.h (IDC_STATIC_HEADER): New control id.
1403 * res.rc (IDD_SPLASH): Adjust the copyright.
1404 (IDD_DESKTOP): Make header text accessible as a separate control.
1405 * desktop.cc (set_status): Use eset() instead of SetWindowText().
1406 (load_dialog): Disable checkboxes and change dialog text in
1407 download-only mode.
1408 (DesktopSetupPage::OnInit): Disable checkboxes in download-only
1409 mode.
1410 * threebar.cc (ThreeBarProgressPage::OnMessageApp): Deprecate the
1411 default fallthrough.
1412 * download.cc (do_download_thread): Explicitly return the next
1413 dialog.
1414
f8dcce01
MB
14152007-04-19 Max Bowsher <maxb1@ukf.net>
1416
1417 * configure.in: Turn inilint default build off again, since I cannot
1418 get it to work.
1419
6b457e67
MB
14202007-04-19 Max Bowsher <maxb1@ukf.net>
1421
54ac354e
MB
1422 * configure.in: Make inilint built by default.
1423
14242007-04-19 Max Bowsher <maxb1@ukf.net>
1425
1426 * inilintmain.cc: Fix multiple compile errors.
6b457e67 1427
86e53214
MB
14282007-04-19 Max Bowsher <maxb1@ukf.net>
1429
1430 * Makefile.am: Make inilint use same warnonly-inilex workaround that
1431 setup already does.
1432
7b21a88e
IP
14332007-03-29 Igor Peshansky <pechtcha@cs.nyu.edu>
1434
1435 * LogFile.cc (LogFile::exit): Write exit_msg directly to log, without
1436 the message box.
1437 * resource.h (IDC_DESKTOP_SEPARATOR,IDC_STATUS_HEADER,IDC_STATUS): New
1438 control ids.
1439 * res.rc (IDD_DESKTOP): Change the caption. Add status information.
1440 * desktop.h (DesktopSetupPage::DesktopSetupPage): Define constructor
1441 in the implementation.
1442 * desktop.cc (DesktopControlsInfo): Position specifiers for status
1443 information items.
1444 (DesktopSetupPage::DesktopSetupPage): Register position specifiers.
1445 (set_status): New static method.
1446 (load_dialog): Set status information, if available.
1447 (DesktopSetupPage::OnInit): Set status header font.
1448
909f5cf9
BD
14492007-03-01 Brian Dessent <brian@dessent.net>
1450
1451 * ini.h (SETUP_INI_FILENAME): Rename setup_9x.ini to setup_legacy.ini.
1452 (SETUP_BZ2_FILENAME): Likewise.
1453
5072c0bb
BD
14542007-02-27 Brian Dessent <brian@dessent.net>
1455
1456 * ini.h (SETUP_INI_FILENAME): Add define.
1457 (SETUP_BZ2_FILENAME): Add define.
1458 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use
1459 above macros to parameterize setup.ini filename.
1460 * fromcwd.cc (SetupFindVisitor::visitFile): Ditto.
1461 * ini.cc (do_remote_ini): Ditto.
1462 * Makefile.am (setup_SOURCES): Add win32.cc.
1463 * autoload.c: Include windows.h directly instead of win32.h so that
1464 win32.h can contain C++.
1465 * desktop.cc (verinfo): Delete.
1466 (make_link): Use IsWindowsNT to check for NT instead of verinfo.
1467 (DesktopSetupPage::OnInit): Likewise.
1468 * mount.cc (is_admin): Likewise.
1469 * script.cc (init_run_script): Likewise.
1470 * main.cc (class SIDWrapper, SIDWrapper::SIDWrapper,
1471 SIDWrapper::~SIDWrapper, SIDWrapper::theSID, class HANDLEWrapper,
1472 HANDLEWrapper::HANDLEWrapper, HANDLEWrapper::~HANDLEWrapper,
1473 HANDLEWrapper::theHANDLE, class TokenGroupCollection,
1474 TokenGroupCollection::TokenGroupCollection,
1475 TokenGroupCollection::~TokenGroupCollection,
1476 TokenGroupCollection::populate, TokenGroupCollection::find,
1477 class NTSecurity, set_default_sec, NTSecurity::NoteFailedAPI,
1478 NTSecurity::NTSecurity, NTSecurity::failed,
1479 NTSecurity::initialiseEveryOneSID, NTSecurity::setDefaultDACL,
1480 NTSecurity::setDefaultSecurity): Remove implementation of these
1481 classes from this file and into new file win32.cc and existing win32.h.
1482 (main): Fix whitespace and formatting per GNU coding standards.
1483 * res.rc (IDS_SETUPINI_MISSING): Parameterize filename with %s.
1484 * win32.cc: New file containing methods removed from main.cc as well
1485 as new class VersionInfo methods.
1486 * win32.h: Include <string> for std::string.
1487 (class SIDWrapper, class HANDLEWrapper, class TokenGroupCollection,
1488 class NTSecurity): Add classes removed from main.cc.
1489 (class VersionInfo): Add new class.
1490 (GetVer): Declare.
1491 (IsWindowsNT): Define.
1492
5cc32375
BD
14932007-02-20 Brian Dessent <brian@dessent.net>
1494
1495 * README: Modernize list of required packages, and mention doconfigure.
1496
5ef77c46
BD
14972007-02-17 Cesar Strauss <cstrauss@cea.inpe.br>
1498
3c1254b9
MB
1499 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
1500 Initialize the version and operator fields of the newly created
1501 PackageSpecification object, so setup can pick the correct source
1502 version later on.
5ef77c46 1503
a875b471
BD
15042007-02-17 Brian Dessent <brian@dessent.net>
1505
1506 * script.cc (Script::run): Check for existance of script file and
1507 return without doing anything if it does not exist.
1508
3a694862
MB
15092006-12-26 Max Bowsher <maxb1@ukf.net>
1510
1511 * IniDBBuilder.h (IniDBBuilder): Make this class abstract.
1512 * IniDBBuilder.cc: Delete file.
1513 * Makefile.am (inilint_SOURCES, setup_SOURCES): Remove IniDBBuilder.cc.
1514
be8736e4
MB
15152006-12-26 Max Bowsher <maxb1@ukf.net>
1516
1517 Add a shell script that documents/centralizes the standard configure
1518 command line.
1519
1520 * doconfigure: New file.
1521 * Makefile.am (EXTRA_DIST): Add doconfigure.
1522
cafda414
IP
15232006-11-28 Igor Peshansky <pechtcha@cs.nyu.edu>
1524
1525 * install.cc (Installer::installOne): If file is in use, ask the user
1526 to stop processes and retry.
1527 (MB_RETRYCONTINUE, IDCONTINUE): New macros.
1528 (hMsgBoxHook): New static field.
1529 (CBTProc): New window hook function.
1530 (_custom_MessageBox): New function.
1531 * CHANGES: Update with the above.
1532
effce34d
IP
15332006-10-12 Igor Peshansky <pechtcha@cs.nyu.edu>
1534
1535 * desktop.cc (make_cygwin_bat,save_icon): Capitalize filename.
1536
7dc7a0a4
BD
15372006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1538
1539 * package_version.cc (packageversion::scan): Catch and handle
1540 validation exception.
1541
0ec7cbc9
BD
15422006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1543
1544 * cygpackage.h (filesize): Remove unused field.
1545 (cygpackage::createInstance): Ditto.
1546 * cygpackage.cc (cygpackage::createInstance): Ditto.
1547 * package_db.cc (packagedb::packagedb): Remove unused variables.
1548 Simplify parsing of installed.db.
1549
c861f482
BD
15502006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1551
1552 * desktop.cc (DesktopSetupPage::OnInit): Remove stray MessageBox.
1553
3d4c5ebb
IP
15542006-05-24 Igor Peshansky <pechtcha@cs.nyu.edu>
1555
1556 * PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView.
1557 * PickView.h (PickView::DrawIcon): Move from PickPackageLine.
1558 (PickView::icon_dc,PickView::bm_icon): New instance field.
1559 (PickView::rect_icon,PickView::bg_fg_brush): Ditto.
1560 * PickCategoryLine.cc (PickCategoryLine::paint): Use
1561 PickView::DrawIcon() instead of BitBlt().
1562 * PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView.
1563 (PickPackageLine::paint): Use PickView::DrawIcon().
1564 * PickView.cc (PickView::~PickView): Delete GDI objects.
1565 (PickView::init): Create icon drawing context.
1566 (PickView::DrawIcon): New function. Use system default colors to
1567 draw bitmaps.
1568 (PickView::paint): Set background color instead of using transparent
1569 mode. Create system-colored brush.
1570
ba2559db
BD
15712006-04-25 Brian Dessent <brian@dessent.net>
1572
1573 * COPYING: New file (GPL).
1574 * Makfile.am (EXTRA_DIST): Add COPYING.
1575
5f9ac473
MB
15762006-04-17 Max Bowsher <maxb1@ukf.net>
1577
1578 * String++.cc, String++.h: Finally, it's time for the long-awaited
1579 departure of 'class String' from this world. setup.exe can now
1580 happily claim to follow the sane path of using just one general
1581 purpose string class throughout :-)
1582
02d06553
MB
15832006-04-17 Max Bowsher <maxb1@ukf.net>
1584
1585 * cygpackage.cc, cygpackage.h, package_version.cc, package_version.h:
1586 Do some String to std::string migration.
1587
1eb2461a
MB
15882006-04-17 Max Bowsher <maxb1@ukf.net>
1589
1590 * package_meta.cc, package_meta.h, package_source.cc,
1591 package_source.h: Do some String to std::string migration.
1592 * package_db.cc: Small tweak to assist with the above.
1593
d19f12fd
MB
15942006-04-17 Max Bowsher <maxb1@ukf.net>
1595
1596 * PickView.cc, PickView.h, package_db.cc, package_db.h:
1597 Do some String to std::string migration.
1598 * package_meta.h: Change a couple of types to assist with the above.
1599
9b0876b3
MB
16002006-04-17 Max Bowsher <maxb1@ukf.net>
1601
1602 * IniDBBuilder.cc, IniDBBuilder.h, IniDBBuilderPackage.cc,
1603 IniDBBuilderPackage.h, PickLine.h, PickPackageLine.cc:
1604 Do some String to std::string migration.
1605
fd93eff9
MB
16062006-04-16 Max Bowsher <maxb1@ukf.net>
1607
1608 * FindVisitor.cc, FindVisitor.h, IniParseFindVisitor.cc,
1609 IniParseFindVisitor.h, ScanFindVisitor.cc, ScanFindVisitor.h, find.cc,
1610 find.h, fromcwd.cc, ini.cc, ini.h, iniparse.y, postinstall.cc:
1611 Do some String to std::string migration.
1612
a3a02820
MB
16132006-04-16 Max Bowsher <maxb1@ukf.net>
1614
1615 * IOStreamProvider.h, archive.cc, archive.h, archive_tar.cc,
1616 archive_tar.h, io_stream.cc, io_stream.h, io_stream_cygfile.cc,
1617 io_stream_cygfile.h, io_stream_file.cc, io_stream_file.h:
1618 Do some String to std::string migration.
1619
2bba98e8
MB
16202006-04-16 Max Bowsher <maxb1@ukf.net>
1621
1622 * desktop.cc, download.cc, install.cc, mount.cc, mount.h, script.cc,
1623 script.h: Do some String to std::string migration.
1624
ee4ad3a7
MB
16252006-04-16 Max Bowsher <maxb1@ukf.net>
1626
1627 * category.cc: Remove source file that contained no code!
1628 * category.h: Delete, moving the single useful line to...
1629 * package_meta.h: ...here. Remove category.h include.
1630 * choose.cc, package_db.h, package_meta.cc: Remove category.h include.
1631 * Makefile.am: Remove references to removed files.
1632
08678720
MB
16332006-04-15 Max Bowsher <maxb1@ukf.net>
1634
1635 * ConnectionSetting.cc, ConnectionSetting.h, Exception.cc,
1636 Exception.h, IniParseFeedback.cc, IniParseFeedback.h, LogFile.cc,
1637 LogFile.h, LogSingleton.h, PackageSpecification.cc,
1638 PackageSpecification.h, SourceSetting.cc, SourceSetting.h,
1639 UserSettings.cc, UserSettings.h, dialog.cc, dialog.h, diskfull.cc,
1640 diskfull.h, filemanip.cc, filemanip.h, inilintmain.cc, localdir.cc,
1641 main.cc, nio-file.cc, nio-http.cc, prereq.cc, prereq.h, proppage.cc,
1642 proppage.h, site.cc, site.h, splash.cc, state.cc, state.h, window.cc,
1643 window.h: Do some String to std::string migration.
1644
cb026227
MB
16452006-04-15 Max Bowsher <maxb1@ukf.net>
1646
1647 * String++.cc, String++.h
1648 (new_cstr_char_array, format_1000s): Migrate String to std::string.
ca2b7505 1649 (casecompare_lt_op, std::string operator+): New.
cb026227 1650
470f4928
MB
16512006-04-06 Max Bowsher <maxb1@ukf.net>
1652
1653 * String++.h, String++.cc
1654 (String::replace): Remove - usused.
1655 (String::find): Remove - semantics do not match std::string.
1656
1657 * root.cc (directory_is_rootdir): Switch to std::string.find().
1658 * script.cc (Script::baseName): Rewrite use of String.find().
1659
2b791966
MB
16602006-03-30 Max Bowsher <maxb1@ukf.net>
1661
1662 * String++.cc (replace): New function to take the place of one form
1663 of String::replace method.
1664 * String++.h (replace): Declare.
1665 (String::replace): Make private.
1666
1667 * desktop.cc (make_cygwin_bat): Use new function.
1668 * filemanip.cc (backslash): Use simple loop in place of
1669 String::replace.
1670 * filemanip.h (backslash): Change signature to use std::string in
1671 place of String.
1672
afa76033
MB
16732006-03-30 Max Bowsher <maxb1@ukf.net>
1674
1675 * String++.cc, String++.h (casecompare): New function replacing
1676 String.casecompare to increase parity with std::string.
1677 (String::casecompare): Make private.
1678
1679 * ConnectionSetting.cc, IniDBBuilderPackage.cc,
1680 IniParseFindVisitor.cc, LogFile.cc, PackageSpecification.cc,
1681 PickView.cc, SourceSetting.cc, String++.cc, String++.h, fromcwd.cc,
1682 io_stream.cc, mount.cc, package_db.cc, package_source.h,
1683 package_version.cc, prereq.h, script.cc:
1684 Use casecompare in place of String::casecompare.
1685
8300be9c
MB
16862006-03-30 Max Bowsher <maxb1@ukf.net>
1687
1688 * String++.cc, String++.h: Remove String(int) constructor, which
1689 was causing dangerously bizarre implicit conversions, and was a point
1690 of disparity between String and std::string.
1691 (stringify): New function to replace functionality removed above.
1692
1693 * PickView.cc (PickView::init_headers),
1694 archive_tar.cc (archive_tar::next_file_name),
1695 cygpackage.cc (cygpackage::setCanonicalVersion):
1696 Make explicit and call out with a FIXME some bizarre behaviour.
1697
1698 * ScanFindVisitor.cc (ScanFindVisitor::visitFile),
1699 filemanip.cc (base), iniparse.y,
1700 threebar.cc (ThreeBarProgressPage::SetBar2):
1701 Make simple adaptations to the changed API.
1702
7c593196
IP
17032006-03-14 Igor Peshansky <pechtcha@cs.nyu.edu>
1704
1705 * PickView.cc (PickView::setViewMode): Auto-expand category if
1706 its name starts with a dot.
1707
3dbb54fc
DK
17082006-03-14 Dave Korn <dave.korn@artimi.com>
1709
1710 * String++.cc (new_cstr_char_array): Handle null input correctly.
1711
e5e2eba8
CF
17122006-03-10 Christopher Faylor <cgf@timesys.com>
1713
1714 * res.rc: Update copyright.
1715 (IDS_MIRROR_LST): Use cygwin.com for mirror list, not
1716 sources.redhat.com.
e5e2eba8 1717 * site.cc (NOSAVE1): Use preferred name of sourceware site.
4f41c01c 1718 (NOSAVE2): sourceware.cygnus.com -> sources.redhat.com.
e5e2eba8
CF
1719 (NOSAVE1_LEN): Use just-defined name to determine length.
1720 (NOSAVE2_LEN): Ditto.
1721 (NOSAVE3_LEN): Ditto.
1722
17232006-03-10 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1724
1725 * res.rc (IDD_DROPPED): New dialog.
1726 * resource.h (IDD_DROPPED): New dialog-id.
1727 (IDC_DROP_MIRRORS, IDC_DROP_NOWARN): New control-ids.
1728 * site.cc: Add enum for response on dropped mirrors.
1729 (cache_is_usable, cache_needs_writing): New bools.
1730 (cache_warn_urls): New string.
1731 (cached_site-list, dropped_site_list): New SiteLists.
1732 (site_list_type::init, site_list_type::site_list_type): Change to four
1733 parameter form.
1734 (site_list_type::site_list_type, site_list_type::operator=) Copy
1735 servername, area and location.
1736 (load_site_list): New function, broken out of get_site_list. Support
1737 four-parameter site_list_type.
1738 (get_site_list): Break out load_site_list. Move reading cache earlier.
1739 Don't write new cache. Set flags to record cache state. Load both
1740 all_site_list and cached_site_list.
1741 (SiteSetting::registerSavedSite): Use four-parameter site_list_type.
1742 (drop_proc, check_dropped_mirrors, write_cache_list, save_cache_file):
1743 New functions.
1744 (SitePage::OnNext): Check for dropped mirrors and save cache as
1745 appropriate.
1746 (SitePage::OnMessageCmd): Use four-parameter site_list_type.
1747 * site.h
1748 (site_list_type::init, site_list_type::site_list_type): Change to four
1749 parameter form.
1750 (site_list_type): Add servername, area and location members.
1751
b2b35a6e
IP
17522006-03-09 Igor Peshansky <pechtcha@cs.nyu.edu>
1753
1754 * script.cc (Script::run): Fix inverted test for abnormal exit.
1755
966a9815
MB
17562006-03-09 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1757 Max Bowsher <maxb1@ukf.net>
1758
1759 Provide indication of site that a file is being downloaded from.
1760
1761 * geturl.cc: Use std::string instead of String throughout.
1762 (init_dialog): Put more information into GUI.
1763 Remove unused 'owner' parameter and change all callers.
1764 (progress): Remove spurious \n characters from GUI.
1765 * geturl.h: Use std::string instead of String throughout.
1766 * res.rc (IDD_INSTATUS): Use SS_ENDELLIPSIS.
1767
8e91c2fb
MB
17682006-03-09 Max Bowsher <maxb1@ukf.net>
1769
1770 * Makefile.am (EXTRA_DIST): Add tree-minus.bmp and tree-plus.bmp.
1771
bb810dd8
DK
17722006-01-20 Bryan Thrall <bryan.thrall@flightsafety.com>
1773
1774 * source.cc (SourcePage::OnActivate): Command line takes precedence
1775 over last user selection.
1776
253585ba
MB
17772005-11-30 Max Bowsher <maxb1@ukf.net>
1778
1779 * res.rc (IDD_ROOT, IDD_LOCAL_DIR): Rearrange some controls a little,
1780 in response to suggestion from Carl Karsten.
1781
d60832c6
MB
17822005-11-30 Max Bowsher <maxb1@ukf.net>
1783
1784 * site.h, site.cc: Use std::string in preference to String.
1785 (site_list_type::init): Convert some painful raw C string work to
1786 STL std::string work. Stop totally ignoring the result of this
1787 calculation, implementing the (somewhat weird) sort order for sites
1788 that was apparently indented for ages.
1789
3d3c6047
IP
17902005-10-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1791
1792 * io_stream.cc (url_scheme_not_registered): New macro.
1793 (io_stream::open): Better log message on error.
1794 (io_stream::mkpath_p,io_stream::remove,io_stream::mklink): Ditto.
1795 (io_stream::move,io_stream::exists): Ditto.
1796
b059e20b
IP
17972005-10-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1798
1799 * site.cc (get_site_list): Default to empty mirror list if
1800 server unavailable and none cached, to allow using preferred
1801 mirrors anyway.
1802
82573872
IP
18032005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1804
1805 * package_db.cc (packagedb::packagedb): Remember missing package
1806 database file.
1807
9237e1bb
IP
18082005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1809
1810 * site.cc (get_site_list): Store mirror list locally.
1811 Use local copy if unable to download.
1812
a8be3f13
IP
18132005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1814
1815 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
1816 Better log message on error.
1817
2a8125be
IP
18182005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1819
bd3a38c7 1820 * script.cc (Script::isAScript): Fix string comparison.
2a8125be 1821
01b9378a
IP
18222005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1823
1824 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Reconnect on FTP timeout.
1825
65ce9baf
BD
18262005-09-11 Masayuki FUJII <boochang@m4.kcn.ne.jp>
1827
1828 * package_meta.cc (packagemeta::ScanDownloadedFiles): Don't use an
1829 invalid iterator. Fix whitespace.
1830
3f6926b1
BD
18312005-09-09 Brian Dessent <brian@dessent.net>
1832
1833 * CHANGES: Document recent updates.
1834 * choose.cc (ChooserPage::OnInit): Add new tooltip.
1835 * res.rc (IDD_CHOOSE): Remove 'administrative' from description.
1836 (IDS_HIDEOBS_TOOLTIP): Add new string for tooltip.
1837 * resource.h (IDS_HIDEOBS_TOOLTIP): Define.
1838 * window.cc (Window::ActivateTooltips): Fix whitespace. Set tooltip
1839 delay to 30 seconds.
1840
9dda7744
BD
18412005-09-09 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1842
1843 * PickView.cc (PickView::paint): Set background mode to transparent.
1844 * PickCategoryLine.cc (PickCategoryLine::paint): Use bitwise AND to
1845 blit bitmaps.
1846 * PickPackageLine.cc (PickPackageLine::paint): Ditto.
1847
534c25cc
BD
18482005-09-01 Brian Dessent <brian@dessent.net>
1849
1850 * package_meta.cc (packagemeta::uninstall): Remove support for
1851 undocumented and dangerous postremove script.
1852
18532005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1854
1855 * script.cc (run): Change to return the exit code or negative error.
1856 (Script::run): Ditto.
1857 (try_run_script): Receive both filename and extension and run only
1858 one script. Also return the exit code.
1859 * script.h (try_run_script): Change signature.
1860 (Script::run): Ditto.
1861 * postinstall.cc (RunScript::operator()): Change to return the exit
1862 code or negative error.
1863 * install.cc (Installer::preremoveOne): Pass extension to
1864 try_run_script().
1865
18662005-09-01 Eric Blake <ebb9@byu.net>
1867
1868 * script.cc (shells): Use /bin/bash, not sh, to allow upgrades to
1869 /bin/sh.
1870
0ac305ec
BD
18712005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1872
1873 * PickView.h (PickView::size_col): New instance variable.
1874 * PickView.cc (pkg_headers, cat_headers): Add size column.
1875 (PickView::set_headers): Initialize size_col.
1876 (PickView::init_headers): Include width of size column.
1877 * PickPackageLine.cc (PickPackageLine::paint): Handle size_col.
1878 * String++.cc (format_1000s): New function.
1879 * String++.h (format_1000s): Declare new function.
1880
aa62e0f3
BD
18812005-09-01 Brian Dessent <brian@dessent.net>
1882
1883 * Makefile.am (BASECXXFLAGS): Add -Wno-uninitialized to work around
1884 spurious warnings with gcc 3.4.4.
1885
687dd890
BD
18862005-05-22 Brian Dessent <brian@dessent.net>
1887
1888 * res.rc (IDD_CHOOSE): Change description to include administrative
1889 packages in addition to obsolete.
1890
82306ac2
BD
18912005-05-21 Brian Dessent <brian@dessent.net>
1892
1893 * prereq.cc: New file.
1894 * prereq.h: Ditto.
1895 * tree-minus.bmp: Ditto.
1896 * tree-plus.bmp: Ditto.
1897 * Makefile.am: Add prereq.cc and prereq.h to build.
1898 * PickCategoryLine.cc (PickCategoryLine::paint): Add new parameter and
1899 refactor. Use bitmap for '+' and '-' indicators. Draw package lines
1900 column-wise for better drawing efficiency.
1901 (PickCategoryLine::click): Use previously calculated x value.
1902 * PickCategoryLine.h (PickCategoryLine::paint): Update prototype. Add
1903 'spin_x' member.
1904 * PickLine.h (PickLine:paint): Update prototype.
1905 * PickPackageLine.cc (PickPackageLine::DrawCheck): Remove.
1906 (PickPackageLine::DrawIcon): New function.
1907 (PickPackageLine::paint): Add parameter. Refactor completely for more
1908 efficient painting.
1909 * PickPackageLine.h (PickPackageLine::DrawIcon): Add prototype.
1910 (PickPackageLine::paint): Update prototype.
1911 (PickPackageLine::DrawCheck): Remove.
ca2b7505 1912 * PickView.cc (pkg_headers): Remove unused 'slen' field, add new
82306ac2 1913 'needs_clip' field to signify if clipping is necessary for this column.
ca2b7505 1914 (PickView::note_width): Fold long line. Refactor slightly for
82306ac2
BD
1915 simplicity.
1916 (PickView::set_view_mode): Remove.
1917 (PickView::cycleViewMode): New function.
1918 (PickView::setViewMode): Refactor completely. Incorporate functionality
1919 of clear_view() here instead. Simplify package selection into a single
1920 'for' loop rather than repeating code for each type.
1921 (isObsolete): New function, with second overloaded version.
1922 (PickView::setObsolete): New function.
1923 (PickView::insert_pkg): Do not show obsolete packages. Move
1924 declaration of 'db' lower. Fix whitespace.
1925 (PickView::insert_category): Do not show obsolete packages.
ca2b7505 1926 (PickView::clear_view): Remove. Moved logic into 'setViewMode'.
82306ac2
BD
1927 (PickView::scroll): Add additional parameter 'howmany' with default
1928 value of 1. Scroll by 'howmany' lines for SB_LINEDOWN and SB_LINEUP.
1929 (NUM_CATEGORY_COL_WIDTH): Define.
1930 (PickView::init_headers): Fix whitespace. Add comments. Ignore
1931 obsolete packages in width calculations. Add functionality to size
1932 'Category' column so that at least NUM_CATEGORY_COL_WIDTH categories
1933 are displayed for every package. Ensure that 'new_col' takes into
1934 account all possible labels.
1935 (PickView::PickView): Initialize showObsolete to false.
1936 (PickView::init): Remove unused bitmap bm_rtarrow. Add new bitmaps
1937 bm_treeplus and bm_treeminus. Use a macro for better readability.
1938 Fix whitespace formatting. Remove header computation from here, call
1939 refresh() instead.
1940 (PickView::registerWindowClass): Remove unnecessary background brush.
1941 (PickView::WindowProc): Add support for WM_MOUSEWHEEL message
1942 processing. Fix indentation. Reformat for readability.
1943 (PickView::paint): Get the update region before calling BeginPaint.
1944 Fill the update region with the default colors. Do not do clipping
1945 here. Pass update region to the PickLine paint function instead.
1946 Free the update region when finished.
1947 (PickView::Create): Fix indentation.
1948 (PickView::defaultTrust): Ditto.
1949 (PickView::refresh): Add column recalculation logic here.
1950 * PickView.h: Fix indentation.
1951 (RTARROW_WIDTH): Remove unused define.
1952 (NEW_COL_SIZE_SLOP): Ditto.
1953 (TREE_INDENT): Define.
1954 (PickView::get_view_mode): Remove.
1955 (PickView::set_view_mode): Rename to setViewMode for consistency.
1956 (PickView::cycleViewMode): Add new function.
1957 (PickView::setObsolete): Ditto.
1958 (PickView::clear_view): Remove.
1959 (PickView::bm_treeplus): Define new member.
1960 (PickView::bm_treeminus): Ditto.
1961 (PickView::scroll): Add parameter.
1962 (PickView::Header::slen): Remove unused member.
1963 (PickView::Header::needs_clip): Define new member.
1964 (PickView::showObsolete): Ditto.
1965 (isObsolete): Add prototype, and for overloaded version as well.
1966 * choose.cc: Add include.
1967 (ChooserControlsInfo): Allow new checkbox to be resized.
1968 (ChooserPage::OnInit): Start dialog with 'Hide obsolete' checked.
1969 (ChooserPage::OnNext): Call the dependency checker, act accordingly.
1970 (ChooserPage::changeTrust): Notify dependency checker of current trust
1971 level when it changes.
1972 (ChooserPage::OnMessageCmd): Just call cycleViewMode instead when
1973 changing the view. Update the chooser when the user toggles the
1974 'hide obsolete' checkbox.
1975 (ChooserPage::OnMouseWheel): New function. Pass mouse wheel message
1976 on to chooser.
1977 * choose.h (OnMouseWheel): Add prototype.
1978 * main.cc: Add include.
1979 (main): Define and initialize the PrereqPage object. Add it into
1980 the property sheet list.
1981 * PropPage.cc (PropertyPage::DialogProc): Add support for WM_MOUSEWHEEL
1982 message processing in derived classes.
1983 (PropertyPage::OnMouseWheel): New function.
1984 * PropPage.h (PropertyPage::OnMouseWheel): Add prototype.
1985 * res.rc (IDD_LOCAL_DIR): Shorten edit box so that pushbutton is not
1986 crowded.
1987 (IDD_SITE): Provide static text with an ID so that it can be resized
1988 properly. Move pushbutton slightly to right so that it doesn't crowd
1989 edit box.
1990 (IDD_SPLASH): Change copyright displayed on spash screen to be generic
1991 since the actual list of contributors is long.
1992 (IDD_CHOOSE): Add checkbox. Resize other controls to accomodate.
1993 (IDD_PREREQ): New dialog.
1994 (SPIN): Delete duplicated bitmap resource.
1995 (IDB_RTARROW): Remove unused bitmap resource.
1996 (IDB_TREE_PLUS): Add.
1997 (IDB_TREE_MINUS): Ditto.
1998 (IDS_TRUSTPREV_TOOLTIP): Revise wording to be more concise.
1999 (IDS_TRUSTCURR_TOOLTIP): Ditto.
2000 (IDS_TRUSTEXP_TOOLTIP): Ditto.
2001 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
2002 * resource.h (IDD_PREREQ): Define.
2003 (IDB_RTARROW): Remove.
2004 (IDB_TREE_PLUS): Add, and renumber.
2005 (IDB_TREE_MINUS): Ditto.
2006 (IDC_SITE_USERURL): Define.
2007 (IDC_CHOOSE_HIDE): Ditto.
2008 (IDC_PREREQ_TEXT): Ditto.
2009 (IDC_PREREQ_EDIT): Ditto.
2010 (IDC_PREREQ_CHECK): Ditto.
2011 * site.cc (SiteControlsInfo): Ensure that 'User URL' static text is
2012 properly resized.
2013
846e099d
MB
20142005-05-14 Max Bowsher <maxb@ukf.net>
2015
2016 "Type" field of packageversions was not even being filled in. Fix.
2017
2018 * cygpackage.h, cygpackage.cc (cygpackage::createInstance):
2019 Make "type" a mandatory parameter of the constructor.
2020 * IniDBBuilderPackage.cc: Adjust callers.
2021
c1352375
MB
20222005-05-14 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
2023
2024 Fix behaviour of hardlinks in source packages.
2025
2026 * archive.cc (archive::extract_file):
2027 Use prefixPath for link target on hardlinks.
2028
403f1027
MB
20292005-05-14 Max Bowsher <maxb@ukf.net>
2030
2031 Hopefully, solve the "preremove DLL dependency" bug, by running all
2032 preremove scripts before actually removing any files.
2033
ca2b7505 2034 * install.cc
403f1027
MB
2035 (Installer::preremoveOne): New method. Run preremove scripts here.
2036 (Installer::replaceOne): Remove method.
2037 (num_replacements): Remove variable.
2038 (do_install_thread): Significantly rewrite.
2039 * package_meta.cc (packagemeta::uninstall):
2040 Do not run preremove script here.
2041
f916c374
MB
20422005-05-14 Max Bowsher <maxb@ukf.net>
2043
2044 * download.cc (do_download_thread):
2045 Do not use packageversion::changeRequested().
2046 * package_version.cc (packageversion::Type):
2047 Implement declared but previously unimplemented method.
2048 (packageversion::changeRequested, _packageversion::changeRequested):
2049 Remove.
2050 * package_version.h
2051 (packageversion::changeRequested, _packageversion::changeRequested):
2052 Remove.
2053 * install.cc (Installer::replaceOne): Simplify, return void, not int.
2054 (installOneSource): Rename to...
403f1027 2055 (installOne): ...this. Change arguments and return type. Refactor.
f916c374
MB
2056 (install_one): Remove.
2057 (do_install_thread): Tidying up.
2058
655310ed
MB
20592005-05-07 Max Bowsher <maxb@ukf.net>
2060
2061 * download.cc (validateCachedPackage): Remove all MD5 checking code.
2062 It is not acceptable to check MD5 sums as part of simply answering
2063 whether a package exists in the local cache or not. It is too slow.
2064 MD5 sums always have been - and will continue to be - checked at
2065 install time.
2066 (NoMD5Option): Remove this option, as the code it controls has been
2067 removed.
2068
61a9e487
MB
20692005-05-07 Max Bowsher <maxb@ukf.net>
2070
2071 * install.cc (md5_one): Make the MD5 checking done at install time
2072 display a progess GUI, as the MD5 checking done at other times does.
2073
4c90a532
MB
20742005-05-07 Max Bowsher <maxb@ukf.net>
2075
2076 * resource.h, res.rc: Followup to recent de-MSVC-ification of
2077 resource.h, by removing a lot from res.rc, and the last few bits
2078 from resource.h.
2079
9a8a04fc
BD
20802005-05-05 Brian Dessent <brian@dessent.net>
2081
37f49caf
BD
2082 * choose.cc (ChooserPage::OnInit): Initialize tooltips for this
2083 dialog.
2084
2085 * proppage.h (PropertyPage::makeClickable): Update prototype to
2086 reflect same argument name as function.
2087
2088 * proppage.cc (PropertyPage::DialogProc): Remove redundant 'break'
ca2b7505 2089 statements that follow 'return's. Add missing braces to case
37f49caf
BD
2090 statements. Call handler for TTN_GETDISPINFO.
2091
2092 * res.rc (IDS_TRUSTKEEP_TOOLTIP): Add new STRINGTABLE entry for
2093 tooltip text.
2094 (IDS_TRUSTPREV_TOOLTIP): Ditto.
ca2b7505 2095 (IDS_TRUSTCURR_TOOLTIP): Ditto.
37f49caf
BD
2096 (IDS_TRUSTEXP_TOOLTIP): Ditto.
2097 (IDS_TRUSTPREV_TOOLTIP): Ditto.
2098 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
2099
2100 * resource.h: Likewise, add identifiers for tooltip resources.
2101
2102 * window.h: Add includes.
2103 (Window::TooltipHandle): Add new private data structure.
2104 (Window::TooltipStrings): Ditto.
2105 (Window::ActivateTooltips): Define new function to support tooltip
2106 functionality.
2107 (Window::SetTooltipState): Ditto.
2108 (Window::AddTooltip): Ditto.
322281d3 2109 (Window::TooltipNotificationHandler): Ditto.
37f49caf
BD
2110
2111 * window.cc (Window::Window): Initialize handle to NULL.
2112 (Window::~Window): Call DestroyWindow on tooltip control if it was
2113 activated.
2114 (Window::ActivateTooltips): New function to activate the tooltip
2115 control.
2116 (Window::SetTooltipState): New function to allow toggling of
2117 tooltips.
2118 (Window::AddTooltip): New function that adds a tooltip to a given
2119 control in a given window. Also implement overloaded versions that
2120 provide simpler interface and the ability to use a string resource.
2121 (Window::TooltipNotificationHandler): New function to handle
2122 TTN_GETDISPINFO notification messages.
2123
21242005-05-05 Brian Dessent <brian@dessent.net>
4c90a532 2125
9a8a04fc
BD
2126 * resource.h: Reorganize. Group by type, and give each its own
2127 range of IDs. Regenerate IDs accordingly.
2128 (IDD_CHOOSER): Remove obsolete and unused symbol.
2129
9e6e3c68
BD
21302005-05-05 Brian Dessent <brian@dessent.net>
2131
2132 * root.h (class RootPage): Add missing virtual to OnMessageCmd.
2133
746fff8d
BD
21342005-05-05 Brian Dessent <brian@dessent.net>
2135
2136 * root.cc (dialog_cmd): Remove. Use OnMessageCmd instead.
2137 (RootPage::Create): Accomodate above change.
2138
2139 * root.h (class RootPage): Add prototype for OnMessageCmd.
2140
2141 * res.rc (IDD_ROOT): Fix broken button groups. Correct the order of
ca2b7505 2142 the controls and use of WS_GROUP so that the radio buttons act
746fff8d
BD
2143 correctly.
2144
d2a3615c
MB
21452005-05-05 Max Bowsher <maxb@ukf.net>
2146
2147 Bulk rename of String++ member cstr_oneuse () to c_str () for
2148 similarity to std::string.
2149
2150 * Exception.cc
2151 * IniDBBuilderPackage.cc
2152 * IniParseFindVisitor.cc
2153 * LogFile.cc
2154 * PickCategoryLine.cc
2155 * PickPackageLine.cc
2156 * PickView.cc
2157 * String++.cc
2158 * String++.h
2159 * archive.cc
2160 * cygpackage.cc
2161 * desktop.cc
2162 * dialog.cc
2163 * diskfull.cc
2164 * download.cc
2165 * filemanip.cc
2166 * find.cc
2167 * geturl.cc
2168 * ini.cc
2169 * install.cc
2170 * io_stream.cc
2171 * io_stream_cygfile.cc
2172 * io_stream_file.cc
2173 * localdir.cc
2174 * mount.cc
2175 * nio-http.cc
2176 * package_db.cc
2177 * package_meta.cc
2178 * package_source.h
2179 * postinstall.cc
2180 * proppage.cc
2181 * root.cc
2182 * script.cc
2183 * site.cc
2184 * splash.cc
2185 * threebar.cc
2186 * window.cc
2187
3a8630fd
MB
21882005-05-05 Max Bowsher <maxb@ukf.net>
2189
2190 Some String++ refactoring, setting out in the general direction of
2191 eventually just using the STL std::string, not our own class.
2192
2193 * String++.cc (String::cstr, String::cstr () const): Remove.
2194 (new_cstr_char_array): New function.
2195 * String++.h: Sync with above.
2196 Remove irrelevant "class io_stream;" declaration.
2197
2198 * cygpackage.h: Add "class io_stream;" declaration, now no longer
2199 being supplied by side-effect.
2200
2201 * filemanip.cc: Remove unneeded includes, add "using namespace std;".
2202 (parse_filename): Exchange some awkward pointer manipulation for
2203 std::string usage. Use new_cstr_char_array ().
2204 * filemanip.h: Sync with above.
2205 (fileparse): Improve style of declaration.
2206
2207 * io_stream_cygfile.cc (io_stream_cygfile::normalise):
2208 Use new_cstr_char_array ().
2209 * site.cc (site_list_type::init, get_site_list): Ditto.
2210
daab12c7
BD
22112005-05-05 Brian Dessent <brian@dessent.net>
2212
03e84729
MB
2213 * ControlAdjuster.h (enum ControlPosition): Declare new resizing
2214 methods CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, and their
2215 TOP/BOTTOM aliases.
daab12c7 2216
03e84729
MB
2217 * ControlAdjuster.cc (ControlAdjuster::ControlInfo::adjust):
2218 Implement CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, which are
2219 designed to resize elements in a two-column layout.
daab12c7 2220
03e84729
MB
2221 * localdir.h (class LocalDirPage): Remove constructor implementation
2222 from here...
daab12c7 2223
03e84729
MB
2224 * localdir.cc (LocalDirPage::LocalDirPage): ...to here, and call
2225 AddControlsInfo on initialization.
2226 (static LocaldirControlsInfo): Add. Define sizing rules for dialog
daab12c7
BD
2227 elements.
2228
03e84729
MB
2229 * proppage.h: Add includes.
2230 (PropertyPage::ClickableURL):
2231 Declare new storage type for internal use by class.
2232 (PropertyPage::urls): Likewise.
2233 (PropertyPage::urlWinProc): Add declaration.
daab12c7
BD
2234 (PropertyPage::makeClickable): Likewise.
2235
03e84729
MB
2236 * proppage.cc: Add includes.
2237 (PropertyPage::DialogProc): Implement handler for WM_CTLCOLORSTATIC
2238 message. Supports static controls that have been turned into
2239 clickable hyperlinks.
2240 (static PropertyPage::urls): Declare.
2241 (PropertyPage::makeClickable): Implement new member function that
2242 provides user interface for making text into clickable URLs.
2243 (PropertyPage::urlWinProc): Implement new private member function used
2244 as a windowproc for subclassing a static control.
2245
2246 * resource.h (IDC_SPLASH_URL, IDC_FILEMODES_LINK, IDC_ROOTDIR_GRP,
2247 IDC_INSTALLFOR_GRP, IDC_ALLUSERS_TEXT, IDC_JUSTME_TEXT, IDC_MODE_GRP,
2248 IDC_MODE_TEXT, IDC_MODE_BIN, IDC_LOCALDIR_GRP, IDC_SPLASH_TEXT,
2249 IDC_SPLASH_ICON, IDC_SPLASH_COPYR): Add. Replaces anonymous
daab12c7
BD
2250 IDC_STATIC ids, so that controls can be referenced by the resizer.
2251
03e84729
MB
2252 * res.rc (IDD_LOCAL_DIR): Rearrange controls to match top-down order
2253 in the dialog. Fold long lines. Replace anonymous IDC_STATIC ids.
2254 (IDD_ROOT): Reorder in same manner. Replace anonymous IDC_STATIC ids.
2255 Add descriptive text of each option, and hyperlink for more
2256 information. Mark suggested choice as "(RECOMMENDED)". Swap order of
2257 'unix'/'dos' radio buttons so that recommended choice is first in both
2258 columns.
2259 (IDD_SPLASH): Reorder elements to match top-down order of dialog, fold
2260 long lines. Add descriptive paragraph, remove anonymous ids. Update
2261 copyright text, replace sources.redhat.com with cygwin.com.
daab12c7 2262
03e84729 2263 * root.h (class RootPage): Remove constructor implementation from
daab12c7
BD
2264 here...
2265
03e84729
MB
2266 * root.cc: ...to here, and call AddControlInfo.
2267 (static RootControlsInfo): Add. Populate with resizing data.
daab12c7
BD
2268 (RootPage::OnInit): Make text a clickable hyperlink.
2269
03e84729 2270 * splash.h (class SplashPage): Likewise, move constructor from
daab12c7
BD
2271 here...
2272
03e84729
MB
2273 * splash.cc: ...to here. Call AddControlInfo.
2274 (static SplashControlsInfo): Add and populate.
2275 (SplashPage::Create): Make link on splash page a clickable hyperlink.
daab12c7 2276
03e84729
MB
2277 * window.h: Add include.
2278 (class Window): Store allocated fonts with a vector instead of fixed
2279 array. Change indentation of setParent to be consistent.
daab12c7 2280
03e84729
MB
2281 * window.cc (Window::Window): Remove FontCounter.
2282 (Window::~Window): Likewise. Iterate over vector of fonts instead.
2283 (Window::SetDlgItemFont): Use vector.
daab12c7 2284
042d83f9
MB
22852005-05-05 Max Bowsher <maxb@ukf.net>
2286
2287 * Makefile.am (EXTRA_DIST, inilint_SOURCES):
2288 Sync with several recent changes.
2289
a38fde1a
BD
22902005-05-05 Brian Dessent <brian@dessent.net>
2291
03e84729 2292 * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Include section
a38fde1a
BD
2293 comment.
2294
dd267526
BD
22952005-05-05 Brian Dessent <brian@dessent.net>
2296
2297 * res.rc: (IDC_CHOOSE): Widen 'view' button by 6px horizontally and
2298 4px vertically. Adjust other controls to accomodate.
2299 (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that manifest is
2300 included in the binary.
2301
2302 * setup.exe.manifest: New file. Results in common controls with
2303 themed appearance on modern versions of Windows.
2304
83524e5b
MB
23052005-05-05 Brian Dessent <brian@dessent.net>
2306
03e84729 2307 * main.cc (WinMain): Change conditional to avoid spurious error
83524e5b 2308 message on success. Include reason for failure in log message.
96f50f64 2309
071f7af3
MB
23102005-05-04 Max Bowsher <maxb@ukf.net>
2311
2312 * state.cc, state.h (net_method, net_proxy_host, net_proxy_port,)
2313 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
2314 Inet_ftp_user, net_ftp_passwd):
2315 Move these global variables to be static variables of the NetIO class.
2316
2317 * netio.h, netio.cc (net_method, net_proxy_host, net_proxy_port,)
2318 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
2319 net_ftp_user, net_ftp_passwd):
2320 As above.
2321
2322 * ConnectionSetting.cc, net.cc:
2323 Change include, refer to variables in new location.
2324
0a49fe44
MB
23252005-05-04 Max Bowsher <maxb@ukf.net>
2326
2327 * PickLine.cc: Remove file - redundant.
2328 * Makefile.am (setup_SOURCES): Adjust.
2329
7f3324d2
MB
23302005-05-04 Max Bowsher <maxb@ukf.net>
2331
2332 * package_version.h (packageversion::set_requirements):
2333 Remove deftrust argument default value.
2334
23352005-05-04 Max Bowsher <maxb@ukf.net>
2ef95e81
MB
2336
2337 * package_version.cc (DependencyProcessor): Remove trivial class.
2338 (select, processOneDependency): Do not use DependencyProcessor, just
2339 pass parameters normally.
2340
d20a2e29
MB
23412005-05-04 Brian Dessent <brian@dessent.net>
2342
2343 Fix bug #820: Clicking Curr, etc., causes some dependencies to not
2344 be installed.
2345
2346 * choose.cc (ChooserPage::changeTrust):
2347 Add a missing "packagedb.markUnVisited ()".
2348
9bd063e0
MB
23492005-05-03 Max Bowsher <maxb@ukf.net>
2350
2351 * PickCategoryLine.cc (PickCategoryLine::click):
2352 * PickPackageLine.cc (PickPackageLine::click):
2353 Abandon use of trivial packagemeta::PrepareForVisit() wrapper.
2354
2355 * package_meta.h (packagemeta::PrepareForVisit): Remove.
2356 * package_meta.cc (packagemeta::PrepareForVisit): Remove.
2357
97b50ad7
MB
23582005-05-03 Max Bowsher <maxb@ukf.net>
2359
2360 * choose.h (ChooserPage::ifChecked): Remove.
2361 (ChooserPage::changeTrust): Convert from template to ordinary function.
2362 * choose.cc (ChooserPage::changeTrust): As above, plus avoid the use
2363 of custom class SetRequirement, when bind2nd(mem_fun(...),...) can
2364 achieve the same effect.
2365 * package_meta.h (SetRequirement): Remove, now unused.
2366
98b84622
MB
23672005-05-03 Max Bowsher <maxb@ukf.net>
2368
2369 * package_meta.h (packagemeta::set_requirements):
2370 Remove default argument which seems inappropriate.
2371 * PickPackageLine.cc (PickPackageLine::click):
2372 Make an argument explicit, and not that it seems like the wrong value.
2373
7c86285f
MB
23742005-05-03 Brian Dessent <brian@dessent.net>
2375
2376 Fix part of bug #853 - proxy port not remembered.
2377
2378 * net.cc (doing_loading): New static boolean.
2379 (load_dialog): Use the boolean to prevent save_dialog() from taking
2380 action due to field changes due to initialization.
2381 (save_dialog): Check the boolean and respond appropriately.
2382
9ad9a0b0
MB
23832005-04-19 Max Bowsher <maxb@ukf.net>
2384
2385 * postinstall.cc (RunFindVisitor::visitFile): Fix crash on
2386 encountering a postinstall script with a name of 4 characters or less.
2387 Bug introduced on 2004-12-25.
2388
946198be
MB
23892005-04-05 Max Bowsher <maxb@ukf.net>
2390
2391 The Big Cleanup: Phase "rfc1738"
2392
2393 * rfc1738.cc, rfc1738.h: Delete.
2394 * csu_util/rfc1738.cc: Reimport latest version from upstream source.
2395 Make thread-safe. Rewrite C++ wrapper in terms of std::string.
2396 Document the divergences from the upstream source.
2397 * csu_util/rfc1738.h: Recreate for the std::string version of the
2398 C++ wrapper.
2399
2400 * Makefile.am (setup_SOURCES): Sync with added/removed files.
2401 * IniParseFindVisitor.cc: Modify #includes.
2402 (IniParseFindVisitor::visitFile): Change function name, as the new
2403 C++ wrapper does not contain an irregularity that the old one did.
2404 * download.cc: Modify #includes.
2405 * ini.cc: Modify #includes.
2406
e76de0f5
MB
24072005-04-05 Max Bowsher <maxb@ukf.net>
2408
2409 Remove setup's internal compression libraries, instead relying on the
2410 mingw-foo packages which have been part of the Cygwin net distribution
2411 for some time now. At the same time, reorganize the README file to
2412 inform about the change, and make some additional tidy-ups there whilst
2413 working there.
2414
2415 * GUIDELINES: Remove, contents transferred to README.
2416 * README: Add build instructions. Delete unconfirmed and fixed bugs
2417 sections. Incorporate the former contents of GUIDELINES.
2418
2419 * bz2lib/: Remove.
2420 * zlib/: Remove.
ca2b7505 2421 * Makefile.am (DIST_SUBDIRS, SUBDIRS):
e76de0f5
MB
2422 * configure.in: Remove AC_CONFIG_SUBDIRS for removed subdirs.
2423 * compress_bz.h: Remove complex _WIN32 preprocessor conditional.
2424 * compress_gz.h: Fix #include file name.
2425 * archive_tar_file.cc: Remove unused #include.
2426 * install.cc: Remove unused #include.
2427
069a187a
MB
24282005-01-27 Max Bowsher <maxb@ukf.net>
2429
2430 Set CYGWIN=nontsec, for postinstall scripts.
2431
2432 * main.cc (main): putenv("CYGWIN=nontsec").
2433
b4cf6208
MB
24342005-01-27 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
2435
2436 Fix corrupt display of ini parse percentage in log file.
2437
2438 * ini.cc (GuiParseFeedback): Use a sensible data type for lastpct.
2439
eff7a094
MB
24402004-12-29 Max Bowsher <maxb@ukf.net>
2441
2442 * site.cc (get_site_list): Filter the incoming mirrors list to contain
2443 only URL schemes that we can read.
2444
2c539780
MB
24452004-12-28 Max Bowsher <maxb@ukf.net>
2446
2447 The Big Cleanup: Phase "hash"
2448
2449 * hash.cc, hash.h: Delete.
2450 * Makefile.am (setup_SOURCES): Sync with deleted files.
2451
2452 * package_mets: Modify includes.
2453 (standard_dirs): Remove.
2454 (hash::add_subdirs): Remove.
2455 (packagemeta::uninstall): Re-implement using STL set instead of
2456 homebrew hash.
2457
4abaa9f9
MB
24582004-12-28 Max Bowsher <maxb@ukf.net>
2459
2460 * String++.h (operator std::string): Take care to never do
2461 std::string((char*)NULL) - it causes a hang!
2462
a77b6167
MB
24632004-12-27 Max Bowsher <maxb@ukf.net>
2464
2465 The Big Cleanup: Phase "log"
2466
2467 * log.cc, log.h: Delete old C-style compatibility wrapper around the
2468 logging subsystem.
2469 * Makefile.am (setup_SOURCES): Sync with deleted files.
2470
2471 * AntiVirus.cc, archive_tar_file.cc, ini.cc, install.cc,
2472 * io_stream_cygfile.cc, localdir.cc, msg.cc, net.cc, netio.cc,
2473 * netio.h, nio-ftp.cc, nio-ftp.h, root.cc, source.cc:
2474 Throughout, refine includes, and update code using the old
2475 compatibility wrapper to C++ streams style code.
2476
b16e07fc
MB
24772004-12-27 Max Bowsher <maxb@ukf.net>
2478
2479 * compress.cc: Refine includes. Remove placeholder function
2480 definitions. Make destructor an empty function.
2481 * compress.h: Refine includes. Make placeholder functions pure
2482 virtual. Add missing const on buffer argument to write function,
2483 to match derived classes.
2484 * compress_bz.cc, compress_gz.cc: Refine includes. Throw exception,
2485 rather than logging and returning an error, when an unimplemented
2486 function is called.
2487 * compress_bz.h, compress_gz.h: Refine includes.
2488
2b734ec7
MB
24892004-12-26 Max Bowsher <maxb@ukf.net>
2490
2491 The Big Cleanup: Phase "version"
2492
2493 * String++.h (operator std::string): Add.
2494 * desktop.cc, fromcwd.cc: Remove irrelevant include.
2495
2496 * version.cc, version.h: Delete, replacing all functionality in new
2497 files.
2498
2499 * setup_version.h: Add, taking over declaration of generated version
2500 symbol functionality.
2501
2502 * Makefile.am (setup_SOURCES): Sync with new/deleted files.
2503 (setup_version.c): Rename the symbol 'version' to 'setup_version'.
2504 * main.cc: Modify includes.
2505 (main): Adapt to setup_version rename.
2506 * splash.cc: Modify includes.
2507 (SplashPage::OnInit): Adapt to setup_version rename.
2508
2509 * csu_util/version_compare.cc, csu_util/version_compare.h: Add,
2510 containing a completely rewritten replacement for canonical_version().
2511
2512 * IniDBBuilderPackage.cc: Modify includes.
2513 (IniDBBuilderPackage::buildVersion): Use new version_compare API.
2514 * ini.cc: Modify includes.
2515 (setup_version): Rename...
2516 (ini_setup_version): ...to this.
2517 (do_local_ini, do_remote_ini): Adapt to above change.
2518 (do_ini_thread): Adapt to above change. Use new version_compare API.
2519
0f45aabe
MB
25202004-12-25 Max Bowsher <maxb@ukf.net>
2521
2522 * install.cc (Installer::installOneSource): Remove a stray "break;"
2523 left over from the switch-case -> if-else conversion in the previous
2524 change.
2525
4875ac88
MB
25262004-12-25 Max Bowsher <maxb@ukf.net>
2527
2528 The Big Cleanup: Phase "win32"
2529
2530 * win32.h: Major overhaul. Document why we use _WIN32_IE. Move out
2531 fragment dealing with alloca() to the single file in which it is used.
2532 Remove fragment dealing with _MAX_PATH, and convert all uses of it
2533 elsewhere to MAX_PATH. Remove random include of <stdarg.h>. Remove
2534 NOCOMATTRIBUTE, as setup contains no code which it affects. Remove
2535 includes of <wininet.h> and <windowsx.h> - see later in this log.
2536 (IsWindowsNT): New inline function, a much simpler implementation of
2537 Win32::OS().
2538
2539 * win32.cc: Delete.
2540
2541 * Makefile.am (setup_SOURCES): Remove "win32.cc".
2542
2543 * AntiVirus.cc (detect), PickPackageLine.cc (PickPackageLine::paint),
2544 * install.c (Installer::installOneSource):
2545 Use IsWindowsNT(), not Win32::OS().
2546 * main.cc (main): Use IsWindowsNT(), not locally defined iswinnt.
2547
2548 * PickView.cc (PickView::WindowProc), netio.cc (auth_proc),
2549 * proppage.cc (PropertyPage::DialogProc):
2550 Avoid using obfuscating macros from <windowsx.h>.
2551
2552 * archive.cc: Include or #define alloca() in the only file in which
2553 it is used.
2554
2555 * nio-ie5.h: Include <wininet.h> here, where it is actually needed,
2556 rather than in "win32.h" which is included almost everywhere.
2557
2558 * archive_tar.cc, archive_tar.h, cygpackage.cc, cygpackage.h,
2559 * desktop.cc, find.cc, install.cc, main.cc, mklink2.c, mount.cc,
2560 * script.cc: Use MAX_PATH, not _MAX_PATH.
2561
f4a981ab
MB
25622004-12-25 Max Bowsher <maxb@ukf.net>
2563
2564 Remove some overcomplications.
2565
2566 * Makefile.am (setup_SOURCES): Remove FilterVisitor.{cc,h}.
2567 * FilterVisitor.cc, FilterVisitor.h: Delete.
2568 * String++.cc (strmatch, String::matches): Remove.
2569 * String++.h (String::matches): Remove.
2570 * postinstall.cc: Do not include "FilterVisitor.h".
2571 (RunFindVisitor): Exclude items with the extension ".done".
2572 (do_postinstall_thread): Remove overcomplicated exclusion of items
2573 with the extension ".done".
2574
768d880e
MB
25752004-12-24 Max Bowsher <maxb@ukf.net>
2576
2577 * String++.cc, String++.h: Remove unused and incomplete code.
2578 * LogFile.cc (LogFile::log_save): Don't leak memory.
2579 * filemanip.cc, geturl.cc, root.cc, version.cc:
2580 Don't pointlessly create temporary copies strings.
2581
db165a9a
MB
25822004-12-23 Max Bowsher <maxb@ukf.net>
2583
2584 * choose.cc (ChooserPage::OnNext): Relegate some overly verbose
2585 logging to an #ifdef DEBUG section.
2586 * geturl.h (dismiss_url_status_dialog): Remove stale function
2587 declaration, for which there is no definition.
2588 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
2589 Motivated by the recent unexplained hang bug, add some extra logging.
2590
0229b1d7
MB
25912004-11-22 Max Bowsher <maxb@ukf.net>
2592
2593 * MD5++.cc, MD5++.h: Remove this class.
2594 * csu_util/MD5Sum.cc, csu_util/MD5Sum.h: New more complete MD5 class.
2595 * Makefile.am (setup_SOURCES): Adjust to new files.
2596 * download.cc (validateCachedPackage): Simplify, using the new class.
2597 * install.cc (md5_one): Ditto.
2598 * package_source.h (packagesource::md5): Change to be an object of the
2599 new class.
2600
2c4261a8
MB
26012004-11-22 Max Bowsher <maxb@ukf.net>
2602
ba102d1c
MB
2603 * main.cc (main): Fix bug in one of the 2004-11-19 commits.
2604 Avoid referring to the theLog pointer before it is set.
2c4261a8 2605
9132ff16
MB
26062004-11-20 Max Bowsher <maxb@ukf.net>
2607
2608 * res.rc (IDD_SOURCE): Clarify the radio-button option descriptions.
2609 Re-layout the radio buttons.
2610
6beebaa3
MB
26112004-11-20 Max Bowsher <maxb@ukf.net>
2612
2613 Repair the broken detection of wrongly-sized package files.
2614
2615 * download.cc (validateCachedPackage): Make static, since not used
2616 elsewhere. Improve logging. Migrate file-size tests to here, alongside
2617 the MD5 tests.
2618 (check_for_cached): Remove broken testing of file-size, now covered by
2619 the above. Code cleanups.
2620
54ff37c8
MB
26212004-11-19 Max Bowsher <maxb@ukf.net>
2622
2623 * package_version.cc (dumpAndList): Make dependencies much more
2624 readable in full log output.
2625
4d7a6eeb
MB
26262004-11-19 Max Bowsher <maxb@ukf.net>
2627
2628 * proppage.cc (PropertyPage::DialogProc): Wrap in a TOPLEVEL_CATCH
2629 block, since allowing exceptions to unwind into the guts of Windows is
2630 quite disasterous.
2631
c66b9174
MB
26322004-11-19 Max Bowsher <maxb@ukf.net>
2633
2634 * main.cc (main): Move option parsing code earlier - it must execute
2635 before any significant object creations, which might test options in
2636 their initialization.
2637
82b64f8a
MB
26382004-11-19 Max Bowsher <maxb@ukf.net>
2639
2640 * main.cc (main): Remove some junk code - either commented out, or
2641 contained within unreachable preprocessor conditional sections.
2642
4fa49408
MB
26432004-11-19 Max Bowsher <maxb@ukf.net>
2644
2645 * install.cc (Installer::installOneSource): Avoid leaking the open
2646 file handles of every tarball that is installed.
2647
0e9a5c4f
MB
26482004-11-19 Max Bowsher <maxb@ukf.net>
2649
2650 * package_source.h (packagesource::Canonical, packagesource::Base)
2651 (packagesource::Filename): Add "const" specification to accessor
2652 methods.
2653
6b68e703
MB
26542004-11-18 Max Bowsher <maxb@ukf.net>
2655
2656 * archive.h (archive::~archive): Define a pure virtual destructor to
2657 enforce the abstract nature of this class.
2658 * archive.cc (archive::~archive): Pure virtual destructors require an
2659 implementation! Add one.
2660 * io_stream.h (io_stream::destroyed): Remove this severely
2661 brain-damaged implementation of a weakly-enforced abstract class.
2662 The pure virtual destructor was strongly enforcing the abstract nature
2663 anyway.
2664 * io_stream.cc (io_stream::~io_stream): Empty out horribly pointless
2665 code from the pure virtual destructor.
2666 * archive_tar.cc (archive_tar::~archive_tar): Remove all
2667 reference to the removed "destroyed" member.
2668 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
2669 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
2670 * compress_gz.cc (compress_gz::~compress_gz): Ditto.
2671 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Ditto.
2672 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
2673 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
2674
51200ef2
MB
26752004-11-17 Max Bowsher <maxb@ukf.net>
2676
2677 * mount.cc (create_mount): Fix operator precedence error introduced in
2678 first 2004-11-11 commit - warned of by gcc 3.3.3 but not 3.4.1 !
2679
f5d45c3b
MB
26802004-11-13 Max Bowsher <maxb@ukf.net>
2681
2682 Miscellaneous cleanup.
2683
2684 * geturl.cc (getUrlToStream): Make static.
2685 * geturl.h (getUrlToStream): Remove declaration.
2686
2687 * geturl.cc, geturl.h, netio.cc, netio.h, nio-ftp.cc, nio-ftp.h,
2688 nio-http.cc, nio-http.h:
2689 Remove unused "allow_ftp_auth" flag throughout.
2690
f4d80c3f
MB
26912004-11-11 Max Bowsher <maxb@ukf.net>
2692
2693 * libmd5-rfc: New directory, to hold code imported from the libmd5-rfc
2694 project in a clearly delineated fashion.
2695 * libmd5-rfc/README: New file.
2696 * md5.c, md5.h: Delete...
2697 * libmd5-rfc/md5.c, libmd5-rfc/md5.h: ...and replace with pristine
2698 versions from upstream (only change is restoration of upstream CVS
2699 keyword expansions).
2700 * libmd5-rfc/md5main.c: New file.
2701 * Makefile.ami (setup_SOURCES): Edit file paths.
2702 * download.cc, install.cc: Edit include paths.
2703
68d49419
MB
27042004-11-11 Max Bowsher <maxb@ukf.net>
2705
2706 * dialog.cc (fatal): Make capable of handling a passed-in error code,
2707 as an alternative to calling GetLastError().
2708 * dialog.h (fatal): Adjust prototype as above.
2709 * mount.cc (create_mount): Use the above to correctly report errors.
2710
af111c7d
MB
27112004-10-28 Max Bowsher <maxb@ukf.net>
2712
2713 * LogFile.cc (LogFile::getFileName), splash.cc (SplashPage::Create),
2714 threebar.cc (ThreeBarProgressPage::SetBar2):
2715 Migrate from cistring and string resources
2716 to String and string literals.
2717 * localdir.cc: Remove unneeded #include of "cistring.h".
2718 * cistring.cc, cistring.h: Remove this now-redundant class.
2719 * Makefile.am: Remove mention of the above removed files.
2720 * res.rc, resource.h: Remove obsolete strings and IDs, both those
2721 obseleted by and obselete before the above changes.
2722 * res.rc: Merge the 2 adjacent STRINGTABLEs.
2723
8a264069
MB
27242004-10-27 Max Bowsher <maxb@ukf.net>
2725
2726 * Makefile.am (setup_SOURCES): Add "RECTWrapper.h". It was missing.
2727
b4b8ab8d
MB
27282004-10-25 Bas van Gompel <cygsup-patch.buzz@bavag.tmfweb.nl>
2729
2730 * package_source.cc (packagesource::set_canonical):
2731 Fix one-off in 'base' when ini is in same dir as package.
2732
49560a44
MB
27332004-10-25 Max Bowsher <maxb@ukf.net>
2734
2735 * main.cc (next_dialog): Remove this legacy global variable.
2736 * download.cc (do_download_thread): Return a value instead of setting
2737 a global variable, then returning void.
2738 (do_download_reflector): Look for the next dialog code as a return
2739 value instead of a global variable.
2740
99ff5a8b
MB
27412004-10-25 Max Bowsher <maxb@ukf.net>
2742
2743 * port.h: Remove this redundant file - all contained definitions are
2744 duplicated in "win32.h".
2745 * Makefile.am, UserSetting.cc, UserSettings.cc, archive.cc,
2746 archive_tar.cc, archive_tar_file.cc, choose.cc, compress.cc,
2747 compress_bz.cc, compress_gz.cc, desktop.cc, find.cc, fromcwd.cc,
2748 iniparse.y, install.cc, io_stream_cygfile.cc, io_stream_file.cc,
2749 main.cc, netio.cc, site.cc, version.cc:
2750 Remove all references to "port.h".
2751
46d04e97
MB
27522004-10-25 Max Bowsher <maxb@ukf.net>
2753
2754 Fix compilation with w32api 3.1 and later.
2755
2756 * ControlAdjuster.h, RECTWrapper.h, cistring.h, propsheet.h,
2757 window.cc, window.h: Include "win32.h" not <windows.h> directly.
2758 * win32.h (WINBASEAPI): Define to empty string.
2759
5524909e
IP
27602004-09-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2761
2762 * script.cc (run): Kill stdin when running scripts.
2763
84b9cc5e
MB
27642004-09-01 Max Bowsher <maxb@ukf.net>
2765
2766 * Makefile.am: Oops. Unwanted keyword expansion ate the code of the
2767 previous commit. Restore the code, escaped to not look like a keyword.
2768
012374fe
MB
27692004-09-01 Max Bowsher <maxb@ukf.net>
2770
2771 * Makefile.am: Simplify the shell incantation for getting the revision
2772 of ChangeLog from grep-and-sed to just sed.
2773
b4113ac0
MB
27742004-08-31 Max Bowsher <maxb@ukf.net>
2775
2776 Attain GCC 3.4 compatibility.
2777
2778 * PackageSpecification.h (PackageSpecification): Make the
2779 unnecessarily private copy-constructor public.
2780
fc2ba841
MB
27812004-08-30 Max Bowsher <maxb@ukf.net>
2782
2783 Rework the implementation of not including -Werror for specific files,
2784 to a way that does not require hardcoding modified automake output back
2785 into its input.
2786
2787 * Makefile.am (AM_CXXFLAGS, BASECXXFLAGS): Seperate out -Werror.
2788 (autoload.o): Drop this rule, -finline-functions is no longer required
2789 and -Werror is acceptable here now we have __attribute__ ((used)).
2790 (WARNONLY_CFLAGS, inilex.o): Drop these.
2791 (EXTRA_PROGRAMS): Add a fake "warnonly" program.
2792 (warnonly_CXXFLAGS): Set to the $(BASECXXFLAGS).
2793 (warnonly_SOURCES): Set to "inilex.cc".
2794 (EXTRA_setup_SOURCES): Set to $(warnonly_SOURCES).
2795 (setup_SOURCES): Remove "inilex.cc".
2796 (setup_LDADD): Add "warnonly-inilex.o".
2797
d3c2a043
MB
27982004-08-30 Max Bowsher <maxb@ukf.net>
2799
2800 Move closer to GCC 3.4 compatibility.
2801
2802 * IOStreamProvider.h, io_stream_cygfile.cc, io_stream_cygfile.h,
2803 io_stream_file.cc: Do not incorrectly use "enum" after it has been
2804 hidden inside a typedef.
2805 * archive.h: In "virtual func() = 0;", the 0 is a language construct,
2806 not some symbol that might evaluate to 0, and gcc 3.4 enforces this.
2807 * autoload.c (DllInfo.name): Silence warning by making const.
2808 (DLL, autoload_common): __attribute__ ((used)) is now required to
2809 prevent gcc being over-eager in it's optimization, and removing these
2810 seemingly-unused (used only from assembly) functions.
2811 Silences some warnings, too.
2812 * Makefile.am (AM_CXXFLAGS, AM_CFLAGS): The options
2813 -Wstrict-prototypes -Wmissing-prototypes do not apply to C++ and
2814 g++ 3.4 complains about them.
2815
072fb49a
MB
28162004-08-29 Max Bowsher <maxb@ukf.net>
2817
ca2b7505 2818 * Exception.h: Reformatting, #include more, remove incorrect and
072fb49a
MB
2819 less-than-useful comments.
2820 (TOPLEVEL_CATCH): New preprocessor macro.
2821
2822 * LogFile.cc (LogFile::operator()): Throw an exception object, not a
2823 char* string.
2824
2825 Wrap the top-level of each thread (including the main thread) in a
2826 try...catch block, in order to display a useful error message if an
2827 exception is not caught.
2828 * download.cc (do_download_reflector): Here ...
2829 * ini.cc (do_ini_thread_reflector): ... and here ...
2830 * install.cc (do_install_reflector: ... and here ...
2831 * main.cc (main): ... and here ...
2832 * postinstall.cc (do_postinstall_thread): ... and here ...
2833 * site.cc (do_download_site_info_thread): ... and here!
2834
2835 * msg.h: Include a missing header requirement.
2836 * res.rc (IDS_UNCAUGHT_EXCEPTION, IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO):
2837 New strings.
2838 * resource.h (IDS_UNCAUGHT_EXCEPTION)
2839 (IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO): New IDs.
2840
56c41dda
MB
28412004-08-28 Max Bowsher <maxb@ukf.net>
2842
2843 * res.rc (IDS_WINDOW_INIT_BADMSG): New string.
2844 * resource.h (IDS_WINDOW_INIT_BADMSG): New string resource ID.
2845 * window.cc (Window::FirstWindowProcReflector): Convert an abort()
2846 into a descriptive error.
2847
abdd4b38
MB
28482004-08-24 Max Bowsher <maxb@ukf.net>
2849
2850 The Doug Lee replacement malloc was no longer hooked up with the
2851 buildsystem in any way. Pruning the remaining unused file.
2852
2853 * dlmalloc.c: Removed.
2854
24649384
MB
28552004-08-18 Max Bowsher <maxb@ukf.net>
2856
ca2b7505 2857 "librsync is not wire-compatible with rsync 2.x, and is not likely
24649384
MB
2858 to be in the future." -- librsync.sourceforge.net
2859
2860 So, it is of no practical use to setup. Therefore, removing all
2861 rsync related files and code from setup.
2862
2863 * rsync: Directory removed.
2864 * Makefile.am: Remove rsync support from the buildsystem.
2865 * configure.in: Ditto.
2866 * README: Since it seems vanishingly unlikely that it will ever happen,
2867 remove rsync support from the wishlist.
2868 * io_stream_rsync.cc: Remove.
2869 * io_stream_rsync.h: Remove.
2870
2800a92a
RC
28712004-04-25 Robert Collins <rbtcollins@hotmail.com>
2872
24649384
MB
2873 * package_meta.cc (packagemeta::set_requirements): fix problem with
2874 libpcre0 not being pulled in automatically.
2800a92a 2875
304e9816
RC
28762004-04-25 Robert Collins <rbtcollins@hotmail.com>
2877
24649384
MB
2878 * IniDBBuilderPackage.cc (dumpAndList):
2879 Move out to packageversion for reuse.
304e9816 2880 * package_meta.cc (packagemeta::logAllVersions): log dependencies.
24649384
MB
2881 * package_version.cc (packageversion::depends):
2882 provide a const accessor.
304e9816
RC
2883 (dumpAndList): Moved from INIDBBuilder.cc.
2884 * package_version.h: declare new method and function.
2885
5419ce48
RC
28862003-12-21 Robert Collins <rbtcollins@hotmail.com>
2887
2888 * main.cc (main): Update to head libgetopt++ syntax.
2889
201741b7
RC
28902003-11-2 Robert Collins <rbtcollins@hotmail.com>
2891
2892 * ControlAdjuster.h (ControlPosition::CP_MIDDLE): Rename to
2893 CP_CENTERED.
2894 * ControlAdjuster.cc: Ditto.
2895
081bf320
RC
28962003-10-31 Frank Richter <frichter@gmx.li>
2897
ca2b7505
CF
2898 * localdir.cc (OnNext): When SelectDirectoryA() fails, display a
2899 message with the error returned from the system instead of just
081bf320
RC
2900 'could not change dir'. Also, offer the user to 'Retry', 'Ignore' the
2901 error or 'Abort' the directory change.
2902
4b6e5406
RC
29032003-10-31 Frank Richter <frichter@gmx.li>
2904
2905 * propsheet.cc (PropSheetWndProc): Don't do child resizing if a the
2906 window gets minimized. Otherwise some glitches (e.g. wrong child
2907 sizes) occur.
2908 Added support for WM_GETMINMAXINFO. Prevents the property sheet from
2909 getting smaller than the original size.
2910
576a2b0b
RC
29112003-11-1 Robert Collins <rbtcollins@hotmail.com>
2912
2913 * ControlAdjuster.h (ControlDimension): Add.
2914 (ControlAdjuster): Factor adjust functionality into ControlInfo.
2915 * ControlAdjuster.cc (ControlAdjuster::adjust): Ditto.
2916 (ControlAdjuster::ControlInfo::adjust): Ditto.
2917
a8d753b6
RC
29182003-10-31 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2919
2920 * ControlAdjuster.h (ControlPosition): New enum type.
2921 (ControlInfo::horizontalPos, ControlInfo::verticalPos): New
2922 instance variables.
2923 (ControlInfo::anchorLeft, ControlInfo::anchorTop,
2924 ControlInfo::anchorRight, ControlInfo::anchorBottom): Remove.
2925 * ControlAdjuster.cc (ControlAdjuster::AdjustControls): Switch to
2926 using position specifiers instead of anchors.
2927 * choose.cc (ChooserControlsInfo): Ditto.
2928 * proppage.cc (DefaultControlsInfo): Ditto.
2929 * propsheet.cc (PropSheetControlsInfo): Ditto.
2930 * site.cc (SiteControlsInfo): Position specifiers for site
2931 selection dialog controls.
2932 * threebar.cc (ThreeBarControlsInfo): Position specifiers for
2933 progress dialog controls.
2934
c9feb168
RC
29352003-10-27 Ralf Habacker <ralf.habacker@freenet.de>
2936
2937 * main.cc (HelpOption): New instance.
2938 (main): Added help command line option handling.
2939 * localdir.cc (LocalDirOption): New instance.
2940 (LocalDirSetting::load): allow setting localdir from command line.
2941
ee91d9be
RC
29422003-10-16 Frank Richter <frichter@gmx.li>
2943
ca2b7505
CF
2944 * ControlAdjuster.cc: New file, helper to move elements of a dialog
2945 along when the it's resized.
ee91d9be
RC
2946 * ControlAdjuster.h: Ditto.
2947 * Makefile.am: Add new source files.
2948 * proppage.cc (PropertyPage::DialogProc): Adjust some common
2949 controls (Cygwin icon top right, separator below) when a page is
2950 resized.
2951 (PropertyPage::PropertyPage): Dito.
2952 * propsheet.cc (IsDialog): New. Test whether a window is a dialog.
2953 Used internally by resize logic.
2954 (EnumPages): New. Used internally by resize logic: resizes the
2955 property sheet's individual pages.
2956 (PropSheetWndProc): New. Hook for the propery sheet window proc.
2957 (PropSheetProc): More style tweaks, add maximize box and thick border
2958 as well. Hook into the property sheet's window proc.
2959 (PropSheet::AdjustPageSize): New. Adjust the metrics of a single page
2960 to fit nicely into the property sheet. Part of resize logic.
2961 * res.rc (All dialogs): The top-right Cygwin icon and top separator
ca2b7505 2962 now have IDs distinct from IDC_STATIC, so their metrics can be
ee91d9be
RC
2963 adjusted upon a resize. Also, all those Cygwin icons are at the exact
2964 same spot now.
ca2b7505 2965 * choose.cc (ChooserPage::ChooserPage): Now the controls on the
ee91d9be
RC
2966 chooser page move/size when the page size is changed.
2967 * choose.h: Dito.
2968
1622a084
RC
29692003-10-23 Jerry D. Hedden <jerry@hedden.us>
2970
2971 * ConnectionSetting.cc (ConnectionSetting::load): Load proxysettings.
2972 (ConnectionSetting::save): Save proxy settings.
2973
7f6de8c0
RC
29742003-10-07 Robert Collins <rbtcollins@hotmail.com>
2975
2976 * proppage.h (PropertyPage::wantsActivation): const correctness fix.
2977
587a67fc
MB
29782003-08-19 Max Bowsher <maxb@ukf.net>
2979
2980 * win32.h: Define NOMINMAX only if not already defined - because
2981 libstdc++-v3 3.3.1 defines NOMINMAX itself.
2982
58b12a06
MB
29832003-08-03 Max Bowsher <maxb@ukf.net>
2984
2985 * ChangeLog: Fix broken line-wrapping throughout. Clarify that
2986 "Ran automake" in 2003-07-26 entry was in bz2lib and zlib subdirs.
2987
56a7c49e
MB
29882003-08-03 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2989
2990 * propsheet.cc (Copyright): Update copyright dates.
2991 (PropSheet::PropSheet): Remove NumPropPages initialization.
2992 (PropSheet::CreatePages): Use PropertyPages.size() instead of
2993 NumPropPages.
2994 (PropSheet::Create): Ditto.
2995 (PropSheet::AddPage): Change to use new PropertyPages std::vector<>.
2996 * propsheet.h (Copyright): Update copyright dates.
2997 (File Scope): Include <vector>.
2998 (PropSheet::PropertyPages): Change from array to vector<>.
2999 (PropSheet::NumPropPages): Remove.
3000
25130a4d
MB
30012003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3002
3003 Changes modified by Max Bowsher <maxb@ukf.net>
3004 * splash.cc (Copyright): Update copyright dates.
3005 (SplashPage::OnInit): Remove call to SetDlgItemFont(). Now handled in
3006 base class.
3007 * proppage.h (PropertyPage::setTitleFont): Declare.
3008 * proppage.cc (Copyright): Update copyright dates.
3009 (PropertyPage::DialogProc WM_INITDIALOG): Move all font setting code,
3010 including that from splash.cc into new function...
3011 (PropertyPage::setTitleFont): Create, using moved code. Change font
3012 "MS Sans Serif" to "MS Shell Dlg" in line with recent res.rc change.
3013 Set font for IDC_STATIC_WELCOME_TITLE here, to allow easy re-use of
3014 style for future "Finished" page.
3015
62489576
MB
30162003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3017
3018 * propsheet.cc: Include "resource.h".
3019 (PropSheet::Create): Add the Cygwin icon in the left of the title bar.
3020
106d8160
MB
30212003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3022
3023 * proppage.cc (PropertyPage::FirstDialogProcReflector): Modify comment.
3024
5296fc07
MB
30252003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3026
3027 * proppage.h (Copyright): Update copyright dates.
3028 (PropertyPage): Document OnNext and OnBack.
3029
5039f845
MB
30302003-07-31 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3031
3032 * proppage.cc (PropertyPage::Create): Use more self-documenting
3033 MAKEINTRESOURCE() instead of cast to LPCSTR.
3034
672d28ad
RC
30352003-07-31 Robert Collins <rbtcollins@hotmail.com>
3036
3037 * README: Mark completed items complete.
3038
c59b8da6
MB
30392003-07-31 Pierre Humblet <pierre.humblet@ieee.org>
3040
3041 * main.cc (set_default_sec): Set token owner from token user.
3042 Always try to set the token primary group to Users or Admins.
3043
25e21380
IP
30442003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3045
3046 * String++.h (String::replace): New instance functions.
3047 * String++.cc (String::replace): Implement.
3048 * filemanip.cc (backslash): Change to use String::replace.
3049 * desktop.cc (make_cygwin_bat): Escape '%' in path.
3050
346627e7
IP
30512003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3052
3053 * String++.h (TOSTRING): New macro.
3054 * UserSettings.cc (UserSettings::deRegisterSetting): Fix
3055 erroneous __LINE__/__FILE__ usage.
3056 * download.cc (validateCachedPackage, check_for_cached): Ditto.
3057 * geturl.cc (getUrlToStream): Ditto.
3058 * install.cc (md5_one): Ditto.
3059
d9f4a2ba
MB
30602003-07-30 Max Bowsher <maxb@ukf.net>
3061
3062 * ini.cc (do_ini_thread): Return bool.
3063 (do_ini_thread_reflector): Put returned bool in lParam.
3064 * threebar.cc (WM_APP_SETUP_INI_DOWNLOAD_COMPLETE): Rework for new
3065 meaning of lParam. Replace erroneous use of do_fromcwd with
3066 SetActivePageByID (IDD_SOURCE).
3067
39b42ff3
RC
30682003-07-30 Robert Collins <rbtcollins@hotmail.com>
3069
3070 * ConnectionSetting.cc: New file, persist connection type selection.
3071 * ConnectionSetting.h: Ditto.
3072 * net.cc: Hold a ConnectionSetting instance to trigger the logic.
3073 (NetPage::OnInit): Don't force net_method to any value.
3074 * Makefile.am: Add new source files.
3075
6ff96351
RC
30762003-07-30 Robert Collins <rbtcollins@hotmail.com>
3077
3078 * SourceSetting.cc: New file, persist source selection.
3079 * SourceSetting.h: Ditto.
3080 * source.cc: Hold a Source setting instance to trigger the logic.
3081 * Makefile.am: Add new source files.
3082
f0fd8856
RC
30832003-07-30 Robert Collins <rbtcollins@hotmail.com>
3084
3085 * UserSettings.h (UserSettings::settingFileForLoad): Extracted method
3086 from LocalDirSetting::load().
3087 * UserSettings.cc (UserSettings::settingFileForLoad): Ditto.
3088 * UserSettings.h (UserSettings::settingFileForSave): Extracted method
3089 from LocalDirSetting::save().
3090 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
3091 * localdir.cc (LocalDirSetting::load): Extract location logic to
3092 UserSettings.
3093 (LocalDirSetting::save): Extract location logic to UserSettings.
3094 * site.cc (SiteSetting::getSavedSites): Use
3095 UserSettings::settingFileForLoad.
3096 (SiteSetting::save): Use UserSettings::settingFileForSave.
3097
bb8e2353
RC
30982003-07-30 Robert Collins <rbtcollins@hotmail.com>
3099
ca2b7505 3100 * PickView.cc: Adjust ::GetClientRect(..) to the inherited one
bb8e2353
RC
3101 throughout.
3102
b28e9f01
MB
31032003-07-29 Max Bowsher <maxb@ukf.net>
3104
3105 Based on a patch by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
3106 * AntiVirus.cc (AntiVirusPage::wantsActivation): Define.
3107 * AntiVirus.h (AntiVirusPage::wantsActivation): Declare.
3108 * localdir.cc (LocalDirPage::OnBack): Remove logic subsumed by
3109 RootPage::wantsActivation.
3110 * proppage.cc (PropertyPage::DialogProc): Call wantsActivation(),
3111 and skip to next page in sequence if activation is refused.
3112 * proppage.h (PropertyPage::wantsActivation): Default implementation.
3113 * root.cc (RootPage::wantsActivation): Define.
3114 * root.h (RootPage::wantsActivation): Declare.
3115 * source.cc: Don't include "AntiVirus.h".
3116 (SourcePage::OnNext): Remove logic subsumed by
3117 RootPage::wantsActivation.
3118 (SourcePage::OnBack): Remove logic subsumed by
3119 AntiVirusPage::wantsActivation.
3120 * splash.cc: Don't include "AntiVirus.h" or "dialog.h".
3121 (SplashPage::OnNext): Remove - subsumed by
3122 AntiVirusPage::wantsActivation.
3123 * splash.h (SplashPage::OnNext): Remove declaration.
3124
ec2dbbf0
RC
31252003-07-29 Robert Collins <rbtcollins@hotmail.com>
3126
3127 * PickView.h (PickView::refresh): New method.
3128 * PickView.cc (PickView::refresh): Extracted from various
3129 ChooserPage callers.
3130 * choose.cc: Use PickView::refresh wherever possible.
3131
bc16bb7d
RC
31322003-07-29 Robert Collins <rbtcollins@hotmail.com>
3133
3134 * choose.h (ChooserPage::createListView): Remove last parameter.
3135 (ChooserPage::getDefaultListViewSize): Extracted method.
3136 * choose.cc (ChooserPage::createListView): Remove last parameter.
3137 (ChooserPage::getDefaultListViewSize): Extracted method.
3138
952ea3fe
RC
31392003-07-29 Robert Collins <rbtcollins@hotmail.com>
3140
ca2b7505 3141 * choose.cc (ChooserPage::createListView): Remove unneeded
952ea3fe
RC
3142 parameter.
3143 * choose.h: Ditto.
3144
55c6e691
MB
31452003-07-29 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3146
3147 * dialog.h (do_fromcwd): Change function declaration.
3148 * fromcwd.cc (do_fromcwd): Change return type to bool. Eliminate
3149 use of next_dialog, return true or false instead.
3150 * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
3151 value instead of next_dialog.
3152
2f18f94d
RC
31532003-07-29 Robert Collins <rbtcollins@hotmail.com>
3154
3155 * package_db.h (packagedb::fillMissingCategory): Move from ChooserPage.
3156 * choose.h (ChooserPage::fillMissingCategory): Delete.
3157 * package_db.cc (packagedb::fillMissingCategory): Move from ChooserPage.
ca2b7505 3158 * choose.cc (ChooserPage::fillMissingCategory): Delete and adjust
2f18f94d
RC
3159 callers.
3160
525531ca
RC
31612003-07-29 Robert Collins <rbtcollins@hotmail.com>
3162
3163 * PickView.h (CATEGORY_EXPANDED): Move from choose.h
3164 (CATEGORY_COLLAPSED): Move from choose.cc.
3165 (PickView::setViewMode): Move from ChooserPage.
3166 * choose.h (CATEGORY_EXPANDED): Delete.
3167 (CATEGORY_COLLAPSED): Delete.
3168 (ChooserPage::setViewMode): Delete.
3169 * PickView.cc (PickView::setViewMode): Move from ChooserPage.
3170 * chooser.cc (ChooserPage::setViewMode): Delete, and adjust callers
3171 throughout.
3172
0f61a6a4
MB
31732003-07-28 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3174
3175 * AntiVirus.cc (AntiVirusPage::OnNext): Do not explicitly specify the
3176 page to display next, since it follows in the default page ordering
3177 anyway.
3178
6d751ec8
MB
31792003-07-28 Max Bowsher <maxb@ukf.net>
3180
3181 * dialog.h: (NEXT): Remove obsolete macro.
3182 * site.cc (save_dialog): Remove use of NEXT(), and non-functional
3183 unnecessary error handler.
3184
358712d8
RC
31852003-07-28 Robert Collins <rbtcollins@hotmail.com>
3186
3187 * package_meta.h (packagemeta::addToCategoryAll): Declare.
ca2b7505 3188 * package_meta.cc (packagemeta::addToCategoryAll): New method,
358712d8
RC
3189 separated to allow clear iteration.
3190 * choose.cc (ChooserPage::fillMissingCategory): BUGFIX: "all" is
3191 meant to be added unconditionally.
3192
31f0ccce
RC
31932003-07-27 Robert Collins <rbtcollins@hotmail.com>
3194
3195 * Generic.h: New file, home for generic programming tools.
3196 (visit_if): Move here from package_meta.cc.
3197 Adjust to be fully parameterised.
ca2b7505 3198 * package_meta.h (packagemeta::hasNoCategories): Query for generic
31f0ccce
RC
3199 programming.
3200 (packagemeta::setDefaultCategories): set categories for packages
3201 with none.
ca2b7505 3202 * package_meta.cc: Move visit_if out. Adjust users for
31f0ccce
RC
3203 full paramterised operation.
3204 (packagemeta::hasNoCategories): Implement.
3205 (packagemeta::setDefaultCategories): Implement.
3206 * choose.cc (ChooserPage::fillMissingCategory): Use visit_if to
3207 reduce duplicate code.
3208 (ChooserPage::setExistence): Delete.
ca2b7505 3209 * choose.h (ChooserPage::setExistence): Rename to
31f0ccce
RC
3210 packagedb::setExistence.
3211 * package_db.h (packagedb::setExistence): Declare.
3212 * package_db.cc (packagedb::setExistence): Copy from choose.cc
3213
dbdc1d9d
RC
32142003-07-27 Robert Collins <rbtcollins@hotmail.com>
3215
3216 * localdir.h (LocalDirPage::OnInit): Remove.
3217 * localdir.cc (LocalDirPage::OnInit): Move to LocalDirSetting
3218 ::load().
3219 (LocalDirSetting::load): Copied from LocalDirPage::OnInit.
3220 * site.h (SitePage::OnInit): Remove.
3221 (SitePage::getSavedSites): New member, replaces get_saved_sites.
ca2b7505 3222 (SitePage::registerSavedSite): New member, replaces
dbdc1d9d
RC
3223 register_saved_site.
3224 * site.cc (SitePage::OnInit): Move to SiteSetting::load().
3225 (SiteSetting::load): Copied from SitePage::OnInit.
3226 (SitePage::getSavedSites): Renamed from get_saved_sites.
3227 (SitePage::registerSavedSite): Renamed from register_saved_site.
3228 (do_download_site_info_thread): Don't look at the list size for
3229 determining if the download was successful.
3230
22120c90
RC
32312003-07-27 Robert Collins <rbtcollins@hotmail.com>
3232
ca2b7505 3233 * choose.h (ChooserPage::setViewMode): Remove HWND from
22120c90
RC
3234 signature.
3235 (ChooserPage::defaultTrust): Ditto.
3236 Move to PickView.
ca2b7505 3237 (ChooserPage::ifChecked): Use Window helper function
22120c90
RC
3238 IsButtonChecked.
3239 * choose.cc (ChooserPage::setViewMode): Use chooser->GetHWND()
3240 throughout.
3241 Update all callers with new signature.
3242 (ChooserPage::defaultTrust): Ditto.
3243 Move to PickView.
3244 * PickView.h (PickView::defaultTrust): Declare.
3245 * PickView.cc (PickView::defaultTrust): Copy from chooser.cc.
3246
9c9cfce7
RC
32472003-07-27 Robert Collins <rbtcollins@hotmail.com>
3248
3249 * PickView.h (PickView::lv): Eliminate.
3250 * PickView.cc (PickView::init): Replace use of lv with
3251 GetHWND().
ca2b7505 3252 (PickView::list_click): Ditto.
9c9cfce7
RC
3253 * choose.h (ChooserPage::lv): Eliminate.
3254 * choose.cc: Replace lv with chooser->GetHWND()
3255 throughout.
3256
d2be933d
RC
32572003-07-27 Robert Collins <rbtcollins@hotmail.com>
3258
3259 * PickView.h (PickView::chooser): Eliminate.
3260 (PickView::list_vscroll): Make non-static.
3261 (PickView::list_hscroll): Ditto.
3262 (PickView::list_click): Ditto.
3263 (PickView::paint): Ditto.
3264 * PickView.cc (PickView::list_vscroll): Eliminate use
3265 of PickView::chooser.
3266 (PickView::list_hscroll): Ditto.
3267 (PickView::list_click): Ditto.
3268 (PickView::paint): Ditto.
3269 * choose.cc (Chooser::createListView): Eliminate use
3270 of PickView::chooser.
3271
693916f8
RC
32722003-07-27 Robert Collins <rbtcollins@hotmail.com>
3273
3274 * PickView.h (PickView): Inherit from Window.
3275 (PickView::RegisterWindows): Move from ChooserPage.
3276 (PickView::listview_proc): Likewise.
3277 (PickView::paint): Ditto.
3278 (PickView::list_click): Ditto.
3279 (PickView::list_hscroll): Ditto.
3280 (PickView::list_vscroll): Ditto.
3281 (PickView::lv): Ditto.
3282 (PickView::chooser): Ditto.
3283 (PickView::Create): Override Windows::Create as we migrate.
3284 (PickView::registerWindowClass): Renamed RegisterWindows.
3285 (PickView::WindowClassAtom): Prevent double registration.
3286 (PickView::init): Declare.
3287 * PickView.cc: Adjust for new inheritance.
3288 (PickView::RegisterWindows): Move from ChooserPage.
3289 (PickView::listview_proc): Likewise.
3290 (PickView::paint): Ditto.
3291 (PickView::list_click): Ditto.
3292 (PickView::list_hscroll): Ditto.
3293 (PickView::list_vscroll): Ditto.
3294 (PickView::lv): Ditto.
3295 (PickView::chooser): Ditto.
3296 (PickView::Create): Introduce stub.
3297 (PickView::RegisterWindows): Rename
3298 (PickView::init): Extracted from constructor to allow
3299 reordering.
ca2b7505 3300 * chooser.h (ChooserPage::registerWindows): Rename to
693916f8
RC
3301 PickView::RegisterWindows.
3302 (ChooserPage::listview_proc): Likewise.
3303 (ChooserPage::paint): Ditto.
3304 (ChooserPage::list_click): Ditto.
3305 (ChooserPage::list_hscroll): Ditto.
3306 (ChooserPage::list_vscroll): Ditto.
ca2b7505 3307 (ChooserPage::lv): Duplicate into PickView, observe
693916f8
RC
3308 as non-static.
3309 (ChooserPage::chooser): Ditto.
3310 * chooser.cc (ChooserPage::registerWindows): Delete.
3311 (ChooserPage::listview_proc): Ditto.
3312 (ChooserPage::paint): Ditto.
3313 (ChooserPage::list_click): Ditto.
3314 (ChooserPage::list_hscroll): Ditto.
3315 (ChooserPage::list_vscroll): Ditto.
3316 (ChooserPage::createListView): Create() on PickView.
ca2b7505 3317 * window.h (Window::RegisterWindowClass): Make virtual
693916f8
RC
3318 to allow Create to become a Template Method, and rename
3319 to registerWindowClass as it's not static.
3320 * window.cc (Window::registerWindowClass): Ditto.
3321 (Window::FirstWindowProcReflector): BUGFIX: Set window
3322 handle to prevent races with the window procedure.
3323
724c2956
RC
33242003-07-27 Robert Collins <rbtcollins@hotmail.com>
3325
3326 * choose.cc (set_view_mode): Rename to ChooserPage::setViewMode.
3327 (default_trust): Rename to ChooserPage::defaultTrust.
3328 (fill_missing_category): Rename to ChooserPage::fillMissingCategory.
3329 (set_existence): Rename to ChooserPage::setExistence.
3330 (register_windows): Rename to ChooserPage::registerWindows.
3331 (listview_proc): Rename to ChooserPage::listview_proc.
3332 (paint): Rename to ChooserPage::paint.
3333 (list_click): Rename to ChooserPage::list_click.
3334 (list_hscroll): Rename to ChooserPage::list_hscroll.
3335 (list_vscroll): Rename to ChooserPage::list_vscroll.
3336 (lv): Rename to ChooserPage::lv.
3337 (chooser): Rename to ChooserPage::chooser.
3338 * choose.h (ChooserPage::setViewMode): Declare.
3339 (ChooserPage::defaultTrust): Declare.
3340 (ChooserPage::fillMissingCategory): Declare.
3341 (ChooserPage::setExistence): Declare.
3342 (ChooserPage::registerWindows): Declare.
3343 (ChooserPage::listview_proc): Declare.
3344 (ChooserPage::paint): Declare.
3345 (ChooserPage::list_click): Declare.
3346 (ChooserPage::list_hscroll): Declare.
3347 (ChooserPage::list_vscroll): Declare.
3348 (ChooserPage::lv): Declare.
3349 (ChooserPage::chooser): Declare.
3350
d05ae76a
RC
33512003-07-27 Robert Collins <rbtcollins@hotmail.com>
3352
ca2b7505 3353 * choose.cc (create_listview): Use for_each instead of explicit
d05ae76a
RC
3354 iteration.
3355 (create_listview): Rename to ChooserPage::createListview.
3356 * package_meta.h (packagemeta::set_requirements): Explicitly separate
3357 the 1 and 2 parameter versions.
3358
33592003-07-27 Robert Collins <rbtcollins@hotmail.com>
69711722
RC
3360
3361 * String++.h (String::operator !=): Declare for char * and String.
3362 * String++.cc (String::operator !=): Implement.
3363 * package_meta.cc(StringConcatenator): Move above all users.
3364 (_visit_if): Predicate support for visitors.
ca2b7505 3365 (packagemeta::getReadableCategoryList): Refactor to use
69711722
RC
3366 StringConcatenator with a predicate.
3367 * choose.h: Remove unneeded c++ guards.
3368
cda26207
RC
33692003-07-26 Robert Collins <rbtcollins@hotmail.com>
3370
58b12a06
MB
3371 * choose.cc (scan_downloaded_files): Rename to
3372 packagemeta::ScanDownloadedFiles.
cda26207
RC
3373 (scanAVersion): Rename to packageversion::scan.
3374 (GetParentRect): Rename to ChooserPage::getParentRect.
3375 * choose.h (ChooserPage::getParentRect): Declare.
3376 * package_meta.h (packagemeta::ScanDownloadedFiles): Declare.
3377 * package_version.h (packageversion::scan): Declare.
3378 * package_version.cc (packageversion::scan): Move from choose.cc
58b12a06
MB
3379 * package_meta.cc (packagemeta::ScanDownloadedFiles): Move from
3380 choose.cc
cda26207 3381
edc3c6fc
RC
33822003-07-26 Robert Collins <rbtcollins@hotmail.com>
3383
3384 * choose.cc (ChooserPage::OnNext): log before starting activity threads.
3385 (ChooserPage::OnInit): Remove temporary variable frame.
3386 (ChooserPage::setPrompt): Extract method from OnInit.
3387 (choose_inst_text): Remove unused variable.
3388 * choose.h(ChooserPage::setPrompt): Declare
3389 * res.rc (IDD_CHOOSE): Bugfix: the chooser was setting a non-present
3390 caption.
3391
d55e14fe
RC
33922003-07-26 Robert Collins <rbtcollins@hotmail.com>
3393
3394 Remove package specific code from choose.cc.
3395 Update copyrights where appropriate.
3396 * choose.cc(ChooserPage::OnNext): Extract logging to
3397 packagemeta::logSelectionStatus.
3398 * package_meta.cc(packagemeta::logSelectionStatus): Extract from
3399 ChooserPage::OnNext.
3400 (StringConcatenator): helper for logSelectionStatus.
3401 (action_caption): Make const.
3402 * package_meta.h(packagemeta): Declare logSelectionStatus.
3403 (packagemeta::action_caption): Make const.
3404 * package_version.cc(packageversion::sourcePackage): Make const.
3405 * package_version.h(packageversion::sourcePackage): Make const.
3406
12f8ac69
RC
34072003-07-26 Robert Collins <rbtcollins@hotmail.com>
3408
3409 * choose.cc: Update copyright.
3410 (ChooserPage::keepClicked): Extracted from OnMessageCmd.
3411 (ChooserPage::changeTrust): Ditto.
3412 * choose.h (ChooserPage): Declare keepClicked and changeTrust.
3413 (ChooserPage::ifChecked): Extracted from OnMessageCmd.
58b12a06
MB
3414 * package_meta.h (SetRequirement): Adapter for visiting package
3415 collections.
12f8ac69 3416
93d7e783
MB
34172003-07-26 Max Bowsher <maxb@ukf.net>
3418
3419 * tests/.cvsignore: New file, listing Makefile.in.
3420
dea6cc21
RC
34212003-07-26 Robert Collins <rbtcollins@hotmail.com>
3422
3423 Save used local cache dir from initial run of setup, so the user doesn't
3424 need to retype it.
58b12a06
MB
3425 * localdir.h (LocalDirSetting): UserSetting class for the local cache
3426 dir.
3427 * localdir.cc (LocalDirSetting::save): Replace save_local_dir, and
3428 update callers.
dea6cc21 3429
0df9be37
RC
34302003-07-26 Robert Collins <rbtcollins@hotmail.com>
3431
ca2b7505 3432 Save used site from initial run of setup, so the user doesn't need to
0df9be37
RC
3433 retype it.
3434 * main.cc (main): Load and save all user settings.
3435 * site.cc (SiteSetting::save): Migrate logic from save_site_url.
58b12a06
MB
3436 (SitePage::OnNext): Use ChosenSites.save() to remove uneeded
3437 save_site_url call.
0df9be37
RC
3438 (save_site_url): Delete.
3439 * site.h (save_site_url): Remove declaration.
3440 * .cvsignore: Update autoconf generated files.
3441
bf137801
RC
34422003-07-26 Robert Collins <rbtcollins@hotmail.com>
3443
3444 * tests/Makefile.am: Driver for test suite.
3445 * tests/UserSettingTest.cc: Test UserSetting interface.
3446 * tests/UserSettingsTest.cc: Test UserSettings interface.
3447 * Makefile.am: Add the tests dir to recurse into.
3448 * configure.in: Ditto.
58b12a06
MB
3449 * UserSetting.h: Add load and save methods to allow global
3450 serialisation.
bf137801
RC
3451 Add explicit copy and assignment operators to prevent synthetics.
3452 Make the constructor protected to prevent direct instantiation.
3453 * UserSettings.h (UserSettings::loadAllSettings): New method.
3454 (UserSettings::savedAllSettings): New method.
3455 * UserSettings.cc: Implement new methods.
3456 * site.cc: Implement stubs for new required UserSetting methods.
3457 * site.h (ChosenSite): Ditto.
58b12a06
MB
3458 * bz2lib/: Ran automake.
3459 * zlib/: Ran automake.
bf137801 3460
3d5a4f16
MB
34612003-07-23 Max Bowsher <maxb@ukf.net>
3462
3463 * desktop.cc (DesktopSetupPage::OnBack): Remove obsolete use of NEXT().
3464 * root.cc (RootPage::OnNext): Ditto.
3465 (RootPage::OnBack): Ditto.
3466 * install.cc (do_install_thread): Remove obsolete use of next_dialog.
3467 * main.cc (main): Ditto.
3468 * postinstall.cc (do_postinstall_thread): Ditto.
3469
7108d406
MB
34702003-07-23 Max Bowsher <maxb@ukf.net>
3471
3472 * dialog.h (do_choose, do_desktop, do_local_dir, do_net, do_other)
3473 (do_root, do_site, do_source, do_splash): Remove declarations, since
3474 these functions no longer exist.
3475
b1c23913
MB
34762003-07-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3477
3478 * choose.cc (initialized): Remove obsolete file scope variable.
3479
d52a6cc8
MB
34802003-07-18 Max Bowsher <maxb@ukf.net>
3481
3482 * res.rc: Make caption of every dialog page begin with "Cygwin Setup".
3483 This aids recognition when minimized.
3484 Prompted by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
3485
9d53f045
MB
34862003-07-10 Jeremy White <jwhite@codeweavers.com>
3487
3488 * mount.cc, root.cc, site.cc: Make StringOptions required,
3489 thereby making --longopt <parm> behave as a newbie would expect.
3490
12e726c4
MB
34912003-07-08 Max Bowsher <maxb@ukf.net>
3492
3493 * LogFile.h, cistring.h, dialog.h, diskfull.h, filemanip.h, geturl.h,
3494 hash.h, log.h, mkdir.h, mklink2.h, mount.h, msg.h, netio.h, nio-file.h,
3495 nio-ftp.h, nio-http.h, nio-ie5.h, port.h, simpsock.h, state.h,
3496 version.h: Add inclusion guard.
3497 * root.h: Standardize naming of inclusion guard.
3498
c93bc6d0
MB
34992003-06-23 Max Bowsher <maxb@ukf.net>
3500
3501 * AntiVirus.h, Exception.h, FilterVisitor.h, FindVisitor.h,
3502 IOStreamProvider.h, IniDBBuilder.h, IniDBBuilderPackage.h,
3503 IniParseFeedback.h, IniParseFindVisitor.h, LogSingleton.h, MD5++.h,
3504 PackageSpecification.h, PackageTrust.h, PickCategoryLine.h, PickLine.h,
3505 PickPackageLine.h, PickView.h, RECTWrapper.h, ScanFindVisitor.h,
3506 String++.h, UserSetting.h, UserSettings.h, archive.h, archive_tar.h,
3507 category.h, choose.h, compress.h, compress_bz.h, compress_gz.h,
3508 cygpackage.h, desktop.h, download.h, find.h, ini.h, io_stream.h,
3509 io_stream_cygfile.h, io_stream_file.h, io_stream_memory.h,
3510 io_stream_rsync.h, localdir.h, net.h, package_db.h, package_meta.h,
3511 package_source.h, package_version.h, proppage.h, propsheet.h, script.h,
3512 site.h, source.h, splash.h, threebar.h, win32.h, window.h:
3513 Standardize naming and placement of inclusion guards.
3514
4a2af5fb
MB
35152003-06-22 Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>
3516
3517 * res.rc (all dialogs): Change font from "MS Sans Serif" to
3518 "MS Shell Dlg".
3519
8b726ef6
MB
35202003-06-22 Max Bowsher <maxb@ukf.net>
3521
3522 * Makefile.am: Clarify comment.
3523 Derive AM_CFLAGS from AM_CXXFLAGS, rather than the other way around.
3524 (AM_CXXFLAGS): Remove -Wmissing-declarations - it is a C-only warning.
3525 (AM_CFLAGS): Add -Winline, and -Wmissing-declarations.
3526
1e9ebf8a
MB
35272003-06-22 Max Bowsher <maxb@ukf.net>
3528
3529 * rfc1738.cc (rfc1738_do_escape): Eliminate redundant conditional.
3530
0a539fe4
MB
35312003-06-05 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3532
3533 * window.h (SETUP_WINDOW_H): Rename multi-include guard.
3534 (Copyright): Update.
3535 (RECTWrapper): New forward declaration.
3536 (Window::Create): Move.
3537 (Window::MoveWindow): New overload declaration.
3538 * window.cc: (RECTWrapper.h) Include.
3539 (Copyright): Update.
3540 (Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
3541 of C-style casts.
3542 (Window::MoveWindow): New overload.
3543
3c0ca7aa
MB
35442003-05-31 Max Bowsher <maxb@ukf.net>
3545
3546 * res.rc: Resize title controls to fully fill available width.
3547
e0d021d0
MB
35482003-05-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3549
3550 * RECTWrapper.h: New file.
3551
1e3b2ad4
RC
35522003-04-12 Robert Collins <rbtcollins@hotmail.com>
3553
3554 * script.cc (Script::extension): Extract method from Script::run.
3555 (Script::run): Extract extension generation to Script::extension.
3556 * script.h (Script::extension): Declare.
3557
2533f348
RC
35582003-04-12 Robert Collins <rbtcollins@hotmail.com>
3559
3560 * script.cc (run_script): Remove.
3561 (try_run_script): Inline method run_script.
3562 * script.h (run_script): Remove.
3563
34ea5b6d
RC
35642003-04-12 Robert Collins <rbtcollins@hotmail.com>
3565
3566 * postinstall.cc (RunScript::operator()): Use new run syntax.
3567 * script.h (Script::run): Eliminate to_log parameter.
3568 * script.cc (Script::run): Ditto.
3569 (run_script): Use new run syntax.
3570
9f27ab95
RC
35712003-04-12 Robert Collins <rbtcollins@hotmail.com>
3572
3573 * script.cc (Script::run): Eliminate temp variable 'f2'.
3574 Rename temp variable 'f2' to 'windowsName' for increased clarity.
3575
783ed9c5
RC
35762003-04-12 Robert Collins <rbtcollins@hotmail.com>
3577
3578 * script.cc (Script::run): Eliminate temp variable 'fname'.
3579
0900bd5b
RC
35802003-04-12 Robert Collins <rbtcollins@hotmail.com>
3581
3582 * script.cc (Script::run): Eliminate temp variable 'dir'.
3583
294e5067
RC
35842003-04-12 Robert Collins <rbtcollins@hotmail.com>
3585
3586 * script.cc (run_script): Always pass TRUE to Script::run.
3587 * script.h (run_script): Remove optional to_log parameter.
3588
a0e56f67
RC
35892003-04-12 Robert Collins <rbtcollins@hotmail.com>
3590
3591 * script.cc (run_script): Move functionality into Script.
3592 (Script::run): Absorb run_script.
3593
8c242540
RC
35942003-04-12 Robert Collins <rbtcollins@hotmail.com>
3595
3596 * PickCategoryLine.cc (PickCategoryLine::click): Tell packagemeta we
3597 are about to perform a visit.
3598 * PickPackageLine.cc (PickPackageLine::click): Tell packagemeta we
3599 are about to perform a visit.
ca2b7505 3600 * package_db.cc (packagedb::markUnVisited): Convenience wrapper -
8c242540
RC
3601 mark all packages as unvisited.
3602 * package_db.h (packagedb::markUnVisited): Declare.
3603 * package_meta.cc (packagemeta::PrepareForVisit): New static method
3604 to prepare for a loop-free visit.
3605 (packagemeta::packagemeta): Adjust for new member.
3606 (packagemeta::set_requirements): Only visit a node once.
3607 (packagemeta::visited): Get and Set methods for new member visited_.
3608 * package_meta.h (packagemeta::PrepareForVisit): Declare.
3609 (packagemeta::visited): Declare.
3610 (packagemeta::visited_): Declare.
3611
5f4b0e57
MB
36122003-04-07 Max Bowsher <maxb@ukf.net>
3613
3614 * download.cc: Add command line option to suppress MD5 checks.
3615 (validateCachedPackage): Test option and possibly skip.
3616
e46e15bf
RC
36172003-04-02 Robert Collins <rbtcollins@hotmail.com>
3618
3619 Merge in setup-200303-troubleshooting fixes.
3620
36212003-04-02 Robert Collins <rbtcollins@hotmail.com>
3622
3623 * main.cc (NTSecurity::setDefaultDACL): Reinstate commented code.
3624 (NTSecurity::setDefaultSecurity): Ditto.
3625
36262003-04-02 Robert Collins <rbtcollins@hotmail.com>
3627
3628 * main.cc (NTSecurity::setDefaultDACL): Use MS calculations for ACL
3629 buffer sizing.
3630
36312003-04-02 Robert Collins <rbtcollins@hotmail.com>
3632
3633 * main.cc (NTSecurity::setDefaultDACL): Sanity check memory allocation.
3634
36352003-04-02 Robert Collins <rbtcollins@hotmail.com>
3636
58b12a06
MB
3637 * main.cc (NTSecurity::setDefaultDACL): Adjust commented code for
3638 auto_ptr use.
e46e15bf
RC
3639
36402003-04-02 Robert Collins <rbtcollins@hotmail.com>
3641
3642 * main.cc (NTSecurity::NoteFailedAPI): Helper function.
3643 Use throughout NTSecurity routines.
3644 (NTSecurity::setDefaultDACL): Use dynamic memory for ACL storage.
3645
36462003-04-02 Robert Collins <rbtcollins@hotmail.com>
3647
58b12a06
MB
3648 * main.cc (NTSecurity::setDefaultDACL): Disable ~ 50% of remaining
3649 active code.
e46e15bf
RC
3650
36512003-04-02 Robert Collins <rbtcollins@hotmail.com>
3652
3653 * main.cc (NTSecurity::GroupInfo): Extract group query code.
3654 (NTSecurity::setDefaultDACL): Disable ~ 50% of code.
3655
36562003-04-02 Robert Collins <rbtcollins@hotmail.com>
3657
58b12a06
MB
3658 * main.cc (NTSecurity::setDefaultSecurity): Disable ~ 50% of security
3659 code.
e46e15bf
RC
3660
36612003-04-01 Robert Collins <rbtcollins@hotmail.com>
3662
58b12a06
MB
3663 * main.cc (NTSecurity::setDefaultSecurity): Remove double declaration of
3664 sz. User TokenGroupCollection to abstract token searching logic,
3665 eliminate isadmin and isuser temporary variables.
e46e15bf
RC
3666 (TokenGroupCollection): New class for querying token group information.
3667
36682003-04-01 Robert Collins <rbtcollins@hotmail.com>
3669
3670 * main.cc (NTSecurity::setDefaultSecurity): Extract esid initialisation.
3671 Move local variables to just before first use.
3672 SetTokenInformationFailures where being handled inconsistently.
3673 Remove assignments from if statements.
3674 (NTSecurity::esid): Rename to everyOneSID.
3675 (NTSecurity::initialiseEveryOneSID): new method.
3676 (NTSecurity::setDefaultDACL): Extract method for default DACL logic.
3677
36782003-04-01 Robert Collins <rbtcollins@hotmail.com>
3679
3680 * main.cc (SIDWrapper): Manage SID memory.
3681 (HANDLEWrapper): Likewise for HANDLES.
3682 (NTSecurity): Worker class for set_default_sec().
3683 (set_default_sec): Move body into NTSecurity::setDefaultSecurity().
58b12a06
MB
3684 (NTSecurity::setDefaultSecurity): Eliminate goto out: via memory
3685 managing objects.
e46e15bf 3686
da0b54f3
MB
36872003-04-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3688
3689 * cygwin.ico: Added two new resolutions, 64x64 and 72x72.
3690
3baca7c9
RC
36912003-03-29 Robert Collins <rbtcollins@hotmail.com>
3692
3693 * GUIDELINES: New file documenting code guidelines.
3694
11e37aca
MB
36952003-03-26 Max Bowsher <maxb@ukf.net>
3696
3697 * .cvsignore: Add cfgaux.
3698
18a3405d
RC
36992003-03-26 Robert Collins <rbtcollins@hotmail.com>
3700
11e37aca
MB
3701 * package_version.cc (_defaultversion::accessible): Override and make
3702 always false.
3703 (_packageversion::accessible): Fix a couple of logic bugs resulting in
3704 incorrect trues.
18a3405d
RC
3705 * package_version.h (_packageversion::accessible): Make virtual.
3706
39ba3555
MB
37072003-03-25 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3708
3709 * threebar.h (WM_APP_START_POSTINSTALL): New message.
3710 (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message.
3711 * threebar.cc (ThreeBarProgressPage::OnMessageApp):
3712 Add handling for WM_APP_START_POSTINSTALL and
3713 WM_APP_POSTINSTALL_THREAD_COMPLETE.
3714 * install.cc (do_install_thread): Set next_dialog to
3715 IDD_S_POSTINSTALL.
3716 * desktop.cc (DesktopSetupPage::OnFinish): Move the
3717 do_postinstall call to ThreeBarProgressPage::OnMessageApp.
3718 * script.h (Script::fullName): New member function.
3719 (Script::run): New member function.
3720 (Script::ETCPostinstall): New static member constant.
3721 * script.cc (Script::fullName): Implement.
3722 (Script::run): Implement.
3723 (Script::ETCPostinstall): Define.
3724 (Script::isAScript): Use ETCPostinstall instead of a
3725 hardcoded string constant.
3726 (run): Enable "#if 0"'d code.
3727 * postinstall.cc (Progress): New extern variable.
3728 (RunFindVisitor::visitFile): Add script to vector
3729 instead of running.
3730 (RunFindVisitor::_scripts): New member variable.
3731 (RunScript): New helper class for use in for_each.
3732 (do_postinstall_thread): Rename do_postinstall to. Add
3733 Progress bar and text setting. Add package count.
3734 (do_postinstall_reflector): New static function.
3735 (do_postinstall): Rename to do_postinstall_thread.
3736 Create a thread instead.
3737
1069407c
MB
37382003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3739
3740 * script.cc (run): Add file_out parameter.
3741 Redirect output of subprocess to file, creating the
3742 path if necessary. Minimize the script window.
3743 (run_script): Add optional to_log boolean parameter.
3744 If to_log, redirect output to temporary file and then
3745 import it into LOG_BABBLE.
3746 (OutputLog): New helper class.
3747 (operator<<): New operation on OutputLog.
3748 * script.h (run_script): Add optional to_log parameter.
3749 * postinstall.cc (RunFindVisitor::visitFile): Instruct
3750 run_script() to log script output.
3751 (do_postinstall): Ditto.
3752
84fd41a9
RC
37532003-03-20 Robert Collins <rbtcollins@hotmail.com>
3754
ca2b7505 3755 * package_meta.cc (packagemeta::set_action): The logic
84fd41a9
RC
3756 test for the default action was reversed.
3757
864a5ec1
MB
37582003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3759
3760 * postinstall.cc (do_postinstall): Filter out '*.done'.
3761 * FilterVisitor.h: New header file. Declare the
3762 FilterVisitor, Filter, and ExcludeNameFilter classes.
3763 * FilterVisitor.cc: New file. Implement FilterVisitor,
3764 Filter, and ExcludeNameFilter.
3765 * String++.h (String::matches): New instance function.
3766 * String++.cc (String::matches): Implement.
3767 (strmatch) Import and adapt for <buf,len> strings.
3768 * Makefile.am (setup_SOURCES): Add FilterVisitor.cc and
3769 FilterVisitor.h to value.
3770
560ac5e2
MB
37712002-03-18 Max Bowsher <maxb@ukf.net>
3772
3773 * LogFile.cc (LogFile::exit): Use CRT exit() instead of ExitProcess().
3774 Use passed exit_code even if been_here.
3775 Remove incorrect _CYGWIN_ preprocessor conditional.
3776
ad646f43
RC
37772003-03-16 Robert Collins <rbtcollins@hotmail.com>
3778
e0312c44
RC
3779 * package_db.h (PackageDBConnectedIterator): Typedef
3780 for connected loop detection collection iterator.
ca2b7505
CF
3781 * package_db.cc (ConnectedLoopDetector): An
3782 implementation of R.E. Tarjans strongly connected
e0312c44
RC
3783 set visitor algorithm.
3784 * postinstall.cc (do_postinstall): Use the new iterator
3785 for visiting postinstall scripts.
ad646f43
RC
3786
37872003-03-16 Robert Collins <rbtcollins@hotmail.com>
3788
3789 * install.cc: Introduce Installer class.
3790 (init_dialog): Rename to Installer::initDialog.
3791 (progress): Rename to Installer::progress.
3792 (standard_dirs): Rename to Installer::StandardDirs.
3793 (uninstall_one): Rename to Installer::uninstallOne.
3794 (replace_one): Rename to Installer::replaceOne.
ca2b7505 3795 (log_ror_failure): Rename to
e0312c44 3796 Installer::replaceOnRebootFailed.
ca2b7505 3797 (log_ror_success): Rename to
e0312c44 3798 Installer::replaceOnRebootSucceeded.
ad646f43
RC
3799 (install_one_source): Rename to Installer::installOneSource.
3800 Note script files as they are installed.
3801 * package_version.cc (packageversion::addScript): Implement.
3802 (packageversion::scripts): Implement.
ca2b7505 3803 * package_version.h (packageversion::addScript): Record the
e0312c44 3804 presence of a script.
ad646f43 3805 * script.h (Script): New class to track scripts.
e0312c44
RC
3806 * postinstall.cc (do_postinstall): Iterate through the
3807 package listed scripts before searching for scripts.
ca2b7505 3808 * String++.cc (String::substr): Second argument needed to
e0312c44 3809 be signed.
ca2b7505 3810 * String++.h (String::substr): Second argument needed to
e0312c44 3811 be signed.
ad646f43 3812
c0a46d04
MB
38132003-03-16 Max Bowsher <maxb@ukf.net>
3814
3815 * .cvsignore: Create, to ignore configure, aclocal.m4, Makefile.in and
3816 autom4te.cache.
3817
3d7ae5a2
MB
38182003-03-16 Max Bowsher <maxb@ukf.net>
3819
3820 * UserSettings.cc (UserSettings::Instance): Remove premature return.
3821
92f9402a
RC
38222003-03-15 Robert Collins <rbtcollins@hotmail.com>
3823
3824 * script.cc (run): Rename variable b to createSucceeded.
3825
38262003-03-15 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3827
3828 * script.cc (run): Close unneeded handles.
3829
b49f570f
RC
38302003-03-15 Robert Collins <rbtcollins@hotmail.com>
3831
3832 * configure: Remove.
3833 * aclocal.m4: Remove.
3834 * Makefile.in: Remove.
3835 * cfgaux: Remove.
3836 * cfgaux/compile: Remove.
3837 * cfgaux/config.guess: Remove.
3838 * cfgaux/config.sub: Remove.
3839 * cfgaux/depcomp: Remove.
3840 * cfgaux/install-sh: Remove.
3841 * cfgaux/ltmain.sh: Remove.
3842 * cfgaux/missing: Remove.
3843 * cfgaux/mkinstalldirs: Remove.
3844
b6001c0d
MB
38452003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3846
3847 * install.cc (replace_one): Clear Text3.
3848
46ccc05f
MB
38492003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3850
3851 * install.cc (install_one_source): Add logging for successful
3852 replace-on-reboot scheduling. Factor out duplicate code.
3853 Set rebootneeded on Win9x.
3854 (log_ror_failure): New static function.
3855 (log_ror_success): New static function.
3856
c27b09ba
RC
38572003-03-14 Robert Collins <rbtcollins@hotmail.com>
3858
ca2b7505 3859 * choose.cc (ChooserPage::OnNext): Fix iterator bug. Reported by
c27b09ba
RC
3860 Igor Pechtchanski <pechtcha@cs.nyu.edu>.
3861
a081d4ff
MB
38622003-03-13 Max Bowsher <maxb@ukf.net>
3863
3864 * Update included zlib to 1.1.4.
3865
f430003c
RC
38662003-03-13 Robert Collins <rbtcollins@hotmail.com>
3867
46ccc05f
MB
3868 * install.cc (do_install_thread): Use a query method rather than temp
3869 variable do_skip.
f430003c 3870
46ccc05f 38712003-03-09 Pavel Tsekov <ptsekov@gmx.net>
f430003c 3872
ca2b7505 3873 * install.cc (do_install_thread): Use IDS_SKIP_PACKAGE
f430003c
RC
3874 instead of IDS_CORRUPT_PACKAGE when asking the user to take
3875 action if the hash verification check fails for a source package.
3876 Do not increase the value of 'total_bytes' variable if the
3877 user chooses to skip over a package, which failed the hash
3878 verification.
3879
48c7d667
MB
38802003-03-10 Max Bowsher <maxb@ukf.net>
3881
3882 * Makefile.am: Add foreign to AUTOMAKE_OPTIONS.
3883
aaeee283
RC
38842003-03-10 Robert Collins <rbtcollins@hotmail.com>
3885
3886 * UserSettings.cc (UserSettings::init): Really initialize all members.
3887
ead15931
RC
38882003-03-10 Robert Collins <rbtcollins@hotmail.com>
3889
3890 * Exception.h: Add a logic error exception id.
3891 * Makefile.am: Add new sources.
3892 * UserSettings.cc: New file.
3893 * UserSettings.h: New file.
3894 * UserSetting.cc: New file.
3895 * UserSetting.h: New file.
3896 * site.h: Add a SiteSetting as example of a UserSetting.
46ccc05f
MB
3897 * site.cc (ChosenSites): Add a instance of SiteSetting to trigger
3898 registration.
ead15931 3899
c1754473
RC
39002003-03-10 Robert Collins <rbtcollins@hotmail.com>
3901
46ccc05f
MB
3902 * compress_bz.cc (compress_bz::read): Adjust incorrect assignment of
3903 lasterr.
c1754473
RC
3904 (compress_bz::error): Return lasterr which will indicate any error.
3905
52620058
RC
39062003-03-10 Robert Collins <rbtcollins@hotmail.com>
3907
3908 * choose.h (ChooserPage): Override OnActivate.
46ccc05f
MB
3909 * choose.cc (ChooserPage::OnActivate): Refresh the current view when
3910 activating the dialog.
52620058 3911
6e754226
RC
39122003-03-09 Robert Collins <rbtcollins@hotmail.com>
3913
46ccc05f
MB
3914 * package_version.cc (_defaultversion::pick(bool)): Override this and
3915 do nothing.
3916 (packageversion::pick(bool): Use a mutator function rather than direct
3917 member access.
3918 * package_version.h (_packageversion::pick(bool)): Move method from
3919 _packageversion.
6e754226 3920
970149e8
RC
39212003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3922
ca2b7505 3923 * install.cc (install_one_source): Remove the MD5 verification
970149e8
RC
3924 code.
3925 Delay the creation of the package listing file.
ca2b7505 3926 (do_install_thread): Check the hashes for packages which need
970149e8
RC
3927 to be installed before the uninstall step. Allow the user to
3928 skip over packages, which fail the hash verification.
3929 (md5_one): Define new function.
3930 * res.rc (IDS_SKIP_PACKAGE): New string resource.
3931 * resource.h (IDS_SKIP_PACKAGE): New macro definition.
3932
f37b36a3
RC
39332003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3934
3935 * Exception.h: Declare new constructor.
3936 (Exception::_message): Change the type from 'const char *' to
3937 'class String'.
3938 (Exception::~Exception): Implement destructor (make gcc shut up).
3939 * Exception.cc: Implement new constructor.
3940 (Exception::what): Use String::cstr_oneuse ().
3941 * download.cc (validateCachedPackage): Use the constructor, which
3942 takes String& as its second argument, when throwing objects
3943 of type Exception.
3944 (check_for_cached): Ditto.
3945 * install.cc (install_one_source): Ditto.
3946
eef9ea26
RC
39472003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3948
3949 * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
3950 log filename to %s.
3951 (IDS_MISSING_LOG): New string resource.
3952 * resource.h (IDS_MISSING_LOG): New resource.
3953 * LogFile.cc (LogFile::exit): Pass log filename for
3954 LOG_BABBLE to note().
3955 (LogFile::getFileName): New function.
3956 * LogFile.h (LogFile::getFileName): New function.
3957
514b100e
RC
39582003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3959
3960 * String++.cc: Don't include concat.h.
3961 * Makefile.am: Remove concat.cc and concat.h references.
3962 * concat.h: Remove.
3963 * concat.cc: Remove.
3964
56c60dcc
MB
39652003-03-09 Max Bowsher <maxb@ukf.net>
3966
3967 * bootstrap.sh: Add sanity check of current directory.
3968 Recurse into libgetopt++ if needed.
3969
4f4b9def
RC
39702003-03-09 Robert Collins <rbtcollins@hotmail.com>
3971
3972 * Update readme of bugs and wishes.
3973
ed6137e5
MB
39742003-03-05 Max Bowsher <maxb@ukf.net>
3975
3976 * netio.cc (save_dialog): Allocate an empty string if the password is
3977 null, so that an empty password is accepted elsewhere in setup.
3978 (check_if_enable_ok): An empty password is OK.
3979
e0aec95e
MB
39802003-03-05 Brian Keener <bkeener@thesoftwaresource.com>
3981
ed6137e5 3982 * PickView.cc (PickView::views): Add two new views for Skipped
e0aec95e
MB
3983 packages and Installed Packages not requiring update.
3984 (PickView::set_headers () ): Ditto.
3985 (PickView::clear_view (void) ): Ditto.
3986 (PickView::views::caption () ): Add two new captions for the new
3987 views added for Skipped and Installed Packages.
3988 (PickView::scroll () ): Modify Scroll Bar property to Disable
ed6137e5 3989 instead of disappearing when there is nothing to Scroll.
e0aec95e
MB
3990 * PickView.h: Add two new views for Skipped packages and Installed
3991 packages to public class view.
3992 * choose.cc (list_click () ): Modify Scroll Bar property to Disable
ed6137e5 3993 instead of disappearing when there is nothing to Scroll.
e0aec95e
MB
3994 (listview_proc () ): Ditto.
3995 (set_view_mode): Add two new views for Skipped Packages and Installed
3996 Packages not requiring update. Modify Scroll Bar property to Disable
3997 instead of disappearing when there is nothing to scroll.
3998 * res.rc (IDD_CHOOSE): Reposition Radio Buttons, View Selection
3999 Button and View Button Caption to make room for longer captions.
4000
c7fb2f36
MB
40012003-03-04 Max Bowsher <maxb@ukf.net>
4002
4003 * compress_gz.cc (compress_gz::construct):
4004 Fix broken checkin dated 2002-07-03.
4005
d5be1d23
MB
40062003-02-28 Max Bowsher <maxb@ukf.net>
4007
4008 * main.cc (set_default_sec): Add logging.
4009
adaa168a
MB
40102003-02-28 Pierre Humblet <pierre.humblet@ieee.org>
4011
4012 * main.cc (set_default_dacl): Replace with set_default_sec.
4013 (set_default_sec): Attempt to change the default group to
4014 Users or Administrators if it is None, in addition to setting
4015 Everyone in the default DACL.
4016 (main): Call set_default_sec instead of set_default_dacl.
4017
3a8d1127
MB
40182003-01-31 Max Bowsher <maxb@ukf.net>
4019
4020 * install.cc (install_one_source): Fix spacing in log message.
4021
c7230a28
MB
40222003-01-19 Max Bowsher <maxb@ukf.net>
4023
4024 * resource.h (IDC_CHOOSE_KEEP): Define.
4025 * res.rc (IDD_CHOOSE): Add radio button IDC_CHOOSE_KEEP.
4026 * choose.cc (create_listview): Add IDC_CHOOSE_KEEP to ta[].
4027 (ChooserPage::OnMessageCmd): Handle new IDC_CHOOSE_KEEP button.
4028
ac949c48
MB
40292003-01-15 Max Bowsher <maxb@ukf.net>
4030
4031 * mkdir.cc [_CYGWIN_]: Implement what was pseudocode.
4032 * io_stream.h [__CYGWIN__]: Don't typedef ssize_t.
4033 * proppage.h: Include "win32.h" instead of <windows.h>.
4034
4f618d88
MB
40352003-01-15 Max Bowsher <maxb@ukf.net>
4036
4037 * mount.cc [MAINTAINER_FEATURES]: Add --override-registry-name option.
4038
1606c4e9
MB
40392002-12-11 Abraham Backus <abraham@backus.com>
4040
4041 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Leave port out of Host header,
4042 unless non-default.
4043
c4e25cde
MB
40442002-12-11 Max Bowsher <maxb@ukf.net>
4045
4046 * package_meta.cc: Change 'endl' to 'endLog' as appropriate.
4047 * package_version.cc: Ditto.
4048
bfdf6ac2
MB
40492002-09-22 Max Bowsher <maxb@ukf.net>
4050
4051 * PickView.cc (pkg_headers): Rename column 'Category' to 'Categories'.
4052 * package_meta.h (packagemeta::getReadableCategoryList): Declare.
4053 * package_meta.cc (packagemeta::getReadableCategoryList): Implement.
4054 * PickPackageLine.cc (PickPackageLine::paint): Change to use
4055 getReadableCategoryList.
4056 Fix x2 argument to IntersectClipRect.
4057
63c82708
RC
40582002-11-25 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
4059
4060 * window.h (Window::GetWindowRect): New method declaration.
4061 (Window::GetClientRect): Ditto.
4062 (Window::MoveWindow): Ditto.
4063 (Window::ScreenToClient): Ditto.
4064 * window.cc (REFLECTION_INFO): Remove.
4065 (ReflectionInfo): Remove.
4066 (Window::FirstWindowProcReflector): Use the WM_NCCREATE message instead
4067 of the horrid REFLECTION_INFO hack to hook the Window instance to the
4068 HWND instance.
4069 (Window::WindowProcReflector): Use GetWindowLongPtr() now that it's
4070 available.
4071 (Window::Create): Change to use new WM_NCCREATE reflection procedure
4072 above.
4073 (Window::GetWindowRect): New method.
4074 (Window::GetClientRect): New method.
4075 (Window::MoveWindow): New method.
4076 (Window::CenterWindow): Use new methods, also specify "::" for some non-
4077 member functions with the same names.
4078 (Window::ScreenToClient): New method.
4079
58983805
RC
40802002-11-26 Robert Collins <rbtcollins@hotmail.com>
4081
4082 * AntiVirus.cc: Change the short option again! It's now 'A'.
4083 * desktop.cc (etc_profile): Remove.
4084 (make_etc_profile): Remove.
4085 (uexists): Remove.
4086 (make_passwd_group): Remove.
4087 (do_desktop_setup): Don't call removed functions.
4088
b2028692
RC
40892002-11-26 Robert Collins <rbtcollins@hotmail.com>
4090
4091 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fix my botched application of
4092 Marcel's patch.
4093
2d8e4784
RC
40942002-07-08 Marcel Telka <marcel@telka.sk>
4095
b2028692 4096 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fixed decoding of the FTP
2d8e4784
RC
4097 reply (code 227) to the PASV command.
4098
3a87705e
RC
40992002-11-26 Robert Collins <rbtcollins@hotmail.com>
4100
4101 * IniDBBuilderPackage.cc (IniDBBuilderPackage::~IniDBBuilderPackage):
4102 Sort the packages db once all the new packages have been added.
4103 * IniDBBuilderPackage.h (IniDBBuilderPackage::~IniDBBuilderPackage):
4104 Declare this.
4105
bd4e91a7
RC
41062002-11-26 Robert Collins <rbtcollins@hotmail.com>
4107
4108 * choose.cc (ChooserPage::OnNext): Remove extracted comment.
4109 * package_version.cc (processOneDependency): Return once selecting
4110 a package (bugfix to prevous rework).
4111 Log if the default trust fails the package specification.
4112
f416a2b6
RC
41132002-11-26 Robert Collins <rbtcollins@hotmail.com>
4114
4115 * package_meta.h (packagemeta::logAllVersions): Declare.
4116 (packagemeta::trustLabel): Ditto.
ca2b7505 4117 * choose.cc (ChooserPage::OnNext): Get each package to log all it's
f416a2b6
RC
4118 versions.
4119 * package_meta.cc (packagemeta::logAllVersions): Implement.
4120 (packagemeta::trustLabel): Ditto.
4121
14485ab2
RC
41222002-11-25 Robert Collins <rbtcollins@hotmail.com>
4123
4124 * AntiVirus.cc: Change 'd' to 'D' to fix command line conflict.
4125
f9e903a3
RC
41262002-11-25 Robert Collins <rbtcollins@hotmail.com>
4127
4128 * AntiVirus.cc: New file.
4129 * AntiVirus.h: Ditto.
4130 * LogFile.cc: Include AntiVirus.h for class definition.
4131 (LogFile::exit): Trigger AntiVirus::AtExit().
4132 * MakeFile.am(setup_SOURCES): Add AntiVirus files.
4133 * autoload.c: Declare Service Control Manager related API's.
4134 * main.cc: Include AntiVirus.h for class definition.
4135 (main): Add the AntiVirus page in.
4136 * res.rc: Define IDD_VIRUS.
4137 * resource.h: Define IDD_VIRUS related control ID's.
4138 * splash.h: Override OnNext.
4139 * splash.cc: Only show AntiVirus page when one has been detected.
4140 * source.cc: Ditto.
4141
05c5b8a6
RC
41422002-11-25 Robert Collins <rbtcollins@hotmail.com>
4143
4144 * package_version.cc (DependencyProcessor): Create convenience class.
4145 (select): Extract version selection method.
4146 (processOneDependency): Check for a satisfactory trusted version
4147 first.
4148
41492002-11-10 Robert Collins <rbtcollins@hotmail.com>
15004270
RC
4150
4151 * main.cc (main): Use the factory for LogFile.
4152 * String++.cc: Update to use sstream.
58b12a06 4153 (String::String): Use a ostringstream for libC++ 3.2.
15004270
RC
4154 * LogFile.h (LogFile): Make createLogFile static.
4155
05c5b8a6 41562002-11-10 Robert Collins <rbtcollins@hotmail.com>
51629951
RC
4157
4158 * main.cc (main): Oops, pass LogSingleton a reference, not a pointer.
4159
666bf37d
RC
41602002-11-04 Max Bowsher <maxb@ukf.net>
4161
4162 * Exception.h (Exception::what): Add throw() specification,
4163 to agree with libstdc++-v3.
4164 * Exception.cc (Exception::what): Ditto.
4165 * IniDBBuilderPackage.h: Add 'std::' where needed.
4166 * PickCategoryLine.h: Ditto.
4167 * category.h: Ditto.
4168 * package_db.h: Ditto.
4169 * package_meta.h: Ditto.
4170 * package_source.h: Ditto.
4171 * package_version.h: Ditto.
4172 * site.h: Ditto.
4173 * win32.h: Define NOMINMAX before including <windows.h>.
4174 * package_meta.cc: Add 'using namespace std;'.
4175 (packagemeta::set_requirements): Remove default parameter values
4176 from definition (gcc3 likes them only in declaration).
4177 * package_version.cc: Add 'using namespace std;'.
4178 (packageversion::set_requirements): Remove default parameter
4179 values from definition (gcc3 likes them only in declaration).
4180
37decc22
RC
41812002-11-10 Robert Collins <rbtcollins@hotmail.com>
4182
4183 * compress_bz.cc: Don't include bzlib.h directly, the compress_bz.h
4184 header includes it.
4185
41862002-11-04 Max Bowsher <maxb@ukf.net>
4187
ca2b7505
CF
4188 * compress_bz.h: #undef small before including bzlib.h - if we are
4189 going to hide the fact that we are _WIN32 from bzlib, then we need
37decc22
RC
4190 to #undef small for it as well (bad windows.h clash).
4191
a55c8f45
RC
41922002-11-10 Robert Collins <rbtcollins@hotmail.com>
4193
4194 * localdir.cc: Update the extern LogFile to be a pointer.
4195 (save_local_dir): Change . to -> for the above.
4196 * main.cc (theFile): Change from an instance to a pointer.
4197 (main): Change . to -> for the above.
4198
c83c52d8
RC
41992002-11-10 Robert Collins <rbtcollins@hotmail.com>
4200
4201 * LogFile.cc: use 'std::' where needed throughout.
4202 (LogFile::createLogFile): Implement a factory for LogFile.
4203 (LogFile::LogFile): Update for use with the factory, and to
4204 handle the latest g++ library changes.
4205 (LogFile::operator()): Ditto.
4206 (LogFile::endEntry()): Ditto.
4207 * LogFile.h: Ditto.
4208 * LogSingleton.cc: Ditto.
4209 * LogSingleton.h: Ditto.
4210
318af134
RC
42112002-11-04 Max Bowsher <maxb@ukf.net>
4212
4213 * String++.h: Add 'std::' where needed.
4214
6625e635
RC
42152002-11-04 Max Bowsher <maxb@ukf.net>
4216
4217 * IniDBBuilderPackage.cc: Add 'using namespace std;'.
4218 * IniParseFindVisitor.cc: Ditto.
4219 * LogFile.cc: Ditto.
4220 * LogSingleton.cc: Ditto.
4221 * PickView.cc: Ditto.
4222 * String++.cc: Ditto.
4223 * choose.cc: Ditto.
4224 * download.cc: Ditto.
4225 * find.cc: Ditto.
4226 * install.cc: Ditto.
4227 * io_stream.cc: Ditto.
4228 * io_stream_file.cc: Ditto.
4229 * package_db.cc: Ditto.
4230 * root.cc: Ditto.
4231 * site.cc: Ditto.
4232
955bf437
RC
42332002-11-04 Max Bowsher <maxb@ukf.net>
4234
4235 * LogSingleton.h: Add 'std::' where needed.
4236
b34fb59f
RC
42372002-11-04 Max Bowsher <maxb@ukf.net>
4238
4239 * archive_tar_file.cc: Include <algorithm>.
4240 Change min(a,b) to std::min(a,b)
4241 * compress_bz.cc: Ditto.
4242 * compress_gz.cc: Ditto.
4243
326fbcb8
RC
42442002-11-04 Max Bowsher <maxb@ukf.net>
4245
4246 * res.rc: Change a #-comment (invalid) to a //-comment.
4247
4361306f
RC
42482002-11-04 Max Bowsher <maxb@ukf.net>
4249
4250 * Makefile.am (%.o: %.rc): Make windres use $(CC) not hardcoded gcc.
58b12a06
MB
4251 (inilint_LDADD): Remove -lstd++.
4252 (setup_LDADD): Ditto.
4361306f 4253
05d7b7f2
RC
42542002-09-22 Max Bowsher <maxb@ukf.net>
4255
4256 * IniDBBuilderPackage.cc: Update DEBUG code to current class
4257 layout.
4258
f2ff9838
RC
42592002-09-21 Robert Collins <rbtcollins@hotmail.com>
4260
4261 * choose.h: Add OnUnattended method.
4262 * desktop.cc (DesktopSetupPage::OnInit): Allow fine grained
4263 control via command line options.
4264 (DesktopSetupPage::OnUnattended): Implement.
4265 (DesktopSetupPage::OnMessageApp): Implement.
4266 * desktop.h (DesktopSetupPage::OnUnattended): declare.
4267 (DesktopSetupPage::OnMessageApp): Ditto.
4268 * download.cc (do_download_thread): Support unattended mode.
4269 * install.cc (do_install_thread): Ditto.
4270 * localdir.h: Ditto.
4271 * main.cc (main): Ditto.
4272 * net.cc (NetPage::OnUnattended): Ditto.
4273 * net.h (NetPage::OnUnattended): Declare.
4274 * proppage.cc (PropertyPage::DialogProc): Support unattended mode.
4275 * proppage.h (PropertyPage::OnUnattended): Declare.
4276 * root.cc (RootPage::OnInit): Support unattended mode.
4277 (RootPage::OnUnattended): Implement.
4278 * root.h (RootPage::OnUnattended): Declare.
4279 * site.cc (register_saved_site): Extract Method from get_saved_sites.
4280 (get_saved_sites): Remove common code for adding a site.
4281 (SitePage::OnInit): Support unattended mode.
4282 (SitePage::OnUnattended): Implement.
4283 * site.h (SitePage::OnUnattended): Declare.
4284 * source.cc (SourcePage::OnActivate): Support unattended mode.
4285 (SourcePage::OnUnattended): Implement.
4286 * source.h (SourcePage::OnUnattended): Declare.
4287 * splash.h (SplashPage::OnUnattended): Declare.
4288 * state.cc (unattended_mode): Declare.
4289 * state.h (unattended_mode): Declare.
4290 * threebar.h (ThreeBarProgressPage::OnUnattended): New method.
4291
707f3d66
RC
42922002-09-21 Robert Collins <rbtcollins@hotmail.com>
4293
4294 * res.rc: Commit Harry Johnston's dialog caption patch. From July.
4295
ec13f13c
RC
42962002-07-15 Robert Collins <rbtcollins@hotmail.com>
4297
4298 * package_version.cc (packageversion::sources): Implement this.
4299 * download.cc (do_download_thread): Support multiple files per package.
4300
e5662e0a
RC
43012002-07-15 Robert Collins <rbtcollins@hotmail.com>
4302
4303 * package_version.h (packageversion::sources): Support multiple files in
4304 a single package version.
4305 * package_version.cc (_packageversion::accessible): Ditto.
4306 (packageversion::source): Ditto.
4307
60daae94
RC
43082002-07-15 Robert Collins <rbtcollins@hotmail.com>
4309
4310 * iniparse.y: Implement support for multiple source files for a source
4311 package.
4312 * IniDBBuilder.h (IniDBBuilder::buildSourceFile): Ditto.
4313 * IniDBBuilderPackage.h (IniDBBuilder::buildSourceFile): Ditto.
4314 * IniDBBuilder.cc (IniDBBuilder::buildSourceFile): Ditto.
ca2b7505 4315 * IniDBBuilderPackage.cc (IniDBBuilder::buildSourceFile): Implement a
60daae94
RC
4316 stub as preparation.
4317
4f591f9d
RC
43182002-07-13 Robert Collins <rbtcollins@hotmail.com>
4319
ca2b7505 4320 * PickPackageLine.cc (PickPackageLine::click): Set requirements for
4f591f9d
RC
4321 packages under all circumstances - slightly higher overheader, simpler
4322 code.
ca2b7505 4323 * download.cc (do_download_thread): Correctly download source
4f591f9d
RC
4324 packages.
4325 * package_meta.cc (checkForInstalled): Remove.
4326 (checkForUpgradeable): Ditto.
4327 (checkForSatisfiable): Ditto.
4328 (processOneDependency): Ditto.
4329 (packagemeta::set_requirements): Move guts to packageversion.
4330 * package_version.cc (checkForInstalled): Copied from package_meta.cc.
4331 (checkForUpgradeable): Ditto.
4332 (checkForSatisfiable): Ditto.
4333 (processOneDependency): Ditto.
4334 (packageversion::set_requirements): Ditto.
4335 * package_version.h (packageversion::set_requirements): Declare.
4336
b1ff53ed
RC
43372002-07-13 Robert Collins <rbtcollins@hotmail.com>
4338
4339 * IniDBBuilder.cc (IniDBBuilder::buildBeginBuildDepends): Implement.
4340 (IniDBBuilder::buildBeginBinary): Implement.
4341 * IniDBBuilder.h (IniDBBuilder::buildBeginBuildDepends): Declare.
4342 (IniDBBuilder::buildBeginBinary): Ditto.
4343 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildBeginBuildDepends):
4344 Implement.
4345 (IniDBBuilderPackage::buildBeginBinary): Ditto.
4346 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildBeginBuildDepends):
4347 Declare.
4348 (IniDBBuilderPackage::buildBeginBinary): Ditto.
4349 * inilex.l: Recognise Build-Depends-Indep, [,], >, < and remove
4350 T_UNKNOWN.
4351 * iniparse.y: Full support for parsing a debian Sources file in-line in
4352 setup.ini.
4353 * package_version.cc (packageversion::binaries): Implement.
4354 * package_version.h (packageversion::binaries): Declare list of what
4355 packages are created from a given source package.
4356 (_packageversion::binaries): Ditto.
4357
233a3e17
RC
43582002-07-10 Robert Collins <rbtcollins@hotmail.com>
4359
4360 * iniparse.y: Add basis for support for parsing a debian Sources file.
4361 * inilex.l: Ditto.
4362
cfae3b8d
RC
43632002-07-09 Robert Collins <rbtcollins@hotmail.com>
4364
4365 Change custom container code for packagedb::packages to STL containers
4366 throughout.
4367 * IniDBBuilderPackage.cc: Ditto.
4368 * PickView.cc: Ditto.
4369 * choose.cc: Ditto.
4370 * desktop.cc: Ditto.
4371 * download.cc: Ditto.
4372 * install.cc: Ditto.
4373 * package_db.cc: Ditto.
4374 * package_db.h: Ditto.
4375 * Makefile.am: Remove list.h references.
4376 * list.h: Remove.
4377
09130e58
RC
43782002-07-08 Max Bowsher <maxb@ukf.net>
4379
4380 * PickView.cc (PickView::PickView): Set font of package list header to
4381 the same as used in the rest of the package list.
4382
a75ed5ce
RC
43832002-07-08 Robert Collins <rbtcollins@hotmail.com>
4384
4385 * install.cc (NoReplaceOnReboot): New command line option to prevent
4386 replacing in use files.
4387 (install_one_source): Check the option and use it.
4388 * README: Update TODO lists.
4389
0cf68afd
RC
43902002-07-08 Robert Collins <rbtcollins@hotmail.com>
4391
ca2b7505 4392 * PickCategoryLine.cc: Change bucket to use STL container syntax
0cf68afd
RC
4393 throughout.
4394 (PickCategoryLine::paint): Use new Category type syntax.
ca2b7505 4395 * PickCategoryLine.h: Use STL vectors rather than custom containers
0cf68afd
RC
4396 throughout.
4397 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageCategory):
4398 Use new add_category syntax.
4399 * PickView.cc (PickView::insert_pkg): Use new Category type syntax.
4400 (PickView::insert_category): Ditto.
4401 (PickView::init_headers): Ditto.
4402 * category.cc: Trim obsolete code.
ca2b7505 4403 * category.h: Replace interconnecting class with a typedef to
0cf68afd
RC
4404 facilitate leveraging STL maps.
4405 * choose.cc (fill_missing_category): Use updated pkg.add_category
4406 syntax.
4407 (default_trust): Use new Category type syntax.
4408 (set_view_mode): Ditto.
4409 (create_listview): Ditto.
4410 * package_db.cc (categories): Ditto.
4411 * package_db.h: Update headers list to include needed headers.
4412 (packagedb::categories): Replace custom list with STL map.
4413 * package_meta.cc: Use new Category type syntax throughout.
4414 (packagemeta::add_category): Implement new syntax.
4415 * package_meta.h: Remove commented out source.
4416 (packagemeta::add_category): Update syntax to decouple interface from
4417 packagedb.
4418
89374d4a
CF
44192002-07-06 Christopher Faylor <cgf@redhat.com>
4420
4421 * site.cc (do_download_site_info_thread): Correct spelling error.
4422
405d7186
RC
44232002-07-06 Robert Collins <rbtcollins@hotmail.com>
4424
4425 * PickCategoryLine.h: Include required header list.h.
4426 * PickPackageLine.cc (PickPackageLine::paint): Adjust to use STL
4427 containers for listing of packages per category and vice verca.
4428 * PickView.cc (PickView::insert_pkg): Ditto.
4429 (PickView::insert_category): Ditto.
4430 * String++.h (String::caseless): STL helper to allow trivial containers
4431 of Strings with case insensitive comparisons.
4432 * category.h: Adjust to use STL containers for listing of packages per
4433 category and vice verca.
4434 * choose.cc (fill_missing_category): Ditto.
4435 (default_trust): Ditto.
4436 (ChooserPage::OnNext): Ditto.
4437 * package_meta.cc (CategoryPackage::~CategoryPackage): Remove.
4438 (packagemeta::packagemeta): Adjust for new category list name.
4439 (packagemeta::~packagemeta): Adjust to use STL containers for listing
4440 of packages per category and vice verca.
4441 (packagemeta::set_action): Ditto.
4442 * package_meta.h (CategoryPackage): Remove.
4443 (packagemeta): Adjust to use STL containers for listing of packages per
4444 category and vice verca.
4445
080bec6e
RC
44462002-07-05 Robert Collins <rbtcollins@hotmail.com>
4447
4448 * io_stream.cc: Use STL containers rather than custom ones.
4449 (io_stream::registerProvider): Ditto.
4450 (findProvider): Ditto.
4451
3f34f364
RC
44522002-07-05 Robert Collins <rbtcollins@hotmail.com>
4453
4454 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4455 Use STL collections for download site collections.
4456 (IniDBBuilderPackage::add_correct_version): Ditto.
4457 (IniDBBuilderPackage::process_src): Ditto.
4458 * PickPackageLine.cc (PickPackageLine::click): Use the packageversion
4459 accessible() call to abstract package availability.
ca2b7505 4460 * choose.cc (scanAVersion): Use STL collections for download site
3f34f364
RC
4461 collections.
4462 * download.cc (check_for_cached): Ditto.
4463 (download_one): Ditto.
4464 * package_meta.cc (packagemeta::set_action): Use the packageversion
4465 accessible() call to abstract package availability.
4466 * package_source.h: Use STL containers rather than custom containers.
4467 (site): Create a == operator to allow STL container use.
4468 (packagesource::sites): Use STL containers rather than custom
4469 containers.
4470 * package_version.cc (_packageversion::accessible): Use STL containers
4471 for download site containers.
4472
e2cdf72c
RC
44732002-07-05 Robert Collins <rbtcollins@hotmail.com>
4474
4475 * LogFile.cc: Use STL containers rather than custom containers.
4476 (filedef): Create == and < operators for STL use.
4477 (files): Convert to an STL set.
4478 (LogFile::setFile): Use STL operations on files.
4479 (LogFile::exit): Ditto.
4480
3bac26a1
RC
44812002-07-05 Robert Collins <rbtcollins@hotmail.com>
4482
4483 * ini.cc (do_remote_ini): Use STL collection for site collection.
4484 * site.cc: Include site.h first to ensure it's parsable standalone.
4485 Use STL algorithms.
4486 (site_list): Convert to an STL container.
4487 (all_site_list): Ditto.
4488 (site_list_type::site_list_type): Implement copy constructor.
4489 (site_list_type::operator=): Implement assignment operator.
4490 (site_list_type::operator ==): Implement.
4491 (site_list_type::operator <): Ditto.
4492 (save_dialog): Use STL collection calls for site collection.
4493 (save_site_url): Ditto.
4494 (get_site_list): Ditto.
4495 (get_saved_sites): Ditto.
4496 (do_download_site_info_thread): Ditto.
4497 (SitePage::OnNext): Ditto.
4498 (SitePage::PopulateListBox): Ditto.
4499 (SitePage::OnMessageCmd): Ditto.
4500 * site.h: Use STL vectors instead of custom code.
4501 (site_list_type::site_list_type): Declare.
4502 (site_list_type::operator=): Ditto.
4503 (site_list_type::operator ==): Ditto.
4504 (site_list_type::operator !=): Ditto.
4505 (site_list_type::operator <): Ditto.
4506 (site_list_type::operator <=): Ditto.
4507 (site_list_type::operator >): Ditto.
4508 (site_list_type::operator >=): Ditto.
4509 (site_list): Convert to an STL container.
4510 (all_site_list): Ditto.
4511
528a8edb
RC
45122002-07-05 Robert Collins <rbtcollins@hotmail.com>
4513
4514 * choose.cc (default_trust): Check package accessibility before
4515 triggering an install. (Suggested by Pavel).
4516
45172002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4518
4519 * compress_gz.cc (compress_gz::construct): Always initialize key members
4520 to ensure the destructor does the right thing.
4521
4e868a01
RC
45222002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4523
4524 * filemanip.cc (parse_filename): Do not try to parse empty
4525 strings (filenames).
4526 * package_db.cc (packagedb::packagedb): For each line check if sscanf()
4527 extracted good package name and filename.
4528
7f2b9277
RC
45292002-07-03 Robert Collins <rbtcollins@hotmail.com>
4530
4531 * package_meta.cc (packagemeta::set_requirements): Automatically select
ca2b7505 4532 version of dependent packages that satisfies the requirements.
7f2b9277
RC
4533 Use processOneDependency to trigger the install of those packages.
4534 (checkForInstalled): Check that the package remains installed.
4535 (processOneDependency): Helper function for dependent packages.
4536 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackage): Add more
4537 debug information.
4538 Clear out all current state on new packages.
ca2b7505 4539 (IniDBBuilderPackage::add_correct_version): Copy the dependency list
7f2b9277
RC
4540 across.
4541
84c4f5d1
RC
45422002-07-02 Robert Collins <rbtcollins@hotmail.com>
4543
4544 * Makefile.am (inilint_SOURCES): Add PackageSpecification sources.
4545 nb: inilint is still incomplete, as the packageversion code is not
4546 ready for database-less linking.
4547 * site.cc (get_site_list): When the same site is reentered by the user
4548 replace the old one. (Suggested by John Marshall).
4549
64cd7f94
RC
45502002-07-02 Robert Collins <rbtcollins@hotmail.com>
4551
4552 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4553 Clear out package selections when generating implicit source packages.
4554 * PackageSpecification.cc (PackageSpecification::satisfies): Implement.
4555 (PackageSpecification::_operators::satisfies): Implement.
4556 * PackageSpecification.h (PackageSpecification::_operators::satisfies):
4557 Worker function for testing versions.
4558
3c196821
RC
45592002-07-01 Robert Collins <rbtcollins@hotmail.com>
4560
4561 * IniDBBuilder.cc (IniDBBuilder::buildPackageRequirement): Remove.
4562 * IniDBBuilder.h (IniDBBuilder::buildPackageRequirement): Ditto.
4563 * IniDBBuilderPackage.cc: Use the STL algorithms.
4564 Change cpv to cbpv throughout. Adjust -> to ., and use the new accessor
4565 functions for the same variable throughout.
4566 (IniDBBuilderPackage::IniDBBuilderPackage): Initialise new members.
4567 (IniDBBuilderPackage::buildPackage): Use new cygpackage syntax,
4568 and set an empty source package.
4569 (IniDBBuilderPackage::buildPackageInstall): Use the new source member
4570 to record an install package.
4571 (IniDBBuilderPackage::buildPackageSource): Move source package logic
4572 out from process_src, as it now occurs at separate times.
4573 (IniDBBuilderPackage::buildPackageRequirement): Remove.
ca2b7505 4574 (IniDBBuilderPackage::buildSourceName): Use renamed package
3c196821
RC
4575 specifiation accessor for clarity.
4576 (IniDBBuilderPackage::buildSourceNameVersion): Ditto.
4577 (IniDBBuilderPackage::add_correct_version): Use STL iterators rather
4578 than custom code.
4579 Remove source package references.
4580 (IniDBBuilderPackage::process_src): Remove source package code as it's
4581 now handled separately.
4582 Set Path information before merging versions, to prevent dangling
4583 pointers.
4584 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildPackageRequirement):
4585 Remove.
4586 (IniDBBuilderPackage::cpv): Remove.
4587 (IniDBBuilderPackage::cbpv): New generic binary working variable.
4588 (IniDBBuilderPackage::cspv): Ditto, but for source packages.
4589 (IniDBBuilderPackage::csp): Source package variable for disjoint
4590 source packages.
4591 * Makefile.am (AM_CFLAGS): Remove -Winline to allow stl set code
4592 to compile. If it compiles cleanly in gcc 3.1, then reinstate.
4593 * PickPackageLine.cc: Adjust packageversion accessors to the new
4594 reference calls. (i.e. -> to .) throughout.
4595 (PickPackageLine::paint): Use accessible() for clarity.
4596 Use new split out source package logic.
4597 (PickPackageLine::click): Ditto.
4598 * PickView.cc (PickView::init_headers): Adjust packageversion accessors
4599 to the new reference calls. (i.e. -> to .) throughout.
4600 Use new split out source package logic.
4601 * choose.cc: Don't depend on a specific package type.
ca2b7505 4602 Adjust packageversion accessors to the new reference calls. (i.e. -> to
3c196821
RC
4603 .) throughout.
4604 (set_existence): Use accessible () for clarity.
4605 (default_trust): Simplify a little.
ca2b7505 4606 (scanAVersion): Factored out code from scan_downloaded_files for
3c196821
RC
4607 clarity.
4608 (scan_downloaded_files): Factor out inner loop for clarity.
4609 (ChooserPage::OnNext): Don't dump the dependency list,
ca2b7505 4610 it's parsing is robust now!.
3c196821
RC
4611 * cygpackage.cc (createInstance): Use a factory method to create new
4612 objects.
4613 (cygpackage::cygpackage): Make this private for use by the factory.
4614 (cygpackage::setCanonicalVersion): Renamed from set_canonical_version.
4615 Remove key usage as it's obsolete.
4616 * cygpackage.h (cygpackage): Inherit from _packageversion, not
4617 packageversion.
4618 (cygpackage::createInstance): New factory.
4619 (cygpackage::cygpackage): Make private.
4620 * desktop.cc (make_passwd_group): Use new packageversion reference.
4621 * download.cc (do_download_thread): Use changeRequested() for clarity.
4622 Use new packageversion reference calls.
4623 * iniparse.y (REQUIRES): Reuse the packageList code and dump the one-off
4624 requires code.
4625 * install.cc: Adjust -> to ., and use the new accessor functions for
4626 packageversion throughout.
4627 * package_db.cc: Adjust -> to ., and use the new accessor functions for
4628 packageversion throughout.
4629 (packagedb::packagedb): Use the new cygpackage factory.
4630 (packagedb::flush): Leverage String to remove buffer overflow chance in
4631 sprintf.
4632 (packagedb::findBinary): Find a binary meta package that has a version
4633 matching a given specification.
4634 (packagedb::findSource): Ditto, but for source.
4635 * package_db.h (packagedb::findBinary): Declare.
4636 (packagedb::findSource): Ditto.
4637 * package_meta.cc: Adjust packageversion accessors to the new
4638 reference calls. (i.e. -> to .) throughout.
4639 Include the package_meta header first to ensure it parses standalone.
4640 Use the STL algorithms.
4641 (packagemeta::packagemeta): Create a copy constructor to allowing
4642 cloning binary package metadata to source package metadata.
ca2b7505 4643 (packagemeta::~packagemeta): Use the STL coleltion code rather than
3c196821
RC
4644 custom collection code.
4645 (packagemeta::add_version): Ditto.
4646 (packagemeta::set_installed): Ditto.
4647 (packagemeta::SDesc): Ditto.
4648 (hasSDesc): Helper function for find_if.
4649 (checkForInstalled): Ditto.
4650 (checkForUpgradeable): Ditto.
4651 (checkForSatisfiable): Ditto.
4652 (packagemeta::action_caption): Update for split out source packages.
4653 (packagemeta::set_action): Ditto.
4654 (packagemeta::set_requirements): Support multi-valued dependency
4655 lists - a|b & c|d - with versioned package specifications.
4656 (packagemeta::accessible): Helper member to improve abstraction.
4657 (packagemeta::sourceAccessible): Ditto.
4658 * package_meta.h: Adjust packageversion accessors to the new
4659 reference calls. (i.e. "->" to "." and"*" to "" ) throughout.
58b12a06 4660 (packagemeta::packagemeta): Declare copy constructor.
3c196821
RC
4661 Remove self initialising members.
4662 (packagemeta::set_action): Update parameters for new packageversion.
4663 (packagemeta::trustp): Ditto.
4664 (packagemeta::versions): Becomes an STL set.
4665 * package_source.h (packagesource::Cached): Const correctness change.
4666 * package_version.cc: Rewrite the packageversion interface to remove
4667 the cygpackage nonvirtual members, and provide a copy by value,
4668 pointer semantics reference counting wrapper class to ease use and
4669 comparison of packageversions.
4670 Change existing packageversion class to _packageversion throughout.
4671 (_defaultversion): A trivial concrete class to prevent specialcasing
4672 the default constructor for packageversion;
4673 (packageversion::packageversion): Implement.
4674 (packageversion::~packageversion): Ditto.
4675 (packageversion::operator=): Ditto.
4676 (packageversion::operator !): Ditto.
4677 (packageversion::operator bool): Ditto.
4678 (packageversion::operator ==): Ditto.
4679 (packageversion::operator !=): Ditto.
4680 (packageversion::operator <): Ditto.
4681 (packageversion::Name): Ditto.
4682 (packageversion::Canonical_version): Ditto.
4683 (packageversion::setCanonicalVersion): Ditto.
4684 (packageversion::getfirstfile): Ditto.
4685 (packageversion::getnextfile): Ditto.
4686 (packageversion::SDesc): Ditto.
4687 (packageversion::set_sdesc): Ditto.
4688 (packageversion::LDesc): Ditto.
4689 (packageversion::set_ldesc): Ditto.
4690 (packageversion::sourcePackage): Ditto.
4691 (packageversion::sourcePackageSpecification): Ditto.
4692 (packageversion::setSourcePackageSpecification): Ditto.
4693 (packageversion::depends): Ditto.
4694 (packageversion::predepends): Ditto.
4695 (packageversion::recommends): Ditto.
4696 (packageversion::suggests): Ditto.
4697 (packageversion::replaces): Ditto.
4698 (packageversion::conflicts): Ditto.
4699 (packageversion::provides): Ditto.
4700 (packageversion::picked): Ditto.
4701 (packageversion::pick): Ditto.
4702 (packageversion::changeRequested): Ditto.
4703 (packageversion::uninstall): Ditto.
4704 (packageversion::source): Ditto.
4705 (packageversion::accessible): Ditto.
4706 (_packageversion::sourcePackage): Ditto.
4707 (_packageversion::accessible): Ditto.
4708 (_packageversion::changeRequested): Ditto.
4709 * package_version.h: Rewrite the packageversion interface to remove
4710 the cygpackage nonvirtual members, and provide a copy by value,
4711 pointer semantics reference counting wrapper class to ease use and
4712 comparison of packageversions.
4713 Change existing packageversion class to _packageversion throughout.
4714 (Dependency): Remove.
4715 (packageversion): New wrapper class.
4716 (_packageversion): Renamed from packageversion.
4717 (_packageversion::setCanonicalVersion): New method.
4718 (_packageversion::sourcePackage): Ditto.
4719 (_packageversion::sourcePackageSpecification): Ditto.
4720 (_packageversion::setSourcePackageSpecification): Ditto.
4721 (_packageversion::changeRequested): Ditto.
4722 (_packageversion::bin): Rename to source.
4723 (_packageversion::src): Remove.
4724 (_packageversion::accessible): New method.
4725 (_packageversion::references): Allow reference counting.
ca2b7505 4726 (_packageversion::sourceVersion): Cached the best-match source
3c196821
RC
4727 package version.
4728
387cb501
RC
47292002-06-27 Robert Collins <rbtcollins@hotmail.com>
4730
4731 * compress_bz.h (compress_bz::position): Track how much has been read.
4732 * compress_bz.cc (compress_bz::compress_bz): And initialise it.
4733 (compress_bz::read): Track amount read by the client.
4734 (compress_bz::tell): And report it when asked.
4735
7d702af3
RC
47362002-06-27 Robert Collins <rbtcollins@hotmail.com>
4737
4738 * Makefile.am (snapshot): Automate snapshot creation some more.
4739
08cd08c3
RC
47402002-06-27 Robert Collins <rbtcollins@hotmail.com>
4741
4742 * msg.cc (msg): Use vsnprintf to avoid buffer overflows.
4743 (mbox): Ditto.
4744 * ini.cc (fprintf): Ditto.
4745 * log.cc (log): Ditto.
4746 * package_db.cc (packagedb::sourcePackages): Split out source packages
4747 from binary packages.
4748 * package_db.h: Ditto.
4749
aa1e3b4d
RC
47502002-06-27 Robert Collins <rbtcollins@hotmail.com>
4751
4752 * PackageSpecification.h: New file. Abstracts the ability to refer
4753 to another package, by name, or name and version.
4754 * PackageSpecification.cc: Ditto.
4755 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Simplify.
4756 (IniDBBuilder::buildPackageSource): Ditto.
4757 (IniDBBuilder::buildBeginDepends): New method for versioned
4758 dependencies.
4759 (IniDBBuilder::buildBeginPreDepends): Likewise, for dependencies to be
4760 satisfied before pre-install.
4761 (IniDBBuilder::buildPriority): New method, for getting the package
4762 Priority.
4763 (IniDBBuilder::buildInstalledSize): How much disk space does it need?
4764 (IniDBBuilder::buildMaintainer): Who maintains the package?
4765 (IniDBBuilder::buildArchitecture): What platform is it for?
4766 (IniDBBuilder::buildInstallSize): How big is the binary download?
4767 (IniDBBuilder::buildInstallMD5): Whats the MD5 on the binary?
4768 (IniDBBuilder::buildSourceMD5): Whats the MD5 on the source package?
4769 (IniDBBuilder::buildBeginRecommends): What other packages are
4770 recommended with this one?
4771 (IniDBBuilder::buildBeginSuggests): And suggested?
4772 (IniDBBuilder::buildBeginReplaces): What packages does this replace?
4773 (IniDBBuilder::buildBeginConflicts): And collide with?
4774 (IniDBBuilder::buildBeginProvides): What virtual packages (or obsolete
4775 package names) does this provide?
4776 (IniDBBuilder::buildDescription): Grab a multi line description one
4777 line at a time.
4778 (IniDBBuilder::buildSourceName): What source package should be used to
4779 install the source for this binary package?
4780 (IniDBBuilder::buildSourceNameVersion): Is a specific version needed?
ca2b7505 4781 (IniDBBuilder::buildPackageListAndNode): Add another AND clause to a
aa1e3b4d
RC
4782 list of package specifications.
4783 (IniDBBuilder::buildPackageListOrNode): Add another OR clause.
4784 (IniDBBuilder::buildPackageListOperator): Add a versioning operator
4785 to the current specification.
4786 (IniDBBuilder::buildPackageListOperatorVersion): What version does the
4787 operator act on?
4788 * IniDBBuilder.h: Declare all the IniDBBuilder.cc changes.
4789 * IniDBBuilderPackage.cc: As for IniDBBuilder.cc.
4790 (IniDBBuilderPackage::IniDBBuilderPackage): Iniitialize new members.
ca2b7505 4791 (IniDBBuilderPackage::process_src): Streamline and split out
aa1e3b4d
RC
4792 functionality.
4793 (IniDBBuilderPackage::setSourceSize): From process_src.
4794 * IniDBBuilderPackage.h: Declare the IniDBBuilderPackage.cc changes.
4795 (IniDBBuilderPackage::currentSpec): Track the in-progress specifiation.
4796 (IniDBBuilderPackage::currentOrList): Track the current Or list.
4797 (IniDBBuilderPackage::currentAndList): Track the current And list.
4798 * IniParseFeedback.cc (IniParseFeedback::progress): Provide completion
349bd18c 4799 progress on parsing.
aa1e3b4d
RC
4800 (IniParseFeedback::iniName): Tell what ini filename we are currently
4801 processing.
4802 * IniParseFeedback.h: Declare IniParseFeedback.cc changes.
ca2b7505 4803 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
aa1e3b4d
RC
4804 Make the feedback object non-const to allow mutating methods which are
4805 needed when the object has state.
4806 (IniParseFindVisitor::visitFile): Tell the caller the name of each
4807 .ini found.
4808 Initialise the parser with the feedback object to allow it to tell of
4809 progress.
4810 * IniParseFindVisitor.h: Declare IniParseFindVisitor.cc changes.
4811 * Makefile.am (inilinst_SOURCES): Add more requisite classes.
4812 (setup_SOURCES): Add the new PackageSpecification sources.
4813 * ScanFindVisitor.cc (ScanFindVisitor::visitFile): Use the new
4814 builder syntax to setup binary package details.
4815 * choose.cc: Use the LogSingleton calls throughout.
4816 * configure.in: Create the INILINT substitution correctly for recent
4817 autotool configurations.
4818 * cygpackage.cc (cygpackage::getfirstfile): Return an empty String
4819 rather than a string built from an int. Thanks to Pavel Tsekov for
4820 identifying the bug.
4821 (cygpackage::getnextfile): Ditto.
4822 * download.cc: Use LogSIngletion calls throughout.
ca2b7505 4823 (validateCachedPackage): A refactoring of the
aa1e3b4d
RC
4824 check_for_cached code to eliminate duplciation.
4825 (check_for_cached): Use validateCachedPackage to check packages.
ca2b7505 4826 * ini.cc (GuiParseFeedback): Provide gui feedback on ini name and
aa1e3b4d
RC
4827 parsing progress.
4828 (do_remote_ini): Ditto.
4829 * ini.h (ini_init): Pass a IniParseFeedback to the parser, to allow
4830 progress reporting.
4831 * inilex.l: Identify new symbols - operators, and multi line plain text.
4832 Releases files.
4833 * inilintmain.cc (show_help): Provide basic infomation on inilint.
4834 * iniparse.y: Adjust for the new builder syntax, and process debian
4835 Release files.
4836 * io_stream_file.cc: Always include mkdir.h.
4837 * list.h: Factor index location into a private routine.
4838 (list::findindex): Implement this.
ca2b7505 4839 * mkdir.cc (mkdir_p): Make the use of WIN32 code conditional on mingw
aa1e3b4d
RC
4840 builds. NB: This breaks cygwin build functionality still.
4841 * package_meta.cc: Use the LogSingleton calls throughout.
4842 (packagemeta::set_requirements): Adjust for object changes in
4843 dependencies.
4844 * package_meta.h (packagemeta::packagemeta): Initialise new members.
ca2b7505 4845 (packagemeta::architecture): What platform does this package run on?
aa1e3b4d 4846 This may need to move in the future to a per packagefile object.
58b12a06 4847 (packagemeta::priority): What priority does this package have?
aa1e3b4d
RC
4848 * package_source.h (packagesource::packagesource): Initialise new
4849 members.
4850 (packagesource::installedSize): How much space does the package need?
4851 (packagesource::setInstalledSize): Tell the amount.
4852 (packagesource::_installedSize): And store it.
ca2b7505 4853 * package_version.cc (packageversion::sourcePackage): return the
aa1e3b4d
RC
4854 source package.
4855 (packageversion::setSourcePackage): And set it.
4856 * package_version.h: Declare the package_version.cc changes.
4857 (packageversion::depends): New package specification AND list.
4858 (packageversion::predepends): Ditto.
4859 (packageversion::recommends): Ditto.
4860 (packageversion::suggests): Ditto.
4861 (packageversion::replaces): Ditto.
4862 (packageversion::conflicts): Ditto.
4863 (packageversion::provides): Ditto.
4864 (packageversion::sourcePackage): What source package is needed?
4865 * threebar.cc (ThreeBarProgressPage::SetText4): Set the label beside
4866 the bottom bar.
4867 * threebar.h: Declare the threebar.cc change.
4868
48692002-06-27 John Marshall <johnm@falch.net>
4870
4871 * res.rc (SETUPINI_MISSING): Make trailing spaces visible.
4872 * site.cc (SitePage::OnMessageCmd): Ditto
4873
2a994e0b
RC
48742002-06-15 Robert Collins <rbtcollins@hotmail.com>
4875
4876 * nio-ie5.cc (NetIO_IE5::NetIO_IE): Allow cached data.
4877
ceff7035
RC
48782002-06-15 Robert Collins <rbtcollins@hotmail.com>
4879
4880 * package_meta.cc (packagemeta::set_action): When installing packages
4881 with no binaries, choose the source package.
4882
9bd27040
RC
48832002-06-10 Robert Collins <rbtcollins@hotmail.com>
4884
4885 * IniParseFindVisitor (IniParseFindVisitor::visitFile): Apply Max
ca2b7505 4886 Bowshers fix for the crash with a root level setup.ini.
9bd27040
RC
4887 * README: Update todos.
4888
1dcff4a0
RC
48892002-05-26 Ralf Habacker <ralf.habacker@freenet.de>
4890
4891 * archive_tar.cc (archive_tar::next_file_name()): fixed broken
4892 GNU long name extension support.
349bd18c 4893
0773e4f2
RC
48942002-05-27 Robert Collins <rbtcollins@hotmail.com>
4895
ca2b7505 4896 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Don't
0773e4f2
RC
4897 unescape 0 length strings.
4898
a828d772
RC
48992002-05-20 Robert Collins <rbtcollins@hotmail.com>
4900
4901 * package_meta.cc (packagemeta::set_action): Don't allow reinstall
4902 when local with no cached file, and install the default source if the
4903 default version has no binary.
4904
67829ce0
RC
49052002-05-19 Robert Collins <rbtcollins@hotmail.com>
4906
4907 * IniDBBuilderPackage.cc (IniDBBuilderPackage::IniDBBuilderPackage): New
349bd18c 4908 method.
ca2b7505 4909 (IniDBBuilderPackage::buildVersion): Provide a warning when a newer
67829ce0
RC
4910 setup version created the ini file.
4911 * IniDBBuilderPackage.h (IniDBBuilderPackage::IniDBBuilderPackage): New
4912 method.
4913 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use the new
4914 feedback strategy.
4915 * IniParseFindVisitor.h (IniParseFindVisitor::IniParseFindVisitor):
4916 Require a feedback strategy.
4917 * Makefile.am (setup_SOURCES): Add IniParseFeedback sources.
4918 * Makefile.in: Regenerate.
4919
4849e2fc
RC
49202002-05-19 Robert Collins <rbtcollins@hotmail.com>
4921
4922 * io_stream_file.cc (io_stream_file::remove): Use the SetFileAttributes
4923 trick to delete read only files.
ca2b7505 4924 * io_stream_cygfile.cc (io_stream_cygfile::remove): Use file:// to
4849e2fc
RC
4925 remove files.
4926 * Makefile.am (release): Tweak to be more helpful.
4927 * Makefile.in: Regenerate.
4928
7cb35117
RC
49292002-05-19 Robert Collins <rbtcollins@hotmail.com>
4930
4931 * Makefile.am (release): Tweak to be more helpful.
4932 * Makefile.in: Regenerate.
7cb35117 4933
5090e3ce
RC
49342002-05-19 Robert Collins <rbtcollins@hotmail.com>
4935
4936 * Makefile.am (release): Tweak to be more helpful.
4937 * Makefile.in: Regenerate.
4938
9e9b881a
RC
49392002-05-19 Robert Collins <rbtcollins@hotmail.com>
4940
ca2b7505 4941 * choose.cc (scan_downloaded_files): When a non-installed version
9e9b881a
RC
4942 has neither bin nor src cached files for local installs,
4943 remove the version from availability.
4944
ea36e064
RC
49452002-05-19 Robert Collins <rbtcollins@hotmail.com>
4946
4947 * ini.cc (do_remote_ini): Save uncompressed ini's correctly.
4948
b401ef47
RC
49492002-05-19 Robert Collins <rbtcollins@hotmail.com>
4950
4951 * rsync: New support library, contains librsync. This is not (yet)
349bd18c 4952 rsync interoperable.
b401ef47
RC
4953 * configure.in: --with-rsync to enable rsync support. (Not complete).
4954 * Makefile.am: Enable building with rsync.
4955 * Makefile.in: Regenerate.
4956 * configure: Ditto.
4957 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Pass the md5 as
4958 an array.
4959 (IniDBBuilder::buildPackageSource): Ditto.
4960 * IniDBBuilder.h: Ditto.
4961 * IniDBBuilderPackage.cc: Ditto.
4962 * IniDBBuilderPackage.h: Ditto.
4963 * FindVisitor.cc: New file.
4964 * FindVisitor.h: New file, interface for visiting a file system
4965 aggregate.
4966 * IniParseFindVisitor.cc: New file.
ca2b7505 4967 * IniParseFindVisitor.h: New file, concrete FindVisitor that parses
b401ef47
RC
4968 found setup.ini's.
4969 * README: Update TODO's.
4970 * String++.cc (String::String): New constructor for <string> inter-
4971 operability.
4972 (String::substr): New method.
4973 * String++.h: Ditto.
4974 * choose.cc (scan2): Remove.
4975 (scan_downloaded_files): Simplify.
4976 * dialog.h: Include parsing pre-requirements.
4977 * download.cc (check_for_cached): Fullname was used incorrectly - fix.
4978 * filemanip.cc (parse_filename): -src packages where incorrectly parsed.
4979 * find.cc: Rewrite. Now uses a Visitor pattern and is re-entrant.
4980 * find.h: Ditto.
4981 * fromcwd.cc: Remove unneeded includes.
4982 (is_test_version): Remove.
4983 (found_file): Remove.
4984 (SetupFindVisitor): Trivial visitor to detect setup.ini's.
4985 (found_ini): Remove.
4986 (do_fromcwd): Remove commented code that has be replaced elsewhere.
4987 * ini.cc (local_ini): Remove.
4988 (findBuilder): Remove.
4989 (find_routine): Remove.
4990 (do_local_ini): Use new IniParseFindVisitor.
4991 * iniparse.y: Typecase MD5 arrays, as we know they are allocated as
4992 unsigned char.
4993 * postinstall.cc: Remove non-core includes.
4994 (run_script_in_postinstall): Remove.
4995 (RunFindVisitor): Trivial Visitor, runs each found script.
4996 (do_postinstall): Use new find syntax.
4997
0d4e0aad
CF
49982002-05-14 Christopher Faylor <cgf@redhat.com>
4999
5000 * ini.cc (find_routine): Don't clear buffer it it's NULL.
5001
50022002-05-14 Christopher Faylor <cgf@redhat.com>
5003
5004 * filemanip.h (trail): Declare.
5005 * filemanip.cc (trail): New function.
5006 (find_tar_ext): Use trail() instead of strstr().
5007 * fromcwd.cc (check_ini): Ditto.
5008 * ini.cc (find_routine): Ditto. Don't tack local_dir to path since it
5009 should now be fully qualified. Set ini_filename. Reset error_buf and
5010 error_count for any subsequent ini file parsing.
5011 (ini_filename): New static variable for parse error reporting.
5012 (yyerror): Use full path of setup.ini in error message. Subtract one
5013 from line number if at bol.
5014 * find.cc (found_part): Eliminate.
5015 (find_sub): Call for_each with full path found rather than just file
5016 component.
5017 (find): Don't calculate found_part.
5018 * inilex.l (ini_init): Flush input buffer and reset line number.
5019 (yybol): New function. Exports YY_AT_BOL.
5020 * iniparse.y: Increase stack depth to allow more tokens to be processed.
5021 (yyparse): Remove newline from error condition to allow subsequent
5022 per-line error processing to proceed normally.
5023
50242002-05-14 Christopher Faylor <cgf@redhat.com>
5025
5026 * find.cc (find_sub): Be more defensive in preserving trailing parts of
5027 components when doing recursive directory searches or calling user
5028 supplied for_each().
5029 * ini.cc (find_routine): Don't assume that any path name with
5030 "setup.ini" in it is actually a setup.ini file. Only honor trailing
5031 components. Copy path argument to temporary storage when unescaping
5032 to prevent nuking of argument.
5033
874c569a
RC
50342002-05-12 Robert Collins <rbtcollins@hotmail.com>
5035
5036 * CONTRIBUTORS: New file.
5037
f6a81f69
RC
50382002-04-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5039
5040 * choose.cc: Run indent.
5041 (nextbutton): Remove static variable.
5042 (default_trust): Remove use of nextbutton.
5043 (set_view_mode): Ditto.
5044 (create_listview): Add IDC_CHOOSE_PREV and IDC_CHOOSE_NEXT to ta[] so
5045 rbset() sets the prev/next/curr radio buttons properly.
5046 (dialog_cmd): Delete function.
5047 (dialog_proc): Delete function. Move WM_INITDIALOG functionality to
5048 ChooserPage::OnInit.
5049 (do_choose): Delete function. Move pre-DialogBox() code to
5050 ChooserPage::OnInit(), post-DialogBox() code to ChooserPage::OnNext.
5051 (WM_APP_START_CHOOSE): Remove define.
5052 (WM_APP_CHOOSE_IS_FINISHED): Remove define.
5053 (do_choose_thread): Delete function.
5054 (ChooserPage::OnActivate): Delete method.
5055 (ChooserPage::OnMessageApp): Delete method.
5056 (ChooserPage::OnInit): New method.
5057 (ChooserPage::OnNext): New method.
5058 (ChooserPage::OnBack): New method.
5059 (ChooserPage::OnMessageCmd): New method.
5060 * choose.h: Run indent.
5061 (ChooserPage::OnMessageApp): Delete declaration.
5062 (ChooserPage::OnActivate): Ditto.
5063 (ChooserPage::OnMessageCmd): New declaration.
5064 (ChooserPage::OnInit): Ditto.
5065 (ChooserPage::OnNext): Ditto.
5066 (ChooserPage::OnBack): Ditto.
5067 * desktop.cc (DesktopSetupPage::OnBack): Replace use of IDD_CHOOSER
5068 with IDD_CHOOSE.
5069 * fromcwd.cc (do_fromcwd): Replace use of IDD_CHOOSER with IDD_CHOOSE.
5070 * ini.cc (do_ini_thread): Replace use of IDD_CHOOSER with IDD_CHOOSE.
5071 * res.rc (IDD_CHOOSE): Remove dialog template.
5072 (IDD_CHOOSER): Alter dialog template to fit wizard size and format.
5073
74617327
RC
50742002-05-12 Robert Collins <rbtcollins@hotmail.com>
5075
5076 * LogFile.cc (endLog): Work around an apparent libg++-3 bug causing
5077 corrupt log file entries.
5078 * geturl.cc: Convert to the new LogSingleton logging.
5079
3272d625
RC
50802002-05-12 Robert Collins <rbtcollins@hotmail.com>
5081
5082 * ini.cc (do_remote_ini): Use setup.bz2 if it exists in preference to
5083 setup.ini.
5084
fc687221
RC
50852002-05-12 Robert Collins <rbtcollins@hotmail.com>
5086
5087 * geturl.h: Declare getUrlToStream.
5088 * geturl.cc (getUrlToStream): New function.
5089 (get_url_to_membuf): Refactor to use getUrlToStream.
5090
902c8a3f
RC
50912002-05-11 Robert Collins <rbtcollins@hotmail.com>
5092
5093 * Makefile.am: Add a release target to automate some of the routine
5094 work.
5095 * Makefile.in: Regenerate.
5096
2ab26cdb
RC
50972002-05-11 Robert Collins <rbtcollins@hotmail.com>
5098
5099 * choose.cc (scan_downloaded_files): On local installs remove all
5100 mirror sites if no cached copy of a package is found.
5101
94852d65
RC
51022002-05-10 Robert Collins <rbtcollins@hotmail.com>
5103
5104 * Makefile.in: Regenerate.
58b12a06 5105 * iniparse.y: Use left recursion, not right in the lines rule to
94852d65
RC
5106 avoid stack overflows.
5107 * README: Update TODO's.
5108 * io_stream_file.cc: Native builds need to include sys/stat.h
5109
3548fbc3
RC
51102002-05-06 John Marshall <jmarshall@acm.org>
5111
5112 * site.cc (SitePage::OnMessageCmd): recalculate navigation
5113 button activation when "Add" is pressed.
5114 (SitePage::CheckControlsAndDisableAccordingly): tweak comment.
5115
51162002-05-07 Robert Collins <rbtcollins@hotmail.com>
2b48ecd0
RC
5117
5118 * Makefile.am (inlint_SOURCES): Add conditional objects to inilint
5119 depending on platform.
5120 Add file:// support.
5121 * configure.in: Set conditional MINGWTARGET if compiling against mingw
5122 libraries.
5123 * Makefile.in: Regenerate.
5124 * configure: Ditto.
5125 * io_stream_file.cc: Only use win32 calls when building for mingw.
5126
19911586
RC
51272002-05-05 Robert Collins <rbtcollins@hotmail.com>
5128
5129 * Makefile.am (noinst_PROGRAMS): Make inilint configurable.
5130 * configure.in: Ditto.
5131 Fix incorrect header checking syntax.
5132 * aclocal.m4: Regenerate.
5133 * configure: Regenerate.
5134 * Makefile.in: Regenerate.
5135 * io_stream.cc: Remove platform specific and provider specific code.
5136 (io_stream::registerProvider): New method, registers a Url provider with
5137 the io_stream code.
5138 Make all methods consistently throw invalid_argument exceptions when
5139 a provider that is requested is not present.
5140 (findProvider): New private function, finds a provider.
5141 * io_stream.h: Declare io_stream::registerProvider.
5142 * io_stream_cygfile.cc: Create a Provider class to register with
5143 io_stream.cc.
5144 * io_stream_file.cc: Ditto.
5145 * archive.cc: Remove unneeded includes.
5146 * archive_tar.cc: Remove unneeded includes.
5147 * archive_tar.h: Add required include.
5148 * archive_tar_file.cc: Remove unneded includes.
5149 * choose.cc: Remove unneeded includes:
5150
bf4ffcd9
RC
51512002-05-04 Robert Collins <rbtcollins@hotmail.com>
5152
5153 * io_stream.cc: Use the new log interface thruout.
5154
9f4a0c62
RC
51552002-05-04 Robert Collins <rbtcollins@hotmail.com>
5156
5157 * log.cc (log): Reimplement via LogSingleton.
5158 (log_save): Remove.
5159 (exit_setup): Remove.
5160 * log.h (log_save): Remove.
5161 (exit_setup): Remove.
5162 * LogSingleton.cc: New file.
5163 * LogSingleton.h: New file.
5164 * LogFile.cc: New file.
5165 * LogFile.h: New file.
5166 * Makefile.am (inilint_SOURCES): Add the new log interface.
5167 (setup_SOURCES): Add the new log interface and the concrete File
5168 implementation.
5169 * Makefile.in: Regenerate.
5170 * archive.cc: Use the new log interface thruout.
5171 * archive_tar.cc: Ditto.
5172 * main.cc: Ditto.
5173 * dialog.cc (fatal): Use the new log interface.
5174 * ini.cc (do_ini_thread): Use the log interface to exit.
5175 * isntall.cc (do_install_thread): Ditto.
5176 * netio.cc (auth_cmd): Ditto.
5177 * msg.cc (fatal): Ditto.
5178 * localdir.cc (save_local_dir): Save to different files depending on
5179 the mode, and if a root dir exists.
5180
076654e7
RC
51812002-05-04 Robert Collins <rbtcollins@hotmail.com>
5182
5183 * IniDBBuilder.cc: New file.
5184 * IniDBBuilder.h: New file.
5185 * IniDBBuilderPackage.cc: New file.
5186 * IniDBBuilderPackage.h: New file.
5187 * PackageTrust.h: New file.
5188 * IniState.h: Remove, wasn't thought out well enough.
5189 * Makefile.am (inilint_SOURCES): Add more requirements.
5190 (setup_SOURCES): Add new Builder base and concrete classes.
5191 * Makefile.in: Regenerate.
5192 * String++.cc (String::String): Implement int contructor.
5193 * String++.h (String): Declare int constructor.
5194 * archive_tar.cc (archive_tar::next_file_name): Return String() when
5195 no filename exists.
5196 * archive_tar.h (archive_tar_file): Remove get_next_filename method,
5197 it's not needed.
5198 * ini.cc: Replace IniState wuth IniDBBuilderPacakge.
5199 (find_routine): Use new IniDBBuilder to configure the parser.
5200 (do_local_ini): Ditto.
5201 (do_remote_ini): Ditto.
5202 * ini.h: Use IniDBBuilder to initialise parsing.
ca2b7505 5203 * inilex.l (MD5): Parse the MD5 string correctly, we had the nibbles
076654e7
RC
5204 swapped.
5205 (ini_init): Use an IniDBBuilder rather than static variables.
5206 * iniparse.y: Hand off all the object creation to a builder, rather
ca2b7505 5207 than hardcoding the behaviour. This allows run-time configured
076654e7 5208 behaviour.
ca2b7505 5209 * io_stream_cygfile.h (io_stream_cygfile): Remove get_next_filename
076654e7
RC
5210 method, it's not needed.
5211 * io_stream_file.h (io_stream_file): Ditto.
5212 * mount.cc (cygpath): Return String() for missing mounts.
5213 * package_meta.cc (packagemeta::SDesc): Return String() for blank
5214 descriptions.
5215 * package_meta.h (trusts): Remove - replaced by PackageTrust.h.
5216 (packagemeta::packagemeta): Fix incorrect syntax in String constructor
5217 usage.
ca2b7505 5218 * cygpackage.cc (cygpackage::cygpackage): Fix incorrect syntax in
076654e7
RC
5219 String constructor usage.
5220 * site.h (site_list_type): Ditto.
5221
6391823e
RC
52222002-05-03 Robert Collins <rbtcollins@hotmail.com>
5223
5224 * String++.h: Declare a << operator that accepts String objects.
5225 * String++.cc: We need iostream for..
5226 (operator <<): this. Provide a << operator that accepts String objects.
5227 * ini.cc (yyerror): Remove the "C" classifier - it's not needed.
5228 Change from vargs to a String parameter.
5229 * inilintmail.cc: Remove the gui related headers.
5230 (yyerror): Implement this for parsing.
5231 * iniparse.y: Use the new yyerror syntax.
5232
b92028a4
RC
52332002-05-03 Robert Collins <rbtcollins@hotmail.com>
5234
5235 * Makefile.am: Add IniState.h.
5236 * Makefile.in: Regenerate.
5237 * IniState.h: New file.
5238 * choose.cc: Don't include ini.h - it's not needed.
5239 * configure: Regenerate.
5240 * desktop.cc: Don't include ini.h - it's not needed.
5241 * download.cc: Ditto.
5242 * fromcwd.cc: Ditto.
5243 * ini.cc: Use IniState.h to track each parsing calling.
5244 (find_routine): Ditto.
5245 (do_remote_ini): Ditto.
5246 (do_ini_thread): Ditto.
5247 * ini.h (ini_init): Adjust parameters to include state object.
5248 * inilex.l: Declare parser state variable.
5249 (ini_init): Adjust parameters to include state object.
ca2b7505 5250 * iniparse.y: Remove obsolete setup_timestamp and setup_version
b92028a4
RC
5251 declarations.
5252 (setup_header): Use new state variable to track time and version.
5253 (add_correct_version): Ditto.
5254 * install.cc: Don't include ini.h - it's not needed.
5255
e0a4db64
RC
52562002-05-03 Robert Collins <rbtcollins@hotmail.com>
5257
5258 * nio-files.cc (NetIO): Use io_stream syntax for get_file_size.
5259 * io_stream_file.cc: Don't include filemanip.h.
5260 (io_stream_file::get_size): Implement here to remove filemanip
5261 dependency.
5262 * io_stream_cygfile.cc: Don't include filemanip.h.
5263 (io_stream_cygfile::get_size): Implement here to remove filemanip
5264 dependency.
5265 Implement a stat based version for when win32 is not available.
5266 * filemanip.h (get_file_size): Return size_t - it's more appropriate.
5267 * filemanip.cc: Don't include win32.h - be platform independent.
5268 Include strings.h and io_stream.h as part of that.
5269 (get_file_size): Leverage io_streams and remove win32 implementation.
5270 * download.cc (check_for_cached): Use io_stream syntax for
5271 get_file_size.
5272 (download_one): Ditto.
5273
52742002-05-02 Robert Collins <rbtcollins@hotmail.com>
ac65f5c5
RC
5275
5276 * configure.in: Correct a typo in last change.
5277 * configure: Regenerate.
5278 * Makefile.in: Regenerate.
5279
e0a4db64 52802002-05-02 Robert Collins <rbtcollins@hotmail.com>
e06ded88
RC
5281
5282 * configure.in: Check for string.h and string.
5283 * configure: Regenerate.
5284 * Makefile.in: Regenerate.
5285
1fd0694a
RC
52862002-05-01 Robert Collins <rbtcollins@hotmail.com>
5287
5288 * res.rc (IDD_SPLASH): Remove white box.
5289
89ca06c0
RC
52902002-05-01 Robert Collins <rbtcollins@hotmail.com>
5291
5292 Oops! forgot to list these in the last checkin.
5293 * inilintmain.cc: New file.
5294 * md5.h: New file - imported md5 source, BSD style licence.
5295 * md5.cc: New file - imported md5 source, BSD style licence.
5296 * Exception.cc: New file.
5297 * Exception.h: New file.
5298 * MD5++.cc: New file.
5299 * MD5++.h: New file.
5300
58ee6135
RC
53012002-05-01 Robert Collins <rbtcollins@hotmail.com>
5302
ca2b7505 5303 * Makefile.am (AM_CFLAGS): Remove -mwindows, it's a linker flag.
58ee6135
RC
5304 Remove -fno-rtti, we need it for exceptions.
5305 (AM_CXXFLAGS): Ditto.
5306 (WARNONLY_CFLAGS): Ditto.
5307 (EXTRA_PROGRAMS): Add with initial linter sources - not functional yet.
5308 (setup_LDFLAGS): Add and set to -mwindows.
5309 (setup_SOURCES): Add new sources.
5310 * Makefile.in: Regenerate.
5311 * README: Update TODO.
5312 * choose.cc (scan_downloaded_files): Use ini information if it's
5313 available.
5314 * configure: Regenerate.
5315 * download.cc (check_for_cached): Make reusable from elsewhere.
5316 Throw exceptions on errors (as opposed to failures).
5317 Check MD5 sum when it's known.
5318 (download_one): Never force a download.
5319 Handle corrupt package exceptions.
5320 * ini.cc (find_routine): Reverse escape the URL to correctly identify
5321 the site URL.
5322 * inilex.l (MD5): Provide a parsing rule (note: lowercase is required).
ca2b7505 5323 * iniparse.y: Allow calculation of MD5 sums, and allow src only
58ee6135
RC
5324 packages.
5325 (process_src): New helper function.
5326 * isntall.cc (install_one_source): Check MD5 sums when possible.
5327 Throw exceptions on errors.
5328 (do_install_thread): Handle exceptions for installation calls.
5329 * package_source.h: Store MD5 information.
5330 * propsheet.cc (PropSheet::Create): Add a useful comment.
5331 * res.rc (IDS_INSTALL_ERROR): Define.
5332 (IDS_CORRUPT_PACKAGE): Define.
5333 * resource.h (IDS_INSTALL_ERROR): Define.
5334 (IDS_CORRUPT_PACKAGE): Define.
5335 * rfc1738.cc (rfc1738_unescape_part): Implement.
5336 * rfc1738.h (rfc1738_unescape_part): Declare.
5337
45e01f23
RC
53382002-04-29 Robert Collins <rbtcollins@hotmail.com>
5339
5340 * Makefile.am: Remove dependecy rules that automake emits.
5341 Correct badly copied dependency info for manually compiled files.
58b12a06 5342 (setup_SOURCES): Add all used headers.
45e01f23
RC
5343 (EXTRA_DIST): Include non compilate but required sources.
5344 (setup_LDADD): Remove mingw32, it is autodetected.
5345 * Makefile.in: Regenerate.
5346 * String++.h: sys/types is a system header.
5347 * choose.cc (do_choose_thread): Make into a Win32 thread routine.
5348 Use ExitThread.
5349 (ChooserPage::OnMessageApp): Use Win32 threads. (_beginthread is not
5350 portable).
5351 * configure: Regenerate.
5352 * configure.in: Check for mingw32/cygwin specific headers and libraries.
ca2b7505 5353 * cygpackage.h: Include the win32.h header to get correct macro
45e01f23
RC
5354 definitions in all situations.
5355 * download.cc (do_download_reflector): Make into a Win32 thread routine.
5356 Use ExitThread.
5357 (do_download): Use Win32 threads.
5358 * ini.cc: Ditto.
5359 * install.cc: Ditto.
ca2b7505 5360 * (WinMain): Adjust to build valid command line using application
45e01f23 5361 under both mingw32 and cygwin.
ca2b7505 5362 * mount.cc (set)cygdrive_flags): Create new system flags if the
45e01f23
RC
5363 user requests system and the value does not exist.
5364 * nio-http.cc: Define a _strnicmp for cygwin.
5365 * package_db.cc: Include <errno.h> if it exists.
ca2b7505 5366 * site.cc (do_download_site_info_thread): Make into a Win32 thread
45e01f23
RC
5367 routine.
5368 Use ExitThread.
5369 (do_download_site-Info): Use Win32 threads.
ca2b7505 5370 * state.cc: Explicity declare variables to avoid header conflicts
45e01f23
RC
5371 caused by '#define extern" on cygwin.
5372 * win32.h: Include <alloca.h> if it exists.
5373 (_MAX_PATH): Define as MAX_PATH when not defined by windows.h.
5374 (_access): Define as access if not defined by windows.h.
5375
8bb9dad9
RC
53762002-04-27 Robert Collins <rbtcollins@hotmail.com>
5377
5378 * compress_gz.cc (compress_gz::error): EOF is not an error condition.
5379
6908b7d7
RC
53802002-04-27 Robert Collins <rbtcollins@hotmail.com>
5381
5382 * Makefile.am: Add libgetopt++ to the subdirs list.
5383 Search the libgetopt++ header directory.
5384 Link against libgetopt++.la.
5385 (setup_SOURCES): Remove GetOption.cc and getopt.c and Option.cc.
5386 (setup_LDADD): Explicitly include res.o.
5387 * Makefile.in: Regenerate.
5388 * aclocal.m4: Regenerate.
5389 * bootstrap.sh: Call libtoolize.
5390 * configure: Regenerate.
5391 * configure.in: Add libtool support and configure libgetopt++.
5392 * desktop.cc (NoShortcutsOption): Turn into a BoolOption.
5393 (DesktopSetupPage::OnInit): Use the simpler syntax.
5394 * desktop.h: Remove dependency on Option.h, and remove NoShortcustOption
5395 declaration.
5396 * main.cc: Include getopt++/GetOption.h.
5397 (main): Use simpler syntax.
5398 * cdefs.h: Remove.
5399 * getopt.h: Remove.
5400 * getopt.c: Remove.
5401 * GetOption.h: Remove.
5402 * GetOption.cc: Remove.
5403 * Option.h: Remove.
5404 * Option.cc: Remove.
5405
9063358a
RC
54062002-04-26 Robert Collins <rbtcollins@hotmail.com>
5407
5408 * Makefile.am: Add zlib and bz2lib to SUBDIRS.
5409
f6100b6f
RC
54102002-04-26 Robert Collins <rbtcollins@hotmail.com>
5411
5412 * aclocal.m4: New file, cached macros.
ca2b7505 5413 * bootstrap.sh: New file, calls required autotools in appropriate
f6100b6f
RC
5414 order.
5415 * Makefile.am: New file, input Makefile for automake.
5416 * Makefile,in: Now a generated file - regenerate.
5417 * configure: Regenerate.
5418 * configure.in: Add automake support.
5419 * inilex.l: Change VERSION to PACKAGEVERSION to avoid a collision with
5420 automake's VERSION define.
5421 * iniparse.y: Ditto.
5422
db04fc41
RC
54232002-04-26 Robert Collins <rbtcollins@hotmail.com>
5424
5425 * cdefs.h: New file, imported to allow getopt.c to build without
5426 cygwin headers.
5427 * getopt.h: New file, imported to allow building without cygwin headers.
5428 * getopt.c: Ditto.
5429 * bz2lib: New directory, contains copy of bz2lib.
5430 * cfgaux: New directory, contains autotool helper scripts.
ca2b7505 5431 * Makefile,in: Adjust library and target definitions for building
db04fc41
RC
5432 outside the sourceware tree.
5433 * compress_bz.h: Use new bz2lib header location.
5434 * mount.cc: Import key defines and enums to be independent of cygwin
5435 headers.
ca2b7505 5436 * configure.in: Update to autoconf 2.53, and to be sourceware
db04fc41
RC
5437 independent.
5438 * configure: Regenerate.
5439
931f2755
RC
54402002-04-12 Robert Collins <rbtcollins@hotmail.com>
5441
5442 * mklink2.cc (make_link_2): Tweak to work with current w32api
5443 headers.
5444
54452002-04-10 Pavel Tsekov <ptsekov@gmx.net>
5446
5447 * version.cc (canonicalize_version): Fix a call delete[]
5448 to delete the allocated address.
5449
54502002-03-29 Robert Collins <rbtcollins@hotmail.com>
5451
5452 * PickView.cc (PickView::set_headers): Set last_col correctly. Thanks
5453 to Ton van Overbeek for locating the bug area.
5454
49cf3899
RC
54552003-03-27 Robert Collins <rbtcollins@hotmail.com>
5456
5457 * PickView.cc (PickView::insert_pkg): Be more generic with
5458 object use.
5459 (PickView::insert_category): Ditto.
5460 (PickView::~PickView): Create.
5461 * PickView.h (PickView::~PickView): Declare.
5462
1be8f8fd
RC
54632003-03-27 Robert Collins <rbtcollins@hotmail.com>
5464
5465 * Makefile.in (OBJS): Add new commandline objects.
5466 * desktop.cc (NoShortCutsOption): New option code.
5467 (DesktopSetupPage::OnInit): Check whether to skip shortcuts.
5468 * desktop.h (NoShortCutsOption): New concrete command line option class.
5469 * main.cc (WinMain): Process command line options.
5470 * GetOption.h: New file, singleton command line class.
5471 * GetOption.cc: New file, implementation of the above.
5472 * Option.h : New file, abstract option for GetOption.
5473 * Option.cc: New file, implement constructor and destructor.
5474
f2e49cf8
RC
54752002-03-26 Pavel Tsekov <ptsekov@gmx.net>
5476
58b12a06 5477 * mkdir.cc (mkdir_p): Stop processing if the path is exhausted.
f2e49cf8
RC
5478
54792002-03-26 Ton van Overbeek <tvoverbe@cistron.nl>
5480
58b12a06
MB
5481 * PickPackageLine.cc (PickPackageline::paint): Adjust clipping rectangle
5482 to textheight, so large fonts work.
f2e49cf8
RC
5483
54842003-03-26 Robert Collins <rbtcollins@hotmail.com>
5485
58b12a06
MB
5486 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Don't translate
5487 symlinks.
f2e49cf8
RC
5488
54892003-03-26 Robert Collins <rbtcollins@hotmail.com>
5490
58b12a06
MB
5491 * io_stream_cygfile.cc (cwd): New static for cwd storage.
5492 (io_stream_cygfile::normalise): New method.
5493 (io_stream_cygfile::io_stream_cygfile): Use it.
5494 (io_stream_cygfile::exists): Ditto.
5495 (io_stream_cygfile::remove): Ditto.
5496 (io_stream_cygfile::mklink): And again.
5497 (cygmkdir_p): Yes, again.
5498 (io_stream_cygfile::move): And once more.
5499 * io_stream_cygfile.h (io_stream_cygfile::normalise): Declare.
5500 (io_stream_cygfile::cwd): Ditto.
f2e49cf8 5501
51ebb760
RC
55022003-03-26 Robert Collins <rbtcollins@hotmail.com>
5503
5504 * package_meta.cc (package_meta::~package_meta): Remove duplicate.
ca2b7505 5505 (CategoryPackage::~CategoryPackage): Ditto. (Thanks to Ton van
51ebb760
RC
5506 Overbeek for the report).
5507 * mklink2.cc: Moved from mklink2.c to avoid 'not a prototype error'.
5508 Make g++ compatible.
5509 * mklink2.c: Remove.
5510 * site.cc (site_list_type::init): Delete the correct memory addres.
5511 Thanks to Pavel Tsekov for tracking this down.
5512
e7d67c03
RC
55132002-03-20 Robert Collins <rbtcollins@hotmail.com>
5514
5515 * win32.h: Only define alloca if it's not already.
5516
2fa7c5a4
RC
55172002-03-20 Robert Collins <rbtcollins@hotmail.com>
5518
58b12a06
MB
5519 * package_meta.h (packamgemeta::trustp): Make 'test' choice leave
5520 installed packages alone.
2fa7c5a4
RC
5521 * README: Update with latest requests.
5522 * Various: MTC fixes from setup200202 branch.
5523
7bf13fc9
CF
55242002-03-19 Christopher Faylor <cgf@redhat.com>
5525
5526 * Makefile.in (setup_version.c): Add back magic which allows detection
5527 of setup.exe version number.
5528
2fa7c5a4
RC
55292002-03-17 Robert Collins <rbtcollins@hotmail.com>
5530
58b12a06 5531 * PickPackageLine.cc (PickPackageLine::paint): Fix incorrect clip region
2fa7c5a4
RC
5532 calculation on win9x systems.
5533
55342002-03-16 Robert Collins <rbtcollins@hotmail.com>
5535
58b12a06
MB
5536 * install.cc (install_one_source): Write the correct length of a string
5537 to the lst file (Thanks to Pavel Tsekov for reporting the bug).
2fa7c5a4
RC
5538
55392002-03-15 Robert Collins <rbtcollins@hotmail.com>
5540
5541 * choose.cc (list_click): Always refresh the entire chooser, as our
58b12a06
MB
5542 package state change mechanism is broken with the new improved list
5543 classes.
2fa7c5a4
RC
5544
55452002-03-15 Robert Collins <rbtcollins@hotmail.com>
5546
58b12a06
MB
5547 * desktop.cc (make_passwd_group): Check for .lnk suffix on /etc/passwd
5548 and /etc/group.
2fa7c5a4
RC
5549
55502002-03-15 Robert Collins <rbtcollins@hotmail.com>
5551
58b12a06
MB
5552 * PickPackageLine.cc (PickPackageLine::DrawCheck): New method factored
5553 out from paint().
5554 (PickPackageLine::paint): Use DrawCheck to draw the src tick box, and
5555 the new bin tickbox.
2fa7c5a4
RC
5556 (PickPackageLine::click): Handle the new bin tickbox.
5557 * PickPackageLine.h (PickPackageLine::DrawCheck): Declare this.
5558 * PickView.cc (pkg_headers): Add a Bin? column.
5559 (cat_headers): Ditto.
5560 (PickView::set_headers): Ditto.
5561 (PickView::init_headers): Ditto.
5562 * PickView.h (PickView): Ditto.
58b12a06
MB
5563 * choose.cc (list_click): Use the new name for src_col to set the clip
5564 rectangle.
2fa7c5a4
RC
5565
55662002-02-24 Michael A Chase <mchase@ix.netcom.com>
5567
5568 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Fix up Robert's
5569 fixup.
5570
55712002-02-24 Michael A Chase <mchase@ix.netcom.com>
5572
5573 * desktop.cc (make_link): Add "file://" prefix to io_stream::mkpath_p()
5574 call.
5575 (make_passwd_group): Ditto.
5576 * localdir.cc (save_local_dir): Ditto.
5577 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Wrap long lines.
5578 Add "cygfile://" prefix to io_stream::open() calls.
5579
204315f9
RC
55802002-02-24 Robert Collins <rbtcollins@hotmail.com>
5581
5582 * log.cc (log_save): Fix creating /var/log.
5583 * packate_meta.cc (standard_dirs): Remove duplicate '/''s.
5584
58db1046
RC
55852002-02-24 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5586
5587 * res.rc (STRINGTABLE): Add IDS_CYGWIN_SETUP and
5588 IDS_CYGWIN_SETUP_WITH_PROGRESS strings.
5589 * resource.h: Add IDS_CYGWIN_SETUP and
5590 IDS_CYGWIN_SETUP_WITH_PROGRESS IDs.
5591
5592 * splash.cc (OnInit): Qualify SetWindowText() call with global scope
5593 operator (::SetWindowText()).
5594
5595 * threebar.cc: Run indent.
5596 (cistring.h): Add include.
5597 (SetText1, SetText2, SetText3): Qualify SetWindowText() call with
5598 global scope operator.
5599 (SetBar2): Add logic for writing percent complete into window title.
5600
5601 * window.h: Run indent.
5602 (SetWindowText): New function.
5603 (String): Add forward declaration.
5604 * window.cc: Run indent.
5605 (String++.h): Add include.
5606 (SetWindowText): New function.
5607
490717ef
RC
56082002-02-24 Robert Collins <rbtcollins@hotmail.com>
5609
5610 * README: Update TODO list.
5611 * install.cc (install_one): Fix src package location.
5612 (do_install_thread): Fix creating directories.
5613
7c6ef2c3
RC
56142002-02-19 Robert Collins <rbtcollins@hotmail.com>
5615
5616 * choose.cc: Include cygpackage.h for scan2 use.
5617 (set_existence): Ignore setup.ini mirrors when installing from cwd.
5618 (scan2): Process any valid file.
58b12a06
MB
5619 Add cache entries when a file matching a setup.ini listed version is
5620 found.
7c6ef2c3
RC
5621 * filemanip.cc (parse_filename): Remove pkgtar - not used anywhere else.
5622 * filemanip.h (filemanip::pkgtar): Remove.
5623 * package_meta.cc (CategoryPackage::~CategoryPackage): New method.
5624 (packagemeta::~packagemeta): Move from package_meta.h
5625 Remove and delete all version and category information.
5626 * package_meta.h (CategoryPackage): Create a destructor.
5627 (packagemeta::~packagemeta): Move to .cc file.
5628
56292002-02-19 Robert Collins <rbtcollins@hotmail.com>
5630
5631 * install.cc (install_one_source): Make NULL cached package names cause
5632 errors.
5633
bb087dce
RC
56342002-02-18 Michael A Chase <mchase@ix.netcom.com>
5635
5636 * desktop.cc (make_passwd_group): Don't create passwd-grp.bat
5637 unnecessarily.
5638
56392002-02-18 Michael A Chase <mchase@ix.netcom.com>
5640
5641 * log.cc (log_save): Put "\n" at end of log lines instead of "'".
5642
c90bc3df
RC
56432002-02-19 Robert Collins <rbtcollins@hotmail.com>
5644
5645 * mount.cc (create_mount): Avoid a const char*->char* warning.
5646 (read_mounts): Ditto.
5647
3bab9a49
RC
56482002-02-05 Jason Tishler <jason@tishler.net>
5649
58b12a06 5650 * download.cc (do_download_thread): Fix off-by-one error.
3bab9a49 5651
1ac649ed
RC
56522002-02-19 Robert Collins <rbtcollins@hotmail.com>
5653
5654 * configure.in (CXXFLAGS): Substitute at configure time, not runtime.
5655 * configure (CXXFLAGS): Regenerate.
5656 * Makefile.in (iniparse.o): Build via default rules - no errors now.
5657 * README: TODO list updates.
5658
56592002-02-19 Michael A Chase <mchase@ix.netcom.com>
5660
5661 * String++.cc (String::concat):: Remove.
5662 (String::vconcat):: Ditto.
5663 * String++.h (String::concat):: Remove.
5664 (String::vconcat):: Ditto.
5665 * archive_tar.cc: Don't include concat.h.
5666 * archive_tar_file.cc: Don't include concat.h.
5667 * compress_bz.cc (compress_bz::peek): Don't log unneeded messages.
5668 (compress_bz::seek): Ditto.
5669 (compress_bz::~compress_bz): Ditto.
5670 * compress_gz.cc (compress_gz::peek): Ditto.
5671 (compress_gz::error): Ditto.
5672 (compress_gz::~compress_gz): Ditto.
5673 * concat.cc (vconcat): Remove.
5674 (concat): Ditto.
5675 * concat.h (vconcat): Remove.
5676 (concat): Ditto.
5677 * desktop.cc (desktop_icon): Use new cygpath.
5678 (make_etc_profile): Ditto.
5679 (uexists): Ditto.
5680 (make_passwd_group): Ditto.
5681 (save_icon): Ditto.
5682 (check_desktop): Remove concat use.
5683 (check_start_menu): Ditto.
5684 * download.cc (download_one): Use new mkpath_p correctly.
5685 Use LOG_PLAIN.
5686 * fromcwd.cc: Don't include concat.h.
5687 * geturl.cc (get_url_to_membuf): Use String log() call.
5688 (get_url_to_file): Ditto.
5689 * install.cc: Don't include concat.h.
5690 (uninstall_one): Use LOG_PLAIN.
5691 (replace_one): Ditto.
5692 (install_one_source): Ditto.
5693 (install_one): More char to String conversion.
5694 (do_install_thread): Use new cygpath.
5695 Use new create_mount.
5696 * io_stream.cc (io_stream::move): Use new log().
58b12a06
MB
5697 * io_stream_cygfile (io_stream_cygfile::io_stream_cygfile): Use new
5698 cygpath.
1ac649ed
RC
5699 (io_stream_cygfile::exists): Ditto.
5700 (io_stream_cygfile::remove): Ditto.
5701 (io_stream_cygfile::mklink): Ditto.
5702 (io_stream_cygfile::write): Ditto.
5703 (cygmkdir_p): Ditto.
5704 (io_stream_cygfile::move): Ditto.
5705 * io_stream_file.cc: Don't include log.h.
5706 (io_stream_file::write): Don't log unneeded messages.
5707 * localdir.cc: Don't include concat.h.
5708 (LocalDirPage::OnNext): Use LOG_PLAIN.
5709 * log.cc: Don't include log.h.
5710 (exit_setup): Use new cygpath.
5711 * log.h (log_level): Add new level LOG_PLAIN.
5712 * main.cc (WinMain): Use new log().
5713 * mount.cc (SLASH_P): New macro from concat.h.
5714 (cygpath): Make String version globally visible.
5715 Remove varargs version.
5716 * mount,h: Ditto.
5717 * msg.cc (mbox): Use LOG_PLAIN.
5718 * net.cc (NetPage::OnNext): Ditto.
5719 * nio-ftp.cc (ftp_line): Use new log().
5720 * nio-http.cc: Don't include log.h.
5721 (retry_get): Use alternative url variable.
5722 * package_db.cc: Don't include concat.h.
5723 (packagedb::flush): Don't use concat.
5724 * package_meta.cc: Don't include concat.h.
5725 (packagemeta::uninstall): Use new cygpath.
5726 * postinstall.cc (do_postinstall): Ditto.
5727 * root.cc (RootPage::OnNext): Use LOG_PLAIN.
5728 * script.cc: Don't include concat.h.
5729 (init_run_script): Use new cygpath.
5730 (run_script): More char * to String conversion.
5731 (try_run_script): Ditto.
5732 * site.cc: Don't include concat.h.
5733 (SitePage::OnNext): Use LOG_PLAIN.
5734 (SitePage::OnMessageCmd): Use new log().
5735 * source.cc (SourcePage::OnDeactivate): Use LOG_PLAIN.
5736
3c054baf
RC
57372002-02-19 Robert Collins <rbtcollins@hotmail.com>
5738
5739 * Makefile.in (OBJS): Add new object.
58b12a06
MB
5740 * PickCategoryLine.cc (PickCategoryLine::paint): Print a "+" before the
5741 name.
3c054baf
RC
5742 * PickCategoryLine.h (PickCategoryLine::bucket): Use the String class.
5743 * PickLine.h (Pickline::key): Change to a String to help plug leaks.
5744 (PickLine::Pickline): Accept a String for the key.
58b12a06
MB
5745 * PickPackageLine.cc (PickPackageLine::paint): Convert all char use to
5746 Strings.
5747 * PickPackageLine.h (PickPackageLine::PickPackageLine): The key is
5748 automatically initialised now.
3c054baf 5749 * PickView.cc (PickView::note_width): Convert all char * use to Strings.
58b12a06
MB
5750 (PickView::init_header): Move category length checking out of the inner
5751 loop for efficiency.
3c054baf
RC
5752 Convert all char use to Strings.
5753 * PickView.h: Include the String++ header.
5754 (PickView::note_width): Update the prototype.
5755 * String++.cc: New file, implements a reference counting string class.
5756 * String++.h: New file, declares a reference counting string class.
5757 * archive.cc: Include String++ instead of concat.
5758 (archive::extract_file): Convert char * usage to Strings.
5759 * archive.h: Inlude the String++ header.
5760 (archive::extract_file): Update prototype.
5761 (archive::next_file_name): Convert to a String.
5762 (archive::linktarget): Ditto.
5763 * archive_tar.cc (archive_tar::next_file_name): Convert to String usage.
5764 (archive_tar::linktarget): Ditto.
5765 * arhive_tar.h: Update the copyright.
5766 Explicitly include the relevant headers.
5767 (tar_map_result_type): Convert to String usage.
5768 (archive_tar::next_file_name): Update prototype.
5769 (archive_tar::linktarget): Ditto.
5770 * category.cc (Category::Category): Update initialisers.
5771 Convert to String usage.
5772 (Categorycmp): Update to String usage.
5773 * category.h: Include the String++ header.
5774 (Category::Category): Update to String usage.
5775 (Category::name): Ditto.
5776 (Category::key): Ditto.
5777 * choose.cc: Remove concat.h, it's not needed.
5778 (scan2): Update to String usage.
5779 (do_choose): Ditto.
5780 * cygpackage.cc: Update includes for use of String class.
5781 (cygpackage::cygpackage): Update for String usage.
5782 (cygpackage::set_canonical_version): Ditto.
5783 (cygpackage::destroy): Ditto.
5784 (cygpackage::getfirstfile): Ditto.
5785 (cygpackage::getnextfile): Ditto.
5786 (cygpackage::Name): Ditto.
5787 (cygpackage::Vendor_version): Ditto.
5788 (cygpackage::Package_version): Ditto.
5789 (cygpackage::Canonical_version): Ditto.
5790 (cygpackage::set_sdesc): Ditto.
5791 (cygpackage::set_ldesc): Ditto.
5792 * cygpackage.h: Include String++.h for parsing this file.
5793 (cygpackage::cygpackage): Update for String usage.
5794 (cygpackage::set_canonical_version): Ditto.
5795 (cygpackage::destroy): Ditto.
5796 (cygpackage::getfirstfile): Ditto.
5797 (cygpackage::getnextfile): Ditto.
5798 (cygpackage::Name): Ditto.
5799 (cygpackage::Vendor_version): Ditto.
5800 (cygpackage::Package_version): Ditto.
5801 (cygpackage::Canonical_version): Ditto.
5802 (cygpackage::set_sdesc): Ditto.
5803 (cygpackage::set_ldesc): Ditto.
5804 (cygpackage::name): Ditto.
5805 (cygpackage::vendor): Ditto.
5806 (cygpackage::packagev): Ditto.
5807 (cygpackage::canonical): Ditto.
5808 (cygpackage::fn): Ditto.
5809 (cygpackage::sdesc): Ditto.
5810 (cygpackage::ldesc): Ditto.
5811 * desktop.cc: Update includes for use of String class.
5812 (batname): Update for String usage.
5813 (iconname): Ditto.
5814 (make_link): Ditto.
5815 (start)menu): Ditto.
5816 (desktop_icon): Ditto.
5817 (make_cygwin_bat): Ditto.
5818 (make_etc_profile): Ditto.
5819 (uexists): Ditto.
5820 (make_passwd_group): Ditto.
5821 (save_icon): Ditto.
5822 (check_desktop): Ditto.
5823 (check_startmenu): Ditto.
5824 * dialog.cc (eget): Update for String usage.
5825 (egetString): New function.
5826 (eset): New variant for Strings.
5827 * dialog.h: Include String++.h for parsing this file.
5828 (egetString): New function.
5829 (eset): New variant for Strings.
5830 * diskfull.cc (diskfull): Update for String usage.
5831 * diskfull.h: Include String++.h for parsing this file.
5832 (diskfull): Update for String usage.
5833 * download.cc: Update includes for use of String class.
5834 (check_for_cached): Update for String usage.
5835 (download_one): Ditto.
5836 * filemanip.cc (get_file_size): Ditto.
5837 (base): Ditto.
5838 (parse_filename): Ditto.
5839 (backslash): Ditto.
5840 * filemanip.h: Include String++.h for parsing this file.
5841 (fileparse): Update for String usage.
5842 (base): Ditto.
5843 (parse_filename): Ditto.
5844 Don't consider '_' to be a separator.
5845 (backslash): Ditto.
5846 * find.cc: Update includes for use of String class.
5847 (find_sub): Make more flexible.
5848 (find): Update for String usage.
5849 * find.h (find): Use Strings.
5850 * fromcwd.cc (found_file): Update for String usage.
5851 * geturl.cc: Ditto.
5852 (init_dialog): Ditto.
5853 (get_url_to_membuf): Ditto.
5854 (get_url_to_string): Ditto.
5855 (get_url_to_file): Ditto.
5856 * geturl.h: Ditto.
5857 (get_url_to_membuf): Ditto.
5858 (get_url_to_string): Ditto.
5859 (get_url_to_file): Ditto.
5860 * hash.h: Ditto.
5861 (add_subdirs): Ditto.
5862 * ini.cc: Update includes for String usage.
5863 (find_routine): Update for String usage.
5864 (do_remote_ini): Ditto.
5865 (do_ini_thread): Ditto.
5866 * ini.h (ini_init): Ditto.
5867 * inilex.l: Update includes for String usage.
5868 (ini_init): Update for String usage.
5869 * iniparse.y: Ditto.
5870 (add_correct_version): Ditto.
5871 * install.cc: Update includes for String usage.
5872 (install_one_source): Update for String usage.
5873 (uninstall_one): Ditto.
5874 (replace_one): Ditto.
5875 (install_one_source): Ditto.
5876 (do_install_thread): Ditto.
5877 * io_stream.cc: Update includes for String usage.
5878 (io_stream::open): Update for String usage.
5879 (io_stream::mkpath_p): Ditto.
5880 (io_stream::remove): Ditto.
5881 (io_stream::mklink): Ditto.
5882 (io_stream::move_copy): Ditto.
5883 (io_stream::move): Ditto.
5884 (io_stream::exists): Ditto.
5885 * io_stream.h: Update includes to allow correct parsing.
5886 (io_stream::open): Update for String usage.
5887 (io_stream::mkpath_p): Ditto.
5888 (io_stream::remove): Ditto.
5889 (io_stream::mklink): Ditto.
5890 (io_stream::move_copy): Ditto.
5891 (io_stream::move): Ditto.
5892 (io_stream::exists): Ditto.
5893 * io_stream_cygfile.cc: Update includes for String usage.
5894 (get_root_dir_now): Update for String usage.
5895 (io_stream_cygfile::io_stream_cygfile): Ditto.
5896 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5897 (io_stream_cygfile::exists): Ditto.
5898 (io_stream_cygfile::remove): Ditto.
5899 (io_stream_cygfile::mklink): Ditto.
5900 (cygmkdir_p): Ditto.
5901 (io_stream_cygfile::set_mtime): Ditto.
5902 (io_stream_cygfile::move): Ditto.
5903 (io_stream_cygfile::get_size): Ditto.
5904 * io_stream_cygfile.h: Update includes for String usage.
5905 (io_stream_cygfile::io_stream_cygfile): Update for String usage.
5906 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5907 (io_stream_cygfile::exists): Ditto.
5908 (io_stream_cygfile::remove): Ditto.
5909 (io_stream_cygfile::mklink): Ditto.
5910 (cygmkdir_p): Ditto.
5911 (io_stream_cygfile::set_mtime): Ditto.
5912 (io_stream_cygfile::move): Ditto.
5913 (io_stream_cygfile::get_size): Ditto.
5914 (io_stream_cygfile::fname): Ditto.
5915 (io_stream_cygfile::lmode): Ditto.
5916 * io_stream_file.cc: Update includes for String usage.
5917 (io_stream_file::io_stream_file): Update for String usage.
5918 (io_stream_file::~io_stream_file): Ditto.
5919 (io_stream_file::exists): Ditto.
5920 (io_stream_file::remove): Ditto.
5921 (io_stream_file::mklink): Ditto.
5922 (io_stream_file::set_mtime): Ditto.
5923 (io_stream_file::move): Ditto.
5924 (io_stream_file::get_size): Ditto.
5925 * io_stream_file.h: Update includes for String usage.
5926 * io_stream_file.cc: Update includes for String usage.
5927 (io_stream_file::io_stream_file): Update for String usage.
5928 (io_stream_file::~io_stream_file): Ditto.
5929 (io_stream_file::exists): Ditto.
5930 (io_stream_file::remove): Ditto.
5931 (io_stream_file::mklink): Ditto.
5932 (io_stream_file::set_mtime): Ditto.
5933 (io_stream_file::move): Ditto.
5934 (io_stream_file::get_size): Ditto.
5935 (io_stream_file::fname): Ditto.
5936 (io_stream_file::lmode): Ditto.
5937 * localdir.cc: Update includes for String usage.
5938 (save_local_dir): Update for String usage.
5939 (check_if_enable_next): Ditto.
5940 (load_dialog): Ditto.
5941 (browse_cb): Ditto.
5942 (LocalDirPage::OnInit): Ditto.
5943 (LocalDirPage::OnNext): Ditto.
5944 * log.cc: Update includes for String usage.
5945 (struct LogEnt): Update for String usage.
5946 (log): Ditto.
5947 (log_save): Ditto.
5948 (exit_setup): Ditto.
5949 * log.h: Update includes for String usage.
5950 (log_level): Update for String usage.
5951 (log): Ditto.
5952 (log_save): Ditto.
5953 * main.cc (WinMain): Update for String usage.
5954 * mklink2.c (make_link_2): Update for String usage.
5955 * mklink2.h (make_link_2): Update for String usage.
5956 * mount.cc: Update includes for String usage.
5957 (mount_table): Update for String usage.
5958 (find2): Ditto.
5959 (create_mount): Ditto.
5960 (remove1): Ditto.
5961 (remove_mount): Ditto.
5962 (read_mounts): Ditto.
5963 (set_root_dir): Ditto.
5964 (get_root_dir): Ditto.
5965 (path_prefix_p): Ditto.
5966 (cygpath): Ditto.
5967 * mount.h: Update includes for String usage.
5968 (create_mount): Update for String usage.
5969 (remove_mount): Ditto.
5970 (cygpath): Ditto.
5971 (set_root_dir): Ditto.
5972 (get_root_dir): Ditto.
5973 * msg.cc (mbox): Ditto.
5974 * net.cc (NetPage::OnNext): Ditto.
5975 * package_db.cc (packagedb::flush): Ditto.
5976 (packagedb::packages): Ditto.
5977 (packagedb::categories): Ditto.
5978 * package_db.h: Update includes for String usage.
5979 (packagedb::packages): Update for String usage.
5980 (packagedb::categories): Ditto.
5981 * package_meta.cc: Update includes for String usage.
5982 (hash::add_subdirs): Update for String usage.
5983 (packagemeta::uninstall): Ditto.
5984 (packagemeta::SDesc): Ditto.
5985 (packagemeta::action_caption): Ditto.
5986 * package_meta.h: Update includes for String usage.
5987 (packagemeta::packagemeta): Update for String usage.
5988 (packagemeta::~packagemeta): Ditto.
5989 (packagemeta::uninstall): Ditto.
5990 (packagemeta::SDesc): Ditto.
5991 (packagemeta::action_caption): Ditto.
5992 (package_source.cc site::site): Ditto.
5993 (packagesource::set_canonical): Ditto.
5994 (packagesource::set_cached): Ditto.
5995 * package_source.h: Update includes for String usage.
5996 (site::site): Update for String usage.
5997 (packagesource::set_canonical): Ditto.
5998 (packagesource::set_cached): Ditto.
5999 (packagesource::packagesource): Ditto.
6000 (packagesource::sites): Ditto.
6001 (packagesource::cached): Ditto.
6002 * package_version.h: Update includes for String usage.
6003 (Dependency): Update for String usage.
6004 (packageversion): Ditto.
6005 * postinstall.cc: Update includes for String usage.
6006 (do_postinstall): Update for String usage.
6007 * res.rc (IDD_LOCAL_DIR): Fix typo again!
6008 * rfc1738.cc (rfc1738_escape_part): Update for String usage.
6009 * rfc1738.h: Update includes for String usage.
6010 (rfc1738_escape_part): Update for String usage.
6011 * root.cc: Update includes for String usage.
6012 (check_if_enable_next): Update for String usage.
6013 (save_dialog): Ditto.
6014 (browse_cb): Ditto.
6015 (directory_is_absolute): Ditto.
6016 (directory_is_rootdir): Ditto.
6017 (directory_has_spaces): Ditto.
6018 (RootPage::OnInit): Ditto.
6019 (RootPage::OnNext): Ditto.
6020 * script.cc: Update includes for String usage.
6021 (init_run_script): Update for String usage.
6022 (run): Ditto.
6023 (run_script): Ditto.
6024 (try_run_script): Ditto.
6025 * script.h: Update includes for String usage.
6026 (run_script): Update for String usage.
6027 (try_run_script): Ditto.
6028 * site.cc site_list): Ditto.
6029 (all_site_list): Ditto.
6030 (other_url): Eliminate.
6031 (site_list_type::init): Update for String usage.
6032 (site_list_type::site_list_type): Ditto.
6033 (get_site_list): Ditto.
6034 (get_saved_sites): Ditto.
6035 (do_download_site_info_thread): Ditto.
6036 (SitePage::OnNext): Ditto.
6037 (SitePage::OnActivate): Ditto.
6038 (SitePage::PopulateListBox): Ditto.
6039 (SitePage::OnMessageCmd): Handle empty url's.
6040 * site.h: Update includes for String usage.
6041 (site_list_type::site_list_type): Update for String usage.
6042 (site_list_type::init): Ditto.
6043 (site_list_type::~site_list_type): Ditto.
6044 (site_list_type::url): Ditto.
6045 (site_list_type::displayed_url): Ditto.
6046 (site_list_type::key): Ditto.
6047 * source.cc (SourcePage::OnDeactivate): Ditto.
6048 * state.h: Update includes for String usage.
6049 (local_dir): Update for String usage.
6050 (trust_level): Remove.
6051 * version.cc: Update includes for String usage.
6052 (canonicalize_version): Update for String usage.
6053 * version.h: Update includes for String usage.
6054 (canonicalize_version): Update for String usage.
6055
08233ec7
CF
60562002-02-15 Christopher Faylor <cgf@redhat.com>
6057
6058 * filemanip.c (parse_filename): Revert previous change.
6059
94dffbdd
CF
60602002-02-14 Christopher Faylor <cgf@redhat.com>
6061
6062 * filemanip.c (parse_filename): Don't treat '_' as a version number
6063 introducer.
6064
cef493d7
CF
60652002-01-29 Christopher Faylor <cgf@redhat.com>
6066
6067 * configure: Regenerate.
6068
57219197
RC
60692002-01-27 Robert Collins <rbtcollins@hotmail.com>
6070
94dffbdd
CF
6071 * res.rc (IDD_LOCAL_DIR): Fix typo reported by Rene
6072 <Hoeck@extern.lrz-muenchen.de>
57219197 6073
cc7493c3
RC
60742002-01-27 Robert Collins <rbtcollins@hotmail.com>
6075
6076 * README: Update Todo's.
6077 * list.h: Run indent.
6078 (list): New methods checksize and insert to reduce code duplication.
6079 (list::registerbykey): Use them.
6080 (list::registerbyobject): Ditto.
94dffbdd
CF
6081 (list::removebyindex): Copy each object individually - safe for non
6082 trivial objects.
cc7493c3
RC
6083 (list::checksize): Implement.
6084 (list::insert): Implement.
6085
a900d1fa
RC
60862002-01-27 Robert Collins <rbtcollins@hotmail.com>
6087
6088 * Makefile.in: Remove the dlmalloc object by default.
94dffbdd
CF
6089 * install.cc (do_install_thread): Remove the mallinfo call for 'working
6090 around' the crashing issue.
a900d1fa 6091 * package_db.h: Include <string.h> - it's needed to parse this.
94dffbdd 6092 * package_source.cc (site::site): Move here from the header file.
a900d1fa
RC
6093 * package_source.h (site): Stop the constructor being inlinable.
6094
9835fb4a
RC
60952002-01-26 Robert Collins <rbtcollins@hotmail.com>
6096
6097 * filemanip.cc (find_tar_ext): Add a descriptive comment.
6098
60992002-01-25 Michael A Chase <mchase@ix.netcom.com>
6100
6101 * filemanip.cc (find_tar_ext): Clean up tests for .tar.gz and .tar.
6102 * fromcwd.cc (do_fromcwd): Expand FIXME comment in source file check.
94dffbdd
CF
6103 * install.cc (install_one_source): Add space between words in log()
6104 call.
cef493d7 6105
77ba23d8
RC
61062002-01-22 Robert Collins <rbtcollins@hotmail.com>
6107
94dffbdd
CF
6108 * log.cc (exit_setup): When saving to the download dir, explicity
6109 specify the path.
77ba23d8 6110
6dc75764
RC
61112002-01-22 Robert Collins <rbtcollins@hotmail.com>
6112
94dffbdd
CF
6113 * archive.cc (extract_file): Separate out the prefix and the URL
6114 scheme.
6dc75764 6115 * archive.h (archive::extract_file): Ditto.
94dffbdd
CF
6116 * install.cc (install_one_source): Ditto. Use the new
6117 archive::extract_file syntax.
6dc75764
RC
6118 (replace_one): Use the new syntax.
6119 (io_stream.cc): Add some log info for links.
6120
7e8fc33c
RC
61212002-01-22 Robert Collins <rbtcollins@hotmail.com>
6122
6123 * PickCategoryLine.cc (PickCategoryLine::actiontext): Remove.
6124 (PickCategoryLine::paint): Use the new action method.
6125 (PickCategoryLine::click): Set the action for all children.
6126 (PickCategoryLine::set_action): New method.
6127 * PickCategoryLine.h (PickCategoryLine::-actions): Remove.
6128 (PickCategoryLine::current_default): Use packagemeta _actions class.
94dffbdd
CF
6129 * PickLine.h (PickLine::set_action): New abstract method that requires
6130 including package_meta.h.
7e8fc33c
RC
6131 * PickPackageLine.cc (PickPackageLine::set_action): New method.
6132 * PickPackageLine.h (PickPackageLine::set_action): Declare this.
6133 * list.h (getbykey): A const correctness fix.
6134 * package_meta.cc: Run indent.
6135 (packagemeta::Default_action): New const.
6136 (packagemeta::Install_action): Ditto.
6137 (packagemeta::Reinstall_action): Ditto.
6138 (packagemeta::Uninstall_action): Ditto.
6139 (packagemeta::_actions::caption): New method.
6140 (packagemeta::_actions::operator++): Ditto.
6141 (packagemeta::set_action): New overload.
6142 * package_meta.h (packagemeta::_actions): New class.
6143 (packagemeta::set_action): Declare this.
6144
2c9254b6
RC
61452002-01-22 Robert Collins <rbtcollins@hotmail.com>
6146
6147 * Makefile.in (OBJS): Remove supp.o - it appears accidental.
6148 * choose.cc: Don't define alloca anymore, it's done in win32.h
6149
97647369
RC
61502002-01-22 Robert Collins <rbtcollins@hotmail.com>
6151
6152 * PickPackageLine.cc: New file.
6153 * PickPackageLine.h: New file.
6154 * PickLine.cc: New file.
6155 * PickLine.h: New file.
6156 * PickCategoryLine.cc: New file.
6157 * PickCategoryLine.h: New file.
6158 * PickView.cc: New file.
6159 * PickView.h: New file.
6160 * Makefile.in: Add new objects to setup.exe.
6161 Backout -fno-exceptions option.
6162 * choose.cc: Include PickView.h.
6163 Remove view related defines and static variables.
6164 (_pkg_headers): Moved to PickView.cc.
6165 (_cat_headers): Ditto.
6166 (view::views::Unknown): Ditto.
6167 (view::views::PackageFull):
6168 (view::views::Package):
6169 (view::views::Category):
6170 (pkgtrustp): Moved to package_meta.cc.
6171 (add_required): Moved to package_meta.cc.
6172 (pick_category_line::empty): Moved to PickCategoryLine.cc
6173 (paint): Adjust for moved static variables.
6174 (view::scroll): Moved to PickView.cc.
6175 (list_vscroll): Adjust for moved static variables.
6176 (list_hscroll): Ditto.
6177 (list_click): Ditto.
6178 (note_width): Moved to PickView.cc.
6179 (view::view): Ditto.
6180 (view::set_view_mode): Ditto.
6181 (view::mode_caption): Ditto.
6182 (view::views::caption): Ditto.
6183 (view::set_headers): Ditto.
6184 (DoInsertItem): Ditto.
6185 (view::init_headers): Ditto.
6186 (view::insert_pkg): Ditto.
6187 (view::insert_category): Ditto.
6188 (view::clear_view): Ditto.
6189 (view::views::operator++): Ditto.
6190 (view::click): Ditto.
6191 (default_trust): Adjust for moved statics.
6192 (pick_pkg_line::paint): Moved to PickPackageLine.cc.
6193 (pick_pkg_line::click): Ditto.
6194 (pick_category_line::actiontext): Moved to PickCategoryLine.cc
6195 (pick_category_line::paint): Ditto.
6196 (pick_category_line::click): Ditto.
6197 (set_view_mode): Adjust for moved statics.
6198 (create_listview): Ditto.
58b12a06
MB
6199 * choose.h: Remove Category and packagemeta forward defines -
6200 not needed.
97647369
RC
6201 Don't include unneeded headers list and package_meta.
6202 (_header): Move to PickView.h.
6203 (pick_line): Move to PickLine.h.
6204 (pick_pkg_line): Move to PickPackageLine.h.
6205 (pick_category_line): Move to PickCategoryLine.h.
6206 (view): Move to PickView.h.
6207 * ini.h (trusts): Move to package_meta.h.
6208 * package_meta.h (trusts): New enum.
6209 (packagemeta::set_requirements): New helper method.
6210 (packagemeta::trustp): Ditto.
6211
b566778e
CF
62122002-01-21 Christopher Faylor <cgf@redhat.com>
6213
6214 * choose.h (view): Move forward declaration of views into public area
6215 or g++ v3 will complain.
6216
f71e9756
CF
62172002-01-21 Christopher Faylor <cgf@redhat.com>
6218
6219 * Makefile.in (CXXFLAGS): Add -fno-exceptions.
6220 * win32.h (alloca): Define as __builtin_alloca.
6221 * io_stream_memory.cc: Add include file.
6222
e9440f0f
RC
62232002-01-21 Robert Collins <rbtcollins@hotmail.com>
6224
58b12a06
MB
6225 * archive_tar.cc (archive_tar::~archive_tar): Mark the stream as
6226 destroyed.
e9440f0f
RC
6227 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
6228 * compress.cc (compress::~compress): Be less verbose.
6229 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
6230 Mark the stream as destroyed.
58b12a06
MB
6231 * compress_gz.cc (compress_gz::~compress_gz): Mark the stream as
6232 destroyed.
6233 * io_stream.cc (io_stream::~io_stream): Only warn when the stream is not
6234 marked as destroyed.
cef493d7 6235 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Mark the
e9440f0f
RC
6236 stream as destroyed.
6237 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
6238 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
cef493d7 6239
5e0464a1
RC
62402002-01-21 Robert Collins <rbtcollins@hotmail.com>
6241
6242 * Makefile.in (CFLAGS): Allow customisable malloc debug flags.
6243 (OBJS): Link in malloc objects.
6244 * category.cc (category): Use new char, not strdup.
6245 * choose.cc (pick_pkg_line::paint): Allow for the regionsize to shrink.
6246 (do_choose): Use new char, not malloc.
6247 * concat.cc (vconcat): Ditto.
6248 * cygpackage.cc (cygpackage): Use new char, not strdup.
6249 (set_canonical_version): Ditto.
6250 (cygpackage::destroy): Use delete[], not free.
6251 * desktop.cc (uexists): Ditto.
6252 * dialog.cc (egest): Use new char, not strdup.
6253 * dlmalloc.c: New file - Doug Lea's malloc 2.7.0
6254 * hash.cc (hash::hash): Use delete instead of free.
6255 (hash::add): Use new char, not strdup.
6256 * ini.cc (do_remote_ini): Use delete[] not free.
6257 * inilex.l: Use new char, not strdup.
6258 (ini_init): Ditto.
6259 * iniparse.y: Ditto.
6260 Use a local package_db rather than a static one.
6261 * install.cc (struct mallinfo): Workaround an apparent dlmalloc bug.
6262 (do_install_thread): Call mallinfo to force a consistency check. Appears
6263 to fix a 'inuse' error in -DDEBUG builds.
6264 Use delete[] for strings.
58b12a06
MB
6265 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Use new
6266 char, not strdup.
5e0464a1
RC
6267 (io_stream_cygfile::~io_stream_cygfile): Use delete[], not free.
6268 (io_stream_cygfile::remove): Use new char, not strdup.
58b12a06
MB
6269 * io_stream_file.cc (io_stream_file::io_stream_file): Use new char, not
6270 strdup.
5e0464a1
RC
6271 (io_stream_file::io_stream_file): Use delete[], not free.
6272 (io_stream_file::remove): Use new char, not strdup.
6273 * io_stream_memory.cc (memblock::~memblock): Use delete[], not free.
6274 * io_stream_memory.h (memblock): Use new char, not malloc.
6275 * localdir.cc (LocalDirPage::OnInit): Use new char, not strdup.
6276 * main.cc (WinMain): Use new char, not strdup.
6277 * mount.cc (find2): Use new char, not malloc.
6278 (read_mounts): Ditto.
6279 (cygpath): Use new char, not strdup.
6280 * netio.cc (NetIO::~NetIO): Use delete[], not free.
6281 (NetIO::set_url): Use new char, not strdup.
6282 (NetIO::get_ftp_auth): Use delete[], not free.
6283 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
6284 Use new char instead of strdup.
6285 * nio-http.cc (base64_encode): Use new char, not malloc.
6286 * package_meta.cc (hash::add_subdirs): Use new char instead of strdup.
6287 * package_source.h (~ packagesource): Use delete[] instead of delete.
6288 * port.h (strdup): Deprecate the use of strdup.
6289 * rfc1738.cc (rfc1738_do_escape): Use new char, not calloc.
6290 * script.cc (init_run_script): Us delete[], not free.
6291 (run_script): Ditto.
6292 * simpsock.cc (SimpleSocket::fill): Use new char, not malloc.
6293 (SimpleSocket::invalidate): Use delete[], not free.
6294 * site.cc (site_list_type::init): Use new char instead of strdup.
6295 * site.h (~site_list_type): Use delete[], not free.
6296
ad3c7385
RC
62972002-01-20 Robert Collins <rbtcollins@hotmail.com>
6298
6299 * Makefile.in (OBJS): Add win32.o - win32 support functions.
6300 * README: Update todos.
58b12a06
MB
6301 * archive.cc (extract_file): Support a suffix for appending to extracted
6302 files.
ad3c7385
RC
6303 * archive.h: Ditto.
6304 * choose.cc (set_view_mode): Use the new view::views class.
6305 (view::views::Unknown): New static for defaulting view::views variables.
6306 (view::views::PackageFull): New static for the current view.
6307 (view::views::Package): Ditto.
6308 (view::views::Category): Ditto.
6309 (topbucket::paint): Remove.
6310 (topbucket::empty): Rename to pick_category_line::empty.
6311 (topbucket::~topbucket): Remove.
6312 (paint): Use the new view::views class.
6313 Don't paint 'all' as a category when showing package categoies.
6314 (pick_category_line::actiontext): New method.
58b12a06
MB
6315 (pick_category_line::paint): Make showing the category optional, and
6316 show the 'category action'.
ad3c7385 6317 (pick_category_line::click): Make showing the category optional, and
58b12a06
MB
6318 differentiate between the name being clicked, and the action
6319 description.
ad3c7385
RC
6320 (view::view): Use the new view::views class.
6321 (view::set_view_mode): Ditto.
6322 (view::mode_caption): Ditto.
6323 (view::views::caption): New method.
6324 (view::set_headers): Use the new view::views class.
6325 (view::clear_view): Ditto.
cef493d7 6326 (viewsplusplus): Replaced by
ad3c7385
RC
6327 (view::views::operator++): New operator.
6328 (set_view_mode): Use the new view::views class.
6329 (create_listview): Ditto.
6330 (dialog_cmd): Ditto.
6331 * choose.h (actions): Remove.
6332 (views): Remove.
6333 (pick_line): Add a new convenience constructor.
6334 (top_bucket): Remove.
6335 (pick_category_line): Reparent under pick_line, and adsorb top_bucket.
6336 (view::views): New class.
6337 * ini.h: Don't include choose.h
6338 (is_download_action): Remove.
6339 (is_upgrade_action): Remove.
6340 (is_uninstall_action): Remove.
6341 (is_full_action): Remove.
6342 * install.cc (num_replacements): New static.
6343 (rebootneeded): Ditto.
6344 (replace_one): Handle upgrades separate from removal or new installs.
6345 (install_one_source): Handle in use files.
6346 (install_one): Don't repeat upgrades.
6347 (do_install_thread): Initialize new statics.
6348 Order actions as uninstall, replace, install.
6349 Warn about rebooting if needed.
6350 * res.rc (IDS_REBOOT_REQUIRED): New string.
6351 * resource.h (IDS_REBOOT_REQUIRED): Give value.
6352 * win32.h: Declare class Win32, and update copyright and intent message.
6353 * win32.cc: New file.
6354
edef4f57
CV
63552002-01-15 Corinna Vinschen <corinna@vinschen.de>
6356
6357 * io_stream.cc (io_stream::gets): Eliminate trailing new line chars.
6358 * package_meta.cc (packagemeta::uninstall): Check for additional
6359 Windows shortcut. Unset R/O file attribute before trying to delete
6360 file.
6361
21f325d7
RC
63622002-01-09 Robert Collins <rbtcollins@hotmail.com>
6363
58b12a06
MB
6364 * choose.cc (pkgtrustp): Fall back to installed if a package is not
6365 present in the current trust level. For prev, fall back via curr.
21f325d7
RC
6366 (set_existence): Allow sources with no sites, but cached files to be
6367 kept.
6368 (pick_category_line::paint): Start drawing clickable categories.
6369 * fromcwd.cc (found_file): Reinstate local file scanning.
6370
858f100d
RC
63712002-01-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6372
cef493d7 6373 * fromcwd.cc: Run indent.
858f100d
RC
6374 (do_fromcwd): Reverse sense of comment. Set next_dialog
6375 to IDD_CHOOSER instead of IDD_CHOOSE.
6376 * ini.cc (find_routine): Remove "/" from "/setup.ini".
cef493d7 6377
d343da15
RC
63782001-01-07 Robert Collins <rbtcollins@hotmail.com>
6379
6380 * category.cc (Categorycmp): Add a const safe version.
6381 * category.h (Categorycmp): Add a const safe version.
6382 (Category): Add operator ==.
6383 * choose.cc (fill_missing_category): Add every package to "All".
58b12a06
MB
6384 (pick_category_line::paint): Add support for hidden labels, and a tree
6385 depth.
d343da15
RC
6386 (pick_category_line::click): Ditto.
6387 (view::view): Pass in a top level category to use.
6388 (view::insert_pkg): Special case - skip category "All".
6389 (view::insert_category): Ditto.
6390 (view::clear_view): Set the contents label state.
6391 (create_listview): Pass in a top level category to view().
6392 * choose.h (topbucket): Make bucket available to derived classes.
6393 (pick_category_line): Add support for hidden labels, and a tree depth.
6394 Remove our second copy of bucket.
6395 (view): Pass in a top level category to the constructor.
6396 Use pick_category_line to allow three level display.
6397
bcf20115
RC
63982001-01-06 Robert Collins <rbtcollins@hotmail.com>
6399
6400 * cygpackage.h (cygpackage): Make set_[s|l]desc virtual.
6401 * iniparse.y (add_correct_version): Copy descriptions across.
58b12a06
MB
6402 * package_meta.cc (SDesc): Iterate through versions, return the first
6403 with a description.
bcf20115
RC
6404 * package_version.h (packageversion): Add new virtuals set_[l|s]desc.
6405
bc78a6d5
RC
64062001-01-04 Robert Collins <rbtcollins@hotmail.com>
6407
6408 * script.cc (run_script): Change cygpath:// to cygfile://.
6409 * install.cc (do_install_thread): Fix off-by-one errors.
6410
4f4e55c2
RC
64112001-01-04 Robert Collins <rbtcollins@hotmail.com>
6412
6413 * package_db.cc (packagedb::flush): Fix an off-by-one error.
6414
8e9aa511
RC
64152002-01-04 Jan Nieuwenhuizen <janneke@gnu.org>
6416
6417 * Makefile.in (realclean): more clean.
6418 (OBJS): Add script.o.
6419 * postinstall.cc (run_script_in_etc_postinstall): New function.
6420 (do_postinstall): Split off new funtion init_run_script ().
6421 (init_run_script):
6422 (run):
6423 (run_script): Move to script.cc. Replace some deprecated remove
6424 and move calls.
6425 * script.h:
6426 * script.cc: New file.
6427 * Forward port cygwin-20010707.jcn3.patch.
6428 * package_meta.cc (uninstall): Run pre- and postremove scripts.
6429 * install.cc: Typo fix.
6430 (do_install): Run script initialisation.
cef493d7 6431
b7301c43
RC
64322001-01-04 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6433
6434 * cistring.cc: Run d2u.
6435 * cistring.h: Run d2u.
6436
6437 * desktop.cc (etc_profile): Remove "test -f ./.bashrc && . ./.bashrc"
6438 from the generated /etc/profile. Bash will source this file
6439 automatically, and having this here merely results in .bashrc being
6440 executed twice. Run d2u.
6441 * desktop.h: Run d2u.
6442
6443 * propsheet.cc: Run d2u.
6444 (PropSheetProc): New function. Add minimize box here instead of in
6445 PropertyPage::DialogProc.
6446 (PropSheet::Create): Change to use creation callback PropSheetProc.
6447 (DLGTEMPLATEEX): Add 'hidden' Windows struct definition.
6448
6449 * propsheet.h: Run indent, d2u.
6450 * proppage.h: Run indent, d2u.
6451
6452 * proppage.cc: Run d2u.
6453 (PropertyPage::DialogProc): Remove minimize-box-adding
6454 functionality. Remove commented-out "PropSheet_SetWizButtons" calls.
6455 Add support for calling virtual OnMessageCmd. Add setting of fonts in
6456 WM_INITDIALOG handler.
6457 (resource.h): New include for resource IDs.
6458
6459 * res.rc: Resize and rearrange property page dialog templates
6460 to bring them in line with "Microsoft's Backward Compatible Wizard 97"
6461 specification. Run d2u.
6462 (IDD_SITE): Add an edit control and an "Add" button in order to
6463 combine the IDD_SITE and IDD_OTHER_URL functionality onto one page.
6464 (IDD_OTHER_URL): Remove dialog template.
6465 (IDD_DLSTATUS): Remove dialog template.
6466
6467 * site.cc: Run d2u.
6468 (SitePage::OnBack): Remove NEXT() macro invocation.
6469 (SitePage::OnActivate): New member function.
6470 (load_dialog): Remove. Functionality subsumed into
6471 SitePage::OnActivate.
6472 (save_dialog): Change to support both list and user URLs. Remove
6473 OTHER_IDX and mirror_idx logic.
6474 (SitePage::PopulateListBox): New member function.
6475 (SitePage::CheckControlsAndDisableAccordingly): New member function.
6476 (SitePage::OnMessageCmd): New override.
6477 (check_if_enable_next): Remove.
6478 (dialog_cmd): Remove.
6479 (do_download_site_info_thread): Remove calls to NEXT() macro.
6480 (SitePage::Create): Call the single-param PropertyPage::Create
6481 overload.
6482 (other_url): New static taken from other.cc.
6483 (SitePage::OnNext): Remove mirror_idx logic.
6484 (SitePage::OnInit): Remove "Other URL" entry from list box. Remove
6485 list box populating code, now handled in SitePage::PopulateListBox.
6486 (mirror_idx, NO_IDX, OTHER_IDX): Remove.
6487 (save_site_url): Fix potential buffer overflow problem. Switched to
6488 TCHAR in grossly premature preparation for multilingual support.
6489 * site.h: Run d2u.
6490 (SitePage::OnActivate): New member function.
6491 (SitePage::CheckControlsAndDisableAccordingly) New member.
6492 (SitePage::OnMessageCmd): New override.
6493 (do_download_site_info_thread): Add MessageBox call on failure to
6494 download site list.
6495
6496 * splash.cc: Run d2u.
6497 (SplashPage::OnInit): Set the font for the title.
6498 * splash.h: Run d2u.
6499
6500 * threebar.cc: Run d2u.
6501 * threebar.h: Run d2u.
6502
6503 * window.h: Run d2u.
6504 (Window::IsButtonChecked): New member function declaration.
6505 (Window::OnMessageCmd): New member function.
6506 (Window::SetDlgItemFont): New member function declaration.
6507 (Window::MAXFONTS, Window::Fonts, Window::FontCounter): New data
6508 members.
6509 * window.cc: Run d2u.
6510 (Window::IsButtonChecked): New member function definition.
6511 (Window::SetDlgItemFont): New member function definition.
6512 (Window::Window): Add initialization for FontCounter.
6513 (Window::~Window): Delete any fonts we created.
6514
6515 * geturl.cc: Run d2u.
6516 (progress): Remove the "3" field width from the "%3d"
6517 percent-complete format indicator. Causes line to not start at
6518 beginning of text box, and does little to help with "jumping", since
6519 the "bytes downloaded so far" field is variable-width anyway. Change
6520 kb/s format field to "%03.1" to 0-pad the kb/s number in the event of
6521 painfully slow connections, or temporary slowdowns in faster
6522 connections should such more-instantaneous functionality become
6523 available.
6524
6525 * net.h: Run d2u.
6526 (NetPage::OnMessageCmd): New member function declaration.
6527 (NetPage::CheckIfEnableNext): New member function declaration.
6528 * net.cc: Run d2u.
6529 (NetPage::OnMessageCmd): New member function definition.
6530 (dialog_cmd): Remove, subsumed into NetPage::OnMessageCmd.
6531 (check_if_enable_next): Remove.
6532 (NetPage::CheckIfEnableNext): New member function, subsumes
6533 check_if_enable_next.
6534 (propsheet.h): Add include.
6535 (NetPage::Init): Add call to CheckIfEnableNext.
6536 (load_dialog): Remove call to check_if_enable_next.
6537 (NetPage::Create): Call single-template-ID-parameter overload of
6538 PropertyPage::Create instead of three-parameter one.
6539
6540 * Makefile.in (OBJS): Remove other.o.
6541 * other.cc: Remove file.
6542
df62e023
RC
65432002-01-01 Robert Collins <rbtcollins@hotmail.com>
6544
6545 * README: Update TODO's.
6546 * choose.cc (set_existence): Delete non installed packages with no
6547 mirrors.
6548 (fill_missing_category): Fix an off-by-one error.
cef493d7 6549 (default_trust): Ditto. Also delete any unused categories.
df62e023
RC
6550 (view::init_headers): Fix an off-by-one error.
6551 (set_view_mode): Ditto.
6552 (set_view_mode): Ditto.
6553 (create_listview): Ditto.
6554 (dialog_cmd): Ditto.
6555 (do_choose): Ditto.
6556 * io_stream.cc: Indent.
6557 * io_stream.h: Ditto.
6558 * package_db.cc: Ditto.
6559 * package_meta.h: Const correctness for SDesc ();
6560 * proppage.cc: Run d2u and indent.
6561 * propsheet.cc: Run d2u and indent.
6562 * window.cc: Run d2u and indent.
6563 * window.h: Run d2u and indent.
6564
cec57ee1
CF
65652001-12-28 Christopher Faylor <cgf@redhat.com>
6566
e98c531e 6567 * Makefile.in (iniparse.o): Accommodate newer bisons.
cec57ee1 6568
ab57ceaa
RC
65692001-12-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6570
6571 * window.h (Window): New file, new class.
6572 * window.cc (Window): New file, new class.
6573
6574 * threebar.h (ThreeBarProgressPage): New file, new class.
6575 * threebar.cc (ThreeBarProgressPage): New file, new class.
6576
6577 * splash.h (SplashPage): New file, new class.
6578 * splash.cc (SplashPage): Replace file with implementation of new
6579 class.
6580
6581 * source.h (SourcePage): New file, new class.
6582 * source.cc: Run indent.
6583 (SourcePage): Add class implementation to this file.
6584 (do_source): Remove, functionality subsumed by SourcePage::Create()
6585 and SourcePage::OnDeactivate().
cef493d7 6586 (dialog_proc): Remove, functionality subsumed by
ab57ceaa
RC
6587 SourcePage::OnActivate().
6588
6589 * site.h: Run indent.
6590 (SitePage): Add class declaration.
6591 * site.cc: Run indent.
6592 (SitePage): Add class implementation.
6593 (do_download_site_info_thread): New function.
6594 (context): New var. Context info for do_download_site_info_thread().
6595 (do_download_site_info): New function.
6596 (SitePage::Create, SitePage::OnInit SitePage::OnNext)
6597 (SitePage::OnBack): SitePage class implementation..
6598 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers, now handled
6599 by SitePage members.
6600 (dialog_proc): Remove, now handled by SitePage::OnInit and base class
6601 functionality.
6602 (do_site): Remove, now handled by do_download_site_info_thread() and
6603 SitePage::OnNext functionality.
6604 (get_site_list): Remove dismiss_url_status_dialog() call.
6605
6606 * root.h (RootPage): New file, new class.
6607 * root.cc: Run indent.
6608 (dialog_cmd): Pass parent HWND parameter to note(), yesno().
6609 (dialog_proc): Remove.
6610 (do_root): Remove
6611 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL clauses from switch.
6612 (RootPage::OnInit): New member function. Move get_root_dir() logic to
6613 here from do_root().
6614 (RootPage::Create): New member function.
cef493d7 6615 (RootPage::OnNext): New member function. Move IDOK logic from
ab57ceaa
RC
6616 dialog_cmd() to here.
6617 (RootPage::OnBack): New member function.
6618
6619 * propsheet.h (PropSheet): New file, new class.
6620 * propsheet.cc (PropSheet): New file, new class.
6621
6622 * proppage.h (PropertyPage): New file, new class.
6623 * proppage.cc (PropertyPage): New file, new class.
6624
6625 * postinstall.cc (do_postinstall): Add owner parameter.
6626
6627 * other.cc (do_other): Add owner parameter.
6628
6629 * nio-file.cc (NetIO::Purl): Pass NULL parent param to note().
cef493d7 6630 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Pass NULL parent param to
ab57ceaa 6631 get_ftp_auth().
cef493d7 6632 * nio-http.cc (retry_get): Pass NULL parent param to get_auth(),
ab57ceaa
RC
6633 get_proxy_auth(),
6634 and get_ftp_auth().
cef493d7 6635 * nio-ie5.cc (NetIO::_url): Pass NULL parent param to note(),
ab57ceaa
RC
6636 get_auth(), get_proxy_auth().
6637
6638 * netio.h (get_auth, get_proxy_auth, get_ftp_auth): Add owner param.
cef493d7 6639 * netio.cc (auth_common, NetIO::get_auth, NetIO::get_proxy_auth,
ab57ceaa
RC
6640 NetIO::get_ftp_auth)
6641 (auth_common): Add owner param. Pass owner param to DialogBox.
cef493d7 6642 (NetIO::get_auth, NetIO::get_proxy_auth, NetIO::get_ftp_auth): Pass
ab57ceaa
RC
6643 owner param to auth_common().
6644
6645 * net.h (NetPage): New file, new class.
6646 * net.cc: Run indent.
6647 (net.h, threebar.h): Add includes.
6648 (Progress): Add extern.
6649 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, now handled by
6650 property sheet logic. Saved temporarily for reference.
cef493d7 6651 (NetPage::Create, NetPage::OnInit, NetPage::OnDeactivate,
ab57ceaa
RC
6652 NetPage::OnNext, NetPage::OnBack):
6653 New implementation of NetPage class members.
6654 (do_net): Remove.
6655 (dialog_proc): Remove.
6656
6657 * msg.h (fatal, note, yesno): Add owner param.
6658 * msg.c (fatal, note, yesno, mbox): Add owner param.
6659 (mbox): Remove MB_TOPMOST from MessageBox call. Unnecessary and wrong
6660 now that we have a parent.
6661
6662 * main.cc: Run indent.
cef493d7 6663 (commctrl.h, proppage.h, propsheet.h, splash.h, source.h)
ab57ceaa
RC
6664 (localdir.h, net.h, site.h, choose.h, threebar.h, desktop.h): Include
6665 headers.
6666 (root_dialog_proc): extern into this file.
6667 (Progress): Progress dialog defined here, used in several other files.
6668 (WinMain): Instantiate and create Splash, Source, Root, LocalDir, Net,
6669 Site, Chooser, Desktop pages and MainWindow sheet. Call
6670 InitCommonControls() to make sure Windows is set up for our use of
6671 property sheets. Add pages to sheet.
6672 Call MainWindow.Create() to "DoModal". Remove main loop, that logic is
6673 now handled by the PropSheet class.
6674 (root.h): Add include.
6675
6676 * log.cc (log_save): Pass NULL parent to fatal().
6677 (exit_setup): Pass NULL parent to note().
6678
6679 * localdir.h (LocalDirPage): New file, new class.
6680 * localdir.cc: Run indent.
6681 (localdir.h): New include.
6682 (threebar.h): New include.
6683 (Progress): extern into this file.
6684 (LocalDirPage::Create, LocalDirPage::OnInit, LocalDirPage::OnActivate)
cef493d7 6685 (LocalDirPage::OnNext, LocalDirPage::OnBack): Implementation of
ab57ceaa
RC
6686 LocalDirPage.
6687 (LocalDirPage::OnNext): Move log() call from do_local_dir() to here.
6688 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers.
6689 (do_local_dir): Remove.
6690 (dialog_proc): Remove.
6691 (cwd): Remove, not used by anything.
6692
6693 * install.cc: Run indent.
6694 (process.h, threebar.h): New includes.
6695 (Progress): extern into this file.
6696 (ins_dialog, ins_action, ins_pkgname, ins_filename, ins_pprogress)
6697 (ins_iprogress, ins_diskfull, init_event): Remove, now handled by
6698 ThreeBarProgressPage.
cef493d7 6699 (dialog_cmd, dialog_proc, dialog): Removed, handled in
ab57ceaa 6700 ThreeBarProgressPage.
cef493d7
CF
6701 (init_dialog): Remove all mention of the above ins_* handles. Now
6702 handled in ThreeBarProgressPage. Altered SetWindowText()s to call
ab57ceaa
RC
6703 ThreeBarProgressPage instance Progress directly.
6704 (progress): Alter bar update logic to call ThreeBarProgressPage
6705 instance Progress directly.
6706 (uninstall_one): Alter SetWindowText()s to call ThreeBarProgressPage
6707 instance Progress directly.
cef493d7 6708 (install_one_source): Alter SetWindowText()s to call
ab57ceaa
RC
6709 ThreeBarProgressPage
6710 instance Progress directly. Pass NULL parent to note().
cef493d7 6711 (do_install_thread): Rename from do_install(), added owner param.
ab57ceaa
RC
6712 Alter SetWindowText()s to call ThreeBarProgressPage instance Progress
6713 directly.
6714 Remove dismiss_url_status_dialog() call, no longer necessary. Remove
cef493d7 6715 ShowWindow(<hide>) call, also unnecessary now. Pass owner handle to
ab57ceaa
RC
6716 fatal().
6717 (do_install_reflector): New function.
6718 (do_install): New function.
6719
6720 * ini.cc (process.h, threebar.h): New includes.
6721 (Progress): externed into this file.
6722 (find_routine): Pass NULL parent to note().
6723 (do_local_ini): Add owner param.
cef493d7 6724 (do_remote_ini): Add owner param. Pass owner to get_url_to_membuf()
ab57ceaa
RC
6725 and note(). Remove call to dismiss_url_status_dialog().
6726 (do_ini_thread): Rename from do_ini(). Add owner param. Pass owner to
cef493d7 6727 do_local_ini(), do_remote_ini(), yesno(), and note(). Set next_dialog
ab57ceaa
RC
6728 to IDD_CHOOSER on exit.
6729 (do_ini_thread_reflector): New function.
6730 (context): New var. Context for do_ini_thread.
6731 (do_ini): New function.
6732
6733 * geturl.h (get_url_to_membuf, get_url_to_string, get_url_to_file): Add
6734 owner param.
cef493d7 6735 * geturl.cc (gw_dialog, gw_url, gw_rate, gw_progress, gw_pprogress,
ab57ceaa 6736 gw_iprogress)
cef493d7 6737 (gw_progress_text, gw_pprogress_text, gw_iprogress_text, init_event):
ab57ceaa
RC
6738 Removed.
6739 (threebar.h): New include.
6740 (Progress): externed into this file.
cef493d7 6741 (dialog_cmd, dialog_proc, dialog): Removed, handled by
ab57ceaa 6742 ThreeBarProgressPage now.
cef493d7 6743 (init_dialog): Remove "if (gw_dialog == 0)" clause. Alter
ab57ceaa 6744 SetWindowText()s
cef493d7 6745 and bar setting SendMessage()s to call ThreeBarProgressPage instance
ab57ceaa
RC
6746 Progress directly. Remove "one bar only" logic, this is now handled
6747 explicitly in the ThreeBarProgressPage class.
cef493d7 6748 (progress): Altered bar and text update logic to call
ab57ceaa
RC
6749 ThreeBarProgressPage instance Progress directly. Changed kbps
6750 calculation to floating point and now print out a single decimal
6751 place.
6752 (get_url_to_membuf): Add owner param. Pass it to init_dialog.
6753 (get_url_to_string): Add owner param. Pass it to get_url_to_membuf.
cef493d7 6754 (get_url_to_file): Add owner param. Pass it to init_dialog. Alter bar
ab57ceaa
RC
6755 update logic to call ThreeBarProgressPage instance Progress directly.
6756 (dismiss_url_status_dialog): Remove.
6757
6758 * fromcwd.cc (do_fromcwd): Add owner param. Initialize found_ini to
6759 false, was true.
6760
6761 * download.cc: Run indent.
6762 (process.h, threebar.h): New includes.
6763 (Progress): externed into this file.
6764 (download_one): Add owner param. Pass it to get_url_to_file().
6765 (do_download_thread): Renamed from do_download. Add owner param. When
6766 calculating total_download_bytes, take binpicked and srcpicked into
6767 account. Remove call to dismiss_url_status_dialog(), no longer needed.
6768 Pass owner handle to download_one() and yesno().
6769 (do_download_reflector, do_download): New functions.
6770 (context): New var. Context for do_download_thread().
6771
6772 * dialog.h (D(x)): Add owner param.
6773
6774 * desktop.h (DesktopSetupPage): New file, new class.
6775 * desktop.cc: Run indent.
6776 (desktop.h): Add include.
cef493d7 6777 (dialog_proc, do_desktop): Remove, now handled in
ab57ceaa
RC
6778 DesktopSetupPage::OnInit().
6779 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, handled in
6780 DesktopSetupPage::OnFinish(), DesktopSetupPage::OnBack(), and PropSheet
6781 resp.
6782 (DesktopSetupPage::Create, DesktopSetupPage::OnInit)
6783 (DesktopSetupPage::OnBack, DesktopSetupPage::OnFinish): Implementation
6784 of DesktopSetupPage.
6785
6786 * cistring.h: New file, new class.
6787 * cistring.cc: New file, new class.
6788
6789 * choose.h: Run indent.
6790 (Chooser): New class declaration.
6791 * choose.cc: Run indent.
cef493d7 6792 (do_choose): Add owner param. Pass it to DialogBox() and
ab57ceaa
RC
6793 fatal().
6794 (Chooser): New class implementation.
6795
6796 * res.rc (IDS_VERSION_INFO): New string.
6797 (IDD_SOURCE, IDD_LOCAL_DIR, IDD_ROOT, IDD_SITE, IDD_OTHER_URL)
6798 (IDD_DLSTATUS, IDD_INSTATUS, IDD_SPLASH, IDD_CHOOSE, IDD_DESKTOP):
6799 Change WS_POPUP to WS_CHILD. Numerous positioning/size changes
6800 throughout.
6801 (IDD_CHOOSE): Give template the WS_EX_CONTROLPARENT style to enable
6802 TAB control navigation etc. Give the controls a reasonable tab order.
6803 Grouped radio buttons. Something's still not right, can't tab away
6804 from back/next/cancel group reliably.
6805 * resource.h (IDD_CHOOSER): New dialog ID.
6806
6807 * Makefile.in (OBJS): Add cistring.o, proppage.o, propsheet.o,
6808 threebar.o, and window.o.
6809
cc41a057
RC
68102001-12-21 Robert Collins <rbtcollins@hotmail.com>
6811
58b12a06
MB
6812 * choose.cc (listview_proc): Update the scrollbar when the headers are
6813 dragged.
cc41a057
RC
6814 (pick_pkg_line::paint): Clip columns to prevent overlap.
6815
cbfc4215
RC
68162001-12-20 Robert Collins <rbtcollins@hotmail.com>
6817
6818 * Makefile.in: Add libcomctl32.a for setup.exe.
6819 * archive.h (archive): Prevent non-child direct creation of the class.
58b12a06
MB
6820 * archive_tar.h (archive_tar): Prevent inaccurate synthetic copy and
6821 assignment.
cbfc4215
RC
6822 * choose.cc: Include commctrl for the choose header.
6823 (NEW_COL_SIZE_SLOP): Define without magic numbers.
6824 (pkgtrustp): Convert to function.
6825 (set_action): Remove.
cef493d7 6826 (add_required, fill_missing_category,default_trust): Use list syntax for
cbfc4215
RC
6827 package list.
6828 Use new set_action.
6829 (choose_caption): Remove.
6830 (topbucket::paint): New method.
6831 (topbucket::empty): Ditto.
6832 (topbucket::click): Ditto.
6833 (topbucket::~topbucket): Ditto.
6834 (paint): Remove i,ii and p as they are obsolete.
6835 Remove header drawing code.
6836 Use new chooser method to paint the chooser.
6837 Use new chooser itemcount method.
6838 (scroll_common): Rename to view::scroll.
6839 Scroll the header window separately.
58b12a06
MB
6840 (list_vscroll, list_hscroll, list_click): Update for new chooser
6841 methods.
cbfc4215
RC
6842 (listview_proc): Look for header messages.
6843 (note_width): Accept stringless calls.
6844 (pick_line::set_line): Remove.
6845 (pick_line::paint): Remove.
58b12a06
MB
6846 (pick_pkg_line::paint): Paint this one line, using the header column
6847 widths.
6848 (pick_category_line::paint): Paint this category, and anything in the
6849 bucket.
cbfc4215
RC
6850 (pick_line::click): Remove.
6851 (pick_pkg_line::click): Handle a click.
6852 (pick_category_line::click): Handle a click.
6853 (_view): Rename all to view.
6854 (view::view): Initialise the control contents.
6855 (view::set_headers): Work with the header control.
6856 (view::init_headers): Use list syntax for package list.
6857 Rearrange the width logic a little.
6858 (view::insert_pkg): Update to use the hierarchy.
6859 (view::insert_category): Ditto.
6860 (view::insert_at, view::insert_under): Remove.
6861 (view::clear_view): Update to use the hierarchy.
6862 (view::click): Update to use the hierarchy.
6863 (set_view_mode): Use list syntax for package list.
6864 Update for new chooser methods.
6865 (DoInsertItem): New helper function. (Needs a home somewhere).
58b12a06
MB
6866 (create_listview): Remove choose control code and use the constructor
6867 instead.
cbfc4215
RC
6868 (dialog_cmd,scan2,do_choose): Use list syntax for package list.
6869 * choose.h: Include newly required headers list and package_meta.
6870 (_voew): Rename to view.
6871 (pick_line): Convert to an ABC.
6872 (pick_pkg_line): New class.
6873 (pick_catgory_line): New class.
6874 (topbucket): New class.
6875 (view::scroll): New method created from listview_scroll function.
6876 * desktop.cc (make_passwd_group): Use list syntax for package list.
6877 * download.cc (do_download): Use list syntax for package list.
6878 * fromcwd.cc (found_file): Use list syntax for package list.
6879 * iniparse.y (pacakges): Use list syntax for package list.
6880 * install.cc (uninstall_one): Use list syntax for package list.
6881 (do_install): Use list syntax for package list.
58b12a06
MB
6882 * io_stream.h (io_stream): Prevent non-child direct creation of the
6883 class.
cbfc4215
RC
6884 Prevent inaccurate synthetic copy and assignment.
6885 * list.h: Include required header stdlib.
6886 Work on const correctness.
6887 * package_db.cc (packagedb::getpackagebyname): Remove.
6888 (packagedb::packagedb): Remove custom list code, and make db a local.
6889 (packagedb::getfirstpackage): Remove.
6890 (packagedb::getnextpackage): Remove.
6891 (packagedb::addpackage): Remove.
6892 (flush): Remove custom list code.
6893 (packagedb::registerpackage): Remove.
6894 (packagedb::packages): New static member.
6895 (packagedb::task): New static member.
6896 * package_db.h (PackageDBActions): New enum.
6897 (packagedb): Remove getfirstpackage, getnextpackage, getpackagebyname,
6898 addpackage, registerpackage, packages, packagecount, curr_package, db.
6899 Add packages, task.
6900 * pacakge_meta.cc: Include package_db.h.
6901 (packagemeta::action_caption): New method.
6902 (packagemeta::set_action): New method.
6903 * package_meta.h (CategoryPackage): Initialise key.
6904 (packagemeta): Initialise key.
6905 Add set_action and action_caption methods.
6906 Prevent inaccurate synthetic copy and assignment.
6907 * resource.h (IDC_CHOOSE_LISTHEADER): New ID.
6908 * source.cc: Include package_db for db manipulation.
6909 (save_dialog): Set the db task.
58b12a06
MB
6910 * win32.h: Tell the w32 include headers what IE version to
6911 expect/require.
cbfc4215 6912
cd8e5750
RC
69132001-12-06 Robert Collins <rbtcollins@hotmail.com>
6914
6915 * README: Wishlist updates.
6916
5519d243
RC
69172001-12-04 Robert Collins <rbtcollins@hotmail.com>
6918
6919 * package_db.cc (getnextpackage): Don't overrun the array.
6920
de6a1a64
RC
69212001-12-04 Robert Collins <rbtcollins@hotmail.com>
6922
6923 * Makefile.in (OBJS): Add setup_version.o.
6924 (version.c): Rename to setup_version.
6925 * choose.cc (set_action): Prevent NULL pointer dereference.
6926 (package_sort): Remove.
6927 * fromcwd.cc (canonicalize_version): Moved to version.cc.
58b12a06
MB
6928 (check_ini): New function for use with find to see if there is a cached
6929 setup.ini.
de6a1a64
RC
6930 (do_fromcwd): Check for a cached setup.ini from any mirror site.
6931 * ini.cc (find_routine): New function, for finding cached setup.ini's.
6932 (do_local_ini): New function, drives parsing of local ini's.
58b12a06
MB
6933 (do_remote_ini): New function, drives parsing and caching of remote
6934 ini's.
de6a1a64
RC
6935 (do_ini): Move guts to do_remote_ini and do_local_ini.
6936 * list.h (removebyindex): New method.
6937 * other.cc (save_dialog): Use new site_list and all_site_list to add the
6938 new site to the site picklist.
6939 (dialog_cmd): Only save the dialog when exiting the dialog.
6940 * res.rc (IDD_SITE): Make IDC_URL_LIST a multiple-selection control.
6941 * site.cc (site_list_type): Move to site.h
6942 (site_list): New global, sites chosen by the user.
6943 (all_site_list): New global, all potential sites.
58b12a06
MB
6944 (site_list_type::init): New method, parses a mirror.lst URL string into
6945 a site_list_type object.
de6a1a64
RC
6946 (site_list_type::site_list_type): New method.
6947 (check_if_enable_next): Examine the control, not a local variable.
6948 (load_dialog): Select all the user chosen sites by default.
cef493d7 6949 (save_dialog): Adjust for multiple selection semantics.
de6a1a64 6950 (save_site_url): Save all user chosen sites.
58b12a06
MB
6951 (dialog_cmd): Don't save the dialog when the listbox recieves a message
6952 - thats not needed.
de6a1a64
RC
6953 Remove obsolete other_url reference.
6954 (dialog_proc): Use all_site_list instead of site_list.
6955 (site_sort): Remove.
6956 (get_site_list): Remove malloc use - use list template instead.
6957 Move site_list_type initialisation to site_list_type::init().
6958 (get_initial_list_idx): Renamed to ...
6959 (get_saved_sites): this. Also read in multiple sites to the site_list.
6960 (do_site): Use all_site_list not site_list.
6961 Log all chosen sites.
6962 * site.h: New file, defines site related class, functions and variables.
6963 * state.h: Add comment about use of state.h
6964 (mirror_site): Remove.
6965 (other_url): Remove.
6966 (MIRROR_SITE): Remove.
6967 * version.cc: New file, for version-handling and related functions.
6968
341988b9
RC
69692001-12-02 Robert Collins <rbtcollins@hotmail.com>
6970
6971 * Makefile.in: Add filemanip.o to setup.
6972 * archive.cc (archive::extract_file): Use new io_stream method 'copy'.
6973 * archive_tar.h (archive_tar_file): Implement get_size virtual.
6974 (archive_tar): Ditto.
58b12a06
MB
6975 * choose.cc (set_action): Use [] operator instead of getnth - its more
6976 readable.
341988b9
RC
6977 (paint): Ditto.
6978 (_view::init_headers): Ditto.
6979 (_view::insert_pkg): Ditto.
6980 (set_view_mode): Ditto.
6981 (scan2): Ditto.
6982 (do_choose): Ditto.
6983 (base): Moved to filemanip.cc.
6984 (find_tar_ext): Ditto.
6985 (parse_filename): Ditto.
6986 (_Info::_Info): Remove.
6987 * compress_bz.h (compress_bz): Implement get_size virtual.
6988 * compress_gz.h (compress_gz): Implement get_size virtual.
58b12a06
MB
6989 * cygpackage.cc (cygpackage::destroy): Use array delete for char *
6990 objects.
341988b9 6991 * download.cc (get_file_size): Move to filemanip.cc.
58b12a06
MB
6992 (check_for_cached): Use [] operator instead of getnth - its more
6993 readable.
341988b9
RC
6994 (download_one): Ditto.
6995 * filemanip.cc: New file.
58b12a06
MB
6996 * geturl.cc (init_dialog): Make url a pointer to const as it is not
6997 modified.
6998 (get_url_to_membuf): New function - contains get_url_to_string worker
6999 code.
341988b9
RC
7000 (get_url_to_string): Becomes a trivial wrapper to get_url_to_membuf.
7001 * geturl.h: Declare new prototype.
7002 * ini.cc (do_ini): Use get_url_to_membuf and pass ini_init an io_stream.
7003 Tidy up the error code a little.
7004 * ini.h: Remove __cplusplus protection for ini_init.
7005 (_Info): Remove.
7006 * inilex.l: Remove old globals.
7007 (ini_init): Use an io_stream for getting the characters.
7008 (ini_getchar): Ditto.
7009 * iniparse.y: Declare yylex as a C++ function.
58b12a06
MB
7010 (add_correct_version): Use [] operator instead of getnth - its more
7011 readable.
341988b9
RC
7012 * io_stream.cc (io_stream::move_copy): Use the copy method.
7013 (io_stream::copy): New method to simply copy from one stream to another.
58b12a06
MB
7014 * io_stream.h (io_stream): New static method copy, and virtual method
7015 get_size.
341988b9
RC
7016 * io_stream_cygfile.cc (io_stream_cygfile::get_size): Implement this.
7017 * io_stream_cygfile.h (io_stream_cygfile::get_size): Declare this.
7018 * io_stream_file.cc (io_stream_file::get_size): Implement this.
7019 * io_stream_file.h (io_stream_file::get_size): Declare this.
7020 * io_stream_memory.h: Include errno as it's neded to parse the header.
7021 (io_stream_memory::get_size): Implement this.
7022 (io_stream_memory::st_size): Delete this.
7023 * list.h: Change getnth into the [] operator.
58b12a06
MB
7024 * netio.cc (NetIO::NetIO): Change prototype to reflect Purl not being
7025 modified.
341988b9
RC
7026 (NetIO::set_url): Ditto.
7027 (NetIO::open): Ditto.
7028 * netio.h: As for netio.cc.
58b12a06
MB
7029 * nio-file.cc (NetIO_File::NetIO_File): Change prototype to reflect
7030 Purl not being modified.
341988b9
RC
7031 * nio-file.h: Ditto.
7032 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
7033 * nio-ftp.h (NetIO_FTP::NetIO_FTP): Ditto.
7034 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Ditto.
7035 * nio-http.h (NetIO_HTTP::NetIO_HTTP): Ditto.
7036 * nio-i5.cc (NetIO_IE5::NetIO_IE5): Ditto.
7037 * nio-i5.h (NetIO_IE5::NetIO_IE5): Ditto.
7038 * package_meta.cc (packagemeta::~packagemeta): Bugfix: use array delete.
7039 * package_source.cc (packagesource::set_canonical): Ditto.
7040 (packagesource::set_cached): Ditto.
7041 * package_source.h (site::~site): Ditto.
58b12a06
MB
7042 * site.cc: Change site_list_type to a class, and search and replace
7043 sort_key to key globally.
341988b9 7044
071c1c54
RC
70452001-12-01 Robert Collins <rbtcollins@hotmail.com>
7046
58b12a06
MB
7047 * package_source.cc (packagesource::set_canonical): Filename was out by
7048 one.
071c1c54 7049
4fe323f9
RC
70502001-11-30 Robert Collins <rbtcollins@hotmail.com>
7051
7052 * Makefile.in (OBJS): Remove category_list - it's not needed.
7053 * README: More wishlist updates.
7054 * category.cc (Category::Category): Initialise new members.
7055 (Categorycmp): New function.
7056 * category.h (Category): New member key for template use.
7057 * category_list.cc: Remove.
7058 * category_list.h: Remove.
7059 (Categorycmp): New function prototype.
7060 * choose.cc: Remove category_list - not needed.
cef493d7 7061 (set_action): Only show the 'source' option when the source is actually
4fe323f9
RC
7062 available.
7063 (add_required): Fix recursion limiter to 5.
7064 (fill_missing_category): Use list access.
7065 (default_trust): Ditto.
7066 (pick_line::paint): Ditto.
7067 (_view::init_headers): Ditto.
7068 (_view::insert_pkg): Ditto.
7069 (_view::insert_category): Ditto.
7070 (_view::click): Ditto.
7071 (set_view_mode): Ditto.
7072 (do_choose): Ditto.
7073 * cygpackage.h: Remove category_list - not needed.
7074 * geturl.cc (get_url_to_string): Fix null byte insertion.
7075 * inipatse.y: Remove category_list - not needed.
7076 (categories): Use list access.
7077 * package_db.cc: Ditto.
7078 * package_db.h: Remove category_list - not needed.
7079 (packagedb): Use the list template for categories.
7080 * package_meta.cc (add_category): Ditto.
7081 * package_meta.h (CategoryPackage): Link to the category as well.
cef493d7 7082 (packagemeta): Use a list of CategoryPackages instead of Categories
4fe323f9
RC
7083 for more memory efficient cross-referencing.
7084
7d66d192
RC
70852001-11-30 Robert Collins <rbtcollins@hotmail.com>
7086
58b12a06
MB
7087 * package_db.cc (packagedb::flush): Write a canonical version for all
7088 packages irrespective of the media they were installed from.
7d66d192 7089
bb849dbd
RC
70902001-11-29 Robert Collins <rbtcollins@hotmail.com>
7091
7092 * Makefile.in (OBJS): Add package_source and rfc1738.
7093 * README: Wishlist update.
7094 * category_list.cc (register_category): Use references.
7095 * category_list.h (CategoryList): Ditto.
7096 * choose.cc (isinstalled): Remove.
7097 (pkgtrustp): New macro.
7098 (set_action): Use packagemeta.
7099 (add_required): Ditto.
58b12a06
MB
7100 (choose_caption): Example package to choose caption, rather than state
7101 flags.
bb849dbd
RC
7102 (check_existence): Remove.
7103 (set_existence): Remove old code.
7104 (fill_missing_category): Use packagemeta.
7105 (keep_or_skip): Remove.
7106 (default_trust): Use packagemeta and set trust values directly.
7107 (pick_line::set_line): Use packagemeta.
7108 (_view::insert_pkg): Ditto.
7109 (_view::insert_category): Ditto.
7110 (_view::click): Ditto.
7111 (set_view_mode): Ditto. Also remove "exclude" code.
7112 (create_listview): Use packagemeta.
7113 (dialog_cmd): Ditto.
7114 (getpkgbyname): Remove
7115 (scan2): Use packagemeta. Temporarily comment out the holefinding code.
7116 (read_installed_db): Remove.
7117 (package_sort): Use packagemeta.
58b12a06
MB
7118 (do_choose): Use packagemeta. Don't sort the packages - the db does
7119 that.
bb849dbd
RC
7120 * choose.h: Use packagemeta.
7121 * cygpackage.cc (cygpackage::cygpackage): Initialise all variables.
7122 (cygpackage::cygpackage): Ditto.
7123 (cygpackage::set_canonical_version): Copy the passed string.
7124 (cygpackage::~cygpackage): Move cleanup code to destroy().
7125 (cygpackage::destroy): New function.
7126 (cygpackage::getfirstfile): Use a separate buffer.
7127 (cygpackage::getnextfile): Ditto.
7128 (cygpackage::Canonical_version): New function.
7129 (cygpackage::set_sdesc): Ditto.
7130 (cygpackage::set_ldesc): Ditto.
7131 * cygpackage.h (cygpackage::Canonical_version): New method.
7132 (cygpackage::set_sdesc): New method.
7133 (cygpackage::set_ldesc): New method.
7134 (cygpackage::SDesc): New method.
7135 (cygpackage::LDesc): New method.
7136 (cygpackage::set_canonical_version): New method.
7137 * desktop.cc: Include packagedb headers.
7138 (make_password_group): Use packagemeta.
7139 * download.cc: Include packagedb headers.
58b12a06
MB
7140 (check_for_cached): New method to find any cached file and fill out the
7141 database info.
bb849dbd
RC
7142 (download_one): Take a packagesource, support multiple mirrors.
7143 (do_download): Use packagemeta.
7144 * from cwd.cc: Include packagedb headers.
7145 (found_file): Use packagemeta.
7146 * ini.cc (do_ini): Beginning of multiple-mirror support.
7147 * ini.h (CategoryPackage): Remove.
7148 (Dependency): Remove.
7149 (Package): Remove.
58b12a06
MB
7150 (new_package,getpkgbyname,getpackagecategorybyname,add_category):
7151 Remove.
bb849dbd
RC
7152 * inilex.l: Support multiple mirrors.
7153 * iniparse.y: Include packagedb headers.
7154 (parser): Use packagemeta.
7155 (new_package): Remove.
7156 (add_correct_version): New function.
7157 (new_requirement): Remove.
7158 (add_category): Remove.
7159 * install.cc (uninstall_one): Use packagemeta.
7160 (install_one_source): New function.
7161 (install_one): Use packagemeta.
7162 (do_install): Use packagemeta.
7163 * io_stream.cc (io_stream::move): Bugfix on move/copy case.
58b12a06
MB
7164 * io_stream_cygfile.cc (io-stream_cygfile::set_mtime): Do not reopen the
7165 file after setting the mtime, it makes no sense, and results in 0 length
7166 files.
bb849dbd
RC
7167 * io_stream_file.cc (io-stream_file::set_mtime): Ditto.
7168 * list.h: New file, template class for a form of list.
7169 * package_db.cc (packagedb::registerpackage): New function.
7170 * package_db.h (packagedb::npackages ()): New method.
7171 * package_meta.cc (packagemeta::add_version): Use list template.
7172 (packagemeta::set_installed): Ditto.
7173 (packagemeta::add_category): New method.
7174 * package_meta.h: Include necessary headers to parse the class.
7175 (CategoryPackage): New class.
7176 (packagemeta): Initialise all members.
7177 (packagemeta::SDesc): New method.
7178 (packagemeta::Categories): New method.
7179 (packagemeta::add_category): Ditto.
7180 (packagemeta::versions): Change to be a list instance.
7181 * package_source.cc (packagesource::set_canonical): New method.
7182 (packagesource::set_cached): New method.
7183 * package_source.h: Include necessary headers to parse the class.
7184 (site): New class.
7185 (packagesource::packagesource): Initialize all members.
7186 (packagesource): Make this class non-abstract.
7187 * package_version.cc (packageversion::packageversion): New method.
7188 * package_version.h (Dependency): New class.
7189 (packageversion::Canonical_vesion): New method.
7190 (packageversion::SDesc): New method.
7191 (packageversion::LDesc): New method.
7192 (packageversion::new_requirement): Ditto.
7193 (packageversion::srcpicked, binpicked): What to install.
7194 (packageversion::src, bin): Installation source data.
7195 * rfc1738.cc: New file. Escapes special characters in URL's.
7196 * rfc1738.h: Ditto.
7197
90d14922
RC
71982001-11-26 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
7199
7200 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Stop header parsing when
7201 SimpleSocket::gets() returns a zero-length string, so that we
7202 don't end up eating the entire stream thinking it's all header info.
7203
7c7034e8
RC
72042001-11-23 Robert Collins <rbtcollins@hotmail.com>
7205
7206 * install.cc (badrename): Remove.
58b12a06
MB
7207 (do_install): Use packagedb flush method to write
7208 /etc/setup/installed.db.
7c7034e8
RC
7209 * io_stream.cc (io_stream::move_copy): New method.
7210 (io_stream::move): New method.
7211 * io_stream.h (io_stream): New methods move and move_copy.
7212 * io_stream_cygfile.cc (io_stream_cygfile::move): New method.
7213 * io_stream_cygfile.h (io_stream_cygfile): New method move.
7214 * io_stream_file.cc (io_stream_file::move): New method.
7215 * io_stream_file.h (io_stream_file): New method move.
7216 * package_db.cc (packagedb::flush): New method.
7217 * package_db.h (packagedb): New method flush.
7218
fa0c0d10
RC
72192001-11-23 Robert Collins <rbtcollins@hotmail.com>
7220
7221 * Makefile.in (OBJS): Add package_version.
7222 * ategory.cc (Category::Category): Update constructors.
7223 * category_list.cc (CategoryList::register_category): Insert correctly.
7224 * choose.cc: Include package_version.h, not package.h.
7225 * cygpackage.cc: Ditto.
7226 (cygpackage::uninstall): New method.
7227 * cygpackage.h (cygpackage): Rename genericpackage to packageversion.
7228 New method uninstall.
7229 * hash.cc (add, has, enumerate): Change prototype to be accurate.
7230 * hash.h (hash): Change prototypes to be accurate.
7231 * ini.h (_Info): New parameterless constructor.
7232 (CategoryPackage): New constructor.
7233 (Package): Ditto.
7234 * install.cc: Don't include unneeded headers.
7235 Include package database headers.
7236 (hash::add_subdirs): Remove.
58b12a06
MB
7237 (uninstall_one): Use packagemeta->uninstall to perform the
7238 uninstallation. Don't uninstall source packages.
7239 (do_install): Just can uninstall_one once as we ignore source packages
7240 now. Don't copy the installed.old database accross, instead iterate
7241 through the packagedb packages list and write the installed packages
7242 out.
fa0c0d10
RC
7243 * package_db.cc: Include package_version.h, not package.h.
7244 (packagedb::packagedb): Never let db be undefined.
7245 Record the installation filename, so we can reconstruct installed.db.
7246 (packagedb::addpackage): Insert packages in alpha sorted order.
7247 (packagedb::categories): Initialise correctly.
7248 * package_meta.cc: Include win32 and mount headers as a workaround to
7249 current io_stream limitations. Include a TODO about that.
7250 (standard_dirs): New, from install.cc.
7251 (hash::add_subdirs): New, from install.cc.
7252 (packagemeta::set_installed): Rename genericpackage to packageversion.
7253 (packagemeta::uninstall): New method.
7254 * package_meta.h: Rename genericpackage to packageversion.
7255 (packagemeta): Update constructor.
7256 (add_version, set_installed): Rename genericpackage to packageversion.
7257 (uninstall): New method.
7258 (installed_from): New member.
7259 * package_source.cc: New file.
7260 * package_source.h: New file.
7261 * package_version.cc: New file.
7262 * package_version.h: New file.
7263 * package.cc: Removed.
7264 * package.h: Removed.
cef493d7 7265
7b606ae5
RC
72662001-11-21 Robert Collins <rbtcollins@hotmail.com>
7267
7268 * Makefile.in (OBJS): Add category.o and category_list.o.
7269 * category.h: New file.
7270 * category.cc: New file.
7271 * category_list.h: New file.
7272 * category_list.cc: New file.
7273 * choose.cc: Include category headers.
7274 (fill_missing_category): Use package_db to access global categories.
7275 (_view::insert_pkg): Ditto.
7276 (_view::insert_category): Ditto.
7277 (set_view_mode): Ditto.
7278 (getcategorybyname): Remove.
7279 * cygpackage.h: Include category_list.h to parse this correctly.
7280 (cygpackage): New virtual &Categories.
7281 * ini.h (_CategoryPackage): More C to C++ conversion.
7282 (Category): Remove.
7283 (getcategorybyname): Remove.
7284 (register_category): Remove.
7285 * iniparse.y: Include package db and category headers.
7286 (categories): Use package_db to access global categories.
7287 (category): Remove.
7288 (ncategories): Remove.
7289 (register_category): Remove.
7290 * package.h: New virtual &Categories.
58b12a06
MB
7291 * package_db.cc (packagedb::packagedb): Don't read the installed db
7292 twice.
7b606ae5 7293 (packagedb::categories): Declare.
58b12a06
MB
7294 * package_db.h (packagedb): New member categories for global categories
7295 list.
7b606ae5 7296
d0fa1c4e
RC
72972001-11-21 Robert Collins <rbtcollins@hotmail.com>
7298
7299 * choose.h: Don't include ini.h
7300 * ini.h: Allow pure c++ in the header file.
7301
24cbae7f
RC
73022001-11-21 Robert Collins <rbtcollins@hotmail.com>
7303
7304 * install.cc (do_install): Write a version 2 installed.db file.
58b12a06
MB
7305 * package_db.cc (packagedb::packagedb): Read version 1 and 2
7306 installed.db files.
24cbae7f 7307
7939f6d1
RC
73082001-11-21 Robert Collins <rbtcollins@hotmail.com>
7309
7310 * Makefile.in (OBJS): Add package abstraction objects.
7311 * choose.cc: Include package abstraction headers.
7312 (read_installed_db): Use packagedb class and ignore installed sources.
7313 * cygpackage.cc: New file.
7314 * cygpackage.h: New file.
7315 * filemanip.h (get_file_size): Use unixy types.
7316 * package.h: New file.
7317 * package.cc: New file.
7318 * package_db.cc: New file.
7319 * package_db.h: New file.
7320 * package_meta.cc: New file.
7321 * package_meta.h: New file.
7322
33bc0053
RC
73232001-11-21 Robert Collins <rbtcollins@hotmail.com>
7324
7325 * REAME: Updates to wishlist.
7326
12ccadc0
RC
73272001-11-16 Robert Collins <rbtcollins@hotmail.com>
7328
7329 * README: Updated and added my list of wishlist and todo items.
7330
ca9506cc
RC
73312001-11-14 Robert Collins <rbtcollins@hotmail.com>
7332
7333 * Makefile.in (OBJS): Include io_stream_memory in setup.exe.
7334 * archive_tar.cc (archive_tar::write): New prototype.
7335 (archive_tar::seek): New method.
7336 * archive.h (archive_tar_file): Update write() and add seek().
7337 (archive_tar): Ditto.
7338 * archive_tar_file.cc (archive_tar_file::write): New prototype.
7339 (archive_tar_file::seek): New method.
7340 * compress_bz.cc (compress_bz::write): New prototype.
7341 (compress_bz::seek): New function.
7342 * compress_bz.h (compress_bz): Update write() and add seek().
7343 * compress_gz.cc (compress_gz::write): New prototype.
7344 (compress_gz::seek): New function.
7345 * compress_gz.h (compress_gz): Update write() and add seek().
7346 * geturl.cc: Include io_stream headers.
7347 (GUBuf): Remove.
7348 (get_url_to_string): Use a io_stream_memory buffer instead of GUBuf.
7349 * io_stream.h (io_stream_seek_t): New enum.
7350 (io_stream): Update write() and add seek().
7351 * io_stream_cygfile.cc (io_stream_cygfile::write): New prototype.
7352 (io_stream_cygfile::seek): New function.
58b12a06
MB
7353 * io_stream_cygfile.h (io_stream_cygfile): Update write() and add
7354 seek().
ca9506cc
RC
7355 * io_stream_file.cc (io_stream_file::write): New prototype.
7356 (io_stream_file::seek): New function.
7357 * io_stream_file.h (io_stream_file): Update write() and add seek().
7358
2db33f10
RC
73592001-11-13 Brian Keener <bkeener@thesoftwaresource.com>
7360
7361 * localdir.cc: Add headers unistd.h and port.h.
cef493d7 7362 (save_local_dir): Expand search logic to include local directory for
2db33f10
RC
7363 location of file last-cache.
7364 (dialog_cmd): Skip IDD_ROOT when downloading and use Back button.
cef493d7 7365 (do_local_dir): Expand search logic to include local directory for file
2db33f10
RC
7366 last-cache.
7367 * res.rc (IDD_CHOOSE_DIALOG): Add hotkey to View button.
cef493d7 7368 * Source.cc (dialog_cmd): Skip IDD_ROOT if select Download from
2db33f10 7369 Internet.
cef493d7 7370 (do_source): Default to Install from Internet on first entry or
2db33f10
RC
7371 previous selection if backing up from IDD_ROOT or IDD_LOCAL_DIR.
7372
03a6c5b1
RC
73732001-11-13 Robert Collins <rbtcollins@hotmail.com>
7374
7375 * choose.cc (find_tar_ext): Only match at the end of the string.
7376 (getpkgbyname): Prevent NULL pointer dereference.
7377
b24c88b3
RC
73782001-11-13 Robert Collins <rbtcollins@hotmail.com>
7379
7380 * Makefile.in (CFLAGS): Add warnings and -Werr.
58b12a06
MB
7381 (WARNONLY_FLAGS): For sources that produce (harmless) errors no matter
7382 what.
b24c88b3
RC
7383 (OBJS): Add io_stream class' objects.
7384 (autoload.o): Use WARNONLY_FLAGS.
7385 (inilex.o): Ditto.
7386 (iniparse.o): Ditto.
7387 * archive.cc: New file.
7388 * archive.h: New file.
7389 * archive_tar.cc: New file.
7390 * archive_tar.h: New file.
7391 * archive_tar_file.cc: New file.
7392 * autoload.c: Fix compiler warnings (unused, deprecated conversion).
7393 * choose.cc: Use io_stream.h, not mount.h.
7394 Run indent.
58b12a06
MB
7395 (find_tar_ext): Rewritten to use strstr, and to accept .tar as an
7396 extension.
b24c88b3
RC
7397 (read_installed_db): Use io_streams.
7398 * choose.h: Run indent.
7399 * compress.cc: New file.
7400 * compress.h: New file.
7401 * compress_bz.cc: New file.
7402 * compress_bz.h: New file.
7403 * compress_gz.cc: New file.
7404 * compress_gz.h: New file.
7405 * concat.cc: Run indent.
7406 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7407 * concat.h: Run indent.
7408 * desktop.cc: Run indent.
7409 Include mklink2.h rather than redefining by hand.
7410 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7411 (etc_profile): Fix compiler warning (deprecated conversion).
7412 (make_link): Fix compiler warning (deprecated conversion).
7413 Tidy up use of args variable - consolidate into argbuf.
7414 (start_menu): Fix compiler warning (deprecated conversion).
7415 (desktop_icon): Fix compiler warning (deprecated conversion).
7416 (make_etc_profile): Fix compiler warning (deprecated conversion).
7417 (uexists): Fix compiler warning (deprecated conversion).
7418 (check_desktop): Fix compiler warning (deprecated conversion).
7419 (check_startmenu): Fix compiler warning (deprecated conversion).
7420 * dialog.cc: Run indent.
7421 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7422 (fatal): Fix compiler warning (deprecated conversion).
7423 * dialog.h: Run indent.
7424 * diskfull.cc: Run indent.
7425 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7426 * download.cc: Run indent.
7427 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7428 (download_one): Fix compiler warning (signed vs unsigned comparison).
7429 * filemanip.h: Run indent.
7430 * find.cc: Run indent.
7431 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7432 (find): Fix compiler warning (deprecated conversion).
7433 * find.h: Run indent.
7434 * fromcwd.cc: Run indent.
7435 * geturl.cc: Run indent.
7436 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7437 (dialog_cmd): Return a value.
7438 (dialog_proc): Remove unused variables.
7439 Return a value.
7440 (get_url_to_file): Fix compiler warning (deprecated conversion).
7441 * geturl.h: Run indent.
7442 * hash.cc: Run indent.
7443 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7444 * hash.h: Run indent.
7445 * ini.cc: Run indent.
7446 Use io_streams.
7447 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7448 (do_ini): Use io_streams for local io.
7449 * ini.h: Run indent.
7450 * inilex.l (ignore_line): Fix compiler warning (is not a prototype).
7451 Fix compiler warning (brackets for truth assignment).
7452 * install.cc: Run indent.
7453 Fix compiler warning (/* in comment).
7454 Use io_streams.
7455 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7456 (dialog_cmd): Return a value.
7457 (dialog_proc): Return a value.
7458 (start_tics): Deleted - was unused.
7459 (badrename): Fix compiler warnings (unused, deprecated conversion).
7460 (standard_dirs): Fix compiler warning (deprecated conversion).
7461 (exists): Remove.
7462 (uninstall_one): Convert to io_streams.
7463 (install_one): Convert to io_streams.
7464 (do_install): Convert to io_streans.
7465 Fix compiler warning (deprecated conversion).
7466 * io_stream.cc: New file.
7467 * io_stream.h: New file.
7468 * io_stream_cygfile.cc: New file.
7469 * io_stream_cygfile.h: New file.
7470 * io_stream_file.cc: New file.
7471 * io_stream_file.h: New file.
7472 * localdir.cc: Run indent.
7473 Use io_streams.
7474 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7475 (get_root_dir_now): Remove.
7476 (save_local_dir): Convert to io_streams.
7477 (dialog_cmd): Return a value.
7478 (do_local_dir): Convert to io_streams.
7479 (log.cc): Run indent.
7480 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7481 (log): Fix compiler warning (deprecated conversion).
7482 (log_save): Fix compiler warning (deprecated conversion).
7483 * log.h: Run indent.
7484 (log): Fix compiler warning (deprecated conversion).
7485 (log_save): Fix compiler warning (deprecated conversion).
7486 * main.cc: Run indent.
7487 Don't include "netio.h".
7488 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7489 (netio_test): Remove.
7490 (sid_auth): Fix compiler warning (partially bracketed initialiser).
7491 (WinMain): Return a value.
7492 * mkdir.cc: Run indent.
7493 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7494 * mklink2.c: Run indent.
7495 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7496 (mkcygsymlink): New function.
7497 * mklink2.h: New file.
7498 * mount.cc: Run indent.
7499 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7500 (create_mount): Remove unused variables.
7501 (cygpath): Fix compiler warning (signed vs unsigned comparison).
7502 * mount.h: Run indent.
7503 * msg.cc: Run indent.
7504 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7505 (msg): Fix compiler warning (deprecated conversion).
7506 (mbox): Fix compiler warning (deprecated conversion).
7507 * msg.h: Run indent.
7508 (msg): Fix compiler warning (deprecated conversion).
7509 * net.cc: Run indent.
7510 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7511 (dialog_cmd): Return a value.
7512 * netio.cc: Run indent.
7513 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7514 (auth_cmd): Return a value.
7515 * netio.h: Run indent.
7516 * nio-file.cc: Run indent.
7517 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7518 (NetIO_File::NetIO_File): Fix compiler warning (deprecated conversion).
7519 * nio-file.h: Run indent.
7520 * nio-ftp.cc: Run indent.
7521 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7522 * nio-ftp.h: Run indent.
7523 * nio-http.cc: Run indent.
7524 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7525 * nio-http.h: Run indent.
7526 * nio-ie5.cc: Run indent.
7527 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7528 * nio-ie5.h: Run indent.
7529 * other.cc: Run indent.
7530 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7531 (dialog_cmd): Return a value.
7532 * port.h: Run indent.
7533 * postinstall.cc: Run indent.
7534 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7535 (cmd): Fix compiler warning (deprecated conversion).
7536 (eun): Fix compiler warning (deprecated conversion).
7537 * root.cc: Run indent.
7538 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7539 * simpsock.cc: Run indent.
7540 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7541 * simpsock.h: Run indent.
7542 * site.cc: Run indent.
7543 Use io_streams.
7544 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7545 (get_root_dir_now): Remove.
7546 (save_site_url): Convert to io_streams.
7547 (dialog_cmd): Return 0.
7548 (get_initial_list_idx): Convert to io_streans.
7549 * source.cc: Run indent.
7550 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7551 (check_if_enable_next): Remove.
7552 (load_dialog): Remove unused variables.
7553 (save_dialog): Ditto.
7554 (dialog_cmd): Return a value.
7555 * splash.cc: Return a value.
7556 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7557 (dialog_cmd): Return a value.
7558 * state.cc: Run indent.
7559 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7560 * state.h: Run indent.
7561 * tar.h: Remove.
7562 * tar.cc: Remove.
7563
398dd7b2
CF
75642001-11-12 Christopher Faylor <cgf@redhat.com>
7565
7566 * desktop.cc (start_menu): Change start menu name to "Cygwin".
7567 (check_startmenu): Ditto.
7568
c29ee141
CF
75692001-11-11 Christopher Faylor <cgf@redhat.com>
7570
7571 * choose.cc (parse_filename): Finish reorganization by correctly
7572 decrementing p in memmove.
7573
3a8276de
CF
75742001-11-11 Christopher Faylor <cgf@redhat.com>
7575
7576 * choose.cc (parse_filename): Reorganize code to work around gcc
7577 optimization problem.
7578
6eea52fb
RC
75792001-11-09 Gareth Pearce <tilps@hotmail.com>
7580
7581 * choose.cc (set_action): Allow skip as an option for installed
7582 packages that have version number not listed in setup.ini.
7583
cf99b153
RC
75842001-11-10 Robert Collins <rbtcollins@hotmail.com>
7585
7586 * choose.cc (set_cation): Backout last change.
7587 (choose_caption): Ditto.
7588
55e204f6
RC
75892001-11-10 Robert Collins <rbtcollins@hotmail.com>
7590
7591 * ini.h (actions): Remove - transferred to choose.h.
7592 (views): Ditto.
7593 * choose.h: Protect class's from "C" compilers.
7594 (actions): New enum, from ini.h. This may not be the 'right' place
7595 but that place doesn't exist yet.
7596 (_views): New enum, from ini.h.
58b12a06
MB
7597 * choose.cc (set_action): Handle installed packages with a version not
7598 in setup.ini.
55e204f6
RC
7599 (choose_caption): Ditto.
7600 * iniparse.y: Rearrange header order to handle new ini.h.
7601
76022001-11-10 Robert Collins <rbtcollins@hotmail.com>
7603
7604 * ini.h (_Info): Fix compiler warnings (signed vs unsigned comparison).
7605 (registry_category): Fix compiler warning (deprecated conversion).
7606 * iniparse.y (registry_category): Ditto.
58b12a06
MB
7607 * choose.cc (cvsid): Fix compiler warnings (unused, deprecated
7608 conversion).
55e204f6
RC
7609 (add_requried): Remove unused variable.
7610 (choose_caption): Handle all enumeration values via a default.
7611 (paint): Fix compiler warnings (unused, deprecated conversion).
58b12a06
MB
7612 (scroll_common): Fix compiler warnings (unused, signed vs unsigned
7613 comparison).
55e204f6
RC
7614 (list_clicK): Fix compiler warnings (signed vs unsigned comparison).
7615 (note_width): Fix compiler warnings (deprecated conversion).
7616 (keep_or_skip): Fix compiler warnings (unused).
7617 (_view::mode_caption): Fix compiler warnings (deprecated conversion).
7618 (set_view_mode): Fix compiler warnings (unused).
58b12a06
MB
7619 (create_listview): Fix compiler warnings (unused, incorrect format,
7620 reaches end of function).
55e204f6 7621 (dialog_proc): Fix compiler warnings (unused).
58b12a06
MB
7622 (read_installed_db): Fix compiler warnings (unused, deprecated
7623 conversion).
55e204f6
RC
7624 * choose.h (_header): Fix compiler warnings (deprecated conversion).
7625 (_view): Ditto.
7626
67a55ad9 76272001-11-08 Pavel Tsekov <ptsekov@syntrex.com>
cef493d7 7628
67a55ad9
RC
7629 * simpsock.h (SimpleSocket::invalidate): Declare new method.
7630 * simpsock.cc (SimpleSocket::invalidate): Implement new method.
7631 (SimpleSocket::SimpleSocket): Initialize buf to zero. Do not allocate
7632 memory for buf in the constructor.
7633 (SimpleSocket::~SimpleSocket): Use SimpleSocket::invalidate().
7634 (SimpleSocket::printf): Use SimpleSocket::write() instead of send().
7635 (SimpleSocket::write): Check object consistency - return -1 on error.
7636 invalidate() the object on socket write error.
7637 (SimpleSocket::fill): Check object consistency - return -1 on error.
7638 invalidate() the object if socket read error is encountered and there
7639 is no more data available in the internal read buffer.
7640 Allocate memory for the internal read buffer.
7641 (SimpleSocket::gets): Return zero (NULL pointer) if error is encountered
7642 during fill() and no more data is available in the internal read buffer.
7643 (SimpleSocket::read): Check object consistency - return -1 on error.
7644 invalidate() the object if socket read error is encountered.
7645 * nio-ftp.cc (NetIO_FTP:NetIO_FTP): Allow 125 as valid response code to
7646 the RETR command (fix for MS IIS ftp server 5 - possibly others too).
7647 (NetIO_FTP::ok): Check if the SimpleSocket object is ok().
7648 (NetIO_FTP::read): Use NetIO_FTP::ok().
7649 * nio-http.cc: Check for valid return value of SimpleSocket::gets().
7650 (NetIO_HTTP::ok): Check if the SimpleSocket object is ok().
7651
5898e300
RC
76522001-11-09 Robert Collins <rbtcollins@hotmail.com>
7653
58b12a06
MB
7654 * simpsock.cc (cvsid): Avoid compiler warnings (not used, deprecated
7655 conversion).
7656 (SimpleSocket::SimpleSocket): Avoid compiler warnings (deprecated
7657 conversion).
5898e300
RC
7658 (SimpleSocket::printf): Ditto.
7659 (SimpleSocket::write): Ditto.
7660 * simpsock.h (SimpleSocket): Avoid compiler warnings for constructor,
7661 printf and write.
58b12a06
MB
7662 * nio-ftp.cc (cvsid): Avoid compiler warnings (not used, deprecated
7663 conversion).
5898e300 7664 (NetIO_FTP::NetIO_FTP): Remove unused variable done.
58b12a06
MB
7665 * nio-http.cc (cvsid): Avoid compiler warnings (not used, deprecated
7666 conversion).
5898e300 7667
8e58f8fd
RC
76682001-11-07 Charles Wilson <cwilson@ece.gatech.edu>
7669
7670 * geturl.cc (get_url_to_string): clean up memory leak
7671 (get_url_to_file): ditto
cef493d7 7672
4b4002ab
RC
76732001-11-06 Robert Collins <rbtcollins@hotmail.com>
7674
7675 * localdir.cc (dialog_cmd): Go back to IDD_ROOT in every case.
7676 * source.cc (dialog_cmd): Go forward to IDD_ROOT in every case.
7677
94525fd9
RC
76782001-11-06 Pavel Tsekov <ptsekov@syntrex.com>
7679
7680 * fromcwd.cc (found_file): Free() memory containing the version and
58b12a06
MB
7681 filepath information for a given package, before replacing the pointers
7682 which reference this memory.
94525fd9
RC
7683
76842001-11-06 Robert Collins <rbtcollins@hotmail.com>
ca83c665
RC
7685
7686 * fromcwd: Fix compiler warnings for cvsid.
7687 (canonicalize_version): Fix compilter warnings.
7688 (do_fromcwd): Ditto.
7689 * version.h: Fix compiler warnings for canonicalize_version.
7690
ce1f9ec2
RC
76912001-11-03 Robert Collins <rbtcollins@hotmail.com>
7692
7693 * res.rc (IDD_CHOOSE): Move the view caption to the right hand side.
7694
89d82ec7
RC
76952001-11-02 Robert Collins <rbtcollins@hotmail.com>
7696
7697 * res.rc (IDD_CHOOSE): Tweak for use on a 640x480 screen.
7698
c8fea72a
RC
76992001-11-02 Robert Collins <rbtcollins@hotmail.com>
7700
58b12a06
MB
7701 * choose.cc (set_action): Correctly allow skip for any uninstalled
7702 package.
8114d309
RC
7703
77042001-11-02 Robert Collins <rbtcollins@hotmail.com>
7705
58b12a06
MB
7706 * choose.cc (default_trust): Change the "Required" forced install
7707 category to "Base".
c8fea72a 7708
f557695e
RC
77092001-11-02 Robert Collins <rbtcollins@hotmail.com>
7710
7711 * choose.cc: Ran indent.
58b12a06
MB
7712 (set_action): When the requested trust level is missing and the level
7713 was not user requested, set the action to ACTION_SAME_CURR.
f557695e 7714
9a60dafc
CF
77152001-11-01 Christopher Faylor <cgf@redhat.com>
7716
cef493d7 7717 * Makefile.in (mingw_getopt.o): Fix typo in non-verbose compilation.
f557695e
RC
7718
77192001-11-02 Robert Collins <rbtcollins@hotmail.com>
7720
7721 * choose.cc (_view::init_headers): Resync with the paint logic.
9a60dafc 7722
878faffd
RC
77232001-11-02 Robert Collins <rbtcollins@hotmail.com>
7724
58b12a06
MB
7725 * choose.cc (add_required): Allow SKIP and SRC_ONLY for currently
7726 installed packages.
878faffd 7727
05bfdf26
RC
77282001-11-02 Robert Collins <rbtcollins@hotmail.com>
7729
58b12a06
MB
7730 * choose.cc (default_trust): Autoset currently installed packages per
7731 the user's selection of prev/curr/exp.
05bfdf26 7732
0b9af00c
RC
77332001-11-02 Robert Collins <rbtcollins@hotmail.com>
7734
7735 * splash.cc (dialog_proc): Return TRUE as specified in the WIN32 API.
7736
7cefe128
RC
77372001-11-02 Pavel Tsekov <ptsekov@syntrex.com>
7738
7739 * geturl.cc (is_showing): Remove.
7740 (is_local_install): New static variable. Controls whether the
7741 progress dialog and the supporting thread will be created.
58b12a06
MB
7742 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the WIN32
7743 API.
7cefe128 7744 (init_dialog): Remove usage of SetForegroundWindow and is_showing.
cef493d7 7745 This prevents the progress dialog to gain control over the
7cefe128
RC
7746 application and fixes the "setup.exe going to background" problem.
7747 (progress): Use is_local_install.
7748 (get_url_to_string): Set is_local_install.
7749 (dismiss_url_status_dialog): Use is_local_install.
7750 * install.cc (dialog_proc): Return TRUE as specified in WIN32 API.
7751 (init_dialog): Remove usage of SetForegroundWindow.
cef493d7 7752 This prevents the progress dialog to gain control over the
7cefe128
RC
7753 application and fixes the "setup.exe going to background" problem.
7754
42a99ed1
RC
77552001-11-02 Robert Collins <rbtcollins@hotmail.com>
7756
7757 * choose.cc (list_click): Change r to row for clarity.
7758 When we shrink the list below 1 page, scroll to the top of the list.
7759 (_view::click): Return the actual change for contractions.
58b12a06
MB
7760 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the Win32
7761 API.
42a99ed1 7762
45c2d7d3
RC
77632001-11-02 Robert Collins <rbtcollins@hotmail.com>
7764
58b12a06
MB
7765 * choose.cc (dialog_cmd): Swap cygwin root selection and local dir
7766 selection order.
45c2d7d3
RC
7767 * localdir.cc: Ran indent.
7768 (get_root_dir_now): New function.
7769 (save_local_dir): New function.
58b12a06
MB
7770 (dialog_cmd): Use it and swap cygwin root selection and local dir
7771 selection order.
45c2d7d3 7772 (do_local_dir): If there is a saved local dir, read it in.
58b12a06
MB
7773 * net.cc (dialog_cmd): Swap cygwin root selection and local dir
7774 selection order.
45c2d7d3
RC
7775 * root.cc (dialog_cmd): Ditto.
7776 * source.cc (dialog_cmd): Ditto.
7777
2399c54d
RC
77782001-11-01 Robert Collins <rbtcollins@hotmail.com>
7779
7780 * choose.cc(list_vscroll): Return 0 as required by win32.
7781 (list_hscroll): Ditto.
7782 (list_click): Ditto.
7783
8e4402a9
RC
77842001-11-01 Robert Collins <rbtcollins@hotmail.com>
7785
7786 * argv.cc: Remove.
7787 * argv.h: Remove.
7788 * main.cc(WinMain): Use __argv to retrieve command line parameters.
7789 * Makefile,in: Remove argv.o.
7790
c168185f
RC
77912001-11-01 Matt Hargett <matt@use.net>
7792
cef493d7
CF
7793 * geturl.cc (progress): Change int to unsigned int to eliminate
7794 lint warnings.
7795 * (get_url_to_string): Check for NULL pointer.
7796 * mount.cc (find2): Use free instead of delete for malloc'd
7797 memory.
7798 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.
c168185f 7799
f97a1ece
RC
78002001-10-31 Robert Collins <rbtcollins@hotmail.com>
7801
58b12a06
MB
7802 * choose.cc(_view::insert_under): Handle linen > nlines and lines[linen]
7803 with neither a package nor a category. The lines[linen] bug was reported
7804 by Matt (matt@usa.net).
7805 (read_installed_db): Bugfix for testing whether a package has a source
7806 tarball. Reported by Matt (matt@usa.net).
7807 * geturl.cc(dialog): Rename gw_dialog to local_gw_dialog to avoid
7808 programmer confusion and lint errors. Reported by Matt (matt@usa.net).
f97a1ece 7809
d52ed64b
RC
78102001-10-31 Robert Collins <rbtcollins@hotmail.com>
7811
58b12a06
MB
7812 * argv.cc: New file, converts arguments for -mwindows
7813 programs. (Simplified derivation from dcrt0.cc.)
d52ed64b
RC
7814 * argv.h: New file.
7815 * Makefile,in: Add argv.o and mingw_getopt.o to setup.exe object list.
7816 Add mingw_getopt.o build rule.
7817 * main.cc(WinMain): Initialise argv and argc for use by getopt.
7818
392ba1ba
CF
78192001-10-27 Christopher Faylor <cgf@redhat.com>
7820
7821 * res.rc: Rearrange info on top line slightly.
7822
31324d15
CF
78232001-10-27 Christopher Faylor <cgf@redhat.com>
7824
7825 * desktop.cc (make_passwd_group): Move file creation earlier in the
7826 process to ensure that passwd-grp.bat reflects desired operation.
7827
78282001-27-10 Trevor Forbes <t4bs@hotmail.com>
7829
7830 * postinstall.cc (each): Remove "*.done" file else rename will fail.
7831
ee411d77
CF
78322001-10-16 Christopher Faylor <cgf@redhat.com>
7833
7834 * res.rc: Oops. Take 640x480 screen size into account.
7835
e74944da
CF
78362001-10-16 Christopher Faylor <cgf@redhat.com>
7837
7838 * res.rc: Enlarge chooser screen.
7839
e368cfb9
CF
78402001-10-12 Christopher Faylor <cgf@redhat.com>
7841
7842 * Makefile.in: Accomodate changes to w32api_include macro.
7843
a6ba3670
CF
78442001-10-12 Christopher Faylor <cgf@redhat.com>
7845
7846 * Makefile.in: Use correct flags for windres.
7847
683e96f6
CF
78482001-10-12 Christopher Faylor <cgf@redhat.com>
7849
7850 * Makefile.in (CFLAGS): Remove -nostdinc from CFLAGS.
7851
2c18c00b
CF
78522001-10-12 Christopher Faylor <cgf@redhat.com>
7853
7854 * choose.cc (pick_line::paint): Reorganize after botched patch.
7855
0f61a05a
CF
78562001-10-12 Christopher Faylor <cgf@redhat.com>
7857
7858 * choose.cc (pick_line::paint): Add missing declaration.
7859
308d6f3e
CF
78602001-10-10 Ralf Habacker <Ralf.Habacker@freenet.de>
7861
7862 * choose.cc (pick_line::paint): Add package name to sdesc for display.
7863
3bcf85be
RC
7864Wed Sep 26 21:39:00 Robert Collins rbtcollins@hotmail.com
7865
7866 * choose.cc (_view::insert_pkg): Correctly exit loop.
7867 * iniparse.y (register_category): Always insert new categories.
7868
fb2cd8f6
CF
7869Fri Sep 21 13:56:32 2001 Christopher Faylor <cgf@cygnus.com>
7870
7871 * inilex.l (yylex): For comments, eat all characters up to, but not
7872 including newline.
7873
127b32e1
CF
7874Sun Aug 26 12:50:01 2001 John Marshall <jmarshall@acm.org>
7875
7876 * fromcwd.cc (found_file): Use correct package name when adding an
7877 unknown package rather than random stack garbage.
7878
2cd555aa
CF
7879Sun Aug 12 14:25:21 2001 Christopher Faylor <cgf@cygnus.com>
7880
7881 * desktop.cc (make_passwd_group): .bat files need \r\n endings.
7882
4254cc64
CF
7883Wed Aug 8 13:53:47 2001 Christopher Faylor <cgf@cygnus.com>
7884
7885 * desktop.cc (etc_profile): Leave environment variables untouched.
7886
acbae401
CV
78872001-08-07 Corinna Vinschen <corinna@vinschen.de>
7888
7889 * autoload.c: Add dynamic load statements for NT/W2K
7890 advapi32 functions not available in 9x/ME.
7891 * main.cc (set_default_dacl): New function.
7892 (WinMain): Call `set_default_dacl' if running on NT/W2K.
7893
969a294c
CF
7894Sat Aug 4 21:35:53 2001 Christopher Faylor <cgf@cygnus.com>
7895
7896 * ini.h (_CategoryPackage): Change pkg field to pkgname for
7897 consistency.
7898 * choose.cc: Use pkgname field when referencing _CategoryPackage
7899 throughout.
7900 (fill_missing_category): Don't add excluded packages.
7901 (default_trust): Ditto.
7902 (_view::insert_pkg): Ditto.
7903 * iniparse.y (register_category): Use consistent variable name.
7904
9eeb0e83
ED
79052001-07-09 Egor Duda <deo@logos-m.ru>
7906
7907 * choose.cc: Use system foreground color for text output.
7908
06560feb
CF
7909Sat Jul 7 00:40:28 2001 Christopher Faylor <cgf@cygnus.com>
7910
7911 * choose.cc (set_action): Use default trust for determining reinstall
7912 and source only.
7913 (default_trust): Set default trust.
7914 (pick_line::paint): Allow source selection when reinstalling or
7915 retrieving.
7916
1fb09149
CF
7917Fri Jul 6 18:08:49 2001 Christopher Faylor <cgf@cygnus.com>
7918
7919 * choose.cc (isinstalled): Modify to properly accomodate special case
7920 of "download only".
7921 (set_action): Check downloaded components, not installed components if
7922 "download only".
7923 (set_existence): Always include full list of files when "download
7924 only".
7925
14cfffa5
CF
7926Fri Jul 6 00:37:05 2001 Christopher Faylor <cgf@cygnus.com>
7927
7928 * choose.cc (pick_line::paint): Properly display "na" field when no
7929 source exists.
7930
f54385f6
CF
7931Thu Jul 5 00:34:23 2001 Christopher Faylor <cgf@cygnus.com>
7932
7933 * choose.cc (scan2): Ensure that older versions do not show up in
7934 "Test" slot.
7935
85b1fb54
CF
7936Mon Jul 2 15:47:59 2001 Christopher Faylor <cgf@cygnus.com>
7937
7938 * choose.cc (set_action): Allow "Skip" action if trust != installed.
7939 * res.rc: Fix copyright.
7940
2dada532
CF
7941Sat Jun 30 14:05:21 2001 Michael A Chase <mchase@ix.netcom.com>
7942
7943 * res.rc (IDD_LOCAL_DIR): Change caption to match the other dialog
7944 boxes.
06c6d195 7945 (IDD_CHOOSE): Adjust horizontal size so package names are visible.
2dada532
CF
7946
7947 * choose.cc: Restore some more changes from 2001-06-25, throughout.
7948 (paint): Wrap some excessively long lines.
7949 (pick_line::paint): Ditto. Move the arrow in the "Current" column
7950 right to where it belongs. Move the source checkbox slightly to the
7951 right.
7952 (do_choose): List categories and required packages in setup.log.full.
7953
7954Sat Jun 30 23:04:59 2001 Christopher Faylor <cgf@cygnus.com>
7955
58b12a06
MB
7956 * choose.cc (scan2): Restore source scanning eliminated by previous
7957 checkin.
2dada532 7958
1b13eeec
CF
7959Sat Jun 30 15:18:33 2001 Christopher Faylor <cgf@cygnus.com>
7960
7961 * ini.h (struct _Info): Add "derived" element.
7962 * choose.cc (scan2): Try to place unknown tar files into proper slot
7963 when package exists in setup.ini but tar file does not.
7964
9307254d
RC
7965Sat Jun 30 13:39:00 2001 Robert Collins <rbtcollins@hotmail.com>
7966
7967 * choose.cc (create_listview): Call set_view_mode with VIEW_CATEGORY.
7968 (do_choose): Log the first category name.
7969
3467d79f
CF
7970Fri Jun 29 23:07:44 2001 Christopher Faylor <cgf@cygnus.com>
7971
7972 *ini.h: Reapply 2001-06-25 changes.
7973 * choose.cc (add_required): Ditto. Default to "Keep" state if
7974 UNINSTALL and product is installed. Default to curr state if SKIP,
7975 etc.
7976 (keep_or_skip): New function. Returns skip or keep state depending on
7977 installed state of package.
7978 (default_trust): Use keep_or_skip to set state.
7979 (_view::insert_pkg): Use calloc to allocate lines.
7980 (set_view_mode): Adapt 2001-06-25 change to set_full_list here.
7981
8f53e82a
RC
7982Sat Jun 30 11:01:00 2001 Robert Collins <rbtcollins@hotmail.com>
7983
1fb09149 7984 * choose.cc: Remove globals full_list, headers, package_indexes and
8f53e82a
RC
7985 nindexes.
7986 Add globals cat_headers, pkg_headers and chooser.
7987 (add_required): New function.
7988 (paint): Use the chooser for header details.
7989 Call into the chooser to paint each line.
1fb09149 7990 (list_click): Use new global variables.
8f53e82a
RC
7991 Call into the chooser to handle the click.
7992 Repaint the entire view if packages have been added or removed.
7993 (note_width): Get passed a headers struct rather than using a global
7994 variable.
7995 (fill_missing_category): New function.
7996 (default_trust): Skip non-"Required" or "Misc" packages.
7997 (pick_line::set_line (Package *)): New function.
7998 (pick_line::set_line (Category *)): New function.
7999 (pick_line::paint): New function.
8000 (pick_line::click): New function.
8001 (_view::_view): New function.
8002 (_view::set_view_mode): New function.
8003 (_view::mode_caption): New function.
8004 (_view::set_headers): New function.
8005 (_view::init_header): New function.
8006 (_view::insert_pkg): New function.
8007 (_view::insert_category): New function.
8008 (_view::insert_at): New function.
8009 (_view::insert_under): New function.
8010 (_view::clear_view): New function.
8011 (viewsplusplus): New function.
8012 (_view::client): New function.
8013 (set_view_mode): Use new chooser functionality.
8014 (set_full_list): Use new global variables.
8015 (create_listview): Instantiate chooser.
8016 Remove all hardcoded headers[] code.
8017 (dialog_cmd): On trust changes, check dependencies.
8018 (getcategorybyname): New function.
8019 (getpackagecategorybyname): New function.
8020 (scan2): Use case-insensitive package comparison.
8021 (do_choose): Use fill_missing_category ().
8022 Show some category data.
8023 * ini.h: Protect against multiple inclusion.
8024 (views) New enum.
8025 (_CategoryPackage): New struct.
8026 (_Category): New struct.
8027 (_Package): Change category to Category * from char *.
8028 (extern Category category): New global variable.
8029 (extern in ncategories): Ditto.
8030 (getcategorybyname): New prototype.
8031 (catpackagecategorybyname): New prototype.
8032 (register_category): New prototype.
8033 (add_category): New prototype.
8034 * iniparse.y: Parse multiple categories per package.
2dada532
CF
8035 (category): New global variable.
8036 (ncategories): New global variable.
8f53e82a
RC
8037 (new_package): Compare package against NULL, not 0.
8038 (new_requirement): Source formatting fix.
8039 (register_category): New function.
8040 (add_category): New function.
8041 * res.rc: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
8042 IDC_CHOOSE_VIEWCAPTION: New control.
8043 * resource.h: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
8044 IDC_CHOOSE_VIEWCAPTION: New control.
8045 Increment _APS_NEXT_CONTROL_VALUE.
8046
26a27c14
CF
8047Mon Jun 25 00:56:37 2001 Michael A Chase <mchase@ix.netcom.com>
8048
e19ad6a3 8049 * choose.cc (paint): Wrap excessively long lines.
26a27c14
CF
8050 (list_click): Ditto.
8051 (create_listview): Ditto.
8052 (do_choose): Ditto. Replace TABs and remove CRs in lines written to
8053 setup.log.full. Allow "Yes" for source exists in setup.log.full when
8054 installing from local directories.
8055
97312777
CF
8056Mon Jun 25 00:56:37 2001 Christopher Faylor <cgf@cygnus.com>
8057
5f9f0d8d
CF
8058 * choose.cc (set_action): Only clear srcpicked when moving to next
8059 state. Allow source installation if it exists in the current "trust"
8060 state. Don't move to skip state when package is installed.
97312777
CF
8061 (list_click): Don't allow source clicking when no source is available.
8062 (set_full_list): Display package when not is_full_action.
8063 * ini.h (is_full_action): Define.
8064
72fd1d1e
CF
8065Sun Jun 17 12:06:14 2001 Christopher Faylor <cgf@cygnus.com>
8066
8067 * install.cc (check_for_old_cygwin): New function. First stab at
8068 checking for old cygwin versions.
8069 (do_install): Call check_for_old_cygwin if there were no errors during
8070 the install.
8071
41ac91b5 8072Sat Jun 16 11:33:51 2001 Michael A Chase <mchase@ix.netcom.com>
86202506
CF
8073
8074 * choose.cc (_Info::_Info): Test _source paramenter for non-NULL rather
8075 than zeroed "source" element.
8076
80429b97
CF
8077Fri Jun 15 20:54:43 2001 Christopher Faylor <cgf@cygnus.com>
8078
8079 * choose.cc (scan2): Insert unknown tar archives, found on disk, into
8080 the highest available "hole" in the trust array.
8081
654ea642
CF
8082Fri Jun 15 00:20:48 2001 Christopher Faylor <cgf@cygnus.com>
8083
8084 * choose.cc (set_existence): Use pointer method for indexing in trust
8085 array.
8086 (create_listview): Ditto.
8087 (scan2): Ditto. Also, use consistent variable name for indexing into
8088 trust array.
8089 * ini.h (Package): Reorganize info array for easier scanning.
8090
e98d90bd
CF
8091Fri Jun 15 00:01:51 2001 Christopher Faylor <cgf@cygnus.com>
8092
8093 * choose.cc (isinstalled): Eliminate special download only test.
8094 (set_action): Don't move to next state if in ACTION_SAME range and not
8095 incrementing.
8096 (choose_caption): Display "Retrieve" rather than "Reinstall" when just
8097 downloading.
8098 (do_choose): Sort packages after all packages have been read.
8099 Accomodate the fact that first element in trust array is empty so that
8100 log files don't report the wrong trust value.
8101 * iniparse.y (new_package): Malloc space for package name or suffer
8102 memory corruption.
8103
38c97581
CF
8104Thu Jun 14 22:43:59 2001 Robert Collins <rbtcollins@hotmail.com>
8105
8106 * ini.h (Dependency): New structure. Declare new function.
58b12a06
MB
8107 * inilex.l (yylex): Detect new setup.ini options - category and
8108 requires.
38c97581
CF
8109 * iniparse.y: Declare new setup.ini token values.
8110 (yyparse): Parse new token values.
8111 (new_requirement): New function.
8112
8113Thu Jun 14 22:43:26 2001 Christopher Faylor <cgf@cygnus.com>
8114
8115 * choose.cc (read_installed_db): Eliminate obsolete code.
8116
3ae6c15c
CF
8117Thu Jun 14 22:11:53 2001 Christopher Faylor <cgf@cygnus.com>
8118
8119 * choose.cc (set_action): Set trust on "redo".
8120 (_Info::_Info): New constructor.
8121 (read_installed_db): Use new constructor. Use trusts type for
8122 iterator.
8123 * ini.h (struct _Info): Label struct, add constructor.
8124 (Package): Make installed_ix a type 'trusts.'
8125 * install.cc (uninstall_one): Unset any installed info for current
8126 package.
8127 (install_one): Allocate new Info struct for installed reflecting new
8128 installed info.
8129 (do_install): Don't output line to installed.db if package is being
8130 uninstalled.
8131
9c0a9876
CF
8132Thu Jun 14 20:33:01 2001 Robert Collins <rbtcollins@hotmail.com>
8133
8134 * choose.cc (getpkgbyname): Use consistent method for scanning package
8135 array.
8136
68b27c12
CF
8137Wed Jun 13 23:33:08 2001 Christopher Faylor <cgf@cygnus.com>
8138
8139 * choose.cc: Add some comments.
8140 (getpkgbyname): Use strcasecmp for comparisons.
8141
07108cc2
CF
8142Wed Jun 13 16:07:00 2001 Christopher Faylor <cgf@cygnus.com>
8143
f0984dcb 8144 * install.cc (do_install): Avoid checking for download action if
07108cc2
CF
8145 package wasn't currently retrieved.
8146
c46a33a9
CF
8147Wed Jun 13 11:27:22 2001 Christopher Faylor <cgf@cygnus.com>
8148
8149 * choose.cc: Eliminate extra array throughout. Use element in package
8150 structure instead. Use pointers rather than array indexes where
8151 appropriate.
8152 (set_action): New function to set next action based on current.
8153 (choose_caption): New function. Returns display caption.
8154 (check_existence): Change arguments. Use pointer to 'info' structure.
8155 (set_existence): Use pointer rather than array index.
8156 (default_trust): Use trusts enum for second argument.
8157 (set_full_list): Honor exclude element in package structure.
8158 (build_labels): Eliminate.
8159 (base): Make global. Use const char * argument.
8160 (get_package_version): Eliminate.
8161 (getpkgbyname): New function.
8162 (read_installed_db): Use parse_filename to get version info.
8163 * desktop.cc (make_passwd_group): Use getpkgbyname function.
8164 * download.cc (get_file_size): const argument.
8165 (do_download): Use is_download_action to determine when something
8166 should be downloaded.
8167 * filemanip.h: Add some functions.
8168 * ini.cc (do_ini): Use NULL rather than 0 for pointer assignment.
8169 * ini.h: Use enums for actions and trusts.
8170 (is_download_action): New macro.
8171 (is_upgrade_action): Ditto.
8172 (is_uninstall_action): Ditto.
8173 (struct Package): Add new fields.
8174 * inilex.l (yylex): Detect new setup.ini options.
8175 * iniparse.y: Declare new tokens.
8176 (yyparse): Detect exclude keyword. Fill out version field even if
8177 version == 0.
8178 (new_package): Use greater granularity when allocating package array to
8179 avoid repeated calls to realloc.
8180 * install.cc (exists): const argument.
8181 (uninstall_one): Take pkg argument.
8182 (install_one): Ditto. Eliminate unneeded arguments which can be
8183 derived from package info.
8184 (do_install): Iterate over package array using a pointer. Use
8185 is_download_action to control when package should be downloaded.
8186 * tar.cc (tar_open): const argument.
8187 * tar.h: Refloect const argument.
8188
7cc06fd3
CF
81892001-05-31 Michael Chase mchase@ix.netcom.com
8190
8191 * main.cc (WinMain): Add setup version to starting setup.log entry
8192
9522028b
CF
8193Tue May 29 21:37:58 2001 Yukihiko Sohda <sohda@is.titech.ac.jp>
8194
8195 * inilex.l: Add + to list of valid string characters.
8196
e9b1aaa7
CF
8197Mon May 28 20:54:50 2001 Christopher Faylor <cgf@cygnus.com>
8198
8199 * Makefile.in: Remove more stuff in the clean target.
8200
8e1299fa
CF
8201Mon May 28 18:24:59 2001 Christopher Faylor <cgf@cygnus.com>
8202
8203 * Makefile.in: Correctly generate iniparse.h.
8204
85553593
CV
8205Tue Mar 6 19:14:00 2001 Corinna Vinschen <corinna@vinschen.de>
8206
8207 * geturl.cc (get_url_to_file): Add parameter `allow_ftp_auth'.
8208 * geturl.h: Change declaration of `get_url_to_file' accordingly.
8209 * netio.cc (NetIO::NetIO): Add parameter `allow_ftp_auth'.
8210 Set member `ftp_auth'.
8211 (NetIO::open): Add parameter `allow_ftp_auth'. Use it in calls
8212 to constructors of derived classes.
8213 (NetIO::get_ftp_auth): New method.
8214 * netio.h: Change class definition accordingly.
8215 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Add parameter `allow_ftp_auth'.
8216 Take global variables `net_ftp_user' and `net_ftp_passwd' into account.
8217 Add code for ftp authentication retry.
8218 * nio-ftp.h: Change class definition accordingly.
8219 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Add parameter `allow_ftp_auth'.
8220 Add code for ftp authentication retry in case of proxy connection.
8221 * nio-http.h: Change class definition accordingly.
8222 * res.rc: Add FTP authentication dialog.
8223 * resource.h: Add new constants used in res.rc.
8224 * state.h: Add variables `net_ftp_user' and `net_ftp_passwd'.
8225
c4174b9c
CF
8226Sun May 27 17:12:23 2001 Christopher Faylor <cgf@cygnus.com>
8227
8228 * res.rc (IDD_SPLASH): Add a copyright year.
8229
0af2d779
CF
8230Sun May 27 15:42:18 2001 Christopher Faylor <cgf@cygnus.com>
8231
8232 * Makefile.in: Make iniparse.y produce a c++ file.
8233 * choose.cc (set_existence): Revert 2001-05-27 change.
8234 * ini.cc: Remove "C" from declaration of yyparse.
8235 * iniparse.y (yyparse): Fill out version field by default when a binary
8236 install is detected and no version has been set yet.
8237 * install.cc (do_install): Mount things earlier so that we can use
8238 proper mount table settings. Don't remove mounts since they are now
8239 honored.
8240 * mount.cc (create_mount): Reread the mount table after establishing a
8241 new mount.
8242 (read_mounts): Explicitly clear root_here to allow multiple uses of
8243 this function. Ensure that there is no garbage in the table when we've
8244 exhausted all of the mounts in the registry.
8245 (cygpath): Accomodate ./ in path.
8246
85b43844
CF
8247Sun May 27 02:59:07 2001 Christopher Faylor <cgf@cygnus.com>
8248
0af2d779
CF
8249 Use parse_filename method to parse filenames throughout. Use
8250 get_root_dir to retrieve the current root directory throughout. Set
8251 const in argument list, where appropriate, throughout.
8252 * choose.cc (set_existence): Detect case of uninstalled package with no
8253 version.
85b43844
CF
8254 (parse_filename): New function.
8255 * filemanip.h (fileparse): New structure.
8256 * mount.cc (read_mounts): Remember where we found the root mount.
8257 (set_root_dir): New function.
8258 (get_root_dir): Ditto.
8259 * mount.h: Declare new functions.
8260 * site.cc (get_root_dir_now): Renamed from get_root_dir.
8261 (save_site_url): Use new function name.
8262 (get_initial_list_idx): Ditto.
8263
08f8c762
CF
8264Sat May 26 21:23:59 2001 Christopher Faylor <cgf@cygnus.com>
8265
8266 * choose.cc: Use a constant throughout to deal with chooser icon
8267 length.
8268 * res.rc (IDD_CHOOSE): Increase size of chooser box.
8269
47f8d8b3
CF
82702001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
8271
8272 * choose.cc (do_choose): Fix incorrect assignment of trust setting to
8273 use when Redownload or Sources Only selected.
8274
6a748750
CF
8275Thu May 10 22:35:59 2001 Christopher Faylor <cgf@cygnus.com>
8276
8277 Reformat file after botched patch formatting.
8278 * choose.cc (which_trust): Eliminate variable.
8279 (default_trust): Don't set which_trust.
8280 (do_choose): Use selected trust when reinstalling or installing source.
8281
a351e48c
CF
8282Thu May 10 21:04:18 2001 Christopher Faylor <cgf@cygnus.com>
8283
8284 Change concat to cygpath throughout.
8285 Change map_filename to cygpath throughout.
8286 * concat.cc (vconcat): New function.
8287 (concat): Use vconcat.
8288 * concat.h: Reflect above.
8289 * install.cc (map_filename): Eliminate.
8290 (install_one): Free dest_file.
8291 * mount.cc (find2): Expect input key to be pointing to mount record.
8292 (in_table): New function.
8293 (is_admin): Move from root.cc.
8294 (read_mounts): New function.
8295 (path_prefix_p): New function.
8296 (cygpath): New function.
8297 * mount.h: Define new functions and structure.
8298 * root.cc (in_table): Move to mount.cc.
8299 (do_root): Call read_mounts to initialize root stuff and mount table.
8300 * site.cc (get_root_dir): Ditto.
8301
e227ee24
CF
83022001-05-09 Matt Hargett <matt@use.net>
8303
8304 * Makefile.in: Remove *.rc from clean.
8305
25fd2965
CF
8306Tue May 8 23:33:38 2001 Christopher Faylor <cgf@cygnus.com>
8307
8308 * choose.cc (scan2): Fix incorrect setting of TRUST_CURR rather than
8309 TRUST_PREV which produced "0" versions.
8310
42bf5b92
CF
83112001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
8312
8313 * resource.h: Add new field IDC_CHOOSE_INST_TEXT. Modify
8314 _APS_NEXT_CONTROL_VALUE to account for addition of
8315 IDC_CHOOSE_INST_TEXT.
8316 * res.rc (IDD_CHOOSE): Modify choose dialog to use new field
8317 IDC_CHOOSE_INST_TEXT for screen text. Modify choose Dialog to allow
8318 hot keys to select Prev, Curr, Exp.
8319 * ini.h: Add new actions for ACTION_REDO and ACTION_SRC_ONLY. Modify
8320 define for LOOP_PACKAGES to include new actions ACTION_REDO and
8321 ACTION_SRC_ONLY.
8322 * choose.cc: Add new Trusts for TRUST_REDO and TRUST_SRC_ONLY.
8323 (paint): Modify to check TRUST_SRC_ONLY when determining Bitmap for
8324 source Checkbox to use.
8325 (build_labels): Add logic to allow for selection of Source only
8326 Download/ReDownload/Install/Reinstall and also to Redownload/Reinstall
8327 current version binary.
8328 (dialog_proc): Add conditional display for file selection prompt based
8329 on download vs install using IDC_CHOOSE_INST_TEXT.
8330 (do_choose): Add new logic for TRUST_REDO and TRUST_SRC_ONLY selection
8331 and modify logic for TRUST_UNINSTALL, TRUST_KEEP, and TRUST_NONE to
8332 handle the instance where Source Download/Install was selected. Modify
8333 log file to store appropriate information regarding Action selected and
8334 the new actions that were added (I.E.: ACTION_REDO and
8335 ACTION_SRC_ONLY).
8336 * download.cc: Add include for <unistd.h> and "port.h".
8337 (download_one): Modify parameter list to include the selected action
8338 for the file to be downloaded. Modify size check against expected size
8339 to include check for ACTION_REDO and ACTION_SRC_ONLY. Modify rename of
8340 .tmp file to also remove the destination file if exists due to ability
8341 to redownload source and binary now.
8342 (do_download): Modify to also use ACTION_REDO and ACTION_SRC_ONLY in
8343 calculation of Download Bytes. Modify to also use ACTION_REDO and
8344 ACTION_SRC_ONLY in determining files selected for download.
8345 * install.cc (uninstall_one): Add check to treat a Reinstall like an
8346 upgrade so current version will be uninstalled prior to reinstall.
8347 (do_install): Add logic to handle ACTION_REDO and ACTION_SRC_ONLY for
8348 uninstalling and installing binary and source packages.
8349 * desktop.cc (make_passwd_group): Modify logic to account for a Source
8350 only cygwin install when checking for cygwin to determine need for
8351 mkpasswd and mkgroup.
8352
8353Mon May 7 23:33:30 2001 Matt Hargett <matt@use.net>
8a09aa99
CF
8354
8355 * winsup/cinstall/res.rc: Added accelerators and improved focus order.
8356 Removed WS_DISABLED from "OK" buttons to accomodate default focus
8357 changes in net.cc and source.cc.
8358 * winsup/cinstall/net.cc (dialog_proc): If no radio button is selected,
8359 a default is selected.
8360 * winsup/cinstall/source.cc (dialog_proc): Ditto.
8361 (check_if_enable_next): Removed. No longer needed since a radio button
8362 will always be selected.
8363 (load_dialog): Removed call to check_if_enable_next.
8364 (dialog_cmd): Ditto. Also added default to switch.
8365
87bdba0c
CF
8366Tue Apr 24 23:42:02 2001 Christopher Faylor <cgf@cygnus.com>
8367
8368 * res.rc: Resize affected text.
8369
8293fc16
CF
8370Tue Apr 24 23:35:31 2001 Christopher Faylor <cgf@cygnus.com>
8371
8372 * net.cc (do_net): Default to direct download.
87bdba0c 8373 * res.rc: Move default selections to the top.
8293fc16 8374
ed96c6da
EB
83752001-04-18 Earnie Boyd <earnie@users.sourceforge.net>
8376
8377 * win32.h: Remove the definitions for _UNION_NAME and _STRUCT_NAME.
8378 Must now include <windows.h> and not the pieces.
8379 * choose.cc (create_listview): Clean up type mismatch problems.
8380 * dialog.h (NEXT(id)): Ditto.
8381 * geturl.cc (dialog): Ditto.
8382 * install.cc (dialog): Ditto.
8383 * splash.cc (load_dialog): Ditto.
8384
fe94cc29
CF
8385Wed Apr 18 18:59:21 2001 Christopher Faylor <cgf@cygnus.com>
8386
8387 * tar.cc (class gzbz): Define dummy virtual functions.
8388
fb087b80
CF
8389Wed Apr 18 16:01:21 2001 Christopher Faylor <cgf@cygnus.com>
8390
8391 * Makefile.in: Add bz2 include/library support.
8392 * filemanip.h: New file.
fe94cc29
CF
8393 * choose.cc (find_tar_ext): New function. Returns TRUE if .tar.gz or
8394 .tar.bz2 found.
fb087b80
CF
8395 (scan2): Reorganize to use find_tar_ext, accomodating .bz2 extension.
8396 (read_installed_db): Ditto.
8397 (do_choose): Ditto.
8398 * fromcwd.cc (found_file): Ditto.
8399 (do_fromcwd): Ditto.
8400 * tar.cc (class gzbz): New super class for uncompression support.
8401 (gz): New class for gzip support.
8402 (bz): New class for bzip2 support.
8403 (tar_open): Use gzbz class to control file opening.
8404 (tar_ftell): Ditto for returning position in file.
8405 (skip_file): Ditto for reading file.
8406 (tar_next_file): Ditto.
8407 (tar_read_file): Ditto.
8408 (tar_close): Ditto for close.
8409
8410 * zlib/configure.in: Force NM substitution.
8411
8412 * source.cc (do_source): Default to "Install from Internet".
8413
88bcaf07
CF
84142001-03-16 Brian Keener <bkeener@thesoftwaresource.com>
8415
8416 * nio-file.cc (NetIO_File::NetIO_File): Use `get_file_size' instead of
8417 `stat'.
8418 * choose.cc (list_click): Correct inability to select source code for
8419 download.
8420 (scan2): Modify to skip source tarballs when scanning disk for
8421 installable packages.
8422
ef45c299
CV
84232001-03-10 Chris Abbey <chris_abbey@yahoo.com>
8424
8425 * install.cc: install sources into /usr/src instead
8426 of /, also include the sizes of source tarballs
8427 in total_bytes.
8428 * download.cc: include sizes of source tarballs in
8429 total_download_bytes.
8430
9fe1181b
CV
8431Tue Mar 6 19:31:00 2000 Corinna Vinschen <corinna@vinschen.com>
8432
8433 * download.cc (get_file_size): Remove `static'.
8434
2bfdb848
CV
8435Tue Mar 6 19:11:00 2000 Corinna Vinschen <corinna@vinschen.com>
8436
8437 * tar.cc (tar_open): Use `get_file_size' instead of `stat'.
8438
60c632b3
CV
84392001-03-06 Brian Keener <bkeener@thesoftwaresource.com>
8440
8441 * choose.cc (paint): Modify message for nothing to download vs
8442 nothing to install/update based on installation method.
8443 (list_click): Modify to skip versions in selection process if
88bcaf07 8444 installing from local directory and installation file does not exist.
60c632b3
CV
8445 Also leaves Source Action set to N/A if the source file does not exist
8446 and installing from local directory.
8447 (check_existence): New method to check current existence of installation
8448 files based on selected installation method.
8449 (set_existence): New method to set the current existence of installation
8450 files based on selected installation method.
8451 (best_trust): Modify decision process for best trust to base decision on
8452 current trust selected (IE: Prev, Curr, or Test), existence of file and
8453 installation method selected.
8454 (default_trust): Add logic to capture the current trust level and the
8455 trust selected for the given package.
88bcaf07 8456 (set_full_list): Expand decision criteria for displaying a package in
60c632b3
CV
8457 the selection list to include file existence/non-existence and selected
8458 installation method.
8459 (build_labels): Modify criteria for label addition to include
8460 installation method and file existence/non-existence.
88bcaf07 8461 (create_listview): Modify to establish package trust level for each
60c632b3
CV
8462 package before setting up the display list. Also modification to set
8463 current trust button as the default.
88bcaf07 8464 (dialog_cmd): Set response for Prev, Curr, Test button push to perform
60c632b3
CV
8465 a reset of the selection list in addition to setting the default trust.
8466 (get_package_version): New method to provide reusable code for
8467 determining the package version from the file name for a specified
8468 trust.
8469 (scan2): Modify to use new method get_package_version and
8470 also enhance handling of the build for the structures package and
8471 extra.
8472 (read_installed_db): Modify to use the new method
8473 get_package_version and also enhance handling of the build for the
8474 structures package and extra.
88bcaf07 8475 (do_choose): Add additional initialization of package and extra
60c632b3
CV
8476 structures. Modify to use read_installed_db all the time despite
8477 install method. Modify output to setup.log.full log file to increase
8478 readability by adding additional spacing, expanded code and available
8479 versions.
8480 * ini.h: Add new fields install_exists, source_exists and
88bcaf07 8481 partial_list_display to the structure definition for package.
60c632b3
CV
8482 * res.rc (IDD_CHOOSE): Modify choose dialog Prev, Curr, and Test
8483 pushbuttons by replacing with Radio Buttons thus allowing the
8484 operator to better determine which is selected.
8485
2f9645a1
CV
84862001-02-20 Brian Keener <bkeener@thesoftwaresource.com>
8487
88bcaf07 8488 * download.cc (do_download): Add new variables total_download_bytes and
2f9645a1
CV
8489 total_download_bytes_sofar for download progress meter. Add loop
8490 to accumulate the total bytes to download from the selected packages.
8491 * geturl.cc: Add state.h and diskfull.h to include list. Add new
8492 variables gw_iprogress, gw_pprogress, gw_progress_text,
8493 gw_pprogress_text, and gw_iprogress_text to allow for addition of
8494 total packages download progress meter and disk full percent
8495 progress meter. Add variables total_download_bytes and
8496 total_download_bytes_sofar for use by progress meters.
88bcaf07
CF
8497 (dialog_proc): Add new variables gw_iprogress, gw_pprogress,
8498 gw_progress_text, gw_pprogress_text, and gw_iprogress_text to
8499 allow for addition of total packages download progress meter and disk
8500 full percent progress meter.
2f9645a1
CV
8501 (init_dialog): Ditto.
8502 (progress): Ditto.
8503 (get_url_to_file): Ditto.
8504 * geturl.h: Add external definition for total_download_bytes and
8505 total_download_bytes_sofar.
88bcaf07 8506 * res.rc: Add two additional progress meters (IDC_DLS_IPROGRESS)
2f9645a1
CV
8507 and (IDC_DLS_PPROGRESS) and three text objects (IDC_DLS_PROGRESS_TEXT)
8508 and (IDC_DLS_IPROGRESS_TEXT, IDC_DLS_PPROGRESS_TEXT) for use in the
8509 download meters.
88bcaf07 8510 * resource.h: Add new fields for progress meters and text and update
2f9645a1
CV
8511 _APS_NEXT_CONTROL_VALUE.
8512
b41962a3
CV
8513Wed Feb 21 13:05:00 2000 Corinna Vinschen <vinschen@redhat.com>
8514
8515 * download.cc (get_file_size): Check for INVALID_HANDLE_VALUE instead
8516 for NULL.
8517
8518Wed Feb 21 11:21:00 2000 Corinna Vinschen <vinschen@redhat.com>
01954c34
CV
8519
8520 * download.cc (download_one): Add missing parenthesis.
8521
88a77116
CV
8522Mon Feb 19 18:59:00 2000 Corinna Vinschen <vinschen@redhat.com>
8523
8524 * download.cc (get_file_size): New function. Eliminates the need
8525 to call `stat'.
8526 (download_one): Call `get_file_size' instead of `stat'. This
8527 workarounds a problem with mingw's `stat' call.
8528
577f35ed
EB
85292001-02-07 Earnie Boyd <earnie@users.sourceforge.net>
8530
8531 * Makefile.in: (%.o: %.rc): Specify --include-dir $(w32api_include).
8532 This is to allow cinstall to build with 2.95.2-7 and to make the
8533 use of headers consistent.
8534
38f5563e
DD
85352000-12-26 Earnie Boyd <earnie_boyd@yahoo.com>
8536
8537 * Makefile.in (autoload.o): Add target to specify -fno-inline-functions
8538
c0a7e0f2
DD
8539Tue Dec 26 03:46:00 2000 Matt Hargett <matt@use.net>
8540
8541 * winsup/cinstall/res.rc: Added accelerators and improved focus
8542 order.
8543
72826a5b
CF
85442000-12-10 Egor Duda <deo@logos-m.ru>
8545
8546 * choose.cc (paint): Use system background color for text output.
8547
8548Sun Dec 10 19:05:25 2000 Christopher Faylor <cgf@cygnus.com>
8549
8550 * Makefile.in: Use CXX for linking and for compiling .cc files.
8551 * configure.in: Find correct c++ compiler.
8552 * configure: Regenerate.
8553
67bebcb5
DD
85542000-11-17 DJ Delorie <dj@redhat.com>
8555
8556 * splash.cc (load_dialog): Make message more obvious.
8557 * res.rc: Ditto.
8558
25fb9139
CF
8559Fri Nov 17 17:15:21 2000 Christopher Faylor <cgf@cygnus.com>
8560
8561 * Makefile.in: Use g++ to link so that libstdc++.a gets used. This is
8562 necessary for newer compilers.
8563
ef2007fd
CV
8564Wed Nov 9 2:19:00 2000 Corinna Vinschen <vinschen@redhat.com>
8565
8566 * desktop.cc: Include "ini.h" and "version.h".
8567 (make_passwd_group): Skip the function on 9x/ME boxes when an
8568 older version of Cygwin has been installed which doesn't
8569 support mkpasswd/mkgroup on 9x/ME.
8570 * install.cc: Move the `LOOP_PACKAGES' and `pi' macros to...
8571 * ini.h: ...here.
8572
277b4d56
CV
8573Wed Nov 8 17:10:00 2000 Corinna Vinschen <vinschen@redhat.com>
8574
8575 * desktop.cc (make_passwd_group): Don't exit when started
8576 on 9x/ME since mkpasswd/mkgroup are usable on 9x/ME now.
8577
f8a6415f
DD
8578Sun Nov 5 12:51:42 2000 Jason Tishler <jt@dothill.com>
8579
8580 * install.cc (do_install): Add call to set_cygdrive_flags to sync
8581 the mount modes.
8582 * mount.cc (set_cygdrive_flags): New function.
8583 (get_cygdrive_flags): Ditto.
8584 (default_cygdrive): Ditto.
8585 (set_cygdrive_flags): Ditto.
8586 * mount.h: Add prototype for set_cygdrive_flags.
8587
3b9077d4
DD
85882000-10-23 DJ Delorie <dj@redhat.com>
8589
8590 * ini.h: add source actions
8591 * fromcwd.cc: check for available sources
8592 * res.rc: add checkbox bitmaps
8593 * resource.h: ditto
8594 * check-*.bmp: new
8595 * choose.cc: add source column
8596 * download.cc: download sources if called for
8597 * install.cc: [un]install sources too
8598
1b1b33ac
DD
85992000-10-22 DJ Delorie <dj@redhat.com>
8600
8601 * choose.cc (build_labels): Don't skip TRUST_PREV completely; only
8602 ignore it wrt full_list if there's already a version installed.
8603 (do_choose): Sort the list.
8604 (package_sort): New.
8605
2a1a01e0
DD
86062000-10-12 DJ Delorie <dj@redhat.com>
8607
8608 * res.rc: Add more error strings.
8609 * resource.h: Ditto.
8610 * iniparse.y (new_package): re-initialize if needed.
8611 * download.cc (do_download): Keep track of errors; notify and
8612 allow retry.
8613 * install.cc (do_install): Ditto.
8614
1a9886fe
DD
86152000-10-05 DJ Delorie <dj@redhat.com>
8616
8617 * Makefile.in: fix %.cc rule
8618
40aef45e
DD
86192000-10-04 DJ Delorie <dj@redhat.com>
8620
8621 * desktop.cc: quote HOME and USER, don't . ./.profile
8622
8623 * choose.cc (build_labels): don't include in partial list just
8624 because there's a *previous* version available.
8625
8626 * install.cc (do_install): if installing from local directory with
8627 setup.ini and the file isn't found, look in "." also. Note errors.
8628
dd3f7f9b
DD
86292000-10-02 DJ Delorie <dj@redhat.com>
8630
8631 * ini.cc (do_ini): save setup.ini locally
8632
86332000-10-02 Chris Abbey <cabbey@bresnanlink.net>
8634
8635 * desktop.cc: quote escapes in prompt
8636
fee2a8d0
DD
86372000-10-02 Jason Tishler <jt@dothill.com>
8638
8639 * root.cc (is_admin): New function.
8640 (read_mount_table): Check for administrative priviledges and set
8641 installation scope as appropriate.
8642
a03db251
DD
86432000-09-28 DJ Delorie <dj@redhat.com>
8644
8645 * nio-ftp.cc (ftp_line): handle continuations more robustly
8646
b151e01e 86472000-09-14 Brian Keener <bkeener@thesoftwaresource.com>
0b758d4c
DD
8648
8649 * res.rc: increased the size of the site dialog (IDD_SITE) & the
8650 corresponding list box to provide for more URL's to be listed.
8651 Modified the position of the Back, Next and Cancel buttons to
8652 correspond to the new size of the dialog.
8653
d07591a3
DD
86542000-09-13 DJ Delorie <dj@redhat.com>
8655
8656 * install.cc (do_install): update disk fullness once per package
8657 to improve performance
8658
8659 * choose.cc (create_listview): call ReleaseDC
8660
89725f30
DD
8661Mon Sep 11 22:40 2000 Harold L Hunt II <harold@compasstechnologies.com>
8662
8663 * mkdir.cc: Create directories when ERROR_FILE_NOT_FOUND is
8664 returned, as it seems Samba 2.0.6+ returns this instead of
8665 ERROR_PATH_NOT_FOUND
88bcaf07 8666
6fbc690d
CF
8667Mon Sep 11 19:35:24 2000 Christopher Faylor <cgf@cygnus.com>
8668
8669 * site.cc (get_initial_list_idx): Don't default to saved URL if it
8670 refers to sources.
8671
13d27274
DD
86722000-09-07 DJ Delorie <dj@redhat.com>
8673
8674 * splash.cc: use version.h, not local decl
8675 * res.rc: add "old version" message
8676 * resource.h: ditto
8677 * version.h: new
8678 * fromcwd.cc (canonicalize_version): make global
89725f30
DD
8679 * iniparse.y: add setup-version support, fix bug in blank line
8680 handling
8681
13d27274
DD
8682 * inilex.l: add [exp] as alias for [test], add setup-version
8683 * Makefile.in (version.c): add setup-version tag
8684
8685 * desktop.cc (do_desktop): remove 1.1 version number
8686 (do_desktop_setup): ditto
8687
8688 * ini.cc (do_ini): zero out package list just in case we redo it.
8689
8cfbc487
DD
86902000-09-07 Jeffrey Juliano <juliano@cs.unc.edu>
8691
8692 * choose.cc (list_click): Check for nindexes==0; if so, return.
8693
c92e1307
DD
86942000-09-06 Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru>
8695
8696 * localdir.cc: new, local package directory selection dialog; cd
8697 into selected directory
8698 * Makefile.in (OBJS): add localdir.o
8699 * dialog.h: add prototype for do_local_dir
8700 * main.cc (WinMain): initialize local_dir to cwd; add call to
8701 do_local_dir
8702 * net.cc (dialog_cmd): make DO_LOCAL_DIR next dialog
8703 * source.cc (dialog_cmd): ditto
8704 * res.rc: add DO_LOCAL_DIR dialog; remove "current directory" from
8705 presented choices in IDD_SOURCE; add IDS_ERR_CHDIR error string
8706 * resource.h: defines for DO_LOCAL_DIR dialog; define IDS_ERR_CHDIR
8707 * root.cc (dialog_cmd): make DO_LOCAL_DIR previous dialog
8708 * state.h: add local_dir variable
8709
87102000-09-06 Brian Keener <bkeener@thesoftwaresource.com>
50225eae
DD
8711
8712 * desktop.cc: added logic to handle to the new dialog and to
8713 default the setting for the new checkboxes based on whether the
8714 desktop icon or start menu link already exist.
8715 (desktop_icon): correction to desktop directories for desktop icon
8716 creation. Additional logic added for Win95 which does not appear
8717 to have Common Directories so if Common selected and null uses
8718 normal directory.
8719 (start_menu): Additional logic added for Win95 which does not
8720 appear to have Common Directories so if Common selected and null
8721 uses normal directory.
8722 (do_desktop_setup): moved the saving of the icon, creation of the
8723 bat file, profile, passwd, Start Menu link and desktop shortcut to
8724 this method from do_desktop. Made the creation of the desktop
8725 icon and start menu link conditional on settings of new dialog
8726 created for desktop.
8727 * install.cc (do_install): changed next from IDD_S_DESKTOP to
8728 IDD_DESKTOP.
8729 * main.cc (WinMain): changed case IDD_S_DESKTOP to IDD_DESKTOP.
8730 * res.rc: added new resource to create a desktop dialog with 2
8731 checkboxes for creating the desktop icon and start menu link.
8732 * resource.h: changed IDD_S_DESKTOP to IDD_DESKTOP and added two
8733 new controls: IDC_ROOT_MENU and IDC_ROOT_DESKTOP for new dialog.
8734 * state.h: added root_menu and root_desktop for use in dialog.
8735
4a83b7b0
DD
87362000-08-29 DJ Delorie <dj@redhat.com>
8737
8738 * choose.cc (scan_downloaded_files): scan for existing files, so
8739 that the user only sees new downloads.
8740
8741 * nio-ie5.cc (NetIO_IE5): pre-check for wininet.dll, enable dial-up
8742 * site.cc (do_site): if we can't download the mirror list, go back
8743 to the net setup box to choose another transport.
8744 * autoload.c: add more functions
8745 * Makefile.in (ALL_DEP_LDLIBS): remove wininet.a
8746 * resource.h: add WININET message
8747
8748 * net.cc (do_net): no longer default to IE5
8749 * simpsock.h (class SimpleSocket): new, simplify socket operations
8750 * simpsock.cc: ditto
8751 * nio-http.h: new, for direct http protocol
8752 * nio-http.cc: ditto
8753 * nio-ftp.h: new, for direct http protocol
8754 * nio-ftp.cc: ditto
8755 * netio.cc (set_url): move initialization here to handle redirections
8756 (open): add direct http/ftp
8757 * netio.h (NetIO::set_url): new
8758
8759 * log.cc (log_save): create directory for log if needed
8760
8761 * hash.cc, hash.h: new
8762 * Makefile: add hash.o
8763 * choose.cc: enable "uninstall" option
8764 * download.cc: invert action test to accomodate uninstalling
8765 * ini.h: add ACTION_UNINSTALL
8766 * install.cc: add uninstall functionality
8767 * res.rc: make install tag changeable
8768 * resource.h: add uninstall resources
8769
8770 * res.rc: update mirror list URL
88bcaf07 8771
50f64a4b
DD
87722000-08-24 DJ Delorie <dj@redhat.com>
8773
89b1a15b
DD
8774 * log.cc, log.h: new files
8775 * Makefile.in (OBJS): add log.o
8776 * tar.cc: use exit_setup instead of exit
8777 * dialog.cc (fatal): use exit_setup instead of ExitProcess
8778 * msg.cc (fatal): ditto
8779 * install.cc (dialog_cmd): ditto
8780 * ini.cc (do_ini): ditto
8781 * main.cc (main): add logging
8782 * source.cc (do_source): ditto
8783 * root.cc (do_source): ditto
8784 * site.cc (do_site): ditto
8785 * other.cc (do_other): ditto
8786 * net.cc (do_net): ditto
8787 * choose.cc (do_choose): ditto
8788 * download.cc (do_download): ditto
8789 * install.cc (do_install): ditto
8790 * msg.cc (fatal): ditto
8791
8792 * res.rc: mark password boxes as *being* password boxes.
8793
58b12a06
MB
8794 * fromcwd.cc (canonicalize_version): use multiple buffers so that
8795 multiple calls won't use the same buffer.
50f64a4b
DD
8796 * choose.cc (create_listview): don't default to full list if no changes
8797 (base): return computed value, not temporary :-(
8798 (do_choose): don't use installed.db if we're only downloading.
8799
348860fa
DD
88002000-08-23 DJ Delorie <dj@redhat.com>
8801
8802 * nio-ie5.cc (NetIO_IE5): Fix authentication logic
8803 * nio-ie5.h (flush_io): new
8804 * netio.cc (load_dialog): note when we're initializing the dialog
8805 box, and ignore changes to the edit fields then.
8806
5f48f258
DD
88072000-08-21 DJ Delorie <dj@redhat.com>
8808
8809 * README: Update
8810
8811 * fromcwd.cc (found_file): don't remember the canonicalized version
8812
8813 * choose.cc (paint): print "nothing to do" message when list is empty.
8814 (build_labels): Use version "0.0" if no version is available.
8815 (create_listview): default to full list if nothing to install/update.
8816 (base): new, returns basename of file
8817 (read_installed_db): compare base names, not full paths
8818
713bbe5f
DD
88192000-08-11 DJ Delorie <dj@redhat.com>
8820
8821 * choose.cc: add new chooser dialog
8822 * fromcwd.cc: use IDD_CHOOSE
8823 * ini.cc: use IDD_CHOOSE
8824 * main.cc: use IDD_CHOOSE
8825 * ini.h: cosmetic changes
8826 * res.rc: add choose dialog, bitmaps
8827 * choose-spin.bmp: new
8828 * choose-rtarrow.bmp: new
8829 * resource.h: add choose dialog controls
8830
8831 * mount.cc: remove debug statement
88bcaf07 8832
2e9cbac5
DD
88332000-08-08 DJ Delorie <dj@redhat.com>
8834
8835 * Makefile.in (version.c): make version checking more robust
8836 * splash.cc (load_dialog): handle case where there's no version
8837
8507f105
DD
88382000-08-07 DJ Delorie <dj@redhat.com>
8839
8840 * (all): add cvsid tags
8841 * Makefile.in: generate version.c from ChangeLog, add splash.o
8842 * splash.o: new
8843 * res.rc: add splash screen
88bcaf07 8844
f5d0464b
DD
88452000-08-02 DJ Delorie <dj@redhat.com>
8846
4e8ff53f
DD
8847 * net.cc: remove proxy password code
8848 * res.rc: remove proxy user/pass from net, add auth dialogs
8849 * netio.cc,h: add sys/proxy auth methods
8850 * nio-ie5: use them, check for http status codes
8851 * state.h: add system authorization
8852
f5d0464b
DD
8853 * concat.cc (concat): canonicalize x:// to x:/ (exception to ://
8854 meaning an url)
8855
76cbfa85
DD
88562000-08-02 Norman Vine <nhv@yahoo,com>
8857
8858 * msg.cc (mbox): added MB_TOPMOST to MessageBox type flags
8859
e92c4436
DD
88602000-08-01 DJ Delorie <dj@redhat.com>
8861
bf74c544
DD
8862 * postinstall.cc (each): don't rename files we ignore
8863 (do_postinstall): set CYGWINROOT to root_dir, chdir there
8864
e92c4436
DD
8865 * desktop.cc: have /etc/profile call ~/.profile and ~/.bashrc
8866
a6100861
DD
88672000-07-31 DJ Delorie <dj@redhat.com>
8868
8869 * desktop.cc: reverse PATH so /usr/bin precedes /bin
8870
b11b49f3
DD
88712000-07-18 DJ Delorie <dj@redhat.com>
8872
a99bdfd8
DD
8873 * autoload.c: new, autoload dlls that might not be available.
8874 * Makefile.in (OBJS): add autoload.o
8875
8876 * res.rc: rewrite root options (text/binary, system/user) to be
8877 more obvious.
8878
b5b282c4
DD
8879 * site.cc (get_site_list): trim displayed URL, sort by domain
8880
8881 * net.cc (do_net): make IE5 default to checked, for now
8882
b11b49f3
DD
8883 * choose.cc (do_choose): sort packages correctly
8884 * ini.cc (do_ini): handle parse errors more gracefully
8885 (yyerror): ditto
8886 (fprintf): line buffer output
b5b282c4 8887 (do_ini): if we can't load setup.ini, go back to the site list.
b11b49f3
DD
8888 * ini.h: add "unknown" trust level
8889 * inilex.l: absorb unknown trust levels and key/value pairs,
8890 add line number logic
8891 * iniparse.y: handle parse errors more gracefully.
8892 * install.cc: skip packages with no valid install entry
8893
1fd6d0a2
DD
88942000-07-17 DJ Delorie <dj@cygnus.com>
8895
8896 * coding standards fixups, many files
8897 * mkdir.cc: warn about deletions *before* deleting them
8898
ed3e8b9b
DD
88992000-07-17 Jeff Juliano <juliano@cs.unc.edu>
8900
8901 * res.rc (IDD_OTHER_URL): reorder to give default focus to entry
8902
8903 * other.cc (dialog_cmd): save download site URL
8904 * site.cc (get_root_dir): new
8905 (save_mirror_site): new
8906 (dialog_cmd): save download site URL
8907 (get_site_list): make list big enough to add prev site
8908 (get_initial_list_idx): new, read last-used URL from file and
8909 append it to site_list
8910 (do_site): call get_initial_list_idx
8911
8912 * concat.cc (concat): avoid segfault when first parm is null
88bcaf07 8913
f57c332f
DD
89142000-07-13 DJ Delorie <dj@cygnus.com>
8915
8916 * postinstall.cc: new
8917 * Makefile.in: add postinstall.o
8918 * concat.h: add backslash ()
8919 * concat.cc: ditto
8920 * desktop.cc (etc_profile): don't do postinstall
8921 (backslash): moved to concat.cc
8922 (uexists): new
8923 (make_postinstall_script): run directly
8924 (do_desktop): chain to do_postinstall
8925 * dialog.h: add exit_msg, do_postinstall
8926 * download.cc: use exit_msg
8927 * install.cc: ditto
8928 * main.cc: add postinstall, exit_msg
8929 * resource.h: add postinstall
d6cda811 8930 * README: add more to-do items
f57c332f 8931
3a8e3956
DD
89322000-07-12 DJ Delorie <dj@cygnus.com>
8933
8934 * desktop.cc: add /etc/postinstall/ support
1a18aed7 8935 * install.cc: add more "standard" directories
3a8e3956 8936
e0c3d906
DD
89372000-07-11 DJ Delorie <dj@cygnus.com>
8938
8939 * desktop.cc: create /etc/profile
ad09bcd9
DD
8940 * desktop.cc: fix include syntax
8941 * Makefile.in: add auto-dependencies
24e259bb
DD
8942 * root.cc: support system vs user
8943 * desktop.cc: ditto
8944 * mount.h: ditto
8945 * mount.cc: ditto
8946 * install.cc: ditto
8947 * res.rc: ditto
8948 * resource.h: ditto
8949 * state.h: ditto
84d58d4c 8950 * desktop.cc: make sure we use backslashes, not slashes.
bf1d5889
DD
8951 * desktop.cc: don't set PATH in cygwin.bat, create /etc/passwd
8952 * geturl.cc: change math for percentage to avoid overflow
8953 * install.cc: ditto
8954 * download.cc: post "download complete" message.
8955 * root.cc: pre-fill in defaults if needed, don't start
8956 browse at root_dir unless it's set.
a3f48e18 8957 * desktop.cc: quote $PATH in case it has spaces in it
88bcaf07 8958
904d24fe
DD
89592000-07-10 DJ Delorie <dj@cygnus.com>
8960
8961 * Makefile.in: add desktop.o and mklink2.o
8962 * dialog.h: add do_desktop
8963 * install.cc: create standard directories, call do_desktop
8964 * res.rc: add cygwin.ico as a file also
8965 * desktop.cc: new, do shortcuts, batch files, and icons
8966 * mklink2.c: new, for COM
1ab805b8 8967 * README: update to-do list
904d24fe 8968
04d6e06b
DD
89692000-07-10 DJ Delorie <dj@cygnus.com>
8970
8971 * ini.cc (do_ini): don't worry about timestamps if we're not
88bcaf07 8972 actually installing.
04d6e06b 8973
5601a13d
DD
89742000-07-09 DJ Delorie <dj@cygnus.com>
8975
8976 * Makefile.in: add -I$(srcdir) for ini.h
8977
23c9e63c
DD
89782000-07-06 DJ Delorie <dj@cygnus.com>
8979
8980 * Replace everything with a new GUI version
8981 * zlib/gzio.c: add gzctell() for progress displays
8982
89832000-06-22 DJ Delorie <dj@cygnus.com>
8984
8985 * setup.c (tarx): re-add call to write_pkg()
8986
aa32874b
DD
89872000-06-07 DJ Delorie <dj@cygnus.com>
8988
8989 * cygcalls.c: new, call cygwin1.dll functions directly
8990 * cygcalls.h: header for same
8991 * Makefile.in: add cygcalls.[ch], remove mount/cygpath/umount
8992 exes, fix cinstall.rc dependencies.
8993 * path.c: remove unneeded code
8994 * setup.c: use cygcalls instead of xcreate_process.
8995 uncompress embedded files with zlib
8996 add "-d" for "download only"
8997 add "-h" for help
8998 postpone mount changes until very end
8999 add download progress indicators
9000 pack multi-column listings more
9001 auto-delete temp files
9002 customize banner message according to options
9003 prompt user for text/binary mounts
9004 add warnings about empty setup directory, root installs, etc
9005
99d1bf2d
DD
90062000-05-24 DJ Delorie <dj@cygnus.com>
9007
9008 * tar.c: New file; built-in tar using zlib.
9009 * tar.h: New file; header for same.
9010 * ctar.c: New file; test program for same.
9011 * Makefile.in: add built-in tar, remove tar.exe and gzip.exe
58b12a06
MB
9012 * path.c (pathcat): convert slashes and canonicalize, instead of
9013 aborting
99d1bf2d
DD
9014 * setup.c (tarx): add support for built-in tar
9015 (main): accept unix-style slashes, check root dir for drive letters,
58b12a06
MB
9016 warn about installing in /, make sure cwd is empty for internet
9017 installs, defer mounts to end of install, support built-in tar.
99d1bf2d 9018
55650749
CF
9019Fri May 19 23:44:37 2000 Christopher Faylor <cgf@cygnus.com>
9020
9021 Fix compiler warnings throughout.
9022 * pkg.c (init_pkgs): Make static 'stuff' global_pkgstuff for use in
9023 get_pkg_stuff.
9024 * setup.c: Make 'root' global.
9025 (istargz): Return pointer to "stem" of matched .tar.gz file.
9026 (tarx): Special case cygwin-20000301 to == cygwin-1.1.0.tar.gz. Remove
9027 bogus check_for_installed check.
9028 (recurse_dirs): Add preliminary support for .bat file execution.
9029 (create_uninstall): Eliminate unneeded parameter.
9030 (do_start_menu): Ditto.
9031 (mkmount): Ditto.
9032 (get_pkg_stuff): Ditto. Check for currently installed cygwin by
9033 scanning for the version number. Eliminate unneeded argument to
9034 create_uninstall.
9035 (getdownloadsource): Add 'name' to list of names rather than url.
9036 (main): Eliminate unneeded argument in get_pkg_stuff. Eliminate
9037 unneeded argument in mkmount and do_start_menu.
9038
f4dda8f0
DD
90392000-05-18 DJ Delorie <dj@cygnus.com>
9040
9041 * setup.c (optionprompt): allow multi-column, clean up message
9042 about more options, be more robust about user input.
9043 (getdownloadsource): make the mirror URL a macro.
9044 (main): do mounts after done prompting user.
9045
62844d84
CF
9046Tue May 2 00:56:41 2000 Christopher Faylor <cgf@cygnus.com>
9047
9048 * setup.c (cleanup): Inverse order of deletion stands a better chance
9049 of deleting cygpath.exe. Still seems to suffer from occasional races,
9050 though.
9051 (cleanup_on_signal): Perform convoluted dance to accomodate win95 and
9052 w2k.
9053 (output_file): Defend against an unlikely handle leak.
9054 (main): Don't set up signal handling until we have something special to
9055 do.
9056
ad6749c8
CF
9057Mon May 1 17:56:32 2000 Christopher Faylor <cgf@cygnus.com>
9058
9059 * path.c (kill_cygpath): Delete function.
9060 (exit_cygpath): Make more defensive so that it can be called at any
9061 time.
9062 (cygpath_pipe): Don't set up signal here. Do it in main().
9063 * setup.c (istargz): New function.
9064 (recurse_dirs): Look for *.gz pattern rather than *tar.gz since *tar.gz
9065 inexplicably fails on samba mounted partitions. Use istargz to match
9066 tar.gz tail.
9067 (processdirlisting) Use istargz to match tar.gz tail.
9068 (cleanup): Renamed from filedel.
9069 (cleanup_on_signal): New function. Called on CTRL-C.
9070 (main): Record handle of main thread so that it can be suspended when
9071 CTRL-C occurs. Set up cleanup_on_signal signal handler.
9072
460cf7b6
CF
9073Mon May 1 11:05:07 2000 Christopher Faylor <cgf@cygnus.com>
9074
9075 * setup.c (do_start_menu): Don't concatenate paths to already built
9076 paths.
9077
9e76799c
CF
9078Sun Apr 30 22:37:34 2000 Christopher Faylor <cgf@cygnus.com>
9079
9080 * path.c (exit_cygpath): Wait for subprocess to exit before returning.
9081 (cygpath_pipe): Don't call exit_cygpath. Let main atexit routine do
9082 that.
9083 * pkg.c (init_pkgs): Accept root argument. Make registry key "cygwin
9084 root"-specific.
9085 * setup.c (filedel): Call exit_cygpath here so that we can be assured
9086 that cygpath subprocess has died. This allows us to delete cygpath.exe
9087 and cygwin1.dll.
9088 (optionprompt): Initialize response to -1 so that second screen of
9089 mirrors will appear.
9090 (get_pkg_stuff): Don't attempt to use HKCLU. Pass root to init_pkgs.
9091 * setup.h: Reflect init_pkgs prototype change.
9092
2cf65e6e
CF
9093Sat Apr 29 23:53:30 2000 Christopher Faylor <cgf@cygnus.com>
9094
9095 * pkg.c (init_pkgs): Accept an argument to control what root registry
9096 key should be used.
9097 * setup.c (get_pkg_stuff): Use HKCLU registry key if default fails.
9098 * setup.h: Reflect init_pkgs prototype change.
9099
9100Sat Apr 29 23:27:14 2000 Christopher Faylor <cgf@cygnus.com>
9101
9102 * error.c (winerror): Respond to gcc warning.
9103 * path.c (cygpath_pipe): Ditto.
9104 * setup.c (filedel): Call sa_cleanup on deleteme.
9105 (create_shortcut): Coerce argument to eliminate compiler warning.
9106 (tarx): Use installed version of cygwin1.dll, overriding tar file name.
9107 (refmatches): New function. Tests if ref is contained in a list of
9108 packages to install.
9109 (filematches): New function. Tests if filename matches one of a list
9110 of packages to install.
9111 (recurse_dirs): Accept list of packages to install. Generalize tar.gz
9112 test to accomodate _tar.gz.
9113 (prompt): Ensure that stdout is flushed prior to asking for input.
9114 (findhref): Initialize variables to quiet a compiler warning.
9115 (processdirlisting): Accept list of packages to install. Special case
9116 cygwin tar file version number.
9117 (downloaddir): Accept list of packages to install.
9118 (downloadfrom): Ditto.
9119 (create_uninstall): Eliminate unneeded variables. Quote arguments to
9120 regtool.
9121 (do_start_menu): Don't create uninstall bat file if updating or user
9122 specified a list of packages.
9123 (mkmount): Eliminate unneeded variables.
9124 (get_pkg_stuff): New function. Checks for previous unversioned
9125 installation.
9126 (main): Accept -u and -f options and package names on the command line.
9127 Use get_pkg_stuff to initialize package information. Umount /etc.
9128 Call recurse_dirs and downloadfrom with list of package to install.
9129 Ensure that all /usr/local directories are created. Output
9130 installation time to setup.log.
9131 * setup.h: Add some prototypes.
9132 * xsystem.c (xcreate_process): Eliminate unneeded variable.
9133
4cf88dd9
CF
9134Sat Apr 29 12:43:08 2000 Christopher Faylor <cgf@cygnus.com>
9135
9136 * setup.c (optionprompt): Don't overlap display of already seen options
9137 on next page.
9138 (geturl): Print name of site which we're connecting to rather than "ftp
9139 site".
9140 (processdirlisting): Avoid URLs that contain a /. or ./ . Is this
9141 test too simplistic?
9142 (do_start_menu): Use pathcat to build path to <root>\bin to avoid
9143 problems when user chooses x:\ as their root.
9144 (main): For now, default to "non-update" mode. Allow -u option to
9145 signify an update.
9146
36591a07
CF
9147Sat Apr 29 00:26:06 2000 Christopher Faylor <cgf@cygnus.com>
9148
9149 * pkg.c: New file.
9150 * setup.c (tarx): Skip already installed or older packages. Report
9151 when a package has been updated.
9152 (processdirlisting): Skip already installed or older packages.
9153 (main): Detect -f option for forced installation. Initialize pkg stuff
9154 if appropriate.
9155 * setup.h: Add pkg definitions.
9156
c298ea4a
CF
9157Thu Apr 27 14:21:30 2000 Christopher Faylor <cgf@cygnus.com>
9158
9159 * setup.c (findhref): Return NULL on empty string. Eat any trailing
9160 ";something".
9161 (processdirlisting): Attempt to limit recursively processing the same
9162 directory.
9163
f4cafa7e
CF
9164Thu Apr 27 11:42:23 2000 Christopher Faylor <cgf@cygnus.com>
9165
9166 * setup.c (filedel): New function.
9167 (output_file): Keep track of files extracted from setup.exe for
9168 subsequent deletion.
9169 (tarx): Close process handle of child tar process or suffer handle
9170 leak.
9171 (getdownloadsource): Close mirror file so that it can be unlinked.
9172 (processdirlisting): Return total number of files extracted.
9173 (main): Initialize array of files to delete. Ensure that files are
9174 closed on exit. Make the directory that setup.exe is started from ==
9175 the directory where temporary files are placed. Issue an error if no
9176 files were found to download.
9177 * xsystem.c (xcreate_process): Close the thread handle. Close the
9178 process handle if we waited for it to exit.
9179
cd475210
CF
9180Thu Apr 27 09:54:19 2000 Christopher Faylor <cgf@cygnus.com>
9181
9182 * setup.c (main): Change version number output.
9183
7dff5e71
CF
9184Thu Apr 27 09:23:17 2000 Christopher Faylor <cgf@cygnus.com>
9185
9186 * setup.c (tarx): Use full path name to tar executable.
9187 (main): Build full pathname to tar executable. Create /usr/local/etc
9188 by default.
9189
99437fdb
CF
9190Wed Apr 26 22:16:57 2000 Christopher Faylor <cgf@cygnus.com>
9191
9192 * setup.c (findhref): Change method for scanning for href= to choose
9193 the last one on the line. This is still not foolproof and probably
9194 will need to be changed eventually. Don't abort if no "size" field is
9195 evident.
9196 (processdirlisting): Fix boolean algebra.
9197
0f562d55
CF
9198Wed Apr 26 01:10:39 2000 Christopher Faylor <cgf@cygnus.com>
9199
9200 * main.c (tarx): Add some code for future task of unmounting
9201 directories encountered in tar file.
9202
4356382d
CF
9203Sat Apr 22 16:37:03 2000 Christopher Faylor <cgf@cygnus.com>
9204
9205 * setup.c (findhref): Decode file size, when appropriate.
9206 (needfile): New function. Returns 1 when file should be
9207 downloaded.
9208 (processdirlisting): Always download if file size does not
9209 match. Prompt when download fails for some reason.
9210 (getdownloadsource): Accomodate findhref argument changes.
9211
6ab1ce6c
CF
9212Sat Apr 22 15:13:42 2000 Christopher Faylor <cgf@cygnus.com>
9213
9214 Throughout, use global session handle rather than reinitializing for
9215 each connect. Don't pass session as an argument to setup.c functions.
9216 * setup.c (geturl): Only issue "Connecting to.." message when using
9217 http or first time for ftp since subsequent connections will be fast.
9218 (processdirlisting): Allocate space for "N" when user has specified
9219 "N"ever option so that it can be subsequently freed.
9220 (main): Abort if we can't get the list of mirrors.
9221
37ee316b
CF
9222Thu Apr 20 16:41:42 2000 Christopher Faylor <cgf@cygnus.com>
9223
9224 * setup.c (main): Umount /bin and /lib.
9225
a59fb4fa
CF
9226Wed Apr 19 13:34:44 2000 Christopher Faylor <cgf@cygnus.com>
9227
9228 * setup.c (main): Create an empty /var/run/utmp.
9229
75f4b861
CF
9230Tue Apr 18 19:16:56 2000 Christopher Faylor <cgf@cygnus.com>
9231
9232 * Makefile.in: Add umount to list of files to include in setup.exe.
9233 * setup.c (xumount): New function for unmounting directories.
9234 (main): Unmount /usr.
9235 (mkmount): Unmount "unix directory" before trying to figure out where
9236 to create the directory.
9237
d4a66789
CF
9238Tue Apr 18 17:28:55 2000 Christopher Faylor <cgf@cygnus.com>
9239
9240 * setup.c (mkmount): Use xcreate_process to start mount process,
9241 avoiding the shell.
9242 (main): Don't do buffering on stdout or prompts won't be displayed
9243 correctly if running in a cygwin shell with CYGWIN=tty.
9244
a6c3982d
CF
9245Tue Apr 18 15:35:19 2000 Christopher Faylor <cgf@cygnus.com>
9246
9247 * setup.c (main): Remove the CYGWIN environment variable before
9248 starting any cygwin programs.
9249
0ffd5e3b
CF
9250Mon Apr 17 19:20:52 2000 Vadim Egorov <egorovv@mailandnews.com>
9251
9252 * setup.c (geturl): Use alternative method for finding filename part of
9253 a URL.
9254 (processdirlisting): Accomodate strange output from non-MS ftp proxy.
9255 (downloaddir): Unlink file containing dir listing.
9256 (downloadfrom): Ditto.
9257
3e54bcf9
CF
9258Mon Apr 17 00:00:49 2000 Christopher Faylor <cgf@cygnus.com>
9259
9260 * setup.c (main): Disallow running setup.exe from the "root".
9261
005b73c4
CF
9262Sun Apr 16 18:50:58 2000 Christopher Faylor <cgf@cygnus.com>
9263
2cf65e6e 9264 Use "warning" function, where appropriate, to output warnings.
005b73c4
CF
9265 * setup.c (warning): New function -- outputs warning to console and log
9266 file.
9267 (tarx): Fix index used to reset file protection.
9268 (main): Open the log file earlier so that more stuff can be sent to it.
9269
36dc5fc8
CF
9270Sat Apr 15 20:05:33 2000 Christopher Faylor <cgf@cygnus.com>
9271
9272 * setup.c (processdirlisting): Make "N" option a little less aggressive.
9273
c73320de
CF
9274Fri Apr 14 11:11:29 2000 Christopher Faylor <cgf@cygnus.com>
9275
9276 * setup.c (tarx): Wait to after tar has completed to reset protections
9277 or suffer races with tar process.
9278
68cdfc92
CF
9279Thu Apr 13 12:51:19 2000 Christopher Faylor <cgf@cygnus.com>
9280
9281 * Makefile.in: Eliminate duplicate -nostdinc from CFLAGS.
9282 * setup.c (create_uninstall): Create the uninstall .bat file in the
9283 "root" so that we can remove the /bin directory. Add bin\cygwin.bat to
9284 list of files to be deleted. Fix directory detection for determining
9285 when to use 'rmdir'.
9286 (do_start_menu): Add /usr/local/bin to the path.
9287 (main): Add slop to files.array allocation so that we don't have to
9288 worry about reallocating the array when it grows too large when doing
9289 some trivial "pushes". Add /tmp and /usr/local/{bin,lib} to list of
9290 files.
9291
35d18861
CF
9292Thu Apr 13 01:59:44 2000 Christopher Faylor <cgf@cygnus.com>
9293
9294 * setup.c (processdirlisting): Fix handling of "A" for "A"lways
9295 download.
9296
20904de1
CF
9297Thu Apr 13 01:11:45 2000 Christopher Faylor <cgf@cygnus.com>
9298
9299 * path.c (kill_cygpath): New cleanup function.
9300 (exit_cygpath): New cleanup function.
9301 (cygpath_pipe): New function. Sets up cygpath in the background for
9302 translating filenames.
9303 (pathcvt): Use background cygpath for file translation.
9304 * setup.c (tarx): New function. Called to extract tar files, capture
9305 logging output, and translate it to Windows format.
9306 (recurse_dirs): Use 'tarx' function to extract files.
9307 (create_uninstall): Use file list built up by tarx rather than reading
9308 the log file.
9309 (mkmount): Add ability to mount root.
9310 (main): Track elapsed install time. Mount root.
9311 * starry.h: Add index field to strarry for tracking of tarx's usage of
9312 this structure.
9313 * xsystem.c (xcreate_process): Return proces handle when not waiting.
9314
c1246750
CF
9315Mon Apr 10 22:44:56 2000 Christopher Faylor <cgf@cygnus.com>
9316
9317 * path.c: New file.
9318 (pathfp): New function. Preliminary work for new -f cygpath
9319 functionality.
9320 * Makefile.in: Add new file.
9321 (pathcvt): Move to new file.
9322 (dtoupath): Ditto.
9323 (utodpath): Ditto.
9324 (pathcat): Ditto.
9325 * setup.c (processdirlisting): Always open file in text mode.
9326 (create_uninstall): Ditto.
9327 (getdownloadsource): Ditto.
9328 (main): Ditto.
9329
4b40edd0
CF
9330Mon Apr 10 20:33:40 2000 Christopher Faylor <cgf@cygnus.com>
9331
9332 * xsystem.c: New file.
9333 * Makefile.in: Accomodate new file.
9334 * setup.c (xsystem): Move to new file.
9335 (recurse_dirs): Accept handle to output log file. Don't use ">"
9336 redirection to trap tar output. Use supplied handle instead.
9337 (create_uninstall): Accept FILE pointer to opened log file. Don't
9338 unlink log file here.
9339 (do_start_menu): Accept FILE pointer to pass to create_uninstall.
9340 (main): Open log file here and pass it to various functions. Unlink
9341 when done.
9342
6f8e3b45
CF
9343Mon Apr 10 17:15:52 2000 Christopher Faylor <cgf@cygnus.com>
9344
9345 Change occurrences of .usr.bin to .bin throughout.
9346 * setup.c (geturl): Increase number of retries to 20. Let user know
9347 what's going on during long connects.
9348 (processdirlisting): Accept "A"lways and "N"ever as update options.
9349 (create_uninstall): Load cygwin1.dll from the current directory rather
9350 than \bin.
9351 (main): Add some expository text.
9352
2a907b70
CF
9353Sun Apr 9 20:59:15 2000 Christopher Faylor <cgf@cygnus.com>
9354
9355 * Makefile.in: Change method for compressing cygwin1.dll to avoid
9356 creating a cygwin1.dll in the current directory. Ensure the addition
9357 of -nostdinc to MINGW_CFLAGS.
9358
c4285a3c
CF
9359Sun Apr 9 02:15:47 2000 Christopher Faylor <cgf@cygnus.com>
9360
9361 * Makefile.in: Augment clean target.
9362
ea615d51
RP
9363Fri Apr 7 17:04:02 Ron Parker <rdparker@sourceware.cygnus.com>
9364
9365 * README: Added info about non-working mingw implementation
c1246750 9366 * gzip.exe.gz: Replace with a version from the same build as the other
ea615d51 9367 tools.
c1246750 9368 * tar.exe.gz: Replace with a version from the same build as the other
ea615d51 9369 tools.
c1246750 9370 * mount.exe.gz: Add to repository until, mingw can build setup.
ea615d51
RP
9371 * cygpath.exe.gz: ditto
9372 * cygwin1.dll.gz: ditto
c1246750
CF
9373 * setup.c: Overwrite /bin and /lib mounts. Generate working shortcut
9374 for Win9x. Display only a screenfull of options at a time. Call all
9375 tools with an absolute path.
9376 * setup.dsp: Restore the carriage returns, MS Developer Studio needs
9377 them.
ea615d51
RP
9378 * setup.dsw: ditto
9379 * zlib.dsw: ditto
9380
51954e74
CF
9381Thu Apr 6 19:15:27 2000 Christopher Faylor <cgf@cygnus.com>
9382
c1246750
CF
9383 * Makefile.in: Add "-nostdinc" to regular CFLAGS. Add target to grab
9384 cygwin1.dll from ../cygwin subdirectory.
51954e74
CF
9385 * gzip.exe.gz: Update.
9386 * tar.exe.gz: Update.
9387
7b777418
CF
9388Wed Apr 5 10:52:08 2000 Christopher Faylor <cgf@cygnus.com>
9389
9390 * Makefile.in: Use ZLIB variable as a target.
9391
4306b490
CF
9392Sat Apr 1 22:49:09 2000 Christopher Faylor <cgf@cygnus.com>
9393
5e7eb909
CF
9394 * Makefile.in: Eliminate traces of cygwinisms. Don't link with
9395 libmsvcrt.a. It's unneeded. Build .rc file on the fly from various
9396 sources.
4306b490
CF
9397 * configure.in: Locate correct objcopy.
9398 * configure: Regenerate.
9399
739457f4
CF
9400Sat Apr 1 20:48:09 2000 Christopher Faylor <cgf@cygnus.com>
9401
9402 * Makefile.in: New file.
9403 * configure.in: New file.
9404 * configure: New file.
9405 * zlib/Makefile.am: New file.
9406 * zlib/configure.in: New file.
9407 * zlib/aclocal.m4: New file.
9408 * zlib/acinclude.m4: New file.
9409 * zlib/configure: Regenerate from configure.in.
9410 * zlib/Makefile.in: Regenerate from Makefile.am
8507f105
DD
9411
9412%%% $Id$
9413$Revision$
This page took 1.265431 seconds and 5 git commands to generate.