]> cygwin.com Git - cygwin-apps/setup.git/blame - ChangeLog
* site.cc (get_site_list): Use empty string if user settings
[cygwin-apps/setup.git] / ChangeLog
CommitLineData
ca09f44c
DK
12009-09-18 Dave Korn <dave.korn.cygwin@gmail.com>
2
3 * site.cc (get_site_list): Use empty string if user settings
4 return NULL pointer for cached mirrors list.
5 (SiteSetting::getSavedSites): Do nothing if user settings return
6 NULL pointer for last mirror URL.
7
83ab685b
CF
82009-08-21 Christopher Faylor <me+cygwin@cgf.cx>
9
10 * site.cc (SiteSetting::registerSavedSite): Fix comment.
11
0cbac692
CF
122009-07-03 Christopher Faylor <me+cygwin@cgf.cx>
13
14 * main.cc (set_cout): Don't reset stdout if we already have a stdout.
15
7411af0f
CF
162009-07-03 Christopher Faylor <me+cygwin@cgf.cx>
17
18 * choose.cc (ChooserPage::ChooserPage): Use more specific name for
19 saving window settings.
20 (ChooserPage::~ChooserPage): Ditto.
21
0baffe9a
DK
222009-07-01 Dave Korn <dave.korn.cygwin@gmail.com>
23
24 * PickView.h (PickView::total_delta_x): New int member.
25 (PickView::set_header_column_order): Add prototype.
26 * PickView.cc (PickView::set_header_column_order): New function,
27 broken out from ...
28 (PickView::set_headers): ... here. Call it.
29 (PickView::init_headers): Apply total_delta_x to last_col width.
30 (PickView::PickView): Initialise new total_delta_x member to zero.
31 (PickView::WindowProc): Use set_header_column_order to find and
32 adjust final column for both sets of headers.
33
ca2b7505
CF
342009-06-29 Christopher Faylor <me+cygwin@cgf.cx>
35
36 * SourceSetting.cc (SourceSetting::SourceSetting): Restore proper
37 remembrane of last source setting.
38 * choose.cc (ChooserPage::ChooserPage): Potentially retrieve dialog
39 placement info.
40 (ChooserPage::~ChooserPage): Save geometry settings if the user moved
41 or resized the page.
42 (ChooserPage::PlaceDialog): Rename from MaximizeDialog. Accommodate
43 changed user placement settings.
44 (ChooserPage::OnActivate): MaximizeDialog -> PlaceDialog.
45 (ChooserPage::OnNext): Ditto.
46 * choose.h (ChooserPage::~ChooserPage): Define.
47 (ChooserPage::cmd_show): Delete.
48 (ChooserPage::saved_geom): New field.
49 (ChooserPage::window_placement): Ditto.
50 (ChooserPage::pre_chooser_placement): Ditto.
51 (ChooserPage::PlaceDialog): Rename from MaximizeDialog.
52
7c863922
CF
532009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
54
55 * ConnectionSetting.cc (ConnectionSetting::ConnectionSetting): Remove
56 old code which no longer makes sense when run from a constructor.
57 * SourceSetting.cc (SourceSetting::SourceSetting): Ditto.
58 * localdir.cc (LocalDirSetting::LocalDirSetting): Ditto. Fix typo
59 which caused saved settings to be ignored.
60
127febea
CF
612009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
62
63 * UserSettings.cc (UserSettings::UserSettings): settings.rc -> setup.rc.
64
e36b0f1e
CV
652009-06-28 Corinna Vinschen <corinna@vinschen.de>
66
67 * desktop.cc (DesktopSetupPage::OnInit): Drop CoInitialize call here.
68 * main.cc (main_display): Use InitCommonControlsEx rather than
69 InitCommonControls per MSDN. Call CoInitializeEx and create IShellLink
70 instance here to workaround a problem on Windows 7. Release IShellLink
71 instance and call CoUninitialize on exit.
72 * mklink.cc (sl): Change to global variable. Drop call to
73 CoCreateInstance here. Check if sl is valid before using it.
74
f26f525f
CF
752009-06-27 Christopher Faylor <me+cygwin@cgf.cx>
76
77 Preliminary option handling revamp.
78 Throughout, change load/save methods to constructors/destructors which
79 use new UserSettings methods. Do not inherit from UserSetting class.
80 * KeysSetting.cc (ExtraKeysSetting *ExtraKeysSetting::global): Define.
81 (ExtraKeysSetting::ExtraKeysSetting): Initialize some class members use
82 new UserSettings methods.
83 (ExtraKeysSetting::~ExtraKeysSetting): Use new UserSettings method.
84 * Makefile.am (setup_SOURCES): Eliminate UserSetting.h and
85 UserSetting.cc.
86 * UserSettings.cc: Complete rewrite. Implements new UserSettings
87 class methods.
88 * UserSettings.h: Complete rewrite. Defines new UserSettings class
89 methods.
90 * crypto.cc (ExtraKeys): Delete.
91 (add_key_from_sexpr): Use ExtraKeysSetting::instance rather than
92 ExtraKeys.
93 (verify_ini_file_sig): Ditto.
94 * io_stream.h (io_stream): Define virtual << operators.
95 * localdir.cc (localDir): Delete.
96 * main.cc: Include headers which declar new dynamically invoked
97 classes.
98 (main_display): New function. Controls order of option setting and
99 property page setup. Add new class invocations to force option setting
100 initializtion.
101 (main): Invoke new UserSettings class constructor to populate new
102 settings class. Call main_display() to do most of the setup work.
103 Call Settings.save () to save all settings.
104 * net.cc (theSetting): Delete.
105 * site.cc (SiteSetting::save): Record whether we've saved the
106 information already.
107 (get_site_list): Just use value returned from new UserSettings method
108 rather than parsing a file.
109 (SiteSetting::getSavedSites): Ditto.
110 (write_cache_list): Use UserSettings operator to store mirror cache.
111 (save_cache_file): Ditto.
112 * source.cc (theSetting): Delete.
113
114 * win32.h: gcc-4 accommodation.
115
9d0a3d8a
DK
1162009-06-26 Dave Korn <dave.korn.cygwin@gmail.com>
117
118 * res.rc (SETUP_STANDARD_DIALOG_W, SETUP_STANDARD_DIALOG_H,
119 SETUP_SMALL_DIALOG_W, SETUP_SMALL_DIALOG_H): Add constant defines
120 for dialog sizes.
121 (SETUP_STANDARD_DIALOG_DIMS, SETUP_SMALL_DIALOG_DIMS): Add helper
122 macros for (W,H) pairs of dimensions.
123 (SETUP_HEADICON_X): New global constant define.
124 (IDD_SOURCE, IDD_VIRUS, IDD_LOCAL, IDD_ROOT, IDD_SITE, IDD_NET,
125 IDD_INSTATUS, IDD_PROXY_AUTH, IDD_NET_AUTH, IDD_DESKTOP,
126 IDD_FTP_AUTH DIALOG, IDD_DROPPED): Use the above for dialog sizes,
127 horizontal rules and icon positioning.
128 (SETUP_KPCE_W): New define for radio-button size.
129 (SETUP_VIEWCAP_W, SETUP_VIEWCAP_X, SETUP_VIEW_W, SETUP_VIEW_X,
130 SETUP_EXP_X, SETUP_CURR_X, SETUP_PREV_X, SETUP_KEEP_X): Add defines
131 for right-aligned controls.
132 (SETUP_SEARCH_X, SETUP_SEARCH_W, SETUP_SEARCHTEXT_X,
133 SETUP_SEARCHTEXT_W, SETUP_CLEAR_X, SETUP_CLEAR_W): Likewise defines
134 for left-aligned controls.
135 (IDD_CHOOSE): Use all the above, and reformat with whitespace
136 between args for clarity.
137
1789ef54
CV
1382009-06-26 Corinna Vinschen <corinna@vinschen.de>
139
140 * Makefile.am (setup_LDADD): Add -lshlwapi.
141 * PickView.cc: Include shlwapi.h.
142 (PickView::setViewMode): Compare package name with search string
143 case-insensitive.
144 (PickView::insert_category): Ditto.
145
557b4e65
CV
1462009-06-26 Corinna Vinschen <corinna@vinschen.de>
147
148 * script.cc (init_run_script): Don't set $HOME to /tmp. It breaks
149 mkpasswd -c.
150
46cf12cd
CV
1512009-06-25 Corinna Vinschen <corinna@vinschen.de>
152
153 * script.cc (init_run_script): Reinstantiate accidentally removed
154 setting of sh.
155
b56d411d
CF
1562009-06-22 Christopher Faylor <me+cygwin@cgf.cx>
157
158 * script.cc (init_run_script): Revert to initializing cmd based on OS
159 type.
160
c14feb84
CV
1612009-06-22 Corinna Vinschen <corinna@vinschen.de>
162
163 * script.cc (Script::run): Start bash without -c option.
164
00fa5f6c
CF
1652009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
166
167 * threebar.cc (ThreeBarProgressPage::ins_dialog): Move variable to more
168 appropriate class.
169 (ThreeBarProgressPage::MaximizeDialog): Move function to more
170 appropriate class.
171 (ThreeBarProgressPage::OnMessageApp): Remove MaximizeDialog calls.
172 * threebar.h: Remove maximize handling.
173 * choose.cc (ChooserPage::ins_dialog): New variable.
174 (ChooserPage::MaximizeDialog): New function.
175 (ChooserPage::ChooserPage): Remove unneeded handling of nCmdShow.
176 (ChooserPage::OnActivate): Maximize chooser page via MaximizeDialog.
177 (ChooserPage::OnNext): Revert chooser page to normal before returning.
178 * main.cc (main): Don't pass cmd_show to ChooserPage.
179 * propsheet.cc (PropSheetProc): Accommodate change in class for
180 SetHwndDialog.
181
5a85457b
CF
1822009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
183
184 * script.cc (shells): Delete.
185 (cmd): Just assign to "cmd.exe" since we're always running on NT now.
186 (sanitize_PATH ): New function.
187 (init_run_script): Ensure that we're only called once. Strip
188 environment of non-pertinent stuff. Call sanitize_PATH to remove
189 non-standard stuff from the PATH. Set up a few standard environment
190 variables.
191
b0bb51b4
CV
1922009-06-16 Corinna Vinschen <corinna@vinschen.de>
193
194 * mount.cc (create_install_root): Don't load mount table again.
195 (read_mounts_nt): Don't break loop, rather continue when not being
196 able to open "Cygwin" registry key.
197
ed1f007a
CF
1982009-06-03 Ralph Hempel <rhempel@bmts.com>
199
200 * source.cc: Add support for both -D and -L on the command line.
201
7cb7c06e
CV
2022009-06-03 Corinna Vinschen <corinna@vinschen.de>
203
204 * filemanip.cc (unlink): Rename from DeleteFileW. Take additional
205 parameter to indicate file type to unlink. Use in flags given to
206 NtCreateFile.
207 (DeleteFileW): Just call unlink from here with FILE_NON_DIRECTORY_FILE
208 flag.
209 (RemoveDirectoryW): Ditto with FILE_DIRECTORY_FILE flag.
210
1eb4caec
CW
2112009-05-30 Charles Wilson <cygwin@cwilson.fastmail.fm>
212
213 * script.cc (Script::run): Really start bash with --norc
214 --noprofile options.
215
b7940eb5
CV
2162009-05-13 Corinna Vinschen <corinna@vinschen.de>
217
218 * script.cc (Script::run): Start bash with --norc --noprofile options.
219
94f52d39
CV
2202009-05-13 Corinna Vinschen <corinna@vinschen.de>
221
222 * filemanip.cc (struct _FILE_RENAME_INFORMATION): Remove definition.
223 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Set
224 default permission for .exe files to 0755.
225 (io_stream_cygfile::mklink): Try to create real hardlink first. Add
226 comment.
227 * mklink2.cc (mkcyghardlink): New function to create real hardlink.
228 * mklink2.h (mkcyghardlink): Declare.
229 * mount.cc (from_fstab_line): Set got_usr_bin and got_usr_lib flags
230 if /usr/bin and /usr/lib mount points exist in /etc/fstab.
231 (add_usr_mnts): Only create mounts if corresponding got_usr_bin and
232 got_usr_lib flags are not set.
233 (read_mounts_nt): Initialize got_usr_bin and got_usr_lib to false.
234 Always call add_usr_mnts, even if from_fstab succeeded.
235 * ntdll.h: Include ddk/ntifs.h.
236
b4473ece
CV
2372009-05-12 Corinna Vinschen <corinna@vinschen.de>
238
239 * filemanip.cc (GetFileAttributesW): Add accidentally omited
240 OBJ_CASE_INSENSITIVE when creating OBJECT_ATTRIBUTES.
241 (SetFileAttributesW): Ditto.
242 (MoveFileW): Ditto.
243 (DeleteFileW): Ditto.
244 (RemoveDirectoryW): Ditto.
245 (nt_wfopen): Ditto.
246
e0fd9bd3
CF
2472009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
248
249 * localdir.cc (load_dialog): Choose description string based on install
250 type.
251 * res.rc (IDD_LOCAL_DIR): Replace static description text with
252 IDC_LOCAL_DIR_DESC.
253 * resource.h (IDS_LOCAL_DIR_DOWNLOAD): New string resource id.
254 (IDS_LOCAL_DIR_INSTALL): Likewise.
255 (IDC_LOCAL_DIR_DESC): New text control resource id.
256
2572009-05-11 Christopher Faylor <me+cygwin@cgf.cx>
258
259 * main.cc (set_cout): Simplify code a little.
260
18d74072
CV
2612009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
262
263 * choose.cc (ChooserPage::OnMessageCmd): Clear search filter when
264 clear button clicked.
265 * res.rc (IDD_CHOOSE_DIALOG): Add IDC_CHOOSE_CLEAR_SEARCH button.
266 * resource.h (IDC_CHOOSE_CLEAR_SEARCH): New button resource ID.
267
6dcfeb7d
CV
2682009-05-11 Corinna Vinschen <corinna@vinschen.de>
269
270 * UserSettings.cc (UserSettings::settingFileForLoad): Fix local load
271 path strings.
272 (UserSettings::settingFileForSave): Never store in cwd.
273 * autoload.c (ntdll): Autoload ntdll.dll functions here.
274 * desktop.cc (make_cygwin_bat): Use GetFileAttributesW rather than
275 _waccess. Use nt_wfopen instead of _wfopen.
276 (save_icon): Ditto.
277 * filemanip.cc (get_file_size): Call io_stream::open with empty mode
278 string to avoid opening file twice.
279 (GetFileAttributesW): New function to replace Win32 function with
280 equivalent function opening files with backup intent.
281 (SetFileAttributesW): Ditto.
282 (MoveFileW): Ditto.
283 (DeleteFileW): Ditto.
284 (RemoveDirectoryW): Ditto.
285 (nt_wfopen): New function to replace _wfopen with equivalent function
286 opening files with backup intent.
287 * filemanip.h (nt_wfopen): Declare.
288 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Initalize
289 lasterr to 0. Allow empty mode and don't open file, if so. Call
290 nt_wfopen rather than _wfopen.
291 (io_stream_cygfile::exists): Use GetFileAttributesW rather than
292 _waccess.
293 (io_stream_cygfile::get_size): Use CreateFileW/GetFileSize to get
294 file size on NT.
295 * io_stream_file.cc (io_stream_file::io_stream_file): Initalize lasterr
296 to 0. Allow empty mode and don't open file, if so. Call nt_wfopen
297 rather than _wfopen.
298 (io_stream_file::exists): Use GetFileAttributesW rather than _waccess.
299 (io_stream_file::remove): Don't try to remove non-existant file.
300 (io_stream_file::get_size): Use CreateFileW/GetFileSize to get
301 file size on NT. Add comment to keep track of 2GB border.
302 * mkdir.cc: Remove function pointers for ntdll functions.
303 (init_ntfuncs): Remove function.
304 (mkdir_p): Drop call to init_ntfuncs. Call ntdll functions directly
305 rather than over local function pointers.
306 * ntdll.h: New file.
307 * postinstall.cc (do_postinstall_reflector): Switch to admins group
ca2b7505 308 as primary group after postinstall scripts have been written.
6dcfeb7d
CV
309 Explain why.
310 (do_postinstall): Add comment.
311 * res.rc: Bump copyright date.
312 * win32.h (class TokenGroupCollection): Remove.
313 * win32.cc (TokenGroupCollection::populate): Remove.
314 (TokenGroupCollection::find): Remove.
315 (NTSecurity::setDefaultSecurity): Drop reading token groups. Just
316 try to switch to admins group as primary group.
317
4b47445f
CV
3182009-05-07 Corinna Vinschen <corinna@vinschen.de>
319
320 * package_db.cc (ConnectedLoopFinder::doIt): Revert patch from
321 2008-08-29. Add dumb hardcoded algorithm to make sure base-cygwin
322 and base-passwd are always the first packages in the postinstall
323 executable order.
324
8752dea2
CV
3252009-05-06 Corinna Vinschen <corinna@vinschen.de>
326
327 * install.cc (Installer::StandardDirs): Add /home with 1777 perms.
328 * main.cc (main): Drop setting $CYGWIN to nontsec.
329
059906b3
DK
3302009-04-24 Andrew Punch <andrew@magneticbooks.com.au>
331
332 * PickView.h: Add #include <string>.
333 (PickView::SetPackageFilter): Add new function.
334 (PickView::packageFilterString): Add new string data member.
335 * PickView.cc (PickView::setViewMode): Use it to filter names.
336 (PickView::insert_category): Likewise.
337 (PickView::PickView): Initialise packageFilterString to blank.
338 * res.rc (IDD_CHOOSE): Add IDC_CHOOSE_SEARCH_EDIT and
339 IDC_CHOOSE_SEARCH_LABEL controls.
340 (IDS_SEARCH_TOOLTIP): Add new string resource.
341 * resource.h (IDS_SEARCH_TOOLTIP): New string resource ID.
342 (IDC_CHOOSE_SEARCH_EDIT): New edit control ID.
343 (IDC_CHOOSE_SEARCH_LABEL): Mew static text control ID.
344 * choose.cc (ChooserControlsInfo[]): Add IDC_CHOOSE_SEARCH_LABEL
345 and IDC_CHOOSE_SEARCH_EDIT controls to auto-resize list.
346 (ChooserPage::OnInit): Add tooltip to search edit box.
347 (ChooserPage::OnMessageCmd): Handle EN_CHANGE event from
348 IDC_CHOOSE_SEARCH_EDIT.
349
6bfd5236
DK
3502009-04-24 Dave Korn <dave.korn.cygwin@gmail.com>
351
352 * propsheet.cc (PropSheetWndProc): Re-enable hasMinRect.
353
d29a864d
CV
3542009-04-23 Corinna Vinschen <corinna@vinschen.de>
355
356 * win32.h (NTSecurity::primaryGroupSID): Convert to a structure for
357 direct usage in GetTokenInformation.
358 (NTSecurity::osid): Remove.
359 (NTSecurity::setAdminGroup): Declare.
360 * win32.cc (NTSecurity::resetPrimaryGroup): Accommodate change to
361 primaryGroupSID. Add log output.
362 (NTSecurity::setAdminGroup): New method.
363 (NTSecurity::setDefaultSecurity): Use local structures for getting
364 TOKEN_USER and setting TOKEN_OWNER information. Accommodate change to
365 primaryGroupSID. Slightly enhance log output.
366 Only set primary group to Administrators group when installing for
367 all users. Call setAdminGroup to do it.
368
770e3aed
CV
3692009-04-22 Corinna Vinschen <corinna@vinschen.de>
370
371 * mklink2.cc (mkcygsymlink_nt): Allow 4K chars in symlink. Use strncat
372 rather than strcat.
373 * postinstall.cc (do_postinstall): Reset user token to original
374 primary group.
d29a864d 375 * win32.cc (NTSecurity::resetPrimaryGroup): New method.
770e3aed
CV
376 (NTSecurity::setDefaultSecurity): Store original primary group in
377 new NTSecurity member primaryGroupSID. Set primary group in user token
378 to Administrators group for admin users. Align comment.
379 * win32.h (class NTSecurity): Add member primaryGroupSID.
380 (NTSecurity::resetPrimaryGroup): Declare.
381
a03b43ad
CF
3822009-04-09 Christopher Faylor <me+cygwin@cgf.cx>
383
384 * main.cc (set_cout): Load AttachConsole dynamically to avoid using it
385 on older Windows which don't support it.
386
c8356810
CF
3872009-03-21 Christopher Faylor <me+cygwin@cgf.cx>
388
389 * LogFile.cc (LogFile::endEntry): Output messages to stdout.
390 * main.cc (set_cout): New function. Sets stdout to console if one
391 exists.
392 (main): Redirect stdout to console if unattended_mode or help option is
393 specified and no stdout is available.
394
3952009-03-21 Terry Fleming <terrynfleming@gmail.com>
396 Christopher Faylor <me+cygwin@cgf.cx>
397
398 * propsheet.cc (PropSheetWndProc): Detect a Window closing event and
399 issue an "Are you sure" message.
400
a2488a3c
CV
4012008-08-29 Corinna Vinschen <corinna@vinschen.de>
402
403 * package_db.cc (ConnectedLoopFinder::doIt): Add code to get a basic
404 order into the dependency list. Add comment to explain why.
405
ef3be327
BD
4062008-08-22 Brian Dessent <brian@dessent.net>
407
408 * KeysSetting.cc: Include string.h for memcpy et al.
409 * filemanip.cc: Include stdlib.h for for mbstowcs.
410 * io_stream_cygfile.h: Update cygmkdir_p prototype for mode_t.
411 * mount.cc (conv_fstab_spaces): Silence gcc 4.3 warning ("parentheses
412 around assignment used as truth value").
413
e0a4fb63
CV
4142008-08-20 Corinna Vinschen <corinna@vinschen.de>
415
416 * install.cc (Installer::StandardDirs): Additionally create /var/log
417 dir. Set mode of /var/log and /var/run to 01777.
418 * localdir.cc (LocalDirSetting::save): Create /var/log with 01777
419 permissions before creating setup.log files.
420
be617b59
CV
4212008-08-20 Corinna Vinschen <corinna@vinschen.de>
422
423 * io_stream_cygfile.cc (io_stream_cygfile::set_mtime_and_mode):
424 Accommodate SetPosixPerms being method of nt_sec.
425 * mkdir.cc (mkdir_p): Ditto.
426 * mklink2.cc (mkcygsymlink_nt): Ditto.
427 * win32.cc: Slightly rearrange.
428 (NTSecurity::SetPosixPerms): Make SetPosixPerms method of NTSecurity
429 rather than stand-alone function. Remove dynamic allocation for
430 security descriptors in favor of static allocation. Drop out
431 preliminary if well-known SIDs are not initialized. Slightly change
432 and rearrange comments. Add creating NULL SID ACE for special
433 permissions.
434 (NTSecurity::initialiseWellKnownSIDs): New function, replacing
435 NTSecurity::initialiseEveryOneSID. Initialize all well-known SIDs
436 here. Set wellKnownSIDsinitialized to true on success.
437 (NTSecurity::setDefaultDACL): Don't call initialiseEveryOneSID. Change
438 comment. Drop setting failed. Don't open process token here.
439 (NTSecurity::setBackupPrivileges): New function.
440 (NTSecurity::setDefaultSecurity): Call initialiseWellKnownSIDs.
441 Open process token here. Disable setting primary group. Add comment
442 to explain why.
443 * win32.h (SetPosixPerms): Move to NTSecurity.
444 (class NTSecurity): Add SetPosixPerms method. Make all SIDs private
445 again. Make NoteFailedAPI private. Add setBackupPrivileges method.
446 Rename usid to UsersSID. Remove failed method and _failed member.
447 Add wellKnownSIDsinitialized accessors and _wellKnownSIDsinitialized
448 member.
449
b41c2908
CV
4502008-08-19 Corinna Vinschen <corinna@vinschen.de>
451
452 * install.cc (struct std_dirs_t): New type.
453 (class Installer): Change type of StandardDirs to std_dirs_t.
454 (Installer::StandardDirs): Store filename and mode.
455 (do_install_thread): Call io_stream::mkpath_p with name and mode from
456 Installer::StandardDirs.
457 * main.cc (main): Call setDefaultSecurity on global nt_sec.
458 * IOStreamProvider.h (IOStreamProvider::mkdir_p): Add mode parameter.
459 * LogFile.cc (LogFile::log_save): Call io_stream::mkpath_p with 0755
460 mode.
461 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
462 * desktop.cc (make_link): Ditto.
463 * download.cc (download_one): Ditto.
464 * ini.cc (do_remote_ini): Ditto.
465 (do_ini_thread): Ditto.
466 * package_db.cc (packagedb::flush): Ditto.
467 * archive.cc (archive::extract_file): Ditto. Call set_mtime_and_mode
468 with mode from archive. Add code to handle directory permissions as
469 well.
470 * archive_tar.cc (archive_tar::get_mtime): Return time_t. Reformat.
471 (archive_tar::get_mode): New method.
472 * archive_tar.h (class archive_tar_file): Fix prototypes. Replace
473 prototype for set_mtime with prototype for set_mtime_and_mode.
474 (class archive_tar): Ditto.
475 * archive_tar_file.cc (archive_tar_file::get_mtime): Return time_t.
476 (archive_tar_file::get_mode): New method returning mode from tar header.
477 * compress_bz.cc (compress_bz::set_mtime_and_mode): Replace set_mtime.
478 (compress_bz::get_mtime): Return time_t.
479 (compress_bz::get_mode): New function.
480 * compress_gz.cc: Ditto.
481 * compress_lzma.cc: Ditto.
482 * io_stream.cc (io_stream::mkpath_p): Take additional file mode.
483 Call mkdir_p with additional file mode.
484 * io_stream_cygfile.cc (CygFileProvider::mkdir_p): Take additional file
485 mode.
486 (cygmkdir_p): Ditto. Call mkdir_p with additional file mode.
487 (io_stream_cygfile::set_mtime_and_mode): Replace set_mtime. Call
488 SetPosixPerms.
489 * io_stream_file.cc (FileProvider::mkdir_p): Take additional file mode.
490 (io_stream_file::set_mtime_and_mode): Replace set_mtime.
491 * mkdir.cc (init_ntfuncs): New function to initialize function pointers
492 from ntdll.dll.
493 (mkdir_p): Take additional file mode. On NT, use NT functions to create
494 directory. Call SetPosixPerms.
495 * compress_bz.h: Change prototypes accordingly.
496 * compress_gz.h: Ditto.
497 * compress_lzma.h: Ditto.
498 * io_stream.h: Ditto.
499 * io_stream_cygfile.h: Ditto.
500 * io_stream_file.h: Ditto.
501 * io_stream_memory.h: Ditto.
502 * mkdir.h: Ditto.
503 * mklink2.cc (mkcygsymlink_nt): Open file with STANDARD_RIGHTS_ALL
504 access and FILE_FLAG_BACKUP_SEMANTICS flag. Call SetPosixPerms.
505 * mount.cc (from_fstab): Open file with FILE_FLAG_BACKUP_SEMANTICS.
506 * script.cc (OutputLog::OutputLog): Call io_stream::mkpath_p with 0755
507 mode. Open file with FILE_FLAG_BACKUP_SEMANTICS.
508 * win32.cc (SetPosixPerms): New function to set POSIX-like permissions.
509 (nt_sec): New global NTSecurity variable.
510 (NTSecurity::setDefaultDACL): Open token with TOKEN_ADJUST_PRIVILEGES.
511 (NTSecurity::setDefaultSecurity): Enable SE_BACKUP_NAME and
512 SE_RESTORE_NAME privileges if available.
513 * win32.h (SetPosixPerms): Add prototype.
514 (class NTSecurity): Make everyOneSID and administratorsSID public.
515 (nt_sec): Declare.
516
65288dc7
CV
5172008-08-14 Corinna Vinschen <corinna@vinschen.de>
518
519 * mount.cc (unconvert_slashes): New inline function.
520 (skip_ws): New inline function.
521 (find_ws): New inline function.
522 (conv_fstab_spaces): New inline function.
523 (from_fstab_line): New function to read single line from fstab file.
524 (from_fstab): New function to read /etc/fstab file and fill mount
525 table.
526 (read_mounts_nt): Call from_fstab after getting setup/rootdir from
527 registry. Only call add_usr_mnts if no fstab file found.
528
1ae1adf7
CV
5292008-08-13 Corinna Vinschen <corinna@vinschen.de>
530
531 * install.cc (Installer::installOne): Skip 46 bytes type tar package
532 silently.
533
53d33c5d
CV
5342008-08-13 Corinna Vinschen <corinna@vinschen.de>
535
536 * install.cc (Installer::installOne): Use MoveFileExW on NT. Special
537 case for bug in Windows 2000.
538 * package_meta.cc (packagemeta::uninstall): Use wide char file functions
539 on NT.
540 * win32.h (VersionInfo::major): New method.
541 (VersionInfo::minor): New method.
542 (OSMajorVersion): Define.
543 (OSMinorVersion): Define.
544
2f0315ad
CV
5452008-08-12 Corinna Vinschen <corinna@vinschen.de>
546
547 Revamp for Cygwin 1.7.
548 * desktop.cc (make_cygwin_bat): Use wide char file functions on NT.
549 (save_icon): Ditto.
550 * filemanip.cc (tfx_chars): New char table for wide char transformation
551 of reserved FS chars to UNICODE private use area.
552 (transform_chars): New static function.
553 (mklongpath): New function to convert multibyte path to wide char
554 path with long path prefix.
555 * filemanip.h (mklongpath): Declare.
556 * ini.h (SETUP_INI_FILENAME): Use setup.ini filenames as defined in
557 real life (setup-2.ini/setup.ini).
558 (SETUP_BZ2_FILENAME): Ditto.
559 * install.cc (do_install_thread): Don't create registry mount points
560 on NT, rather create setup/rootdir entry.
561 * io_stream_cygfile.cc: Throughout use wide char file functions on NT.
562 (io_stream_cygfile::w_str): New method to create wide char path.
563 * io_stream_cygfile.h (class io_stream_cygfile): Remove lmode member.
564 Add wname member and w_str method.
565 * io_stream_file.cc: Throughout use wide char file functions on NT.
566 (io_stream_file::w_str): New method to create wide char path.
567 * io_stream_file.h (class io_stream_file): Remove lmode member.
568 Add wname member and w_str method.
569 * mkdir.cc (mkdir_p): Use wide char file functions on NT.
570 * mklink2.cc (mkcygsymlink_9x): Rename from mkcygsymlink. Make static.
571 (mkcygsymlink_nt): New static function.
572 (mkcygsymlink): Just call mkcygsymlink_9x or mkcygsymlink_nt dependent
573 on OS.
574 * mount.cc (CYGWIN_INFO_CYGWIN_SETUP_REGISTRY_NAME): Define.
575 (remove1): Move to earlier point in file to avoid declaration.
576 (remove_mount): Ditto. Make static.
577 (create_install_root): New function to create setup/rootdir registry
578 value on NT.
579 (read_mounts_9x): Rename from read_mounts. Make static. Conditionalize
580 for OS.
581 (add_usr_mnts): New static function.
582 (read_mounts_nt): Ditto, to read mounts on NT.
583 (read_mounts): Just call read_mounts_nt or read_mounts_9x dependent on
584 OS.
585 (set_root_dir): On NT, call read_mounts.
586 (cygpath): Only add slash for non-root mount to avoid multiple slashes
587 in resulting path (invalid in long path names).
588 * mount.h (find_mount): Drop declaration.
589 (remove_mount): Ditto.
590 (create_install_root): Add declaration.
591 (read_mounts): Accommodate new parameter.
592 * package_db.cc (chosen_db_task): New global variable.
593 * package_db.h (chosen_db_task): Declare.
594 * root.cc (check_if_enable_next): Don't use get_root_dir here to
595 avoid having to call save_dialog in RootPage::OnMessageCmd.
596 (GetDlgItemRect): New static inline function.
597 (SetDlgItemRect): Ditto.
598 (load_dialog): On NT, stretch "Install For" block to full dialog width
599 and hide "Default Text File Type" block.
600 (save_dialog): On NT set root_text always to IDC_ROOT_BINARY.
601 (RootPage::OnMessageCmd): Remove call to save_dialog.
602 (RootPage::OnNext): Initialize packagedb here the first time, to
603 avoid fetching wrong data from different previous installation.
604 * source.cc (save_dialog): Don't initialize packagedb here, rather
605 just memorize setting in chosen_db_task for the deferred initialization
606 in RootPage::OnNext.
607
0407753c
DK
6082008-08-07 Dave Korn <dave.korn.cygwin@gmail.com>
609
610 Implement command-line selection of packages to install and make
611 unattended mode deal with any dialogs that might arise. A joint
612 effort synthesized from contributions by:
613
614 Dr. Frank Lee <rl201@cam.ac.uk>
615 Bryan Thrall <bryan.thrall@flightsafety.com>
616 Kohsuke Kawaguchi <kk@kohsuke.org>
617 Dave Korn <dave.korn.cygwin@gmail.com>
618
619 * install.cc (rebootneeded): Don't define statically here.
620 (do_install_thread): Let exit_msg reflect rebootneeded.
621 * main.cc (main): If rebootneeded, log it when exiting.
622 * msg.cc (mbox): In unattended_mode, choose and log default answer.
623 * package_db.cc (packagedb::fillMissingCategory): Iterate over all
624 packages adding those selected by packagemeta::isManuallyWanted to
625 base category so that command-line selections are installed.
626 * package_meta.cc (PackageOption): Add new StringOption to allow
627 command-line selection of packages to add to base install.
628 (packagemeta::isManuallyWanted): New function tests if package was
629 selected on command-line.
ca2b7505 630 (packagemeta::addToCategoryBase): New function adds package to
0407753c
DK
631 "base" category.
632 * state.cc (rebootneeded): Define here non-static.
633 * state.h (rebootneeded): Declare here with extern linkage.
634 * threebar.cc (ThreeBarProgressPage::MaximizeDialog): Don't change
635 size when running in unattended mode.
636
da60e4b2
CF
6372008-08-05 Christopher Faylor <me+cygwin@cgf.cx>
638
639 * UserSettings.cc (UserSettings::settingFileForLoad): Look locally for
640 settings before looking outside of current directory.
641 * choose.cc (ChooserPage::ChooserPage): Record the property sheet's
642 current show state via new passed in parameter.
643 * choose.h (ChooserPage::ChooserPage): Reflect change in argument list.
644 (ChooserPage::nCmdShow): Define new element.
645 * main.cc (main): Send current show state to Chooser.
646 * package_version.cc (packageversion::set_requirements): Increase
647 recursion check from 5 to 30.
648 * propsheet.cc (PropSheetWndProc): Register hwndDlg with
649 ThreeBarProgressPage.
650 * threebar.cc (ControlAdjuster::ControlInfo): Initialize cmd_show_set.
651 (ThreeBarProgressPage::MaximizeDialog): New function.
652 (ThreeBarProgressPage::OnMessageApp): Call MaximizeDialog to maximize
653 package selection screen and restore when done.
654 * threebar.h (ThreeBarProgressPage::MaximizeDialog): Declare function.
655 (ThreeBarProgressPage::cmd_show_set): Declare variable.
656 (ThreeBarProgressPage::cmd_show): Declare variable.
657 (ThreeBarProgressPage::ins_dialog): Declare variable.
658 (ThreeBarProgressPage::SetHwndDialog): Define function.
659
5bb88929
CW
6602008-07-22 Charles Wilson <cygwin@cwilson.fastmail.fm>
661
662 Add support for .tar.lzma files (decompress only).
663
664 * Makefile.am: Add new files.
665 * compress.cc (compress::decompress): add support
666 for compress_lzma.
667 * compress_lzma.h: new file.
668 * compress_lzma.cc: new file.
669 * filemanip.cc (find_tar_ext): add support for
670 .tar.lzma files.
671 * install.cc (Installer::installOne): update comments.
672 * lzma-sdk/LzmaDec.h: new file.
673 * lzma-sdk/LzmaDec.c: new file.
674 * lzma-sdk/Types.h: new file.
675
5bc84ff1
CW
6762008-07-08 Charles Wilson <cygwin@cwilson.fastmail.fm>
677
678 * compress.cc (compress::decompress): clean up concrete
679 decompressor objects on failure -- but in that case, do
680 NOT destroy original io_stream.
681 * compress_bz.h (compress_bz::release_original): new method.
682 (owns_original): new member variable.
683 * compress_bz.cc (compress_bz::release_original): new method.
684 (compress_bz::compress_bz): take ownership of parent by default.
ca2b7505 685 (compress_bz::~compress_bz): only delete original if
5bc84ff1
CW
686 owns_original is true.
687 * compress_gz.h (compress_gz::release_original): new method.
688 (owns_original): new member variable.
689 * compress_gz.cc (compress_gz::release_original): new method.
690 (compress_gz::construct): take ownership of parent by default.
ca2b7505 691 (compress_gz::~compress_gz): only delete original if
5bc84ff1
CW
692 owns_original is true.
693
fe25359c
DK
6942008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
695
696 * configure.in, gpg-error-config-fake: Revert previous removal.
697
586f2b08
DK
6982008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
699
700 * net.cc: Correct stray CRLF.
701
8f016701
DK
7022008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
703
704 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Remove nasty hack.
705 * gpg-error-config-fake: Delete file obsoleted by de-hackification.
706
1cc1fad4
CF
7072008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
708
709 * configure.in: Disable shared library builds.
710
be6622c0
CF
7112008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
712
713 * Makefile.am: Make and install libraries into common location and use
714 them from there.
715 * configure.in: Find gpg-error-config in the libgpg-error/src
716 subdirectory rather than using the host system's version. Set the
717 prefix and exec_prefix to a common location for the subdirs so that
718 useful files will be installed in a common location.
719
dbfe3c19
DK
7202008-06-22 Dave Korn <dave.korn.cygwin@gmail.com>
721
be6622c0
CF
722 Merged across diffs between setup_crypto_branch_branchpoint and
723 setup_crypto_branch_mergepoint2 from setup_crypto_branch.
dbfe3c19
DK
724
725 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
726 KeysSetting.h, gpg-error-config-fake, cygwin.pub, cyg-pubkey.h,
be6622c0 727 gpg-key-to-s-expr.sh: New files.
dbfe3c19 728 * ini.cc, ini.h, resource.h, res.rc, netio.cc, Makefile.am,
be6622c0 729 configure.ac, libgetopt++/src/OptionSet.cc: Modified files.
dbfe3c19
DK
730
731 2008-06-21 Dave Korn <dave.korn.cygwin@gmail.com>
732
ca2b7505 733 * ini.cc (do_remote_ini): Revert misbegotten removal of
dbfe3c19
DK
734 not-always-superfluous-after-all added slash in URLs.
735
736 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
737
738 * gpg-packet.h (GPG_KEY_SEXPR_BUF_SIZE): Move from here ...
739 * crypto.h (GPG_KEY_SEXPR_BUF_SIZE): ... to here.
740 (GPG_KEY_MAX_COEFF_SIZE): Add related definition.
741
742 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
743
744 * gpg-packet.cc (walk_packets_1): Check packet length field is
745 valid sane and possible to avoid malicious manipulation.
746 * ChangeLog: Corrected date on previous commit.
747
748 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
749
ca2b7505 750 * crypto.cc (add_key_from_sexpr): Use real buffer size, not debug
dbfe3c19
DK
751 constant size.
752
753 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
754
755 * crypto.cc (verify_ini_file_sig): Actually set init-once flag!
756
757 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
758
759 * crypto.cc (KeepUntrustedKeysOption): Fix helpstring punctuation.
760
761 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
762
763 * crypto.cc (verify_ini_file_sig): Fix two minor logic errors.
764
765 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
766
767 * ini.h (current_ini_sig_name): Declare extern.
768 * ini.cc (current_ini_sig_name): New variable.
769 (NoVerifyOption): New boolean option.
770 (do_remote_ini): If sig verification not disabled, attempt to
771 download the matching sig file for any setup.bz2 or setup.ini
772 and use it to verify or discard the download.
773
774 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
775
776 * resource.h (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Reserve IDs for
777 two new message strings.
778 * res.rc (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Define the text.
779
780 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
781
782 * Makefile.am (setup_SOURCES): Add new files crypto.cc, crypto.h,
783 cyg-pubkey.h, gpg-packet.cc, gpg-packet.h. KeysSetting.cc and
784 KeysSetting.h to the build.
785 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
786 KeysSetting.h: New files. Adds gpg sig verification support.
787
788 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
789
790 * Makefile.am (DIST_SUBDIRS, SUBDIRS): Add libgpg-error and
791 libgcrypt subdirs.
792 (AM_CPPFLAGS): Add -I paths to generated headers in both and to
793 shipped headers in libgcrypt.
794 (setup_LDADD): Add libgpg-error.a and libgcrypt.a to final link.
795
796 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Preload into cache
797 to fake out libgcrypt configure process.
798 (AC_CONFIG_SUBDIRS): Add libgpg-error/ and libgcrypt/
799
800 * gpg-error-config-fake: New shell script to redirect libgcrypt
801 sub-configure into looking for newly-built libgpg-error.
802
803 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
804
805 * setup/libgpg-error/: Fresh import of upstream sources of
806 libgpg-error-1.6.tar.bz2 from http://www.gnupg.org/
807 * setup/libgcrypt/: Fresh import of upstream sources of
808 libgcrypt-1.4.1.tar.bz2 from http://www.gnupg.org/
809
810 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
811
812 * netio.cc (NetIO::set_url): Avoid double-free bug on delete
813 by setting path to a strdup of url rather than using the same
814 pointer value twice.
815
816 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
817
818 * cygwin.pub: Add reference copy of Cygwin setup signing key.
819 * gpg-key-to-s-expr.sh: New bash script. Outputs textual
820 representation of public key in s-expr format.
821 * cyg-pubkey.h: New header generated by the above from Cygwin
822 setup signing key. Currently needs manual regeneration if key
823 ever updated.
824
2cae901b
BD
8252008-04-16 Brian Dessent <brian@dessent.net>
826
827 * mount.cc: Include malloc.h.
828 (is_admin): Use alloca instead of a VLA in case
829 GetTokenInformation is sensitive to alignment.
830
784414bf
BD
8312008-04-15 Brian Dessent <brian@dessent.net>
832
833 * mount.cc (is_admin): Get explicit size of required buffer by
834 calling GetTokenInformation first with NULL.
835
9d44d4f7
BD
8362008-04-10 Brian Dessent <brian@dessent.net>
837
838 * Makefile.am (setup_LDFLAGS): Make sure static libbz2 and zlib
839 are used.
840
1db74bf0
BD
8412008-04-09 Brian Dessent <brian@dessent.net>
842
843 * README: flex and bison are required when building from CVS.
844
09aa7d89
BD
8452008-04-08 Brian Dessent <brian@dessent.net>
846
847 * Makefile.am (snapshot): Provide default value of ${cygwinsite}
848 if not set.
849
60dfa7aa
BD
8502008-04-08 Brian Dessent <brian@dessent.net>
851
852 * Makefile.am (release): Use -f so that "make release" works
853 when existing binaries of the same name exist.
854
33ef69a7
BD
8552008-04-08 Brian Dessent <brian@dessent.net>
856
857 * res.rc (IDD_SPLASH): Update copyright years on splash page.
858
51325df5
BD
8592008-04-08 Brian Dessent <brian@dessent.net>
860
861 * CHANGES: Update.
862 * install.cc (Installer::installOne): Cope with compressed
863 0-byte dummy packages. Fix progress bar update bug introduced
864 in earlier refactoring.
865
2e0aaec9
BD
8662008-04-08 Brian Dessent <brian@dessent.net>
867
868 * CHANGES: Update.
869
8702008-04-08 Brian Dessent <brian@dessent.net>
871
872 Various warning/header cleanups necessary for clean gcc 4.3 build.
873 * ConnectionSetting.cc: Include stdlib.h.
874 * LogFile.cc: Ditto.
875 * Makefile.am: Don't hardcode paths to MinGW libz and libbz2.
876 * PickView.cc: Include limits.h.
877 * String++.cc: Include string.h.
878 * archive_tar.cc (archive_tar::next_file_name): Silence nested-if
879 warning.
880 * autoload.c: Switch back to .text section before emiting
881 autoload_common.
882 * choose.cc: Include stdlib.h and algorithm.
883 * compress_gz.cc: Include memory.h and malloc.h.
884 * filemanip.cc: Include string.h.
885 (parse_filename): Silence nested-if warning.
886 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Silence warning.
887 * package_db.cc: Include algorithm.
888 * site.cc (get_site_list): Silence warning.
889 * win32.cc: Include memory.
890 * csu_util/MD5Sum.cc: Include string.h.
891
d0355815 8922008-03-02 Dave Korn <dave.korn@artimi.com>
4e6c8d9e 893
d0355815 894 * install.cc (Installer::installOne): Accept new HWND argument
4e6c8d9e
DK
895 from caller and pass it to MessageBox calls so that MB_TASKMODAL
896 can work.
897 (check_for_old_cygwin): Likewise.
898 (do_install_thread): Pass owner's HWND (from thread context) when
899 calling them.
900
84ea7bd6
DK
9012008-02-23 Dave Korn <dave.korn@artimi.com>
902
903 * cygpackage.cc (cygpackage::getfirstfile): Guard against trying to
904 construct std::string from NULL returned by io_stream::gets when the
905 stream decompressor fails on a corrupt *.lst.gz file.
906
22ade75c
DK
9072008-02-21 Dave Korn <dave.korn@artimi.com>
908
909 * geturl.cc (progress): Correct SI unit notation.
910
b612bff1
DK
9112008-02-01 Vincent Privat <vincent.privat@gmail.com>
912
913 * net.cc (OnInit): New StringOption (ProxyOption)
914 This new option (-p) allows to call setup.exe with a proxy
915 in its command-line arguments.
916
a81fbc25
BD
9172007-07-31 Brian Dessent <brian@dessent.net>
918
919 * ini.cc (do_remote_ini): Fix crash due to double free of ini_file.
920
92ef6cf8
BD
9212007-07-30 Brian Dessent <brian@dessent.net>
922
923 * CHANGES: Update.
924 * configure.in (AM_INIT_AUTOMAKE): Enable more automake warnings.
925 * Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
926 (CLEANFILES): Add. Minor portability tweaks.
927 * tests/Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
928 * archive.cc (archive::extract): Try to be more compatible when
929 opening tar files.
930 * compress_bz.cc: Fix whitespace throughout.
931 (compress_bz::~compress_bz): Ensure that underlying io_stream's dtor is
932 also run.
933 * install.cc (Installer::installOne): Refactor.
934 * package_db.cc (ConnectedLoopFinder::doIt): Move some log spewage into
935 setup.log.full from setup.log.
936 (packagedb::connectedBegin): Ditto. Consolidate log output to one line.
937
0a0203db
BD
9382007-07-02 Brian Dessent <brian@dessent.net>
939
940 * CHANGES: Update.
941
475ee6a3
BD
9422007-06-26 Brian Dessent <brian@dessent.net>
943
944 * Makefile.am (release): Drop inconsistent use of $(EXEEXT). Leave an
945 untouched copy of setup.exe so that later make invocations don't
946 unnecessarily rebuild it.
947 (snapshot): Fix typo.
948 * install.cc (md5_one): Don't try to check packages whose
949 pkgsource.Cached () is NULL, as with those whose download failed.
950
12dea33a
BD
9512007-06-26 Brian Dessent <brian@dessent.net>
952
953 * CHANGES: Update to reflect release branch.
954
9552007-06-26 Brian Dessent <brian@dessent.net>
812cdd92
BD
956
957 * CHANGES: Make current.
958
feee2f2b
BD
9592007-05-30 Brian Dessent <brian@dessent.net>
960
961 * find.h (class Find): Make _start_dir non-const.
962 * find.cc (Find::Find): Append a trailing slash to _start_dir only if
963 it does not already contain one.
964 (Find::accept): Use the previously stored value of _start_dir rather
965 than unconditionally appending a slash.
966
b941c8be
BD
9672007-05-29 Brian Dessent <brian@dessent.net>
968
969 * Makefile.am: No need to specify the default value of --preprocessor
970 to windres. Rework the automatic version extraction rules so that the
971 source tarball is generated with the proper name and directory instead
972 of setup-0. Update snapshot rule to also upload a copy of the binary
973 with debugging symbols still present.
974
dacb1ebd
BD
9752007-05-29 Brian Dessent <brian@dessent.net>
976
977 This is a general tidying up/modernization of the build infrastructure.
978 Renaming the lexer and parser to .ll and .yy allows using automake's
979 builtin support for flex and bison with C++ sources, and libinilex is a
980 slightly cleaner way of omitting -Werror.
981
982 * Makefile.am (AUTOMAKE_OPTIONS): Move to AM_INIT_AUTOMAKE.
983 (AM_YFLAGS): Define.
984 (AM_LFLAGS): Define.
985 (INCLUDES): Remove redundant mingw directory.
986 (EXTRA_DIST): Adjust for newly named lexer/parser.
987 (BUILT_SOURCES): Ditto.
988 (inilint_LDADD): Ditto.
989 (inilint_SOURCES): Ditto.
990 (setup_LDADD): Ditto.
991 (setup_SOURCES): Ditto.
992 (iniparse.cc): Remove custom rules.
993 (inilex.cc): Ditto.
994 * configure.in: Update quoting and use modern form of AC_INIT and
995 AM_INIT_AUTOMAKE.
996 * inilex.l: Rename from this ...
997 * inilex.ll: ... to this.
998 * iniparse.y: Rename from this ...
999 * iniparse.yy: ... to this.
1000
eb20d728
BD
10012007-05-29 Brian Dessent <brian@dessent.net>
1002
1003 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
1004 Remove error_buf and error_count initializers.
1005 (IniParseFindVisitor::visitFile): Store filename in current_ini_name.
1006 Use yyerror_count and yyerror_messages in place of removed error_count
1007 and error_buf members.
1008 * IniParseFindVisitor.h (class IniParseFindVisitor): Remove error_buf
1009 and error_count members.
1010 * ini.cc: Include io_stream_memory.h. Remove file static variables
1011 error_buf, error_count, and ini_filename.
1012 (GuiParseFeedback::progress): Remove some verbose log spam.
1013 (do_remote_ini): Recode .ini-fetching logic to properly display parse
1014 errors, and to account for corrupt bzip2 files.
1015 (yyerror): Moved elsewhere.
1016 (fprintf): Delete unused function.
1017 * ini.h: Remove useless __cplusplus guard. Declare extern variables
1018 current_ini_name, yyerror_messages, and yyerror_count.
1019 * inilex.l: Add current_ini_name, yyerror_messages, and
1020 yyerror_count.
1021 (ini_init): Initialize new variables.
1022 (yybol): Delete.
1023 (yyerror): Reimplement using std::string and relocate from ini.cc.
1024 * io_stream.cc (io_stream::copy): Add clarifying comment.
1025
6c8daadf
IP
10262007-05-04 Igor Peshansky <pechtcha@cs.nyu.edu>
1027
1028 * resource.h (IDC_STATIC_HEADER): New control id.
1029 * res.rc (IDD_SPLASH): Adjust the copyright.
1030 (IDD_DESKTOP): Make header text accessible as a separate control.
1031 * desktop.cc (set_status): Use eset() instead of SetWindowText().
1032 (load_dialog): Disable checkboxes and change dialog text in
1033 download-only mode.
1034 (DesktopSetupPage::OnInit): Disable checkboxes in download-only
1035 mode.
1036 * threebar.cc (ThreeBarProgressPage::OnMessageApp): Deprecate the
1037 default fallthrough.
1038 * download.cc (do_download_thread): Explicitly return the next
1039 dialog.
1040
f8dcce01
MB
10412007-04-19 Max Bowsher <maxb1@ukf.net>
1042
1043 * configure.in: Turn inilint default build off again, since I cannot
1044 get it to work.
1045
6b457e67
MB
10462007-04-19 Max Bowsher <maxb1@ukf.net>
1047
54ac354e
MB
1048 * configure.in: Make inilint built by default.
1049
10502007-04-19 Max Bowsher <maxb1@ukf.net>
1051
1052 * inilintmain.cc: Fix multiple compile errors.
6b457e67 1053
86e53214
MB
10542007-04-19 Max Bowsher <maxb1@ukf.net>
1055
1056 * Makefile.am: Make inilint use same warnonly-inilex workaround that
1057 setup already does.
1058
7b21a88e
IP
10592007-03-29 Igor Peshansky <pechtcha@cs.nyu.edu>
1060
1061 * LogFile.cc (LogFile::exit): Write exit_msg directly to log, without
1062 the message box.
1063 * resource.h (IDC_DESKTOP_SEPARATOR,IDC_STATUS_HEADER,IDC_STATUS): New
1064 control ids.
1065 * res.rc (IDD_DESKTOP): Change the caption. Add status information.
1066 * desktop.h (DesktopSetupPage::DesktopSetupPage): Define constructor
1067 in the implementation.
1068 * desktop.cc (DesktopControlsInfo): Position specifiers for status
1069 information items.
1070 (DesktopSetupPage::DesktopSetupPage): Register position specifiers.
1071 (set_status): New static method.
1072 (load_dialog): Set status information, if available.
1073 (DesktopSetupPage::OnInit): Set status header font.
1074
909f5cf9
BD
10752007-03-01 Brian Dessent <brian@dessent.net>
1076
1077 * ini.h (SETUP_INI_FILENAME): Rename setup_9x.ini to setup_legacy.ini.
1078 (SETUP_BZ2_FILENAME): Likewise.
1079
5072c0bb
BD
10802007-02-27 Brian Dessent <brian@dessent.net>
1081
1082 * ini.h (SETUP_INI_FILENAME): Add define.
1083 (SETUP_BZ2_FILENAME): Add define.
1084 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use
1085 above macros to parameterize setup.ini filename.
1086 * fromcwd.cc (SetupFindVisitor::visitFile): Ditto.
1087 * ini.cc (do_remote_ini): Ditto.
1088 * Makefile.am (setup_SOURCES): Add win32.cc.
1089 * autoload.c: Include windows.h directly instead of win32.h so that
1090 win32.h can contain C++.
1091 * desktop.cc (verinfo): Delete.
1092 (make_link): Use IsWindowsNT to check for NT instead of verinfo.
1093 (DesktopSetupPage::OnInit): Likewise.
1094 * mount.cc (is_admin): Likewise.
1095 * script.cc (init_run_script): Likewise.
1096 * main.cc (class SIDWrapper, SIDWrapper::SIDWrapper,
1097 SIDWrapper::~SIDWrapper, SIDWrapper::theSID, class HANDLEWrapper,
1098 HANDLEWrapper::HANDLEWrapper, HANDLEWrapper::~HANDLEWrapper,
1099 HANDLEWrapper::theHANDLE, class TokenGroupCollection,
1100 TokenGroupCollection::TokenGroupCollection,
1101 TokenGroupCollection::~TokenGroupCollection,
1102 TokenGroupCollection::populate, TokenGroupCollection::find,
1103 class NTSecurity, set_default_sec, NTSecurity::NoteFailedAPI,
1104 NTSecurity::NTSecurity, NTSecurity::failed,
1105 NTSecurity::initialiseEveryOneSID, NTSecurity::setDefaultDACL,
1106 NTSecurity::setDefaultSecurity): Remove implementation of these
1107 classes from this file and into new file win32.cc and existing win32.h.
1108 (main): Fix whitespace and formatting per GNU coding standards.
1109 * res.rc (IDS_SETUPINI_MISSING): Parameterize filename with %s.
1110 * win32.cc: New file containing methods removed from main.cc as well
1111 as new class VersionInfo methods.
1112 * win32.h: Include <string> for std::string.
1113 (class SIDWrapper, class HANDLEWrapper, class TokenGroupCollection,
1114 class NTSecurity): Add classes removed from main.cc.
1115 (class VersionInfo): Add new class.
1116 (GetVer): Declare.
1117 (IsWindowsNT): Define.
1118
5cc32375
BD
11192007-02-20 Brian Dessent <brian@dessent.net>
1120
1121 * README: Modernize list of required packages, and mention doconfigure.
1122
5ef77c46
BD
11232007-02-17 Cesar Strauss <cstrauss@cea.inpe.br>
1124
3c1254b9
MB
1125 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
1126 Initialize the version and operator fields of the newly created
1127 PackageSpecification object, so setup can pick the correct source
1128 version later on.
5ef77c46 1129
a875b471
BD
11302007-02-17 Brian Dessent <brian@dessent.net>
1131
1132 * script.cc (Script::run): Check for existance of script file and
1133 return without doing anything if it does not exist.
1134
3a694862
MB
11352006-12-26 Max Bowsher <maxb1@ukf.net>
1136
1137 * IniDBBuilder.h (IniDBBuilder): Make this class abstract.
1138 * IniDBBuilder.cc: Delete file.
1139 * Makefile.am (inilint_SOURCES, setup_SOURCES): Remove IniDBBuilder.cc.
1140
be8736e4
MB
11412006-12-26 Max Bowsher <maxb1@ukf.net>
1142
1143 Add a shell script that documents/centralizes the standard configure
1144 command line.
1145
1146 * doconfigure: New file.
1147 * Makefile.am (EXTRA_DIST): Add doconfigure.
1148
cafda414
IP
11492006-11-28 Igor Peshansky <pechtcha@cs.nyu.edu>
1150
1151 * install.cc (Installer::installOne): If file is in use, ask the user
1152 to stop processes and retry.
1153 (MB_RETRYCONTINUE, IDCONTINUE): New macros.
1154 (hMsgBoxHook): New static field.
1155 (CBTProc): New window hook function.
1156 (_custom_MessageBox): New function.
1157 * CHANGES: Update with the above.
1158
effce34d
IP
11592006-10-12 Igor Peshansky <pechtcha@cs.nyu.edu>
1160
1161 * desktop.cc (make_cygwin_bat,save_icon): Capitalize filename.
1162
7dc7a0a4
BD
11632006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1164
1165 * package_version.cc (packageversion::scan): Catch and handle
1166 validation exception.
1167
0ec7cbc9
BD
11682006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1169
1170 * cygpackage.h (filesize): Remove unused field.
1171 (cygpackage::createInstance): Ditto.
1172 * cygpackage.cc (cygpackage::createInstance): Ditto.
1173 * package_db.cc (packagedb::packagedb): Remove unused variables.
1174 Simplify parsing of installed.db.
1175
c861f482
BD
11762006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1177
1178 * desktop.cc (DesktopSetupPage::OnInit): Remove stray MessageBox.
1179
3d4c5ebb
IP
11802006-05-24 Igor Peshansky <pechtcha@cs.nyu.edu>
1181
1182 * PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView.
1183 * PickView.h (PickView::DrawIcon): Move from PickPackageLine.
1184 (PickView::icon_dc,PickView::bm_icon): New instance field.
1185 (PickView::rect_icon,PickView::bg_fg_brush): Ditto.
1186 * PickCategoryLine.cc (PickCategoryLine::paint): Use
1187 PickView::DrawIcon() instead of BitBlt().
1188 * PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView.
1189 (PickPackageLine::paint): Use PickView::DrawIcon().
1190 * PickView.cc (PickView::~PickView): Delete GDI objects.
1191 (PickView::init): Create icon drawing context.
1192 (PickView::DrawIcon): New function. Use system default colors to
1193 draw bitmaps.
1194 (PickView::paint): Set background color instead of using transparent
1195 mode. Create system-colored brush.
1196
ba2559db
BD
11972006-04-25 Brian Dessent <brian@dessent.net>
1198
1199 * COPYING: New file (GPL).
1200 * Makfile.am (EXTRA_DIST): Add COPYING.
1201
5f9ac473
MB
12022006-04-17 Max Bowsher <maxb1@ukf.net>
1203
1204 * String++.cc, String++.h: Finally, it's time for the long-awaited
1205 departure of 'class String' from this world. setup.exe can now
1206 happily claim to follow the sane path of using just one general
1207 purpose string class throughout :-)
1208
02d06553
MB
12092006-04-17 Max Bowsher <maxb1@ukf.net>
1210
1211 * cygpackage.cc, cygpackage.h, package_version.cc, package_version.h:
1212 Do some String to std::string migration.
1213
1eb2461a
MB
12142006-04-17 Max Bowsher <maxb1@ukf.net>
1215
1216 * package_meta.cc, package_meta.h, package_source.cc,
1217 package_source.h: Do some String to std::string migration.
1218 * package_db.cc: Small tweak to assist with the above.
1219
d19f12fd
MB
12202006-04-17 Max Bowsher <maxb1@ukf.net>
1221
1222 * PickView.cc, PickView.h, package_db.cc, package_db.h:
1223 Do some String to std::string migration.
1224 * package_meta.h: Change a couple of types to assist with the above.
1225
9b0876b3
MB
12262006-04-17 Max Bowsher <maxb1@ukf.net>
1227
1228 * IniDBBuilder.cc, IniDBBuilder.h, IniDBBuilderPackage.cc,
1229 IniDBBuilderPackage.h, PickLine.h, PickPackageLine.cc:
1230 Do some String to std::string migration.
1231
fd93eff9
MB
12322006-04-16 Max Bowsher <maxb1@ukf.net>
1233
1234 * FindVisitor.cc, FindVisitor.h, IniParseFindVisitor.cc,
1235 IniParseFindVisitor.h, ScanFindVisitor.cc, ScanFindVisitor.h, find.cc,
1236 find.h, fromcwd.cc, ini.cc, ini.h, iniparse.y, postinstall.cc:
1237 Do some String to std::string migration.
1238
a3a02820
MB
12392006-04-16 Max Bowsher <maxb1@ukf.net>
1240
1241 * IOStreamProvider.h, archive.cc, archive.h, archive_tar.cc,
1242 archive_tar.h, io_stream.cc, io_stream.h, io_stream_cygfile.cc,
1243 io_stream_cygfile.h, io_stream_file.cc, io_stream_file.h:
1244 Do some String to std::string migration.
1245
2bba98e8
MB
12462006-04-16 Max Bowsher <maxb1@ukf.net>
1247
1248 * desktop.cc, download.cc, install.cc, mount.cc, mount.h, script.cc,
1249 script.h: Do some String to std::string migration.
1250
ee4ad3a7
MB
12512006-04-16 Max Bowsher <maxb1@ukf.net>
1252
1253 * category.cc: Remove source file that contained no code!
1254 * category.h: Delete, moving the single useful line to...
1255 * package_meta.h: ...here. Remove category.h include.
1256 * choose.cc, package_db.h, package_meta.cc: Remove category.h include.
1257 * Makefile.am: Remove references to removed files.
1258
08678720
MB
12592006-04-15 Max Bowsher <maxb1@ukf.net>
1260
1261 * ConnectionSetting.cc, ConnectionSetting.h, Exception.cc,
1262 Exception.h, IniParseFeedback.cc, IniParseFeedback.h, LogFile.cc,
1263 LogFile.h, LogSingleton.h, PackageSpecification.cc,
1264 PackageSpecification.h, SourceSetting.cc, SourceSetting.h,
1265 UserSettings.cc, UserSettings.h, dialog.cc, dialog.h, diskfull.cc,
1266 diskfull.h, filemanip.cc, filemanip.h, inilintmain.cc, localdir.cc,
1267 main.cc, nio-file.cc, nio-http.cc, prereq.cc, prereq.h, proppage.cc,
1268 proppage.h, site.cc, site.h, splash.cc, state.cc, state.h, window.cc,
1269 window.h: Do some String to std::string migration.
1270
cb026227
MB
12712006-04-15 Max Bowsher <maxb1@ukf.net>
1272
1273 * String++.cc, String++.h
1274 (new_cstr_char_array, format_1000s): Migrate String to std::string.
ca2b7505 1275 (casecompare_lt_op, std::string operator+): New.
cb026227 1276
470f4928
MB
12772006-04-06 Max Bowsher <maxb1@ukf.net>
1278
1279 * String++.h, String++.cc
1280 (String::replace): Remove - usused.
1281 (String::find): Remove - semantics do not match std::string.
1282
1283 * root.cc (directory_is_rootdir): Switch to std::string.find().
1284 * script.cc (Script::baseName): Rewrite use of String.find().
1285
2b791966
MB
12862006-03-30 Max Bowsher <maxb1@ukf.net>
1287
1288 * String++.cc (replace): New function to take the place of one form
1289 of String::replace method.
1290 * String++.h (replace): Declare.
1291 (String::replace): Make private.
1292
1293 * desktop.cc (make_cygwin_bat): Use new function.
1294 * filemanip.cc (backslash): Use simple loop in place of
1295 String::replace.
1296 * filemanip.h (backslash): Change signature to use std::string in
1297 place of String.
1298
afa76033
MB
12992006-03-30 Max Bowsher <maxb1@ukf.net>
1300
1301 * String++.cc, String++.h (casecompare): New function replacing
1302 String.casecompare to increase parity with std::string.
1303 (String::casecompare): Make private.
1304
1305 * ConnectionSetting.cc, IniDBBuilderPackage.cc,
1306 IniParseFindVisitor.cc, LogFile.cc, PackageSpecification.cc,
1307 PickView.cc, SourceSetting.cc, String++.cc, String++.h, fromcwd.cc,
1308 io_stream.cc, mount.cc, package_db.cc, package_source.h,
1309 package_version.cc, prereq.h, script.cc:
1310 Use casecompare in place of String::casecompare.
1311
8300be9c
MB
13122006-03-30 Max Bowsher <maxb1@ukf.net>
1313
1314 * String++.cc, String++.h: Remove String(int) constructor, which
1315 was causing dangerously bizarre implicit conversions, and was a point
1316 of disparity between String and std::string.
1317 (stringify): New function to replace functionality removed above.
1318
1319 * PickView.cc (PickView::init_headers),
1320 archive_tar.cc (archive_tar::next_file_name),
1321 cygpackage.cc (cygpackage::setCanonicalVersion):
1322 Make explicit and call out with a FIXME some bizarre behaviour.
1323
1324 * ScanFindVisitor.cc (ScanFindVisitor::visitFile),
1325 filemanip.cc (base), iniparse.y,
1326 threebar.cc (ThreeBarProgressPage::SetBar2):
1327 Make simple adaptations to the changed API.
1328
7c593196
IP
13292006-03-14 Igor Peshansky <pechtcha@cs.nyu.edu>
1330
1331 * PickView.cc (PickView::setViewMode): Auto-expand category if
1332 its name starts with a dot.
1333
3dbb54fc
DK
13342006-03-14 Dave Korn <dave.korn@artimi.com>
1335
1336 * String++.cc (new_cstr_char_array): Handle null input correctly.
1337
e5e2eba8
CF
13382006-03-10 Christopher Faylor <cgf@timesys.com>
1339
1340 * res.rc: Update copyright.
1341 (IDS_MIRROR_LST): Use cygwin.com for mirror list, not
1342 sources.redhat.com.
e5e2eba8 1343 * site.cc (NOSAVE1): Use preferred name of sourceware site.
4f41c01c 1344 (NOSAVE2): sourceware.cygnus.com -> sources.redhat.com.
e5e2eba8
CF
1345 (NOSAVE1_LEN): Use just-defined name to determine length.
1346 (NOSAVE2_LEN): Ditto.
1347 (NOSAVE3_LEN): Ditto.
1348
13492006-03-10 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1350
1351 * res.rc (IDD_DROPPED): New dialog.
1352 * resource.h (IDD_DROPPED): New dialog-id.
1353 (IDC_DROP_MIRRORS, IDC_DROP_NOWARN): New control-ids.
1354 * site.cc: Add enum for response on dropped mirrors.
1355 (cache_is_usable, cache_needs_writing): New bools.
1356 (cache_warn_urls): New string.
1357 (cached_site-list, dropped_site_list): New SiteLists.
1358 (site_list_type::init, site_list_type::site_list_type): Change to four
1359 parameter form.
1360 (site_list_type::site_list_type, site_list_type::operator=) Copy
1361 servername, area and location.
1362 (load_site_list): New function, broken out of get_site_list. Support
1363 four-parameter site_list_type.
1364 (get_site_list): Break out load_site_list. Move reading cache earlier.
1365 Don't write new cache. Set flags to record cache state. Load both
1366 all_site_list and cached_site_list.
1367 (SiteSetting::registerSavedSite): Use four-parameter site_list_type.
1368 (drop_proc, check_dropped_mirrors, write_cache_list, save_cache_file):
1369 New functions.
1370 (SitePage::OnNext): Check for dropped mirrors and save cache as
1371 appropriate.
1372 (SitePage::OnMessageCmd): Use four-parameter site_list_type.
1373 * site.h
1374 (site_list_type::init, site_list_type::site_list_type): Change to four
1375 parameter form.
1376 (site_list_type): Add servername, area and location members.
1377
b2b35a6e
IP
13782006-03-09 Igor Peshansky <pechtcha@cs.nyu.edu>
1379
1380 * script.cc (Script::run): Fix inverted test for abnormal exit.
1381
966a9815
MB
13822006-03-09 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1383 Max Bowsher <maxb1@ukf.net>
1384
1385 Provide indication of site that a file is being downloaded from.
1386
1387 * geturl.cc: Use std::string instead of String throughout.
1388 (init_dialog): Put more information into GUI.
1389 Remove unused 'owner' parameter and change all callers.
1390 (progress): Remove spurious \n characters from GUI.
1391 * geturl.h: Use std::string instead of String throughout.
1392 * res.rc (IDD_INSTATUS): Use SS_ENDELLIPSIS.
1393
8e91c2fb
MB
13942006-03-09 Max Bowsher <maxb1@ukf.net>
1395
1396 * Makefile.am (EXTRA_DIST): Add tree-minus.bmp and tree-plus.bmp.
1397
bb810dd8
DK
13982006-01-20 Bryan Thrall <bryan.thrall@flightsafety.com>
1399
1400 * source.cc (SourcePage::OnActivate): Command line takes precedence
1401 over last user selection.
1402
253585ba
MB
14032005-11-30 Max Bowsher <maxb1@ukf.net>
1404
1405 * res.rc (IDD_ROOT, IDD_LOCAL_DIR): Rearrange some controls a little,
1406 in response to suggestion from Carl Karsten.
1407
d60832c6
MB
14082005-11-30 Max Bowsher <maxb1@ukf.net>
1409
1410 * site.h, site.cc: Use std::string in preference to String.
1411 (site_list_type::init): Convert some painful raw C string work to
1412 STL std::string work. Stop totally ignoring the result of this
1413 calculation, implementing the (somewhat weird) sort order for sites
1414 that was apparently indented for ages.
1415
3d3c6047
IP
14162005-10-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1417
1418 * io_stream.cc (url_scheme_not_registered): New macro.
1419 (io_stream::open): Better log message on error.
1420 (io_stream::mkpath_p,io_stream::remove,io_stream::mklink): Ditto.
1421 (io_stream::move,io_stream::exists): Ditto.
1422
b059e20b
IP
14232005-10-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1424
1425 * site.cc (get_site_list): Default to empty mirror list if
1426 server unavailable and none cached, to allow using preferred
1427 mirrors anyway.
1428
82573872
IP
14292005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1430
1431 * package_db.cc (packagedb::packagedb): Remember missing package
1432 database file.
1433
9237e1bb
IP
14342005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1435
1436 * site.cc (get_site_list): Store mirror list locally.
1437 Use local copy if unable to download.
1438
a8be3f13
IP
14392005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1440
1441 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
1442 Better log message on error.
1443
2a8125be
IP
14442005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1445
bd3a38c7 1446 * script.cc (Script::isAScript): Fix string comparison.
2a8125be 1447
01b9378a
IP
14482005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1449
1450 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Reconnect on FTP timeout.
1451
65ce9baf
BD
14522005-09-11 Masayuki FUJII <boochang@m4.kcn.ne.jp>
1453
1454 * package_meta.cc (packagemeta::ScanDownloadedFiles): Don't use an
1455 invalid iterator. Fix whitespace.
1456
3f6926b1
BD
14572005-09-09 Brian Dessent <brian@dessent.net>
1458
1459 * CHANGES: Document recent updates.
1460 * choose.cc (ChooserPage::OnInit): Add new tooltip.
1461 * res.rc (IDD_CHOOSE): Remove 'administrative' from description.
1462 (IDS_HIDEOBS_TOOLTIP): Add new string for tooltip.
1463 * resource.h (IDS_HIDEOBS_TOOLTIP): Define.
1464 * window.cc (Window::ActivateTooltips): Fix whitespace. Set tooltip
1465 delay to 30 seconds.
1466
9dda7744
BD
14672005-09-09 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1468
1469 * PickView.cc (PickView::paint): Set background mode to transparent.
1470 * PickCategoryLine.cc (PickCategoryLine::paint): Use bitwise AND to
1471 blit bitmaps.
1472 * PickPackageLine.cc (PickPackageLine::paint): Ditto.
1473
534c25cc
BD
14742005-09-01 Brian Dessent <brian@dessent.net>
1475
1476 * package_meta.cc (packagemeta::uninstall): Remove support for
1477 undocumented and dangerous postremove script.
1478
14792005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1480
1481 * script.cc (run): Change to return the exit code or negative error.
1482 (Script::run): Ditto.
1483 (try_run_script): Receive both filename and extension and run only
1484 one script. Also return the exit code.
1485 * script.h (try_run_script): Change signature.
1486 (Script::run): Ditto.
1487 * postinstall.cc (RunScript::operator()): Change to return the exit
1488 code or negative error.
1489 * install.cc (Installer::preremoveOne): Pass extension to
1490 try_run_script().
1491
14922005-09-01 Eric Blake <ebb9@byu.net>
1493
1494 * script.cc (shells): Use /bin/bash, not sh, to allow upgrades to
1495 /bin/sh.
1496
0ac305ec
BD
14972005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1498
1499 * PickView.h (PickView::size_col): New instance variable.
1500 * PickView.cc (pkg_headers, cat_headers): Add size column.
1501 (PickView::set_headers): Initialize size_col.
1502 (PickView::init_headers): Include width of size column.
1503 * PickPackageLine.cc (PickPackageLine::paint): Handle size_col.
1504 * String++.cc (format_1000s): New function.
1505 * String++.h (format_1000s): Declare new function.
1506
aa62e0f3
BD
15072005-09-01 Brian Dessent <brian@dessent.net>
1508
1509 * Makefile.am (BASECXXFLAGS): Add -Wno-uninitialized to work around
1510 spurious warnings with gcc 3.4.4.
1511
687dd890
BD
15122005-05-22 Brian Dessent <brian@dessent.net>
1513
1514 * res.rc (IDD_CHOOSE): Change description to include administrative
1515 packages in addition to obsolete.
1516
82306ac2
BD
15172005-05-21 Brian Dessent <brian@dessent.net>
1518
1519 * prereq.cc: New file.
1520 * prereq.h: Ditto.
1521 * tree-minus.bmp: Ditto.
1522 * tree-plus.bmp: Ditto.
1523 * Makefile.am: Add prereq.cc and prereq.h to build.
1524 * PickCategoryLine.cc (PickCategoryLine::paint): Add new parameter and
1525 refactor. Use bitmap for '+' and '-' indicators. Draw package lines
1526 column-wise for better drawing efficiency.
1527 (PickCategoryLine::click): Use previously calculated x value.
1528 * PickCategoryLine.h (PickCategoryLine::paint): Update prototype. Add
1529 'spin_x' member.
1530 * PickLine.h (PickLine:paint): Update prototype.
1531 * PickPackageLine.cc (PickPackageLine::DrawCheck): Remove.
1532 (PickPackageLine::DrawIcon): New function.
1533 (PickPackageLine::paint): Add parameter. Refactor completely for more
1534 efficient painting.
1535 * PickPackageLine.h (PickPackageLine::DrawIcon): Add prototype.
1536 (PickPackageLine::paint): Update prototype.
1537 (PickPackageLine::DrawCheck): Remove.
ca2b7505 1538 * PickView.cc (pkg_headers): Remove unused 'slen' field, add new
82306ac2 1539 'needs_clip' field to signify if clipping is necessary for this column.
ca2b7505 1540 (PickView::note_width): Fold long line. Refactor slightly for
82306ac2
BD
1541 simplicity.
1542 (PickView::set_view_mode): Remove.
1543 (PickView::cycleViewMode): New function.
1544 (PickView::setViewMode): Refactor completely. Incorporate functionality
1545 of clear_view() here instead. Simplify package selection into a single
1546 'for' loop rather than repeating code for each type.
1547 (isObsolete): New function, with second overloaded version.
1548 (PickView::setObsolete): New function.
1549 (PickView::insert_pkg): Do not show obsolete packages. Move
1550 declaration of 'db' lower. Fix whitespace.
1551 (PickView::insert_category): Do not show obsolete packages.
ca2b7505 1552 (PickView::clear_view): Remove. Moved logic into 'setViewMode'.
82306ac2
BD
1553 (PickView::scroll): Add additional parameter 'howmany' with default
1554 value of 1. Scroll by 'howmany' lines for SB_LINEDOWN and SB_LINEUP.
1555 (NUM_CATEGORY_COL_WIDTH): Define.
1556 (PickView::init_headers): Fix whitespace. Add comments. Ignore
1557 obsolete packages in width calculations. Add functionality to size
1558 'Category' column so that at least NUM_CATEGORY_COL_WIDTH categories
1559 are displayed for every package. Ensure that 'new_col' takes into
1560 account all possible labels.
1561 (PickView::PickView): Initialize showObsolete to false.
1562 (PickView::init): Remove unused bitmap bm_rtarrow. Add new bitmaps
1563 bm_treeplus and bm_treeminus. Use a macro for better readability.
1564 Fix whitespace formatting. Remove header computation from here, call
1565 refresh() instead.
1566 (PickView::registerWindowClass): Remove unnecessary background brush.
1567 (PickView::WindowProc): Add support for WM_MOUSEWHEEL message
1568 processing. Fix indentation. Reformat for readability.
1569 (PickView::paint): Get the update region before calling BeginPaint.
1570 Fill the update region with the default colors. Do not do clipping
1571 here. Pass update region to the PickLine paint function instead.
1572 Free the update region when finished.
1573 (PickView::Create): Fix indentation.
1574 (PickView::defaultTrust): Ditto.
1575 (PickView::refresh): Add column recalculation logic here.
1576 * PickView.h: Fix indentation.
1577 (RTARROW_WIDTH): Remove unused define.
1578 (NEW_COL_SIZE_SLOP): Ditto.
1579 (TREE_INDENT): Define.
1580 (PickView::get_view_mode): Remove.
1581 (PickView::set_view_mode): Rename to setViewMode for consistency.
1582 (PickView::cycleViewMode): Add new function.
1583 (PickView::setObsolete): Ditto.
1584 (PickView::clear_view): Remove.
1585 (PickView::bm_treeplus): Define new member.
1586 (PickView::bm_treeminus): Ditto.
1587 (PickView::scroll): Add parameter.
1588 (PickView::Header::slen): Remove unused member.
1589 (PickView::Header::needs_clip): Define new member.
1590 (PickView::showObsolete): Ditto.
1591 (isObsolete): Add prototype, and for overloaded version as well.
1592 * choose.cc: Add include.
1593 (ChooserControlsInfo): Allow new checkbox to be resized.
1594 (ChooserPage::OnInit): Start dialog with 'Hide obsolete' checked.
1595 (ChooserPage::OnNext): Call the dependency checker, act accordingly.
1596 (ChooserPage::changeTrust): Notify dependency checker of current trust
1597 level when it changes.
1598 (ChooserPage::OnMessageCmd): Just call cycleViewMode instead when
1599 changing the view. Update the chooser when the user toggles the
1600 'hide obsolete' checkbox.
1601 (ChooserPage::OnMouseWheel): New function. Pass mouse wheel message
1602 on to chooser.
1603 * choose.h (OnMouseWheel): Add prototype.
1604 * main.cc: Add include.
1605 (main): Define and initialize the PrereqPage object. Add it into
1606 the property sheet list.
1607 * PropPage.cc (PropertyPage::DialogProc): Add support for WM_MOUSEWHEEL
1608 message processing in derived classes.
1609 (PropertyPage::OnMouseWheel): New function.
1610 * PropPage.h (PropertyPage::OnMouseWheel): Add prototype.
1611 * res.rc (IDD_LOCAL_DIR): Shorten edit box so that pushbutton is not
1612 crowded.
1613 (IDD_SITE): Provide static text with an ID so that it can be resized
1614 properly. Move pushbutton slightly to right so that it doesn't crowd
1615 edit box.
1616 (IDD_SPLASH): Change copyright displayed on spash screen to be generic
1617 since the actual list of contributors is long.
1618 (IDD_CHOOSE): Add checkbox. Resize other controls to accomodate.
1619 (IDD_PREREQ): New dialog.
1620 (SPIN): Delete duplicated bitmap resource.
1621 (IDB_RTARROW): Remove unused bitmap resource.
1622 (IDB_TREE_PLUS): Add.
1623 (IDB_TREE_MINUS): Ditto.
1624 (IDS_TRUSTPREV_TOOLTIP): Revise wording to be more concise.
1625 (IDS_TRUSTCURR_TOOLTIP): Ditto.
1626 (IDS_TRUSTEXP_TOOLTIP): Ditto.
1627 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
1628 * resource.h (IDD_PREREQ): Define.
1629 (IDB_RTARROW): Remove.
1630 (IDB_TREE_PLUS): Add, and renumber.
1631 (IDB_TREE_MINUS): Ditto.
1632 (IDC_SITE_USERURL): Define.
1633 (IDC_CHOOSE_HIDE): Ditto.
1634 (IDC_PREREQ_TEXT): Ditto.
1635 (IDC_PREREQ_EDIT): Ditto.
1636 (IDC_PREREQ_CHECK): Ditto.
1637 * site.cc (SiteControlsInfo): Ensure that 'User URL' static text is
1638 properly resized.
1639
846e099d
MB
16402005-05-14 Max Bowsher <maxb@ukf.net>
1641
1642 "Type" field of packageversions was not even being filled in. Fix.
1643
1644 * cygpackage.h, cygpackage.cc (cygpackage::createInstance):
1645 Make "type" a mandatory parameter of the constructor.
1646 * IniDBBuilderPackage.cc: Adjust callers.
1647
c1352375
MB
16482005-05-14 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1649
1650 Fix behaviour of hardlinks in source packages.
1651
1652 * archive.cc (archive::extract_file):
1653 Use prefixPath for link target on hardlinks.
1654
403f1027
MB
16552005-05-14 Max Bowsher <maxb@ukf.net>
1656
1657 Hopefully, solve the "preremove DLL dependency" bug, by running all
1658 preremove scripts before actually removing any files.
1659
ca2b7505 1660 * install.cc
403f1027
MB
1661 (Installer::preremoveOne): New method. Run preremove scripts here.
1662 (Installer::replaceOne): Remove method.
1663 (num_replacements): Remove variable.
1664 (do_install_thread): Significantly rewrite.
1665 * package_meta.cc (packagemeta::uninstall):
1666 Do not run preremove script here.
1667
f916c374
MB
16682005-05-14 Max Bowsher <maxb@ukf.net>
1669
1670 * download.cc (do_download_thread):
1671 Do not use packageversion::changeRequested().
1672 * package_version.cc (packageversion::Type):
1673 Implement declared but previously unimplemented method.
1674 (packageversion::changeRequested, _packageversion::changeRequested):
1675 Remove.
1676 * package_version.h
1677 (packageversion::changeRequested, _packageversion::changeRequested):
1678 Remove.
1679 * install.cc (Installer::replaceOne): Simplify, return void, not int.
1680 (installOneSource): Rename to...
403f1027 1681 (installOne): ...this. Change arguments and return type. Refactor.
f916c374
MB
1682 (install_one): Remove.
1683 (do_install_thread): Tidying up.
1684
655310ed
MB
16852005-05-07 Max Bowsher <maxb@ukf.net>
1686
1687 * download.cc (validateCachedPackage): Remove all MD5 checking code.
1688 It is not acceptable to check MD5 sums as part of simply answering
1689 whether a package exists in the local cache or not. It is too slow.
1690 MD5 sums always have been - and will continue to be - checked at
1691 install time.
1692 (NoMD5Option): Remove this option, as the code it controls has been
1693 removed.
1694
61a9e487
MB
16952005-05-07 Max Bowsher <maxb@ukf.net>
1696
1697 * install.cc (md5_one): Make the MD5 checking done at install time
1698 display a progess GUI, as the MD5 checking done at other times does.
1699
4c90a532
MB
17002005-05-07 Max Bowsher <maxb@ukf.net>
1701
1702 * resource.h, res.rc: Followup to recent de-MSVC-ification of
1703 resource.h, by removing a lot from res.rc, and the last few bits
1704 from resource.h.
1705
9a8a04fc
BD
17062005-05-05 Brian Dessent <brian@dessent.net>
1707
37f49caf
BD
1708 * choose.cc (ChooserPage::OnInit): Initialize tooltips for this
1709 dialog.
1710
1711 * proppage.h (PropertyPage::makeClickable): Update prototype to
1712 reflect same argument name as function.
1713
1714 * proppage.cc (PropertyPage::DialogProc): Remove redundant 'break'
ca2b7505 1715 statements that follow 'return's. Add missing braces to case
37f49caf
BD
1716 statements. Call handler for TTN_GETDISPINFO.
1717
1718 * res.rc (IDS_TRUSTKEEP_TOOLTIP): Add new STRINGTABLE entry for
1719 tooltip text.
1720 (IDS_TRUSTPREV_TOOLTIP): Ditto.
ca2b7505 1721 (IDS_TRUSTCURR_TOOLTIP): Ditto.
37f49caf
BD
1722 (IDS_TRUSTEXP_TOOLTIP): Ditto.
1723 (IDS_TRUSTPREV_TOOLTIP): Ditto.
1724 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
1725
1726 * resource.h: Likewise, add identifiers for tooltip resources.
1727
1728 * window.h: Add includes.
1729 (Window::TooltipHandle): Add new private data structure.
1730 (Window::TooltipStrings): Ditto.
1731 (Window::ActivateTooltips): Define new function to support tooltip
1732 functionality.
1733 (Window::SetTooltipState): Ditto.
1734 (Window::AddTooltip): Ditto.
322281d3 1735 (Window::TooltipNotificationHandler): Ditto.
37f49caf
BD
1736
1737 * window.cc (Window::Window): Initialize handle to NULL.
1738 (Window::~Window): Call DestroyWindow on tooltip control if it was
1739 activated.
1740 (Window::ActivateTooltips): New function to activate the tooltip
1741 control.
1742 (Window::SetTooltipState): New function to allow toggling of
1743 tooltips.
1744 (Window::AddTooltip): New function that adds a tooltip to a given
1745 control in a given window. Also implement overloaded versions that
1746 provide simpler interface and the ability to use a string resource.
1747 (Window::TooltipNotificationHandler): New function to handle
1748 TTN_GETDISPINFO notification messages.
1749
17502005-05-05 Brian Dessent <brian@dessent.net>
4c90a532 1751
9a8a04fc
BD
1752 * resource.h: Reorganize. Group by type, and give each its own
1753 range of IDs. Regenerate IDs accordingly.
1754 (IDD_CHOOSER): Remove obsolete and unused symbol.
1755
9e6e3c68
BD
17562005-05-05 Brian Dessent <brian@dessent.net>
1757
1758 * root.h (class RootPage): Add missing virtual to OnMessageCmd.
1759
746fff8d
BD
17602005-05-05 Brian Dessent <brian@dessent.net>
1761
1762 * root.cc (dialog_cmd): Remove. Use OnMessageCmd instead.
1763 (RootPage::Create): Accomodate above change.
1764
1765 * root.h (class RootPage): Add prototype for OnMessageCmd.
1766
1767 * res.rc (IDD_ROOT): Fix broken button groups. Correct the order of
ca2b7505 1768 the controls and use of WS_GROUP so that the radio buttons act
746fff8d
BD
1769 correctly.
1770
d2a3615c
MB
17712005-05-05 Max Bowsher <maxb@ukf.net>
1772
1773 Bulk rename of String++ member cstr_oneuse () to c_str () for
1774 similarity to std::string.
1775
1776 * Exception.cc
1777 * IniDBBuilderPackage.cc
1778 * IniParseFindVisitor.cc
1779 * LogFile.cc
1780 * PickCategoryLine.cc
1781 * PickPackageLine.cc
1782 * PickView.cc
1783 * String++.cc
1784 * String++.h
1785 * archive.cc
1786 * cygpackage.cc
1787 * desktop.cc
1788 * dialog.cc
1789 * diskfull.cc
1790 * download.cc
1791 * filemanip.cc
1792 * find.cc
1793 * geturl.cc
1794 * ini.cc
1795 * install.cc
1796 * io_stream.cc
1797 * io_stream_cygfile.cc
1798 * io_stream_file.cc
1799 * localdir.cc
1800 * mount.cc
1801 * nio-http.cc
1802 * package_db.cc
1803 * package_meta.cc
1804 * package_source.h
1805 * postinstall.cc
1806 * proppage.cc
1807 * root.cc
1808 * script.cc
1809 * site.cc
1810 * splash.cc
1811 * threebar.cc
1812 * window.cc
1813
3a8630fd
MB
18142005-05-05 Max Bowsher <maxb@ukf.net>
1815
1816 Some String++ refactoring, setting out in the general direction of
1817 eventually just using the STL std::string, not our own class.
1818
1819 * String++.cc (String::cstr, String::cstr () const): Remove.
1820 (new_cstr_char_array): New function.
1821 * String++.h: Sync with above.
1822 Remove irrelevant "class io_stream;" declaration.
1823
1824 * cygpackage.h: Add "class io_stream;" declaration, now no longer
1825 being supplied by side-effect.
1826
1827 * filemanip.cc: Remove unneeded includes, add "using namespace std;".
1828 (parse_filename): Exchange some awkward pointer manipulation for
1829 std::string usage. Use new_cstr_char_array ().
1830 * filemanip.h: Sync with above.
1831 (fileparse): Improve style of declaration.
1832
1833 * io_stream_cygfile.cc (io_stream_cygfile::normalise):
1834 Use new_cstr_char_array ().
1835 * site.cc (site_list_type::init, get_site_list): Ditto.
1836
daab12c7
BD
18372005-05-05 Brian Dessent <brian@dessent.net>
1838
03e84729
MB
1839 * ControlAdjuster.h (enum ControlPosition): Declare new resizing
1840 methods CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, and their
1841 TOP/BOTTOM aliases.
daab12c7 1842
03e84729
MB
1843 * ControlAdjuster.cc (ControlAdjuster::ControlInfo::adjust):
1844 Implement CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, which are
1845 designed to resize elements in a two-column layout.
daab12c7 1846
03e84729
MB
1847 * localdir.h (class LocalDirPage): Remove constructor implementation
1848 from here...
daab12c7 1849
03e84729
MB
1850 * localdir.cc (LocalDirPage::LocalDirPage): ...to here, and call
1851 AddControlsInfo on initialization.
1852 (static LocaldirControlsInfo): Add. Define sizing rules for dialog
daab12c7
BD
1853 elements.
1854
03e84729
MB
1855 * proppage.h: Add includes.
1856 (PropertyPage::ClickableURL):
1857 Declare new storage type for internal use by class.
1858 (PropertyPage::urls): Likewise.
1859 (PropertyPage::urlWinProc): Add declaration.
daab12c7
BD
1860 (PropertyPage::makeClickable): Likewise.
1861
03e84729
MB
1862 * proppage.cc: Add includes.
1863 (PropertyPage::DialogProc): Implement handler for WM_CTLCOLORSTATIC
1864 message. Supports static controls that have been turned into
1865 clickable hyperlinks.
1866 (static PropertyPage::urls): Declare.
1867 (PropertyPage::makeClickable): Implement new member function that
1868 provides user interface for making text into clickable URLs.
1869 (PropertyPage::urlWinProc): Implement new private member function used
1870 as a windowproc for subclassing a static control.
1871
1872 * resource.h (IDC_SPLASH_URL, IDC_FILEMODES_LINK, IDC_ROOTDIR_GRP,
1873 IDC_INSTALLFOR_GRP, IDC_ALLUSERS_TEXT, IDC_JUSTME_TEXT, IDC_MODE_GRP,
1874 IDC_MODE_TEXT, IDC_MODE_BIN, IDC_LOCALDIR_GRP, IDC_SPLASH_TEXT,
1875 IDC_SPLASH_ICON, IDC_SPLASH_COPYR): Add. Replaces anonymous
daab12c7
BD
1876 IDC_STATIC ids, so that controls can be referenced by the resizer.
1877
03e84729
MB
1878 * res.rc (IDD_LOCAL_DIR): Rearrange controls to match top-down order
1879 in the dialog. Fold long lines. Replace anonymous IDC_STATIC ids.
1880 (IDD_ROOT): Reorder in same manner. Replace anonymous IDC_STATIC ids.
1881 Add descriptive text of each option, and hyperlink for more
1882 information. Mark suggested choice as "(RECOMMENDED)". Swap order of
1883 'unix'/'dos' radio buttons so that recommended choice is first in both
1884 columns.
1885 (IDD_SPLASH): Reorder elements to match top-down order of dialog, fold
1886 long lines. Add descriptive paragraph, remove anonymous ids. Update
1887 copyright text, replace sources.redhat.com with cygwin.com.
daab12c7 1888
03e84729 1889 * root.h (class RootPage): Remove constructor implementation from
daab12c7
BD
1890 here...
1891
03e84729
MB
1892 * root.cc: ...to here, and call AddControlInfo.
1893 (static RootControlsInfo): Add. Populate with resizing data.
daab12c7
BD
1894 (RootPage::OnInit): Make text a clickable hyperlink.
1895
03e84729 1896 * splash.h (class SplashPage): Likewise, move constructor from
daab12c7
BD
1897 here...
1898
03e84729
MB
1899 * splash.cc: ...to here. Call AddControlInfo.
1900 (static SplashControlsInfo): Add and populate.
1901 (SplashPage::Create): Make link on splash page a clickable hyperlink.
daab12c7 1902
03e84729
MB
1903 * window.h: Add include.
1904 (class Window): Store allocated fonts with a vector instead of fixed
1905 array. Change indentation of setParent to be consistent.
daab12c7 1906
03e84729
MB
1907 * window.cc (Window::Window): Remove FontCounter.
1908 (Window::~Window): Likewise. Iterate over vector of fonts instead.
1909 (Window::SetDlgItemFont): Use vector.
daab12c7 1910
042d83f9
MB
19112005-05-05 Max Bowsher <maxb@ukf.net>
1912
1913 * Makefile.am (EXTRA_DIST, inilint_SOURCES):
1914 Sync with several recent changes.
1915
a38fde1a
BD
19162005-05-05 Brian Dessent <brian@dessent.net>
1917
03e84729 1918 * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Include section
a38fde1a
BD
1919 comment.
1920
dd267526
BD
19212005-05-05 Brian Dessent <brian@dessent.net>
1922
1923 * res.rc: (IDC_CHOOSE): Widen 'view' button by 6px horizontally and
1924 4px vertically. Adjust other controls to accomodate.
1925 (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that manifest is
1926 included in the binary.
1927
1928 * setup.exe.manifest: New file. Results in common controls with
1929 themed appearance on modern versions of Windows.
1930
83524e5b
MB
19312005-05-05 Brian Dessent <brian@dessent.net>
1932
03e84729 1933 * main.cc (WinMain): Change conditional to avoid spurious error
83524e5b 1934 message on success. Include reason for failure in log message.
96f50f64 1935
071f7af3
MB
19362005-05-04 Max Bowsher <maxb@ukf.net>
1937
1938 * state.cc, state.h (net_method, net_proxy_host, net_proxy_port,)
1939 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
1940 Inet_ftp_user, net_ftp_passwd):
1941 Move these global variables to be static variables of the NetIO class.
1942
1943 * netio.h, netio.cc (net_method, net_proxy_host, net_proxy_port,)
1944 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
1945 net_ftp_user, net_ftp_passwd):
1946 As above.
1947
1948 * ConnectionSetting.cc, net.cc:
1949 Change include, refer to variables in new location.
1950
0a49fe44
MB
19512005-05-04 Max Bowsher <maxb@ukf.net>
1952
1953 * PickLine.cc: Remove file - redundant.
1954 * Makefile.am (setup_SOURCES): Adjust.
1955
7f3324d2
MB
19562005-05-04 Max Bowsher <maxb@ukf.net>
1957
1958 * package_version.h (packageversion::set_requirements):
1959 Remove deftrust argument default value.
1960
19612005-05-04 Max Bowsher <maxb@ukf.net>
2ef95e81
MB
1962
1963 * package_version.cc (DependencyProcessor): Remove trivial class.
1964 (select, processOneDependency): Do not use DependencyProcessor, just
1965 pass parameters normally.
1966
d20a2e29
MB
19672005-05-04 Brian Dessent <brian@dessent.net>
1968
1969 Fix bug #820: Clicking Curr, etc., causes some dependencies to not
1970 be installed.
1971
1972 * choose.cc (ChooserPage::changeTrust):
1973 Add a missing "packagedb.markUnVisited ()".
1974
9bd063e0
MB
19752005-05-03 Max Bowsher <maxb@ukf.net>
1976
1977 * PickCategoryLine.cc (PickCategoryLine::click):
1978 * PickPackageLine.cc (PickPackageLine::click):
1979 Abandon use of trivial packagemeta::PrepareForVisit() wrapper.
1980
1981 * package_meta.h (packagemeta::PrepareForVisit): Remove.
1982 * package_meta.cc (packagemeta::PrepareForVisit): Remove.
1983
97b50ad7
MB
19842005-05-03 Max Bowsher <maxb@ukf.net>
1985
1986 * choose.h (ChooserPage::ifChecked): Remove.
1987 (ChooserPage::changeTrust): Convert from template to ordinary function.
1988 * choose.cc (ChooserPage::changeTrust): As above, plus avoid the use
1989 of custom class SetRequirement, when bind2nd(mem_fun(...),...) can
1990 achieve the same effect.
1991 * package_meta.h (SetRequirement): Remove, now unused.
1992
98b84622
MB
19932005-05-03 Max Bowsher <maxb@ukf.net>
1994
1995 * package_meta.h (packagemeta::set_requirements):
1996 Remove default argument which seems inappropriate.
1997 * PickPackageLine.cc (PickPackageLine::click):
1998 Make an argument explicit, and not that it seems like the wrong value.
1999
7c86285f
MB
20002005-05-03 Brian Dessent <brian@dessent.net>
2001
2002 Fix part of bug #853 - proxy port not remembered.
2003
2004 * net.cc (doing_loading): New static boolean.
2005 (load_dialog): Use the boolean to prevent save_dialog() from taking
2006 action due to field changes due to initialization.
2007 (save_dialog): Check the boolean and respond appropriately.
2008
9ad9a0b0
MB
20092005-04-19 Max Bowsher <maxb@ukf.net>
2010
2011 * postinstall.cc (RunFindVisitor::visitFile): Fix crash on
2012 encountering a postinstall script with a name of 4 characters or less.
2013 Bug introduced on 2004-12-25.
2014
946198be
MB
20152005-04-05 Max Bowsher <maxb@ukf.net>
2016
2017 The Big Cleanup: Phase "rfc1738"
2018
2019 * rfc1738.cc, rfc1738.h: Delete.
2020 * csu_util/rfc1738.cc: Reimport latest version from upstream source.
2021 Make thread-safe. Rewrite C++ wrapper in terms of std::string.
2022 Document the divergences from the upstream source.
2023 * csu_util/rfc1738.h: Recreate for the std::string version of the
2024 C++ wrapper.
2025
2026 * Makefile.am (setup_SOURCES): Sync with added/removed files.
2027 * IniParseFindVisitor.cc: Modify #includes.
2028 (IniParseFindVisitor::visitFile): Change function name, as the new
2029 C++ wrapper does not contain an irregularity that the old one did.
2030 * download.cc: Modify #includes.
2031 * ini.cc: Modify #includes.
2032
e76de0f5
MB
20332005-04-05 Max Bowsher <maxb@ukf.net>
2034
2035 Remove setup's internal compression libraries, instead relying on the
2036 mingw-foo packages which have been part of the Cygwin net distribution
2037 for some time now. At the same time, reorganize the README file to
2038 inform about the change, and make some additional tidy-ups there whilst
2039 working there.
2040
2041 * GUIDELINES: Remove, contents transferred to README.
2042 * README: Add build instructions. Delete unconfirmed and fixed bugs
2043 sections. Incorporate the former contents of GUIDELINES.
2044
2045 * bz2lib/: Remove.
2046 * zlib/: Remove.
ca2b7505 2047 * Makefile.am (DIST_SUBDIRS, SUBDIRS):
e76de0f5
MB
2048 * configure.in: Remove AC_CONFIG_SUBDIRS for removed subdirs.
2049 * compress_bz.h: Remove complex _WIN32 preprocessor conditional.
2050 * compress_gz.h: Fix #include file name.
2051 * archive_tar_file.cc: Remove unused #include.
2052 * install.cc: Remove unused #include.
2053
069a187a
MB
20542005-01-27 Max Bowsher <maxb@ukf.net>
2055
2056 Set CYGWIN=nontsec, for postinstall scripts.
2057
2058 * main.cc (main): putenv("CYGWIN=nontsec").
2059
b4cf6208
MB
20602005-01-27 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
2061
2062 Fix corrupt display of ini parse percentage in log file.
2063
2064 * ini.cc (GuiParseFeedback): Use a sensible data type for lastpct.
2065
eff7a094
MB
20662004-12-29 Max Bowsher <maxb@ukf.net>
2067
2068 * site.cc (get_site_list): Filter the incoming mirrors list to contain
2069 only URL schemes that we can read.
2070
2c539780
MB
20712004-12-28 Max Bowsher <maxb@ukf.net>
2072
2073 The Big Cleanup: Phase "hash"
2074
2075 * hash.cc, hash.h: Delete.
2076 * Makefile.am (setup_SOURCES): Sync with deleted files.
2077
2078 * package_mets: Modify includes.
2079 (standard_dirs): Remove.
2080 (hash::add_subdirs): Remove.
2081 (packagemeta::uninstall): Re-implement using STL set instead of
2082 homebrew hash.
2083
4abaa9f9
MB
20842004-12-28 Max Bowsher <maxb@ukf.net>
2085
2086 * String++.h (operator std::string): Take care to never do
2087 std::string((char*)NULL) - it causes a hang!
2088
a77b6167
MB
20892004-12-27 Max Bowsher <maxb@ukf.net>
2090
2091 The Big Cleanup: Phase "log"
2092
2093 * log.cc, log.h: Delete old C-style compatibility wrapper around the
2094 logging subsystem.
2095 * Makefile.am (setup_SOURCES): Sync with deleted files.
2096
2097 * AntiVirus.cc, archive_tar_file.cc, ini.cc, install.cc,
2098 * io_stream_cygfile.cc, localdir.cc, msg.cc, net.cc, netio.cc,
2099 * netio.h, nio-ftp.cc, nio-ftp.h, root.cc, source.cc:
2100 Throughout, refine includes, and update code using the old
2101 compatibility wrapper to C++ streams style code.
2102
b16e07fc
MB
21032004-12-27 Max Bowsher <maxb@ukf.net>
2104
2105 * compress.cc: Refine includes. Remove placeholder function
2106 definitions. Make destructor an empty function.
2107 * compress.h: Refine includes. Make placeholder functions pure
2108 virtual. Add missing const on buffer argument to write function,
2109 to match derived classes.
2110 * compress_bz.cc, compress_gz.cc: Refine includes. Throw exception,
2111 rather than logging and returning an error, when an unimplemented
2112 function is called.
2113 * compress_bz.h, compress_gz.h: Refine includes.
2114
2b734ec7
MB
21152004-12-26 Max Bowsher <maxb@ukf.net>
2116
2117 The Big Cleanup: Phase "version"
2118
2119 * String++.h (operator std::string): Add.
2120 * desktop.cc, fromcwd.cc: Remove irrelevant include.
2121
2122 * version.cc, version.h: Delete, replacing all functionality in new
2123 files.
2124
2125 * setup_version.h: Add, taking over declaration of generated version
2126 symbol functionality.
2127
2128 * Makefile.am (setup_SOURCES): Sync with new/deleted files.
2129 (setup_version.c): Rename the symbol 'version' to 'setup_version'.
2130 * main.cc: Modify includes.
2131 (main): Adapt to setup_version rename.
2132 * splash.cc: Modify includes.
2133 (SplashPage::OnInit): Adapt to setup_version rename.
2134
2135 * csu_util/version_compare.cc, csu_util/version_compare.h: Add,
2136 containing a completely rewritten replacement for canonical_version().
2137
2138 * IniDBBuilderPackage.cc: Modify includes.
2139 (IniDBBuilderPackage::buildVersion): Use new version_compare API.
2140 * ini.cc: Modify includes.
2141 (setup_version): Rename...
2142 (ini_setup_version): ...to this.
2143 (do_local_ini, do_remote_ini): Adapt to above change.
2144 (do_ini_thread): Adapt to above change. Use new version_compare API.
2145
0f45aabe
MB
21462004-12-25 Max Bowsher <maxb@ukf.net>
2147
2148 * install.cc (Installer::installOneSource): Remove a stray "break;"
2149 left over from the switch-case -> if-else conversion in the previous
2150 change.
2151
4875ac88
MB
21522004-12-25 Max Bowsher <maxb@ukf.net>
2153
2154 The Big Cleanup: Phase "win32"
2155
2156 * win32.h: Major overhaul. Document why we use _WIN32_IE. Move out
2157 fragment dealing with alloca() to the single file in which it is used.
2158 Remove fragment dealing with _MAX_PATH, and convert all uses of it
2159 elsewhere to MAX_PATH. Remove random include of <stdarg.h>. Remove
2160 NOCOMATTRIBUTE, as setup contains no code which it affects. Remove
2161 includes of <wininet.h> and <windowsx.h> - see later in this log.
2162 (IsWindowsNT): New inline function, a much simpler implementation of
2163 Win32::OS().
2164
2165 * win32.cc: Delete.
2166
2167 * Makefile.am (setup_SOURCES): Remove "win32.cc".
2168
2169 * AntiVirus.cc (detect), PickPackageLine.cc (PickPackageLine::paint),
2170 * install.c (Installer::installOneSource):
2171 Use IsWindowsNT(), not Win32::OS().
2172 * main.cc (main): Use IsWindowsNT(), not locally defined iswinnt.
2173
2174 * PickView.cc (PickView::WindowProc), netio.cc (auth_proc),
2175 * proppage.cc (PropertyPage::DialogProc):
2176 Avoid using obfuscating macros from <windowsx.h>.
2177
2178 * archive.cc: Include or #define alloca() in the only file in which
2179 it is used.
2180
2181 * nio-ie5.h: Include <wininet.h> here, where it is actually needed,
2182 rather than in "win32.h" which is included almost everywhere.
2183
2184 * archive_tar.cc, archive_tar.h, cygpackage.cc, cygpackage.h,
2185 * desktop.cc, find.cc, install.cc, main.cc, mklink2.c, mount.cc,
2186 * script.cc: Use MAX_PATH, not _MAX_PATH.
2187
f4a981ab
MB
21882004-12-25 Max Bowsher <maxb@ukf.net>
2189
2190 Remove some overcomplications.
2191
2192 * Makefile.am (setup_SOURCES): Remove FilterVisitor.{cc,h}.
2193 * FilterVisitor.cc, FilterVisitor.h: Delete.
2194 * String++.cc (strmatch, String::matches): Remove.
2195 * String++.h (String::matches): Remove.
2196 * postinstall.cc: Do not include "FilterVisitor.h".
2197 (RunFindVisitor): Exclude items with the extension ".done".
2198 (do_postinstall_thread): Remove overcomplicated exclusion of items
2199 with the extension ".done".
2200
768d880e
MB
22012004-12-24 Max Bowsher <maxb@ukf.net>
2202
2203 * String++.cc, String++.h: Remove unused and incomplete code.
2204 * LogFile.cc (LogFile::log_save): Don't leak memory.
2205 * filemanip.cc, geturl.cc, root.cc, version.cc:
2206 Don't pointlessly create temporary copies strings.
2207
db165a9a
MB
22082004-12-23 Max Bowsher <maxb@ukf.net>
2209
2210 * choose.cc (ChooserPage::OnNext): Relegate some overly verbose
2211 logging to an #ifdef DEBUG section.
2212 * geturl.h (dismiss_url_status_dialog): Remove stale function
2213 declaration, for which there is no definition.
2214 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
2215 Motivated by the recent unexplained hang bug, add some extra logging.
2216
0229b1d7
MB
22172004-11-22 Max Bowsher <maxb@ukf.net>
2218
2219 * MD5++.cc, MD5++.h: Remove this class.
2220 * csu_util/MD5Sum.cc, csu_util/MD5Sum.h: New more complete MD5 class.
2221 * Makefile.am (setup_SOURCES): Adjust to new files.
2222 * download.cc (validateCachedPackage): Simplify, using the new class.
2223 * install.cc (md5_one): Ditto.
2224 * package_source.h (packagesource::md5): Change to be an object of the
2225 new class.
2226
2c4261a8
MB
22272004-11-22 Max Bowsher <maxb@ukf.net>
2228
ba102d1c
MB
2229 * main.cc (main): Fix bug in one of the 2004-11-19 commits.
2230 Avoid referring to the theLog pointer before it is set.
2c4261a8 2231
9132ff16
MB
22322004-11-20 Max Bowsher <maxb@ukf.net>
2233
2234 * res.rc (IDD_SOURCE): Clarify the radio-button option descriptions.
2235 Re-layout the radio buttons.
2236
6beebaa3
MB
22372004-11-20 Max Bowsher <maxb@ukf.net>
2238
2239 Repair the broken detection of wrongly-sized package files.
2240
2241 * download.cc (validateCachedPackage): Make static, since not used
2242 elsewhere. Improve logging. Migrate file-size tests to here, alongside
2243 the MD5 tests.
2244 (check_for_cached): Remove broken testing of file-size, now covered by
2245 the above. Code cleanups.
2246
54ff37c8
MB
22472004-11-19 Max Bowsher <maxb@ukf.net>
2248
2249 * package_version.cc (dumpAndList): Make dependencies much more
2250 readable in full log output.
2251
4d7a6eeb
MB
22522004-11-19 Max Bowsher <maxb@ukf.net>
2253
2254 * proppage.cc (PropertyPage::DialogProc): Wrap in a TOPLEVEL_CATCH
2255 block, since allowing exceptions to unwind into the guts of Windows is
2256 quite disasterous.
2257
c66b9174
MB
22582004-11-19 Max Bowsher <maxb@ukf.net>
2259
2260 * main.cc (main): Move option parsing code earlier - it must execute
2261 before any significant object creations, which might test options in
2262 their initialization.
2263
82b64f8a
MB
22642004-11-19 Max Bowsher <maxb@ukf.net>
2265
2266 * main.cc (main): Remove some junk code - either commented out, or
2267 contained within unreachable preprocessor conditional sections.
2268
4fa49408
MB
22692004-11-19 Max Bowsher <maxb@ukf.net>
2270
2271 * install.cc (Installer::installOneSource): Avoid leaking the open
2272 file handles of every tarball that is installed.
2273
0e9a5c4f
MB
22742004-11-19 Max Bowsher <maxb@ukf.net>
2275
2276 * package_source.h (packagesource::Canonical, packagesource::Base)
2277 (packagesource::Filename): Add "const" specification to accessor
2278 methods.
2279
6b68e703
MB
22802004-11-18 Max Bowsher <maxb@ukf.net>
2281
2282 * archive.h (archive::~archive): Define a pure virtual destructor to
2283 enforce the abstract nature of this class.
2284 * archive.cc (archive::~archive): Pure virtual destructors require an
2285 implementation! Add one.
2286 * io_stream.h (io_stream::destroyed): Remove this severely
2287 brain-damaged implementation of a weakly-enforced abstract class.
2288 The pure virtual destructor was strongly enforcing the abstract nature
2289 anyway.
2290 * io_stream.cc (io_stream::~io_stream): Empty out horribly pointless
2291 code from the pure virtual destructor.
2292 * archive_tar.cc (archive_tar::~archive_tar): Remove all
2293 reference to the removed "destroyed" member.
2294 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
2295 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
2296 * compress_gz.cc (compress_gz::~compress_gz): Ditto.
2297 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Ditto.
2298 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
2299 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
2300
51200ef2
MB
23012004-11-17 Max Bowsher <maxb@ukf.net>
2302
2303 * mount.cc (create_mount): Fix operator precedence error introduced in
2304 first 2004-11-11 commit - warned of by gcc 3.3.3 but not 3.4.1 !
2305
f5d45c3b
MB
23062004-11-13 Max Bowsher <maxb@ukf.net>
2307
2308 Miscellaneous cleanup.
2309
2310 * geturl.cc (getUrlToStream): Make static.
2311 * geturl.h (getUrlToStream): Remove declaration.
2312
2313 * geturl.cc, geturl.h, netio.cc, netio.h, nio-ftp.cc, nio-ftp.h,
2314 nio-http.cc, nio-http.h:
2315 Remove unused "allow_ftp_auth" flag throughout.
2316
f4d80c3f
MB
23172004-11-11 Max Bowsher <maxb@ukf.net>
2318
2319 * libmd5-rfc: New directory, to hold code imported from the libmd5-rfc
2320 project in a clearly delineated fashion.
2321 * libmd5-rfc/README: New file.
2322 * md5.c, md5.h: Delete...
2323 * libmd5-rfc/md5.c, libmd5-rfc/md5.h: ...and replace with pristine
2324 versions from upstream (only change is restoration of upstream CVS
2325 keyword expansions).
2326 * libmd5-rfc/md5main.c: New file.
2327 * Makefile.ami (setup_SOURCES): Edit file paths.
2328 * download.cc, install.cc: Edit include paths.
2329
68d49419
MB
23302004-11-11 Max Bowsher <maxb@ukf.net>
2331
2332 * dialog.cc (fatal): Make capable of handling a passed-in error code,
2333 as an alternative to calling GetLastError().
2334 * dialog.h (fatal): Adjust prototype as above.
2335 * mount.cc (create_mount): Use the above to correctly report errors.
2336
af111c7d
MB
23372004-10-28 Max Bowsher <maxb@ukf.net>
2338
2339 * LogFile.cc (LogFile::getFileName), splash.cc (SplashPage::Create),
2340 threebar.cc (ThreeBarProgressPage::SetBar2):
2341 Migrate from cistring and string resources
2342 to String and string literals.
2343 * localdir.cc: Remove unneeded #include of "cistring.h".
2344 * cistring.cc, cistring.h: Remove this now-redundant class.
2345 * Makefile.am: Remove mention of the above removed files.
2346 * res.rc, resource.h: Remove obsolete strings and IDs, both those
2347 obseleted by and obselete before the above changes.
2348 * res.rc: Merge the 2 adjacent STRINGTABLEs.
2349
8a264069
MB
23502004-10-27 Max Bowsher <maxb@ukf.net>
2351
2352 * Makefile.am (setup_SOURCES): Add "RECTWrapper.h". It was missing.
2353
b4b8ab8d
MB
23542004-10-25 Bas van Gompel <cygsup-patch.buzz@bavag.tmfweb.nl>
2355
2356 * package_source.cc (packagesource::set_canonical):
2357 Fix one-off in 'base' when ini is in same dir as package.
2358
49560a44
MB
23592004-10-25 Max Bowsher <maxb@ukf.net>
2360
2361 * main.cc (next_dialog): Remove this legacy global variable.
2362 * download.cc (do_download_thread): Return a value instead of setting
2363 a global variable, then returning void.
2364 (do_download_reflector): Look for the next dialog code as a return
2365 value instead of a global variable.
2366
99ff5a8b
MB
23672004-10-25 Max Bowsher <maxb@ukf.net>
2368
2369 * port.h: Remove this redundant file - all contained definitions are
2370 duplicated in "win32.h".
2371 * Makefile.am, UserSetting.cc, UserSettings.cc, archive.cc,
2372 archive_tar.cc, archive_tar_file.cc, choose.cc, compress.cc,
2373 compress_bz.cc, compress_gz.cc, desktop.cc, find.cc, fromcwd.cc,
2374 iniparse.y, install.cc, io_stream_cygfile.cc, io_stream_file.cc,
2375 main.cc, netio.cc, site.cc, version.cc:
2376 Remove all references to "port.h".
2377
46d04e97
MB
23782004-10-25 Max Bowsher <maxb@ukf.net>
2379
2380 Fix compilation with w32api 3.1 and later.
2381
2382 * ControlAdjuster.h, RECTWrapper.h, cistring.h, propsheet.h,
2383 window.cc, window.h: Include "win32.h" not <windows.h> directly.
2384 * win32.h (WINBASEAPI): Define to empty string.
2385
5524909e
IP
23862004-09-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2387
2388 * script.cc (run): Kill stdin when running scripts.
2389
84b9cc5e
MB
23902004-09-01 Max Bowsher <maxb@ukf.net>
2391
2392 * Makefile.am: Oops. Unwanted keyword expansion ate the code of the
2393 previous commit. Restore the code, escaped to not look like a keyword.
2394
012374fe
MB
23952004-09-01 Max Bowsher <maxb@ukf.net>
2396
2397 * Makefile.am: Simplify the shell incantation for getting the revision
2398 of ChangeLog from grep-and-sed to just sed.
2399
b4113ac0
MB
24002004-08-31 Max Bowsher <maxb@ukf.net>
2401
2402 Attain GCC 3.4 compatibility.
2403
2404 * PackageSpecification.h (PackageSpecification): Make the
2405 unnecessarily private copy-constructor public.
2406
fc2ba841
MB
24072004-08-30 Max Bowsher <maxb@ukf.net>
2408
2409 Rework the implementation of not including -Werror for specific files,
2410 to a way that does not require hardcoding modified automake output back
2411 into its input.
2412
2413 * Makefile.am (AM_CXXFLAGS, BASECXXFLAGS): Seperate out -Werror.
2414 (autoload.o): Drop this rule, -finline-functions is no longer required
2415 and -Werror is acceptable here now we have __attribute__ ((used)).
2416 (WARNONLY_CFLAGS, inilex.o): Drop these.
2417 (EXTRA_PROGRAMS): Add a fake "warnonly" program.
2418 (warnonly_CXXFLAGS): Set to the $(BASECXXFLAGS).
2419 (warnonly_SOURCES): Set to "inilex.cc".
2420 (EXTRA_setup_SOURCES): Set to $(warnonly_SOURCES).
2421 (setup_SOURCES): Remove "inilex.cc".
2422 (setup_LDADD): Add "warnonly-inilex.o".
2423
d3c2a043
MB
24242004-08-30 Max Bowsher <maxb@ukf.net>
2425
2426 Move closer to GCC 3.4 compatibility.
2427
2428 * IOStreamProvider.h, io_stream_cygfile.cc, io_stream_cygfile.h,
2429 io_stream_file.cc: Do not incorrectly use "enum" after it has been
2430 hidden inside a typedef.
2431 * archive.h: In "virtual func() = 0;", the 0 is a language construct,
2432 not some symbol that might evaluate to 0, and gcc 3.4 enforces this.
2433 * autoload.c (DllInfo.name): Silence warning by making const.
2434 (DLL, autoload_common): __attribute__ ((used)) is now required to
2435 prevent gcc being over-eager in it's optimization, and removing these
2436 seemingly-unused (used only from assembly) functions.
2437 Silences some warnings, too.
2438 * Makefile.am (AM_CXXFLAGS, AM_CFLAGS): The options
2439 -Wstrict-prototypes -Wmissing-prototypes do not apply to C++ and
2440 g++ 3.4 complains about them.
2441
072fb49a
MB
24422004-08-29 Max Bowsher <maxb@ukf.net>
2443
ca2b7505 2444 * Exception.h: Reformatting, #include more, remove incorrect and
072fb49a
MB
2445 less-than-useful comments.
2446 (TOPLEVEL_CATCH): New preprocessor macro.
2447
2448 * LogFile.cc (LogFile::operator()): Throw an exception object, not a
2449 char* string.
2450
2451 Wrap the top-level of each thread (including the main thread) in a
2452 try...catch block, in order to display a useful error message if an
2453 exception is not caught.
2454 * download.cc (do_download_reflector): Here ...
2455 * ini.cc (do_ini_thread_reflector): ... and here ...
2456 * install.cc (do_install_reflector: ... and here ...
2457 * main.cc (main): ... and here ...
2458 * postinstall.cc (do_postinstall_thread): ... and here ...
2459 * site.cc (do_download_site_info_thread): ... and here!
2460
2461 * msg.h: Include a missing header requirement.
2462 * res.rc (IDS_UNCAUGHT_EXCEPTION, IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO):
2463 New strings.
2464 * resource.h (IDS_UNCAUGHT_EXCEPTION)
2465 (IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO): New IDs.
2466
56c41dda
MB
24672004-08-28 Max Bowsher <maxb@ukf.net>
2468
2469 * res.rc (IDS_WINDOW_INIT_BADMSG): New string.
2470 * resource.h (IDS_WINDOW_INIT_BADMSG): New string resource ID.
2471 * window.cc (Window::FirstWindowProcReflector): Convert an abort()
2472 into a descriptive error.
2473
abdd4b38
MB
24742004-08-24 Max Bowsher <maxb@ukf.net>
2475
2476 The Doug Lee replacement malloc was no longer hooked up with the
2477 buildsystem in any way. Pruning the remaining unused file.
2478
2479 * dlmalloc.c: Removed.
2480
24649384
MB
24812004-08-18 Max Bowsher <maxb@ukf.net>
2482
ca2b7505 2483 "librsync is not wire-compatible with rsync 2.x, and is not likely
24649384
MB
2484 to be in the future." -- librsync.sourceforge.net
2485
2486 So, it is of no practical use to setup. Therefore, removing all
2487 rsync related files and code from setup.
2488
2489 * rsync: Directory removed.
2490 * Makefile.am: Remove rsync support from the buildsystem.
2491 * configure.in: Ditto.
2492 * README: Since it seems vanishingly unlikely that it will ever happen,
2493 remove rsync support from the wishlist.
2494 * io_stream_rsync.cc: Remove.
2495 * io_stream_rsync.h: Remove.
2496
2800a92a
RC
24972004-04-25 Robert Collins <rbtcollins@hotmail.com>
2498
24649384
MB
2499 * package_meta.cc (packagemeta::set_requirements): fix problem with
2500 libpcre0 not being pulled in automatically.
2800a92a 2501
304e9816
RC
25022004-04-25 Robert Collins <rbtcollins@hotmail.com>
2503
24649384
MB
2504 * IniDBBuilderPackage.cc (dumpAndList):
2505 Move out to packageversion for reuse.
304e9816 2506 * package_meta.cc (packagemeta::logAllVersions): log dependencies.
24649384
MB
2507 * package_version.cc (packageversion::depends):
2508 provide a const accessor.
304e9816
RC
2509 (dumpAndList): Moved from INIDBBuilder.cc.
2510 * package_version.h: declare new method and function.
2511
5419ce48
RC
25122003-12-21 Robert Collins <rbtcollins@hotmail.com>
2513
2514 * main.cc (main): Update to head libgetopt++ syntax.
2515
201741b7
RC
25162003-11-2 Robert Collins <rbtcollins@hotmail.com>
2517
2518 * ControlAdjuster.h (ControlPosition::CP_MIDDLE): Rename to
2519 CP_CENTERED.
2520 * ControlAdjuster.cc: Ditto.
2521
081bf320
RC
25222003-10-31 Frank Richter <frichter@gmx.li>
2523
ca2b7505
CF
2524 * localdir.cc (OnNext): When SelectDirectoryA() fails, display a
2525 message with the error returned from the system instead of just
081bf320
RC
2526 'could not change dir'. Also, offer the user to 'Retry', 'Ignore' the
2527 error or 'Abort' the directory change.
2528
4b6e5406
RC
25292003-10-31 Frank Richter <frichter@gmx.li>
2530
2531 * propsheet.cc (PropSheetWndProc): Don't do child resizing if a the
2532 window gets minimized. Otherwise some glitches (e.g. wrong child
2533 sizes) occur.
2534 Added support for WM_GETMINMAXINFO. Prevents the property sheet from
2535 getting smaller than the original size.
2536
576a2b0b
RC
25372003-11-1 Robert Collins <rbtcollins@hotmail.com>
2538
2539 * ControlAdjuster.h (ControlDimension): Add.
2540 (ControlAdjuster): Factor adjust functionality into ControlInfo.
2541 * ControlAdjuster.cc (ControlAdjuster::adjust): Ditto.
2542 (ControlAdjuster::ControlInfo::adjust): Ditto.
2543
a8d753b6
RC
25442003-10-31 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2545
2546 * ControlAdjuster.h (ControlPosition): New enum type.
2547 (ControlInfo::horizontalPos, ControlInfo::verticalPos): New
2548 instance variables.
2549 (ControlInfo::anchorLeft, ControlInfo::anchorTop,
2550 ControlInfo::anchorRight, ControlInfo::anchorBottom): Remove.
2551 * ControlAdjuster.cc (ControlAdjuster::AdjustControls): Switch to
2552 using position specifiers instead of anchors.
2553 * choose.cc (ChooserControlsInfo): Ditto.
2554 * proppage.cc (DefaultControlsInfo): Ditto.
2555 * propsheet.cc (PropSheetControlsInfo): Ditto.
2556 * site.cc (SiteControlsInfo): Position specifiers for site
2557 selection dialog controls.
2558 * threebar.cc (ThreeBarControlsInfo): Position specifiers for
2559 progress dialog controls.
2560
c9feb168
RC
25612003-10-27 Ralf Habacker <ralf.habacker@freenet.de>
2562
2563 * main.cc (HelpOption): New instance.
2564 (main): Added help command line option handling.
2565 * localdir.cc (LocalDirOption): New instance.
2566 (LocalDirSetting::load): allow setting localdir from command line.
2567
ee91d9be
RC
25682003-10-16 Frank Richter <frichter@gmx.li>
2569
ca2b7505
CF
2570 * ControlAdjuster.cc: New file, helper to move elements of a dialog
2571 along when the it's resized.
ee91d9be
RC
2572 * ControlAdjuster.h: Ditto.
2573 * Makefile.am: Add new source files.
2574 * proppage.cc (PropertyPage::DialogProc): Adjust some common
2575 controls (Cygwin icon top right, separator below) when a page is
2576 resized.
2577 (PropertyPage::PropertyPage): Dito.
2578 * propsheet.cc (IsDialog): New. Test whether a window is a dialog.
2579 Used internally by resize logic.
2580 (EnumPages): New. Used internally by resize logic: resizes the
2581 property sheet's individual pages.
2582 (PropSheetWndProc): New. Hook for the propery sheet window proc.
2583 (PropSheetProc): More style tweaks, add maximize box and thick border
2584 as well. Hook into the property sheet's window proc.
2585 (PropSheet::AdjustPageSize): New. Adjust the metrics of a single page
2586 to fit nicely into the property sheet. Part of resize logic.
2587 * res.rc (All dialogs): The top-right Cygwin icon and top separator
ca2b7505 2588 now have IDs distinct from IDC_STATIC, so their metrics can be
ee91d9be
RC
2589 adjusted upon a resize. Also, all those Cygwin icons are at the exact
2590 same spot now.
ca2b7505 2591 * choose.cc (ChooserPage::ChooserPage): Now the controls on the
ee91d9be
RC
2592 chooser page move/size when the page size is changed.
2593 * choose.h: Dito.
2594
1622a084
RC
25952003-10-23 Jerry D. Hedden <jerry@hedden.us>
2596
2597 * ConnectionSetting.cc (ConnectionSetting::load): Load proxysettings.
2598 (ConnectionSetting::save): Save proxy settings.
2599
7f6de8c0
RC
26002003-10-07 Robert Collins <rbtcollins@hotmail.com>
2601
2602 * proppage.h (PropertyPage::wantsActivation): const correctness fix.
2603
587a67fc
MB
26042003-08-19 Max Bowsher <maxb@ukf.net>
2605
2606 * win32.h: Define NOMINMAX only if not already defined - because
2607 libstdc++-v3 3.3.1 defines NOMINMAX itself.
2608
58b12a06
MB
26092003-08-03 Max Bowsher <maxb@ukf.net>
2610
2611 * ChangeLog: Fix broken line-wrapping throughout. Clarify that
2612 "Ran automake" in 2003-07-26 entry was in bz2lib and zlib subdirs.
2613
56a7c49e
MB
26142003-08-03 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2615
2616 * propsheet.cc (Copyright): Update copyright dates.
2617 (PropSheet::PropSheet): Remove NumPropPages initialization.
2618 (PropSheet::CreatePages): Use PropertyPages.size() instead of
2619 NumPropPages.
2620 (PropSheet::Create): Ditto.
2621 (PropSheet::AddPage): Change to use new PropertyPages std::vector<>.
2622 * propsheet.h (Copyright): Update copyright dates.
2623 (File Scope): Include <vector>.
2624 (PropSheet::PropertyPages): Change from array to vector<>.
2625 (PropSheet::NumPropPages): Remove.
2626
25130a4d
MB
26272003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2628
2629 Changes modified by Max Bowsher <maxb@ukf.net>
2630 * splash.cc (Copyright): Update copyright dates.
2631 (SplashPage::OnInit): Remove call to SetDlgItemFont(). Now handled in
2632 base class.
2633 * proppage.h (PropertyPage::setTitleFont): Declare.
2634 * proppage.cc (Copyright): Update copyright dates.
2635 (PropertyPage::DialogProc WM_INITDIALOG): Move all font setting code,
2636 including that from splash.cc into new function...
2637 (PropertyPage::setTitleFont): Create, using moved code. Change font
2638 "MS Sans Serif" to "MS Shell Dlg" in line with recent res.rc change.
2639 Set font for IDC_STATIC_WELCOME_TITLE here, to allow easy re-use of
2640 style for future "Finished" page.
2641
62489576
MB
26422003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2643
2644 * propsheet.cc: Include "resource.h".
2645 (PropSheet::Create): Add the Cygwin icon in the left of the title bar.
2646
106d8160
MB
26472003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2648
2649 * proppage.cc (PropertyPage::FirstDialogProcReflector): Modify comment.
2650
5296fc07
MB
26512003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2652
2653 * proppage.h (Copyright): Update copyright dates.
2654 (PropertyPage): Document OnNext and OnBack.
2655
5039f845
MB
26562003-07-31 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2657
2658 * proppage.cc (PropertyPage::Create): Use more self-documenting
2659 MAKEINTRESOURCE() instead of cast to LPCSTR.
2660
672d28ad
RC
26612003-07-31 Robert Collins <rbtcollins@hotmail.com>
2662
2663 * README: Mark completed items complete.
2664
c59b8da6
MB
26652003-07-31 Pierre Humblet <pierre.humblet@ieee.org>
2666
2667 * main.cc (set_default_sec): Set token owner from token user.
2668 Always try to set the token primary group to Users or Admins.
2669
25e21380
IP
26702003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2671
2672 * String++.h (String::replace): New instance functions.
2673 * String++.cc (String::replace): Implement.
2674 * filemanip.cc (backslash): Change to use String::replace.
2675 * desktop.cc (make_cygwin_bat): Escape '%' in path.
2676
346627e7
IP
26772003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2678
2679 * String++.h (TOSTRING): New macro.
2680 * UserSettings.cc (UserSettings::deRegisterSetting): Fix
2681 erroneous __LINE__/__FILE__ usage.
2682 * download.cc (validateCachedPackage, check_for_cached): Ditto.
2683 * geturl.cc (getUrlToStream): Ditto.
2684 * install.cc (md5_one): Ditto.
2685
d9f4a2ba
MB
26862003-07-30 Max Bowsher <maxb@ukf.net>
2687
2688 * ini.cc (do_ini_thread): Return bool.
2689 (do_ini_thread_reflector): Put returned bool in lParam.
2690 * threebar.cc (WM_APP_SETUP_INI_DOWNLOAD_COMPLETE): Rework for new
2691 meaning of lParam. Replace erroneous use of do_fromcwd with
2692 SetActivePageByID (IDD_SOURCE).
2693
39b42ff3
RC
26942003-07-30 Robert Collins <rbtcollins@hotmail.com>
2695
2696 * ConnectionSetting.cc: New file, persist connection type selection.
2697 * ConnectionSetting.h: Ditto.
2698 * net.cc: Hold a ConnectionSetting instance to trigger the logic.
2699 (NetPage::OnInit): Don't force net_method to any value.
2700 * Makefile.am: Add new source files.
2701
6ff96351
RC
27022003-07-30 Robert Collins <rbtcollins@hotmail.com>
2703
2704 * SourceSetting.cc: New file, persist source selection.
2705 * SourceSetting.h: Ditto.
2706 * source.cc: Hold a Source setting instance to trigger the logic.
2707 * Makefile.am: Add new source files.
2708
f0fd8856
RC
27092003-07-30 Robert Collins <rbtcollins@hotmail.com>
2710
2711 * UserSettings.h (UserSettings::settingFileForLoad): Extracted method
2712 from LocalDirSetting::load().
2713 * UserSettings.cc (UserSettings::settingFileForLoad): Ditto.
2714 * UserSettings.h (UserSettings::settingFileForSave): Extracted method
2715 from LocalDirSetting::save().
2716 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
2717 * localdir.cc (LocalDirSetting::load): Extract location logic to
2718 UserSettings.
2719 (LocalDirSetting::save): Extract location logic to UserSettings.
2720 * site.cc (SiteSetting::getSavedSites): Use
2721 UserSettings::settingFileForLoad.
2722 (SiteSetting::save): Use UserSettings::settingFileForSave.
2723
bb8e2353
RC
27242003-07-30 Robert Collins <rbtcollins@hotmail.com>
2725
ca2b7505 2726 * PickView.cc: Adjust ::GetClientRect(..) to the inherited one
bb8e2353
RC
2727 throughout.
2728
b28e9f01
MB
27292003-07-29 Max Bowsher <maxb@ukf.net>
2730
2731 Based on a patch by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
2732 * AntiVirus.cc (AntiVirusPage::wantsActivation): Define.
2733 * AntiVirus.h (AntiVirusPage::wantsActivation): Declare.
2734 * localdir.cc (LocalDirPage::OnBack): Remove logic subsumed by
2735 RootPage::wantsActivation.
2736 * proppage.cc (PropertyPage::DialogProc): Call wantsActivation(),
2737 and skip to next page in sequence if activation is refused.
2738 * proppage.h (PropertyPage::wantsActivation): Default implementation.
2739 * root.cc (RootPage::wantsActivation): Define.
2740 * root.h (RootPage::wantsActivation): Declare.
2741 * source.cc: Don't include "AntiVirus.h".
2742 (SourcePage::OnNext): Remove logic subsumed by
2743 RootPage::wantsActivation.
2744 (SourcePage::OnBack): Remove logic subsumed by
2745 AntiVirusPage::wantsActivation.
2746 * splash.cc: Don't include "AntiVirus.h" or "dialog.h".
2747 (SplashPage::OnNext): Remove - subsumed by
2748 AntiVirusPage::wantsActivation.
2749 * splash.h (SplashPage::OnNext): Remove declaration.
2750
ec2dbbf0
RC
27512003-07-29 Robert Collins <rbtcollins@hotmail.com>
2752
2753 * PickView.h (PickView::refresh): New method.
2754 * PickView.cc (PickView::refresh): Extracted from various
2755 ChooserPage callers.
2756 * choose.cc: Use PickView::refresh wherever possible.
2757
bc16bb7d
RC
27582003-07-29 Robert Collins <rbtcollins@hotmail.com>
2759
2760 * choose.h (ChooserPage::createListView): Remove last parameter.
2761 (ChooserPage::getDefaultListViewSize): Extracted method.
2762 * choose.cc (ChooserPage::createListView): Remove last parameter.
2763 (ChooserPage::getDefaultListViewSize): Extracted method.
2764
952ea3fe
RC
27652003-07-29 Robert Collins <rbtcollins@hotmail.com>
2766
ca2b7505 2767 * choose.cc (ChooserPage::createListView): Remove unneeded
952ea3fe
RC
2768 parameter.
2769 * choose.h: Ditto.
2770
55c6e691
MB
27712003-07-29 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2772
2773 * dialog.h (do_fromcwd): Change function declaration.
2774 * fromcwd.cc (do_fromcwd): Change return type to bool. Eliminate
2775 use of next_dialog, return true or false instead.
2776 * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
2777 value instead of next_dialog.
2778
2f18f94d
RC
27792003-07-29 Robert Collins <rbtcollins@hotmail.com>
2780
2781 * package_db.h (packagedb::fillMissingCategory): Move from ChooserPage.
2782 * choose.h (ChooserPage::fillMissingCategory): Delete.
2783 * package_db.cc (packagedb::fillMissingCategory): Move from ChooserPage.
ca2b7505 2784 * choose.cc (ChooserPage::fillMissingCategory): Delete and adjust
2f18f94d
RC
2785 callers.
2786
525531ca
RC
27872003-07-29 Robert Collins <rbtcollins@hotmail.com>
2788
2789 * PickView.h (CATEGORY_EXPANDED): Move from choose.h
2790 (CATEGORY_COLLAPSED): Move from choose.cc.
2791 (PickView::setViewMode): Move from ChooserPage.
2792 * choose.h (CATEGORY_EXPANDED): Delete.
2793 (CATEGORY_COLLAPSED): Delete.
2794 (ChooserPage::setViewMode): Delete.
2795 * PickView.cc (PickView::setViewMode): Move from ChooserPage.
2796 * chooser.cc (ChooserPage::setViewMode): Delete, and adjust callers
2797 throughout.
2798
0f61a6a4
MB
27992003-07-28 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2800
2801 * AntiVirus.cc (AntiVirusPage::OnNext): Do not explicitly specify the
2802 page to display next, since it follows in the default page ordering
2803 anyway.
2804
6d751ec8
MB
28052003-07-28 Max Bowsher <maxb@ukf.net>
2806
2807 * dialog.h: (NEXT): Remove obsolete macro.
2808 * site.cc (save_dialog): Remove use of NEXT(), and non-functional
2809 unnecessary error handler.
2810
358712d8
RC
28112003-07-28 Robert Collins <rbtcollins@hotmail.com>
2812
2813 * package_meta.h (packagemeta::addToCategoryAll): Declare.
ca2b7505 2814 * package_meta.cc (packagemeta::addToCategoryAll): New method,
358712d8
RC
2815 separated to allow clear iteration.
2816 * choose.cc (ChooserPage::fillMissingCategory): BUGFIX: "all" is
2817 meant to be added unconditionally.
2818
31f0ccce
RC
28192003-07-27 Robert Collins <rbtcollins@hotmail.com>
2820
2821 * Generic.h: New file, home for generic programming tools.
2822 (visit_if): Move here from package_meta.cc.
2823 Adjust to be fully parameterised.
ca2b7505 2824 * package_meta.h (packagemeta::hasNoCategories): Query for generic
31f0ccce
RC
2825 programming.
2826 (packagemeta::setDefaultCategories): set categories for packages
2827 with none.
ca2b7505 2828 * package_meta.cc: Move visit_if out. Adjust users for
31f0ccce
RC
2829 full paramterised operation.
2830 (packagemeta::hasNoCategories): Implement.
2831 (packagemeta::setDefaultCategories): Implement.
2832 * choose.cc (ChooserPage::fillMissingCategory): Use visit_if to
2833 reduce duplicate code.
2834 (ChooserPage::setExistence): Delete.
ca2b7505 2835 * choose.h (ChooserPage::setExistence): Rename to
31f0ccce
RC
2836 packagedb::setExistence.
2837 * package_db.h (packagedb::setExistence): Declare.
2838 * package_db.cc (packagedb::setExistence): Copy from choose.cc
2839
dbdc1d9d
RC
28402003-07-27 Robert Collins <rbtcollins@hotmail.com>
2841
2842 * localdir.h (LocalDirPage::OnInit): Remove.
2843 * localdir.cc (LocalDirPage::OnInit): Move to LocalDirSetting
2844 ::load().
2845 (LocalDirSetting::load): Copied from LocalDirPage::OnInit.
2846 * site.h (SitePage::OnInit): Remove.
2847 (SitePage::getSavedSites): New member, replaces get_saved_sites.
ca2b7505 2848 (SitePage::registerSavedSite): New member, replaces
dbdc1d9d
RC
2849 register_saved_site.
2850 * site.cc (SitePage::OnInit): Move to SiteSetting::load().
2851 (SiteSetting::load): Copied from SitePage::OnInit.
2852 (SitePage::getSavedSites): Renamed from get_saved_sites.
2853 (SitePage::registerSavedSite): Renamed from register_saved_site.
2854 (do_download_site_info_thread): Don't look at the list size for
2855 determining if the download was successful.
2856
22120c90
RC
28572003-07-27 Robert Collins <rbtcollins@hotmail.com>
2858
ca2b7505 2859 * choose.h (ChooserPage::setViewMode): Remove HWND from
22120c90
RC
2860 signature.
2861 (ChooserPage::defaultTrust): Ditto.
2862 Move to PickView.
ca2b7505 2863 (ChooserPage::ifChecked): Use Window helper function
22120c90
RC
2864 IsButtonChecked.
2865 * choose.cc (ChooserPage::setViewMode): Use chooser->GetHWND()
2866 throughout.
2867 Update all callers with new signature.
2868 (ChooserPage::defaultTrust): Ditto.
2869 Move to PickView.
2870 * PickView.h (PickView::defaultTrust): Declare.
2871 * PickView.cc (PickView::defaultTrust): Copy from chooser.cc.
2872
9c9cfce7
RC
28732003-07-27 Robert Collins <rbtcollins@hotmail.com>
2874
2875 * PickView.h (PickView::lv): Eliminate.
2876 * PickView.cc (PickView::init): Replace use of lv with
2877 GetHWND().
ca2b7505 2878 (PickView::list_click): Ditto.
9c9cfce7
RC
2879 * choose.h (ChooserPage::lv): Eliminate.
2880 * choose.cc: Replace lv with chooser->GetHWND()
2881 throughout.
2882
d2be933d
RC
28832003-07-27 Robert Collins <rbtcollins@hotmail.com>
2884
2885 * PickView.h (PickView::chooser): Eliminate.
2886 (PickView::list_vscroll): Make non-static.
2887 (PickView::list_hscroll): Ditto.
2888 (PickView::list_click): Ditto.
2889 (PickView::paint): Ditto.
2890 * PickView.cc (PickView::list_vscroll): Eliminate use
2891 of PickView::chooser.
2892 (PickView::list_hscroll): Ditto.
2893 (PickView::list_click): Ditto.
2894 (PickView::paint): Ditto.
2895 * choose.cc (Chooser::createListView): Eliminate use
2896 of PickView::chooser.
2897
693916f8
RC
28982003-07-27 Robert Collins <rbtcollins@hotmail.com>
2899
2900 * PickView.h (PickView): Inherit from Window.
2901 (PickView::RegisterWindows): Move from ChooserPage.
2902 (PickView::listview_proc): Likewise.
2903 (PickView::paint): Ditto.
2904 (PickView::list_click): Ditto.
2905 (PickView::list_hscroll): Ditto.
2906 (PickView::list_vscroll): Ditto.
2907 (PickView::lv): Ditto.
2908 (PickView::chooser): Ditto.
2909 (PickView::Create): Override Windows::Create as we migrate.
2910 (PickView::registerWindowClass): Renamed RegisterWindows.
2911 (PickView::WindowClassAtom): Prevent double registration.
2912 (PickView::init): Declare.
2913 * PickView.cc: Adjust for new inheritance.
2914 (PickView::RegisterWindows): Move from ChooserPage.
2915 (PickView::listview_proc): Likewise.
2916 (PickView::paint): Ditto.
2917 (PickView::list_click): Ditto.
2918 (PickView::list_hscroll): Ditto.
2919 (PickView::list_vscroll): Ditto.
2920 (PickView::lv): Ditto.
2921 (PickView::chooser): Ditto.
2922 (PickView::Create): Introduce stub.
2923 (PickView::RegisterWindows): Rename
2924 (PickView::init): Extracted from constructor to allow
2925 reordering.
ca2b7505 2926 * chooser.h (ChooserPage::registerWindows): Rename to
693916f8
RC
2927 PickView::RegisterWindows.
2928 (ChooserPage::listview_proc): Likewise.
2929 (ChooserPage::paint): Ditto.
2930 (ChooserPage::list_click): Ditto.
2931 (ChooserPage::list_hscroll): Ditto.
2932 (ChooserPage::list_vscroll): Ditto.
ca2b7505 2933 (ChooserPage::lv): Duplicate into PickView, observe
693916f8
RC
2934 as non-static.
2935 (ChooserPage::chooser): Ditto.
2936 * chooser.cc (ChooserPage::registerWindows): Delete.
2937 (ChooserPage::listview_proc): Ditto.
2938 (ChooserPage::paint): Ditto.
2939 (ChooserPage::list_click): Ditto.
2940 (ChooserPage::list_hscroll): Ditto.
2941 (ChooserPage::list_vscroll): Ditto.
2942 (ChooserPage::createListView): Create() on PickView.
ca2b7505 2943 * window.h (Window::RegisterWindowClass): Make virtual
693916f8
RC
2944 to allow Create to become a Template Method, and rename
2945 to registerWindowClass as it's not static.
2946 * window.cc (Window::registerWindowClass): Ditto.
2947 (Window::FirstWindowProcReflector): BUGFIX: Set window
2948 handle to prevent races with the window procedure.
2949
724c2956
RC
29502003-07-27 Robert Collins <rbtcollins@hotmail.com>
2951
2952 * choose.cc (set_view_mode): Rename to ChooserPage::setViewMode.
2953 (default_trust): Rename to ChooserPage::defaultTrust.
2954 (fill_missing_category): Rename to ChooserPage::fillMissingCategory.
2955 (set_existence): Rename to ChooserPage::setExistence.
2956 (register_windows): Rename to ChooserPage::registerWindows.
2957 (listview_proc): Rename to ChooserPage::listview_proc.
2958 (paint): Rename to ChooserPage::paint.
2959 (list_click): Rename to ChooserPage::list_click.
2960 (list_hscroll): Rename to ChooserPage::list_hscroll.
2961 (list_vscroll): Rename to ChooserPage::list_vscroll.
2962 (lv): Rename to ChooserPage::lv.
2963 (chooser): Rename to ChooserPage::chooser.
2964 * choose.h (ChooserPage::setViewMode): Declare.
2965 (ChooserPage::defaultTrust): Declare.
2966 (ChooserPage::fillMissingCategory): Declare.
2967 (ChooserPage::setExistence): Declare.
2968 (ChooserPage::registerWindows): Declare.
2969 (ChooserPage::listview_proc): Declare.
2970 (ChooserPage::paint): Declare.
2971 (ChooserPage::list_click): Declare.
2972 (ChooserPage::list_hscroll): Declare.
2973 (ChooserPage::list_vscroll): Declare.
2974 (ChooserPage::lv): Declare.
2975 (ChooserPage::chooser): Declare.
2976
d05ae76a
RC
29772003-07-27 Robert Collins <rbtcollins@hotmail.com>
2978
ca2b7505 2979 * choose.cc (create_listview): Use for_each instead of explicit
d05ae76a
RC
2980 iteration.
2981 (create_listview): Rename to ChooserPage::createListview.
2982 * package_meta.h (packagemeta::set_requirements): Explicitly separate
2983 the 1 and 2 parameter versions.
2984
29852003-07-27 Robert Collins <rbtcollins@hotmail.com>
69711722
RC
2986
2987 * String++.h (String::operator !=): Declare for char * and String.
2988 * String++.cc (String::operator !=): Implement.
2989 * package_meta.cc(StringConcatenator): Move above all users.
2990 (_visit_if): Predicate support for visitors.
ca2b7505 2991 (packagemeta::getReadableCategoryList): Refactor to use
69711722
RC
2992 StringConcatenator with a predicate.
2993 * choose.h: Remove unneeded c++ guards.
2994
cda26207
RC
29952003-07-26 Robert Collins <rbtcollins@hotmail.com>
2996
58b12a06
MB
2997 * choose.cc (scan_downloaded_files): Rename to
2998 packagemeta::ScanDownloadedFiles.
cda26207
RC
2999 (scanAVersion): Rename to packageversion::scan.
3000 (GetParentRect): Rename to ChooserPage::getParentRect.
3001 * choose.h (ChooserPage::getParentRect): Declare.
3002 * package_meta.h (packagemeta::ScanDownloadedFiles): Declare.
3003 * package_version.h (packageversion::scan): Declare.
3004 * package_version.cc (packageversion::scan): Move from choose.cc
58b12a06
MB
3005 * package_meta.cc (packagemeta::ScanDownloadedFiles): Move from
3006 choose.cc
cda26207 3007
edc3c6fc
RC
30082003-07-26 Robert Collins <rbtcollins@hotmail.com>
3009
3010 * choose.cc (ChooserPage::OnNext): log before starting activity threads.
3011 (ChooserPage::OnInit): Remove temporary variable frame.
3012 (ChooserPage::setPrompt): Extract method from OnInit.
3013 (choose_inst_text): Remove unused variable.
3014 * choose.h(ChooserPage::setPrompt): Declare
3015 * res.rc (IDD_CHOOSE): Bugfix: the chooser was setting a non-present
3016 caption.
3017
d55e14fe
RC
30182003-07-26 Robert Collins <rbtcollins@hotmail.com>
3019
3020 Remove package specific code from choose.cc.
3021 Update copyrights where appropriate.
3022 * choose.cc(ChooserPage::OnNext): Extract logging to
3023 packagemeta::logSelectionStatus.
3024 * package_meta.cc(packagemeta::logSelectionStatus): Extract from
3025 ChooserPage::OnNext.
3026 (StringConcatenator): helper for logSelectionStatus.
3027 (action_caption): Make const.
3028 * package_meta.h(packagemeta): Declare logSelectionStatus.
3029 (packagemeta::action_caption): Make const.
3030 * package_version.cc(packageversion::sourcePackage): Make const.
3031 * package_version.h(packageversion::sourcePackage): Make const.
3032
12f8ac69
RC
30332003-07-26 Robert Collins <rbtcollins@hotmail.com>
3034
3035 * choose.cc: Update copyright.
3036 (ChooserPage::keepClicked): Extracted from OnMessageCmd.
3037 (ChooserPage::changeTrust): Ditto.
3038 * choose.h (ChooserPage): Declare keepClicked and changeTrust.
3039 (ChooserPage::ifChecked): Extracted from OnMessageCmd.
58b12a06
MB
3040 * package_meta.h (SetRequirement): Adapter for visiting package
3041 collections.
12f8ac69 3042
93d7e783
MB
30432003-07-26 Max Bowsher <maxb@ukf.net>
3044
3045 * tests/.cvsignore: New file, listing Makefile.in.
3046
dea6cc21
RC
30472003-07-26 Robert Collins <rbtcollins@hotmail.com>
3048
3049 Save used local cache dir from initial run of setup, so the user doesn't
3050 need to retype it.
58b12a06
MB
3051 * localdir.h (LocalDirSetting): UserSetting class for the local cache
3052 dir.
3053 * localdir.cc (LocalDirSetting::save): Replace save_local_dir, and
3054 update callers.
dea6cc21 3055
0df9be37
RC
30562003-07-26 Robert Collins <rbtcollins@hotmail.com>
3057
ca2b7505 3058 Save used site from initial run of setup, so the user doesn't need to
0df9be37
RC
3059 retype it.
3060 * main.cc (main): Load and save all user settings.
3061 * site.cc (SiteSetting::save): Migrate logic from save_site_url.
58b12a06
MB
3062 (SitePage::OnNext): Use ChosenSites.save() to remove uneeded
3063 save_site_url call.
0df9be37
RC
3064 (save_site_url): Delete.
3065 * site.h (save_site_url): Remove declaration.
3066 * .cvsignore: Update autoconf generated files.
3067
bf137801
RC
30682003-07-26 Robert Collins <rbtcollins@hotmail.com>
3069
3070 * tests/Makefile.am: Driver for test suite.
3071 * tests/UserSettingTest.cc: Test UserSetting interface.
3072 * tests/UserSettingsTest.cc: Test UserSettings interface.
3073 * Makefile.am: Add the tests dir to recurse into.
3074 * configure.in: Ditto.
58b12a06
MB
3075 * UserSetting.h: Add load and save methods to allow global
3076 serialisation.
bf137801
RC
3077 Add explicit copy and assignment operators to prevent synthetics.
3078 Make the constructor protected to prevent direct instantiation.
3079 * UserSettings.h (UserSettings::loadAllSettings): New method.
3080 (UserSettings::savedAllSettings): New method.
3081 * UserSettings.cc: Implement new methods.
3082 * site.cc: Implement stubs for new required UserSetting methods.
3083 * site.h (ChosenSite): Ditto.
58b12a06
MB
3084 * bz2lib/: Ran automake.
3085 * zlib/: Ran automake.
bf137801 3086
3d5a4f16
MB
30872003-07-23 Max Bowsher <maxb@ukf.net>
3088
3089 * desktop.cc (DesktopSetupPage::OnBack): Remove obsolete use of NEXT().
3090 * root.cc (RootPage::OnNext): Ditto.
3091 (RootPage::OnBack): Ditto.
3092 * install.cc (do_install_thread): Remove obsolete use of next_dialog.
3093 * main.cc (main): Ditto.
3094 * postinstall.cc (do_postinstall_thread): Ditto.
3095
7108d406
MB
30962003-07-23 Max Bowsher <maxb@ukf.net>
3097
3098 * dialog.h (do_choose, do_desktop, do_local_dir, do_net, do_other)
3099 (do_root, do_site, do_source, do_splash): Remove declarations, since
3100 these functions no longer exist.
3101
b1c23913
MB
31022003-07-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3103
3104 * choose.cc (initialized): Remove obsolete file scope variable.
3105
d52a6cc8
MB
31062003-07-18 Max Bowsher <maxb@ukf.net>
3107
3108 * res.rc: Make caption of every dialog page begin with "Cygwin Setup".
3109 This aids recognition when minimized.
3110 Prompted by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
3111
9d53f045
MB
31122003-07-10 Jeremy White <jwhite@codeweavers.com>
3113
3114 * mount.cc, root.cc, site.cc: Make StringOptions required,
3115 thereby making --longopt <parm> behave as a newbie would expect.
3116
12e726c4
MB
31172003-07-08 Max Bowsher <maxb@ukf.net>
3118
3119 * LogFile.h, cistring.h, dialog.h, diskfull.h, filemanip.h, geturl.h,
3120 hash.h, log.h, mkdir.h, mklink2.h, mount.h, msg.h, netio.h, nio-file.h,
3121 nio-ftp.h, nio-http.h, nio-ie5.h, port.h, simpsock.h, state.h,
3122 version.h: Add inclusion guard.
3123 * root.h: Standardize naming of inclusion guard.
3124
c93bc6d0
MB
31252003-06-23 Max Bowsher <maxb@ukf.net>
3126
3127 * AntiVirus.h, Exception.h, FilterVisitor.h, FindVisitor.h,
3128 IOStreamProvider.h, IniDBBuilder.h, IniDBBuilderPackage.h,
3129 IniParseFeedback.h, IniParseFindVisitor.h, LogSingleton.h, MD5++.h,
3130 PackageSpecification.h, PackageTrust.h, PickCategoryLine.h, PickLine.h,
3131 PickPackageLine.h, PickView.h, RECTWrapper.h, ScanFindVisitor.h,
3132 String++.h, UserSetting.h, UserSettings.h, archive.h, archive_tar.h,
3133 category.h, choose.h, compress.h, compress_bz.h, compress_gz.h,
3134 cygpackage.h, desktop.h, download.h, find.h, ini.h, io_stream.h,
3135 io_stream_cygfile.h, io_stream_file.h, io_stream_memory.h,
3136 io_stream_rsync.h, localdir.h, net.h, package_db.h, package_meta.h,
3137 package_source.h, package_version.h, proppage.h, propsheet.h, script.h,
3138 site.h, source.h, splash.h, threebar.h, win32.h, window.h:
3139 Standardize naming and placement of inclusion guards.
3140
4a2af5fb
MB
31412003-06-22 Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>
3142
3143 * res.rc (all dialogs): Change font from "MS Sans Serif" to
3144 "MS Shell Dlg".
3145
8b726ef6
MB
31462003-06-22 Max Bowsher <maxb@ukf.net>
3147
3148 * Makefile.am: Clarify comment.
3149 Derive AM_CFLAGS from AM_CXXFLAGS, rather than the other way around.
3150 (AM_CXXFLAGS): Remove -Wmissing-declarations - it is a C-only warning.
3151 (AM_CFLAGS): Add -Winline, and -Wmissing-declarations.
3152
1e9ebf8a
MB
31532003-06-22 Max Bowsher <maxb@ukf.net>
3154
3155 * rfc1738.cc (rfc1738_do_escape): Eliminate redundant conditional.
3156
0a539fe4
MB
31572003-06-05 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3158
3159 * window.h (SETUP_WINDOW_H): Rename multi-include guard.
3160 (Copyright): Update.
3161 (RECTWrapper): New forward declaration.
3162 (Window::Create): Move.
3163 (Window::MoveWindow): New overload declaration.
3164 * window.cc: (RECTWrapper.h) Include.
3165 (Copyright): Update.
3166 (Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
3167 of C-style casts.
3168 (Window::MoveWindow): New overload.
3169
3c0ca7aa
MB
31702003-05-31 Max Bowsher <maxb@ukf.net>
3171
3172 * res.rc: Resize title controls to fully fill available width.
3173
e0d021d0
MB
31742003-05-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3175
3176 * RECTWrapper.h: New file.
3177
1e3b2ad4
RC
31782003-04-12 Robert Collins <rbtcollins@hotmail.com>
3179
3180 * script.cc (Script::extension): Extract method from Script::run.
3181 (Script::run): Extract extension generation to Script::extension.
3182 * script.h (Script::extension): Declare.
3183
2533f348
RC
31842003-04-12 Robert Collins <rbtcollins@hotmail.com>
3185
3186 * script.cc (run_script): Remove.
3187 (try_run_script): Inline method run_script.
3188 * script.h (run_script): Remove.
3189
34ea5b6d
RC
31902003-04-12 Robert Collins <rbtcollins@hotmail.com>
3191
3192 * postinstall.cc (RunScript::operator()): Use new run syntax.
3193 * script.h (Script::run): Eliminate to_log parameter.
3194 * script.cc (Script::run): Ditto.
3195 (run_script): Use new run syntax.
3196
9f27ab95
RC
31972003-04-12 Robert Collins <rbtcollins@hotmail.com>
3198
3199 * script.cc (Script::run): Eliminate temp variable 'f2'.
3200 Rename temp variable 'f2' to 'windowsName' for increased clarity.
3201
783ed9c5
RC
32022003-04-12 Robert Collins <rbtcollins@hotmail.com>
3203
3204 * script.cc (Script::run): Eliminate temp variable 'fname'.
3205
0900bd5b
RC
32062003-04-12 Robert Collins <rbtcollins@hotmail.com>
3207
3208 * script.cc (Script::run): Eliminate temp variable 'dir'.
3209
294e5067
RC
32102003-04-12 Robert Collins <rbtcollins@hotmail.com>
3211
3212 * script.cc (run_script): Always pass TRUE to Script::run.
3213 * script.h (run_script): Remove optional to_log parameter.
3214
a0e56f67
RC
32152003-04-12 Robert Collins <rbtcollins@hotmail.com>
3216
3217 * script.cc (run_script): Move functionality into Script.
3218 (Script::run): Absorb run_script.
3219
8c242540
RC
32202003-04-12 Robert Collins <rbtcollins@hotmail.com>
3221
3222 * PickCategoryLine.cc (PickCategoryLine::click): Tell packagemeta we
3223 are about to perform a visit.
3224 * PickPackageLine.cc (PickPackageLine::click): Tell packagemeta we
3225 are about to perform a visit.
ca2b7505 3226 * package_db.cc (packagedb::markUnVisited): Convenience wrapper -
8c242540
RC
3227 mark all packages as unvisited.
3228 * package_db.h (packagedb::markUnVisited): Declare.
3229 * package_meta.cc (packagemeta::PrepareForVisit): New static method
3230 to prepare for a loop-free visit.
3231 (packagemeta::packagemeta): Adjust for new member.
3232 (packagemeta::set_requirements): Only visit a node once.
3233 (packagemeta::visited): Get and Set methods for new member visited_.
3234 * package_meta.h (packagemeta::PrepareForVisit): Declare.
3235 (packagemeta::visited): Declare.
3236 (packagemeta::visited_): Declare.
3237
5f4b0e57
MB
32382003-04-07 Max Bowsher <maxb@ukf.net>
3239
3240 * download.cc: Add command line option to suppress MD5 checks.
3241 (validateCachedPackage): Test option and possibly skip.
3242
e46e15bf
RC
32432003-04-02 Robert Collins <rbtcollins@hotmail.com>
3244
3245 Merge in setup-200303-troubleshooting fixes.
3246
32472003-04-02 Robert Collins <rbtcollins@hotmail.com>
3248
3249 * main.cc (NTSecurity::setDefaultDACL): Reinstate commented code.
3250 (NTSecurity::setDefaultSecurity): Ditto.
3251
32522003-04-02 Robert Collins <rbtcollins@hotmail.com>
3253
3254 * main.cc (NTSecurity::setDefaultDACL): Use MS calculations for ACL
3255 buffer sizing.
3256
32572003-04-02 Robert Collins <rbtcollins@hotmail.com>
3258
3259 * main.cc (NTSecurity::setDefaultDACL): Sanity check memory allocation.
3260
32612003-04-02 Robert Collins <rbtcollins@hotmail.com>
3262
58b12a06
MB
3263 * main.cc (NTSecurity::setDefaultDACL): Adjust commented code for
3264 auto_ptr use.
e46e15bf
RC
3265
32662003-04-02 Robert Collins <rbtcollins@hotmail.com>
3267
3268 * main.cc (NTSecurity::NoteFailedAPI): Helper function.
3269 Use throughout NTSecurity routines.
3270 (NTSecurity::setDefaultDACL): Use dynamic memory for ACL storage.
3271
32722003-04-02 Robert Collins <rbtcollins@hotmail.com>
3273
58b12a06
MB
3274 * main.cc (NTSecurity::setDefaultDACL): Disable ~ 50% of remaining
3275 active code.
e46e15bf
RC
3276
32772003-04-02 Robert Collins <rbtcollins@hotmail.com>
3278
3279 * main.cc (NTSecurity::GroupInfo): Extract group query code.
3280 (NTSecurity::setDefaultDACL): Disable ~ 50% of code.
3281
32822003-04-02 Robert Collins <rbtcollins@hotmail.com>
3283
58b12a06
MB
3284 * main.cc (NTSecurity::setDefaultSecurity): Disable ~ 50% of security
3285 code.
e46e15bf
RC
3286
32872003-04-01 Robert Collins <rbtcollins@hotmail.com>
3288
58b12a06
MB
3289 * main.cc (NTSecurity::setDefaultSecurity): Remove double declaration of
3290 sz. User TokenGroupCollection to abstract token searching logic,
3291 eliminate isadmin and isuser temporary variables.
e46e15bf
RC
3292 (TokenGroupCollection): New class for querying token group information.
3293
32942003-04-01 Robert Collins <rbtcollins@hotmail.com>
3295
3296 * main.cc (NTSecurity::setDefaultSecurity): Extract esid initialisation.
3297 Move local variables to just before first use.
3298 SetTokenInformationFailures where being handled inconsistently.
3299 Remove assignments from if statements.
3300 (NTSecurity::esid): Rename to everyOneSID.
3301 (NTSecurity::initialiseEveryOneSID): new method.
3302 (NTSecurity::setDefaultDACL): Extract method for default DACL logic.
3303
33042003-04-01 Robert Collins <rbtcollins@hotmail.com>
3305
3306 * main.cc (SIDWrapper): Manage SID memory.
3307 (HANDLEWrapper): Likewise for HANDLES.
3308 (NTSecurity): Worker class for set_default_sec().
3309 (set_default_sec): Move body into NTSecurity::setDefaultSecurity().
58b12a06
MB
3310 (NTSecurity::setDefaultSecurity): Eliminate goto out: via memory
3311 managing objects.
e46e15bf 3312
da0b54f3
MB
33132003-04-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3314
3315 * cygwin.ico: Added two new resolutions, 64x64 and 72x72.
3316
3baca7c9
RC
33172003-03-29 Robert Collins <rbtcollins@hotmail.com>
3318
3319 * GUIDELINES: New file documenting code guidelines.
3320
11e37aca
MB
33212003-03-26 Max Bowsher <maxb@ukf.net>
3322
3323 * .cvsignore: Add cfgaux.
3324
18a3405d
RC
33252003-03-26 Robert Collins <rbtcollins@hotmail.com>
3326
11e37aca
MB
3327 * package_version.cc (_defaultversion::accessible): Override and make
3328 always false.
3329 (_packageversion::accessible): Fix a couple of logic bugs resulting in
3330 incorrect trues.
18a3405d
RC
3331 * package_version.h (_packageversion::accessible): Make virtual.
3332
39ba3555
MB
33332003-03-25 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3334
3335 * threebar.h (WM_APP_START_POSTINSTALL): New message.
3336 (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message.
3337 * threebar.cc (ThreeBarProgressPage::OnMessageApp):
3338 Add handling for WM_APP_START_POSTINSTALL and
3339 WM_APP_POSTINSTALL_THREAD_COMPLETE.
3340 * install.cc (do_install_thread): Set next_dialog to
3341 IDD_S_POSTINSTALL.
3342 * desktop.cc (DesktopSetupPage::OnFinish): Move the
3343 do_postinstall call to ThreeBarProgressPage::OnMessageApp.
3344 * script.h (Script::fullName): New member function.
3345 (Script::run): New member function.
3346 (Script::ETCPostinstall): New static member constant.
3347 * script.cc (Script::fullName): Implement.
3348 (Script::run): Implement.
3349 (Script::ETCPostinstall): Define.
3350 (Script::isAScript): Use ETCPostinstall instead of a
3351 hardcoded string constant.
3352 (run): Enable "#if 0"'d code.
3353 * postinstall.cc (Progress): New extern variable.
3354 (RunFindVisitor::visitFile): Add script to vector
3355 instead of running.
3356 (RunFindVisitor::_scripts): New member variable.
3357 (RunScript): New helper class for use in for_each.
3358 (do_postinstall_thread): Rename do_postinstall to. Add
3359 Progress bar and text setting. Add package count.
3360 (do_postinstall_reflector): New static function.
3361 (do_postinstall): Rename to do_postinstall_thread.
3362 Create a thread instead.
3363
1069407c
MB
33642003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3365
3366 * script.cc (run): Add file_out parameter.
3367 Redirect output of subprocess to file, creating the
3368 path if necessary. Minimize the script window.
3369 (run_script): Add optional to_log boolean parameter.
3370 If to_log, redirect output to temporary file and then
3371 import it into LOG_BABBLE.
3372 (OutputLog): New helper class.
3373 (operator<<): New operation on OutputLog.
3374 * script.h (run_script): Add optional to_log parameter.
3375 * postinstall.cc (RunFindVisitor::visitFile): Instruct
3376 run_script() to log script output.
3377 (do_postinstall): Ditto.
3378
84fd41a9
RC
33792003-03-20 Robert Collins <rbtcollins@hotmail.com>
3380
ca2b7505 3381 * package_meta.cc (packagemeta::set_action): The logic
84fd41a9
RC
3382 test for the default action was reversed.
3383
864a5ec1
MB
33842003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3385
3386 * postinstall.cc (do_postinstall): Filter out '*.done'.
3387 * FilterVisitor.h: New header file. Declare the
3388 FilterVisitor, Filter, and ExcludeNameFilter classes.
3389 * FilterVisitor.cc: New file. Implement FilterVisitor,
3390 Filter, and ExcludeNameFilter.
3391 * String++.h (String::matches): New instance function.
3392 * String++.cc (String::matches): Implement.
3393 (strmatch) Import and adapt for <buf,len> strings.
3394 * Makefile.am (setup_SOURCES): Add FilterVisitor.cc and
3395 FilterVisitor.h to value.
3396
560ac5e2
MB
33972002-03-18 Max Bowsher <maxb@ukf.net>
3398
3399 * LogFile.cc (LogFile::exit): Use CRT exit() instead of ExitProcess().
3400 Use passed exit_code even if been_here.
3401 Remove incorrect _CYGWIN_ preprocessor conditional.
3402
ad646f43
RC
34032003-03-16 Robert Collins <rbtcollins@hotmail.com>
3404
e0312c44
RC
3405 * package_db.h (PackageDBConnectedIterator): Typedef
3406 for connected loop detection collection iterator.
ca2b7505
CF
3407 * package_db.cc (ConnectedLoopDetector): An
3408 implementation of R.E. Tarjans strongly connected
e0312c44
RC
3409 set visitor algorithm.
3410 * postinstall.cc (do_postinstall): Use the new iterator
3411 for visiting postinstall scripts.
ad646f43
RC
3412
34132003-03-16 Robert Collins <rbtcollins@hotmail.com>
3414
3415 * install.cc: Introduce Installer class.
3416 (init_dialog): Rename to Installer::initDialog.
3417 (progress): Rename to Installer::progress.
3418 (standard_dirs): Rename to Installer::StandardDirs.
3419 (uninstall_one): Rename to Installer::uninstallOne.
3420 (replace_one): Rename to Installer::replaceOne.
ca2b7505 3421 (log_ror_failure): Rename to
e0312c44 3422 Installer::replaceOnRebootFailed.
ca2b7505 3423 (log_ror_success): Rename to
e0312c44 3424 Installer::replaceOnRebootSucceeded.
ad646f43
RC
3425 (install_one_source): Rename to Installer::installOneSource.
3426 Note script files as they are installed.
3427 * package_version.cc (packageversion::addScript): Implement.
3428 (packageversion::scripts): Implement.
ca2b7505 3429 * package_version.h (packageversion::addScript): Record the
e0312c44 3430 presence of a script.
ad646f43 3431 * script.h (Script): New class to track scripts.
e0312c44
RC
3432 * postinstall.cc (do_postinstall): Iterate through the
3433 package listed scripts before searching for scripts.
ca2b7505 3434 * String++.cc (String::substr): Second argument needed to
e0312c44 3435 be signed.
ca2b7505 3436 * String++.h (String::substr): Second argument needed to
e0312c44 3437 be signed.
ad646f43 3438
c0a46d04
MB
34392003-03-16 Max Bowsher <maxb@ukf.net>
3440
3441 * .cvsignore: Create, to ignore configure, aclocal.m4, Makefile.in and
3442 autom4te.cache.
3443
3d7ae5a2
MB
34442003-03-16 Max Bowsher <maxb@ukf.net>
3445
3446 * UserSettings.cc (UserSettings::Instance): Remove premature return.
3447
92f9402a
RC
34482003-03-15 Robert Collins <rbtcollins@hotmail.com>
3449
3450 * script.cc (run): Rename variable b to createSucceeded.
3451
34522003-03-15 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3453
3454 * script.cc (run): Close unneeded handles.
3455
b49f570f
RC
34562003-03-15 Robert Collins <rbtcollins@hotmail.com>
3457
3458 * configure: Remove.
3459 * aclocal.m4: Remove.
3460 * Makefile.in: Remove.
3461 * cfgaux: Remove.
3462 * cfgaux/compile: Remove.
3463 * cfgaux/config.guess: Remove.
3464 * cfgaux/config.sub: Remove.
3465 * cfgaux/depcomp: Remove.
3466 * cfgaux/install-sh: Remove.
3467 * cfgaux/ltmain.sh: Remove.
3468 * cfgaux/missing: Remove.
3469 * cfgaux/mkinstalldirs: Remove.
3470
b6001c0d
MB
34712003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3472
3473 * install.cc (replace_one): Clear Text3.
3474
46ccc05f
MB
34752003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3476
3477 * install.cc (install_one_source): Add logging for successful
3478 replace-on-reboot scheduling. Factor out duplicate code.
3479 Set rebootneeded on Win9x.
3480 (log_ror_failure): New static function.
3481 (log_ror_success): New static function.
3482
c27b09ba
RC
34832003-03-14 Robert Collins <rbtcollins@hotmail.com>
3484
ca2b7505 3485 * choose.cc (ChooserPage::OnNext): Fix iterator bug. Reported by
c27b09ba
RC
3486 Igor Pechtchanski <pechtcha@cs.nyu.edu>.
3487
a081d4ff
MB
34882003-03-13 Max Bowsher <maxb@ukf.net>
3489
3490 * Update included zlib to 1.1.4.
3491
f430003c
RC
34922003-03-13 Robert Collins <rbtcollins@hotmail.com>
3493
46ccc05f
MB
3494 * install.cc (do_install_thread): Use a query method rather than temp
3495 variable do_skip.
f430003c 3496
46ccc05f 34972003-03-09 Pavel Tsekov <ptsekov@gmx.net>
f430003c 3498
ca2b7505 3499 * install.cc (do_install_thread): Use IDS_SKIP_PACKAGE
f430003c
RC
3500 instead of IDS_CORRUPT_PACKAGE when asking the user to take
3501 action if the hash verification check fails for a source package.
3502 Do not increase the value of 'total_bytes' variable if the
3503 user chooses to skip over a package, which failed the hash
3504 verification.
3505
48c7d667
MB
35062003-03-10 Max Bowsher <maxb@ukf.net>
3507
3508 * Makefile.am: Add foreign to AUTOMAKE_OPTIONS.
3509
aaeee283
RC
35102003-03-10 Robert Collins <rbtcollins@hotmail.com>
3511
3512 * UserSettings.cc (UserSettings::init): Really initialize all members.
3513
ead15931
RC
35142003-03-10 Robert Collins <rbtcollins@hotmail.com>
3515
3516 * Exception.h: Add a logic error exception id.
3517 * Makefile.am: Add new sources.
3518 * UserSettings.cc: New file.
3519 * UserSettings.h: New file.
3520 * UserSetting.cc: New file.
3521 * UserSetting.h: New file.
3522 * site.h: Add a SiteSetting as example of a UserSetting.
46ccc05f
MB
3523 * site.cc (ChosenSites): Add a instance of SiteSetting to trigger
3524 registration.
ead15931 3525
c1754473
RC
35262003-03-10 Robert Collins <rbtcollins@hotmail.com>
3527
46ccc05f
MB
3528 * compress_bz.cc (compress_bz::read): Adjust incorrect assignment of
3529 lasterr.
c1754473
RC
3530 (compress_bz::error): Return lasterr which will indicate any error.
3531
52620058
RC
35322003-03-10 Robert Collins <rbtcollins@hotmail.com>
3533
3534 * choose.h (ChooserPage): Override OnActivate.
46ccc05f
MB
3535 * choose.cc (ChooserPage::OnActivate): Refresh the current view when
3536 activating the dialog.
52620058 3537
6e754226
RC
35382003-03-09 Robert Collins <rbtcollins@hotmail.com>
3539
46ccc05f
MB
3540 * package_version.cc (_defaultversion::pick(bool)): Override this and
3541 do nothing.
3542 (packageversion::pick(bool): Use a mutator function rather than direct
3543 member access.
3544 * package_version.h (_packageversion::pick(bool)): Move method from
3545 _packageversion.
6e754226 3546
970149e8
RC
35472003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3548
ca2b7505 3549 * install.cc (install_one_source): Remove the MD5 verification
970149e8
RC
3550 code.
3551 Delay the creation of the package listing file.
ca2b7505 3552 (do_install_thread): Check the hashes for packages which need
970149e8
RC
3553 to be installed before the uninstall step. Allow the user to
3554 skip over packages, which fail the hash verification.
3555 (md5_one): Define new function.
3556 * res.rc (IDS_SKIP_PACKAGE): New string resource.
3557 * resource.h (IDS_SKIP_PACKAGE): New macro definition.
3558
f37b36a3
RC
35592003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3560
3561 * Exception.h: Declare new constructor.
3562 (Exception::_message): Change the type from 'const char *' to
3563 'class String'.
3564 (Exception::~Exception): Implement destructor (make gcc shut up).
3565 * Exception.cc: Implement new constructor.
3566 (Exception::what): Use String::cstr_oneuse ().
3567 * download.cc (validateCachedPackage): Use the constructor, which
3568 takes String& as its second argument, when throwing objects
3569 of type Exception.
3570 (check_for_cached): Ditto.
3571 * install.cc (install_one_source): Ditto.
3572
eef9ea26
RC
35732003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3574
3575 * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
3576 log filename to %s.
3577 (IDS_MISSING_LOG): New string resource.
3578 * resource.h (IDS_MISSING_LOG): New resource.
3579 * LogFile.cc (LogFile::exit): Pass log filename for
3580 LOG_BABBLE to note().
3581 (LogFile::getFileName): New function.
3582 * LogFile.h (LogFile::getFileName): New function.
3583
514b100e
RC
35842003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3585
3586 * String++.cc: Don't include concat.h.
3587 * Makefile.am: Remove concat.cc and concat.h references.
3588 * concat.h: Remove.
3589 * concat.cc: Remove.
3590
56c60dcc
MB
35912003-03-09 Max Bowsher <maxb@ukf.net>
3592
3593 * bootstrap.sh: Add sanity check of current directory.
3594 Recurse into libgetopt++ if needed.
3595
4f4b9def
RC
35962003-03-09 Robert Collins <rbtcollins@hotmail.com>
3597
3598 * Update readme of bugs and wishes.
3599
ed6137e5
MB
36002003-03-05 Max Bowsher <maxb@ukf.net>
3601
3602 * netio.cc (save_dialog): Allocate an empty string if the password is
3603 null, so that an empty password is accepted elsewhere in setup.
3604 (check_if_enable_ok): An empty password is OK.
3605
e0aec95e
MB
36062003-03-05 Brian Keener <bkeener@thesoftwaresource.com>
3607
ed6137e5 3608 * PickView.cc (PickView::views): Add two new views for Skipped
e0aec95e
MB
3609 packages and Installed Packages not requiring update.
3610 (PickView::set_headers () ): Ditto.
3611 (PickView::clear_view (void) ): Ditto.
3612 (PickView::views::caption () ): Add two new captions for the new
3613 views added for Skipped and Installed Packages.
3614 (PickView::scroll () ): Modify Scroll Bar property to Disable
ed6137e5 3615 instead of disappearing when there is nothing to Scroll.
e0aec95e
MB
3616 * PickView.h: Add two new views for Skipped packages and Installed
3617 packages to public class view.
3618 * choose.cc (list_click () ): Modify Scroll Bar property to Disable
ed6137e5 3619 instead of disappearing when there is nothing to Scroll.
e0aec95e
MB
3620 (listview_proc () ): Ditto.
3621 (set_view_mode): Add two new views for Skipped Packages and Installed
3622 Packages not requiring update. Modify Scroll Bar property to Disable
3623 instead of disappearing when there is nothing to scroll.
3624 * res.rc (IDD_CHOOSE): Reposition Radio Buttons, View Selection
3625 Button and View Button Caption to make room for longer captions.
3626
c7fb2f36
MB
36272003-03-04 Max Bowsher <maxb@ukf.net>
3628
3629 * compress_gz.cc (compress_gz::construct):
3630 Fix broken checkin dated 2002-07-03.
3631
d5be1d23
MB
36322003-02-28 Max Bowsher <maxb@ukf.net>
3633
3634 * main.cc (set_default_sec): Add logging.
3635
adaa168a
MB
36362003-02-28 Pierre Humblet <pierre.humblet@ieee.org>
3637
3638 * main.cc (set_default_dacl): Replace with set_default_sec.
3639 (set_default_sec): Attempt to change the default group to
3640 Users or Administrators if it is None, in addition to setting
3641 Everyone in the default DACL.
3642 (main): Call set_default_sec instead of set_default_dacl.
3643
3a8d1127
MB
36442003-01-31 Max Bowsher <maxb@ukf.net>
3645
3646 * install.cc (install_one_source): Fix spacing in log message.
3647
c7230a28
MB
36482003-01-19 Max Bowsher <maxb@ukf.net>
3649
3650 * resource.h (IDC_CHOOSE_KEEP): Define.
3651 * res.rc (IDD_CHOOSE): Add radio button IDC_CHOOSE_KEEP.
3652 * choose.cc (create_listview): Add IDC_CHOOSE_KEEP to ta[].
3653 (ChooserPage::OnMessageCmd): Handle new IDC_CHOOSE_KEEP button.
3654
ac949c48
MB
36552003-01-15 Max Bowsher <maxb@ukf.net>
3656
3657 * mkdir.cc [_CYGWIN_]: Implement what was pseudocode.
3658 * io_stream.h [__CYGWIN__]: Don't typedef ssize_t.
3659 * proppage.h: Include "win32.h" instead of <windows.h>.
3660
4f618d88
MB
36612003-01-15 Max Bowsher <maxb@ukf.net>
3662
3663 * mount.cc [MAINTAINER_FEATURES]: Add --override-registry-name option.
3664
1606c4e9
MB
36652002-12-11 Abraham Backus <abraham@backus.com>
3666
3667 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Leave port out of Host header,
3668 unless non-default.
3669
c4e25cde
MB
36702002-12-11 Max Bowsher <maxb@ukf.net>
3671
3672 * package_meta.cc: Change 'endl' to 'endLog' as appropriate.
3673 * package_version.cc: Ditto.
3674
bfdf6ac2
MB
36752002-09-22 Max Bowsher <maxb@ukf.net>
3676
3677 * PickView.cc (pkg_headers): Rename column 'Category' to 'Categories'.
3678 * package_meta.h (packagemeta::getReadableCategoryList): Declare.
3679 * package_meta.cc (packagemeta::getReadableCategoryList): Implement.
3680 * PickPackageLine.cc (PickPackageLine::paint): Change to use
3681 getReadableCategoryList.
3682 Fix x2 argument to IntersectClipRect.
3683
63c82708
RC
36842002-11-25 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3685
3686 * window.h (Window::GetWindowRect): New method declaration.
3687 (Window::GetClientRect): Ditto.
3688 (Window::MoveWindow): Ditto.
3689 (Window::ScreenToClient): Ditto.
3690 * window.cc (REFLECTION_INFO): Remove.
3691 (ReflectionInfo): Remove.
3692 (Window::FirstWindowProcReflector): Use the WM_NCCREATE message instead
3693 of the horrid REFLECTION_INFO hack to hook the Window instance to the
3694 HWND instance.
3695 (Window::WindowProcReflector): Use GetWindowLongPtr() now that it's
3696 available.
3697 (Window::Create): Change to use new WM_NCCREATE reflection procedure
3698 above.
3699 (Window::GetWindowRect): New method.
3700 (Window::GetClientRect): New method.
3701 (Window::MoveWindow): New method.
3702 (Window::CenterWindow): Use new methods, also specify "::" for some non-
3703 member functions with the same names.
3704 (Window::ScreenToClient): New method.
3705
58983805
RC
37062002-11-26 Robert Collins <rbtcollins@hotmail.com>
3707
3708 * AntiVirus.cc: Change the short option again! It's now 'A'.
3709 * desktop.cc (etc_profile): Remove.
3710 (make_etc_profile): Remove.
3711 (uexists): Remove.
3712 (make_passwd_group): Remove.
3713 (do_desktop_setup): Don't call removed functions.
3714
b2028692
RC
37152002-11-26 Robert Collins <rbtcollins@hotmail.com>
3716
3717 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fix my botched application of
3718 Marcel's patch.
3719
2d8e4784
RC
37202002-07-08 Marcel Telka <marcel@telka.sk>
3721
b2028692 3722 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fixed decoding of the FTP
2d8e4784
RC
3723 reply (code 227) to the PASV command.
3724
3a87705e
RC
37252002-11-26 Robert Collins <rbtcollins@hotmail.com>
3726
3727 * IniDBBuilderPackage.cc (IniDBBuilderPackage::~IniDBBuilderPackage):
3728 Sort the packages db once all the new packages have been added.
3729 * IniDBBuilderPackage.h (IniDBBuilderPackage::~IniDBBuilderPackage):
3730 Declare this.
3731
bd4e91a7
RC
37322002-11-26 Robert Collins <rbtcollins@hotmail.com>
3733
3734 * choose.cc (ChooserPage::OnNext): Remove extracted comment.
3735 * package_version.cc (processOneDependency): Return once selecting
3736 a package (bugfix to prevous rework).
3737 Log if the default trust fails the package specification.
3738
f416a2b6
RC
37392002-11-26 Robert Collins <rbtcollins@hotmail.com>
3740
3741 * package_meta.h (packagemeta::logAllVersions): Declare.
3742 (packagemeta::trustLabel): Ditto.
ca2b7505 3743 * choose.cc (ChooserPage::OnNext): Get each package to log all it's
f416a2b6
RC
3744 versions.
3745 * package_meta.cc (packagemeta::logAllVersions): Implement.
3746 (packagemeta::trustLabel): Ditto.
3747
14485ab2
RC
37482002-11-25 Robert Collins <rbtcollins@hotmail.com>
3749
3750 * AntiVirus.cc: Change 'd' to 'D' to fix command line conflict.
3751
f9e903a3
RC
37522002-11-25 Robert Collins <rbtcollins@hotmail.com>
3753
3754 * AntiVirus.cc: New file.
3755 * AntiVirus.h: Ditto.
3756 * LogFile.cc: Include AntiVirus.h for class definition.
3757 (LogFile::exit): Trigger AntiVirus::AtExit().
3758 * MakeFile.am(setup_SOURCES): Add AntiVirus files.
3759 * autoload.c: Declare Service Control Manager related API's.
3760 * main.cc: Include AntiVirus.h for class definition.
3761 (main): Add the AntiVirus page in.
3762 * res.rc: Define IDD_VIRUS.
3763 * resource.h: Define IDD_VIRUS related control ID's.
3764 * splash.h: Override OnNext.
3765 * splash.cc: Only show AntiVirus page when one has been detected.
3766 * source.cc: Ditto.
3767
05c5b8a6
RC
37682002-11-25 Robert Collins <rbtcollins@hotmail.com>
3769
3770 * package_version.cc (DependencyProcessor): Create convenience class.
3771 (select): Extract version selection method.
3772 (processOneDependency): Check for a satisfactory trusted version
3773 first.
3774
37752002-11-10 Robert Collins <rbtcollins@hotmail.com>
15004270
RC
3776
3777 * main.cc (main): Use the factory for LogFile.
3778 * String++.cc: Update to use sstream.
58b12a06 3779 (String::String): Use a ostringstream for libC++ 3.2.
15004270
RC
3780 * LogFile.h (LogFile): Make createLogFile static.
3781
05c5b8a6 37822002-11-10 Robert Collins <rbtcollins@hotmail.com>
51629951
RC
3783
3784 * main.cc (main): Oops, pass LogSingleton a reference, not a pointer.
3785
666bf37d
RC
37862002-11-04 Max Bowsher <maxb@ukf.net>
3787
3788 * Exception.h (Exception::what): Add throw() specification,
3789 to agree with libstdc++-v3.
3790 * Exception.cc (Exception::what): Ditto.
3791 * IniDBBuilderPackage.h: Add 'std::' where needed.
3792 * PickCategoryLine.h: Ditto.
3793 * category.h: Ditto.
3794 * package_db.h: Ditto.
3795 * package_meta.h: Ditto.
3796 * package_source.h: Ditto.
3797 * package_version.h: Ditto.
3798 * site.h: Ditto.
3799 * win32.h: Define NOMINMAX before including <windows.h>.
3800 * package_meta.cc: Add 'using namespace std;'.
3801 (packagemeta::set_requirements): Remove default parameter values
3802 from definition (gcc3 likes them only in declaration).
3803 * package_version.cc: Add 'using namespace std;'.
3804 (packageversion::set_requirements): Remove default parameter
3805 values from definition (gcc3 likes them only in declaration).
3806
37decc22
RC
38072002-11-10 Robert Collins <rbtcollins@hotmail.com>
3808
3809 * compress_bz.cc: Don't include bzlib.h directly, the compress_bz.h
3810 header includes it.
3811
38122002-11-04 Max Bowsher <maxb@ukf.net>
3813
ca2b7505
CF
3814 * compress_bz.h: #undef small before including bzlib.h - if we are
3815 going to hide the fact that we are _WIN32 from bzlib, then we need
37decc22
RC
3816 to #undef small for it as well (bad windows.h clash).
3817
a55c8f45
RC
38182002-11-10 Robert Collins <rbtcollins@hotmail.com>
3819
3820 * localdir.cc: Update the extern LogFile to be a pointer.
3821 (save_local_dir): Change . to -> for the above.
3822 * main.cc (theFile): Change from an instance to a pointer.
3823 (main): Change . to -> for the above.
3824
c83c52d8
RC
38252002-11-10 Robert Collins <rbtcollins@hotmail.com>
3826
3827 * LogFile.cc: use 'std::' where needed throughout.
3828 (LogFile::createLogFile): Implement a factory for LogFile.
3829 (LogFile::LogFile): Update for use with the factory, and to
3830 handle the latest g++ library changes.
3831 (LogFile::operator()): Ditto.
3832 (LogFile::endEntry()): Ditto.
3833 * LogFile.h: Ditto.
3834 * LogSingleton.cc: Ditto.
3835 * LogSingleton.h: Ditto.
3836
318af134
RC
38372002-11-04 Max Bowsher <maxb@ukf.net>
3838
3839 * String++.h: Add 'std::' where needed.
3840
6625e635
RC
38412002-11-04 Max Bowsher <maxb@ukf.net>
3842
3843 * IniDBBuilderPackage.cc: Add 'using namespace std;'.
3844 * IniParseFindVisitor.cc: Ditto.
3845 * LogFile.cc: Ditto.
3846 * LogSingleton.cc: Ditto.
3847 * PickView.cc: Ditto.
3848 * String++.cc: Ditto.
3849 * choose.cc: Ditto.
3850 * download.cc: Ditto.
3851 * find.cc: Ditto.
3852 * install.cc: Ditto.
3853 * io_stream.cc: Ditto.
3854 * io_stream_file.cc: Ditto.
3855 * package_db.cc: Ditto.
3856 * root.cc: Ditto.
3857 * site.cc: Ditto.
3858
955bf437
RC
38592002-11-04 Max Bowsher <maxb@ukf.net>
3860
3861 * LogSingleton.h: Add 'std::' where needed.
3862
b34fb59f
RC
38632002-11-04 Max Bowsher <maxb@ukf.net>
3864
3865 * archive_tar_file.cc: Include <algorithm>.
3866 Change min(a,b) to std::min(a,b)
3867 * compress_bz.cc: Ditto.
3868 * compress_gz.cc: Ditto.
3869
326fbcb8
RC
38702002-11-04 Max Bowsher <maxb@ukf.net>
3871
3872 * res.rc: Change a #-comment (invalid) to a //-comment.
3873
4361306f
RC
38742002-11-04 Max Bowsher <maxb@ukf.net>
3875
3876 * Makefile.am (%.o: %.rc): Make windres use $(CC) not hardcoded gcc.
58b12a06
MB
3877 (inilint_LDADD): Remove -lstd++.
3878 (setup_LDADD): Ditto.
4361306f 3879
05d7b7f2
RC
38802002-09-22 Max Bowsher <maxb@ukf.net>
3881
3882 * IniDBBuilderPackage.cc: Update DEBUG code to current class
3883 layout.
3884
f2ff9838
RC
38852002-09-21 Robert Collins <rbtcollins@hotmail.com>
3886
3887 * choose.h: Add OnUnattended method.
3888 * desktop.cc (DesktopSetupPage::OnInit): Allow fine grained
3889 control via command line options.
3890 (DesktopSetupPage::OnUnattended): Implement.
3891 (DesktopSetupPage::OnMessageApp): Implement.
3892 * desktop.h (DesktopSetupPage::OnUnattended): declare.
3893 (DesktopSetupPage::OnMessageApp): Ditto.
3894 * download.cc (do_download_thread): Support unattended mode.
3895 * install.cc (do_install_thread): Ditto.
3896 * localdir.h: Ditto.
3897 * main.cc (main): Ditto.
3898 * net.cc (NetPage::OnUnattended): Ditto.
3899 * net.h (NetPage::OnUnattended): Declare.
3900 * proppage.cc (PropertyPage::DialogProc): Support unattended mode.
3901 * proppage.h (PropertyPage::OnUnattended): Declare.
3902 * root.cc (RootPage::OnInit): Support unattended mode.
3903 (RootPage::OnUnattended): Implement.
3904 * root.h (RootPage::OnUnattended): Declare.
3905 * site.cc (register_saved_site): Extract Method from get_saved_sites.
3906 (get_saved_sites): Remove common code for adding a site.
3907 (SitePage::OnInit): Support unattended mode.
3908 (SitePage::OnUnattended): Implement.
3909 * site.h (SitePage::OnUnattended): Declare.
3910 * source.cc (SourcePage::OnActivate): Support unattended mode.
3911 (SourcePage::OnUnattended): Implement.
3912 * source.h (SourcePage::OnUnattended): Declare.
3913 * splash.h (SplashPage::OnUnattended): Declare.
3914 * state.cc (unattended_mode): Declare.
3915 * state.h (unattended_mode): Declare.
3916 * threebar.h (ThreeBarProgressPage::OnUnattended): New method.
3917
707f3d66
RC
39182002-09-21 Robert Collins <rbtcollins@hotmail.com>
3919
3920 * res.rc: Commit Harry Johnston's dialog caption patch. From July.
3921
ec13f13c
RC
39222002-07-15 Robert Collins <rbtcollins@hotmail.com>
3923
3924 * package_version.cc (packageversion::sources): Implement this.
3925 * download.cc (do_download_thread): Support multiple files per package.
3926
e5662e0a
RC
39272002-07-15 Robert Collins <rbtcollins@hotmail.com>
3928
3929 * package_version.h (packageversion::sources): Support multiple files in
3930 a single package version.
3931 * package_version.cc (_packageversion::accessible): Ditto.
3932 (packageversion::source): Ditto.
3933
60daae94
RC
39342002-07-15 Robert Collins <rbtcollins@hotmail.com>
3935
3936 * iniparse.y: Implement support for multiple source files for a source
3937 package.
3938 * IniDBBuilder.h (IniDBBuilder::buildSourceFile): Ditto.
3939 * IniDBBuilderPackage.h (IniDBBuilder::buildSourceFile): Ditto.
3940 * IniDBBuilder.cc (IniDBBuilder::buildSourceFile): Ditto.
ca2b7505 3941 * IniDBBuilderPackage.cc (IniDBBuilder::buildSourceFile): Implement a
60daae94
RC
3942 stub as preparation.
3943
4f591f9d
RC
39442002-07-13 Robert Collins <rbtcollins@hotmail.com>
3945
ca2b7505 3946 * PickPackageLine.cc (PickPackageLine::click): Set requirements for
4f591f9d
RC
3947 packages under all circumstances - slightly higher overheader, simpler
3948 code.
ca2b7505 3949 * download.cc (do_download_thread): Correctly download source
4f591f9d
RC
3950 packages.
3951 * package_meta.cc (checkForInstalled): Remove.
3952 (checkForUpgradeable): Ditto.
3953 (checkForSatisfiable): Ditto.
3954 (processOneDependency): Ditto.
3955 (packagemeta::set_requirements): Move guts to packageversion.
3956 * package_version.cc (checkForInstalled): Copied from package_meta.cc.
3957 (checkForUpgradeable): Ditto.
3958 (checkForSatisfiable): Ditto.
3959 (processOneDependency): Ditto.
3960 (packageversion::set_requirements): Ditto.
3961 * package_version.h (packageversion::set_requirements): Declare.
3962
b1ff53ed
RC
39632002-07-13 Robert Collins <rbtcollins@hotmail.com>
3964
3965 * IniDBBuilder.cc (IniDBBuilder::buildBeginBuildDepends): Implement.
3966 (IniDBBuilder::buildBeginBinary): Implement.
3967 * IniDBBuilder.h (IniDBBuilder::buildBeginBuildDepends): Declare.
3968 (IniDBBuilder::buildBeginBinary): Ditto.
3969 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildBeginBuildDepends):
3970 Implement.
3971 (IniDBBuilderPackage::buildBeginBinary): Ditto.
3972 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildBeginBuildDepends):
3973 Declare.
3974 (IniDBBuilderPackage::buildBeginBinary): Ditto.
3975 * inilex.l: Recognise Build-Depends-Indep, [,], >, < and remove
3976 T_UNKNOWN.
3977 * iniparse.y: Full support for parsing a debian Sources file in-line in
3978 setup.ini.
3979 * package_version.cc (packageversion::binaries): Implement.
3980 * package_version.h (packageversion::binaries): Declare list of what
3981 packages are created from a given source package.
3982 (_packageversion::binaries): Ditto.
3983
233a3e17
RC
39842002-07-10 Robert Collins <rbtcollins@hotmail.com>
3985
3986 * iniparse.y: Add basis for support for parsing a debian Sources file.
3987 * inilex.l: Ditto.
3988
cfae3b8d
RC
39892002-07-09 Robert Collins <rbtcollins@hotmail.com>
3990
3991 Change custom container code for packagedb::packages to STL containers
3992 throughout.
3993 * IniDBBuilderPackage.cc: Ditto.
3994 * PickView.cc: Ditto.
3995 * choose.cc: Ditto.
3996 * desktop.cc: Ditto.
3997 * download.cc: Ditto.
3998 * install.cc: Ditto.
3999 * package_db.cc: Ditto.
4000 * package_db.h: Ditto.
4001 * Makefile.am: Remove list.h references.
4002 * list.h: Remove.
4003
09130e58
RC
40042002-07-08 Max Bowsher <maxb@ukf.net>
4005
4006 * PickView.cc (PickView::PickView): Set font of package list header to
4007 the same as used in the rest of the package list.
4008
a75ed5ce
RC
40092002-07-08 Robert Collins <rbtcollins@hotmail.com>
4010
4011 * install.cc (NoReplaceOnReboot): New command line option to prevent
4012 replacing in use files.
4013 (install_one_source): Check the option and use it.
4014 * README: Update TODO lists.
4015
0cf68afd
RC
40162002-07-08 Robert Collins <rbtcollins@hotmail.com>
4017
ca2b7505 4018 * PickCategoryLine.cc: Change bucket to use STL container syntax
0cf68afd
RC
4019 throughout.
4020 (PickCategoryLine::paint): Use new Category type syntax.
ca2b7505 4021 * PickCategoryLine.h: Use STL vectors rather than custom containers
0cf68afd
RC
4022 throughout.
4023 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageCategory):
4024 Use new add_category syntax.
4025 * PickView.cc (PickView::insert_pkg): Use new Category type syntax.
4026 (PickView::insert_category): Ditto.
4027 (PickView::init_headers): Ditto.
4028 * category.cc: Trim obsolete code.
ca2b7505 4029 * category.h: Replace interconnecting class with a typedef to
0cf68afd
RC
4030 facilitate leveraging STL maps.
4031 * choose.cc (fill_missing_category): Use updated pkg.add_category
4032 syntax.
4033 (default_trust): Use new Category type syntax.
4034 (set_view_mode): Ditto.
4035 (create_listview): Ditto.
4036 * package_db.cc (categories): Ditto.
4037 * package_db.h: Update headers list to include needed headers.
4038 (packagedb::categories): Replace custom list with STL map.
4039 * package_meta.cc: Use new Category type syntax throughout.
4040 (packagemeta::add_category): Implement new syntax.
4041 * package_meta.h: Remove commented out source.
4042 (packagemeta::add_category): Update syntax to decouple interface from
4043 packagedb.
4044
89374d4a
CF
40452002-07-06 Christopher Faylor <cgf@redhat.com>
4046
4047 * site.cc (do_download_site_info_thread): Correct spelling error.
4048
405d7186
RC
40492002-07-06 Robert Collins <rbtcollins@hotmail.com>
4050
4051 * PickCategoryLine.h: Include required header list.h.
4052 * PickPackageLine.cc (PickPackageLine::paint): Adjust to use STL
4053 containers for listing of packages per category and vice verca.
4054 * PickView.cc (PickView::insert_pkg): Ditto.
4055 (PickView::insert_category): Ditto.
4056 * String++.h (String::caseless): STL helper to allow trivial containers
4057 of Strings with case insensitive comparisons.
4058 * category.h: Adjust to use STL containers for listing of packages per
4059 category and vice verca.
4060 * choose.cc (fill_missing_category): Ditto.
4061 (default_trust): Ditto.
4062 (ChooserPage::OnNext): Ditto.
4063 * package_meta.cc (CategoryPackage::~CategoryPackage): Remove.
4064 (packagemeta::packagemeta): Adjust for new category list name.
4065 (packagemeta::~packagemeta): Adjust to use STL containers for listing
4066 of packages per category and vice verca.
4067 (packagemeta::set_action): Ditto.
4068 * package_meta.h (CategoryPackage): Remove.
4069 (packagemeta): Adjust to use STL containers for listing of packages per
4070 category and vice verca.
4071
080bec6e
RC
40722002-07-05 Robert Collins <rbtcollins@hotmail.com>
4073
4074 * io_stream.cc: Use STL containers rather than custom ones.
4075 (io_stream::registerProvider): Ditto.
4076 (findProvider): Ditto.
4077
3f34f364
RC
40782002-07-05 Robert Collins <rbtcollins@hotmail.com>
4079
4080 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4081 Use STL collections for download site collections.
4082 (IniDBBuilderPackage::add_correct_version): Ditto.
4083 (IniDBBuilderPackage::process_src): Ditto.
4084 * PickPackageLine.cc (PickPackageLine::click): Use the packageversion
4085 accessible() call to abstract package availability.
ca2b7505 4086 * choose.cc (scanAVersion): Use STL collections for download site
3f34f364
RC
4087 collections.
4088 * download.cc (check_for_cached): Ditto.
4089 (download_one): Ditto.
4090 * package_meta.cc (packagemeta::set_action): Use the packageversion
4091 accessible() call to abstract package availability.
4092 * package_source.h: Use STL containers rather than custom containers.
4093 (site): Create a == operator to allow STL container use.
4094 (packagesource::sites): Use STL containers rather than custom
4095 containers.
4096 * package_version.cc (_packageversion::accessible): Use STL containers
4097 for download site containers.
4098
e2cdf72c
RC
40992002-07-05 Robert Collins <rbtcollins@hotmail.com>
4100
4101 * LogFile.cc: Use STL containers rather than custom containers.
4102 (filedef): Create == and < operators for STL use.
4103 (files): Convert to an STL set.
4104 (LogFile::setFile): Use STL operations on files.
4105 (LogFile::exit): Ditto.
4106
3bac26a1
RC
41072002-07-05 Robert Collins <rbtcollins@hotmail.com>
4108
4109 * ini.cc (do_remote_ini): Use STL collection for site collection.
4110 * site.cc: Include site.h first to ensure it's parsable standalone.
4111 Use STL algorithms.
4112 (site_list): Convert to an STL container.
4113 (all_site_list): Ditto.
4114 (site_list_type::site_list_type): Implement copy constructor.
4115 (site_list_type::operator=): Implement assignment operator.
4116 (site_list_type::operator ==): Implement.
4117 (site_list_type::operator <): Ditto.
4118 (save_dialog): Use STL collection calls for site collection.
4119 (save_site_url): Ditto.
4120 (get_site_list): Ditto.
4121 (get_saved_sites): Ditto.
4122 (do_download_site_info_thread): Ditto.
4123 (SitePage::OnNext): Ditto.
4124 (SitePage::PopulateListBox): Ditto.
4125 (SitePage::OnMessageCmd): Ditto.
4126 * site.h: Use STL vectors instead of custom code.
4127 (site_list_type::site_list_type): Declare.
4128 (site_list_type::operator=): Ditto.
4129 (site_list_type::operator ==): Ditto.
4130 (site_list_type::operator !=): Ditto.
4131 (site_list_type::operator <): Ditto.
4132 (site_list_type::operator <=): Ditto.
4133 (site_list_type::operator >): Ditto.
4134 (site_list_type::operator >=): Ditto.
4135 (site_list): Convert to an STL container.
4136 (all_site_list): Ditto.
4137
528a8edb
RC
41382002-07-05 Robert Collins <rbtcollins@hotmail.com>
4139
4140 * choose.cc (default_trust): Check package accessibility before
4141 triggering an install. (Suggested by Pavel).
4142
41432002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4144
4145 * compress_gz.cc (compress_gz::construct): Always initialize key members
4146 to ensure the destructor does the right thing.
4147
4e868a01
RC
41482002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4149
4150 * filemanip.cc (parse_filename): Do not try to parse empty
4151 strings (filenames).
4152 * package_db.cc (packagedb::packagedb): For each line check if sscanf()
4153 extracted good package name and filename.
4154
7f2b9277
RC
41552002-07-03 Robert Collins <rbtcollins@hotmail.com>
4156
4157 * package_meta.cc (packagemeta::set_requirements): Automatically select
ca2b7505 4158 version of dependent packages that satisfies the requirements.
7f2b9277
RC
4159 Use processOneDependency to trigger the install of those packages.
4160 (checkForInstalled): Check that the package remains installed.
4161 (processOneDependency): Helper function for dependent packages.
4162 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackage): Add more
4163 debug information.
4164 Clear out all current state on new packages.
ca2b7505 4165 (IniDBBuilderPackage::add_correct_version): Copy the dependency list
7f2b9277
RC
4166 across.
4167
84c4f5d1
RC
41682002-07-02 Robert Collins <rbtcollins@hotmail.com>
4169
4170 * Makefile.am (inilint_SOURCES): Add PackageSpecification sources.
4171 nb: inilint is still incomplete, as the packageversion code is not
4172 ready for database-less linking.
4173 * site.cc (get_site_list): When the same site is reentered by the user
4174 replace the old one. (Suggested by John Marshall).
4175
64cd7f94
RC
41762002-07-02 Robert Collins <rbtcollins@hotmail.com>
4177
4178 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4179 Clear out package selections when generating implicit source packages.
4180 * PackageSpecification.cc (PackageSpecification::satisfies): Implement.
4181 (PackageSpecification::_operators::satisfies): Implement.
4182 * PackageSpecification.h (PackageSpecification::_operators::satisfies):
4183 Worker function for testing versions.
4184
3c196821
RC
41852002-07-01 Robert Collins <rbtcollins@hotmail.com>
4186
4187 * IniDBBuilder.cc (IniDBBuilder::buildPackageRequirement): Remove.
4188 * IniDBBuilder.h (IniDBBuilder::buildPackageRequirement): Ditto.
4189 * IniDBBuilderPackage.cc: Use the STL algorithms.
4190 Change cpv to cbpv throughout. Adjust -> to ., and use the new accessor
4191 functions for the same variable throughout.
4192 (IniDBBuilderPackage::IniDBBuilderPackage): Initialise new members.
4193 (IniDBBuilderPackage::buildPackage): Use new cygpackage syntax,
4194 and set an empty source package.
4195 (IniDBBuilderPackage::buildPackageInstall): Use the new source member
4196 to record an install package.
4197 (IniDBBuilderPackage::buildPackageSource): Move source package logic
4198 out from process_src, as it now occurs at separate times.
4199 (IniDBBuilderPackage::buildPackageRequirement): Remove.
ca2b7505 4200 (IniDBBuilderPackage::buildSourceName): Use renamed package
3c196821
RC
4201 specifiation accessor for clarity.
4202 (IniDBBuilderPackage::buildSourceNameVersion): Ditto.
4203 (IniDBBuilderPackage::add_correct_version): Use STL iterators rather
4204 than custom code.
4205 Remove source package references.
4206 (IniDBBuilderPackage::process_src): Remove source package code as it's
4207 now handled separately.
4208 Set Path information before merging versions, to prevent dangling
4209 pointers.
4210 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildPackageRequirement):
4211 Remove.
4212 (IniDBBuilderPackage::cpv): Remove.
4213 (IniDBBuilderPackage::cbpv): New generic binary working variable.
4214 (IniDBBuilderPackage::cspv): Ditto, but for source packages.
4215 (IniDBBuilderPackage::csp): Source package variable for disjoint
4216 source packages.
4217 * Makefile.am (AM_CFLAGS): Remove -Winline to allow stl set code
4218 to compile. If it compiles cleanly in gcc 3.1, then reinstate.
4219 * PickPackageLine.cc: Adjust packageversion accessors to the new
4220 reference calls. (i.e. -> to .) throughout.
4221 (PickPackageLine::paint): Use accessible() for clarity.
4222 Use new split out source package logic.
4223 (PickPackageLine::click): Ditto.
4224 * PickView.cc (PickView::init_headers): Adjust packageversion accessors
4225 to the new reference calls. (i.e. -> to .) throughout.
4226 Use new split out source package logic.
4227 * choose.cc: Don't depend on a specific package type.
ca2b7505 4228 Adjust packageversion accessors to the new reference calls. (i.e. -> to
3c196821
RC
4229 .) throughout.
4230 (set_existence): Use accessible () for clarity.
4231 (default_trust): Simplify a little.
ca2b7505 4232 (scanAVersion): Factored out code from scan_downloaded_files for
3c196821
RC
4233 clarity.
4234 (scan_downloaded_files): Factor out inner loop for clarity.
4235 (ChooserPage::OnNext): Don't dump the dependency list,
ca2b7505 4236 it's parsing is robust now!.
3c196821
RC
4237 * cygpackage.cc (createInstance): Use a factory method to create new
4238 objects.
4239 (cygpackage::cygpackage): Make this private for use by the factory.
4240 (cygpackage::setCanonicalVersion): Renamed from set_canonical_version.
4241 Remove key usage as it's obsolete.
4242 * cygpackage.h (cygpackage): Inherit from _packageversion, not
4243 packageversion.
4244 (cygpackage::createInstance): New factory.
4245 (cygpackage::cygpackage): Make private.
4246 * desktop.cc (make_passwd_group): Use new packageversion reference.
4247 * download.cc (do_download_thread): Use changeRequested() for clarity.
4248 Use new packageversion reference calls.
4249 * iniparse.y (REQUIRES): Reuse the packageList code and dump the one-off
4250 requires code.
4251 * install.cc: Adjust -> to ., and use the new accessor functions for
4252 packageversion throughout.
4253 * package_db.cc: Adjust -> to ., and use the new accessor functions for
4254 packageversion throughout.
4255 (packagedb::packagedb): Use the new cygpackage factory.
4256 (packagedb::flush): Leverage String to remove buffer overflow chance in
4257 sprintf.
4258 (packagedb::findBinary): Find a binary meta package that has a version
4259 matching a given specification.
4260 (packagedb::findSource): Ditto, but for source.
4261 * package_db.h (packagedb::findBinary): Declare.
4262 (packagedb::findSource): Ditto.
4263 * package_meta.cc: Adjust packageversion accessors to the new
4264 reference calls. (i.e. -> to .) throughout.
4265 Include the package_meta header first to ensure it parses standalone.
4266 Use the STL algorithms.
4267 (packagemeta::packagemeta): Create a copy constructor to allowing
4268 cloning binary package metadata to source package metadata.
ca2b7505 4269 (packagemeta::~packagemeta): Use the STL coleltion code rather than
3c196821
RC
4270 custom collection code.
4271 (packagemeta::add_version): Ditto.
4272 (packagemeta::set_installed): Ditto.
4273 (packagemeta::SDesc): Ditto.
4274 (hasSDesc): Helper function for find_if.
4275 (checkForInstalled): Ditto.
4276 (checkForUpgradeable): Ditto.
4277 (checkForSatisfiable): Ditto.
4278 (packagemeta::action_caption): Update for split out source packages.
4279 (packagemeta::set_action): Ditto.
4280 (packagemeta::set_requirements): Support multi-valued dependency
4281 lists - a|b & c|d - with versioned package specifications.
4282 (packagemeta::accessible): Helper member to improve abstraction.
4283 (packagemeta::sourceAccessible): Ditto.
4284 * package_meta.h: Adjust packageversion accessors to the new
4285 reference calls. (i.e. "->" to "." and"*" to "" ) throughout.
58b12a06 4286 (packagemeta::packagemeta): Declare copy constructor.
3c196821
RC
4287 Remove self initialising members.
4288 (packagemeta::set_action): Update parameters for new packageversion.
4289 (packagemeta::trustp): Ditto.
4290 (packagemeta::versions): Becomes an STL set.
4291 * package_source.h (packagesource::Cached): Const correctness change.
4292 * package_version.cc: Rewrite the packageversion interface to remove
4293 the cygpackage nonvirtual members, and provide a copy by value,
4294 pointer semantics reference counting wrapper class to ease use and
4295 comparison of packageversions.
4296 Change existing packageversion class to _packageversion throughout.
4297 (_defaultversion): A trivial concrete class to prevent specialcasing
4298 the default constructor for packageversion;
4299 (packageversion::packageversion): Implement.
4300 (packageversion::~packageversion): Ditto.
4301 (packageversion::operator=): Ditto.
4302 (packageversion::operator !): Ditto.
4303 (packageversion::operator bool): Ditto.
4304 (packageversion::operator ==): Ditto.
4305 (packageversion::operator !=): Ditto.
4306 (packageversion::operator <): Ditto.
4307 (packageversion::Name): Ditto.
4308 (packageversion::Canonical_version): Ditto.
4309 (packageversion::setCanonicalVersion): Ditto.
4310 (packageversion::getfirstfile): Ditto.
4311 (packageversion::getnextfile): Ditto.
4312 (packageversion::SDesc): Ditto.
4313 (packageversion::set_sdesc): Ditto.
4314 (packageversion::LDesc): Ditto.
4315 (packageversion::set_ldesc): Ditto.
4316 (packageversion::sourcePackage): Ditto.
4317 (packageversion::sourcePackageSpecification): Ditto.
4318 (packageversion::setSourcePackageSpecification): Ditto.
4319 (packageversion::depends): Ditto.
4320 (packageversion::predepends): Ditto.
4321 (packageversion::recommends): Ditto.
4322 (packageversion::suggests): Ditto.
4323 (packageversion::replaces): Ditto.
4324 (packageversion::conflicts): Ditto.
4325 (packageversion::provides): Ditto.
4326 (packageversion::picked): Ditto.
4327 (packageversion::pick): Ditto.
4328 (packageversion::changeRequested): Ditto.
4329 (packageversion::uninstall): Ditto.
4330 (packageversion::source): Ditto.
4331 (packageversion::accessible): Ditto.
4332 (_packageversion::sourcePackage): Ditto.
4333 (_packageversion::accessible): Ditto.
4334 (_packageversion::changeRequested): Ditto.
4335 * package_version.h: Rewrite the packageversion interface to remove
4336 the cygpackage nonvirtual members, and provide a copy by value,
4337 pointer semantics reference counting wrapper class to ease use and
4338 comparison of packageversions.
4339 Change existing packageversion class to _packageversion throughout.
4340 (Dependency): Remove.
4341 (packageversion): New wrapper class.
4342 (_packageversion): Renamed from packageversion.
4343 (_packageversion::setCanonicalVersion): New method.
4344 (_packageversion::sourcePackage): Ditto.
4345 (_packageversion::sourcePackageSpecification): Ditto.
4346 (_packageversion::setSourcePackageSpecification): Ditto.
4347 (_packageversion::changeRequested): Ditto.
4348 (_packageversion::bin): Rename to source.
4349 (_packageversion::src): Remove.
4350 (_packageversion::accessible): New method.
4351 (_packageversion::references): Allow reference counting.
ca2b7505 4352 (_packageversion::sourceVersion): Cached the best-match source
3c196821
RC
4353 package version.
4354
387cb501
RC
43552002-06-27 Robert Collins <rbtcollins@hotmail.com>
4356
4357 * compress_bz.h (compress_bz::position): Track how much has been read.
4358 * compress_bz.cc (compress_bz::compress_bz): And initialise it.
4359 (compress_bz::read): Track amount read by the client.
4360 (compress_bz::tell): And report it when asked.
4361
7d702af3
RC
43622002-06-27 Robert Collins <rbtcollins@hotmail.com>
4363
4364 * Makefile.am (snapshot): Automate snapshot creation some more.
4365
08cd08c3
RC
43662002-06-27 Robert Collins <rbtcollins@hotmail.com>
4367
4368 * msg.cc (msg): Use vsnprintf to avoid buffer overflows.
4369 (mbox): Ditto.
4370 * ini.cc (fprintf): Ditto.
4371 * log.cc (log): Ditto.
4372 * package_db.cc (packagedb::sourcePackages): Split out source packages
4373 from binary packages.
4374 * package_db.h: Ditto.
4375
aa1e3b4d
RC
43762002-06-27 Robert Collins <rbtcollins@hotmail.com>
4377
4378 * PackageSpecification.h: New file. Abstracts the ability to refer
4379 to another package, by name, or name and version.
4380 * PackageSpecification.cc: Ditto.
4381 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Simplify.
4382 (IniDBBuilder::buildPackageSource): Ditto.
4383 (IniDBBuilder::buildBeginDepends): New method for versioned
4384 dependencies.
4385 (IniDBBuilder::buildBeginPreDepends): Likewise, for dependencies to be
4386 satisfied before pre-install.
4387 (IniDBBuilder::buildPriority): New method, for getting the package
4388 Priority.
4389 (IniDBBuilder::buildInstalledSize): How much disk space does it need?
4390 (IniDBBuilder::buildMaintainer): Who maintains the package?
4391 (IniDBBuilder::buildArchitecture): What platform is it for?
4392 (IniDBBuilder::buildInstallSize): How big is the binary download?
4393 (IniDBBuilder::buildInstallMD5): Whats the MD5 on the binary?
4394 (IniDBBuilder::buildSourceMD5): Whats the MD5 on the source package?
4395 (IniDBBuilder::buildBeginRecommends): What other packages are
4396 recommended with this one?
4397 (IniDBBuilder::buildBeginSuggests): And suggested?
4398 (IniDBBuilder::buildBeginReplaces): What packages does this replace?
4399 (IniDBBuilder::buildBeginConflicts): And collide with?
4400 (IniDBBuilder::buildBeginProvides): What virtual packages (or obsolete
4401 package names) does this provide?
4402 (IniDBBuilder::buildDescription): Grab a multi line description one
4403 line at a time.
4404 (IniDBBuilder::buildSourceName): What source package should be used to
4405 install the source for this binary package?
4406 (IniDBBuilder::buildSourceNameVersion): Is a specific version needed?
ca2b7505 4407 (IniDBBuilder::buildPackageListAndNode): Add another AND clause to a
aa1e3b4d
RC
4408 list of package specifications.
4409 (IniDBBuilder::buildPackageListOrNode): Add another OR clause.
4410 (IniDBBuilder::buildPackageListOperator): Add a versioning operator
4411 to the current specification.
4412 (IniDBBuilder::buildPackageListOperatorVersion): What version does the
4413 operator act on?
4414 * IniDBBuilder.h: Declare all the IniDBBuilder.cc changes.
4415 * IniDBBuilderPackage.cc: As for IniDBBuilder.cc.
4416 (IniDBBuilderPackage::IniDBBuilderPackage): Iniitialize new members.
ca2b7505 4417 (IniDBBuilderPackage::process_src): Streamline and split out
aa1e3b4d
RC
4418 functionality.
4419 (IniDBBuilderPackage::setSourceSize): From process_src.
4420 * IniDBBuilderPackage.h: Declare the IniDBBuilderPackage.cc changes.
4421 (IniDBBuilderPackage::currentSpec): Track the in-progress specifiation.
4422 (IniDBBuilderPackage::currentOrList): Track the current Or list.
4423 (IniDBBuilderPackage::currentAndList): Track the current And list.
4424 * IniParseFeedback.cc (IniParseFeedback::progress): Provide completion
349bd18c 4425 progress on parsing.
aa1e3b4d
RC
4426 (IniParseFeedback::iniName): Tell what ini filename we are currently
4427 processing.
4428 * IniParseFeedback.h: Declare IniParseFeedback.cc changes.
ca2b7505 4429 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
aa1e3b4d
RC
4430 Make the feedback object non-const to allow mutating methods which are
4431 needed when the object has state.
4432 (IniParseFindVisitor::visitFile): Tell the caller the name of each
4433 .ini found.
4434 Initialise the parser with the feedback object to allow it to tell of
4435 progress.
4436 * IniParseFindVisitor.h: Declare IniParseFindVisitor.cc changes.
4437 * Makefile.am (inilinst_SOURCES): Add more requisite classes.
4438 (setup_SOURCES): Add the new PackageSpecification sources.
4439 * ScanFindVisitor.cc (ScanFindVisitor::visitFile): Use the new
4440 builder syntax to setup binary package details.
4441 * choose.cc: Use the LogSingleton calls throughout.
4442 * configure.in: Create the INILINT substitution correctly for recent
4443 autotool configurations.
4444 * cygpackage.cc (cygpackage::getfirstfile): Return an empty String
4445 rather than a string built from an int. Thanks to Pavel Tsekov for
4446 identifying the bug.
4447 (cygpackage::getnextfile): Ditto.
4448 * download.cc: Use LogSIngletion calls throughout.
ca2b7505 4449 (validateCachedPackage): A refactoring of the
aa1e3b4d
RC
4450 check_for_cached code to eliminate duplciation.
4451 (check_for_cached): Use validateCachedPackage to check packages.
ca2b7505 4452 * ini.cc (GuiParseFeedback): Provide gui feedback on ini name and
aa1e3b4d
RC
4453 parsing progress.
4454 (do_remote_ini): Ditto.
4455 * ini.h (ini_init): Pass a IniParseFeedback to the parser, to allow
4456 progress reporting.
4457 * inilex.l: Identify new symbols - operators, and multi line plain text.
4458 Releases files.
4459 * inilintmain.cc (show_help): Provide basic infomation on inilint.
4460 * iniparse.y: Adjust for the new builder syntax, and process debian
4461 Release files.
4462 * io_stream_file.cc: Always include mkdir.h.
4463 * list.h: Factor index location into a private routine.
4464 (list::findindex): Implement this.
ca2b7505 4465 * mkdir.cc (mkdir_p): Make the use of WIN32 code conditional on mingw
aa1e3b4d
RC
4466 builds. NB: This breaks cygwin build functionality still.
4467 * package_meta.cc: Use the LogSingleton calls throughout.
4468 (packagemeta::set_requirements): Adjust for object changes in
4469 dependencies.
4470 * package_meta.h (packagemeta::packagemeta): Initialise new members.
ca2b7505 4471 (packagemeta::architecture): What platform does this package run on?
aa1e3b4d 4472 This may need to move in the future to a per packagefile object.
58b12a06 4473 (packagemeta::priority): What priority does this package have?
aa1e3b4d
RC
4474 * package_source.h (packagesource::packagesource): Initialise new
4475 members.
4476 (packagesource::installedSize): How much space does the package need?
4477 (packagesource::setInstalledSize): Tell the amount.
4478 (packagesource::_installedSize): And store it.
ca2b7505 4479 * package_version.cc (packageversion::sourcePackage): return the
aa1e3b4d
RC
4480 source package.
4481 (packageversion::setSourcePackage): And set it.
4482 * package_version.h: Declare the package_version.cc changes.
4483 (packageversion::depends): New package specification AND list.
4484 (packageversion::predepends): Ditto.
4485 (packageversion::recommends): Ditto.
4486 (packageversion::suggests): Ditto.
4487 (packageversion::replaces): Ditto.
4488 (packageversion::conflicts): Ditto.
4489 (packageversion::provides): Ditto.
4490 (packageversion::sourcePackage): What source package is needed?
4491 * threebar.cc (ThreeBarProgressPage::SetText4): Set the label beside
4492 the bottom bar.
4493 * threebar.h: Declare the threebar.cc change.
4494
44952002-06-27 John Marshall <johnm@falch.net>
4496
4497 * res.rc (SETUPINI_MISSING): Make trailing spaces visible.
4498 * site.cc (SitePage::OnMessageCmd): Ditto
4499
2a994e0b
RC
45002002-06-15 Robert Collins <rbtcollins@hotmail.com>
4501
4502 * nio-ie5.cc (NetIO_IE5::NetIO_IE): Allow cached data.
4503
ceff7035
RC
45042002-06-15 Robert Collins <rbtcollins@hotmail.com>
4505
4506 * package_meta.cc (packagemeta::set_action): When installing packages
4507 with no binaries, choose the source package.
4508
9bd27040
RC
45092002-06-10 Robert Collins <rbtcollins@hotmail.com>
4510
4511 * IniParseFindVisitor (IniParseFindVisitor::visitFile): Apply Max
ca2b7505 4512 Bowshers fix for the crash with a root level setup.ini.
9bd27040
RC
4513 * README: Update todos.
4514
1dcff4a0
RC
45152002-05-26 Ralf Habacker <ralf.habacker@freenet.de>
4516
4517 * archive_tar.cc (archive_tar::next_file_name()): fixed broken
4518 GNU long name extension support.
349bd18c 4519
0773e4f2
RC
45202002-05-27 Robert Collins <rbtcollins@hotmail.com>
4521
ca2b7505 4522 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Don't
0773e4f2
RC
4523 unescape 0 length strings.
4524
a828d772
RC
45252002-05-20 Robert Collins <rbtcollins@hotmail.com>
4526
4527 * package_meta.cc (packagemeta::set_action): Don't allow reinstall
4528 when local with no cached file, and install the default source if the
4529 default version has no binary.
4530
67829ce0
RC
45312002-05-19 Robert Collins <rbtcollins@hotmail.com>
4532
4533 * IniDBBuilderPackage.cc (IniDBBuilderPackage::IniDBBuilderPackage): New
349bd18c 4534 method.
ca2b7505 4535 (IniDBBuilderPackage::buildVersion): Provide a warning when a newer
67829ce0
RC
4536 setup version created the ini file.
4537 * IniDBBuilderPackage.h (IniDBBuilderPackage::IniDBBuilderPackage): New
4538 method.
4539 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use the new
4540 feedback strategy.
4541 * IniParseFindVisitor.h (IniParseFindVisitor::IniParseFindVisitor):
4542 Require a feedback strategy.
4543 * Makefile.am (setup_SOURCES): Add IniParseFeedback sources.
4544 * Makefile.in: Regenerate.
4545
4849e2fc
RC
45462002-05-19 Robert Collins <rbtcollins@hotmail.com>
4547
4548 * io_stream_file.cc (io_stream_file::remove): Use the SetFileAttributes
4549 trick to delete read only files.
ca2b7505 4550 * io_stream_cygfile.cc (io_stream_cygfile::remove): Use file:// to
4849e2fc
RC
4551 remove files.
4552 * Makefile.am (release): Tweak to be more helpful.
4553 * Makefile.in: Regenerate.
4554
7cb35117
RC
45552002-05-19 Robert Collins <rbtcollins@hotmail.com>
4556
4557 * Makefile.am (release): Tweak to be more helpful.
4558 * Makefile.in: Regenerate.
7cb35117 4559
5090e3ce
RC
45602002-05-19 Robert Collins <rbtcollins@hotmail.com>
4561
4562 * Makefile.am (release): Tweak to be more helpful.
4563 * Makefile.in: Regenerate.
4564
9e9b881a
RC
45652002-05-19 Robert Collins <rbtcollins@hotmail.com>
4566
ca2b7505 4567 * choose.cc (scan_downloaded_files): When a non-installed version
9e9b881a
RC
4568 has neither bin nor src cached files for local installs,
4569 remove the version from availability.
4570
ea36e064
RC
45712002-05-19 Robert Collins <rbtcollins@hotmail.com>
4572
4573 * ini.cc (do_remote_ini): Save uncompressed ini's correctly.
4574
b401ef47
RC
45752002-05-19 Robert Collins <rbtcollins@hotmail.com>
4576
4577 * rsync: New support library, contains librsync. This is not (yet)
349bd18c 4578 rsync interoperable.
b401ef47
RC
4579 * configure.in: --with-rsync to enable rsync support. (Not complete).
4580 * Makefile.am: Enable building with rsync.
4581 * Makefile.in: Regenerate.
4582 * configure: Ditto.
4583 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Pass the md5 as
4584 an array.
4585 (IniDBBuilder::buildPackageSource): Ditto.
4586 * IniDBBuilder.h: Ditto.
4587 * IniDBBuilderPackage.cc: Ditto.
4588 * IniDBBuilderPackage.h: Ditto.
4589 * FindVisitor.cc: New file.
4590 * FindVisitor.h: New file, interface for visiting a file system
4591 aggregate.
4592 * IniParseFindVisitor.cc: New file.
ca2b7505 4593 * IniParseFindVisitor.h: New file, concrete FindVisitor that parses
b401ef47
RC
4594 found setup.ini's.
4595 * README: Update TODO's.
4596 * String++.cc (String::String): New constructor for <string> inter-
4597 operability.
4598 (String::substr): New method.
4599 * String++.h: Ditto.
4600 * choose.cc (scan2): Remove.
4601 (scan_downloaded_files): Simplify.
4602 * dialog.h: Include parsing pre-requirements.
4603 * download.cc (check_for_cached): Fullname was used incorrectly - fix.
4604 * filemanip.cc (parse_filename): -src packages where incorrectly parsed.
4605 * find.cc: Rewrite. Now uses a Visitor pattern and is re-entrant.
4606 * find.h: Ditto.
4607 * fromcwd.cc: Remove unneeded includes.
4608 (is_test_version): Remove.
4609 (found_file): Remove.
4610 (SetupFindVisitor): Trivial visitor to detect setup.ini's.
4611 (found_ini): Remove.
4612 (do_fromcwd): Remove commented code that has be replaced elsewhere.
4613 * ini.cc (local_ini): Remove.
4614 (findBuilder): Remove.
4615 (find_routine): Remove.
4616 (do_local_ini): Use new IniParseFindVisitor.
4617 * iniparse.y: Typecase MD5 arrays, as we know they are allocated as
4618 unsigned char.
4619 * postinstall.cc: Remove non-core includes.
4620 (run_script_in_postinstall): Remove.
4621 (RunFindVisitor): Trivial Visitor, runs each found script.
4622 (do_postinstall): Use new find syntax.
4623
0d4e0aad
CF
46242002-05-14 Christopher Faylor <cgf@redhat.com>
4625
4626 * ini.cc (find_routine): Don't clear buffer it it's NULL.
4627
46282002-05-14 Christopher Faylor <cgf@redhat.com>
4629
4630 * filemanip.h (trail): Declare.
4631 * filemanip.cc (trail): New function.
4632 (find_tar_ext): Use trail() instead of strstr().
4633 * fromcwd.cc (check_ini): Ditto.
4634 * ini.cc (find_routine): Ditto. Don't tack local_dir to path since it
4635 should now be fully qualified. Set ini_filename. Reset error_buf and
4636 error_count for any subsequent ini file parsing.
4637 (ini_filename): New static variable for parse error reporting.
4638 (yyerror): Use full path of setup.ini in error message. Subtract one
4639 from line number if at bol.
4640 * find.cc (found_part): Eliminate.
4641 (find_sub): Call for_each with full path found rather than just file
4642 component.
4643 (find): Don't calculate found_part.
4644 * inilex.l (ini_init): Flush input buffer and reset line number.
4645 (yybol): New function. Exports YY_AT_BOL.
4646 * iniparse.y: Increase stack depth to allow more tokens to be processed.
4647 (yyparse): Remove newline from error condition to allow subsequent
4648 per-line error processing to proceed normally.
4649
46502002-05-14 Christopher Faylor <cgf@redhat.com>
4651
4652 * find.cc (find_sub): Be more defensive in preserving trailing parts of
4653 components when doing recursive directory searches or calling user
4654 supplied for_each().
4655 * ini.cc (find_routine): Don't assume that any path name with
4656 "setup.ini" in it is actually a setup.ini file. Only honor trailing
4657 components. Copy path argument to temporary storage when unescaping
4658 to prevent nuking of argument.
4659
874c569a
RC
46602002-05-12 Robert Collins <rbtcollins@hotmail.com>
4661
4662 * CONTRIBUTORS: New file.
4663
f6a81f69
RC
46642002-04-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
4665
4666 * choose.cc: Run indent.
4667 (nextbutton): Remove static variable.
4668 (default_trust): Remove use of nextbutton.
4669 (set_view_mode): Ditto.
4670 (create_listview): Add IDC_CHOOSE_PREV and IDC_CHOOSE_NEXT to ta[] so
4671 rbset() sets the prev/next/curr radio buttons properly.
4672 (dialog_cmd): Delete function.
4673 (dialog_proc): Delete function. Move WM_INITDIALOG functionality to
4674 ChooserPage::OnInit.
4675 (do_choose): Delete function. Move pre-DialogBox() code to
4676 ChooserPage::OnInit(), post-DialogBox() code to ChooserPage::OnNext.
4677 (WM_APP_START_CHOOSE): Remove define.
4678 (WM_APP_CHOOSE_IS_FINISHED): Remove define.
4679 (do_choose_thread): Delete function.
4680 (ChooserPage::OnActivate): Delete method.
4681 (ChooserPage::OnMessageApp): Delete method.
4682 (ChooserPage::OnInit): New method.
4683 (ChooserPage::OnNext): New method.
4684 (ChooserPage::OnBack): New method.
4685 (ChooserPage::OnMessageCmd): New method.
4686 * choose.h: Run indent.
4687 (ChooserPage::OnMessageApp): Delete declaration.
4688 (ChooserPage::OnActivate): Ditto.
4689 (ChooserPage::OnMessageCmd): New declaration.
4690 (ChooserPage::OnInit): Ditto.
4691 (ChooserPage::OnNext): Ditto.
4692 (ChooserPage::OnBack): Ditto.
4693 * desktop.cc (DesktopSetupPage::OnBack): Replace use of IDD_CHOOSER
4694 with IDD_CHOOSE.
4695 * fromcwd.cc (do_fromcwd): Replace use of IDD_CHOOSER with IDD_CHOOSE.
4696 * ini.cc (do_ini_thread): Replace use of IDD_CHOOSER with IDD_CHOOSE.
4697 * res.rc (IDD_CHOOSE): Remove dialog template.
4698 (IDD_CHOOSER): Alter dialog template to fit wizard size and format.
4699
74617327
RC
47002002-05-12 Robert Collins <rbtcollins@hotmail.com>
4701
4702 * LogFile.cc (endLog): Work around an apparent libg++-3 bug causing
4703 corrupt log file entries.
4704 * geturl.cc: Convert to the new LogSingleton logging.
4705
3272d625
RC
47062002-05-12 Robert Collins <rbtcollins@hotmail.com>
4707
4708 * ini.cc (do_remote_ini): Use setup.bz2 if it exists in preference to
4709 setup.ini.
4710
fc687221
RC
47112002-05-12 Robert Collins <rbtcollins@hotmail.com>
4712
4713 * geturl.h: Declare getUrlToStream.
4714 * geturl.cc (getUrlToStream): New function.
4715 (get_url_to_membuf): Refactor to use getUrlToStream.
4716
902c8a3f
RC
47172002-05-11 Robert Collins <rbtcollins@hotmail.com>
4718
4719 * Makefile.am: Add a release target to automate some of the routine
4720 work.
4721 * Makefile.in: Regenerate.
4722
2ab26cdb
RC
47232002-05-11 Robert Collins <rbtcollins@hotmail.com>
4724
4725 * choose.cc (scan_downloaded_files): On local installs remove all
4726 mirror sites if no cached copy of a package is found.
4727
94852d65
RC
47282002-05-10 Robert Collins <rbtcollins@hotmail.com>
4729
4730 * Makefile.in: Regenerate.
58b12a06 4731 * iniparse.y: Use left recursion, not right in the lines rule to
94852d65
RC
4732 avoid stack overflows.
4733 * README: Update TODO's.
4734 * io_stream_file.cc: Native builds need to include sys/stat.h
4735
3548fbc3
RC
47362002-05-06 John Marshall <jmarshall@acm.org>
4737
4738 * site.cc (SitePage::OnMessageCmd): recalculate navigation
4739 button activation when "Add" is pressed.
4740 (SitePage::CheckControlsAndDisableAccordingly): tweak comment.
4741
47422002-05-07 Robert Collins <rbtcollins@hotmail.com>
2b48ecd0
RC
4743
4744 * Makefile.am (inlint_SOURCES): Add conditional objects to inilint
4745 depending on platform.
4746 Add file:// support.
4747 * configure.in: Set conditional MINGWTARGET if compiling against mingw
4748 libraries.
4749 * Makefile.in: Regenerate.
4750 * configure: Ditto.
4751 * io_stream_file.cc: Only use win32 calls when building for mingw.
4752
19911586
RC
47532002-05-05 Robert Collins <rbtcollins@hotmail.com>
4754
4755 * Makefile.am (noinst_PROGRAMS): Make inilint configurable.
4756 * configure.in: Ditto.
4757 Fix incorrect header checking syntax.
4758 * aclocal.m4: Regenerate.
4759 * configure: Regenerate.
4760 * Makefile.in: Regenerate.
4761 * io_stream.cc: Remove platform specific and provider specific code.
4762 (io_stream::registerProvider): New method, registers a Url provider with
4763 the io_stream code.
4764 Make all methods consistently throw invalid_argument exceptions when
4765 a provider that is requested is not present.
4766 (findProvider): New private function, finds a provider.
4767 * io_stream.h: Declare io_stream::registerProvider.
4768 * io_stream_cygfile.cc: Create a Provider class to register with
4769 io_stream.cc.
4770 * io_stream_file.cc: Ditto.
4771 * archive.cc: Remove unneeded includes.
4772 * archive_tar.cc: Remove unneeded includes.
4773 * archive_tar.h: Add required include.
4774 * archive_tar_file.cc: Remove unneded includes.
4775 * choose.cc: Remove unneeded includes:
4776
bf4ffcd9
RC
47772002-05-04 Robert Collins <rbtcollins@hotmail.com>
4778
4779 * io_stream.cc: Use the new log interface thruout.
4780
9f4a0c62
RC
47812002-05-04 Robert Collins <rbtcollins@hotmail.com>
4782
4783 * log.cc (log): Reimplement via LogSingleton.
4784 (log_save): Remove.
4785 (exit_setup): Remove.
4786 * log.h (log_save): Remove.
4787 (exit_setup): Remove.
4788 * LogSingleton.cc: New file.
4789 * LogSingleton.h: New file.
4790 * LogFile.cc: New file.
4791 * LogFile.h: New file.
4792 * Makefile.am (inilint_SOURCES): Add the new log interface.
4793 (setup_SOURCES): Add the new log interface and the concrete File
4794 implementation.
4795 * Makefile.in: Regenerate.
4796 * archive.cc: Use the new log interface thruout.
4797 * archive_tar.cc: Ditto.
4798 * main.cc: Ditto.
4799 * dialog.cc (fatal): Use the new log interface.
4800 * ini.cc (do_ini_thread): Use the log interface to exit.
4801 * isntall.cc (do_install_thread): Ditto.
4802 * netio.cc (auth_cmd): Ditto.
4803 * msg.cc (fatal): Ditto.
4804 * localdir.cc (save_local_dir): Save to different files depending on
4805 the mode, and if a root dir exists.
4806
076654e7
RC
48072002-05-04 Robert Collins <rbtcollins@hotmail.com>
4808
4809 * IniDBBuilder.cc: New file.
4810 * IniDBBuilder.h: New file.
4811 * IniDBBuilderPackage.cc: New file.
4812 * IniDBBuilderPackage.h: New file.
4813 * PackageTrust.h: New file.
4814 * IniState.h: Remove, wasn't thought out well enough.
4815 * Makefile.am (inilint_SOURCES): Add more requirements.
4816 (setup_SOURCES): Add new Builder base and concrete classes.
4817 * Makefile.in: Regenerate.
4818 * String++.cc (String::String): Implement int contructor.
4819 * String++.h (String): Declare int constructor.
4820 * archive_tar.cc (archive_tar::next_file_name): Return String() when
4821 no filename exists.
4822 * archive_tar.h (archive_tar_file): Remove get_next_filename method,
4823 it's not needed.
4824 * ini.cc: Replace IniState wuth IniDBBuilderPacakge.
4825 (find_routine): Use new IniDBBuilder to configure the parser.
4826 (do_local_ini): Ditto.
4827 (do_remote_ini): Ditto.
4828 * ini.h: Use IniDBBuilder to initialise parsing.
ca2b7505 4829 * inilex.l (MD5): Parse the MD5 string correctly, we had the nibbles
076654e7
RC
4830 swapped.
4831 (ini_init): Use an IniDBBuilder rather than static variables.
4832 * iniparse.y: Hand off all the object creation to a builder, rather
ca2b7505 4833 than hardcoding the behaviour. This allows run-time configured
076654e7 4834 behaviour.
ca2b7505 4835 * io_stream_cygfile.h (io_stream_cygfile): Remove get_next_filename
076654e7
RC
4836 method, it's not needed.
4837 * io_stream_file.h (io_stream_file): Ditto.
4838 * mount.cc (cygpath): Return String() for missing mounts.
4839 * package_meta.cc (packagemeta::SDesc): Return String() for blank
4840 descriptions.
4841 * package_meta.h (trusts): Remove - replaced by PackageTrust.h.
4842 (packagemeta::packagemeta): Fix incorrect syntax in String constructor
4843 usage.
ca2b7505 4844 * cygpackage.cc (cygpackage::cygpackage): Fix incorrect syntax in
076654e7
RC
4845 String constructor usage.
4846 * site.h (site_list_type): Ditto.
4847
6391823e
RC
48482002-05-03 Robert Collins <rbtcollins@hotmail.com>
4849
4850 * String++.h: Declare a << operator that accepts String objects.
4851 * String++.cc: We need iostream for..
4852 (operator <<): this. Provide a << operator that accepts String objects.
4853 * ini.cc (yyerror): Remove the "C" classifier - it's not needed.
4854 Change from vargs to a String parameter.
4855 * inilintmail.cc: Remove the gui related headers.
4856 (yyerror): Implement this for parsing.
4857 * iniparse.y: Use the new yyerror syntax.
4858
b92028a4
RC
48592002-05-03 Robert Collins <rbtcollins@hotmail.com>
4860
4861 * Makefile.am: Add IniState.h.
4862 * Makefile.in: Regenerate.
4863 * IniState.h: New file.
4864 * choose.cc: Don't include ini.h - it's not needed.
4865 * configure: Regenerate.
4866 * desktop.cc: Don't include ini.h - it's not needed.
4867 * download.cc: Ditto.
4868 * fromcwd.cc: Ditto.
4869 * ini.cc: Use IniState.h to track each parsing calling.
4870 (find_routine): Ditto.
4871 (do_remote_ini): Ditto.
4872 (do_ini_thread): Ditto.
4873 * ini.h (ini_init): Adjust parameters to include state object.
4874 * inilex.l: Declare parser state variable.
4875 (ini_init): Adjust parameters to include state object.
ca2b7505 4876 * iniparse.y: Remove obsolete setup_timestamp and setup_version
b92028a4
RC
4877 declarations.
4878 (setup_header): Use new state variable to track time and version.
4879 (add_correct_version): Ditto.
4880 * install.cc: Don't include ini.h - it's not needed.
4881
e0a4db64
RC
48822002-05-03 Robert Collins <rbtcollins@hotmail.com>
4883
4884 * nio-files.cc (NetIO): Use io_stream syntax for get_file_size.
4885 * io_stream_file.cc: Don't include filemanip.h.
4886 (io_stream_file::get_size): Implement here to remove filemanip
4887 dependency.
4888 * io_stream_cygfile.cc: Don't include filemanip.h.
4889 (io_stream_cygfile::get_size): Implement here to remove filemanip
4890 dependency.
4891 Implement a stat based version for when win32 is not available.
4892 * filemanip.h (get_file_size): Return size_t - it's more appropriate.
4893 * filemanip.cc: Don't include win32.h - be platform independent.
4894 Include strings.h and io_stream.h as part of that.
4895 (get_file_size): Leverage io_streams and remove win32 implementation.
4896 * download.cc (check_for_cached): Use io_stream syntax for
4897 get_file_size.
4898 (download_one): Ditto.
4899
49002002-05-02 Robert Collins <rbtcollins@hotmail.com>
ac65f5c5
RC
4901
4902 * configure.in: Correct a typo in last change.
4903 * configure: Regenerate.
4904 * Makefile.in: Regenerate.
4905
e0a4db64 49062002-05-02 Robert Collins <rbtcollins@hotmail.com>
e06ded88
RC
4907
4908 * configure.in: Check for string.h and string.
4909 * configure: Regenerate.
4910 * Makefile.in: Regenerate.
4911
1fd0694a
RC
49122002-05-01 Robert Collins <rbtcollins@hotmail.com>
4913
4914 * res.rc (IDD_SPLASH): Remove white box.
4915
89ca06c0
RC
49162002-05-01 Robert Collins <rbtcollins@hotmail.com>
4917
4918 Oops! forgot to list these in the last checkin.
4919 * inilintmain.cc: New file.
4920 * md5.h: New file - imported md5 source, BSD style licence.
4921 * md5.cc: New file - imported md5 source, BSD style licence.
4922 * Exception.cc: New file.
4923 * Exception.h: New file.
4924 * MD5++.cc: New file.
4925 * MD5++.h: New file.
4926
58ee6135
RC
49272002-05-01 Robert Collins <rbtcollins@hotmail.com>
4928
ca2b7505 4929 * Makefile.am (AM_CFLAGS): Remove -mwindows, it's a linker flag.
58ee6135
RC
4930 Remove -fno-rtti, we need it for exceptions.
4931 (AM_CXXFLAGS): Ditto.
4932 (WARNONLY_CFLAGS): Ditto.
4933 (EXTRA_PROGRAMS): Add with initial linter sources - not functional yet.
4934 (setup_LDFLAGS): Add and set to -mwindows.
4935 (setup_SOURCES): Add new sources.
4936 * Makefile.in: Regenerate.
4937 * README: Update TODO.
4938 * choose.cc (scan_downloaded_files): Use ini information if it's
4939 available.
4940 * configure: Regenerate.
4941 * download.cc (check_for_cached): Make reusable from elsewhere.
4942 Throw exceptions on errors (as opposed to failures).
4943 Check MD5 sum when it's known.
4944 (download_one): Never force a download.
4945 Handle corrupt package exceptions.
4946 * ini.cc (find_routine): Reverse escape the URL to correctly identify
4947 the site URL.
4948 * inilex.l (MD5): Provide a parsing rule (note: lowercase is required).
ca2b7505 4949 * iniparse.y: Allow calculation of MD5 sums, and allow src only
58ee6135
RC
4950 packages.
4951 (process_src): New helper function.
4952 * isntall.cc (install_one_source): Check MD5 sums when possible.
4953 Throw exceptions on errors.
4954 (do_install_thread): Handle exceptions for installation calls.
4955 * package_source.h: Store MD5 information.
4956 * propsheet.cc (PropSheet::Create): Add a useful comment.
4957 * res.rc (IDS_INSTALL_ERROR): Define.
4958 (IDS_CORRUPT_PACKAGE): Define.
4959 * resource.h (IDS_INSTALL_ERROR): Define.
4960 (IDS_CORRUPT_PACKAGE): Define.
4961 * rfc1738.cc (rfc1738_unescape_part): Implement.
4962 * rfc1738.h (rfc1738_unescape_part): Declare.
4963
45e01f23
RC
49642002-04-29 Robert Collins <rbtcollins@hotmail.com>
4965
4966 * Makefile.am: Remove dependecy rules that automake emits.
4967 Correct badly copied dependency info for manually compiled files.
58b12a06 4968 (setup_SOURCES): Add all used headers.
45e01f23
RC
4969 (EXTRA_DIST): Include non compilate but required sources.
4970 (setup_LDADD): Remove mingw32, it is autodetected.
4971 * Makefile.in: Regenerate.
4972 * String++.h: sys/types is a system header.
4973 * choose.cc (do_choose_thread): Make into a Win32 thread routine.
4974 Use ExitThread.
4975 (ChooserPage::OnMessageApp): Use Win32 threads. (_beginthread is not
4976 portable).
4977 * configure: Regenerate.
4978 * configure.in: Check for mingw32/cygwin specific headers and libraries.
ca2b7505 4979 * cygpackage.h: Include the win32.h header to get correct macro
45e01f23
RC
4980 definitions in all situations.
4981 * download.cc (do_download_reflector): Make into a Win32 thread routine.
4982 Use ExitThread.
4983 (do_download): Use Win32 threads.
4984 * ini.cc: Ditto.
4985 * install.cc: Ditto.
ca2b7505 4986 * (WinMain): Adjust to build valid command line using application
45e01f23 4987 under both mingw32 and cygwin.
ca2b7505 4988 * mount.cc (set)cygdrive_flags): Create new system flags if the
45e01f23
RC
4989 user requests system and the value does not exist.
4990 * nio-http.cc: Define a _strnicmp for cygwin.
4991 * package_db.cc: Include <errno.h> if it exists.
ca2b7505 4992 * site.cc (do_download_site_info_thread): Make into a Win32 thread
45e01f23
RC
4993 routine.
4994 Use ExitThread.
4995 (do_download_site-Info): Use Win32 threads.
ca2b7505 4996 * state.cc: Explicity declare variables to avoid header conflicts
45e01f23
RC
4997 caused by '#define extern" on cygwin.
4998 * win32.h: Include <alloca.h> if it exists.
4999 (_MAX_PATH): Define as MAX_PATH when not defined by windows.h.
5000 (_access): Define as access if not defined by windows.h.
5001
8bb9dad9
RC
50022002-04-27 Robert Collins <rbtcollins@hotmail.com>
5003
5004 * compress_gz.cc (compress_gz::error): EOF is not an error condition.
5005
6908b7d7
RC
50062002-04-27 Robert Collins <rbtcollins@hotmail.com>
5007
5008 * Makefile.am: Add libgetopt++ to the subdirs list.
5009 Search the libgetopt++ header directory.
5010 Link against libgetopt++.la.
5011 (setup_SOURCES): Remove GetOption.cc and getopt.c and Option.cc.
5012 (setup_LDADD): Explicitly include res.o.
5013 * Makefile.in: Regenerate.
5014 * aclocal.m4: Regenerate.
5015 * bootstrap.sh: Call libtoolize.
5016 * configure: Regenerate.
5017 * configure.in: Add libtool support and configure libgetopt++.
5018 * desktop.cc (NoShortcutsOption): Turn into a BoolOption.
5019 (DesktopSetupPage::OnInit): Use the simpler syntax.
5020 * desktop.h: Remove dependency on Option.h, and remove NoShortcustOption
5021 declaration.
5022 * main.cc: Include getopt++/GetOption.h.
5023 (main): Use simpler syntax.
5024 * cdefs.h: Remove.
5025 * getopt.h: Remove.
5026 * getopt.c: Remove.
5027 * GetOption.h: Remove.
5028 * GetOption.cc: Remove.
5029 * Option.h: Remove.
5030 * Option.cc: Remove.
5031
9063358a
RC
50322002-04-26 Robert Collins <rbtcollins@hotmail.com>
5033
5034 * Makefile.am: Add zlib and bz2lib to SUBDIRS.
5035
f6100b6f
RC
50362002-04-26 Robert Collins <rbtcollins@hotmail.com>
5037
5038 * aclocal.m4: New file, cached macros.
ca2b7505 5039 * bootstrap.sh: New file, calls required autotools in appropriate
f6100b6f
RC
5040 order.
5041 * Makefile.am: New file, input Makefile for automake.
5042 * Makefile,in: Now a generated file - regenerate.
5043 * configure: Regenerate.
5044 * configure.in: Add automake support.
5045 * inilex.l: Change VERSION to PACKAGEVERSION to avoid a collision with
5046 automake's VERSION define.
5047 * iniparse.y: Ditto.
5048
db04fc41
RC
50492002-04-26 Robert Collins <rbtcollins@hotmail.com>
5050
5051 * cdefs.h: New file, imported to allow getopt.c to build without
5052 cygwin headers.
5053 * getopt.h: New file, imported to allow building without cygwin headers.
5054 * getopt.c: Ditto.
5055 * bz2lib: New directory, contains copy of bz2lib.
5056 * cfgaux: New directory, contains autotool helper scripts.
ca2b7505 5057 * Makefile,in: Adjust library and target definitions for building
db04fc41
RC
5058 outside the sourceware tree.
5059 * compress_bz.h: Use new bz2lib header location.
5060 * mount.cc: Import key defines and enums to be independent of cygwin
5061 headers.
ca2b7505 5062 * configure.in: Update to autoconf 2.53, and to be sourceware
db04fc41
RC
5063 independent.
5064 * configure: Regenerate.
5065
931f2755
RC
50662002-04-12 Robert Collins <rbtcollins@hotmail.com>
5067
5068 * mklink2.cc (make_link_2): Tweak to work with current w32api
5069 headers.
5070
50712002-04-10 Pavel Tsekov <ptsekov@gmx.net>
5072
5073 * version.cc (canonicalize_version): Fix a call delete[]
5074 to delete the allocated address.
5075
50762002-03-29 Robert Collins <rbtcollins@hotmail.com>
5077
5078 * PickView.cc (PickView::set_headers): Set last_col correctly. Thanks
5079 to Ton van Overbeek for locating the bug area.
5080
49cf3899
RC
50812003-03-27 Robert Collins <rbtcollins@hotmail.com>
5082
5083 * PickView.cc (PickView::insert_pkg): Be more generic with
5084 object use.
5085 (PickView::insert_category): Ditto.
5086 (PickView::~PickView): Create.
5087 * PickView.h (PickView::~PickView): Declare.
5088
1be8f8fd
RC
50892003-03-27 Robert Collins <rbtcollins@hotmail.com>
5090
5091 * Makefile.in (OBJS): Add new commandline objects.
5092 * desktop.cc (NoShortCutsOption): New option code.
5093 (DesktopSetupPage::OnInit): Check whether to skip shortcuts.
5094 * desktop.h (NoShortCutsOption): New concrete command line option class.
5095 * main.cc (WinMain): Process command line options.
5096 * GetOption.h: New file, singleton command line class.
5097 * GetOption.cc: New file, implementation of the above.
5098 * Option.h : New file, abstract option for GetOption.
5099 * Option.cc: New file, implement constructor and destructor.
5100
f2e49cf8
RC
51012002-03-26 Pavel Tsekov <ptsekov@gmx.net>
5102
58b12a06 5103 * mkdir.cc (mkdir_p): Stop processing if the path is exhausted.
f2e49cf8
RC
5104
51052002-03-26 Ton van Overbeek <tvoverbe@cistron.nl>
5106
58b12a06
MB
5107 * PickPackageLine.cc (PickPackageline::paint): Adjust clipping rectangle
5108 to textheight, so large fonts work.
f2e49cf8
RC
5109
51102003-03-26 Robert Collins <rbtcollins@hotmail.com>
5111
58b12a06
MB
5112 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Don't translate
5113 symlinks.
f2e49cf8
RC
5114
51152003-03-26 Robert Collins <rbtcollins@hotmail.com>
5116
58b12a06
MB
5117 * io_stream_cygfile.cc (cwd): New static for cwd storage.
5118 (io_stream_cygfile::normalise): New method.
5119 (io_stream_cygfile::io_stream_cygfile): Use it.
5120 (io_stream_cygfile::exists): Ditto.
5121 (io_stream_cygfile::remove): Ditto.
5122 (io_stream_cygfile::mklink): And again.
5123 (cygmkdir_p): Yes, again.
5124 (io_stream_cygfile::move): And once more.
5125 * io_stream_cygfile.h (io_stream_cygfile::normalise): Declare.
5126 (io_stream_cygfile::cwd): Ditto.
f2e49cf8 5127
51ebb760
RC
51282003-03-26 Robert Collins <rbtcollins@hotmail.com>
5129
5130 * package_meta.cc (package_meta::~package_meta): Remove duplicate.
ca2b7505 5131 (CategoryPackage::~CategoryPackage): Ditto. (Thanks to Ton van
51ebb760
RC
5132 Overbeek for the report).
5133 * mklink2.cc: Moved from mklink2.c to avoid 'not a prototype error'.
5134 Make g++ compatible.
5135 * mklink2.c: Remove.
5136 * site.cc (site_list_type::init): Delete the correct memory addres.
5137 Thanks to Pavel Tsekov for tracking this down.
5138
e7d67c03
RC
51392002-03-20 Robert Collins <rbtcollins@hotmail.com>
5140
5141 * win32.h: Only define alloca if it's not already.
5142
2fa7c5a4
RC
51432002-03-20 Robert Collins <rbtcollins@hotmail.com>
5144
58b12a06
MB
5145 * package_meta.h (packamgemeta::trustp): Make 'test' choice leave
5146 installed packages alone.
2fa7c5a4
RC
5147 * README: Update with latest requests.
5148 * Various: MTC fixes from setup200202 branch.
5149
7bf13fc9
CF
51502002-03-19 Christopher Faylor <cgf@redhat.com>
5151
5152 * Makefile.in (setup_version.c): Add back magic which allows detection
5153 of setup.exe version number.
5154
2fa7c5a4
RC
51552002-03-17 Robert Collins <rbtcollins@hotmail.com>
5156
58b12a06 5157 * PickPackageLine.cc (PickPackageLine::paint): Fix incorrect clip region
2fa7c5a4
RC
5158 calculation on win9x systems.
5159
51602002-03-16 Robert Collins <rbtcollins@hotmail.com>
5161
58b12a06
MB
5162 * install.cc (install_one_source): Write the correct length of a string
5163 to the lst file (Thanks to Pavel Tsekov for reporting the bug).
2fa7c5a4
RC
5164
51652002-03-15 Robert Collins <rbtcollins@hotmail.com>
5166
5167 * choose.cc (list_click): Always refresh the entire chooser, as our
58b12a06
MB
5168 package state change mechanism is broken with the new improved list
5169 classes.
2fa7c5a4
RC
5170
51712002-03-15 Robert Collins <rbtcollins@hotmail.com>
5172
58b12a06
MB
5173 * desktop.cc (make_passwd_group): Check for .lnk suffix on /etc/passwd
5174 and /etc/group.
2fa7c5a4
RC
5175
51762002-03-15 Robert Collins <rbtcollins@hotmail.com>
5177
58b12a06
MB
5178 * PickPackageLine.cc (PickPackageLine::DrawCheck): New method factored
5179 out from paint().
5180 (PickPackageLine::paint): Use DrawCheck to draw the src tick box, and
5181 the new bin tickbox.
2fa7c5a4
RC
5182 (PickPackageLine::click): Handle the new bin tickbox.
5183 * PickPackageLine.h (PickPackageLine::DrawCheck): Declare this.
5184 * PickView.cc (pkg_headers): Add a Bin? column.
5185 (cat_headers): Ditto.
5186 (PickView::set_headers): Ditto.
5187 (PickView::init_headers): Ditto.
5188 * PickView.h (PickView): Ditto.
58b12a06
MB
5189 * choose.cc (list_click): Use the new name for src_col to set the clip
5190 rectangle.
2fa7c5a4
RC
5191
51922002-02-24 Michael A Chase <mchase@ix.netcom.com>
5193
5194 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Fix up Robert's
5195 fixup.
5196
51972002-02-24 Michael A Chase <mchase@ix.netcom.com>
5198
5199 * desktop.cc (make_link): Add "file://" prefix to io_stream::mkpath_p()
5200 call.
5201 (make_passwd_group): Ditto.
5202 * localdir.cc (save_local_dir): Ditto.
5203 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Wrap long lines.
5204 Add "cygfile://" prefix to io_stream::open() calls.
5205
204315f9
RC
52062002-02-24 Robert Collins <rbtcollins@hotmail.com>
5207
5208 * log.cc (log_save): Fix creating /var/log.
5209 * packate_meta.cc (standard_dirs): Remove duplicate '/''s.
5210
58db1046
RC
52112002-02-24 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5212
5213 * res.rc (STRINGTABLE): Add IDS_CYGWIN_SETUP and
5214 IDS_CYGWIN_SETUP_WITH_PROGRESS strings.
5215 * resource.h: Add IDS_CYGWIN_SETUP and
5216 IDS_CYGWIN_SETUP_WITH_PROGRESS IDs.
5217
5218 * splash.cc (OnInit): Qualify SetWindowText() call with global scope
5219 operator (::SetWindowText()).
5220
5221 * threebar.cc: Run indent.
5222 (cistring.h): Add include.
5223 (SetText1, SetText2, SetText3): Qualify SetWindowText() call with
5224 global scope operator.
5225 (SetBar2): Add logic for writing percent complete into window title.
5226
5227 * window.h: Run indent.
5228 (SetWindowText): New function.
5229 (String): Add forward declaration.
5230 * window.cc: Run indent.
5231 (String++.h): Add include.
5232 (SetWindowText): New function.
5233
490717ef
RC
52342002-02-24 Robert Collins <rbtcollins@hotmail.com>
5235
5236 * README: Update TODO list.
5237 * install.cc (install_one): Fix src package location.
5238 (do_install_thread): Fix creating directories.
5239
7c6ef2c3
RC
52402002-02-19 Robert Collins <rbtcollins@hotmail.com>
5241
5242 * choose.cc: Include cygpackage.h for scan2 use.
5243 (set_existence): Ignore setup.ini mirrors when installing from cwd.
5244 (scan2): Process any valid file.
58b12a06
MB
5245 Add cache entries when a file matching a setup.ini listed version is
5246 found.
7c6ef2c3
RC
5247 * filemanip.cc (parse_filename): Remove pkgtar - not used anywhere else.
5248 * filemanip.h (filemanip::pkgtar): Remove.
5249 * package_meta.cc (CategoryPackage::~CategoryPackage): New method.
5250 (packagemeta::~packagemeta): Move from package_meta.h
5251 Remove and delete all version and category information.
5252 * package_meta.h (CategoryPackage): Create a destructor.
5253 (packagemeta::~packagemeta): Move to .cc file.
5254
52552002-02-19 Robert Collins <rbtcollins@hotmail.com>
5256
5257 * install.cc (install_one_source): Make NULL cached package names cause
5258 errors.
5259
bb087dce
RC
52602002-02-18 Michael A Chase <mchase@ix.netcom.com>
5261
5262 * desktop.cc (make_passwd_group): Don't create passwd-grp.bat
5263 unnecessarily.
5264
52652002-02-18 Michael A Chase <mchase@ix.netcom.com>
5266
5267 * log.cc (log_save): Put "\n" at end of log lines instead of "'".
5268
c90bc3df
RC
52692002-02-19 Robert Collins <rbtcollins@hotmail.com>
5270
5271 * mount.cc (create_mount): Avoid a const char*->char* warning.
5272 (read_mounts): Ditto.
5273
3bab9a49
RC
52742002-02-05 Jason Tishler <jason@tishler.net>
5275
58b12a06 5276 * download.cc (do_download_thread): Fix off-by-one error.
3bab9a49 5277
1ac649ed
RC
52782002-02-19 Robert Collins <rbtcollins@hotmail.com>
5279
5280 * configure.in (CXXFLAGS): Substitute at configure time, not runtime.
5281 * configure (CXXFLAGS): Regenerate.
5282 * Makefile.in (iniparse.o): Build via default rules - no errors now.
5283 * README: TODO list updates.
5284
52852002-02-19 Michael A Chase <mchase@ix.netcom.com>
5286
5287 * String++.cc (String::concat):: Remove.
5288 (String::vconcat):: Ditto.
5289 * String++.h (String::concat):: Remove.
5290 (String::vconcat):: Ditto.
5291 * archive_tar.cc: Don't include concat.h.
5292 * archive_tar_file.cc: Don't include concat.h.
5293 * compress_bz.cc (compress_bz::peek): Don't log unneeded messages.
5294 (compress_bz::seek): Ditto.
5295 (compress_bz::~compress_bz): Ditto.
5296 * compress_gz.cc (compress_gz::peek): Ditto.
5297 (compress_gz::error): Ditto.
5298 (compress_gz::~compress_gz): Ditto.
5299 * concat.cc (vconcat): Remove.
5300 (concat): Ditto.
5301 * concat.h (vconcat): Remove.
5302 (concat): Ditto.
5303 * desktop.cc (desktop_icon): Use new cygpath.
5304 (make_etc_profile): Ditto.
5305 (uexists): Ditto.
5306 (make_passwd_group): Ditto.
5307 (save_icon): Ditto.
5308 (check_desktop): Remove concat use.
5309 (check_start_menu): Ditto.
5310 * download.cc (download_one): Use new mkpath_p correctly.
5311 Use LOG_PLAIN.
5312 * fromcwd.cc: Don't include concat.h.
5313 * geturl.cc (get_url_to_membuf): Use String log() call.
5314 (get_url_to_file): Ditto.
5315 * install.cc: Don't include concat.h.
5316 (uninstall_one): Use LOG_PLAIN.
5317 (replace_one): Ditto.
5318 (install_one_source): Ditto.
5319 (install_one): More char to String conversion.
5320 (do_install_thread): Use new cygpath.
5321 Use new create_mount.
5322 * io_stream.cc (io_stream::move): Use new log().
58b12a06
MB
5323 * io_stream_cygfile (io_stream_cygfile::io_stream_cygfile): Use new
5324 cygpath.
1ac649ed
RC
5325 (io_stream_cygfile::exists): Ditto.
5326 (io_stream_cygfile::remove): Ditto.
5327 (io_stream_cygfile::mklink): Ditto.
5328 (io_stream_cygfile::write): Ditto.
5329 (cygmkdir_p): Ditto.
5330 (io_stream_cygfile::move): Ditto.
5331 * io_stream_file.cc: Don't include log.h.
5332 (io_stream_file::write): Don't log unneeded messages.
5333 * localdir.cc: Don't include concat.h.
5334 (LocalDirPage::OnNext): Use LOG_PLAIN.
5335 * log.cc: Don't include log.h.
5336 (exit_setup): Use new cygpath.
5337 * log.h (log_level): Add new level LOG_PLAIN.
5338 * main.cc (WinMain): Use new log().
5339 * mount.cc (SLASH_P): New macro from concat.h.
5340 (cygpath): Make String version globally visible.
5341 Remove varargs version.
5342 * mount,h: Ditto.
5343 * msg.cc (mbox): Use LOG_PLAIN.
5344 * net.cc (NetPage::OnNext): Ditto.
5345 * nio-ftp.cc (ftp_line): Use new log().
5346 * nio-http.cc: Don't include log.h.
5347 (retry_get): Use alternative url variable.
5348 * package_db.cc: Don't include concat.h.
5349 (packagedb::flush): Don't use concat.
5350 * package_meta.cc: Don't include concat.h.
5351 (packagemeta::uninstall): Use new cygpath.
5352 * postinstall.cc (do_postinstall): Ditto.
5353 * root.cc (RootPage::OnNext): Use LOG_PLAIN.
5354 * script.cc: Don't include concat.h.
5355 (init_run_script): Use new cygpath.
5356 (run_script): More char * to String conversion.
5357 (try_run_script): Ditto.
5358 * site.cc: Don't include concat.h.
5359 (SitePage::OnNext): Use LOG_PLAIN.
5360 (SitePage::OnMessageCmd): Use new log().
5361 * source.cc (SourcePage::OnDeactivate): Use LOG_PLAIN.
5362
3c054baf
RC
53632002-02-19 Robert Collins <rbtcollins@hotmail.com>
5364
5365 * Makefile.in (OBJS): Add new object.
58b12a06
MB
5366 * PickCategoryLine.cc (PickCategoryLine::paint): Print a "+" before the
5367 name.
3c054baf
RC
5368 * PickCategoryLine.h (PickCategoryLine::bucket): Use the String class.
5369 * PickLine.h (Pickline::key): Change to a String to help plug leaks.
5370 (PickLine::Pickline): Accept a String for the key.
58b12a06
MB
5371 * PickPackageLine.cc (PickPackageLine::paint): Convert all char use to
5372 Strings.
5373 * PickPackageLine.h (PickPackageLine::PickPackageLine): The key is
5374 automatically initialised now.
3c054baf 5375 * PickView.cc (PickView::note_width): Convert all char * use to Strings.
58b12a06
MB
5376 (PickView::init_header): Move category length checking out of the inner
5377 loop for efficiency.
3c054baf
RC
5378 Convert all char use to Strings.
5379 * PickView.h: Include the String++ header.
5380 (PickView::note_width): Update the prototype.
5381 * String++.cc: New file, implements a reference counting string class.
5382 * String++.h: New file, declares a reference counting string class.
5383 * archive.cc: Include String++ instead of concat.
5384 (archive::extract_file): Convert char * usage to Strings.
5385 * archive.h: Inlude the String++ header.
5386 (archive::extract_file): Update prototype.
5387 (archive::next_file_name): Convert to a String.
5388 (archive::linktarget): Ditto.
5389 * archive_tar.cc (archive_tar::next_file_name): Convert to String usage.
5390 (archive_tar::linktarget): Ditto.
5391 * arhive_tar.h: Update the copyright.
5392 Explicitly include the relevant headers.
5393 (tar_map_result_type): Convert to String usage.
5394 (archive_tar::next_file_name): Update prototype.
5395 (archive_tar::linktarget): Ditto.
5396 * category.cc (Category::Category): Update initialisers.
5397 Convert to String usage.
5398 (Categorycmp): Update to String usage.
5399 * category.h: Include the String++ header.
5400 (Category::Category): Update to String usage.
5401 (Category::name): Ditto.
5402 (Category::key): Ditto.
5403 * choose.cc: Remove concat.h, it's not needed.
5404 (scan2): Update to String usage.
5405 (do_choose): Ditto.
5406 * cygpackage.cc: Update includes for use of String class.
5407 (cygpackage::cygpackage): Update for String usage.
5408 (cygpackage::set_canonical_version): Ditto.
5409 (cygpackage::destroy): Ditto.
5410 (cygpackage::getfirstfile): Ditto.
5411 (cygpackage::getnextfile): Ditto.
5412 (cygpackage::Name): Ditto.
5413 (cygpackage::Vendor_version): Ditto.
5414 (cygpackage::Package_version): Ditto.
5415 (cygpackage::Canonical_version): Ditto.
5416 (cygpackage::set_sdesc): Ditto.
5417 (cygpackage::set_ldesc): Ditto.
5418 * cygpackage.h: Include String++.h for parsing this file.
5419 (cygpackage::cygpackage): Update for String usage.
5420 (cygpackage::set_canonical_version): Ditto.
5421 (cygpackage::destroy): Ditto.
5422 (cygpackage::getfirstfile): Ditto.
5423 (cygpackage::getnextfile): Ditto.
5424 (cygpackage::Name): Ditto.
5425 (cygpackage::Vendor_version): Ditto.
5426 (cygpackage::Package_version): Ditto.
5427 (cygpackage::Canonical_version): Ditto.
5428 (cygpackage::set_sdesc): Ditto.
5429 (cygpackage::set_ldesc): Ditto.
5430 (cygpackage::name): Ditto.
5431 (cygpackage::vendor): Ditto.
5432 (cygpackage::packagev): Ditto.
5433 (cygpackage::canonical): Ditto.
5434 (cygpackage::fn): Ditto.
5435 (cygpackage::sdesc): Ditto.
5436 (cygpackage::ldesc): Ditto.
5437 * desktop.cc: Update includes for use of String class.
5438 (batname): Update for String usage.
5439 (iconname): Ditto.
5440 (make_link): Ditto.
5441 (start)menu): Ditto.
5442 (desktop_icon): Ditto.
5443 (make_cygwin_bat): Ditto.
5444 (make_etc_profile): Ditto.
5445 (uexists): Ditto.
5446 (make_passwd_group): Ditto.
5447 (save_icon): Ditto.
5448 (check_desktop): Ditto.
5449 (check_startmenu): Ditto.
5450 * dialog.cc (eget): Update for String usage.
5451 (egetString): New function.
5452 (eset): New variant for Strings.
5453 * dialog.h: Include String++.h for parsing this file.
5454 (egetString): New function.
5455 (eset): New variant for Strings.
5456 * diskfull.cc (diskfull): Update for String usage.
5457 * diskfull.h: Include String++.h for parsing this file.
5458 (diskfull): Update for String usage.
5459 * download.cc: Update includes for use of String class.
5460 (check_for_cached): Update for String usage.
5461 (download_one): Ditto.
5462 * filemanip.cc (get_file_size): Ditto.
5463 (base): Ditto.
5464 (parse_filename): Ditto.
5465 (backslash): Ditto.
5466 * filemanip.h: Include String++.h for parsing this file.
5467 (fileparse): Update for String usage.
5468 (base): Ditto.
5469 (parse_filename): Ditto.
5470 Don't consider '_' to be a separator.
5471 (backslash): Ditto.
5472 * find.cc: Update includes for use of String class.
5473 (find_sub): Make more flexible.
5474 (find): Update for String usage.
5475 * find.h (find): Use Strings.
5476 * fromcwd.cc (found_file): Update for String usage.
5477 * geturl.cc: Ditto.
5478 (init_dialog): Ditto.
5479 (get_url_to_membuf): Ditto.
5480 (get_url_to_string): Ditto.
5481 (get_url_to_file): Ditto.
5482 * geturl.h: Ditto.
5483 (get_url_to_membuf): Ditto.
5484 (get_url_to_string): Ditto.
5485 (get_url_to_file): Ditto.
5486 * hash.h: Ditto.
5487 (add_subdirs): Ditto.
5488 * ini.cc: Update includes for String usage.
5489 (find_routine): Update for String usage.
5490 (do_remote_ini): Ditto.
5491 (do_ini_thread): Ditto.
5492 * ini.h (ini_init): Ditto.
5493 * inilex.l: Update includes for String usage.
5494 (ini_init): Update for String usage.
5495 * iniparse.y: Ditto.
5496 (add_correct_version): Ditto.
5497 * install.cc: Update includes for String usage.
5498 (install_one_source): Update for String usage.
5499 (uninstall_one): Ditto.
5500 (replace_one): Ditto.
5501 (install_one_source): Ditto.
5502 (do_install_thread): Ditto.
5503 * io_stream.cc: Update includes for String usage.
5504 (io_stream::open): Update for String usage.
5505 (io_stream::mkpath_p): Ditto.
5506 (io_stream::remove): Ditto.
5507 (io_stream::mklink): Ditto.
5508 (io_stream::move_copy): Ditto.
5509 (io_stream::move): Ditto.
5510 (io_stream::exists): Ditto.
5511 * io_stream.h: Update includes to allow correct parsing.
5512 (io_stream::open): Update for String usage.
5513 (io_stream::mkpath_p): Ditto.
5514 (io_stream::remove): Ditto.
5515 (io_stream::mklink): Ditto.
5516 (io_stream::move_copy): Ditto.
5517 (io_stream::move): Ditto.
5518 (io_stream::exists): Ditto.
5519 * io_stream_cygfile.cc: Update includes for String usage.
5520 (get_root_dir_now): Update for String usage.
5521 (io_stream_cygfile::io_stream_cygfile): Ditto.
5522 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5523 (io_stream_cygfile::exists): Ditto.
5524 (io_stream_cygfile::remove): Ditto.
5525 (io_stream_cygfile::mklink): Ditto.
5526 (cygmkdir_p): Ditto.
5527 (io_stream_cygfile::set_mtime): Ditto.
5528 (io_stream_cygfile::move): Ditto.
5529 (io_stream_cygfile::get_size): Ditto.
5530 * io_stream_cygfile.h: Update includes for String usage.
5531 (io_stream_cygfile::io_stream_cygfile): Update for String usage.
5532 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5533 (io_stream_cygfile::exists): Ditto.
5534 (io_stream_cygfile::remove): Ditto.
5535 (io_stream_cygfile::mklink): Ditto.
5536 (cygmkdir_p): Ditto.
5537 (io_stream_cygfile::set_mtime): Ditto.
5538 (io_stream_cygfile::move): Ditto.
5539 (io_stream_cygfile::get_size): Ditto.
5540 (io_stream_cygfile::fname): Ditto.
5541 (io_stream_cygfile::lmode): Ditto.
5542 * io_stream_file.cc: Update includes for String usage.
5543 (io_stream_file::io_stream_file): Update for String usage.
5544 (io_stream_file::~io_stream_file): Ditto.
5545 (io_stream_file::exists): Ditto.
5546 (io_stream_file::remove): Ditto.
5547 (io_stream_file::mklink): Ditto.
5548 (io_stream_file::set_mtime): Ditto.
5549 (io_stream_file::move): Ditto.
5550 (io_stream_file::get_size): Ditto.
5551 * io_stream_file.h: Update includes for String usage.
5552 * io_stream_file.cc: Update includes for String usage.
5553 (io_stream_file::io_stream_file): Update for String usage.
5554 (io_stream_file::~io_stream_file): Ditto.
5555 (io_stream_file::exists): Ditto.
5556 (io_stream_file::remove): Ditto.
5557 (io_stream_file::mklink): Ditto.
5558 (io_stream_file::set_mtime): Ditto.
5559 (io_stream_file::move): Ditto.
5560 (io_stream_file::get_size): Ditto.
5561 (io_stream_file::fname): Ditto.
5562 (io_stream_file::lmode): Ditto.
5563 * localdir.cc: Update includes for String usage.
5564 (save_local_dir): Update for String usage.
5565 (check_if_enable_next): Ditto.
5566 (load_dialog): Ditto.
5567 (browse_cb): Ditto.
5568 (LocalDirPage::OnInit): Ditto.
5569 (LocalDirPage::OnNext): Ditto.
5570 * log.cc: Update includes for String usage.
5571 (struct LogEnt): Update for String usage.
5572 (log): Ditto.
5573 (log_save): Ditto.
5574 (exit_setup): Ditto.
5575 * log.h: Update includes for String usage.
5576 (log_level): Update for String usage.
5577 (log): Ditto.
5578 (log_save): Ditto.
5579 * main.cc (WinMain): Update for String usage.
5580 * mklink2.c (make_link_2): Update for String usage.
5581 * mklink2.h (make_link_2): Update for String usage.
5582 * mount.cc: Update includes for String usage.
5583 (mount_table): Update for String usage.
5584 (find2): Ditto.
5585 (create_mount): Ditto.
5586 (remove1): Ditto.
5587 (remove_mount): Ditto.
5588 (read_mounts): Ditto.
5589 (set_root_dir): Ditto.
5590 (get_root_dir): Ditto.
5591 (path_prefix_p): Ditto.
5592 (cygpath): Ditto.
5593 * mount.h: Update includes for String usage.
5594 (create_mount): Update for String usage.
5595 (remove_mount): Ditto.
5596 (cygpath): Ditto.
5597 (set_root_dir): Ditto.
5598 (get_root_dir): Ditto.
5599 * msg.cc (mbox): Ditto.
5600 * net.cc (NetPage::OnNext): Ditto.
5601 * package_db.cc (packagedb::flush): Ditto.
5602 (packagedb::packages): Ditto.
5603 (packagedb::categories): Ditto.
5604 * package_db.h: Update includes for String usage.
5605 (packagedb::packages): Update for String usage.
5606 (packagedb::categories): Ditto.
5607 * package_meta.cc: Update includes for String usage.
5608 (hash::add_subdirs): Update for String usage.
5609 (packagemeta::uninstall): Ditto.
5610 (packagemeta::SDesc): Ditto.
5611 (packagemeta::action_caption): Ditto.
5612 * package_meta.h: Update includes for String usage.
5613 (packagemeta::packagemeta): Update for String usage.
5614 (packagemeta::~packagemeta): Ditto.
5615 (packagemeta::uninstall): Ditto.
5616 (packagemeta::SDesc): Ditto.
5617 (packagemeta::action_caption): Ditto.
5618 (package_source.cc site::site): Ditto.
5619 (packagesource::set_canonical): Ditto.
5620 (packagesource::set_cached): Ditto.
5621 * package_source.h: Update includes for String usage.
5622 (site::site): Update for String usage.
5623 (packagesource::set_canonical): Ditto.
5624 (packagesource::set_cached): Ditto.
5625 (packagesource::packagesource): Ditto.
5626 (packagesource::sites): Ditto.
5627 (packagesource::cached): Ditto.
5628 * package_version.h: Update includes for String usage.
5629 (Dependency): Update for String usage.
5630 (packageversion): Ditto.
5631 * postinstall.cc: Update includes for String usage.
5632 (do_postinstall): Update for String usage.
5633 * res.rc (IDD_LOCAL_DIR): Fix typo again!
5634 * rfc1738.cc (rfc1738_escape_part): Update for String usage.
5635 * rfc1738.h: Update includes for String usage.
5636 (rfc1738_escape_part): Update for String usage.
5637 * root.cc: Update includes for String usage.
5638 (check_if_enable_next): Update for String usage.
5639 (save_dialog): Ditto.
5640 (browse_cb): Ditto.
5641 (directory_is_absolute): Ditto.
5642 (directory_is_rootdir): Ditto.
5643 (directory_has_spaces): Ditto.
5644 (RootPage::OnInit): Ditto.
5645 (RootPage::OnNext): Ditto.
5646 * script.cc: Update includes for String usage.
5647 (init_run_script): Update for String usage.
5648 (run): Ditto.
5649 (run_script): Ditto.
5650 (try_run_script): Ditto.
5651 * script.h: Update includes for String usage.
5652 (run_script): Update for String usage.
5653 (try_run_script): Ditto.
5654 * site.cc site_list): Ditto.
5655 (all_site_list): Ditto.
5656 (other_url): Eliminate.
5657 (site_list_type::init): Update for String usage.
5658 (site_list_type::site_list_type): Ditto.
5659 (get_site_list): Ditto.
5660 (get_saved_sites): Ditto.
5661 (do_download_site_info_thread): Ditto.
5662 (SitePage::OnNext): Ditto.
5663 (SitePage::OnActivate): Ditto.
5664 (SitePage::PopulateListBox): Ditto.
5665 (SitePage::OnMessageCmd): Handle empty url's.
5666 * site.h: Update includes for String usage.
5667 (site_list_type::site_list_type): Update for String usage.
5668 (site_list_type::init): Ditto.
5669 (site_list_type::~site_list_type): Ditto.
5670 (site_list_type::url): Ditto.
5671 (site_list_type::displayed_url): Ditto.
5672 (site_list_type::key): Ditto.
5673 * source.cc (SourcePage::OnDeactivate): Ditto.
5674 * state.h: Update includes for String usage.
5675 (local_dir): Update for String usage.
5676 (trust_level): Remove.
5677 * version.cc: Update includes for String usage.
5678 (canonicalize_version): Update for String usage.
5679 * version.h: Update includes for String usage.
5680 (canonicalize_version): Update for String usage.
5681
08233ec7
CF
56822002-02-15 Christopher Faylor <cgf@redhat.com>
5683
5684 * filemanip.c (parse_filename): Revert previous change.
5685
94dffbdd
CF
56862002-02-14 Christopher Faylor <cgf@redhat.com>
5687
5688 * filemanip.c (parse_filename): Don't treat '_' as a version number
5689 introducer.
5690
cef493d7
CF
56912002-01-29 Christopher Faylor <cgf@redhat.com>
5692
5693 * configure: Regenerate.
5694
57219197
RC
56952002-01-27 Robert Collins <rbtcollins@hotmail.com>
5696
94dffbdd
CF
5697 * res.rc (IDD_LOCAL_DIR): Fix typo reported by Rene
5698 <Hoeck@extern.lrz-muenchen.de>
57219197 5699
cc7493c3
RC
57002002-01-27 Robert Collins <rbtcollins@hotmail.com>
5701
5702 * README: Update Todo's.
5703 * list.h: Run indent.
5704 (list): New methods checksize and insert to reduce code duplication.
5705 (list::registerbykey): Use them.
5706 (list::registerbyobject): Ditto.
94dffbdd
CF
5707 (list::removebyindex): Copy each object individually - safe for non
5708 trivial objects.
cc7493c3
RC
5709 (list::checksize): Implement.
5710 (list::insert): Implement.
5711
a900d1fa
RC
57122002-01-27 Robert Collins <rbtcollins@hotmail.com>
5713
5714 * Makefile.in: Remove the dlmalloc object by default.
94dffbdd
CF
5715 * install.cc (do_install_thread): Remove the mallinfo call for 'working
5716 around' the crashing issue.
a900d1fa 5717 * package_db.h: Include <string.h> - it's needed to parse this.
94dffbdd 5718 * package_source.cc (site::site): Move here from the header file.
a900d1fa
RC
5719 * package_source.h (site): Stop the constructor being inlinable.
5720
9835fb4a
RC
57212002-01-26 Robert Collins <rbtcollins@hotmail.com>
5722
5723 * filemanip.cc (find_tar_ext): Add a descriptive comment.
5724
57252002-01-25 Michael A Chase <mchase@ix.netcom.com>
5726
5727 * filemanip.cc (find_tar_ext): Clean up tests for .tar.gz and .tar.
5728 * fromcwd.cc (do_fromcwd): Expand FIXME comment in source file check.
94dffbdd
CF
5729 * install.cc (install_one_source): Add space between words in log()
5730 call.
cef493d7 5731
77ba23d8
RC
57322002-01-22 Robert Collins <rbtcollins@hotmail.com>
5733
94dffbdd
CF
5734 * log.cc (exit_setup): When saving to the download dir, explicity
5735 specify the path.
77ba23d8 5736
6dc75764
RC
57372002-01-22 Robert Collins <rbtcollins@hotmail.com>
5738
94dffbdd
CF
5739 * archive.cc (extract_file): Separate out the prefix and the URL
5740 scheme.
6dc75764 5741 * archive.h (archive::extract_file): Ditto.
94dffbdd
CF
5742 * install.cc (install_one_source): Ditto. Use the new
5743 archive::extract_file syntax.
6dc75764
RC
5744 (replace_one): Use the new syntax.
5745 (io_stream.cc): Add some log info for links.
5746
7e8fc33c
RC
57472002-01-22 Robert Collins <rbtcollins@hotmail.com>
5748
5749 * PickCategoryLine.cc (PickCategoryLine::actiontext): Remove.
5750 (PickCategoryLine::paint): Use the new action method.
5751 (PickCategoryLine::click): Set the action for all children.
5752 (PickCategoryLine::set_action): New method.
5753 * PickCategoryLine.h (PickCategoryLine::-actions): Remove.
5754 (PickCategoryLine::current_default): Use packagemeta _actions class.
94dffbdd
CF
5755 * PickLine.h (PickLine::set_action): New abstract method that requires
5756 including package_meta.h.
7e8fc33c
RC
5757 * PickPackageLine.cc (PickPackageLine::set_action): New method.
5758 * PickPackageLine.h (PickPackageLine::set_action): Declare this.
5759 * list.h (getbykey): A const correctness fix.
5760 * package_meta.cc: Run indent.
5761 (packagemeta::Default_action): New const.
5762 (packagemeta::Install_action): Ditto.
5763 (packagemeta::Reinstall_action): Ditto.
5764 (packagemeta::Uninstall_action): Ditto.
5765 (packagemeta::_actions::caption): New method.
5766 (packagemeta::_actions::operator++): Ditto.
5767 (packagemeta::set_action): New overload.
5768 * package_meta.h (packagemeta::_actions): New class.
5769 (packagemeta::set_action): Declare this.
5770
2c9254b6
RC
57712002-01-22 Robert Collins <rbtcollins@hotmail.com>
5772
5773 * Makefile.in (OBJS): Remove supp.o - it appears accidental.
5774 * choose.cc: Don't define alloca anymore, it's done in win32.h
5775
97647369
RC
57762002-01-22 Robert Collins <rbtcollins@hotmail.com>
5777
5778 * PickPackageLine.cc: New file.
5779 * PickPackageLine.h: New file.
5780 * PickLine.cc: New file.
5781 * PickLine.h: New file.
5782 * PickCategoryLine.cc: New file.
5783 * PickCategoryLine.h: New file.
5784 * PickView.cc: New file.
5785 * PickView.h: New file.
5786 * Makefile.in: Add new objects to setup.exe.
5787 Backout -fno-exceptions option.
5788 * choose.cc: Include PickView.h.
5789 Remove view related defines and static variables.
5790 (_pkg_headers): Moved to PickView.cc.
5791 (_cat_headers): Ditto.
5792 (view::views::Unknown): Ditto.
5793 (view::views::PackageFull):
5794 (view::views::Package):
5795 (view::views::Category):
5796 (pkgtrustp): Moved to package_meta.cc.
5797 (add_required): Moved to package_meta.cc.
5798 (pick_category_line::empty): Moved to PickCategoryLine.cc
5799 (paint): Adjust for moved static variables.
5800 (view::scroll): Moved to PickView.cc.
5801 (list_vscroll): Adjust for moved static variables.
5802 (list_hscroll): Ditto.
5803 (list_click): Ditto.
5804 (note_width): Moved to PickView.cc.
5805 (view::view): Ditto.
5806 (view::set_view_mode): Ditto.
5807 (view::mode_caption): Ditto.
5808 (view::views::caption): Ditto.
5809 (view::set_headers): Ditto.
5810 (DoInsertItem): Ditto.
5811 (view::init_headers): Ditto.
5812 (view::insert_pkg): Ditto.
5813 (view::insert_category): Ditto.
5814 (view::clear_view): Ditto.
5815 (view::views::operator++): Ditto.
5816 (view::click): Ditto.
5817 (default_trust): Adjust for moved statics.
5818 (pick_pkg_line::paint): Moved to PickPackageLine.cc.
5819 (pick_pkg_line::click): Ditto.
5820 (pick_category_line::actiontext): Moved to PickCategoryLine.cc
5821 (pick_category_line::paint): Ditto.
5822 (pick_category_line::click): Ditto.
5823 (set_view_mode): Adjust for moved statics.
5824 (create_listview): Ditto.
58b12a06
MB
5825 * choose.h: Remove Category and packagemeta forward defines -
5826 not needed.
97647369
RC
5827 Don't include unneeded headers list and package_meta.
5828 (_header): Move to PickView.h.
5829 (pick_line): Move to PickLine.h.
5830 (pick_pkg_line): Move to PickPackageLine.h.
5831 (pick_category_line): Move to PickCategoryLine.h.
5832 (view): Move to PickView.h.
5833 * ini.h (trusts): Move to package_meta.h.
5834 * package_meta.h (trusts): New enum.
5835 (packagemeta::set_requirements): New helper method.
5836 (packagemeta::trustp): Ditto.
5837
b566778e
CF
58382002-01-21 Christopher Faylor <cgf@redhat.com>
5839
5840 * choose.h (view): Move forward declaration of views into public area
5841 or g++ v3 will complain.
5842
f71e9756
CF
58432002-01-21 Christopher Faylor <cgf@redhat.com>
5844
5845 * Makefile.in (CXXFLAGS): Add -fno-exceptions.
5846 * win32.h (alloca): Define as __builtin_alloca.
5847 * io_stream_memory.cc: Add include file.
5848
e9440f0f
RC
58492002-01-21 Robert Collins <rbtcollins@hotmail.com>
5850
58b12a06
MB
5851 * archive_tar.cc (archive_tar::~archive_tar): Mark the stream as
5852 destroyed.
e9440f0f
RC
5853 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
5854 * compress.cc (compress::~compress): Be less verbose.
5855 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
5856 Mark the stream as destroyed.
58b12a06
MB
5857 * compress_gz.cc (compress_gz::~compress_gz): Mark the stream as
5858 destroyed.
5859 * io_stream.cc (io_stream::~io_stream): Only warn when the stream is not
5860 marked as destroyed.
cef493d7 5861 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Mark the
e9440f0f
RC
5862 stream as destroyed.
5863 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
5864 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
cef493d7 5865
5e0464a1
RC
58662002-01-21 Robert Collins <rbtcollins@hotmail.com>
5867
5868 * Makefile.in (CFLAGS): Allow customisable malloc debug flags.
5869 (OBJS): Link in malloc objects.
5870 * category.cc (category): Use new char, not strdup.
5871 * choose.cc (pick_pkg_line::paint): Allow for the regionsize to shrink.
5872 (do_choose): Use new char, not malloc.
5873 * concat.cc (vconcat): Ditto.
5874 * cygpackage.cc (cygpackage): Use new char, not strdup.
5875 (set_canonical_version): Ditto.
5876 (cygpackage::destroy): Use delete[], not free.
5877 * desktop.cc (uexists): Ditto.
5878 * dialog.cc (egest): Use new char, not strdup.
5879 * dlmalloc.c: New file - Doug Lea's malloc 2.7.0
5880 * hash.cc (hash::hash): Use delete instead of free.
5881 (hash::add): Use new char, not strdup.
5882 * ini.cc (do_remote_ini): Use delete[] not free.
5883 * inilex.l: Use new char, not strdup.
5884 (ini_init): Ditto.
5885 * iniparse.y: Ditto.
5886 Use a local package_db rather than a static one.
5887 * install.cc (struct mallinfo): Workaround an apparent dlmalloc bug.
5888 (do_install_thread): Call mallinfo to force a consistency check. Appears
5889 to fix a 'inuse' error in -DDEBUG builds.
5890 Use delete[] for strings.
58b12a06
MB
5891 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Use new
5892 char, not strdup.
5e0464a1
RC
5893 (io_stream_cygfile::~io_stream_cygfile): Use delete[], not free.
5894 (io_stream_cygfile::remove): Use new char, not strdup.
58b12a06
MB
5895 * io_stream_file.cc (io_stream_file::io_stream_file): Use new char, not
5896 strdup.
5e0464a1
RC
5897 (io_stream_file::io_stream_file): Use delete[], not free.
5898 (io_stream_file::remove): Use new char, not strdup.
5899 * io_stream_memory.cc (memblock::~memblock): Use delete[], not free.
5900 * io_stream_memory.h (memblock): Use new char, not malloc.
5901 * localdir.cc (LocalDirPage::OnInit): Use new char, not strdup.
5902 * main.cc (WinMain): Use new char, not strdup.
5903 * mount.cc (find2): Use new char, not malloc.
5904 (read_mounts): Ditto.
5905 (cygpath): Use new char, not strdup.
5906 * netio.cc (NetIO::~NetIO): Use delete[], not free.
5907 (NetIO::set_url): Use new char, not strdup.
5908 (NetIO::get_ftp_auth): Use delete[], not free.
5909 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
5910 Use new char instead of strdup.
5911 * nio-http.cc (base64_encode): Use new char, not malloc.
5912 * package_meta.cc (hash::add_subdirs): Use new char instead of strdup.
5913 * package_source.h (~ packagesource): Use delete[] instead of delete.
5914 * port.h (strdup): Deprecate the use of strdup.
5915 * rfc1738.cc (rfc1738_do_escape): Use new char, not calloc.
5916 * script.cc (init_run_script): Us delete[], not free.
5917 (run_script): Ditto.
5918 * simpsock.cc (SimpleSocket::fill): Use new char, not malloc.
5919 (SimpleSocket::invalidate): Use delete[], not free.
5920 * site.cc (site_list_type::init): Use new char instead of strdup.
5921 * site.h (~site_list_type): Use delete[], not free.
5922
ad3c7385
RC
59232002-01-20 Robert Collins <rbtcollins@hotmail.com>
5924
5925 * Makefile.in (OBJS): Add win32.o - win32 support functions.
5926 * README: Update todos.
58b12a06
MB
5927 * archive.cc (extract_file): Support a suffix for appending to extracted
5928 files.
ad3c7385
RC
5929 * archive.h: Ditto.
5930 * choose.cc (set_view_mode): Use the new view::views class.
5931 (view::views::Unknown): New static for defaulting view::views variables.
5932 (view::views::PackageFull): New static for the current view.
5933 (view::views::Package): Ditto.
5934 (view::views::Category): Ditto.
5935 (topbucket::paint): Remove.
5936 (topbucket::empty): Rename to pick_category_line::empty.
5937 (topbucket::~topbucket): Remove.
5938 (paint): Use the new view::views class.
5939 Don't paint 'all' as a category when showing package categoies.
5940 (pick_category_line::actiontext): New method.
58b12a06
MB
5941 (pick_category_line::paint): Make showing the category optional, and
5942 show the 'category action'.
ad3c7385 5943 (pick_category_line::click): Make showing the category optional, and
58b12a06
MB
5944 differentiate between the name being clicked, and the action
5945 description.
ad3c7385
RC
5946 (view::view): Use the new view::views class.
5947 (view::set_view_mode): Ditto.
5948 (view::mode_caption): Ditto.
5949 (view::views::caption): New method.
5950 (view::set_headers): Use the new view::views class.
5951 (view::clear_view): Ditto.
cef493d7 5952 (viewsplusplus): Replaced by
ad3c7385
RC
5953 (view::views::operator++): New operator.
5954 (set_view_mode): Use the new view::views class.
5955 (create_listview): Ditto.
5956 (dialog_cmd): Ditto.
5957 * choose.h (actions): Remove.
5958 (views): Remove.
5959 (pick_line): Add a new convenience constructor.
5960 (top_bucket): Remove.
5961 (pick_category_line): Reparent under pick_line, and adsorb top_bucket.
5962 (view::views): New class.
5963 * ini.h: Don't include choose.h
5964 (is_download_action): Remove.
5965 (is_upgrade_action): Remove.
5966 (is_uninstall_action): Remove.
5967 (is_full_action): Remove.
5968 * install.cc (num_replacements): New static.
5969 (rebootneeded): Ditto.
5970 (replace_one): Handle upgrades separate from removal or new installs.
5971 (install_one_source): Handle in use files.
5972 (install_one): Don't repeat upgrades.
5973 (do_install_thread): Initialize new statics.
5974 Order actions as uninstall, replace, install.
5975 Warn about rebooting if needed.
5976 * res.rc (IDS_REBOOT_REQUIRED): New string.
5977 * resource.h (IDS_REBOOT_REQUIRED): Give value.
5978 * win32.h: Declare class Win32, and update copyright and intent message.
5979 * win32.cc: New file.
5980
edef4f57
CV
59812002-01-15 Corinna Vinschen <corinna@vinschen.de>
5982
5983 * io_stream.cc (io_stream::gets): Eliminate trailing new line chars.
5984 * package_meta.cc (packagemeta::uninstall): Check for additional
5985 Windows shortcut. Unset R/O file attribute before trying to delete
5986 file.
5987
21f325d7
RC
59882002-01-09 Robert Collins <rbtcollins@hotmail.com>
5989
58b12a06
MB
5990 * choose.cc (pkgtrustp): Fall back to installed if a package is not
5991 present in the current trust level. For prev, fall back via curr.
21f325d7
RC
5992 (set_existence): Allow sources with no sites, but cached files to be
5993 kept.
5994 (pick_category_line::paint): Start drawing clickable categories.
5995 * fromcwd.cc (found_file): Reinstate local file scanning.
5996
858f100d
RC
59972002-01-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5998
cef493d7 5999 * fromcwd.cc: Run indent.
858f100d
RC
6000 (do_fromcwd): Reverse sense of comment. Set next_dialog
6001 to IDD_CHOOSER instead of IDD_CHOOSE.
6002 * ini.cc (find_routine): Remove "/" from "/setup.ini".
cef493d7 6003
d343da15
RC
60042001-01-07 Robert Collins <rbtcollins@hotmail.com>
6005
6006 * category.cc (Categorycmp): Add a const safe version.
6007 * category.h (Categorycmp): Add a const safe version.
6008 (Category): Add operator ==.
6009 * choose.cc (fill_missing_category): Add every package to "All".
58b12a06
MB
6010 (pick_category_line::paint): Add support for hidden labels, and a tree
6011 depth.
d343da15
RC
6012 (pick_category_line::click): Ditto.
6013 (view::view): Pass in a top level category to use.
6014 (view::insert_pkg): Special case - skip category "All".
6015 (view::insert_category): Ditto.
6016 (view::clear_view): Set the contents label state.
6017 (create_listview): Pass in a top level category to view().
6018 * choose.h (topbucket): Make bucket available to derived classes.
6019 (pick_category_line): Add support for hidden labels, and a tree depth.
6020 Remove our second copy of bucket.
6021 (view): Pass in a top level category to the constructor.
6022 Use pick_category_line to allow three level display.
6023
bcf20115
RC
60242001-01-06 Robert Collins <rbtcollins@hotmail.com>
6025
6026 * cygpackage.h (cygpackage): Make set_[s|l]desc virtual.
6027 * iniparse.y (add_correct_version): Copy descriptions across.
58b12a06
MB
6028 * package_meta.cc (SDesc): Iterate through versions, return the first
6029 with a description.
bcf20115
RC
6030 * package_version.h (packageversion): Add new virtuals set_[l|s]desc.
6031
bc78a6d5
RC
60322001-01-04 Robert Collins <rbtcollins@hotmail.com>
6033
6034 * script.cc (run_script): Change cygpath:// to cygfile://.
6035 * install.cc (do_install_thread): Fix off-by-one errors.
6036
4f4e55c2
RC
60372001-01-04 Robert Collins <rbtcollins@hotmail.com>
6038
6039 * package_db.cc (packagedb::flush): Fix an off-by-one error.
6040
8e9aa511
RC
60412002-01-04 Jan Nieuwenhuizen <janneke@gnu.org>
6042
6043 * Makefile.in (realclean): more clean.
6044 (OBJS): Add script.o.
6045 * postinstall.cc (run_script_in_etc_postinstall): New function.
6046 (do_postinstall): Split off new funtion init_run_script ().
6047 (init_run_script):
6048 (run):
6049 (run_script): Move to script.cc. Replace some deprecated remove
6050 and move calls.
6051 * script.h:
6052 * script.cc: New file.
6053 * Forward port cygwin-20010707.jcn3.patch.
6054 * package_meta.cc (uninstall): Run pre- and postremove scripts.
6055 * install.cc: Typo fix.
6056 (do_install): Run script initialisation.
cef493d7 6057
b7301c43
RC
60582001-01-04 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6059
6060 * cistring.cc: Run d2u.
6061 * cistring.h: Run d2u.
6062
6063 * desktop.cc (etc_profile): Remove "test -f ./.bashrc && . ./.bashrc"
6064 from the generated /etc/profile. Bash will source this file
6065 automatically, and having this here merely results in .bashrc being
6066 executed twice. Run d2u.
6067 * desktop.h: Run d2u.
6068
6069 * propsheet.cc: Run d2u.
6070 (PropSheetProc): New function. Add minimize box here instead of in
6071 PropertyPage::DialogProc.
6072 (PropSheet::Create): Change to use creation callback PropSheetProc.
6073 (DLGTEMPLATEEX): Add 'hidden' Windows struct definition.
6074
6075 * propsheet.h: Run indent, d2u.
6076 * proppage.h: Run indent, d2u.
6077
6078 * proppage.cc: Run d2u.
6079 (PropertyPage::DialogProc): Remove minimize-box-adding
6080 functionality. Remove commented-out "PropSheet_SetWizButtons" calls.
6081 Add support for calling virtual OnMessageCmd. Add setting of fonts in
6082 WM_INITDIALOG handler.
6083 (resource.h): New include for resource IDs.
6084
6085 * res.rc: Resize and rearrange property page dialog templates
6086 to bring them in line with "Microsoft's Backward Compatible Wizard 97"
6087 specification. Run d2u.
6088 (IDD_SITE): Add an edit control and an "Add" button in order to
6089 combine the IDD_SITE and IDD_OTHER_URL functionality onto one page.
6090 (IDD_OTHER_URL): Remove dialog template.
6091 (IDD_DLSTATUS): Remove dialog template.
6092
6093 * site.cc: Run d2u.
6094 (SitePage::OnBack): Remove NEXT() macro invocation.
6095 (SitePage::OnActivate): New member function.
6096 (load_dialog): Remove. Functionality subsumed into
6097 SitePage::OnActivate.
6098 (save_dialog): Change to support both list and user URLs. Remove
6099 OTHER_IDX and mirror_idx logic.
6100 (SitePage::PopulateListBox): New member function.
6101 (SitePage::CheckControlsAndDisableAccordingly): New member function.
6102 (SitePage::OnMessageCmd): New override.
6103 (check_if_enable_next): Remove.
6104 (dialog_cmd): Remove.
6105 (do_download_site_info_thread): Remove calls to NEXT() macro.
6106 (SitePage::Create): Call the single-param PropertyPage::Create
6107 overload.
6108 (other_url): New static taken from other.cc.
6109 (SitePage::OnNext): Remove mirror_idx logic.
6110 (SitePage::OnInit): Remove "Other URL" entry from list box. Remove
6111 list box populating code, now handled in SitePage::PopulateListBox.
6112 (mirror_idx, NO_IDX, OTHER_IDX): Remove.
6113 (save_site_url): Fix potential buffer overflow problem. Switched to
6114 TCHAR in grossly premature preparation for multilingual support.
6115 * site.h: Run d2u.
6116 (SitePage::OnActivate): New member function.
6117 (SitePage::CheckControlsAndDisableAccordingly) New member.
6118 (SitePage::OnMessageCmd): New override.
6119 (do_download_site_info_thread): Add MessageBox call on failure to
6120 download site list.
6121
6122 * splash.cc: Run d2u.
6123 (SplashPage::OnInit): Set the font for the title.
6124 * splash.h: Run d2u.
6125
6126 * threebar.cc: Run d2u.
6127 * threebar.h: Run d2u.
6128
6129 * window.h: Run d2u.
6130 (Window::IsButtonChecked): New member function declaration.
6131 (Window::OnMessageCmd): New member function.
6132 (Window::SetDlgItemFont): New member function declaration.
6133 (Window::MAXFONTS, Window::Fonts, Window::FontCounter): New data
6134 members.
6135 * window.cc: Run d2u.
6136 (Window::IsButtonChecked): New member function definition.
6137 (Window::SetDlgItemFont): New member function definition.
6138 (Window::Window): Add initialization for FontCounter.
6139 (Window::~Window): Delete any fonts we created.
6140
6141 * geturl.cc: Run d2u.
6142 (progress): Remove the "3" field width from the "%3d"
6143 percent-complete format indicator. Causes line to not start at
6144 beginning of text box, and does little to help with "jumping", since
6145 the "bytes downloaded so far" field is variable-width anyway. Change
6146 kb/s format field to "%03.1" to 0-pad the kb/s number in the event of
6147 painfully slow connections, or temporary slowdowns in faster
6148 connections should such more-instantaneous functionality become
6149 available.
6150
6151 * net.h: Run d2u.
6152 (NetPage::OnMessageCmd): New member function declaration.
6153 (NetPage::CheckIfEnableNext): New member function declaration.
6154 * net.cc: Run d2u.
6155 (NetPage::OnMessageCmd): New member function definition.
6156 (dialog_cmd): Remove, subsumed into NetPage::OnMessageCmd.
6157 (check_if_enable_next): Remove.
6158 (NetPage::CheckIfEnableNext): New member function, subsumes
6159 check_if_enable_next.
6160 (propsheet.h): Add include.
6161 (NetPage::Init): Add call to CheckIfEnableNext.
6162 (load_dialog): Remove call to check_if_enable_next.
6163 (NetPage::Create): Call single-template-ID-parameter overload of
6164 PropertyPage::Create instead of three-parameter one.
6165
6166 * Makefile.in (OBJS): Remove other.o.
6167 * other.cc: Remove file.
6168
df62e023
RC
61692002-01-01 Robert Collins <rbtcollins@hotmail.com>
6170
6171 * README: Update TODO's.
6172 * choose.cc (set_existence): Delete non installed packages with no
6173 mirrors.
6174 (fill_missing_category): Fix an off-by-one error.
cef493d7 6175 (default_trust): Ditto. Also delete any unused categories.
df62e023
RC
6176 (view::init_headers): Fix an off-by-one error.
6177 (set_view_mode): Ditto.
6178 (set_view_mode): Ditto.
6179 (create_listview): Ditto.
6180 (dialog_cmd): Ditto.
6181 (do_choose): Ditto.
6182 * io_stream.cc: Indent.
6183 * io_stream.h: Ditto.
6184 * package_db.cc: Ditto.
6185 * package_meta.h: Const correctness for SDesc ();
6186 * proppage.cc: Run d2u and indent.
6187 * propsheet.cc: Run d2u and indent.
6188 * window.cc: Run d2u and indent.
6189 * window.h: Run d2u and indent.
6190
cec57ee1
CF
61912001-12-28 Christopher Faylor <cgf@redhat.com>
6192
e98c531e 6193 * Makefile.in (iniparse.o): Accommodate newer bisons.
cec57ee1 6194
ab57ceaa
RC
61952001-12-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6196
6197 * window.h (Window): New file, new class.
6198 * window.cc (Window): New file, new class.
6199
6200 * threebar.h (ThreeBarProgressPage): New file, new class.
6201 * threebar.cc (ThreeBarProgressPage): New file, new class.
6202
6203 * splash.h (SplashPage): New file, new class.
6204 * splash.cc (SplashPage): Replace file with implementation of new
6205 class.
6206
6207 * source.h (SourcePage): New file, new class.
6208 * source.cc: Run indent.
6209 (SourcePage): Add class implementation to this file.
6210 (do_source): Remove, functionality subsumed by SourcePage::Create()
6211 and SourcePage::OnDeactivate().
cef493d7 6212 (dialog_proc): Remove, functionality subsumed by
ab57ceaa
RC
6213 SourcePage::OnActivate().
6214
6215 * site.h: Run indent.
6216 (SitePage): Add class declaration.
6217 * site.cc: Run indent.
6218 (SitePage): Add class implementation.
6219 (do_download_site_info_thread): New function.
6220 (context): New var. Context info for do_download_site_info_thread().
6221 (do_download_site_info): New function.
6222 (SitePage::Create, SitePage::OnInit SitePage::OnNext)
6223 (SitePage::OnBack): SitePage class implementation..
6224 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers, now handled
6225 by SitePage members.
6226 (dialog_proc): Remove, now handled by SitePage::OnInit and base class
6227 functionality.
6228 (do_site): Remove, now handled by do_download_site_info_thread() and
6229 SitePage::OnNext functionality.
6230 (get_site_list): Remove dismiss_url_status_dialog() call.
6231
6232 * root.h (RootPage): New file, new class.
6233 * root.cc: Run indent.
6234 (dialog_cmd): Pass parent HWND parameter to note(), yesno().
6235 (dialog_proc): Remove.
6236 (do_root): Remove
6237 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL clauses from switch.
6238 (RootPage::OnInit): New member function. Move get_root_dir() logic to
6239 here from do_root().
6240 (RootPage::Create): New member function.
cef493d7 6241 (RootPage::OnNext): New member function. Move IDOK logic from
ab57ceaa
RC
6242 dialog_cmd() to here.
6243 (RootPage::OnBack): New member function.
6244
6245 * propsheet.h (PropSheet): New file, new class.
6246 * propsheet.cc (PropSheet): New file, new class.
6247
6248 * proppage.h (PropertyPage): New file, new class.
6249 * proppage.cc (PropertyPage): New file, new class.
6250
6251 * postinstall.cc (do_postinstall): Add owner parameter.
6252
6253 * other.cc (do_other): Add owner parameter.
6254
6255 * nio-file.cc (NetIO::Purl): Pass NULL parent param to note().
cef493d7 6256 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Pass NULL parent param to
ab57ceaa 6257 get_ftp_auth().
cef493d7 6258 * nio-http.cc (retry_get): Pass NULL parent param to get_auth(),
ab57ceaa
RC
6259 get_proxy_auth(),
6260 and get_ftp_auth().
cef493d7 6261 * nio-ie5.cc (NetIO::_url): Pass NULL parent param to note(),
ab57ceaa
RC
6262 get_auth(), get_proxy_auth().
6263
6264 * netio.h (get_auth, get_proxy_auth, get_ftp_auth): Add owner param.
cef493d7 6265 * netio.cc (auth_common, NetIO::get_auth, NetIO::get_proxy_auth,
ab57ceaa
RC
6266 NetIO::get_ftp_auth)
6267 (auth_common): Add owner param. Pass owner param to DialogBox.
cef493d7 6268 (NetIO::get_auth, NetIO::get_proxy_auth, NetIO::get_ftp_auth): Pass
ab57ceaa
RC
6269 owner param to auth_common().
6270
6271 * net.h (NetPage): New file, new class.
6272 * net.cc: Run indent.
6273 (net.h, threebar.h): Add includes.
6274 (Progress): Add extern.
6275 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, now handled by
6276 property sheet logic. Saved temporarily for reference.
cef493d7 6277 (NetPage::Create, NetPage::OnInit, NetPage::OnDeactivate,
ab57ceaa
RC
6278 NetPage::OnNext, NetPage::OnBack):
6279 New implementation of NetPage class members.
6280 (do_net): Remove.
6281 (dialog_proc): Remove.
6282
6283 * msg.h (fatal, note, yesno): Add owner param.
6284 * msg.c (fatal, note, yesno, mbox): Add owner param.
6285 (mbox): Remove MB_TOPMOST from MessageBox call. Unnecessary and wrong
6286 now that we have a parent.
6287
6288 * main.cc: Run indent.
cef493d7 6289 (commctrl.h, proppage.h, propsheet.h, splash.h, source.h)
ab57ceaa
RC
6290 (localdir.h, net.h, site.h, choose.h, threebar.h, desktop.h): Include
6291 headers.
6292 (root_dialog_proc): extern into this file.
6293 (Progress): Progress dialog defined here, used in several other files.
6294 (WinMain): Instantiate and create Splash, Source, Root, LocalDir, Net,
6295 Site, Chooser, Desktop pages and MainWindow sheet. Call
6296 InitCommonControls() to make sure Windows is set up for our use of
6297 property sheets. Add pages to sheet.
6298 Call MainWindow.Create() to "DoModal". Remove main loop, that logic is
6299 now handled by the PropSheet class.
6300 (root.h): Add include.
6301
6302 * log.cc (log_save): Pass NULL parent to fatal().
6303 (exit_setup): Pass NULL parent to note().
6304
6305 * localdir.h (LocalDirPage): New file, new class.
6306 * localdir.cc: Run indent.
6307 (localdir.h): New include.
6308 (threebar.h): New include.
6309 (Progress): extern into this file.
6310 (LocalDirPage::Create, LocalDirPage::OnInit, LocalDirPage::OnActivate)
cef493d7 6311 (LocalDirPage::OnNext, LocalDirPage::OnBack): Implementation of
ab57ceaa
RC
6312 LocalDirPage.
6313 (LocalDirPage::OnNext): Move log() call from do_local_dir() to here.
6314 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers.
6315 (do_local_dir): Remove.
6316 (dialog_proc): Remove.
6317 (cwd): Remove, not used by anything.
6318
6319 * install.cc: Run indent.
6320 (process.h, threebar.h): New includes.
6321 (Progress): extern into this file.
6322 (ins_dialog, ins_action, ins_pkgname, ins_filename, ins_pprogress)
6323 (ins_iprogress, ins_diskfull, init_event): Remove, now handled by
6324 ThreeBarProgressPage.
cef493d7 6325 (dialog_cmd, dialog_proc, dialog): Removed, handled in
ab57ceaa 6326 ThreeBarProgressPage.
cef493d7
CF
6327 (init_dialog): Remove all mention of the above ins_* handles. Now
6328 handled in ThreeBarProgressPage. Altered SetWindowText()s to call
ab57ceaa
RC
6329 ThreeBarProgressPage instance Progress directly.
6330 (progress): Alter bar update logic to call ThreeBarProgressPage
6331 instance Progress directly.
6332 (uninstall_one): Alter SetWindowText()s to call ThreeBarProgressPage
6333 instance Progress directly.
cef493d7 6334 (install_one_source): Alter SetWindowText()s to call
ab57ceaa
RC
6335 ThreeBarProgressPage
6336 instance Progress directly. Pass NULL parent to note().
cef493d7 6337 (do_install_thread): Rename from do_install(), added owner param.
ab57ceaa
RC
6338 Alter SetWindowText()s to call ThreeBarProgressPage instance Progress
6339 directly.
6340 Remove dismiss_url_status_dialog() call, no longer necessary. Remove
cef493d7 6341 ShowWindow(<hide>) call, also unnecessary now. Pass owner handle to
ab57ceaa
RC
6342 fatal().
6343 (do_install_reflector): New function.
6344 (do_install): New function.
6345
6346 * ini.cc (process.h, threebar.h): New includes.
6347 (Progress): externed into this file.
6348 (find_routine): Pass NULL parent to note().
6349 (do_local_ini): Add owner param.
cef493d7 6350 (do_remote_ini): Add owner param. Pass owner to get_url_to_membuf()
ab57ceaa
RC
6351 and note(). Remove call to dismiss_url_status_dialog().
6352 (do_ini_thread): Rename from do_ini(). Add owner param. Pass owner to
cef493d7 6353 do_local_ini(), do_remote_ini(), yesno(), and note(). Set next_dialog
ab57ceaa
RC
6354 to IDD_CHOOSER on exit.
6355 (do_ini_thread_reflector): New function.
6356 (context): New var. Context for do_ini_thread.
6357 (do_ini): New function.
6358
6359 * geturl.h (get_url_to_membuf, get_url_to_string, get_url_to_file): Add
6360 owner param.
cef493d7 6361 * geturl.cc (gw_dialog, gw_url, gw_rate, gw_progress, gw_pprogress,
ab57ceaa 6362 gw_iprogress)
cef493d7 6363 (gw_progress_text, gw_pprogress_text, gw_iprogress_text, init_event):
ab57ceaa
RC
6364 Removed.
6365 (threebar.h): New include.
6366 (Progress): externed into this file.
cef493d7 6367 (dialog_cmd, dialog_proc, dialog): Removed, handled by
ab57ceaa 6368 ThreeBarProgressPage now.
cef493d7 6369 (init_dialog): Remove "if (gw_dialog == 0)" clause. Alter
ab57ceaa 6370 SetWindowText()s
cef493d7 6371 and bar setting SendMessage()s to call ThreeBarProgressPage instance
ab57ceaa
RC
6372 Progress directly. Remove "one bar only" logic, this is now handled
6373 explicitly in the ThreeBarProgressPage class.
cef493d7 6374 (progress): Altered bar and text update logic to call
ab57ceaa
RC
6375 ThreeBarProgressPage instance Progress directly. Changed kbps
6376 calculation to floating point and now print out a single decimal
6377 place.
6378 (get_url_to_membuf): Add owner param. Pass it to init_dialog.
6379 (get_url_to_string): Add owner param. Pass it to get_url_to_membuf.
cef493d7 6380 (get_url_to_file): Add owner param. Pass it to init_dialog. Alter bar
ab57ceaa
RC
6381 update logic to call ThreeBarProgressPage instance Progress directly.
6382 (dismiss_url_status_dialog): Remove.
6383
6384 * fromcwd.cc (do_fromcwd): Add owner param. Initialize found_ini to
6385 false, was true.
6386
6387 * download.cc: Run indent.
6388 (process.h, threebar.h): New includes.
6389 (Progress): externed into this file.
6390 (download_one): Add owner param. Pass it to get_url_to_file().
6391 (do_download_thread): Renamed from do_download. Add owner param. When
6392 calculating total_download_bytes, take binpicked and srcpicked into
6393 account. Remove call to dismiss_url_status_dialog(), no longer needed.
6394 Pass owner handle to download_one() and yesno().
6395 (do_download_reflector, do_download): New functions.
6396 (context): New var. Context for do_download_thread().
6397
6398 * dialog.h (D(x)): Add owner param.
6399
6400 * desktop.h (DesktopSetupPage): New file, new class.
6401 * desktop.cc: Run indent.
6402 (desktop.h): Add include.
cef493d7 6403 (dialog_proc, do_desktop): Remove, now handled in
ab57ceaa
RC
6404 DesktopSetupPage::OnInit().
6405 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, handled in
6406 DesktopSetupPage::OnFinish(), DesktopSetupPage::OnBack(), and PropSheet
6407 resp.
6408 (DesktopSetupPage::Create, DesktopSetupPage::OnInit)
6409 (DesktopSetupPage::OnBack, DesktopSetupPage::OnFinish): Implementation
6410 of DesktopSetupPage.
6411
6412 * cistring.h: New file, new class.
6413 * cistring.cc: New file, new class.
6414
6415 * choose.h: Run indent.
6416 (Chooser): New class declaration.
6417 * choose.cc: Run indent.
cef493d7 6418 (do_choose): Add owner param. Pass it to DialogBox() and
ab57ceaa
RC
6419 fatal().
6420 (Chooser): New class implementation.
6421
6422 * res.rc (IDS_VERSION_INFO): New string.
6423 (IDD_SOURCE, IDD_LOCAL_DIR, IDD_ROOT, IDD_SITE, IDD_OTHER_URL)
6424 (IDD_DLSTATUS, IDD_INSTATUS, IDD_SPLASH, IDD_CHOOSE, IDD_DESKTOP):
6425 Change WS_POPUP to WS_CHILD. Numerous positioning/size changes
6426 throughout.
6427 (IDD_CHOOSE): Give template the WS_EX_CONTROLPARENT style to enable
6428 TAB control navigation etc. Give the controls a reasonable tab order.
6429 Grouped radio buttons. Something's still not right, can't tab away
6430 from back/next/cancel group reliably.
6431 * resource.h (IDD_CHOOSER): New dialog ID.
6432
6433 * Makefile.in (OBJS): Add cistring.o, proppage.o, propsheet.o,
6434 threebar.o, and window.o.
6435
cc41a057
RC
64362001-12-21 Robert Collins <rbtcollins@hotmail.com>
6437
58b12a06
MB
6438 * choose.cc (listview_proc): Update the scrollbar when the headers are
6439 dragged.
cc41a057
RC
6440 (pick_pkg_line::paint): Clip columns to prevent overlap.
6441
cbfc4215
RC
64422001-12-20 Robert Collins <rbtcollins@hotmail.com>
6443
6444 * Makefile.in: Add libcomctl32.a for setup.exe.
6445 * archive.h (archive): Prevent non-child direct creation of the class.
58b12a06
MB
6446 * archive_tar.h (archive_tar): Prevent inaccurate synthetic copy and
6447 assignment.
cbfc4215
RC
6448 * choose.cc: Include commctrl for the choose header.
6449 (NEW_COL_SIZE_SLOP): Define without magic numbers.
6450 (pkgtrustp): Convert to function.
6451 (set_action): Remove.
cef493d7 6452 (add_required, fill_missing_category,default_trust): Use list syntax for
cbfc4215
RC
6453 package list.
6454 Use new set_action.
6455 (choose_caption): Remove.
6456 (topbucket::paint): New method.
6457 (topbucket::empty): Ditto.
6458 (topbucket::click): Ditto.
6459 (topbucket::~topbucket): Ditto.
6460 (paint): Remove i,ii and p as they are obsolete.
6461 Remove header drawing code.
6462 Use new chooser method to paint the chooser.
6463 Use new chooser itemcount method.
6464 (scroll_common): Rename to view::scroll.
6465 Scroll the header window separately.
58b12a06
MB
6466 (list_vscroll, list_hscroll, list_click): Update for new chooser
6467 methods.
cbfc4215
RC
6468 (listview_proc): Look for header messages.
6469 (note_width): Accept stringless calls.
6470 (pick_line::set_line): Remove.
6471 (pick_line::paint): Remove.
58b12a06
MB
6472 (pick_pkg_line::paint): Paint this one line, using the header column
6473 widths.
6474 (pick_category_line::paint): Paint this category, and anything in the
6475 bucket.
cbfc4215
RC
6476 (pick_line::click): Remove.
6477 (pick_pkg_line::click): Handle a click.
6478 (pick_category_line::click): Handle a click.
6479 (_view): Rename all to view.
6480 (view::view): Initialise the control contents.
6481 (view::set_headers): Work with the header control.
6482 (view::init_headers): Use list syntax for package list.
6483 Rearrange the width logic a little.
6484 (view::insert_pkg): Update to use the hierarchy.
6485 (view::insert_category): Ditto.
6486 (view::insert_at, view::insert_under): Remove.
6487 (view::clear_view): Update to use the hierarchy.
6488 (view::click): Update to use the hierarchy.
6489 (set_view_mode): Use list syntax for package list.
6490 Update for new chooser methods.
6491 (DoInsertItem): New helper function. (Needs a home somewhere).
58b12a06
MB
6492 (create_listview): Remove choose control code and use the constructor
6493 instead.
cbfc4215
RC
6494 (dialog_cmd,scan2,do_choose): Use list syntax for package list.
6495 * choose.h: Include newly required headers list and package_meta.
6496 (_voew): Rename to view.
6497 (pick_line): Convert to an ABC.
6498 (pick_pkg_line): New class.
6499 (pick_catgory_line): New class.
6500 (topbucket): New class.
6501 (view::scroll): New method created from listview_scroll function.
6502 * desktop.cc (make_passwd_group): Use list syntax for package list.
6503 * download.cc (do_download): Use list syntax for package list.
6504 * fromcwd.cc (found_file): Use list syntax for package list.
6505 * iniparse.y (pacakges): Use list syntax for package list.
6506 * install.cc (uninstall_one): Use list syntax for package list.
6507 (do_install): Use list syntax for package list.
58b12a06
MB
6508 * io_stream.h (io_stream): Prevent non-child direct creation of the
6509 class.
cbfc4215
RC
6510 Prevent inaccurate synthetic copy and assignment.
6511 * list.h: Include required header stdlib.
6512 Work on const correctness.
6513 * package_db.cc (packagedb::getpackagebyname): Remove.
6514 (packagedb::packagedb): Remove custom list code, and make db a local.
6515 (packagedb::getfirstpackage): Remove.
6516 (packagedb::getnextpackage): Remove.
6517 (packagedb::addpackage): Remove.
6518 (flush): Remove custom list code.
6519 (packagedb::registerpackage): Remove.
6520 (packagedb::packages): New static member.
6521 (packagedb::task): New static member.
6522 * package_db.h (PackageDBActions): New enum.
6523 (packagedb): Remove getfirstpackage, getnextpackage, getpackagebyname,
6524 addpackage, registerpackage, packages, packagecount, curr_package, db.
6525 Add packages, task.
6526 * pacakge_meta.cc: Include package_db.h.
6527 (packagemeta::action_caption): New method.
6528 (packagemeta::set_action): New method.
6529 * package_meta.h (CategoryPackage): Initialise key.
6530 (packagemeta): Initialise key.
6531 Add set_action and action_caption methods.
6532 Prevent inaccurate synthetic copy and assignment.
6533 * resource.h (IDC_CHOOSE_LISTHEADER): New ID.
6534 * source.cc: Include package_db for db manipulation.
6535 (save_dialog): Set the db task.
58b12a06
MB
6536 * win32.h: Tell the w32 include headers what IE version to
6537 expect/require.
cbfc4215 6538
cd8e5750
RC
65392001-12-06 Robert Collins <rbtcollins@hotmail.com>
6540
6541 * README: Wishlist updates.
6542
5519d243
RC
65432001-12-04 Robert Collins <rbtcollins@hotmail.com>
6544
6545 * package_db.cc (getnextpackage): Don't overrun the array.
6546
de6a1a64
RC
65472001-12-04 Robert Collins <rbtcollins@hotmail.com>
6548
6549 * Makefile.in (OBJS): Add setup_version.o.
6550 (version.c): Rename to setup_version.
6551 * choose.cc (set_action): Prevent NULL pointer dereference.
6552 (package_sort): Remove.
6553 * fromcwd.cc (canonicalize_version): Moved to version.cc.
58b12a06
MB
6554 (check_ini): New function for use with find to see if there is a cached
6555 setup.ini.
de6a1a64
RC
6556 (do_fromcwd): Check for a cached setup.ini from any mirror site.
6557 * ini.cc (find_routine): New function, for finding cached setup.ini's.
6558 (do_local_ini): New function, drives parsing of local ini's.
58b12a06
MB
6559 (do_remote_ini): New function, drives parsing and caching of remote
6560 ini's.
de6a1a64
RC
6561 (do_ini): Move guts to do_remote_ini and do_local_ini.
6562 * list.h (removebyindex): New method.
6563 * other.cc (save_dialog): Use new site_list and all_site_list to add the
6564 new site to the site picklist.
6565 (dialog_cmd): Only save the dialog when exiting the dialog.
6566 * res.rc (IDD_SITE): Make IDC_URL_LIST a multiple-selection control.
6567 * site.cc (site_list_type): Move to site.h
6568 (site_list): New global, sites chosen by the user.
6569 (all_site_list): New global, all potential sites.
58b12a06
MB
6570 (site_list_type::init): New method, parses a mirror.lst URL string into
6571 a site_list_type object.
de6a1a64
RC
6572 (site_list_type::site_list_type): New method.
6573 (check_if_enable_next): Examine the control, not a local variable.
6574 (load_dialog): Select all the user chosen sites by default.
cef493d7 6575 (save_dialog): Adjust for multiple selection semantics.
de6a1a64 6576 (save_site_url): Save all user chosen sites.
58b12a06
MB
6577 (dialog_cmd): Don't save the dialog when the listbox recieves a message
6578 - thats not needed.
de6a1a64
RC
6579 Remove obsolete other_url reference.
6580 (dialog_proc): Use all_site_list instead of site_list.
6581 (site_sort): Remove.
6582 (get_site_list): Remove malloc use - use list template instead.
6583 Move site_list_type initialisation to site_list_type::init().
6584 (get_initial_list_idx): Renamed to ...
6585 (get_saved_sites): this. Also read in multiple sites to the site_list.
6586 (do_site): Use all_site_list not site_list.
6587 Log all chosen sites.
6588 * site.h: New file, defines site related class, functions and variables.
6589 * state.h: Add comment about use of state.h
6590 (mirror_site): Remove.
6591 (other_url): Remove.
6592 (MIRROR_SITE): Remove.
6593 * version.cc: New file, for version-handling and related functions.
6594
341988b9
RC
65952001-12-02 Robert Collins <rbtcollins@hotmail.com>
6596
6597 * Makefile.in: Add filemanip.o to setup.
6598 * archive.cc (archive::extract_file): Use new io_stream method 'copy'.
6599 * archive_tar.h (archive_tar_file): Implement get_size virtual.
6600 (archive_tar): Ditto.
58b12a06
MB
6601 * choose.cc (set_action): Use [] operator instead of getnth - its more
6602 readable.
341988b9
RC
6603 (paint): Ditto.
6604 (_view::init_headers): Ditto.
6605 (_view::insert_pkg): Ditto.
6606 (set_view_mode): Ditto.
6607 (scan2): Ditto.
6608 (do_choose): Ditto.
6609 (base): Moved to filemanip.cc.
6610 (find_tar_ext): Ditto.
6611 (parse_filename): Ditto.
6612 (_Info::_Info): Remove.
6613 * compress_bz.h (compress_bz): Implement get_size virtual.
6614 * compress_gz.h (compress_gz): Implement get_size virtual.
58b12a06
MB
6615 * cygpackage.cc (cygpackage::destroy): Use array delete for char *
6616 objects.
341988b9 6617 * download.cc (get_file_size): Move to filemanip.cc.
58b12a06
MB
6618 (check_for_cached): Use [] operator instead of getnth - its more
6619 readable.
341988b9
RC
6620 (download_one): Ditto.
6621 * filemanip.cc: New file.
58b12a06
MB
6622 * geturl.cc (init_dialog): Make url a pointer to const as it is not
6623 modified.
6624 (get_url_to_membuf): New function - contains get_url_to_string worker
6625 code.
341988b9
RC
6626 (get_url_to_string): Becomes a trivial wrapper to get_url_to_membuf.
6627 * geturl.h: Declare new prototype.
6628 * ini.cc (do_ini): Use get_url_to_membuf and pass ini_init an io_stream.
6629 Tidy up the error code a little.
6630 * ini.h: Remove __cplusplus protection for ini_init.
6631 (_Info): Remove.
6632 * inilex.l: Remove old globals.
6633 (ini_init): Use an io_stream for getting the characters.
6634 (ini_getchar): Ditto.
6635 * iniparse.y: Declare yylex as a C++ function.
58b12a06
MB
6636 (add_correct_version): Use [] operator instead of getnth - its more
6637 readable.
341988b9
RC
6638 * io_stream.cc (io_stream::move_copy): Use the copy method.
6639 (io_stream::copy): New method to simply copy from one stream to another.
58b12a06
MB
6640 * io_stream.h (io_stream): New static method copy, and virtual method
6641 get_size.
341988b9
RC
6642 * io_stream_cygfile.cc (io_stream_cygfile::get_size): Implement this.
6643 * io_stream_cygfile.h (io_stream_cygfile::get_size): Declare this.
6644 * io_stream_file.cc (io_stream_file::get_size): Implement this.
6645 * io_stream_file.h (io_stream_file::get_size): Declare this.
6646 * io_stream_memory.h: Include errno as it's neded to parse the header.
6647 (io_stream_memory::get_size): Implement this.
6648 (io_stream_memory::st_size): Delete this.
6649 * list.h: Change getnth into the [] operator.
58b12a06
MB
6650 * netio.cc (NetIO::NetIO): Change prototype to reflect Purl not being
6651 modified.
341988b9
RC
6652 (NetIO::set_url): Ditto.
6653 (NetIO::open): Ditto.
6654 * netio.h: As for netio.cc.
58b12a06
MB
6655 * nio-file.cc (NetIO_File::NetIO_File): Change prototype to reflect
6656 Purl not being modified.
341988b9
RC
6657 * nio-file.h: Ditto.
6658 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
6659 * nio-ftp.h (NetIO_FTP::NetIO_FTP): Ditto.
6660 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Ditto.
6661 * nio-http.h (NetIO_HTTP::NetIO_HTTP): Ditto.
6662 * nio-i5.cc (NetIO_IE5::NetIO_IE5): Ditto.
6663 * nio-i5.h (NetIO_IE5::NetIO_IE5): Ditto.
6664 * package_meta.cc (packagemeta::~packagemeta): Bugfix: use array delete.
6665 * package_source.cc (packagesource::set_canonical): Ditto.
6666 (packagesource::set_cached): Ditto.
6667 * package_source.h (site::~site): Ditto.
58b12a06
MB
6668 * site.cc: Change site_list_type to a class, and search and replace
6669 sort_key to key globally.
341988b9 6670
071c1c54
RC
66712001-12-01 Robert Collins <rbtcollins@hotmail.com>
6672
58b12a06
MB
6673 * package_source.cc (packagesource::set_canonical): Filename was out by
6674 one.
071c1c54 6675
4fe323f9
RC
66762001-11-30 Robert Collins <rbtcollins@hotmail.com>
6677
6678 * Makefile.in (OBJS): Remove category_list - it's not needed.
6679 * README: More wishlist updates.
6680 * category.cc (Category::Category): Initialise new members.
6681 (Categorycmp): New function.
6682 * category.h (Category): New member key for template use.
6683 * category_list.cc: Remove.
6684 * category_list.h: Remove.
6685 (Categorycmp): New function prototype.
6686 * choose.cc: Remove category_list - not needed.
cef493d7 6687 (set_action): Only show the 'source' option when the source is actually
4fe323f9
RC
6688 available.
6689 (add_required): Fix recursion limiter to 5.
6690 (fill_missing_category): Use list access.
6691 (default_trust): Ditto.
6692 (pick_line::paint): Ditto.
6693 (_view::init_headers): Ditto.
6694 (_view::insert_pkg): Ditto.
6695 (_view::insert_category): Ditto.
6696 (_view::click): Ditto.
6697 (set_view_mode): Ditto.
6698 (do_choose): Ditto.
6699 * cygpackage.h: Remove category_list - not needed.
6700 * geturl.cc (get_url_to_string): Fix null byte insertion.
6701 * inipatse.y: Remove category_list - not needed.
6702 (categories): Use list access.
6703 * package_db.cc: Ditto.
6704 * package_db.h: Remove category_list - not needed.
6705 (packagedb): Use the list template for categories.
6706 * package_meta.cc (add_category): Ditto.
6707 * package_meta.h (CategoryPackage): Link to the category as well.
cef493d7 6708 (packagemeta): Use a list of CategoryPackages instead of Categories
4fe323f9
RC
6709 for more memory efficient cross-referencing.
6710
7d66d192
RC
67112001-11-30 Robert Collins <rbtcollins@hotmail.com>
6712
58b12a06
MB
6713 * package_db.cc (packagedb::flush): Write a canonical version for all
6714 packages irrespective of the media they were installed from.
7d66d192 6715
bb849dbd
RC
67162001-11-29 Robert Collins <rbtcollins@hotmail.com>
6717
6718 * Makefile.in (OBJS): Add package_source and rfc1738.
6719 * README: Wishlist update.
6720 * category_list.cc (register_category): Use references.
6721 * category_list.h (CategoryList): Ditto.
6722 * choose.cc (isinstalled): Remove.
6723 (pkgtrustp): New macro.
6724 (set_action): Use packagemeta.
6725 (add_required): Ditto.
58b12a06
MB
6726 (choose_caption): Example package to choose caption, rather than state
6727 flags.
bb849dbd
RC
6728 (check_existence): Remove.
6729 (set_existence): Remove old code.
6730 (fill_missing_category): Use packagemeta.
6731 (keep_or_skip): Remove.
6732 (default_trust): Use packagemeta and set trust values directly.
6733 (pick_line::set_line): Use packagemeta.
6734 (_view::insert_pkg): Ditto.
6735 (_view::insert_category): Ditto.
6736 (_view::click): Ditto.
6737 (set_view_mode): Ditto. Also remove "exclude" code.
6738 (create_listview): Use packagemeta.
6739 (dialog_cmd): Ditto.
6740 (getpkgbyname): Remove
6741 (scan2): Use packagemeta. Temporarily comment out the holefinding code.
6742 (read_installed_db): Remove.
6743 (package_sort): Use packagemeta.
58b12a06
MB
6744 (do_choose): Use packagemeta. Don't sort the packages - the db does
6745 that.
bb849dbd
RC
6746 * choose.h: Use packagemeta.
6747 * cygpackage.cc (cygpackage::cygpackage): Initialise all variables.
6748 (cygpackage::cygpackage): Ditto.
6749 (cygpackage::set_canonical_version): Copy the passed string.
6750 (cygpackage::~cygpackage): Move cleanup code to destroy().
6751 (cygpackage::destroy): New function.
6752 (cygpackage::getfirstfile): Use a separate buffer.
6753 (cygpackage::getnextfile): Ditto.
6754 (cygpackage::Canonical_version): New function.
6755 (cygpackage::set_sdesc): Ditto.
6756 (cygpackage::set_ldesc): Ditto.
6757 * cygpackage.h (cygpackage::Canonical_version): New method.
6758 (cygpackage::set_sdesc): New method.
6759 (cygpackage::set_ldesc): New method.
6760 (cygpackage::SDesc): New method.
6761 (cygpackage::LDesc): New method.
6762 (cygpackage::set_canonical_version): New method.
6763 * desktop.cc: Include packagedb headers.
6764 (make_password_group): Use packagemeta.
6765 * download.cc: Include packagedb headers.
58b12a06
MB
6766 (check_for_cached): New method to find any cached file and fill out the
6767 database info.
bb849dbd
RC
6768 (download_one): Take a packagesource, support multiple mirrors.
6769 (do_download): Use packagemeta.
6770 * from cwd.cc: Include packagedb headers.
6771 (found_file): Use packagemeta.
6772 * ini.cc (do_ini): Beginning of multiple-mirror support.
6773 * ini.h (CategoryPackage): Remove.
6774 (Dependency): Remove.
6775 (Package): Remove.
58b12a06
MB
6776 (new_package,getpkgbyname,getpackagecategorybyname,add_category):
6777 Remove.
bb849dbd
RC
6778 * inilex.l: Support multiple mirrors.
6779 * iniparse.y: Include packagedb headers.
6780 (parser): Use packagemeta.
6781 (new_package): Remove.
6782 (add_correct_version): New function.
6783 (new_requirement): Remove.
6784 (add_category): Remove.
6785 * install.cc (uninstall_one): Use packagemeta.
6786 (install_one_source): New function.
6787 (install_one): Use packagemeta.
6788 (do_install): Use packagemeta.
6789 * io_stream.cc (io_stream::move): Bugfix on move/copy case.
58b12a06
MB
6790 * io_stream_cygfile.cc (io-stream_cygfile::set_mtime): Do not reopen the
6791 file after setting the mtime, it makes no sense, and results in 0 length
6792 files.
bb849dbd
RC
6793 * io_stream_file.cc (io-stream_file::set_mtime): Ditto.
6794 * list.h: New file, template class for a form of list.
6795 * package_db.cc (packagedb::registerpackage): New function.
6796 * package_db.h (packagedb::npackages ()): New method.
6797 * package_meta.cc (packagemeta::add_version): Use list template.
6798 (packagemeta::set_installed): Ditto.
6799 (packagemeta::add_category): New method.
6800 * package_meta.h: Include necessary headers to parse the class.
6801 (CategoryPackage): New class.
6802 (packagemeta): Initialise all members.
6803 (packagemeta::SDesc): New method.
6804 (packagemeta::Categories): New method.
6805 (packagemeta::add_category): Ditto.
6806 (packagemeta::versions): Change to be a list instance.
6807 * package_source.cc (packagesource::set_canonical): New method.
6808 (packagesource::set_cached): New method.
6809 * package_source.h: Include necessary headers to parse the class.
6810 (site): New class.
6811 (packagesource::packagesource): Initialize all members.
6812 (packagesource): Make this class non-abstract.
6813 * package_version.cc (packageversion::packageversion): New method.
6814 * package_version.h (Dependency): New class.
6815 (packageversion::Canonical_vesion): New method.
6816 (packageversion::SDesc): New method.
6817 (packageversion::LDesc): New method.
6818 (packageversion::new_requirement): Ditto.
6819 (packageversion::srcpicked, binpicked): What to install.
6820 (packageversion::src, bin): Installation source data.
6821 * rfc1738.cc: New file. Escapes special characters in URL's.
6822 * rfc1738.h: Ditto.
6823
90d14922
RC
68242001-11-26 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6825
6826 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Stop header parsing when
6827 SimpleSocket::gets() returns a zero-length string, so that we
6828 don't end up eating the entire stream thinking it's all header info.
6829
7c7034e8
RC
68302001-11-23 Robert Collins <rbtcollins@hotmail.com>
6831
6832 * install.cc (badrename): Remove.
58b12a06
MB
6833 (do_install): Use packagedb flush method to write
6834 /etc/setup/installed.db.
7c7034e8
RC
6835 * io_stream.cc (io_stream::move_copy): New method.
6836 (io_stream::move): New method.
6837 * io_stream.h (io_stream): New methods move and move_copy.
6838 * io_stream_cygfile.cc (io_stream_cygfile::move): New method.
6839 * io_stream_cygfile.h (io_stream_cygfile): New method move.
6840 * io_stream_file.cc (io_stream_file::move): New method.
6841 * io_stream_file.h (io_stream_file): New method move.
6842 * package_db.cc (packagedb::flush): New method.
6843 * package_db.h (packagedb): New method flush.
6844
fa0c0d10
RC
68452001-11-23 Robert Collins <rbtcollins@hotmail.com>
6846
6847 * Makefile.in (OBJS): Add package_version.
6848 * ategory.cc (Category::Category): Update constructors.
6849 * category_list.cc (CategoryList::register_category): Insert correctly.
6850 * choose.cc: Include package_version.h, not package.h.
6851 * cygpackage.cc: Ditto.
6852 (cygpackage::uninstall): New method.
6853 * cygpackage.h (cygpackage): Rename genericpackage to packageversion.
6854 New method uninstall.
6855 * hash.cc (add, has, enumerate): Change prototype to be accurate.
6856 * hash.h (hash): Change prototypes to be accurate.
6857 * ini.h (_Info): New parameterless constructor.
6858 (CategoryPackage): New constructor.
6859 (Package): Ditto.
6860 * install.cc: Don't include unneeded headers.
6861 Include package database headers.
6862 (hash::add_subdirs): Remove.
58b12a06
MB
6863 (uninstall_one): Use packagemeta->uninstall to perform the
6864 uninstallation. Don't uninstall source packages.
6865 (do_install): Just can uninstall_one once as we ignore source packages
6866 now. Don't copy the installed.old database accross, instead iterate
6867 through the packagedb packages list and write the installed packages
6868 out.
fa0c0d10
RC
6869 * package_db.cc: Include package_version.h, not package.h.
6870 (packagedb::packagedb): Never let db be undefined.
6871 Record the installation filename, so we can reconstruct installed.db.
6872 (packagedb::addpackage): Insert packages in alpha sorted order.
6873 (packagedb::categories): Initialise correctly.
6874 * package_meta.cc: Include win32 and mount headers as a workaround to
6875 current io_stream limitations. Include a TODO about that.
6876 (standard_dirs): New, from install.cc.
6877 (hash::add_subdirs): New, from install.cc.
6878 (packagemeta::set_installed): Rename genericpackage to packageversion.
6879 (packagemeta::uninstall): New method.
6880 * package_meta.h: Rename genericpackage to packageversion.
6881 (packagemeta): Update constructor.
6882 (add_version, set_installed): Rename genericpackage to packageversion.
6883 (uninstall): New method.
6884 (installed_from): New member.
6885 * package_source.cc: New file.
6886 * package_source.h: New file.
6887 * package_version.cc: New file.
6888 * package_version.h: New file.
6889 * package.cc: Removed.
6890 * package.h: Removed.
cef493d7 6891
7b606ae5
RC
68922001-11-21 Robert Collins <rbtcollins@hotmail.com>
6893
6894 * Makefile.in (OBJS): Add category.o and category_list.o.
6895 * category.h: New file.
6896 * category.cc: New file.
6897 * category_list.h: New file.
6898 * category_list.cc: New file.
6899 * choose.cc: Include category headers.
6900 (fill_missing_category): Use package_db to access global categories.
6901 (_view::insert_pkg): Ditto.
6902 (_view::insert_category): Ditto.
6903 (set_view_mode): Ditto.
6904 (getcategorybyname): Remove.
6905 * cygpackage.h: Include category_list.h to parse this correctly.
6906 (cygpackage): New virtual &Categories.
6907 * ini.h (_CategoryPackage): More C to C++ conversion.
6908 (Category): Remove.
6909 (getcategorybyname): Remove.
6910 (register_category): Remove.
6911 * iniparse.y: Include package db and category headers.
6912 (categories): Use package_db to access global categories.
6913 (category): Remove.
6914 (ncategories): Remove.
6915 (register_category): Remove.
6916 * package.h: New virtual &Categories.
58b12a06
MB
6917 * package_db.cc (packagedb::packagedb): Don't read the installed db
6918 twice.
7b606ae5 6919 (packagedb::categories): Declare.
58b12a06
MB
6920 * package_db.h (packagedb): New member categories for global categories
6921 list.
7b606ae5 6922
d0fa1c4e
RC
69232001-11-21 Robert Collins <rbtcollins@hotmail.com>
6924
6925 * choose.h: Don't include ini.h
6926 * ini.h: Allow pure c++ in the header file.
6927
24cbae7f
RC
69282001-11-21 Robert Collins <rbtcollins@hotmail.com>
6929
6930 * install.cc (do_install): Write a version 2 installed.db file.
58b12a06
MB
6931 * package_db.cc (packagedb::packagedb): Read version 1 and 2
6932 installed.db files.
24cbae7f 6933
7939f6d1
RC
69342001-11-21 Robert Collins <rbtcollins@hotmail.com>
6935
6936 * Makefile.in (OBJS): Add package abstraction objects.
6937 * choose.cc: Include package abstraction headers.
6938 (read_installed_db): Use packagedb class and ignore installed sources.
6939 * cygpackage.cc: New file.
6940 * cygpackage.h: New file.
6941 * filemanip.h (get_file_size): Use unixy types.
6942 * package.h: New file.
6943 * package.cc: New file.
6944 * package_db.cc: New file.
6945 * package_db.h: New file.
6946 * package_meta.cc: New file.
6947 * package_meta.h: New file.
6948
33bc0053
RC
69492001-11-21 Robert Collins <rbtcollins@hotmail.com>
6950
6951 * REAME: Updates to wishlist.
6952
12ccadc0
RC
69532001-11-16 Robert Collins <rbtcollins@hotmail.com>
6954
6955 * README: Updated and added my list of wishlist and todo items.
6956
ca9506cc
RC
69572001-11-14 Robert Collins <rbtcollins@hotmail.com>
6958
6959 * Makefile.in (OBJS): Include io_stream_memory in setup.exe.
6960 * archive_tar.cc (archive_tar::write): New prototype.
6961 (archive_tar::seek): New method.
6962 * archive.h (archive_tar_file): Update write() and add seek().
6963 (archive_tar): Ditto.
6964 * archive_tar_file.cc (archive_tar_file::write): New prototype.
6965 (archive_tar_file::seek): New method.
6966 * compress_bz.cc (compress_bz::write): New prototype.
6967 (compress_bz::seek): New function.
6968 * compress_bz.h (compress_bz): Update write() and add seek().
6969 * compress_gz.cc (compress_gz::write): New prototype.
6970 (compress_gz::seek): New function.
6971 * compress_gz.h (compress_gz): Update write() and add seek().
6972 * geturl.cc: Include io_stream headers.
6973 (GUBuf): Remove.
6974 (get_url_to_string): Use a io_stream_memory buffer instead of GUBuf.
6975 * io_stream.h (io_stream_seek_t): New enum.
6976 (io_stream): Update write() and add seek().
6977 * io_stream_cygfile.cc (io_stream_cygfile::write): New prototype.
6978 (io_stream_cygfile::seek): New function.
58b12a06
MB
6979 * io_stream_cygfile.h (io_stream_cygfile): Update write() and add
6980 seek().
ca9506cc
RC
6981 * io_stream_file.cc (io_stream_file::write): New prototype.
6982 (io_stream_file::seek): New function.
6983 * io_stream_file.h (io_stream_file): Update write() and add seek().
6984
2db33f10
RC
69852001-11-13 Brian Keener <bkeener@thesoftwaresource.com>
6986
6987 * localdir.cc: Add headers unistd.h and port.h.
cef493d7 6988 (save_local_dir): Expand search logic to include local directory for
2db33f10
RC
6989 location of file last-cache.
6990 (dialog_cmd): Skip IDD_ROOT when downloading and use Back button.
cef493d7 6991 (do_local_dir): Expand search logic to include local directory for file
2db33f10
RC
6992 last-cache.
6993 * res.rc (IDD_CHOOSE_DIALOG): Add hotkey to View button.
cef493d7 6994 * Source.cc (dialog_cmd): Skip IDD_ROOT if select Download from
2db33f10 6995 Internet.
cef493d7 6996 (do_source): Default to Install from Internet on first entry or
2db33f10
RC
6997 previous selection if backing up from IDD_ROOT or IDD_LOCAL_DIR.
6998
03a6c5b1
RC
69992001-11-13 Robert Collins <rbtcollins@hotmail.com>
7000
7001 * choose.cc (find_tar_ext): Only match at the end of the string.
7002 (getpkgbyname): Prevent NULL pointer dereference.
7003
b24c88b3
RC
70042001-11-13 Robert Collins <rbtcollins@hotmail.com>
7005
7006 * Makefile.in (CFLAGS): Add warnings and -Werr.
58b12a06
MB
7007 (WARNONLY_FLAGS): For sources that produce (harmless) errors no matter
7008 what.
b24c88b3
RC
7009 (OBJS): Add io_stream class' objects.
7010 (autoload.o): Use WARNONLY_FLAGS.
7011 (inilex.o): Ditto.
7012 (iniparse.o): Ditto.
7013 * archive.cc: New file.
7014 * archive.h: New file.
7015 * archive_tar.cc: New file.
7016 * archive_tar.h: New file.
7017 * archive_tar_file.cc: New file.
7018 * autoload.c: Fix compiler warnings (unused, deprecated conversion).
7019 * choose.cc: Use io_stream.h, not mount.h.
7020 Run indent.
58b12a06
MB
7021 (find_tar_ext): Rewritten to use strstr, and to accept .tar as an
7022 extension.
b24c88b3
RC
7023 (read_installed_db): Use io_streams.
7024 * choose.h: Run indent.
7025 * compress.cc: New file.
7026 * compress.h: New file.
7027 * compress_bz.cc: New file.
7028 * compress_bz.h: New file.
7029 * compress_gz.cc: New file.
7030 * compress_gz.h: New file.
7031 * concat.cc: Run indent.
7032 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7033 * concat.h: Run indent.
7034 * desktop.cc: Run indent.
7035 Include mklink2.h rather than redefining by hand.
7036 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7037 (etc_profile): Fix compiler warning (deprecated conversion).
7038 (make_link): Fix compiler warning (deprecated conversion).
7039 Tidy up use of args variable - consolidate into argbuf.
7040 (start_menu): Fix compiler warning (deprecated conversion).
7041 (desktop_icon): Fix compiler warning (deprecated conversion).
7042 (make_etc_profile): Fix compiler warning (deprecated conversion).
7043 (uexists): Fix compiler warning (deprecated conversion).
7044 (check_desktop): Fix compiler warning (deprecated conversion).
7045 (check_startmenu): Fix compiler warning (deprecated conversion).
7046 * dialog.cc: Run indent.
7047 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7048 (fatal): Fix compiler warning (deprecated conversion).
7049 * dialog.h: Run indent.
7050 * diskfull.cc: Run indent.
7051 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7052 * download.cc: Run indent.
7053 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7054 (download_one): Fix compiler warning (signed vs unsigned comparison).
7055 * filemanip.h: Run indent.
7056 * find.cc: Run indent.
7057 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7058 (find): Fix compiler warning (deprecated conversion).
7059 * find.h: Run indent.
7060 * fromcwd.cc: Run indent.
7061 * geturl.cc: Run indent.
7062 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7063 (dialog_cmd): Return a value.
7064 (dialog_proc): Remove unused variables.
7065 Return a value.
7066 (get_url_to_file): Fix compiler warning (deprecated conversion).
7067 * geturl.h: Run indent.
7068 * hash.cc: Run indent.
7069 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7070 * hash.h: Run indent.
7071 * ini.cc: Run indent.
7072 Use io_streams.
7073 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7074 (do_ini): Use io_streams for local io.
7075 * ini.h: Run indent.
7076 * inilex.l (ignore_line): Fix compiler warning (is not a prototype).
7077 Fix compiler warning (brackets for truth assignment).
7078 * install.cc: Run indent.
7079 Fix compiler warning (/* in comment).
7080 Use io_streams.
7081 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7082 (dialog_cmd): Return a value.
7083 (dialog_proc): Return a value.
7084 (start_tics): Deleted - was unused.
7085 (badrename): Fix compiler warnings (unused, deprecated conversion).
7086 (standard_dirs): Fix compiler warning (deprecated conversion).
7087 (exists): Remove.
7088 (uninstall_one): Convert to io_streams.
7089 (install_one): Convert to io_streams.
7090 (do_install): Convert to io_streans.
7091 Fix compiler warning (deprecated conversion).
7092 * io_stream.cc: New file.
7093 * io_stream.h: New file.
7094 * io_stream_cygfile.cc: New file.
7095 * io_stream_cygfile.h: New file.
7096 * io_stream_file.cc: New file.
7097 * io_stream_file.h: New file.
7098 * localdir.cc: Run indent.
7099 Use io_streams.
7100 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7101 (get_root_dir_now): Remove.
7102 (save_local_dir): Convert to io_streams.
7103 (dialog_cmd): Return a value.
7104 (do_local_dir): Convert to io_streams.
7105 (log.cc): Run indent.
7106 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7107 (log): Fix compiler warning (deprecated conversion).
7108 (log_save): Fix compiler warning (deprecated conversion).
7109 * log.h: Run indent.
7110 (log): Fix compiler warning (deprecated conversion).
7111 (log_save): Fix compiler warning (deprecated conversion).
7112 * main.cc: Run indent.
7113 Don't include "netio.h".
7114 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7115 (netio_test): Remove.
7116 (sid_auth): Fix compiler warning (partially bracketed initialiser).
7117 (WinMain): Return a value.
7118 * mkdir.cc: Run indent.
7119 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7120 * mklink2.c: Run indent.
7121 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7122 (mkcygsymlink): New function.
7123 * mklink2.h: New file.
7124 * mount.cc: Run indent.
7125 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7126 (create_mount): Remove unused variables.
7127 (cygpath): Fix compiler warning (signed vs unsigned comparison).
7128 * mount.h: Run indent.
7129 * msg.cc: Run indent.
7130 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7131 (msg): Fix compiler warning (deprecated conversion).
7132 (mbox): Fix compiler warning (deprecated conversion).
7133 * msg.h: Run indent.
7134 (msg): Fix compiler warning (deprecated conversion).
7135 * net.cc: Run indent.
7136 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7137 (dialog_cmd): Return a value.
7138 * netio.cc: Run indent.
7139 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7140 (auth_cmd): Return a value.
7141 * netio.h: Run indent.
7142 * nio-file.cc: Run indent.
7143 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7144 (NetIO_File::NetIO_File): Fix compiler warning (deprecated conversion).
7145 * nio-file.h: Run indent.
7146 * nio-ftp.cc: Run indent.
7147 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7148 * nio-ftp.h: Run indent.
7149 * nio-http.cc: Run indent.
7150 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7151 * nio-http.h: Run indent.
7152 * nio-ie5.cc: Run indent.
7153 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7154 * nio-ie5.h: Run indent.
7155 * other.cc: Run indent.
7156 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7157 (dialog_cmd): Return a value.
7158 * port.h: Run indent.
7159 * postinstall.cc: Run indent.
7160 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7161 (cmd): Fix compiler warning (deprecated conversion).
7162 (eun): Fix compiler warning (deprecated conversion).
7163 * root.cc: Run indent.
7164 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7165 * simpsock.cc: Run indent.
7166 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7167 * simpsock.h: Run indent.
7168 * site.cc: Run indent.
7169 Use io_streams.
7170 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7171 (get_root_dir_now): Remove.
7172 (save_site_url): Convert to io_streams.
7173 (dialog_cmd): Return 0.
7174 (get_initial_list_idx): Convert to io_streans.
7175 * source.cc: Run indent.
7176 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7177 (check_if_enable_next): Remove.
7178 (load_dialog): Remove unused variables.
7179 (save_dialog): Ditto.
7180 (dialog_cmd): Return a value.
7181 * splash.cc: Return a value.
7182 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7183 (dialog_cmd): Return a value.
7184 * state.cc: Run indent.
7185 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7186 * state.h: Run indent.
7187 * tar.h: Remove.
7188 * tar.cc: Remove.
7189
398dd7b2
CF
71902001-11-12 Christopher Faylor <cgf@redhat.com>
7191
7192 * desktop.cc (start_menu): Change start menu name to "Cygwin".
7193 (check_startmenu): Ditto.
7194
c29ee141
CF
71952001-11-11 Christopher Faylor <cgf@redhat.com>
7196
7197 * choose.cc (parse_filename): Finish reorganization by correctly
7198 decrementing p in memmove.
7199
3a8276de
CF
72002001-11-11 Christopher Faylor <cgf@redhat.com>
7201
7202 * choose.cc (parse_filename): Reorganize code to work around gcc
7203 optimization problem.
7204
6eea52fb
RC
72052001-11-09 Gareth Pearce <tilps@hotmail.com>
7206
7207 * choose.cc (set_action): Allow skip as an option for installed
7208 packages that have version number not listed in setup.ini.
7209
cf99b153
RC
72102001-11-10 Robert Collins <rbtcollins@hotmail.com>
7211
7212 * choose.cc (set_cation): Backout last change.
7213 (choose_caption): Ditto.
7214
55e204f6
RC
72152001-11-10 Robert Collins <rbtcollins@hotmail.com>
7216
7217 * ini.h (actions): Remove - transferred to choose.h.
7218 (views): Ditto.
7219 * choose.h: Protect class's from "C" compilers.
7220 (actions): New enum, from ini.h. This may not be the 'right' place
7221 but that place doesn't exist yet.
7222 (_views): New enum, from ini.h.
58b12a06
MB
7223 * choose.cc (set_action): Handle installed packages with a version not
7224 in setup.ini.
55e204f6
RC
7225 (choose_caption): Ditto.
7226 * iniparse.y: Rearrange header order to handle new ini.h.
7227
72282001-11-10 Robert Collins <rbtcollins@hotmail.com>
7229
7230 * ini.h (_Info): Fix compiler warnings (signed vs unsigned comparison).
7231 (registry_category): Fix compiler warning (deprecated conversion).
7232 * iniparse.y (registry_category): Ditto.
58b12a06
MB
7233 * choose.cc (cvsid): Fix compiler warnings (unused, deprecated
7234 conversion).
55e204f6
RC
7235 (add_requried): Remove unused variable.
7236 (choose_caption): Handle all enumeration values via a default.
7237 (paint): Fix compiler warnings (unused, deprecated conversion).
58b12a06
MB
7238 (scroll_common): Fix compiler warnings (unused, signed vs unsigned
7239 comparison).
55e204f6
RC
7240 (list_clicK): Fix compiler warnings (signed vs unsigned comparison).
7241 (note_width): Fix compiler warnings (deprecated conversion).
7242 (keep_or_skip): Fix compiler warnings (unused).
7243 (_view::mode_caption): Fix compiler warnings (deprecated conversion).
7244 (set_view_mode): Fix compiler warnings (unused).
58b12a06
MB
7245 (create_listview): Fix compiler warnings (unused, incorrect format,
7246 reaches end of function).
55e204f6 7247 (dialog_proc): Fix compiler warnings (unused).
58b12a06
MB
7248 (read_installed_db): Fix compiler warnings (unused, deprecated
7249 conversion).
55e204f6
RC
7250 * choose.h (_header): Fix compiler warnings (deprecated conversion).
7251 (_view): Ditto.
7252
67a55ad9 72532001-11-08 Pavel Tsekov <ptsekov@syntrex.com>
cef493d7 7254
67a55ad9
RC
7255 * simpsock.h (SimpleSocket::invalidate): Declare new method.
7256 * simpsock.cc (SimpleSocket::invalidate): Implement new method.
7257 (SimpleSocket::SimpleSocket): Initialize buf to zero. Do not allocate
7258 memory for buf in the constructor.
7259 (SimpleSocket::~SimpleSocket): Use SimpleSocket::invalidate().
7260 (SimpleSocket::printf): Use SimpleSocket::write() instead of send().
7261 (SimpleSocket::write): Check object consistency - return -1 on error.
7262 invalidate() the object on socket write error.
7263 (SimpleSocket::fill): Check object consistency - return -1 on error.
7264 invalidate() the object if socket read error is encountered and there
7265 is no more data available in the internal read buffer.
7266 Allocate memory for the internal read buffer.
7267 (SimpleSocket::gets): Return zero (NULL pointer) if error is encountered
7268 during fill() and no more data is available in the internal read buffer.
7269 (SimpleSocket::read): Check object consistency - return -1 on error.
7270 invalidate() the object if socket read error is encountered.
7271 * nio-ftp.cc (NetIO_FTP:NetIO_FTP): Allow 125 as valid response code to
7272 the RETR command (fix for MS IIS ftp server 5 - possibly others too).
7273 (NetIO_FTP::ok): Check if the SimpleSocket object is ok().
7274 (NetIO_FTP::read): Use NetIO_FTP::ok().
7275 * nio-http.cc: Check for valid return value of SimpleSocket::gets().
7276 (NetIO_HTTP::ok): Check if the SimpleSocket object is ok().
7277
5898e300
RC
72782001-11-09 Robert Collins <rbtcollins@hotmail.com>
7279
58b12a06
MB
7280 * simpsock.cc (cvsid): Avoid compiler warnings (not used, deprecated
7281 conversion).
7282 (SimpleSocket::SimpleSocket): Avoid compiler warnings (deprecated
7283 conversion).
5898e300
RC
7284 (SimpleSocket::printf): Ditto.
7285 (SimpleSocket::write): Ditto.
7286 * simpsock.h (SimpleSocket): Avoid compiler warnings for constructor,
7287 printf and write.
58b12a06
MB
7288 * nio-ftp.cc (cvsid): Avoid compiler warnings (not used, deprecated
7289 conversion).
5898e300 7290 (NetIO_FTP::NetIO_FTP): Remove unused variable done.
58b12a06
MB
7291 * nio-http.cc (cvsid): Avoid compiler warnings (not used, deprecated
7292 conversion).
5898e300 7293
8e58f8fd
RC
72942001-11-07 Charles Wilson <cwilson@ece.gatech.edu>
7295
7296 * geturl.cc (get_url_to_string): clean up memory leak
7297 (get_url_to_file): ditto
cef493d7 7298
4b4002ab
RC
72992001-11-06 Robert Collins <rbtcollins@hotmail.com>
7300
7301 * localdir.cc (dialog_cmd): Go back to IDD_ROOT in every case.
7302 * source.cc (dialog_cmd): Go forward to IDD_ROOT in every case.
7303
94525fd9
RC
73042001-11-06 Pavel Tsekov <ptsekov@syntrex.com>
7305
7306 * fromcwd.cc (found_file): Free() memory containing the version and
58b12a06
MB
7307 filepath information for a given package, before replacing the pointers
7308 which reference this memory.
94525fd9
RC
7309
73102001-11-06 Robert Collins <rbtcollins@hotmail.com>
ca83c665
RC
7311
7312 * fromcwd: Fix compiler warnings for cvsid.
7313 (canonicalize_version): Fix compilter warnings.
7314 (do_fromcwd): Ditto.
7315 * version.h: Fix compiler warnings for canonicalize_version.
7316
ce1f9ec2
RC
73172001-11-03 Robert Collins <rbtcollins@hotmail.com>
7318
7319 * res.rc (IDD_CHOOSE): Move the view caption to the right hand side.
7320
89d82ec7
RC
73212001-11-02 Robert Collins <rbtcollins@hotmail.com>
7322
7323 * res.rc (IDD_CHOOSE): Tweak for use on a 640x480 screen.
7324
c8fea72a
RC
73252001-11-02 Robert Collins <rbtcollins@hotmail.com>
7326
58b12a06
MB
7327 * choose.cc (set_action): Correctly allow skip for any uninstalled
7328 package.
8114d309
RC
7329
73302001-11-02 Robert Collins <rbtcollins@hotmail.com>
7331
58b12a06
MB
7332 * choose.cc (default_trust): Change the "Required" forced install
7333 category to "Base".
c8fea72a 7334
f557695e
RC
73352001-11-02 Robert Collins <rbtcollins@hotmail.com>
7336
7337 * choose.cc: Ran indent.
58b12a06
MB
7338 (set_action): When the requested trust level is missing and the level
7339 was not user requested, set the action to ACTION_SAME_CURR.
f557695e 7340
9a60dafc
CF
73412001-11-01 Christopher Faylor <cgf@redhat.com>
7342
cef493d7 7343 * Makefile.in (mingw_getopt.o): Fix typo in non-verbose compilation.
f557695e
RC
7344
73452001-11-02 Robert Collins <rbtcollins@hotmail.com>
7346
7347 * choose.cc (_view::init_headers): Resync with the paint logic.
9a60dafc 7348
878faffd
RC
73492001-11-02 Robert Collins <rbtcollins@hotmail.com>
7350
58b12a06
MB
7351 * choose.cc (add_required): Allow SKIP and SRC_ONLY for currently
7352 installed packages.
878faffd 7353
05bfdf26
RC
73542001-11-02 Robert Collins <rbtcollins@hotmail.com>
7355
58b12a06
MB
7356 * choose.cc (default_trust): Autoset currently installed packages per
7357 the user's selection of prev/curr/exp.
05bfdf26 7358
0b9af00c
RC
73592001-11-02 Robert Collins <rbtcollins@hotmail.com>
7360
7361 * splash.cc (dialog_proc): Return TRUE as specified in the WIN32 API.
7362
7cefe128
RC
73632001-11-02 Pavel Tsekov <ptsekov@syntrex.com>
7364
7365 * geturl.cc (is_showing): Remove.
7366 (is_local_install): New static variable. Controls whether the
7367 progress dialog and the supporting thread will be created.
58b12a06
MB
7368 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the WIN32
7369 API.
7cefe128 7370 (init_dialog): Remove usage of SetForegroundWindow and is_showing.
cef493d7 7371 This prevents the progress dialog to gain control over the
7cefe128
RC
7372 application and fixes the "setup.exe going to background" problem.
7373 (progress): Use is_local_install.
7374 (get_url_to_string): Set is_local_install.
7375 (dismiss_url_status_dialog): Use is_local_install.
7376 * install.cc (dialog_proc): Return TRUE as specified in WIN32 API.
7377 (init_dialog): Remove usage of SetForegroundWindow.
cef493d7 7378 This prevents the progress dialog to gain control over the
7cefe128
RC
7379 application and fixes the "setup.exe going to background" problem.
7380
42a99ed1
RC
73812001-11-02 Robert Collins <rbtcollins@hotmail.com>
7382
7383 * choose.cc (list_click): Change r to row for clarity.
7384 When we shrink the list below 1 page, scroll to the top of the list.
7385 (_view::click): Return the actual change for contractions.
58b12a06
MB
7386 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the Win32
7387 API.
42a99ed1 7388
45c2d7d3
RC
73892001-11-02 Robert Collins <rbtcollins@hotmail.com>
7390
58b12a06
MB
7391 * choose.cc (dialog_cmd): Swap cygwin root selection and local dir
7392 selection order.
45c2d7d3
RC
7393 * localdir.cc: Ran indent.
7394 (get_root_dir_now): New function.
7395 (save_local_dir): New function.
58b12a06
MB
7396 (dialog_cmd): Use it and swap cygwin root selection and local dir
7397 selection order.
45c2d7d3 7398 (do_local_dir): If there is a saved local dir, read it in.
58b12a06
MB
7399 * net.cc (dialog_cmd): Swap cygwin root selection and local dir
7400 selection order.
45c2d7d3
RC
7401 * root.cc (dialog_cmd): Ditto.
7402 * source.cc (dialog_cmd): Ditto.
7403
2399c54d
RC
74042001-11-01 Robert Collins <rbtcollins@hotmail.com>
7405
7406 * choose.cc(list_vscroll): Return 0 as required by win32.
7407 (list_hscroll): Ditto.
7408 (list_click): Ditto.
7409
8e4402a9
RC
74102001-11-01 Robert Collins <rbtcollins@hotmail.com>
7411
7412 * argv.cc: Remove.
7413 * argv.h: Remove.
7414 * main.cc(WinMain): Use __argv to retrieve command line parameters.
7415 * Makefile,in: Remove argv.o.
7416
c168185f
RC
74172001-11-01 Matt Hargett <matt@use.net>
7418
cef493d7
CF
7419 * geturl.cc (progress): Change int to unsigned int to eliminate
7420 lint warnings.
7421 * (get_url_to_string): Check for NULL pointer.
7422 * mount.cc (find2): Use free instead of delete for malloc'd
7423 memory.
7424 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.
c168185f 7425
f97a1ece
RC
74262001-10-31 Robert Collins <rbtcollins@hotmail.com>
7427
58b12a06
MB
7428 * choose.cc(_view::insert_under): Handle linen > nlines and lines[linen]
7429 with neither a package nor a category. The lines[linen] bug was reported
7430 by Matt (matt@usa.net).
7431 (read_installed_db): Bugfix for testing whether a package has a source
7432 tarball. Reported by Matt (matt@usa.net).
7433 * geturl.cc(dialog): Rename gw_dialog to local_gw_dialog to avoid
7434 programmer confusion and lint errors. Reported by Matt (matt@usa.net).
f97a1ece 7435
d52ed64b
RC
74362001-10-31 Robert Collins <rbtcollins@hotmail.com>
7437
58b12a06
MB
7438 * argv.cc: New file, converts arguments for -mwindows
7439 programs. (Simplified derivation from dcrt0.cc.)
d52ed64b
RC
7440 * argv.h: New file.
7441 * Makefile,in: Add argv.o and mingw_getopt.o to setup.exe object list.
7442 Add mingw_getopt.o build rule.
7443 * main.cc(WinMain): Initialise argv and argc for use by getopt.
7444
392ba1ba
CF
74452001-10-27 Christopher Faylor <cgf@redhat.com>
7446
7447 * res.rc: Rearrange info on top line slightly.
7448
31324d15
CF
74492001-10-27 Christopher Faylor <cgf@redhat.com>
7450
7451 * desktop.cc (make_passwd_group): Move file creation earlier in the
7452 process to ensure that passwd-grp.bat reflects desired operation.
7453
74542001-27-10 Trevor Forbes <t4bs@hotmail.com>
7455
7456 * postinstall.cc (each): Remove "*.done" file else rename will fail.
7457
ee411d77
CF
74582001-10-16 Christopher Faylor <cgf@redhat.com>
7459
7460 * res.rc: Oops. Take 640x480 screen size into account.
7461
e74944da
CF
74622001-10-16 Christopher Faylor <cgf@redhat.com>
7463
7464 * res.rc: Enlarge chooser screen.
7465
e368cfb9
CF
74662001-10-12 Christopher Faylor <cgf@redhat.com>
7467
7468 * Makefile.in: Accomodate changes to w32api_include macro.
7469
a6ba3670
CF
74702001-10-12 Christopher Faylor <cgf@redhat.com>
7471
7472 * Makefile.in: Use correct flags for windres.
7473
683e96f6
CF
74742001-10-12 Christopher Faylor <cgf@redhat.com>
7475
7476 * Makefile.in (CFLAGS): Remove -nostdinc from CFLAGS.
7477
2c18c00b
CF
74782001-10-12 Christopher Faylor <cgf@redhat.com>
7479
7480 * choose.cc (pick_line::paint): Reorganize after botched patch.
7481
0f61a05a
CF
74822001-10-12 Christopher Faylor <cgf@redhat.com>
7483
7484 * choose.cc (pick_line::paint): Add missing declaration.
7485
308d6f3e
CF
74862001-10-10 Ralf Habacker <Ralf.Habacker@freenet.de>
7487
7488 * choose.cc (pick_line::paint): Add package name to sdesc for display.
7489
3bcf85be
RC
7490Wed Sep 26 21:39:00 Robert Collins rbtcollins@hotmail.com
7491
7492 * choose.cc (_view::insert_pkg): Correctly exit loop.
7493 * iniparse.y (register_category): Always insert new categories.
7494
fb2cd8f6
CF
7495Fri Sep 21 13:56:32 2001 Christopher Faylor <cgf@cygnus.com>
7496
7497 * inilex.l (yylex): For comments, eat all characters up to, but not
7498 including newline.
7499
127b32e1
CF
7500Sun Aug 26 12:50:01 2001 John Marshall <jmarshall@acm.org>
7501
7502 * fromcwd.cc (found_file): Use correct package name when adding an
7503 unknown package rather than random stack garbage.
7504
2cd555aa
CF
7505Sun Aug 12 14:25:21 2001 Christopher Faylor <cgf@cygnus.com>
7506
7507 * desktop.cc (make_passwd_group): .bat files need \r\n endings.
7508
4254cc64
CF
7509Wed Aug 8 13:53:47 2001 Christopher Faylor <cgf@cygnus.com>
7510
7511 * desktop.cc (etc_profile): Leave environment variables untouched.
7512
acbae401
CV
75132001-08-07 Corinna Vinschen <corinna@vinschen.de>
7514
7515 * autoload.c: Add dynamic load statements for NT/W2K
7516 advapi32 functions not available in 9x/ME.
7517 * main.cc (set_default_dacl): New function.
7518 (WinMain): Call `set_default_dacl' if running on NT/W2K.
7519
969a294c
CF
7520Sat Aug 4 21:35:53 2001 Christopher Faylor <cgf@cygnus.com>
7521
7522 * ini.h (_CategoryPackage): Change pkg field to pkgname for
7523 consistency.
7524 * choose.cc: Use pkgname field when referencing _CategoryPackage
7525 throughout.
7526 (fill_missing_category): Don't add excluded packages.
7527 (default_trust): Ditto.
7528 (_view::insert_pkg): Ditto.
7529 * iniparse.y (register_category): Use consistent variable name.
7530
9eeb0e83
ED
75312001-07-09 Egor Duda <deo@logos-m.ru>
7532
7533 * choose.cc: Use system foreground color for text output.
7534
06560feb
CF
7535Sat Jul 7 00:40:28 2001 Christopher Faylor <cgf@cygnus.com>
7536
7537 * choose.cc (set_action): Use default trust for determining reinstall
7538 and source only.
7539 (default_trust): Set default trust.
7540 (pick_line::paint): Allow source selection when reinstalling or
7541 retrieving.
7542
1fb09149
CF
7543Fri Jul 6 18:08:49 2001 Christopher Faylor <cgf@cygnus.com>
7544
7545 * choose.cc (isinstalled): Modify to properly accomodate special case
7546 of "download only".
7547 (set_action): Check downloaded components, not installed components if
7548 "download only".
7549 (set_existence): Always include full list of files when "download
7550 only".
7551
14cfffa5
CF
7552Fri Jul 6 00:37:05 2001 Christopher Faylor <cgf@cygnus.com>
7553
7554 * choose.cc (pick_line::paint): Properly display "na" field when no
7555 source exists.
7556
f54385f6
CF
7557Thu Jul 5 00:34:23 2001 Christopher Faylor <cgf@cygnus.com>
7558
7559 * choose.cc (scan2): Ensure that older versions do not show up in
7560 "Test" slot.
7561
85b1fb54
CF
7562Mon Jul 2 15:47:59 2001 Christopher Faylor <cgf@cygnus.com>
7563
7564 * choose.cc (set_action): Allow "Skip" action if trust != installed.
7565 * res.rc: Fix copyright.
7566
2dada532
CF
7567Sat Jun 30 14:05:21 2001 Michael A Chase <mchase@ix.netcom.com>
7568
7569 * res.rc (IDD_LOCAL_DIR): Change caption to match the other dialog
7570 boxes.
06c6d195 7571 (IDD_CHOOSE): Adjust horizontal size so package names are visible.
2dada532
CF
7572
7573 * choose.cc: Restore some more changes from 2001-06-25, throughout.
7574 (paint): Wrap some excessively long lines.
7575 (pick_line::paint): Ditto. Move the arrow in the "Current" column
7576 right to where it belongs. Move the source checkbox slightly to the
7577 right.
7578 (do_choose): List categories and required packages in setup.log.full.
7579
7580Sat Jun 30 23:04:59 2001 Christopher Faylor <cgf@cygnus.com>
7581
58b12a06
MB
7582 * choose.cc (scan2): Restore source scanning eliminated by previous
7583 checkin.
2dada532 7584
1b13eeec
CF
7585Sat Jun 30 15:18:33 2001 Christopher Faylor <cgf@cygnus.com>
7586
7587 * ini.h (struct _Info): Add "derived" element.
7588 * choose.cc (scan2): Try to place unknown tar files into proper slot
7589 when package exists in setup.ini but tar file does not.
7590
9307254d
RC
7591Sat Jun 30 13:39:00 2001 Robert Collins <rbtcollins@hotmail.com>
7592
7593 * choose.cc (create_listview): Call set_view_mode with VIEW_CATEGORY.
7594 (do_choose): Log the first category name.
7595
3467d79f
CF
7596Fri Jun 29 23:07:44 2001 Christopher Faylor <cgf@cygnus.com>
7597
7598 *ini.h: Reapply 2001-06-25 changes.
7599 * choose.cc (add_required): Ditto. Default to "Keep" state if
7600 UNINSTALL and product is installed. Default to curr state if SKIP,
7601 etc.
7602 (keep_or_skip): New function. Returns skip or keep state depending on
7603 installed state of package.
7604 (default_trust): Use keep_or_skip to set state.
7605 (_view::insert_pkg): Use calloc to allocate lines.
7606 (set_view_mode): Adapt 2001-06-25 change to set_full_list here.
7607
8f53e82a
RC
7608Sat Jun 30 11:01:00 2001 Robert Collins <rbtcollins@hotmail.com>
7609
1fb09149 7610 * choose.cc: Remove globals full_list, headers, package_indexes and
8f53e82a
RC
7611 nindexes.
7612 Add globals cat_headers, pkg_headers and chooser.
7613 (add_required): New function.
7614 (paint): Use the chooser for header details.
7615 Call into the chooser to paint each line.
1fb09149 7616 (list_click): Use new global variables.
8f53e82a
RC
7617 Call into the chooser to handle the click.
7618 Repaint the entire view if packages have been added or removed.
7619 (note_width): Get passed a headers struct rather than using a global
7620 variable.
7621 (fill_missing_category): New function.
7622 (default_trust): Skip non-"Required" or "Misc" packages.
7623 (pick_line::set_line (Package *)): New function.
7624 (pick_line::set_line (Category *)): New function.
7625 (pick_line::paint): New function.
7626 (pick_line::click): New function.
7627 (_view::_view): New function.
7628 (_view::set_view_mode): New function.
7629 (_view::mode_caption): New function.
7630 (_view::set_headers): New function.
7631 (_view::init_header): New function.
7632 (_view::insert_pkg): New function.
7633 (_view::insert_category): New function.
7634 (_view::insert_at): New function.
7635 (_view::insert_under): New function.
7636 (_view::clear_view): New function.
7637 (viewsplusplus): New function.
7638 (_view::client): New function.
7639 (set_view_mode): Use new chooser functionality.
7640 (set_full_list): Use new global variables.
7641 (create_listview): Instantiate chooser.
7642 Remove all hardcoded headers[] code.
7643 (dialog_cmd): On trust changes, check dependencies.
7644 (getcategorybyname): New function.
7645 (getpackagecategorybyname): New function.
7646 (scan2): Use case-insensitive package comparison.
7647 (do_choose): Use fill_missing_category ().
7648 Show some category data.
7649 * ini.h: Protect against multiple inclusion.
7650 (views) New enum.
7651 (_CategoryPackage): New struct.
7652 (_Category): New struct.
7653 (_Package): Change category to Category * from char *.
7654 (extern Category category): New global variable.
7655 (extern in ncategories): Ditto.
7656 (getcategorybyname): New prototype.
7657 (catpackagecategorybyname): New prototype.
7658 (register_category): New prototype.
7659 (add_category): New prototype.
7660 * iniparse.y: Parse multiple categories per package.
2dada532
CF
7661 (category): New global variable.
7662 (ncategories): New global variable.
8f53e82a
RC
7663 (new_package): Compare package against NULL, not 0.
7664 (new_requirement): Source formatting fix.
7665 (register_category): New function.
7666 (add_category): New function.
7667 * res.rc: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
7668 IDC_CHOOSE_VIEWCAPTION: New control.
7669 * resource.h: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
7670 IDC_CHOOSE_VIEWCAPTION: New control.
7671 Increment _APS_NEXT_CONTROL_VALUE.
7672
26a27c14
CF
7673Mon Jun 25 00:56:37 2001 Michael A Chase <mchase@ix.netcom.com>
7674
e19ad6a3 7675 * choose.cc (paint): Wrap excessively long lines.
26a27c14
CF
7676 (list_click): Ditto.
7677 (create_listview): Ditto.
7678 (do_choose): Ditto. Replace TABs and remove CRs in lines written to
7679 setup.log.full. Allow "Yes" for source exists in setup.log.full when
7680 installing from local directories.
7681
97312777
CF
7682Mon Jun 25 00:56:37 2001 Christopher Faylor <cgf@cygnus.com>
7683
5f9f0d8d
CF
7684 * choose.cc (set_action): Only clear srcpicked when moving to next
7685 state. Allow source installation if it exists in the current "trust"
7686 state. Don't move to skip state when package is installed.
97312777
CF
7687 (list_click): Don't allow source clicking when no source is available.
7688 (set_full_list): Display package when not is_full_action.
7689 * ini.h (is_full_action): Define.
7690
72fd1d1e
CF
7691Sun Jun 17 12:06:14 2001 Christopher Faylor <cgf@cygnus.com>
7692
7693 * install.cc (check_for_old_cygwin): New function. First stab at
7694 checking for old cygwin versions.
7695 (do_install): Call check_for_old_cygwin if there were no errors during
7696 the install.
7697
41ac91b5 7698Sat Jun 16 11:33:51 2001 Michael A Chase <mchase@ix.netcom.com>
86202506
CF
7699
7700 * choose.cc (_Info::_Info): Test _source paramenter for non-NULL rather
7701 than zeroed "source" element.
7702
80429b97
CF
7703Fri Jun 15 20:54:43 2001 Christopher Faylor <cgf@cygnus.com>
7704
7705 * choose.cc (scan2): Insert unknown tar archives, found on disk, into
7706 the highest available "hole" in the trust array.
7707
654ea642
CF
7708Fri Jun 15 00:20:48 2001 Christopher Faylor <cgf@cygnus.com>
7709
7710 * choose.cc (set_existence): Use pointer method for indexing in trust
7711 array.
7712 (create_listview): Ditto.
7713 (scan2): Ditto. Also, use consistent variable name for indexing into
7714 trust array.
7715 * ini.h (Package): Reorganize info array for easier scanning.
7716
e98d90bd
CF
7717Fri Jun 15 00:01:51 2001 Christopher Faylor <cgf@cygnus.com>
7718
7719 * choose.cc (isinstalled): Eliminate special download only test.
7720 (set_action): Don't move to next state if in ACTION_SAME range and not
7721 incrementing.
7722 (choose_caption): Display "Retrieve" rather than "Reinstall" when just
7723 downloading.
7724 (do_choose): Sort packages after all packages have been read.
7725 Accomodate the fact that first element in trust array is empty so that
7726 log files don't report the wrong trust value.
7727 * iniparse.y (new_package): Malloc space for package name or suffer
7728 memory corruption.
7729
38c97581
CF
7730Thu Jun 14 22:43:59 2001 Robert Collins <rbtcollins@hotmail.com>
7731
7732 * ini.h (Dependency): New structure. Declare new function.
58b12a06
MB
7733 * inilex.l (yylex): Detect new setup.ini options - category and
7734 requires.
38c97581
CF
7735 * iniparse.y: Declare new setup.ini token values.
7736 (yyparse): Parse new token values.
7737 (new_requirement): New function.
7738
7739Thu Jun 14 22:43:26 2001 Christopher Faylor <cgf@cygnus.com>
7740
7741 * choose.cc (read_installed_db): Eliminate obsolete code.
7742
3ae6c15c
CF
7743Thu Jun 14 22:11:53 2001 Christopher Faylor <cgf@cygnus.com>
7744
7745 * choose.cc (set_action): Set trust on "redo".
7746 (_Info::_Info): New constructor.
7747 (read_installed_db): Use new constructor. Use trusts type for
7748 iterator.
7749 * ini.h (struct _Info): Label struct, add constructor.
7750 (Package): Make installed_ix a type 'trusts.'
7751 * install.cc (uninstall_one): Unset any installed info for current
7752 package.
7753 (install_one): Allocate new Info struct for installed reflecting new
7754 installed info.
7755 (do_install): Don't output line to installed.db if package is being
7756 uninstalled.
7757
9c0a9876
CF
7758Thu Jun 14 20:33:01 2001 Robert Collins <rbtcollins@hotmail.com>
7759
7760 * choose.cc (getpkgbyname): Use consistent method for scanning package
7761 array.
7762
68b27c12
CF
7763Wed Jun 13 23:33:08 2001 Christopher Faylor <cgf@cygnus.com>
7764
7765 * choose.cc: Add some comments.
7766 (getpkgbyname): Use strcasecmp for comparisons.
7767
07108cc2
CF
7768Wed Jun 13 16:07:00 2001 Christopher Faylor <cgf@cygnus.com>
7769
f0984dcb 7770 * install.cc (do_install): Avoid checking for download action if
07108cc2
CF
7771 package wasn't currently retrieved.
7772
c46a33a9
CF
7773Wed Jun 13 11:27:22 2001 Christopher Faylor <cgf@cygnus.com>
7774
7775 * choose.cc: Eliminate extra array throughout. Use element in package
7776 structure instead. Use pointers rather than array indexes where
7777 appropriate.
7778 (set_action): New function to set next action based on current.
7779 (choose_caption): New function. Returns display caption.
7780 (check_existence): Change arguments. Use pointer to 'info' structure.
7781 (set_existence): Use pointer rather than array index.
7782 (default_trust): Use trusts enum for second argument.
7783 (set_full_list): Honor exclude element in package structure.
7784 (build_labels): Eliminate.
7785 (base): Make global. Use const char * argument.
7786 (get_package_version): Eliminate.
7787 (getpkgbyname): New function.
7788 (read_installed_db): Use parse_filename to get version info.
7789 * desktop.cc (make_passwd_group): Use getpkgbyname function.
7790 * download.cc (get_file_size): const argument.
7791 (do_download): Use is_download_action to determine when something
7792 should be downloaded.
7793 * filemanip.h: Add some functions.
7794 * ini.cc (do_ini): Use NULL rather than 0 for pointer assignment.
7795 * ini.h: Use enums for actions and trusts.
7796 (is_download_action): New macro.
7797 (is_upgrade_action): Ditto.
7798 (is_uninstall_action): Ditto.
7799 (struct Package): Add new fields.
7800 * inilex.l (yylex): Detect new setup.ini options.
7801 * iniparse.y: Declare new tokens.
7802 (yyparse): Detect exclude keyword. Fill out version field even if
7803 version == 0.
7804 (new_package): Use greater granularity when allocating package array to
7805 avoid repeated calls to realloc.
7806 * install.cc (exists): const argument.
7807 (uninstall_one): Take pkg argument.
7808 (install_one): Ditto. Eliminate unneeded arguments which can be
7809 derived from package info.
7810 (do_install): Iterate over package array using a pointer. Use
7811 is_download_action to control when package should be downloaded.
7812 * tar.cc (tar_open): const argument.
7813 * tar.h: Refloect const argument.
7814
7cc06fd3
CF
78152001-05-31 Michael Chase mchase@ix.netcom.com
7816
7817 * main.cc (WinMain): Add setup version to starting setup.log entry
7818
9522028b
CF
7819Tue May 29 21:37:58 2001 Yukihiko Sohda <sohda@is.titech.ac.jp>
7820
7821 * inilex.l: Add + to list of valid string characters.
7822
e9b1aaa7
CF
7823Mon May 28 20:54:50 2001 Christopher Faylor <cgf@cygnus.com>
7824
7825 * Makefile.in: Remove more stuff in the clean target.
7826
8e1299fa
CF
7827Mon May 28 18:24:59 2001 Christopher Faylor <cgf@cygnus.com>
7828
7829 * Makefile.in: Correctly generate iniparse.h.
7830
85553593
CV
7831Tue Mar 6 19:14:00 2001 Corinna Vinschen <corinna@vinschen.de>
7832
7833 * geturl.cc (get_url_to_file): Add parameter `allow_ftp_auth'.
7834 * geturl.h: Change declaration of `get_url_to_file' accordingly.
7835 * netio.cc (NetIO::NetIO): Add parameter `allow_ftp_auth'.
7836 Set member `ftp_auth'.
7837 (NetIO::open): Add parameter `allow_ftp_auth'. Use it in calls
7838 to constructors of derived classes.
7839 (NetIO::get_ftp_auth): New method.
7840 * netio.h: Change class definition accordingly.
7841 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Add parameter `allow_ftp_auth'.
7842 Take global variables `net_ftp_user' and `net_ftp_passwd' into account.
7843 Add code for ftp authentication retry.
7844 * nio-ftp.h: Change class definition accordingly.
7845 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Add parameter `allow_ftp_auth'.
7846 Add code for ftp authentication retry in case of proxy connection.
7847 * nio-http.h: Change class definition accordingly.
7848 * res.rc: Add FTP authentication dialog.
7849 * resource.h: Add new constants used in res.rc.
7850 * state.h: Add variables `net_ftp_user' and `net_ftp_passwd'.
7851
c4174b9c
CF
7852Sun May 27 17:12:23 2001 Christopher Faylor <cgf@cygnus.com>
7853
7854 * res.rc (IDD_SPLASH): Add a copyright year.
7855
0af2d779
CF
7856Sun May 27 15:42:18 2001 Christopher Faylor <cgf@cygnus.com>
7857
7858 * Makefile.in: Make iniparse.y produce a c++ file.
7859 * choose.cc (set_existence): Revert 2001-05-27 change.
7860 * ini.cc: Remove "C" from declaration of yyparse.
7861 * iniparse.y (yyparse): Fill out version field by default when a binary
7862 install is detected and no version has been set yet.
7863 * install.cc (do_install): Mount things earlier so that we can use
7864 proper mount table settings. Don't remove mounts since they are now
7865 honored.
7866 * mount.cc (create_mount): Reread the mount table after establishing a
7867 new mount.
7868 (read_mounts): Explicitly clear root_here to allow multiple uses of
7869 this function. Ensure that there is no garbage in the table when we've
7870 exhausted all of the mounts in the registry.
7871 (cygpath): Accomodate ./ in path.
7872
85b43844
CF
7873Sun May 27 02:59:07 2001 Christopher Faylor <cgf@cygnus.com>
7874
0af2d779
CF
7875 Use parse_filename method to parse filenames throughout. Use
7876 get_root_dir to retrieve the current root directory throughout. Set
7877 const in argument list, where appropriate, throughout.
7878 * choose.cc (set_existence): Detect case of uninstalled package with no
7879 version.
85b43844
CF
7880 (parse_filename): New function.
7881 * filemanip.h (fileparse): New structure.
7882 * mount.cc (read_mounts): Remember where we found the root mount.
7883 (set_root_dir): New function.
7884 (get_root_dir): Ditto.
7885 * mount.h: Declare new functions.
7886 * site.cc (get_root_dir_now): Renamed from get_root_dir.
7887 (save_site_url): Use new function name.
7888 (get_initial_list_idx): Ditto.
7889
08f8c762
CF
7890Sat May 26 21:23:59 2001 Christopher Faylor <cgf@cygnus.com>
7891
7892 * choose.cc: Use a constant throughout to deal with chooser icon
7893 length.
7894 * res.rc (IDD_CHOOSE): Increase size of chooser box.
7895
47f8d8b3
CF
78962001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
7897
7898 * choose.cc (do_choose): Fix incorrect assignment of trust setting to
7899 use when Redownload or Sources Only selected.
7900
6a748750
CF
7901Thu May 10 22:35:59 2001 Christopher Faylor <cgf@cygnus.com>
7902
7903 Reformat file after botched patch formatting.
7904 * choose.cc (which_trust): Eliminate variable.
7905 (default_trust): Don't set which_trust.
7906 (do_choose): Use selected trust when reinstalling or installing source.
7907
a351e48c
CF
7908Thu May 10 21:04:18 2001 Christopher Faylor <cgf@cygnus.com>
7909
7910 Change concat to cygpath throughout.
7911 Change map_filename to cygpath throughout.
7912 * concat.cc (vconcat): New function.
7913 (concat): Use vconcat.
7914 * concat.h: Reflect above.
7915 * install.cc (map_filename): Eliminate.
7916 (install_one): Free dest_file.
7917 * mount.cc (find2): Expect input key to be pointing to mount record.
7918 (in_table): New function.
7919 (is_admin): Move from root.cc.
7920 (read_mounts): New function.
7921 (path_prefix_p): New function.
7922 (cygpath): New function.
7923 * mount.h: Define new functions and structure.
7924 * root.cc (in_table): Move to mount.cc.
7925 (do_root): Call read_mounts to initialize root stuff and mount table.
7926 * site.cc (get_root_dir): Ditto.
7927
e227ee24
CF
79282001-05-09 Matt Hargett <matt@use.net>
7929
7930 * Makefile.in: Remove *.rc from clean.
7931
25fd2965
CF
7932Tue May 8 23:33:38 2001 Christopher Faylor <cgf@cygnus.com>
7933
7934 * choose.cc (scan2): Fix incorrect setting of TRUST_CURR rather than
7935 TRUST_PREV which produced "0" versions.
7936
42bf5b92
CF
79372001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
7938
7939 * resource.h: Add new field IDC_CHOOSE_INST_TEXT. Modify
7940 _APS_NEXT_CONTROL_VALUE to account for addition of
7941 IDC_CHOOSE_INST_TEXT.
7942 * res.rc (IDD_CHOOSE): Modify choose dialog to use new field
7943 IDC_CHOOSE_INST_TEXT for screen text. Modify choose Dialog to allow
7944 hot keys to select Prev, Curr, Exp.
7945 * ini.h: Add new actions for ACTION_REDO and ACTION_SRC_ONLY. Modify
7946 define for LOOP_PACKAGES to include new actions ACTION_REDO and
7947 ACTION_SRC_ONLY.
7948 * choose.cc: Add new Trusts for TRUST_REDO and TRUST_SRC_ONLY.
7949 (paint): Modify to check TRUST_SRC_ONLY when determining Bitmap for
7950 source Checkbox to use.
7951 (build_labels): Add logic to allow for selection of Source only
7952 Download/ReDownload/Install/Reinstall and also to Redownload/Reinstall
7953 current version binary.
7954 (dialog_proc): Add conditional display for file selection prompt based
7955 on download vs install using IDC_CHOOSE_INST_TEXT.
7956 (do_choose): Add new logic for TRUST_REDO and TRUST_SRC_ONLY selection
7957 and modify logic for TRUST_UNINSTALL, TRUST_KEEP, and TRUST_NONE to
7958 handle the instance where Source Download/Install was selected. Modify
7959 log file to store appropriate information regarding Action selected and
7960 the new actions that were added (I.E.: ACTION_REDO and
7961 ACTION_SRC_ONLY).
7962 * download.cc: Add include for <unistd.h> and "port.h".
7963 (download_one): Modify parameter list to include the selected action
7964 for the file to be downloaded. Modify size check against expected size
7965 to include check for ACTION_REDO and ACTION_SRC_ONLY. Modify rename of
7966 .tmp file to also remove the destination file if exists due to ability
7967 to redownload source and binary now.
7968 (do_download): Modify to also use ACTION_REDO and ACTION_SRC_ONLY in
7969 calculation of Download Bytes. Modify to also use ACTION_REDO and
7970 ACTION_SRC_ONLY in determining files selected for download.
7971 * install.cc (uninstall_one): Add check to treat a Reinstall like an
7972 upgrade so current version will be uninstalled prior to reinstall.
7973 (do_install): Add logic to handle ACTION_REDO and ACTION_SRC_ONLY for
7974 uninstalling and installing binary and source packages.
7975 * desktop.cc (make_passwd_group): Modify logic to account for a Source
7976 only cygwin install when checking for cygwin to determine need for
7977 mkpasswd and mkgroup.
7978
7979Mon May 7 23:33:30 2001 Matt Hargett <matt@use.net>
8a09aa99
CF
7980
7981 * winsup/cinstall/res.rc: Added accelerators and improved focus order.
7982 Removed WS_DISABLED from "OK" buttons to accomodate default focus
7983 changes in net.cc and source.cc.
7984 * winsup/cinstall/net.cc (dialog_proc): If no radio button is selected,
7985 a default is selected.
7986 * winsup/cinstall/source.cc (dialog_proc): Ditto.
7987 (check_if_enable_next): Removed. No longer needed since a radio button
7988 will always be selected.
7989 (load_dialog): Removed call to check_if_enable_next.
7990 (dialog_cmd): Ditto. Also added default to switch.
7991
87bdba0c
CF
7992Tue Apr 24 23:42:02 2001 Christopher Faylor <cgf@cygnus.com>
7993
7994 * res.rc: Resize affected text.
7995
8293fc16
CF
7996Tue Apr 24 23:35:31 2001 Christopher Faylor <cgf@cygnus.com>
7997
7998 * net.cc (do_net): Default to direct download.
87bdba0c 7999 * res.rc: Move default selections to the top.
8293fc16 8000
ed96c6da
EB
80012001-04-18 Earnie Boyd <earnie@users.sourceforge.net>
8002
8003 * win32.h: Remove the definitions for _UNION_NAME and _STRUCT_NAME.
8004 Must now include <windows.h> and not the pieces.
8005 * choose.cc (create_listview): Clean up type mismatch problems.
8006 * dialog.h (NEXT(id)): Ditto.
8007 * geturl.cc (dialog): Ditto.
8008 * install.cc (dialog): Ditto.
8009 * splash.cc (load_dialog): Ditto.
8010
fe94cc29
CF
8011Wed Apr 18 18:59:21 2001 Christopher Faylor <cgf@cygnus.com>
8012
8013 * tar.cc (class gzbz): Define dummy virtual functions.
8014
fb087b80
CF
8015Wed Apr 18 16:01:21 2001 Christopher Faylor <cgf@cygnus.com>
8016
8017 * Makefile.in: Add bz2 include/library support.
8018 * filemanip.h: New file.
fe94cc29
CF
8019 * choose.cc (find_tar_ext): New function. Returns TRUE if .tar.gz or
8020 .tar.bz2 found.
fb087b80
CF
8021 (scan2): Reorganize to use find_tar_ext, accomodating .bz2 extension.
8022 (read_installed_db): Ditto.
8023 (do_choose): Ditto.
8024 * fromcwd.cc (found_file): Ditto.
8025 (do_fromcwd): Ditto.
8026 * tar.cc (class gzbz): New super class for uncompression support.
8027 (gz): New class for gzip support.
8028 (bz): New class for bzip2 support.
8029 (tar_open): Use gzbz class to control file opening.
8030 (tar_ftell): Ditto for returning position in file.
8031 (skip_file): Ditto for reading file.
8032 (tar_next_file): Ditto.
8033 (tar_read_file): Ditto.
8034 (tar_close): Ditto for close.
8035
8036 * zlib/configure.in: Force NM substitution.
8037
8038 * source.cc (do_source): Default to "Install from Internet".
8039
88bcaf07
CF
80402001-03-16 Brian Keener <bkeener@thesoftwaresource.com>
8041
8042 * nio-file.cc (NetIO_File::NetIO_File): Use `get_file_size' instead of
8043 `stat'.
8044 * choose.cc (list_click): Correct inability to select source code for
8045 download.
8046 (scan2): Modify to skip source tarballs when scanning disk for
8047 installable packages.
8048
ef45c299
CV
80492001-03-10 Chris Abbey <chris_abbey@yahoo.com>
8050
8051 * install.cc: install sources into /usr/src instead
8052 of /, also include the sizes of source tarballs
8053 in total_bytes.
8054 * download.cc: include sizes of source tarballs in
8055 total_download_bytes.
8056
9fe1181b
CV
8057Tue Mar 6 19:31:00 2000 Corinna Vinschen <corinna@vinschen.com>
8058
8059 * download.cc (get_file_size): Remove `static'.
8060
2bfdb848
CV
8061Tue Mar 6 19:11:00 2000 Corinna Vinschen <corinna@vinschen.com>
8062
8063 * tar.cc (tar_open): Use `get_file_size' instead of `stat'.
8064
60c632b3
CV
80652001-03-06 Brian Keener <bkeener@thesoftwaresource.com>
8066
8067 * choose.cc (paint): Modify message for nothing to download vs
8068 nothing to install/update based on installation method.
8069 (list_click): Modify to skip versions in selection process if
88bcaf07 8070 installing from local directory and installation file does not exist.
60c632b3
CV
8071 Also leaves Source Action set to N/A if the source file does not exist
8072 and installing from local directory.
8073 (check_existence): New method to check current existence of installation
8074 files based on selected installation method.
8075 (set_existence): New method to set the current existence of installation
8076 files based on selected installation method.
8077 (best_trust): Modify decision process for best trust to base decision on
8078 current trust selected (IE: Prev, Curr, or Test), existence of file and
8079 installation method selected.
8080 (default_trust): Add logic to capture the current trust level and the
8081 trust selected for the given package.
88bcaf07 8082 (set_full_list): Expand decision criteria for displaying a package in
60c632b3
CV
8083 the selection list to include file existence/non-existence and selected
8084 installation method.
8085 (build_labels): Modify criteria for label addition to include
8086 installation method and file existence/non-existence.
88bcaf07 8087 (create_listview): Modify to establish package trust level for each
60c632b3
CV
8088 package before setting up the display list. Also modification to set
8089 current trust button as the default.
88bcaf07 8090 (dialog_cmd): Set response for Prev, Curr, Test button push to perform
60c632b3
CV
8091 a reset of the selection list in addition to setting the default trust.
8092 (get_package_version): New method to provide reusable code for
8093 determining the package version from the file name for a specified
8094 trust.
8095 (scan2): Modify to use new method get_package_version and
8096 also enhance handling of the build for the structures package and
8097 extra.
8098 (read_installed_db): Modify to use the new method
8099 get_package_version and also enhance handling of the build for the
8100 structures package and extra.
88bcaf07 8101 (do_choose): Add additional initialization of package and extra
60c632b3
CV
8102 structures. Modify to use read_installed_db all the time despite
8103 install method. Modify output to setup.log.full log file to increase
8104 readability by adding additional spacing, expanded code and available
8105 versions.
8106 * ini.h: Add new fields install_exists, source_exists and
88bcaf07 8107 partial_list_display to the structure definition for package.
60c632b3
CV
8108 * res.rc (IDD_CHOOSE): Modify choose dialog Prev, Curr, and Test
8109 pushbuttons by replacing with Radio Buttons thus allowing the
8110 operator to better determine which is selected.
8111
2f9645a1
CV
81122001-02-20 Brian Keener <bkeener@thesoftwaresource.com>
8113
88bcaf07 8114 * download.cc (do_download): Add new variables total_download_bytes and
2f9645a1
CV
8115 total_download_bytes_sofar for download progress meter. Add loop
8116 to accumulate the total bytes to download from the selected packages.
8117 * geturl.cc: Add state.h and diskfull.h to include list. Add new
8118 variables gw_iprogress, gw_pprogress, gw_progress_text,
8119 gw_pprogress_text, and gw_iprogress_text to allow for addition of
8120 total packages download progress meter and disk full percent
8121 progress meter. Add variables total_download_bytes and
8122 total_download_bytes_sofar for use by progress meters.
88bcaf07
CF
8123 (dialog_proc): Add new variables gw_iprogress, gw_pprogress,
8124 gw_progress_text, gw_pprogress_text, and gw_iprogress_text to
8125 allow for addition of total packages download progress meter and disk
8126 full percent progress meter.
2f9645a1
CV
8127 (init_dialog): Ditto.
8128 (progress): Ditto.
8129 (get_url_to_file): Ditto.
8130 * geturl.h: Add external definition for total_download_bytes and
8131 total_download_bytes_sofar.
88bcaf07 8132 * res.rc: Add two additional progress meters (IDC_DLS_IPROGRESS)
2f9645a1
CV
8133 and (IDC_DLS_PPROGRESS) and three text objects (IDC_DLS_PROGRESS_TEXT)
8134 and (IDC_DLS_IPROGRESS_TEXT, IDC_DLS_PPROGRESS_TEXT) for use in the
8135 download meters.
88bcaf07 8136 * resource.h: Add new fields for progress meters and text and update
2f9645a1
CV
8137 _APS_NEXT_CONTROL_VALUE.
8138
b41962a3
CV
8139Wed Feb 21 13:05:00 2000 Corinna Vinschen <vinschen@redhat.com>
8140
8141 * download.cc (get_file_size): Check for INVALID_HANDLE_VALUE instead
8142 for NULL.
8143
8144Wed Feb 21 11:21:00 2000 Corinna Vinschen <vinschen@redhat.com>
01954c34
CV
8145
8146 * download.cc (download_one): Add missing parenthesis.
8147
88a77116
CV
8148Mon Feb 19 18:59:00 2000 Corinna Vinschen <vinschen@redhat.com>
8149
8150 * download.cc (get_file_size): New function. Eliminates the need
8151 to call `stat'.
8152 (download_one): Call `get_file_size' instead of `stat'. This
8153 workarounds a problem with mingw's `stat' call.
8154
577f35ed
EB
81552001-02-07 Earnie Boyd <earnie@users.sourceforge.net>
8156
8157 * Makefile.in: (%.o: %.rc): Specify --include-dir $(w32api_include).
8158 This is to allow cinstall to build with 2.95.2-7 and to make the
8159 use of headers consistent.
8160
38f5563e
DD
81612000-12-26 Earnie Boyd <earnie_boyd@yahoo.com>
8162
8163 * Makefile.in (autoload.o): Add target to specify -fno-inline-functions
8164
c0a7e0f2
DD
8165Tue Dec 26 03:46:00 2000 Matt Hargett <matt@use.net>
8166
8167 * winsup/cinstall/res.rc: Added accelerators and improved focus
8168 order.
8169
72826a5b
CF
81702000-12-10 Egor Duda <deo@logos-m.ru>
8171
8172 * choose.cc (paint): Use system background color for text output.
8173
8174Sun Dec 10 19:05:25 2000 Christopher Faylor <cgf@cygnus.com>
8175
8176 * Makefile.in: Use CXX for linking and for compiling .cc files.
8177 * configure.in: Find correct c++ compiler.
8178 * configure: Regenerate.
8179
67bebcb5
DD
81802000-11-17 DJ Delorie <dj@redhat.com>
8181
8182 * splash.cc (load_dialog): Make message more obvious.
8183 * res.rc: Ditto.
8184
25fb9139
CF
8185Fri Nov 17 17:15:21 2000 Christopher Faylor <cgf@cygnus.com>
8186
8187 * Makefile.in: Use g++ to link so that libstdc++.a gets used. This is
8188 necessary for newer compilers.
8189
ef2007fd
CV
8190Wed Nov 9 2:19:00 2000 Corinna Vinschen <vinschen@redhat.com>
8191
8192 * desktop.cc: Include "ini.h" and "version.h".
8193 (make_passwd_group): Skip the function on 9x/ME boxes when an
8194 older version of Cygwin has been installed which doesn't
8195 support mkpasswd/mkgroup on 9x/ME.
8196 * install.cc: Move the `LOOP_PACKAGES' and `pi' macros to...
8197 * ini.h: ...here.
8198
277b4d56
CV
8199Wed Nov 8 17:10:00 2000 Corinna Vinschen <vinschen@redhat.com>
8200
8201 * desktop.cc (make_passwd_group): Don't exit when started
8202 on 9x/ME since mkpasswd/mkgroup are usable on 9x/ME now.
8203
f8a6415f
DD
8204Sun Nov 5 12:51:42 2000 Jason Tishler <jt@dothill.com>
8205
8206 * install.cc (do_install): Add call to set_cygdrive_flags to sync
8207 the mount modes.
8208 * mount.cc (set_cygdrive_flags): New function.
8209 (get_cygdrive_flags): Ditto.
8210 (default_cygdrive): Ditto.
8211 (set_cygdrive_flags): Ditto.
8212 * mount.h: Add prototype for set_cygdrive_flags.
8213
3b9077d4
DD
82142000-10-23 DJ Delorie <dj@redhat.com>
8215
8216 * ini.h: add source actions
8217 * fromcwd.cc: check for available sources
8218 * res.rc: add checkbox bitmaps
8219 * resource.h: ditto
8220 * check-*.bmp: new
8221 * choose.cc: add source column
8222 * download.cc: download sources if called for
8223 * install.cc: [un]install sources too
8224
1b1b33ac
DD
82252000-10-22 DJ Delorie <dj@redhat.com>
8226
8227 * choose.cc (build_labels): Don't skip TRUST_PREV completely; only
8228 ignore it wrt full_list if there's already a version installed.
8229 (do_choose): Sort the list.
8230 (package_sort): New.
8231
2a1a01e0
DD
82322000-10-12 DJ Delorie <dj@redhat.com>
8233
8234 * res.rc: Add more error strings.
8235 * resource.h: Ditto.
8236 * iniparse.y (new_package): re-initialize if needed.
8237 * download.cc (do_download): Keep track of errors; notify and
8238 allow retry.
8239 * install.cc (do_install): Ditto.
8240
1a9886fe
DD
82412000-10-05 DJ Delorie <dj@redhat.com>
8242
8243 * Makefile.in: fix %.cc rule
8244
40aef45e
DD
82452000-10-04 DJ Delorie <dj@redhat.com>
8246
8247 * desktop.cc: quote HOME and USER, don't . ./.profile
8248
8249 * choose.cc (build_labels): don't include in partial list just
8250 because there's a *previous* version available.
8251
8252 * install.cc (do_install): if installing from local directory with
8253 setup.ini and the file isn't found, look in "." also. Note errors.
8254
dd3f7f9b
DD
82552000-10-02 DJ Delorie <dj@redhat.com>
8256
8257 * ini.cc (do_ini): save setup.ini locally
8258
82592000-10-02 Chris Abbey <cabbey@bresnanlink.net>
8260
8261 * desktop.cc: quote escapes in prompt
8262
fee2a8d0
DD
82632000-10-02 Jason Tishler <jt@dothill.com>
8264
8265 * root.cc (is_admin): New function.
8266 (read_mount_table): Check for administrative priviledges and set
8267 installation scope as appropriate.
8268
a03db251
DD
82692000-09-28 DJ Delorie <dj@redhat.com>
8270
8271 * nio-ftp.cc (ftp_line): handle continuations more robustly
8272
b151e01e 82732000-09-14 Brian Keener <bkeener@thesoftwaresource.com>
0b758d4c
DD
8274
8275 * res.rc: increased the size of the site dialog (IDD_SITE) & the
8276 corresponding list box to provide for more URL's to be listed.
8277 Modified the position of the Back, Next and Cancel buttons to
8278 correspond to the new size of the dialog.
8279
d07591a3
DD
82802000-09-13 DJ Delorie <dj@redhat.com>
8281
8282 * install.cc (do_install): update disk fullness once per package
8283 to improve performance
8284
8285 * choose.cc (create_listview): call ReleaseDC
8286
89725f30
DD
8287Mon Sep 11 22:40 2000 Harold L Hunt II <harold@compasstechnologies.com>
8288
8289 * mkdir.cc: Create directories when ERROR_FILE_NOT_FOUND is
8290 returned, as it seems Samba 2.0.6+ returns this instead of
8291 ERROR_PATH_NOT_FOUND
88bcaf07 8292
6fbc690d
CF
8293Mon Sep 11 19:35:24 2000 Christopher Faylor <cgf@cygnus.com>
8294
8295 * site.cc (get_initial_list_idx): Don't default to saved URL if it
8296 refers to sources.
8297
13d27274
DD
82982000-09-07 DJ Delorie <dj@redhat.com>
8299
8300 * splash.cc: use version.h, not local decl
8301 * res.rc: add "old version" message
8302 * resource.h: ditto
8303 * version.h: new
8304 * fromcwd.cc (canonicalize_version): make global
89725f30
DD
8305 * iniparse.y: add setup-version support, fix bug in blank line
8306 handling
8307
13d27274
DD
8308 * inilex.l: add [exp] as alias for [test], add setup-version
8309 * Makefile.in (version.c): add setup-version tag
8310
8311 * desktop.cc (do_desktop): remove 1.1 version number
8312 (do_desktop_setup): ditto
8313
8314 * ini.cc (do_ini): zero out package list just in case we redo it.
8315
8cfbc487
DD
83162000-09-07 Jeffrey Juliano <juliano@cs.unc.edu>
8317
8318 * choose.cc (list_click): Check for nindexes==0; if so, return.
8319
c92e1307
DD
83202000-09-06 Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru>
8321
8322 * localdir.cc: new, local package directory selection dialog; cd
8323 into selected directory
8324 * Makefile.in (OBJS): add localdir.o
8325 * dialog.h: add prototype for do_local_dir
8326 * main.cc (WinMain): initialize local_dir to cwd; add call to
8327 do_local_dir
8328 * net.cc (dialog_cmd): make DO_LOCAL_DIR next dialog
8329 * source.cc (dialog_cmd): ditto
8330 * res.rc: add DO_LOCAL_DIR dialog; remove "current directory" from
8331 presented choices in IDD_SOURCE; add IDS_ERR_CHDIR error string
8332 * resource.h: defines for DO_LOCAL_DIR dialog; define IDS_ERR_CHDIR
8333 * root.cc (dialog_cmd): make DO_LOCAL_DIR previous dialog
8334 * state.h: add local_dir variable
8335
83362000-09-06 Brian Keener <bkeener@thesoftwaresource.com>
50225eae
DD
8337
8338 * desktop.cc: added logic to handle to the new dialog and to
8339 default the setting for the new checkboxes based on whether the
8340 desktop icon or start menu link already exist.
8341 (desktop_icon): correction to desktop directories for desktop icon
8342 creation. Additional logic added for Win95 which does not appear
8343 to have Common Directories so if Common selected and null uses
8344 normal directory.
8345 (start_menu): Additional logic added for Win95 which does not
8346 appear to have Common Directories so if Common selected and null
8347 uses normal directory.
8348 (do_desktop_setup): moved the saving of the icon, creation of the
8349 bat file, profile, passwd, Start Menu link and desktop shortcut to
8350 this method from do_desktop. Made the creation of the desktop
8351 icon and start menu link conditional on settings of new dialog
8352 created for desktop.
8353 * install.cc (do_install): changed next from IDD_S_DESKTOP to
8354 IDD_DESKTOP.
8355 * main.cc (WinMain): changed case IDD_S_DESKTOP to IDD_DESKTOP.
8356 * res.rc: added new resource to create a desktop dialog with 2
8357 checkboxes for creating the desktop icon and start menu link.
8358 * resource.h: changed IDD_S_DESKTOP to IDD_DESKTOP and added two
8359 new controls: IDC_ROOT_MENU and IDC_ROOT_DESKTOP for new dialog.
8360 * state.h: added root_menu and root_desktop for use in dialog.
8361
4a83b7b0
DD
83622000-08-29 DJ Delorie <dj@redhat.com>
8363
8364 * choose.cc (scan_downloaded_files): scan for existing files, so
8365 that the user only sees new downloads.
8366
8367 * nio-ie5.cc (NetIO_IE5): pre-check for wininet.dll, enable dial-up
8368 * site.cc (do_site): if we can't download the mirror list, go back
8369 to the net setup box to choose another transport.
8370 * autoload.c: add more functions
8371 * Makefile.in (ALL_DEP_LDLIBS): remove wininet.a
8372 * resource.h: add WININET message
8373
8374 * net.cc (do_net): no longer default to IE5
8375 * simpsock.h (class SimpleSocket): new, simplify socket operations
8376 * simpsock.cc: ditto
8377 * nio-http.h: new, for direct http protocol
8378 * nio-http.cc: ditto
8379 * nio-ftp.h: new, for direct http protocol
8380 * nio-ftp.cc: ditto
8381 * netio.cc (set_url): move initialization here to handle redirections
8382 (open): add direct http/ftp
8383 * netio.h (NetIO::set_url): new
8384
8385 * log.cc (log_save): create directory for log if needed
8386
8387 * hash.cc, hash.h: new
8388 * Makefile: add hash.o
8389 * choose.cc: enable "uninstall" option
8390 * download.cc: invert action test to accomodate uninstalling
8391 * ini.h: add ACTION_UNINSTALL
8392 * install.cc: add uninstall functionality
8393 * res.rc: make install tag changeable
8394 * resource.h: add uninstall resources
8395
8396 * res.rc: update mirror list URL
88bcaf07 8397
50f64a4b
DD
83982000-08-24 DJ Delorie <dj@redhat.com>
8399
89b1a15b
DD
8400 * log.cc, log.h: new files
8401 * Makefile.in (OBJS): add log.o
8402 * tar.cc: use exit_setup instead of exit
8403 * dialog.cc (fatal): use exit_setup instead of ExitProcess
8404 * msg.cc (fatal): ditto
8405 * install.cc (dialog_cmd): ditto
8406 * ini.cc (do_ini): ditto
8407 * main.cc (main): add logging
8408 * source.cc (do_source): ditto
8409 * root.cc (do_source): ditto
8410 * site.cc (do_site): ditto
8411 * other.cc (do_other): ditto
8412 * net.cc (do_net): ditto
8413 * choose.cc (do_choose): ditto
8414 * download.cc (do_download): ditto
8415 * install.cc (do_install): ditto
8416 * msg.cc (fatal): ditto
8417
8418 * res.rc: mark password boxes as *being* password boxes.
8419
58b12a06
MB
8420 * fromcwd.cc (canonicalize_version): use multiple buffers so that
8421 multiple calls won't use the same buffer.
50f64a4b
DD
8422 * choose.cc (create_listview): don't default to full list if no changes
8423 (base): return computed value, not temporary :-(
8424 (do_choose): don't use installed.db if we're only downloading.
8425
348860fa
DD
84262000-08-23 DJ Delorie <dj@redhat.com>
8427
8428 * nio-ie5.cc (NetIO_IE5): Fix authentication logic
8429 * nio-ie5.h (flush_io): new
8430 * netio.cc (load_dialog): note when we're initializing the dialog
8431 box, and ignore changes to the edit fields then.
8432
5f48f258
DD
84332000-08-21 DJ Delorie <dj@redhat.com>
8434
8435 * README: Update
8436
8437 * fromcwd.cc (found_file): don't remember the canonicalized version
8438
8439 * choose.cc (paint): print "nothing to do" message when list is empty.
8440 (build_labels): Use version "0.0" if no version is available.
8441 (create_listview): default to full list if nothing to install/update.
8442 (base): new, returns basename of file
8443 (read_installed_db): compare base names, not full paths
8444
713bbe5f
DD
84452000-08-11 DJ Delorie <dj@redhat.com>
8446
8447 * choose.cc: add new chooser dialog
8448 * fromcwd.cc: use IDD_CHOOSE
8449 * ini.cc: use IDD_CHOOSE
8450 * main.cc: use IDD_CHOOSE
8451 * ini.h: cosmetic changes
8452 * res.rc: add choose dialog, bitmaps
8453 * choose-spin.bmp: new
8454 * choose-rtarrow.bmp: new
8455 * resource.h: add choose dialog controls
8456
8457 * mount.cc: remove debug statement
88bcaf07 8458
2e9cbac5
DD
84592000-08-08 DJ Delorie <dj@redhat.com>
8460
8461 * Makefile.in (version.c): make version checking more robust
8462 * splash.cc (load_dialog): handle case where there's no version
8463
8507f105
DD
84642000-08-07 DJ Delorie <dj@redhat.com>
8465
8466 * (all): add cvsid tags
8467 * Makefile.in: generate version.c from ChangeLog, add splash.o
8468 * splash.o: new
8469 * res.rc: add splash screen
88bcaf07 8470
f5d0464b
DD
84712000-08-02 DJ Delorie <dj@redhat.com>
8472
4e8ff53f
DD
8473 * net.cc: remove proxy password code
8474 * res.rc: remove proxy user/pass from net, add auth dialogs
8475 * netio.cc,h: add sys/proxy auth methods
8476 * nio-ie5: use them, check for http status codes
8477 * state.h: add system authorization
8478
f5d0464b
DD
8479 * concat.cc (concat): canonicalize x:// to x:/ (exception to ://
8480 meaning an url)
8481
76cbfa85
DD
84822000-08-02 Norman Vine <nhv@yahoo,com>
8483
8484 * msg.cc (mbox): added MB_TOPMOST to MessageBox type flags
8485
e92c4436
DD
84862000-08-01 DJ Delorie <dj@redhat.com>
8487
bf74c544
DD
8488 * postinstall.cc (each): don't rename files we ignore
8489 (do_postinstall): set CYGWINROOT to root_dir, chdir there
8490
e92c4436
DD
8491 * desktop.cc: have /etc/profile call ~/.profile and ~/.bashrc
8492
a6100861
DD
84932000-07-31 DJ Delorie <dj@redhat.com>
8494
8495 * desktop.cc: reverse PATH so /usr/bin precedes /bin
8496
b11b49f3
DD
84972000-07-18 DJ Delorie <dj@redhat.com>
8498
a99bdfd8
DD
8499 * autoload.c: new, autoload dlls that might not be available.
8500 * Makefile.in (OBJS): add autoload.o
8501
8502 * res.rc: rewrite root options (text/binary, system/user) to be
8503 more obvious.
8504
b5b282c4
DD
8505 * site.cc (get_site_list): trim displayed URL, sort by domain
8506
8507 * net.cc (do_net): make IE5 default to checked, for now
8508
b11b49f3
DD
8509 * choose.cc (do_choose): sort packages correctly
8510 * ini.cc (do_ini): handle parse errors more gracefully
8511 (yyerror): ditto
8512 (fprintf): line buffer output
b5b282c4 8513 (do_ini): if we can't load setup.ini, go back to the site list.
b11b49f3
DD
8514 * ini.h: add "unknown" trust level
8515 * inilex.l: absorb unknown trust levels and key/value pairs,
8516 add line number logic
8517 * iniparse.y: handle parse errors more gracefully.
8518 * install.cc: skip packages with no valid install entry
8519
1fd6d0a2
DD
85202000-07-17 DJ Delorie <dj@cygnus.com>
8521
8522 * coding standards fixups, many files
8523 * mkdir.cc: warn about deletions *before* deleting them
8524
ed3e8b9b
DD
85252000-07-17 Jeff Juliano <juliano@cs.unc.edu>
8526
8527 * res.rc (IDD_OTHER_URL): reorder to give default focus to entry
8528
8529 * other.cc (dialog_cmd): save download site URL
8530 * site.cc (get_root_dir): new
8531 (save_mirror_site): new
8532 (dialog_cmd): save download site URL
8533 (get_site_list): make list big enough to add prev site
8534 (get_initial_list_idx): new, read last-used URL from file and
8535 append it to site_list
8536 (do_site): call get_initial_list_idx
8537
8538 * concat.cc (concat): avoid segfault when first parm is null
88bcaf07 8539
f57c332f
DD
85402000-07-13 DJ Delorie <dj@cygnus.com>
8541
8542 * postinstall.cc: new
8543 * Makefile.in: add postinstall.o
8544 * concat.h: add backslash ()
8545 * concat.cc: ditto
8546 * desktop.cc (etc_profile): don't do postinstall
8547 (backslash): moved to concat.cc
8548 (uexists): new
8549 (make_postinstall_script): run directly
8550 (do_desktop): chain to do_postinstall
8551 * dialog.h: add exit_msg, do_postinstall
8552 * download.cc: use exit_msg
8553 * install.cc: ditto
8554 * main.cc: add postinstall, exit_msg
8555 * resource.h: add postinstall
d6cda811 8556 * README: add more to-do items
f57c332f 8557
3a8e3956
DD
85582000-07-12 DJ Delorie <dj@cygnus.com>
8559
8560 * desktop.cc: add /etc/postinstall/ support
1a18aed7 8561 * install.cc: add more "standard" directories
3a8e3956 8562
e0c3d906
DD
85632000-07-11 DJ Delorie <dj@cygnus.com>
8564
8565 * desktop.cc: create /etc/profile
ad09bcd9
DD
8566 * desktop.cc: fix include syntax
8567 * Makefile.in: add auto-dependencies
24e259bb
DD
8568 * root.cc: support system vs user
8569 * desktop.cc: ditto
8570 * mount.h: ditto
8571 * mount.cc: ditto
8572 * install.cc: ditto
8573 * res.rc: ditto
8574 * resource.h: ditto
8575 * state.h: ditto
84d58d4c 8576 * desktop.cc: make sure we use backslashes, not slashes.
bf1d5889
DD
8577 * desktop.cc: don't set PATH in cygwin.bat, create /etc/passwd
8578 * geturl.cc: change math for percentage to avoid overflow
8579 * install.cc: ditto
8580 * download.cc: post "download complete" message.
8581 * root.cc: pre-fill in defaults if needed, don't start
8582 browse at root_dir unless it's set.
a3f48e18 8583 * desktop.cc: quote $PATH in case it has spaces in it
88bcaf07 8584
904d24fe
DD
85852000-07-10 DJ Delorie <dj@cygnus.com>
8586
8587 * Makefile.in: add desktop.o and mklink2.o
8588 * dialog.h: add do_desktop
8589 * install.cc: create standard directories, call do_desktop
8590 * res.rc: add cygwin.ico as a file also
8591 * desktop.cc: new, do shortcuts, batch files, and icons
8592 * mklink2.c: new, for COM
1ab805b8 8593 * README: update to-do list
904d24fe 8594
04d6e06b
DD
85952000-07-10 DJ Delorie <dj@cygnus.com>
8596
8597 * ini.cc (do_ini): don't worry about timestamps if we're not
88bcaf07 8598 actually installing.
04d6e06b 8599
5601a13d
DD
86002000-07-09 DJ Delorie <dj@cygnus.com>
8601
8602 * Makefile.in: add -I$(srcdir) for ini.h
8603
23c9e63c
DD
86042000-07-06 DJ Delorie <dj@cygnus.com>
8605
8606 * Replace everything with a new GUI version
8607 * zlib/gzio.c: add gzctell() for progress displays
8608
86092000-06-22 DJ Delorie <dj@cygnus.com>
8610
8611 * setup.c (tarx): re-add call to write_pkg()
8612
aa32874b
DD
86132000-06-07 DJ Delorie <dj@cygnus.com>
8614
8615 * cygcalls.c: new, call cygwin1.dll functions directly
8616 * cygcalls.h: header for same
8617 * Makefile.in: add cygcalls.[ch], remove mount/cygpath/umount
8618 exes, fix cinstall.rc dependencies.
8619 * path.c: remove unneeded code
8620 * setup.c: use cygcalls instead of xcreate_process.
8621 uncompress embedded files with zlib
8622 add "-d" for "download only"
8623 add "-h" for help
8624 postpone mount changes until very end
8625 add download progress indicators
8626 pack multi-column listings more
8627 auto-delete temp files
8628 customize banner message according to options
8629 prompt user for text/binary mounts
8630 add warnings about empty setup directory, root installs, etc
8631
99d1bf2d
DD
86322000-05-24 DJ Delorie <dj@cygnus.com>
8633
8634 * tar.c: New file; built-in tar using zlib.
8635 * tar.h: New file; header for same.
8636 * ctar.c: New file; test program for same.
8637 * Makefile.in: add built-in tar, remove tar.exe and gzip.exe
58b12a06
MB
8638 * path.c (pathcat): convert slashes and canonicalize, instead of
8639 aborting
99d1bf2d
DD
8640 * setup.c (tarx): add support for built-in tar
8641 (main): accept unix-style slashes, check root dir for drive letters,
58b12a06
MB
8642 warn about installing in /, make sure cwd is empty for internet
8643 installs, defer mounts to end of install, support built-in tar.
99d1bf2d 8644
55650749
CF
8645Fri May 19 23:44:37 2000 Christopher Faylor <cgf@cygnus.com>
8646
8647 Fix compiler warnings throughout.
8648 * pkg.c (init_pkgs): Make static 'stuff' global_pkgstuff for use in
8649 get_pkg_stuff.
8650 * setup.c: Make 'root' global.
8651 (istargz): Return pointer to "stem" of matched .tar.gz file.
8652 (tarx): Special case cygwin-20000301 to == cygwin-1.1.0.tar.gz. Remove
8653 bogus check_for_installed check.
8654 (recurse_dirs): Add preliminary support for .bat file execution.
8655 (create_uninstall): Eliminate unneeded parameter.
8656 (do_start_menu): Ditto.
8657 (mkmount): Ditto.
8658 (get_pkg_stuff): Ditto. Check for currently installed cygwin by
8659 scanning for the version number. Eliminate unneeded argument to
8660 create_uninstall.
8661 (getdownloadsource): Add 'name' to list of names rather than url.
8662 (main): Eliminate unneeded argument in get_pkg_stuff. Eliminate
8663 unneeded argument in mkmount and do_start_menu.
8664
f4dda8f0
DD
86652000-05-18 DJ Delorie <dj@cygnus.com>
8666
8667 * setup.c (optionprompt): allow multi-column, clean up message
8668 about more options, be more robust about user input.
8669 (getdownloadsource): make the mirror URL a macro.
8670 (main): do mounts after done prompting user.
8671
62844d84
CF
8672Tue May 2 00:56:41 2000 Christopher Faylor <cgf@cygnus.com>
8673
8674 * setup.c (cleanup): Inverse order of deletion stands a better chance
8675 of deleting cygpath.exe. Still seems to suffer from occasional races,
8676 though.
8677 (cleanup_on_signal): Perform convoluted dance to accomodate win95 and
8678 w2k.
8679 (output_file): Defend against an unlikely handle leak.
8680 (main): Don't set up signal handling until we have something special to
8681 do.
8682
ad6749c8
CF
8683Mon May 1 17:56:32 2000 Christopher Faylor <cgf@cygnus.com>
8684
8685 * path.c (kill_cygpath): Delete function.
8686 (exit_cygpath): Make more defensive so that it can be called at any
8687 time.
8688 (cygpath_pipe): Don't set up signal here. Do it in main().
8689 * setup.c (istargz): New function.
8690 (recurse_dirs): Look for *.gz pattern rather than *tar.gz since *tar.gz
8691 inexplicably fails on samba mounted partitions. Use istargz to match
8692 tar.gz tail.
8693 (processdirlisting) Use istargz to match tar.gz tail.
8694 (cleanup): Renamed from filedel.
8695 (cleanup_on_signal): New function. Called on CTRL-C.
8696 (main): Record handle of main thread so that it can be suspended when
8697 CTRL-C occurs. Set up cleanup_on_signal signal handler.
8698
460cf7b6
CF
8699Mon May 1 11:05:07 2000 Christopher Faylor <cgf@cygnus.com>
8700
8701 * setup.c (do_start_menu): Don't concatenate paths to already built
8702 paths.
8703
9e76799c
CF
8704Sun Apr 30 22:37:34 2000 Christopher Faylor <cgf@cygnus.com>
8705
8706 * path.c (exit_cygpath): Wait for subprocess to exit before returning.
8707 (cygpath_pipe): Don't call exit_cygpath. Let main atexit routine do
8708 that.
8709 * pkg.c (init_pkgs): Accept root argument. Make registry key "cygwin
8710 root"-specific.
8711 * setup.c (filedel): Call exit_cygpath here so that we can be assured
8712 that cygpath subprocess has died. This allows us to delete cygpath.exe
8713 and cygwin1.dll.
8714 (optionprompt): Initialize response to -1 so that second screen of
8715 mirrors will appear.
8716 (get_pkg_stuff): Don't attempt to use HKCLU. Pass root to init_pkgs.
8717 * setup.h: Reflect init_pkgs prototype change.
8718
2cf65e6e
CF
8719Sat Apr 29 23:53:30 2000 Christopher Faylor <cgf@cygnus.com>
8720
8721 * pkg.c (init_pkgs): Accept an argument to control what root registry
8722 key should be used.
8723 * setup.c (get_pkg_stuff): Use HKCLU registry key if default fails.
8724 * setup.h: Reflect init_pkgs prototype change.
8725
8726Sat Apr 29 23:27:14 2000 Christopher Faylor <cgf@cygnus.com>
8727
8728 * error.c (winerror): Respond to gcc warning.
8729 * path.c (cygpath_pipe): Ditto.
8730 * setup.c (filedel): Call sa_cleanup on deleteme.
8731 (create_shortcut): Coerce argument to eliminate compiler warning.
8732 (tarx): Use installed version of cygwin1.dll, overriding tar file name.
8733 (refmatches): New function. Tests if ref is contained in a list of
8734 packages to install.
8735 (filematches): New function. Tests if filename matches one of a list
8736 of packages to install.
8737 (recurse_dirs): Accept list of packages to install. Generalize tar.gz
8738 test to accomodate _tar.gz.
8739 (prompt): Ensure that stdout is flushed prior to asking for input.
8740 (findhref): Initialize variables to quiet a compiler warning.
8741 (processdirlisting): Accept list of packages to install. Special case
8742 cygwin tar file version number.
8743 (downloaddir): Accept list of packages to install.
8744 (downloadfrom): Ditto.
8745 (create_uninstall): Eliminate unneeded variables. Quote arguments to
8746 regtool.
8747 (do_start_menu): Don't create uninstall bat file if updating or user
8748 specified a list of packages.
8749 (mkmount): Eliminate unneeded variables.
8750 (get_pkg_stuff): New function. Checks for previous unversioned
8751 installation.
8752 (main): Accept -u and -f options and package names on the command line.
8753 Use get_pkg_stuff to initialize package information. Umount /etc.
8754 Call recurse_dirs and downloadfrom with list of package to install.
8755 Ensure that all /usr/local directories are created. Output
8756 installation time to setup.log.
8757 * setup.h: Add some prototypes.
8758 * xsystem.c (xcreate_process): Eliminate unneeded variable.
8759
4cf88dd9
CF
8760Sat Apr 29 12:43:08 2000 Christopher Faylor <cgf@cygnus.com>
8761
8762 * setup.c (optionprompt): Don't overlap display of already seen options
8763 on next page.
8764 (geturl): Print name of site which we're connecting to rather than "ftp
8765 site".
8766 (processdirlisting): Avoid URLs that contain a /. or ./ . Is this
8767 test too simplistic?
8768 (do_start_menu): Use pathcat to build path to <root>\bin to avoid
8769 problems when user chooses x:\ as their root.
8770 (main): For now, default to "non-update" mode. Allow -u option to
8771 signify an update.
8772
36591a07
CF
8773Sat Apr 29 00:26:06 2000 Christopher Faylor <cgf@cygnus.com>
8774
8775 * pkg.c: New file.
8776 * setup.c (tarx): Skip already installed or older packages. Report
8777 when a package has been updated.
8778 (processdirlisting): Skip already installed or older packages.
8779 (main): Detect -f option for forced installation. Initialize pkg stuff
8780 if appropriate.
8781 * setup.h: Add pkg definitions.
8782
c298ea4a
CF
8783Thu Apr 27 14:21:30 2000 Christopher Faylor <cgf@cygnus.com>
8784
8785 * setup.c (findhref): Return NULL on empty string. Eat any trailing
8786 ";something".
8787 (processdirlisting): Attempt to limit recursively processing the same
8788 directory.
8789
f4cafa7e
CF
8790Thu Apr 27 11:42:23 2000 Christopher Faylor <cgf@cygnus.com>
8791
8792 * setup.c (filedel): New function.
8793 (output_file): Keep track of files extracted from setup.exe for
8794 subsequent deletion.
8795 (tarx): Close process handle of child tar process or suffer handle
8796 leak.
8797 (getdownloadsource): Close mirror file so that it can be unlinked.
8798 (processdirlisting): Return total number of files extracted.
8799 (main): Initialize array of files to delete. Ensure that files are
8800 closed on exit. Make the directory that setup.exe is started from ==
8801 the directory where temporary files are placed. Issue an error if no
8802 files were found to download.
8803 * xsystem.c (xcreate_process): Close the thread handle. Close the
8804 process handle if we waited for it to exit.
8805
cd475210
CF
8806Thu Apr 27 09:54:19 2000 Christopher Faylor <cgf@cygnus.com>
8807
8808 * setup.c (main): Change version number output.
8809
7dff5e71
CF
8810Thu Apr 27 09:23:17 2000 Christopher Faylor <cgf@cygnus.com>
8811
8812 * setup.c (tarx): Use full path name to tar executable.
8813 (main): Build full pathname to tar executable. Create /usr/local/etc
8814 by default.
8815
99437fdb
CF
8816Wed Apr 26 22:16:57 2000 Christopher Faylor <cgf@cygnus.com>
8817
8818 * setup.c (findhref): Change method for scanning for href= to choose
8819 the last one on the line. This is still not foolproof and probably
8820 will need to be changed eventually. Don't abort if no "size" field is
8821 evident.
8822 (processdirlisting): Fix boolean algebra.
8823
0f562d55
CF
8824Wed Apr 26 01:10:39 2000 Christopher Faylor <cgf@cygnus.com>
8825
8826 * main.c (tarx): Add some code for future task of unmounting
8827 directories encountered in tar file.
8828
4356382d
CF
8829Sat Apr 22 16:37:03 2000 Christopher Faylor <cgf@cygnus.com>
8830
8831 * setup.c (findhref): Decode file size, when appropriate.
8832 (needfile): New function. Returns 1 when file should be
8833 downloaded.
8834 (processdirlisting): Always download if file size does not
8835 match. Prompt when download fails for some reason.
8836 (getdownloadsource): Accomodate findhref argument changes.
8837
6ab1ce6c
CF
8838Sat Apr 22 15:13:42 2000 Christopher Faylor <cgf@cygnus.com>
8839
8840 Throughout, use global session handle rather than reinitializing for
8841 each connect. Don't pass session as an argument to setup.c functions.
8842 * setup.c (geturl): Only issue "Connecting to.." message when using
8843 http or first time for ftp since subsequent connections will be fast.
8844 (processdirlisting): Allocate space for "N" when user has specified
8845 "N"ever option so that it can be subsequently freed.
8846 (main): Abort if we can't get the list of mirrors.
8847
37ee316b
CF
8848Thu Apr 20 16:41:42 2000 Christopher Faylor <cgf@cygnus.com>
8849
8850 * setup.c (main): Umount /bin and /lib.
8851
a59fb4fa
CF
8852Wed Apr 19 13:34:44 2000 Christopher Faylor <cgf@cygnus.com>
8853
8854 * setup.c (main): Create an empty /var/run/utmp.
8855
75f4b861
CF
8856Tue Apr 18 19:16:56 2000 Christopher Faylor <cgf@cygnus.com>
8857
8858 * Makefile.in: Add umount to list of files to include in setup.exe.
8859 * setup.c (xumount): New function for unmounting directories.
8860 (main): Unmount /usr.
8861 (mkmount): Unmount "unix directory" before trying to figure out where
8862 to create the directory.
8863
d4a66789
CF
8864Tue Apr 18 17:28:55 2000 Christopher Faylor <cgf@cygnus.com>
8865
8866 * setup.c (mkmount): Use xcreate_process to start mount process,
8867 avoiding the shell.
8868 (main): Don't do buffering on stdout or prompts won't be displayed
8869 correctly if running in a cygwin shell with CYGWIN=tty.
8870
a6c3982d
CF
8871Tue Apr 18 15:35:19 2000 Christopher Faylor <cgf@cygnus.com>
8872
8873 * setup.c (main): Remove the CYGWIN environment variable before
8874 starting any cygwin programs.
8875
0ffd5e3b
CF
8876Mon Apr 17 19:20:52 2000 Vadim Egorov <egorovv@mailandnews.com>
8877
8878 * setup.c (geturl): Use alternative method for finding filename part of
8879 a URL.
8880 (processdirlisting): Accomodate strange output from non-MS ftp proxy.
8881 (downloaddir): Unlink file containing dir listing.
8882 (downloadfrom): Ditto.
8883
3e54bcf9
CF
8884Mon Apr 17 00:00:49 2000 Christopher Faylor <cgf@cygnus.com>
8885
8886 * setup.c (main): Disallow running setup.exe from the "root".
8887
005b73c4
CF
8888Sun Apr 16 18:50:58 2000 Christopher Faylor <cgf@cygnus.com>
8889
2cf65e6e 8890 Use "warning" function, where appropriate, to output warnings.
005b73c4
CF
8891 * setup.c (warning): New function -- outputs warning to console and log
8892 file.
8893 (tarx): Fix index used to reset file protection.
8894 (main): Open the log file earlier so that more stuff can be sent to it.
8895
36dc5fc8
CF
8896Sat Apr 15 20:05:33 2000 Christopher Faylor <cgf@cygnus.com>
8897
8898 * setup.c (processdirlisting): Make "N" option a little less aggressive.
8899
c73320de
CF
8900Fri Apr 14 11:11:29 2000 Christopher Faylor <cgf@cygnus.com>
8901
8902 * setup.c (tarx): Wait to after tar has completed to reset protections
8903 or suffer races with tar process.
8904
68cdfc92
CF
8905Thu Apr 13 12:51:19 2000 Christopher Faylor <cgf@cygnus.com>
8906
8907 * Makefile.in: Eliminate duplicate -nostdinc from CFLAGS.
8908 * setup.c (create_uninstall): Create the uninstall .bat file in the
8909 "root" so that we can remove the /bin directory. Add bin\cygwin.bat to
8910 list of files to be deleted. Fix directory detection for determining
8911 when to use 'rmdir'.
8912 (do_start_menu): Add /usr/local/bin to the path.
8913 (main): Add slop to files.array allocation so that we don't have to
8914 worry about reallocating the array when it grows too large when doing
8915 some trivial "pushes". Add /tmp and /usr/local/{bin,lib} to list of
8916 files.
8917
35d18861
CF
8918Thu Apr 13 01:59:44 2000 Christopher Faylor <cgf@cygnus.com>
8919
8920 * setup.c (processdirlisting): Fix handling of "A" for "A"lways
8921 download.
8922
20904de1
CF
8923Thu Apr 13 01:11:45 2000 Christopher Faylor <cgf@cygnus.com>
8924
8925 * path.c (kill_cygpath): New cleanup function.
8926 (exit_cygpath): New cleanup function.
8927 (cygpath_pipe): New function. Sets up cygpath in the background for
8928 translating filenames.
8929 (pathcvt): Use background cygpath for file translation.
8930 * setup.c (tarx): New function. Called to extract tar files, capture
8931 logging output, and translate it to Windows format.
8932 (recurse_dirs): Use 'tarx' function to extract files.
8933 (create_uninstall): Use file list built up by tarx rather than reading
8934 the log file.
8935 (mkmount): Add ability to mount root.
8936 (main): Track elapsed install time. Mount root.
8937 * starry.h: Add index field to strarry for tracking of tarx's usage of
8938 this structure.
8939 * xsystem.c (xcreate_process): Return proces handle when not waiting.
8940
c1246750
CF
8941Mon Apr 10 22:44:56 2000 Christopher Faylor <cgf@cygnus.com>
8942
8943 * path.c: New file.
8944 (pathfp): New function. Preliminary work for new -f cygpath
8945 functionality.
8946 * Makefile.in: Add new file.
8947 (pathcvt): Move to new file.
8948 (dtoupath): Ditto.
8949 (utodpath): Ditto.
8950 (pathcat): Ditto.
8951 * setup.c (processdirlisting): Always open file in text mode.
8952 (create_uninstall): Ditto.
8953 (getdownloadsource): Ditto.
8954 (main): Ditto.
8955
4b40edd0
CF
8956Mon Apr 10 20:33:40 2000 Christopher Faylor <cgf@cygnus.com>
8957
8958 * xsystem.c: New file.
8959 * Makefile.in: Accomodate new file.
8960 * setup.c (xsystem): Move to new file.
8961 (recurse_dirs): Accept handle to output log file. Don't use ">"
8962 redirection to trap tar output. Use supplied handle instead.
8963 (create_uninstall): Accept FILE pointer to opened log file. Don't
8964 unlink log file here.
8965 (do_start_menu): Accept FILE pointer to pass to create_uninstall.
8966 (main): Open log file here and pass it to various functions. Unlink
8967 when done.
8968
6f8e3b45
CF
8969Mon Apr 10 17:15:52 2000 Christopher Faylor <cgf@cygnus.com>
8970
8971 Change occurrences of .usr.bin to .bin throughout.
8972 * setup.c (geturl): Increase number of retries to 20. Let user know
8973 what's going on during long connects.
8974 (processdirlisting): Accept "A"lways and "N"ever as update options.
8975 (create_uninstall): Load cygwin1.dll from the current directory rather
8976 than \bin.
8977 (main): Add some expository text.
8978
2a907b70
CF
8979Sun Apr 9 20:59:15 2000 Christopher Faylor <cgf@cygnus.com>
8980
8981 * Makefile.in: Change method for compressing cygwin1.dll to avoid
8982 creating a cygwin1.dll in the current directory. Ensure the addition
8983 of -nostdinc to MINGW_CFLAGS.
8984
c4285a3c
CF
8985Sun Apr 9 02:15:47 2000 Christopher Faylor <cgf@cygnus.com>
8986
8987 * Makefile.in: Augment clean target.
8988
ea615d51
RP
8989Fri Apr 7 17:04:02 Ron Parker <rdparker@sourceware.cygnus.com>
8990
8991 * README: Added info about non-working mingw implementation
c1246750 8992 * gzip.exe.gz: Replace with a version from the same build as the other
ea615d51 8993 tools.
c1246750 8994 * tar.exe.gz: Replace with a version from the same build as the other
ea615d51 8995 tools.
c1246750 8996 * mount.exe.gz: Add to repository until, mingw can build setup.
ea615d51
RP
8997 * cygpath.exe.gz: ditto
8998 * cygwin1.dll.gz: ditto
c1246750
CF
8999 * setup.c: Overwrite /bin and /lib mounts. Generate working shortcut
9000 for Win9x. Display only a screenfull of options at a time. Call all
9001 tools with an absolute path.
9002 * setup.dsp: Restore the carriage returns, MS Developer Studio needs
9003 them.
ea615d51
RP
9004 * setup.dsw: ditto
9005 * zlib.dsw: ditto
9006
51954e74
CF
9007Thu Apr 6 19:15:27 2000 Christopher Faylor <cgf@cygnus.com>
9008
c1246750
CF
9009 * Makefile.in: Add "-nostdinc" to regular CFLAGS. Add target to grab
9010 cygwin1.dll from ../cygwin subdirectory.
51954e74
CF
9011 * gzip.exe.gz: Update.
9012 * tar.exe.gz: Update.
9013
7b777418
CF
9014Wed Apr 5 10:52:08 2000 Christopher Faylor <cgf@cygnus.com>
9015
9016 * Makefile.in: Use ZLIB variable as a target.
9017
4306b490
CF
9018Sat Apr 1 22:49:09 2000 Christopher Faylor <cgf@cygnus.com>
9019
5e7eb909
CF
9020 * Makefile.in: Eliminate traces of cygwinisms. Don't link with
9021 libmsvcrt.a. It's unneeded. Build .rc file on the fly from various
9022 sources.
4306b490
CF
9023 * configure.in: Locate correct objcopy.
9024 * configure: Regenerate.
9025
739457f4
CF
9026Sat Apr 1 20:48:09 2000 Christopher Faylor <cgf@cygnus.com>
9027
9028 * Makefile.in: New file.
9029 * configure.in: New file.
9030 * configure: New file.
9031 * zlib/Makefile.am: New file.
9032 * zlib/configure.in: New file.
9033 * zlib/aclocal.m4: New file.
9034 * zlib/acinclude.m4: New file.
9035 * zlib/configure: Regenerate from configure.in.
9036 * zlib/Makefile.in: Regenerate from Makefile.am
8507f105
DD
9037
9038%%% $Id$
9039$Revision$
This page took 1.168165 seconds and 5 git commands to generate.