1 2005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3 * script.cc (Script::isAScript): Fix string comparison.
5 2005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
7 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Reconnect on FTP timeout.
9 2005-09-11 Masayuki FUJII <boochang@m4.kcn.ne.jp>
11 * package_meta.cc (packagemeta::ScanDownloadedFiles): Don't use an
12 invalid iterator. Fix whitespace.
14 2005-09-09 Brian Dessent <brian@dessent.net>
16 * CHANGES: Document recent updates.
17 * choose.cc (ChooserPage::OnInit): Add new tooltip.
18 * res.rc (IDD_CHOOSE): Remove 'administrative' from description.
19 (IDS_HIDEOBS_TOOLTIP): Add new string for tooltip.
20 * resource.h (IDS_HIDEOBS_TOOLTIP): Define.
21 * window.cc (Window::ActivateTooltips): Fix whitespace. Set tooltip
24 2005-09-09 Igor Pechtchanski <pechtcha@cs.nyu.edu>
26 * PickView.cc (PickView::paint): Set background mode to transparent.
27 * PickCategoryLine.cc (PickCategoryLine::paint): Use bitwise AND to
29 * PickPackageLine.cc (PickPackageLine::paint): Ditto.
31 2005-09-01 Brian Dessent <brian@dessent.net>
33 * package_meta.cc (packagemeta::uninstall): Remove support for
34 undocumented and dangerous postremove script.
36 2005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
38 * script.cc (run): Change to return the exit code or negative error.
40 (try_run_script): Receive both filename and extension and run only
41 one script. Also return the exit code.
42 * script.h (try_run_script): Change signature.
44 * postinstall.cc (RunScript::operator()): Change to return the exit
45 code or negative error.
46 * install.cc (Installer::preremoveOne): Pass extension to
49 2005-09-01 Eric Blake <ebb9@byu.net>
51 * script.cc (shells): Use /bin/bash, not sh, to allow upgrades to
54 2005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
56 * PickView.h (PickView::size_col): New instance variable.
57 * PickView.cc (pkg_headers, cat_headers): Add size column.
58 (PickView::set_headers): Initialize size_col.
59 (PickView::init_headers): Include width of size column.
60 * PickPackageLine.cc (PickPackageLine::paint): Handle size_col.
61 * String++.cc (format_1000s): New function.
62 * String++.h (format_1000s): Declare new function.
64 2005-09-01 Brian Dessent <brian@dessent.net>
66 * Makefile.am (BASECXXFLAGS): Add -Wno-uninitialized to work around
67 spurious warnings with gcc 3.4.4.
69 2005-05-22 Brian Dessent <brian@dessent.net>
71 * res.rc (IDD_CHOOSE): Change description to include administrative
72 packages in addition to obsolete.
74 2005-05-21 Brian Dessent <brian@dessent.net>
76 * prereq.cc: New file.
78 * tree-minus.bmp: Ditto.
79 * tree-plus.bmp: Ditto.
80 * Makefile.am: Add prereq.cc and prereq.h to build.
81 * PickCategoryLine.cc (PickCategoryLine::paint): Add new parameter and
82 refactor. Use bitmap for '+' and '-' indicators. Draw package lines
83 column-wise for better drawing efficiency.
84 (PickCategoryLine::click): Use previously calculated x value.
85 * PickCategoryLine.h (PickCategoryLine::paint): Update prototype. Add
87 * PickLine.h (PickLine:paint): Update prototype.
88 * PickPackageLine.cc (PickPackageLine::DrawCheck): Remove.
89 (PickPackageLine::DrawIcon): New function.
90 (PickPackageLine::paint): Add parameter. Refactor completely for more
92 * PickPackageLine.h (PickPackageLine::DrawIcon): Add prototype.
93 (PickPackageLine::paint): Update prototype.
94 (PickPackageLine::DrawCheck): Remove.
95 * PickView.cc (pkg_headers): Remove unused 'slen' field, add new
96 'needs_clip' field to signify if clipping is necessary for this column.
97 (PickView::note_width): Fold long line. Refactor slightly for
99 (PickView::set_view_mode): Remove.
100 (PickView::cycleViewMode): New function.
101 (PickView::setViewMode): Refactor completely. Incorporate functionality
102 of clear_view() here instead. Simplify package selection into a single
103 'for' loop rather than repeating code for each type.
104 (isObsolete): New function, with second overloaded version.
105 (PickView::setObsolete): New function.
106 (PickView::insert_pkg): Do not show obsolete packages. Move
107 declaration of 'db' lower. Fix whitespace.
108 (PickView::insert_category): Do not show obsolete packages.
109 (PickView::clear_view): Remove. Moved logic into 'setViewMode'.
110 (PickView::scroll): Add additional parameter 'howmany' with default
111 value of 1. Scroll by 'howmany' lines for SB_LINEDOWN and SB_LINEUP.
112 (NUM_CATEGORY_COL_WIDTH): Define.
113 (PickView::init_headers): Fix whitespace. Add comments. Ignore
114 obsolete packages in width calculations. Add functionality to size
115 'Category' column so that at least NUM_CATEGORY_COL_WIDTH categories
116 are displayed for every package. Ensure that 'new_col' takes into
117 account all possible labels.
118 (PickView::PickView): Initialize showObsolete to false.
119 (PickView::init): Remove unused bitmap bm_rtarrow. Add new bitmaps
120 bm_treeplus and bm_treeminus. Use a macro for better readability.
121 Fix whitespace formatting. Remove header computation from here, call
123 (PickView::registerWindowClass): Remove unnecessary background brush.
124 (PickView::WindowProc): Add support for WM_MOUSEWHEEL message
125 processing. Fix indentation. Reformat for readability.
126 (PickView::paint): Get the update region before calling BeginPaint.
127 Fill the update region with the default colors. Do not do clipping
128 here. Pass update region to the PickLine paint function instead.
129 Free the update region when finished.
130 (PickView::Create): Fix indentation.
131 (PickView::defaultTrust): Ditto.
132 (PickView::refresh): Add column recalculation logic here.
133 * PickView.h: Fix indentation.
134 (RTARROW_WIDTH): Remove unused define.
135 (NEW_COL_SIZE_SLOP): Ditto.
136 (TREE_INDENT): Define.
137 (PickView::get_view_mode): Remove.
138 (PickView::set_view_mode): Rename to setViewMode for consistency.
139 (PickView::cycleViewMode): Add new function.
140 (PickView::setObsolete): Ditto.
141 (PickView::clear_view): Remove.
142 (PickView::bm_treeplus): Define new member.
143 (PickView::bm_treeminus): Ditto.
144 (PickView::scroll): Add parameter.
145 (PickView::Header::slen): Remove unused member.
146 (PickView::Header::needs_clip): Define new member.
147 (PickView::showObsolete): Ditto.
148 (isObsolete): Add prototype, and for overloaded version as well.
149 * choose.cc: Add include.
150 (ChooserControlsInfo): Allow new checkbox to be resized.
151 (ChooserPage::OnInit): Start dialog with 'Hide obsolete' checked.
152 (ChooserPage::OnNext): Call the dependency checker, act accordingly.
153 (ChooserPage::changeTrust): Notify dependency checker of current trust
154 level when it changes.
155 (ChooserPage::OnMessageCmd): Just call cycleViewMode instead when
156 changing the view. Update the chooser when the user toggles the
157 'hide obsolete' checkbox.
158 (ChooserPage::OnMouseWheel): New function. Pass mouse wheel message
160 * choose.h (OnMouseWheel): Add prototype.
161 * main.cc: Add include.
162 (main): Define and initialize the PrereqPage object. Add it into
163 the property sheet list.
164 * PropPage.cc (PropertyPage::DialogProc): Add support for WM_MOUSEWHEEL
165 message processing in derived classes.
166 (PropertyPage::OnMouseWheel): New function.
167 * PropPage.h (PropertyPage::OnMouseWheel): Add prototype.
168 * res.rc (IDD_LOCAL_DIR): Shorten edit box so that pushbutton is not
170 (IDD_SITE): Provide static text with an ID so that it can be resized
171 properly. Move pushbutton slightly to right so that it doesn't crowd
173 (IDD_SPLASH): Change copyright displayed on spash screen to be generic
174 since the actual list of contributors is long.
175 (IDD_CHOOSE): Add checkbox. Resize other controls to accomodate.
176 (IDD_PREREQ): New dialog.
177 (SPIN): Delete duplicated bitmap resource.
178 (IDB_RTARROW): Remove unused bitmap resource.
179 (IDB_TREE_PLUS): Add.
180 (IDB_TREE_MINUS): Ditto.
181 (IDS_TRUSTPREV_TOOLTIP): Revise wording to be more concise.
182 (IDS_TRUSTCURR_TOOLTIP): Ditto.
183 (IDS_TRUSTEXP_TOOLTIP): Ditto.
184 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
185 * resource.h (IDD_PREREQ): Define.
186 (IDB_RTARROW): Remove.
187 (IDB_TREE_PLUS): Add, and renumber.
188 (IDB_TREE_MINUS): Ditto.
189 (IDC_SITE_USERURL): Define.
190 (IDC_CHOOSE_HIDE): Ditto.
191 (IDC_PREREQ_TEXT): Ditto.
192 (IDC_PREREQ_EDIT): Ditto.
193 (IDC_PREREQ_CHECK): Ditto.
194 * site.cc (SiteControlsInfo): Ensure that 'User URL' static text is
197 2005-05-14 Max Bowsher <maxb@ukf.net>
199 "Type" field of packageversions was not even being filled in. Fix.
201 * cygpackage.h, cygpackage.cc (cygpackage::createInstance):
202 Make "type" a mandatory parameter of the constructor.
203 * IniDBBuilderPackage.cc: Adjust callers.
205 2005-05-14 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
207 Fix behaviour of hardlinks in source packages.
209 * archive.cc (archive::extract_file):
210 Use prefixPath for link target on hardlinks.
212 2005-05-14 Max Bowsher <maxb@ukf.net>
214 Hopefully, solve the "preremove DLL dependency" bug, by running all
215 preremove scripts before actually removing any files.
218 (Installer::preremoveOne): New method. Run preremove scripts here.
219 (Installer::replaceOne): Remove method.
220 (num_replacements): Remove variable.
221 (do_install_thread): Significantly rewrite.
222 * package_meta.cc (packagemeta::uninstall):
223 Do not run preremove script here.
225 2005-05-14 Max Bowsher <maxb@ukf.net>
227 * download.cc (do_download_thread):
228 Do not use packageversion::changeRequested().
229 * package_version.cc (packageversion::Type):
230 Implement declared but previously unimplemented method.
231 (packageversion::changeRequested, _packageversion::changeRequested):
234 (packageversion::changeRequested, _packageversion::changeRequested):
236 * install.cc (Installer::replaceOne): Simplify, return void, not int.
237 (installOneSource): Rename to...
238 (installOne): ...this. Change arguments and return type. Refactor.
239 (install_one): Remove.
240 (do_install_thread): Tidying up.
242 2005-05-07 Max Bowsher <maxb@ukf.net>
244 * download.cc (validateCachedPackage): Remove all MD5 checking code.
245 It is not acceptable to check MD5 sums as part of simply answering
246 whether a package exists in the local cache or not. It is too slow.
247 MD5 sums always have been - and will continue to be - checked at
249 (NoMD5Option): Remove this option, as the code it controls has been
252 2005-05-07 Max Bowsher <maxb@ukf.net>
254 * install.cc (md5_one): Make the MD5 checking done at install time
255 display a progess GUI, as the MD5 checking done at other times does.
257 2005-05-07 Max Bowsher <maxb@ukf.net>
259 * resource.h, res.rc: Followup to recent de-MSVC-ification of
260 resource.h, by removing a lot from res.rc, and the last few bits
263 2005-05-05 Brian Dessent <brian@dessent.net>
265 * choose.cc (ChooserPage::OnInit): Initialize tooltips for this
268 * proppage.h (PropertyPage::makeClickable): Update prototype to
269 reflect same argument name as function.
271 * proppage.cc (PropertyPage::DialogProc): Remove redundant 'break'
272 statements that follow 'return's. Add missing braces to case
273 statements. Call handler for TTN_GETDISPINFO.
275 * res.rc (IDS_TRUSTKEEP_TOOLTIP): Add new STRINGTABLE entry for
277 (IDS_TRUSTPREV_TOOLTIP): Ditto.
278 (IDS_TRUSTCURR_TOOLTIP): Ditto.
279 (IDS_TRUSTEXP_TOOLTIP): Ditto.
280 (IDS_TRUSTPREV_TOOLTIP): Ditto.
281 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
283 * resource.h: Likewise, add identifiers for tooltip resources.
285 * window.h: Add includes.
286 (Window::TooltipHandle): Add new private data structure.
287 (Window::TooltipStrings): Ditto.
288 (Window::ActivateTooltips): Define new function to support tooltip
290 (Window::SetTooltipState): Ditto.
291 (Window::AddTooltip): Ditto.
292 (Window::TooltipNotificationHandler): Ditto.
294 * window.cc (Window::Window): Initialize handle to NULL.
295 (Window::~Window): Call DestroyWindow on tooltip control if it was
297 (Window::ActivateTooltips): New function to activate the tooltip
299 (Window::SetTooltipState): New function to allow toggling of
301 (Window::AddTooltip): New function that adds a tooltip to a given
302 control in a given window. Also implement overloaded versions that
303 provide simpler interface and the ability to use a string resource.
304 (Window::TooltipNotificationHandler): New function to handle
305 TTN_GETDISPINFO notification messages.
307 2005-05-05 Brian Dessent <brian@dessent.net>
309 * resource.h: Reorganize. Group by type, and give each its own
310 range of IDs. Regenerate IDs accordingly.
311 (IDD_CHOOSER): Remove obsolete and unused symbol.
313 2005-05-05 Brian Dessent <brian@dessent.net>
315 * root.h (class RootPage): Add missing virtual to OnMessageCmd.
317 2005-05-05 Brian Dessent <brian@dessent.net>
319 * root.cc (dialog_cmd): Remove. Use OnMessageCmd instead.
320 (RootPage::Create): Accomodate above change.
322 * root.h (class RootPage): Add prototype for OnMessageCmd.
324 * res.rc (IDD_ROOT): Fix broken button groups. Correct the order of
325 the controls and use of WS_GROUP so that the radio buttons act
328 2005-05-05 Max Bowsher <maxb@ukf.net>
330 Bulk rename of String++ member cstr_oneuse () to c_str () for
331 similarity to std::string.
334 * IniDBBuilderPackage.cc
335 * IniParseFindVisitor.cc
337 * PickCategoryLine.cc
354 * io_stream_cygfile.cc
371 2005-05-05 Max Bowsher <maxb@ukf.net>
373 Some String++ refactoring, setting out in the general direction of
374 eventually just using the STL std::string, not our own class.
376 * String++.cc (String::cstr, String::cstr () const): Remove.
377 (new_cstr_char_array): New function.
378 * String++.h: Sync with above.
379 Remove irrelevant "class io_stream;" declaration.
381 * cygpackage.h: Add "class io_stream;" declaration, now no longer
382 being supplied by side-effect.
384 * filemanip.cc: Remove unneeded includes, add "using namespace std;".
385 (parse_filename): Exchange some awkward pointer manipulation for
386 std::string usage. Use new_cstr_char_array ().
387 * filemanip.h: Sync with above.
388 (fileparse): Improve style of declaration.
390 * io_stream_cygfile.cc (io_stream_cygfile::normalise):
391 Use new_cstr_char_array ().
392 * site.cc (site_list_type::init, get_site_list): Ditto.
394 2005-05-05 Brian Dessent <brian@dessent.net>
396 * ControlAdjuster.h (enum ControlPosition): Declare new resizing
397 methods CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, and their
400 * ControlAdjuster.cc (ControlAdjuster::ControlInfo::adjust):
401 Implement CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, which are
402 designed to resize elements in a two-column layout.
404 * localdir.h (class LocalDirPage): Remove constructor implementation
407 * localdir.cc (LocalDirPage::LocalDirPage): ...to here, and call
408 AddControlsInfo on initialization.
409 (static LocaldirControlsInfo): Add. Define sizing rules for dialog
412 * proppage.h: Add includes.
413 (PropertyPage::ClickableURL):
414 Declare new storage type for internal use by class.
415 (PropertyPage::urls): Likewise.
416 (PropertyPage::urlWinProc): Add declaration.
417 (PropertyPage::makeClickable): Likewise.
419 * proppage.cc: Add includes.
420 (PropertyPage::DialogProc): Implement handler for WM_CTLCOLORSTATIC
421 message. Supports static controls that have been turned into
422 clickable hyperlinks.
423 (static PropertyPage::urls): Declare.
424 (PropertyPage::makeClickable): Implement new member function that
425 provides user interface for making text into clickable URLs.
426 (PropertyPage::urlWinProc): Implement new private member function used
427 as a windowproc for subclassing a static control.
429 * resource.h (IDC_SPLASH_URL, IDC_FILEMODES_LINK, IDC_ROOTDIR_GRP,
430 IDC_INSTALLFOR_GRP, IDC_ALLUSERS_TEXT, IDC_JUSTME_TEXT, IDC_MODE_GRP,
431 IDC_MODE_TEXT, IDC_MODE_BIN, IDC_LOCALDIR_GRP, IDC_SPLASH_TEXT,
432 IDC_SPLASH_ICON, IDC_SPLASH_COPYR): Add. Replaces anonymous
433 IDC_STATIC ids, so that controls can be referenced by the resizer.
435 * res.rc (IDD_LOCAL_DIR): Rearrange controls to match top-down order
436 in the dialog. Fold long lines. Replace anonymous IDC_STATIC ids.
437 (IDD_ROOT): Reorder in same manner. Replace anonymous IDC_STATIC ids.
438 Add descriptive text of each option, and hyperlink for more
439 information. Mark suggested choice as "(RECOMMENDED)". Swap order of
440 'unix'/'dos' radio buttons so that recommended choice is first in both
442 (IDD_SPLASH): Reorder elements to match top-down order of dialog, fold
443 long lines. Add descriptive paragraph, remove anonymous ids. Update
444 copyright text, replace sources.redhat.com with cygwin.com.
446 * root.h (class RootPage): Remove constructor implementation from
449 * root.cc: ...to here, and call AddControlInfo.
450 (static RootControlsInfo): Add. Populate with resizing data.
451 (RootPage::OnInit): Make text a clickable hyperlink.
453 * splash.h (class SplashPage): Likewise, move constructor from
456 * splash.cc: ...to here. Call AddControlInfo.
457 (static SplashControlsInfo): Add and populate.
458 (SplashPage::Create): Make link on splash page a clickable hyperlink.
460 * window.h: Add include.
461 (class Window): Store allocated fonts with a vector instead of fixed
462 array. Change indentation of setParent to be consistent.
464 * window.cc (Window::Window): Remove FontCounter.
465 (Window::~Window): Likewise. Iterate over vector of fonts instead.
466 (Window::SetDlgItemFont): Use vector.
468 2005-05-05 Max Bowsher <maxb@ukf.net>
470 * Makefile.am (EXTRA_DIST, inilint_SOURCES):
471 Sync with several recent changes.
473 2005-05-05 Brian Dessent <brian@dessent.net>
475 * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Include section
478 2005-05-05 Brian Dessent <brian@dessent.net>
480 * res.rc: (IDC_CHOOSE): Widen 'view' button by 6px horizontally and
481 4px vertically. Adjust other controls to accomodate.
482 (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that manifest is
483 included in the binary.
485 * setup.exe.manifest: New file. Results in common controls with
486 themed appearance on modern versions of Windows.
488 2005-05-05 Brian Dessent <brian@dessent.net>
490 * main.cc (WinMain): Change conditional to avoid spurious error
491 message on success. Include reason for failure in log message.
493 2005-05-04 Max Bowsher <maxb@ukf.net>
495 * state.cc, state.h (net_method, net_proxy_host, net_proxy_port,)
496 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
497 Inet_ftp_user, net_ftp_passwd):
498 Move these global variables to be static variables of the NetIO class.
500 * netio.h, netio.cc (net_method, net_proxy_host, net_proxy_port,)
501 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
502 net_ftp_user, net_ftp_passwd):
505 * ConnectionSetting.cc, net.cc:
506 Change include, refer to variables in new location.
508 2005-05-04 Max Bowsher <maxb@ukf.net>
510 * PickLine.cc: Remove file - redundant.
511 * Makefile.am (setup_SOURCES): Adjust.
513 2005-05-04 Max Bowsher <maxb@ukf.net>
515 * package_version.h (packageversion::set_requirements):
516 Remove deftrust argument default value.
518 2005-05-04 Max Bowsher <maxb@ukf.net>
520 * package_version.cc (DependencyProcessor): Remove trivial class.
521 (select, processOneDependency): Do not use DependencyProcessor, just
522 pass parameters normally.
524 2005-05-04 Brian Dessent <brian@dessent.net>
526 Fix bug #820: Clicking Curr, etc., causes some dependencies to not
529 * choose.cc (ChooserPage::changeTrust):
530 Add a missing "packagedb.markUnVisited ()".
532 2005-05-03 Max Bowsher <maxb@ukf.net>
534 * PickCategoryLine.cc (PickCategoryLine::click):
535 * PickPackageLine.cc (PickPackageLine::click):
536 Abandon use of trivial packagemeta::PrepareForVisit() wrapper.
538 * package_meta.h (packagemeta::PrepareForVisit): Remove.
539 * package_meta.cc (packagemeta::PrepareForVisit): Remove.
541 2005-05-03 Max Bowsher <maxb@ukf.net>
543 * choose.h (ChooserPage::ifChecked): Remove.
544 (ChooserPage::changeTrust): Convert from template to ordinary function.
545 * choose.cc (ChooserPage::changeTrust): As above, plus avoid the use
546 of custom class SetRequirement, when bind2nd(mem_fun(...),...) can
547 achieve the same effect.
548 * package_meta.h (SetRequirement): Remove, now unused.
550 2005-05-03 Max Bowsher <maxb@ukf.net>
552 * package_meta.h (packagemeta::set_requirements):
553 Remove default argument which seems inappropriate.
554 * PickPackageLine.cc (PickPackageLine::click):
555 Make an argument explicit, and not that it seems like the wrong value.
557 2005-05-03 Brian Dessent <brian@dessent.net>
559 Fix part of bug #853 - proxy port not remembered.
561 * net.cc (doing_loading): New static boolean.
562 (load_dialog): Use the boolean to prevent save_dialog() from taking
563 action due to field changes due to initialization.
564 (save_dialog): Check the boolean and respond appropriately.
566 2005-04-19 Max Bowsher <maxb@ukf.net>
568 * postinstall.cc (RunFindVisitor::visitFile): Fix crash on
569 encountering a postinstall script with a name of 4 characters or less.
570 Bug introduced on 2004-12-25.
572 2005-04-05 Max Bowsher <maxb@ukf.net>
574 The Big Cleanup: Phase "rfc1738"
576 * rfc1738.cc, rfc1738.h: Delete.
577 * csu_util/rfc1738.cc: Reimport latest version from upstream source.
578 Make thread-safe. Rewrite C++ wrapper in terms of std::string.
579 Document the divergences from the upstream source.
580 * csu_util/rfc1738.h: Recreate for the std::string version of the
583 * Makefile.am (setup_SOURCES): Sync with added/removed files.
584 * IniParseFindVisitor.cc: Modify #includes.
585 (IniParseFindVisitor::visitFile): Change function name, as the new
586 C++ wrapper does not contain an irregularity that the old one did.
587 * download.cc: Modify #includes.
588 * ini.cc: Modify #includes.
590 2005-04-05 Max Bowsher <maxb@ukf.net>
592 Remove setup's internal compression libraries, instead relying on the
593 mingw-foo packages which have been part of the Cygwin net distribution
594 for some time now. At the same time, reorganize the README file to
595 inform about the change, and make some additional tidy-ups there whilst
598 * GUIDELINES: Remove, contents transferred to README.
599 * README: Add build instructions. Delete unconfirmed and fixed bugs
600 sections. Incorporate the former contents of GUIDELINES.
604 * Makefile.am (DIST_SUBDIRS, SUBDIRS):
605 * configure.in: Remove AC_CONFIG_SUBDIRS for removed subdirs.
606 * compress_bz.h: Remove complex _WIN32 preprocessor conditional.
607 * compress_gz.h: Fix #include file name.
608 * archive_tar_file.cc: Remove unused #include.
609 * install.cc: Remove unused #include.
611 2005-01-27 Max Bowsher <maxb@ukf.net>
613 Set CYGWIN=nontsec, for postinstall scripts.
615 * main.cc (main): putenv("CYGWIN=nontsec").
617 2005-01-27 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
619 Fix corrupt display of ini parse percentage in log file.
621 * ini.cc (GuiParseFeedback): Use a sensible data type for lastpct.
623 2004-12-29 Max Bowsher <maxb@ukf.net>
625 * site.cc (get_site_list): Filter the incoming mirrors list to contain
626 only URL schemes that we can read.
628 2004-12-28 Max Bowsher <maxb@ukf.net>
630 The Big Cleanup: Phase "hash"
632 * hash.cc, hash.h: Delete.
633 * Makefile.am (setup_SOURCES): Sync with deleted files.
635 * package_mets: Modify includes.
636 (standard_dirs): Remove.
637 (hash::add_subdirs): Remove.
638 (packagemeta::uninstall): Re-implement using STL set instead of
641 2004-12-28 Max Bowsher <maxb@ukf.net>
643 * String++.h (operator std::string): Take care to never do
644 std::string((char*)NULL) - it causes a hang!
646 2004-12-27 Max Bowsher <maxb@ukf.net>
648 The Big Cleanup: Phase "log"
650 * log.cc, log.h: Delete old C-style compatibility wrapper around the
652 * Makefile.am (setup_SOURCES): Sync with deleted files.
654 * AntiVirus.cc, archive_tar_file.cc, ini.cc, install.cc,
655 * io_stream_cygfile.cc, localdir.cc, msg.cc, net.cc, netio.cc,
656 * netio.h, nio-ftp.cc, nio-ftp.h, root.cc, source.cc:
657 Throughout, refine includes, and update code using the old
658 compatibility wrapper to C++ streams style code.
660 2004-12-27 Max Bowsher <maxb@ukf.net>
662 * compress.cc: Refine includes. Remove placeholder function
663 definitions. Make destructor an empty function.
664 * compress.h: Refine includes. Make placeholder functions pure
665 virtual. Add missing const on buffer argument to write function,
666 to match derived classes.
667 * compress_bz.cc, compress_gz.cc: Refine includes. Throw exception,
668 rather than logging and returning an error, when an unimplemented
670 * compress_bz.h, compress_gz.h: Refine includes.
672 2004-12-26 Max Bowsher <maxb@ukf.net>
674 The Big Cleanup: Phase "version"
676 * String++.h (operator std::string): Add.
677 * desktop.cc, fromcwd.cc: Remove irrelevant include.
679 * version.cc, version.h: Delete, replacing all functionality in new
682 * setup_version.h: Add, taking over declaration of generated version
683 symbol functionality.
685 * Makefile.am (setup_SOURCES): Sync with new/deleted files.
686 (setup_version.c): Rename the symbol 'version' to 'setup_version'.
687 * main.cc: Modify includes.
688 (main): Adapt to setup_version rename.
689 * splash.cc: Modify includes.
690 (SplashPage::OnInit): Adapt to setup_version rename.
692 * csu_util/version_compare.cc, csu_util/version_compare.h: Add,
693 containing a completely rewritten replacement for canonical_version().
695 * IniDBBuilderPackage.cc: Modify includes.
696 (IniDBBuilderPackage::buildVersion): Use new version_compare API.
697 * ini.cc: Modify includes.
698 (setup_version): Rename...
699 (ini_setup_version): ...to this.
700 (do_local_ini, do_remote_ini): Adapt to above change.
701 (do_ini_thread): Adapt to above change. Use new version_compare API.
703 2004-12-25 Max Bowsher <maxb@ukf.net>
705 * install.cc (Installer::installOneSource): Remove a stray "break;"
706 left over from the switch-case -> if-else conversion in the previous
709 2004-12-25 Max Bowsher <maxb@ukf.net>
711 The Big Cleanup: Phase "win32"
713 * win32.h: Major overhaul. Document why we use _WIN32_IE. Move out
714 fragment dealing with alloca() to the single file in which it is used.
715 Remove fragment dealing with _MAX_PATH, and convert all uses of it
716 elsewhere to MAX_PATH. Remove random include of <stdarg.h>. Remove
717 NOCOMATTRIBUTE, as setup contains no code which it affects. Remove
718 includes of <wininet.h> and <windowsx.h> - see later in this log.
719 (IsWindowsNT): New inline function, a much simpler implementation of
724 * Makefile.am (setup_SOURCES): Remove "win32.cc".
726 * AntiVirus.cc (detect), PickPackageLine.cc (PickPackageLine::paint),
727 * install.c (Installer::installOneSource):
728 Use IsWindowsNT(), not Win32::OS().
729 * main.cc (main): Use IsWindowsNT(), not locally defined iswinnt.
731 * PickView.cc (PickView::WindowProc), netio.cc (auth_proc),
732 * proppage.cc (PropertyPage::DialogProc):
733 Avoid using obfuscating macros from <windowsx.h>.
735 * archive.cc: Include or #define alloca() in the only file in which
738 * nio-ie5.h: Include <wininet.h> here, where it is actually needed,
739 rather than in "win32.h" which is included almost everywhere.
741 * archive_tar.cc, archive_tar.h, cygpackage.cc, cygpackage.h,
742 * desktop.cc, find.cc, install.cc, main.cc, mklink2.c, mount.cc,
743 * script.cc: Use MAX_PATH, not _MAX_PATH.
745 2004-12-25 Max Bowsher <maxb@ukf.net>
747 Remove some overcomplications.
749 * Makefile.am (setup_SOURCES): Remove FilterVisitor.{cc,h}.
750 * FilterVisitor.cc, FilterVisitor.h: Delete.
751 * String++.cc (strmatch, String::matches): Remove.
752 * String++.h (String::matches): Remove.
753 * postinstall.cc: Do not include "FilterVisitor.h".
754 (RunFindVisitor): Exclude items with the extension ".done".
755 (do_postinstall_thread): Remove overcomplicated exclusion of items
756 with the extension ".done".
758 2004-12-24 Max Bowsher <maxb@ukf.net>
760 * String++.cc, String++.h: Remove unused and incomplete code.
761 * LogFile.cc (LogFile::log_save): Don't leak memory.
762 * filemanip.cc, geturl.cc, root.cc, version.cc:
763 Don't pointlessly create temporary copies strings.
765 2004-12-23 Max Bowsher <maxb@ukf.net>
767 * choose.cc (ChooserPage::OnNext): Relegate some overly verbose
768 logging to an #ifdef DEBUG section.
769 * geturl.h (dismiss_url_status_dialog): Remove stale function
770 declaration, for which there is no definition.
771 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
772 Motivated by the recent unexplained hang bug, add some extra logging.
774 2004-11-22 Max Bowsher <maxb@ukf.net>
776 * MD5++.cc, MD5++.h: Remove this class.
777 * csu_util/MD5Sum.cc, csu_util/MD5Sum.h: New more complete MD5 class.
778 * Makefile.am (setup_SOURCES): Adjust to new files.
779 * download.cc (validateCachedPackage): Simplify, using the new class.
780 * install.cc (md5_one): Ditto.
781 * package_source.h (packagesource::md5): Change to be an object of the
784 2004-11-22 Max Bowsher <maxb@ukf.net>
786 * main.cc (main): Fix bug in one of the 2004-11-19 commits.
787 Avoid referring to the theLog pointer before it is set.
789 2004-11-20 Max Bowsher <maxb@ukf.net>
791 * res.rc (IDD_SOURCE): Clarify the radio-button option descriptions.
792 Re-layout the radio buttons.
794 2004-11-20 Max Bowsher <maxb@ukf.net>
796 Repair the broken detection of wrongly-sized package files.
798 * download.cc (validateCachedPackage): Make static, since not used
799 elsewhere. Improve logging. Migrate file-size tests to here, alongside
801 (check_for_cached): Remove broken testing of file-size, now covered by
802 the above. Code cleanups.
804 2004-11-19 Max Bowsher <maxb@ukf.net>
806 * package_version.cc (dumpAndList): Make dependencies much more
807 readable in full log output.
809 2004-11-19 Max Bowsher <maxb@ukf.net>
811 * proppage.cc (PropertyPage::DialogProc): Wrap in a TOPLEVEL_CATCH
812 block, since allowing exceptions to unwind into the guts of Windows is
815 2004-11-19 Max Bowsher <maxb@ukf.net>
817 * main.cc (main): Move option parsing code earlier - it must execute
818 before any significant object creations, which might test options in
819 their initialization.
821 2004-11-19 Max Bowsher <maxb@ukf.net>
823 * main.cc (main): Remove some junk code - either commented out, or
824 contained within unreachable preprocessor conditional sections.
826 2004-11-19 Max Bowsher <maxb@ukf.net>
828 * install.cc (Installer::installOneSource): Avoid leaking the open
829 file handles of every tarball that is installed.
831 2004-11-19 Max Bowsher <maxb@ukf.net>
833 * package_source.h (packagesource::Canonical, packagesource::Base)
834 (packagesource::Filename): Add "const" specification to accessor
837 2004-11-18 Max Bowsher <maxb@ukf.net>
839 * archive.h (archive::~archive): Define a pure virtual destructor to
840 enforce the abstract nature of this class.
841 * archive.cc (archive::~archive): Pure virtual destructors require an
842 implementation! Add one.
843 * io_stream.h (io_stream::destroyed): Remove this severely
844 brain-damaged implementation of a weakly-enforced abstract class.
845 The pure virtual destructor was strongly enforcing the abstract nature
847 * io_stream.cc (io_stream::~io_stream): Empty out horribly pointless
848 code from the pure virtual destructor.
849 * archive_tar.cc (archive_tar::~archive_tar): Remove all
850 reference to the removed "destroyed" member.
851 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
852 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
853 * compress_gz.cc (compress_gz::~compress_gz): Ditto.
854 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Ditto.
855 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
856 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
858 2004-11-17 Max Bowsher <maxb@ukf.net>
860 * mount.cc (create_mount): Fix operator precedence error introduced in
861 first 2004-11-11 commit - warned of by gcc 3.3.3 but not 3.4.1 !
863 2004-11-13 Max Bowsher <maxb@ukf.net>
865 Miscellaneous cleanup.
867 * geturl.cc (getUrlToStream): Make static.
868 * geturl.h (getUrlToStream): Remove declaration.
870 * geturl.cc, geturl.h, netio.cc, netio.h, nio-ftp.cc, nio-ftp.h,
871 nio-http.cc, nio-http.h:
872 Remove unused "allow_ftp_auth" flag throughout.
874 2004-11-11 Max Bowsher <maxb@ukf.net>
876 * libmd5-rfc: New directory, to hold code imported from the libmd5-rfc
877 project in a clearly delineated fashion.
878 * libmd5-rfc/README: New file.
879 * md5.c, md5.h: Delete...
880 * libmd5-rfc/md5.c, libmd5-rfc/md5.h: ...and replace with pristine
881 versions from upstream (only change is restoration of upstream CVS
883 * libmd5-rfc/md5main.c: New file.
884 * Makefile.ami (setup_SOURCES): Edit file paths.
885 * download.cc, install.cc: Edit include paths.
887 2004-11-11 Max Bowsher <maxb@ukf.net>
889 * dialog.cc (fatal): Make capable of handling a passed-in error code,
890 as an alternative to calling GetLastError().
891 * dialog.h (fatal): Adjust prototype as above.
892 * mount.cc (create_mount): Use the above to correctly report errors.
894 2004-10-28 Max Bowsher <maxb@ukf.net>
896 * LogFile.cc (LogFile::getFileName), splash.cc (SplashPage::Create),
897 threebar.cc (ThreeBarProgressPage::SetBar2):
898 Migrate from cistring and string resources
899 to String and string literals.
900 * localdir.cc: Remove unneeded #include of "cistring.h".
901 * cistring.cc, cistring.h: Remove this now-redundant class.
902 * Makefile.am: Remove mention of the above removed files.
903 * res.rc, resource.h: Remove obsolete strings and IDs, both those
904 obseleted by and obselete before the above changes.
905 * res.rc: Merge the 2 adjacent STRINGTABLEs.
907 2004-10-27 Max Bowsher <maxb@ukf.net>
909 * Makefile.am (setup_SOURCES): Add "RECTWrapper.h". It was missing.
911 2004-10-25 Bas van Gompel <cygsup-patch.buzz@bavag.tmfweb.nl>
913 * package_source.cc (packagesource::set_canonical):
914 Fix one-off in 'base' when ini is in same dir as package.
916 2004-10-25 Max Bowsher <maxb@ukf.net>
918 * main.cc (next_dialog): Remove this legacy global variable.
919 * download.cc (do_download_thread): Return a value instead of setting
920 a global variable, then returning void.
921 (do_download_reflector): Look for the next dialog code as a return
922 value instead of a global variable.
924 2004-10-25 Max Bowsher <maxb@ukf.net>
926 * port.h: Remove this redundant file - all contained definitions are
927 duplicated in "win32.h".
928 * Makefile.am, UserSetting.cc, UserSettings.cc, archive.cc,
929 archive_tar.cc, archive_tar_file.cc, choose.cc, compress.cc,
930 compress_bz.cc, compress_gz.cc, desktop.cc, find.cc, fromcwd.cc,
931 iniparse.y, install.cc, io_stream_cygfile.cc, io_stream_file.cc,
932 main.cc, netio.cc, site.cc, version.cc:
933 Remove all references to "port.h".
935 2004-10-25 Max Bowsher <maxb@ukf.net>
937 Fix compilation with w32api 3.1 and later.
939 * ControlAdjuster.h, RECTWrapper.h, cistring.h, propsheet.h,
940 window.cc, window.h: Include "win32.h" not <windows.h> directly.
941 * win32.h (WINBASEAPI): Define to empty string.
943 2004-09-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
945 * script.cc (run): Kill stdin when running scripts.
947 2004-09-01 Max Bowsher <maxb@ukf.net>
949 * Makefile.am: Oops. Unwanted keyword expansion ate the code of the
950 previous commit. Restore the code, escaped to not look like a keyword.
952 2004-09-01 Max Bowsher <maxb@ukf.net>
954 * Makefile.am: Simplify the shell incantation for getting the revision
955 of ChangeLog from grep-and-sed to just sed.
957 2004-08-31 Max Bowsher <maxb@ukf.net>
959 Attain GCC 3.4 compatibility.
961 * PackageSpecification.h (PackageSpecification): Make the
962 unnecessarily private copy-constructor public.
964 2004-08-30 Max Bowsher <maxb@ukf.net>
966 Rework the implementation of not including -Werror for specific files,
967 to a way that does not require hardcoding modified automake output back
970 * Makefile.am (AM_CXXFLAGS, BASECXXFLAGS): Seperate out -Werror.
971 (autoload.o): Drop this rule, -finline-functions is no longer required
972 and -Werror is acceptable here now we have __attribute__ ((used)).
973 (WARNONLY_CFLAGS, inilex.o): Drop these.
974 (EXTRA_PROGRAMS): Add a fake "warnonly" program.
975 (warnonly_CXXFLAGS): Set to the $(BASECXXFLAGS).
976 (warnonly_SOURCES): Set to "inilex.cc".
977 (EXTRA_setup_SOURCES): Set to $(warnonly_SOURCES).
978 (setup_SOURCES): Remove "inilex.cc".
979 (setup_LDADD): Add "warnonly-inilex.o".
981 2004-08-30 Max Bowsher <maxb@ukf.net>
983 Move closer to GCC 3.4 compatibility.
985 * IOStreamProvider.h, io_stream_cygfile.cc, io_stream_cygfile.h,
986 io_stream_file.cc: Do not incorrectly use "enum" after it has been
987 hidden inside a typedef.
988 * archive.h: In "virtual func() = 0;", the 0 is a language construct,
989 not some symbol that might evaluate to 0, and gcc 3.4 enforces this.
990 * autoload.c (DllInfo.name): Silence warning by making const.
991 (DLL, autoload_common): __attribute__ ((used)) is now required to
992 prevent gcc being over-eager in it's optimization, and removing these
993 seemingly-unused (used only from assembly) functions.
994 Silences some warnings, too.
995 * Makefile.am (AM_CXXFLAGS, AM_CFLAGS): The options
996 -Wstrict-prototypes -Wmissing-prototypes do not apply to C++ and
997 g++ 3.4 complains about them.
999 2004-08-29 Max Bowsher <maxb@ukf.net>
1001 * Exception.h: Reformatting, #include more, remove incorrect and
1002 less-than-useful comments.
1003 (TOPLEVEL_CATCH): New preprocessor macro.
1005 * LogFile.cc (LogFile::operator()): Throw an exception object, not a
1008 Wrap the top-level of each thread (including the main thread) in a
1009 try...catch block, in order to display a useful error message if an
1010 exception is not caught.
1011 * download.cc (do_download_reflector): Here ...
1012 * ini.cc (do_ini_thread_reflector): ... and here ...
1013 * install.cc (do_install_reflector: ... and here ...
1014 * main.cc (main): ... and here ...
1015 * postinstall.cc (do_postinstall_thread): ... and here ...
1016 * site.cc (do_download_site_info_thread): ... and here!
1018 * msg.h: Include a missing header requirement.
1019 * res.rc (IDS_UNCAUGHT_EXCEPTION, IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO):
1021 * resource.h (IDS_UNCAUGHT_EXCEPTION)
1022 (IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO): New IDs.
1024 2004-08-28 Max Bowsher <maxb@ukf.net>
1026 * res.rc (IDS_WINDOW_INIT_BADMSG): New string.
1027 * resource.h (IDS_WINDOW_INIT_BADMSG): New string resource ID.
1028 * window.cc (Window::FirstWindowProcReflector): Convert an abort()
1029 into a descriptive error.
1031 2004-08-24 Max Bowsher <maxb@ukf.net>
1033 The Doug Lee replacement malloc was no longer hooked up with the
1034 buildsystem in any way. Pruning the remaining unused file.
1036 * dlmalloc.c: Removed.
1038 2004-08-18 Max Bowsher <maxb@ukf.net>
1040 "librsync is not wire-compatible with rsync 2.x, and is not likely
1041 to be in the future." -- librsync.sourceforge.net
1043 So, it is of no practical use to setup. Therefore, removing all
1044 rsync related files and code from setup.
1046 * rsync: Directory removed.
1047 * Makefile.am: Remove rsync support from the buildsystem.
1048 * configure.in: Ditto.
1049 * README: Since it seems vanishingly unlikely that it will ever happen,
1050 remove rsync support from the wishlist.
1051 * io_stream_rsync.cc: Remove.
1052 * io_stream_rsync.h: Remove.
1054 2004-04-25 Robert Collins <rbtcollins@hotmail.com>
1056 * package_meta.cc (packagemeta::set_requirements): fix problem with
1057 libpcre0 not being pulled in automatically.
1059 2004-04-25 Robert Collins <rbtcollins@hotmail.com>
1061 * IniDBBuilderPackage.cc (dumpAndList):
1062 Move out to packageversion for reuse.
1063 * package_meta.cc (packagemeta::logAllVersions): log dependencies.
1064 * package_version.cc (packageversion::depends):
1065 provide a const accessor.
1066 (dumpAndList): Moved from INIDBBuilder.cc.
1067 * package_version.h: declare new method and function.
1069 2003-12-21 Robert Collins <rbtcollins@hotmail.com>
1071 * main.cc (main): Update to head libgetopt++ syntax.
1073 2003-11-2 Robert Collins <rbtcollins@hotmail.com>
1075 * ControlAdjuster.h (ControlPosition::CP_MIDDLE): Rename to
1077 * ControlAdjuster.cc: Ditto.
1079 2003-10-31 Frank Richter <frichter@gmx.li>
1081 * localdir.cc (OnNext): When SelectDirectoryA() fails, display a
1082 message with the error returned from the system instead of just
1083 'could not change dir'. Also, offer the user to 'Retry', 'Ignore' the
1084 error or 'Abort' the directory change.
1086 2003-10-31 Frank Richter <frichter@gmx.li>
1088 * propsheet.cc (PropSheetWndProc): Don't do child resizing if a the
1089 window gets minimized. Otherwise some glitches (e.g. wrong child
1091 Added support for WM_GETMINMAXINFO. Prevents the property sheet from
1092 getting smaller than the original size.
1094 2003-11-1 Robert Collins <rbtcollins@hotmail.com>
1096 * ControlAdjuster.h (ControlDimension): Add.
1097 (ControlAdjuster): Factor adjust functionality into ControlInfo.
1098 * ControlAdjuster.cc (ControlAdjuster::adjust): Ditto.
1099 (ControlAdjuster::ControlInfo::adjust): Ditto.
1101 2003-10-31 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1103 * ControlAdjuster.h (ControlPosition): New enum type.
1104 (ControlInfo::horizontalPos, ControlInfo::verticalPos): New
1106 (ControlInfo::anchorLeft, ControlInfo::anchorTop,
1107 ControlInfo::anchorRight, ControlInfo::anchorBottom): Remove.
1108 * ControlAdjuster.cc (ControlAdjuster::AdjustControls): Switch to
1109 using position specifiers instead of anchors.
1110 * choose.cc (ChooserControlsInfo): Ditto.
1111 * proppage.cc (DefaultControlsInfo): Ditto.
1112 * propsheet.cc (PropSheetControlsInfo): Ditto.
1113 * site.cc (SiteControlsInfo): Position specifiers for site
1114 selection dialog controls.
1115 * threebar.cc (ThreeBarControlsInfo): Position specifiers for
1116 progress dialog controls.
1118 2003-10-27 Ralf Habacker <ralf.habacker@freenet.de>
1120 * main.cc (HelpOption): New instance.
1121 (main): Added help command line option handling.
1122 * localdir.cc (LocalDirOption): New instance.
1123 (LocalDirSetting::load): allow setting localdir from command line.
1125 2003-10-16 Frank Richter <frichter@gmx.li>
1127 * ControlAdjuster.cc: New file, helper to move elements of a dialog
1128 along when the it's resized.
1129 * ControlAdjuster.h: Ditto.
1130 * Makefile.am: Add new source files.
1131 * proppage.cc (PropertyPage::DialogProc): Adjust some common
1132 controls (Cygwin icon top right, separator below) when a page is
1134 (PropertyPage::PropertyPage): Dito.
1135 * propsheet.cc (IsDialog): New. Test whether a window is a dialog.
1136 Used internally by resize logic.
1137 (EnumPages): New. Used internally by resize logic: resizes the
1138 property sheet's individual pages.
1139 (PropSheetWndProc): New. Hook for the propery sheet window proc.
1140 (PropSheetProc): More style tweaks, add maximize box and thick border
1141 as well. Hook into the property sheet's window proc.
1142 (PropSheet::AdjustPageSize): New. Adjust the metrics of a single page
1143 to fit nicely into the property sheet. Part of resize logic.
1144 * res.rc (All dialogs): The top-right Cygwin icon and top separator
1145 now have IDs distinct from IDC_STATIC, so their metrics can be
1146 adjusted upon a resize. Also, all those Cygwin icons are at the exact
1148 * choose.cc (ChooserPage::ChooserPage): Now the controls on the
1149 chooser page move/size when the page size is changed.
1152 2003-10-23 Jerry D. Hedden <jerry@hedden.us>
1154 * ConnectionSetting.cc (ConnectionSetting::load): Load proxysettings.
1155 (ConnectionSetting::save): Save proxy settings.
1157 2003-10-07 Robert Collins <rbtcollins@hotmail.com>
1159 * proppage.h (PropertyPage::wantsActivation): const correctness fix.
1161 2003-08-19 Max Bowsher <maxb@ukf.net>
1163 * win32.h: Define NOMINMAX only if not already defined - because
1164 libstdc++-v3 3.3.1 defines NOMINMAX itself.
1166 2003-08-03 Max Bowsher <maxb@ukf.net>
1168 * ChangeLog: Fix broken line-wrapping throughout. Clarify that
1169 "Ran automake" in 2003-07-26 entry was in bz2lib and zlib subdirs.
1171 2003-08-03 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1173 * propsheet.cc (Copyright): Update copyright dates.
1174 (PropSheet::PropSheet): Remove NumPropPages initialization.
1175 (PropSheet::CreatePages): Use PropertyPages.size() instead of
1177 (PropSheet::Create): Ditto.
1178 (PropSheet::AddPage): Change to use new PropertyPages std::vector<>.
1179 * propsheet.h (Copyright): Update copyright dates.
1180 (File Scope): Include <vector>.
1181 (PropSheet::PropertyPages): Change from array to vector<>.
1182 (PropSheet::NumPropPages): Remove.
1184 2003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1186 Changes modified by Max Bowsher <maxb@ukf.net>
1187 * splash.cc (Copyright): Update copyright dates.
1188 (SplashPage::OnInit): Remove call to SetDlgItemFont(). Now handled in
1190 * proppage.h (PropertyPage::setTitleFont): Declare.
1191 * proppage.cc (Copyright): Update copyright dates.
1192 (PropertyPage::DialogProc WM_INITDIALOG): Move all font setting code,
1193 including that from splash.cc into new function...
1194 (PropertyPage::setTitleFont): Create, using moved code. Change font
1195 "MS Sans Serif" to "MS Shell Dlg" in line with recent res.rc change.
1196 Set font for IDC_STATIC_WELCOME_TITLE here, to allow easy re-use of
1197 style for future "Finished" page.
1199 2003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1201 * propsheet.cc: Include "resource.h".
1202 (PropSheet::Create): Add the Cygwin icon in the left of the title bar.
1204 2003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1206 * proppage.cc (PropertyPage::FirstDialogProcReflector): Modify comment.
1208 2003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1210 * proppage.h (Copyright): Update copyright dates.
1211 (PropertyPage): Document OnNext and OnBack.
1213 2003-07-31 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1215 * proppage.cc (PropertyPage::Create): Use more self-documenting
1216 MAKEINTRESOURCE() instead of cast to LPCSTR.
1218 2003-07-31 Robert Collins <rbtcollins@hotmail.com>
1220 * README: Mark completed items complete.
1222 2003-07-31 Pierre Humblet <pierre.humblet@ieee.org>
1224 * main.cc (set_default_sec): Set token owner from token user.
1225 Always try to set the token primary group to Users or Admins.
1227 2003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1229 * String++.h (String::replace): New instance functions.
1230 * String++.cc (String::replace): Implement.
1231 * filemanip.cc (backslash): Change to use String::replace.
1232 * desktop.cc (make_cygwin_bat): Escape '%' in path.
1234 2003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1236 * String++.h (TOSTRING): New macro.
1237 * UserSettings.cc (UserSettings::deRegisterSetting): Fix
1238 erroneous __LINE__/__FILE__ usage.
1239 * download.cc (validateCachedPackage, check_for_cached): Ditto.
1240 * geturl.cc (getUrlToStream): Ditto.
1241 * install.cc (md5_one): Ditto.
1243 2003-07-30 Max Bowsher <maxb@ukf.net>
1245 * ini.cc (do_ini_thread): Return bool.
1246 (do_ini_thread_reflector): Put returned bool in lParam.
1247 * threebar.cc (WM_APP_SETUP_INI_DOWNLOAD_COMPLETE): Rework for new
1248 meaning of lParam. Replace erroneous use of do_fromcwd with
1249 SetActivePageByID (IDD_SOURCE).
1251 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
1253 * ConnectionSetting.cc: New file, persist connection type selection.
1254 * ConnectionSetting.h: Ditto.
1255 * net.cc: Hold a ConnectionSetting instance to trigger the logic.
1256 (NetPage::OnInit): Don't force net_method to any value.
1257 * Makefile.am: Add new source files.
1259 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
1261 * SourceSetting.cc: New file, persist source selection.
1262 * SourceSetting.h: Ditto.
1263 * source.cc: Hold a Source setting instance to trigger the logic.
1264 * Makefile.am: Add new source files.
1266 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
1268 * UserSettings.h (UserSettings::settingFileForLoad): Extracted method
1269 from LocalDirSetting::load().
1270 * UserSettings.cc (UserSettings::settingFileForLoad): Ditto.
1271 * UserSettings.h (UserSettings::settingFileForSave): Extracted method
1272 from LocalDirSetting::save().
1273 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
1274 * localdir.cc (LocalDirSetting::load): Extract location logic to
1276 (LocalDirSetting::save): Extract location logic to UserSettings.
1277 * site.cc (SiteSetting::getSavedSites): Use
1278 UserSettings::settingFileForLoad.
1279 (SiteSetting::save): Use UserSettings::settingFileForSave.
1281 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
1283 * PickView.cc: Adjust ::GetClientRect(..) to the inherited one
1286 2003-07-29 Max Bowsher <maxb@ukf.net>
1288 Based on a patch by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
1289 * AntiVirus.cc (AntiVirusPage::wantsActivation): Define.
1290 * AntiVirus.h (AntiVirusPage::wantsActivation): Declare.
1291 * localdir.cc (LocalDirPage::OnBack): Remove logic subsumed by
1292 RootPage::wantsActivation.
1293 * proppage.cc (PropertyPage::DialogProc): Call wantsActivation(),
1294 and skip to next page in sequence if activation is refused.
1295 * proppage.h (PropertyPage::wantsActivation): Default implementation.
1296 * root.cc (RootPage::wantsActivation): Define.
1297 * root.h (RootPage::wantsActivation): Declare.
1298 * source.cc: Don't include "AntiVirus.h".
1299 (SourcePage::OnNext): Remove logic subsumed by
1300 RootPage::wantsActivation.
1301 (SourcePage::OnBack): Remove logic subsumed by
1302 AntiVirusPage::wantsActivation.
1303 * splash.cc: Don't include "AntiVirus.h" or "dialog.h".
1304 (SplashPage::OnNext): Remove - subsumed by
1305 AntiVirusPage::wantsActivation.
1306 * splash.h (SplashPage::OnNext): Remove declaration.
1308 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
1310 * PickView.h (PickView::refresh): New method.
1311 * PickView.cc (PickView::refresh): Extracted from various
1312 ChooserPage callers.
1313 * choose.cc: Use PickView::refresh wherever possible.
1315 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
1317 * choose.h (ChooserPage::createListView): Remove last parameter.
1318 (ChooserPage::getDefaultListViewSize): Extracted method.
1319 * choose.cc (ChooserPage::createListView): Remove last parameter.
1320 (ChooserPage::getDefaultListViewSize): Extracted method.
1322 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
1324 * choose.cc (ChooserPage::createListView): Remove unneeded
1328 2003-07-29 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1330 * dialog.h (do_fromcwd): Change function declaration.
1331 * fromcwd.cc (do_fromcwd): Change return type to bool. Eliminate
1332 use of next_dialog, return true or false instead.
1333 * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
1334 value instead of next_dialog.
1336 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
1338 * package_db.h (packagedb::fillMissingCategory): Move from ChooserPage.
1339 * choose.h (ChooserPage::fillMissingCategory): Delete.
1340 * package_db.cc (packagedb::fillMissingCategory): Move from ChooserPage.
1341 * choose.cc (ChooserPage::fillMissingCategory): Delete and adjust
1344 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
1346 * PickView.h (CATEGORY_EXPANDED): Move from choose.h
1347 (CATEGORY_COLLAPSED): Move from choose.cc.
1348 (PickView::setViewMode): Move from ChooserPage.
1349 * choose.h (CATEGORY_EXPANDED): Delete.
1350 (CATEGORY_COLLAPSED): Delete.
1351 (ChooserPage::setViewMode): Delete.
1352 * PickView.cc (PickView::setViewMode): Move from ChooserPage.
1353 * chooser.cc (ChooserPage::setViewMode): Delete, and adjust callers
1356 2003-07-28 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1358 * AntiVirus.cc (AntiVirusPage::OnNext): Do not explicitly specify the
1359 page to display next, since it follows in the default page ordering
1362 2003-07-28 Max Bowsher <maxb@ukf.net>
1364 * dialog.h: (NEXT): Remove obsolete macro.
1365 * site.cc (save_dialog): Remove use of NEXT(), and non-functional
1366 unnecessary error handler.
1368 2003-07-28 Robert Collins <rbtcollins@hotmail.com>
1370 * package_meta.h (packagemeta::addToCategoryAll): Declare.
1371 * package_meta.cc (packagemeta::addToCategoryAll): New method,
1372 separated to allow clear iteration.
1373 * choose.cc (ChooserPage::fillMissingCategory): BUGFIX: "all" is
1374 meant to be added unconditionally.
1376 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1378 * Generic.h: New file, home for generic programming tools.
1379 (visit_if): Move here from package_meta.cc.
1380 Adjust to be fully parameterised.
1381 * package_meta.h (packagemeta::hasNoCategories): Query for generic
1383 (packagemeta::setDefaultCategories): set categories for packages
1385 * package_meta.cc: Move visit_if out. Adjust users for
1386 full paramterised operation.
1387 (packagemeta::hasNoCategories): Implement.
1388 (packagemeta::setDefaultCategories): Implement.
1389 * choose.cc (ChooserPage::fillMissingCategory): Use visit_if to
1390 reduce duplicate code.
1391 (ChooserPage::setExistence): Delete.
1392 * choose.h (ChooserPage::setExistence): Rename to
1393 packagedb::setExistence.
1394 * package_db.h (packagedb::setExistence): Declare.
1395 * package_db.cc (packagedb::setExistence): Copy from choose.cc
1397 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1399 * localdir.h (LocalDirPage::OnInit): Remove.
1400 * localdir.cc (LocalDirPage::OnInit): Move to LocalDirSetting
1402 (LocalDirSetting::load): Copied from LocalDirPage::OnInit.
1403 * site.h (SitePage::OnInit): Remove.
1404 (SitePage::getSavedSites): New member, replaces get_saved_sites.
1405 (SitePage::registerSavedSite): New member, replaces
1406 register_saved_site.
1407 * site.cc (SitePage::OnInit): Move to SiteSetting::load().
1408 (SiteSetting::load): Copied from SitePage::OnInit.
1409 (SitePage::getSavedSites): Renamed from get_saved_sites.
1410 (SitePage::registerSavedSite): Renamed from register_saved_site.
1411 (do_download_site_info_thread): Don't look at the list size for
1412 determining if the download was successful.
1414 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1416 * choose.h (ChooserPage::setViewMode): Remove HWND from
1418 (ChooserPage::defaultTrust): Ditto.
1420 (ChooserPage::ifChecked): Use Window helper function
1422 * choose.cc (ChooserPage::setViewMode): Use chooser->GetHWND()
1424 Update all callers with new signature.
1425 (ChooserPage::defaultTrust): Ditto.
1427 * PickView.h (PickView::defaultTrust): Declare.
1428 * PickView.cc (PickView::defaultTrust): Copy from chooser.cc.
1430 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1432 * PickView.h (PickView::lv): Eliminate.
1433 * PickView.cc (PickView::init): Replace use of lv with
1435 (PickView::list_click): Ditto.
1436 * choose.h (ChooserPage::lv): Eliminate.
1437 * choose.cc: Replace lv with chooser->GetHWND()
1440 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1442 * PickView.h (PickView::chooser): Eliminate.
1443 (PickView::list_vscroll): Make non-static.
1444 (PickView::list_hscroll): Ditto.
1445 (PickView::list_click): Ditto.
1446 (PickView::paint): Ditto.
1447 * PickView.cc (PickView::list_vscroll): Eliminate use
1448 of PickView::chooser.
1449 (PickView::list_hscroll): Ditto.
1450 (PickView::list_click): Ditto.
1451 (PickView::paint): Ditto.
1452 * choose.cc (Chooser::createListView): Eliminate use
1453 of PickView::chooser.
1455 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1457 * PickView.h (PickView): Inherit from Window.
1458 (PickView::RegisterWindows): Move from ChooserPage.
1459 (PickView::listview_proc): Likewise.
1460 (PickView::paint): Ditto.
1461 (PickView::list_click): Ditto.
1462 (PickView::list_hscroll): Ditto.
1463 (PickView::list_vscroll): Ditto.
1464 (PickView::lv): Ditto.
1465 (PickView::chooser): Ditto.
1466 (PickView::Create): Override Windows::Create as we migrate.
1467 (PickView::registerWindowClass): Renamed RegisterWindows.
1468 (PickView::WindowClassAtom): Prevent double registration.
1469 (PickView::init): Declare.
1470 * PickView.cc: Adjust for new inheritance.
1471 (PickView::RegisterWindows): Move from ChooserPage.
1472 (PickView::listview_proc): Likewise.
1473 (PickView::paint): Ditto.
1474 (PickView::list_click): Ditto.
1475 (PickView::list_hscroll): Ditto.
1476 (PickView::list_vscroll): Ditto.
1477 (PickView::lv): Ditto.
1478 (PickView::chooser): Ditto.
1479 (PickView::Create): Introduce stub.
1480 (PickView::RegisterWindows): Rename
1481 (PickView::init): Extracted from constructor to allow
1483 * chooser.h (ChooserPage::registerWindows): Rename to
1484 PickView::RegisterWindows.
1485 (ChooserPage::listview_proc): Likewise.
1486 (ChooserPage::paint): Ditto.
1487 (ChooserPage::list_click): Ditto.
1488 (ChooserPage::list_hscroll): Ditto.
1489 (ChooserPage::list_vscroll): Ditto.
1490 (ChooserPage::lv): Duplicate into PickView, observe
1492 (ChooserPage::chooser): Ditto.
1493 * chooser.cc (ChooserPage::registerWindows): Delete.
1494 (ChooserPage::listview_proc): Ditto.
1495 (ChooserPage::paint): Ditto.
1496 (ChooserPage::list_click): Ditto.
1497 (ChooserPage::list_hscroll): Ditto.
1498 (ChooserPage::list_vscroll): Ditto.
1499 (ChooserPage::createListView): Create() on PickView.
1500 * window.h (Window::RegisterWindowClass): Make virtual
1501 to allow Create to become a Template Method, and rename
1502 to registerWindowClass as it's not static.
1503 * window.cc (Window::registerWindowClass): Ditto.
1504 (Window::FirstWindowProcReflector): BUGFIX: Set window
1505 handle to prevent races with the window procedure.
1507 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1509 * choose.cc (set_view_mode): Rename to ChooserPage::setViewMode.
1510 (default_trust): Rename to ChooserPage::defaultTrust.
1511 (fill_missing_category): Rename to ChooserPage::fillMissingCategory.
1512 (set_existence): Rename to ChooserPage::setExistence.
1513 (register_windows): Rename to ChooserPage::registerWindows.
1514 (listview_proc): Rename to ChooserPage::listview_proc.
1515 (paint): Rename to ChooserPage::paint.
1516 (list_click): Rename to ChooserPage::list_click.
1517 (list_hscroll): Rename to ChooserPage::list_hscroll.
1518 (list_vscroll): Rename to ChooserPage::list_vscroll.
1519 (lv): Rename to ChooserPage::lv.
1520 (chooser): Rename to ChooserPage::chooser.
1521 * choose.h (ChooserPage::setViewMode): Declare.
1522 (ChooserPage::defaultTrust): Declare.
1523 (ChooserPage::fillMissingCategory): Declare.
1524 (ChooserPage::setExistence): Declare.
1525 (ChooserPage::registerWindows): Declare.
1526 (ChooserPage::listview_proc): Declare.
1527 (ChooserPage::paint): Declare.
1528 (ChooserPage::list_click): Declare.
1529 (ChooserPage::list_hscroll): Declare.
1530 (ChooserPage::list_vscroll): Declare.
1531 (ChooserPage::lv): Declare.
1532 (ChooserPage::chooser): Declare.
1534 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1536 * choose.cc (create_listview): Use for_each instead of explicit
1538 (create_listview): Rename to ChooserPage::createListview.
1539 * package_meta.h (packagemeta::set_requirements): Explicitly separate
1540 the 1 and 2 parameter versions.
1542 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
1544 * String++.h (String::operator !=): Declare for char * and String.
1545 * String++.cc (String::operator !=): Implement.
1546 * package_meta.cc(StringConcatenator): Move above all users.
1547 (_visit_if): Predicate support for visitors.
1548 (packagemeta::getReadableCategoryList): Refactor to use
1549 StringConcatenator with a predicate.
1550 * choose.h: Remove unneeded c++ guards.
1552 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
1554 * choose.cc (scan_downloaded_files): Rename to
1555 packagemeta::ScanDownloadedFiles.
1556 (scanAVersion): Rename to packageversion::scan.
1557 (GetParentRect): Rename to ChooserPage::getParentRect.
1558 * choose.h (ChooserPage::getParentRect): Declare.
1559 * package_meta.h (packagemeta::ScanDownloadedFiles): Declare.
1560 * package_version.h (packageversion::scan): Declare.
1561 * package_version.cc (packageversion::scan): Move from choose.cc
1562 * package_meta.cc (packagemeta::ScanDownloadedFiles): Move from
1565 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
1567 * choose.cc (ChooserPage::OnNext): log before starting activity threads.
1568 (ChooserPage::OnInit): Remove temporary variable frame.
1569 (ChooserPage::setPrompt): Extract method from OnInit.
1570 (choose_inst_text): Remove unused variable.
1571 * choose.h(ChooserPage::setPrompt): Declare
1572 * res.rc (IDD_CHOOSE): Bugfix: the chooser was setting a non-present
1575 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
1577 Remove package specific code from choose.cc.
1578 Update copyrights where appropriate.
1579 * choose.cc(ChooserPage::OnNext): Extract logging to
1580 packagemeta::logSelectionStatus.
1581 * package_meta.cc(packagemeta::logSelectionStatus): Extract from
1582 ChooserPage::OnNext.
1583 (StringConcatenator): helper for logSelectionStatus.
1584 (action_caption): Make const.
1585 * package_meta.h(packagemeta): Declare logSelectionStatus.
1586 (packagemeta::action_caption): Make const.
1587 * package_version.cc(packageversion::sourcePackage): Make const.
1588 * package_version.h(packageversion::sourcePackage): Make const.
1590 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
1592 * choose.cc: Update copyright.
1593 (ChooserPage::keepClicked): Extracted from OnMessageCmd.
1594 (ChooserPage::changeTrust): Ditto.
1595 * choose.h (ChooserPage): Declare keepClicked and changeTrust.
1596 (ChooserPage::ifChecked): Extracted from OnMessageCmd.
1597 * package_meta.h (SetRequirement): Adapter for visiting package
1600 2003-07-26 Max Bowsher <maxb@ukf.net>
1602 * tests/.cvsignore: New file, listing Makefile.in.
1604 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
1606 Save used local cache dir from initial run of setup, so the user doesn't
1608 * localdir.h (LocalDirSetting): UserSetting class for the local cache
1610 * localdir.cc (LocalDirSetting::save): Replace save_local_dir, and
1613 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
1615 Save used site from initial run of setup, so the user doesn't need to
1617 * main.cc (main): Load and save all user settings.
1618 * site.cc (SiteSetting::save): Migrate logic from save_site_url.
1619 (SitePage::OnNext): Use ChosenSites.save() to remove uneeded
1621 (save_site_url): Delete.
1622 * site.h (save_site_url): Remove declaration.
1623 * .cvsignore: Update autoconf generated files.
1625 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
1627 * tests/Makefile.am: Driver for test suite.
1628 * tests/UserSettingTest.cc: Test UserSetting interface.
1629 * tests/UserSettingsTest.cc: Test UserSettings interface.
1630 * Makefile.am: Add the tests dir to recurse into.
1631 * configure.in: Ditto.
1632 * UserSetting.h: Add load and save methods to allow global
1634 Add explicit copy and assignment operators to prevent synthetics.
1635 Make the constructor protected to prevent direct instantiation.
1636 * UserSettings.h (UserSettings::loadAllSettings): New method.
1637 (UserSettings::savedAllSettings): New method.
1638 * UserSettings.cc: Implement new methods.
1639 * site.cc: Implement stubs for new required UserSetting methods.
1640 * site.h (ChosenSite): Ditto.
1641 * bz2lib/: Ran automake.
1642 * zlib/: Ran automake.
1644 2003-07-23 Max Bowsher <maxb@ukf.net>
1646 * desktop.cc (DesktopSetupPage::OnBack): Remove obsolete use of NEXT().
1647 * root.cc (RootPage::OnNext): Ditto.
1648 (RootPage::OnBack): Ditto.
1649 * install.cc (do_install_thread): Remove obsolete use of next_dialog.
1650 * main.cc (main): Ditto.
1651 * postinstall.cc (do_postinstall_thread): Ditto.
1653 2003-07-23 Max Bowsher <maxb@ukf.net>
1655 * dialog.h (do_choose, do_desktop, do_local_dir, do_net, do_other)
1656 (do_root, do_site, do_source, do_splash): Remove declarations, since
1657 these functions no longer exist.
1659 2003-07-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1661 * choose.cc (initialized): Remove obsolete file scope variable.
1663 2003-07-18 Max Bowsher <maxb@ukf.net>
1665 * res.rc: Make caption of every dialog page begin with "Cygwin Setup".
1666 This aids recognition when minimized.
1667 Prompted by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
1669 2003-07-10 Jeremy White <jwhite@codeweavers.com>
1671 * mount.cc, root.cc, site.cc: Make StringOptions required,
1672 thereby making --longopt <parm> behave as a newbie would expect.
1674 2003-07-08 Max Bowsher <maxb@ukf.net>
1676 * LogFile.h, cistring.h, dialog.h, diskfull.h, filemanip.h, geturl.h,
1677 hash.h, log.h, mkdir.h, mklink2.h, mount.h, msg.h, netio.h, nio-file.h,
1678 nio-ftp.h, nio-http.h, nio-ie5.h, port.h, simpsock.h, state.h,
1679 version.h: Add inclusion guard.
1680 * root.h: Standardize naming of inclusion guard.
1682 2003-06-23 Max Bowsher <maxb@ukf.net>
1684 * AntiVirus.h, Exception.h, FilterVisitor.h, FindVisitor.h,
1685 IOStreamProvider.h, IniDBBuilder.h, IniDBBuilderPackage.h,
1686 IniParseFeedback.h, IniParseFindVisitor.h, LogSingleton.h, MD5++.h,
1687 PackageSpecification.h, PackageTrust.h, PickCategoryLine.h, PickLine.h,
1688 PickPackageLine.h, PickView.h, RECTWrapper.h, ScanFindVisitor.h,
1689 String++.h, UserSetting.h, UserSettings.h, archive.h, archive_tar.h,
1690 category.h, choose.h, compress.h, compress_bz.h, compress_gz.h,
1691 cygpackage.h, desktop.h, download.h, find.h, ini.h, io_stream.h,
1692 io_stream_cygfile.h, io_stream_file.h, io_stream_memory.h,
1693 io_stream_rsync.h, localdir.h, net.h, package_db.h, package_meta.h,
1694 package_source.h, package_version.h, proppage.h, propsheet.h, script.h,
1695 site.h, source.h, splash.h, threebar.h, win32.h, window.h:
1696 Standardize naming and placement of inclusion guards.
1698 2003-06-22 Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>
1700 * res.rc (all dialogs): Change font from "MS Sans Serif" to
1703 2003-06-22 Max Bowsher <maxb@ukf.net>
1705 * Makefile.am: Clarify comment.
1706 Derive AM_CFLAGS from AM_CXXFLAGS, rather than the other way around.
1707 (AM_CXXFLAGS): Remove -Wmissing-declarations - it is a C-only warning.
1708 (AM_CFLAGS): Add -Winline, and -Wmissing-declarations.
1710 2003-06-22 Max Bowsher <maxb@ukf.net>
1712 * rfc1738.cc (rfc1738_do_escape): Eliminate redundant conditional.
1714 2003-06-05 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1716 * window.h (SETUP_WINDOW_H): Rename multi-include guard.
1717 (Copyright): Update.
1718 (RECTWrapper): New forward declaration.
1719 (Window::Create): Move.
1720 (Window::MoveWindow): New overload declaration.
1721 * window.cc: (RECTWrapper.h) Include.
1722 (Copyright): Update.
1723 (Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
1725 (Window::MoveWindow): New overload.
1727 2003-05-31 Max Bowsher <maxb@ukf.net>
1729 * res.rc: Resize title controls to fully fill available width.
1731 2003-05-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1733 * RECTWrapper.h: New file.
1735 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1737 * script.cc (Script::extension): Extract method from Script::run.
1738 (Script::run): Extract extension generation to Script::extension.
1739 * script.h (Script::extension): Declare.
1741 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1743 * script.cc (run_script): Remove.
1744 (try_run_script): Inline method run_script.
1745 * script.h (run_script): Remove.
1747 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1749 * postinstall.cc (RunScript::operator()): Use new run syntax.
1750 * script.h (Script::run): Eliminate to_log parameter.
1751 * script.cc (Script::run): Ditto.
1752 (run_script): Use new run syntax.
1754 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1756 * script.cc (Script::run): Eliminate temp variable 'f2'.
1757 Rename temp variable 'f2' to 'windowsName' for increased clarity.
1759 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1761 * script.cc (Script::run): Eliminate temp variable 'fname'.
1763 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1765 * script.cc (Script::run): Eliminate temp variable 'dir'.
1767 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1769 * script.cc (run_script): Always pass TRUE to Script::run.
1770 * script.h (run_script): Remove optional to_log parameter.
1772 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1774 * script.cc (run_script): Move functionality into Script.
1775 (Script::run): Absorb run_script.
1777 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
1779 * PickCategoryLine.cc (PickCategoryLine::click): Tell packagemeta we
1780 are about to perform a visit.
1781 * PickPackageLine.cc (PickPackageLine::click): Tell packagemeta we
1782 are about to perform a visit.
1783 * package_db.cc (packagedb::markUnVisited): Convenience wrapper -
1784 mark all packages as unvisited.
1785 * package_db.h (packagedb::markUnVisited): Declare.
1786 * package_meta.cc (packagemeta::PrepareForVisit): New static method
1787 to prepare for a loop-free visit.
1788 (packagemeta::packagemeta): Adjust for new member.
1789 (packagemeta::set_requirements): Only visit a node once.
1790 (packagemeta::visited): Get and Set methods for new member visited_.
1791 * package_meta.h (packagemeta::PrepareForVisit): Declare.
1792 (packagemeta::visited): Declare.
1793 (packagemeta::visited_): Declare.
1795 2003-04-07 Max Bowsher <maxb@ukf.net>
1797 * download.cc: Add command line option to suppress MD5 checks.
1798 (validateCachedPackage): Test option and possibly skip.
1800 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1802 Merge in setup-200303-troubleshooting fixes.
1804 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1806 * main.cc (NTSecurity::setDefaultDACL): Reinstate commented code.
1807 (NTSecurity::setDefaultSecurity): Ditto.
1809 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1811 * main.cc (NTSecurity::setDefaultDACL): Use MS calculations for ACL
1814 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1816 * main.cc (NTSecurity::setDefaultDACL): Sanity check memory allocation.
1818 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1820 * main.cc (NTSecurity::setDefaultDACL): Adjust commented code for
1823 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1825 * main.cc (NTSecurity::NoteFailedAPI): Helper function.
1826 Use throughout NTSecurity routines.
1827 (NTSecurity::setDefaultDACL): Use dynamic memory for ACL storage.
1829 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1831 * main.cc (NTSecurity::setDefaultDACL): Disable ~ 50% of remaining
1834 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1836 * main.cc (NTSecurity::GroupInfo): Extract group query code.
1837 (NTSecurity::setDefaultDACL): Disable ~ 50% of code.
1839 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
1841 * main.cc (NTSecurity::setDefaultSecurity): Disable ~ 50% of security
1844 2003-04-01 Robert Collins <rbtcollins@hotmail.com>
1846 * main.cc (NTSecurity::setDefaultSecurity): Remove double declaration of
1847 sz. User TokenGroupCollection to abstract token searching logic,
1848 eliminate isadmin and isuser temporary variables.
1849 (TokenGroupCollection): New class for querying token group information.
1851 2003-04-01 Robert Collins <rbtcollins@hotmail.com>
1853 * main.cc (NTSecurity::setDefaultSecurity): Extract esid initialisation.
1854 Move local variables to just before first use.
1855 SetTokenInformationFailures where being handled inconsistently.
1856 Remove assignments from if statements.
1857 (NTSecurity::esid): Rename to everyOneSID.
1858 (NTSecurity::initialiseEveryOneSID): new method.
1859 (NTSecurity::setDefaultDACL): Extract method for default DACL logic.
1861 2003-04-01 Robert Collins <rbtcollins@hotmail.com>
1863 * main.cc (SIDWrapper): Manage SID memory.
1864 (HANDLEWrapper): Likewise for HANDLES.
1865 (NTSecurity): Worker class for set_default_sec().
1866 (set_default_sec): Move body into NTSecurity::setDefaultSecurity().
1867 (NTSecurity::setDefaultSecurity): Eliminate goto out: via memory
1870 2003-04-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
1872 * cygwin.ico: Added two new resolutions, 64x64 and 72x72.
1874 2003-03-29 Robert Collins <rbtcollins@hotmail.com>
1876 * GUIDELINES: New file documenting code guidelines.
1878 2003-03-26 Max Bowsher <maxb@ukf.net>
1880 * .cvsignore: Add cfgaux.
1882 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
1884 * package_version.cc (_defaultversion::accessible): Override and make
1886 (_packageversion::accessible): Fix a couple of logic bugs resulting in
1888 * package_version.h (_packageversion::accessible): Make virtual.
1890 2003-03-25 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1892 * threebar.h (WM_APP_START_POSTINSTALL): New message.
1893 (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message.
1894 * threebar.cc (ThreeBarProgressPage::OnMessageApp):
1895 Add handling for WM_APP_START_POSTINSTALL and
1896 WM_APP_POSTINSTALL_THREAD_COMPLETE.
1897 * install.cc (do_install_thread): Set next_dialog to
1899 * desktop.cc (DesktopSetupPage::OnFinish): Move the
1900 do_postinstall call to ThreeBarProgressPage::OnMessageApp.
1901 * script.h (Script::fullName): New member function.
1902 (Script::run): New member function.
1903 (Script::ETCPostinstall): New static member constant.
1904 * script.cc (Script::fullName): Implement.
1905 (Script::run): Implement.
1906 (Script::ETCPostinstall): Define.
1907 (Script::isAScript): Use ETCPostinstall instead of a
1908 hardcoded string constant.
1909 (run): Enable "#if 0"'d code.
1910 * postinstall.cc (Progress): New extern variable.
1911 (RunFindVisitor::visitFile): Add script to vector
1913 (RunFindVisitor::_scripts): New member variable.
1914 (RunScript): New helper class for use in for_each.
1915 (do_postinstall_thread): Rename do_postinstall to. Add
1916 Progress bar and text setting. Add package count.
1917 (do_postinstall_reflector): New static function.
1918 (do_postinstall): Rename to do_postinstall_thread.
1919 Create a thread instead.
1921 2003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1923 * script.cc (run): Add file_out parameter.
1924 Redirect output of subprocess to file, creating the
1925 path if necessary. Minimize the script window.
1926 (run_script): Add optional to_log boolean parameter.
1927 If to_log, redirect output to temporary file and then
1928 import it into LOG_BABBLE.
1929 (OutputLog): New helper class.
1930 (operator<<): New operation on OutputLog.
1931 * script.h (run_script): Add optional to_log parameter.
1932 * postinstall.cc (RunFindVisitor::visitFile): Instruct
1933 run_script() to log script output.
1934 (do_postinstall): Ditto.
1936 2003-03-20 Robert Collins <rbtcollins@hotmail.com>
1938 * package_meta.cc (packagemeta::set_action): The logic
1939 test for the default action was reversed.
1941 2003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1943 * postinstall.cc (do_postinstall): Filter out '*.done'.
1944 * FilterVisitor.h: New header file. Declare the
1945 FilterVisitor, Filter, and ExcludeNameFilter classes.
1946 * FilterVisitor.cc: New file. Implement FilterVisitor,
1947 Filter, and ExcludeNameFilter.
1948 * String++.h (String::matches): New instance function.
1949 * String++.cc (String::matches): Implement.
1950 (strmatch) Import and adapt for <buf,len> strings.
1951 * Makefile.am (setup_SOURCES): Add FilterVisitor.cc and
1952 FilterVisitor.h to value.
1954 2002-03-18 Max Bowsher <maxb@ukf.net>
1956 * LogFile.cc (LogFile::exit): Use CRT exit() instead of ExitProcess().
1957 Use passed exit_code even if been_here.
1958 Remove incorrect _CYGWIN_ preprocessor conditional.
1960 2003-03-16 Robert Collins <rbtcollins@hotmail.com>
1962 * package_db.h (PackageDBConnectedIterator): Typedef
1963 for connected loop detection collection iterator.
1964 * package_db.cc (ConnectedLoopDetector): An
1965 implementation of R.E. Tarjans strongly connected
1966 set visitor algorithm.
1967 * postinstall.cc (do_postinstall): Use the new iterator
1968 for visiting postinstall scripts.
1970 2003-03-16 Robert Collins <rbtcollins@hotmail.com>
1972 * install.cc: Introduce Installer class.
1973 (init_dialog): Rename to Installer::initDialog.
1974 (progress): Rename to Installer::progress.
1975 (standard_dirs): Rename to Installer::StandardDirs.
1976 (uninstall_one): Rename to Installer::uninstallOne.
1977 (replace_one): Rename to Installer::replaceOne.
1978 (log_ror_failure): Rename to
1979 Installer::replaceOnRebootFailed.
1980 (log_ror_success): Rename to
1981 Installer::replaceOnRebootSucceeded.
1982 (install_one_source): Rename to Installer::installOneSource.
1983 Note script files as they are installed.
1984 * package_version.cc (packageversion::addScript): Implement.
1985 (packageversion::scripts): Implement.
1986 * package_version.h (packageversion::addScript): Record the
1987 presence of a script.
1988 * script.h (Script): New class to track scripts.
1989 * postinstall.cc (do_postinstall): Iterate through the
1990 package listed scripts before searching for scripts.
1991 * String++.cc (String::substr): Second argument needed to
1993 * String++.h (String::substr): Second argument needed to
1996 2003-03-16 Max Bowsher <maxb@ukf.net>
1998 * .cvsignore: Create, to ignore configure, aclocal.m4, Makefile.in and
2001 2003-03-16 Max Bowsher <maxb@ukf.net>
2003 * UserSettings.cc (UserSettings::Instance): Remove premature return.
2005 2003-03-15 Robert Collins <rbtcollins@hotmail.com>
2007 * script.cc (run): Rename variable b to createSucceeded.
2009 2003-03-15 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2011 * script.cc (run): Close unneeded handles.
2013 2003-03-15 Robert Collins <rbtcollins@hotmail.com>
2015 * configure: Remove.
2016 * aclocal.m4: Remove.
2017 * Makefile.in: Remove.
2019 * cfgaux/compile: Remove.
2020 * cfgaux/config.guess: Remove.
2021 * cfgaux/config.sub: Remove.
2022 * cfgaux/depcomp: Remove.
2023 * cfgaux/install-sh: Remove.
2024 * cfgaux/ltmain.sh: Remove.
2025 * cfgaux/missing: Remove.
2026 * cfgaux/mkinstalldirs: Remove.
2028 2003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2030 * install.cc (replace_one): Clear Text3.
2032 2003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2034 * install.cc (install_one_source): Add logging for successful
2035 replace-on-reboot scheduling. Factor out duplicate code.
2036 Set rebootneeded on Win9x.
2037 (log_ror_failure): New static function.
2038 (log_ror_success): New static function.
2040 2003-03-14 Robert Collins <rbtcollins@hotmail.com>
2042 * choose.cc (ChooserPage::OnNext): Fix iterator bug. Reported by
2043 Igor Pechtchanski <pechtcha@cs.nyu.edu>.
2045 2003-03-13 Max Bowsher <maxb@ukf.net>
2047 * Update included zlib to 1.1.4.
2049 2003-03-13 Robert Collins <rbtcollins@hotmail.com>
2051 * install.cc (do_install_thread): Use a query method rather than temp
2054 2003-03-09 Pavel Tsekov <ptsekov@gmx.net>
2056 * install.cc (do_install_thread): Use IDS_SKIP_PACKAGE
2057 instead of IDS_CORRUPT_PACKAGE when asking the user to take
2058 action if the hash verification check fails for a source package.
2059 Do not increase the value of 'total_bytes' variable if the
2060 user chooses to skip over a package, which failed the hash
2063 2003-03-10 Max Bowsher <maxb@ukf.net>
2065 * Makefile.am: Add foreign to AUTOMAKE_OPTIONS.
2067 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
2069 * UserSettings.cc (UserSettings::init): Really initialize all members.
2071 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
2073 * Exception.h: Add a logic error exception id.
2074 * Makefile.am: Add new sources.
2075 * UserSettings.cc: New file.
2076 * UserSettings.h: New file.
2077 * UserSetting.cc: New file.
2078 * UserSetting.h: New file.
2079 * site.h: Add a SiteSetting as example of a UserSetting.
2080 * site.cc (ChosenSites): Add a instance of SiteSetting to trigger
2083 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
2085 * compress_bz.cc (compress_bz::read): Adjust incorrect assignment of
2087 (compress_bz::error): Return lasterr which will indicate any error.
2089 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
2091 * choose.h (ChooserPage): Override OnActivate.
2092 * choose.cc (ChooserPage::OnActivate): Refresh the current view when
2093 activating the dialog.
2095 2003-03-09 Robert Collins <rbtcollins@hotmail.com>
2097 * package_version.cc (_defaultversion::pick(bool)): Override this and
2099 (packageversion::pick(bool): Use a mutator function rather than direct
2101 * package_version.h (_packageversion::pick(bool)): Move method from
2104 2003-02-16 Pavel Tsekov <ptsekov@gmx.net>
2106 * install.cc (install_one_source): Remove the MD5 verification
2108 Delay the creation of the package listing file.
2109 (do_install_thread): Check the hashes for packages which need
2110 to be installed before the uninstall step. Allow the user to
2111 skip over packages, which fail the hash verification.
2112 (md5_one): Define new function.
2113 * res.rc (IDS_SKIP_PACKAGE): New string resource.
2114 * resource.h (IDS_SKIP_PACKAGE): New macro definition.
2116 2003-02-16 Pavel Tsekov <ptsekov@gmx.net>
2118 * Exception.h: Declare new constructor.
2119 (Exception::_message): Change the type from 'const char *' to
2121 (Exception::~Exception): Implement destructor (make gcc shut up).
2122 * Exception.cc: Implement new constructor.
2123 (Exception::what): Use String::cstr_oneuse ().
2124 * download.cc (validateCachedPackage): Use the constructor, which
2125 takes String& as its second argument, when throwing objects
2127 (check_for_cached): Ditto.
2128 * install.cc (install_one_source): Ditto.
2130 2003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2132 * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
2134 (IDS_MISSING_LOG): New string resource.
2135 * resource.h (IDS_MISSING_LOG): New resource.
2136 * LogFile.cc (LogFile::exit): Pass log filename for
2137 LOG_BABBLE to note().
2138 (LogFile::getFileName): New function.
2139 * LogFile.h (LogFile::getFileName): New function.
2141 2003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2143 * String++.cc: Don't include concat.h.
2144 * Makefile.am: Remove concat.cc and concat.h references.
2146 * concat.cc: Remove.
2148 2003-03-09 Max Bowsher <maxb@ukf.net>
2150 * bootstrap.sh: Add sanity check of current directory.
2151 Recurse into libgetopt++ if needed.
2153 2003-03-09 Robert Collins <rbtcollins@hotmail.com>
2155 * Update readme of bugs and wishes.
2157 2003-03-05 Max Bowsher <maxb@ukf.net>
2159 * netio.cc (save_dialog): Allocate an empty string if the password is
2160 null, so that an empty password is accepted elsewhere in setup.
2161 (check_if_enable_ok): An empty password is OK.
2163 2003-03-05 Brian Keener <bkeener@thesoftwaresource.com>
2165 * PickView.cc (PickView::views): Add two new views for Skipped
2166 packages and Installed Packages not requiring update.
2167 (PickView::set_headers () ): Ditto.
2168 (PickView::clear_view (void) ): Ditto.
2169 (PickView::views::caption () ): Add two new captions for the new
2170 views added for Skipped and Installed Packages.
2171 (PickView::scroll () ): Modify Scroll Bar property to Disable
2172 instead of disappearing when there is nothing to Scroll.
2173 * PickView.h: Add two new views for Skipped packages and Installed
2174 packages to public class view.
2175 * choose.cc (list_click () ): Modify Scroll Bar property to Disable
2176 instead of disappearing when there is nothing to Scroll.
2177 (listview_proc () ): Ditto.
2178 (set_view_mode): Add two new views for Skipped Packages and Installed
2179 Packages not requiring update. Modify Scroll Bar property to Disable
2180 instead of disappearing when there is nothing to scroll.
2181 * res.rc (IDD_CHOOSE): Reposition Radio Buttons, View Selection
2182 Button and View Button Caption to make room for longer captions.
2184 2003-03-04 Max Bowsher <maxb@ukf.net>
2186 * compress_gz.cc (compress_gz::construct):
2187 Fix broken checkin dated 2002-07-03.
2189 2003-02-28 Max Bowsher <maxb@ukf.net>
2191 * main.cc (set_default_sec): Add logging.
2193 2003-02-28 Pierre Humblet <pierre.humblet@ieee.org>
2195 * main.cc (set_default_dacl): Replace with set_default_sec.
2196 (set_default_sec): Attempt to change the default group to
2197 Users or Administrators if it is None, in addition to setting
2198 Everyone in the default DACL.
2199 (main): Call set_default_sec instead of set_default_dacl.
2201 2003-01-31 Max Bowsher <maxb@ukf.net>
2203 * install.cc (install_one_source): Fix spacing in log message.
2205 2003-01-19 Max Bowsher <maxb@ukf.net>
2207 * resource.h (IDC_CHOOSE_KEEP): Define.
2208 * res.rc (IDD_CHOOSE): Add radio button IDC_CHOOSE_KEEP.
2209 * choose.cc (create_listview): Add IDC_CHOOSE_KEEP to ta[].
2210 (ChooserPage::OnMessageCmd): Handle new IDC_CHOOSE_KEEP button.
2212 2003-01-15 Max Bowsher <maxb@ukf.net>
2214 * mkdir.cc [_CYGWIN_]: Implement what was pseudocode.
2215 * io_stream.h [__CYGWIN__]: Don't typedef ssize_t.
2216 * proppage.h: Include "win32.h" instead of <windows.h>.
2218 2003-01-15 Max Bowsher <maxb@ukf.net>
2220 * mount.cc [MAINTAINER_FEATURES]: Add --override-registry-name option.
2222 2002-12-11 Abraham Backus <abraham@backus.com>
2224 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Leave port out of Host header,
2227 2002-12-11 Max Bowsher <maxb@ukf.net>
2229 * package_meta.cc: Change 'endl' to 'endLog' as appropriate.
2230 * package_version.cc: Ditto.
2232 2002-09-22 Max Bowsher <maxb@ukf.net>
2234 * PickView.cc (pkg_headers): Rename column 'Category' to 'Categories'.
2235 * package_meta.h (packagemeta::getReadableCategoryList): Declare.
2236 * package_meta.cc (packagemeta::getReadableCategoryList): Implement.
2237 * PickPackageLine.cc (PickPackageLine::paint): Change to use
2238 getReadableCategoryList.
2239 Fix x2 argument to IntersectClipRect.
2241 2002-11-25 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2243 * window.h (Window::GetWindowRect): New method declaration.
2244 (Window::GetClientRect): Ditto.
2245 (Window::MoveWindow): Ditto.
2246 (Window::ScreenToClient): Ditto.
2247 * window.cc (REFLECTION_INFO): Remove.
2248 (ReflectionInfo): Remove.
2249 (Window::FirstWindowProcReflector): Use the WM_NCCREATE message instead
2250 of the horrid REFLECTION_INFO hack to hook the Window instance to the
2252 (Window::WindowProcReflector): Use GetWindowLongPtr() now that it's
2254 (Window::Create): Change to use new WM_NCCREATE reflection procedure
2256 (Window::GetWindowRect): New method.
2257 (Window::GetClientRect): New method.
2258 (Window::MoveWindow): New method.
2259 (Window::CenterWindow): Use new methods, also specify "::" for some non-
2260 member functions with the same names.
2261 (Window::ScreenToClient): New method.
2263 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
2265 * AntiVirus.cc: Change the short option again! It's now 'A'.
2266 * desktop.cc (etc_profile): Remove.
2267 (make_etc_profile): Remove.
2269 (make_passwd_group): Remove.
2270 (do_desktop_setup): Don't call removed functions.
2272 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
2274 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fix my botched application of
2277 2002-07-08 Marcel Telka <marcel@telka.sk>
2279 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fixed decoding of the FTP
2280 reply (code 227) to the PASV command.
2282 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
2284 * IniDBBuilderPackage.cc (IniDBBuilderPackage::~IniDBBuilderPackage):
2285 Sort the packages db once all the new packages have been added.
2286 * IniDBBuilderPackage.h (IniDBBuilderPackage::~IniDBBuilderPackage):
2289 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
2291 * choose.cc (ChooserPage::OnNext): Remove extracted comment.
2292 * package_version.cc (processOneDependency): Return once selecting
2293 a package (bugfix to prevous rework).
2294 Log if the default trust fails the package specification.
2296 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
2298 * package_meta.h (packagemeta::logAllVersions): Declare.
2299 (packagemeta::trustLabel): Ditto.
2300 * choose.cc (ChooserPage::OnNext): Get each package to log all it's
2302 * package_meta.cc (packagemeta::logAllVersions): Implement.
2303 (packagemeta::trustLabel): Ditto.
2305 2002-11-25 Robert Collins <rbtcollins@hotmail.com>
2307 * AntiVirus.cc: Change 'd' to 'D' to fix command line conflict.
2309 2002-11-25 Robert Collins <rbtcollins@hotmail.com>
2311 * AntiVirus.cc: New file.
2312 * AntiVirus.h: Ditto.
2313 * LogFile.cc: Include AntiVirus.h for class definition.
2314 (LogFile::exit): Trigger AntiVirus::AtExit().
2315 * MakeFile.am(setup_SOURCES): Add AntiVirus files.
2316 * autoload.c: Declare Service Control Manager related API's.
2317 * main.cc: Include AntiVirus.h for class definition.
2318 (main): Add the AntiVirus page in.
2319 * res.rc: Define IDD_VIRUS.
2320 * resource.h: Define IDD_VIRUS related control ID's.
2321 * splash.h: Override OnNext.
2322 * splash.cc: Only show AntiVirus page when one has been detected.
2325 2002-11-25 Robert Collins <rbtcollins@hotmail.com>
2327 * package_version.cc (DependencyProcessor): Create convenience class.
2328 (select): Extract version selection method.
2329 (processOneDependency): Check for a satisfactory trusted version
2332 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
2334 * main.cc (main): Use the factory for LogFile.
2335 * String++.cc: Update to use sstream.
2336 (String::String): Use a ostringstream for libC++ 3.2.
2337 * LogFile.h (LogFile): Make createLogFile static.
2339 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
2341 * main.cc (main): Oops, pass LogSingleton a reference, not a pointer.
2343 2002-11-04 Max Bowsher <maxb@ukf.net>
2345 * Exception.h (Exception::what): Add throw() specification,
2346 to agree with libstdc++-v3.
2347 * Exception.cc (Exception::what): Ditto.
2348 * IniDBBuilderPackage.h: Add 'std::' where needed.
2349 * PickCategoryLine.h: Ditto.
2350 * category.h: Ditto.
2351 * package_db.h: Ditto.
2352 * package_meta.h: Ditto.
2353 * package_source.h: Ditto.
2354 * package_version.h: Ditto.
2356 * win32.h: Define NOMINMAX before including <windows.h>.
2357 * package_meta.cc: Add 'using namespace std;'.
2358 (packagemeta::set_requirements): Remove default parameter values
2359 from definition (gcc3 likes them only in declaration).
2360 * package_version.cc: Add 'using namespace std;'.
2361 (packageversion::set_requirements): Remove default parameter
2362 values from definition (gcc3 likes them only in declaration).
2364 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
2366 * compress_bz.cc: Don't include bzlib.h directly, the compress_bz.h
2369 2002-11-04 Max Bowsher <maxb@ukf.net>
2371 * compress_bz.h: #undef small before including bzlib.h - if we are
2372 going to hide the fact that we are _WIN32 from bzlib, then we need
2373 to #undef small for it as well (bad windows.h clash).
2375 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
2377 * localdir.cc: Update the extern LogFile to be a pointer.
2378 (save_local_dir): Change . to -> for the above.
2379 * main.cc (theFile): Change from an instance to a pointer.
2380 (main): Change . to -> for the above.
2382 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
2384 * LogFile.cc: use 'std::' where needed throughout.
2385 (LogFile::createLogFile): Implement a factory for LogFile.
2386 (LogFile::LogFile): Update for use with the factory, and to
2387 handle the latest g++ library changes.
2388 (LogFile::operator()): Ditto.
2389 (LogFile::endEntry()): Ditto.
2391 * LogSingleton.cc: Ditto.
2392 * LogSingleton.h: Ditto.
2394 2002-11-04 Max Bowsher <maxb@ukf.net>
2396 * String++.h: Add 'std::' where needed.
2398 2002-11-04 Max Bowsher <maxb@ukf.net>
2400 * IniDBBuilderPackage.cc: Add 'using namespace std;'.
2401 * IniParseFindVisitor.cc: Ditto.
2402 * LogFile.cc: Ditto.
2403 * LogSingleton.cc: Ditto.
2404 * PickView.cc: Ditto.
2405 * String++.cc: Ditto.
2407 * download.cc: Ditto.
2409 * install.cc: Ditto.
2410 * io_stream.cc: Ditto.
2411 * io_stream_file.cc: Ditto.
2412 * package_db.cc: Ditto.
2416 2002-11-04 Max Bowsher <maxb@ukf.net>
2418 * LogSingleton.h: Add 'std::' where needed.
2420 2002-11-04 Max Bowsher <maxb@ukf.net>
2422 * archive_tar_file.cc: Include <algorithm>.
2423 Change min(a,b) to std::min(a,b)
2424 * compress_bz.cc: Ditto.
2425 * compress_gz.cc: Ditto.
2427 2002-11-04 Max Bowsher <maxb@ukf.net>
2429 * res.rc: Change a #-comment (invalid) to a //-comment.
2431 2002-11-04 Max Bowsher <maxb@ukf.net>
2433 * Makefile.am (%.o: %.rc): Make windres use $(CC) not hardcoded gcc.
2434 (inilint_LDADD): Remove -lstd++.
2435 (setup_LDADD): Ditto.
2437 2002-09-22 Max Bowsher <maxb@ukf.net>
2439 * IniDBBuilderPackage.cc: Update DEBUG code to current class
2442 2002-09-21 Robert Collins <rbtcollins@hotmail.com>
2444 * choose.h: Add OnUnattended method.
2445 * desktop.cc (DesktopSetupPage::OnInit): Allow fine grained
2446 control via command line options.
2447 (DesktopSetupPage::OnUnattended): Implement.
2448 (DesktopSetupPage::OnMessageApp): Implement.
2449 * desktop.h (DesktopSetupPage::OnUnattended): declare.
2450 (DesktopSetupPage::OnMessageApp): Ditto.
2451 * download.cc (do_download_thread): Support unattended mode.
2452 * install.cc (do_install_thread): Ditto.
2453 * localdir.h: Ditto.
2454 * main.cc (main): Ditto.
2455 * net.cc (NetPage::OnUnattended): Ditto.
2456 * net.h (NetPage::OnUnattended): Declare.
2457 * proppage.cc (PropertyPage::DialogProc): Support unattended mode.
2458 * proppage.h (PropertyPage::OnUnattended): Declare.
2459 * root.cc (RootPage::OnInit): Support unattended mode.
2460 (RootPage::OnUnattended): Implement.
2461 * root.h (RootPage::OnUnattended): Declare.
2462 * site.cc (register_saved_site): Extract Method from get_saved_sites.
2463 (get_saved_sites): Remove common code for adding a site.
2464 (SitePage::OnInit): Support unattended mode.
2465 (SitePage::OnUnattended): Implement.
2466 * site.h (SitePage::OnUnattended): Declare.
2467 * source.cc (SourcePage::OnActivate): Support unattended mode.
2468 (SourcePage::OnUnattended): Implement.
2469 * source.h (SourcePage::OnUnattended): Declare.
2470 * splash.h (SplashPage::OnUnattended): Declare.
2471 * state.cc (unattended_mode): Declare.
2472 * state.h (unattended_mode): Declare.
2473 * threebar.h (ThreeBarProgressPage::OnUnattended): New method.
2475 2002-09-21 Robert Collins <rbtcollins@hotmail.com>
2477 * res.rc: Commit Harry Johnston's dialog caption patch. From July.
2479 2002-07-15 Robert Collins <rbtcollins@hotmail.com>
2481 * package_version.cc (packageversion::sources): Implement this.
2482 * download.cc (do_download_thread): Support multiple files per package.
2484 2002-07-15 Robert Collins <rbtcollins@hotmail.com>
2486 * package_version.h (packageversion::sources): Support multiple files in
2487 a single package version.
2488 * package_version.cc (_packageversion::accessible): Ditto.
2489 (packageversion::source): Ditto.
2491 2002-07-15 Robert Collins <rbtcollins@hotmail.com>
2493 * iniparse.y: Implement support for multiple source files for a source
2495 * IniDBBuilder.h (IniDBBuilder::buildSourceFile): Ditto.
2496 * IniDBBuilderPackage.h (IniDBBuilder::buildSourceFile): Ditto.
2497 * IniDBBuilder.cc (IniDBBuilder::buildSourceFile): Ditto.
2498 * IniDBBuilderPackage.cc (IniDBBuilder::buildSourceFile): Implement a
2499 stub as preparation.
2501 2002-07-13 Robert Collins <rbtcollins@hotmail.com>
2503 * PickPackageLine.cc (PickPackageLine::click): Set requirements for
2504 packages under all circumstances - slightly higher overheader, simpler
2506 * download.cc (do_download_thread): Correctly download source
2508 * package_meta.cc (checkForInstalled): Remove.
2509 (checkForUpgradeable): Ditto.
2510 (checkForSatisfiable): Ditto.
2511 (processOneDependency): Ditto.
2512 (packagemeta::set_requirements): Move guts to packageversion.
2513 * package_version.cc (checkForInstalled): Copied from package_meta.cc.
2514 (checkForUpgradeable): Ditto.
2515 (checkForSatisfiable): Ditto.
2516 (processOneDependency): Ditto.
2517 (packageversion::set_requirements): Ditto.
2518 * package_version.h (packageversion::set_requirements): Declare.
2520 2002-07-13 Robert Collins <rbtcollins@hotmail.com>
2522 * IniDBBuilder.cc (IniDBBuilder::buildBeginBuildDepends): Implement.
2523 (IniDBBuilder::buildBeginBinary): Implement.
2524 * IniDBBuilder.h (IniDBBuilder::buildBeginBuildDepends): Declare.
2525 (IniDBBuilder::buildBeginBinary): Ditto.
2526 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildBeginBuildDepends):
2528 (IniDBBuilderPackage::buildBeginBinary): Ditto.
2529 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildBeginBuildDepends):
2531 (IniDBBuilderPackage::buildBeginBinary): Ditto.
2532 * inilex.l: Recognise Build-Depends-Indep, [,], >, < and remove
2534 * iniparse.y: Full support for parsing a debian Sources file in-line in
2536 * package_version.cc (packageversion::binaries): Implement.
2537 * package_version.h (packageversion::binaries): Declare list of what
2538 packages are created from a given source package.
2539 (_packageversion::binaries): Ditto.
2541 2002-07-10 Robert Collins <rbtcollins@hotmail.com>
2543 * iniparse.y: Add basis for support for parsing a debian Sources file.
2546 2002-07-09 Robert Collins <rbtcollins@hotmail.com>
2548 Change custom container code for packagedb::packages to STL containers
2550 * IniDBBuilderPackage.cc: Ditto.
2551 * PickView.cc: Ditto.
2553 * desktop.cc: Ditto.
2554 * download.cc: Ditto.
2555 * install.cc: Ditto.
2556 * package_db.cc: Ditto.
2557 * package_db.h: Ditto.
2558 * Makefile.am: Remove list.h references.
2561 2002-07-08 Max Bowsher <maxb@ukf.net>
2563 * PickView.cc (PickView::PickView): Set font of package list header to
2564 the same as used in the rest of the package list.
2566 2002-07-08 Robert Collins <rbtcollins@hotmail.com>
2568 * install.cc (NoReplaceOnReboot): New command line option to prevent
2569 replacing in use files.
2570 (install_one_source): Check the option and use it.
2571 * README: Update TODO lists.
2573 2002-07-08 Robert Collins <rbtcollins@hotmail.com>
2575 * PickCategoryLine.cc: Change bucket to use STL container syntax
2577 (PickCategoryLine::paint): Use new Category type syntax.
2578 * PickCategoryLine.h: Use STL vectors rather than custom containers
2580 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageCategory):
2581 Use new add_category syntax.
2582 * PickView.cc (PickView::insert_pkg): Use new Category type syntax.
2583 (PickView::insert_category): Ditto.
2584 (PickView::init_headers): Ditto.
2585 * category.cc: Trim obsolete code.
2586 * category.h: Replace interconnecting class with a typedef to
2587 facilitate leveraging STL maps.
2588 * choose.cc (fill_missing_category): Use updated pkg.add_category
2590 (default_trust): Use new Category type syntax.
2591 (set_view_mode): Ditto.
2592 (create_listview): Ditto.
2593 * package_db.cc (categories): Ditto.
2594 * package_db.h: Update headers list to include needed headers.
2595 (packagedb::categories): Replace custom list with STL map.
2596 * package_meta.cc: Use new Category type syntax throughout.
2597 (packagemeta::add_category): Implement new syntax.
2598 * package_meta.h: Remove commented out source.
2599 (packagemeta::add_category): Update syntax to decouple interface from
2602 2002-07-06 Christopher Faylor <cgf@redhat.com>
2604 * site.cc (do_download_site_info_thread): Correct spelling error.
2606 2002-07-06 Robert Collins <rbtcollins@hotmail.com>
2608 * PickCategoryLine.h: Include required header list.h.
2609 * PickPackageLine.cc (PickPackageLine::paint): Adjust to use STL
2610 containers for listing of packages per category and vice verca.
2611 * PickView.cc (PickView::insert_pkg): Ditto.
2612 (PickView::insert_category): Ditto.
2613 * String++.h (String::caseless): STL helper to allow trivial containers
2614 of Strings with case insensitive comparisons.
2615 * category.h: Adjust to use STL containers for listing of packages per
2616 category and vice verca.
2617 * choose.cc (fill_missing_category): Ditto.
2618 (default_trust): Ditto.
2619 (ChooserPage::OnNext): Ditto.
2620 * package_meta.cc (CategoryPackage::~CategoryPackage): Remove.
2621 (packagemeta::packagemeta): Adjust for new category list name.
2622 (packagemeta::~packagemeta): Adjust to use STL containers for listing
2623 of packages per category and vice verca.
2624 (packagemeta::set_action): Ditto.
2625 * package_meta.h (CategoryPackage): Remove.
2626 (packagemeta): Adjust to use STL containers for listing of packages per
2627 category and vice verca.
2629 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
2631 * io_stream.cc: Use STL containers rather than custom ones.
2632 (io_stream::registerProvider): Ditto.
2633 (findProvider): Ditto.
2635 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
2637 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
2638 Use STL collections for download site collections.
2639 (IniDBBuilderPackage::add_correct_version): Ditto.
2640 (IniDBBuilderPackage::process_src): Ditto.
2641 * PickPackageLine.cc (PickPackageLine::click): Use the packageversion
2642 accessible() call to abstract package availability.
2643 * choose.cc (scanAVersion): Use STL collections for download site
2645 * download.cc (check_for_cached): Ditto.
2646 (download_one): Ditto.
2647 * package_meta.cc (packagemeta::set_action): Use the packageversion
2648 accessible() call to abstract package availability.
2649 * package_source.h: Use STL containers rather than custom containers.
2650 (site): Create a == operator to allow STL container use.
2651 (packagesource::sites): Use STL containers rather than custom
2653 * package_version.cc (_packageversion::accessible): Use STL containers
2654 for download site containers.
2656 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
2658 * LogFile.cc: Use STL containers rather than custom containers.
2659 (filedef): Create == and < operators for STL use.
2660 (files): Convert to an STL set.
2661 (LogFile::setFile): Use STL operations on files.
2662 (LogFile::exit): Ditto.
2664 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
2666 * ini.cc (do_remote_ini): Use STL collection for site collection.
2667 * site.cc: Include site.h first to ensure it's parsable standalone.
2669 (site_list): Convert to an STL container.
2670 (all_site_list): Ditto.
2671 (site_list_type::site_list_type): Implement copy constructor.
2672 (site_list_type::operator=): Implement assignment operator.
2673 (site_list_type::operator ==): Implement.
2674 (site_list_type::operator <): Ditto.
2675 (save_dialog): Use STL collection calls for site collection.
2676 (save_site_url): Ditto.
2677 (get_site_list): Ditto.
2678 (get_saved_sites): Ditto.
2679 (do_download_site_info_thread): Ditto.
2680 (SitePage::OnNext): Ditto.
2681 (SitePage::PopulateListBox): Ditto.
2682 (SitePage::OnMessageCmd): Ditto.
2683 * site.h: Use STL vectors instead of custom code.
2684 (site_list_type::site_list_type): Declare.
2685 (site_list_type::operator=): Ditto.
2686 (site_list_type::operator ==): Ditto.
2687 (site_list_type::operator !=): Ditto.
2688 (site_list_type::operator <): Ditto.
2689 (site_list_type::operator <=): Ditto.
2690 (site_list_type::operator >): Ditto.
2691 (site_list_type::operator >=): Ditto.
2692 (site_list): Convert to an STL container.
2693 (all_site_list): Ditto.
2695 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
2697 * choose.cc (default_trust): Check package accessibility before
2698 triggering an install. (Suggested by Pavel).
2700 2002-07-03 Pavel Tsekov <ptsekov@gmx.net>
2702 * compress_gz.cc (compress_gz::construct): Always initialize key members
2703 to ensure the destructor does the right thing.
2705 2002-07-03 Pavel Tsekov <ptsekov@gmx.net>
2707 * filemanip.cc (parse_filename): Do not try to parse empty
2708 strings (filenames).
2709 * package_db.cc (packagedb::packagedb): For each line check if sscanf()
2710 extracted good package name and filename.
2712 2002-07-03 Robert Collins <rbtcollins@hotmail.com>
2714 * package_meta.cc (packagemeta::set_requirements): Automatically select
2715 version of dependent packages that satisfies the requirements.
2716 Use processOneDependency to trigger the install of those packages.
2717 (checkForInstalled): Check that the package remains installed.
2718 (processOneDependency): Helper function for dependent packages.
2719 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackage): Add more
2721 Clear out all current state on new packages.
2722 (IniDBBuilderPackage::add_correct_version): Copy the dependency list
2725 2002-07-02 Robert Collins <rbtcollins@hotmail.com>
2727 * Makefile.am (inilint_SOURCES): Add PackageSpecification sources.
2728 nb: inilint is still incomplete, as the packageversion code is not
2729 ready for database-less linking.
2730 * site.cc (get_site_list): When the same site is reentered by the user
2731 replace the old one. (Suggested by John Marshall).
2733 2002-07-02 Robert Collins <rbtcollins@hotmail.com>
2735 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
2736 Clear out package selections when generating implicit source packages.
2737 * PackageSpecification.cc (PackageSpecification::satisfies): Implement.
2738 (PackageSpecification::_operators::satisfies): Implement.
2739 * PackageSpecification.h (PackageSpecification::_operators::satisfies):
2740 Worker function for testing versions.
2742 2002-07-01 Robert Collins <rbtcollins@hotmail.com>
2744 * IniDBBuilder.cc (IniDBBuilder::buildPackageRequirement): Remove.
2745 * IniDBBuilder.h (IniDBBuilder::buildPackageRequirement): Ditto.
2746 * IniDBBuilderPackage.cc: Use the STL algorithms.
2747 Change cpv to cbpv throughout. Adjust -> to ., and use the new accessor
2748 functions for the same variable throughout.
2749 (IniDBBuilderPackage::IniDBBuilderPackage): Initialise new members.
2750 (IniDBBuilderPackage::buildPackage): Use new cygpackage syntax,
2751 and set an empty source package.
2752 (IniDBBuilderPackage::buildPackageInstall): Use the new source member
2753 to record an install package.
2754 (IniDBBuilderPackage::buildPackageSource): Move source package logic
2755 out from process_src, as it now occurs at separate times.
2756 (IniDBBuilderPackage::buildPackageRequirement): Remove.
2757 (IniDBBuilderPackage::buildSourceName): Use renamed package
2758 specifiation accessor for clarity.
2759 (IniDBBuilderPackage::buildSourceNameVersion): Ditto.
2760 (IniDBBuilderPackage::add_correct_version): Use STL iterators rather
2762 Remove source package references.
2763 (IniDBBuilderPackage::process_src): Remove source package code as it's
2764 now handled separately.
2765 Set Path information before merging versions, to prevent dangling
2767 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildPackageRequirement):
2769 (IniDBBuilderPackage::cpv): Remove.
2770 (IniDBBuilderPackage::cbpv): New generic binary working variable.
2771 (IniDBBuilderPackage::cspv): Ditto, but for source packages.
2772 (IniDBBuilderPackage::csp): Source package variable for disjoint
2774 * Makefile.am (AM_CFLAGS): Remove -Winline to allow stl set code
2775 to compile. If it compiles cleanly in gcc 3.1, then reinstate.
2776 * PickPackageLine.cc: Adjust packageversion accessors to the new
2777 reference calls. (i.e. -> to .) throughout.
2778 (PickPackageLine::paint): Use accessible() for clarity.
2779 Use new split out source package logic.
2780 (PickPackageLine::click): Ditto.
2781 * PickView.cc (PickView::init_headers): Adjust packageversion accessors
2782 to the new reference calls. (i.e. -> to .) throughout.
2783 Use new split out source package logic.
2784 * choose.cc: Don't depend on a specific package type.
2785 Adjust packageversion accessors to the new reference calls. (i.e. -> to
2787 (set_existence): Use accessible () for clarity.
2788 (default_trust): Simplify a little.
2789 (scanAVersion): Factored out code from scan_downloaded_files for
2791 (scan_downloaded_files): Factor out inner loop for clarity.
2792 (ChooserPage::OnNext): Don't dump the dependency list,
2793 it's parsing is robust now!.
2794 * cygpackage.cc (createInstance): Use a factory method to create new
2796 (cygpackage::cygpackage): Make this private for use by the factory.
2797 (cygpackage::setCanonicalVersion): Renamed from set_canonical_version.
2798 Remove key usage as it's obsolete.
2799 * cygpackage.h (cygpackage): Inherit from _packageversion, not
2801 (cygpackage::createInstance): New factory.
2802 (cygpackage::cygpackage): Make private.
2803 * desktop.cc (make_passwd_group): Use new packageversion reference.
2804 * download.cc (do_download_thread): Use changeRequested() for clarity.
2805 Use new packageversion reference calls.
2806 * iniparse.y (REQUIRES): Reuse the packageList code and dump the one-off
2808 * install.cc: Adjust -> to ., and use the new accessor functions for
2809 packageversion throughout.
2810 * package_db.cc: Adjust -> to ., and use the new accessor functions for
2811 packageversion throughout.
2812 (packagedb::packagedb): Use the new cygpackage factory.
2813 (packagedb::flush): Leverage String to remove buffer overflow chance in
2815 (packagedb::findBinary): Find a binary meta package that has a version
2816 matching a given specification.
2817 (packagedb::findSource): Ditto, but for source.
2818 * package_db.h (packagedb::findBinary): Declare.
2819 (packagedb::findSource): Ditto.
2820 * package_meta.cc: Adjust packageversion accessors to the new
2821 reference calls. (i.e. -> to .) throughout.
2822 Include the package_meta header first to ensure it parses standalone.
2823 Use the STL algorithms.
2824 (packagemeta::packagemeta): Create a copy constructor to allowing
2825 cloning binary package metadata to source package metadata.
2826 (packagemeta::~packagemeta): Use the STL coleltion code rather than
2827 custom collection code.
2828 (packagemeta::add_version): Ditto.
2829 (packagemeta::set_installed): Ditto.
2830 (packagemeta::SDesc): Ditto.
2831 (hasSDesc): Helper function for find_if.
2832 (checkForInstalled): Ditto.
2833 (checkForUpgradeable): Ditto.
2834 (checkForSatisfiable): Ditto.
2835 (packagemeta::action_caption): Update for split out source packages.
2836 (packagemeta::set_action): Ditto.
2837 (packagemeta::set_requirements): Support multi-valued dependency
2838 lists - a|b & c|d - with versioned package specifications.
2839 (packagemeta::accessible): Helper member to improve abstraction.
2840 (packagemeta::sourceAccessible): Ditto.
2841 * package_meta.h: Adjust packageversion accessors to the new
2842 reference calls. (i.e. "->" to "." and"*" to "" ) throughout.
2843 (packagemeta::packagemeta): Declare copy constructor.
2844 Remove self initialising members.
2845 (packagemeta::set_action): Update parameters for new packageversion.
2846 (packagemeta::trustp): Ditto.
2847 (packagemeta::versions): Becomes an STL set.
2848 * package_source.h (packagesource::Cached): Const correctness change.
2849 * package_version.cc: Rewrite the packageversion interface to remove
2850 the cygpackage nonvirtual members, and provide a copy by value,
2851 pointer semantics reference counting wrapper class to ease use and
2852 comparison of packageversions.
2853 Change existing packageversion class to _packageversion throughout.
2854 (_defaultversion): A trivial concrete class to prevent specialcasing
2855 the default constructor for packageversion;
2856 (packageversion::packageversion): Implement.
2857 (packageversion::~packageversion): Ditto.
2858 (packageversion::operator=): Ditto.
2859 (packageversion::operator !): Ditto.
2860 (packageversion::operator bool): Ditto.
2861 (packageversion::operator ==): Ditto.
2862 (packageversion::operator !=): Ditto.
2863 (packageversion::operator <): Ditto.
2864 (packageversion::Name): Ditto.
2865 (packageversion::Canonical_version): Ditto.
2866 (packageversion::setCanonicalVersion): Ditto.
2867 (packageversion::getfirstfile): Ditto.
2868 (packageversion::getnextfile): Ditto.
2869 (packageversion::SDesc): Ditto.
2870 (packageversion::set_sdesc): Ditto.
2871 (packageversion::LDesc): Ditto.
2872 (packageversion::set_ldesc): Ditto.
2873 (packageversion::sourcePackage): Ditto.
2874 (packageversion::sourcePackageSpecification): Ditto.
2875 (packageversion::setSourcePackageSpecification): Ditto.
2876 (packageversion::depends): Ditto.
2877 (packageversion::predepends): Ditto.
2878 (packageversion::recommends): Ditto.
2879 (packageversion::suggests): Ditto.
2880 (packageversion::replaces): Ditto.
2881 (packageversion::conflicts): Ditto.
2882 (packageversion::provides): Ditto.
2883 (packageversion::picked): Ditto.
2884 (packageversion::pick): Ditto.
2885 (packageversion::changeRequested): Ditto.
2886 (packageversion::uninstall): Ditto.
2887 (packageversion::source): Ditto.
2888 (packageversion::accessible): Ditto.
2889 (_packageversion::sourcePackage): Ditto.
2890 (_packageversion::accessible): Ditto.
2891 (_packageversion::changeRequested): Ditto.
2892 * package_version.h: Rewrite the packageversion interface to remove
2893 the cygpackage nonvirtual members, and provide a copy by value,
2894 pointer semantics reference counting wrapper class to ease use and
2895 comparison of packageversions.
2896 Change existing packageversion class to _packageversion throughout.
2897 (Dependency): Remove.
2898 (packageversion): New wrapper class.
2899 (_packageversion): Renamed from packageversion.
2900 (_packageversion::setCanonicalVersion): New method.
2901 (_packageversion::sourcePackage): Ditto.
2902 (_packageversion::sourcePackageSpecification): Ditto.
2903 (_packageversion::setSourcePackageSpecification): Ditto.
2904 (_packageversion::changeRequested): Ditto.
2905 (_packageversion::bin): Rename to source.
2906 (_packageversion::src): Remove.
2907 (_packageversion::accessible): New method.
2908 (_packageversion::references): Allow reference counting.
2909 (_packageversion::sourceVersion): Cached the best-match source
2912 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
2914 * compress_bz.h (compress_bz::position): Track how much has been read.
2915 * compress_bz.cc (compress_bz::compress_bz): And initialise it.
2916 (compress_bz::read): Track amount read by the client.
2917 (compress_bz::tell): And report it when asked.
2919 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
2921 * Makefile.am (snapshot): Automate snapshot creation some more.
2923 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
2925 * msg.cc (msg): Use vsnprintf to avoid buffer overflows.
2927 * ini.cc (fprintf): Ditto.
2928 * log.cc (log): Ditto.
2929 * package_db.cc (packagedb::sourcePackages): Split out source packages
2930 from binary packages.
2931 * package_db.h: Ditto.
2933 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
2935 * PackageSpecification.h: New file. Abstracts the ability to refer
2936 to another package, by name, or name and version.
2937 * PackageSpecification.cc: Ditto.
2938 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Simplify.
2939 (IniDBBuilder::buildPackageSource): Ditto.
2940 (IniDBBuilder::buildBeginDepends): New method for versioned
2942 (IniDBBuilder::buildBeginPreDepends): Likewise, for dependencies to be
2943 satisfied before pre-install.
2944 (IniDBBuilder::buildPriority): New method, for getting the package
2946 (IniDBBuilder::buildInstalledSize): How much disk space does it need?
2947 (IniDBBuilder::buildMaintainer): Who maintains the package?
2948 (IniDBBuilder::buildArchitecture): What platform is it for?
2949 (IniDBBuilder::buildInstallSize): How big is the binary download?
2950 (IniDBBuilder::buildInstallMD5): Whats the MD5 on the binary?
2951 (IniDBBuilder::buildSourceMD5): Whats the MD5 on the source package?
2952 (IniDBBuilder::buildBeginRecommends): What other packages are
2953 recommended with this one?
2954 (IniDBBuilder::buildBeginSuggests): And suggested?
2955 (IniDBBuilder::buildBeginReplaces): What packages does this replace?
2956 (IniDBBuilder::buildBeginConflicts): And collide with?
2957 (IniDBBuilder::buildBeginProvides): What virtual packages (or obsolete
2958 package names) does this provide?
2959 (IniDBBuilder::buildDescription): Grab a multi line description one
2961 (IniDBBuilder::buildSourceName): What source package should be used to
2962 install the source for this binary package?
2963 (IniDBBuilder::buildSourceNameVersion): Is a specific version needed?
2964 (IniDBBuilder::buildPackageListAndNode): Add another AND clause to a
2965 list of package specifications.
2966 (IniDBBuilder::buildPackageListOrNode): Add another OR clause.
2967 (IniDBBuilder::buildPackageListOperator): Add a versioning operator
2968 to the current specification.
2969 (IniDBBuilder::buildPackageListOperatorVersion): What version does the
2971 * IniDBBuilder.h: Declare all the IniDBBuilder.cc changes.
2972 * IniDBBuilderPackage.cc: As for IniDBBuilder.cc.
2973 (IniDBBuilderPackage::IniDBBuilderPackage): Iniitialize new members.
2974 (IniDBBuilderPackage::process_src): Streamline and split out
2976 (IniDBBuilderPackage::setSourceSize): From process_src.
2977 * IniDBBuilderPackage.h: Declare the IniDBBuilderPackage.cc changes.
2978 (IniDBBuilderPackage::currentSpec): Track the in-progress specifiation.
2979 (IniDBBuilderPackage::currentOrList): Track the current Or list.
2980 (IniDBBuilderPackage::currentAndList): Track the current And list.
2981 * IniParseFeedback.cc (IniParseFeedback::progress): Provide completion
2982 progress on parsing.
2983 (IniParseFeedback::iniName): Tell what ini filename we are currently
2985 * IniParseFeedback.h: Declare IniParseFeedback.cc changes.
2986 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
2987 Make the feedback object non-const to allow mutating methods which are
2988 needed when the object has state.
2989 (IniParseFindVisitor::visitFile): Tell the caller the name of each
2991 Initialise the parser with the feedback object to allow it to tell of
2993 * IniParseFindVisitor.h: Declare IniParseFindVisitor.cc changes.
2994 * Makefile.am (inilinst_SOURCES): Add more requisite classes.
2995 (setup_SOURCES): Add the new PackageSpecification sources.
2996 * ScanFindVisitor.cc (ScanFindVisitor::visitFile): Use the new
2997 builder syntax to setup binary package details.
2998 * choose.cc: Use the LogSingleton calls throughout.
2999 * configure.in: Create the INILINT substitution correctly for recent
3000 autotool configurations.
3001 * cygpackage.cc (cygpackage::getfirstfile): Return an empty String
3002 rather than a string built from an int. Thanks to Pavel Tsekov for
3003 identifying the bug.
3004 (cygpackage::getnextfile): Ditto.
3005 * download.cc: Use LogSIngletion calls throughout.
3006 (validateCachedPackage): A refactoring of the
3007 check_for_cached code to eliminate duplciation.
3008 (check_for_cached): Use validateCachedPackage to check packages.
3009 * ini.cc (GuiParseFeedback): Provide gui feedback on ini name and
3011 (do_remote_ini): Ditto.
3012 * ini.h (ini_init): Pass a IniParseFeedback to the parser, to allow
3014 * inilex.l: Identify new symbols - operators, and multi line plain text.
3016 * inilintmain.cc (show_help): Provide basic infomation on inilint.
3017 * iniparse.y: Adjust for the new builder syntax, and process debian
3019 * io_stream_file.cc: Always include mkdir.h.
3020 * list.h: Factor index location into a private routine.
3021 (list::findindex): Implement this.
3022 * mkdir.cc (mkdir_p): Make the use of WIN32 code conditional on mingw
3023 builds. NB: This breaks cygwin build functionality still.
3024 * package_meta.cc: Use the LogSingleton calls throughout.
3025 (packagemeta::set_requirements): Adjust for object changes in
3027 * package_meta.h (packagemeta::packagemeta): Initialise new members.
3028 (packagemeta::architecture): What platform does this package run on?
3029 This may need to move in the future to a per packagefile object.
3030 (packagemeta::priority): What priority does this package have?
3031 * package_source.h (packagesource::packagesource): Initialise new
3033 (packagesource::installedSize): How much space does the package need?
3034 (packagesource::setInstalledSize): Tell the amount.
3035 (packagesource::_installedSize): And store it.
3036 * package_version.cc (packageversion::sourcePackage): return the
3038 (packageversion::setSourcePackage): And set it.
3039 * package_version.h: Declare the package_version.cc changes.
3040 (packageversion::depends): New package specification AND list.
3041 (packageversion::predepends): Ditto.
3042 (packageversion::recommends): Ditto.
3043 (packageversion::suggests): Ditto.
3044 (packageversion::replaces): Ditto.
3045 (packageversion::conflicts): Ditto.
3046 (packageversion::provides): Ditto.
3047 (packageversion::sourcePackage): What source package is needed?
3048 * threebar.cc (ThreeBarProgressPage::SetText4): Set the label beside
3050 * threebar.h: Declare the threebar.cc change.
3052 2002-06-27 John Marshall <johnm@falch.net>
3054 * res.rc (SETUPINI_MISSING): Make trailing spaces visible.
3055 * site.cc (SitePage::OnMessageCmd): Ditto
3057 2002-06-15 Robert Collins <rbtcollins@hotmail.com>
3059 * nio-ie5.cc (NetIO_IE5::NetIO_IE): Allow cached data.
3061 2002-06-15 Robert Collins <rbtcollins@hotmail.com>
3063 * package_meta.cc (packagemeta::set_action): When installing packages
3064 with no binaries, choose the source package.
3066 2002-06-10 Robert Collins <rbtcollins@hotmail.com>
3068 * IniParseFindVisitor (IniParseFindVisitor::visitFile): Apply Max
3069 Bowshers fix for the crash with a root level setup.ini.
3070 * README: Update todos.
3072 2002-05-26 Ralf Habacker <ralf.habacker@freenet.de>
3074 * archive_tar.cc (archive_tar::next_file_name()): fixed broken
3075 GNU long name extension support.
3077 2002-05-27 Robert Collins <rbtcollins@hotmail.com>
3079 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Don't
3080 unescape 0 length strings.
3082 2002-05-20 Robert Collins <rbtcollins@hotmail.com>
3084 * package_meta.cc (packagemeta::set_action): Don't allow reinstall
3085 when local with no cached file, and install the default source if the
3086 default version has no binary.
3088 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
3090 * IniDBBuilderPackage.cc (IniDBBuilderPackage::IniDBBuilderPackage): New
3092 (IniDBBuilderPackage::buildVersion): Provide a warning when a newer
3093 setup version created the ini file.
3094 * IniDBBuilderPackage.h (IniDBBuilderPackage::IniDBBuilderPackage): New
3096 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use the new
3098 * IniParseFindVisitor.h (IniParseFindVisitor::IniParseFindVisitor):
3099 Require a feedback strategy.
3100 * Makefile.am (setup_SOURCES): Add IniParseFeedback sources.
3101 * Makefile.in: Regenerate.
3103 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
3105 * io_stream_file.cc (io_stream_file::remove): Use the SetFileAttributes
3106 trick to delete read only files.
3107 * io_stream_cygfile.cc (io_stream_cygfile::remove): Use file:// to
3109 * Makefile.am (release): Tweak to be more helpful.
3110 * Makefile.in: Regenerate.
3112 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
3114 * Makefile.am (release): Tweak to be more helpful.
3115 * Makefile.in: Regenerate.
3117 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
3119 * Makefile.am (release): Tweak to be more helpful.
3120 * Makefile.in: Regenerate.
3122 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
3124 * choose.cc (scan_downloaded_files): When a non-installed version
3125 has neither bin nor src cached files for local installs,
3126 remove the version from availability.
3128 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
3130 * ini.cc (do_remote_ini): Save uncompressed ini's correctly.
3132 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
3134 * rsync: New support library, contains librsync. This is not (yet)
3135 rsync interoperable.
3136 * configure.in: --with-rsync to enable rsync support. (Not complete).
3137 * Makefile.am: Enable building with rsync.
3138 * Makefile.in: Regenerate.
3140 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Pass the md5 as
3142 (IniDBBuilder::buildPackageSource): Ditto.
3143 * IniDBBuilder.h: Ditto.
3144 * IniDBBuilderPackage.cc: Ditto.
3145 * IniDBBuilderPackage.h: Ditto.
3146 * FindVisitor.cc: New file.
3147 * FindVisitor.h: New file, interface for visiting a file system
3149 * IniParseFindVisitor.cc: New file.
3150 * IniParseFindVisitor.h: New file, concrete FindVisitor that parses
3152 * README: Update TODO's.
3153 * String++.cc (String::String): New constructor for <string> inter-
3155 (String::substr): New method.
3156 * String++.h: Ditto.
3157 * choose.cc (scan2): Remove.
3158 (scan_downloaded_files): Simplify.
3159 * dialog.h: Include parsing pre-requirements.
3160 * download.cc (check_for_cached): Fullname was used incorrectly - fix.
3161 * filemanip.cc (parse_filename): -src packages where incorrectly parsed.
3162 * find.cc: Rewrite. Now uses a Visitor pattern and is re-entrant.
3164 * fromcwd.cc: Remove unneeded includes.
3165 (is_test_version): Remove.
3166 (found_file): Remove.
3167 (SetupFindVisitor): Trivial visitor to detect setup.ini's.
3168 (found_ini): Remove.
3169 (do_fromcwd): Remove commented code that has be replaced elsewhere.
3170 * ini.cc (local_ini): Remove.
3171 (findBuilder): Remove.
3172 (find_routine): Remove.
3173 (do_local_ini): Use new IniParseFindVisitor.
3174 * iniparse.y: Typecase MD5 arrays, as we know they are allocated as
3176 * postinstall.cc: Remove non-core includes.
3177 (run_script_in_postinstall): Remove.
3178 (RunFindVisitor): Trivial Visitor, runs each found script.
3179 (do_postinstall): Use new find syntax.
3181 2002-05-14 Christopher Faylor <cgf@redhat.com>
3183 * ini.cc (find_routine): Don't clear buffer it it's NULL.
3185 2002-05-14 Christopher Faylor <cgf@redhat.com>
3187 * filemanip.h (trail): Declare.
3188 * filemanip.cc (trail): New function.
3189 (find_tar_ext): Use trail() instead of strstr().
3190 * fromcwd.cc (check_ini): Ditto.
3191 * ini.cc (find_routine): Ditto. Don't tack local_dir to path since it
3192 should now be fully qualified. Set ini_filename. Reset error_buf and
3193 error_count for any subsequent ini file parsing.
3194 (ini_filename): New static variable for parse error reporting.
3195 (yyerror): Use full path of setup.ini in error message. Subtract one
3196 from line number if at bol.
3197 * find.cc (found_part): Eliminate.
3198 (find_sub): Call for_each with full path found rather than just file
3200 (find): Don't calculate found_part.
3201 * inilex.l (ini_init): Flush input buffer and reset line number.
3202 (yybol): New function. Exports YY_AT_BOL.
3203 * iniparse.y: Increase stack depth to allow more tokens to be processed.
3204 (yyparse): Remove newline from error condition to allow subsequent
3205 per-line error processing to proceed normally.
3207 2002-05-14 Christopher Faylor <cgf@redhat.com>
3209 * find.cc (find_sub): Be more defensive in preserving trailing parts of
3210 components when doing recursive directory searches or calling user
3211 supplied for_each().
3212 * ini.cc (find_routine): Don't assume that any path name with
3213 "setup.ini" in it is actually a setup.ini file. Only honor trailing
3214 components. Copy path argument to temporary storage when unescaping
3215 to prevent nuking of argument.
3217 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
3219 * CONTRIBUTORS: New file.
3221 2002-04-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3223 * choose.cc: Run indent.
3224 (nextbutton): Remove static variable.
3225 (default_trust): Remove use of nextbutton.
3226 (set_view_mode): Ditto.
3227 (create_listview): Add IDC_CHOOSE_PREV and IDC_CHOOSE_NEXT to ta[] so
3228 rbset() sets the prev/next/curr radio buttons properly.
3229 (dialog_cmd): Delete function.
3230 (dialog_proc): Delete function. Move WM_INITDIALOG functionality to
3231 ChooserPage::OnInit.
3232 (do_choose): Delete function. Move pre-DialogBox() code to
3233 ChooserPage::OnInit(), post-DialogBox() code to ChooserPage::OnNext.
3234 (WM_APP_START_CHOOSE): Remove define.
3235 (WM_APP_CHOOSE_IS_FINISHED): Remove define.
3236 (do_choose_thread): Delete function.
3237 (ChooserPage::OnActivate): Delete method.
3238 (ChooserPage::OnMessageApp): Delete method.
3239 (ChooserPage::OnInit): New method.
3240 (ChooserPage::OnNext): New method.
3241 (ChooserPage::OnBack): New method.
3242 (ChooserPage::OnMessageCmd): New method.
3243 * choose.h: Run indent.
3244 (ChooserPage::OnMessageApp): Delete declaration.
3245 (ChooserPage::OnActivate): Ditto.
3246 (ChooserPage::OnMessageCmd): New declaration.
3247 (ChooserPage::OnInit): Ditto.
3248 (ChooserPage::OnNext): Ditto.
3249 (ChooserPage::OnBack): Ditto.
3250 * desktop.cc (DesktopSetupPage::OnBack): Replace use of IDD_CHOOSER
3252 * fromcwd.cc (do_fromcwd): Replace use of IDD_CHOOSER with IDD_CHOOSE.
3253 * ini.cc (do_ini_thread): Replace use of IDD_CHOOSER with IDD_CHOOSE.
3254 * res.rc (IDD_CHOOSE): Remove dialog template.
3255 (IDD_CHOOSER): Alter dialog template to fit wizard size and format.
3257 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
3259 * LogFile.cc (endLog): Work around an apparent libg++-3 bug causing
3260 corrupt log file entries.
3261 * geturl.cc: Convert to the new LogSingleton logging.
3263 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
3265 * ini.cc (do_remote_ini): Use setup.bz2 if it exists in preference to
3268 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
3270 * geturl.h: Declare getUrlToStream.
3271 * geturl.cc (getUrlToStream): New function.
3272 (get_url_to_membuf): Refactor to use getUrlToStream.
3274 2002-05-11 Robert Collins <rbtcollins@hotmail.com>
3276 * Makefile.am: Add a release target to automate some of the routine
3278 * Makefile.in: Regenerate.
3280 2002-05-11 Robert Collins <rbtcollins@hotmail.com>
3282 * choose.cc (scan_downloaded_files): On local installs remove all
3283 mirror sites if no cached copy of a package is found.
3285 2002-05-10 Robert Collins <rbtcollins@hotmail.com>
3287 * Makefile.in: Regenerate.
3288 * iniparse.y: Use left recursion, not right in the lines rule to
3289 avoid stack overflows.
3290 * README: Update TODO's.
3291 * io_stream_file.cc: Native builds need to include sys/stat.h
3293 2002-05-06 John Marshall <jmarshall@acm.org>
3295 * site.cc (SitePage::OnMessageCmd): recalculate navigation
3296 button activation when "Add" is pressed.
3297 (SitePage::CheckControlsAndDisableAccordingly): tweak comment.
3299 2002-05-07 Robert Collins <rbtcollins@hotmail.com>
3301 * Makefile.am (inlint_SOURCES): Add conditional objects to inilint
3302 depending on platform.
3303 Add file:// support.
3304 * configure.in: Set conditional MINGWTARGET if compiling against mingw
3306 * Makefile.in: Regenerate.
3308 * io_stream_file.cc: Only use win32 calls when building for mingw.
3310 2002-05-05 Robert Collins <rbtcollins@hotmail.com>
3312 * Makefile.am (noinst_PROGRAMS): Make inilint configurable.
3313 * configure.in: Ditto.
3314 Fix incorrect header checking syntax.
3315 * aclocal.m4: Regenerate.
3316 * configure: Regenerate.
3317 * Makefile.in: Regenerate.
3318 * io_stream.cc: Remove platform specific and provider specific code.
3319 (io_stream::registerProvider): New method, registers a Url provider with
3321 Make all methods consistently throw invalid_argument exceptions when
3322 a provider that is requested is not present.
3323 (findProvider): New private function, finds a provider.
3324 * io_stream.h: Declare io_stream::registerProvider.
3325 * io_stream_cygfile.cc: Create a Provider class to register with
3327 * io_stream_file.cc: Ditto.
3328 * archive.cc: Remove unneeded includes.
3329 * archive_tar.cc: Remove unneeded includes.
3330 * archive_tar.h: Add required include.
3331 * archive_tar_file.cc: Remove unneded includes.
3332 * choose.cc: Remove unneeded includes:
3334 2002-05-04 Robert Collins <rbtcollins@hotmail.com>
3336 * io_stream.cc: Use the new log interface thruout.
3338 2002-05-04 Robert Collins <rbtcollins@hotmail.com>
3340 * log.cc (log): Reimplement via LogSingleton.
3342 (exit_setup): Remove.
3343 * log.h (log_save): Remove.
3344 (exit_setup): Remove.
3345 * LogSingleton.cc: New file.
3346 * LogSingleton.h: New file.
3347 * LogFile.cc: New file.
3348 * LogFile.h: New file.
3349 * Makefile.am (inilint_SOURCES): Add the new log interface.
3350 (setup_SOURCES): Add the new log interface and the concrete File
3352 * Makefile.in: Regenerate.
3353 * archive.cc: Use the new log interface thruout.
3354 * archive_tar.cc: Ditto.
3356 * dialog.cc (fatal): Use the new log interface.
3357 * ini.cc (do_ini_thread): Use the log interface to exit.
3358 * isntall.cc (do_install_thread): Ditto.
3359 * netio.cc (auth_cmd): Ditto.
3360 * msg.cc (fatal): Ditto.
3361 * localdir.cc (save_local_dir): Save to different files depending on
3362 the mode, and if a root dir exists.
3364 2002-05-04 Robert Collins <rbtcollins@hotmail.com>
3366 * IniDBBuilder.cc: New file.
3367 * IniDBBuilder.h: New file.
3368 * IniDBBuilderPackage.cc: New file.
3369 * IniDBBuilderPackage.h: New file.
3370 * PackageTrust.h: New file.
3371 * IniState.h: Remove, wasn't thought out well enough.
3372 * Makefile.am (inilint_SOURCES): Add more requirements.
3373 (setup_SOURCES): Add new Builder base and concrete classes.
3374 * Makefile.in: Regenerate.
3375 * String++.cc (String::String): Implement int contructor.
3376 * String++.h (String): Declare int constructor.
3377 * archive_tar.cc (archive_tar::next_file_name): Return String() when
3379 * archive_tar.h (archive_tar_file): Remove get_next_filename method,
3381 * ini.cc: Replace IniState wuth IniDBBuilderPacakge.
3382 (find_routine): Use new IniDBBuilder to configure the parser.
3383 (do_local_ini): Ditto.
3384 (do_remote_ini): Ditto.
3385 * ini.h: Use IniDBBuilder to initialise parsing.
3386 * inilex.l (MD5): Parse the MD5 string correctly, we had the nibbles
3388 (ini_init): Use an IniDBBuilder rather than static variables.
3389 * iniparse.y: Hand off all the object creation to a builder, rather
3390 than hardcoding the behaviour. This allows run-time configured
3392 * io_stream_cygfile.h (io_stream_cygfile): Remove get_next_filename
3393 method, it's not needed.
3394 * io_stream_file.h (io_stream_file): Ditto.
3395 * mount.cc (cygpath): Return String() for missing mounts.
3396 * package_meta.cc (packagemeta::SDesc): Return String() for blank
3398 * package_meta.h (trusts): Remove - replaced by PackageTrust.h.
3399 (packagemeta::packagemeta): Fix incorrect syntax in String constructor
3401 * cygpackage.cc (cygpackage::cygpackage): Fix incorrect syntax in
3402 String constructor usage.
3403 * site.h (site_list_type): Ditto.
3405 2002-05-03 Robert Collins <rbtcollins@hotmail.com>
3407 * String++.h: Declare a << operator that accepts String objects.
3408 * String++.cc: We need iostream for..
3409 (operator <<): this. Provide a << operator that accepts String objects.
3410 * ini.cc (yyerror): Remove the "C" classifier - it's not needed.
3411 Change from vargs to a String parameter.
3412 * inilintmail.cc: Remove the gui related headers.
3413 (yyerror): Implement this for parsing.
3414 * iniparse.y: Use the new yyerror syntax.
3416 2002-05-03 Robert Collins <rbtcollins@hotmail.com>
3418 * Makefile.am: Add IniState.h.
3419 * Makefile.in: Regenerate.
3420 * IniState.h: New file.
3421 * choose.cc: Don't include ini.h - it's not needed.
3422 * configure: Regenerate.
3423 * desktop.cc: Don't include ini.h - it's not needed.
3424 * download.cc: Ditto.
3425 * fromcwd.cc: Ditto.
3426 * ini.cc: Use IniState.h to track each parsing calling.
3427 (find_routine): Ditto.
3428 (do_remote_ini): Ditto.
3429 (do_ini_thread): Ditto.
3430 * ini.h (ini_init): Adjust parameters to include state object.
3431 * inilex.l: Declare parser state variable.
3432 (ini_init): Adjust parameters to include state object.
3433 * iniparse.y: Remove obsolete setup_timestamp and setup_version
3435 (setup_header): Use new state variable to track time and version.
3436 (add_correct_version): Ditto.
3437 * install.cc: Don't include ini.h - it's not needed.
3439 2002-05-03 Robert Collins <rbtcollins@hotmail.com>
3441 * nio-files.cc (NetIO): Use io_stream syntax for get_file_size.
3442 * io_stream_file.cc: Don't include filemanip.h.
3443 (io_stream_file::get_size): Implement here to remove filemanip
3445 * io_stream_cygfile.cc: Don't include filemanip.h.
3446 (io_stream_cygfile::get_size): Implement here to remove filemanip
3448 Implement a stat based version for when win32 is not available.
3449 * filemanip.h (get_file_size): Return size_t - it's more appropriate.
3450 * filemanip.cc: Don't include win32.h - be platform independent.
3451 Include strings.h and io_stream.h as part of that.
3452 (get_file_size): Leverage io_streams and remove win32 implementation.
3453 * download.cc (check_for_cached): Use io_stream syntax for
3455 (download_one): Ditto.
3457 2002-05-02 Robert Collins <rbtcollins@hotmail.com>
3459 * configure.in: Correct a typo in last change.
3460 * configure: Regenerate.
3461 * Makefile.in: Regenerate.
3463 2002-05-02 Robert Collins <rbtcollins@hotmail.com>
3465 * configure.in: Check for string.h and string.
3466 * configure: Regenerate.
3467 * Makefile.in: Regenerate.
3469 2002-05-01 Robert Collins <rbtcollins@hotmail.com>
3471 * res.rc (IDD_SPLASH): Remove white box.
3473 2002-05-01 Robert Collins <rbtcollins@hotmail.com>
3475 Oops! forgot to list these in the last checkin.
3476 * inilintmain.cc: New file.
3477 * md5.h: New file - imported md5 source, BSD style licence.
3478 * md5.cc: New file - imported md5 source, BSD style licence.
3479 * Exception.cc: New file.
3480 * Exception.h: New file.
3481 * MD5++.cc: New file.
3482 * MD5++.h: New file.
3484 2002-05-01 Robert Collins <rbtcollins@hotmail.com>
3486 * Makefile.am (AM_CFLAGS): Remove -mwindows, it's a linker flag.
3487 Remove -fno-rtti, we need it for exceptions.
3488 (AM_CXXFLAGS): Ditto.
3489 (WARNONLY_CFLAGS): Ditto.
3490 (EXTRA_PROGRAMS): Add with initial linter sources - not functional yet.
3491 (setup_LDFLAGS): Add and set to -mwindows.
3492 (setup_SOURCES): Add new sources.
3493 * Makefile.in: Regenerate.
3494 * README: Update TODO.
3495 * choose.cc (scan_downloaded_files): Use ini information if it's
3497 * configure: Regenerate.
3498 * download.cc (check_for_cached): Make reusable from elsewhere.
3499 Throw exceptions on errors (as opposed to failures).
3500 Check MD5 sum when it's known.
3501 (download_one): Never force a download.
3502 Handle corrupt package exceptions.
3503 * ini.cc (find_routine): Reverse escape the URL to correctly identify
3505 * inilex.l (MD5): Provide a parsing rule (note: lowercase is required).
3506 * iniparse.y: Allow calculation of MD5 sums, and allow src only
3508 (process_src): New helper function.
3509 * isntall.cc (install_one_source): Check MD5 sums when possible.
3510 Throw exceptions on errors.
3511 (do_install_thread): Handle exceptions for installation calls.
3512 * package_source.h: Store MD5 information.
3513 * propsheet.cc (PropSheet::Create): Add a useful comment.
3514 * res.rc (IDS_INSTALL_ERROR): Define.
3515 (IDS_CORRUPT_PACKAGE): Define.
3516 * resource.h (IDS_INSTALL_ERROR): Define.
3517 (IDS_CORRUPT_PACKAGE): Define.
3518 * rfc1738.cc (rfc1738_unescape_part): Implement.
3519 * rfc1738.h (rfc1738_unescape_part): Declare.
3521 2002-04-29 Robert Collins <rbtcollins@hotmail.com>
3523 * Makefile.am: Remove dependecy rules that automake emits.
3524 Correct badly copied dependency info for manually compiled files.
3525 (setup_SOURCES): Add all used headers.
3526 (EXTRA_DIST): Include non compilate but required sources.
3527 (setup_LDADD): Remove mingw32, it is autodetected.
3528 * Makefile.in: Regenerate.
3529 * String++.h: sys/types is a system header.
3530 * choose.cc (do_choose_thread): Make into a Win32 thread routine.
3532 (ChooserPage::OnMessageApp): Use Win32 threads. (_beginthread is not
3534 * configure: Regenerate.
3535 * configure.in: Check for mingw32/cygwin specific headers and libraries.
3536 * cygpackage.h: Include the win32.h header to get correct macro
3537 definitions in all situations.
3538 * download.cc (do_download_reflector): Make into a Win32 thread routine.
3540 (do_download): Use Win32 threads.
3542 * install.cc: Ditto.
3543 * (WinMain): Adjust to build valid command line using application
3544 under both mingw32 and cygwin.
3545 * mount.cc (set)cygdrive_flags): Create new system flags if the
3546 user requests system and the value does not exist.
3547 * nio-http.cc: Define a _strnicmp for cygwin.
3548 * package_db.cc: Include <errno.h> if it exists.
3549 * site.cc (do_download_site_info_thread): Make into a Win32 thread
3552 (do_download_site-Info): Use Win32 threads.
3553 * state.cc: Explicity declare variables to avoid header conflicts
3554 caused by '#define extern" on cygwin.
3555 * win32.h: Include <alloca.h> if it exists.
3556 (_MAX_PATH): Define as MAX_PATH when not defined by windows.h.
3557 (_access): Define as access if not defined by windows.h.
3559 2002-04-27 Robert Collins <rbtcollins@hotmail.com>
3561 * compress_gz.cc (compress_gz::error): EOF is not an error condition.
3563 2002-04-27 Robert Collins <rbtcollins@hotmail.com>
3565 * Makefile.am: Add libgetopt++ to the subdirs list.
3566 Search the libgetopt++ header directory.
3567 Link against libgetopt++.la.
3568 (setup_SOURCES): Remove GetOption.cc and getopt.c and Option.cc.
3569 (setup_LDADD): Explicitly include res.o.
3570 * Makefile.in: Regenerate.
3571 * aclocal.m4: Regenerate.
3572 * bootstrap.sh: Call libtoolize.
3573 * configure: Regenerate.
3574 * configure.in: Add libtool support and configure libgetopt++.
3575 * desktop.cc (NoShortcutsOption): Turn into a BoolOption.
3576 (DesktopSetupPage::OnInit): Use the simpler syntax.
3577 * desktop.h: Remove dependency on Option.h, and remove NoShortcustOption
3579 * main.cc: Include getopt++/GetOption.h.
3580 (main): Use simpler syntax.
3584 * GetOption.h: Remove.
3585 * GetOption.cc: Remove.
3587 * Option.cc: Remove.
3589 2002-04-26 Robert Collins <rbtcollins@hotmail.com>
3591 * Makefile.am: Add zlib and bz2lib to SUBDIRS.
3593 2002-04-26 Robert Collins <rbtcollins@hotmail.com>
3595 * aclocal.m4: New file, cached macros.
3596 * bootstrap.sh: New file, calls required autotools in appropriate
3598 * Makefile.am: New file, input Makefile for automake.
3599 * Makefile,in: Now a generated file - regenerate.
3600 * configure: Regenerate.
3601 * configure.in: Add automake support.
3602 * inilex.l: Change VERSION to PACKAGEVERSION to avoid a collision with
3603 automake's VERSION define.
3604 * iniparse.y: Ditto.
3606 2002-04-26 Robert Collins <rbtcollins@hotmail.com>
3608 * cdefs.h: New file, imported to allow getopt.c to build without
3610 * getopt.h: New file, imported to allow building without cygwin headers.
3612 * bz2lib: New directory, contains copy of bz2lib.
3613 * cfgaux: New directory, contains autotool helper scripts.
3614 * Makefile,in: Adjust library and target definitions for building
3615 outside the sourceware tree.
3616 * compress_bz.h: Use new bz2lib header location.
3617 * mount.cc: Import key defines and enums to be independent of cygwin
3619 * configure.in: Update to autoconf 2.53, and to be sourceware
3621 * configure: Regenerate.
3623 2002-04-12 Robert Collins <rbtcollins@hotmail.com>
3625 * mklink2.cc (make_link_2): Tweak to work with current w32api
3628 2002-04-10 Pavel Tsekov <ptsekov@gmx.net>
3630 * version.cc (canonicalize_version): Fix a call delete[]
3631 to delete the allocated address.
3633 2002-03-29 Robert Collins <rbtcollins@hotmail.com>
3635 * PickView.cc (PickView::set_headers): Set last_col correctly. Thanks
3636 to Ton van Overbeek for locating the bug area.
3638 2003-03-27 Robert Collins <rbtcollins@hotmail.com>
3640 * PickView.cc (PickView::insert_pkg): Be more generic with
3642 (PickView::insert_category): Ditto.
3643 (PickView::~PickView): Create.
3644 * PickView.h (PickView::~PickView): Declare.
3646 2003-03-27 Robert Collins <rbtcollins@hotmail.com>
3648 * Makefile.in (OBJS): Add new commandline objects.
3649 * desktop.cc (NoShortCutsOption): New option code.
3650 (DesktopSetupPage::OnInit): Check whether to skip shortcuts.
3651 * desktop.h (NoShortCutsOption): New concrete command line option class.
3652 * main.cc (WinMain): Process command line options.
3653 * GetOption.h: New file, singleton command line class.
3654 * GetOption.cc: New file, implementation of the above.
3655 * Option.h : New file, abstract option for GetOption.
3656 * Option.cc: New file, implement constructor and destructor.
3658 2002-03-26 Pavel Tsekov <ptsekov@gmx.net>
3660 * mkdir.cc (mkdir_p): Stop processing if the path is exhausted.
3662 2002-03-26 Ton van Overbeek <tvoverbe@cistron.nl>
3664 * PickPackageLine.cc (PickPackageline::paint): Adjust clipping rectangle
3665 to textheight, so large fonts work.
3667 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
3669 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Don't translate
3672 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
3674 * io_stream_cygfile.cc (cwd): New static for cwd storage.
3675 (io_stream_cygfile::normalise): New method.
3676 (io_stream_cygfile::io_stream_cygfile): Use it.
3677 (io_stream_cygfile::exists): Ditto.
3678 (io_stream_cygfile::remove): Ditto.
3679 (io_stream_cygfile::mklink): And again.
3680 (cygmkdir_p): Yes, again.
3681 (io_stream_cygfile::move): And once more.
3682 * io_stream_cygfile.h (io_stream_cygfile::normalise): Declare.
3683 (io_stream_cygfile::cwd): Ditto.
3685 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
3687 * package_meta.cc (package_meta::~package_meta): Remove duplicate.
3688 (CategoryPackage::~CategoryPackage): Ditto. (Thanks to Ton van
3689 Overbeek for the report).
3690 * mklink2.cc: Moved from mklink2.c to avoid 'not a prototype error'.
3691 Make g++ compatible.
3692 * mklink2.c: Remove.
3693 * site.cc (site_list_type::init): Delete the correct memory addres.
3694 Thanks to Pavel Tsekov for tracking this down.
3696 2002-03-20 Robert Collins <rbtcollins@hotmail.com>
3698 * win32.h: Only define alloca if it's not already.
3700 2002-03-20 Robert Collins <rbtcollins@hotmail.com>
3702 * package_meta.h (packamgemeta::trustp): Make 'test' choice leave
3703 installed packages alone.
3704 * README: Update with latest requests.
3705 * Various: MTC fixes from setup200202 branch.
3707 2002-03-19 Christopher Faylor <cgf@redhat.com>
3709 * Makefile.in (setup_version.c): Add back magic which allows detection
3710 of setup.exe version number.
3712 2002-03-17 Robert Collins <rbtcollins@hotmail.com>
3714 * PickPackageLine.cc (PickPackageLine::paint): Fix incorrect clip region
3715 calculation on win9x systems.
3717 2002-03-16 Robert Collins <rbtcollins@hotmail.com>
3719 * install.cc (install_one_source): Write the correct length of a string
3720 to the lst file (Thanks to Pavel Tsekov for reporting the bug).
3722 2002-03-15 Robert Collins <rbtcollins@hotmail.com>
3724 * choose.cc (list_click): Always refresh the entire chooser, as our
3725 package state change mechanism is broken with the new improved list
3728 2002-03-15 Robert Collins <rbtcollins@hotmail.com>
3730 * desktop.cc (make_passwd_group): Check for .lnk suffix on /etc/passwd
3733 2002-03-15 Robert Collins <rbtcollins@hotmail.com>
3735 * PickPackageLine.cc (PickPackageLine::DrawCheck): New method factored
3737 (PickPackageLine::paint): Use DrawCheck to draw the src tick box, and
3738 the new bin tickbox.
3739 (PickPackageLine::click): Handle the new bin tickbox.
3740 * PickPackageLine.h (PickPackageLine::DrawCheck): Declare this.
3741 * PickView.cc (pkg_headers): Add a Bin? column.
3742 (cat_headers): Ditto.
3743 (PickView::set_headers): Ditto.
3744 (PickView::init_headers): Ditto.
3745 * PickView.h (PickView): Ditto.
3746 * choose.cc (list_click): Use the new name for src_col to set the clip
3749 2002-02-24 Michael A Chase <mchase@ix.netcom.com>
3751 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Fix up Robert's
3754 2002-02-24 Michael A Chase <mchase@ix.netcom.com>
3756 * desktop.cc (make_link): Add "file://" prefix to io_stream::mkpath_p()
3758 (make_passwd_group): Ditto.
3759 * localdir.cc (save_local_dir): Ditto.
3760 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Wrap long lines.
3761 Add "cygfile://" prefix to io_stream::open() calls.
3763 2002-02-24 Robert Collins <rbtcollins@hotmail.com>
3765 * log.cc (log_save): Fix creating /var/log.
3766 * packate_meta.cc (standard_dirs): Remove duplicate '/''s.
3768 2002-02-24 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3770 * res.rc (STRINGTABLE): Add IDS_CYGWIN_SETUP and
3771 IDS_CYGWIN_SETUP_WITH_PROGRESS strings.
3772 * resource.h: Add IDS_CYGWIN_SETUP and
3773 IDS_CYGWIN_SETUP_WITH_PROGRESS IDs.
3775 * splash.cc (OnInit): Qualify SetWindowText() call with global scope
3776 operator (::SetWindowText()).
3778 * threebar.cc: Run indent.
3779 (cistring.h): Add include.
3780 (SetText1, SetText2, SetText3): Qualify SetWindowText() call with
3781 global scope operator.
3782 (SetBar2): Add logic for writing percent complete into window title.
3784 * window.h: Run indent.
3785 (SetWindowText): New function.
3786 (String): Add forward declaration.
3787 * window.cc: Run indent.
3788 (String++.h): Add include.
3789 (SetWindowText): New function.
3791 2002-02-24 Robert Collins <rbtcollins@hotmail.com>
3793 * README: Update TODO list.
3794 * install.cc (install_one): Fix src package location.
3795 (do_install_thread): Fix creating directories.
3797 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
3799 * choose.cc: Include cygpackage.h for scan2 use.
3800 (set_existence): Ignore setup.ini mirrors when installing from cwd.
3801 (scan2): Process any valid file.
3802 Add cache entries when a file matching a setup.ini listed version is
3804 * filemanip.cc (parse_filename): Remove pkgtar - not used anywhere else.
3805 * filemanip.h (filemanip::pkgtar): Remove.
3806 * package_meta.cc (CategoryPackage::~CategoryPackage): New method.
3807 (packagemeta::~packagemeta): Move from package_meta.h
3808 Remove and delete all version and category information.
3809 * package_meta.h (CategoryPackage): Create a destructor.
3810 (packagemeta::~packagemeta): Move to .cc file.
3812 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
3814 * install.cc (install_one_source): Make NULL cached package names cause
3817 2002-02-18 Michael A Chase <mchase@ix.netcom.com>
3819 * desktop.cc (make_passwd_group): Don't create passwd-grp.bat
3822 2002-02-18 Michael A Chase <mchase@ix.netcom.com>
3824 * log.cc (log_save): Put "\n" at end of log lines instead of "'".
3826 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
3828 * mount.cc (create_mount): Avoid a const char*->char* warning.
3829 (read_mounts): Ditto.
3831 2002-02-05 Jason Tishler <jason@tishler.net>
3833 * download.cc (do_download_thread): Fix off-by-one error.
3835 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
3837 * configure.in (CXXFLAGS): Substitute at configure time, not runtime.
3838 * configure (CXXFLAGS): Regenerate.
3839 * Makefile.in (iniparse.o): Build via default rules - no errors now.
3840 * README: TODO list updates.
3842 2002-02-19 Michael A Chase <mchase@ix.netcom.com>
3844 * String++.cc (String::concat):: Remove.
3845 (String::vconcat):: Ditto.
3846 * String++.h (String::concat):: Remove.
3847 (String::vconcat):: Ditto.
3848 * archive_tar.cc: Don't include concat.h.
3849 * archive_tar_file.cc: Don't include concat.h.
3850 * compress_bz.cc (compress_bz::peek): Don't log unneeded messages.
3851 (compress_bz::seek): Ditto.
3852 (compress_bz::~compress_bz): Ditto.
3853 * compress_gz.cc (compress_gz::peek): Ditto.
3854 (compress_gz::error): Ditto.
3855 (compress_gz::~compress_gz): Ditto.
3856 * concat.cc (vconcat): Remove.
3858 * concat.h (vconcat): Remove.
3860 * desktop.cc (desktop_icon): Use new cygpath.
3861 (make_etc_profile): Ditto.
3863 (make_passwd_group): Ditto.
3865 (check_desktop): Remove concat use.
3866 (check_start_menu): Ditto.
3867 * download.cc (download_one): Use new mkpath_p correctly.
3869 * fromcwd.cc: Don't include concat.h.
3870 * geturl.cc (get_url_to_membuf): Use String log() call.
3871 (get_url_to_file): Ditto.
3872 * install.cc: Don't include concat.h.
3873 (uninstall_one): Use LOG_PLAIN.
3874 (replace_one): Ditto.
3875 (install_one_source): Ditto.
3876 (install_one): More char to String conversion.
3877 (do_install_thread): Use new cygpath.
3878 Use new create_mount.
3879 * io_stream.cc (io_stream::move): Use new log().
3880 * io_stream_cygfile (io_stream_cygfile::io_stream_cygfile): Use new
3882 (io_stream_cygfile::exists): Ditto.
3883 (io_stream_cygfile::remove): Ditto.
3884 (io_stream_cygfile::mklink): Ditto.
3885 (io_stream_cygfile::write): Ditto.
3886 (cygmkdir_p): Ditto.
3887 (io_stream_cygfile::move): Ditto.
3888 * io_stream_file.cc: Don't include log.h.
3889 (io_stream_file::write): Don't log unneeded messages.
3890 * localdir.cc: Don't include concat.h.
3891 (LocalDirPage::OnNext): Use LOG_PLAIN.
3892 * log.cc: Don't include log.h.
3893 (exit_setup): Use new cygpath.
3894 * log.h (log_level): Add new level LOG_PLAIN.
3895 * main.cc (WinMain): Use new log().
3896 * mount.cc (SLASH_P): New macro from concat.h.
3897 (cygpath): Make String version globally visible.
3898 Remove varargs version.
3900 * msg.cc (mbox): Use LOG_PLAIN.
3901 * net.cc (NetPage::OnNext): Ditto.
3902 * nio-ftp.cc (ftp_line): Use new log().
3903 * nio-http.cc: Don't include log.h.
3904 (retry_get): Use alternative url variable.
3905 * package_db.cc: Don't include concat.h.
3906 (packagedb::flush): Don't use concat.
3907 * package_meta.cc: Don't include concat.h.
3908 (packagemeta::uninstall): Use new cygpath.
3909 * postinstall.cc (do_postinstall): Ditto.
3910 * root.cc (RootPage::OnNext): Use LOG_PLAIN.
3911 * script.cc: Don't include concat.h.
3912 (init_run_script): Use new cygpath.
3913 (run_script): More char * to String conversion.
3914 (try_run_script): Ditto.
3915 * site.cc: Don't include concat.h.
3916 (SitePage::OnNext): Use LOG_PLAIN.
3917 (SitePage::OnMessageCmd): Use new log().
3918 * source.cc (SourcePage::OnDeactivate): Use LOG_PLAIN.
3920 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
3922 * Makefile.in (OBJS): Add new object.
3923 * PickCategoryLine.cc (PickCategoryLine::paint): Print a "+" before the
3925 * PickCategoryLine.h (PickCategoryLine::bucket): Use the String class.
3926 * PickLine.h (Pickline::key): Change to a String to help plug leaks.
3927 (PickLine::Pickline): Accept a String for the key.
3928 * PickPackageLine.cc (PickPackageLine::paint): Convert all char use to
3930 * PickPackageLine.h (PickPackageLine::PickPackageLine): The key is
3931 automatically initialised now.
3932 * PickView.cc (PickView::note_width): Convert all char * use to Strings.
3933 (PickView::init_header): Move category length checking out of the inner
3934 loop for efficiency.
3935 Convert all char use to Strings.
3936 * PickView.h: Include the String++ header.
3937 (PickView::note_width): Update the prototype.
3938 * String++.cc: New file, implements a reference counting string class.
3939 * String++.h: New file, declares a reference counting string class.
3940 * archive.cc: Include String++ instead of concat.
3941 (archive::extract_file): Convert char * usage to Strings.
3942 * archive.h: Inlude the String++ header.
3943 (archive::extract_file): Update prototype.
3944 (archive::next_file_name): Convert to a String.
3945 (archive::linktarget): Ditto.
3946 * archive_tar.cc (archive_tar::next_file_name): Convert to String usage.
3947 (archive_tar::linktarget): Ditto.
3948 * arhive_tar.h: Update the copyright.
3949 Explicitly include the relevant headers.
3950 (tar_map_result_type): Convert to String usage.
3951 (archive_tar::next_file_name): Update prototype.
3952 (archive_tar::linktarget): Ditto.
3953 * category.cc (Category::Category): Update initialisers.
3954 Convert to String usage.
3955 (Categorycmp): Update to String usage.
3956 * category.h: Include the String++ header.
3957 (Category::Category): Update to String usage.
3958 (Category::name): Ditto.
3959 (Category::key): Ditto.
3960 * choose.cc: Remove concat.h, it's not needed.
3961 (scan2): Update to String usage.
3963 * cygpackage.cc: Update includes for use of String class.
3964 (cygpackage::cygpackage): Update for String usage.
3965 (cygpackage::set_canonical_version): Ditto.
3966 (cygpackage::destroy): Ditto.
3967 (cygpackage::getfirstfile): Ditto.
3968 (cygpackage::getnextfile): Ditto.
3969 (cygpackage::Name): Ditto.
3970 (cygpackage::Vendor_version): Ditto.
3971 (cygpackage::Package_version): Ditto.
3972 (cygpackage::Canonical_version): Ditto.
3973 (cygpackage::set_sdesc): Ditto.
3974 (cygpackage::set_ldesc): Ditto.
3975 * cygpackage.h: Include String++.h for parsing this file.
3976 (cygpackage::cygpackage): Update for String usage.
3977 (cygpackage::set_canonical_version): Ditto.
3978 (cygpackage::destroy): Ditto.
3979 (cygpackage::getfirstfile): Ditto.
3980 (cygpackage::getnextfile): Ditto.
3981 (cygpackage::Name): Ditto.
3982 (cygpackage::Vendor_version): Ditto.
3983 (cygpackage::Package_version): Ditto.
3984 (cygpackage::Canonical_version): Ditto.
3985 (cygpackage::set_sdesc): Ditto.
3986 (cygpackage::set_ldesc): Ditto.
3987 (cygpackage::name): Ditto.
3988 (cygpackage::vendor): Ditto.
3989 (cygpackage::packagev): Ditto.
3990 (cygpackage::canonical): Ditto.
3991 (cygpackage::fn): Ditto.
3992 (cygpackage::sdesc): Ditto.
3993 (cygpackage::ldesc): Ditto.
3994 * desktop.cc: Update includes for use of String class.
3995 (batname): Update for String usage.
3998 (start)menu): Ditto.
3999 (desktop_icon): Ditto.
4000 (make_cygwin_bat): Ditto.
4001 (make_etc_profile): Ditto.
4003 (make_passwd_group): Ditto.
4005 (check_desktop): Ditto.
4006 (check_startmenu): Ditto.
4007 * dialog.cc (eget): Update for String usage.
4008 (egetString): New function.
4009 (eset): New variant for Strings.
4010 * dialog.h: Include String++.h for parsing this file.
4011 (egetString): New function.
4012 (eset): New variant for Strings.
4013 * diskfull.cc (diskfull): Update for String usage.
4014 * diskfull.h: Include String++.h for parsing this file.
4015 (diskfull): Update for String usage.
4016 * download.cc: Update includes for use of String class.
4017 (check_for_cached): Update for String usage.
4018 (download_one): Ditto.
4019 * filemanip.cc (get_file_size): Ditto.
4021 (parse_filename): Ditto.
4023 * filemanip.h: Include String++.h for parsing this file.
4024 (fileparse): Update for String usage.
4026 (parse_filename): Ditto.
4027 Don't consider '_' to be a separator.
4029 * find.cc: Update includes for use of String class.
4030 (find_sub): Make more flexible.
4031 (find): Update for String usage.
4032 * find.h (find): Use Strings.
4033 * fromcwd.cc (found_file): Update for String usage.
4035 (init_dialog): Ditto.
4036 (get_url_to_membuf): Ditto.
4037 (get_url_to_string): Ditto.
4038 (get_url_to_file): Ditto.
4040 (get_url_to_membuf): Ditto.
4041 (get_url_to_string): Ditto.
4042 (get_url_to_file): Ditto.
4044 (add_subdirs): Ditto.
4045 * ini.cc: Update includes for String usage.
4046 (find_routine): Update for String usage.
4047 (do_remote_ini): Ditto.
4048 (do_ini_thread): Ditto.
4049 * ini.h (ini_init): Ditto.
4050 * inilex.l: Update includes for String usage.
4051 (ini_init): Update for String usage.
4052 * iniparse.y: Ditto.
4053 (add_correct_version): Ditto.
4054 * install.cc: Update includes for String usage.
4055 (install_one_source): Update for String usage.
4056 (uninstall_one): Ditto.
4057 (replace_one): Ditto.
4058 (install_one_source): Ditto.
4059 (do_install_thread): Ditto.
4060 * io_stream.cc: Update includes for String usage.
4061 (io_stream::open): Update for String usage.
4062 (io_stream::mkpath_p): Ditto.
4063 (io_stream::remove): Ditto.
4064 (io_stream::mklink): Ditto.
4065 (io_stream::move_copy): Ditto.
4066 (io_stream::move): Ditto.
4067 (io_stream::exists): Ditto.
4068 * io_stream.h: Update includes to allow correct parsing.
4069 (io_stream::open): Update for String usage.
4070 (io_stream::mkpath_p): Ditto.
4071 (io_stream::remove): Ditto.
4072 (io_stream::mklink): Ditto.
4073 (io_stream::move_copy): Ditto.
4074 (io_stream::move): Ditto.
4075 (io_stream::exists): Ditto.
4076 * io_stream_cygfile.cc: Update includes for String usage.
4077 (get_root_dir_now): Update for String usage.
4078 (io_stream_cygfile::io_stream_cygfile): Ditto.
4079 (io_stream_cygfile::~io_stream_cygfile): Ditto.
4080 (io_stream_cygfile::exists): Ditto.
4081 (io_stream_cygfile::remove): Ditto.
4082 (io_stream_cygfile::mklink): Ditto.
4083 (cygmkdir_p): Ditto.
4084 (io_stream_cygfile::set_mtime): Ditto.
4085 (io_stream_cygfile::move): Ditto.
4086 (io_stream_cygfile::get_size): Ditto.
4087 * io_stream_cygfile.h: Update includes for String usage.
4088 (io_stream_cygfile::io_stream_cygfile): Update for String usage.
4089 (io_stream_cygfile::~io_stream_cygfile): Ditto.
4090 (io_stream_cygfile::exists): Ditto.
4091 (io_stream_cygfile::remove): Ditto.
4092 (io_stream_cygfile::mklink): Ditto.
4093 (cygmkdir_p): Ditto.
4094 (io_stream_cygfile::set_mtime): Ditto.
4095 (io_stream_cygfile::move): Ditto.
4096 (io_stream_cygfile::get_size): Ditto.
4097 (io_stream_cygfile::fname): Ditto.
4098 (io_stream_cygfile::lmode): Ditto.
4099 * io_stream_file.cc: Update includes for String usage.
4100 (io_stream_file::io_stream_file): Update for String usage.
4101 (io_stream_file::~io_stream_file): Ditto.
4102 (io_stream_file::exists): Ditto.
4103 (io_stream_file::remove): Ditto.
4104 (io_stream_file::mklink): Ditto.
4105 (io_stream_file::set_mtime): Ditto.
4106 (io_stream_file::move): Ditto.
4107 (io_stream_file::get_size): Ditto.
4108 * io_stream_file.h: Update includes for String usage.
4109 * io_stream_file.cc: Update includes for String usage.
4110 (io_stream_file::io_stream_file): Update for String usage.
4111 (io_stream_file::~io_stream_file): Ditto.
4112 (io_stream_file::exists): Ditto.
4113 (io_stream_file::remove): Ditto.
4114 (io_stream_file::mklink): Ditto.
4115 (io_stream_file::set_mtime): Ditto.
4116 (io_stream_file::move): Ditto.
4117 (io_stream_file::get_size): Ditto.
4118 (io_stream_file::fname): Ditto.
4119 (io_stream_file::lmode): Ditto.
4120 * localdir.cc: Update includes for String usage.
4121 (save_local_dir): Update for String usage.
4122 (check_if_enable_next): Ditto.
4123 (load_dialog): Ditto.
4125 (LocalDirPage::OnInit): Ditto.
4126 (LocalDirPage::OnNext): Ditto.
4127 * log.cc: Update includes for String usage.
4128 (struct LogEnt): Update for String usage.
4131 (exit_setup): Ditto.
4132 * log.h: Update includes for String usage.
4133 (log_level): Update for String usage.
4136 * main.cc (WinMain): Update for String usage.
4137 * mklink2.c (make_link_2): Update for String usage.
4138 * mklink2.h (make_link_2): Update for String usage.
4139 * mount.cc: Update includes for String usage.
4140 (mount_table): Update for String usage.
4142 (create_mount): Ditto.
4144 (remove_mount): Ditto.
4145 (read_mounts): Ditto.
4146 (set_root_dir): Ditto.
4147 (get_root_dir): Ditto.
4148 (path_prefix_p): Ditto.
4150 * mount.h: Update includes for String usage.
4151 (create_mount): Update for String usage.
4152 (remove_mount): Ditto.
4154 (set_root_dir): Ditto.
4155 (get_root_dir): Ditto.
4156 * msg.cc (mbox): Ditto.
4157 * net.cc (NetPage::OnNext): Ditto.
4158 * package_db.cc (packagedb::flush): Ditto.
4159 (packagedb::packages): Ditto.
4160 (packagedb::categories): Ditto.
4161 * package_db.h: Update includes for String usage.
4162 (packagedb::packages): Update for String usage.
4163 (packagedb::categories): Ditto.
4164 * package_meta.cc: Update includes for String usage.
4165 (hash::add_subdirs): Update for String usage.
4166 (packagemeta::uninstall): Ditto.
4167 (packagemeta::SDesc): Ditto.
4168 (packagemeta::action_caption): Ditto.
4169 * package_meta.h: Update includes for String usage.
4170 (packagemeta::packagemeta): Update for String usage.
4171 (packagemeta::~packagemeta): Ditto.
4172 (packagemeta::uninstall): Ditto.
4173 (packagemeta::SDesc): Ditto.
4174 (packagemeta::action_caption): Ditto.
4175 (package_source.cc site::site): Ditto.
4176 (packagesource::set_canonical): Ditto.
4177 (packagesource::set_cached): Ditto.
4178 * package_source.h: Update includes for String usage.
4179 (site::site): Update for String usage.
4180 (packagesource::set_canonical): Ditto.
4181 (packagesource::set_cached): Ditto.
4182 (packagesource::packagesource): Ditto.
4183 (packagesource::sites): Ditto.
4184 (packagesource::cached): Ditto.
4185 * package_version.h: Update includes for String usage.
4186 (Dependency): Update for String usage.
4187 (packageversion): Ditto.
4188 * postinstall.cc: Update includes for String usage.
4189 (do_postinstall): Update for String usage.
4190 * res.rc (IDD_LOCAL_DIR): Fix typo again!
4191 * rfc1738.cc (rfc1738_escape_part): Update for String usage.
4192 * rfc1738.h: Update includes for String usage.
4193 (rfc1738_escape_part): Update for String usage.
4194 * root.cc: Update includes for String usage.
4195 (check_if_enable_next): Update for String usage.
4196 (save_dialog): Ditto.
4198 (directory_is_absolute): Ditto.
4199 (directory_is_rootdir): Ditto.
4200 (directory_has_spaces): Ditto.
4201 (RootPage::OnInit): Ditto.
4202 (RootPage::OnNext): Ditto.
4203 * script.cc: Update includes for String usage.
4204 (init_run_script): Update for String usage.
4206 (run_script): Ditto.
4207 (try_run_script): Ditto.
4208 * script.h: Update includes for String usage.
4209 (run_script): Update for String usage.
4210 (try_run_script): Ditto.
4211 * site.cc site_list): Ditto.
4212 (all_site_list): Ditto.
4213 (other_url): Eliminate.
4214 (site_list_type::init): Update for String usage.
4215 (site_list_type::site_list_type): Ditto.
4216 (get_site_list): Ditto.
4217 (get_saved_sites): Ditto.
4218 (do_download_site_info_thread): Ditto.
4219 (SitePage::OnNext): Ditto.
4220 (SitePage::OnActivate): Ditto.
4221 (SitePage::PopulateListBox): Ditto.
4222 (SitePage::OnMessageCmd): Handle empty url's.
4223 * site.h: Update includes for String usage.
4224 (site_list_type::site_list_type): Update for String usage.
4225 (site_list_type::init): Ditto.
4226 (site_list_type::~site_list_type): Ditto.
4227 (site_list_type::url): Ditto.
4228 (site_list_type::displayed_url): Ditto.
4229 (site_list_type::key): Ditto.
4230 * source.cc (SourcePage::OnDeactivate): Ditto.
4231 * state.h: Update includes for String usage.
4232 (local_dir): Update for String usage.
4233 (trust_level): Remove.
4234 * version.cc: Update includes for String usage.
4235 (canonicalize_version): Update for String usage.
4236 * version.h: Update includes for String usage.
4237 (canonicalize_version): Update for String usage.
4239 2002-02-15 Christopher Faylor <cgf@redhat.com>
4241 * filemanip.c (parse_filename): Revert previous change.
4243 2002-02-14 Christopher Faylor <cgf@redhat.com>
4245 * filemanip.c (parse_filename): Don't treat '_' as a version number
4248 2002-01-29 Christopher Faylor <cgf@redhat.com>
4250 * configure: Regenerate.
4252 2002-01-27 Robert Collins <rbtcollins@hotmail.com>
4254 * res.rc (IDD_LOCAL_DIR): Fix typo reported by Rene
4255 <Hoeck@extern.lrz-muenchen.de>
4257 2002-01-27 Robert Collins <rbtcollins@hotmail.com>
4259 * README: Update Todo's.
4260 * list.h: Run indent.
4261 (list): New methods checksize and insert to reduce code duplication.
4262 (list::registerbykey): Use them.
4263 (list::registerbyobject): Ditto.
4264 (list::removebyindex): Copy each object individually - safe for non
4266 (list::checksize): Implement.
4267 (list::insert): Implement.
4269 2002-01-27 Robert Collins <rbtcollins@hotmail.com>
4271 * Makefile.in: Remove the dlmalloc object by default.
4272 * install.cc (do_install_thread): Remove the mallinfo call for 'working
4273 around' the crashing issue.
4274 * package_db.h: Include <string.h> - it's needed to parse this.
4275 * package_source.cc (site::site): Move here from the header file.
4276 * package_source.h (site): Stop the constructor being inlinable.
4278 2002-01-26 Robert Collins <rbtcollins@hotmail.com>
4280 * filemanip.cc (find_tar_ext): Add a descriptive comment.
4282 2002-01-25 Michael A Chase <mchase@ix.netcom.com>
4284 * filemanip.cc (find_tar_ext): Clean up tests for .tar.gz and .tar.
4285 * fromcwd.cc (do_fromcwd): Expand FIXME comment in source file check.
4286 * install.cc (install_one_source): Add space between words in log()
4289 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
4291 * log.cc (exit_setup): When saving to the download dir, explicity
4294 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
4296 * archive.cc (extract_file): Separate out the prefix and the URL
4298 * archive.h (archive::extract_file): Ditto.
4299 * install.cc (install_one_source): Ditto. Use the new
4300 archive::extract_file syntax.
4301 (replace_one): Use the new syntax.
4302 (io_stream.cc): Add some log info for links.
4304 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
4306 * PickCategoryLine.cc (PickCategoryLine::actiontext): Remove.
4307 (PickCategoryLine::paint): Use the new action method.
4308 (PickCategoryLine::click): Set the action for all children.
4309 (PickCategoryLine::set_action): New method.
4310 * PickCategoryLine.h (PickCategoryLine::-actions): Remove.
4311 (PickCategoryLine::current_default): Use packagemeta _actions class.
4312 * PickLine.h (PickLine::set_action): New abstract method that requires
4313 including package_meta.h.
4314 * PickPackageLine.cc (PickPackageLine::set_action): New method.
4315 * PickPackageLine.h (PickPackageLine::set_action): Declare this.
4316 * list.h (getbykey): A const correctness fix.
4317 * package_meta.cc: Run indent.
4318 (packagemeta::Default_action): New const.
4319 (packagemeta::Install_action): Ditto.
4320 (packagemeta::Reinstall_action): Ditto.
4321 (packagemeta::Uninstall_action): Ditto.
4322 (packagemeta::_actions::caption): New method.
4323 (packagemeta::_actions::operator++): Ditto.
4324 (packagemeta::set_action): New overload.
4325 * package_meta.h (packagemeta::_actions): New class.
4326 (packagemeta::set_action): Declare this.
4328 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
4330 * Makefile.in (OBJS): Remove supp.o - it appears accidental.
4331 * choose.cc: Don't define alloca anymore, it's done in win32.h
4333 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
4335 * PickPackageLine.cc: New file.
4336 * PickPackageLine.h: New file.
4337 * PickLine.cc: New file.
4338 * PickLine.h: New file.
4339 * PickCategoryLine.cc: New file.
4340 * PickCategoryLine.h: New file.
4341 * PickView.cc: New file.
4342 * PickView.h: New file.
4343 * Makefile.in: Add new objects to setup.exe.
4344 Backout -fno-exceptions option.
4345 * choose.cc: Include PickView.h.
4346 Remove view related defines and static variables.
4347 (_pkg_headers): Moved to PickView.cc.
4348 (_cat_headers): Ditto.
4349 (view::views::Unknown): Ditto.
4350 (view::views::PackageFull):
4351 (view::views::Package):
4352 (view::views::Category):
4353 (pkgtrustp): Moved to package_meta.cc.
4354 (add_required): Moved to package_meta.cc.
4355 (pick_category_line::empty): Moved to PickCategoryLine.cc
4356 (paint): Adjust for moved static variables.
4357 (view::scroll): Moved to PickView.cc.
4358 (list_vscroll): Adjust for moved static variables.
4359 (list_hscroll): Ditto.
4360 (list_click): Ditto.
4361 (note_width): Moved to PickView.cc.
4362 (view::view): Ditto.
4363 (view::set_view_mode): Ditto.
4364 (view::mode_caption): Ditto.
4365 (view::views::caption): Ditto.
4366 (view::set_headers): Ditto.
4367 (DoInsertItem): Ditto.
4368 (view::init_headers): Ditto.
4369 (view::insert_pkg): Ditto.
4370 (view::insert_category): Ditto.
4371 (view::clear_view): Ditto.
4372 (view::views::operator++): Ditto.
4373 (view::click): Ditto.
4374 (default_trust): Adjust for moved statics.
4375 (pick_pkg_line::paint): Moved to PickPackageLine.cc.
4376 (pick_pkg_line::click): Ditto.
4377 (pick_category_line::actiontext): Moved to PickCategoryLine.cc
4378 (pick_category_line::paint): Ditto.
4379 (pick_category_line::click): Ditto.
4380 (set_view_mode): Adjust for moved statics.
4381 (create_listview): Ditto.
4382 * choose.h: Remove Category and packagemeta forward defines -
4384 Don't include unneeded headers list and package_meta.
4385 (_header): Move to PickView.h.
4386 (pick_line): Move to PickLine.h.
4387 (pick_pkg_line): Move to PickPackageLine.h.
4388 (pick_category_line): Move to PickCategoryLine.h.
4389 (view): Move to PickView.h.
4390 * ini.h (trusts): Move to package_meta.h.
4391 * package_meta.h (trusts): New enum.
4392 (packagemeta::set_requirements): New helper method.
4393 (packagemeta::trustp): Ditto.
4395 2002-01-21 Christopher Faylor <cgf@redhat.com>
4397 * choose.h (view): Move forward declaration of views into public area
4398 or g++ v3 will complain.
4400 2002-01-21 Christopher Faylor <cgf@redhat.com>
4402 * Makefile.in (CXXFLAGS): Add -fno-exceptions.
4403 * win32.h (alloca): Define as __builtin_alloca.
4404 * io_stream_memory.cc: Add include file.
4406 2002-01-21 Robert Collins <rbtcollins@hotmail.com>
4408 * archive_tar.cc (archive_tar::~archive_tar): Mark the stream as
4410 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
4411 * compress.cc (compress::~compress): Be less verbose.
4412 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
4413 Mark the stream as destroyed.
4414 * compress_gz.cc (compress_gz::~compress_gz): Mark the stream as
4416 * io_stream.cc (io_stream::~io_stream): Only warn when the stream is not
4417 marked as destroyed.
4418 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Mark the
4419 stream as destroyed.
4420 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
4421 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
4423 2002-01-21 Robert Collins <rbtcollins@hotmail.com>
4425 * Makefile.in (CFLAGS): Allow customisable malloc debug flags.
4426 (OBJS): Link in malloc objects.
4427 * category.cc (category): Use new char, not strdup.
4428 * choose.cc (pick_pkg_line::paint): Allow for the regionsize to shrink.
4429 (do_choose): Use new char, not malloc.
4430 * concat.cc (vconcat): Ditto.
4431 * cygpackage.cc (cygpackage): Use new char, not strdup.
4432 (set_canonical_version): Ditto.
4433 (cygpackage::destroy): Use delete[], not free.
4434 * desktop.cc (uexists): Ditto.
4435 * dialog.cc (egest): Use new char, not strdup.
4436 * dlmalloc.c: New file - Doug Lea's malloc 2.7.0
4437 * hash.cc (hash::hash): Use delete instead of free.
4438 (hash::add): Use new char, not strdup.
4439 * ini.cc (do_remote_ini): Use delete[] not free.
4440 * inilex.l: Use new char, not strdup.
4442 * iniparse.y: Ditto.
4443 Use a local package_db rather than a static one.
4444 * install.cc (struct mallinfo): Workaround an apparent dlmalloc bug.
4445 (do_install_thread): Call mallinfo to force a consistency check. Appears
4446 to fix a 'inuse' error in -DDEBUG builds.
4447 Use delete[] for strings.
4448 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Use new
4450 (io_stream_cygfile::~io_stream_cygfile): Use delete[], not free.
4451 (io_stream_cygfile::remove): Use new char, not strdup.
4452 * io_stream_file.cc (io_stream_file::io_stream_file): Use new char, not
4454 (io_stream_file::io_stream_file): Use delete[], not free.
4455 (io_stream_file::remove): Use new char, not strdup.
4456 * io_stream_memory.cc (memblock::~memblock): Use delete[], not free.
4457 * io_stream_memory.h (memblock): Use new char, not malloc.
4458 * localdir.cc (LocalDirPage::OnInit): Use new char, not strdup.
4459 * main.cc (WinMain): Use new char, not strdup.
4460 * mount.cc (find2): Use new char, not malloc.
4461 (read_mounts): Ditto.
4462 (cygpath): Use new char, not strdup.
4463 * netio.cc (NetIO::~NetIO): Use delete[], not free.
4464 (NetIO::set_url): Use new char, not strdup.
4465 (NetIO::get_ftp_auth): Use delete[], not free.
4466 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
4467 Use new char instead of strdup.
4468 * nio-http.cc (base64_encode): Use new char, not malloc.
4469 * package_meta.cc (hash::add_subdirs): Use new char instead of strdup.
4470 * package_source.h (~ packagesource): Use delete[] instead of delete.
4471 * port.h (strdup): Deprecate the use of strdup.
4472 * rfc1738.cc (rfc1738_do_escape): Use new char, not calloc.
4473 * script.cc (init_run_script): Us delete[], not free.
4474 (run_script): Ditto.
4475 * simpsock.cc (SimpleSocket::fill): Use new char, not malloc.
4476 (SimpleSocket::invalidate): Use delete[], not free.
4477 * site.cc (site_list_type::init): Use new char instead of strdup.
4478 * site.h (~site_list_type): Use delete[], not free.
4480 2002-01-20 Robert Collins <rbtcollins@hotmail.com>
4482 * Makefile.in (OBJS): Add win32.o - win32 support functions.
4483 * README: Update todos.
4484 * archive.cc (extract_file): Support a suffix for appending to extracted
4487 * choose.cc (set_view_mode): Use the new view::views class.
4488 (view::views::Unknown): New static for defaulting view::views variables.
4489 (view::views::PackageFull): New static for the current view.
4490 (view::views::Package): Ditto.
4491 (view::views::Category): Ditto.
4492 (topbucket::paint): Remove.
4493 (topbucket::empty): Rename to pick_category_line::empty.
4494 (topbucket::~topbucket): Remove.
4495 (paint): Use the new view::views class.
4496 Don't paint 'all' as a category when showing package categoies.
4497 (pick_category_line::actiontext): New method.
4498 (pick_category_line::paint): Make showing the category optional, and
4499 show the 'category action'.
4500 (pick_category_line::click): Make showing the category optional, and
4501 differentiate between the name being clicked, and the action
4503 (view::view): Use the new view::views class.
4504 (view::set_view_mode): Ditto.
4505 (view::mode_caption): Ditto.
4506 (view::views::caption): New method.
4507 (view::set_headers): Use the new view::views class.
4508 (view::clear_view): Ditto.
4509 (viewsplusplus): Replaced by
4510 (view::views::operator++): New operator.
4511 (set_view_mode): Use the new view::views class.
4512 (create_listview): Ditto.
4513 (dialog_cmd): Ditto.
4514 * choose.h (actions): Remove.
4516 (pick_line): Add a new convenience constructor.
4517 (top_bucket): Remove.
4518 (pick_category_line): Reparent under pick_line, and adsorb top_bucket.
4519 (view::views): New class.
4520 * ini.h: Don't include choose.h
4521 (is_download_action): Remove.
4522 (is_upgrade_action): Remove.
4523 (is_uninstall_action): Remove.
4524 (is_full_action): Remove.
4525 * install.cc (num_replacements): New static.
4526 (rebootneeded): Ditto.
4527 (replace_one): Handle upgrades separate from removal or new installs.
4528 (install_one_source): Handle in use files.
4529 (install_one): Don't repeat upgrades.
4530 (do_install_thread): Initialize new statics.
4531 Order actions as uninstall, replace, install.
4532 Warn about rebooting if needed.
4533 * res.rc (IDS_REBOOT_REQUIRED): New string.
4534 * resource.h (IDS_REBOOT_REQUIRED): Give value.
4535 * win32.h: Declare class Win32, and update copyright and intent message.
4536 * win32.cc: New file.
4538 2002-01-15 Corinna Vinschen <corinna@vinschen.de>
4540 * io_stream.cc (io_stream::gets): Eliminate trailing new line chars.
4541 * package_meta.cc (packagemeta::uninstall): Check for additional
4542 Windows shortcut. Unset R/O file attribute before trying to delete
4545 2002-01-09 Robert Collins <rbtcollins@hotmail.com>
4547 * choose.cc (pkgtrustp): Fall back to installed if a package is not
4548 present in the current trust level. For prev, fall back via curr.
4549 (set_existence): Allow sources with no sites, but cached files to be
4551 (pick_category_line::paint): Start drawing clickable categories.
4552 * fromcwd.cc (found_file): Reinstate local file scanning.
4554 2002-01-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
4556 * fromcwd.cc: Run indent.
4557 (do_fromcwd): Reverse sense of comment. Set next_dialog
4558 to IDD_CHOOSER instead of IDD_CHOOSE.
4559 * ini.cc (find_routine): Remove "/" from "/setup.ini".
4561 2001-01-07 Robert Collins <rbtcollins@hotmail.com>
4563 * category.cc (Categorycmp): Add a const safe version.
4564 * category.h (Categorycmp): Add a const safe version.
4565 (Category): Add operator ==.
4566 * choose.cc (fill_missing_category): Add every package to "All".
4567 (pick_category_line::paint): Add support for hidden labels, and a tree
4569 (pick_category_line::click): Ditto.
4570 (view::view): Pass in a top level category to use.
4571 (view::insert_pkg): Special case - skip category "All".
4572 (view::insert_category): Ditto.
4573 (view::clear_view): Set the contents label state.
4574 (create_listview): Pass in a top level category to view().
4575 * choose.h (topbucket): Make bucket available to derived classes.
4576 (pick_category_line): Add support for hidden labels, and a tree depth.
4577 Remove our second copy of bucket.
4578 (view): Pass in a top level category to the constructor.
4579 Use pick_category_line to allow three level display.
4581 2001-01-06 Robert Collins <rbtcollins@hotmail.com>
4583 * cygpackage.h (cygpackage): Make set_[s|l]desc virtual.
4584 * iniparse.y (add_correct_version): Copy descriptions across.
4585 * package_meta.cc (SDesc): Iterate through versions, return the first
4587 * package_version.h (packageversion): Add new virtuals set_[l|s]desc.
4589 2001-01-04 Robert Collins <rbtcollins@hotmail.com>
4591 * script.cc (run_script): Change cygpath:// to cygfile://.
4592 * install.cc (do_install_thread): Fix off-by-one errors.
4594 2001-01-04 Robert Collins <rbtcollins@hotmail.com>
4596 * package_db.cc (packagedb::flush): Fix an off-by-one error.
4598 2002-01-04 Jan Nieuwenhuizen <janneke@gnu.org>
4600 * Makefile.in (realclean): more clean.
4601 (OBJS): Add script.o.
4602 * postinstall.cc (run_script_in_etc_postinstall): New function.
4603 (do_postinstall): Split off new funtion init_run_script ().
4606 (run_script): Move to script.cc. Replace some deprecated remove
4609 * script.cc: New file.
4610 * Forward port cygwin-20010707.jcn3.patch.
4611 * package_meta.cc (uninstall): Run pre- and postremove scripts.
4612 * install.cc: Typo fix.
4613 (do_install): Run script initialisation.
4615 2001-01-04 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
4617 * cistring.cc: Run d2u.
4618 * cistring.h: Run d2u.
4620 * desktop.cc (etc_profile): Remove "test -f ./.bashrc && . ./.bashrc"
4621 from the generated /etc/profile. Bash will source this file
4622 automatically, and having this here merely results in .bashrc being
4623 executed twice. Run d2u.
4624 * desktop.h: Run d2u.
4626 * propsheet.cc: Run d2u.
4627 (PropSheetProc): New function. Add minimize box here instead of in
4628 PropertyPage::DialogProc.
4629 (PropSheet::Create): Change to use creation callback PropSheetProc.
4630 (DLGTEMPLATEEX): Add 'hidden' Windows struct definition.
4632 * propsheet.h: Run indent, d2u.
4633 * proppage.h: Run indent, d2u.
4635 * proppage.cc: Run d2u.
4636 (PropertyPage::DialogProc): Remove minimize-box-adding
4637 functionality. Remove commented-out "PropSheet_SetWizButtons" calls.
4638 Add support for calling virtual OnMessageCmd. Add setting of fonts in
4639 WM_INITDIALOG handler.
4640 (resource.h): New include for resource IDs.
4642 * res.rc: Resize and rearrange property page dialog templates
4643 to bring them in line with "Microsoft's Backward Compatible Wizard 97"
4644 specification. Run d2u.
4645 (IDD_SITE): Add an edit control and an "Add" button in order to
4646 combine the IDD_SITE and IDD_OTHER_URL functionality onto one page.
4647 (IDD_OTHER_URL): Remove dialog template.
4648 (IDD_DLSTATUS): Remove dialog template.
4651 (SitePage::OnBack): Remove NEXT() macro invocation.
4652 (SitePage::OnActivate): New member function.
4653 (load_dialog): Remove. Functionality subsumed into
4654 SitePage::OnActivate.
4655 (save_dialog): Change to support both list and user URLs. Remove
4656 OTHER_IDX and mirror_idx logic.
4657 (SitePage::PopulateListBox): New member function.
4658 (SitePage::CheckControlsAndDisableAccordingly): New member function.
4659 (SitePage::OnMessageCmd): New override.
4660 (check_if_enable_next): Remove.
4661 (dialog_cmd): Remove.
4662 (do_download_site_info_thread): Remove calls to NEXT() macro.
4663 (SitePage::Create): Call the single-param PropertyPage::Create
4665 (other_url): New static taken from other.cc.
4666 (SitePage::OnNext): Remove mirror_idx logic.
4667 (SitePage::OnInit): Remove "Other URL" entry from list box. Remove
4668 list box populating code, now handled in SitePage::PopulateListBox.
4669 (mirror_idx, NO_IDX, OTHER_IDX): Remove.
4670 (save_site_url): Fix potential buffer overflow problem. Switched to
4671 TCHAR in grossly premature preparation for multilingual support.
4673 (SitePage::OnActivate): New member function.
4674 (SitePage::CheckControlsAndDisableAccordingly) New member.
4675 (SitePage::OnMessageCmd): New override.
4676 (do_download_site_info_thread): Add MessageBox call on failure to
4679 * splash.cc: Run d2u.
4680 (SplashPage::OnInit): Set the font for the title.
4681 * splash.h: Run d2u.
4683 * threebar.cc: Run d2u.
4684 * threebar.h: Run d2u.
4686 * window.h: Run d2u.
4687 (Window::IsButtonChecked): New member function declaration.
4688 (Window::OnMessageCmd): New member function.
4689 (Window::SetDlgItemFont): New member function declaration.
4690 (Window::MAXFONTS, Window::Fonts, Window::FontCounter): New data
4692 * window.cc: Run d2u.
4693 (Window::IsButtonChecked): New member function definition.
4694 (Window::SetDlgItemFont): New member function definition.
4695 (Window::Window): Add initialization for FontCounter.
4696 (Window::~Window): Delete any fonts we created.
4698 * geturl.cc: Run d2u.
4699 (progress): Remove the "3" field width from the "%3d"
4700 percent-complete format indicator. Causes line to not start at
4701 beginning of text box, and does little to help with "jumping", since
4702 the "bytes downloaded so far" field is variable-width anyway. Change
4703 kb/s format field to "%03.1" to 0-pad the kb/s number in the event of
4704 painfully slow connections, or temporary slowdowns in faster
4705 connections should such more-instantaneous functionality become
4709 (NetPage::OnMessageCmd): New member function declaration.
4710 (NetPage::CheckIfEnableNext): New member function declaration.
4712 (NetPage::OnMessageCmd): New member function definition.
4713 (dialog_cmd): Remove, subsumed into NetPage::OnMessageCmd.
4714 (check_if_enable_next): Remove.
4715 (NetPage::CheckIfEnableNext): New member function, subsumes
4716 check_if_enable_next.
4717 (propsheet.h): Add include.
4718 (NetPage::Init): Add call to CheckIfEnableNext.
4719 (load_dialog): Remove call to check_if_enable_next.
4720 (NetPage::Create): Call single-template-ID-parameter overload of
4721 PropertyPage::Create instead of three-parameter one.
4723 * Makefile.in (OBJS): Remove other.o.
4724 * other.cc: Remove file.
4726 2002-01-01 Robert Collins <rbtcollins@hotmail.com>
4728 * README: Update TODO's.
4729 * choose.cc (set_existence): Delete non installed packages with no
4731 (fill_missing_category): Fix an off-by-one error.
4732 (default_trust): Ditto. Also delete any unused categories.
4733 (view::init_headers): Fix an off-by-one error.
4734 (set_view_mode): Ditto.
4735 (set_view_mode): Ditto.
4736 (create_listview): Ditto.
4737 (dialog_cmd): Ditto.
4739 * io_stream.cc: Indent.
4740 * io_stream.h: Ditto.
4741 * package_db.cc: Ditto.
4742 * package_meta.h: Const correctness for SDesc ();
4743 * proppage.cc: Run d2u and indent.
4744 * propsheet.cc: Run d2u and indent.
4745 * window.cc: Run d2u and indent.
4746 * window.h: Run d2u and indent.
4748 2001-12-28 Christopher Faylor <cgf@redhat.com>
4750 * Makefile.in (iniparse.o): Accommodate newer bisons.
4752 2001-12-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
4754 * window.h (Window): New file, new class.
4755 * window.cc (Window): New file, new class.
4757 * threebar.h (ThreeBarProgressPage): New file, new class.
4758 * threebar.cc (ThreeBarProgressPage): New file, new class.
4760 * splash.h (SplashPage): New file, new class.
4761 * splash.cc (SplashPage): Replace file with implementation of new
4764 * source.h (SourcePage): New file, new class.
4765 * source.cc: Run indent.
4766 (SourcePage): Add class implementation to this file.
4767 (do_source): Remove, functionality subsumed by SourcePage::Create()
4768 and SourcePage::OnDeactivate().
4769 (dialog_proc): Remove, functionality subsumed by
4770 SourcePage::OnActivate().
4772 * site.h: Run indent.
4773 (SitePage): Add class declaration.
4774 * site.cc: Run indent.
4775 (SitePage): Add class implementation.
4776 (do_download_site_info_thread): New function.
4777 (context): New var. Context info for do_download_site_info_thread().
4778 (do_download_site_info): New function.
4779 (SitePage::Create, SitePage::OnInit SitePage::OnNext)
4780 (SitePage::OnBack): SitePage class implementation..
4781 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers, now handled
4782 by SitePage members.
4783 (dialog_proc): Remove, now handled by SitePage::OnInit and base class
4785 (do_site): Remove, now handled by do_download_site_info_thread() and
4786 SitePage::OnNext functionality.
4787 (get_site_list): Remove dismiss_url_status_dialog() call.
4789 * root.h (RootPage): New file, new class.
4790 * root.cc: Run indent.
4791 (dialog_cmd): Pass parent HWND parameter to note(), yesno().
4792 (dialog_proc): Remove.
4794 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL clauses from switch.
4795 (RootPage::OnInit): New member function. Move get_root_dir() logic to
4796 here from do_root().
4797 (RootPage::Create): New member function.
4798 (RootPage::OnNext): New member function. Move IDOK logic from
4799 dialog_cmd() to here.
4800 (RootPage::OnBack): New member function.
4802 * propsheet.h (PropSheet): New file, new class.
4803 * propsheet.cc (PropSheet): New file, new class.
4805 * proppage.h (PropertyPage): New file, new class.
4806 * proppage.cc (PropertyPage): New file, new class.
4808 * postinstall.cc (do_postinstall): Add owner parameter.
4810 * other.cc (do_other): Add owner parameter.
4812 * nio-file.cc (NetIO::Purl): Pass NULL parent param to note().
4813 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Pass NULL parent param to
4815 * nio-http.cc (retry_get): Pass NULL parent param to get_auth(),
4818 * nio-ie5.cc (NetIO::_url): Pass NULL parent param to note(),
4819 get_auth(), get_proxy_auth().
4821 * netio.h (get_auth, get_proxy_auth, get_ftp_auth): Add owner param.
4822 * netio.cc (auth_common, NetIO::get_auth, NetIO::get_proxy_auth,
4823 NetIO::get_ftp_auth)
4824 (auth_common): Add owner param. Pass owner param to DialogBox.
4825 (NetIO::get_auth, NetIO::get_proxy_auth, NetIO::get_ftp_auth): Pass
4826 owner param to auth_common().
4828 * net.h (NetPage): New file, new class.
4829 * net.cc: Run indent.
4830 (net.h, threebar.h): Add includes.
4831 (Progress): Add extern.
4832 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, now handled by
4833 property sheet logic. Saved temporarily for reference.
4834 (NetPage::Create, NetPage::OnInit, NetPage::OnDeactivate,
4835 NetPage::OnNext, NetPage::OnBack):
4836 New implementation of NetPage class members.
4838 (dialog_proc): Remove.
4840 * msg.h (fatal, note, yesno): Add owner param.
4841 * msg.c (fatal, note, yesno, mbox): Add owner param.
4842 (mbox): Remove MB_TOPMOST from MessageBox call. Unnecessary and wrong
4843 now that we have a parent.
4845 * main.cc: Run indent.
4846 (commctrl.h, proppage.h, propsheet.h, splash.h, source.h)
4847 (localdir.h, net.h, site.h, choose.h, threebar.h, desktop.h): Include
4849 (root_dialog_proc): extern into this file.
4850 (Progress): Progress dialog defined here, used in several other files.
4851 (WinMain): Instantiate and create Splash, Source, Root, LocalDir, Net,
4852 Site, Chooser, Desktop pages and MainWindow sheet. Call
4853 InitCommonControls() to make sure Windows is set up for our use of
4854 property sheets. Add pages to sheet.
4855 Call MainWindow.Create() to "DoModal". Remove main loop, that logic is
4856 now handled by the PropSheet class.
4857 (root.h): Add include.
4859 * log.cc (log_save): Pass NULL parent to fatal().
4860 (exit_setup): Pass NULL parent to note().
4862 * localdir.h (LocalDirPage): New file, new class.
4863 * localdir.cc: Run indent.
4864 (localdir.h): New include.
4865 (threebar.h): New include.
4866 (Progress): extern into this file.
4867 (LocalDirPage::Create, LocalDirPage::OnInit, LocalDirPage::OnActivate)
4868 (LocalDirPage::OnNext, LocalDirPage::OnBack): Implementation of
4870 (LocalDirPage::OnNext): Move log() call from do_local_dir() to here.
4871 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers.
4872 (do_local_dir): Remove.
4873 (dialog_proc): Remove.
4874 (cwd): Remove, not used by anything.
4876 * install.cc: Run indent.
4877 (process.h, threebar.h): New includes.
4878 (Progress): extern into this file.
4879 (ins_dialog, ins_action, ins_pkgname, ins_filename, ins_pprogress)
4880 (ins_iprogress, ins_diskfull, init_event): Remove, now handled by
4881 ThreeBarProgressPage.
4882 (dialog_cmd, dialog_proc, dialog): Removed, handled in
4883 ThreeBarProgressPage.
4884 (init_dialog): Remove all mention of the above ins_* handles. Now
4885 handled in ThreeBarProgressPage. Altered SetWindowText()s to call
4886 ThreeBarProgressPage instance Progress directly.
4887 (progress): Alter bar update logic to call ThreeBarProgressPage
4888 instance Progress directly.
4889 (uninstall_one): Alter SetWindowText()s to call ThreeBarProgressPage
4890 instance Progress directly.
4891 (install_one_source): Alter SetWindowText()s to call
4892 ThreeBarProgressPage
4893 instance Progress directly. Pass NULL parent to note().
4894 (do_install_thread): Rename from do_install(), added owner param.
4895 Alter SetWindowText()s to call ThreeBarProgressPage instance Progress
4897 Remove dismiss_url_status_dialog() call, no longer necessary. Remove
4898 ShowWindow(<hide>) call, also unnecessary now. Pass owner handle to
4900 (do_install_reflector): New function.
4901 (do_install): New function.
4903 * ini.cc (process.h, threebar.h): New includes.
4904 (Progress): externed into this file.
4905 (find_routine): Pass NULL parent to note().
4906 (do_local_ini): Add owner param.
4907 (do_remote_ini): Add owner param. Pass owner to get_url_to_membuf()
4908 and note(). Remove call to dismiss_url_status_dialog().
4909 (do_ini_thread): Rename from do_ini(). Add owner param. Pass owner to
4910 do_local_ini(), do_remote_ini(), yesno(), and note(). Set next_dialog
4911 to IDD_CHOOSER on exit.
4912 (do_ini_thread_reflector): New function.
4913 (context): New var. Context for do_ini_thread.
4914 (do_ini): New function.
4916 * geturl.h (get_url_to_membuf, get_url_to_string, get_url_to_file): Add
4918 * geturl.cc (gw_dialog, gw_url, gw_rate, gw_progress, gw_pprogress,
4920 (gw_progress_text, gw_pprogress_text, gw_iprogress_text, init_event):
4922 (threebar.h): New include.
4923 (Progress): externed into this file.
4924 (dialog_cmd, dialog_proc, dialog): Removed, handled by
4925 ThreeBarProgressPage now.
4926 (init_dialog): Remove "if (gw_dialog == 0)" clause. Alter
4928 and bar setting SendMessage()s to call ThreeBarProgressPage instance
4929 Progress directly. Remove "one bar only" logic, this is now handled
4930 explicitly in the ThreeBarProgressPage class.
4931 (progress): Altered bar and text update logic to call
4932 ThreeBarProgressPage instance Progress directly. Changed kbps
4933 calculation to floating point and now print out a single decimal
4935 (get_url_to_membuf): Add owner param. Pass it to init_dialog.
4936 (get_url_to_string): Add owner param. Pass it to get_url_to_membuf.
4937 (get_url_to_file): Add owner param. Pass it to init_dialog. Alter bar
4938 update logic to call ThreeBarProgressPage instance Progress directly.
4939 (dismiss_url_status_dialog): Remove.
4941 * fromcwd.cc (do_fromcwd): Add owner param. Initialize found_ini to
4944 * download.cc: Run indent.
4945 (process.h, threebar.h): New includes.
4946 (Progress): externed into this file.
4947 (download_one): Add owner param. Pass it to get_url_to_file().
4948 (do_download_thread): Renamed from do_download. Add owner param. When
4949 calculating total_download_bytes, take binpicked and srcpicked into
4950 account. Remove call to dismiss_url_status_dialog(), no longer needed.
4951 Pass owner handle to download_one() and yesno().
4952 (do_download_reflector, do_download): New functions.
4953 (context): New var. Context for do_download_thread().
4955 * dialog.h (D(x)): Add owner param.
4957 * desktop.h (DesktopSetupPage): New file, new class.
4958 * desktop.cc: Run indent.
4959 (desktop.h): Add include.
4960 (dialog_proc, do_desktop): Remove, now handled in
4961 DesktopSetupPage::OnInit().
4962 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, handled in
4963 DesktopSetupPage::OnFinish(), DesktopSetupPage::OnBack(), and PropSheet
4965 (DesktopSetupPage::Create, DesktopSetupPage::OnInit)
4966 (DesktopSetupPage::OnBack, DesktopSetupPage::OnFinish): Implementation
4967 of DesktopSetupPage.
4969 * cistring.h: New file, new class.
4970 * cistring.cc: New file, new class.
4972 * choose.h: Run indent.
4973 (Chooser): New class declaration.
4974 * choose.cc: Run indent.
4975 (do_choose): Add owner param. Pass it to DialogBox() and
4977 (Chooser): New class implementation.
4979 * res.rc (IDS_VERSION_INFO): New string.
4980 (IDD_SOURCE, IDD_LOCAL_DIR, IDD_ROOT, IDD_SITE, IDD_OTHER_URL)
4981 (IDD_DLSTATUS, IDD_INSTATUS, IDD_SPLASH, IDD_CHOOSE, IDD_DESKTOP):
4982 Change WS_POPUP to WS_CHILD. Numerous positioning/size changes
4984 (IDD_CHOOSE): Give template the WS_EX_CONTROLPARENT style to enable
4985 TAB control navigation etc. Give the controls a reasonable tab order.
4986 Grouped radio buttons. Something's still not right, can't tab away
4987 from back/next/cancel group reliably.
4988 * resource.h (IDD_CHOOSER): New dialog ID.
4990 * Makefile.in (OBJS): Add cistring.o, proppage.o, propsheet.o,
4991 threebar.o, and window.o.
4993 2001-12-21 Robert Collins <rbtcollins@hotmail.com>
4995 * choose.cc (listview_proc): Update the scrollbar when the headers are
4997 (pick_pkg_line::paint): Clip columns to prevent overlap.
4999 2001-12-20 Robert Collins <rbtcollins@hotmail.com>
5001 * Makefile.in: Add libcomctl32.a for setup.exe.
5002 * archive.h (archive): Prevent non-child direct creation of the class.
5003 * archive_tar.h (archive_tar): Prevent inaccurate synthetic copy and
5005 * choose.cc: Include commctrl for the choose header.
5006 (NEW_COL_SIZE_SLOP): Define without magic numbers.
5007 (pkgtrustp): Convert to function.
5008 (set_action): Remove.
5009 (add_required, fill_missing_category,default_trust): Use list syntax for
5012 (choose_caption): Remove.
5013 (topbucket::paint): New method.
5014 (topbucket::empty): Ditto.
5015 (topbucket::click): Ditto.
5016 (topbucket::~topbucket): Ditto.
5017 (paint): Remove i,ii and p as they are obsolete.
5018 Remove header drawing code.
5019 Use new chooser method to paint the chooser.
5020 Use new chooser itemcount method.
5021 (scroll_common): Rename to view::scroll.
5022 Scroll the header window separately.
5023 (list_vscroll, list_hscroll, list_click): Update for new chooser
5025 (listview_proc): Look for header messages.
5026 (note_width): Accept stringless calls.
5027 (pick_line::set_line): Remove.
5028 (pick_line::paint): Remove.
5029 (pick_pkg_line::paint): Paint this one line, using the header column
5031 (pick_category_line::paint): Paint this category, and anything in the
5033 (pick_line::click): Remove.
5034 (pick_pkg_line::click): Handle a click.
5035 (pick_category_line::click): Handle a click.
5036 (_view): Rename all to view.
5037 (view::view): Initialise the control contents.
5038 (view::set_headers): Work with the header control.
5039 (view::init_headers): Use list syntax for package list.
5040 Rearrange the width logic a little.
5041 (view::insert_pkg): Update to use the hierarchy.
5042 (view::insert_category): Ditto.
5043 (view::insert_at, view::insert_under): Remove.
5044 (view::clear_view): Update to use the hierarchy.
5045 (view::click): Update to use the hierarchy.
5046 (set_view_mode): Use list syntax for package list.
5047 Update for new chooser methods.
5048 (DoInsertItem): New helper function. (Needs a home somewhere).
5049 (create_listview): Remove choose control code and use the constructor
5051 (dialog_cmd,scan2,do_choose): Use list syntax for package list.
5052 * choose.h: Include newly required headers list and package_meta.
5053 (_voew): Rename to view.
5054 (pick_line): Convert to an ABC.
5055 (pick_pkg_line): New class.
5056 (pick_catgory_line): New class.
5057 (topbucket): New class.
5058 (view::scroll): New method created from listview_scroll function.
5059 * desktop.cc (make_passwd_group): Use list syntax for package list.
5060 * download.cc (do_download): Use list syntax for package list.
5061 * fromcwd.cc (found_file): Use list syntax for package list.
5062 * iniparse.y (pacakges): Use list syntax for package list.
5063 * install.cc (uninstall_one): Use list syntax for package list.
5064 (do_install): Use list syntax for package list.
5065 * io_stream.h (io_stream): Prevent non-child direct creation of the
5067 Prevent inaccurate synthetic copy and assignment.
5068 * list.h: Include required header stdlib.
5069 Work on const correctness.
5070 * package_db.cc (packagedb::getpackagebyname): Remove.
5071 (packagedb::packagedb): Remove custom list code, and make db a local.
5072 (packagedb::getfirstpackage): Remove.
5073 (packagedb::getnextpackage): Remove.
5074 (packagedb::addpackage): Remove.
5075 (flush): Remove custom list code.
5076 (packagedb::registerpackage): Remove.
5077 (packagedb::packages): New static member.
5078 (packagedb::task): New static member.
5079 * package_db.h (PackageDBActions): New enum.
5080 (packagedb): Remove getfirstpackage, getnextpackage, getpackagebyname,
5081 addpackage, registerpackage, packages, packagecount, curr_package, db.
5083 * pacakge_meta.cc: Include package_db.h.
5084 (packagemeta::action_caption): New method.
5085 (packagemeta::set_action): New method.
5086 * package_meta.h (CategoryPackage): Initialise key.
5087 (packagemeta): Initialise key.
5088 Add set_action and action_caption methods.
5089 Prevent inaccurate synthetic copy and assignment.
5090 * resource.h (IDC_CHOOSE_LISTHEADER): New ID.
5091 * source.cc: Include package_db for db manipulation.
5092 (save_dialog): Set the db task.
5093 * win32.h: Tell the w32 include headers what IE version to
5096 2001-12-06 Robert Collins <rbtcollins@hotmail.com>
5098 * README: Wishlist updates.
5100 2001-12-04 Robert Collins <rbtcollins@hotmail.com>
5102 * package_db.cc (getnextpackage): Don't overrun the array.
5104 2001-12-04 Robert Collins <rbtcollins@hotmail.com>
5106 * Makefile.in (OBJS): Add setup_version.o.
5107 (version.c): Rename to setup_version.
5108 * choose.cc (set_action): Prevent NULL pointer dereference.
5109 (package_sort): Remove.
5110 * fromcwd.cc (canonicalize_version): Moved to version.cc.
5111 (check_ini): New function for use with find to see if there is a cached
5113 (do_fromcwd): Check for a cached setup.ini from any mirror site.
5114 * ini.cc (find_routine): New function, for finding cached setup.ini's.
5115 (do_local_ini): New function, drives parsing of local ini's.
5116 (do_remote_ini): New function, drives parsing and caching of remote
5118 (do_ini): Move guts to do_remote_ini and do_local_ini.
5119 * list.h (removebyindex): New method.
5120 * other.cc (save_dialog): Use new site_list and all_site_list to add the
5121 new site to the site picklist.
5122 (dialog_cmd): Only save the dialog when exiting the dialog.
5123 * res.rc (IDD_SITE): Make IDC_URL_LIST a multiple-selection control.
5124 * site.cc (site_list_type): Move to site.h
5125 (site_list): New global, sites chosen by the user.
5126 (all_site_list): New global, all potential sites.
5127 (site_list_type::init): New method, parses a mirror.lst URL string into
5128 a site_list_type object.
5129 (site_list_type::site_list_type): New method.
5130 (check_if_enable_next): Examine the control, not a local variable.
5131 (load_dialog): Select all the user chosen sites by default.
5132 (save_dialog): Adjust for multiple selection semantics.
5133 (save_site_url): Save all user chosen sites.
5134 (dialog_cmd): Don't save the dialog when the listbox recieves a message
5136 Remove obsolete other_url reference.
5137 (dialog_proc): Use all_site_list instead of site_list.
5138 (site_sort): Remove.
5139 (get_site_list): Remove malloc use - use list template instead.
5140 Move site_list_type initialisation to site_list_type::init().
5141 (get_initial_list_idx): Renamed to ...
5142 (get_saved_sites): this. Also read in multiple sites to the site_list.
5143 (do_site): Use all_site_list not site_list.
5144 Log all chosen sites.
5145 * site.h: New file, defines site related class, functions and variables.
5146 * state.h: Add comment about use of state.h
5147 (mirror_site): Remove.
5148 (other_url): Remove.
5149 (MIRROR_SITE): Remove.
5150 * version.cc: New file, for version-handling and related functions.
5152 2001-12-02 Robert Collins <rbtcollins@hotmail.com>
5154 * Makefile.in: Add filemanip.o to setup.
5155 * archive.cc (archive::extract_file): Use new io_stream method 'copy'.
5156 * archive_tar.h (archive_tar_file): Implement get_size virtual.
5157 (archive_tar): Ditto.
5158 * choose.cc (set_action): Use [] operator instead of getnth - its more
5161 (_view::init_headers): Ditto.
5162 (_view::insert_pkg): Ditto.
5163 (set_view_mode): Ditto.
5166 (base): Moved to filemanip.cc.
5167 (find_tar_ext): Ditto.
5168 (parse_filename): Ditto.
5169 (_Info::_Info): Remove.
5170 * compress_bz.h (compress_bz): Implement get_size virtual.
5171 * compress_gz.h (compress_gz): Implement get_size virtual.
5172 * cygpackage.cc (cygpackage::destroy): Use array delete for char *
5174 * download.cc (get_file_size): Move to filemanip.cc.
5175 (check_for_cached): Use [] operator instead of getnth - its more
5177 (download_one): Ditto.
5178 * filemanip.cc: New file.
5179 * geturl.cc (init_dialog): Make url a pointer to const as it is not
5181 (get_url_to_membuf): New function - contains get_url_to_string worker
5183 (get_url_to_string): Becomes a trivial wrapper to get_url_to_membuf.
5184 * geturl.h: Declare new prototype.
5185 * ini.cc (do_ini): Use get_url_to_membuf and pass ini_init an io_stream.
5186 Tidy up the error code a little.
5187 * ini.h: Remove __cplusplus protection for ini_init.
5189 * inilex.l: Remove old globals.
5190 (ini_init): Use an io_stream for getting the characters.
5191 (ini_getchar): Ditto.
5192 * iniparse.y: Declare yylex as a C++ function.
5193 (add_correct_version): Use [] operator instead of getnth - its more
5195 * io_stream.cc (io_stream::move_copy): Use the copy method.
5196 (io_stream::copy): New method to simply copy from one stream to another.
5197 * io_stream.h (io_stream): New static method copy, and virtual method
5199 * io_stream_cygfile.cc (io_stream_cygfile::get_size): Implement this.
5200 * io_stream_cygfile.h (io_stream_cygfile::get_size): Declare this.
5201 * io_stream_file.cc (io_stream_file::get_size): Implement this.
5202 * io_stream_file.h (io_stream_file::get_size): Declare this.
5203 * io_stream_memory.h: Include errno as it's neded to parse the header.
5204 (io_stream_memory::get_size): Implement this.
5205 (io_stream_memory::st_size): Delete this.
5206 * list.h: Change getnth into the [] operator.
5207 * netio.cc (NetIO::NetIO): Change prototype to reflect Purl not being
5209 (NetIO::set_url): Ditto.
5210 (NetIO::open): Ditto.
5211 * netio.h: As for netio.cc.
5212 * nio-file.cc (NetIO_File::NetIO_File): Change prototype to reflect
5213 Purl not being modified.
5214 * nio-file.h: Ditto.
5215 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
5216 * nio-ftp.h (NetIO_FTP::NetIO_FTP): Ditto.
5217 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Ditto.
5218 * nio-http.h (NetIO_HTTP::NetIO_HTTP): Ditto.
5219 * nio-i5.cc (NetIO_IE5::NetIO_IE5): Ditto.
5220 * nio-i5.h (NetIO_IE5::NetIO_IE5): Ditto.
5221 * package_meta.cc (packagemeta::~packagemeta): Bugfix: use array delete.
5222 * package_source.cc (packagesource::set_canonical): Ditto.
5223 (packagesource::set_cached): Ditto.
5224 * package_source.h (site::~site): Ditto.
5225 * site.cc: Change site_list_type to a class, and search and replace
5226 sort_key to key globally.
5228 2001-12-01 Robert Collins <rbtcollins@hotmail.com>
5230 * package_source.cc (packagesource::set_canonical): Filename was out by
5233 2001-11-30 Robert Collins <rbtcollins@hotmail.com>
5235 * Makefile.in (OBJS): Remove category_list - it's not needed.
5236 * README: More wishlist updates.
5237 * category.cc (Category::Category): Initialise new members.
5238 (Categorycmp): New function.
5239 * category.h (Category): New member key for template use.
5240 * category_list.cc: Remove.
5241 * category_list.h: Remove.
5242 (Categorycmp): New function prototype.
5243 * choose.cc: Remove category_list - not needed.
5244 (set_action): Only show the 'source' option when the source is actually
5246 (add_required): Fix recursion limiter to 5.
5247 (fill_missing_category): Use list access.
5248 (default_trust): Ditto.
5249 (pick_line::paint): Ditto.
5250 (_view::init_headers): Ditto.
5251 (_view::insert_pkg): Ditto.
5252 (_view::insert_category): Ditto.
5253 (_view::click): Ditto.
5254 (set_view_mode): Ditto.
5256 * cygpackage.h: Remove category_list - not needed.
5257 * geturl.cc (get_url_to_string): Fix null byte insertion.
5258 * inipatse.y: Remove category_list - not needed.
5259 (categories): Use list access.
5260 * package_db.cc: Ditto.
5261 * package_db.h: Remove category_list - not needed.
5262 (packagedb): Use the list template for categories.
5263 * package_meta.cc (add_category): Ditto.
5264 * package_meta.h (CategoryPackage): Link to the category as well.
5265 (packagemeta): Use a list of CategoryPackages instead of Categories
5266 for more memory efficient cross-referencing.
5268 2001-11-30 Robert Collins <rbtcollins@hotmail.com>
5270 * package_db.cc (packagedb::flush): Write a canonical version for all
5271 packages irrespective of the media they were installed from.
5273 2001-11-29 Robert Collins <rbtcollins@hotmail.com>
5275 * Makefile.in (OBJS): Add package_source and rfc1738.
5276 * README: Wishlist update.
5277 * category_list.cc (register_category): Use references.
5278 * category_list.h (CategoryList): Ditto.
5279 * choose.cc (isinstalled): Remove.
5280 (pkgtrustp): New macro.
5281 (set_action): Use packagemeta.
5282 (add_required): Ditto.
5283 (choose_caption): Example package to choose caption, rather than state
5285 (check_existence): Remove.
5286 (set_existence): Remove old code.
5287 (fill_missing_category): Use packagemeta.
5288 (keep_or_skip): Remove.
5289 (default_trust): Use packagemeta and set trust values directly.
5290 (pick_line::set_line): Use packagemeta.
5291 (_view::insert_pkg): Ditto.
5292 (_view::insert_category): Ditto.
5293 (_view::click): Ditto.
5294 (set_view_mode): Ditto. Also remove "exclude" code.
5295 (create_listview): Use packagemeta.
5296 (dialog_cmd): Ditto.
5297 (getpkgbyname): Remove
5298 (scan2): Use packagemeta. Temporarily comment out the holefinding code.
5299 (read_installed_db): Remove.
5300 (package_sort): Use packagemeta.
5301 (do_choose): Use packagemeta. Don't sort the packages - the db does
5303 * choose.h: Use packagemeta.
5304 * cygpackage.cc (cygpackage::cygpackage): Initialise all variables.
5305 (cygpackage::cygpackage): Ditto.
5306 (cygpackage::set_canonical_version): Copy the passed string.
5307 (cygpackage::~cygpackage): Move cleanup code to destroy().
5308 (cygpackage::destroy): New function.
5309 (cygpackage::getfirstfile): Use a separate buffer.
5310 (cygpackage::getnextfile): Ditto.
5311 (cygpackage::Canonical_version): New function.
5312 (cygpackage::set_sdesc): Ditto.
5313 (cygpackage::set_ldesc): Ditto.
5314 * cygpackage.h (cygpackage::Canonical_version): New method.
5315 (cygpackage::set_sdesc): New method.
5316 (cygpackage::set_ldesc): New method.
5317 (cygpackage::SDesc): New method.
5318 (cygpackage::LDesc): New method.
5319 (cygpackage::set_canonical_version): New method.
5320 * desktop.cc: Include packagedb headers.
5321 (make_password_group): Use packagemeta.
5322 * download.cc: Include packagedb headers.
5323 (check_for_cached): New method to find any cached file and fill out the
5325 (download_one): Take a packagesource, support multiple mirrors.
5326 (do_download): Use packagemeta.
5327 * from cwd.cc: Include packagedb headers.
5328 (found_file): Use packagemeta.
5329 * ini.cc (do_ini): Beginning of multiple-mirror support.
5330 * ini.h (CategoryPackage): Remove.
5331 (Dependency): Remove.
5333 (new_package,getpkgbyname,getpackagecategorybyname,add_category):
5335 * inilex.l: Support multiple mirrors.
5336 * iniparse.y: Include packagedb headers.
5337 (parser): Use packagemeta.
5338 (new_package): Remove.
5339 (add_correct_version): New function.
5340 (new_requirement): Remove.
5341 (add_category): Remove.
5342 * install.cc (uninstall_one): Use packagemeta.
5343 (install_one_source): New function.
5344 (install_one): Use packagemeta.
5345 (do_install): Use packagemeta.
5346 * io_stream.cc (io_stream::move): Bugfix on move/copy case.
5347 * io_stream_cygfile.cc (io-stream_cygfile::set_mtime): Do not reopen the
5348 file after setting the mtime, it makes no sense, and results in 0 length
5350 * io_stream_file.cc (io-stream_file::set_mtime): Ditto.
5351 * list.h: New file, template class for a form of list.
5352 * package_db.cc (packagedb::registerpackage): New function.
5353 * package_db.h (packagedb::npackages ()): New method.
5354 * package_meta.cc (packagemeta::add_version): Use list template.
5355 (packagemeta::set_installed): Ditto.
5356 (packagemeta::add_category): New method.
5357 * package_meta.h: Include necessary headers to parse the class.
5358 (CategoryPackage): New class.
5359 (packagemeta): Initialise all members.
5360 (packagemeta::SDesc): New method.
5361 (packagemeta::Categories): New method.
5362 (packagemeta::add_category): Ditto.
5363 (packagemeta::versions): Change to be a list instance.
5364 * package_source.cc (packagesource::set_canonical): New method.
5365 (packagesource::set_cached): New method.
5366 * package_source.h: Include necessary headers to parse the class.
5368 (packagesource::packagesource): Initialize all members.
5369 (packagesource): Make this class non-abstract.
5370 * package_version.cc (packageversion::packageversion): New method.
5371 * package_version.h (Dependency): New class.
5372 (packageversion::Canonical_vesion): New method.
5373 (packageversion::SDesc): New method.
5374 (packageversion::LDesc): New method.
5375 (packageversion::new_requirement): Ditto.
5376 (packageversion::srcpicked, binpicked): What to install.
5377 (packageversion::src, bin): Installation source data.
5378 * rfc1738.cc: New file. Escapes special characters in URL's.
5381 2001-11-26 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5383 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Stop header parsing when
5384 SimpleSocket::gets() returns a zero-length string, so that we
5385 don't end up eating the entire stream thinking it's all header info.
5387 2001-11-23 Robert Collins <rbtcollins@hotmail.com>
5389 * install.cc (badrename): Remove.
5390 (do_install): Use packagedb flush method to write
5391 /etc/setup/installed.db.
5392 * io_stream.cc (io_stream::move_copy): New method.
5393 (io_stream::move): New method.
5394 * io_stream.h (io_stream): New methods move and move_copy.
5395 * io_stream_cygfile.cc (io_stream_cygfile::move): New method.
5396 * io_stream_cygfile.h (io_stream_cygfile): New method move.
5397 * io_stream_file.cc (io_stream_file::move): New method.
5398 * io_stream_file.h (io_stream_file): New method move.
5399 * package_db.cc (packagedb::flush): New method.
5400 * package_db.h (packagedb): New method flush.
5402 2001-11-23 Robert Collins <rbtcollins@hotmail.com>
5404 * Makefile.in (OBJS): Add package_version.
5405 * ategory.cc (Category::Category): Update constructors.
5406 * category_list.cc (CategoryList::register_category): Insert correctly.
5407 * choose.cc: Include package_version.h, not package.h.
5408 * cygpackage.cc: Ditto.
5409 (cygpackage::uninstall): New method.
5410 * cygpackage.h (cygpackage): Rename genericpackage to packageversion.
5411 New method uninstall.
5412 * hash.cc (add, has, enumerate): Change prototype to be accurate.
5413 * hash.h (hash): Change prototypes to be accurate.
5414 * ini.h (_Info): New parameterless constructor.
5415 (CategoryPackage): New constructor.
5417 * install.cc: Don't include unneeded headers.
5418 Include package database headers.
5419 (hash::add_subdirs): Remove.
5420 (uninstall_one): Use packagemeta->uninstall to perform the
5421 uninstallation. Don't uninstall source packages.
5422 (do_install): Just can uninstall_one once as we ignore source packages
5423 now. Don't copy the installed.old database accross, instead iterate
5424 through the packagedb packages list and write the installed packages
5426 * package_db.cc: Include package_version.h, not package.h.
5427 (packagedb::packagedb): Never let db be undefined.
5428 Record the installation filename, so we can reconstruct installed.db.
5429 (packagedb::addpackage): Insert packages in alpha sorted order.
5430 (packagedb::categories): Initialise correctly.
5431 * package_meta.cc: Include win32 and mount headers as a workaround to
5432 current io_stream limitations. Include a TODO about that.
5433 (standard_dirs): New, from install.cc.
5434 (hash::add_subdirs): New, from install.cc.
5435 (packagemeta::set_installed): Rename genericpackage to packageversion.
5436 (packagemeta::uninstall): New method.
5437 * package_meta.h: Rename genericpackage to packageversion.
5438 (packagemeta): Update constructor.
5439 (add_version, set_installed): Rename genericpackage to packageversion.
5440 (uninstall): New method.
5441 (installed_from): New member.
5442 * package_source.cc: New file.
5443 * package_source.h: New file.
5444 * package_version.cc: New file.
5445 * package_version.h: New file.
5446 * package.cc: Removed.
5447 * package.h: Removed.
5449 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
5451 * Makefile.in (OBJS): Add category.o and category_list.o.
5452 * category.h: New file.
5453 * category.cc: New file.
5454 * category_list.h: New file.
5455 * category_list.cc: New file.
5456 * choose.cc: Include category headers.
5457 (fill_missing_category): Use package_db to access global categories.
5458 (_view::insert_pkg): Ditto.
5459 (_view::insert_category): Ditto.
5460 (set_view_mode): Ditto.
5461 (getcategorybyname): Remove.
5462 * cygpackage.h: Include category_list.h to parse this correctly.
5463 (cygpackage): New virtual &Categories.
5464 * ini.h (_CategoryPackage): More C to C++ conversion.
5466 (getcategorybyname): Remove.
5467 (register_category): Remove.
5468 * iniparse.y: Include package db and category headers.
5469 (categories): Use package_db to access global categories.
5471 (ncategories): Remove.
5472 (register_category): Remove.
5473 * package.h: New virtual &Categories.
5474 * package_db.cc (packagedb::packagedb): Don't read the installed db
5476 (packagedb::categories): Declare.
5477 * package_db.h (packagedb): New member categories for global categories
5480 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
5482 * choose.h: Don't include ini.h
5483 * ini.h: Allow pure c++ in the header file.
5485 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
5487 * install.cc (do_install): Write a version 2 installed.db file.
5488 * package_db.cc (packagedb::packagedb): Read version 1 and 2
5491 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
5493 * Makefile.in (OBJS): Add package abstraction objects.
5494 * choose.cc: Include package abstraction headers.
5495 (read_installed_db): Use packagedb class and ignore installed sources.
5496 * cygpackage.cc: New file.
5497 * cygpackage.h: New file.
5498 * filemanip.h (get_file_size): Use unixy types.
5499 * package.h: New file.
5500 * package.cc: New file.
5501 * package_db.cc: New file.
5502 * package_db.h: New file.
5503 * package_meta.cc: New file.
5504 * package_meta.h: New file.
5506 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
5508 * REAME: Updates to wishlist.
5510 2001-11-16 Robert Collins <rbtcollins@hotmail.com>
5512 * README: Updated and added my list of wishlist and todo items.
5514 2001-11-14 Robert Collins <rbtcollins@hotmail.com>
5516 * Makefile.in (OBJS): Include io_stream_memory in setup.exe.
5517 * archive_tar.cc (archive_tar::write): New prototype.
5518 (archive_tar::seek): New method.
5519 * archive.h (archive_tar_file): Update write() and add seek().
5520 (archive_tar): Ditto.
5521 * archive_tar_file.cc (archive_tar_file::write): New prototype.
5522 (archive_tar_file::seek): New method.
5523 * compress_bz.cc (compress_bz::write): New prototype.
5524 (compress_bz::seek): New function.
5525 * compress_bz.h (compress_bz): Update write() and add seek().
5526 * compress_gz.cc (compress_gz::write): New prototype.
5527 (compress_gz::seek): New function.
5528 * compress_gz.h (compress_gz): Update write() and add seek().
5529 * geturl.cc: Include io_stream headers.
5531 (get_url_to_string): Use a io_stream_memory buffer instead of GUBuf.
5532 * io_stream.h (io_stream_seek_t): New enum.
5533 (io_stream): Update write() and add seek().
5534 * io_stream_cygfile.cc (io_stream_cygfile::write): New prototype.
5535 (io_stream_cygfile::seek): New function.
5536 * io_stream_cygfile.h (io_stream_cygfile): Update write() and add
5538 * io_stream_file.cc (io_stream_file::write): New prototype.
5539 (io_stream_file::seek): New function.
5540 * io_stream_file.h (io_stream_file): Update write() and add seek().
5542 2001-11-13 Brian Keener <bkeener@thesoftwaresource.com>
5544 * localdir.cc: Add headers unistd.h and port.h.
5545 (save_local_dir): Expand search logic to include local directory for
5546 location of file last-cache.
5547 (dialog_cmd): Skip IDD_ROOT when downloading and use Back button.
5548 (do_local_dir): Expand search logic to include local directory for file
5550 * res.rc (IDD_CHOOSE_DIALOG): Add hotkey to View button.
5551 * Source.cc (dialog_cmd): Skip IDD_ROOT if select Download from
5553 (do_source): Default to Install from Internet on first entry or
5554 previous selection if backing up from IDD_ROOT or IDD_LOCAL_DIR.
5556 2001-11-13 Robert Collins <rbtcollins@hotmail.com>
5558 * choose.cc (find_tar_ext): Only match at the end of the string.
5559 (getpkgbyname): Prevent NULL pointer dereference.
5561 2001-11-13 Robert Collins <rbtcollins@hotmail.com>
5563 * Makefile.in (CFLAGS): Add warnings and -Werr.
5564 (WARNONLY_FLAGS): For sources that produce (harmless) errors no matter
5566 (OBJS): Add io_stream class' objects.
5567 (autoload.o): Use WARNONLY_FLAGS.
5569 (iniparse.o): Ditto.
5570 * archive.cc: New file.
5571 * archive.h: New file.
5572 * archive_tar.cc: New file.
5573 * archive_tar.h: New file.
5574 * archive_tar_file.cc: New file.
5575 * autoload.c: Fix compiler warnings (unused, deprecated conversion).
5576 * choose.cc: Use io_stream.h, not mount.h.
5578 (find_tar_ext): Rewritten to use strstr, and to accept .tar as an
5580 (read_installed_db): Use io_streams.
5581 * choose.h: Run indent.
5582 * compress.cc: New file.
5583 * compress.h: New file.
5584 * compress_bz.cc: New file.
5585 * compress_bz.h: New file.
5586 * compress_gz.cc: New file.
5587 * compress_gz.h: New file.
5588 * concat.cc: Run indent.
5589 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5590 * concat.h: Run indent.
5591 * desktop.cc: Run indent.
5592 Include mklink2.h rather than redefining by hand.
5593 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5594 (etc_profile): Fix compiler warning (deprecated conversion).
5595 (make_link): Fix compiler warning (deprecated conversion).
5596 Tidy up use of args variable - consolidate into argbuf.
5597 (start_menu): Fix compiler warning (deprecated conversion).
5598 (desktop_icon): Fix compiler warning (deprecated conversion).
5599 (make_etc_profile): Fix compiler warning (deprecated conversion).
5600 (uexists): Fix compiler warning (deprecated conversion).
5601 (check_desktop): Fix compiler warning (deprecated conversion).
5602 (check_startmenu): Fix compiler warning (deprecated conversion).
5603 * dialog.cc: Run indent.
5604 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5605 (fatal): Fix compiler warning (deprecated conversion).
5606 * dialog.h: Run indent.
5607 * diskfull.cc: Run indent.
5608 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5609 * download.cc: Run indent.
5610 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5611 (download_one): Fix compiler warning (signed vs unsigned comparison).
5612 * filemanip.h: Run indent.
5613 * find.cc: Run indent.
5614 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5615 (find): Fix compiler warning (deprecated conversion).
5616 * find.h: Run indent.
5617 * fromcwd.cc: Run indent.
5618 * geturl.cc: Run indent.
5619 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5620 (dialog_cmd): Return a value.
5621 (dialog_proc): Remove unused variables.
5623 (get_url_to_file): Fix compiler warning (deprecated conversion).
5624 * geturl.h: Run indent.
5625 * hash.cc: Run indent.
5626 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5627 * hash.h: Run indent.
5628 * ini.cc: Run indent.
5630 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5631 (do_ini): Use io_streams for local io.
5632 * ini.h: Run indent.
5633 * inilex.l (ignore_line): Fix compiler warning (is not a prototype).
5634 Fix compiler warning (brackets for truth assignment).
5635 * install.cc: Run indent.
5636 Fix compiler warning (/* in comment).
5638 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5639 (dialog_cmd): Return a value.
5640 (dialog_proc): Return a value.
5641 (start_tics): Deleted - was unused.
5642 (badrename): Fix compiler warnings (unused, deprecated conversion).
5643 (standard_dirs): Fix compiler warning (deprecated conversion).
5645 (uninstall_one): Convert to io_streams.
5646 (install_one): Convert to io_streams.
5647 (do_install): Convert to io_streans.
5648 Fix compiler warning (deprecated conversion).
5649 * io_stream.cc: New file.
5650 * io_stream.h: New file.
5651 * io_stream_cygfile.cc: New file.
5652 * io_stream_cygfile.h: New file.
5653 * io_stream_file.cc: New file.
5654 * io_stream_file.h: New file.
5655 * localdir.cc: Run indent.
5657 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5658 (get_root_dir_now): Remove.
5659 (save_local_dir): Convert to io_streams.
5660 (dialog_cmd): Return a value.
5661 (do_local_dir): Convert to io_streams.
5662 (log.cc): Run indent.
5663 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5664 (log): Fix compiler warning (deprecated conversion).
5665 (log_save): Fix compiler warning (deprecated conversion).
5666 * log.h: Run indent.
5667 (log): Fix compiler warning (deprecated conversion).
5668 (log_save): Fix compiler warning (deprecated conversion).
5669 * main.cc: Run indent.
5670 Don't include "netio.h".
5671 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5672 (netio_test): Remove.
5673 (sid_auth): Fix compiler warning (partially bracketed initialiser).
5674 (WinMain): Return a value.
5675 * mkdir.cc: Run indent.
5676 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5677 * mklink2.c: Run indent.
5678 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5679 (mkcygsymlink): New function.
5680 * mklink2.h: New file.
5681 * mount.cc: Run indent.
5682 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5683 (create_mount): Remove unused variables.
5684 (cygpath): Fix compiler warning (signed vs unsigned comparison).
5685 * mount.h: Run indent.
5686 * msg.cc: Run indent.
5687 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5688 (msg): Fix compiler warning (deprecated conversion).
5689 (mbox): Fix compiler warning (deprecated conversion).
5690 * msg.h: Run indent.
5691 (msg): Fix compiler warning (deprecated conversion).
5692 * net.cc: Run indent.
5693 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5694 (dialog_cmd): Return a value.
5695 * netio.cc: Run indent.
5696 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5697 (auth_cmd): Return a value.
5698 * netio.h: Run indent.
5699 * nio-file.cc: Run indent.
5700 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5701 (NetIO_File::NetIO_File): Fix compiler warning (deprecated conversion).
5702 * nio-file.h: Run indent.
5703 * nio-ftp.cc: Run indent.
5704 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5705 * nio-ftp.h: Run indent.
5706 * nio-http.cc: Run indent.
5707 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5708 * nio-http.h: Run indent.
5709 * nio-ie5.cc: Run indent.
5710 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5711 * nio-ie5.h: Run indent.
5712 * other.cc: Run indent.
5713 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5714 (dialog_cmd): Return a value.
5715 * port.h: Run indent.
5716 * postinstall.cc: Run indent.
5717 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5718 (cmd): Fix compiler warning (deprecated conversion).
5719 (eun): Fix compiler warning (deprecated conversion).
5720 * root.cc: Run indent.
5721 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5722 * simpsock.cc: Run indent.
5723 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5724 * simpsock.h: Run indent.
5725 * site.cc: Run indent.
5727 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5728 (get_root_dir_now): Remove.
5729 (save_site_url): Convert to io_streams.
5730 (dialog_cmd): Return 0.
5731 (get_initial_list_idx): Convert to io_streans.
5732 * source.cc: Run indent.
5733 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5734 (check_if_enable_next): Remove.
5735 (load_dialog): Remove unused variables.
5736 (save_dialog): Ditto.
5737 (dialog_cmd): Return a value.
5738 * splash.cc: Return a value.
5739 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5740 (dialog_cmd): Return a value.
5741 * state.cc: Run indent.
5742 (cvsid): Fix compiler warnings (unused, deprecated conversion).
5743 * state.h: Run indent.
5747 2001-11-12 Christopher Faylor <cgf@redhat.com>
5749 * desktop.cc (start_menu): Change start menu name to "Cygwin".
5750 (check_startmenu): Ditto.
5752 2001-11-11 Christopher Faylor <cgf@redhat.com>
5754 * choose.cc (parse_filename): Finish reorganization by correctly
5755 decrementing p in memmove.
5757 2001-11-11 Christopher Faylor <cgf@redhat.com>
5759 * choose.cc (parse_filename): Reorganize code to work around gcc
5760 optimization problem.
5762 2001-11-09 Gareth Pearce <tilps@hotmail.com>
5764 * choose.cc (set_action): Allow skip as an option for installed
5765 packages that have version number not listed in setup.ini.
5767 2001-11-10 Robert Collins <rbtcollins@hotmail.com>
5769 * choose.cc (set_cation): Backout last change.
5770 (choose_caption): Ditto.
5772 2001-11-10 Robert Collins <rbtcollins@hotmail.com>
5774 * ini.h (actions): Remove - transferred to choose.h.
5776 * choose.h: Protect class's from "C" compilers.
5777 (actions): New enum, from ini.h. This may not be the 'right' place
5778 but that place doesn't exist yet.
5779 (_views): New enum, from ini.h.
5780 * choose.cc (set_action): Handle installed packages with a version not
5782 (choose_caption): Ditto.
5783 * iniparse.y: Rearrange header order to handle new ini.h.
5785 2001-11-10 Robert Collins <rbtcollins@hotmail.com>
5787 * ini.h (_Info): Fix compiler warnings (signed vs unsigned comparison).
5788 (registry_category): Fix compiler warning (deprecated conversion).
5789 * iniparse.y (registry_category): Ditto.
5790 * choose.cc (cvsid): Fix compiler warnings (unused, deprecated
5792 (add_requried): Remove unused variable.
5793 (choose_caption): Handle all enumeration values via a default.
5794 (paint): Fix compiler warnings (unused, deprecated conversion).
5795 (scroll_common): Fix compiler warnings (unused, signed vs unsigned
5797 (list_clicK): Fix compiler warnings (signed vs unsigned comparison).
5798 (note_width): Fix compiler warnings (deprecated conversion).
5799 (keep_or_skip): Fix compiler warnings (unused).
5800 (_view::mode_caption): Fix compiler warnings (deprecated conversion).
5801 (set_view_mode): Fix compiler warnings (unused).
5802 (create_listview): Fix compiler warnings (unused, incorrect format,
5803 reaches end of function).
5804 (dialog_proc): Fix compiler warnings (unused).
5805 (read_installed_db): Fix compiler warnings (unused, deprecated
5807 * choose.h (_header): Fix compiler warnings (deprecated conversion).
5810 2001-11-08 Pavel Tsekov <ptsekov@syntrex.com>
5812 * simpsock.h (SimpleSocket::invalidate): Declare new method.
5813 * simpsock.cc (SimpleSocket::invalidate): Implement new method.
5814 (SimpleSocket::SimpleSocket): Initialize buf to zero. Do not allocate
5815 memory for buf in the constructor.
5816 (SimpleSocket::~SimpleSocket): Use SimpleSocket::invalidate().
5817 (SimpleSocket::printf): Use SimpleSocket::write() instead of send().
5818 (SimpleSocket::write): Check object consistency - return -1 on error.
5819 invalidate() the object on socket write error.
5820 (SimpleSocket::fill): Check object consistency - return -1 on error.
5821 invalidate() the object if socket read error is encountered and there
5822 is no more data available in the internal read buffer.
5823 Allocate memory for the internal read buffer.
5824 (SimpleSocket::gets): Return zero (NULL pointer) if error is encountered
5825 during fill() and no more data is available in the internal read buffer.
5826 (SimpleSocket::read): Check object consistency - return -1 on error.
5827 invalidate() the object if socket read error is encountered.
5828 * nio-ftp.cc (NetIO_FTP:NetIO_FTP): Allow 125 as valid response code to
5829 the RETR command (fix for MS IIS ftp server 5 - possibly others too).
5830 (NetIO_FTP::ok): Check if the SimpleSocket object is ok().
5831 (NetIO_FTP::read): Use NetIO_FTP::ok().
5832 * nio-http.cc: Check for valid return value of SimpleSocket::gets().
5833 (NetIO_HTTP::ok): Check if the SimpleSocket object is ok().
5835 2001-11-09 Robert Collins <rbtcollins@hotmail.com>
5837 * simpsock.cc (cvsid): Avoid compiler warnings (not used, deprecated
5839 (SimpleSocket::SimpleSocket): Avoid compiler warnings (deprecated
5841 (SimpleSocket::printf): Ditto.
5842 (SimpleSocket::write): Ditto.
5843 * simpsock.h (SimpleSocket): Avoid compiler warnings for constructor,
5845 * nio-ftp.cc (cvsid): Avoid compiler warnings (not used, deprecated
5847 (NetIO_FTP::NetIO_FTP): Remove unused variable done.
5848 * nio-http.cc (cvsid): Avoid compiler warnings (not used, deprecated
5851 2001-11-07 Charles Wilson <cwilson@ece.gatech.edu>
5853 * geturl.cc (get_url_to_string): clean up memory leak
5854 (get_url_to_file): ditto
5856 2001-11-06 Robert Collins <rbtcollins@hotmail.com>
5858 * localdir.cc (dialog_cmd): Go back to IDD_ROOT in every case.
5859 * source.cc (dialog_cmd): Go forward to IDD_ROOT in every case.
5861 2001-11-06 Pavel Tsekov <ptsekov@syntrex.com>
5863 * fromcwd.cc (found_file): Free() memory containing the version and
5864 filepath information for a given package, before replacing the pointers
5865 which reference this memory.
5867 2001-11-06 Robert Collins <rbtcollins@hotmail.com>
5869 * fromcwd: Fix compiler warnings for cvsid.
5870 (canonicalize_version): Fix compilter warnings.
5871 (do_fromcwd): Ditto.
5872 * version.h: Fix compiler warnings for canonicalize_version.
5874 2001-11-03 Robert Collins <rbtcollins@hotmail.com>
5876 * res.rc (IDD_CHOOSE): Move the view caption to the right hand side.
5878 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5880 * res.rc (IDD_CHOOSE): Tweak for use on a 640x480 screen.
5882 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5884 * choose.cc (set_action): Correctly allow skip for any uninstalled
5887 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5889 * choose.cc (default_trust): Change the "Required" forced install
5892 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5894 * choose.cc: Ran indent.
5895 (set_action): When the requested trust level is missing and the level
5896 was not user requested, set the action to ACTION_SAME_CURR.
5898 2001-11-01 Christopher Faylor <cgf@redhat.com>
5900 * Makefile.in (mingw_getopt.o): Fix typo in non-verbose compilation.
5902 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5904 * choose.cc (_view::init_headers): Resync with the paint logic.
5906 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5908 * choose.cc (add_required): Allow SKIP and SRC_ONLY for currently
5911 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5913 * choose.cc (default_trust): Autoset currently installed packages per
5914 the user's selection of prev/curr/exp.
5916 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5918 * splash.cc (dialog_proc): Return TRUE as specified in the WIN32 API.
5920 2001-11-02 Pavel Tsekov <ptsekov@syntrex.com>
5922 * geturl.cc (is_showing): Remove.
5923 (is_local_install): New static variable. Controls whether the
5924 progress dialog and the supporting thread will be created.
5925 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the WIN32
5927 (init_dialog): Remove usage of SetForegroundWindow and is_showing.
5928 This prevents the progress dialog to gain control over the
5929 application and fixes the "setup.exe going to background" problem.
5930 (progress): Use is_local_install.
5931 (get_url_to_string): Set is_local_install.
5932 (dismiss_url_status_dialog): Use is_local_install.
5933 * install.cc (dialog_proc): Return TRUE as specified in WIN32 API.
5934 (init_dialog): Remove usage of SetForegroundWindow.
5935 This prevents the progress dialog to gain control over the
5936 application and fixes the "setup.exe going to background" problem.
5938 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5940 * choose.cc (list_click): Change r to row for clarity.
5941 When we shrink the list below 1 page, scroll to the top of the list.
5942 (_view::click): Return the actual change for contractions.
5943 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the Win32
5946 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
5948 * choose.cc (dialog_cmd): Swap cygwin root selection and local dir
5950 * localdir.cc: Ran indent.
5951 (get_root_dir_now): New function.
5952 (save_local_dir): New function.
5953 (dialog_cmd): Use it and swap cygwin root selection and local dir
5955 (do_local_dir): If there is a saved local dir, read it in.
5956 * net.cc (dialog_cmd): Swap cygwin root selection and local dir
5958 * root.cc (dialog_cmd): Ditto.
5959 * source.cc (dialog_cmd): Ditto.
5961 2001-11-01 Robert Collins <rbtcollins@hotmail.com>
5963 * choose.cc(list_vscroll): Return 0 as required by win32.
5964 (list_hscroll): Ditto.
5965 (list_click): Ditto.
5967 2001-11-01 Robert Collins <rbtcollins@hotmail.com>
5971 * main.cc(WinMain): Use __argv to retrieve command line parameters.
5972 * Makefile,in: Remove argv.o.
5974 2001-11-01 Matt Hargett <matt@use.net>
5976 * geturl.cc (progress): Change int to unsigned int to eliminate
5978 * (get_url_to_string): Check for NULL pointer.
5979 * mount.cc (find2): Use free instead of delete for malloc'd
5981 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.
5983 2001-10-31 Robert Collins <rbtcollins@hotmail.com>
5985 * choose.cc(_view::insert_under): Handle linen > nlines and lines[linen]
5986 with neither a package nor a category. The lines[linen] bug was reported
5987 by Matt (matt@usa.net).
5988 (read_installed_db): Bugfix for testing whether a package has a source
5989 tarball. Reported by Matt (matt@usa.net).
5990 * geturl.cc(dialog): Rename gw_dialog to local_gw_dialog to avoid
5991 programmer confusion and lint errors. Reported by Matt (matt@usa.net).
5993 2001-10-31 Robert Collins <rbtcollins@hotmail.com>
5995 * argv.cc: New file, converts arguments for -mwindows
5996 programs. (Simplified derivation from dcrt0.cc.)
5998 * Makefile,in: Add argv.o and mingw_getopt.o to setup.exe object list.
5999 Add mingw_getopt.o build rule.
6000 * main.cc(WinMain): Initialise argv and argc for use by getopt.
6002 2001-10-27 Christopher Faylor <cgf@redhat.com>
6004 * res.rc: Rearrange info on top line slightly.
6006 2001-10-27 Christopher Faylor <cgf@redhat.com>
6008 * desktop.cc (make_passwd_group): Move file creation earlier in the
6009 process to ensure that passwd-grp.bat reflects desired operation.
6011 2001-27-10 Trevor Forbes <t4bs@hotmail.com>
6013 * postinstall.cc (each): Remove "*.done" file else rename will fail.
6015 2001-10-16 Christopher Faylor <cgf@redhat.com>
6017 * res.rc: Oops. Take 640x480 screen size into account.
6019 2001-10-16 Christopher Faylor <cgf@redhat.com>
6021 * res.rc: Enlarge chooser screen.
6023 2001-10-12 Christopher Faylor <cgf@redhat.com>
6025 * Makefile.in: Accomodate changes to w32api_include macro.
6027 2001-10-12 Christopher Faylor <cgf@redhat.com>
6029 * Makefile.in: Use correct flags for windres.
6031 2001-10-12 Christopher Faylor <cgf@redhat.com>
6033 * Makefile.in (CFLAGS): Remove -nostdinc from CFLAGS.
6035 2001-10-12 Christopher Faylor <cgf@redhat.com>
6037 * choose.cc (pick_line::paint): Reorganize after botched patch.
6039 2001-10-12 Christopher Faylor <cgf@redhat.com>
6041 * choose.cc (pick_line::paint): Add missing declaration.
6043 2001-10-10 Ralf Habacker <Ralf.Habacker@freenet.de>
6045 * choose.cc (pick_line::paint): Add package name to sdesc for display.
6047 Wed Sep 26 21:39:00 Robert Collins rbtcollins@hotmail.com
6049 * choose.cc (_view::insert_pkg): Correctly exit loop.
6050 * iniparse.y (register_category): Always insert new categories.
6052 Fri Sep 21 13:56:32 2001 Christopher Faylor <cgf@cygnus.com>
6054 * inilex.l (yylex): For comments, eat all characters up to, but not
6057 Sun Aug 26 12:50:01 2001 John Marshall <jmarshall@acm.org>
6059 * fromcwd.cc (found_file): Use correct package name when adding an
6060 unknown package rather than random stack garbage.
6062 Sun Aug 12 14:25:21 2001 Christopher Faylor <cgf@cygnus.com>
6064 * desktop.cc (make_passwd_group): .bat files need \r\n endings.
6066 Wed Aug 8 13:53:47 2001 Christopher Faylor <cgf@cygnus.com>
6068 * desktop.cc (etc_profile): Leave environment variables untouched.
6070 2001-08-07 Corinna Vinschen <corinna@vinschen.de>
6072 * autoload.c: Add dynamic load statements for NT/W2K
6073 advapi32 functions not available in 9x/ME.
6074 * main.cc (set_default_dacl): New function.
6075 (WinMain): Call `set_default_dacl' if running on NT/W2K.
6077 Sat Aug 4 21:35:53 2001 Christopher Faylor <cgf@cygnus.com>
6079 * ini.h (_CategoryPackage): Change pkg field to pkgname for
6081 * choose.cc: Use pkgname field when referencing _CategoryPackage
6083 (fill_missing_category): Don't add excluded packages.
6084 (default_trust): Ditto.
6085 (_view::insert_pkg): Ditto.
6086 * iniparse.y (register_category): Use consistent variable name.
6088 2001-07-09 Egor Duda <deo@logos-m.ru>
6090 * choose.cc: Use system foreground color for text output.
6092 Sat Jul 7 00:40:28 2001 Christopher Faylor <cgf@cygnus.com>
6094 * choose.cc (set_action): Use default trust for determining reinstall
6096 (default_trust): Set default trust.
6097 (pick_line::paint): Allow source selection when reinstalling or
6100 Fri Jul 6 18:08:49 2001 Christopher Faylor <cgf@cygnus.com>
6102 * choose.cc (isinstalled): Modify to properly accomodate special case
6104 (set_action): Check downloaded components, not installed components if
6106 (set_existence): Always include full list of files when "download
6109 Fri Jul 6 00:37:05 2001 Christopher Faylor <cgf@cygnus.com>
6111 * choose.cc (pick_line::paint): Properly display "na" field when no
6114 Thu Jul 5 00:34:23 2001 Christopher Faylor <cgf@cygnus.com>
6116 * choose.cc (scan2): Ensure that older versions do not show up in
6119 Mon Jul 2 15:47:59 2001 Christopher Faylor <cgf@cygnus.com>
6121 * choose.cc (set_action): Allow "Skip" action if trust != installed.
6122 * res.rc: Fix copyright.
6124 Sat Jun 30 14:05:21 2001 Michael A Chase <mchase@ix.netcom.com>
6126 * res.rc (IDD_LOCAL_DIR): Change caption to match the other dialog
6128 (IDD_CHOOSE): Adjust horizontal size so package names are visible.
6130 * choose.cc: Restore some more changes from 2001-06-25, throughout.
6131 (paint): Wrap some excessively long lines.
6132 (pick_line::paint): Ditto. Move the arrow in the "Current" column
6133 right to where it belongs. Move the source checkbox slightly to the
6135 (do_choose): List categories and required packages in setup.log.full.
6137 Sat Jun 30 23:04:59 2001 Christopher Faylor <cgf@cygnus.com>
6139 * choose.cc (scan2): Restore source scanning eliminated by previous
6142 Sat Jun 30 15:18:33 2001 Christopher Faylor <cgf@cygnus.com>
6144 * ini.h (struct _Info): Add "derived" element.
6145 * choose.cc (scan2): Try to place unknown tar files into proper slot
6146 when package exists in setup.ini but tar file does not.
6148 Sat Jun 30 13:39:00 2001 Robert Collins <rbtcollins@hotmail.com>
6150 * choose.cc (create_listview): Call set_view_mode with VIEW_CATEGORY.
6151 (do_choose): Log the first category name.
6153 Fri Jun 29 23:07:44 2001 Christopher Faylor <cgf@cygnus.com>
6155 *ini.h: Reapply 2001-06-25 changes.
6156 * choose.cc (add_required): Ditto. Default to "Keep" state if
6157 UNINSTALL and product is installed. Default to curr state if SKIP,
6159 (keep_or_skip): New function. Returns skip or keep state depending on
6160 installed state of package.
6161 (default_trust): Use keep_or_skip to set state.
6162 (_view::insert_pkg): Use calloc to allocate lines.
6163 (set_view_mode): Adapt 2001-06-25 change to set_full_list here.
6165 Sat Jun 30 11:01:00 2001 Robert Collins <rbtcollins@hotmail.com>
6167 * choose.cc: Remove globals full_list, headers, package_indexes and
6169 Add globals cat_headers, pkg_headers and chooser.
6170 (add_required): New function.
6171 (paint): Use the chooser for header details.
6172 Call into the chooser to paint each line.
6173 (list_click): Use new global variables.
6174 Call into the chooser to handle the click.
6175 Repaint the entire view if packages have been added or removed.
6176 (note_width): Get passed a headers struct rather than using a global
6178 (fill_missing_category): New function.
6179 (default_trust): Skip non-"Required" or "Misc" packages.
6180 (pick_line::set_line (Package *)): New function.
6181 (pick_line::set_line (Category *)): New function.
6182 (pick_line::paint): New function.
6183 (pick_line::click): New function.
6184 (_view::_view): New function.
6185 (_view::set_view_mode): New function.
6186 (_view::mode_caption): New function.
6187 (_view::set_headers): New function.
6188 (_view::init_header): New function.
6189 (_view::insert_pkg): New function.
6190 (_view::insert_category): New function.
6191 (_view::insert_at): New function.
6192 (_view::insert_under): New function.
6193 (_view::clear_view): New function.
6194 (viewsplusplus): New function.
6195 (_view::client): New function.
6196 (set_view_mode): Use new chooser functionality.
6197 (set_full_list): Use new global variables.
6198 (create_listview): Instantiate chooser.
6199 Remove all hardcoded headers[] code.
6200 (dialog_cmd): On trust changes, check dependencies.
6201 (getcategorybyname): New function.
6202 (getpackagecategorybyname): New function.
6203 (scan2): Use case-insensitive package comparison.
6204 (do_choose): Use fill_missing_category ().
6205 Show some category data.
6206 * ini.h: Protect against multiple inclusion.
6208 (_CategoryPackage): New struct.
6209 (_Category): New struct.
6210 (_Package): Change category to Category * from char *.
6211 (extern Category category): New global variable.
6212 (extern in ncategories): Ditto.
6213 (getcategorybyname): New prototype.
6214 (catpackagecategorybyname): New prototype.
6215 (register_category): New prototype.
6216 (add_category): New prototype.
6217 * iniparse.y: Parse multiple categories per package.
6218 (category): New global variable.
6219 (ncategories): New global variable.
6220 (new_package): Compare package against NULL, not 0.
6221 (new_requirement): Source formatting fix.
6222 (register_category): New function.
6223 (add_category): New function.
6224 * res.rc: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
6225 IDC_CHOOSE_VIEWCAPTION: New control.
6226 * resource.h: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
6227 IDC_CHOOSE_VIEWCAPTION: New control.
6228 Increment _APS_NEXT_CONTROL_VALUE.
6230 Mon Jun 25 00:56:37 2001 Michael A Chase <mchase@ix.netcom.com>
6232 * choose.cc (paint): Wrap excessively long lines.
6233 (list_click): Ditto.
6234 (create_listview): Ditto.
6235 (do_choose): Ditto. Replace TABs and remove CRs in lines written to
6236 setup.log.full. Allow "Yes" for source exists in setup.log.full when
6237 installing from local directories.
6239 Mon Jun 25 00:56:37 2001 Christopher Faylor <cgf@cygnus.com>
6241 * choose.cc (set_action): Only clear srcpicked when moving to next
6242 state. Allow source installation if it exists in the current "trust"
6243 state. Don't move to skip state when package is installed.
6244 (list_click): Don't allow source clicking when no source is available.
6245 (set_full_list): Display package when not is_full_action.
6246 * ini.h (is_full_action): Define.
6248 Sun Jun 17 12:06:14 2001 Christopher Faylor <cgf@cygnus.com>
6250 * install.cc (check_for_old_cygwin): New function. First stab at
6251 checking for old cygwin versions.
6252 (do_install): Call check_for_old_cygwin if there were no errors during
6255 Sat Jun 16 11:33:51 2001 Michael A Chase <mchase@ix.netcom.com>
6257 * choose.cc (_Info::_Info): Test _source paramenter for non-NULL rather
6258 than zeroed "source" element.
6260 Fri Jun 15 20:54:43 2001 Christopher Faylor <cgf@cygnus.com>
6262 * choose.cc (scan2): Insert unknown tar archives, found on disk, into
6263 the highest available "hole" in the trust array.
6265 Fri Jun 15 00:20:48 2001 Christopher Faylor <cgf@cygnus.com>
6267 * choose.cc (set_existence): Use pointer method for indexing in trust
6269 (create_listview): Ditto.
6270 (scan2): Ditto. Also, use consistent variable name for indexing into
6272 * ini.h (Package): Reorganize info array for easier scanning.
6274 Fri Jun 15 00:01:51 2001 Christopher Faylor <cgf@cygnus.com>
6276 * choose.cc (isinstalled): Eliminate special download only test.
6277 (set_action): Don't move to next state if in ACTION_SAME range and not
6279 (choose_caption): Display "Retrieve" rather than "Reinstall" when just
6281 (do_choose): Sort packages after all packages have been read.
6282 Accomodate the fact that first element in trust array is empty so that
6283 log files don't report the wrong trust value.
6284 * iniparse.y (new_package): Malloc space for package name or suffer
6287 Thu Jun 14 22:43:59 2001 Robert Collins <rbtcollins@hotmail.com>
6289 * ini.h (Dependency): New structure. Declare new function.
6290 * inilex.l (yylex): Detect new setup.ini options - category and
6292 * iniparse.y: Declare new setup.ini token values.
6293 (yyparse): Parse new token values.
6294 (new_requirement): New function.
6296 Thu Jun 14 22:43:26 2001 Christopher Faylor <cgf@cygnus.com>
6298 * choose.cc (read_installed_db): Eliminate obsolete code.
6300 Thu Jun 14 22:11:53 2001 Christopher Faylor <cgf@cygnus.com>
6302 * choose.cc (set_action): Set trust on "redo".
6303 (_Info::_Info): New constructor.
6304 (read_installed_db): Use new constructor. Use trusts type for
6306 * ini.h (struct _Info): Label struct, add constructor.
6307 (Package): Make installed_ix a type 'trusts.'
6308 * install.cc (uninstall_one): Unset any installed info for current
6310 (install_one): Allocate new Info struct for installed reflecting new
6312 (do_install): Don't output line to installed.db if package is being
6315 Thu Jun 14 20:33:01 2001 Robert Collins <rbtcollins@hotmail.com>
6317 * choose.cc (getpkgbyname): Use consistent method for scanning package
6320 Wed Jun 13 23:33:08 2001 Christopher Faylor <cgf@cygnus.com>
6322 * choose.cc: Add some comments.
6323 (getpkgbyname): Use strcasecmp for comparisons.
6325 Wed Jun 13 16:07:00 2001 Christopher Faylor <cgf@cygnus.com>
6327 * install.cc (do_install): Avoid checking for download action if
6328 package wasn't currently retrieved.
6330 Wed Jun 13 11:27:22 2001 Christopher Faylor <cgf@cygnus.com>
6332 * choose.cc: Eliminate extra array throughout. Use element in package
6333 structure instead. Use pointers rather than array indexes where
6335 (set_action): New function to set next action based on current.
6336 (choose_caption): New function. Returns display caption.
6337 (check_existence): Change arguments. Use pointer to 'info' structure.
6338 (set_existence): Use pointer rather than array index.
6339 (default_trust): Use trusts enum for second argument.
6340 (set_full_list): Honor exclude element in package structure.
6341 (build_labels): Eliminate.
6342 (base): Make global. Use const char * argument.
6343 (get_package_version): Eliminate.
6344 (getpkgbyname): New function.
6345 (read_installed_db): Use parse_filename to get version info.
6346 * desktop.cc (make_passwd_group): Use getpkgbyname function.
6347 * download.cc (get_file_size): const argument.
6348 (do_download): Use is_download_action to determine when something
6349 should be downloaded.
6350 * filemanip.h: Add some functions.
6351 * ini.cc (do_ini): Use NULL rather than 0 for pointer assignment.
6352 * ini.h: Use enums for actions and trusts.
6353 (is_download_action): New macro.
6354 (is_upgrade_action): Ditto.
6355 (is_uninstall_action): Ditto.
6356 (struct Package): Add new fields.
6357 * inilex.l (yylex): Detect new setup.ini options.
6358 * iniparse.y: Declare new tokens.
6359 (yyparse): Detect exclude keyword. Fill out version field even if
6361 (new_package): Use greater granularity when allocating package array to
6362 avoid repeated calls to realloc.
6363 * install.cc (exists): const argument.
6364 (uninstall_one): Take pkg argument.
6365 (install_one): Ditto. Eliminate unneeded arguments which can be
6366 derived from package info.
6367 (do_install): Iterate over package array using a pointer. Use
6368 is_download_action to control when package should be downloaded.
6369 * tar.cc (tar_open): const argument.
6370 * tar.h: Refloect const argument.
6372 2001-05-31 Michael Chase mchase@ix.netcom.com
6374 * main.cc (WinMain): Add setup version to starting setup.log entry
6376 Tue May 29 21:37:58 2001 Yukihiko Sohda <sohda@is.titech.ac.jp>
6378 * inilex.l: Add + to list of valid string characters.
6380 Mon May 28 20:54:50 2001 Christopher Faylor <cgf@cygnus.com>
6382 * Makefile.in: Remove more stuff in the clean target.
6384 Mon May 28 18:24:59 2001 Christopher Faylor <cgf@cygnus.com>
6386 * Makefile.in: Correctly generate iniparse.h.
6388 Tue Mar 6 19:14:00 2001 Corinna Vinschen <corinna@vinschen.de>
6390 * geturl.cc (get_url_to_file): Add parameter `allow_ftp_auth'.
6391 * geturl.h: Change declaration of `get_url_to_file' accordingly.
6392 * netio.cc (NetIO::NetIO): Add parameter `allow_ftp_auth'.
6393 Set member `ftp_auth'.
6394 (NetIO::open): Add parameter `allow_ftp_auth'. Use it in calls
6395 to constructors of derived classes.
6396 (NetIO::get_ftp_auth): New method.
6397 * netio.h: Change class definition accordingly.
6398 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Add parameter `allow_ftp_auth'.
6399 Take global variables `net_ftp_user' and `net_ftp_passwd' into account.
6400 Add code for ftp authentication retry.
6401 * nio-ftp.h: Change class definition accordingly.
6402 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Add parameter `allow_ftp_auth'.
6403 Add code for ftp authentication retry in case of proxy connection.
6404 * nio-http.h: Change class definition accordingly.
6405 * res.rc: Add FTP authentication dialog.
6406 * resource.h: Add new constants used in res.rc.
6407 * state.h: Add variables `net_ftp_user' and `net_ftp_passwd'.
6409 Sun May 27 17:12:23 2001 Christopher Faylor <cgf@cygnus.com>
6411 * res.rc (IDD_SPLASH): Add a copyright year.
6413 Sun May 27 15:42:18 2001 Christopher Faylor <cgf@cygnus.com>
6415 * Makefile.in: Make iniparse.y produce a c++ file.
6416 * choose.cc (set_existence): Revert 2001-05-27 change.
6417 * ini.cc: Remove "C" from declaration of yyparse.
6418 * iniparse.y (yyparse): Fill out version field by default when a binary
6419 install is detected and no version has been set yet.
6420 * install.cc (do_install): Mount things earlier so that we can use
6421 proper mount table settings. Don't remove mounts since they are now
6423 * mount.cc (create_mount): Reread the mount table after establishing a
6425 (read_mounts): Explicitly clear root_here to allow multiple uses of
6426 this function. Ensure that there is no garbage in the table when we've
6427 exhausted all of the mounts in the registry.
6428 (cygpath): Accomodate ./ in path.
6430 Sun May 27 02:59:07 2001 Christopher Faylor <cgf@cygnus.com>
6432 Use parse_filename method to parse filenames throughout. Use
6433 get_root_dir to retrieve the current root directory throughout. Set
6434 const in argument list, where appropriate, throughout.
6435 * choose.cc (set_existence): Detect case of uninstalled package with no
6437 (parse_filename): New function.
6438 * filemanip.h (fileparse): New structure.
6439 * mount.cc (read_mounts): Remember where we found the root mount.
6440 (set_root_dir): New function.
6441 (get_root_dir): Ditto.
6442 * mount.h: Declare new functions.
6443 * site.cc (get_root_dir_now): Renamed from get_root_dir.
6444 (save_site_url): Use new function name.
6445 (get_initial_list_idx): Ditto.
6447 Sat May 26 21:23:59 2001 Christopher Faylor <cgf@cygnus.com>
6449 * choose.cc: Use a constant throughout to deal with chooser icon
6451 * res.rc (IDD_CHOOSE): Increase size of chooser box.
6453 2001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
6455 * choose.cc (do_choose): Fix incorrect assignment of trust setting to
6456 use when Redownload or Sources Only selected.
6458 Thu May 10 22:35:59 2001 Christopher Faylor <cgf@cygnus.com>
6460 Reformat file after botched patch formatting.
6461 * choose.cc (which_trust): Eliminate variable.
6462 (default_trust): Don't set which_trust.
6463 (do_choose): Use selected trust when reinstalling or installing source.
6465 Thu May 10 21:04:18 2001 Christopher Faylor <cgf@cygnus.com>
6467 Change concat to cygpath throughout.
6468 Change map_filename to cygpath throughout.
6469 * concat.cc (vconcat): New function.
6470 (concat): Use vconcat.
6471 * concat.h: Reflect above.
6472 * install.cc (map_filename): Eliminate.
6473 (install_one): Free dest_file.
6474 * mount.cc (find2): Expect input key to be pointing to mount record.
6475 (in_table): New function.
6476 (is_admin): Move from root.cc.
6477 (read_mounts): New function.
6478 (path_prefix_p): New function.
6479 (cygpath): New function.
6480 * mount.h: Define new functions and structure.
6481 * root.cc (in_table): Move to mount.cc.
6482 (do_root): Call read_mounts to initialize root stuff and mount table.
6483 * site.cc (get_root_dir): Ditto.
6485 2001-05-09 Matt Hargett <matt@use.net>
6487 * Makefile.in: Remove *.rc from clean.
6489 Tue May 8 23:33:38 2001 Christopher Faylor <cgf@cygnus.com>
6491 * choose.cc (scan2): Fix incorrect setting of TRUST_CURR rather than
6492 TRUST_PREV which produced "0" versions.
6494 2001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
6496 * resource.h: Add new field IDC_CHOOSE_INST_TEXT. Modify
6497 _APS_NEXT_CONTROL_VALUE to account for addition of
6498 IDC_CHOOSE_INST_TEXT.
6499 * res.rc (IDD_CHOOSE): Modify choose dialog to use new field
6500 IDC_CHOOSE_INST_TEXT for screen text. Modify choose Dialog to allow
6501 hot keys to select Prev, Curr, Exp.
6502 * ini.h: Add new actions for ACTION_REDO and ACTION_SRC_ONLY. Modify
6503 define for LOOP_PACKAGES to include new actions ACTION_REDO and
6505 * choose.cc: Add new Trusts for TRUST_REDO and TRUST_SRC_ONLY.
6506 (paint): Modify to check TRUST_SRC_ONLY when determining Bitmap for
6507 source Checkbox to use.
6508 (build_labels): Add logic to allow for selection of Source only
6509 Download/ReDownload/Install/Reinstall and also to Redownload/Reinstall
6510 current version binary.
6511 (dialog_proc): Add conditional display for file selection prompt based
6512 on download vs install using IDC_CHOOSE_INST_TEXT.
6513 (do_choose): Add new logic for TRUST_REDO and TRUST_SRC_ONLY selection
6514 and modify logic for TRUST_UNINSTALL, TRUST_KEEP, and TRUST_NONE to
6515 handle the instance where Source Download/Install was selected. Modify
6516 log file to store appropriate information regarding Action selected and
6517 the new actions that were added (I.E.: ACTION_REDO and
6519 * download.cc: Add include for <unistd.h> and "port.h".
6520 (download_one): Modify parameter list to include the selected action
6521 for the file to be downloaded. Modify size check against expected size
6522 to include check for ACTION_REDO and ACTION_SRC_ONLY. Modify rename of
6523 .tmp file to also remove the destination file if exists due to ability
6524 to redownload source and binary now.
6525 (do_download): Modify to also use ACTION_REDO and ACTION_SRC_ONLY in
6526 calculation of Download Bytes. Modify to also use ACTION_REDO and
6527 ACTION_SRC_ONLY in determining files selected for download.
6528 * install.cc (uninstall_one): Add check to treat a Reinstall like an
6529 upgrade so current version will be uninstalled prior to reinstall.
6530 (do_install): Add logic to handle ACTION_REDO and ACTION_SRC_ONLY for
6531 uninstalling and installing binary and source packages.
6532 * desktop.cc (make_passwd_group): Modify logic to account for a Source
6533 only cygwin install when checking for cygwin to determine need for
6534 mkpasswd and mkgroup.
6536 Mon May 7 23:33:30 2001 Matt Hargett <matt@use.net>
6538 * winsup/cinstall/res.rc: Added accelerators and improved focus order.
6539 Removed WS_DISABLED from "OK" buttons to accomodate default focus
6540 changes in net.cc and source.cc.
6541 * winsup/cinstall/net.cc (dialog_proc): If no radio button is selected,
6542 a default is selected.
6543 * winsup/cinstall/source.cc (dialog_proc): Ditto.
6544 (check_if_enable_next): Removed. No longer needed since a radio button
6545 will always be selected.
6546 (load_dialog): Removed call to check_if_enable_next.
6547 (dialog_cmd): Ditto. Also added default to switch.
6549 Tue Apr 24 23:42:02 2001 Christopher Faylor <cgf@cygnus.com>
6551 * res.rc: Resize affected text.
6553 Tue Apr 24 23:35:31 2001 Christopher Faylor <cgf@cygnus.com>
6555 * net.cc (do_net): Default to direct download.
6556 * res.rc: Move default selections to the top.
6558 2001-04-18 Earnie Boyd <earnie@users.sourceforge.net>
6560 * win32.h: Remove the definitions for _UNION_NAME and _STRUCT_NAME.
6561 Must now include <windows.h> and not the pieces.
6562 * choose.cc (create_listview): Clean up type mismatch problems.
6563 * dialog.h (NEXT(id)): Ditto.
6564 * geturl.cc (dialog): Ditto.
6565 * install.cc (dialog): Ditto.
6566 * splash.cc (load_dialog): Ditto.
6568 Wed Apr 18 18:59:21 2001 Christopher Faylor <cgf@cygnus.com>
6570 * tar.cc (class gzbz): Define dummy virtual functions.
6572 Wed Apr 18 16:01:21 2001 Christopher Faylor <cgf@cygnus.com>
6574 * Makefile.in: Add bz2 include/library support.
6575 * filemanip.h: New file.
6576 * choose.cc (find_tar_ext): New function. Returns TRUE if .tar.gz or
6578 (scan2): Reorganize to use find_tar_ext, accomodating .bz2 extension.
6579 (read_installed_db): Ditto.
6581 * fromcwd.cc (found_file): Ditto.
6582 (do_fromcwd): Ditto.
6583 * tar.cc (class gzbz): New super class for uncompression support.
6584 (gz): New class for gzip support.
6585 (bz): New class for bzip2 support.
6586 (tar_open): Use gzbz class to control file opening.
6587 (tar_ftell): Ditto for returning position in file.
6588 (skip_file): Ditto for reading file.
6589 (tar_next_file): Ditto.
6590 (tar_read_file): Ditto.
6591 (tar_close): Ditto for close.
6593 * zlib/configure.in: Force NM substitution.
6595 * source.cc (do_source): Default to "Install from Internet".
6597 2001-03-16 Brian Keener <bkeener@thesoftwaresource.com>
6599 * nio-file.cc (NetIO_File::NetIO_File): Use `get_file_size' instead of
6601 * choose.cc (list_click): Correct inability to select source code for
6603 (scan2): Modify to skip source tarballs when scanning disk for
6604 installable packages.
6606 2001-03-10 Chris Abbey <chris_abbey@yahoo.com>
6608 * install.cc: install sources into /usr/src instead
6609 of /, also include the sizes of source tarballs
6611 * download.cc: include sizes of source tarballs in
6612 total_download_bytes.
6614 Tue Mar 6 19:31:00 2000 Corinna Vinschen <corinna@vinschen.com>
6616 * download.cc (get_file_size): Remove `static'.
6618 Tue Mar 6 19:11:00 2000 Corinna Vinschen <corinna@vinschen.com>
6620 * tar.cc (tar_open): Use `get_file_size' instead of `stat'.
6622 2001-03-06 Brian Keener <bkeener@thesoftwaresource.com>
6624 * choose.cc (paint): Modify message for nothing to download vs
6625 nothing to install/update based on installation method.
6626 (list_click): Modify to skip versions in selection process if
6627 installing from local directory and installation file does not exist.
6628 Also leaves Source Action set to N/A if the source file does not exist
6629 and installing from local directory.
6630 (check_existence): New method to check current existence of installation
6631 files based on selected installation method.
6632 (set_existence): New method to set the current existence of installation
6633 files based on selected installation method.
6634 (best_trust): Modify decision process for best trust to base decision on
6635 current trust selected (IE: Prev, Curr, or Test), existence of file and
6636 installation method selected.
6637 (default_trust): Add logic to capture the current trust level and the
6638 trust selected for the given package.
6639 (set_full_list): Expand decision criteria for displaying a package in
6640 the selection list to include file existence/non-existence and selected
6641 installation method.
6642 (build_labels): Modify criteria for label addition to include
6643 installation method and file existence/non-existence.
6644 (create_listview): Modify to establish package trust level for each
6645 package before setting up the display list. Also modification to set
6646 current trust button as the default.
6647 (dialog_cmd): Set response for Prev, Curr, Test button push to perform
6648 a reset of the selection list in addition to setting the default trust.
6649 (get_package_version): New method to provide reusable code for
6650 determining the package version from the file name for a specified
6652 (scan2): Modify to use new method get_package_version and
6653 also enhance handling of the build for the structures package and
6655 (read_installed_db): Modify to use the new method
6656 get_package_version and also enhance handling of the build for the
6657 structures package and extra.
6658 (do_choose): Add additional initialization of package and extra
6659 structures. Modify to use read_installed_db all the time despite
6660 install method. Modify output to setup.log.full log file to increase
6661 readability by adding additional spacing, expanded code and available
6663 * ini.h: Add new fields install_exists, source_exists and
6664 partial_list_display to the structure definition for package.
6665 * res.rc (IDD_CHOOSE): Modify choose dialog Prev, Curr, and Test
6666 pushbuttons by replacing with Radio Buttons thus allowing the
6667 operator to better determine which is selected.
6669 2001-02-20 Brian Keener <bkeener@thesoftwaresource.com>
6671 * download.cc (do_download): Add new variables total_download_bytes and
6672 total_download_bytes_sofar for download progress meter. Add loop
6673 to accumulate the total bytes to download from the selected packages.
6674 * geturl.cc: Add state.h and diskfull.h to include list. Add new
6675 variables gw_iprogress, gw_pprogress, gw_progress_text,
6676 gw_pprogress_text, and gw_iprogress_text to allow for addition of
6677 total packages download progress meter and disk full percent
6678 progress meter. Add variables total_download_bytes and
6679 total_download_bytes_sofar for use by progress meters.
6680 (dialog_proc): Add new variables gw_iprogress, gw_pprogress,
6681 gw_progress_text, gw_pprogress_text, and gw_iprogress_text to
6682 allow for addition of total packages download progress meter and disk
6683 full percent progress meter.
6684 (init_dialog): Ditto.
6686 (get_url_to_file): Ditto.
6687 * geturl.h: Add external definition for total_download_bytes and
6688 total_download_bytes_sofar.
6689 * res.rc: Add two additional progress meters (IDC_DLS_IPROGRESS)
6690 and (IDC_DLS_PPROGRESS) and three text objects (IDC_DLS_PROGRESS_TEXT)
6691 and (IDC_DLS_IPROGRESS_TEXT, IDC_DLS_PPROGRESS_TEXT) for use in the
6693 * resource.h: Add new fields for progress meters and text and update
6694 _APS_NEXT_CONTROL_VALUE.
6696 Wed Feb 21 13:05:00 2000 Corinna Vinschen <vinschen@redhat.com>
6698 * download.cc (get_file_size): Check for INVALID_HANDLE_VALUE instead
6701 Wed Feb 21 11:21:00 2000 Corinna Vinschen <vinschen@redhat.com>
6703 * download.cc (download_one): Add missing parenthesis.
6705 Mon Feb 19 18:59:00 2000 Corinna Vinschen <vinschen@redhat.com>
6707 * download.cc (get_file_size): New function. Eliminates the need
6709 (download_one): Call `get_file_size' instead of `stat'. This
6710 workarounds a problem with mingw's `stat' call.
6712 2001-02-07 Earnie Boyd <earnie@users.sourceforge.net>
6714 * Makefile.in: (%.o: %.rc): Specify --include-dir $(w32api_include).
6715 This is to allow cinstall to build with 2.95.2-7 and to make the
6716 use of headers consistent.
6718 2000-12-26 Earnie Boyd <earnie_boyd@yahoo.com>
6720 * Makefile.in (autoload.o): Add target to specify -fno-inline-functions
6722 Tue Dec 26 03:46:00 2000 Matt Hargett <matt@use.net>
6724 * winsup/cinstall/res.rc: Added accelerators and improved focus
6727 2000-12-10 Egor Duda <deo@logos-m.ru>
6729 * choose.cc (paint): Use system background color for text output.
6731 Sun Dec 10 19:05:25 2000 Christopher Faylor <cgf@cygnus.com>
6733 * Makefile.in: Use CXX for linking and for compiling .cc files.
6734 * configure.in: Find correct c++ compiler.
6735 * configure: Regenerate.
6737 2000-11-17 DJ Delorie <dj@redhat.com>
6739 * splash.cc (load_dialog): Make message more obvious.
6742 Fri Nov 17 17:15:21 2000 Christopher Faylor <cgf@cygnus.com>
6744 * Makefile.in: Use g++ to link so that libstdc++.a gets used. This is
6745 necessary for newer compilers.
6747 Wed Nov 9 2:19:00 2000 Corinna Vinschen <vinschen@redhat.com>
6749 * desktop.cc: Include "ini.h" and "version.h".
6750 (make_passwd_group): Skip the function on 9x/ME boxes when an
6751 older version of Cygwin has been installed which doesn't
6752 support mkpasswd/mkgroup on 9x/ME.
6753 * install.cc: Move the `LOOP_PACKAGES' and `pi' macros to...
6756 Wed Nov 8 17:10:00 2000 Corinna Vinschen <vinschen@redhat.com>
6758 * desktop.cc (make_passwd_group): Don't exit when started
6759 on 9x/ME since mkpasswd/mkgroup are usable on 9x/ME now.
6761 Sun Nov 5 12:51:42 2000 Jason Tishler <jt@dothill.com>
6763 * install.cc (do_install): Add call to set_cygdrive_flags to sync
6765 * mount.cc (set_cygdrive_flags): New function.
6766 (get_cygdrive_flags): Ditto.
6767 (default_cygdrive): Ditto.
6768 (set_cygdrive_flags): Ditto.
6769 * mount.h: Add prototype for set_cygdrive_flags.
6771 2000-10-23 DJ Delorie <dj@redhat.com>
6773 * ini.h: add source actions
6774 * fromcwd.cc: check for available sources
6775 * res.rc: add checkbox bitmaps
6778 * choose.cc: add source column
6779 * download.cc: download sources if called for
6780 * install.cc: [un]install sources too
6782 2000-10-22 DJ Delorie <dj@redhat.com>
6784 * choose.cc (build_labels): Don't skip TRUST_PREV completely; only
6785 ignore it wrt full_list if there's already a version installed.
6786 (do_choose): Sort the list.
6787 (package_sort): New.
6789 2000-10-12 DJ Delorie <dj@redhat.com>
6791 * res.rc: Add more error strings.
6792 * resource.h: Ditto.
6793 * iniparse.y (new_package): re-initialize if needed.
6794 * download.cc (do_download): Keep track of errors; notify and
6796 * install.cc (do_install): Ditto.
6798 2000-10-05 DJ Delorie <dj@redhat.com>
6800 * Makefile.in: fix %.cc rule
6802 2000-10-04 DJ Delorie <dj@redhat.com>
6804 * desktop.cc: quote HOME and USER, don't . ./.profile
6806 * choose.cc (build_labels): don't include in partial list just
6807 because there's a *previous* version available.
6809 * install.cc (do_install): if installing from local directory with
6810 setup.ini and the file isn't found, look in "." also. Note errors.
6812 2000-10-02 DJ Delorie <dj@redhat.com>
6814 * ini.cc (do_ini): save setup.ini locally
6816 2000-10-02 Chris Abbey <cabbey@bresnanlink.net>
6818 * desktop.cc: quote escapes in prompt
6820 2000-10-02 Jason Tishler <jt@dothill.com>
6822 * root.cc (is_admin): New function.
6823 (read_mount_table): Check for administrative priviledges and set
6824 installation scope as appropriate.
6826 2000-09-28 DJ Delorie <dj@redhat.com>
6828 * nio-ftp.cc (ftp_line): handle continuations more robustly
6830 2000-09-14 Brian Keener <bkeener@thesoftwaresource.com>
6832 * res.rc: increased the size of the site dialog (IDD_SITE) & the
6833 corresponding list box to provide for more URL's to be listed.
6834 Modified the position of the Back, Next and Cancel buttons to
6835 correspond to the new size of the dialog.
6837 2000-09-13 DJ Delorie <dj@redhat.com>
6839 * install.cc (do_install): update disk fullness once per package
6840 to improve performance
6842 * choose.cc (create_listview): call ReleaseDC
6844 Mon Sep 11 22:40 2000 Harold L Hunt II <harold@compasstechnologies.com>
6846 * mkdir.cc: Create directories when ERROR_FILE_NOT_FOUND is
6847 returned, as it seems Samba 2.0.6+ returns this instead of
6848 ERROR_PATH_NOT_FOUND
6850 Mon Sep 11 19:35:24 2000 Christopher Faylor <cgf@cygnus.com>
6852 * site.cc (get_initial_list_idx): Don't default to saved URL if it
6855 2000-09-07 DJ Delorie <dj@redhat.com>
6857 * splash.cc: use version.h, not local decl
6858 * res.rc: add "old version" message
6861 * fromcwd.cc (canonicalize_version): make global
6862 * iniparse.y: add setup-version support, fix bug in blank line
6865 * inilex.l: add [exp] as alias for [test], add setup-version
6866 * Makefile.in (version.c): add setup-version tag
6868 * desktop.cc (do_desktop): remove 1.1 version number
6869 (do_desktop_setup): ditto
6871 * ini.cc (do_ini): zero out package list just in case we redo it.
6873 2000-09-07 Jeffrey Juliano <juliano@cs.unc.edu>
6875 * choose.cc (list_click): Check for nindexes==0; if so, return.
6877 2000-09-06 Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru>
6879 * localdir.cc: new, local package directory selection dialog; cd
6880 into selected directory
6881 * Makefile.in (OBJS): add localdir.o
6882 * dialog.h: add prototype for do_local_dir
6883 * main.cc (WinMain): initialize local_dir to cwd; add call to
6885 * net.cc (dialog_cmd): make DO_LOCAL_DIR next dialog
6886 * source.cc (dialog_cmd): ditto
6887 * res.rc: add DO_LOCAL_DIR dialog; remove "current directory" from
6888 presented choices in IDD_SOURCE; add IDS_ERR_CHDIR error string
6889 * resource.h: defines for DO_LOCAL_DIR dialog; define IDS_ERR_CHDIR
6890 * root.cc (dialog_cmd): make DO_LOCAL_DIR previous dialog
6891 * state.h: add local_dir variable
6893 2000-09-06 Brian Keener <bkeener@thesoftwaresource.com>
6895 * desktop.cc: added logic to handle to the new dialog and to
6896 default the setting for the new checkboxes based on whether the
6897 desktop icon or start menu link already exist.
6898 (desktop_icon): correction to desktop directories for desktop icon
6899 creation. Additional logic added for Win95 which does not appear
6900 to have Common Directories so if Common selected and null uses
6902 (start_menu): Additional logic added for Win95 which does not
6903 appear to have Common Directories so if Common selected and null
6904 uses normal directory.
6905 (do_desktop_setup): moved the saving of the icon, creation of the
6906 bat file, profile, passwd, Start Menu link and desktop shortcut to
6907 this method from do_desktop. Made the creation of the desktop
6908 icon and start menu link conditional on settings of new dialog
6909 created for desktop.
6910 * install.cc (do_install): changed next from IDD_S_DESKTOP to
6912 * main.cc (WinMain): changed case IDD_S_DESKTOP to IDD_DESKTOP.
6913 * res.rc: added new resource to create a desktop dialog with 2
6914 checkboxes for creating the desktop icon and start menu link.
6915 * resource.h: changed IDD_S_DESKTOP to IDD_DESKTOP and added two
6916 new controls: IDC_ROOT_MENU and IDC_ROOT_DESKTOP for new dialog.
6917 * state.h: added root_menu and root_desktop for use in dialog.
6919 2000-08-29 DJ Delorie <dj@redhat.com>
6921 * choose.cc (scan_downloaded_files): scan for existing files, so
6922 that the user only sees new downloads.
6924 * nio-ie5.cc (NetIO_IE5): pre-check for wininet.dll, enable dial-up
6925 * site.cc (do_site): if we can't download the mirror list, go back
6926 to the net setup box to choose another transport.
6927 * autoload.c: add more functions
6928 * Makefile.in (ALL_DEP_LDLIBS): remove wininet.a
6929 * resource.h: add WININET message
6931 * net.cc (do_net): no longer default to IE5
6932 * simpsock.h (class SimpleSocket): new, simplify socket operations
6933 * simpsock.cc: ditto
6934 * nio-http.h: new, for direct http protocol
6935 * nio-http.cc: ditto
6936 * nio-ftp.h: new, for direct http protocol
6938 * netio.cc (set_url): move initialization here to handle redirections
6939 (open): add direct http/ftp
6940 * netio.h (NetIO::set_url): new
6942 * log.cc (log_save): create directory for log if needed
6944 * hash.cc, hash.h: new
6945 * Makefile: add hash.o
6946 * choose.cc: enable "uninstall" option
6947 * download.cc: invert action test to accomodate uninstalling
6948 * ini.h: add ACTION_UNINSTALL
6949 * install.cc: add uninstall functionality
6950 * res.rc: make install tag changeable
6951 * resource.h: add uninstall resources
6953 * res.rc: update mirror list URL
6955 2000-08-24 DJ Delorie <dj@redhat.com>
6957 * log.cc, log.h: new files
6958 * Makefile.in (OBJS): add log.o
6959 * tar.cc: use exit_setup instead of exit
6960 * dialog.cc (fatal): use exit_setup instead of ExitProcess
6961 * msg.cc (fatal): ditto
6962 * install.cc (dialog_cmd): ditto
6963 * ini.cc (do_ini): ditto
6964 * main.cc (main): add logging
6965 * source.cc (do_source): ditto
6966 * root.cc (do_source): ditto
6967 * site.cc (do_site): ditto
6968 * other.cc (do_other): ditto
6969 * net.cc (do_net): ditto
6970 * choose.cc (do_choose): ditto
6971 * download.cc (do_download): ditto
6972 * install.cc (do_install): ditto
6973 * msg.cc (fatal): ditto
6975 * res.rc: mark password boxes as *being* password boxes.
6977 * fromcwd.cc (canonicalize_version): use multiple buffers so that
6978 multiple calls won't use the same buffer.
6979 * choose.cc (create_listview): don't default to full list if no changes
6980 (base): return computed value, not temporary :-(
6981 (do_choose): don't use installed.db if we're only downloading.
6983 2000-08-23 DJ Delorie <dj@redhat.com>
6985 * nio-ie5.cc (NetIO_IE5): Fix authentication logic
6986 * nio-ie5.h (flush_io): new
6987 * netio.cc (load_dialog): note when we're initializing the dialog
6988 box, and ignore changes to the edit fields then.
6990 2000-08-21 DJ Delorie <dj@redhat.com>
6994 * fromcwd.cc (found_file): don't remember the canonicalized version
6996 * choose.cc (paint): print "nothing to do" message when list is empty.
6997 (build_labels): Use version "0.0" if no version is available.
6998 (create_listview): default to full list if nothing to install/update.
6999 (base): new, returns basename of file
7000 (read_installed_db): compare base names, not full paths
7002 2000-08-11 DJ Delorie <dj@redhat.com>
7004 * choose.cc: add new chooser dialog
7005 * fromcwd.cc: use IDD_CHOOSE
7006 * ini.cc: use IDD_CHOOSE
7007 * main.cc: use IDD_CHOOSE
7008 * ini.h: cosmetic changes
7009 * res.rc: add choose dialog, bitmaps
7010 * choose-spin.bmp: new
7011 * choose-rtarrow.bmp: new
7012 * resource.h: add choose dialog controls
7014 * mount.cc: remove debug statement
7016 2000-08-08 DJ Delorie <dj@redhat.com>
7018 * Makefile.in (version.c): make version checking more robust
7019 * splash.cc (load_dialog): handle case where there's no version
7021 2000-08-07 DJ Delorie <dj@redhat.com>
7023 * (all): add cvsid tags
7024 * Makefile.in: generate version.c from ChangeLog, add splash.o
7026 * res.rc: add splash screen
7028 2000-08-02 DJ Delorie <dj@redhat.com>
7030 * net.cc: remove proxy password code
7031 * res.rc: remove proxy user/pass from net, add auth dialogs
7032 * netio.cc,h: add sys/proxy auth methods
7033 * nio-ie5: use them, check for http status codes
7034 * state.h: add system authorization
7036 * concat.cc (concat): canonicalize x:// to x:/ (exception to ://
7039 2000-08-02 Norman Vine <nhv@yahoo,com>
7041 * msg.cc (mbox): added MB_TOPMOST to MessageBox type flags
7043 2000-08-01 DJ Delorie <dj@redhat.com>
7045 * postinstall.cc (each): don't rename files we ignore
7046 (do_postinstall): set CYGWINROOT to root_dir, chdir there
7048 * desktop.cc: have /etc/profile call ~/.profile and ~/.bashrc
7050 2000-07-31 DJ Delorie <dj@redhat.com>
7052 * desktop.cc: reverse PATH so /usr/bin precedes /bin
7054 2000-07-18 DJ Delorie <dj@redhat.com>
7056 * autoload.c: new, autoload dlls that might not be available.
7057 * Makefile.in (OBJS): add autoload.o
7059 * res.rc: rewrite root options (text/binary, system/user) to be
7062 * site.cc (get_site_list): trim displayed URL, sort by domain
7064 * net.cc (do_net): make IE5 default to checked, for now
7066 * choose.cc (do_choose): sort packages correctly
7067 * ini.cc (do_ini): handle parse errors more gracefully
7069 (fprintf): line buffer output
7070 (do_ini): if we can't load setup.ini, go back to the site list.
7071 * ini.h: add "unknown" trust level
7072 * inilex.l: absorb unknown trust levels and key/value pairs,
7073 add line number logic
7074 * iniparse.y: handle parse errors more gracefully.
7075 * install.cc: skip packages with no valid install entry
7077 2000-07-17 DJ Delorie <dj@cygnus.com>
7079 * coding standards fixups, many files
7080 * mkdir.cc: warn about deletions *before* deleting them
7082 2000-07-17 Jeff Juliano <juliano@cs.unc.edu>
7084 * res.rc (IDD_OTHER_URL): reorder to give default focus to entry
7086 * other.cc (dialog_cmd): save download site URL
7087 * site.cc (get_root_dir): new
7088 (save_mirror_site): new
7089 (dialog_cmd): save download site URL
7090 (get_site_list): make list big enough to add prev site
7091 (get_initial_list_idx): new, read last-used URL from file and
7092 append it to site_list
7093 (do_site): call get_initial_list_idx
7095 * concat.cc (concat): avoid segfault when first parm is null
7097 2000-07-13 DJ Delorie <dj@cygnus.com>
7099 * postinstall.cc: new
7100 * Makefile.in: add postinstall.o
7101 * concat.h: add backslash ()
7103 * desktop.cc (etc_profile): don't do postinstall
7104 (backslash): moved to concat.cc
7106 (make_postinstall_script): run directly
7107 (do_desktop): chain to do_postinstall
7108 * dialog.h: add exit_msg, do_postinstall
7109 * download.cc: use exit_msg
7111 * main.cc: add postinstall, exit_msg
7112 * resource.h: add postinstall
7113 * README: add more to-do items
7115 2000-07-12 DJ Delorie <dj@cygnus.com>
7117 * desktop.cc: add /etc/postinstall/ support
7118 * install.cc: add more "standard" directories
7120 2000-07-11 DJ Delorie <dj@cygnus.com>
7122 * desktop.cc: create /etc/profile
7123 * desktop.cc: fix include syntax
7124 * Makefile.in: add auto-dependencies
7125 * root.cc: support system vs user
7133 * desktop.cc: make sure we use backslashes, not slashes.
7134 * desktop.cc: don't set PATH in cygwin.bat, create /etc/passwd
7135 * geturl.cc: change math for percentage to avoid overflow
7137 * download.cc: post "download complete" message.
7138 * root.cc: pre-fill in defaults if needed, don't start
7139 browse at root_dir unless it's set.
7140 * desktop.cc: quote $PATH in case it has spaces in it
7142 2000-07-10 DJ Delorie <dj@cygnus.com>
7144 * Makefile.in: add desktop.o and mklink2.o
7145 * dialog.h: add do_desktop
7146 * install.cc: create standard directories, call do_desktop
7147 * res.rc: add cygwin.ico as a file also
7148 * desktop.cc: new, do shortcuts, batch files, and icons
7149 * mklink2.c: new, for COM
7150 * README: update to-do list
7152 2000-07-10 DJ Delorie <dj@cygnus.com>
7154 * ini.cc (do_ini): don't worry about timestamps if we're not
7155 actually installing.
7157 2000-07-09 DJ Delorie <dj@cygnus.com>
7159 * Makefile.in: add -I$(srcdir) for ini.h
7161 2000-07-06 DJ Delorie <dj@cygnus.com>
7163 * Replace everything with a new GUI version
7164 * zlib/gzio.c: add gzctell() for progress displays
7166 2000-06-22 DJ Delorie <dj@cygnus.com>
7168 * setup.c (tarx): re-add call to write_pkg()
7170 2000-06-07 DJ Delorie <dj@cygnus.com>
7172 * cygcalls.c: new, call cygwin1.dll functions directly
7173 * cygcalls.h: header for same
7174 * Makefile.in: add cygcalls.[ch], remove mount/cygpath/umount
7175 exes, fix cinstall.rc dependencies.
7176 * path.c: remove unneeded code
7177 * setup.c: use cygcalls instead of xcreate_process.
7178 uncompress embedded files with zlib
7179 add "-d" for "download only"
7181 postpone mount changes until very end
7182 add download progress indicators
7183 pack multi-column listings more
7184 auto-delete temp files
7185 customize banner message according to options
7186 prompt user for text/binary mounts
7187 add warnings about empty setup directory, root installs, etc
7189 2000-05-24 DJ Delorie <dj@cygnus.com>
7191 * tar.c: New file; built-in tar using zlib.
7192 * tar.h: New file; header for same.
7193 * ctar.c: New file; test program for same.
7194 * Makefile.in: add built-in tar, remove tar.exe and gzip.exe
7195 * path.c (pathcat): convert slashes and canonicalize, instead of
7197 * setup.c (tarx): add support for built-in tar
7198 (main): accept unix-style slashes, check root dir for drive letters,
7199 warn about installing in /, make sure cwd is empty for internet
7200 installs, defer mounts to end of install, support built-in tar.
7202 Fri May 19 23:44:37 2000 Christopher Faylor <cgf@cygnus.com>
7204 Fix compiler warnings throughout.
7205 * pkg.c (init_pkgs): Make static 'stuff' global_pkgstuff for use in
7207 * setup.c: Make 'root' global.
7208 (istargz): Return pointer to "stem" of matched .tar.gz file.
7209 (tarx): Special case cygwin-20000301 to == cygwin-1.1.0.tar.gz. Remove
7210 bogus check_for_installed check.
7211 (recurse_dirs): Add preliminary support for .bat file execution.
7212 (create_uninstall): Eliminate unneeded parameter.
7213 (do_start_menu): Ditto.
7215 (get_pkg_stuff): Ditto. Check for currently installed cygwin by
7216 scanning for the version number. Eliminate unneeded argument to
7218 (getdownloadsource): Add 'name' to list of names rather than url.
7219 (main): Eliminate unneeded argument in get_pkg_stuff. Eliminate
7220 unneeded argument in mkmount and do_start_menu.
7222 2000-05-18 DJ Delorie <dj@cygnus.com>
7224 * setup.c (optionprompt): allow multi-column, clean up message
7225 about more options, be more robust about user input.
7226 (getdownloadsource): make the mirror URL a macro.
7227 (main): do mounts after done prompting user.
7229 Tue May 2 00:56:41 2000 Christopher Faylor <cgf@cygnus.com>
7231 * setup.c (cleanup): Inverse order of deletion stands a better chance
7232 of deleting cygpath.exe. Still seems to suffer from occasional races,
7234 (cleanup_on_signal): Perform convoluted dance to accomodate win95 and
7236 (output_file): Defend against an unlikely handle leak.
7237 (main): Don't set up signal handling until we have something special to
7240 Mon May 1 17:56:32 2000 Christopher Faylor <cgf@cygnus.com>
7242 * path.c (kill_cygpath): Delete function.
7243 (exit_cygpath): Make more defensive so that it can be called at any
7245 (cygpath_pipe): Don't set up signal here. Do it in main().
7246 * setup.c (istargz): New function.
7247 (recurse_dirs): Look for *.gz pattern rather than *tar.gz since *tar.gz
7248 inexplicably fails on samba mounted partitions. Use istargz to match
7250 (processdirlisting) Use istargz to match tar.gz tail.
7251 (cleanup): Renamed from filedel.
7252 (cleanup_on_signal): New function. Called on CTRL-C.
7253 (main): Record handle of main thread so that it can be suspended when
7254 CTRL-C occurs. Set up cleanup_on_signal signal handler.
7256 Mon May 1 11:05:07 2000 Christopher Faylor <cgf@cygnus.com>
7258 * setup.c (do_start_menu): Don't concatenate paths to already built
7261 Sun Apr 30 22:37:34 2000 Christopher Faylor <cgf@cygnus.com>
7263 * path.c (exit_cygpath): Wait for subprocess to exit before returning.
7264 (cygpath_pipe): Don't call exit_cygpath. Let main atexit routine do
7266 * pkg.c (init_pkgs): Accept root argument. Make registry key "cygwin
7268 * setup.c (filedel): Call exit_cygpath here so that we can be assured
7269 that cygpath subprocess has died. This allows us to delete cygpath.exe
7271 (optionprompt): Initialize response to -1 so that second screen of
7272 mirrors will appear.
7273 (get_pkg_stuff): Don't attempt to use HKCLU. Pass root to init_pkgs.
7274 * setup.h: Reflect init_pkgs prototype change.
7276 Sat Apr 29 23:53:30 2000 Christopher Faylor <cgf@cygnus.com>
7278 * pkg.c (init_pkgs): Accept an argument to control what root registry
7280 * setup.c (get_pkg_stuff): Use HKCLU registry key if default fails.
7281 * setup.h: Reflect init_pkgs prototype change.
7283 Sat Apr 29 23:27:14 2000 Christopher Faylor <cgf@cygnus.com>
7285 * error.c (winerror): Respond to gcc warning.
7286 * path.c (cygpath_pipe): Ditto.
7287 * setup.c (filedel): Call sa_cleanup on deleteme.
7288 (create_shortcut): Coerce argument to eliminate compiler warning.
7289 (tarx): Use installed version of cygwin1.dll, overriding tar file name.
7290 (refmatches): New function. Tests if ref is contained in a list of
7291 packages to install.
7292 (filematches): New function. Tests if filename matches one of a list
7293 of packages to install.
7294 (recurse_dirs): Accept list of packages to install. Generalize tar.gz
7295 test to accomodate _tar.gz.
7296 (prompt): Ensure that stdout is flushed prior to asking for input.
7297 (findhref): Initialize variables to quiet a compiler warning.
7298 (processdirlisting): Accept list of packages to install. Special case
7299 cygwin tar file version number.
7300 (downloaddir): Accept list of packages to install.
7301 (downloadfrom): Ditto.
7302 (create_uninstall): Eliminate unneeded variables. Quote arguments to
7304 (do_start_menu): Don't create uninstall bat file if updating or user
7305 specified a list of packages.
7306 (mkmount): Eliminate unneeded variables.
7307 (get_pkg_stuff): New function. Checks for previous unversioned
7309 (main): Accept -u and -f options and package names on the command line.
7310 Use get_pkg_stuff to initialize package information. Umount /etc.
7311 Call recurse_dirs and downloadfrom with list of package to install.
7312 Ensure that all /usr/local directories are created. Output
7313 installation time to setup.log.
7314 * setup.h: Add some prototypes.
7315 * xsystem.c (xcreate_process): Eliminate unneeded variable.
7317 Sat Apr 29 12:43:08 2000 Christopher Faylor <cgf@cygnus.com>
7319 * setup.c (optionprompt): Don't overlap display of already seen options
7321 (geturl): Print name of site which we're connecting to rather than "ftp
7323 (processdirlisting): Avoid URLs that contain a /. or ./ . Is this
7324 test too simplistic?
7325 (do_start_menu): Use pathcat to build path to <root>\bin to avoid
7326 problems when user chooses x:\ as their root.
7327 (main): For now, default to "non-update" mode. Allow -u option to
7330 Sat Apr 29 00:26:06 2000 Christopher Faylor <cgf@cygnus.com>
7333 * setup.c (tarx): Skip already installed or older packages. Report
7334 when a package has been updated.
7335 (processdirlisting): Skip already installed or older packages.
7336 (main): Detect -f option for forced installation. Initialize pkg stuff
7338 * setup.h: Add pkg definitions.
7340 Thu Apr 27 14:21:30 2000 Christopher Faylor <cgf@cygnus.com>
7342 * setup.c (findhref): Return NULL on empty string. Eat any trailing
7344 (processdirlisting): Attempt to limit recursively processing the same
7347 Thu Apr 27 11:42:23 2000 Christopher Faylor <cgf@cygnus.com>
7349 * setup.c (filedel): New function.
7350 (output_file): Keep track of files extracted from setup.exe for
7351 subsequent deletion.
7352 (tarx): Close process handle of child tar process or suffer handle
7354 (getdownloadsource): Close mirror file so that it can be unlinked.
7355 (processdirlisting): Return total number of files extracted.
7356 (main): Initialize array of files to delete. Ensure that files are
7357 closed on exit. Make the directory that setup.exe is started from ==
7358 the directory where temporary files are placed. Issue an error if no
7359 files were found to download.
7360 * xsystem.c (xcreate_process): Close the thread handle. Close the
7361 process handle if we waited for it to exit.
7363 Thu Apr 27 09:54:19 2000 Christopher Faylor <cgf@cygnus.com>
7365 * setup.c (main): Change version number output.
7367 Thu Apr 27 09:23:17 2000 Christopher Faylor <cgf@cygnus.com>
7369 * setup.c (tarx): Use full path name to tar executable.
7370 (main): Build full pathname to tar executable. Create /usr/local/etc
7373 Wed Apr 26 22:16:57 2000 Christopher Faylor <cgf@cygnus.com>
7375 * setup.c (findhref): Change method for scanning for href= to choose
7376 the last one on the line. This is still not foolproof and probably
7377 will need to be changed eventually. Don't abort if no "size" field is
7379 (processdirlisting): Fix boolean algebra.
7381 Wed Apr 26 01:10:39 2000 Christopher Faylor <cgf@cygnus.com>
7383 * main.c (tarx): Add some code for future task of unmounting
7384 directories encountered in tar file.
7386 Sat Apr 22 16:37:03 2000 Christopher Faylor <cgf@cygnus.com>
7388 * setup.c (findhref): Decode file size, when appropriate.
7389 (needfile): New function. Returns 1 when file should be
7391 (processdirlisting): Always download if file size does not
7392 match. Prompt when download fails for some reason.
7393 (getdownloadsource): Accomodate findhref argument changes.
7395 Sat Apr 22 15:13:42 2000 Christopher Faylor <cgf@cygnus.com>
7397 Throughout, use global session handle rather than reinitializing for
7398 each connect. Don't pass session as an argument to setup.c functions.
7399 * setup.c (geturl): Only issue "Connecting to.." message when using
7400 http or first time for ftp since subsequent connections will be fast.
7401 (processdirlisting): Allocate space for "N" when user has specified
7402 "N"ever option so that it can be subsequently freed.
7403 (main): Abort if we can't get the list of mirrors.
7405 Thu Apr 20 16:41:42 2000 Christopher Faylor <cgf@cygnus.com>
7407 * setup.c (main): Umount /bin and /lib.
7409 Wed Apr 19 13:34:44 2000 Christopher Faylor <cgf@cygnus.com>
7411 * setup.c (main): Create an empty /var/run/utmp.
7413 Tue Apr 18 19:16:56 2000 Christopher Faylor <cgf@cygnus.com>
7415 * Makefile.in: Add umount to list of files to include in setup.exe.
7416 * setup.c (xumount): New function for unmounting directories.
7417 (main): Unmount /usr.
7418 (mkmount): Unmount "unix directory" before trying to figure out where
7419 to create the directory.
7421 Tue Apr 18 17:28:55 2000 Christopher Faylor <cgf@cygnus.com>
7423 * setup.c (mkmount): Use xcreate_process to start mount process,
7425 (main): Don't do buffering on stdout or prompts won't be displayed
7426 correctly if running in a cygwin shell with CYGWIN=tty.
7428 Tue Apr 18 15:35:19 2000 Christopher Faylor <cgf@cygnus.com>
7430 * setup.c (main): Remove the CYGWIN environment variable before
7431 starting any cygwin programs.
7433 Mon Apr 17 19:20:52 2000 Vadim Egorov <egorovv@mailandnews.com>
7435 * setup.c (geturl): Use alternative method for finding filename part of
7437 (processdirlisting): Accomodate strange output from non-MS ftp proxy.
7438 (downloaddir): Unlink file containing dir listing.
7439 (downloadfrom): Ditto.
7441 Mon Apr 17 00:00:49 2000 Christopher Faylor <cgf@cygnus.com>
7443 * setup.c (main): Disallow running setup.exe from the "root".
7445 Sun Apr 16 18:50:58 2000 Christopher Faylor <cgf@cygnus.com>
7447 Use "warning" function, where appropriate, to output warnings.
7448 * setup.c (warning): New function -- outputs warning to console and log
7450 (tarx): Fix index used to reset file protection.
7451 (main): Open the log file earlier so that more stuff can be sent to it.
7453 Sat Apr 15 20:05:33 2000 Christopher Faylor <cgf@cygnus.com>
7455 * setup.c (processdirlisting): Make "N" option a little less aggressive.
7457 Fri Apr 14 11:11:29 2000 Christopher Faylor <cgf@cygnus.com>
7459 * setup.c (tarx): Wait to after tar has completed to reset protections
7460 or suffer races with tar process.
7462 Thu Apr 13 12:51:19 2000 Christopher Faylor <cgf@cygnus.com>
7464 * Makefile.in: Eliminate duplicate -nostdinc from CFLAGS.
7465 * setup.c (create_uninstall): Create the uninstall .bat file in the
7466 "root" so that we can remove the /bin directory. Add bin\cygwin.bat to
7467 list of files to be deleted. Fix directory detection for determining
7468 when to use 'rmdir'.
7469 (do_start_menu): Add /usr/local/bin to the path.
7470 (main): Add slop to files.array allocation so that we don't have to
7471 worry about reallocating the array when it grows too large when doing
7472 some trivial "pushes". Add /tmp and /usr/local/{bin,lib} to list of
7475 Thu Apr 13 01:59:44 2000 Christopher Faylor <cgf@cygnus.com>
7477 * setup.c (processdirlisting): Fix handling of "A" for "A"lways
7480 Thu Apr 13 01:11:45 2000 Christopher Faylor <cgf@cygnus.com>
7482 * path.c (kill_cygpath): New cleanup function.
7483 (exit_cygpath): New cleanup function.
7484 (cygpath_pipe): New function. Sets up cygpath in the background for
7485 translating filenames.
7486 (pathcvt): Use background cygpath for file translation.
7487 * setup.c (tarx): New function. Called to extract tar files, capture
7488 logging output, and translate it to Windows format.
7489 (recurse_dirs): Use 'tarx' function to extract files.
7490 (create_uninstall): Use file list built up by tarx rather than reading
7492 (mkmount): Add ability to mount root.
7493 (main): Track elapsed install time. Mount root.
7494 * starry.h: Add index field to strarry for tracking of tarx's usage of
7496 * xsystem.c (xcreate_process): Return proces handle when not waiting.
7498 Mon Apr 10 22:44:56 2000 Christopher Faylor <cgf@cygnus.com>
7501 (pathfp): New function. Preliminary work for new -f cygpath
7503 * Makefile.in: Add new file.
7504 (pathcvt): Move to new file.
7508 * setup.c (processdirlisting): Always open file in text mode.
7509 (create_uninstall): Ditto.
7510 (getdownloadsource): Ditto.
7513 Mon Apr 10 20:33:40 2000 Christopher Faylor <cgf@cygnus.com>
7515 * xsystem.c: New file.
7516 * Makefile.in: Accomodate new file.
7517 * setup.c (xsystem): Move to new file.
7518 (recurse_dirs): Accept handle to output log file. Don't use ">"
7519 redirection to trap tar output. Use supplied handle instead.
7520 (create_uninstall): Accept FILE pointer to opened log file. Don't
7521 unlink log file here.
7522 (do_start_menu): Accept FILE pointer to pass to create_uninstall.
7523 (main): Open log file here and pass it to various functions. Unlink
7526 Mon Apr 10 17:15:52 2000 Christopher Faylor <cgf@cygnus.com>
7528 Change occurrences of .usr.bin to .bin throughout.
7529 * setup.c (geturl): Increase number of retries to 20. Let user know
7530 what's going on during long connects.
7531 (processdirlisting): Accept "A"lways and "N"ever as update options.
7532 (create_uninstall): Load cygwin1.dll from the current directory rather
7534 (main): Add some expository text.
7536 Sun Apr 9 20:59:15 2000 Christopher Faylor <cgf@cygnus.com>
7538 * Makefile.in: Change method for compressing cygwin1.dll to avoid
7539 creating a cygwin1.dll in the current directory. Ensure the addition
7540 of -nostdinc to MINGW_CFLAGS.
7542 Sun Apr 9 02:15:47 2000 Christopher Faylor <cgf@cygnus.com>
7544 * Makefile.in: Augment clean target.
7546 Fri Apr 7 17:04:02 Ron Parker <rdparker@sourceware.cygnus.com>
7548 * README: Added info about non-working mingw implementation
7549 * gzip.exe.gz: Replace with a version from the same build as the other
7551 * tar.exe.gz: Replace with a version from the same build as the other
7553 * mount.exe.gz: Add to repository until, mingw can build setup.
7554 * cygpath.exe.gz: ditto
7555 * cygwin1.dll.gz: ditto
7556 * setup.c: Overwrite /bin and /lib mounts. Generate working shortcut
7557 for Win9x. Display only a screenfull of options at a time. Call all
7558 tools with an absolute path.
7559 * setup.dsp: Restore the carriage returns, MS Developer Studio needs
7564 Thu Apr 6 19:15:27 2000 Christopher Faylor <cgf@cygnus.com>
7566 * Makefile.in: Add "-nostdinc" to regular CFLAGS. Add target to grab
7567 cygwin1.dll from ../cygwin subdirectory.
7568 * gzip.exe.gz: Update.
7569 * tar.exe.gz: Update.
7571 Wed Apr 5 10:52:08 2000 Christopher Faylor <cgf@cygnus.com>
7573 * Makefile.in: Use ZLIB variable as a target.
7575 Sat Apr 1 22:49:09 2000 Christopher Faylor <cgf@cygnus.com>
7577 * Makefile.in: Eliminate traces of cygwinisms. Don't link with
7578 libmsvcrt.a. It's unneeded. Build .rc file on the fly from various
7580 * configure.in: Locate correct objcopy.
7581 * configure: Regenerate.
7583 Sat Apr 1 20:48:09 2000 Christopher Faylor <cgf@cygnus.com>
7585 * Makefile.in: New file.
7586 * configure.in: New file.
7587 * configure: New file.
7588 * zlib/Makefile.am: New file.
7589 * zlib/configure.in: New file.
7590 * zlib/aclocal.m4: New file.
7591 * zlib/acinclude.m4: New file.
7592 * zlib/configure: Regenerate from configure.in.
7593 * zlib/Makefile.in: Regenerate from Makefile.am