1 2010-03-13 DJ Delorie <dj@redhat.com>
3 * nio-ftp.c (read): Read RETR status code on EOF to avoid
6 2010-03-01 Christopher Faylor <me+cygwin@cgf.cx>
8 * Makefile.in: Output the name of the generated src target.
10 2010-03-01 Christopher Faylor <me+cygwin@cgf.cx>
12 * Makefile.in: Add a setup-src target.
14 2010-03-01 Corinna Vinschen <corinna@vinschen.de>
16 * filemanip.cc (mklongpath): Skip "." and ".." path components to
19 2010-02-15 Corinna Vinschen <corinna@vinschen.de>
21 * filemanip.cc (mklongpath): Simplify backslash folding.
23 2010-02-15 Corinna Vinschen <corinna@vinschen.de>
25 * filemanip.cc (transform_chars): Drop function.
26 (mklongpath): Call mbrtowc in a loop rather than just mbstowcs.
27 Transform characters on the fly. Fold multiple backslashes into one.
28 Drop trailing backslash.
30 2010-02-15 Dave Korn <dave.korn.cygwin@gmail.com>
32 * choose.cc (ChooserPage::PlaceDialog): Only skip resizing window
33 in fully-unattended mode, not chooser-only mode.
34 (ChooserPage::OnUnattended): Return appropriate status to run page
35 or not according to kind of unattended mode.
36 * choose.h (ChooserPage::OnUnattended): Remove inline implementation
37 and retain prototype only.
38 * main.cc (PackageManagerOption): New boolean option.
39 (main): Take it into account when setting unattended_mode.
40 * proppage.cc (PropertyPage::DialogProc): Use new enum type when
41 setting unattended_mode.
42 * state.cc (unattended_mode): Change from bool to enum attend_mode.
43 * state.h (enum attend_mode): Declare new enum type.
44 (unattended_mode): Update extern declaration to use it.
46 2010-02-04 Corinna Vinschen <corinna@vinschen.de>
48 * win32.cc (NTSecurity::GetPosixPerms): Return NULL security descriptor
50 (NTSecurity::SetPosixPerms): Remove.
51 * win32.h (NTSecurity::GetPosixPerms): Remove declaration.
53 2010-02-02 Corinna Vinschen <corinna@vinschen.de>
55 * desktop.cc (make_link): Use 0 default permissions when creating files
57 * download.cc (download_one): Ditto.
58 * ini.cc (do_remote_ini): Ditto.
59 * localdir.cc (offer_to_create): Ditto.
60 * filemanip.cc (nt_wfopen): Use Windows default permissions if perms
62 * mkdir.cc (mkdir_p): Ditto if mode is set to 0.
64 2010-01-29 Christopher Faylor <me+cygwin@cgf.cx>
66 * mount.cc (read_mounts_9x): Preserve old way of doing things when
69 2010-01-28 Christopher Faylor <me+cygwin@cgf.cx>
71 * desktop.cc (make_link): Preserve old way of doing things when
73 (make_cygwin_bat): Ditto.
75 * mount.cc (read_mounts): Ditto.
76 (set_root_dir): Ditto.
77 * root.cc (load_dialog): Ditto.
79 * install.cc (Installer::installOne): Don't install anything if there
80 is no canonical file associated with source.
81 (do_install_thread): Set up old-style registry entries if is_legacy
82 rather than just keying on whether this is Windows NT.
83 * io_stream_file.cc (io_stream_file::exists): Redefine "exists" to mean
86 2010-01-16 Christopher Faylor <me+cygwin@cgf.cx>
88 * archive_tar.c (archive_tar_file::read): Always set read_something
89 even for zero-length files.
91 2010-01-16 Christopher Faylor <me+cygwin@cgf.cx>
93 * archive_tar.h (archive_tar_file::read_something): New member.
94 * archive_tar_file.cc (archive_tar_file::archive_tar_file): Don't reset
95 state unless we've actually read something.
96 (archive_tar_file::read): Set read_something variable here to indicate
97 that we've read something from the tar file.
99 2010-01-13 Christopher Faylor <me+cygwin@cgf.cx>
101 * localdir.cc (LocalDirPage::OnNext): Strip trailing slashes.
103 2009-12-27 Christopher Faylor <me+cygwin@cgf.cx>
105 * main.cc (dyn_AttachConsole): Make static.
106 (dyn_GetLongPathName): New variable.
107 (set_dynaddr): New function.
108 (set_cout): Don't set dyn_AttachConsole here.
109 (set_legacy): Don't attempt to call function which does not exist in
110 older versions of NT.
111 (main): Call set_dynaddr to set dynamic load addresses.
113 2009-12-22 Christopher Faylor <me+cygwin@cgf.cx>
115 * ini.h: Use is_legacy to control setup.ini names.
116 * main.cc (set_legacy): New function.
117 (main): Call set_legacy with program name to determine if this is
118 supposed to be an installation of the legacy version of cygwin. Issue
119 a warning on attempt to install legacy on Windows NT class system.
121 2009-12-22 Christopher Faylor <me+cygwin@cgf.cx>
123 * package_message (packagemessage::display): Avoid displaying a message
124 when in unattended mode.
126 2009-12-22 Corinna Vinschen <corinna@vinschen.de>
128 * win32.h (isdirsep): Define to replace local isslash definitions.
129 * UserSettings.cc (UserSettings::open_settings): Remove isslash.
130 Use isdirsep instead of isslash.
131 * filemanip.cc (mklongpath): Ditto.
132 * root.cc (directory_is_rootdir): Ditto.
133 * localdir.cc (LocalDirSetting::save): Avoid consecutive backslashes
134 in setup log file paths.
135 * main.cc (main): Ditto.
137 2009-12-21 Christopher Faylor <me+cygwin@cgf.cx>
139 * choose.cc (ChooserPage::PlaceDialog): Put *correct* size in
140 WINDOWPLACEMENT length field.
142 2009-12-18 Corinna Vinschen <corinna@vinschen.de>
144 Throughout, revert prototypes and methods set_mtime_and_mode to
145 set_mtime and only care for the file timestamp.
147 Throughout, accommodate additional mode_t parameter in call to
150 * IOStreamProvider.h (IOStreamProvider::open): Add mode_t parameter.
151 * archive.cc (archive::extract_file): Reorder creation of in and tmp
152 to get the file mode from the tar archive earlier. Call io_stream::open
153 with additional mode from tar archive. Accommodate reversion to
155 * filemanip.cc (nt_wfopen): Remove retry loop. Instead initialize
156 OBJECT_ATTRIBUTES with matching POSIX perms according to incoming
157 perms to create correct ACL on file creation. Remove subsequent call
158 to nt_sec.SetPosixPerms.
159 * io_stream.cc (io_stream::open): Take additional mode_t parameter
160 and connect through to IOStreamProvider's open.
161 * io_stream.h (io_stream::open): Add mode_t parameter.
162 * io_stream_cygfile.cc (CygFileProvider::open): Ditto.
163 (io_stream_cygfile::io_stream_cygfile): Ditto. Call nt_wfopen with
164 incoming mode_t parameter. Make sure .exe and .dll files always
165 have execute permissions set.
166 (io_stream_cygfile::set_mtime): Remove retry loop and open file with
167 just GENERIC_WRITE access.
168 * io_stream_cygfile.h (io_stream_cygfile::io_stream_cygfile): Add mode_t
170 * io_stream_file.cc (FileProvider::open): Ditto.
171 (io_stream_file::io_stream_file): Ditto. Call nt_wfopen with incoming
173 * io_stream_file.h (io_stream_file::io_stream_file): Add mode_t
175 * io_stream_memory.h (class io_stream_memory): Remove mode member.
176 Just return 0 from get_mode.
177 * mkdir.cc (mkdir_p): Remove retry loop. Instead initialize
178 OBJECT_ATTRIBUTES with matching POSIX perms according to incoming
179 perms to create correct ACL on file creation. Remove subsequent call
180 to nt_sec.SetPosixPerms.
181 * mklink2.cc (mkcygsymlink_nt): Remove retry loop. Instead initialize
182 SECURITY_ATTRIBUTES with matching POSIX perms to create correct ACL on
184 * win32.cc (NTSecurity::GetPosixPerms): New function to generate
185 POSIX ACL. Default to current owner and current primary group for
186 owner/group permissions.
187 (NTSecurity::SetPosixPerms): Let GetPosixPerms create the DACL.
188 (NTSecurity::setAdminGroup): Set groupSID to admins SID if successful.
189 (NTSecurity::setDefaultSecurity): Store user SID in ownerSID member.
190 Default groupSID to original primary group.
191 * win32.h (struct acl_t): Define here.
192 (class NTSecurity): Rename ownerSID and groupSID to cr_ownerSID and
193 cr_groupSID. Change throughout. Add members ownerSID and groupSID.
194 Declare new method GetPosixPerms.
196 2009-12-17 Corinna Vinschen <corinna@vinschen.de>
198 * filemanip.cc (nt_wfopen): Only call nt_sec.SetPosixPerms if we have
200 * mkdir.cc (mkdir_p): Ditto.
202 2009-12-17 Corinna Vinschen <corinna@vinschen.de>
204 * filemanip.cc (nt_wfopen): Fix requested access rights. Retry
205 without WRITE_DAC access on access denied. Add comment.
206 * io_stream_cygfile.cc (io_stream_cygfile::set_mtime_and_mode): Ditto.
207 * mkdir.cc (mkdir_p): Ditto.
208 * mklink2.cc (mkcygsymlink_nt): Ditto.
210 2009-12-17 Corinna Vinschen <corinna@vinschen.de>
212 * localdir.cc (LocalDirSetting::save): Call mkdir_p with isadir set
213 since /var/log is a dir.
215 2009-12-16 Corinna Vinschen <corinna@vinschen.de>
217 * UserSettings.cc (UserSettings::open_settings): Never add more than
219 * filemanip.cc (tfx_chars): Align to Cygwin's transformation table.
220 * localdir.cc (LocalDirSetting::save): Call mkdir_p with DOS path.
222 2009-12-16 Christopher Faylor <me+cygwin@cgf.cx>
224 * package_message.h: New file.
226 2009-12-13 Christopher Faylor <me+cygwin@cgf.cx>
228 * IniDBBuilder.h (buildMessage): Define for base class.
229 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildMessage): Define.
230 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildMessage): Declare.
231 * PickPackageLine.cc: Pass pointer to package to "pick" throughout,
233 * PickView.cc: Ditto.
235 * package_meta.cc: Ditto.
237 * package_version.cc: Ditto.
238 (packageversion::pick): Add pkg pointer as second argument. Display
239 message where appropriate.
240 * package_version.h (packageversion::pick): Add pkg pointer as second
242 * package_meta.h (packagemeta::mesage): Define.
243 (packagemeta::set_message): Define.
244 * inilex.ll: Properly return MESSAGE token.
245 * iniparse.yy: Handle message: keyword.
247 2009-12-08 Dave Korn <dave.korn.cygwin@gmail.com>
249 * localdir.cc (offer_to_create): New function.
250 (browse_cb): Handle selection changed and validate failed
251 callbacks, and call offer_to_create where appropriate.
252 (browse): Set new dialog style flags in browser info.
253 (LocalDirPage::OnNext): Replace call to mkdir_p with offer to
254 create or error message dialog display, allow proceeding to
255 chooser even if local dir does not exist in unattend mode or
256 if user insists, and fix small memory leak.
258 * res.rc (IDS_MAYBE_MKDIR, IDS_CANT_MKDIR, IDS_NO_CWD): Define new
260 * resource.h (IDS_MAYBE_MKDIR, IDS_CANT_MKDIR, IDS_NO_CWD): Define
261 corresponding resource ID numbers.
263 2009-12-03 Corinna Vinschen <corinna@vinschen.de>
265 * main.cc (WinMain): Disable running on Windows 9x. Show message box
268 2009-12-03 Dave Korn <dave.korn.cygwin@gmail.com>
270 (ChooserPage::createListview): When nothing is found in the "All"
271 category, pass an empty static dummy category object to the PickView
272 constructor, instead of trying to dereference not-found iterator.
274 2009-11-23 Corinna Vinschen <corinna@vinschen.de>
276 * io_stream_cygfile.cc (io_stream_cygfile::get_size): Don't try to
277 close invalid handle.
278 * io_stream_file.cc (io_stream_file::get_size): Ditto
280 2009-11-22 Dave Korn <dave.korn.cygwin@gmail.com>
282 * threebar.cc (ThreeBarProgressPage::OnMessageApp): Don't loop forever
283 retrying ini file download/parse if it errors in unattended mode.
285 2009-11-22 Dave Korn <dave.korn.cygwin@gmail.com>
287 * package_meta.cc (CategoryOption): New StringOption for '-C'.
288 (parseNames): New helper subroutine abstracts string parsing from ...
289 (packagemeta::isManuallyWanted): Use it, and check for category names
290 from CategoryOption as well as individual package names.
291 * package_db.cc (packagedb::fillMissingCategory): Don't check for
292 manually-wanted packages until after initialising all the categories.
294 2009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
296 * localdir.cc (LocalDirSetting::LocalDirSetting): Restore -l option.
298 2009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
300 * site.cc: Add #include of BoolOption header from libgetopt.
301 (OnlySiteOption): New BoolOption for command-line -O option.
302 (get_site_list): Respect BoolOption by not downloading mirror
303 list, nor using nor updating cached mirrors.
305 2009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
307 * download.cc (do_download_thread): Only retry an incomplete download
308 a limited number of times in unattended mode.
310 2009-11-04 Dave Korn <dave.korn.cygwin@gmail.com>
312 * main.cc (main_display): Use apartment-, not multi- threading model
313 when initialiseing COM.
315 2009-11-04 Corinna Vinschen <corinna@vinschen.de>
317 * localdir.cc (browse): Make title text depend on what we do.
318 (LocalDirPage::OnNext): If we plan to download, try to create directory
319 before cd'ing into it.
321 2009-11-03 Corinna Vinschen <corinna@vinschen.de>
323 * mkdir.cc: Include sys/stat.h unconditionally.
324 (mkdir_p): Add S_IFDIR flag in call to nt_sec.SetPosixPerms.
325 * win32.cc: Include sys/stat.h.
326 (NTSecurity::SetPosixPerms): Add CREATOR OWNER, CREATOR GROUP, and
327 Everyone inheritance-only entries when setting a directory DACL.
328 (NTSecurity::initialiseWellKnownSIDs): Create SIDs for CREATOR OWNER and
330 * win32.h (class NTSecurity): Add members ownerSID and groupSID.
332 2009-10-03 Andy Koppe <andy.koppe@gmail.com>
334 * main.cc (main): Make sure C runtime uses same codepage as GUI.
336 2009-09-20 Christopher Faylor <me+cygwin@cgf.cx>
338 * main (set_cout): Really do attach to a console if stdout is "bad".
340 2009-09-18 Andy Koppe <andy.koppe@gmail.com>
342 * root.cc (string orig_root_dir): New variable.
343 (check_if_enable_next): Show warning against installing Cygwin into
344 disk root only if the root directory has actually been changed.
345 * res.rc: Make the root dir warning a bit more meaningful, and refrain
346 from using uppercase.
348 2009-09-18 Christopher Faylor <me+cygwin@cgf.cx>
350 * choose.cc (ChooserPage::OnBack): Revert to non-maximized when
351 returning to mirror from package selection.
353 2009-09-18 Dave Korn <dave.korn.cygwin@gmail.com>
355 * site.cc (get_site_list): Use empty string if user settings
356 return NULL pointer for cached mirrors list.
357 (SiteSetting::getSavedSites): Do nothing if user settings return
358 NULL pointer for last mirror URL.
360 2009-08-21 Christopher Faylor <me+cygwin@cgf.cx>
362 * site.cc (SiteSetting::registerSavedSite): Fix comment.
364 2009-07-03 Christopher Faylor <me+cygwin@cgf.cx>
366 * main.cc (set_cout): Don't reset stdout if we already have a stdout.
368 2009-07-03 Christopher Faylor <me+cygwin@cgf.cx>
370 * choose.cc (ChooserPage::ChooserPage): Use more specific name for
371 saving window settings.
372 (ChooserPage::~ChooserPage): Ditto.
374 2009-07-01 Dave Korn <dave.korn.cygwin@gmail.com>
376 * PickView.h (PickView::total_delta_x): New int member.
377 (PickView::set_header_column_order): Add prototype.
378 * PickView.cc (PickView::set_header_column_order): New function,
380 (PickView::set_headers): ... here. Call it.
381 (PickView::init_headers): Apply total_delta_x to last_col width.
382 (PickView::PickView): Initialise new total_delta_x member to zero.
383 (PickView::WindowProc): Use set_header_column_order to find and
384 adjust final column for both sets of headers.
386 2009-06-29 Christopher Faylor <me+cygwin@cgf.cx>
388 * SourceSetting.cc (SourceSetting::SourceSetting): Restore proper
389 remembrane of last source setting.
390 * choose.cc (ChooserPage::ChooserPage): Potentially retrieve dialog
392 (ChooserPage::~ChooserPage): Save geometry settings if the user moved
394 (ChooserPage::PlaceDialog): Rename from MaximizeDialog. Accommodate
395 changed user placement settings.
396 (ChooserPage::OnActivate): MaximizeDialog -> PlaceDialog.
397 (ChooserPage::OnNext): Ditto.
398 * choose.h (ChooserPage::~ChooserPage): Define.
399 (ChooserPage::cmd_show): Delete.
400 (ChooserPage::saved_geom): New field.
401 (ChooserPage::window_placement): Ditto.
402 (ChooserPage::pre_chooser_placement): Ditto.
403 (ChooserPage::PlaceDialog): Rename from MaximizeDialog.
405 2009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
407 * ConnectionSetting.cc (ConnectionSetting::ConnectionSetting): Remove
408 old code which no longer makes sense when run from a constructor.
409 * SourceSetting.cc (SourceSetting::SourceSetting): Ditto.
410 * localdir.cc (LocalDirSetting::LocalDirSetting): Ditto. Fix typo
411 which caused saved settings to be ignored.
413 2009-06-28 Christopher Faylor <me+cygwin@cgf.cx>
415 * UserSettings.cc (UserSettings::UserSettings): settings.rc -> setup.rc.
417 2009-06-28 Corinna Vinschen <corinna@vinschen.de>
419 * desktop.cc (DesktopSetupPage::OnInit): Drop CoInitialize call here.
420 * main.cc (main_display): Use InitCommonControlsEx rather than
421 InitCommonControls per MSDN. Call CoInitializeEx and create IShellLink
422 instance here to workaround a problem on Windows 7. Release IShellLink
423 instance and call CoUninitialize on exit.
424 * mklink.cc (sl): Change to global variable. Drop call to
425 CoCreateInstance here. Check if sl is valid before using it.
427 2009-06-27 Christopher Faylor <me+cygwin@cgf.cx>
429 Preliminary option handling revamp.
430 Throughout, change load/save methods to constructors/destructors which
431 use new UserSettings methods. Do not inherit from UserSetting class.
432 * KeysSetting.cc (ExtraKeysSetting *ExtraKeysSetting::global): Define.
433 (ExtraKeysSetting::ExtraKeysSetting): Initialize some class members use
434 new UserSettings methods.
435 (ExtraKeysSetting::~ExtraKeysSetting): Use new UserSettings method.
436 * Makefile.am (setup_SOURCES): Eliminate UserSetting.h and
438 * UserSettings.cc: Complete rewrite. Implements new UserSettings
440 * UserSettings.h: Complete rewrite. Defines new UserSettings class
442 * crypto.cc (ExtraKeys): Delete.
443 (add_key_from_sexpr): Use ExtraKeysSetting::instance rather than
445 (verify_ini_file_sig): Ditto.
446 * io_stream.h (io_stream): Define virtual << operators.
447 * localdir.cc (localDir): Delete.
448 * main.cc: Include headers which declar new dynamically invoked
450 (main_display): New function. Controls order of option setting and
451 property page setup. Add new class invocations to force option setting
453 (main): Invoke new UserSettings class constructor to populate new
454 settings class. Call main_display() to do most of the setup work.
455 Call Settings.save () to save all settings.
456 * net.cc (theSetting): Delete.
457 * site.cc (SiteSetting::save): Record whether we've saved the
459 (get_site_list): Just use value returned from new UserSettings method
460 rather than parsing a file.
461 (SiteSetting::getSavedSites): Ditto.
462 (write_cache_list): Use UserSettings operator to store mirror cache.
463 (save_cache_file): Ditto.
464 * source.cc (theSetting): Delete.
466 * win32.h: gcc-4 accommodation.
468 2009-06-26 Dave Korn <dave.korn.cygwin@gmail.com>
470 * res.rc (SETUP_STANDARD_DIALOG_W, SETUP_STANDARD_DIALOG_H,
471 SETUP_SMALL_DIALOG_W, SETUP_SMALL_DIALOG_H): Add constant defines
473 (SETUP_STANDARD_DIALOG_DIMS, SETUP_SMALL_DIALOG_DIMS): Add helper
474 macros for (W,H) pairs of dimensions.
475 (SETUP_HEADICON_X): New global constant define.
476 (IDD_SOURCE, IDD_VIRUS, IDD_LOCAL, IDD_ROOT, IDD_SITE, IDD_NET,
477 IDD_INSTATUS, IDD_PROXY_AUTH, IDD_NET_AUTH, IDD_DESKTOP,
478 IDD_FTP_AUTH DIALOG, IDD_DROPPED): Use the above for dialog sizes,
479 horizontal rules and icon positioning.
480 (SETUP_KPCE_W): New define for radio-button size.
481 (SETUP_VIEWCAP_W, SETUP_VIEWCAP_X, SETUP_VIEW_W, SETUP_VIEW_X,
482 SETUP_EXP_X, SETUP_CURR_X, SETUP_PREV_X, SETUP_KEEP_X): Add defines
483 for right-aligned controls.
484 (SETUP_SEARCH_X, SETUP_SEARCH_W, SETUP_SEARCHTEXT_X,
485 SETUP_SEARCHTEXT_W, SETUP_CLEAR_X, SETUP_CLEAR_W): Likewise defines
486 for left-aligned controls.
487 (IDD_CHOOSE): Use all the above, and reformat with whitespace
488 between args for clarity.
490 2009-06-26 Corinna Vinschen <corinna@vinschen.de>
492 * Makefile.am (setup_LDADD): Add -lshlwapi.
493 * PickView.cc: Include shlwapi.h.
494 (PickView::setViewMode): Compare package name with search string
496 (PickView::insert_category): Ditto.
498 2009-06-26 Corinna Vinschen <corinna@vinschen.de>
500 * script.cc (init_run_script): Don't set $HOME to /tmp. It breaks
503 2009-06-25 Corinna Vinschen <corinna@vinschen.de>
505 * script.cc (init_run_script): Reinstantiate accidentally removed
508 2009-06-22 Christopher Faylor <me+cygwin@cgf.cx>
510 * script.cc (init_run_script): Revert to initializing cmd based on OS
513 2009-06-22 Corinna Vinschen <corinna@vinschen.de>
515 * script.cc (Script::run): Start bash without -c option.
517 2009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
519 * threebar.cc (ThreeBarProgressPage::ins_dialog): Move variable to more
521 (ThreeBarProgressPage::MaximizeDialog): Move function to more
523 (ThreeBarProgressPage::OnMessageApp): Remove MaximizeDialog calls.
524 * threebar.h: Remove maximize handling.
525 * choose.cc (ChooserPage::ins_dialog): New variable.
526 (ChooserPage::MaximizeDialog): New function.
527 (ChooserPage::ChooserPage): Remove unneeded handling of nCmdShow.
528 (ChooserPage::OnActivate): Maximize chooser page via MaximizeDialog.
529 (ChooserPage::OnNext): Revert chooser page to normal before returning.
530 * main.cc (main): Don't pass cmd_show to ChooserPage.
531 * propsheet.cc (PropSheetProc): Accommodate change in class for
534 2009-06-20 Christopher Faylor <me+cygwin@cgf.cx>
536 * script.cc (shells): Delete.
537 (cmd): Just assign to "cmd.exe" since we're always running on NT now.
538 (sanitize_PATH ): New function.
539 (init_run_script): Ensure that we're only called once. Strip
540 environment of non-pertinent stuff. Call sanitize_PATH to remove
541 non-standard stuff from the PATH. Set up a few standard environment
544 2009-06-16 Corinna Vinschen <corinna@vinschen.de>
546 * mount.cc (create_install_root): Don't load mount table again.
547 (read_mounts_nt): Don't break loop, rather continue when not being
548 able to open "Cygwin" registry key.
550 2009-06-03 Ralph Hempel <rhempel@bmts.com>
552 * source.cc: Add support for both -D and -L on the command line.
554 2009-06-03 Corinna Vinschen <corinna@vinschen.de>
556 * filemanip.cc (unlink): Rename from DeleteFileW. Take additional
557 parameter to indicate file type to unlink. Use in flags given to
559 (DeleteFileW): Just call unlink from here with FILE_NON_DIRECTORY_FILE
561 (RemoveDirectoryW): Ditto with FILE_DIRECTORY_FILE flag.
563 2009-05-30 Charles Wilson <cygwin@cwilson.fastmail.fm>
565 * script.cc (Script::run): Really start bash with --norc
568 2009-05-13 Corinna Vinschen <corinna@vinschen.de>
570 * script.cc (Script::run): Start bash with --norc --noprofile options.
572 2009-05-13 Corinna Vinschen <corinna@vinschen.de>
574 * filemanip.cc (struct _FILE_RENAME_INFORMATION): Remove definition.
575 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Set
576 default permission for .exe files to 0755.
577 (io_stream_cygfile::mklink): Try to create real hardlink first. Add
579 * mklink2.cc (mkcyghardlink): New function to create real hardlink.
580 * mklink2.h (mkcyghardlink): Declare.
581 * mount.cc (from_fstab_line): Set got_usr_bin and got_usr_lib flags
582 if /usr/bin and /usr/lib mount points exist in /etc/fstab.
583 (add_usr_mnts): Only create mounts if corresponding got_usr_bin and
584 got_usr_lib flags are not set.
585 (read_mounts_nt): Initialize got_usr_bin and got_usr_lib to false.
586 Always call add_usr_mnts, even if from_fstab succeeded.
587 * ntdll.h: Include ddk/ntifs.h.
589 2009-05-12 Corinna Vinschen <corinna@vinschen.de>
591 * filemanip.cc (GetFileAttributesW): Add accidentally omited
592 OBJ_CASE_INSENSITIVE when creating OBJECT_ATTRIBUTES.
593 (SetFileAttributesW): Ditto.
595 (DeleteFileW): Ditto.
596 (RemoveDirectoryW): Ditto.
599 2009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
601 * localdir.cc (load_dialog): Choose description string based on install
603 * res.rc (IDD_LOCAL_DIR): Replace static description text with
605 * resource.h (IDS_LOCAL_DIR_DOWNLOAD): New string resource id.
606 (IDS_LOCAL_DIR_INSTALL): Likewise.
607 (IDC_LOCAL_DIR_DESC): New text control resource id.
609 2009-05-11 Christopher Faylor <me+cygwin@cgf.cx>
611 * main.cc (set_cout): Simplify code a little.
613 2009-05-11 Bryan Thrall <bryan.thrall@flightsafety.com>
615 * choose.cc (ChooserPage::OnMessageCmd): Clear search filter when
616 clear button clicked.
617 * res.rc (IDD_CHOOSE_DIALOG): Add IDC_CHOOSE_CLEAR_SEARCH button.
618 * resource.h (IDC_CHOOSE_CLEAR_SEARCH): New button resource ID.
620 2009-05-11 Corinna Vinschen <corinna@vinschen.de>
622 * UserSettings.cc (UserSettings::settingFileForLoad): Fix local load
624 (UserSettings::settingFileForSave): Never store in cwd.
625 * autoload.c (ntdll): Autoload ntdll.dll functions here.
626 * desktop.cc (make_cygwin_bat): Use GetFileAttributesW rather than
627 _waccess. Use nt_wfopen instead of _wfopen.
629 * filemanip.cc (get_file_size): Call io_stream::open with empty mode
630 string to avoid opening file twice.
631 (GetFileAttributesW): New function to replace Win32 function with
632 equivalent function opening files with backup intent.
633 (SetFileAttributesW): Ditto.
635 (DeleteFileW): Ditto.
636 (RemoveDirectoryW): Ditto.
637 (nt_wfopen): New function to replace _wfopen with equivalent function
638 opening files with backup intent.
639 * filemanip.h (nt_wfopen): Declare.
640 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Initalize
641 lasterr to 0. Allow empty mode and don't open file, if so. Call
642 nt_wfopen rather than _wfopen.
643 (io_stream_cygfile::exists): Use GetFileAttributesW rather than
645 (io_stream_cygfile::get_size): Use CreateFileW/GetFileSize to get
647 * io_stream_file.cc (io_stream_file::io_stream_file): Initalize lasterr
648 to 0. Allow empty mode and don't open file, if so. Call nt_wfopen
650 (io_stream_file::exists): Use GetFileAttributesW rather than _waccess.
651 (io_stream_file::remove): Don't try to remove non-existant file.
652 (io_stream_file::get_size): Use CreateFileW/GetFileSize to get
653 file size on NT. Add comment to keep track of 2GB border.
654 * mkdir.cc: Remove function pointers for ntdll functions.
655 (init_ntfuncs): Remove function.
656 (mkdir_p): Drop call to init_ntfuncs. Call ntdll functions directly
657 rather than over local function pointers.
659 * postinstall.cc (do_postinstall_reflector): Switch to admins group
660 as primary group after postinstall scripts have been written.
662 (do_postinstall): Add comment.
663 * res.rc: Bump copyright date.
664 * win32.h (class TokenGroupCollection): Remove.
665 * win32.cc (TokenGroupCollection::populate): Remove.
666 (TokenGroupCollection::find): Remove.
667 (NTSecurity::setDefaultSecurity): Drop reading token groups. Just
668 try to switch to admins group as primary group.
670 2009-05-07 Corinna Vinschen <corinna@vinschen.de>
672 * package_db.cc (ConnectedLoopFinder::doIt): Revert patch from
673 2008-08-29. Add dumb hardcoded algorithm to make sure base-cygwin
674 and base-passwd are always the first packages in the postinstall
677 2009-05-06 Corinna Vinschen <corinna@vinschen.de>
679 * install.cc (Installer::StandardDirs): Add /home with 1777 perms.
680 * main.cc (main): Drop setting $CYGWIN to nontsec.
682 2009-04-24 Andrew Punch <andrew@magneticbooks.com.au>
684 * PickView.h: Add #include <string>.
685 (PickView::SetPackageFilter): Add new function.
686 (PickView::packageFilterString): Add new string data member.
687 * PickView.cc (PickView::setViewMode): Use it to filter names.
688 (PickView::insert_category): Likewise.
689 (PickView::PickView): Initialise packageFilterString to blank.
690 * res.rc (IDD_CHOOSE): Add IDC_CHOOSE_SEARCH_EDIT and
691 IDC_CHOOSE_SEARCH_LABEL controls.
692 (IDS_SEARCH_TOOLTIP): Add new string resource.
693 * resource.h (IDS_SEARCH_TOOLTIP): New string resource ID.
694 (IDC_CHOOSE_SEARCH_EDIT): New edit control ID.
695 (IDC_CHOOSE_SEARCH_LABEL): Mew static text control ID.
696 * choose.cc (ChooserControlsInfo[]): Add IDC_CHOOSE_SEARCH_LABEL
697 and IDC_CHOOSE_SEARCH_EDIT controls to auto-resize list.
698 (ChooserPage::OnInit): Add tooltip to search edit box.
699 (ChooserPage::OnMessageCmd): Handle EN_CHANGE event from
700 IDC_CHOOSE_SEARCH_EDIT.
702 2009-04-24 Dave Korn <dave.korn.cygwin@gmail.com>
704 * propsheet.cc (PropSheetWndProc): Re-enable hasMinRect.
706 2009-04-23 Corinna Vinschen <corinna@vinschen.de>
708 * win32.h (NTSecurity::primaryGroupSID): Convert to a structure for
709 direct usage in GetTokenInformation.
710 (NTSecurity::osid): Remove.
711 (NTSecurity::setAdminGroup): Declare.
712 * win32.cc (NTSecurity::resetPrimaryGroup): Accommodate change to
713 primaryGroupSID. Add log output.
714 (NTSecurity::setAdminGroup): New method.
715 (NTSecurity::setDefaultSecurity): Use local structures for getting
716 TOKEN_USER and setting TOKEN_OWNER information. Accommodate change to
717 primaryGroupSID. Slightly enhance log output.
718 Only set primary group to Administrators group when installing for
719 all users. Call setAdminGroup to do it.
721 2009-04-22 Corinna Vinschen <corinna@vinschen.de>
723 * mklink2.cc (mkcygsymlink_nt): Allow 4K chars in symlink. Use strncat
725 * postinstall.cc (do_postinstall): Reset user token to original
727 * win32.cc (NTSecurity::resetPrimaryGroup): New method.
728 (NTSecurity::setDefaultSecurity): Store original primary group in
729 new NTSecurity member primaryGroupSID. Set primary group in user token
730 to Administrators group for admin users. Align comment.
731 * win32.h (class NTSecurity): Add member primaryGroupSID.
732 (NTSecurity::resetPrimaryGroup): Declare.
734 2009-04-09 Christopher Faylor <me+cygwin@cgf.cx>
736 * main.cc (set_cout): Load AttachConsole dynamically to avoid using it
737 on older Windows which don't support it.
739 2009-03-21 Christopher Faylor <me+cygwin@cgf.cx>
741 * LogFile.cc (LogFile::endEntry): Output messages to stdout.
742 * main.cc (set_cout): New function. Sets stdout to console if one
744 (main): Redirect stdout to console if unattended_mode or help option is
745 specified and no stdout is available.
747 2009-03-21 Terry Fleming <terrynfleming@gmail.com>
748 Christopher Faylor <me+cygwin@cgf.cx>
750 * propsheet.cc (PropSheetWndProc): Detect a Window closing event and
751 issue an "Are you sure" message.
753 2008-08-29 Corinna Vinschen <corinna@vinschen.de>
755 * package_db.cc (ConnectedLoopFinder::doIt): Add code to get a basic
756 order into the dependency list. Add comment to explain why.
758 2008-08-22 Brian Dessent <brian@dessent.net>
760 * KeysSetting.cc: Include string.h for memcpy et al.
761 * filemanip.cc: Include stdlib.h for for mbstowcs.
762 * io_stream_cygfile.h: Update cygmkdir_p prototype for mode_t.
763 * mount.cc (conv_fstab_spaces): Silence gcc 4.3 warning ("parentheses
764 around assignment used as truth value").
766 2008-08-20 Corinna Vinschen <corinna@vinschen.de>
768 * install.cc (Installer::StandardDirs): Additionally create /var/log
769 dir. Set mode of /var/log and /var/run to 01777.
770 * localdir.cc (LocalDirSetting::save): Create /var/log with 01777
771 permissions before creating setup.log files.
773 2008-08-20 Corinna Vinschen <corinna@vinschen.de>
775 * io_stream_cygfile.cc (io_stream_cygfile::set_mtime_and_mode):
776 Accommodate SetPosixPerms being method of nt_sec.
777 * mkdir.cc (mkdir_p): Ditto.
778 * mklink2.cc (mkcygsymlink_nt): Ditto.
779 * win32.cc: Slightly rearrange.
780 (NTSecurity::SetPosixPerms): Make SetPosixPerms method of NTSecurity
781 rather than stand-alone function. Remove dynamic allocation for
782 security descriptors in favor of static allocation. Drop out
783 preliminary if well-known SIDs are not initialized. Slightly change
784 and rearrange comments. Add creating NULL SID ACE for special
786 (NTSecurity::initialiseWellKnownSIDs): New function, replacing
787 NTSecurity::initialiseEveryOneSID. Initialize all well-known SIDs
788 here. Set wellKnownSIDsinitialized to true on success.
789 (NTSecurity::setDefaultDACL): Don't call initialiseEveryOneSID. Change
790 comment. Drop setting failed. Don't open process token here.
791 (NTSecurity::setBackupPrivileges): New function.
792 (NTSecurity::setDefaultSecurity): Call initialiseWellKnownSIDs.
793 Open process token here. Disable setting primary group. Add comment
795 * win32.h (SetPosixPerms): Move to NTSecurity.
796 (class NTSecurity): Add SetPosixPerms method. Make all SIDs private
797 again. Make NoteFailedAPI private. Add setBackupPrivileges method.
798 Rename usid to UsersSID. Remove failed method and _failed member.
799 Add wellKnownSIDsinitialized accessors and _wellKnownSIDsinitialized
802 2008-08-19 Corinna Vinschen <corinna@vinschen.de>
804 * install.cc (struct std_dirs_t): New type.
805 (class Installer): Change type of StandardDirs to std_dirs_t.
806 (Installer::StandardDirs): Store filename and mode.
807 (do_install_thread): Call io_stream::mkpath_p with name and mode from
808 Installer::StandardDirs.
809 * main.cc (main): Call setDefaultSecurity on global nt_sec.
810 * IOStreamProvider.h (IOStreamProvider::mkdir_p): Add mode parameter.
811 * LogFile.cc (LogFile::log_save): Call io_stream::mkpath_p with 0755
813 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
814 * desktop.cc (make_link): Ditto.
815 * download.cc (download_one): Ditto.
816 * ini.cc (do_remote_ini): Ditto.
817 (do_ini_thread): Ditto.
818 * package_db.cc (packagedb::flush): Ditto.
819 * archive.cc (archive::extract_file): Ditto. Call set_mtime_and_mode
820 with mode from archive. Add code to handle directory permissions as
822 * archive_tar.cc (archive_tar::get_mtime): Return time_t. Reformat.
823 (archive_tar::get_mode): New method.
824 * archive_tar.h (class archive_tar_file): Fix prototypes. Replace
825 prototype for set_mtime with prototype for set_mtime_and_mode.
826 (class archive_tar): Ditto.
827 * archive_tar_file.cc (archive_tar_file::get_mtime): Return time_t.
828 (archive_tar_file::get_mode): New method returning mode from tar header.
829 * compress_bz.cc (compress_bz::set_mtime_and_mode): Replace set_mtime.
830 (compress_bz::get_mtime): Return time_t.
831 (compress_bz::get_mode): New function.
832 * compress_gz.cc: Ditto.
833 * compress_lzma.cc: Ditto.
834 * io_stream.cc (io_stream::mkpath_p): Take additional file mode.
835 Call mkdir_p with additional file mode.
836 * io_stream_cygfile.cc (CygFileProvider::mkdir_p): Take additional file
838 (cygmkdir_p): Ditto. Call mkdir_p with additional file mode.
839 (io_stream_cygfile::set_mtime_and_mode): Replace set_mtime. Call
841 * io_stream_file.cc (FileProvider::mkdir_p): Take additional file mode.
842 (io_stream_file::set_mtime_and_mode): Replace set_mtime.
843 * mkdir.cc (init_ntfuncs): New function to initialize function pointers
845 (mkdir_p): Take additional file mode. On NT, use NT functions to create
846 directory. Call SetPosixPerms.
847 * compress_bz.h: Change prototypes accordingly.
848 * compress_gz.h: Ditto.
849 * compress_lzma.h: Ditto.
850 * io_stream.h: Ditto.
851 * io_stream_cygfile.h: Ditto.
852 * io_stream_file.h: Ditto.
853 * io_stream_memory.h: Ditto.
855 * mklink2.cc (mkcygsymlink_nt): Open file with STANDARD_RIGHTS_ALL
856 access and FILE_FLAG_BACKUP_SEMANTICS flag. Call SetPosixPerms.
857 * mount.cc (from_fstab): Open file with FILE_FLAG_BACKUP_SEMANTICS.
858 * script.cc (OutputLog::OutputLog): Call io_stream::mkpath_p with 0755
859 mode. Open file with FILE_FLAG_BACKUP_SEMANTICS.
860 * win32.cc (SetPosixPerms): New function to set POSIX-like permissions.
861 (nt_sec): New global NTSecurity variable.
862 (NTSecurity::setDefaultDACL): Open token with TOKEN_ADJUST_PRIVILEGES.
863 (NTSecurity::setDefaultSecurity): Enable SE_BACKUP_NAME and
864 SE_RESTORE_NAME privileges if available.
865 * win32.h (SetPosixPerms): Add prototype.
866 (class NTSecurity): Make everyOneSID and administratorsSID public.
869 2008-08-14 Corinna Vinschen <corinna@vinschen.de>
871 * mount.cc (unconvert_slashes): New inline function.
872 (skip_ws): New inline function.
873 (find_ws): New inline function.
874 (conv_fstab_spaces): New inline function.
875 (from_fstab_line): New function to read single line from fstab file.
876 (from_fstab): New function to read /etc/fstab file and fill mount
878 (read_mounts_nt): Call from_fstab after getting setup/rootdir from
879 registry. Only call add_usr_mnts if no fstab file found.
881 2008-08-13 Corinna Vinschen <corinna@vinschen.de>
883 * install.cc (Installer::installOne): Skip 46 bytes type tar package
886 2008-08-13 Corinna Vinschen <corinna@vinschen.de>
888 * install.cc (Installer::installOne): Use MoveFileExW on NT. Special
889 case for bug in Windows 2000.
890 * package_meta.cc (packagemeta::uninstall): Use wide char file functions
892 * win32.h (VersionInfo::major): New method.
893 (VersionInfo::minor): New method.
894 (OSMajorVersion): Define.
895 (OSMinorVersion): Define.
897 2008-08-12 Corinna Vinschen <corinna@vinschen.de>
899 Revamp for Cygwin 1.7.
900 * desktop.cc (make_cygwin_bat): Use wide char file functions on NT.
902 * filemanip.cc (tfx_chars): New char table for wide char transformation
903 of reserved FS chars to UNICODE private use area.
904 (transform_chars): New static function.
905 (mklongpath): New function to convert multibyte path to wide char
906 path with long path prefix.
907 * filemanip.h (mklongpath): Declare.
908 * ini.h (SETUP_INI_FILENAME): Use setup.ini filenames as defined in
909 real life (setup-2.ini/setup.ini).
910 (SETUP_BZ2_FILENAME): Ditto.
911 * install.cc (do_install_thread): Don't create registry mount points
912 on NT, rather create setup/rootdir entry.
913 * io_stream_cygfile.cc: Throughout use wide char file functions on NT.
914 (io_stream_cygfile::w_str): New method to create wide char path.
915 * io_stream_cygfile.h (class io_stream_cygfile): Remove lmode member.
916 Add wname member and w_str method.
917 * io_stream_file.cc: Throughout use wide char file functions on NT.
918 (io_stream_file::w_str): New method to create wide char path.
919 * io_stream_file.h (class io_stream_file): Remove lmode member.
920 Add wname member and w_str method.
921 * mkdir.cc (mkdir_p): Use wide char file functions on NT.
922 * mklink2.cc (mkcygsymlink_9x): Rename from mkcygsymlink. Make static.
923 (mkcygsymlink_nt): New static function.
924 (mkcygsymlink): Just call mkcygsymlink_9x or mkcygsymlink_nt dependent
926 * mount.cc (CYGWIN_INFO_CYGWIN_SETUP_REGISTRY_NAME): Define.
927 (remove1): Move to earlier point in file to avoid declaration.
928 (remove_mount): Ditto. Make static.
929 (create_install_root): New function to create setup/rootdir registry
931 (read_mounts_9x): Rename from read_mounts. Make static. Conditionalize
933 (add_usr_mnts): New static function.
934 (read_mounts_nt): Ditto, to read mounts on NT.
935 (read_mounts): Just call read_mounts_nt or read_mounts_9x dependent on
937 (set_root_dir): On NT, call read_mounts.
938 (cygpath): Only add slash for non-root mount to avoid multiple slashes
939 in resulting path (invalid in long path names).
940 * mount.h (find_mount): Drop declaration.
941 (remove_mount): Ditto.
942 (create_install_root): Add declaration.
943 (read_mounts): Accommodate new parameter.
944 * package_db.cc (chosen_db_task): New global variable.
945 * package_db.h (chosen_db_task): Declare.
946 * root.cc (check_if_enable_next): Don't use get_root_dir here to
947 avoid having to call save_dialog in RootPage::OnMessageCmd.
948 (GetDlgItemRect): New static inline function.
949 (SetDlgItemRect): Ditto.
950 (load_dialog): On NT, stretch "Install For" block to full dialog width
951 and hide "Default Text File Type" block.
952 (save_dialog): On NT set root_text always to IDC_ROOT_BINARY.
953 (RootPage::OnMessageCmd): Remove call to save_dialog.
954 (RootPage::OnNext): Initialize packagedb here the first time, to
955 avoid fetching wrong data from different previous installation.
956 * source.cc (save_dialog): Don't initialize packagedb here, rather
957 just memorize setting in chosen_db_task for the deferred initialization
960 2008-08-07 Dave Korn <dave.korn.cygwin@gmail.com>
962 Implement command-line selection of packages to install and make
963 unattended mode deal with any dialogs that might arise. A joint
964 effort synthesized from contributions by:
966 Dr. Frank Lee <rl201@cam.ac.uk>
967 Bryan Thrall <bryan.thrall@flightsafety.com>
968 Kohsuke Kawaguchi <kk@kohsuke.org>
969 Dave Korn <dave.korn.cygwin@gmail.com>
971 * install.cc (rebootneeded): Don't define statically here.
972 (do_install_thread): Let exit_msg reflect rebootneeded.
973 * main.cc (main): If rebootneeded, log it when exiting.
974 * msg.cc (mbox): In unattended_mode, choose and log default answer.
975 * package_db.cc (packagedb::fillMissingCategory): Iterate over all
976 packages adding those selected by packagemeta::isManuallyWanted to
977 base category so that command-line selections are installed.
978 * package_meta.cc (PackageOption): Add new StringOption to allow
979 command-line selection of packages to add to base install.
980 (packagemeta::isManuallyWanted): New function tests if package was
981 selected on command-line.
982 (packagemeta::addToCategoryBase): New function adds package to
984 * state.cc (rebootneeded): Define here non-static.
985 * state.h (rebootneeded): Declare here with extern linkage.
986 * threebar.cc (ThreeBarProgressPage::MaximizeDialog): Don't change
987 size when running in unattended mode.
989 2008-08-05 Christopher Faylor <me+cygwin@cgf.cx>
991 * UserSettings.cc (UserSettings::settingFileForLoad): Look locally for
992 settings before looking outside of current directory.
993 * choose.cc (ChooserPage::ChooserPage): Record the property sheet's
994 current show state via new passed in parameter.
995 * choose.h (ChooserPage::ChooserPage): Reflect change in argument list.
996 (ChooserPage::nCmdShow): Define new element.
997 * main.cc (main): Send current show state to Chooser.
998 * package_version.cc (packageversion::set_requirements): Increase
999 recursion check from 5 to 30.
1000 * propsheet.cc (PropSheetWndProc): Register hwndDlg with
1001 ThreeBarProgressPage.
1002 * threebar.cc (ControlAdjuster::ControlInfo): Initialize cmd_show_set.
1003 (ThreeBarProgressPage::MaximizeDialog): New function.
1004 (ThreeBarProgressPage::OnMessageApp): Call MaximizeDialog to maximize
1005 package selection screen and restore when done.
1006 * threebar.h (ThreeBarProgressPage::MaximizeDialog): Declare function.
1007 (ThreeBarProgressPage::cmd_show_set): Declare variable.
1008 (ThreeBarProgressPage::cmd_show): Declare variable.
1009 (ThreeBarProgressPage::ins_dialog): Declare variable.
1010 (ThreeBarProgressPage::SetHwndDialog): Define function.
1012 2008-07-22 Charles Wilson <cygwin@cwilson.fastmail.fm>
1014 Add support for .tar.lzma files (decompress only).
1016 * Makefile.am: Add new files.
1017 * compress.cc (compress::decompress): add support
1019 * compress_lzma.h: new file.
1020 * compress_lzma.cc: new file.
1021 * filemanip.cc (find_tar_ext): add support for
1023 * install.cc (Installer::installOne): update comments.
1024 * lzma-sdk/LzmaDec.h: new file.
1025 * lzma-sdk/LzmaDec.c: new file.
1026 * lzma-sdk/Types.h: new file.
1028 2008-07-08 Charles Wilson <cygwin@cwilson.fastmail.fm>
1030 * compress.cc (compress::decompress): clean up concrete
1031 decompressor objects on failure -- but in that case, do
1032 NOT destroy original io_stream.
1033 * compress_bz.h (compress_bz::release_original): new method.
1034 (owns_original): new member variable.
1035 * compress_bz.cc (compress_bz::release_original): new method.
1036 (compress_bz::compress_bz): take ownership of parent by default.
1037 (compress_bz::~compress_bz): only delete original if
1038 owns_original is true.
1039 * compress_gz.h (compress_gz::release_original): new method.
1040 (owns_original): new member variable.
1041 * compress_gz.cc (compress_gz::release_original): new method.
1042 (compress_gz::construct): take ownership of parent by default.
1043 (compress_gz::~compress_gz): only delete original if
1044 owns_original is true.
1046 2008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
1048 * configure.in, gpg-error-config-fake: Revert previous removal.
1050 2008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
1052 * net.cc: Correct stray CRLF.
1054 2008-06-25 Dave Korn <dave.korn.cygwin@gmail.com>
1056 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Remove nasty hack.
1057 * gpg-error-config-fake: Delete file obsoleted by de-hackification.
1059 2008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
1061 * configure.in: Disable shared library builds.
1063 2008-06-24 Christopher Faylor <me+cygwin@cgf.cx>
1065 * Makefile.am: Make and install libraries into common location and use
1067 * configure.in: Find gpg-error-config in the libgpg-error/src
1068 subdirectory rather than using the host system's version. Set the
1069 prefix and exec_prefix to a common location for the subdirs so that
1070 useful files will be installed in a common location.
1072 2008-06-22 Dave Korn <dave.korn.cygwin@gmail.com>
1074 Merged across diffs between setup_crypto_branch_branchpoint and
1075 setup_crypto_branch_mergepoint2 from setup_crypto_branch.
1077 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
1078 KeysSetting.h, gpg-error-config-fake, cygwin.pub, cyg-pubkey.h,
1079 gpg-key-to-s-expr.sh: New files.
1080 * ini.cc, ini.h, resource.h, res.rc, netio.cc, Makefile.am,
1081 configure.ac, libgetopt++/src/OptionSet.cc: Modified files.
1083 2008-06-21 Dave Korn <dave.korn.cygwin@gmail.com>
1085 * ini.cc (do_remote_ini): Revert misbegotten removal of
1086 not-always-superfluous-after-all added slash in URLs.
1088 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
1090 * gpg-packet.h (GPG_KEY_SEXPR_BUF_SIZE): Move from here ...
1091 * crypto.h (GPG_KEY_SEXPR_BUF_SIZE): ... to here.
1092 (GPG_KEY_MAX_COEFF_SIZE): Add related definition.
1094 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
1096 * gpg-packet.cc (walk_packets_1): Check packet length field is
1097 valid sane and possible to avoid malicious manipulation.
1098 * ChangeLog: Corrected date on previous commit.
1100 2008-06-18 Dave Korn <dave.korn.cygwin@gmail.com>
1102 * crypto.cc (add_key_from_sexpr): Use real buffer size, not debug
1105 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1107 * crypto.cc (verify_ini_file_sig): Actually set init-once flag!
1109 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1111 * crypto.cc (KeepUntrustedKeysOption): Fix helpstring punctuation.
1113 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1115 * crypto.cc (verify_ini_file_sig): Fix two minor logic errors.
1117 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1119 * ini.h (current_ini_sig_name): Declare extern.
1120 * ini.cc (current_ini_sig_name): New variable.
1121 (NoVerifyOption): New boolean option.
1122 (do_remote_ini): If sig verification not disabled, attempt to
1123 download the matching sig file for any setup.bz2 or setup.ini
1124 and use it to verify or discard the download.
1126 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1128 * resource.h (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Reserve IDs for
1129 two new message strings.
1130 * res.rc (IDS_SIG_INVALID, IDS_CRYPTO_ERROR): Define the text.
1132 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1134 * Makefile.am (setup_SOURCES): Add new files crypto.cc, crypto.h,
1135 cyg-pubkey.h, gpg-packet.cc, gpg-packet.h. KeysSetting.cc and
1136 KeysSetting.h to the build.
1137 * crypto.cc, crypto.h, gpg-packet.cc, gpg-packet.h, KeysSetting.cc,
1138 KeysSetting.h: New files. Adds gpg sig verification support.
1140 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1142 * Makefile.am (DIST_SUBDIRS, SUBDIRS): Add libgpg-error and
1144 (AM_CPPFLAGS): Add -I paths to generated headers in both and to
1145 shipped headers in libgcrypt.
1146 (setup_LDADD): Add libgpg-error.a and libgcrypt.a to final link.
1148 * configure.in (ac_cv_path_GPG_ERROR_CONFIG): Preload into cache
1149 to fake out libgcrypt configure process.
1150 (AC_CONFIG_SUBDIRS): Add libgpg-error/ and libgcrypt/
1152 * gpg-error-config-fake: New shell script to redirect libgcrypt
1153 sub-configure into looking for newly-built libgpg-error.
1155 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1157 * setup/libgpg-error/: Fresh import of upstream sources of
1158 libgpg-error-1.6.tar.bz2 from http://www.gnupg.org/
1159 * setup/libgcrypt/: Fresh import of upstream sources of
1160 libgcrypt-1.4.1.tar.bz2 from http://www.gnupg.org/
1162 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1164 * netio.cc (NetIO::set_url): Avoid double-free bug on delete
1165 by setting path to a strdup of url rather than using the same
1166 pointer value twice.
1168 2008-06-16 Dave Korn <dave.korn.cygwin@gmail.com>
1170 * cygwin.pub: Add reference copy of Cygwin setup signing key.
1171 * gpg-key-to-s-expr.sh: New bash script. Outputs textual
1172 representation of public key in s-expr format.
1173 * cyg-pubkey.h: New header generated by the above from Cygwin
1174 setup signing key. Currently needs manual regeneration if key
1177 2008-04-16 Brian Dessent <brian@dessent.net>
1179 * mount.cc: Include malloc.h.
1180 (is_admin): Use alloca instead of a VLA in case
1181 GetTokenInformation is sensitive to alignment.
1183 2008-04-15 Brian Dessent <brian@dessent.net>
1185 * mount.cc (is_admin): Get explicit size of required buffer by
1186 calling GetTokenInformation first with NULL.
1188 2008-04-10 Brian Dessent <brian@dessent.net>
1190 * Makefile.am (setup_LDFLAGS): Make sure static libbz2 and zlib
1193 2008-04-09 Brian Dessent <brian@dessent.net>
1195 * README: flex and bison are required when building from CVS.
1197 2008-04-08 Brian Dessent <brian@dessent.net>
1199 * Makefile.am (snapshot): Provide default value of ${cygwinsite}
1202 2008-04-08 Brian Dessent <brian@dessent.net>
1204 * Makefile.am (release): Use -f so that "make release" works
1205 when existing binaries of the same name exist.
1207 2008-04-08 Brian Dessent <brian@dessent.net>
1209 * res.rc (IDD_SPLASH): Update copyright years on splash page.
1211 2008-04-08 Brian Dessent <brian@dessent.net>
1214 * install.cc (Installer::installOne): Cope with compressed
1215 0-byte dummy packages. Fix progress bar update bug introduced
1216 in earlier refactoring.
1218 2008-04-08 Brian Dessent <brian@dessent.net>
1222 2008-04-08 Brian Dessent <brian@dessent.net>
1224 Various warning/header cleanups necessary for clean gcc 4.3 build.
1225 * ConnectionSetting.cc: Include stdlib.h.
1226 * LogFile.cc: Ditto.
1227 * Makefile.am: Don't hardcode paths to MinGW libz and libbz2.
1228 * PickView.cc: Include limits.h.
1229 * String++.cc: Include string.h.
1230 * archive_tar.cc (archive_tar::next_file_name): Silence nested-if
1232 * autoload.c: Switch back to .text section before emiting
1234 * choose.cc: Include stdlib.h and algorithm.
1235 * compress_gz.cc: Include memory.h and malloc.h.
1236 * filemanip.cc: Include string.h.
1237 (parse_filename): Silence nested-if warning.
1238 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Silence warning.
1239 * package_db.cc: Include algorithm.
1240 * site.cc (get_site_list): Silence warning.
1241 * win32.cc: Include memory.
1242 * csu_util/MD5Sum.cc: Include string.h.
1244 2008-03-02 Dave Korn <dave.korn@artimi.com>
1246 * install.cc (Installer::installOne): Accept new HWND argument
1247 from caller and pass it to MessageBox calls so that MB_TASKMODAL
1249 (check_for_old_cygwin): Likewise.
1250 (do_install_thread): Pass owner's HWND (from thread context) when
1253 2008-02-23 Dave Korn <dave.korn@artimi.com>
1255 * cygpackage.cc (cygpackage::getfirstfile): Guard against trying to
1256 construct std::string from NULL returned by io_stream::gets when the
1257 stream decompressor fails on a corrupt *.lst.gz file.
1259 2008-02-21 Dave Korn <dave.korn@artimi.com>
1261 * geturl.cc (progress): Correct SI unit notation.
1263 2008-02-01 Vincent Privat <vincent.privat@gmail.com>
1265 * net.cc (OnInit): New StringOption (ProxyOption)
1266 This new option (-p) allows to call setup.exe with a proxy
1267 in its command-line arguments.
1269 2007-07-31 Brian Dessent <brian@dessent.net>
1271 * ini.cc (do_remote_ini): Fix crash due to double free of ini_file.
1273 2007-07-30 Brian Dessent <brian@dessent.net>
1276 * configure.in (AM_INIT_AUTOMAKE): Enable more automake warnings.
1277 * Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
1278 (CLEANFILES): Add. Minor portability tweaks.
1279 * tests/Makefile.am (INCLUDES): Use AM_CPPFLAGS instead.
1280 * archive.cc (archive::extract): Try to be more compatible when
1282 * compress_bz.cc: Fix whitespace throughout.
1283 (compress_bz::~compress_bz): Ensure that underlying io_stream's dtor is
1285 * install.cc (Installer::installOne): Refactor.
1286 * package_db.cc (ConnectedLoopFinder::doIt): Move some log spewage into
1287 setup.log.full from setup.log.
1288 (packagedb::connectedBegin): Ditto. Consolidate log output to one line.
1290 2007-07-02 Brian Dessent <brian@dessent.net>
1294 2007-06-26 Brian Dessent <brian@dessent.net>
1296 * Makefile.am (release): Drop inconsistent use of $(EXEEXT). Leave an
1297 untouched copy of setup.exe so that later make invocations don't
1298 unnecessarily rebuild it.
1299 (snapshot): Fix typo.
1300 * install.cc (md5_one): Don't try to check packages whose
1301 pkgsource.Cached () is NULL, as with those whose download failed.
1303 2007-06-26 Brian Dessent <brian@dessent.net>
1305 * CHANGES: Update to reflect release branch.
1307 2007-06-26 Brian Dessent <brian@dessent.net>
1309 * CHANGES: Make current.
1311 2007-05-30 Brian Dessent <brian@dessent.net>
1313 * find.h (class Find): Make _start_dir non-const.
1314 * find.cc (Find::Find): Append a trailing slash to _start_dir only if
1315 it does not already contain one.
1316 (Find::accept): Use the previously stored value of _start_dir rather
1317 than unconditionally appending a slash.
1319 2007-05-29 Brian Dessent <brian@dessent.net>
1321 * Makefile.am: No need to specify the default value of --preprocessor
1322 to windres. Rework the automatic version extraction rules so that the
1323 source tarball is generated with the proper name and directory instead
1324 of setup-0. Update snapshot rule to also upload a copy of the binary
1325 with debugging symbols still present.
1327 2007-05-29 Brian Dessent <brian@dessent.net>
1329 This is a general tidying up/modernization of the build infrastructure.
1330 Renaming the lexer and parser to .ll and .yy allows using automake's
1331 builtin support for flex and bison with C++ sources, and libinilex is a
1332 slightly cleaner way of omitting -Werror.
1334 * Makefile.am (AUTOMAKE_OPTIONS): Move to AM_INIT_AUTOMAKE.
1335 (AM_YFLAGS): Define.
1336 (AM_LFLAGS): Define.
1337 (INCLUDES): Remove redundant mingw directory.
1338 (EXTRA_DIST): Adjust for newly named lexer/parser.
1339 (BUILT_SOURCES): Ditto.
1340 (inilint_LDADD): Ditto.
1341 (inilint_SOURCES): Ditto.
1342 (setup_LDADD): Ditto.
1343 (setup_SOURCES): Ditto.
1344 (iniparse.cc): Remove custom rules.
1346 * configure.in: Update quoting and use modern form of AC_INIT and
1348 * inilex.l: Rename from this ...
1349 * inilex.ll: ... to this.
1350 * iniparse.y: Rename from this ...
1351 * iniparse.yy: ... to this.
1353 2007-05-29 Brian Dessent <brian@dessent.net>
1355 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
1356 Remove error_buf and error_count initializers.
1357 (IniParseFindVisitor::visitFile): Store filename in current_ini_name.
1358 Use yyerror_count and yyerror_messages in place of removed error_count
1359 and error_buf members.
1360 * IniParseFindVisitor.h (class IniParseFindVisitor): Remove error_buf
1361 and error_count members.
1362 * ini.cc: Include io_stream_memory.h. Remove file static variables
1363 error_buf, error_count, and ini_filename.
1364 (GuiParseFeedback::progress): Remove some verbose log spam.
1365 (do_remote_ini): Recode .ini-fetching logic to properly display parse
1366 errors, and to account for corrupt bzip2 files.
1367 (yyerror): Moved elsewhere.
1368 (fprintf): Delete unused function.
1369 * ini.h: Remove useless __cplusplus guard. Declare extern variables
1370 current_ini_name, yyerror_messages, and yyerror_count.
1371 * inilex.l: Add current_ini_name, yyerror_messages, and
1373 (ini_init): Initialize new variables.
1375 (yyerror): Reimplement using std::string and relocate from ini.cc.
1376 * io_stream.cc (io_stream::copy): Add clarifying comment.
1378 2007-05-04 Igor Peshansky <pechtcha@cs.nyu.edu>
1380 * resource.h (IDC_STATIC_HEADER): New control id.
1381 * res.rc (IDD_SPLASH): Adjust the copyright.
1382 (IDD_DESKTOP): Make header text accessible as a separate control.
1383 * desktop.cc (set_status): Use eset() instead of SetWindowText().
1384 (load_dialog): Disable checkboxes and change dialog text in
1386 (DesktopSetupPage::OnInit): Disable checkboxes in download-only
1388 * threebar.cc (ThreeBarProgressPage::OnMessageApp): Deprecate the
1389 default fallthrough.
1390 * download.cc (do_download_thread): Explicitly return the next
1393 2007-04-19 Max Bowsher <maxb1@ukf.net>
1395 * configure.in: Turn inilint default build off again, since I cannot
1398 2007-04-19 Max Bowsher <maxb1@ukf.net>
1400 * configure.in: Make inilint built by default.
1402 2007-04-19 Max Bowsher <maxb1@ukf.net>
1404 * inilintmain.cc: Fix multiple compile errors.
1406 2007-04-19 Max Bowsher <maxb1@ukf.net>
1408 * Makefile.am: Make inilint use same warnonly-inilex workaround that
1411 2007-03-29 Igor Peshansky <pechtcha@cs.nyu.edu>
1413 * LogFile.cc (LogFile::exit): Write exit_msg directly to log, without
1415 * resource.h (IDC_DESKTOP_SEPARATOR,IDC_STATUS_HEADER,IDC_STATUS): New
1417 * res.rc (IDD_DESKTOP): Change the caption. Add status information.
1418 * desktop.h (DesktopSetupPage::DesktopSetupPage): Define constructor
1419 in the implementation.
1420 * desktop.cc (DesktopControlsInfo): Position specifiers for status
1422 (DesktopSetupPage::DesktopSetupPage): Register position specifiers.
1423 (set_status): New static method.
1424 (load_dialog): Set status information, if available.
1425 (DesktopSetupPage::OnInit): Set status header font.
1427 2007-03-01 Brian Dessent <brian@dessent.net>
1429 * ini.h (SETUP_INI_FILENAME): Rename setup_9x.ini to setup_legacy.ini.
1430 (SETUP_BZ2_FILENAME): Likewise.
1432 2007-02-27 Brian Dessent <brian@dessent.net>
1434 * ini.h (SETUP_INI_FILENAME): Add define.
1435 (SETUP_BZ2_FILENAME): Add define.
1436 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use
1437 above macros to parameterize setup.ini filename.
1438 * fromcwd.cc (SetupFindVisitor::visitFile): Ditto.
1439 * ini.cc (do_remote_ini): Ditto.
1440 * Makefile.am (setup_SOURCES): Add win32.cc.
1441 * autoload.c: Include windows.h directly instead of win32.h so that
1442 win32.h can contain C++.
1443 * desktop.cc (verinfo): Delete.
1444 (make_link): Use IsWindowsNT to check for NT instead of verinfo.
1445 (DesktopSetupPage::OnInit): Likewise.
1446 * mount.cc (is_admin): Likewise.
1447 * script.cc (init_run_script): Likewise.
1448 * main.cc (class SIDWrapper, SIDWrapper::SIDWrapper,
1449 SIDWrapper::~SIDWrapper, SIDWrapper::theSID, class HANDLEWrapper,
1450 HANDLEWrapper::HANDLEWrapper, HANDLEWrapper::~HANDLEWrapper,
1451 HANDLEWrapper::theHANDLE, class TokenGroupCollection,
1452 TokenGroupCollection::TokenGroupCollection,
1453 TokenGroupCollection::~TokenGroupCollection,
1454 TokenGroupCollection::populate, TokenGroupCollection::find,
1455 class NTSecurity, set_default_sec, NTSecurity::NoteFailedAPI,
1456 NTSecurity::NTSecurity, NTSecurity::failed,
1457 NTSecurity::initialiseEveryOneSID, NTSecurity::setDefaultDACL,
1458 NTSecurity::setDefaultSecurity): Remove implementation of these
1459 classes from this file and into new file win32.cc and existing win32.h.
1460 (main): Fix whitespace and formatting per GNU coding standards.
1461 * res.rc (IDS_SETUPINI_MISSING): Parameterize filename with %s.
1462 * win32.cc: New file containing methods removed from main.cc as well
1463 as new class VersionInfo methods.
1464 * win32.h: Include <string> for std::string.
1465 (class SIDWrapper, class HANDLEWrapper, class TokenGroupCollection,
1466 class NTSecurity): Add classes removed from main.cc.
1467 (class VersionInfo): Add new class.
1469 (IsWindowsNT): Define.
1471 2007-02-20 Brian Dessent <brian@dessent.net>
1473 * README: Modernize list of required packages, and mention doconfigure.
1475 2007-02-17 Cesar Strauss <cstrauss@cea.inpe.br>
1477 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
1478 Initialize the version and operator fields of the newly created
1479 PackageSpecification object, so setup can pick the correct source
1482 2007-02-17 Brian Dessent <brian@dessent.net>
1484 * script.cc (Script::run): Check for existance of script file and
1485 return without doing anything if it does not exist.
1487 2006-12-26 Max Bowsher <maxb1@ukf.net>
1489 * IniDBBuilder.h (IniDBBuilder): Make this class abstract.
1490 * IniDBBuilder.cc: Delete file.
1491 * Makefile.am (inilint_SOURCES, setup_SOURCES): Remove IniDBBuilder.cc.
1493 2006-12-26 Max Bowsher <maxb1@ukf.net>
1495 Add a shell script that documents/centralizes the standard configure
1498 * doconfigure: New file.
1499 * Makefile.am (EXTRA_DIST): Add doconfigure.
1501 2006-11-28 Igor Peshansky <pechtcha@cs.nyu.edu>
1503 * install.cc (Installer::installOne): If file is in use, ask the user
1504 to stop processes and retry.
1505 (MB_RETRYCONTINUE, IDCONTINUE): New macros.
1506 (hMsgBoxHook): New static field.
1507 (CBTProc): New window hook function.
1508 (_custom_MessageBox): New function.
1509 * CHANGES: Update with the above.
1511 2006-10-12 Igor Peshansky <pechtcha@cs.nyu.edu>
1513 * desktop.cc (make_cygwin_bat,save_icon): Capitalize filename.
1515 2006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1517 * package_version.cc (packageversion::scan): Catch and handle
1518 validation exception.
1520 2006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1522 * cygpackage.h (filesize): Remove unused field.
1523 (cygpackage::createInstance): Ditto.
1524 * cygpackage.cc (cygpackage::createInstance): Ditto.
1525 * package_db.cc (packagedb::packagedb): Remove unused variables.
1526 Simplify parsing of installed.db.
1528 2006-08-06 Igor Peshansky <pechtcha@cs.nyu.edu>
1530 * desktop.cc (DesktopSetupPage::OnInit): Remove stray MessageBox.
1532 2006-05-24 Igor Peshansky <pechtcha@cs.nyu.edu>
1534 * PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView.
1535 * PickView.h (PickView::DrawIcon): Move from PickPackageLine.
1536 (PickView::icon_dc,PickView::bm_icon): New instance field.
1537 (PickView::rect_icon,PickView::bg_fg_brush): Ditto.
1538 * PickCategoryLine.cc (PickCategoryLine::paint): Use
1539 PickView::DrawIcon() instead of BitBlt().
1540 * PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView.
1541 (PickPackageLine::paint): Use PickView::DrawIcon().
1542 * PickView.cc (PickView::~PickView): Delete GDI objects.
1543 (PickView::init): Create icon drawing context.
1544 (PickView::DrawIcon): New function. Use system default colors to
1546 (PickView::paint): Set background color instead of using transparent
1547 mode. Create system-colored brush.
1549 2006-04-25 Brian Dessent <brian@dessent.net>
1551 * COPYING: New file (GPL).
1552 * Makfile.am (EXTRA_DIST): Add COPYING.
1554 2006-04-17 Max Bowsher <maxb1@ukf.net>
1556 * String++.cc, String++.h: Finally, it's time for the long-awaited
1557 departure of 'class String' from this world. setup.exe can now
1558 happily claim to follow the sane path of using just one general
1559 purpose string class throughout :-)
1561 2006-04-17 Max Bowsher <maxb1@ukf.net>
1563 * cygpackage.cc, cygpackage.h, package_version.cc, package_version.h:
1564 Do some String to std::string migration.
1566 2006-04-17 Max Bowsher <maxb1@ukf.net>
1568 * package_meta.cc, package_meta.h, package_source.cc,
1569 package_source.h: Do some String to std::string migration.
1570 * package_db.cc: Small tweak to assist with the above.
1572 2006-04-17 Max Bowsher <maxb1@ukf.net>
1574 * PickView.cc, PickView.h, package_db.cc, package_db.h:
1575 Do some String to std::string migration.
1576 * package_meta.h: Change a couple of types to assist with the above.
1578 2006-04-17 Max Bowsher <maxb1@ukf.net>
1580 * IniDBBuilder.cc, IniDBBuilder.h, IniDBBuilderPackage.cc,
1581 IniDBBuilderPackage.h, PickLine.h, PickPackageLine.cc:
1582 Do some String to std::string migration.
1584 2006-04-16 Max Bowsher <maxb1@ukf.net>
1586 * FindVisitor.cc, FindVisitor.h, IniParseFindVisitor.cc,
1587 IniParseFindVisitor.h, ScanFindVisitor.cc, ScanFindVisitor.h, find.cc,
1588 find.h, fromcwd.cc, ini.cc, ini.h, iniparse.y, postinstall.cc:
1589 Do some String to std::string migration.
1591 2006-04-16 Max Bowsher <maxb1@ukf.net>
1593 * IOStreamProvider.h, archive.cc, archive.h, archive_tar.cc,
1594 archive_tar.h, io_stream.cc, io_stream.h, io_stream_cygfile.cc,
1595 io_stream_cygfile.h, io_stream_file.cc, io_stream_file.h:
1596 Do some String to std::string migration.
1598 2006-04-16 Max Bowsher <maxb1@ukf.net>
1600 * desktop.cc, download.cc, install.cc, mount.cc, mount.h, script.cc,
1601 script.h: Do some String to std::string migration.
1603 2006-04-16 Max Bowsher <maxb1@ukf.net>
1605 * category.cc: Remove source file that contained no code!
1606 * category.h: Delete, moving the single useful line to...
1607 * package_meta.h: ...here. Remove category.h include.
1608 * choose.cc, package_db.h, package_meta.cc: Remove category.h include.
1609 * Makefile.am: Remove references to removed files.
1611 2006-04-15 Max Bowsher <maxb1@ukf.net>
1613 * ConnectionSetting.cc, ConnectionSetting.h, Exception.cc,
1614 Exception.h, IniParseFeedback.cc, IniParseFeedback.h, LogFile.cc,
1615 LogFile.h, LogSingleton.h, PackageSpecification.cc,
1616 PackageSpecification.h, SourceSetting.cc, SourceSetting.h,
1617 UserSettings.cc, UserSettings.h, dialog.cc, dialog.h, diskfull.cc,
1618 diskfull.h, filemanip.cc, filemanip.h, inilintmain.cc, localdir.cc,
1619 main.cc, nio-file.cc, nio-http.cc, prereq.cc, prereq.h, proppage.cc,
1620 proppage.h, site.cc, site.h, splash.cc, state.cc, state.h, window.cc,
1621 window.h: Do some String to std::string migration.
1623 2006-04-15 Max Bowsher <maxb1@ukf.net>
1625 * String++.cc, String++.h
1626 (new_cstr_char_array, format_1000s): Migrate String to std::string.
1627 (casecompare_lt_op, std::string operator+): New.
1629 2006-04-06 Max Bowsher <maxb1@ukf.net>
1631 * String++.h, String++.cc
1632 (String::replace): Remove - usused.
1633 (String::find): Remove - semantics do not match std::string.
1635 * root.cc (directory_is_rootdir): Switch to std::string.find().
1636 * script.cc (Script::baseName): Rewrite use of String.find().
1638 2006-03-30 Max Bowsher <maxb1@ukf.net>
1640 * String++.cc (replace): New function to take the place of one form
1641 of String::replace method.
1642 * String++.h (replace): Declare.
1643 (String::replace): Make private.
1645 * desktop.cc (make_cygwin_bat): Use new function.
1646 * filemanip.cc (backslash): Use simple loop in place of
1648 * filemanip.h (backslash): Change signature to use std::string in
1651 2006-03-30 Max Bowsher <maxb1@ukf.net>
1653 * String++.cc, String++.h (casecompare): New function replacing
1654 String.casecompare to increase parity with std::string.
1655 (String::casecompare): Make private.
1657 * ConnectionSetting.cc, IniDBBuilderPackage.cc,
1658 IniParseFindVisitor.cc, LogFile.cc, PackageSpecification.cc,
1659 PickView.cc, SourceSetting.cc, String++.cc, String++.h, fromcwd.cc,
1660 io_stream.cc, mount.cc, package_db.cc, package_source.h,
1661 package_version.cc, prereq.h, script.cc:
1662 Use casecompare in place of String::casecompare.
1664 2006-03-30 Max Bowsher <maxb1@ukf.net>
1666 * String++.cc, String++.h: Remove String(int) constructor, which
1667 was causing dangerously bizarre implicit conversions, and was a point
1668 of disparity between String and std::string.
1669 (stringify): New function to replace functionality removed above.
1671 * PickView.cc (PickView::init_headers),
1672 archive_tar.cc (archive_tar::next_file_name),
1673 cygpackage.cc (cygpackage::setCanonicalVersion):
1674 Make explicit and call out with a FIXME some bizarre behaviour.
1676 * ScanFindVisitor.cc (ScanFindVisitor::visitFile),
1677 filemanip.cc (base), iniparse.y,
1678 threebar.cc (ThreeBarProgressPage::SetBar2):
1679 Make simple adaptations to the changed API.
1681 2006-03-14 Igor Peshansky <pechtcha@cs.nyu.edu>
1683 * PickView.cc (PickView::setViewMode): Auto-expand category if
1684 its name starts with a dot.
1686 2006-03-14 Dave Korn <dave.korn@artimi.com>
1688 * String++.cc (new_cstr_char_array): Handle null input correctly.
1690 2006-03-10 Christopher Faylor <cgf@timesys.com>
1692 * res.rc: Update copyright.
1693 (IDS_MIRROR_LST): Use cygwin.com for mirror list, not
1695 * site.cc (NOSAVE1): Use preferred name of sourceware site.
1696 (NOSAVE2): sourceware.cygnus.com -> sources.redhat.com.
1697 (NOSAVE1_LEN): Use just-defined name to determine length.
1698 (NOSAVE2_LEN): Ditto.
1699 (NOSAVE3_LEN): Ditto.
1701 2006-03-10 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1703 * res.rc (IDD_DROPPED): New dialog.
1704 * resource.h (IDD_DROPPED): New dialog-id.
1705 (IDC_DROP_MIRRORS, IDC_DROP_NOWARN): New control-ids.
1706 * site.cc: Add enum for response on dropped mirrors.
1707 (cache_is_usable, cache_needs_writing): New bools.
1708 (cache_warn_urls): New string.
1709 (cached_site-list, dropped_site_list): New SiteLists.
1710 (site_list_type::init, site_list_type::site_list_type): Change to four
1712 (site_list_type::site_list_type, site_list_type::operator=) Copy
1713 servername, area and location.
1714 (load_site_list): New function, broken out of get_site_list. Support
1715 four-parameter site_list_type.
1716 (get_site_list): Break out load_site_list. Move reading cache earlier.
1717 Don't write new cache. Set flags to record cache state. Load both
1718 all_site_list and cached_site_list.
1719 (SiteSetting::registerSavedSite): Use four-parameter site_list_type.
1720 (drop_proc, check_dropped_mirrors, write_cache_list, save_cache_file):
1722 (SitePage::OnNext): Check for dropped mirrors and save cache as
1724 (SitePage::OnMessageCmd): Use four-parameter site_list_type.
1726 (site_list_type::init, site_list_type::site_list_type): Change to four
1728 (site_list_type): Add servername, area and location members.
1730 2006-03-09 Igor Peshansky <pechtcha@cs.nyu.edu>
1732 * script.cc (Script::run): Fix inverted test for abnormal exit.
1734 2006-03-09 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
1735 Max Bowsher <maxb1@ukf.net>
1737 Provide indication of site that a file is being downloaded from.
1739 * geturl.cc: Use std::string instead of String throughout.
1740 (init_dialog): Put more information into GUI.
1741 Remove unused 'owner' parameter and change all callers.
1742 (progress): Remove spurious \n characters from GUI.
1743 * geturl.h: Use std::string instead of String throughout.
1744 * res.rc (IDD_INSTATUS): Use SS_ENDELLIPSIS.
1746 2006-03-09 Max Bowsher <maxb1@ukf.net>
1748 * Makefile.am (EXTRA_DIST): Add tree-minus.bmp and tree-plus.bmp.
1750 2006-01-20 Bryan Thrall <bryan.thrall@flightsafety.com>
1752 * source.cc (SourcePage::OnActivate): Command line takes precedence
1753 over last user selection.
1755 2005-11-30 Max Bowsher <maxb1@ukf.net>
1757 * res.rc (IDD_ROOT, IDD_LOCAL_DIR): Rearrange some controls a little,
1758 in response to suggestion from Carl Karsten.
1760 2005-11-30 Max Bowsher <maxb1@ukf.net>
1762 * site.h, site.cc: Use std::string in preference to String.
1763 (site_list_type::init): Convert some painful raw C string work to
1764 STL std::string work. Stop totally ignoring the result of this
1765 calculation, implementing the (somewhat weird) sort order for sites
1766 that was apparently indented for ages.
1768 2005-10-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1770 * io_stream.cc (url_scheme_not_registered): New macro.
1771 (io_stream::open): Better log message on error.
1772 (io_stream::mkpath_p,io_stream::remove,io_stream::mklink): Ditto.
1773 (io_stream::move,io_stream::exists): Ditto.
1775 2005-10-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1777 * site.cc (get_site_list): Default to empty mirror list if
1778 server unavailable and none cached, to allow using preferred
1781 2005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1783 * package_db.cc (packagedb::packagedb): Remember missing package
1786 2005-09-29 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1788 * site.cc (get_site_list): Store mirror list locally.
1789 Use local copy if unable to download.
1791 2005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1793 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
1794 Better log message on error.
1796 2005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1798 * script.cc (Script::isAScript): Fix string comparison.
1800 2005-09-27 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1802 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Reconnect on FTP timeout.
1804 2005-09-11 Masayuki FUJII <boochang@m4.kcn.ne.jp>
1806 * package_meta.cc (packagemeta::ScanDownloadedFiles): Don't use an
1807 invalid iterator. Fix whitespace.
1809 2005-09-09 Brian Dessent <brian@dessent.net>
1811 * CHANGES: Document recent updates.
1812 * choose.cc (ChooserPage::OnInit): Add new tooltip.
1813 * res.rc (IDD_CHOOSE): Remove 'administrative' from description.
1814 (IDS_HIDEOBS_TOOLTIP): Add new string for tooltip.
1815 * resource.h (IDS_HIDEOBS_TOOLTIP): Define.
1816 * window.cc (Window::ActivateTooltips): Fix whitespace. Set tooltip
1817 delay to 30 seconds.
1819 2005-09-09 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1821 * PickView.cc (PickView::paint): Set background mode to transparent.
1822 * PickCategoryLine.cc (PickCategoryLine::paint): Use bitwise AND to
1824 * PickPackageLine.cc (PickPackageLine::paint): Ditto.
1826 2005-09-01 Brian Dessent <brian@dessent.net>
1828 * package_meta.cc (packagemeta::uninstall): Remove support for
1829 undocumented and dangerous postremove script.
1831 2005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1833 * script.cc (run): Change to return the exit code or negative error.
1834 (Script::run): Ditto.
1835 (try_run_script): Receive both filename and extension and run only
1836 one script. Also return the exit code.
1837 * script.h (try_run_script): Change signature.
1838 (Script::run): Ditto.
1839 * postinstall.cc (RunScript::operator()): Change to return the exit
1840 code or negative error.
1841 * install.cc (Installer::preremoveOne): Pass extension to
1844 2005-09-01 Eric Blake <ebb9@byu.net>
1846 * script.cc (shells): Use /bin/bash, not sh, to allow upgrades to
1849 2005-09-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
1851 * PickView.h (PickView::size_col): New instance variable.
1852 * PickView.cc (pkg_headers, cat_headers): Add size column.
1853 (PickView::set_headers): Initialize size_col.
1854 (PickView::init_headers): Include width of size column.
1855 * PickPackageLine.cc (PickPackageLine::paint): Handle size_col.
1856 * String++.cc (format_1000s): New function.
1857 * String++.h (format_1000s): Declare new function.
1859 2005-09-01 Brian Dessent <brian@dessent.net>
1861 * Makefile.am (BASECXXFLAGS): Add -Wno-uninitialized to work around
1862 spurious warnings with gcc 3.4.4.
1864 2005-05-22 Brian Dessent <brian@dessent.net>
1866 * res.rc (IDD_CHOOSE): Change description to include administrative
1867 packages in addition to obsolete.
1869 2005-05-21 Brian Dessent <brian@dessent.net>
1871 * prereq.cc: New file.
1873 * tree-minus.bmp: Ditto.
1874 * tree-plus.bmp: Ditto.
1875 * Makefile.am: Add prereq.cc and prereq.h to build.
1876 * PickCategoryLine.cc (PickCategoryLine::paint): Add new parameter and
1877 refactor. Use bitmap for '+' and '-' indicators. Draw package lines
1878 column-wise for better drawing efficiency.
1879 (PickCategoryLine::click): Use previously calculated x value.
1880 * PickCategoryLine.h (PickCategoryLine::paint): Update prototype. Add
1882 * PickLine.h (PickLine:paint): Update prototype.
1883 * PickPackageLine.cc (PickPackageLine::DrawCheck): Remove.
1884 (PickPackageLine::DrawIcon): New function.
1885 (PickPackageLine::paint): Add parameter. Refactor completely for more
1887 * PickPackageLine.h (PickPackageLine::DrawIcon): Add prototype.
1888 (PickPackageLine::paint): Update prototype.
1889 (PickPackageLine::DrawCheck): Remove.
1890 * PickView.cc (pkg_headers): Remove unused 'slen' field, add new
1891 'needs_clip' field to signify if clipping is necessary for this column.
1892 (PickView::note_width): Fold long line. Refactor slightly for
1894 (PickView::set_view_mode): Remove.
1895 (PickView::cycleViewMode): New function.
1896 (PickView::setViewMode): Refactor completely. Incorporate functionality
1897 of clear_view() here instead. Simplify package selection into a single
1898 'for' loop rather than repeating code for each type.
1899 (isObsolete): New function, with second overloaded version.
1900 (PickView::setObsolete): New function.
1901 (PickView::insert_pkg): Do not show obsolete packages. Move
1902 declaration of 'db' lower. Fix whitespace.
1903 (PickView::insert_category): Do not show obsolete packages.
1904 (PickView::clear_view): Remove. Moved logic into 'setViewMode'.
1905 (PickView::scroll): Add additional parameter 'howmany' with default
1906 value of 1. Scroll by 'howmany' lines for SB_LINEDOWN and SB_LINEUP.
1907 (NUM_CATEGORY_COL_WIDTH): Define.
1908 (PickView::init_headers): Fix whitespace. Add comments. Ignore
1909 obsolete packages in width calculations. Add functionality to size
1910 'Category' column so that at least NUM_CATEGORY_COL_WIDTH categories
1911 are displayed for every package. Ensure that 'new_col' takes into
1912 account all possible labels.
1913 (PickView::PickView): Initialize showObsolete to false.
1914 (PickView::init): Remove unused bitmap bm_rtarrow. Add new bitmaps
1915 bm_treeplus and bm_treeminus. Use a macro for better readability.
1916 Fix whitespace formatting. Remove header computation from here, call
1918 (PickView::registerWindowClass): Remove unnecessary background brush.
1919 (PickView::WindowProc): Add support for WM_MOUSEWHEEL message
1920 processing. Fix indentation. Reformat for readability.
1921 (PickView::paint): Get the update region before calling BeginPaint.
1922 Fill the update region with the default colors. Do not do clipping
1923 here. Pass update region to the PickLine paint function instead.
1924 Free the update region when finished.
1925 (PickView::Create): Fix indentation.
1926 (PickView::defaultTrust): Ditto.
1927 (PickView::refresh): Add column recalculation logic here.
1928 * PickView.h: Fix indentation.
1929 (RTARROW_WIDTH): Remove unused define.
1930 (NEW_COL_SIZE_SLOP): Ditto.
1931 (TREE_INDENT): Define.
1932 (PickView::get_view_mode): Remove.
1933 (PickView::set_view_mode): Rename to setViewMode for consistency.
1934 (PickView::cycleViewMode): Add new function.
1935 (PickView::setObsolete): Ditto.
1936 (PickView::clear_view): Remove.
1937 (PickView::bm_treeplus): Define new member.
1938 (PickView::bm_treeminus): Ditto.
1939 (PickView::scroll): Add parameter.
1940 (PickView::Header::slen): Remove unused member.
1941 (PickView::Header::needs_clip): Define new member.
1942 (PickView::showObsolete): Ditto.
1943 (isObsolete): Add prototype, and for overloaded version as well.
1944 * choose.cc: Add include.
1945 (ChooserControlsInfo): Allow new checkbox to be resized.
1946 (ChooserPage::OnInit): Start dialog with 'Hide obsolete' checked.
1947 (ChooserPage::OnNext): Call the dependency checker, act accordingly.
1948 (ChooserPage::changeTrust): Notify dependency checker of current trust
1949 level when it changes.
1950 (ChooserPage::OnMessageCmd): Just call cycleViewMode instead when
1951 changing the view. Update the chooser when the user toggles the
1952 'hide obsolete' checkbox.
1953 (ChooserPage::OnMouseWheel): New function. Pass mouse wheel message
1955 * choose.h (OnMouseWheel): Add prototype.
1956 * main.cc: Add include.
1957 (main): Define and initialize the PrereqPage object. Add it into
1958 the property sheet list.
1959 * PropPage.cc (PropertyPage::DialogProc): Add support for WM_MOUSEWHEEL
1960 message processing in derived classes.
1961 (PropertyPage::OnMouseWheel): New function.
1962 * PropPage.h (PropertyPage::OnMouseWheel): Add prototype.
1963 * res.rc (IDD_LOCAL_DIR): Shorten edit box so that pushbutton is not
1965 (IDD_SITE): Provide static text with an ID so that it can be resized
1966 properly. Move pushbutton slightly to right so that it doesn't crowd
1968 (IDD_SPLASH): Change copyright displayed on spash screen to be generic
1969 since the actual list of contributors is long.
1970 (IDD_CHOOSE): Add checkbox. Resize other controls to accomodate.
1971 (IDD_PREREQ): New dialog.
1972 (SPIN): Delete duplicated bitmap resource.
1973 (IDB_RTARROW): Remove unused bitmap resource.
1974 (IDB_TREE_PLUS): Add.
1975 (IDB_TREE_MINUS): Ditto.
1976 (IDS_TRUSTPREV_TOOLTIP): Revise wording to be more concise.
1977 (IDS_TRUSTCURR_TOOLTIP): Ditto.
1978 (IDS_TRUSTEXP_TOOLTIP): Ditto.
1979 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
1980 * resource.h (IDD_PREREQ): Define.
1981 (IDB_RTARROW): Remove.
1982 (IDB_TREE_PLUS): Add, and renumber.
1983 (IDB_TREE_MINUS): Ditto.
1984 (IDC_SITE_USERURL): Define.
1985 (IDC_CHOOSE_HIDE): Ditto.
1986 (IDC_PREREQ_TEXT): Ditto.
1987 (IDC_PREREQ_EDIT): Ditto.
1988 (IDC_PREREQ_CHECK): Ditto.
1989 * site.cc (SiteControlsInfo): Ensure that 'User URL' static text is
1992 2005-05-14 Max Bowsher <maxb@ukf.net>
1994 "Type" field of packageversions was not even being filled in. Fix.
1996 * cygpackage.h, cygpackage.cc (cygpackage::createInstance):
1997 Make "type" a mandatory parameter of the constructor.
1998 * IniDBBuilderPackage.cc: Adjust callers.
2000 2005-05-14 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
2002 Fix behaviour of hardlinks in source packages.
2004 * archive.cc (archive::extract_file):
2005 Use prefixPath for link target on hardlinks.
2007 2005-05-14 Max Bowsher <maxb@ukf.net>
2009 Hopefully, solve the "preremove DLL dependency" bug, by running all
2010 preremove scripts before actually removing any files.
2013 (Installer::preremoveOne): New method. Run preremove scripts here.
2014 (Installer::replaceOne): Remove method.
2015 (num_replacements): Remove variable.
2016 (do_install_thread): Significantly rewrite.
2017 * package_meta.cc (packagemeta::uninstall):
2018 Do not run preremove script here.
2020 2005-05-14 Max Bowsher <maxb@ukf.net>
2022 * download.cc (do_download_thread):
2023 Do not use packageversion::changeRequested().
2024 * package_version.cc (packageversion::Type):
2025 Implement declared but previously unimplemented method.
2026 (packageversion::changeRequested, _packageversion::changeRequested):
2029 (packageversion::changeRequested, _packageversion::changeRequested):
2031 * install.cc (Installer::replaceOne): Simplify, return void, not int.
2032 (installOneSource): Rename to...
2033 (installOne): ...this. Change arguments and return type. Refactor.
2034 (install_one): Remove.
2035 (do_install_thread): Tidying up.
2037 2005-05-07 Max Bowsher <maxb@ukf.net>
2039 * download.cc (validateCachedPackage): Remove all MD5 checking code.
2040 It is not acceptable to check MD5 sums as part of simply answering
2041 whether a package exists in the local cache or not. It is too slow.
2042 MD5 sums always have been - and will continue to be - checked at
2044 (NoMD5Option): Remove this option, as the code it controls has been
2047 2005-05-07 Max Bowsher <maxb@ukf.net>
2049 * install.cc (md5_one): Make the MD5 checking done at install time
2050 display a progess GUI, as the MD5 checking done at other times does.
2052 2005-05-07 Max Bowsher <maxb@ukf.net>
2054 * resource.h, res.rc: Followup to recent de-MSVC-ification of
2055 resource.h, by removing a lot from res.rc, and the last few bits
2058 2005-05-05 Brian Dessent <brian@dessent.net>
2060 * choose.cc (ChooserPage::OnInit): Initialize tooltips for this
2063 * proppage.h (PropertyPage::makeClickable): Update prototype to
2064 reflect same argument name as function.
2066 * proppage.cc (PropertyPage::DialogProc): Remove redundant 'break'
2067 statements that follow 'return's. Add missing braces to case
2068 statements. Call handler for TTN_GETDISPINFO.
2070 * res.rc (IDS_TRUSTKEEP_TOOLTIP): Add new STRINGTABLE entry for
2072 (IDS_TRUSTPREV_TOOLTIP): Ditto.
2073 (IDS_TRUSTCURR_TOOLTIP): Ditto.
2074 (IDS_TRUSTEXP_TOOLTIP): Ditto.
2075 (IDS_TRUSTPREV_TOOLTIP): Ditto.
2076 (IDS_VIEWBUTTON_TOOLTIP): Ditto.
2078 * resource.h: Likewise, add identifiers for tooltip resources.
2080 * window.h: Add includes.
2081 (Window::TooltipHandle): Add new private data structure.
2082 (Window::TooltipStrings): Ditto.
2083 (Window::ActivateTooltips): Define new function to support tooltip
2085 (Window::SetTooltipState): Ditto.
2086 (Window::AddTooltip): Ditto.
2087 (Window::TooltipNotificationHandler): Ditto.
2089 * window.cc (Window::Window): Initialize handle to NULL.
2090 (Window::~Window): Call DestroyWindow on tooltip control if it was
2092 (Window::ActivateTooltips): New function to activate the tooltip
2094 (Window::SetTooltipState): New function to allow toggling of
2096 (Window::AddTooltip): New function that adds a tooltip to a given
2097 control in a given window. Also implement overloaded versions that
2098 provide simpler interface and the ability to use a string resource.
2099 (Window::TooltipNotificationHandler): New function to handle
2100 TTN_GETDISPINFO notification messages.
2102 2005-05-05 Brian Dessent <brian@dessent.net>
2104 * resource.h: Reorganize. Group by type, and give each its own
2105 range of IDs. Regenerate IDs accordingly.
2106 (IDD_CHOOSER): Remove obsolete and unused symbol.
2108 2005-05-05 Brian Dessent <brian@dessent.net>
2110 * root.h (class RootPage): Add missing virtual to OnMessageCmd.
2112 2005-05-05 Brian Dessent <brian@dessent.net>
2114 * root.cc (dialog_cmd): Remove. Use OnMessageCmd instead.
2115 (RootPage::Create): Accomodate above change.
2117 * root.h (class RootPage): Add prototype for OnMessageCmd.
2119 * res.rc (IDD_ROOT): Fix broken button groups. Correct the order of
2120 the controls and use of WS_GROUP so that the radio buttons act
2123 2005-05-05 Max Bowsher <maxb@ukf.net>
2125 Bulk rename of String++ member cstr_oneuse () to c_str () for
2126 similarity to std::string.
2129 * IniDBBuilderPackage.cc
2130 * IniParseFindVisitor.cc
2132 * PickCategoryLine.cc
2133 * PickPackageLine.cc
2149 * io_stream_cygfile.cc
2166 2005-05-05 Max Bowsher <maxb@ukf.net>
2168 Some String++ refactoring, setting out in the general direction of
2169 eventually just using the STL std::string, not our own class.
2171 * String++.cc (String::cstr, String::cstr () const): Remove.
2172 (new_cstr_char_array): New function.
2173 * String++.h: Sync with above.
2174 Remove irrelevant "class io_stream;" declaration.
2176 * cygpackage.h: Add "class io_stream;" declaration, now no longer
2177 being supplied by side-effect.
2179 * filemanip.cc: Remove unneeded includes, add "using namespace std;".
2180 (parse_filename): Exchange some awkward pointer manipulation for
2181 std::string usage. Use new_cstr_char_array ().
2182 * filemanip.h: Sync with above.
2183 (fileparse): Improve style of declaration.
2185 * io_stream_cygfile.cc (io_stream_cygfile::normalise):
2186 Use new_cstr_char_array ().
2187 * site.cc (site_list_type::init, get_site_list): Ditto.
2189 2005-05-05 Brian Dessent <brian@dessent.net>
2191 * ControlAdjuster.h (enum ControlPosition): Declare new resizing
2192 methods CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, and their
2195 * ControlAdjuster.cc (ControlAdjuster::ControlInfo::adjust):
2196 Implement CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, which are
2197 designed to resize elements in a two-column layout.
2199 * localdir.h (class LocalDirPage): Remove constructor implementation
2202 * localdir.cc (LocalDirPage::LocalDirPage): ...to here, and call
2203 AddControlsInfo on initialization.
2204 (static LocaldirControlsInfo): Add. Define sizing rules for dialog
2207 * proppage.h: Add includes.
2208 (PropertyPage::ClickableURL):
2209 Declare new storage type for internal use by class.
2210 (PropertyPage::urls): Likewise.
2211 (PropertyPage::urlWinProc): Add declaration.
2212 (PropertyPage::makeClickable): Likewise.
2214 * proppage.cc: Add includes.
2215 (PropertyPage::DialogProc): Implement handler for WM_CTLCOLORSTATIC
2216 message. Supports static controls that have been turned into
2217 clickable hyperlinks.
2218 (static PropertyPage::urls): Declare.
2219 (PropertyPage::makeClickable): Implement new member function that
2220 provides user interface for making text into clickable URLs.
2221 (PropertyPage::urlWinProc): Implement new private member function used
2222 as a windowproc for subclassing a static control.
2224 * resource.h (IDC_SPLASH_URL, IDC_FILEMODES_LINK, IDC_ROOTDIR_GRP,
2225 IDC_INSTALLFOR_GRP, IDC_ALLUSERS_TEXT, IDC_JUSTME_TEXT, IDC_MODE_GRP,
2226 IDC_MODE_TEXT, IDC_MODE_BIN, IDC_LOCALDIR_GRP, IDC_SPLASH_TEXT,
2227 IDC_SPLASH_ICON, IDC_SPLASH_COPYR): Add. Replaces anonymous
2228 IDC_STATIC ids, so that controls can be referenced by the resizer.
2230 * res.rc (IDD_LOCAL_DIR): Rearrange controls to match top-down order
2231 in the dialog. Fold long lines. Replace anonymous IDC_STATIC ids.
2232 (IDD_ROOT): Reorder in same manner. Replace anonymous IDC_STATIC ids.
2233 Add descriptive text of each option, and hyperlink for more
2234 information. Mark suggested choice as "(RECOMMENDED)". Swap order of
2235 'unix'/'dos' radio buttons so that recommended choice is first in both
2237 (IDD_SPLASH): Reorder elements to match top-down order of dialog, fold
2238 long lines. Add descriptive paragraph, remove anonymous ids. Update
2239 copyright text, replace sources.redhat.com with cygwin.com.
2241 * root.h (class RootPage): Remove constructor implementation from
2244 * root.cc: ...to here, and call AddControlInfo.
2245 (static RootControlsInfo): Add. Populate with resizing data.
2246 (RootPage::OnInit): Make text a clickable hyperlink.
2248 * splash.h (class SplashPage): Likewise, move constructor from
2251 * splash.cc: ...to here. Call AddControlInfo.
2252 (static SplashControlsInfo): Add and populate.
2253 (SplashPage::Create): Make link on splash page a clickable hyperlink.
2255 * window.h: Add include.
2256 (class Window): Store allocated fonts with a vector instead of fixed
2257 array. Change indentation of setParent to be consistent.
2259 * window.cc (Window::Window): Remove FontCounter.
2260 (Window::~Window): Likewise. Iterate over vector of fonts instead.
2261 (Window::SetDlgItemFont): Use vector.
2263 2005-05-05 Max Bowsher <maxb@ukf.net>
2265 * Makefile.am (EXTRA_DIST, inilint_SOURCES):
2266 Sync with several recent changes.
2268 2005-05-05 Brian Dessent <brian@dessent.net>
2270 * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Include section
2273 2005-05-05 Brian Dessent <brian@dessent.net>
2275 * res.rc: (IDC_CHOOSE): Widen 'view' button by 6px horizontally and
2276 4px vertically. Adjust other controls to accomodate.
2277 (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that manifest is
2278 included in the binary.
2280 * setup.exe.manifest: New file. Results in common controls with
2281 themed appearance on modern versions of Windows.
2283 2005-05-05 Brian Dessent <brian@dessent.net>
2285 * main.cc (WinMain): Change conditional to avoid spurious error
2286 message on success. Include reason for failure in log message.
2288 2005-05-04 Max Bowsher <maxb@ukf.net>
2290 * state.cc, state.h (net_method, net_proxy_host, net_proxy_port,)
2291 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
2292 Inet_ftp_user, net_ftp_passwd):
2293 Move these global variables to be static variables of the NetIO class.
2295 * netio.h, netio.cc (net_method, net_proxy_host, net_proxy_port,)
2296 (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
2297 net_ftp_user, net_ftp_passwd):
2300 * ConnectionSetting.cc, net.cc:
2301 Change include, refer to variables in new location.
2303 2005-05-04 Max Bowsher <maxb@ukf.net>
2305 * PickLine.cc: Remove file - redundant.
2306 * Makefile.am (setup_SOURCES): Adjust.
2308 2005-05-04 Max Bowsher <maxb@ukf.net>
2310 * package_version.h (packageversion::set_requirements):
2311 Remove deftrust argument default value.
2313 2005-05-04 Max Bowsher <maxb@ukf.net>
2315 * package_version.cc (DependencyProcessor): Remove trivial class.
2316 (select, processOneDependency): Do not use DependencyProcessor, just
2317 pass parameters normally.
2319 2005-05-04 Brian Dessent <brian@dessent.net>
2321 Fix bug #820: Clicking Curr, etc., causes some dependencies to not
2324 * choose.cc (ChooserPage::changeTrust):
2325 Add a missing "packagedb.markUnVisited ()".
2327 2005-05-03 Max Bowsher <maxb@ukf.net>
2329 * PickCategoryLine.cc (PickCategoryLine::click):
2330 * PickPackageLine.cc (PickPackageLine::click):
2331 Abandon use of trivial packagemeta::PrepareForVisit() wrapper.
2333 * package_meta.h (packagemeta::PrepareForVisit): Remove.
2334 * package_meta.cc (packagemeta::PrepareForVisit): Remove.
2336 2005-05-03 Max Bowsher <maxb@ukf.net>
2338 * choose.h (ChooserPage::ifChecked): Remove.
2339 (ChooserPage::changeTrust): Convert from template to ordinary function.
2340 * choose.cc (ChooserPage::changeTrust): As above, plus avoid the use
2341 of custom class SetRequirement, when bind2nd(mem_fun(...),...) can
2342 achieve the same effect.
2343 * package_meta.h (SetRequirement): Remove, now unused.
2345 2005-05-03 Max Bowsher <maxb@ukf.net>
2347 * package_meta.h (packagemeta::set_requirements):
2348 Remove default argument which seems inappropriate.
2349 * PickPackageLine.cc (PickPackageLine::click):
2350 Make an argument explicit, and not that it seems like the wrong value.
2352 2005-05-03 Brian Dessent <brian@dessent.net>
2354 Fix part of bug #853 - proxy port not remembered.
2356 * net.cc (doing_loading): New static boolean.
2357 (load_dialog): Use the boolean to prevent save_dialog() from taking
2358 action due to field changes due to initialization.
2359 (save_dialog): Check the boolean and respond appropriately.
2361 2005-04-19 Max Bowsher <maxb@ukf.net>
2363 * postinstall.cc (RunFindVisitor::visitFile): Fix crash on
2364 encountering a postinstall script with a name of 4 characters or less.
2365 Bug introduced on 2004-12-25.
2367 2005-04-05 Max Bowsher <maxb@ukf.net>
2369 The Big Cleanup: Phase "rfc1738"
2371 * rfc1738.cc, rfc1738.h: Delete.
2372 * csu_util/rfc1738.cc: Reimport latest version from upstream source.
2373 Make thread-safe. Rewrite C++ wrapper in terms of std::string.
2374 Document the divergences from the upstream source.
2375 * csu_util/rfc1738.h: Recreate for the std::string version of the
2378 * Makefile.am (setup_SOURCES): Sync with added/removed files.
2379 * IniParseFindVisitor.cc: Modify #includes.
2380 (IniParseFindVisitor::visitFile): Change function name, as the new
2381 C++ wrapper does not contain an irregularity that the old one did.
2382 * download.cc: Modify #includes.
2383 * ini.cc: Modify #includes.
2385 2005-04-05 Max Bowsher <maxb@ukf.net>
2387 Remove setup's internal compression libraries, instead relying on the
2388 mingw-foo packages which have been part of the Cygwin net distribution
2389 for some time now. At the same time, reorganize the README file to
2390 inform about the change, and make some additional tidy-ups there whilst
2393 * GUIDELINES: Remove, contents transferred to README.
2394 * README: Add build instructions. Delete unconfirmed and fixed bugs
2395 sections. Incorporate the former contents of GUIDELINES.
2399 * Makefile.am (DIST_SUBDIRS, SUBDIRS):
2400 * configure.in: Remove AC_CONFIG_SUBDIRS for removed subdirs.
2401 * compress_bz.h: Remove complex _WIN32 preprocessor conditional.
2402 * compress_gz.h: Fix #include file name.
2403 * archive_tar_file.cc: Remove unused #include.
2404 * install.cc: Remove unused #include.
2406 2005-01-27 Max Bowsher <maxb@ukf.net>
2408 Set CYGWIN=nontsec, for postinstall scripts.
2410 * main.cc (main): putenv("CYGWIN=nontsec").
2412 2005-01-27 Bas van Gompel <patch-cygsup.buzz@bavag.tmfweb.nl>
2414 Fix corrupt display of ini parse percentage in log file.
2416 * ini.cc (GuiParseFeedback): Use a sensible data type for lastpct.
2418 2004-12-29 Max Bowsher <maxb@ukf.net>
2420 * site.cc (get_site_list): Filter the incoming mirrors list to contain
2421 only URL schemes that we can read.
2423 2004-12-28 Max Bowsher <maxb@ukf.net>
2425 The Big Cleanup: Phase "hash"
2427 * hash.cc, hash.h: Delete.
2428 * Makefile.am (setup_SOURCES): Sync with deleted files.
2430 * package_mets: Modify includes.
2431 (standard_dirs): Remove.
2432 (hash::add_subdirs): Remove.
2433 (packagemeta::uninstall): Re-implement using STL set instead of
2436 2004-12-28 Max Bowsher <maxb@ukf.net>
2438 * String++.h (operator std::string): Take care to never do
2439 std::string((char*)NULL) - it causes a hang!
2441 2004-12-27 Max Bowsher <maxb@ukf.net>
2443 The Big Cleanup: Phase "log"
2445 * log.cc, log.h: Delete old C-style compatibility wrapper around the
2447 * Makefile.am (setup_SOURCES): Sync with deleted files.
2449 * AntiVirus.cc, archive_tar_file.cc, ini.cc, install.cc,
2450 * io_stream_cygfile.cc, localdir.cc, msg.cc, net.cc, netio.cc,
2451 * netio.h, nio-ftp.cc, nio-ftp.h, root.cc, source.cc:
2452 Throughout, refine includes, and update code using the old
2453 compatibility wrapper to C++ streams style code.
2455 2004-12-27 Max Bowsher <maxb@ukf.net>
2457 * compress.cc: Refine includes. Remove placeholder function
2458 definitions. Make destructor an empty function.
2459 * compress.h: Refine includes. Make placeholder functions pure
2460 virtual. Add missing const on buffer argument to write function,
2461 to match derived classes.
2462 * compress_bz.cc, compress_gz.cc: Refine includes. Throw exception,
2463 rather than logging and returning an error, when an unimplemented
2465 * compress_bz.h, compress_gz.h: Refine includes.
2467 2004-12-26 Max Bowsher <maxb@ukf.net>
2469 The Big Cleanup: Phase "version"
2471 * String++.h (operator std::string): Add.
2472 * desktop.cc, fromcwd.cc: Remove irrelevant include.
2474 * version.cc, version.h: Delete, replacing all functionality in new
2477 * setup_version.h: Add, taking over declaration of generated version
2478 symbol functionality.
2480 * Makefile.am (setup_SOURCES): Sync with new/deleted files.
2481 (setup_version.c): Rename the symbol 'version' to 'setup_version'.
2482 * main.cc: Modify includes.
2483 (main): Adapt to setup_version rename.
2484 * splash.cc: Modify includes.
2485 (SplashPage::OnInit): Adapt to setup_version rename.
2487 * csu_util/version_compare.cc, csu_util/version_compare.h: Add,
2488 containing a completely rewritten replacement for canonical_version().
2490 * IniDBBuilderPackage.cc: Modify includes.
2491 (IniDBBuilderPackage::buildVersion): Use new version_compare API.
2492 * ini.cc: Modify includes.
2493 (setup_version): Rename...
2494 (ini_setup_version): ...to this.
2495 (do_local_ini, do_remote_ini): Adapt to above change.
2496 (do_ini_thread): Adapt to above change. Use new version_compare API.
2498 2004-12-25 Max Bowsher <maxb@ukf.net>
2500 * install.cc (Installer::installOneSource): Remove a stray "break;"
2501 left over from the switch-case -> if-else conversion in the previous
2504 2004-12-25 Max Bowsher <maxb@ukf.net>
2506 The Big Cleanup: Phase "win32"
2508 * win32.h: Major overhaul. Document why we use _WIN32_IE. Move out
2509 fragment dealing with alloca() to the single file in which it is used.
2510 Remove fragment dealing with _MAX_PATH, and convert all uses of it
2511 elsewhere to MAX_PATH. Remove random include of <stdarg.h>. Remove
2512 NOCOMATTRIBUTE, as setup contains no code which it affects. Remove
2513 includes of <wininet.h> and <windowsx.h> - see later in this log.
2514 (IsWindowsNT): New inline function, a much simpler implementation of
2519 * Makefile.am (setup_SOURCES): Remove "win32.cc".
2521 * AntiVirus.cc (detect), PickPackageLine.cc (PickPackageLine::paint),
2522 * install.c (Installer::installOneSource):
2523 Use IsWindowsNT(), not Win32::OS().
2524 * main.cc (main): Use IsWindowsNT(), not locally defined iswinnt.
2526 * PickView.cc (PickView::WindowProc), netio.cc (auth_proc),
2527 * proppage.cc (PropertyPage::DialogProc):
2528 Avoid using obfuscating macros from <windowsx.h>.
2530 * archive.cc: Include or #define alloca() in the only file in which
2533 * nio-ie5.h: Include <wininet.h> here, where it is actually needed,
2534 rather than in "win32.h" which is included almost everywhere.
2536 * archive_tar.cc, archive_tar.h, cygpackage.cc, cygpackage.h,
2537 * desktop.cc, find.cc, install.cc, main.cc, mklink2.c, mount.cc,
2538 * script.cc: Use MAX_PATH, not _MAX_PATH.
2540 2004-12-25 Max Bowsher <maxb@ukf.net>
2542 Remove some overcomplications.
2544 * Makefile.am (setup_SOURCES): Remove FilterVisitor.{cc,h}.
2545 * FilterVisitor.cc, FilterVisitor.h: Delete.
2546 * String++.cc (strmatch, String::matches): Remove.
2547 * String++.h (String::matches): Remove.
2548 * postinstall.cc: Do not include "FilterVisitor.h".
2549 (RunFindVisitor): Exclude items with the extension ".done".
2550 (do_postinstall_thread): Remove overcomplicated exclusion of items
2551 with the extension ".done".
2553 2004-12-24 Max Bowsher <maxb@ukf.net>
2555 * String++.cc, String++.h: Remove unused and incomplete code.
2556 * LogFile.cc (LogFile::log_save): Don't leak memory.
2557 * filemanip.cc, geturl.cc, root.cc, version.cc:
2558 Don't pointlessly create temporary copies strings.
2560 2004-12-23 Max Bowsher <maxb@ukf.net>
2562 * choose.cc (ChooserPage::OnNext): Relegate some overly verbose
2563 logging to an #ifdef DEBUG section.
2564 * geturl.h (dismiss_url_status_dialog): Remove stale function
2565 declaration, for which there is no definition.
2566 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
2567 Motivated by the recent unexplained hang bug, add some extra logging.
2569 2004-11-22 Max Bowsher <maxb@ukf.net>
2571 * MD5++.cc, MD5++.h: Remove this class.
2572 * csu_util/MD5Sum.cc, csu_util/MD5Sum.h: New more complete MD5 class.
2573 * Makefile.am (setup_SOURCES): Adjust to new files.
2574 * download.cc (validateCachedPackage): Simplify, using the new class.
2575 * install.cc (md5_one): Ditto.
2576 * package_source.h (packagesource::md5): Change to be an object of the
2579 2004-11-22 Max Bowsher <maxb@ukf.net>
2581 * main.cc (main): Fix bug in one of the 2004-11-19 commits.
2582 Avoid referring to the theLog pointer before it is set.
2584 2004-11-20 Max Bowsher <maxb@ukf.net>
2586 * res.rc (IDD_SOURCE): Clarify the radio-button option descriptions.
2587 Re-layout the radio buttons.
2589 2004-11-20 Max Bowsher <maxb@ukf.net>
2591 Repair the broken detection of wrongly-sized package files.
2593 * download.cc (validateCachedPackage): Make static, since not used
2594 elsewhere. Improve logging. Migrate file-size tests to here, alongside
2596 (check_for_cached): Remove broken testing of file-size, now covered by
2597 the above. Code cleanups.
2599 2004-11-19 Max Bowsher <maxb@ukf.net>
2601 * package_version.cc (dumpAndList): Make dependencies much more
2602 readable in full log output.
2604 2004-11-19 Max Bowsher <maxb@ukf.net>
2606 * proppage.cc (PropertyPage::DialogProc): Wrap in a TOPLEVEL_CATCH
2607 block, since allowing exceptions to unwind into the guts of Windows is
2610 2004-11-19 Max Bowsher <maxb@ukf.net>
2612 * main.cc (main): Move option parsing code earlier - it must execute
2613 before any significant object creations, which might test options in
2614 their initialization.
2616 2004-11-19 Max Bowsher <maxb@ukf.net>
2618 * main.cc (main): Remove some junk code - either commented out, or
2619 contained within unreachable preprocessor conditional sections.
2621 2004-11-19 Max Bowsher <maxb@ukf.net>
2623 * install.cc (Installer::installOneSource): Avoid leaking the open
2624 file handles of every tarball that is installed.
2626 2004-11-19 Max Bowsher <maxb@ukf.net>
2628 * package_source.h (packagesource::Canonical, packagesource::Base)
2629 (packagesource::Filename): Add "const" specification to accessor
2632 2004-11-18 Max Bowsher <maxb@ukf.net>
2634 * archive.h (archive::~archive): Define a pure virtual destructor to
2635 enforce the abstract nature of this class.
2636 * archive.cc (archive::~archive): Pure virtual destructors require an
2637 implementation! Add one.
2638 * io_stream.h (io_stream::destroyed): Remove this severely
2639 brain-damaged implementation of a weakly-enforced abstract class.
2640 The pure virtual destructor was strongly enforcing the abstract nature
2642 * io_stream.cc (io_stream::~io_stream): Empty out horribly pointless
2643 code from the pure virtual destructor.
2644 * archive_tar.cc (archive_tar::~archive_tar): Remove all
2645 reference to the removed "destroyed" member.
2646 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
2647 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
2648 * compress_gz.cc (compress_gz::~compress_gz): Ditto.
2649 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Ditto.
2650 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
2651 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
2653 2004-11-17 Max Bowsher <maxb@ukf.net>
2655 * mount.cc (create_mount): Fix operator precedence error introduced in
2656 first 2004-11-11 commit - warned of by gcc 3.3.3 but not 3.4.1 !
2658 2004-11-13 Max Bowsher <maxb@ukf.net>
2660 Miscellaneous cleanup.
2662 * geturl.cc (getUrlToStream): Make static.
2663 * geturl.h (getUrlToStream): Remove declaration.
2665 * geturl.cc, geturl.h, netio.cc, netio.h, nio-ftp.cc, nio-ftp.h,
2666 nio-http.cc, nio-http.h:
2667 Remove unused "allow_ftp_auth" flag throughout.
2669 2004-11-11 Max Bowsher <maxb@ukf.net>
2671 * libmd5-rfc: New directory, to hold code imported from the libmd5-rfc
2672 project in a clearly delineated fashion.
2673 * libmd5-rfc/README: New file.
2674 * md5.c, md5.h: Delete...
2675 * libmd5-rfc/md5.c, libmd5-rfc/md5.h: ...and replace with pristine
2676 versions from upstream (only change is restoration of upstream CVS
2677 keyword expansions).
2678 * libmd5-rfc/md5main.c: New file.
2679 * Makefile.ami (setup_SOURCES): Edit file paths.
2680 * download.cc, install.cc: Edit include paths.
2682 2004-11-11 Max Bowsher <maxb@ukf.net>
2684 * dialog.cc (fatal): Make capable of handling a passed-in error code,
2685 as an alternative to calling GetLastError().
2686 * dialog.h (fatal): Adjust prototype as above.
2687 * mount.cc (create_mount): Use the above to correctly report errors.
2689 2004-10-28 Max Bowsher <maxb@ukf.net>
2691 * LogFile.cc (LogFile::getFileName), splash.cc (SplashPage::Create),
2692 threebar.cc (ThreeBarProgressPage::SetBar2):
2693 Migrate from cistring and string resources
2694 to String and string literals.
2695 * localdir.cc: Remove unneeded #include of "cistring.h".
2696 * cistring.cc, cistring.h: Remove this now-redundant class.
2697 * Makefile.am: Remove mention of the above removed files.
2698 * res.rc, resource.h: Remove obsolete strings and IDs, both those
2699 obseleted by and obselete before the above changes.
2700 * res.rc: Merge the 2 adjacent STRINGTABLEs.
2702 2004-10-27 Max Bowsher <maxb@ukf.net>
2704 * Makefile.am (setup_SOURCES): Add "RECTWrapper.h". It was missing.
2706 2004-10-25 Bas van Gompel <cygsup-patch.buzz@bavag.tmfweb.nl>
2708 * package_source.cc (packagesource::set_canonical):
2709 Fix one-off in 'base' when ini is in same dir as package.
2711 2004-10-25 Max Bowsher <maxb@ukf.net>
2713 * main.cc (next_dialog): Remove this legacy global variable.
2714 * download.cc (do_download_thread): Return a value instead of setting
2715 a global variable, then returning void.
2716 (do_download_reflector): Look for the next dialog code as a return
2717 value instead of a global variable.
2719 2004-10-25 Max Bowsher <maxb@ukf.net>
2721 * port.h: Remove this redundant file - all contained definitions are
2722 duplicated in "win32.h".
2723 * Makefile.am, UserSetting.cc, UserSettings.cc, archive.cc,
2724 archive_tar.cc, archive_tar_file.cc, choose.cc, compress.cc,
2725 compress_bz.cc, compress_gz.cc, desktop.cc, find.cc, fromcwd.cc,
2726 iniparse.y, install.cc, io_stream_cygfile.cc, io_stream_file.cc,
2727 main.cc, netio.cc, site.cc, version.cc:
2728 Remove all references to "port.h".
2730 2004-10-25 Max Bowsher <maxb@ukf.net>
2732 Fix compilation with w32api 3.1 and later.
2734 * ControlAdjuster.h, RECTWrapper.h, cistring.h, propsheet.h,
2735 window.cc, window.h: Include "win32.h" not <windows.h> directly.
2736 * win32.h (WINBASEAPI): Define to empty string.
2738 2004-09-13 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2740 * script.cc (run): Kill stdin when running scripts.
2742 2004-09-01 Max Bowsher <maxb@ukf.net>
2744 * Makefile.am: Oops. Unwanted keyword expansion ate the code of the
2745 previous commit. Restore the code, escaped to not look like a keyword.
2747 2004-09-01 Max Bowsher <maxb@ukf.net>
2749 * Makefile.am: Simplify the shell incantation for getting the revision
2750 of ChangeLog from grep-and-sed to just sed.
2752 2004-08-31 Max Bowsher <maxb@ukf.net>
2754 Attain GCC 3.4 compatibility.
2756 * PackageSpecification.h (PackageSpecification): Make the
2757 unnecessarily private copy-constructor public.
2759 2004-08-30 Max Bowsher <maxb@ukf.net>
2761 Rework the implementation of not including -Werror for specific files,
2762 to a way that does not require hardcoding modified automake output back
2765 * Makefile.am (AM_CXXFLAGS, BASECXXFLAGS): Seperate out -Werror.
2766 (autoload.o): Drop this rule, -finline-functions is no longer required
2767 and -Werror is acceptable here now we have __attribute__ ((used)).
2768 (WARNONLY_CFLAGS, inilex.o): Drop these.
2769 (EXTRA_PROGRAMS): Add a fake "warnonly" program.
2770 (warnonly_CXXFLAGS): Set to the $(BASECXXFLAGS).
2771 (warnonly_SOURCES): Set to "inilex.cc".
2772 (EXTRA_setup_SOURCES): Set to $(warnonly_SOURCES).
2773 (setup_SOURCES): Remove "inilex.cc".
2774 (setup_LDADD): Add "warnonly-inilex.o".
2776 2004-08-30 Max Bowsher <maxb@ukf.net>
2778 Move closer to GCC 3.4 compatibility.
2780 * IOStreamProvider.h, io_stream_cygfile.cc, io_stream_cygfile.h,
2781 io_stream_file.cc: Do not incorrectly use "enum" after it has been
2782 hidden inside a typedef.
2783 * archive.h: In "virtual func() = 0;", the 0 is a language construct,
2784 not some symbol that might evaluate to 0, and gcc 3.4 enforces this.
2785 * autoload.c (DllInfo.name): Silence warning by making const.
2786 (DLL, autoload_common): __attribute__ ((used)) is now required to
2787 prevent gcc being over-eager in it's optimization, and removing these
2788 seemingly-unused (used only from assembly) functions.
2789 Silences some warnings, too.
2790 * Makefile.am (AM_CXXFLAGS, AM_CFLAGS): The options
2791 -Wstrict-prototypes -Wmissing-prototypes do not apply to C++ and
2792 g++ 3.4 complains about them.
2794 2004-08-29 Max Bowsher <maxb@ukf.net>
2796 * Exception.h: Reformatting, #include more, remove incorrect and
2797 less-than-useful comments.
2798 (TOPLEVEL_CATCH): New preprocessor macro.
2800 * LogFile.cc (LogFile::operator()): Throw an exception object, not a
2803 Wrap the top-level of each thread (including the main thread) in a
2804 try...catch block, in order to display a useful error message if an
2805 exception is not caught.
2806 * download.cc (do_download_reflector): Here ...
2807 * ini.cc (do_ini_thread_reflector): ... and here ...
2808 * install.cc (do_install_reflector: ... and here ...
2809 * main.cc (main): ... and here ...
2810 * postinstall.cc (do_postinstall_thread): ... and here ...
2811 * site.cc (do_download_site_info_thread): ... and here!
2813 * msg.h: Include a missing header requirement.
2814 * res.rc (IDS_UNCAUGHT_EXCEPTION, IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO):
2816 * resource.h (IDS_UNCAUGHT_EXCEPTION)
2817 (IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO): New IDs.
2819 2004-08-28 Max Bowsher <maxb@ukf.net>
2821 * res.rc (IDS_WINDOW_INIT_BADMSG): New string.
2822 * resource.h (IDS_WINDOW_INIT_BADMSG): New string resource ID.
2823 * window.cc (Window::FirstWindowProcReflector): Convert an abort()
2824 into a descriptive error.
2826 2004-08-24 Max Bowsher <maxb@ukf.net>
2828 The Doug Lee replacement malloc was no longer hooked up with the
2829 buildsystem in any way. Pruning the remaining unused file.
2831 * dlmalloc.c: Removed.
2833 2004-08-18 Max Bowsher <maxb@ukf.net>
2835 "librsync is not wire-compatible with rsync 2.x, and is not likely
2836 to be in the future." -- librsync.sourceforge.net
2838 So, it is of no practical use to setup. Therefore, removing all
2839 rsync related files and code from setup.
2841 * rsync: Directory removed.
2842 * Makefile.am: Remove rsync support from the buildsystem.
2843 * configure.in: Ditto.
2844 * README: Since it seems vanishingly unlikely that it will ever happen,
2845 remove rsync support from the wishlist.
2846 * io_stream_rsync.cc: Remove.
2847 * io_stream_rsync.h: Remove.
2849 2004-04-25 Robert Collins <rbtcollins@hotmail.com>
2851 * package_meta.cc (packagemeta::set_requirements): fix problem with
2852 libpcre0 not being pulled in automatically.
2854 2004-04-25 Robert Collins <rbtcollins@hotmail.com>
2856 * IniDBBuilderPackage.cc (dumpAndList):
2857 Move out to packageversion for reuse.
2858 * package_meta.cc (packagemeta::logAllVersions): log dependencies.
2859 * package_version.cc (packageversion::depends):
2860 provide a const accessor.
2861 (dumpAndList): Moved from INIDBBuilder.cc.
2862 * package_version.h: declare new method and function.
2864 2003-12-21 Robert Collins <rbtcollins@hotmail.com>
2866 * main.cc (main): Update to head libgetopt++ syntax.
2868 2003-11-2 Robert Collins <rbtcollins@hotmail.com>
2870 * ControlAdjuster.h (ControlPosition::CP_MIDDLE): Rename to
2872 * ControlAdjuster.cc: Ditto.
2874 2003-10-31 Frank Richter <frichter@gmx.li>
2876 * localdir.cc (OnNext): When SelectDirectoryA() fails, display a
2877 message with the error returned from the system instead of just
2878 'could not change dir'. Also, offer the user to 'Retry', 'Ignore' the
2879 error or 'Abort' the directory change.
2881 2003-10-31 Frank Richter <frichter@gmx.li>
2883 * propsheet.cc (PropSheetWndProc): Don't do child resizing if a the
2884 window gets minimized. Otherwise some glitches (e.g. wrong child
2886 Added support for WM_GETMINMAXINFO. Prevents the property sheet from
2887 getting smaller than the original size.
2889 2003-11-1 Robert Collins <rbtcollins@hotmail.com>
2891 * ControlAdjuster.h (ControlDimension): Add.
2892 (ControlAdjuster): Factor adjust functionality into ControlInfo.
2893 * ControlAdjuster.cc (ControlAdjuster::adjust): Ditto.
2894 (ControlAdjuster::ControlInfo::adjust): Ditto.
2896 2003-10-31 Igor Pechtchanski <pechtcha@cs.nyu.edu>
2898 * ControlAdjuster.h (ControlPosition): New enum type.
2899 (ControlInfo::horizontalPos, ControlInfo::verticalPos): New
2901 (ControlInfo::anchorLeft, ControlInfo::anchorTop,
2902 ControlInfo::anchorRight, ControlInfo::anchorBottom): Remove.
2903 * ControlAdjuster.cc (ControlAdjuster::AdjustControls): Switch to
2904 using position specifiers instead of anchors.
2905 * choose.cc (ChooserControlsInfo): Ditto.
2906 * proppage.cc (DefaultControlsInfo): Ditto.
2907 * propsheet.cc (PropSheetControlsInfo): Ditto.
2908 * site.cc (SiteControlsInfo): Position specifiers for site
2909 selection dialog controls.
2910 * threebar.cc (ThreeBarControlsInfo): Position specifiers for
2911 progress dialog controls.
2913 2003-10-27 Ralf Habacker <ralf.habacker@freenet.de>
2915 * main.cc (HelpOption): New instance.
2916 (main): Added help command line option handling.
2917 * localdir.cc (LocalDirOption): New instance.
2918 (LocalDirSetting::load): allow setting localdir from command line.
2920 2003-10-16 Frank Richter <frichter@gmx.li>
2922 * ControlAdjuster.cc: New file, helper to move elements of a dialog
2923 along when the it's resized.
2924 * ControlAdjuster.h: Ditto.
2925 * Makefile.am: Add new source files.
2926 * proppage.cc (PropertyPage::DialogProc): Adjust some common
2927 controls (Cygwin icon top right, separator below) when a page is
2929 (PropertyPage::PropertyPage): Dito.
2930 * propsheet.cc (IsDialog): New. Test whether a window is a dialog.
2931 Used internally by resize logic.
2932 (EnumPages): New. Used internally by resize logic: resizes the
2933 property sheet's individual pages.
2934 (PropSheetWndProc): New. Hook for the propery sheet window proc.
2935 (PropSheetProc): More style tweaks, add maximize box and thick border
2936 as well. Hook into the property sheet's window proc.
2937 (PropSheet::AdjustPageSize): New. Adjust the metrics of a single page
2938 to fit nicely into the property sheet. Part of resize logic.
2939 * res.rc (All dialogs): The top-right Cygwin icon and top separator
2940 now have IDs distinct from IDC_STATIC, so their metrics can be
2941 adjusted upon a resize. Also, all those Cygwin icons are at the exact
2943 * choose.cc (ChooserPage::ChooserPage): Now the controls on the
2944 chooser page move/size when the page size is changed.
2947 2003-10-23 Jerry D. Hedden <jerry@hedden.us>
2949 * ConnectionSetting.cc (ConnectionSetting::load): Load proxysettings.
2950 (ConnectionSetting::save): Save proxy settings.
2952 2003-10-07 Robert Collins <rbtcollins@hotmail.com>
2954 * proppage.h (PropertyPage::wantsActivation): const correctness fix.
2956 2003-08-19 Max Bowsher <maxb@ukf.net>
2958 * win32.h: Define NOMINMAX only if not already defined - because
2959 libstdc++-v3 3.3.1 defines NOMINMAX itself.
2961 2003-08-03 Max Bowsher <maxb@ukf.net>
2963 * ChangeLog: Fix broken line-wrapping throughout. Clarify that
2964 "Ran automake" in 2003-07-26 entry was in bz2lib and zlib subdirs.
2966 2003-08-03 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2968 * propsheet.cc (Copyright): Update copyright dates.
2969 (PropSheet::PropSheet): Remove NumPropPages initialization.
2970 (PropSheet::CreatePages): Use PropertyPages.size() instead of
2972 (PropSheet::Create): Ditto.
2973 (PropSheet::AddPage): Change to use new PropertyPages std::vector<>.
2974 * propsheet.h (Copyright): Update copyright dates.
2975 (File Scope): Include <vector>.
2976 (PropSheet::PropertyPages): Change from array to vector<>.
2977 (PropSheet::NumPropPages): Remove.
2979 2003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2981 Changes modified by Max Bowsher <maxb@ukf.net>
2982 * splash.cc (Copyright): Update copyright dates.
2983 (SplashPage::OnInit): Remove call to SetDlgItemFont(). Now handled in
2985 * proppage.h (PropertyPage::setTitleFont): Declare.
2986 * proppage.cc (Copyright): Update copyright dates.
2987 (PropertyPage::DialogProc WM_INITDIALOG): Move all font setting code,
2988 including that from splash.cc into new function...
2989 (PropertyPage::setTitleFont): Create, using moved code. Change font
2990 "MS Sans Serif" to "MS Shell Dlg" in line with recent res.rc change.
2991 Set font for IDC_STATIC_WELCOME_TITLE here, to allow easy re-use of
2992 style for future "Finished" page.
2994 2003-08-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
2996 * propsheet.cc: Include "resource.h".
2997 (PropSheet::Create): Add the Cygwin icon in the left of the title bar.
2999 2003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3001 * proppage.cc (PropertyPage::FirstDialogProcReflector): Modify comment.
3003 2003-08-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3005 * proppage.h (Copyright): Update copyright dates.
3006 (PropertyPage): Document OnNext and OnBack.
3008 2003-07-31 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3010 * proppage.cc (PropertyPage::Create): Use more self-documenting
3011 MAKEINTRESOURCE() instead of cast to LPCSTR.
3013 2003-07-31 Robert Collins <rbtcollins@hotmail.com>
3015 * README: Mark completed items complete.
3017 2003-07-31 Pierre Humblet <pierre.humblet@ieee.org>
3019 * main.cc (set_default_sec): Set token owner from token user.
3020 Always try to set the token primary group to Users or Admins.
3022 2003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3024 * String++.h (String::replace): New instance functions.
3025 * String++.cc (String::replace): Implement.
3026 * filemanip.cc (backslash): Change to use String::replace.
3027 * desktop.cc (make_cygwin_bat): Escape '%' in path.
3029 2003-07-30 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3031 * String++.h (TOSTRING): New macro.
3032 * UserSettings.cc (UserSettings::deRegisterSetting): Fix
3033 erroneous __LINE__/__FILE__ usage.
3034 * download.cc (validateCachedPackage, check_for_cached): Ditto.
3035 * geturl.cc (getUrlToStream): Ditto.
3036 * install.cc (md5_one): Ditto.
3038 2003-07-30 Max Bowsher <maxb@ukf.net>
3040 * ini.cc (do_ini_thread): Return bool.
3041 (do_ini_thread_reflector): Put returned bool in lParam.
3042 * threebar.cc (WM_APP_SETUP_INI_DOWNLOAD_COMPLETE): Rework for new
3043 meaning of lParam. Replace erroneous use of do_fromcwd with
3044 SetActivePageByID (IDD_SOURCE).
3046 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
3048 * ConnectionSetting.cc: New file, persist connection type selection.
3049 * ConnectionSetting.h: Ditto.
3050 * net.cc: Hold a ConnectionSetting instance to trigger the logic.
3051 (NetPage::OnInit): Don't force net_method to any value.
3052 * Makefile.am: Add new source files.
3054 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
3056 * SourceSetting.cc: New file, persist source selection.
3057 * SourceSetting.h: Ditto.
3058 * source.cc: Hold a Source setting instance to trigger the logic.
3059 * Makefile.am: Add new source files.
3061 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
3063 * UserSettings.h (UserSettings::settingFileForLoad): Extracted method
3064 from LocalDirSetting::load().
3065 * UserSettings.cc (UserSettings::settingFileForLoad): Ditto.
3066 * UserSettings.h (UserSettings::settingFileForSave): Extracted method
3067 from LocalDirSetting::save().
3068 * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
3069 * localdir.cc (LocalDirSetting::load): Extract location logic to
3071 (LocalDirSetting::save): Extract location logic to UserSettings.
3072 * site.cc (SiteSetting::getSavedSites): Use
3073 UserSettings::settingFileForLoad.
3074 (SiteSetting::save): Use UserSettings::settingFileForSave.
3076 2003-07-30 Robert Collins <rbtcollins@hotmail.com>
3078 * PickView.cc: Adjust ::GetClientRect(..) to the inherited one
3081 2003-07-29 Max Bowsher <maxb@ukf.net>
3083 Based on a patch by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
3084 * AntiVirus.cc (AntiVirusPage::wantsActivation): Define.
3085 * AntiVirus.h (AntiVirusPage::wantsActivation): Declare.
3086 * localdir.cc (LocalDirPage::OnBack): Remove logic subsumed by
3087 RootPage::wantsActivation.
3088 * proppage.cc (PropertyPage::DialogProc): Call wantsActivation(),
3089 and skip to next page in sequence if activation is refused.
3090 * proppage.h (PropertyPage::wantsActivation): Default implementation.
3091 * root.cc (RootPage::wantsActivation): Define.
3092 * root.h (RootPage::wantsActivation): Declare.
3093 * source.cc: Don't include "AntiVirus.h".
3094 (SourcePage::OnNext): Remove logic subsumed by
3095 RootPage::wantsActivation.
3096 (SourcePage::OnBack): Remove logic subsumed by
3097 AntiVirusPage::wantsActivation.
3098 * splash.cc: Don't include "AntiVirus.h" or "dialog.h".
3099 (SplashPage::OnNext): Remove - subsumed by
3100 AntiVirusPage::wantsActivation.
3101 * splash.h (SplashPage::OnNext): Remove declaration.
3103 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
3105 * PickView.h (PickView::refresh): New method.
3106 * PickView.cc (PickView::refresh): Extracted from various
3107 ChooserPage callers.
3108 * choose.cc: Use PickView::refresh wherever possible.
3110 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
3112 * choose.h (ChooserPage::createListView): Remove last parameter.
3113 (ChooserPage::getDefaultListViewSize): Extracted method.
3114 * choose.cc (ChooserPage::createListView): Remove last parameter.
3115 (ChooserPage::getDefaultListViewSize): Extracted method.
3117 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
3119 * choose.cc (ChooserPage::createListView): Remove unneeded
3123 2003-07-29 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3125 * dialog.h (do_fromcwd): Change function declaration.
3126 * fromcwd.cc (do_fromcwd): Change return type to bool. Eliminate
3127 use of next_dialog, return true or false instead.
3128 * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
3129 value instead of next_dialog.
3131 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
3133 * package_db.h (packagedb::fillMissingCategory): Move from ChooserPage.
3134 * choose.h (ChooserPage::fillMissingCategory): Delete.
3135 * package_db.cc (packagedb::fillMissingCategory): Move from ChooserPage.
3136 * choose.cc (ChooserPage::fillMissingCategory): Delete and adjust
3139 2003-07-29 Robert Collins <rbtcollins@hotmail.com>
3141 * PickView.h (CATEGORY_EXPANDED): Move from choose.h
3142 (CATEGORY_COLLAPSED): Move from choose.cc.
3143 (PickView::setViewMode): Move from ChooserPage.
3144 * choose.h (CATEGORY_EXPANDED): Delete.
3145 (CATEGORY_COLLAPSED): Delete.
3146 (ChooserPage::setViewMode): Delete.
3147 * PickView.cc (PickView::setViewMode): Move from ChooserPage.
3148 * chooser.cc (ChooserPage::setViewMode): Delete, and adjust callers
3151 2003-07-28 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3153 * AntiVirus.cc (AntiVirusPage::OnNext): Do not explicitly specify the
3154 page to display next, since it follows in the default page ordering
3157 2003-07-28 Max Bowsher <maxb@ukf.net>
3159 * dialog.h: (NEXT): Remove obsolete macro.
3160 * site.cc (save_dialog): Remove use of NEXT(), and non-functional
3161 unnecessary error handler.
3163 2003-07-28 Robert Collins <rbtcollins@hotmail.com>
3165 * package_meta.h (packagemeta::addToCategoryAll): Declare.
3166 * package_meta.cc (packagemeta::addToCategoryAll): New method,
3167 separated to allow clear iteration.
3168 * choose.cc (ChooserPage::fillMissingCategory): BUGFIX: "all" is
3169 meant to be added unconditionally.
3171 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3173 * Generic.h: New file, home for generic programming tools.
3174 (visit_if): Move here from package_meta.cc.
3175 Adjust to be fully parameterised.
3176 * package_meta.h (packagemeta::hasNoCategories): Query for generic
3178 (packagemeta::setDefaultCategories): set categories for packages
3180 * package_meta.cc: Move visit_if out. Adjust users for
3181 full paramterised operation.
3182 (packagemeta::hasNoCategories): Implement.
3183 (packagemeta::setDefaultCategories): Implement.
3184 * choose.cc (ChooserPage::fillMissingCategory): Use visit_if to
3185 reduce duplicate code.
3186 (ChooserPage::setExistence): Delete.
3187 * choose.h (ChooserPage::setExistence): Rename to
3188 packagedb::setExistence.
3189 * package_db.h (packagedb::setExistence): Declare.
3190 * package_db.cc (packagedb::setExistence): Copy from choose.cc
3192 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3194 * localdir.h (LocalDirPage::OnInit): Remove.
3195 * localdir.cc (LocalDirPage::OnInit): Move to LocalDirSetting
3197 (LocalDirSetting::load): Copied from LocalDirPage::OnInit.
3198 * site.h (SitePage::OnInit): Remove.
3199 (SitePage::getSavedSites): New member, replaces get_saved_sites.
3200 (SitePage::registerSavedSite): New member, replaces
3201 register_saved_site.
3202 * site.cc (SitePage::OnInit): Move to SiteSetting::load().
3203 (SiteSetting::load): Copied from SitePage::OnInit.
3204 (SitePage::getSavedSites): Renamed from get_saved_sites.
3205 (SitePage::registerSavedSite): Renamed from register_saved_site.
3206 (do_download_site_info_thread): Don't look at the list size for
3207 determining if the download was successful.
3209 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3211 * choose.h (ChooserPage::setViewMode): Remove HWND from
3213 (ChooserPage::defaultTrust): Ditto.
3215 (ChooserPage::ifChecked): Use Window helper function
3217 * choose.cc (ChooserPage::setViewMode): Use chooser->GetHWND()
3219 Update all callers with new signature.
3220 (ChooserPage::defaultTrust): Ditto.
3222 * PickView.h (PickView::defaultTrust): Declare.
3223 * PickView.cc (PickView::defaultTrust): Copy from chooser.cc.
3225 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3227 * PickView.h (PickView::lv): Eliminate.
3228 * PickView.cc (PickView::init): Replace use of lv with
3230 (PickView::list_click): Ditto.
3231 * choose.h (ChooserPage::lv): Eliminate.
3232 * choose.cc: Replace lv with chooser->GetHWND()
3235 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3237 * PickView.h (PickView::chooser): Eliminate.
3238 (PickView::list_vscroll): Make non-static.
3239 (PickView::list_hscroll): Ditto.
3240 (PickView::list_click): Ditto.
3241 (PickView::paint): Ditto.
3242 * PickView.cc (PickView::list_vscroll): Eliminate use
3243 of PickView::chooser.
3244 (PickView::list_hscroll): Ditto.
3245 (PickView::list_click): Ditto.
3246 (PickView::paint): Ditto.
3247 * choose.cc (Chooser::createListView): Eliminate use
3248 of PickView::chooser.
3250 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3252 * PickView.h (PickView): Inherit from Window.
3253 (PickView::RegisterWindows): Move from ChooserPage.
3254 (PickView::listview_proc): Likewise.
3255 (PickView::paint): Ditto.
3256 (PickView::list_click): Ditto.
3257 (PickView::list_hscroll): Ditto.
3258 (PickView::list_vscroll): Ditto.
3259 (PickView::lv): Ditto.
3260 (PickView::chooser): Ditto.
3261 (PickView::Create): Override Windows::Create as we migrate.
3262 (PickView::registerWindowClass): Renamed RegisterWindows.
3263 (PickView::WindowClassAtom): Prevent double registration.
3264 (PickView::init): Declare.
3265 * PickView.cc: Adjust for new inheritance.
3266 (PickView::RegisterWindows): Move from ChooserPage.
3267 (PickView::listview_proc): Likewise.
3268 (PickView::paint): Ditto.
3269 (PickView::list_click): Ditto.
3270 (PickView::list_hscroll): Ditto.
3271 (PickView::list_vscroll): Ditto.
3272 (PickView::lv): Ditto.
3273 (PickView::chooser): Ditto.
3274 (PickView::Create): Introduce stub.
3275 (PickView::RegisterWindows): Rename
3276 (PickView::init): Extracted from constructor to allow
3278 * chooser.h (ChooserPage::registerWindows): Rename to
3279 PickView::RegisterWindows.
3280 (ChooserPage::listview_proc): Likewise.
3281 (ChooserPage::paint): Ditto.
3282 (ChooserPage::list_click): Ditto.
3283 (ChooserPage::list_hscroll): Ditto.
3284 (ChooserPage::list_vscroll): Ditto.
3285 (ChooserPage::lv): Duplicate into PickView, observe
3287 (ChooserPage::chooser): Ditto.
3288 * chooser.cc (ChooserPage::registerWindows): Delete.
3289 (ChooserPage::listview_proc): Ditto.
3290 (ChooserPage::paint): Ditto.
3291 (ChooserPage::list_click): Ditto.
3292 (ChooserPage::list_hscroll): Ditto.
3293 (ChooserPage::list_vscroll): Ditto.
3294 (ChooserPage::createListView): Create() on PickView.
3295 * window.h (Window::RegisterWindowClass): Make virtual
3296 to allow Create to become a Template Method, and rename
3297 to registerWindowClass as it's not static.
3298 * window.cc (Window::registerWindowClass): Ditto.
3299 (Window::FirstWindowProcReflector): BUGFIX: Set window
3300 handle to prevent races with the window procedure.
3302 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3304 * choose.cc (set_view_mode): Rename to ChooserPage::setViewMode.
3305 (default_trust): Rename to ChooserPage::defaultTrust.
3306 (fill_missing_category): Rename to ChooserPage::fillMissingCategory.
3307 (set_existence): Rename to ChooserPage::setExistence.
3308 (register_windows): Rename to ChooserPage::registerWindows.
3309 (listview_proc): Rename to ChooserPage::listview_proc.
3310 (paint): Rename to ChooserPage::paint.
3311 (list_click): Rename to ChooserPage::list_click.
3312 (list_hscroll): Rename to ChooserPage::list_hscroll.
3313 (list_vscroll): Rename to ChooserPage::list_vscroll.
3314 (lv): Rename to ChooserPage::lv.
3315 (chooser): Rename to ChooserPage::chooser.
3316 * choose.h (ChooserPage::setViewMode): Declare.
3317 (ChooserPage::defaultTrust): Declare.
3318 (ChooserPage::fillMissingCategory): Declare.
3319 (ChooserPage::setExistence): Declare.
3320 (ChooserPage::registerWindows): Declare.
3321 (ChooserPage::listview_proc): Declare.
3322 (ChooserPage::paint): Declare.
3323 (ChooserPage::list_click): Declare.
3324 (ChooserPage::list_hscroll): Declare.
3325 (ChooserPage::list_vscroll): Declare.
3326 (ChooserPage::lv): Declare.
3327 (ChooserPage::chooser): Declare.
3329 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3331 * choose.cc (create_listview): Use for_each instead of explicit
3333 (create_listview): Rename to ChooserPage::createListview.
3334 * package_meta.h (packagemeta::set_requirements): Explicitly separate
3335 the 1 and 2 parameter versions.
3337 2003-07-27 Robert Collins <rbtcollins@hotmail.com>
3339 * String++.h (String::operator !=): Declare for char * and String.
3340 * String++.cc (String::operator !=): Implement.
3341 * package_meta.cc(StringConcatenator): Move above all users.
3342 (_visit_if): Predicate support for visitors.
3343 (packagemeta::getReadableCategoryList): Refactor to use
3344 StringConcatenator with a predicate.
3345 * choose.h: Remove unneeded c++ guards.
3347 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
3349 * choose.cc (scan_downloaded_files): Rename to
3350 packagemeta::ScanDownloadedFiles.
3351 (scanAVersion): Rename to packageversion::scan.
3352 (GetParentRect): Rename to ChooserPage::getParentRect.
3353 * choose.h (ChooserPage::getParentRect): Declare.
3354 * package_meta.h (packagemeta::ScanDownloadedFiles): Declare.
3355 * package_version.h (packageversion::scan): Declare.
3356 * package_version.cc (packageversion::scan): Move from choose.cc
3357 * package_meta.cc (packagemeta::ScanDownloadedFiles): Move from
3360 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
3362 * choose.cc (ChooserPage::OnNext): log before starting activity threads.
3363 (ChooserPage::OnInit): Remove temporary variable frame.
3364 (ChooserPage::setPrompt): Extract method from OnInit.
3365 (choose_inst_text): Remove unused variable.
3366 * choose.h(ChooserPage::setPrompt): Declare
3367 * res.rc (IDD_CHOOSE): Bugfix: the chooser was setting a non-present
3370 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
3372 Remove package specific code from choose.cc.
3373 Update copyrights where appropriate.
3374 * choose.cc(ChooserPage::OnNext): Extract logging to
3375 packagemeta::logSelectionStatus.
3376 * package_meta.cc(packagemeta::logSelectionStatus): Extract from
3377 ChooserPage::OnNext.
3378 (StringConcatenator): helper for logSelectionStatus.
3379 (action_caption): Make const.
3380 * package_meta.h(packagemeta): Declare logSelectionStatus.
3381 (packagemeta::action_caption): Make const.
3382 * package_version.cc(packageversion::sourcePackage): Make const.
3383 * package_version.h(packageversion::sourcePackage): Make const.
3385 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
3387 * choose.cc: Update copyright.
3388 (ChooserPage::keepClicked): Extracted from OnMessageCmd.
3389 (ChooserPage::changeTrust): Ditto.
3390 * choose.h (ChooserPage): Declare keepClicked and changeTrust.
3391 (ChooserPage::ifChecked): Extracted from OnMessageCmd.
3392 * package_meta.h (SetRequirement): Adapter for visiting package
3395 2003-07-26 Max Bowsher <maxb@ukf.net>
3397 * tests/.cvsignore: New file, listing Makefile.in.
3399 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
3401 Save used local cache dir from initial run of setup, so the user doesn't
3403 * localdir.h (LocalDirSetting): UserSetting class for the local cache
3405 * localdir.cc (LocalDirSetting::save): Replace save_local_dir, and
3408 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
3410 Save used site from initial run of setup, so the user doesn't need to
3412 * main.cc (main): Load and save all user settings.
3413 * site.cc (SiteSetting::save): Migrate logic from save_site_url.
3414 (SitePage::OnNext): Use ChosenSites.save() to remove uneeded
3416 (save_site_url): Delete.
3417 * site.h (save_site_url): Remove declaration.
3418 * .cvsignore: Update autoconf generated files.
3420 2003-07-26 Robert Collins <rbtcollins@hotmail.com>
3422 * tests/Makefile.am: Driver for test suite.
3423 * tests/UserSettingTest.cc: Test UserSetting interface.
3424 * tests/UserSettingsTest.cc: Test UserSettings interface.
3425 * Makefile.am: Add the tests dir to recurse into.
3426 * configure.in: Ditto.
3427 * UserSetting.h: Add load and save methods to allow global
3429 Add explicit copy and assignment operators to prevent synthetics.
3430 Make the constructor protected to prevent direct instantiation.
3431 * UserSettings.h (UserSettings::loadAllSettings): New method.
3432 (UserSettings::savedAllSettings): New method.
3433 * UserSettings.cc: Implement new methods.
3434 * site.cc: Implement stubs for new required UserSetting methods.
3435 * site.h (ChosenSite): Ditto.
3436 * bz2lib/: Ran automake.
3437 * zlib/: Ran automake.
3439 2003-07-23 Max Bowsher <maxb@ukf.net>
3441 * desktop.cc (DesktopSetupPage::OnBack): Remove obsolete use of NEXT().
3442 * root.cc (RootPage::OnNext): Ditto.
3443 (RootPage::OnBack): Ditto.
3444 * install.cc (do_install_thread): Remove obsolete use of next_dialog.
3445 * main.cc (main): Ditto.
3446 * postinstall.cc (do_postinstall_thread): Ditto.
3448 2003-07-23 Max Bowsher <maxb@ukf.net>
3450 * dialog.h (do_choose, do_desktop, do_local_dir, do_net, do_other)
3451 (do_root, do_site, do_source, do_splash): Remove declarations, since
3452 these functions no longer exist.
3454 2003-07-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3456 * choose.cc (initialized): Remove obsolete file scope variable.
3458 2003-07-18 Max Bowsher <maxb@ukf.net>
3460 * res.rc: Make caption of every dialog page begin with "Cygwin Setup".
3461 This aids recognition when minimized.
3462 Prompted by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
3464 2003-07-10 Jeremy White <jwhite@codeweavers.com>
3466 * mount.cc, root.cc, site.cc: Make StringOptions required,
3467 thereby making --longopt <parm> behave as a newbie would expect.
3469 2003-07-08 Max Bowsher <maxb@ukf.net>
3471 * LogFile.h, cistring.h, dialog.h, diskfull.h, filemanip.h, geturl.h,
3472 hash.h, log.h, mkdir.h, mklink2.h, mount.h, msg.h, netio.h, nio-file.h,
3473 nio-ftp.h, nio-http.h, nio-ie5.h, port.h, simpsock.h, state.h,
3474 version.h: Add inclusion guard.
3475 * root.h: Standardize naming of inclusion guard.
3477 2003-06-23 Max Bowsher <maxb@ukf.net>
3479 * AntiVirus.h, Exception.h, FilterVisitor.h, FindVisitor.h,
3480 IOStreamProvider.h, IniDBBuilder.h, IniDBBuilderPackage.h,
3481 IniParseFeedback.h, IniParseFindVisitor.h, LogSingleton.h, MD5++.h,
3482 PackageSpecification.h, PackageTrust.h, PickCategoryLine.h, PickLine.h,
3483 PickPackageLine.h, PickView.h, RECTWrapper.h, ScanFindVisitor.h,
3484 String++.h, UserSetting.h, UserSettings.h, archive.h, archive_tar.h,
3485 category.h, choose.h, compress.h, compress_bz.h, compress_gz.h,
3486 cygpackage.h, desktop.h, download.h, find.h, ini.h, io_stream.h,
3487 io_stream_cygfile.h, io_stream_file.h, io_stream_memory.h,
3488 io_stream_rsync.h, localdir.h, net.h, package_db.h, package_meta.h,
3489 package_source.h, package_version.h, proppage.h, propsheet.h, script.h,
3490 site.h, source.h, splash.h, threebar.h, win32.h, window.h:
3491 Standardize naming and placement of inclusion guards.
3493 2003-06-22 Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>
3495 * res.rc (all dialogs): Change font from "MS Sans Serif" to
3498 2003-06-22 Max Bowsher <maxb@ukf.net>
3500 * Makefile.am: Clarify comment.
3501 Derive AM_CFLAGS from AM_CXXFLAGS, rather than the other way around.
3502 (AM_CXXFLAGS): Remove -Wmissing-declarations - it is a C-only warning.
3503 (AM_CFLAGS): Add -Winline, and -Wmissing-declarations.
3505 2003-06-22 Max Bowsher <maxb@ukf.net>
3507 * rfc1738.cc (rfc1738_do_escape): Eliminate redundant conditional.
3509 2003-06-05 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3511 * window.h (SETUP_WINDOW_H): Rename multi-include guard.
3512 (Copyright): Update.
3513 (RECTWrapper): New forward declaration.
3514 (Window::Create): Move.
3515 (Window::MoveWindow): New overload declaration.
3516 * window.cc: (RECTWrapper.h) Include.
3517 (Copyright): Update.
3518 (Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
3520 (Window::MoveWindow): New overload.
3522 2003-05-31 Max Bowsher <maxb@ukf.net>
3524 * res.rc: Resize title controls to fully fill available width.
3526 2003-05-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3528 * RECTWrapper.h: New file.
3530 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3532 * script.cc (Script::extension): Extract method from Script::run.
3533 (Script::run): Extract extension generation to Script::extension.
3534 * script.h (Script::extension): Declare.
3536 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3538 * script.cc (run_script): Remove.
3539 (try_run_script): Inline method run_script.
3540 * script.h (run_script): Remove.
3542 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3544 * postinstall.cc (RunScript::operator()): Use new run syntax.
3545 * script.h (Script::run): Eliminate to_log parameter.
3546 * script.cc (Script::run): Ditto.
3547 (run_script): Use new run syntax.
3549 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3551 * script.cc (Script::run): Eliminate temp variable 'f2'.
3552 Rename temp variable 'f2' to 'windowsName' for increased clarity.
3554 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3556 * script.cc (Script::run): Eliminate temp variable 'fname'.
3558 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3560 * script.cc (Script::run): Eliminate temp variable 'dir'.
3562 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3564 * script.cc (run_script): Always pass TRUE to Script::run.
3565 * script.h (run_script): Remove optional to_log parameter.
3567 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3569 * script.cc (run_script): Move functionality into Script.
3570 (Script::run): Absorb run_script.
3572 2003-04-12 Robert Collins <rbtcollins@hotmail.com>
3574 * PickCategoryLine.cc (PickCategoryLine::click): Tell packagemeta we
3575 are about to perform a visit.
3576 * PickPackageLine.cc (PickPackageLine::click): Tell packagemeta we
3577 are about to perform a visit.
3578 * package_db.cc (packagedb::markUnVisited): Convenience wrapper -
3579 mark all packages as unvisited.
3580 * package_db.h (packagedb::markUnVisited): Declare.
3581 * package_meta.cc (packagemeta::PrepareForVisit): New static method
3582 to prepare for a loop-free visit.
3583 (packagemeta::packagemeta): Adjust for new member.
3584 (packagemeta::set_requirements): Only visit a node once.
3585 (packagemeta::visited): Get and Set methods for new member visited_.
3586 * package_meta.h (packagemeta::PrepareForVisit): Declare.
3587 (packagemeta::visited): Declare.
3588 (packagemeta::visited_): Declare.
3590 2003-04-07 Max Bowsher <maxb@ukf.net>
3592 * download.cc: Add command line option to suppress MD5 checks.
3593 (validateCachedPackage): Test option and possibly skip.
3595 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3597 Merge in setup-200303-troubleshooting fixes.
3599 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3601 * main.cc (NTSecurity::setDefaultDACL): Reinstate commented code.
3602 (NTSecurity::setDefaultSecurity): Ditto.
3604 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3606 * main.cc (NTSecurity::setDefaultDACL): Use MS calculations for ACL
3609 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3611 * main.cc (NTSecurity::setDefaultDACL): Sanity check memory allocation.
3613 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3615 * main.cc (NTSecurity::setDefaultDACL): Adjust commented code for
3618 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3620 * main.cc (NTSecurity::NoteFailedAPI): Helper function.
3621 Use throughout NTSecurity routines.
3622 (NTSecurity::setDefaultDACL): Use dynamic memory for ACL storage.
3624 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3626 * main.cc (NTSecurity::setDefaultDACL): Disable ~ 50% of remaining
3629 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3631 * main.cc (NTSecurity::GroupInfo): Extract group query code.
3632 (NTSecurity::setDefaultDACL): Disable ~ 50% of code.
3634 2003-04-02 Robert Collins <rbtcollins@hotmail.com>
3636 * main.cc (NTSecurity::setDefaultSecurity): Disable ~ 50% of security
3639 2003-04-01 Robert Collins <rbtcollins@hotmail.com>
3641 * main.cc (NTSecurity::setDefaultSecurity): Remove double declaration of
3642 sz. User TokenGroupCollection to abstract token searching logic,
3643 eliminate isadmin and isuser temporary variables.
3644 (TokenGroupCollection): New class for querying token group information.
3646 2003-04-01 Robert Collins <rbtcollins@hotmail.com>
3648 * main.cc (NTSecurity::setDefaultSecurity): Extract esid initialisation.
3649 Move local variables to just before first use.
3650 SetTokenInformationFailures where being handled inconsistently.
3651 Remove assignments from if statements.
3652 (NTSecurity::esid): Rename to everyOneSID.
3653 (NTSecurity::initialiseEveryOneSID): new method.
3654 (NTSecurity::setDefaultDACL): Extract method for default DACL logic.
3656 2003-04-01 Robert Collins <rbtcollins@hotmail.com>
3658 * main.cc (SIDWrapper): Manage SID memory.
3659 (HANDLEWrapper): Likewise for HANDLES.
3660 (NTSecurity): Worker class for set_default_sec().
3661 (set_default_sec): Move body into NTSecurity::setDefaultSecurity().
3662 (NTSecurity::setDefaultSecurity): Eliminate goto out: via memory
3665 2003-04-01 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
3667 * cygwin.ico: Added two new resolutions, 64x64 and 72x72.
3669 2003-03-29 Robert Collins <rbtcollins@hotmail.com>
3671 * GUIDELINES: New file documenting code guidelines.
3673 2003-03-26 Max Bowsher <maxb@ukf.net>
3675 * .cvsignore: Add cfgaux.
3677 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
3679 * package_version.cc (_defaultversion::accessible): Override and make
3681 (_packageversion::accessible): Fix a couple of logic bugs resulting in
3683 * package_version.h (_packageversion::accessible): Make virtual.
3685 2003-03-25 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3687 * threebar.h (WM_APP_START_POSTINSTALL): New message.
3688 (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message.
3689 * threebar.cc (ThreeBarProgressPage::OnMessageApp):
3690 Add handling for WM_APP_START_POSTINSTALL and
3691 WM_APP_POSTINSTALL_THREAD_COMPLETE.
3692 * install.cc (do_install_thread): Set next_dialog to
3694 * desktop.cc (DesktopSetupPage::OnFinish): Move the
3695 do_postinstall call to ThreeBarProgressPage::OnMessageApp.
3696 * script.h (Script::fullName): New member function.
3697 (Script::run): New member function.
3698 (Script::ETCPostinstall): New static member constant.
3699 * script.cc (Script::fullName): Implement.
3700 (Script::run): Implement.
3701 (Script::ETCPostinstall): Define.
3702 (Script::isAScript): Use ETCPostinstall instead of a
3703 hardcoded string constant.
3704 (run): Enable "#if 0"'d code.
3705 * postinstall.cc (Progress): New extern variable.
3706 (RunFindVisitor::visitFile): Add script to vector
3708 (RunFindVisitor::_scripts): New member variable.
3709 (RunScript): New helper class for use in for_each.
3710 (do_postinstall_thread): Rename do_postinstall to. Add
3711 Progress bar and text setting. Add package count.
3712 (do_postinstall_reflector): New static function.
3713 (do_postinstall): Rename to do_postinstall_thread.
3714 Create a thread instead.
3716 2003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3718 * script.cc (run): Add file_out parameter.
3719 Redirect output of subprocess to file, creating the
3720 path if necessary. Minimize the script window.
3721 (run_script): Add optional to_log boolean parameter.
3722 If to_log, redirect output to temporary file and then
3723 import it into LOG_BABBLE.
3724 (OutputLog): New helper class.
3725 (operator<<): New operation on OutputLog.
3726 * script.h (run_script): Add optional to_log parameter.
3727 * postinstall.cc (RunFindVisitor::visitFile): Instruct
3728 run_script() to log script output.
3729 (do_postinstall): Ditto.
3731 2003-03-20 Robert Collins <rbtcollins@hotmail.com>
3733 * package_meta.cc (packagemeta::set_action): The logic
3734 test for the default action was reversed.
3736 2003-03-18 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3738 * postinstall.cc (do_postinstall): Filter out '*.done'.
3739 * FilterVisitor.h: New header file. Declare the
3740 FilterVisitor, Filter, and ExcludeNameFilter classes.
3741 * FilterVisitor.cc: New file. Implement FilterVisitor,
3742 Filter, and ExcludeNameFilter.
3743 * String++.h (String::matches): New instance function.
3744 * String++.cc (String::matches): Implement.
3745 (strmatch) Import and adapt for <buf,len> strings.
3746 * Makefile.am (setup_SOURCES): Add FilterVisitor.cc and
3747 FilterVisitor.h to value.
3749 2002-03-18 Max Bowsher <maxb@ukf.net>
3751 * LogFile.cc (LogFile::exit): Use CRT exit() instead of ExitProcess().
3752 Use passed exit_code even if been_here.
3753 Remove incorrect _CYGWIN_ preprocessor conditional.
3755 2003-03-16 Robert Collins <rbtcollins@hotmail.com>
3757 * package_db.h (PackageDBConnectedIterator): Typedef
3758 for connected loop detection collection iterator.
3759 * package_db.cc (ConnectedLoopDetector): An
3760 implementation of R.E. Tarjans strongly connected
3761 set visitor algorithm.
3762 * postinstall.cc (do_postinstall): Use the new iterator
3763 for visiting postinstall scripts.
3765 2003-03-16 Robert Collins <rbtcollins@hotmail.com>
3767 * install.cc: Introduce Installer class.
3768 (init_dialog): Rename to Installer::initDialog.
3769 (progress): Rename to Installer::progress.
3770 (standard_dirs): Rename to Installer::StandardDirs.
3771 (uninstall_one): Rename to Installer::uninstallOne.
3772 (replace_one): Rename to Installer::replaceOne.
3773 (log_ror_failure): Rename to
3774 Installer::replaceOnRebootFailed.
3775 (log_ror_success): Rename to
3776 Installer::replaceOnRebootSucceeded.
3777 (install_one_source): Rename to Installer::installOneSource.
3778 Note script files as they are installed.
3779 * package_version.cc (packageversion::addScript): Implement.
3780 (packageversion::scripts): Implement.
3781 * package_version.h (packageversion::addScript): Record the
3782 presence of a script.
3783 * script.h (Script): New class to track scripts.
3784 * postinstall.cc (do_postinstall): Iterate through the
3785 package listed scripts before searching for scripts.
3786 * String++.cc (String::substr): Second argument needed to
3788 * String++.h (String::substr): Second argument needed to
3791 2003-03-16 Max Bowsher <maxb@ukf.net>
3793 * .cvsignore: Create, to ignore configure, aclocal.m4, Makefile.in and
3796 2003-03-16 Max Bowsher <maxb@ukf.net>
3798 * UserSettings.cc (UserSettings::Instance): Remove premature return.
3800 2003-03-15 Robert Collins <rbtcollins@hotmail.com>
3802 * script.cc (run): Rename variable b to createSucceeded.
3804 2003-03-15 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3806 * script.cc (run): Close unneeded handles.
3808 2003-03-15 Robert Collins <rbtcollins@hotmail.com>
3810 * configure: Remove.
3811 * aclocal.m4: Remove.
3812 * Makefile.in: Remove.
3814 * cfgaux/compile: Remove.
3815 * cfgaux/config.guess: Remove.
3816 * cfgaux/config.sub: Remove.
3817 * cfgaux/depcomp: Remove.
3818 * cfgaux/install-sh: Remove.
3819 * cfgaux/ltmain.sh: Remove.
3820 * cfgaux/missing: Remove.
3821 * cfgaux/mkinstalldirs: Remove.
3823 2003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3825 * install.cc (replace_one): Clear Text3.
3827 2003-03-14 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3829 * install.cc (install_one_source): Add logging for successful
3830 replace-on-reboot scheduling. Factor out duplicate code.
3831 Set rebootneeded on Win9x.
3832 (log_ror_failure): New static function.
3833 (log_ror_success): New static function.
3835 2003-03-14 Robert Collins <rbtcollins@hotmail.com>
3837 * choose.cc (ChooserPage::OnNext): Fix iterator bug. Reported by
3838 Igor Pechtchanski <pechtcha@cs.nyu.edu>.
3840 2003-03-13 Max Bowsher <maxb@ukf.net>
3842 * Update included zlib to 1.1.4.
3844 2003-03-13 Robert Collins <rbtcollins@hotmail.com>
3846 * install.cc (do_install_thread): Use a query method rather than temp
3849 2003-03-09 Pavel Tsekov <ptsekov@gmx.net>
3851 * install.cc (do_install_thread): Use IDS_SKIP_PACKAGE
3852 instead of IDS_CORRUPT_PACKAGE when asking the user to take
3853 action if the hash verification check fails for a source package.
3854 Do not increase the value of 'total_bytes' variable if the
3855 user chooses to skip over a package, which failed the hash
3858 2003-03-10 Max Bowsher <maxb@ukf.net>
3860 * Makefile.am: Add foreign to AUTOMAKE_OPTIONS.
3862 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
3864 * UserSettings.cc (UserSettings::init): Really initialize all members.
3866 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
3868 * Exception.h: Add a logic error exception id.
3869 * Makefile.am: Add new sources.
3870 * UserSettings.cc: New file.
3871 * UserSettings.h: New file.
3872 * UserSetting.cc: New file.
3873 * UserSetting.h: New file.
3874 * site.h: Add a SiteSetting as example of a UserSetting.
3875 * site.cc (ChosenSites): Add a instance of SiteSetting to trigger
3878 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
3880 * compress_bz.cc (compress_bz::read): Adjust incorrect assignment of
3882 (compress_bz::error): Return lasterr which will indicate any error.
3884 2003-03-10 Robert Collins <rbtcollins@hotmail.com>
3886 * choose.h (ChooserPage): Override OnActivate.
3887 * choose.cc (ChooserPage::OnActivate): Refresh the current view when
3888 activating the dialog.
3890 2003-03-09 Robert Collins <rbtcollins@hotmail.com>
3892 * package_version.cc (_defaultversion::pick(bool)): Override this and
3894 (packageversion::pick(bool): Use a mutator function rather than direct
3896 * package_version.h (_packageversion::pick(bool)): Move method from
3899 2003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3901 * install.cc (install_one_source): Remove the MD5 verification
3903 Delay the creation of the package listing file.
3904 (do_install_thread): Check the hashes for packages which need
3905 to be installed before the uninstall step. Allow the user to
3906 skip over packages, which fail the hash verification.
3907 (md5_one): Define new function.
3908 * res.rc (IDS_SKIP_PACKAGE): New string resource.
3909 * resource.h (IDS_SKIP_PACKAGE): New macro definition.
3911 2003-02-16 Pavel Tsekov <ptsekov@gmx.net>
3913 * Exception.h: Declare new constructor.
3914 (Exception::_message): Change the type from 'const char *' to
3916 (Exception::~Exception): Implement destructor (make gcc shut up).
3917 * Exception.cc: Implement new constructor.
3918 (Exception::what): Use String::cstr_oneuse ().
3919 * download.cc (validateCachedPackage): Use the constructor, which
3920 takes String& as its second argument, when throwing objects
3922 (check_for_cached): Ditto.
3923 * install.cc (install_one_source): Ditto.
3925 2003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3927 * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
3929 (IDS_MISSING_LOG): New string resource.
3930 * resource.h (IDS_MISSING_LOG): New resource.
3931 * LogFile.cc (LogFile::exit): Pass log filename for
3932 LOG_BABBLE to note().
3933 (LogFile::getFileName): New function.
3934 * LogFile.h (LogFile::getFileName): New function.
3936 2003-02-01 Igor Pechtchanski <pechtcha@cs.nyu.edu>
3938 * String++.cc: Don't include concat.h.
3939 * Makefile.am: Remove concat.cc and concat.h references.
3941 * concat.cc: Remove.
3943 2003-03-09 Max Bowsher <maxb@ukf.net>
3945 * bootstrap.sh: Add sanity check of current directory.
3946 Recurse into libgetopt++ if needed.
3948 2003-03-09 Robert Collins <rbtcollins@hotmail.com>
3950 * Update readme of bugs and wishes.
3952 2003-03-05 Max Bowsher <maxb@ukf.net>
3954 * netio.cc (save_dialog): Allocate an empty string if the password is
3955 null, so that an empty password is accepted elsewhere in setup.
3956 (check_if_enable_ok): An empty password is OK.
3958 2003-03-05 Brian Keener <bkeener@thesoftwaresource.com>
3960 * PickView.cc (PickView::views): Add two new views for Skipped
3961 packages and Installed Packages not requiring update.
3962 (PickView::set_headers () ): Ditto.
3963 (PickView::clear_view (void) ): Ditto.
3964 (PickView::views::caption () ): Add two new captions for the new
3965 views added for Skipped and Installed Packages.
3966 (PickView::scroll () ): Modify Scroll Bar property to Disable
3967 instead of disappearing when there is nothing to Scroll.
3968 * PickView.h: Add two new views for Skipped packages and Installed
3969 packages to public class view.
3970 * choose.cc (list_click () ): Modify Scroll Bar property to Disable
3971 instead of disappearing when there is nothing to Scroll.
3972 (listview_proc () ): Ditto.
3973 (set_view_mode): Add two new views for Skipped Packages and Installed
3974 Packages not requiring update. Modify Scroll Bar property to Disable
3975 instead of disappearing when there is nothing to scroll.
3976 * res.rc (IDD_CHOOSE): Reposition Radio Buttons, View Selection
3977 Button and View Button Caption to make room for longer captions.
3979 2003-03-04 Max Bowsher <maxb@ukf.net>
3981 * compress_gz.cc (compress_gz::construct):
3982 Fix broken checkin dated 2002-07-03.
3984 2003-02-28 Max Bowsher <maxb@ukf.net>
3986 * main.cc (set_default_sec): Add logging.
3988 2003-02-28 Pierre Humblet <pierre.humblet@ieee.org>
3990 * main.cc (set_default_dacl): Replace with set_default_sec.
3991 (set_default_sec): Attempt to change the default group to
3992 Users or Administrators if it is None, in addition to setting
3993 Everyone in the default DACL.
3994 (main): Call set_default_sec instead of set_default_dacl.
3996 2003-01-31 Max Bowsher <maxb@ukf.net>
3998 * install.cc (install_one_source): Fix spacing in log message.
4000 2003-01-19 Max Bowsher <maxb@ukf.net>
4002 * resource.h (IDC_CHOOSE_KEEP): Define.
4003 * res.rc (IDD_CHOOSE): Add radio button IDC_CHOOSE_KEEP.
4004 * choose.cc (create_listview): Add IDC_CHOOSE_KEEP to ta[].
4005 (ChooserPage::OnMessageCmd): Handle new IDC_CHOOSE_KEEP button.
4007 2003-01-15 Max Bowsher <maxb@ukf.net>
4009 * mkdir.cc [_CYGWIN_]: Implement what was pseudocode.
4010 * io_stream.h [__CYGWIN__]: Don't typedef ssize_t.
4011 * proppage.h: Include "win32.h" instead of <windows.h>.
4013 2003-01-15 Max Bowsher <maxb@ukf.net>
4015 * mount.cc [MAINTAINER_FEATURES]: Add --override-registry-name option.
4017 2002-12-11 Abraham Backus <abraham@backus.com>
4019 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Leave port out of Host header,
4022 2002-12-11 Max Bowsher <maxb@ukf.net>
4024 * package_meta.cc: Change 'endl' to 'endLog' as appropriate.
4025 * package_version.cc: Ditto.
4027 2002-09-22 Max Bowsher <maxb@ukf.net>
4029 * PickView.cc (pkg_headers): Rename column 'Category' to 'Categories'.
4030 * package_meta.h (packagemeta::getReadableCategoryList): Declare.
4031 * package_meta.cc (packagemeta::getReadableCategoryList): Implement.
4032 * PickPackageLine.cc (PickPackageLine::paint): Change to use
4033 getReadableCategoryList.
4034 Fix x2 argument to IntersectClipRect.
4036 2002-11-25 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
4038 * window.h (Window::GetWindowRect): New method declaration.
4039 (Window::GetClientRect): Ditto.
4040 (Window::MoveWindow): Ditto.
4041 (Window::ScreenToClient): Ditto.
4042 * window.cc (REFLECTION_INFO): Remove.
4043 (ReflectionInfo): Remove.
4044 (Window::FirstWindowProcReflector): Use the WM_NCCREATE message instead
4045 of the horrid REFLECTION_INFO hack to hook the Window instance to the
4047 (Window::WindowProcReflector): Use GetWindowLongPtr() now that it's
4049 (Window::Create): Change to use new WM_NCCREATE reflection procedure
4051 (Window::GetWindowRect): New method.
4052 (Window::GetClientRect): New method.
4053 (Window::MoveWindow): New method.
4054 (Window::CenterWindow): Use new methods, also specify "::" for some non-
4055 member functions with the same names.
4056 (Window::ScreenToClient): New method.
4058 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
4060 * AntiVirus.cc: Change the short option again! It's now 'A'.
4061 * desktop.cc (etc_profile): Remove.
4062 (make_etc_profile): Remove.
4064 (make_passwd_group): Remove.
4065 (do_desktop_setup): Don't call removed functions.
4067 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
4069 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fix my botched application of
4072 2002-07-08 Marcel Telka <marcel@telka.sk>
4074 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fixed decoding of the FTP
4075 reply (code 227) to the PASV command.
4077 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
4079 * IniDBBuilderPackage.cc (IniDBBuilderPackage::~IniDBBuilderPackage):
4080 Sort the packages db once all the new packages have been added.
4081 * IniDBBuilderPackage.h (IniDBBuilderPackage::~IniDBBuilderPackage):
4084 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
4086 * choose.cc (ChooserPage::OnNext): Remove extracted comment.
4087 * package_version.cc (processOneDependency): Return once selecting
4088 a package (bugfix to prevous rework).
4089 Log if the default trust fails the package specification.
4091 2002-11-26 Robert Collins <rbtcollins@hotmail.com>
4093 * package_meta.h (packagemeta::logAllVersions): Declare.
4094 (packagemeta::trustLabel): Ditto.
4095 * choose.cc (ChooserPage::OnNext): Get each package to log all it's
4097 * package_meta.cc (packagemeta::logAllVersions): Implement.
4098 (packagemeta::trustLabel): Ditto.
4100 2002-11-25 Robert Collins <rbtcollins@hotmail.com>
4102 * AntiVirus.cc: Change 'd' to 'D' to fix command line conflict.
4104 2002-11-25 Robert Collins <rbtcollins@hotmail.com>
4106 * AntiVirus.cc: New file.
4107 * AntiVirus.h: Ditto.
4108 * LogFile.cc: Include AntiVirus.h for class definition.
4109 (LogFile::exit): Trigger AntiVirus::AtExit().
4110 * MakeFile.am(setup_SOURCES): Add AntiVirus files.
4111 * autoload.c: Declare Service Control Manager related API's.
4112 * main.cc: Include AntiVirus.h for class definition.
4113 (main): Add the AntiVirus page in.
4114 * res.rc: Define IDD_VIRUS.
4115 * resource.h: Define IDD_VIRUS related control ID's.
4116 * splash.h: Override OnNext.
4117 * splash.cc: Only show AntiVirus page when one has been detected.
4120 2002-11-25 Robert Collins <rbtcollins@hotmail.com>
4122 * package_version.cc (DependencyProcessor): Create convenience class.
4123 (select): Extract version selection method.
4124 (processOneDependency): Check for a satisfactory trusted version
4127 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
4129 * main.cc (main): Use the factory for LogFile.
4130 * String++.cc: Update to use sstream.
4131 (String::String): Use a ostringstream for libC++ 3.2.
4132 * LogFile.h (LogFile): Make createLogFile static.
4134 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
4136 * main.cc (main): Oops, pass LogSingleton a reference, not a pointer.
4138 2002-11-04 Max Bowsher <maxb@ukf.net>
4140 * Exception.h (Exception::what): Add throw() specification,
4141 to agree with libstdc++-v3.
4142 * Exception.cc (Exception::what): Ditto.
4143 * IniDBBuilderPackage.h: Add 'std::' where needed.
4144 * PickCategoryLine.h: Ditto.
4145 * category.h: Ditto.
4146 * package_db.h: Ditto.
4147 * package_meta.h: Ditto.
4148 * package_source.h: Ditto.
4149 * package_version.h: Ditto.
4151 * win32.h: Define NOMINMAX before including <windows.h>.
4152 * package_meta.cc: Add 'using namespace std;'.
4153 (packagemeta::set_requirements): Remove default parameter values
4154 from definition (gcc3 likes them only in declaration).
4155 * package_version.cc: Add 'using namespace std;'.
4156 (packageversion::set_requirements): Remove default parameter
4157 values from definition (gcc3 likes them only in declaration).
4159 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
4161 * compress_bz.cc: Don't include bzlib.h directly, the compress_bz.h
4164 2002-11-04 Max Bowsher <maxb@ukf.net>
4166 * compress_bz.h: #undef small before including bzlib.h - if we are
4167 going to hide the fact that we are _WIN32 from bzlib, then we need
4168 to #undef small for it as well (bad windows.h clash).
4170 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
4172 * localdir.cc: Update the extern LogFile to be a pointer.
4173 (save_local_dir): Change . to -> for the above.
4174 * main.cc (theFile): Change from an instance to a pointer.
4175 (main): Change . to -> for the above.
4177 2002-11-10 Robert Collins <rbtcollins@hotmail.com>
4179 * LogFile.cc: use 'std::' where needed throughout.
4180 (LogFile::createLogFile): Implement a factory for LogFile.
4181 (LogFile::LogFile): Update for use with the factory, and to
4182 handle the latest g++ library changes.
4183 (LogFile::operator()): Ditto.
4184 (LogFile::endEntry()): Ditto.
4186 * LogSingleton.cc: Ditto.
4187 * LogSingleton.h: Ditto.
4189 2002-11-04 Max Bowsher <maxb@ukf.net>
4191 * String++.h: Add 'std::' where needed.
4193 2002-11-04 Max Bowsher <maxb@ukf.net>
4195 * IniDBBuilderPackage.cc: Add 'using namespace std;'.
4196 * IniParseFindVisitor.cc: Ditto.
4197 * LogFile.cc: Ditto.
4198 * LogSingleton.cc: Ditto.
4199 * PickView.cc: Ditto.
4200 * String++.cc: Ditto.
4202 * download.cc: Ditto.
4204 * install.cc: Ditto.
4205 * io_stream.cc: Ditto.
4206 * io_stream_file.cc: Ditto.
4207 * package_db.cc: Ditto.
4211 2002-11-04 Max Bowsher <maxb@ukf.net>
4213 * LogSingleton.h: Add 'std::' where needed.
4215 2002-11-04 Max Bowsher <maxb@ukf.net>
4217 * archive_tar_file.cc: Include <algorithm>.
4218 Change min(a,b) to std::min(a,b)
4219 * compress_bz.cc: Ditto.
4220 * compress_gz.cc: Ditto.
4222 2002-11-04 Max Bowsher <maxb@ukf.net>
4224 * res.rc: Change a #-comment (invalid) to a //-comment.
4226 2002-11-04 Max Bowsher <maxb@ukf.net>
4228 * Makefile.am (%.o: %.rc): Make windres use $(CC) not hardcoded gcc.
4229 (inilint_LDADD): Remove -lstd++.
4230 (setup_LDADD): Ditto.
4232 2002-09-22 Max Bowsher <maxb@ukf.net>
4234 * IniDBBuilderPackage.cc: Update DEBUG code to current class
4237 2002-09-21 Robert Collins <rbtcollins@hotmail.com>
4239 * choose.h: Add OnUnattended method.
4240 * desktop.cc (DesktopSetupPage::OnInit): Allow fine grained
4241 control via command line options.
4242 (DesktopSetupPage::OnUnattended): Implement.
4243 (DesktopSetupPage::OnMessageApp): Implement.
4244 * desktop.h (DesktopSetupPage::OnUnattended): declare.
4245 (DesktopSetupPage::OnMessageApp): Ditto.
4246 * download.cc (do_download_thread): Support unattended mode.
4247 * install.cc (do_install_thread): Ditto.
4248 * localdir.h: Ditto.
4249 * main.cc (main): Ditto.
4250 * net.cc (NetPage::OnUnattended): Ditto.
4251 * net.h (NetPage::OnUnattended): Declare.
4252 * proppage.cc (PropertyPage::DialogProc): Support unattended mode.
4253 * proppage.h (PropertyPage::OnUnattended): Declare.
4254 * root.cc (RootPage::OnInit): Support unattended mode.
4255 (RootPage::OnUnattended): Implement.
4256 * root.h (RootPage::OnUnattended): Declare.
4257 * site.cc (register_saved_site): Extract Method from get_saved_sites.
4258 (get_saved_sites): Remove common code for adding a site.
4259 (SitePage::OnInit): Support unattended mode.
4260 (SitePage::OnUnattended): Implement.
4261 * site.h (SitePage::OnUnattended): Declare.
4262 * source.cc (SourcePage::OnActivate): Support unattended mode.
4263 (SourcePage::OnUnattended): Implement.
4264 * source.h (SourcePage::OnUnattended): Declare.
4265 * splash.h (SplashPage::OnUnattended): Declare.
4266 * state.cc (unattended_mode): Declare.
4267 * state.h (unattended_mode): Declare.
4268 * threebar.h (ThreeBarProgressPage::OnUnattended): New method.
4270 2002-09-21 Robert Collins <rbtcollins@hotmail.com>
4272 * res.rc: Commit Harry Johnston's dialog caption patch. From July.
4274 2002-07-15 Robert Collins <rbtcollins@hotmail.com>
4276 * package_version.cc (packageversion::sources): Implement this.
4277 * download.cc (do_download_thread): Support multiple files per package.
4279 2002-07-15 Robert Collins <rbtcollins@hotmail.com>
4281 * package_version.h (packageversion::sources): Support multiple files in
4282 a single package version.
4283 * package_version.cc (_packageversion::accessible): Ditto.
4284 (packageversion::source): Ditto.
4286 2002-07-15 Robert Collins <rbtcollins@hotmail.com>
4288 * iniparse.y: Implement support for multiple source files for a source
4290 * IniDBBuilder.h (IniDBBuilder::buildSourceFile): Ditto.
4291 * IniDBBuilderPackage.h (IniDBBuilder::buildSourceFile): Ditto.
4292 * IniDBBuilder.cc (IniDBBuilder::buildSourceFile): Ditto.
4293 * IniDBBuilderPackage.cc (IniDBBuilder::buildSourceFile): Implement a
4294 stub as preparation.
4296 2002-07-13 Robert Collins <rbtcollins@hotmail.com>
4298 * PickPackageLine.cc (PickPackageLine::click): Set requirements for
4299 packages under all circumstances - slightly higher overheader, simpler
4301 * download.cc (do_download_thread): Correctly download source
4303 * package_meta.cc (checkForInstalled): Remove.
4304 (checkForUpgradeable): Ditto.
4305 (checkForSatisfiable): Ditto.
4306 (processOneDependency): Ditto.
4307 (packagemeta::set_requirements): Move guts to packageversion.
4308 * package_version.cc (checkForInstalled): Copied from package_meta.cc.
4309 (checkForUpgradeable): Ditto.
4310 (checkForSatisfiable): Ditto.
4311 (processOneDependency): Ditto.
4312 (packageversion::set_requirements): Ditto.
4313 * package_version.h (packageversion::set_requirements): Declare.
4315 2002-07-13 Robert Collins <rbtcollins@hotmail.com>
4317 * IniDBBuilder.cc (IniDBBuilder::buildBeginBuildDepends): Implement.
4318 (IniDBBuilder::buildBeginBinary): Implement.
4319 * IniDBBuilder.h (IniDBBuilder::buildBeginBuildDepends): Declare.
4320 (IniDBBuilder::buildBeginBinary): Ditto.
4321 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildBeginBuildDepends):
4323 (IniDBBuilderPackage::buildBeginBinary): Ditto.
4324 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildBeginBuildDepends):
4326 (IniDBBuilderPackage::buildBeginBinary): Ditto.
4327 * inilex.l: Recognise Build-Depends-Indep, [,], >, < and remove
4329 * iniparse.y: Full support for parsing a debian Sources file in-line in
4331 * package_version.cc (packageversion::binaries): Implement.
4332 * package_version.h (packageversion::binaries): Declare list of what
4333 packages are created from a given source package.
4334 (_packageversion::binaries): Ditto.
4336 2002-07-10 Robert Collins <rbtcollins@hotmail.com>
4338 * iniparse.y: Add basis for support for parsing a debian Sources file.
4341 2002-07-09 Robert Collins <rbtcollins@hotmail.com>
4343 Change custom container code for packagedb::packages to STL containers
4345 * IniDBBuilderPackage.cc: Ditto.
4346 * PickView.cc: Ditto.
4348 * desktop.cc: Ditto.
4349 * download.cc: Ditto.
4350 * install.cc: Ditto.
4351 * package_db.cc: Ditto.
4352 * package_db.h: Ditto.
4353 * Makefile.am: Remove list.h references.
4356 2002-07-08 Max Bowsher <maxb@ukf.net>
4358 * PickView.cc (PickView::PickView): Set font of package list header to
4359 the same as used in the rest of the package list.
4361 2002-07-08 Robert Collins <rbtcollins@hotmail.com>
4363 * install.cc (NoReplaceOnReboot): New command line option to prevent
4364 replacing in use files.
4365 (install_one_source): Check the option and use it.
4366 * README: Update TODO lists.
4368 2002-07-08 Robert Collins <rbtcollins@hotmail.com>
4370 * PickCategoryLine.cc: Change bucket to use STL container syntax
4372 (PickCategoryLine::paint): Use new Category type syntax.
4373 * PickCategoryLine.h: Use STL vectors rather than custom containers
4375 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageCategory):
4376 Use new add_category syntax.
4377 * PickView.cc (PickView::insert_pkg): Use new Category type syntax.
4378 (PickView::insert_category): Ditto.
4379 (PickView::init_headers): Ditto.
4380 * category.cc: Trim obsolete code.
4381 * category.h: Replace interconnecting class with a typedef to
4382 facilitate leveraging STL maps.
4383 * choose.cc (fill_missing_category): Use updated pkg.add_category
4385 (default_trust): Use new Category type syntax.
4386 (set_view_mode): Ditto.
4387 (create_listview): Ditto.
4388 * package_db.cc (categories): Ditto.
4389 * package_db.h: Update headers list to include needed headers.
4390 (packagedb::categories): Replace custom list with STL map.
4391 * package_meta.cc: Use new Category type syntax throughout.
4392 (packagemeta::add_category): Implement new syntax.
4393 * package_meta.h: Remove commented out source.
4394 (packagemeta::add_category): Update syntax to decouple interface from
4397 2002-07-06 Christopher Faylor <cgf@redhat.com>
4399 * site.cc (do_download_site_info_thread): Correct spelling error.
4401 2002-07-06 Robert Collins <rbtcollins@hotmail.com>
4403 * PickCategoryLine.h: Include required header list.h.
4404 * PickPackageLine.cc (PickPackageLine::paint): Adjust to use STL
4405 containers for listing of packages per category and vice verca.
4406 * PickView.cc (PickView::insert_pkg): Ditto.
4407 (PickView::insert_category): Ditto.
4408 * String++.h (String::caseless): STL helper to allow trivial containers
4409 of Strings with case insensitive comparisons.
4410 * category.h: Adjust to use STL containers for listing of packages per
4411 category and vice verca.
4412 * choose.cc (fill_missing_category): Ditto.
4413 (default_trust): Ditto.
4414 (ChooserPage::OnNext): Ditto.
4415 * package_meta.cc (CategoryPackage::~CategoryPackage): Remove.
4416 (packagemeta::packagemeta): Adjust for new category list name.
4417 (packagemeta::~packagemeta): Adjust to use STL containers for listing
4418 of packages per category and vice verca.
4419 (packagemeta::set_action): Ditto.
4420 * package_meta.h (CategoryPackage): Remove.
4421 (packagemeta): Adjust to use STL containers for listing of packages per
4422 category and vice verca.
4424 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
4426 * io_stream.cc: Use STL containers rather than custom ones.
4427 (io_stream::registerProvider): Ditto.
4428 (findProvider): Ditto.
4430 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
4432 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4433 Use STL collections for download site collections.
4434 (IniDBBuilderPackage::add_correct_version): Ditto.
4435 (IniDBBuilderPackage::process_src): Ditto.
4436 * PickPackageLine.cc (PickPackageLine::click): Use the packageversion
4437 accessible() call to abstract package availability.
4438 * choose.cc (scanAVersion): Use STL collections for download site
4440 * download.cc (check_for_cached): Ditto.
4441 (download_one): Ditto.
4442 * package_meta.cc (packagemeta::set_action): Use the packageversion
4443 accessible() call to abstract package availability.
4444 * package_source.h: Use STL containers rather than custom containers.
4445 (site): Create a == operator to allow STL container use.
4446 (packagesource::sites): Use STL containers rather than custom
4448 * package_version.cc (_packageversion::accessible): Use STL containers
4449 for download site containers.
4451 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
4453 * LogFile.cc: Use STL containers rather than custom containers.
4454 (filedef): Create == and < operators for STL use.
4455 (files): Convert to an STL set.
4456 (LogFile::setFile): Use STL operations on files.
4457 (LogFile::exit): Ditto.
4459 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
4461 * ini.cc (do_remote_ini): Use STL collection for site collection.
4462 * site.cc: Include site.h first to ensure it's parsable standalone.
4464 (site_list): Convert to an STL container.
4465 (all_site_list): Ditto.
4466 (site_list_type::site_list_type): Implement copy constructor.
4467 (site_list_type::operator=): Implement assignment operator.
4468 (site_list_type::operator ==): Implement.
4469 (site_list_type::operator <): Ditto.
4470 (save_dialog): Use STL collection calls for site collection.
4471 (save_site_url): Ditto.
4472 (get_site_list): Ditto.
4473 (get_saved_sites): Ditto.
4474 (do_download_site_info_thread): Ditto.
4475 (SitePage::OnNext): Ditto.
4476 (SitePage::PopulateListBox): Ditto.
4477 (SitePage::OnMessageCmd): Ditto.
4478 * site.h: Use STL vectors instead of custom code.
4479 (site_list_type::site_list_type): Declare.
4480 (site_list_type::operator=): Ditto.
4481 (site_list_type::operator ==): Ditto.
4482 (site_list_type::operator !=): Ditto.
4483 (site_list_type::operator <): Ditto.
4484 (site_list_type::operator <=): Ditto.
4485 (site_list_type::operator >): Ditto.
4486 (site_list_type::operator >=): Ditto.
4487 (site_list): Convert to an STL container.
4488 (all_site_list): Ditto.
4490 2002-07-05 Robert Collins <rbtcollins@hotmail.com>
4492 * choose.cc (default_trust): Check package accessibility before
4493 triggering an install. (Suggested by Pavel).
4495 2002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4497 * compress_gz.cc (compress_gz::construct): Always initialize key members
4498 to ensure the destructor does the right thing.
4500 2002-07-03 Pavel Tsekov <ptsekov@gmx.net>
4502 * filemanip.cc (parse_filename): Do not try to parse empty
4503 strings (filenames).
4504 * package_db.cc (packagedb::packagedb): For each line check if sscanf()
4505 extracted good package name and filename.
4507 2002-07-03 Robert Collins <rbtcollins@hotmail.com>
4509 * package_meta.cc (packagemeta::set_requirements): Automatically select
4510 version of dependent packages that satisfies the requirements.
4511 Use processOneDependency to trigger the install of those packages.
4512 (checkForInstalled): Check that the package remains installed.
4513 (processOneDependency): Helper function for dependent packages.
4514 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackage): Add more
4516 Clear out all current state on new packages.
4517 (IniDBBuilderPackage::add_correct_version): Copy the dependency list
4520 2002-07-02 Robert Collins <rbtcollins@hotmail.com>
4522 * Makefile.am (inilint_SOURCES): Add PackageSpecification sources.
4523 nb: inilint is still incomplete, as the packageversion code is not
4524 ready for database-less linking.
4525 * site.cc (get_site_list): When the same site is reentered by the user
4526 replace the old one. (Suggested by John Marshall).
4528 2002-07-02 Robert Collins <rbtcollins@hotmail.com>
4530 * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
4531 Clear out package selections when generating implicit source packages.
4532 * PackageSpecification.cc (PackageSpecification::satisfies): Implement.
4533 (PackageSpecification::_operators::satisfies): Implement.
4534 * PackageSpecification.h (PackageSpecification::_operators::satisfies):
4535 Worker function for testing versions.
4537 2002-07-01 Robert Collins <rbtcollins@hotmail.com>
4539 * IniDBBuilder.cc (IniDBBuilder::buildPackageRequirement): Remove.
4540 * IniDBBuilder.h (IniDBBuilder::buildPackageRequirement): Ditto.
4541 * IniDBBuilderPackage.cc: Use the STL algorithms.
4542 Change cpv to cbpv throughout. Adjust -> to ., and use the new accessor
4543 functions for the same variable throughout.
4544 (IniDBBuilderPackage::IniDBBuilderPackage): Initialise new members.
4545 (IniDBBuilderPackage::buildPackage): Use new cygpackage syntax,
4546 and set an empty source package.
4547 (IniDBBuilderPackage::buildPackageInstall): Use the new source member
4548 to record an install package.
4549 (IniDBBuilderPackage::buildPackageSource): Move source package logic
4550 out from process_src, as it now occurs at separate times.
4551 (IniDBBuilderPackage::buildPackageRequirement): Remove.
4552 (IniDBBuilderPackage::buildSourceName): Use renamed package
4553 specifiation accessor for clarity.
4554 (IniDBBuilderPackage::buildSourceNameVersion): Ditto.
4555 (IniDBBuilderPackage::add_correct_version): Use STL iterators rather
4557 Remove source package references.
4558 (IniDBBuilderPackage::process_src): Remove source package code as it's
4559 now handled separately.
4560 Set Path information before merging versions, to prevent dangling
4562 * IniDBBuilderPackage.h (IniDBBuilderPackage::buildPackageRequirement):
4564 (IniDBBuilderPackage::cpv): Remove.
4565 (IniDBBuilderPackage::cbpv): New generic binary working variable.
4566 (IniDBBuilderPackage::cspv): Ditto, but for source packages.
4567 (IniDBBuilderPackage::csp): Source package variable for disjoint
4569 * Makefile.am (AM_CFLAGS): Remove -Winline to allow stl set code
4570 to compile. If it compiles cleanly in gcc 3.1, then reinstate.
4571 * PickPackageLine.cc: Adjust packageversion accessors to the new
4572 reference calls. (i.e. -> to .) throughout.
4573 (PickPackageLine::paint): Use accessible() for clarity.
4574 Use new split out source package logic.
4575 (PickPackageLine::click): Ditto.
4576 * PickView.cc (PickView::init_headers): Adjust packageversion accessors
4577 to the new reference calls. (i.e. -> to .) throughout.
4578 Use new split out source package logic.
4579 * choose.cc: Don't depend on a specific package type.
4580 Adjust packageversion accessors to the new reference calls. (i.e. -> to
4582 (set_existence): Use accessible () for clarity.
4583 (default_trust): Simplify a little.
4584 (scanAVersion): Factored out code from scan_downloaded_files for
4586 (scan_downloaded_files): Factor out inner loop for clarity.
4587 (ChooserPage::OnNext): Don't dump the dependency list,
4588 it's parsing is robust now!.
4589 * cygpackage.cc (createInstance): Use a factory method to create new
4591 (cygpackage::cygpackage): Make this private for use by the factory.
4592 (cygpackage::setCanonicalVersion): Renamed from set_canonical_version.
4593 Remove key usage as it's obsolete.
4594 * cygpackage.h (cygpackage): Inherit from _packageversion, not
4596 (cygpackage::createInstance): New factory.
4597 (cygpackage::cygpackage): Make private.
4598 * desktop.cc (make_passwd_group): Use new packageversion reference.
4599 * download.cc (do_download_thread): Use changeRequested() for clarity.
4600 Use new packageversion reference calls.
4601 * iniparse.y (REQUIRES): Reuse the packageList code and dump the one-off
4603 * install.cc: Adjust -> to ., and use the new accessor functions for
4604 packageversion throughout.
4605 * package_db.cc: Adjust -> to ., and use the new accessor functions for
4606 packageversion throughout.
4607 (packagedb::packagedb): Use the new cygpackage factory.
4608 (packagedb::flush): Leverage String to remove buffer overflow chance in
4610 (packagedb::findBinary): Find a binary meta package that has a version
4611 matching a given specification.
4612 (packagedb::findSource): Ditto, but for source.
4613 * package_db.h (packagedb::findBinary): Declare.
4614 (packagedb::findSource): Ditto.
4615 * package_meta.cc: Adjust packageversion accessors to the new
4616 reference calls. (i.e. -> to .) throughout.
4617 Include the package_meta header first to ensure it parses standalone.
4618 Use the STL algorithms.
4619 (packagemeta::packagemeta): Create a copy constructor to allowing
4620 cloning binary package metadata to source package metadata.
4621 (packagemeta::~packagemeta): Use the STL coleltion code rather than
4622 custom collection code.
4623 (packagemeta::add_version): Ditto.
4624 (packagemeta::set_installed): Ditto.
4625 (packagemeta::SDesc): Ditto.
4626 (hasSDesc): Helper function for find_if.
4627 (checkForInstalled): Ditto.
4628 (checkForUpgradeable): Ditto.
4629 (checkForSatisfiable): Ditto.
4630 (packagemeta::action_caption): Update for split out source packages.
4631 (packagemeta::set_action): Ditto.
4632 (packagemeta::set_requirements): Support multi-valued dependency
4633 lists - a|b & c|d - with versioned package specifications.
4634 (packagemeta::accessible): Helper member to improve abstraction.
4635 (packagemeta::sourceAccessible): Ditto.
4636 * package_meta.h: Adjust packageversion accessors to the new
4637 reference calls. (i.e. "->" to "." and"*" to "" ) throughout.
4638 (packagemeta::packagemeta): Declare copy constructor.
4639 Remove self initialising members.
4640 (packagemeta::set_action): Update parameters for new packageversion.
4641 (packagemeta::trustp): Ditto.
4642 (packagemeta::versions): Becomes an STL set.
4643 * package_source.h (packagesource::Cached): Const correctness change.
4644 * package_version.cc: Rewrite the packageversion interface to remove
4645 the cygpackage nonvirtual members, and provide a copy by value,
4646 pointer semantics reference counting wrapper class to ease use and
4647 comparison of packageversions.
4648 Change existing packageversion class to _packageversion throughout.
4649 (_defaultversion): A trivial concrete class to prevent specialcasing
4650 the default constructor for packageversion;
4651 (packageversion::packageversion): Implement.
4652 (packageversion::~packageversion): Ditto.
4653 (packageversion::operator=): Ditto.
4654 (packageversion::operator !): Ditto.
4655 (packageversion::operator bool): Ditto.
4656 (packageversion::operator ==): Ditto.
4657 (packageversion::operator !=): Ditto.
4658 (packageversion::operator <): Ditto.
4659 (packageversion::Name): Ditto.
4660 (packageversion::Canonical_version): Ditto.
4661 (packageversion::setCanonicalVersion): Ditto.
4662 (packageversion::getfirstfile): Ditto.
4663 (packageversion::getnextfile): Ditto.
4664 (packageversion::SDesc): Ditto.
4665 (packageversion::set_sdesc): Ditto.
4666 (packageversion::LDesc): Ditto.
4667 (packageversion::set_ldesc): Ditto.
4668 (packageversion::sourcePackage): Ditto.
4669 (packageversion::sourcePackageSpecification): Ditto.
4670 (packageversion::setSourcePackageSpecification): Ditto.
4671 (packageversion::depends): Ditto.
4672 (packageversion::predepends): Ditto.
4673 (packageversion::recommends): Ditto.
4674 (packageversion::suggests): Ditto.
4675 (packageversion::replaces): Ditto.
4676 (packageversion::conflicts): Ditto.
4677 (packageversion::provides): Ditto.
4678 (packageversion::picked): Ditto.
4679 (packageversion::pick): Ditto.
4680 (packageversion::changeRequested): Ditto.
4681 (packageversion::uninstall): Ditto.
4682 (packageversion::source): Ditto.
4683 (packageversion::accessible): Ditto.
4684 (_packageversion::sourcePackage): Ditto.
4685 (_packageversion::accessible): Ditto.
4686 (_packageversion::changeRequested): Ditto.
4687 * package_version.h: Rewrite the packageversion interface to remove
4688 the cygpackage nonvirtual members, and provide a copy by value,
4689 pointer semantics reference counting wrapper class to ease use and
4690 comparison of packageversions.
4691 Change existing packageversion class to _packageversion throughout.
4692 (Dependency): Remove.
4693 (packageversion): New wrapper class.
4694 (_packageversion): Renamed from packageversion.
4695 (_packageversion::setCanonicalVersion): New method.
4696 (_packageversion::sourcePackage): Ditto.
4697 (_packageversion::sourcePackageSpecification): Ditto.
4698 (_packageversion::setSourcePackageSpecification): Ditto.
4699 (_packageversion::changeRequested): Ditto.
4700 (_packageversion::bin): Rename to source.
4701 (_packageversion::src): Remove.
4702 (_packageversion::accessible): New method.
4703 (_packageversion::references): Allow reference counting.
4704 (_packageversion::sourceVersion): Cached the best-match source
4707 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
4709 * compress_bz.h (compress_bz::position): Track how much has been read.
4710 * compress_bz.cc (compress_bz::compress_bz): And initialise it.
4711 (compress_bz::read): Track amount read by the client.
4712 (compress_bz::tell): And report it when asked.
4714 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
4716 * Makefile.am (snapshot): Automate snapshot creation some more.
4718 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
4720 * msg.cc (msg): Use vsnprintf to avoid buffer overflows.
4722 * ini.cc (fprintf): Ditto.
4723 * log.cc (log): Ditto.
4724 * package_db.cc (packagedb::sourcePackages): Split out source packages
4725 from binary packages.
4726 * package_db.h: Ditto.
4728 2002-06-27 Robert Collins <rbtcollins@hotmail.com>
4730 * PackageSpecification.h: New file. Abstracts the ability to refer
4731 to another package, by name, or name and version.
4732 * PackageSpecification.cc: Ditto.
4733 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Simplify.
4734 (IniDBBuilder::buildPackageSource): Ditto.
4735 (IniDBBuilder::buildBeginDepends): New method for versioned
4737 (IniDBBuilder::buildBeginPreDepends): Likewise, for dependencies to be
4738 satisfied before pre-install.
4739 (IniDBBuilder::buildPriority): New method, for getting the package
4741 (IniDBBuilder::buildInstalledSize): How much disk space does it need?
4742 (IniDBBuilder::buildMaintainer): Who maintains the package?
4743 (IniDBBuilder::buildArchitecture): What platform is it for?
4744 (IniDBBuilder::buildInstallSize): How big is the binary download?
4745 (IniDBBuilder::buildInstallMD5): Whats the MD5 on the binary?
4746 (IniDBBuilder::buildSourceMD5): Whats the MD5 on the source package?
4747 (IniDBBuilder::buildBeginRecommends): What other packages are
4748 recommended with this one?
4749 (IniDBBuilder::buildBeginSuggests): And suggested?
4750 (IniDBBuilder::buildBeginReplaces): What packages does this replace?
4751 (IniDBBuilder::buildBeginConflicts): And collide with?
4752 (IniDBBuilder::buildBeginProvides): What virtual packages (or obsolete
4753 package names) does this provide?
4754 (IniDBBuilder::buildDescription): Grab a multi line description one
4756 (IniDBBuilder::buildSourceName): What source package should be used to
4757 install the source for this binary package?
4758 (IniDBBuilder::buildSourceNameVersion): Is a specific version needed?
4759 (IniDBBuilder::buildPackageListAndNode): Add another AND clause to a
4760 list of package specifications.
4761 (IniDBBuilder::buildPackageListOrNode): Add another OR clause.
4762 (IniDBBuilder::buildPackageListOperator): Add a versioning operator
4763 to the current specification.
4764 (IniDBBuilder::buildPackageListOperatorVersion): What version does the
4766 * IniDBBuilder.h: Declare all the IniDBBuilder.cc changes.
4767 * IniDBBuilderPackage.cc: As for IniDBBuilder.cc.
4768 (IniDBBuilderPackage::IniDBBuilderPackage): Iniitialize new members.
4769 (IniDBBuilderPackage::process_src): Streamline and split out
4771 (IniDBBuilderPackage::setSourceSize): From process_src.
4772 * IniDBBuilderPackage.h: Declare the IniDBBuilderPackage.cc changes.
4773 (IniDBBuilderPackage::currentSpec): Track the in-progress specifiation.
4774 (IniDBBuilderPackage::currentOrList): Track the current Or list.
4775 (IniDBBuilderPackage::currentAndList): Track the current And list.
4776 * IniParseFeedback.cc (IniParseFeedback::progress): Provide completion
4777 progress on parsing.
4778 (IniParseFeedback::iniName): Tell what ini filename we are currently
4780 * IniParseFeedback.h: Declare IniParseFeedback.cc changes.
4781 * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
4782 Make the feedback object non-const to allow mutating methods which are
4783 needed when the object has state.
4784 (IniParseFindVisitor::visitFile): Tell the caller the name of each
4786 Initialise the parser with the feedback object to allow it to tell of
4788 * IniParseFindVisitor.h: Declare IniParseFindVisitor.cc changes.
4789 * Makefile.am (inilinst_SOURCES): Add more requisite classes.
4790 (setup_SOURCES): Add the new PackageSpecification sources.
4791 * ScanFindVisitor.cc (ScanFindVisitor::visitFile): Use the new
4792 builder syntax to setup binary package details.
4793 * choose.cc: Use the LogSingleton calls throughout.
4794 * configure.in: Create the INILINT substitution correctly for recent
4795 autotool configurations.
4796 * cygpackage.cc (cygpackage::getfirstfile): Return an empty String
4797 rather than a string built from an int. Thanks to Pavel Tsekov for
4798 identifying the bug.
4799 (cygpackage::getnextfile): Ditto.
4800 * download.cc: Use LogSIngletion calls throughout.
4801 (validateCachedPackage): A refactoring of the
4802 check_for_cached code to eliminate duplciation.
4803 (check_for_cached): Use validateCachedPackage to check packages.
4804 * ini.cc (GuiParseFeedback): Provide gui feedback on ini name and
4806 (do_remote_ini): Ditto.
4807 * ini.h (ini_init): Pass a IniParseFeedback to the parser, to allow
4809 * inilex.l: Identify new symbols - operators, and multi line plain text.
4811 * inilintmain.cc (show_help): Provide basic infomation on inilint.
4812 * iniparse.y: Adjust for the new builder syntax, and process debian
4814 * io_stream_file.cc: Always include mkdir.h.
4815 * list.h: Factor index location into a private routine.
4816 (list::findindex): Implement this.
4817 * mkdir.cc (mkdir_p): Make the use of WIN32 code conditional on mingw
4818 builds. NB: This breaks cygwin build functionality still.
4819 * package_meta.cc: Use the LogSingleton calls throughout.
4820 (packagemeta::set_requirements): Adjust for object changes in
4822 * package_meta.h (packagemeta::packagemeta): Initialise new members.
4823 (packagemeta::architecture): What platform does this package run on?
4824 This may need to move in the future to a per packagefile object.
4825 (packagemeta::priority): What priority does this package have?
4826 * package_source.h (packagesource::packagesource): Initialise new
4828 (packagesource::installedSize): How much space does the package need?
4829 (packagesource::setInstalledSize): Tell the amount.
4830 (packagesource::_installedSize): And store it.
4831 * package_version.cc (packageversion::sourcePackage): return the
4833 (packageversion::setSourcePackage): And set it.
4834 * package_version.h: Declare the package_version.cc changes.
4835 (packageversion::depends): New package specification AND list.
4836 (packageversion::predepends): Ditto.
4837 (packageversion::recommends): Ditto.
4838 (packageversion::suggests): Ditto.
4839 (packageversion::replaces): Ditto.
4840 (packageversion::conflicts): Ditto.
4841 (packageversion::provides): Ditto.
4842 (packageversion::sourcePackage): What source package is needed?
4843 * threebar.cc (ThreeBarProgressPage::SetText4): Set the label beside
4845 * threebar.h: Declare the threebar.cc change.
4847 2002-06-27 John Marshall <johnm@falch.net>
4849 * res.rc (SETUPINI_MISSING): Make trailing spaces visible.
4850 * site.cc (SitePage::OnMessageCmd): Ditto
4852 2002-06-15 Robert Collins <rbtcollins@hotmail.com>
4854 * nio-ie5.cc (NetIO_IE5::NetIO_IE): Allow cached data.
4856 2002-06-15 Robert Collins <rbtcollins@hotmail.com>
4858 * package_meta.cc (packagemeta::set_action): When installing packages
4859 with no binaries, choose the source package.
4861 2002-06-10 Robert Collins <rbtcollins@hotmail.com>
4863 * IniParseFindVisitor (IniParseFindVisitor::visitFile): Apply Max
4864 Bowshers fix for the crash with a root level setup.ini.
4865 * README: Update todos.
4867 2002-05-26 Ralf Habacker <ralf.habacker@freenet.de>
4869 * archive_tar.cc (archive_tar::next_file_name()): fixed broken
4870 GNU long name extension support.
4872 2002-05-27 Robert Collins <rbtcollins@hotmail.com>
4874 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Don't
4875 unescape 0 length strings.
4877 2002-05-20 Robert Collins <rbtcollins@hotmail.com>
4879 * package_meta.cc (packagemeta::set_action): Don't allow reinstall
4880 when local with no cached file, and install the default source if the
4881 default version has no binary.
4883 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
4885 * IniDBBuilderPackage.cc (IniDBBuilderPackage::IniDBBuilderPackage): New
4887 (IniDBBuilderPackage::buildVersion): Provide a warning when a newer
4888 setup version created the ini file.
4889 * IniDBBuilderPackage.h (IniDBBuilderPackage::IniDBBuilderPackage): New
4891 * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use the new
4893 * IniParseFindVisitor.h (IniParseFindVisitor::IniParseFindVisitor):
4894 Require a feedback strategy.
4895 * Makefile.am (setup_SOURCES): Add IniParseFeedback sources.
4896 * Makefile.in: Regenerate.
4898 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
4900 * io_stream_file.cc (io_stream_file::remove): Use the SetFileAttributes
4901 trick to delete read only files.
4902 * io_stream_cygfile.cc (io_stream_cygfile::remove): Use file:// to
4904 * Makefile.am (release): Tweak to be more helpful.
4905 * Makefile.in: Regenerate.
4907 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
4909 * Makefile.am (release): Tweak to be more helpful.
4910 * Makefile.in: Regenerate.
4912 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
4914 * Makefile.am (release): Tweak to be more helpful.
4915 * Makefile.in: Regenerate.
4917 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
4919 * choose.cc (scan_downloaded_files): When a non-installed version
4920 has neither bin nor src cached files for local installs,
4921 remove the version from availability.
4923 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
4925 * ini.cc (do_remote_ini): Save uncompressed ini's correctly.
4927 2002-05-19 Robert Collins <rbtcollins@hotmail.com>
4929 * rsync: New support library, contains librsync. This is not (yet)
4930 rsync interoperable.
4931 * configure.in: --with-rsync to enable rsync support. (Not complete).
4932 * Makefile.am: Enable building with rsync.
4933 * Makefile.in: Regenerate.
4935 * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Pass the md5 as
4937 (IniDBBuilder::buildPackageSource): Ditto.
4938 * IniDBBuilder.h: Ditto.
4939 * IniDBBuilderPackage.cc: Ditto.
4940 * IniDBBuilderPackage.h: Ditto.
4941 * FindVisitor.cc: New file.
4942 * FindVisitor.h: New file, interface for visiting a file system
4944 * IniParseFindVisitor.cc: New file.
4945 * IniParseFindVisitor.h: New file, concrete FindVisitor that parses
4947 * README: Update TODO's.
4948 * String++.cc (String::String): New constructor for <string> inter-
4950 (String::substr): New method.
4951 * String++.h: Ditto.
4952 * choose.cc (scan2): Remove.
4953 (scan_downloaded_files): Simplify.
4954 * dialog.h: Include parsing pre-requirements.
4955 * download.cc (check_for_cached): Fullname was used incorrectly - fix.
4956 * filemanip.cc (parse_filename): -src packages where incorrectly parsed.
4957 * find.cc: Rewrite. Now uses a Visitor pattern and is re-entrant.
4959 * fromcwd.cc: Remove unneeded includes.
4960 (is_test_version): Remove.
4961 (found_file): Remove.
4962 (SetupFindVisitor): Trivial visitor to detect setup.ini's.
4963 (found_ini): Remove.
4964 (do_fromcwd): Remove commented code that has be replaced elsewhere.
4965 * ini.cc (local_ini): Remove.
4966 (findBuilder): Remove.
4967 (find_routine): Remove.
4968 (do_local_ini): Use new IniParseFindVisitor.
4969 * iniparse.y: Typecase MD5 arrays, as we know they are allocated as
4971 * postinstall.cc: Remove non-core includes.
4972 (run_script_in_postinstall): Remove.
4973 (RunFindVisitor): Trivial Visitor, runs each found script.
4974 (do_postinstall): Use new find syntax.
4976 2002-05-14 Christopher Faylor <cgf@redhat.com>
4978 * ini.cc (find_routine): Don't clear buffer it it's NULL.
4980 2002-05-14 Christopher Faylor <cgf@redhat.com>
4982 * filemanip.h (trail): Declare.
4983 * filemanip.cc (trail): New function.
4984 (find_tar_ext): Use trail() instead of strstr().
4985 * fromcwd.cc (check_ini): Ditto.
4986 * ini.cc (find_routine): Ditto. Don't tack local_dir to path since it
4987 should now be fully qualified. Set ini_filename. Reset error_buf and
4988 error_count for any subsequent ini file parsing.
4989 (ini_filename): New static variable for parse error reporting.
4990 (yyerror): Use full path of setup.ini in error message. Subtract one
4991 from line number if at bol.
4992 * find.cc (found_part): Eliminate.
4993 (find_sub): Call for_each with full path found rather than just file
4995 (find): Don't calculate found_part.
4996 * inilex.l (ini_init): Flush input buffer and reset line number.
4997 (yybol): New function. Exports YY_AT_BOL.
4998 * iniparse.y: Increase stack depth to allow more tokens to be processed.
4999 (yyparse): Remove newline from error condition to allow subsequent
5000 per-line error processing to proceed normally.
5002 2002-05-14 Christopher Faylor <cgf@redhat.com>
5004 * find.cc (find_sub): Be more defensive in preserving trailing parts of
5005 components when doing recursive directory searches or calling user
5006 supplied for_each().
5007 * ini.cc (find_routine): Don't assume that any path name with
5008 "setup.ini" in it is actually a setup.ini file. Only honor trailing
5009 components. Copy path argument to temporary storage when unescaping
5010 to prevent nuking of argument.
5012 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
5014 * CONTRIBUTORS: New file.
5016 2002-04-02 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5018 * choose.cc: Run indent.
5019 (nextbutton): Remove static variable.
5020 (default_trust): Remove use of nextbutton.
5021 (set_view_mode): Ditto.
5022 (create_listview): Add IDC_CHOOSE_PREV and IDC_CHOOSE_NEXT to ta[] so
5023 rbset() sets the prev/next/curr radio buttons properly.
5024 (dialog_cmd): Delete function.
5025 (dialog_proc): Delete function. Move WM_INITDIALOG functionality to
5026 ChooserPage::OnInit.
5027 (do_choose): Delete function. Move pre-DialogBox() code to
5028 ChooserPage::OnInit(), post-DialogBox() code to ChooserPage::OnNext.
5029 (WM_APP_START_CHOOSE): Remove define.
5030 (WM_APP_CHOOSE_IS_FINISHED): Remove define.
5031 (do_choose_thread): Delete function.
5032 (ChooserPage::OnActivate): Delete method.
5033 (ChooserPage::OnMessageApp): Delete method.
5034 (ChooserPage::OnInit): New method.
5035 (ChooserPage::OnNext): New method.
5036 (ChooserPage::OnBack): New method.
5037 (ChooserPage::OnMessageCmd): New method.
5038 * choose.h: Run indent.
5039 (ChooserPage::OnMessageApp): Delete declaration.
5040 (ChooserPage::OnActivate): Ditto.
5041 (ChooserPage::OnMessageCmd): New declaration.
5042 (ChooserPage::OnInit): Ditto.
5043 (ChooserPage::OnNext): Ditto.
5044 (ChooserPage::OnBack): Ditto.
5045 * desktop.cc (DesktopSetupPage::OnBack): Replace use of IDD_CHOOSER
5047 * fromcwd.cc (do_fromcwd): Replace use of IDD_CHOOSER with IDD_CHOOSE.
5048 * ini.cc (do_ini_thread): Replace use of IDD_CHOOSER with IDD_CHOOSE.
5049 * res.rc (IDD_CHOOSE): Remove dialog template.
5050 (IDD_CHOOSER): Alter dialog template to fit wizard size and format.
5052 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
5054 * LogFile.cc (endLog): Work around an apparent libg++-3 bug causing
5055 corrupt log file entries.
5056 * geturl.cc: Convert to the new LogSingleton logging.
5058 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
5060 * ini.cc (do_remote_ini): Use setup.bz2 if it exists in preference to
5063 2002-05-12 Robert Collins <rbtcollins@hotmail.com>
5065 * geturl.h: Declare getUrlToStream.
5066 * geturl.cc (getUrlToStream): New function.
5067 (get_url_to_membuf): Refactor to use getUrlToStream.
5069 2002-05-11 Robert Collins <rbtcollins@hotmail.com>
5071 * Makefile.am: Add a release target to automate some of the routine
5073 * Makefile.in: Regenerate.
5075 2002-05-11 Robert Collins <rbtcollins@hotmail.com>
5077 * choose.cc (scan_downloaded_files): On local installs remove all
5078 mirror sites if no cached copy of a package is found.
5080 2002-05-10 Robert Collins <rbtcollins@hotmail.com>
5082 * Makefile.in: Regenerate.
5083 * iniparse.y: Use left recursion, not right in the lines rule to
5084 avoid stack overflows.
5085 * README: Update TODO's.
5086 * io_stream_file.cc: Native builds need to include sys/stat.h
5088 2002-05-06 John Marshall <jmarshall@acm.org>
5090 * site.cc (SitePage::OnMessageCmd): recalculate navigation
5091 button activation when "Add" is pressed.
5092 (SitePage::CheckControlsAndDisableAccordingly): tweak comment.
5094 2002-05-07 Robert Collins <rbtcollins@hotmail.com>
5096 * Makefile.am (inlint_SOURCES): Add conditional objects to inilint
5097 depending on platform.
5098 Add file:// support.
5099 * configure.in: Set conditional MINGWTARGET if compiling against mingw
5101 * Makefile.in: Regenerate.
5103 * io_stream_file.cc: Only use win32 calls when building for mingw.
5105 2002-05-05 Robert Collins <rbtcollins@hotmail.com>
5107 * Makefile.am (noinst_PROGRAMS): Make inilint configurable.
5108 * configure.in: Ditto.
5109 Fix incorrect header checking syntax.
5110 * aclocal.m4: Regenerate.
5111 * configure: Regenerate.
5112 * Makefile.in: Regenerate.
5113 * io_stream.cc: Remove platform specific and provider specific code.
5114 (io_stream::registerProvider): New method, registers a Url provider with
5116 Make all methods consistently throw invalid_argument exceptions when
5117 a provider that is requested is not present.
5118 (findProvider): New private function, finds a provider.
5119 * io_stream.h: Declare io_stream::registerProvider.
5120 * io_stream_cygfile.cc: Create a Provider class to register with
5122 * io_stream_file.cc: Ditto.
5123 * archive.cc: Remove unneeded includes.
5124 * archive_tar.cc: Remove unneeded includes.
5125 * archive_tar.h: Add required include.
5126 * archive_tar_file.cc: Remove unneded includes.
5127 * choose.cc: Remove unneeded includes:
5129 2002-05-04 Robert Collins <rbtcollins@hotmail.com>
5131 * io_stream.cc: Use the new log interface thruout.
5133 2002-05-04 Robert Collins <rbtcollins@hotmail.com>
5135 * log.cc (log): Reimplement via LogSingleton.
5137 (exit_setup): Remove.
5138 * log.h (log_save): Remove.
5139 (exit_setup): Remove.
5140 * LogSingleton.cc: New file.
5141 * LogSingleton.h: New file.
5142 * LogFile.cc: New file.
5143 * LogFile.h: New file.
5144 * Makefile.am (inilint_SOURCES): Add the new log interface.
5145 (setup_SOURCES): Add the new log interface and the concrete File
5147 * Makefile.in: Regenerate.
5148 * archive.cc: Use the new log interface thruout.
5149 * archive_tar.cc: Ditto.
5151 * dialog.cc (fatal): Use the new log interface.
5152 * ini.cc (do_ini_thread): Use the log interface to exit.
5153 * isntall.cc (do_install_thread): Ditto.
5154 * netio.cc (auth_cmd): Ditto.
5155 * msg.cc (fatal): Ditto.
5156 * localdir.cc (save_local_dir): Save to different files depending on
5157 the mode, and if a root dir exists.
5159 2002-05-04 Robert Collins <rbtcollins@hotmail.com>
5161 * IniDBBuilder.cc: New file.
5162 * IniDBBuilder.h: New file.
5163 * IniDBBuilderPackage.cc: New file.
5164 * IniDBBuilderPackage.h: New file.
5165 * PackageTrust.h: New file.
5166 * IniState.h: Remove, wasn't thought out well enough.
5167 * Makefile.am (inilint_SOURCES): Add more requirements.
5168 (setup_SOURCES): Add new Builder base and concrete classes.
5169 * Makefile.in: Regenerate.
5170 * String++.cc (String::String): Implement int contructor.
5171 * String++.h (String): Declare int constructor.
5172 * archive_tar.cc (archive_tar::next_file_name): Return String() when
5174 * archive_tar.h (archive_tar_file): Remove get_next_filename method,
5176 * ini.cc: Replace IniState wuth IniDBBuilderPacakge.
5177 (find_routine): Use new IniDBBuilder to configure the parser.
5178 (do_local_ini): Ditto.
5179 (do_remote_ini): Ditto.
5180 * ini.h: Use IniDBBuilder to initialise parsing.
5181 * inilex.l (MD5): Parse the MD5 string correctly, we had the nibbles
5183 (ini_init): Use an IniDBBuilder rather than static variables.
5184 * iniparse.y: Hand off all the object creation to a builder, rather
5185 than hardcoding the behaviour. This allows run-time configured
5187 * io_stream_cygfile.h (io_stream_cygfile): Remove get_next_filename
5188 method, it's not needed.
5189 * io_stream_file.h (io_stream_file): Ditto.
5190 * mount.cc (cygpath): Return String() for missing mounts.
5191 * package_meta.cc (packagemeta::SDesc): Return String() for blank
5193 * package_meta.h (trusts): Remove - replaced by PackageTrust.h.
5194 (packagemeta::packagemeta): Fix incorrect syntax in String constructor
5196 * cygpackage.cc (cygpackage::cygpackage): Fix incorrect syntax in
5197 String constructor usage.
5198 * site.h (site_list_type): Ditto.
5200 2002-05-03 Robert Collins <rbtcollins@hotmail.com>
5202 * String++.h: Declare a << operator that accepts String objects.
5203 * String++.cc: We need iostream for..
5204 (operator <<): this. Provide a << operator that accepts String objects.
5205 * ini.cc (yyerror): Remove the "C" classifier - it's not needed.
5206 Change from vargs to a String parameter.
5207 * inilintmail.cc: Remove the gui related headers.
5208 (yyerror): Implement this for parsing.
5209 * iniparse.y: Use the new yyerror syntax.
5211 2002-05-03 Robert Collins <rbtcollins@hotmail.com>
5213 * Makefile.am: Add IniState.h.
5214 * Makefile.in: Regenerate.
5215 * IniState.h: New file.
5216 * choose.cc: Don't include ini.h - it's not needed.
5217 * configure: Regenerate.
5218 * desktop.cc: Don't include ini.h - it's not needed.
5219 * download.cc: Ditto.
5220 * fromcwd.cc: Ditto.
5221 * ini.cc: Use IniState.h to track each parsing calling.
5222 (find_routine): Ditto.
5223 (do_remote_ini): Ditto.
5224 (do_ini_thread): Ditto.
5225 * ini.h (ini_init): Adjust parameters to include state object.
5226 * inilex.l: Declare parser state variable.
5227 (ini_init): Adjust parameters to include state object.
5228 * iniparse.y: Remove obsolete setup_timestamp and setup_version
5230 (setup_header): Use new state variable to track time and version.
5231 (add_correct_version): Ditto.
5232 * install.cc: Don't include ini.h - it's not needed.
5234 2002-05-03 Robert Collins <rbtcollins@hotmail.com>
5236 * nio-files.cc (NetIO): Use io_stream syntax for get_file_size.
5237 * io_stream_file.cc: Don't include filemanip.h.
5238 (io_stream_file::get_size): Implement here to remove filemanip
5240 * io_stream_cygfile.cc: Don't include filemanip.h.
5241 (io_stream_cygfile::get_size): Implement here to remove filemanip
5243 Implement a stat based version for when win32 is not available.
5244 * filemanip.h (get_file_size): Return size_t - it's more appropriate.
5245 * filemanip.cc: Don't include win32.h - be platform independent.
5246 Include strings.h and io_stream.h as part of that.
5247 (get_file_size): Leverage io_streams and remove win32 implementation.
5248 * download.cc (check_for_cached): Use io_stream syntax for
5250 (download_one): Ditto.
5252 2002-05-02 Robert Collins <rbtcollins@hotmail.com>
5254 * configure.in: Correct a typo in last change.
5255 * configure: Regenerate.
5256 * Makefile.in: Regenerate.
5258 2002-05-02 Robert Collins <rbtcollins@hotmail.com>
5260 * configure.in: Check for string.h and string.
5261 * configure: Regenerate.
5262 * Makefile.in: Regenerate.
5264 2002-05-01 Robert Collins <rbtcollins@hotmail.com>
5266 * res.rc (IDD_SPLASH): Remove white box.
5268 2002-05-01 Robert Collins <rbtcollins@hotmail.com>
5270 Oops! forgot to list these in the last checkin.
5271 * inilintmain.cc: New file.
5272 * md5.h: New file - imported md5 source, BSD style licence.
5273 * md5.cc: New file - imported md5 source, BSD style licence.
5274 * Exception.cc: New file.
5275 * Exception.h: New file.
5276 * MD5++.cc: New file.
5277 * MD5++.h: New file.
5279 2002-05-01 Robert Collins <rbtcollins@hotmail.com>
5281 * Makefile.am (AM_CFLAGS): Remove -mwindows, it's a linker flag.
5282 Remove -fno-rtti, we need it for exceptions.
5283 (AM_CXXFLAGS): Ditto.
5284 (WARNONLY_CFLAGS): Ditto.
5285 (EXTRA_PROGRAMS): Add with initial linter sources - not functional yet.
5286 (setup_LDFLAGS): Add and set to -mwindows.
5287 (setup_SOURCES): Add new sources.
5288 * Makefile.in: Regenerate.
5289 * README: Update TODO.
5290 * choose.cc (scan_downloaded_files): Use ini information if it's
5292 * configure: Regenerate.
5293 * download.cc (check_for_cached): Make reusable from elsewhere.
5294 Throw exceptions on errors (as opposed to failures).
5295 Check MD5 sum when it's known.
5296 (download_one): Never force a download.
5297 Handle corrupt package exceptions.
5298 * ini.cc (find_routine): Reverse escape the URL to correctly identify
5300 * inilex.l (MD5): Provide a parsing rule (note: lowercase is required).
5301 * iniparse.y: Allow calculation of MD5 sums, and allow src only
5303 (process_src): New helper function.
5304 * isntall.cc (install_one_source): Check MD5 sums when possible.
5305 Throw exceptions on errors.
5306 (do_install_thread): Handle exceptions for installation calls.
5307 * package_source.h: Store MD5 information.
5308 * propsheet.cc (PropSheet::Create): Add a useful comment.
5309 * res.rc (IDS_INSTALL_ERROR): Define.
5310 (IDS_CORRUPT_PACKAGE): Define.
5311 * resource.h (IDS_INSTALL_ERROR): Define.
5312 (IDS_CORRUPT_PACKAGE): Define.
5313 * rfc1738.cc (rfc1738_unescape_part): Implement.
5314 * rfc1738.h (rfc1738_unescape_part): Declare.
5316 2002-04-29 Robert Collins <rbtcollins@hotmail.com>
5318 * Makefile.am: Remove dependecy rules that automake emits.
5319 Correct badly copied dependency info for manually compiled files.
5320 (setup_SOURCES): Add all used headers.
5321 (EXTRA_DIST): Include non compilate but required sources.
5322 (setup_LDADD): Remove mingw32, it is autodetected.
5323 * Makefile.in: Regenerate.
5324 * String++.h: sys/types is a system header.
5325 * choose.cc (do_choose_thread): Make into a Win32 thread routine.
5327 (ChooserPage::OnMessageApp): Use Win32 threads. (_beginthread is not
5329 * configure: Regenerate.
5330 * configure.in: Check for mingw32/cygwin specific headers and libraries.
5331 * cygpackage.h: Include the win32.h header to get correct macro
5332 definitions in all situations.
5333 * download.cc (do_download_reflector): Make into a Win32 thread routine.
5335 (do_download): Use Win32 threads.
5337 * install.cc: Ditto.
5338 * (WinMain): Adjust to build valid command line using application
5339 under both mingw32 and cygwin.
5340 * mount.cc (set)cygdrive_flags): Create new system flags if the
5341 user requests system and the value does not exist.
5342 * nio-http.cc: Define a _strnicmp for cygwin.
5343 * package_db.cc: Include <errno.h> if it exists.
5344 * site.cc (do_download_site_info_thread): Make into a Win32 thread
5347 (do_download_site-Info): Use Win32 threads.
5348 * state.cc: Explicity declare variables to avoid header conflicts
5349 caused by '#define extern" on cygwin.
5350 * win32.h: Include <alloca.h> if it exists.
5351 (_MAX_PATH): Define as MAX_PATH when not defined by windows.h.
5352 (_access): Define as access if not defined by windows.h.
5354 2002-04-27 Robert Collins <rbtcollins@hotmail.com>
5356 * compress_gz.cc (compress_gz::error): EOF is not an error condition.
5358 2002-04-27 Robert Collins <rbtcollins@hotmail.com>
5360 * Makefile.am: Add libgetopt++ to the subdirs list.
5361 Search the libgetopt++ header directory.
5362 Link against libgetopt++.la.
5363 (setup_SOURCES): Remove GetOption.cc and getopt.c and Option.cc.
5364 (setup_LDADD): Explicitly include res.o.
5365 * Makefile.in: Regenerate.
5366 * aclocal.m4: Regenerate.
5367 * bootstrap.sh: Call libtoolize.
5368 * configure: Regenerate.
5369 * configure.in: Add libtool support and configure libgetopt++.
5370 * desktop.cc (NoShortcutsOption): Turn into a BoolOption.
5371 (DesktopSetupPage::OnInit): Use the simpler syntax.
5372 * desktop.h: Remove dependency on Option.h, and remove NoShortcustOption
5374 * main.cc: Include getopt++/GetOption.h.
5375 (main): Use simpler syntax.
5379 * GetOption.h: Remove.
5380 * GetOption.cc: Remove.
5382 * Option.cc: Remove.
5384 2002-04-26 Robert Collins <rbtcollins@hotmail.com>
5386 * Makefile.am: Add zlib and bz2lib to SUBDIRS.
5388 2002-04-26 Robert Collins <rbtcollins@hotmail.com>
5390 * aclocal.m4: New file, cached macros.
5391 * bootstrap.sh: New file, calls required autotools in appropriate
5393 * Makefile.am: New file, input Makefile for automake.
5394 * Makefile,in: Now a generated file - regenerate.
5395 * configure: Regenerate.
5396 * configure.in: Add automake support.
5397 * inilex.l: Change VERSION to PACKAGEVERSION to avoid a collision with
5398 automake's VERSION define.
5399 * iniparse.y: Ditto.
5401 2002-04-26 Robert Collins <rbtcollins@hotmail.com>
5403 * cdefs.h: New file, imported to allow getopt.c to build without
5405 * getopt.h: New file, imported to allow building without cygwin headers.
5407 * bz2lib: New directory, contains copy of bz2lib.
5408 * cfgaux: New directory, contains autotool helper scripts.
5409 * Makefile,in: Adjust library and target definitions for building
5410 outside the sourceware tree.
5411 * compress_bz.h: Use new bz2lib header location.
5412 * mount.cc: Import key defines and enums to be independent of cygwin
5414 * configure.in: Update to autoconf 2.53, and to be sourceware
5416 * configure: Regenerate.
5418 2002-04-12 Robert Collins <rbtcollins@hotmail.com>
5420 * mklink2.cc (make_link_2): Tweak to work with current w32api
5423 2002-04-10 Pavel Tsekov <ptsekov@gmx.net>
5425 * version.cc (canonicalize_version): Fix a call delete[]
5426 to delete the allocated address.
5428 2002-03-29 Robert Collins <rbtcollins@hotmail.com>
5430 * PickView.cc (PickView::set_headers): Set last_col correctly. Thanks
5431 to Ton van Overbeek for locating the bug area.
5433 2003-03-27 Robert Collins <rbtcollins@hotmail.com>
5435 * PickView.cc (PickView::insert_pkg): Be more generic with
5437 (PickView::insert_category): Ditto.
5438 (PickView::~PickView): Create.
5439 * PickView.h (PickView::~PickView): Declare.
5441 2003-03-27 Robert Collins <rbtcollins@hotmail.com>
5443 * Makefile.in (OBJS): Add new commandline objects.
5444 * desktop.cc (NoShortCutsOption): New option code.
5445 (DesktopSetupPage::OnInit): Check whether to skip shortcuts.
5446 * desktop.h (NoShortCutsOption): New concrete command line option class.
5447 * main.cc (WinMain): Process command line options.
5448 * GetOption.h: New file, singleton command line class.
5449 * GetOption.cc: New file, implementation of the above.
5450 * Option.h : New file, abstract option for GetOption.
5451 * Option.cc: New file, implement constructor and destructor.
5453 2002-03-26 Pavel Tsekov <ptsekov@gmx.net>
5455 * mkdir.cc (mkdir_p): Stop processing if the path is exhausted.
5457 2002-03-26 Ton van Overbeek <tvoverbe@cistron.nl>
5459 * PickPackageLine.cc (PickPackageline::paint): Adjust clipping rectangle
5460 to textheight, so large fonts work.
5462 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
5464 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Don't translate
5467 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
5469 * io_stream_cygfile.cc (cwd): New static for cwd storage.
5470 (io_stream_cygfile::normalise): New method.
5471 (io_stream_cygfile::io_stream_cygfile): Use it.
5472 (io_stream_cygfile::exists): Ditto.
5473 (io_stream_cygfile::remove): Ditto.
5474 (io_stream_cygfile::mklink): And again.
5475 (cygmkdir_p): Yes, again.
5476 (io_stream_cygfile::move): And once more.
5477 * io_stream_cygfile.h (io_stream_cygfile::normalise): Declare.
5478 (io_stream_cygfile::cwd): Ditto.
5480 2003-03-26 Robert Collins <rbtcollins@hotmail.com>
5482 * package_meta.cc (package_meta::~package_meta): Remove duplicate.
5483 (CategoryPackage::~CategoryPackage): Ditto. (Thanks to Ton van
5484 Overbeek for the report).
5485 * mklink2.cc: Moved from mklink2.c to avoid 'not a prototype error'.
5486 Make g++ compatible.
5487 * mklink2.c: Remove.
5488 * site.cc (site_list_type::init): Delete the correct memory addres.
5489 Thanks to Pavel Tsekov for tracking this down.
5491 2002-03-20 Robert Collins <rbtcollins@hotmail.com>
5493 * win32.h: Only define alloca if it's not already.
5495 2002-03-20 Robert Collins <rbtcollins@hotmail.com>
5497 * package_meta.h (packamgemeta::trustp): Make 'test' choice leave
5498 installed packages alone.
5499 * README: Update with latest requests.
5500 * Various: MTC fixes from setup200202 branch.
5502 2002-03-19 Christopher Faylor <cgf@redhat.com>
5504 * Makefile.in (setup_version.c): Add back magic which allows detection
5505 of setup.exe version number.
5507 2002-03-17 Robert Collins <rbtcollins@hotmail.com>
5509 * PickPackageLine.cc (PickPackageLine::paint): Fix incorrect clip region
5510 calculation on win9x systems.
5512 2002-03-16 Robert Collins <rbtcollins@hotmail.com>
5514 * install.cc (install_one_source): Write the correct length of a string
5515 to the lst file (Thanks to Pavel Tsekov for reporting the bug).
5517 2002-03-15 Robert Collins <rbtcollins@hotmail.com>
5519 * choose.cc (list_click): Always refresh the entire chooser, as our
5520 package state change mechanism is broken with the new improved list
5523 2002-03-15 Robert Collins <rbtcollins@hotmail.com>
5525 * desktop.cc (make_passwd_group): Check for .lnk suffix on /etc/passwd
5528 2002-03-15 Robert Collins <rbtcollins@hotmail.com>
5530 * PickPackageLine.cc (PickPackageLine::DrawCheck): New method factored
5532 (PickPackageLine::paint): Use DrawCheck to draw the src tick box, and
5533 the new bin tickbox.
5534 (PickPackageLine::click): Handle the new bin tickbox.
5535 * PickPackageLine.h (PickPackageLine::DrawCheck): Declare this.
5536 * PickView.cc (pkg_headers): Add a Bin? column.
5537 (cat_headers): Ditto.
5538 (PickView::set_headers): Ditto.
5539 (PickView::init_headers): Ditto.
5540 * PickView.h (PickView): Ditto.
5541 * choose.cc (list_click): Use the new name for src_col to set the clip
5544 2002-02-24 Michael A Chase <mchase@ix.netcom.com>
5546 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Fix up Robert's
5549 2002-02-24 Michael A Chase <mchase@ix.netcom.com>
5551 * desktop.cc (make_link): Add "file://" prefix to io_stream::mkpath_p()
5553 (make_passwd_group): Ditto.
5554 * localdir.cc (save_local_dir): Ditto.
5555 * io_stream_cygfile.cc (io_stream_cygfile::mklink): Wrap long lines.
5556 Add "cygfile://" prefix to io_stream::open() calls.
5558 2002-02-24 Robert Collins <rbtcollins@hotmail.com>
5560 * log.cc (log_save): Fix creating /var/log.
5561 * packate_meta.cc (standard_dirs): Remove duplicate '/''s.
5563 2002-02-24 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
5565 * res.rc (STRINGTABLE): Add IDS_CYGWIN_SETUP and
5566 IDS_CYGWIN_SETUP_WITH_PROGRESS strings.
5567 * resource.h: Add IDS_CYGWIN_SETUP and
5568 IDS_CYGWIN_SETUP_WITH_PROGRESS IDs.
5570 * splash.cc (OnInit): Qualify SetWindowText() call with global scope
5571 operator (::SetWindowText()).
5573 * threebar.cc: Run indent.
5574 (cistring.h): Add include.
5575 (SetText1, SetText2, SetText3): Qualify SetWindowText() call with
5576 global scope operator.
5577 (SetBar2): Add logic for writing percent complete into window title.
5579 * window.h: Run indent.
5580 (SetWindowText): New function.
5581 (String): Add forward declaration.
5582 * window.cc: Run indent.
5583 (String++.h): Add include.
5584 (SetWindowText): New function.
5586 2002-02-24 Robert Collins <rbtcollins@hotmail.com>
5588 * README: Update TODO list.
5589 * install.cc (install_one): Fix src package location.
5590 (do_install_thread): Fix creating directories.
5592 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
5594 * choose.cc: Include cygpackage.h for scan2 use.
5595 (set_existence): Ignore setup.ini mirrors when installing from cwd.
5596 (scan2): Process any valid file.
5597 Add cache entries when a file matching a setup.ini listed version is
5599 * filemanip.cc (parse_filename): Remove pkgtar - not used anywhere else.
5600 * filemanip.h (filemanip::pkgtar): Remove.
5601 * package_meta.cc (CategoryPackage::~CategoryPackage): New method.
5602 (packagemeta::~packagemeta): Move from package_meta.h
5603 Remove and delete all version and category information.
5604 * package_meta.h (CategoryPackage): Create a destructor.
5605 (packagemeta::~packagemeta): Move to .cc file.
5607 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
5609 * install.cc (install_one_source): Make NULL cached package names cause
5612 2002-02-18 Michael A Chase <mchase@ix.netcom.com>
5614 * desktop.cc (make_passwd_group): Don't create passwd-grp.bat
5617 2002-02-18 Michael A Chase <mchase@ix.netcom.com>
5619 * log.cc (log_save): Put "\n" at end of log lines instead of "'".
5621 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
5623 * mount.cc (create_mount): Avoid a const char*->char* warning.
5624 (read_mounts): Ditto.
5626 2002-02-05 Jason Tishler <jason@tishler.net>
5628 * download.cc (do_download_thread): Fix off-by-one error.
5630 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
5632 * configure.in (CXXFLAGS): Substitute at configure time, not runtime.
5633 * configure (CXXFLAGS): Regenerate.
5634 * Makefile.in (iniparse.o): Build via default rules - no errors now.
5635 * README: TODO list updates.
5637 2002-02-19 Michael A Chase <mchase@ix.netcom.com>
5639 * String++.cc (String::concat):: Remove.
5640 (String::vconcat):: Ditto.
5641 * String++.h (String::concat):: Remove.
5642 (String::vconcat):: Ditto.
5643 * archive_tar.cc: Don't include concat.h.
5644 * archive_tar_file.cc: Don't include concat.h.
5645 * compress_bz.cc (compress_bz::peek): Don't log unneeded messages.
5646 (compress_bz::seek): Ditto.
5647 (compress_bz::~compress_bz): Ditto.
5648 * compress_gz.cc (compress_gz::peek): Ditto.
5649 (compress_gz::error): Ditto.
5650 (compress_gz::~compress_gz): Ditto.
5651 * concat.cc (vconcat): Remove.
5653 * concat.h (vconcat): Remove.
5655 * desktop.cc (desktop_icon): Use new cygpath.
5656 (make_etc_profile): Ditto.
5658 (make_passwd_group): Ditto.
5660 (check_desktop): Remove concat use.
5661 (check_start_menu): Ditto.
5662 * download.cc (download_one): Use new mkpath_p correctly.
5664 * fromcwd.cc: Don't include concat.h.
5665 * geturl.cc (get_url_to_membuf): Use String log() call.
5666 (get_url_to_file): Ditto.
5667 * install.cc: Don't include concat.h.
5668 (uninstall_one): Use LOG_PLAIN.
5669 (replace_one): Ditto.
5670 (install_one_source): Ditto.
5671 (install_one): More char to String conversion.
5672 (do_install_thread): Use new cygpath.
5673 Use new create_mount.
5674 * io_stream.cc (io_stream::move): Use new log().
5675 * io_stream_cygfile (io_stream_cygfile::io_stream_cygfile): Use new
5677 (io_stream_cygfile::exists): Ditto.
5678 (io_stream_cygfile::remove): Ditto.
5679 (io_stream_cygfile::mklink): Ditto.
5680 (io_stream_cygfile::write): Ditto.
5681 (cygmkdir_p): Ditto.
5682 (io_stream_cygfile::move): Ditto.
5683 * io_stream_file.cc: Don't include log.h.
5684 (io_stream_file::write): Don't log unneeded messages.
5685 * localdir.cc: Don't include concat.h.
5686 (LocalDirPage::OnNext): Use LOG_PLAIN.
5687 * log.cc: Don't include log.h.
5688 (exit_setup): Use new cygpath.
5689 * log.h (log_level): Add new level LOG_PLAIN.
5690 * main.cc (WinMain): Use new log().
5691 * mount.cc (SLASH_P): New macro from concat.h.
5692 (cygpath): Make String version globally visible.
5693 Remove varargs version.
5695 * msg.cc (mbox): Use LOG_PLAIN.
5696 * net.cc (NetPage::OnNext): Ditto.
5697 * nio-ftp.cc (ftp_line): Use new log().
5698 * nio-http.cc: Don't include log.h.
5699 (retry_get): Use alternative url variable.
5700 * package_db.cc: Don't include concat.h.
5701 (packagedb::flush): Don't use concat.
5702 * package_meta.cc: Don't include concat.h.
5703 (packagemeta::uninstall): Use new cygpath.
5704 * postinstall.cc (do_postinstall): Ditto.
5705 * root.cc (RootPage::OnNext): Use LOG_PLAIN.
5706 * script.cc: Don't include concat.h.
5707 (init_run_script): Use new cygpath.
5708 (run_script): More char * to String conversion.
5709 (try_run_script): Ditto.
5710 * site.cc: Don't include concat.h.
5711 (SitePage::OnNext): Use LOG_PLAIN.
5712 (SitePage::OnMessageCmd): Use new log().
5713 * source.cc (SourcePage::OnDeactivate): Use LOG_PLAIN.
5715 2002-02-19 Robert Collins <rbtcollins@hotmail.com>
5717 * Makefile.in (OBJS): Add new object.
5718 * PickCategoryLine.cc (PickCategoryLine::paint): Print a "+" before the
5720 * PickCategoryLine.h (PickCategoryLine::bucket): Use the String class.
5721 * PickLine.h (Pickline::key): Change to a String to help plug leaks.
5722 (PickLine::Pickline): Accept a String for the key.
5723 * PickPackageLine.cc (PickPackageLine::paint): Convert all char use to
5725 * PickPackageLine.h (PickPackageLine::PickPackageLine): The key is
5726 automatically initialised now.
5727 * PickView.cc (PickView::note_width): Convert all char * use to Strings.
5728 (PickView::init_header): Move category length checking out of the inner
5729 loop for efficiency.
5730 Convert all char use to Strings.
5731 * PickView.h: Include the String++ header.
5732 (PickView::note_width): Update the prototype.
5733 * String++.cc: New file, implements a reference counting string class.
5734 * String++.h: New file, declares a reference counting string class.
5735 * archive.cc: Include String++ instead of concat.
5736 (archive::extract_file): Convert char * usage to Strings.
5737 * archive.h: Inlude the String++ header.
5738 (archive::extract_file): Update prototype.
5739 (archive::next_file_name): Convert to a String.
5740 (archive::linktarget): Ditto.
5741 * archive_tar.cc (archive_tar::next_file_name): Convert to String usage.
5742 (archive_tar::linktarget): Ditto.
5743 * arhive_tar.h: Update the copyright.
5744 Explicitly include the relevant headers.
5745 (tar_map_result_type): Convert to String usage.
5746 (archive_tar::next_file_name): Update prototype.
5747 (archive_tar::linktarget): Ditto.
5748 * category.cc (Category::Category): Update initialisers.
5749 Convert to String usage.
5750 (Categorycmp): Update to String usage.
5751 * category.h: Include the String++ header.
5752 (Category::Category): Update to String usage.
5753 (Category::name): Ditto.
5754 (Category::key): Ditto.
5755 * choose.cc: Remove concat.h, it's not needed.
5756 (scan2): Update to String usage.
5758 * cygpackage.cc: Update includes for use of String class.
5759 (cygpackage::cygpackage): Update for String usage.
5760 (cygpackage::set_canonical_version): Ditto.
5761 (cygpackage::destroy): Ditto.
5762 (cygpackage::getfirstfile): Ditto.
5763 (cygpackage::getnextfile): Ditto.
5764 (cygpackage::Name): Ditto.
5765 (cygpackage::Vendor_version): Ditto.
5766 (cygpackage::Package_version): Ditto.
5767 (cygpackage::Canonical_version): Ditto.
5768 (cygpackage::set_sdesc): Ditto.
5769 (cygpackage::set_ldesc): Ditto.
5770 * cygpackage.h: Include String++.h for parsing this file.
5771 (cygpackage::cygpackage): Update for String usage.
5772 (cygpackage::set_canonical_version): Ditto.
5773 (cygpackage::destroy): Ditto.
5774 (cygpackage::getfirstfile): Ditto.
5775 (cygpackage::getnextfile): Ditto.
5776 (cygpackage::Name): Ditto.
5777 (cygpackage::Vendor_version): Ditto.
5778 (cygpackage::Package_version): Ditto.
5779 (cygpackage::Canonical_version): Ditto.
5780 (cygpackage::set_sdesc): Ditto.
5781 (cygpackage::set_ldesc): Ditto.
5782 (cygpackage::name): Ditto.
5783 (cygpackage::vendor): Ditto.
5784 (cygpackage::packagev): Ditto.
5785 (cygpackage::canonical): Ditto.
5786 (cygpackage::fn): Ditto.
5787 (cygpackage::sdesc): Ditto.
5788 (cygpackage::ldesc): Ditto.
5789 * desktop.cc: Update includes for use of String class.
5790 (batname): Update for String usage.
5793 (start)menu): Ditto.
5794 (desktop_icon): Ditto.
5795 (make_cygwin_bat): Ditto.
5796 (make_etc_profile): Ditto.
5798 (make_passwd_group): Ditto.
5800 (check_desktop): Ditto.
5801 (check_startmenu): Ditto.
5802 * dialog.cc (eget): Update for String usage.
5803 (egetString): New function.
5804 (eset): New variant for Strings.
5805 * dialog.h: Include String++.h for parsing this file.
5806 (egetString): New function.
5807 (eset): New variant for Strings.
5808 * diskfull.cc (diskfull): Update for String usage.
5809 * diskfull.h: Include String++.h for parsing this file.
5810 (diskfull): Update for String usage.
5811 * download.cc: Update includes for use of String class.
5812 (check_for_cached): Update for String usage.
5813 (download_one): Ditto.
5814 * filemanip.cc (get_file_size): Ditto.
5816 (parse_filename): Ditto.
5818 * filemanip.h: Include String++.h for parsing this file.
5819 (fileparse): Update for String usage.
5821 (parse_filename): Ditto.
5822 Don't consider '_' to be a separator.
5824 * find.cc: Update includes for use of String class.
5825 (find_sub): Make more flexible.
5826 (find): Update for String usage.
5827 * find.h (find): Use Strings.
5828 * fromcwd.cc (found_file): Update for String usage.
5830 (init_dialog): Ditto.
5831 (get_url_to_membuf): Ditto.
5832 (get_url_to_string): Ditto.
5833 (get_url_to_file): Ditto.
5835 (get_url_to_membuf): Ditto.
5836 (get_url_to_string): Ditto.
5837 (get_url_to_file): Ditto.
5839 (add_subdirs): Ditto.
5840 * ini.cc: Update includes for String usage.
5841 (find_routine): Update for String usage.
5842 (do_remote_ini): Ditto.
5843 (do_ini_thread): Ditto.
5844 * ini.h (ini_init): Ditto.
5845 * inilex.l: Update includes for String usage.
5846 (ini_init): Update for String usage.
5847 * iniparse.y: Ditto.
5848 (add_correct_version): Ditto.
5849 * install.cc: Update includes for String usage.
5850 (install_one_source): Update for String usage.
5851 (uninstall_one): Ditto.
5852 (replace_one): Ditto.
5853 (install_one_source): Ditto.
5854 (do_install_thread): Ditto.
5855 * io_stream.cc: Update includes for String usage.
5856 (io_stream::open): Update for String usage.
5857 (io_stream::mkpath_p): Ditto.
5858 (io_stream::remove): Ditto.
5859 (io_stream::mklink): Ditto.
5860 (io_stream::move_copy): Ditto.
5861 (io_stream::move): Ditto.
5862 (io_stream::exists): Ditto.
5863 * io_stream.h: Update includes to allow correct parsing.
5864 (io_stream::open): Update for String usage.
5865 (io_stream::mkpath_p): Ditto.
5866 (io_stream::remove): Ditto.
5867 (io_stream::mklink): Ditto.
5868 (io_stream::move_copy): Ditto.
5869 (io_stream::move): Ditto.
5870 (io_stream::exists): Ditto.
5871 * io_stream_cygfile.cc: Update includes for String usage.
5872 (get_root_dir_now): Update for String usage.
5873 (io_stream_cygfile::io_stream_cygfile): Ditto.
5874 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5875 (io_stream_cygfile::exists): Ditto.
5876 (io_stream_cygfile::remove): Ditto.
5877 (io_stream_cygfile::mklink): Ditto.
5878 (cygmkdir_p): Ditto.
5879 (io_stream_cygfile::set_mtime): Ditto.
5880 (io_stream_cygfile::move): Ditto.
5881 (io_stream_cygfile::get_size): Ditto.
5882 * io_stream_cygfile.h: Update includes for String usage.
5883 (io_stream_cygfile::io_stream_cygfile): Update for String usage.
5884 (io_stream_cygfile::~io_stream_cygfile): Ditto.
5885 (io_stream_cygfile::exists): Ditto.
5886 (io_stream_cygfile::remove): Ditto.
5887 (io_stream_cygfile::mklink): Ditto.
5888 (cygmkdir_p): Ditto.
5889 (io_stream_cygfile::set_mtime): Ditto.
5890 (io_stream_cygfile::move): Ditto.
5891 (io_stream_cygfile::get_size): Ditto.
5892 (io_stream_cygfile::fname): Ditto.
5893 (io_stream_cygfile::lmode): Ditto.
5894 * io_stream_file.cc: Update includes for String usage.
5895 (io_stream_file::io_stream_file): Update for String usage.
5896 (io_stream_file::~io_stream_file): Ditto.
5897 (io_stream_file::exists): Ditto.
5898 (io_stream_file::remove): Ditto.
5899 (io_stream_file::mklink): Ditto.
5900 (io_stream_file::set_mtime): Ditto.
5901 (io_stream_file::move): Ditto.
5902 (io_stream_file::get_size): Ditto.
5903 * io_stream_file.h: Update includes for String usage.
5904 * io_stream_file.cc: Update includes for String usage.
5905 (io_stream_file::io_stream_file): Update for String usage.
5906 (io_stream_file::~io_stream_file): Ditto.
5907 (io_stream_file::exists): Ditto.
5908 (io_stream_file::remove): Ditto.
5909 (io_stream_file::mklink): Ditto.
5910 (io_stream_file::set_mtime): Ditto.
5911 (io_stream_file::move): Ditto.
5912 (io_stream_file::get_size): Ditto.
5913 (io_stream_file::fname): Ditto.
5914 (io_stream_file::lmode): Ditto.
5915 * localdir.cc: Update includes for String usage.
5916 (save_local_dir): Update for String usage.
5917 (check_if_enable_next): Ditto.
5918 (load_dialog): Ditto.
5920 (LocalDirPage::OnInit): Ditto.
5921 (LocalDirPage::OnNext): Ditto.
5922 * log.cc: Update includes for String usage.
5923 (struct LogEnt): Update for String usage.
5926 (exit_setup): Ditto.
5927 * log.h: Update includes for String usage.
5928 (log_level): Update for String usage.
5931 * main.cc (WinMain): Update for String usage.
5932 * mklink2.c (make_link_2): Update for String usage.
5933 * mklink2.h (make_link_2): Update for String usage.
5934 * mount.cc: Update includes for String usage.
5935 (mount_table): Update for String usage.
5937 (create_mount): Ditto.
5939 (remove_mount): Ditto.
5940 (read_mounts): Ditto.
5941 (set_root_dir): Ditto.
5942 (get_root_dir): Ditto.
5943 (path_prefix_p): Ditto.
5945 * mount.h: Update includes for String usage.
5946 (create_mount): Update for String usage.
5947 (remove_mount): Ditto.
5949 (set_root_dir): Ditto.
5950 (get_root_dir): Ditto.
5951 * msg.cc (mbox): Ditto.
5952 * net.cc (NetPage::OnNext): Ditto.
5953 * package_db.cc (packagedb::flush): Ditto.
5954 (packagedb::packages): Ditto.
5955 (packagedb::categories): Ditto.
5956 * package_db.h: Update includes for String usage.
5957 (packagedb::packages): Update for String usage.
5958 (packagedb::categories): Ditto.
5959 * package_meta.cc: Update includes for String usage.
5960 (hash::add_subdirs): Update for String usage.
5961 (packagemeta::uninstall): Ditto.
5962 (packagemeta::SDesc): Ditto.
5963 (packagemeta::action_caption): Ditto.
5964 * package_meta.h: Update includes for String usage.
5965 (packagemeta::packagemeta): Update for String usage.
5966 (packagemeta::~packagemeta): Ditto.
5967 (packagemeta::uninstall): Ditto.
5968 (packagemeta::SDesc): Ditto.
5969 (packagemeta::action_caption): Ditto.
5970 (package_source.cc site::site): Ditto.
5971 (packagesource::set_canonical): Ditto.
5972 (packagesource::set_cached): Ditto.
5973 * package_source.h: Update includes for String usage.
5974 (site::site): Update for String usage.
5975 (packagesource::set_canonical): Ditto.
5976 (packagesource::set_cached): Ditto.
5977 (packagesource::packagesource): Ditto.
5978 (packagesource::sites): Ditto.
5979 (packagesource::cached): Ditto.
5980 * package_version.h: Update includes for String usage.
5981 (Dependency): Update for String usage.
5982 (packageversion): Ditto.
5983 * postinstall.cc: Update includes for String usage.
5984 (do_postinstall): Update for String usage.
5985 * res.rc (IDD_LOCAL_DIR): Fix typo again!
5986 * rfc1738.cc (rfc1738_escape_part): Update for String usage.
5987 * rfc1738.h: Update includes for String usage.
5988 (rfc1738_escape_part): Update for String usage.
5989 * root.cc: Update includes for String usage.
5990 (check_if_enable_next): Update for String usage.
5991 (save_dialog): Ditto.
5993 (directory_is_absolute): Ditto.
5994 (directory_is_rootdir): Ditto.
5995 (directory_has_spaces): Ditto.
5996 (RootPage::OnInit): Ditto.
5997 (RootPage::OnNext): Ditto.
5998 * script.cc: Update includes for String usage.
5999 (init_run_script): Update for String usage.
6001 (run_script): Ditto.
6002 (try_run_script): Ditto.
6003 * script.h: Update includes for String usage.
6004 (run_script): Update for String usage.
6005 (try_run_script): Ditto.
6006 * site.cc site_list): Ditto.
6007 (all_site_list): Ditto.
6008 (other_url): Eliminate.
6009 (site_list_type::init): Update for String usage.
6010 (site_list_type::site_list_type): Ditto.
6011 (get_site_list): Ditto.
6012 (get_saved_sites): Ditto.
6013 (do_download_site_info_thread): Ditto.
6014 (SitePage::OnNext): Ditto.
6015 (SitePage::OnActivate): Ditto.
6016 (SitePage::PopulateListBox): Ditto.
6017 (SitePage::OnMessageCmd): Handle empty url's.
6018 * site.h: Update includes for String usage.
6019 (site_list_type::site_list_type): Update for String usage.
6020 (site_list_type::init): Ditto.
6021 (site_list_type::~site_list_type): Ditto.
6022 (site_list_type::url): Ditto.
6023 (site_list_type::displayed_url): Ditto.
6024 (site_list_type::key): Ditto.
6025 * source.cc (SourcePage::OnDeactivate): Ditto.
6026 * state.h: Update includes for String usage.
6027 (local_dir): Update for String usage.
6028 (trust_level): Remove.
6029 * version.cc: Update includes for String usage.
6030 (canonicalize_version): Update for String usage.
6031 * version.h: Update includes for String usage.
6032 (canonicalize_version): Update for String usage.
6034 2002-02-15 Christopher Faylor <cgf@redhat.com>
6036 * filemanip.c (parse_filename): Revert previous change.
6038 2002-02-14 Christopher Faylor <cgf@redhat.com>
6040 * filemanip.c (parse_filename): Don't treat '_' as a version number
6043 2002-01-29 Christopher Faylor <cgf@redhat.com>
6045 * configure: Regenerate.
6047 2002-01-27 Robert Collins <rbtcollins@hotmail.com>
6049 * res.rc (IDD_LOCAL_DIR): Fix typo reported by Rene
6050 <Hoeck@extern.lrz-muenchen.de>
6052 2002-01-27 Robert Collins <rbtcollins@hotmail.com>
6054 * README: Update Todo's.
6055 * list.h: Run indent.
6056 (list): New methods checksize and insert to reduce code duplication.
6057 (list::registerbykey): Use them.
6058 (list::registerbyobject): Ditto.
6059 (list::removebyindex): Copy each object individually - safe for non
6061 (list::checksize): Implement.
6062 (list::insert): Implement.
6064 2002-01-27 Robert Collins <rbtcollins@hotmail.com>
6066 * Makefile.in: Remove the dlmalloc object by default.
6067 * install.cc (do_install_thread): Remove the mallinfo call for 'working
6068 around' the crashing issue.
6069 * package_db.h: Include <string.h> - it's needed to parse this.
6070 * package_source.cc (site::site): Move here from the header file.
6071 * package_source.h (site): Stop the constructor being inlinable.
6073 2002-01-26 Robert Collins <rbtcollins@hotmail.com>
6075 * filemanip.cc (find_tar_ext): Add a descriptive comment.
6077 2002-01-25 Michael A Chase <mchase@ix.netcom.com>
6079 * filemanip.cc (find_tar_ext): Clean up tests for .tar.gz and .tar.
6080 * fromcwd.cc (do_fromcwd): Expand FIXME comment in source file check.
6081 * install.cc (install_one_source): Add space between words in log()
6084 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
6086 * log.cc (exit_setup): When saving to the download dir, explicity
6089 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
6091 * archive.cc (extract_file): Separate out the prefix and the URL
6093 * archive.h (archive::extract_file): Ditto.
6094 * install.cc (install_one_source): Ditto. Use the new
6095 archive::extract_file syntax.
6096 (replace_one): Use the new syntax.
6097 (io_stream.cc): Add some log info for links.
6099 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
6101 * PickCategoryLine.cc (PickCategoryLine::actiontext): Remove.
6102 (PickCategoryLine::paint): Use the new action method.
6103 (PickCategoryLine::click): Set the action for all children.
6104 (PickCategoryLine::set_action): New method.
6105 * PickCategoryLine.h (PickCategoryLine::-actions): Remove.
6106 (PickCategoryLine::current_default): Use packagemeta _actions class.
6107 * PickLine.h (PickLine::set_action): New abstract method that requires
6108 including package_meta.h.
6109 * PickPackageLine.cc (PickPackageLine::set_action): New method.
6110 * PickPackageLine.h (PickPackageLine::set_action): Declare this.
6111 * list.h (getbykey): A const correctness fix.
6112 * package_meta.cc: Run indent.
6113 (packagemeta::Default_action): New const.
6114 (packagemeta::Install_action): Ditto.
6115 (packagemeta::Reinstall_action): Ditto.
6116 (packagemeta::Uninstall_action): Ditto.
6117 (packagemeta::_actions::caption): New method.
6118 (packagemeta::_actions::operator++): Ditto.
6119 (packagemeta::set_action): New overload.
6120 * package_meta.h (packagemeta::_actions): New class.
6121 (packagemeta::set_action): Declare this.
6123 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
6125 * Makefile.in (OBJS): Remove supp.o - it appears accidental.
6126 * choose.cc: Don't define alloca anymore, it's done in win32.h
6128 2002-01-22 Robert Collins <rbtcollins@hotmail.com>
6130 * PickPackageLine.cc: New file.
6131 * PickPackageLine.h: New file.
6132 * PickLine.cc: New file.
6133 * PickLine.h: New file.
6134 * PickCategoryLine.cc: New file.
6135 * PickCategoryLine.h: New file.
6136 * PickView.cc: New file.
6137 * PickView.h: New file.
6138 * Makefile.in: Add new objects to setup.exe.
6139 Backout -fno-exceptions option.
6140 * choose.cc: Include PickView.h.
6141 Remove view related defines and static variables.
6142 (_pkg_headers): Moved to PickView.cc.
6143 (_cat_headers): Ditto.
6144 (view::views::Unknown): Ditto.
6145 (view::views::PackageFull):
6146 (view::views::Package):
6147 (view::views::Category):
6148 (pkgtrustp): Moved to package_meta.cc.
6149 (add_required): Moved to package_meta.cc.
6150 (pick_category_line::empty): Moved to PickCategoryLine.cc
6151 (paint): Adjust for moved static variables.
6152 (view::scroll): Moved to PickView.cc.
6153 (list_vscroll): Adjust for moved static variables.
6154 (list_hscroll): Ditto.
6155 (list_click): Ditto.
6156 (note_width): Moved to PickView.cc.
6157 (view::view): Ditto.
6158 (view::set_view_mode): Ditto.
6159 (view::mode_caption): Ditto.
6160 (view::views::caption): Ditto.
6161 (view::set_headers): Ditto.
6162 (DoInsertItem): Ditto.
6163 (view::init_headers): Ditto.
6164 (view::insert_pkg): Ditto.
6165 (view::insert_category): Ditto.
6166 (view::clear_view): Ditto.
6167 (view::views::operator++): Ditto.
6168 (view::click): Ditto.
6169 (default_trust): Adjust for moved statics.
6170 (pick_pkg_line::paint): Moved to PickPackageLine.cc.
6171 (pick_pkg_line::click): Ditto.
6172 (pick_category_line::actiontext): Moved to PickCategoryLine.cc
6173 (pick_category_line::paint): Ditto.
6174 (pick_category_line::click): Ditto.
6175 (set_view_mode): Adjust for moved statics.
6176 (create_listview): Ditto.
6177 * choose.h: Remove Category and packagemeta forward defines -
6179 Don't include unneeded headers list and package_meta.
6180 (_header): Move to PickView.h.
6181 (pick_line): Move to PickLine.h.
6182 (pick_pkg_line): Move to PickPackageLine.h.
6183 (pick_category_line): Move to PickCategoryLine.h.
6184 (view): Move to PickView.h.
6185 * ini.h (trusts): Move to package_meta.h.
6186 * package_meta.h (trusts): New enum.
6187 (packagemeta::set_requirements): New helper method.
6188 (packagemeta::trustp): Ditto.
6190 2002-01-21 Christopher Faylor <cgf@redhat.com>
6192 * choose.h (view): Move forward declaration of views into public area
6193 or g++ v3 will complain.
6195 2002-01-21 Christopher Faylor <cgf@redhat.com>
6197 * Makefile.in (CXXFLAGS): Add -fno-exceptions.
6198 * win32.h (alloca): Define as __builtin_alloca.
6199 * io_stream_memory.cc: Add include file.
6201 2002-01-21 Robert Collins <rbtcollins@hotmail.com>
6203 * archive_tar.cc (archive_tar::~archive_tar): Mark the stream as
6205 * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
6206 * compress.cc (compress::~compress): Be less verbose.
6207 * compress_bz.cc (compress_bz::~compress_bz): Ditto.
6208 Mark the stream as destroyed.
6209 * compress_gz.cc (compress_gz::~compress_gz): Mark the stream as
6211 * io_stream.cc (io_stream::~io_stream): Only warn when the stream is not
6212 marked as destroyed.
6213 * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Mark the
6214 stream as destroyed.
6215 * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
6216 * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
6218 2002-01-21 Robert Collins <rbtcollins@hotmail.com>
6220 * Makefile.in (CFLAGS): Allow customisable malloc debug flags.
6221 (OBJS): Link in malloc objects.
6222 * category.cc (category): Use new char, not strdup.
6223 * choose.cc (pick_pkg_line::paint): Allow for the regionsize to shrink.
6224 (do_choose): Use new char, not malloc.
6225 * concat.cc (vconcat): Ditto.
6226 * cygpackage.cc (cygpackage): Use new char, not strdup.
6227 (set_canonical_version): Ditto.
6228 (cygpackage::destroy): Use delete[], not free.
6229 * desktop.cc (uexists): Ditto.
6230 * dialog.cc (egest): Use new char, not strdup.
6231 * dlmalloc.c: New file - Doug Lea's malloc 2.7.0
6232 * hash.cc (hash::hash): Use delete instead of free.
6233 (hash::add): Use new char, not strdup.
6234 * ini.cc (do_remote_ini): Use delete[] not free.
6235 * inilex.l: Use new char, not strdup.
6237 * iniparse.y: Ditto.
6238 Use a local package_db rather than a static one.
6239 * install.cc (struct mallinfo): Workaround an apparent dlmalloc bug.
6240 (do_install_thread): Call mallinfo to force a consistency check. Appears
6241 to fix a 'inuse' error in -DDEBUG builds.
6242 Use delete[] for strings.
6243 * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Use new
6245 (io_stream_cygfile::~io_stream_cygfile): Use delete[], not free.
6246 (io_stream_cygfile::remove): Use new char, not strdup.
6247 * io_stream_file.cc (io_stream_file::io_stream_file): Use new char, not
6249 (io_stream_file::io_stream_file): Use delete[], not free.
6250 (io_stream_file::remove): Use new char, not strdup.
6251 * io_stream_memory.cc (memblock::~memblock): Use delete[], not free.
6252 * io_stream_memory.h (memblock): Use new char, not malloc.
6253 * localdir.cc (LocalDirPage::OnInit): Use new char, not strdup.
6254 * main.cc (WinMain): Use new char, not strdup.
6255 * mount.cc (find2): Use new char, not malloc.
6256 (read_mounts): Ditto.
6257 (cygpath): Use new char, not strdup.
6258 * netio.cc (NetIO::~NetIO): Use delete[], not free.
6259 (NetIO::set_url): Use new char, not strdup.
6260 (NetIO::get_ftp_auth): Use delete[], not free.
6261 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
6262 Use new char instead of strdup.
6263 * nio-http.cc (base64_encode): Use new char, not malloc.
6264 * package_meta.cc (hash::add_subdirs): Use new char instead of strdup.
6265 * package_source.h (~ packagesource): Use delete[] instead of delete.
6266 * port.h (strdup): Deprecate the use of strdup.
6267 * rfc1738.cc (rfc1738_do_escape): Use new char, not calloc.
6268 * script.cc (init_run_script): Us delete[], not free.
6269 (run_script): Ditto.
6270 * simpsock.cc (SimpleSocket::fill): Use new char, not malloc.
6271 (SimpleSocket::invalidate): Use delete[], not free.
6272 * site.cc (site_list_type::init): Use new char instead of strdup.
6273 * site.h (~site_list_type): Use delete[], not free.
6275 2002-01-20 Robert Collins <rbtcollins@hotmail.com>
6277 * Makefile.in (OBJS): Add win32.o - win32 support functions.
6278 * README: Update todos.
6279 * archive.cc (extract_file): Support a suffix for appending to extracted
6282 * choose.cc (set_view_mode): Use the new view::views class.
6283 (view::views::Unknown): New static for defaulting view::views variables.
6284 (view::views::PackageFull): New static for the current view.
6285 (view::views::Package): Ditto.
6286 (view::views::Category): Ditto.
6287 (topbucket::paint): Remove.
6288 (topbucket::empty): Rename to pick_category_line::empty.
6289 (topbucket::~topbucket): Remove.
6290 (paint): Use the new view::views class.
6291 Don't paint 'all' as a category when showing package categoies.
6292 (pick_category_line::actiontext): New method.
6293 (pick_category_line::paint): Make showing the category optional, and
6294 show the 'category action'.
6295 (pick_category_line::click): Make showing the category optional, and
6296 differentiate between the name being clicked, and the action
6298 (view::view): Use the new view::views class.
6299 (view::set_view_mode): Ditto.
6300 (view::mode_caption): Ditto.
6301 (view::views::caption): New method.
6302 (view::set_headers): Use the new view::views class.
6303 (view::clear_view): Ditto.
6304 (viewsplusplus): Replaced by
6305 (view::views::operator++): New operator.
6306 (set_view_mode): Use the new view::views class.
6307 (create_listview): Ditto.
6308 (dialog_cmd): Ditto.
6309 * choose.h (actions): Remove.
6311 (pick_line): Add a new convenience constructor.
6312 (top_bucket): Remove.
6313 (pick_category_line): Reparent under pick_line, and adsorb top_bucket.
6314 (view::views): New class.
6315 * ini.h: Don't include choose.h
6316 (is_download_action): Remove.
6317 (is_upgrade_action): Remove.
6318 (is_uninstall_action): Remove.
6319 (is_full_action): Remove.
6320 * install.cc (num_replacements): New static.
6321 (rebootneeded): Ditto.
6322 (replace_one): Handle upgrades separate from removal or new installs.
6323 (install_one_source): Handle in use files.
6324 (install_one): Don't repeat upgrades.
6325 (do_install_thread): Initialize new statics.
6326 Order actions as uninstall, replace, install.
6327 Warn about rebooting if needed.
6328 * res.rc (IDS_REBOOT_REQUIRED): New string.
6329 * resource.h (IDS_REBOOT_REQUIRED): Give value.
6330 * win32.h: Declare class Win32, and update copyright and intent message.
6331 * win32.cc: New file.
6333 2002-01-15 Corinna Vinschen <corinna@vinschen.de>
6335 * io_stream.cc (io_stream::gets): Eliminate trailing new line chars.
6336 * package_meta.cc (packagemeta::uninstall): Check for additional
6337 Windows shortcut. Unset R/O file attribute before trying to delete
6340 2002-01-09 Robert Collins <rbtcollins@hotmail.com>
6342 * choose.cc (pkgtrustp): Fall back to installed if a package is not
6343 present in the current trust level. For prev, fall back via curr.
6344 (set_existence): Allow sources with no sites, but cached files to be
6346 (pick_category_line::paint): Start drawing clickable categories.
6347 * fromcwd.cc (found_file): Reinstate local file scanning.
6349 2002-01-07 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6351 * fromcwd.cc: Run indent.
6352 (do_fromcwd): Reverse sense of comment. Set next_dialog
6353 to IDD_CHOOSER instead of IDD_CHOOSE.
6354 * ini.cc (find_routine): Remove "/" from "/setup.ini".
6356 2001-01-07 Robert Collins <rbtcollins@hotmail.com>
6358 * category.cc (Categorycmp): Add a const safe version.
6359 * category.h (Categorycmp): Add a const safe version.
6360 (Category): Add operator ==.
6361 * choose.cc (fill_missing_category): Add every package to "All".
6362 (pick_category_line::paint): Add support for hidden labels, and a tree
6364 (pick_category_line::click): Ditto.
6365 (view::view): Pass in a top level category to use.
6366 (view::insert_pkg): Special case - skip category "All".
6367 (view::insert_category): Ditto.
6368 (view::clear_view): Set the contents label state.
6369 (create_listview): Pass in a top level category to view().
6370 * choose.h (topbucket): Make bucket available to derived classes.
6371 (pick_category_line): Add support for hidden labels, and a tree depth.
6372 Remove our second copy of bucket.
6373 (view): Pass in a top level category to the constructor.
6374 Use pick_category_line to allow three level display.
6376 2001-01-06 Robert Collins <rbtcollins@hotmail.com>
6378 * cygpackage.h (cygpackage): Make set_[s|l]desc virtual.
6379 * iniparse.y (add_correct_version): Copy descriptions across.
6380 * package_meta.cc (SDesc): Iterate through versions, return the first
6382 * package_version.h (packageversion): Add new virtuals set_[l|s]desc.
6384 2001-01-04 Robert Collins <rbtcollins@hotmail.com>
6386 * script.cc (run_script): Change cygpath:// to cygfile://.
6387 * install.cc (do_install_thread): Fix off-by-one errors.
6389 2001-01-04 Robert Collins <rbtcollins@hotmail.com>
6391 * package_db.cc (packagedb::flush): Fix an off-by-one error.
6393 2002-01-04 Jan Nieuwenhuizen <janneke@gnu.org>
6395 * Makefile.in (realclean): more clean.
6396 (OBJS): Add script.o.
6397 * postinstall.cc (run_script_in_etc_postinstall): New function.
6398 (do_postinstall): Split off new funtion init_run_script ().
6401 (run_script): Move to script.cc. Replace some deprecated remove
6404 * script.cc: New file.
6405 * Forward port cygwin-20010707.jcn3.patch.
6406 * package_meta.cc (uninstall): Run pre- and postremove scripts.
6407 * install.cc: Typo fix.
6408 (do_install): Run script initialisation.
6410 2001-01-04 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6412 * cistring.cc: Run d2u.
6413 * cistring.h: Run d2u.
6415 * desktop.cc (etc_profile): Remove "test -f ./.bashrc && . ./.bashrc"
6416 from the generated /etc/profile. Bash will source this file
6417 automatically, and having this here merely results in .bashrc being
6418 executed twice. Run d2u.
6419 * desktop.h: Run d2u.
6421 * propsheet.cc: Run d2u.
6422 (PropSheetProc): New function. Add minimize box here instead of in
6423 PropertyPage::DialogProc.
6424 (PropSheet::Create): Change to use creation callback PropSheetProc.
6425 (DLGTEMPLATEEX): Add 'hidden' Windows struct definition.
6427 * propsheet.h: Run indent, d2u.
6428 * proppage.h: Run indent, d2u.
6430 * proppage.cc: Run d2u.
6431 (PropertyPage::DialogProc): Remove minimize-box-adding
6432 functionality. Remove commented-out "PropSheet_SetWizButtons" calls.
6433 Add support for calling virtual OnMessageCmd. Add setting of fonts in
6434 WM_INITDIALOG handler.
6435 (resource.h): New include for resource IDs.
6437 * res.rc: Resize and rearrange property page dialog templates
6438 to bring them in line with "Microsoft's Backward Compatible Wizard 97"
6439 specification. Run d2u.
6440 (IDD_SITE): Add an edit control and an "Add" button in order to
6441 combine the IDD_SITE and IDD_OTHER_URL functionality onto one page.
6442 (IDD_OTHER_URL): Remove dialog template.
6443 (IDD_DLSTATUS): Remove dialog template.
6446 (SitePage::OnBack): Remove NEXT() macro invocation.
6447 (SitePage::OnActivate): New member function.
6448 (load_dialog): Remove. Functionality subsumed into
6449 SitePage::OnActivate.
6450 (save_dialog): Change to support both list and user URLs. Remove
6451 OTHER_IDX and mirror_idx logic.
6452 (SitePage::PopulateListBox): New member function.
6453 (SitePage::CheckControlsAndDisableAccordingly): New member function.
6454 (SitePage::OnMessageCmd): New override.
6455 (check_if_enable_next): Remove.
6456 (dialog_cmd): Remove.
6457 (do_download_site_info_thread): Remove calls to NEXT() macro.
6458 (SitePage::Create): Call the single-param PropertyPage::Create
6460 (other_url): New static taken from other.cc.
6461 (SitePage::OnNext): Remove mirror_idx logic.
6462 (SitePage::OnInit): Remove "Other URL" entry from list box. Remove
6463 list box populating code, now handled in SitePage::PopulateListBox.
6464 (mirror_idx, NO_IDX, OTHER_IDX): Remove.
6465 (save_site_url): Fix potential buffer overflow problem. Switched to
6466 TCHAR in grossly premature preparation for multilingual support.
6468 (SitePage::OnActivate): New member function.
6469 (SitePage::CheckControlsAndDisableAccordingly) New member.
6470 (SitePage::OnMessageCmd): New override.
6471 (do_download_site_info_thread): Add MessageBox call on failure to
6474 * splash.cc: Run d2u.
6475 (SplashPage::OnInit): Set the font for the title.
6476 * splash.h: Run d2u.
6478 * threebar.cc: Run d2u.
6479 * threebar.h: Run d2u.
6481 * window.h: Run d2u.
6482 (Window::IsButtonChecked): New member function declaration.
6483 (Window::OnMessageCmd): New member function.
6484 (Window::SetDlgItemFont): New member function declaration.
6485 (Window::MAXFONTS, Window::Fonts, Window::FontCounter): New data
6487 * window.cc: Run d2u.
6488 (Window::IsButtonChecked): New member function definition.
6489 (Window::SetDlgItemFont): New member function definition.
6490 (Window::Window): Add initialization for FontCounter.
6491 (Window::~Window): Delete any fonts we created.
6493 * geturl.cc: Run d2u.
6494 (progress): Remove the "3" field width from the "%3d"
6495 percent-complete format indicator. Causes line to not start at
6496 beginning of text box, and does little to help with "jumping", since
6497 the "bytes downloaded so far" field is variable-width anyway. Change
6498 kb/s format field to "%03.1" to 0-pad the kb/s number in the event of
6499 painfully slow connections, or temporary slowdowns in faster
6500 connections should such more-instantaneous functionality become
6504 (NetPage::OnMessageCmd): New member function declaration.
6505 (NetPage::CheckIfEnableNext): New member function declaration.
6507 (NetPage::OnMessageCmd): New member function definition.
6508 (dialog_cmd): Remove, subsumed into NetPage::OnMessageCmd.
6509 (check_if_enable_next): Remove.
6510 (NetPage::CheckIfEnableNext): New member function, subsumes
6511 check_if_enable_next.
6512 (propsheet.h): Add include.
6513 (NetPage::Init): Add call to CheckIfEnableNext.
6514 (load_dialog): Remove call to check_if_enable_next.
6515 (NetPage::Create): Call single-template-ID-parameter overload of
6516 PropertyPage::Create instead of three-parameter one.
6518 * Makefile.in (OBJS): Remove other.o.
6519 * other.cc: Remove file.
6521 2002-01-01 Robert Collins <rbtcollins@hotmail.com>
6523 * README: Update TODO's.
6524 * choose.cc (set_existence): Delete non installed packages with no
6526 (fill_missing_category): Fix an off-by-one error.
6527 (default_trust): Ditto. Also delete any unused categories.
6528 (view::init_headers): Fix an off-by-one error.
6529 (set_view_mode): Ditto.
6530 (set_view_mode): Ditto.
6531 (create_listview): Ditto.
6532 (dialog_cmd): Ditto.
6534 * io_stream.cc: Indent.
6535 * io_stream.h: Ditto.
6536 * package_db.cc: Ditto.
6537 * package_meta.h: Const correctness for SDesc ();
6538 * proppage.cc: Run d2u and indent.
6539 * propsheet.cc: Run d2u and indent.
6540 * window.cc: Run d2u and indent.
6541 * window.h: Run d2u and indent.
6543 2001-12-28 Christopher Faylor <cgf@redhat.com>
6545 * Makefile.in (iniparse.o): Accommodate newer bisons.
6547 2001-12-23 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
6549 * window.h (Window): New file, new class.
6550 * window.cc (Window): New file, new class.
6552 * threebar.h (ThreeBarProgressPage): New file, new class.
6553 * threebar.cc (ThreeBarProgressPage): New file, new class.
6555 * splash.h (SplashPage): New file, new class.
6556 * splash.cc (SplashPage): Replace file with implementation of new
6559 * source.h (SourcePage): New file, new class.
6560 * source.cc: Run indent.
6561 (SourcePage): Add class implementation to this file.
6562 (do_source): Remove, functionality subsumed by SourcePage::Create()
6563 and SourcePage::OnDeactivate().
6564 (dialog_proc): Remove, functionality subsumed by
6565 SourcePage::OnActivate().
6567 * site.h: Run indent.
6568 (SitePage): Add class declaration.
6569 * site.cc: Run indent.
6570 (SitePage): Add class implementation.
6571 (do_download_site_info_thread): New function.
6572 (context): New var. Context info for do_download_site_info_thread().
6573 (do_download_site_info): New function.
6574 (SitePage::Create, SitePage::OnInit SitePage::OnNext)
6575 (SitePage::OnBack): SitePage class implementation..
6576 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers, now handled
6577 by SitePage members.
6578 (dialog_proc): Remove, now handled by SitePage::OnInit and base class
6580 (do_site): Remove, now handled by do_download_site_info_thread() and
6581 SitePage::OnNext functionality.
6582 (get_site_list): Remove dismiss_url_status_dialog() call.
6584 * root.h (RootPage): New file, new class.
6585 * root.cc: Run indent.
6586 (dialog_cmd): Pass parent HWND parameter to note(), yesno().
6587 (dialog_proc): Remove.
6589 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL clauses from switch.
6590 (RootPage::OnInit): New member function. Move get_root_dir() logic to
6591 here from do_root().
6592 (RootPage::Create): New member function.
6593 (RootPage::OnNext): New member function. Move IDOK logic from
6594 dialog_cmd() to here.
6595 (RootPage::OnBack): New member function.
6597 * propsheet.h (PropSheet): New file, new class.
6598 * propsheet.cc (PropSheet): New file, new class.
6600 * proppage.h (PropertyPage): New file, new class.
6601 * proppage.cc (PropertyPage): New file, new class.
6603 * postinstall.cc (do_postinstall): Add owner parameter.
6605 * other.cc (do_other): Add owner parameter.
6607 * nio-file.cc (NetIO::Purl): Pass NULL parent param to note().
6608 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Pass NULL parent param to
6610 * nio-http.cc (retry_get): Pass NULL parent param to get_auth(),
6613 * nio-ie5.cc (NetIO::_url): Pass NULL parent param to note(),
6614 get_auth(), get_proxy_auth().
6616 * netio.h (get_auth, get_proxy_auth, get_ftp_auth): Add owner param.
6617 * netio.cc (auth_common, NetIO::get_auth, NetIO::get_proxy_auth,
6618 NetIO::get_ftp_auth)
6619 (auth_common): Add owner param. Pass owner param to DialogBox.
6620 (NetIO::get_auth, NetIO::get_proxy_auth, NetIO::get_ftp_auth): Pass
6621 owner param to auth_common().
6623 * net.h (NetPage): New file, new class.
6624 * net.cc: Run indent.
6625 (net.h, threebar.h): Add includes.
6626 (Progress): Add extern.
6627 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, now handled by
6628 property sheet logic. Saved temporarily for reference.
6629 (NetPage::Create, NetPage::OnInit, NetPage::OnDeactivate,
6630 NetPage::OnNext, NetPage::OnBack):
6631 New implementation of NetPage class members.
6633 (dialog_proc): Remove.
6635 * msg.h (fatal, note, yesno): Add owner param.
6636 * msg.c (fatal, note, yesno, mbox): Add owner param.
6637 (mbox): Remove MB_TOPMOST from MessageBox call. Unnecessary and wrong
6638 now that we have a parent.
6640 * main.cc: Run indent.
6641 (commctrl.h, proppage.h, propsheet.h, splash.h, source.h)
6642 (localdir.h, net.h, site.h, choose.h, threebar.h, desktop.h): Include
6644 (root_dialog_proc): extern into this file.
6645 (Progress): Progress dialog defined here, used in several other files.
6646 (WinMain): Instantiate and create Splash, Source, Root, LocalDir, Net,
6647 Site, Chooser, Desktop pages and MainWindow sheet. Call
6648 InitCommonControls() to make sure Windows is set up for our use of
6649 property sheets. Add pages to sheet.
6650 Call MainWindow.Create() to "DoModal". Remove main loop, that logic is
6651 now handled by the PropSheet class.
6652 (root.h): Add include.
6654 * log.cc (log_save): Pass NULL parent to fatal().
6655 (exit_setup): Pass NULL parent to note().
6657 * localdir.h (LocalDirPage): New file, new class.
6658 * localdir.cc: Run indent.
6659 (localdir.h): New include.
6660 (threebar.h): New include.
6661 (Progress): extern into this file.
6662 (LocalDirPage::Create, LocalDirPage::OnInit, LocalDirPage::OnActivate)
6663 (LocalDirPage::OnNext, LocalDirPage::OnBack): Implementation of
6665 (LocalDirPage::OnNext): Move log() call from do_local_dir() to here.
6666 (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers.
6667 (do_local_dir): Remove.
6668 (dialog_proc): Remove.
6669 (cwd): Remove, not used by anything.
6671 * install.cc: Run indent.
6672 (process.h, threebar.h): New includes.
6673 (Progress): extern into this file.
6674 (ins_dialog, ins_action, ins_pkgname, ins_filename, ins_pprogress)
6675 (ins_iprogress, ins_diskfull, init_event): Remove, now handled by
6676 ThreeBarProgressPage.
6677 (dialog_cmd, dialog_proc, dialog): Removed, handled in
6678 ThreeBarProgressPage.
6679 (init_dialog): Remove all mention of the above ins_* handles. Now
6680 handled in ThreeBarProgressPage. Altered SetWindowText()s to call
6681 ThreeBarProgressPage instance Progress directly.
6682 (progress): Alter bar update logic to call ThreeBarProgressPage
6683 instance Progress directly.
6684 (uninstall_one): Alter SetWindowText()s to call ThreeBarProgressPage
6685 instance Progress directly.
6686 (install_one_source): Alter SetWindowText()s to call
6687 ThreeBarProgressPage
6688 instance Progress directly. Pass NULL parent to note().
6689 (do_install_thread): Rename from do_install(), added owner param.
6690 Alter SetWindowText()s to call ThreeBarProgressPage instance Progress
6692 Remove dismiss_url_status_dialog() call, no longer necessary. Remove
6693 ShowWindow(<hide>) call, also unnecessary now. Pass owner handle to
6695 (do_install_reflector): New function.
6696 (do_install): New function.
6698 * ini.cc (process.h, threebar.h): New includes.
6699 (Progress): externed into this file.
6700 (find_routine): Pass NULL parent to note().
6701 (do_local_ini): Add owner param.
6702 (do_remote_ini): Add owner param. Pass owner to get_url_to_membuf()
6703 and note(). Remove call to dismiss_url_status_dialog().
6704 (do_ini_thread): Rename from do_ini(). Add owner param. Pass owner to
6705 do_local_ini(), do_remote_ini(), yesno(), and note(). Set next_dialog
6706 to IDD_CHOOSER on exit.
6707 (do_ini_thread_reflector): New function.
6708 (context): New var. Context for do_ini_thread.
6709 (do_ini): New function.
6711 * geturl.h (get_url_to_membuf, get_url_to_string, get_url_to_file): Add
6713 * geturl.cc (gw_dialog, gw_url, gw_rate, gw_progress, gw_pprogress,
6715 (gw_progress_text, gw_pprogress_text, gw_iprogress_text, init_event):
6717 (threebar.h): New include.
6718 (Progress): externed into this file.
6719 (dialog_cmd, dialog_proc, dialog): Removed, handled by
6720 ThreeBarProgressPage now.
6721 (init_dialog): Remove "if (gw_dialog == 0)" clause. Alter
6723 and bar setting SendMessage()s to call ThreeBarProgressPage instance
6724 Progress directly. Remove "one bar only" logic, this is now handled
6725 explicitly in the ThreeBarProgressPage class.
6726 (progress): Altered bar and text update logic to call
6727 ThreeBarProgressPage instance Progress directly. Changed kbps
6728 calculation to floating point and now print out a single decimal
6730 (get_url_to_membuf): Add owner param. Pass it to init_dialog.
6731 (get_url_to_string): Add owner param. Pass it to get_url_to_membuf.
6732 (get_url_to_file): Add owner param. Pass it to init_dialog. Alter bar
6733 update logic to call ThreeBarProgressPage instance Progress directly.
6734 (dismiss_url_status_dialog): Remove.
6736 * fromcwd.cc (do_fromcwd): Add owner param. Initialize found_ini to
6739 * download.cc: Run indent.
6740 (process.h, threebar.h): New includes.
6741 (Progress): externed into this file.
6742 (download_one): Add owner param. Pass it to get_url_to_file().
6743 (do_download_thread): Renamed from do_download. Add owner param. When
6744 calculating total_download_bytes, take binpicked and srcpicked into
6745 account. Remove call to dismiss_url_status_dialog(), no longer needed.
6746 Pass owner handle to download_one() and yesno().
6747 (do_download_reflector, do_download): New functions.
6748 (context): New var. Context for do_download_thread().
6750 * dialog.h (D(x)): Add owner param.
6752 * desktop.h (DesktopSetupPage): New file, new class.
6753 * desktop.cc: Run indent.
6754 (desktop.h): Add include.
6755 (dialog_proc, do_desktop): Remove, now handled in
6756 DesktopSetupPage::OnInit().
6757 (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, handled in
6758 DesktopSetupPage::OnFinish(), DesktopSetupPage::OnBack(), and PropSheet
6760 (DesktopSetupPage::Create, DesktopSetupPage::OnInit)
6761 (DesktopSetupPage::OnBack, DesktopSetupPage::OnFinish): Implementation
6762 of DesktopSetupPage.
6764 * cistring.h: New file, new class.
6765 * cistring.cc: New file, new class.
6767 * choose.h: Run indent.
6768 (Chooser): New class declaration.
6769 * choose.cc: Run indent.
6770 (do_choose): Add owner param. Pass it to DialogBox() and
6772 (Chooser): New class implementation.
6774 * res.rc (IDS_VERSION_INFO): New string.
6775 (IDD_SOURCE, IDD_LOCAL_DIR, IDD_ROOT, IDD_SITE, IDD_OTHER_URL)
6776 (IDD_DLSTATUS, IDD_INSTATUS, IDD_SPLASH, IDD_CHOOSE, IDD_DESKTOP):
6777 Change WS_POPUP to WS_CHILD. Numerous positioning/size changes
6779 (IDD_CHOOSE): Give template the WS_EX_CONTROLPARENT style to enable
6780 TAB control navigation etc. Give the controls a reasonable tab order.
6781 Grouped radio buttons. Something's still not right, can't tab away
6782 from back/next/cancel group reliably.
6783 * resource.h (IDD_CHOOSER): New dialog ID.
6785 * Makefile.in (OBJS): Add cistring.o, proppage.o, propsheet.o,
6786 threebar.o, and window.o.
6788 2001-12-21 Robert Collins <rbtcollins@hotmail.com>
6790 * choose.cc (listview_proc): Update the scrollbar when the headers are
6792 (pick_pkg_line::paint): Clip columns to prevent overlap.
6794 2001-12-20 Robert Collins <rbtcollins@hotmail.com>
6796 * Makefile.in: Add libcomctl32.a for setup.exe.
6797 * archive.h (archive): Prevent non-child direct creation of the class.
6798 * archive_tar.h (archive_tar): Prevent inaccurate synthetic copy and
6800 * choose.cc: Include commctrl for the choose header.
6801 (NEW_COL_SIZE_SLOP): Define without magic numbers.
6802 (pkgtrustp): Convert to function.
6803 (set_action): Remove.
6804 (add_required, fill_missing_category,default_trust): Use list syntax for
6807 (choose_caption): Remove.
6808 (topbucket::paint): New method.
6809 (topbucket::empty): Ditto.
6810 (topbucket::click): Ditto.
6811 (topbucket::~topbucket): Ditto.
6812 (paint): Remove i,ii and p as they are obsolete.
6813 Remove header drawing code.
6814 Use new chooser method to paint the chooser.
6815 Use new chooser itemcount method.
6816 (scroll_common): Rename to view::scroll.
6817 Scroll the header window separately.
6818 (list_vscroll, list_hscroll, list_click): Update for new chooser
6820 (listview_proc): Look for header messages.
6821 (note_width): Accept stringless calls.
6822 (pick_line::set_line): Remove.
6823 (pick_line::paint): Remove.
6824 (pick_pkg_line::paint): Paint this one line, using the header column
6826 (pick_category_line::paint): Paint this category, and anything in the
6828 (pick_line::click): Remove.
6829 (pick_pkg_line::click): Handle a click.
6830 (pick_category_line::click): Handle a click.
6831 (_view): Rename all to view.
6832 (view::view): Initialise the control contents.
6833 (view::set_headers): Work with the header control.
6834 (view::init_headers): Use list syntax for package list.
6835 Rearrange the width logic a little.
6836 (view::insert_pkg): Update to use the hierarchy.
6837 (view::insert_category): Ditto.
6838 (view::insert_at, view::insert_under): Remove.
6839 (view::clear_view): Update to use the hierarchy.
6840 (view::click): Update to use the hierarchy.
6841 (set_view_mode): Use list syntax for package list.
6842 Update for new chooser methods.
6843 (DoInsertItem): New helper function. (Needs a home somewhere).
6844 (create_listview): Remove choose control code and use the constructor
6846 (dialog_cmd,scan2,do_choose): Use list syntax for package list.
6847 * choose.h: Include newly required headers list and package_meta.
6848 (_voew): Rename to view.
6849 (pick_line): Convert to an ABC.
6850 (pick_pkg_line): New class.
6851 (pick_catgory_line): New class.
6852 (topbucket): New class.
6853 (view::scroll): New method created from listview_scroll function.
6854 * desktop.cc (make_passwd_group): Use list syntax for package list.
6855 * download.cc (do_download): Use list syntax for package list.
6856 * fromcwd.cc (found_file): Use list syntax for package list.
6857 * iniparse.y (pacakges): Use list syntax for package list.
6858 * install.cc (uninstall_one): Use list syntax for package list.
6859 (do_install): Use list syntax for package list.
6860 * io_stream.h (io_stream): Prevent non-child direct creation of the
6862 Prevent inaccurate synthetic copy and assignment.
6863 * list.h: Include required header stdlib.
6864 Work on const correctness.
6865 * package_db.cc (packagedb::getpackagebyname): Remove.
6866 (packagedb::packagedb): Remove custom list code, and make db a local.
6867 (packagedb::getfirstpackage): Remove.
6868 (packagedb::getnextpackage): Remove.
6869 (packagedb::addpackage): Remove.
6870 (flush): Remove custom list code.
6871 (packagedb::registerpackage): Remove.
6872 (packagedb::packages): New static member.
6873 (packagedb::task): New static member.
6874 * package_db.h (PackageDBActions): New enum.
6875 (packagedb): Remove getfirstpackage, getnextpackage, getpackagebyname,
6876 addpackage, registerpackage, packages, packagecount, curr_package, db.
6878 * pacakge_meta.cc: Include package_db.h.
6879 (packagemeta::action_caption): New method.
6880 (packagemeta::set_action): New method.
6881 * package_meta.h (CategoryPackage): Initialise key.
6882 (packagemeta): Initialise key.
6883 Add set_action and action_caption methods.
6884 Prevent inaccurate synthetic copy and assignment.
6885 * resource.h (IDC_CHOOSE_LISTHEADER): New ID.
6886 * source.cc: Include package_db for db manipulation.
6887 (save_dialog): Set the db task.
6888 * win32.h: Tell the w32 include headers what IE version to
6891 2001-12-06 Robert Collins <rbtcollins@hotmail.com>
6893 * README: Wishlist updates.
6895 2001-12-04 Robert Collins <rbtcollins@hotmail.com>
6897 * package_db.cc (getnextpackage): Don't overrun the array.
6899 2001-12-04 Robert Collins <rbtcollins@hotmail.com>
6901 * Makefile.in (OBJS): Add setup_version.o.
6902 (version.c): Rename to setup_version.
6903 * choose.cc (set_action): Prevent NULL pointer dereference.
6904 (package_sort): Remove.
6905 * fromcwd.cc (canonicalize_version): Moved to version.cc.
6906 (check_ini): New function for use with find to see if there is a cached
6908 (do_fromcwd): Check for a cached setup.ini from any mirror site.
6909 * ini.cc (find_routine): New function, for finding cached setup.ini's.
6910 (do_local_ini): New function, drives parsing of local ini's.
6911 (do_remote_ini): New function, drives parsing and caching of remote
6913 (do_ini): Move guts to do_remote_ini and do_local_ini.
6914 * list.h (removebyindex): New method.
6915 * other.cc (save_dialog): Use new site_list and all_site_list to add the
6916 new site to the site picklist.
6917 (dialog_cmd): Only save the dialog when exiting the dialog.
6918 * res.rc (IDD_SITE): Make IDC_URL_LIST a multiple-selection control.
6919 * site.cc (site_list_type): Move to site.h
6920 (site_list): New global, sites chosen by the user.
6921 (all_site_list): New global, all potential sites.
6922 (site_list_type::init): New method, parses a mirror.lst URL string into
6923 a site_list_type object.
6924 (site_list_type::site_list_type): New method.
6925 (check_if_enable_next): Examine the control, not a local variable.
6926 (load_dialog): Select all the user chosen sites by default.
6927 (save_dialog): Adjust for multiple selection semantics.
6928 (save_site_url): Save all user chosen sites.
6929 (dialog_cmd): Don't save the dialog when the listbox recieves a message
6931 Remove obsolete other_url reference.
6932 (dialog_proc): Use all_site_list instead of site_list.
6933 (site_sort): Remove.
6934 (get_site_list): Remove malloc use - use list template instead.
6935 Move site_list_type initialisation to site_list_type::init().
6936 (get_initial_list_idx): Renamed to ...
6937 (get_saved_sites): this. Also read in multiple sites to the site_list.
6938 (do_site): Use all_site_list not site_list.
6939 Log all chosen sites.
6940 * site.h: New file, defines site related class, functions and variables.
6941 * state.h: Add comment about use of state.h
6942 (mirror_site): Remove.
6943 (other_url): Remove.
6944 (MIRROR_SITE): Remove.
6945 * version.cc: New file, for version-handling and related functions.
6947 2001-12-02 Robert Collins <rbtcollins@hotmail.com>
6949 * Makefile.in: Add filemanip.o to setup.
6950 * archive.cc (archive::extract_file): Use new io_stream method 'copy'.
6951 * archive_tar.h (archive_tar_file): Implement get_size virtual.
6952 (archive_tar): Ditto.
6953 * choose.cc (set_action): Use [] operator instead of getnth - its more
6956 (_view::init_headers): Ditto.
6957 (_view::insert_pkg): Ditto.
6958 (set_view_mode): Ditto.
6961 (base): Moved to filemanip.cc.
6962 (find_tar_ext): Ditto.
6963 (parse_filename): Ditto.
6964 (_Info::_Info): Remove.
6965 * compress_bz.h (compress_bz): Implement get_size virtual.
6966 * compress_gz.h (compress_gz): Implement get_size virtual.
6967 * cygpackage.cc (cygpackage::destroy): Use array delete for char *
6969 * download.cc (get_file_size): Move to filemanip.cc.
6970 (check_for_cached): Use [] operator instead of getnth - its more
6972 (download_one): Ditto.
6973 * filemanip.cc: New file.
6974 * geturl.cc (init_dialog): Make url a pointer to const as it is not
6976 (get_url_to_membuf): New function - contains get_url_to_string worker
6978 (get_url_to_string): Becomes a trivial wrapper to get_url_to_membuf.
6979 * geturl.h: Declare new prototype.
6980 * ini.cc (do_ini): Use get_url_to_membuf and pass ini_init an io_stream.
6981 Tidy up the error code a little.
6982 * ini.h: Remove __cplusplus protection for ini_init.
6984 * inilex.l: Remove old globals.
6985 (ini_init): Use an io_stream for getting the characters.
6986 (ini_getchar): Ditto.
6987 * iniparse.y: Declare yylex as a C++ function.
6988 (add_correct_version): Use [] operator instead of getnth - its more
6990 * io_stream.cc (io_stream::move_copy): Use the copy method.
6991 (io_stream::copy): New method to simply copy from one stream to another.
6992 * io_stream.h (io_stream): New static method copy, and virtual method
6994 * io_stream_cygfile.cc (io_stream_cygfile::get_size): Implement this.
6995 * io_stream_cygfile.h (io_stream_cygfile::get_size): Declare this.
6996 * io_stream_file.cc (io_stream_file::get_size): Implement this.
6997 * io_stream_file.h (io_stream_file::get_size): Declare this.
6998 * io_stream_memory.h: Include errno as it's neded to parse the header.
6999 (io_stream_memory::get_size): Implement this.
7000 (io_stream_memory::st_size): Delete this.
7001 * list.h: Change getnth into the [] operator.
7002 * netio.cc (NetIO::NetIO): Change prototype to reflect Purl not being
7004 (NetIO::set_url): Ditto.
7005 (NetIO::open): Ditto.
7006 * netio.h: As for netio.cc.
7007 * nio-file.cc (NetIO_File::NetIO_File): Change prototype to reflect
7008 Purl not being modified.
7009 * nio-file.h: Ditto.
7010 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
7011 * nio-ftp.h (NetIO_FTP::NetIO_FTP): Ditto.
7012 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Ditto.
7013 * nio-http.h (NetIO_HTTP::NetIO_HTTP): Ditto.
7014 * nio-i5.cc (NetIO_IE5::NetIO_IE5): Ditto.
7015 * nio-i5.h (NetIO_IE5::NetIO_IE5): Ditto.
7016 * package_meta.cc (packagemeta::~packagemeta): Bugfix: use array delete.
7017 * package_source.cc (packagesource::set_canonical): Ditto.
7018 (packagesource::set_cached): Ditto.
7019 * package_source.h (site::~site): Ditto.
7020 * site.cc: Change site_list_type to a class, and search and replace
7021 sort_key to key globally.
7023 2001-12-01 Robert Collins <rbtcollins@hotmail.com>
7025 * package_source.cc (packagesource::set_canonical): Filename was out by
7028 2001-11-30 Robert Collins <rbtcollins@hotmail.com>
7030 * Makefile.in (OBJS): Remove category_list - it's not needed.
7031 * README: More wishlist updates.
7032 * category.cc (Category::Category): Initialise new members.
7033 (Categorycmp): New function.
7034 * category.h (Category): New member key for template use.
7035 * category_list.cc: Remove.
7036 * category_list.h: Remove.
7037 (Categorycmp): New function prototype.
7038 * choose.cc: Remove category_list - not needed.
7039 (set_action): Only show the 'source' option when the source is actually
7041 (add_required): Fix recursion limiter to 5.
7042 (fill_missing_category): Use list access.
7043 (default_trust): Ditto.
7044 (pick_line::paint): Ditto.
7045 (_view::init_headers): Ditto.
7046 (_view::insert_pkg): Ditto.
7047 (_view::insert_category): Ditto.
7048 (_view::click): Ditto.
7049 (set_view_mode): Ditto.
7051 * cygpackage.h: Remove category_list - not needed.
7052 * geturl.cc (get_url_to_string): Fix null byte insertion.
7053 * inipatse.y: Remove category_list - not needed.
7054 (categories): Use list access.
7055 * package_db.cc: Ditto.
7056 * package_db.h: Remove category_list - not needed.
7057 (packagedb): Use the list template for categories.
7058 * package_meta.cc (add_category): Ditto.
7059 * package_meta.h (CategoryPackage): Link to the category as well.
7060 (packagemeta): Use a list of CategoryPackages instead of Categories
7061 for more memory efficient cross-referencing.
7063 2001-11-30 Robert Collins <rbtcollins@hotmail.com>
7065 * package_db.cc (packagedb::flush): Write a canonical version for all
7066 packages irrespective of the media they were installed from.
7068 2001-11-29 Robert Collins <rbtcollins@hotmail.com>
7070 * Makefile.in (OBJS): Add package_source and rfc1738.
7071 * README: Wishlist update.
7072 * category_list.cc (register_category): Use references.
7073 * category_list.h (CategoryList): Ditto.
7074 * choose.cc (isinstalled): Remove.
7075 (pkgtrustp): New macro.
7076 (set_action): Use packagemeta.
7077 (add_required): Ditto.
7078 (choose_caption): Example package to choose caption, rather than state
7080 (check_existence): Remove.
7081 (set_existence): Remove old code.
7082 (fill_missing_category): Use packagemeta.
7083 (keep_or_skip): Remove.
7084 (default_trust): Use packagemeta and set trust values directly.
7085 (pick_line::set_line): Use packagemeta.
7086 (_view::insert_pkg): Ditto.
7087 (_view::insert_category): Ditto.
7088 (_view::click): Ditto.
7089 (set_view_mode): Ditto. Also remove "exclude" code.
7090 (create_listview): Use packagemeta.
7091 (dialog_cmd): Ditto.
7092 (getpkgbyname): Remove
7093 (scan2): Use packagemeta. Temporarily comment out the holefinding code.
7094 (read_installed_db): Remove.
7095 (package_sort): Use packagemeta.
7096 (do_choose): Use packagemeta. Don't sort the packages - the db does
7098 * choose.h: Use packagemeta.
7099 * cygpackage.cc (cygpackage::cygpackage): Initialise all variables.
7100 (cygpackage::cygpackage): Ditto.
7101 (cygpackage::set_canonical_version): Copy the passed string.
7102 (cygpackage::~cygpackage): Move cleanup code to destroy().
7103 (cygpackage::destroy): New function.
7104 (cygpackage::getfirstfile): Use a separate buffer.
7105 (cygpackage::getnextfile): Ditto.
7106 (cygpackage::Canonical_version): New function.
7107 (cygpackage::set_sdesc): Ditto.
7108 (cygpackage::set_ldesc): Ditto.
7109 * cygpackage.h (cygpackage::Canonical_version): New method.
7110 (cygpackage::set_sdesc): New method.
7111 (cygpackage::set_ldesc): New method.
7112 (cygpackage::SDesc): New method.
7113 (cygpackage::LDesc): New method.
7114 (cygpackage::set_canonical_version): New method.
7115 * desktop.cc: Include packagedb headers.
7116 (make_password_group): Use packagemeta.
7117 * download.cc: Include packagedb headers.
7118 (check_for_cached): New method to find any cached file and fill out the
7120 (download_one): Take a packagesource, support multiple mirrors.
7121 (do_download): Use packagemeta.
7122 * from cwd.cc: Include packagedb headers.
7123 (found_file): Use packagemeta.
7124 * ini.cc (do_ini): Beginning of multiple-mirror support.
7125 * ini.h (CategoryPackage): Remove.
7126 (Dependency): Remove.
7128 (new_package,getpkgbyname,getpackagecategorybyname,add_category):
7130 * inilex.l: Support multiple mirrors.
7131 * iniparse.y: Include packagedb headers.
7132 (parser): Use packagemeta.
7133 (new_package): Remove.
7134 (add_correct_version): New function.
7135 (new_requirement): Remove.
7136 (add_category): Remove.
7137 * install.cc (uninstall_one): Use packagemeta.
7138 (install_one_source): New function.
7139 (install_one): Use packagemeta.
7140 (do_install): Use packagemeta.
7141 * io_stream.cc (io_stream::move): Bugfix on move/copy case.
7142 * io_stream_cygfile.cc (io-stream_cygfile::set_mtime): Do not reopen the
7143 file after setting the mtime, it makes no sense, and results in 0 length
7145 * io_stream_file.cc (io-stream_file::set_mtime): Ditto.
7146 * list.h: New file, template class for a form of list.
7147 * package_db.cc (packagedb::registerpackage): New function.
7148 * package_db.h (packagedb::npackages ()): New method.
7149 * package_meta.cc (packagemeta::add_version): Use list template.
7150 (packagemeta::set_installed): Ditto.
7151 (packagemeta::add_category): New method.
7152 * package_meta.h: Include necessary headers to parse the class.
7153 (CategoryPackage): New class.
7154 (packagemeta): Initialise all members.
7155 (packagemeta::SDesc): New method.
7156 (packagemeta::Categories): New method.
7157 (packagemeta::add_category): Ditto.
7158 (packagemeta::versions): Change to be a list instance.
7159 * package_source.cc (packagesource::set_canonical): New method.
7160 (packagesource::set_cached): New method.
7161 * package_source.h: Include necessary headers to parse the class.
7163 (packagesource::packagesource): Initialize all members.
7164 (packagesource): Make this class non-abstract.
7165 * package_version.cc (packageversion::packageversion): New method.
7166 * package_version.h (Dependency): New class.
7167 (packageversion::Canonical_vesion): New method.
7168 (packageversion::SDesc): New method.
7169 (packageversion::LDesc): New method.
7170 (packageversion::new_requirement): Ditto.
7171 (packageversion::srcpicked, binpicked): What to install.
7172 (packageversion::src, bin): Installation source data.
7173 * rfc1738.cc: New file. Escapes special characters in URL's.
7176 2001-11-26 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
7178 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Stop header parsing when
7179 SimpleSocket::gets() returns a zero-length string, so that we
7180 don't end up eating the entire stream thinking it's all header info.
7182 2001-11-23 Robert Collins <rbtcollins@hotmail.com>
7184 * install.cc (badrename): Remove.
7185 (do_install): Use packagedb flush method to write
7186 /etc/setup/installed.db.
7187 * io_stream.cc (io_stream::move_copy): New method.
7188 (io_stream::move): New method.
7189 * io_stream.h (io_stream): New methods move and move_copy.
7190 * io_stream_cygfile.cc (io_stream_cygfile::move): New method.
7191 * io_stream_cygfile.h (io_stream_cygfile): New method move.
7192 * io_stream_file.cc (io_stream_file::move): New method.
7193 * io_stream_file.h (io_stream_file): New method move.
7194 * package_db.cc (packagedb::flush): New method.
7195 * package_db.h (packagedb): New method flush.
7197 2001-11-23 Robert Collins <rbtcollins@hotmail.com>
7199 * Makefile.in (OBJS): Add package_version.
7200 * ategory.cc (Category::Category): Update constructors.
7201 * category_list.cc (CategoryList::register_category): Insert correctly.
7202 * choose.cc: Include package_version.h, not package.h.
7203 * cygpackage.cc: Ditto.
7204 (cygpackage::uninstall): New method.
7205 * cygpackage.h (cygpackage): Rename genericpackage to packageversion.
7206 New method uninstall.
7207 * hash.cc (add, has, enumerate): Change prototype to be accurate.
7208 * hash.h (hash): Change prototypes to be accurate.
7209 * ini.h (_Info): New parameterless constructor.
7210 (CategoryPackage): New constructor.
7212 * install.cc: Don't include unneeded headers.
7213 Include package database headers.
7214 (hash::add_subdirs): Remove.
7215 (uninstall_one): Use packagemeta->uninstall to perform the
7216 uninstallation. Don't uninstall source packages.
7217 (do_install): Just can uninstall_one once as we ignore source packages
7218 now. Don't copy the installed.old database accross, instead iterate
7219 through the packagedb packages list and write the installed packages
7221 * package_db.cc: Include package_version.h, not package.h.
7222 (packagedb::packagedb): Never let db be undefined.
7223 Record the installation filename, so we can reconstruct installed.db.
7224 (packagedb::addpackage): Insert packages in alpha sorted order.
7225 (packagedb::categories): Initialise correctly.
7226 * package_meta.cc: Include win32 and mount headers as a workaround to
7227 current io_stream limitations. Include a TODO about that.
7228 (standard_dirs): New, from install.cc.
7229 (hash::add_subdirs): New, from install.cc.
7230 (packagemeta::set_installed): Rename genericpackage to packageversion.
7231 (packagemeta::uninstall): New method.
7232 * package_meta.h: Rename genericpackage to packageversion.
7233 (packagemeta): Update constructor.
7234 (add_version, set_installed): Rename genericpackage to packageversion.
7235 (uninstall): New method.
7236 (installed_from): New member.
7237 * package_source.cc: New file.
7238 * package_source.h: New file.
7239 * package_version.cc: New file.
7240 * package_version.h: New file.
7241 * package.cc: Removed.
7242 * package.h: Removed.
7244 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
7246 * Makefile.in (OBJS): Add category.o and category_list.o.
7247 * category.h: New file.
7248 * category.cc: New file.
7249 * category_list.h: New file.
7250 * category_list.cc: New file.
7251 * choose.cc: Include category headers.
7252 (fill_missing_category): Use package_db to access global categories.
7253 (_view::insert_pkg): Ditto.
7254 (_view::insert_category): Ditto.
7255 (set_view_mode): Ditto.
7256 (getcategorybyname): Remove.
7257 * cygpackage.h: Include category_list.h to parse this correctly.
7258 (cygpackage): New virtual &Categories.
7259 * ini.h (_CategoryPackage): More C to C++ conversion.
7261 (getcategorybyname): Remove.
7262 (register_category): Remove.
7263 * iniparse.y: Include package db and category headers.
7264 (categories): Use package_db to access global categories.
7266 (ncategories): Remove.
7267 (register_category): Remove.
7268 * package.h: New virtual &Categories.
7269 * package_db.cc (packagedb::packagedb): Don't read the installed db
7271 (packagedb::categories): Declare.
7272 * package_db.h (packagedb): New member categories for global categories
7275 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
7277 * choose.h: Don't include ini.h
7278 * ini.h: Allow pure c++ in the header file.
7280 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
7282 * install.cc (do_install): Write a version 2 installed.db file.
7283 * package_db.cc (packagedb::packagedb): Read version 1 and 2
7286 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
7288 * Makefile.in (OBJS): Add package abstraction objects.
7289 * choose.cc: Include package abstraction headers.
7290 (read_installed_db): Use packagedb class and ignore installed sources.
7291 * cygpackage.cc: New file.
7292 * cygpackage.h: New file.
7293 * filemanip.h (get_file_size): Use unixy types.
7294 * package.h: New file.
7295 * package.cc: New file.
7296 * package_db.cc: New file.
7297 * package_db.h: New file.
7298 * package_meta.cc: New file.
7299 * package_meta.h: New file.
7301 2001-11-21 Robert Collins <rbtcollins@hotmail.com>
7303 * REAME: Updates to wishlist.
7305 2001-11-16 Robert Collins <rbtcollins@hotmail.com>
7307 * README: Updated and added my list of wishlist and todo items.
7309 2001-11-14 Robert Collins <rbtcollins@hotmail.com>
7311 * Makefile.in (OBJS): Include io_stream_memory in setup.exe.
7312 * archive_tar.cc (archive_tar::write): New prototype.
7313 (archive_tar::seek): New method.
7314 * archive.h (archive_tar_file): Update write() and add seek().
7315 (archive_tar): Ditto.
7316 * archive_tar_file.cc (archive_tar_file::write): New prototype.
7317 (archive_tar_file::seek): New method.
7318 * compress_bz.cc (compress_bz::write): New prototype.
7319 (compress_bz::seek): New function.
7320 * compress_bz.h (compress_bz): Update write() and add seek().
7321 * compress_gz.cc (compress_gz::write): New prototype.
7322 (compress_gz::seek): New function.
7323 * compress_gz.h (compress_gz): Update write() and add seek().
7324 * geturl.cc: Include io_stream headers.
7326 (get_url_to_string): Use a io_stream_memory buffer instead of GUBuf.
7327 * io_stream.h (io_stream_seek_t): New enum.
7328 (io_stream): Update write() and add seek().
7329 * io_stream_cygfile.cc (io_stream_cygfile::write): New prototype.
7330 (io_stream_cygfile::seek): New function.
7331 * io_stream_cygfile.h (io_stream_cygfile): Update write() and add
7333 * io_stream_file.cc (io_stream_file::write): New prototype.
7334 (io_stream_file::seek): New function.
7335 * io_stream_file.h (io_stream_file): Update write() and add seek().
7337 2001-11-13 Brian Keener <bkeener@thesoftwaresource.com>
7339 * localdir.cc: Add headers unistd.h and port.h.
7340 (save_local_dir): Expand search logic to include local directory for
7341 location of file last-cache.
7342 (dialog_cmd): Skip IDD_ROOT when downloading and use Back button.
7343 (do_local_dir): Expand search logic to include local directory for file
7345 * res.rc (IDD_CHOOSE_DIALOG): Add hotkey to View button.
7346 * Source.cc (dialog_cmd): Skip IDD_ROOT if select Download from
7348 (do_source): Default to Install from Internet on first entry or
7349 previous selection if backing up from IDD_ROOT or IDD_LOCAL_DIR.
7351 2001-11-13 Robert Collins <rbtcollins@hotmail.com>
7353 * choose.cc (find_tar_ext): Only match at the end of the string.
7354 (getpkgbyname): Prevent NULL pointer dereference.
7356 2001-11-13 Robert Collins <rbtcollins@hotmail.com>
7358 * Makefile.in (CFLAGS): Add warnings and -Werr.
7359 (WARNONLY_FLAGS): For sources that produce (harmless) errors no matter
7361 (OBJS): Add io_stream class' objects.
7362 (autoload.o): Use WARNONLY_FLAGS.
7364 (iniparse.o): Ditto.
7365 * archive.cc: New file.
7366 * archive.h: New file.
7367 * archive_tar.cc: New file.
7368 * archive_tar.h: New file.
7369 * archive_tar_file.cc: New file.
7370 * autoload.c: Fix compiler warnings (unused, deprecated conversion).
7371 * choose.cc: Use io_stream.h, not mount.h.
7373 (find_tar_ext): Rewritten to use strstr, and to accept .tar as an
7375 (read_installed_db): Use io_streams.
7376 * choose.h: Run indent.
7377 * compress.cc: New file.
7378 * compress.h: New file.
7379 * compress_bz.cc: New file.
7380 * compress_bz.h: New file.
7381 * compress_gz.cc: New file.
7382 * compress_gz.h: New file.
7383 * concat.cc: Run indent.
7384 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7385 * concat.h: Run indent.
7386 * desktop.cc: Run indent.
7387 Include mklink2.h rather than redefining by hand.
7388 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7389 (etc_profile): Fix compiler warning (deprecated conversion).
7390 (make_link): Fix compiler warning (deprecated conversion).
7391 Tidy up use of args variable - consolidate into argbuf.
7392 (start_menu): Fix compiler warning (deprecated conversion).
7393 (desktop_icon): Fix compiler warning (deprecated conversion).
7394 (make_etc_profile): Fix compiler warning (deprecated conversion).
7395 (uexists): Fix compiler warning (deprecated conversion).
7396 (check_desktop): Fix compiler warning (deprecated conversion).
7397 (check_startmenu): Fix compiler warning (deprecated conversion).
7398 * dialog.cc: Run indent.
7399 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7400 (fatal): Fix compiler warning (deprecated conversion).
7401 * dialog.h: Run indent.
7402 * diskfull.cc: Run indent.
7403 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7404 * download.cc: Run indent.
7405 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7406 (download_one): Fix compiler warning (signed vs unsigned comparison).
7407 * filemanip.h: Run indent.
7408 * find.cc: Run indent.
7409 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7410 (find): Fix compiler warning (deprecated conversion).
7411 * find.h: Run indent.
7412 * fromcwd.cc: Run indent.
7413 * geturl.cc: Run indent.
7414 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7415 (dialog_cmd): Return a value.
7416 (dialog_proc): Remove unused variables.
7418 (get_url_to_file): Fix compiler warning (deprecated conversion).
7419 * geturl.h: Run indent.
7420 * hash.cc: Run indent.
7421 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7422 * hash.h: Run indent.
7423 * ini.cc: Run indent.
7425 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7426 (do_ini): Use io_streams for local io.
7427 * ini.h: Run indent.
7428 * inilex.l (ignore_line): Fix compiler warning (is not a prototype).
7429 Fix compiler warning (brackets for truth assignment).
7430 * install.cc: Run indent.
7431 Fix compiler warning (/* in comment).
7433 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7434 (dialog_cmd): Return a value.
7435 (dialog_proc): Return a value.
7436 (start_tics): Deleted - was unused.
7437 (badrename): Fix compiler warnings (unused, deprecated conversion).
7438 (standard_dirs): Fix compiler warning (deprecated conversion).
7440 (uninstall_one): Convert to io_streams.
7441 (install_one): Convert to io_streams.
7442 (do_install): Convert to io_streans.
7443 Fix compiler warning (deprecated conversion).
7444 * io_stream.cc: New file.
7445 * io_stream.h: New file.
7446 * io_stream_cygfile.cc: New file.
7447 * io_stream_cygfile.h: New file.
7448 * io_stream_file.cc: New file.
7449 * io_stream_file.h: New file.
7450 * localdir.cc: Run indent.
7452 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7453 (get_root_dir_now): Remove.
7454 (save_local_dir): Convert to io_streams.
7455 (dialog_cmd): Return a value.
7456 (do_local_dir): Convert to io_streams.
7457 (log.cc): Run indent.
7458 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7459 (log): Fix compiler warning (deprecated conversion).
7460 (log_save): Fix compiler warning (deprecated conversion).
7461 * log.h: Run indent.
7462 (log): Fix compiler warning (deprecated conversion).
7463 (log_save): Fix compiler warning (deprecated conversion).
7464 * main.cc: Run indent.
7465 Don't include "netio.h".
7466 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7467 (netio_test): Remove.
7468 (sid_auth): Fix compiler warning (partially bracketed initialiser).
7469 (WinMain): Return a value.
7470 * mkdir.cc: Run indent.
7471 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7472 * mklink2.c: Run indent.
7473 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7474 (mkcygsymlink): New function.
7475 * mklink2.h: New file.
7476 * mount.cc: Run indent.
7477 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7478 (create_mount): Remove unused variables.
7479 (cygpath): Fix compiler warning (signed vs unsigned comparison).
7480 * mount.h: Run indent.
7481 * msg.cc: Run indent.
7482 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7483 (msg): Fix compiler warning (deprecated conversion).
7484 (mbox): Fix compiler warning (deprecated conversion).
7485 * msg.h: Run indent.
7486 (msg): Fix compiler warning (deprecated conversion).
7487 * net.cc: Run indent.
7488 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7489 (dialog_cmd): Return a value.
7490 * netio.cc: Run indent.
7491 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7492 (auth_cmd): Return a value.
7493 * netio.h: Run indent.
7494 * nio-file.cc: Run indent.
7495 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7496 (NetIO_File::NetIO_File): Fix compiler warning (deprecated conversion).
7497 * nio-file.h: Run indent.
7498 * nio-ftp.cc: Run indent.
7499 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7500 * nio-ftp.h: Run indent.
7501 * nio-http.cc: Run indent.
7502 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7503 * nio-http.h: Run indent.
7504 * nio-ie5.cc: Run indent.
7505 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7506 * nio-ie5.h: Run indent.
7507 * other.cc: Run indent.
7508 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7509 (dialog_cmd): Return a value.
7510 * port.h: Run indent.
7511 * postinstall.cc: Run indent.
7512 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7513 (cmd): Fix compiler warning (deprecated conversion).
7514 (eun): Fix compiler warning (deprecated conversion).
7515 * root.cc: Run indent.
7516 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7517 * simpsock.cc: Run indent.
7518 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7519 * simpsock.h: Run indent.
7520 * site.cc: Run indent.
7522 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7523 (get_root_dir_now): Remove.
7524 (save_site_url): Convert to io_streams.
7525 (dialog_cmd): Return 0.
7526 (get_initial_list_idx): Convert to io_streans.
7527 * source.cc: Run indent.
7528 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7529 (check_if_enable_next): Remove.
7530 (load_dialog): Remove unused variables.
7531 (save_dialog): Ditto.
7532 (dialog_cmd): Return a value.
7533 * splash.cc: Return a value.
7534 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7535 (dialog_cmd): Return a value.
7536 * state.cc: Run indent.
7537 (cvsid): Fix compiler warnings (unused, deprecated conversion).
7538 * state.h: Run indent.
7542 2001-11-12 Christopher Faylor <cgf@redhat.com>
7544 * desktop.cc (start_menu): Change start menu name to "Cygwin".
7545 (check_startmenu): Ditto.
7547 2001-11-11 Christopher Faylor <cgf@redhat.com>
7549 * choose.cc (parse_filename): Finish reorganization by correctly
7550 decrementing p in memmove.
7552 2001-11-11 Christopher Faylor <cgf@redhat.com>
7554 * choose.cc (parse_filename): Reorganize code to work around gcc
7555 optimization problem.
7557 2001-11-09 Gareth Pearce <tilps@hotmail.com>
7559 * choose.cc (set_action): Allow skip as an option for installed
7560 packages that have version number not listed in setup.ini.
7562 2001-11-10 Robert Collins <rbtcollins@hotmail.com>
7564 * choose.cc (set_cation): Backout last change.
7565 (choose_caption): Ditto.
7567 2001-11-10 Robert Collins <rbtcollins@hotmail.com>
7569 * ini.h (actions): Remove - transferred to choose.h.
7571 * choose.h: Protect class's from "C" compilers.
7572 (actions): New enum, from ini.h. This may not be the 'right' place
7573 but that place doesn't exist yet.
7574 (_views): New enum, from ini.h.
7575 * choose.cc (set_action): Handle installed packages with a version not
7577 (choose_caption): Ditto.
7578 * iniparse.y: Rearrange header order to handle new ini.h.
7580 2001-11-10 Robert Collins <rbtcollins@hotmail.com>
7582 * ini.h (_Info): Fix compiler warnings (signed vs unsigned comparison).
7583 (registry_category): Fix compiler warning (deprecated conversion).
7584 * iniparse.y (registry_category): Ditto.
7585 * choose.cc (cvsid): Fix compiler warnings (unused, deprecated
7587 (add_requried): Remove unused variable.
7588 (choose_caption): Handle all enumeration values via a default.
7589 (paint): Fix compiler warnings (unused, deprecated conversion).
7590 (scroll_common): Fix compiler warnings (unused, signed vs unsigned
7592 (list_clicK): Fix compiler warnings (signed vs unsigned comparison).
7593 (note_width): Fix compiler warnings (deprecated conversion).
7594 (keep_or_skip): Fix compiler warnings (unused).
7595 (_view::mode_caption): Fix compiler warnings (deprecated conversion).
7596 (set_view_mode): Fix compiler warnings (unused).
7597 (create_listview): Fix compiler warnings (unused, incorrect format,
7598 reaches end of function).
7599 (dialog_proc): Fix compiler warnings (unused).
7600 (read_installed_db): Fix compiler warnings (unused, deprecated
7602 * choose.h (_header): Fix compiler warnings (deprecated conversion).
7605 2001-11-08 Pavel Tsekov <ptsekov@syntrex.com>
7607 * simpsock.h (SimpleSocket::invalidate): Declare new method.
7608 * simpsock.cc (SimpleSocket::invalidate): Implement new method.
7609 (SimpleSocket::SimpleSocket): Initialize buf to zero. Do not allocate
7610 memory for buf in the constructor.
7611 (SimpleSocket::~SimpleSocket): Use SimpleSocket::invalidate().
7612 (SimpleSocket::printf): Use SimpleSocket::write() instead of send().
7613 (SimpleSocket::write): Check object consistency - return -1 on error.
7614 invalidate() the object on socket write error.
7615 (SimpleSocket::fill): Check object consistency - return -1 on error.
7616 invalidate() the object if socket read error is encountered and there
7617 is no more data available in the internal read buffer.
7618 Allocate memory for the internal read buffer.
7619 (SimpleSocket::gets): Return zero (NULL pointer) if error is encountered
7620 during fill() and no more data is available in the internal read buffer.
7621 (SimpleSocket::read): Check object consistency - return -1 on error.
7622 invalidate() the object if socket read error is encountered.
7623 * nio-ftp.cc (NetIO_FTP:NetIO_FTP): Allow 125 as valid response code to
7624 the RETR command (fix for MS IIS ftp server 5 - possibly others too).
7625 (NetIO_FTP::ok): Check if the SimpleSocket object is ok().
7626 (NetIO_FTP::read): Use NetIO_FTP::ok().
7627 * nio-http.cc: Check for valid return value of SimpleSocket::gets().
7628 (NetIO_HTTP::ok): Check if the SimpleSocket object is ok().
7630 2001-11-09 Robert Collins <rbtcollins@hotmail.com>
7632 * simpsock.cc (cvsid): Avoid compiler warnings (not used, deprecated
7634 (SimpleSocket::SimpleSocket): Avoid compiler warnings (deprecated
7636 (SimpleSocket::printf): Ditto.
7637 (SimpleSocket::write): Ditto.
7638 * simpsock.h (SimpleSocket): Avoid compiler warnings for constructor,
7640 * nio-ftp.cc (cvsid): Avoid compiler warnings (not used, deprecated
7642 (NetIO_FTP::NetIO_FTP): Remove unused variable done.
7643 * nio-http.cc (cvsid): Avoid compiler warnings (not used, deprecated
7646 2001-11-07 Charles Wilson <cwilson@ece.gatech.edu>
7648 * geturl.cc (get_url_to_string): clean up memory leak
7649 (get_url_to_file): ditto
7651 2001-11-06 Robert Collins <rbtcollins@hotmail.com>
7653 * localdir.cc (dialog_cmd): Go back to IDD_ROOT in every case.
7654 * source.cc (dialog_cmd): Go forward to IDD_ROOT in every case.
7656 2001-11-06 Pavel Tsekov <ptsekov@syntrex.com>
7658 * fromcwd.cc (found_file): Free() memory containing the version and
7659 filepath information for a given package, before replacing the pointers
7660 which reference this memory.
7662 2001-11-06 Robert Collins <rbtcollins@hotmail.com>
7664 * fromcwd: Fix compiler warnings for cvsid.
7665 (canonicalize_version): Fix compilter warnings.
7666 (do_fromcwd): Ditto.
7667 * version.h: Fix compiler warnings for canonicalize_version.
7669 2001-11-03 Robert Collins <rbtcollins@hotmail.com>
7671 * res.rc (IDD_CHOOSE): Move the view caption to the right hand side.
7673 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7675 * res.rc (IDD_CHOOSE): Tweak for use on a 640x480 screen.
7677 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7679 * choose.cc (set_action): Correctly allow skip for any uninstalled
7682 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7684 * choose.cc (default_trust): Change the "Required" forced install
7687 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7689 * choose.cc: Ran indent.
7690 (set_action): When the requested trust level is missing and the level
7691 was not user requested, set the action to ACTION_SAME_CURR.
7693 2001-11-01 Christopher Faylor <cgf@redhat.com>
7695 * Makefile.in (mingw_getopt.o): Fix typo in non-verbose compilation.
7697 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7699 * choose.cc (_view::init_headers): Resync with the paint logic.
7701 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7703 * choose.cc (add_required): Allow SKIP and SRC_ONLY for currently
7706 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7708 * choose.cc (default_trust): Autoset currently installed packages per
7709 the user's selection of prev/curr/exp.
7711 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7713 * splash.cc (dialog_proc): Return TRUE as specified in the WIN32 API.
7715 2001-11-02 Pavel Tsekov <ptsekov@syntrex.com>
7717 * geturl.cc (is_showing): Remove.
7718 (is_local_install): New static variable. Controls whether the
7719 progress dialog and the supporting thread will be created.
7720 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the WIN32
7722 (init_dialog): Remove usage of SetForegroundWindow and is_showing.
7723 This prevents the progress dialog to gain control over the
7724 application and fixes the "setup.exe going to background" problem.
7725 (progress): Use is_local_install.
7726 (get_url_to_string): Set is_local_install.
7727 (dismiss_url_status_dialog): Use is_local_install.
7728 * install.cc (dialog_proc): Return TRUE as specified in WIN32 API.
7729 (init_dialog): Remove usage of SetForegroundWindow.
7730 This prevents the progress dialog to gain control over the
7731 application and fixes the "setup.exe going to background" problem.
7733 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7735 * choose.cc (list_click): Change r to row for clarity.
7736 When we shrink the list below 1 page, scroll to the top of the list.
7737 (_view::click): Return the actual change for contractions.
7738 (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the Win32
7741 2001-11-02 Robert Collins <rbtcollins@hotmail.com>
7743 * choose.cc (dialog_cmd): Swap cygwin root selection and local dir
7745 * localdir.cc: Ran indent.
7746 (get_root_dir_now): New function.
7747 (save_local_dir): New function.
7748 (dialog_cmd): Use it and swap cygwin root selection and local dir
7750 (do_local_dir): If there is a saved local dir, read it in.
7751 * net.cc (dialog_cmd): Swap cygwin root selection and local dir
7753 * root.cc (dialog_cmd): Ditto.
7754 * source.cc (dialog_cmd): Ditto.
7756 2001-11-01 Robert Collins <rbtcollins@hotmail.com>
7758 * choose.cc(list_vscroll): Return 0 as required by win32.
7759 (list_hscroll): Ditto.
7760 (list_click): Ditto.
7762 2001-11-01 Robert Collins <rbtcollins@hotmail.com>
7766 * main.cc(WinMain): Use __argv to retrieve command line parameters.
7767 * Makefile,in: Remove argv.o.
7769 2001-11-01 Matt Hargett <matt@use.net>
7771 * geturl.cc (progress): Change int to unsigned int to eliminate
7773 * (get_url_to_string): Check for NULL pointer.
7774 * mount.cc (find2): Use free instead of delete for malloc'd
7776 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.
7778 2001-10-31 Robert Collins <rbtcollins@hotmail.com>
7780 * choose.cc(_view::insert_under): Handle linen > nlines and lines[linen]
7781 with neither a package nor a category. The lines[linen] bug was reported
7782 by Matt (matt@usa.net).
7783 (read_installed_db): Bugfix for testing whether a package has a source
7784 tarball. Reported by Matt (matt@usa.net).
7785 * geturl.cc(dialog): Rename gw_dialog to local_gw_dialog to avoid
7786 programmer confusion and lint errors. Reported by Matt (matt@usa.net).
7788 2001-10-31 Robert Collins <rbtcollins@hotmail.com>
7790 * argv.cc: New file, converts arguments for -mwindows
7791 programs. (Simplified derivation from dcrt0.cc.)
7793 * Makefile,in: Add argv.o and mingw_getopt.o to setup.exe object list.
7794 Add mingw_getopt.o build rule.
7795 * main.cc(WinMain): Initialise argv and argc for use by getopt.
7797 2001-10-27 Christopher Faylor <cgf@redhat.com>
7799 * res.rc: Rearrange info on top line slightly.
7801 2001-10-27 Christopher Faylor <cgf@redhat.com>
7803 * desktop.cc (make_passwd_group): Move file creation earlier in the
7804 process to ensure that passwd-grp.bat reflects desired operation.
7806 2001-27-10 Trevor Forbes <t4bs@hotmail.com>
7808 * postinstall.cc (each): Remove "*.done" file else rename will fail.
7810 2001-10-16 Christopher Faylor <cgf@redhat.com>
7812 * res.rc: Oops. Take 640x480 screen size into account.
7814 2001-10-16 Christopher Faylor <cgf@redhat.com>
7816 * res.rc: Enlarge chooser screen.
7818 2001-10-12 Christopher Faylor <cgf@redhat.com>
7820 * Makefile.in: Accomodate changes to w32api_include macro.
7822 2001-10-12 Christopher Faylor <cgf@redhat.com>
7824 * Makefile.in: Use correct flags for windres.
7826 2001-10-12 Christopher Faylor <cgf@redhat.com>
7828 * Makefile.in (CFLAGS): Remove -nostdinc from CFLAGS.
7830 2001-10-12 Christopher Faylor <cgf@redhat.com>
7832 * choose.cc (pick_line::paint): Reorganize after botched patch.
7834 2001-10-12 Christopher Faylor <cgf@redhat.com>
7836 * choose.cc (pick_line::paint): Add missing declaration.
7838 2001-10-10 Ralf Habacker <Ralf.Habacker@freenet.de>
7840 * choose.cc (pick_line::paint): Add package name to sdesc for display.
7842 Wed Sep 26 21:39:00 Robert Collins rbtcollins@hotmail.com
7844 * choose.cc (_view::insert_pkg): Correctly exit loop.
7845 * iniparse.y (register_category): Always insert new categories.
7847 Fri Sep 21 13:56:32 2001 Christopher Faylor <cgf@cygnus.com>
7849 * inilex.l (yylex): For comments, eat all characters up to, but not
7852 Sun Aug 26 12:50:01 2001 John Marshall <jmarshall@acm.org>
7854 * fromcwd.cc (found_file): Use correct package name when adding an
7855 unknown package rather than random stack garbage.
7857 Sun Aug 12 14:25:21 2001 Christopher Faylor <cgf@cygnus.com>
7859 * desktop.cc (make_passwd_group): .bat files need \r\n endings.
7861 Wed Aug 8 13:53:47 2001 Christopher Faylor <cgf@cygnus.com>
7863 * desktop.cc (etc_profile): Leave environment variables untouched.
7865 2001-08-07 Corinna Vinschen <corinna@vinschen.de>
7867 * autoload.c: Add dynamic load statements for NT/W2K
7868 advapi32 functions not available in 9x/ME.
7869 * main.cc (set_default_dacl): New function.
7870 (WinMain): Call `set_default_dacl' if running on NT/W2K.
7872 Sat Aug 4 21:35:53 2001 Christopher Faylor <cgf@cygnus.com>
7874 * ini.h (_CategoryPackage): Change pkg field to pkgname for
7876 * choose.cc: Use pkgname field when referencing _CategoryPackage
7878 (fill_missing_category): Don't add excluded packages.
7879 (default_trust): Ditto.
7880 (_view::insert_pkg): Ditto.
7881 * iniparse.y (register_category): Use consistent variable name.
7883 2001-07-09 Egor Duda <deo@logos-m.ru>
7885 * choose.cc: Use system foreground color for text output.
7887 Sat Jul 7 00:40:28 2001 Christopher Faylor <cgf@cygnus.com>
7889 * choose.cc (set_action): Use default trust for determining reinstall
7891 (default_trust): Set default trust.
7892 (pick_line::paint): Allow source selection when reinstalling or
7895 Fri Jul 6 18:08:49 2001 Christopher Faylor <cgf@cygnus.com>
7897 * choose.cc (isinstalled): Modify to properly accomodate special case
7899 (set_action): Check downloaded components, not installed components if
7901 (set_existence): Always include full list of files when "download
7904 Fri Jul 6 00:37:05 2001 Christopher Faylor <cgf@cygnus.com>
7906 * choose.cc (pick_line::paint): Properly display "na" field when no
7909 Thu Jul 5 00:34:23 2001 Christopher Faylor <cgf@cygnus.com>
7911 * choose.cc (scan2): Ensure that older versions do not show up in
7914 Mon Jul 2 15:47:59 2001 Christopher Faylor <cgf@cygnus.com>
7916 * choose.cc (set_action): Allow "Skip" action if trust != installed.
7917 * res.rc: Fix copyright.
7919 Sat Jun 30 14:05:21 2001 Michael A Chase <mchase@ix.netcom.com>
7921 * res.rc (IDD_LOCAL_DIR): Change caption to match the other dialog
7923 (IDD_CHOOSE): Adjust horizontal size so package names are visible.
7925 * choose.cc: Restore some more changes from 2001-06-25, throughout.
7926 (paint): Wrap some excessively long lines.
7927 (pick_line::paint): Ditto. Move the arrow in the "Current" column
7928 right to where it belongs. Move the source checkbox slightly to the
7930 (do_choose): List categories and required packages in setup.log.full.
7932 Sat Jun 30 23:04:59 2001 Christopher Faylor <cgf@cygnus.com>
7934 * choose.cc (scan2): Restore source scanning eliminated by previous
7937 Sat Jun 30 15:18:33 2001 Christopher Faylor <cgf@cygnus.com>
7939 * ini.h (struct _Info): Add "derived" element.
7940 * choose.cc (scan2): Try to place unknown tar files into proper slot
7941 when package exists in setup.ini but tar file does not.
7943 Sat Jun 30 13:39:00 2001 Robert Collins <rbtcollins@hotmail.com>
7945 * choose.cc (create_listview): Call set_view_mode with VIEW_CATEGORY.
7946 (do_choose): Log the first category name.
7948 Fri Jun 29 23:07:44 2001 Christopher Faylor <cgf@cygnus.com>
7950 *ini.h: Reapply 2001-06-25 changes.
7951 * choose.cc (add_required): Ditto. Default to "Keep" state if
7952 UNINSTALL and product is installed. Default to curr state if SKIP,
7954 (keep_or_skip): New function. Returns skip or keep state depending on
7955 installed state of package.
7956 (default_trust): Use keep_or_skip to set state.
7957 (_view::insert_pkg): Use calloc to allocate lines.
7958 (set_view_mode): Adapt 2001-06-25 change to set_full_list here.
7960 Sat Jun 30 11:01:00 2001 Robert Collins <rbtcollins@hotmail.com>
7962 * choose.cc: Remove globals full_list, headers, package_indexes and
7964 Add globals cat_headers, pkg_headers and chooser.
7965 (add_required): New function.
7966 (paint): Use the chooser for header details.
7967 Call into the chooser to paint each line.
7968 (list_click): Use new global variables.
7969 Call into the chooser to handle the click.
7970 Repaint the entire view if packages have been added or removed.
7971 (note_width): Get passed a headers struct rather than using a global
7973 (fill_missing_category): New function.
7974 (default_trust): Skip non-"Required" or "Misc" packages.
7975 (pick_line::set_line (Package *)): New function.
7976 (pick_line::set_line (Category *)): New function.
7977 (pick_line::paint): New function.
7978 (pick_line::click): New function.
7979 (_view::_view): New function.
7980 (_view::set_view_mode): New function.
7981 (_view::mode_caption): New function.
7982 (_view::set_headers): New function.
7983 (_view::init_header): New function.
7984 (_view::insert_pkg): New function.
7985 (_view::insert_category): New function.
7986 (_view::insert_at): New function.
7987 (_view::insert_under): New function.
7988 (_view::clear_view): New function.
7989 (viewsplusplus): New function.
7990 (_view::client): New function.
7991 (set_view_mode): Use new chooser functionality.
7992 (set_full_list): Use new global variables.
7993 (create_listview): Instantiate chooser.
7994 Remove all hardcoded headers[] code.
7995 (dialog_cmd): On trust changes, check dependencies.
7996 (getcategorybyname): New function.
7997 (getpackagecategorybyname): New function.
7998 (scan2): Use case-insensitive package comparison.
7999 (do_choose): Use fill_missing_category ().
8000 Show some category data.
8001 * ini.h: Protect against multiple inclusion.
8003 (_CategoryPackage): New struct.
8004 (_Category): New struct.
8005 (_Package): Change category to Category * from char *.
8006 (extern Category category): New global variable.
8007 (extern in ncategories): Ditto.
8008 (getcategorybyname): New prototype.
8009 (catpackagecategorybyname): New prototype.
8010 (register_category): New prototype.
8011 (add_category): New prototype.
8012 * iniparse.y: Parse multiple categories per package.
8013 (category): New global variable.
8014 (ncategories): New global variable.
8015 (new_package): Compare package against NULL, not 0.
8016 (new_requirement): Source formatting fix.
8017 (register_category): New function.
8018 (add_category): New function.
8019 * res.rc: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
8020 IDC_CHOOSE_VIEWCAPTION: New control.
8021 * resource.h: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
8022 IDC_CHOOSE_VIEWCAPTION: New control.
8023 Increment _APS_NEXT_CONTROL_VALUE.
8025 Mon Jun 25 00:56:37 2001 Michael A Chase <mchase@ix.netcom.com>
8027 * choose.cc (paint): Wrap excessively long lines.
8028 (list_click): Ditto.
8029 (create_listview): Ditto.
8030 (do_choose): Ditto. Replace TABs and remove CRs in lines written to
8031 setup.log.full. Allow "Yes" for source exists in setup.log.full when
8032 installing from local directories.
8034 Mon Jun 25 00:56:37 2001 Christopher Faylor <cgf@cygnus.com>
8036 * choose.cc (set_action): Only clear srcpicked when moving to next
8037 state. Allow source installation if it exists in the current "trust"
8038 state. Don't move to skip state when package is installed.
8039 (list_click): Don't allow source clicking when no source is available.
8040 (set_full_list): Display package when not is_full_action.
8041 * ini.h (is_full_action): Define.
8043 Sun Jun 17 12:06:14 2001 Christopher Faylor <cgf@cygnus.com>
8045 * install.cc (check_for_old_cygwin): New function. First stab at
8046 checking for old cygwin versions.
8047 (do_install): Call check_for_old_cygwin if there were no errors during
8050 Sat Jun 16 11:33:51 2001 Michael A Chase <mchase@ix.netcom.com>
8052 * choose.cc (_Info::_Info): Test _source paramenter for non-NULL rather
8053 than zeroed "source" element.
8055 Fri Jun 15 20:54:43 2001 Christopher Faylor <cgf@cygnus.com>
8057 * choose.cc (scan2): Insert unknown tar archives, found on disk, into
8058 the highest available "hole" in the trust array.
8060 Fri Jun 15 00:20:48 2001 Christopher Faylor <cgf@cygnus.com>
8062 * choose.cc (set_existence): Use pointer method for indexing in trust
8064 (create_listview): Ditto.
8065 (scan2): Ditto. Also, use consistent variable name for indexing into
8067 * ini.h (Package): Reorganize info array for easier scanning.
8069 Fri Jun 15 00:01:51 2001 Christopher Faylor <cgf@cygnus.com>
8071 * choose.cc (isinstalled): Eliminate special download only test.
8072 (set_action): Don't move to next state if in ACTION_SAME range and not
8074 (choose_caption): Display "Retrieve" rather than "Reinstall" when just
8076 (do_choose): Sort packages after all packages have been read.
8077 Accomodate the fact that first element in trust array is empty so that
8078 log files don't report the wrong trust value.
8079 * iniparse.y (new_package): Malloc space for package name or suffer
8082 Thu Jun 14 22:43:59 2001 Robert Collins <rbtcollins@hotmail.com>
8084 * ini.h (Dependency): New structure. Declare new function.
8085 * inilex.l (yylex): Detect new setup.ini options - category and
8087 * iniparse.y: Declare new setup.ini token values.
8088 (yyparse): Parse new token values.
8089 (new_requirement): New function.
8091 Thu Jun 14 22:43:26 2001 Christopher Faylor <cgf@cygnus.com>
8093 * choose.cc (read_installed_db): Eliminate obsolete code.
8095 Thu Jun 14 22:11:53 2001 Christopher Faylor <cgf@cygnus.com>
8097 * choose.cc (set_action): Set trust on "redo".
8098 (_Info::_Info): New constructor.
8099 (read_installed_db): Use new constructor. Use trusts type for
8101 * ini.h (struct _Info): Label struct, add constructor.
8102 (Package): Make installed_ix a type 'trusts.'
8103 * install.cc (uninstall_one): Unset any installed info for current
8105 (install_one): Allocate new Info struct for installed reflecting new
8107 (do_install): Don't output line to installed.db if package is being
8110 Thu Jun 14 20:33:01 2001 Robert Collins <rbtcollins@hotmail.com>
8112 * choose.cc (getpkgbyname): Use consistent method for scanning package
8115 Wed Jun 13 23:33:08 2001 Christopher Faylor <cgf@cygnus.com>
8117 * choose.cc: Add some comments.
8118 (getpkgbyname): Use strcasecmp for comparisons.
8120 Wed Jun 13 16:07:00 2001 Christopher Faylor <cgf@cygnus.com>
8122 * install.cc (do_install): Avoid checking for download action if
8123 package wasn't currently retrieved.
8125 Wed Jun 13 11:27:22 2001 Christopher Faylor <cgf@cygnus.com>
8127 * choose.cc: Eliminate extra array throughout. Use element in package
8128 structure instead. Use pointers rather than array indexes where
8130 (set_action): New function to set next action based on current.
8131 (choose_caption): New function. Returns display caption.
8132 (check_existence): Change arguments. Use pointer to 'info' structure.
8133 (set_existence): Use pointer rather than array index.
8134 (default_trust): Use trusts enum for second argument.
8135 (set_full_list): Honor exclude element in package structure.
8136 (build_labels): Eliminate.
8137 (base): Make global. Use const char * argument.
8138 (get_package_version): Eliminate.
8139 (getpkgbyname): New function.
8140 (read_installed_db): Use parse_filename to get version info.
8141 * desktop.cc (make_passwd_group): Use getpkgbyname function.
8142 * download.cc (get_file_size): const argument.
8143 (do_download): Use is_download_action to determine when something
8144 should be downloaded.
8145 * filemanip.h: Add some functions.
8146 * ini.cc (do_ini): Use NULL rather than 0 for pointer assignment.
8147 * ini.h: Use enums for actions and trusts.
8148 (is_download_action): New macro.
8149 (is_upgrade_action): Ditto.
8150 (is_uninstall_action): Ditto.
8151 (struct Package): Add new fields.
8152 * inilex.l (yylex): Detect new setup.ini options.
8153 * iniparse.y: Declare new tokens.
8154 (yyparse): Detect exclude keyword. Fill out version field even if
8156 (new_package): Use greater granularity when allocating package array to
8157 avoid repeated calls to realloc.
8158 * install.cc (exists): const argument.
8159 (uninstall_one): Take pkg argument.
8160 (install_one): Ditto. Eliminate unneeded arguments which can be
8161 derived from package info.
8162 (do_install): Iterate over package array using a pointer. Use
8163 is_download_action to control when package should be downloaded.
8164 * tar.cc (tar_open): const argument.
8165 * tar.h: Refloect const argument.
8167 2001-05-31 Michael Chase mchase@ix.netcom.com
8169 * main.cc (WinMain): Add setup version to starting setup.log entry
8171 Tue May 29 21:37:58 2001 Yukihiko Sohda <sohda@is.titech.ac.jp>
8173 * inilex.l: Add + to list of valid string characters.
8175 Mon May 28 20:54:50 2001 Christopher Faylor <cgf@cygnus.com>
8177 * Makefile.in: Remove more stuff in the clean target.
8179 Mon May 28 18:24:59 2001 Christopher Faylor <cgf@cygnus.com>
8181 * Makefile.in: Correctly generate iniparse.h.
8183 Tue Mar 6 19:14:00 2001 Corinna Vinschen <corinna@vinschen.de>
8185 * geturl.cc (get_url_to_file): Add parameter `allow_ftp_auth'.
8186 * geturl.h: Change declaration of `get_url_to_file' accordingly.
8187 * netio.cc (NetIO::NetIO): Add parameter `allow_ftp_auth'.
8188 Set member `ftp_auth'.
8189 (NetIO::open): Add parameter `allow_ftp_auth'. Use it in calls
8190 to constructors of derived classes.
8191 (NetIO::get_ftp_auth): New method.
8192 * netio.h: Change class definition accordingly.
8193 * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Add parameter `allow_ftp_auth'.
8194 Take global variables `net_ftp_user' and `net_ftp_passwd' into account.
8195 Add code for ftp authentication retry.
8196 * nio-ftp.h: Change class definition accordingly.
8197 * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Add parameter `allow_ftp_auth'.
8198 Add code for ftp authentication retry in case of proxy connection.
8199 * nio-http.h: Change class definition accordingly.
8200 * res.rc: Add FTP authentication dialog.
8201 * resource.h: Add new constants used in res.rc.
8202 * state.h: Add variables `net_ftp_user' and `net_ftp_passwd'.
8204 Sun May 27 17:12:23 2001 Christopher Faylor <cgf@cygnus.com>
8206 * res.rc (IDD_SPLASH): Add a copyright year.
8208 Sun May 27 15:42:18 2001 Christopher Faylor <cgf@cygnus.com>
8210 * Makefile.in: Make iniparse.y produce a c++ file.
8211 * choose.cc (set_existence): Revert 2001-05-27 change.
8212 * ini.cc: Remove "C" from declaration of yyparse.
8213 * iniparse.y (yyparse): Fill out version field by default when a binary
8214 install is detected and no version has been set yet.
8215 * install.cc (do_install): Mount things earlier so that we can use
8216 proper mount table settings. Don't remove mounts since they are now
8218 * mount.cc (create_mount): Reread the mount table after establishing a
8220 (read_mounts): Explicitly clear root_here to allow multiple uses of
8221 this function. Ensure that there is no garbage in the table when we've
8222 exhausted all of the mounts in the registry.
8223 (cygpath): Accomodate ./ in path.
8225 Sun May 27 02:59:07 2001 Christopher Faylor <cgf@cygnus.com>
8227 Use parse_filename method to parse filenames throughout. Use
8228 get_root_dir to retrieve the current root directory throughout. Set
8229 const in argument list, where appropriate, throughout.
8230 * choose.cc (set_existence): Detect case of uninstalled package with no
8232 (parse_filename): New function.
8233 * filemanip.h (fileparse): New structure.
8234 * mount.cc (read_mounts): Remember where we found the root mount.
8235 (set_root_dir): New function.
8236 (get_root_dir): Ditto.
8237 * mount.h: Declare new functions.
8238 * site.cc (get_root_dir_now): Renamed from get_root_dir.
8239 (save_site_url): Use new function name.
8240 (get_initial_list_idx): Ditto.
8242 Sat May 26 21:23:59 2001 Christopher Faylor <cgf@cygnus.com>
8244 * choose.cc: Use a constant throughout to deal with chooser icon
8246 * res.rc (IDD_CHOOSE): Increase size of chooser box.
8248 2001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
8250 * choose.cc (do_choose): Fix incorrect assignment of trust setting to
8251 use when Redownload or Sources Only selected.
8253 Thu May 10 22:35:59 2001 Christopher Faylor <cgf@cygnus.com>
8255 Reformat file after botched patch formatting.
8256 * choose.cc (which_trust): Eliminate variable.
8257 (default_trust): Don't set which_trust.
8258 (do_choose): Use selected trust when reinstalling or installing source.
8260 Thu May 10 21:04:18 2001 Christopher Faylor <cgf@cygnus.com>
8262 Change concat to cygpath throughout.
8263 Change map_filename to cygpath throughout.
8264 * concat.cc (vconcat): New function.
8265 (concat): Use vconcat.
8266 * concat.h: Reflect above.
8267 * install.cc (map_filename): Eliminate.
8268 (install_one): Free dest_file.
8269 * mount.cc (find2): Expect input key to be pointing to mount record.
8270 (in_table): New function.
8271 (is_admin): Move from root.cc.
8272 (read_mounts): New function.
8273 (path_prefix_p): New function.
8274 (cygpath): New function.
8275 * mount.h: Define new functions and structure.
8276 * root.cc (in_table): Move to mount.cc.
8277 (do_root): Call read_mounts to initialize root stuff and mount table.
8278 * site.cc (get_root_dir): Ditto.
8280 2001-05-09 Matt Hargett <matt@use.net>
8282 * Makefile.in: Remove *.rc from clean.
8284 Tue May 8 23:33:38 2001 Christopher Faylor <cgf@cygnus.com>
8286 * choose.cc (scan2): Fix incorrect setting of TRUST_CURR rather than
8287 TRUST_PREV which produced "0" versions.
8289 2001-05-07 Brian Keener <bkeener@thesoftwaresource.com>
8291 * resource.h: Add new field IDC_CHOOSE_INST_TEXT. Modify
8292 _APS_NEXT_CONTROL_VALUE to account for addition of
8293 IDC_CHOOSE_INST_TEXT.
8294 * res.rc (IDD_CHOOSE): Modify choose dialog to use new field
8295 IDC_CHOOSE_INST_TEXT for screen text. Modify choose Dialog to allow
8296 hot keys to select Prev, Curr, Exp.
8297 * ini.h: Add new actions for ACTION_REDO and ACTION_SRC_ONLY. Modify
8298 define for LOOP_PACKAGES to include new actions ACTION_REDO and
8300 * choose.cc: Add new Trusts for TRUST_REDO and TRUST_SRC_ONLY.
8301 (paint): Modify to check TRUST_SRC_ONLY when determining Bitmap for
8302 source Checkbox to use.
8303 (build_labels): Add logic to allow for selection of Source only
8304 Download/ReDownload/Install/Reinstall and also to Redownload/Reinstall
8305 current version binary.
8306 (dialog_proc): Add conditional display for file selection prompt based
8307 on download vs install using IDC_CHOOSE_INST_TEXT.
8308 (do_choose): Add new logic for TRUST_REDO and TRUST_SRC_ONLY selection
8309 and modify logic for TRUST_UNINSTALL, TRUST_KEEP, and TRUST_NONE to
8310 handle the instance where Source Download/Install was selected. Modify
8311 log file to store appropriate information regarding Action selected and
8312 the new actions that were added (I.E.: ACTION_REDO and
8314 * download.cc: Add include for <unistd.h> and "port.h".
8315 (download_one): Modify parameter list to include the selected action
8316 for the file to be downloaded. Modify size check against expected size
8317 to include check for ACTION_REDO and ACTION_SRC_ONLY. Modify rename of
8318 .tmp file to also remove the destination file if exists due to ability
8319 to redownload source and binary now.
8320 (do_download): Modify to also use ACTION_REDO and ACTION_SRC_ONLY in
8321 calculation of Download Bytes. Modify to also use ACTION_REDO and
8322 ACTION_SRC_ONLY in determining files selected for download.
8323 * install.cc (uninstall_one): Add check to treat a Reinstall like an
8324 upgrade so current version will be uninstalled prior to reinstall.
8325 (do_install): Add logic to handle ACTION_REDO and ACTION_SRC_ONLY for
8326 uninstalling and installing binary and source packages.
8327 * desktop.cc (make_passwd_group): Modify logic to account for a Source
8328 only cygwin install when checking for cygwin to determine need for
8329 mkpasswd and mkgroup.
8331 Mon May 7 23:33:30 2001 Matt Hargett <matt@use.net>
8333 * winsup/cinstall/res.rc: Added accelerators and improved focus order.
8334 Removed WS_DISABLED from "OK" buttons to accomodate default focus
8335 changes in net.cc and source.cc.
8336 * winsup/cinstall/net.cc (dialog_proc): If no radio button is selected,
8337 a default is selected.
8338 * winsup/cinstall/source.cc (dialog_proc): Ditto.
8339 (check_if_enable_next): Removed. No longer needed since a radio button
8340 will always be selected.
8341 (load_dialog): Removed call to check_if_enable_next.
8342 (dialog_cmd): Ditto. Also added default to switch.
8344 Tue Apr 24 23:42:02 2001 Christopher Faylor <cgf@cygnus.com>
8346 * res.rc: Resize affected text.
8348 Tue Apr 24 23:35:31 2001 Christopher Faylor <cgf@cygnus.com>
8350 * net.cc (do_net): Default to direct download.
8351 * res.rc: Move default selections to the top.
8353 2001-04-18 Earnie Boyd <earnie@users.sourceforge.net>
8355 * win32.h: Remove the definitions for _UNION_NAME and _STRUCT_NAME.
8356 Must now include <windows.h> and not the pieces.
8357 * choose.cc (create_listview): Clean up type mismatch problems.
8358 * dialog.h (NEXT(id)): Ditto.
8359 * geturl.cc (dialog): Ditto.
8360 * install.cc (dialog): Ditto.
8361 * splash.cc (load_dialog): Ditto.
8363 Wed Apr 18 18:59:21 2001 Christopher Faylor <cgf@cygnus.com>
8365 * tar.cc (class gzbz): Define dummy virtual functions.
8367 Wed Apr 18 16:01:21 2001 Christopher Faylor <cgf@cygnus.com>
8369 * Makefile.in: Add bz2 include/library support.
8370 * filemanip.h: New file.
8371 * choose.cc (find_tar_ext): New function. Returns TRUE if .tar.gz or
8373 (scan2): Reorganize to use find_tar_ext, accomodating .bz2 extension.
8374 (read_installed_db): Ditto.
8376 * fromcwd.cc (found_file): Ditto.
8377 (do_fromcwd): Ditto.
8378 * tar.cc (class gzbz): New super class for uncompression support.
8379 (gz): New class for gzip support.
8380 (bz): New class for bzip2 support.
8381 (tar_open): Use gzbz class to control file opening.
8382 (tar_ftell): Ditto for returning position in file.
8383 (skip_file): Ditto for reading file.
8384 (tar_next_file): Ditto.
8385 (tar_read_file): Ditto.
8386 (tar_close): Ditto for close.
8388 * zlib/configure.in: Force NM substitution.
8390 * source.cc (do_source): Default to "Install from Internet".
8392 2001-03-16 Brian Keener <bkeener@thesoftwaresource.com>
8394 * nio-file.cc (NetIO_File::NetIO_File): Use `get_file_size' instead of
8396 * choose.cc (list_click): Correct inability to select source code for
8398 (scan2): Modify to skip source tarballs when scanning disk for
8399 installable packages.
8401 2001-03-10 Chris Abbey <chris_abbey@yahoo.com>
8403 * install.cc: install sources into /usr/src instead
8404 of /, also include the sizes of source tarballs
8406 * download.cc: include sizes of source tarballs in
8407 total_download_bytes.
8409 Tue Mar 6 19:31:00 2000 Corinna Vinschen <corinna@vinschen.com>
8411 * download.cc (get_file_size): Remove `static'.
8413 Tue Mar 6 19:11:00 2000 Corinna Vinschen <corinna@vinschen.com>
8415 * tar.cc (tar_open): Use `get_file_size' instead of `stat'.
8417 2001-03-06 Brian Keener <bkeener@thesoftwaresource.com>
8419 * choose.cc (paint): Modify message for nothing to download vs
8420 nothing to install/update based on installation method.
8421 (list_click): Modify to skip versions in selection process if
8422 installing from local directory and installation file does not exist.
8423 Also leaves Source Action set to N/A if the source file does not exist
8424 and installing from local directory.
8425 (check_existence): New method to check current existence of installation
8426 files based on selected installation method.
8427 (set_existence): New method to set the current existence of installation
8428 files based on selected installation method.
8429 (best_trust): Modify decision process for best trust to base decision on
8430 current trust selected (IE: Prev, Curr, or Test), existence of file and
8431 installation method selected.
8432 (default_trust): Add logic to capture the current trust level and the
8433 trust selected for the given package.
8434 (set_full_list): Expand decision criteria for displaying a package in
8435 the selection list to include file existence/non-existence and selected
8436 installation method.
8437 (build_labels): Modify criteria for label addition to include
8438 installation method and file existence/non-existence.
8439 (create_listview): Modify to establish package trust level for each
8440 package before setting up the display list. Also modification to set
8441 current trust button as the default.
8442 (dialog_cmd): Set response for Prev, Curr, Test button push to perform
8443 a reset of the selection list in addition to setting the default trust.
8444 (get_package_version): New method to provide reusable code for
8445 determining the package version from the file name for a specified
8447 (scan2): Modify to use new method get_package_version and
8448 also enhance handling of the build for the structures package and
8450 (read_installed_db): Modify to use the new method
8451 get_package_version and also enhance handling of the build for the
8452 structures package and extra.
8453 (do_choose): Add additional initialization of package and extra
8454 structures. Modify to use read_installed_db all the time despite
8455 install method. Modify output to setup.log.full log file to increase
8456 readability by adding additional spacing, expanded code and available
8458 * ini.h: Add new fields install_exists, source_exists and
8459 partial_list_display to the structure definition for package.
8460 * res.rc (IDD_CHOOSE): Modify choose dialog Prev, Curr, and Test
8461 pushbuttons by replacing with Radio Buttons thus allowing the
8462 operator to better determine which is selected.
8464 2001-02-20 Brian Keener <bkeener@thesoftwaresource.com>
8466 * download.cc (do_download): Add new variables total_download_bytes and
8467 total_download_bytes_sofar for download progress meter. Add loop
8468 to accumulate the total bytes to download from the selected packages.
8469 * geturl.cc: Add state.h and diskfull.h to include list. Add new
8470 variables gw_iprogress, gw_pprogress, gw_progress_text,
8471 gw_pprogress_text, and gw_iprogress_text to allow for addition of
8472 total packages download progress meter and disk full percent
8473 progress meter. Add variables total_download_bytes and
8474 total_download_bytes_sofar for use by progress meters.
8475 (dialog_proc): Add new variables gw_iprogress, gw_pprogress,
8476 gw_progress_text, gw_pprogress_text, and gw_iprogress_text to
8477 allow for addition of total packages download progress meter and disk
8478 full percent progress meter.
8479 (init_dialog): Ditto.
8481 (get_url_to_file): Ditto.
8482 * geturl.h: Add external definition for total_download_bytes and
8483 total_download_bytes_sofar.
8484 * res.rc: Add two additional progress meters (IDC_DLS_IPROGRESS)
8485 and (IDC_DLS_PPROGRESS) and three text objects (IDC_DLS_PROGRESS_TEXT)
8486 and (IDC_DLS_IPROGRESS_TEXT, IDC_DLS_PPROGRESS_TEXT) for use in the
8488 * resource.h: Add new fields for progress meters and text and update
8489 _APS_NEXT_CONTROL_VALUE.
8491 Wed Feb 21 13:05:00 2000 Corinna Vinschen <vinschen@redhat.com>
8493 * download.cc (get_file_size): Check for INVALID_HANDLE_VALUE instead
8496 Wed Feb 21 11:21:00 2000 Corinna Vinschen <vinschen@redhat.com>
8498 * download.cc (download_one): Add missing parenthesis.
8500 Mon Feb 19 18:59:00 2000 Corinna Vinschen <vinschen@redhat.com>
8502 * download.cc (get_file_size): New function. Eliminates the need
8504 (download_one): Call `get_file_size' instead of `stat'. This
8505 workarounds a problem with mingw's `stat' call.
8507 2001-02-07 Earnie Boyd <earnie@users.sourceforge.net>
8509 * Makefile.in: (%.o: %.rc): Specify --include-dir $(w32api_include).
8510 This is to allow cinstall to build with 2.95.2-7 and to make the
8511 use of headers consistent.
8513 2000-12-26 Earnie Boyd <earnie_boyd@yahoo.com>
8515 * Makefile.in (autoload.o): Add target to specify -fno-inline-functions
8517 Tue Dec 26 03:46:00 2000 Matt Hargett <matt@use.net>
8519 * winsup/cinstall/res.rc: Added accelerators and improved focus
8522 2000-12-10 Egor Duda <deo@logos-m.ru>
8524 * choose.cc (paint): Use system background color for text output.
8526 Sun Dec 10 19:05:25 2000 Christopher Faylor <cgf@cygnus.com>
8528 * Makefile.in: Use CXX for linking and for compiling .cc files.
8529 * configure.in: Find correct c++ compiler.
8530 * configure: Regenerate.
8532 2000-11-17 DJ Delorie <dj@redhat.com>
8534 * splash.cc (load_dialog): Make message more obvious.
8537 Fri Nov 17 17:15:21 2000 Christopher Faylor <cgf@cygnus.com>
8539 * Makefile.in: Use g++ to link so that libstdc++.a gets used. This is
8540 necessary for newer compilers.
8542 Wed Nov 9 2:19:00 2000 Corinna Vinschen <vinschen@redhat.com>
8544 * desktop.cc: Include "ini.h" and "version.h".
8545 (make_passwd_group): Skip the function on 9x/ME boxes when an
8546 older version of Cygwin has been installed which doesn't
8547 support mkpasswd/mkgroup on 9x/ME.
8548 * install.cc: Move the `LOOP_PACKAGES' and `pi' macros to...
8551 Wed Nov 8 17:10:00 2000 Corinna Vinschen <vinschen@redhat.com>
8553 * desktop.cc (make_passwd_group): Don't exit when started
8554 on 9x/ME since mkpasswd/mkgroup are usable on 9x/ME now.
8556 Sun Nov 5 12:51:42 2000 Jason Tishler <jt@dothill.com>
8558 * install.cc (do_install): Add call to set_cygdrive_flags to sync
8560 * mount.cc (set_cygdrive_flags): New function.
8561 (get_cygdrive_flags): Ditto.
8562 (default_cygdrive): Ditto.
8563 (set_cygdrive_flags): Ditto.
8564 * mount.h: Add prototype for set_cygdrive_flags.
8566 2000-10-23 DJ Delorie <dj@redhat.com>
8568 * ini.h: add source actions
8569 * fromcwd.cc: check for available sources
8570 * res.rc: add checkbox bitmaps
8573 * choose.cc: add source column
8574 * download.cc: download sources if called for
8575 * install.cc: [un]install sources too
8577 2000-10-22 DJ Delorie <dj@redhat.com>
8579 * choose.cc (build_labels): Don't skip TRUST_PREV completely; only
8580 ignore it wrt full_list if there's already a version installed.
8581 (do_choose): Sort the list.
8582 (package_sort): New.
8584 2000-10-12 DJ Delorie <dj@redhat.com>
8586 * res.rc: Add more error strings.
8587 * resource.h: Ditto.
8588 * iniparse.y (new_package): re-initialize if needed.
8589 * download.cc (do_download): Keep track of errors; notify and
8591 * install.cc (do_install): Ditto.
8593 2000-10-05 DJ Delorie <dj@redhat.com>
8595 * Makefile.in: fix %.cc rule
8597 2000-10-04 DJ Delorie <dj@redhat.com>
8599 * desktop.cc: quote HOME and USER, don't . ./.profile
8601 * choose.cc (build_labels): don't include in partial list just
8602 because there's a *previous* version available.
8604 * install.cc (do_install): if installing from local directory with
8605 setup.ini and the file isn't found, look in "." also. Note errors.
8607 2000-10-02 DJ Delorie <dj@redhat.com>
8609 * ini.cc (do_ini): save setup.ini locally
8611 2000-10-02 Chris Abbey <cabbey@bresnanlink.net>
8613 * desktop.cc: quote escapes in prompt
8615 2000-10-02 Jason Tishler <jt@dothill.com>
8617 * root.cc (is_admin): New function.
8618 (read_mount_table): Check for administrative priviledges and set
8619 installation scope as appropriate.
8621 2000-09-28 DJ Delorie <dj@redhat.com>
8623 * nio-ftp.cc (ftp_line): handle continuations more robustly
8625 2000-09-14 Brian Keener <bkeener@thesoftwaresource.com>
8627 * res.rc: increased the size of the site dialog (IDD_SITE) & the
8628 corresponding list box to provide for more URL's to be listed.
8629 Modified the position of the Back, Next and Cancel buttons to
8630 correspond to the new size of the dialog.
8632 2000-09-13 DJ Delorie <dj@redhat.com>
8634 * install.cc (do_install): update disk fullness once per package
8635 to improve performance
8637 * choose.cc (create_listview): call ReleaseDC
8639 Mon Sep 11 22:40 2000 Harold L Hunt II <harold@compasstechnologies.com>
8641 * mkdir.cc: Create directories when ERROR_FILE_NOT_FOUND is
8642 returned, as it seems Samba 2.0.6+ returns this instead of
8643 ERROR_PATH_NOT_FOUND
8645 Mon Sep 11 19:35:24 2000 Christopher Faylor <cgf@cygnus.com>
8647 * site.cc (get_initial_list_idx): Don't default to saved URL if it
8650 2000-09-07 DJ Delorie <dj@redhat.com>
8652 * splash.cc: use version.h, not local decl
8653 * res.rc: add "old version" message
8656 * fromcwd.cc (canonicalize_version): make global
8657 * iniparse.y: add setup-version support, fix bug in blank line
8660 * inilex.l: add [exp] as alias for [test], add setup-version
8661 * Makefile.in (version.c): add setup-version tag
8663 * desktop.cc (do_desktop): remove 1.1 version number
8664 (do_desktop_setup): ditto
8666 * ini.cc (do_ini): zero out package list just in case we redo it.
8668 2000-09-07 Jeffrey Juliano <juliano@cs.unc.edu>
8670 * choose.cc (list_click): Check for nindexes==0; if so, return.
8672 2000-09-06 Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru>
8674 * localdir.cc: new, local package directory selection dialog; cd
8675 into selected directory
8676 * Makefile.in (OBJS): add localdir.o
8677 * dialog.h: add prototype for do_local_dir
8678 * main.cc (WinMain): initialize local_dir to cwd; add call to
8680 * net.cc (dialog_cmd): make DO_LOCAL_DIR next dialog
8681 * source.cc (dialog_cmd): ditto
8682 * res.rc: add DO_LOCAL_DIR dialog; remove "current directory" from
8683 presented choices in IDD_SOURCE; add IDS_ERR_CHDIR error string
8684 * resource.h: defines for DO_LOCAL_DIR dialog; define IDS_ERR_CHDIR
8685 * root.cc (dialog_cmd): make DO_LOCAL_DIR previous dialog
8686 * state.h: add local_dir variable
8688 2000-09-06 Brian Keener <bkeener@thesoftwaresource.com>
8690 * desktop.cc: added logic to handle to the new dialog and to
8691 default the setting for the new checkboxes based on whether the
8692 desktop icon or start menu link already exist.
8693 (desktop_icon): correction to desktop directories for desktop icon
8694 creation. Additional logic added for Win95 which does not appear
8695 to have Common Directories so if Common selected and null uses
8697 (start_menu): Additional logic added for Win95 which does not
8698 appear to have Common Directories so if Common selected and null
8699 uses normal directory.
8700 (do_desktop_setup): moved the saving of the icon, creation of the
8701 bat file, profile, passwd, Start Menu link and desktop shortcut to
8702 this method from do_desktop. Made the creation of the desktop
8703 icon and start menu link conditional on settings of new dialog
8704 created for desktop.
8705 * install.cc (do_install): changed next from IDD_S_DESKTOP to
8707 * main.cc (WinMain): changed case IDD_S_DESKTOP to IDD_DESKTOP.
8708 * res.rc: added new resource to create a desktop dialog with 2
8709 checkboxes for creating the desktop icon and start menu link.
8710 * resource.h: changed IDD_S_DESKTOP to IDD_DESKTOP and added two
8711 new controls: IDC_ROOT_MENU and IDC_ROOT_DESKTOP for new dialog.
8712 * state.h: added root_menu and root_desktop for use in dialog.
8714 2000-08-29 DJ Delorie <dj@redhat.com>
8716 * choose.cc (scan_downloaded_files): scan for existing files, so
8717 that the user only sees new downloads.
8719 * nio-ie5.cc (NetIO_IE5): pre-check for wininet.dll, enable dial-up
8720 * site.cc (do_site): if we can't download the mirror list, go back
8721 to the net setup box to choose another transport.
8722 * autoload.c: add more functions
8723 * Makefile.in (ALL_DEP_LDLIBS): remove wininet.a
8724 * resource.h: add WININET message
8726 * net.cc (do_net): no longer default to IE5
8727 * simpsock.h (class SimpleSocket): new, simplify socket operations
8728 * simpsock.cc: ditto
8729 * nio-http.h: new, for direct http protocol
8730 * nio-http.cc: ditto
8731 * nio-ftp.h: new, for direct http protocol
8733 * netio.cc (set_url): move initialization here to handle redirections
8734 (open): add direct http/ftp
8735 * netio.h (NetIO::set_url): new
8737 * log.cc (log_save): create directory for log if needed
8739 * hash.cc, hash.h: new
8740 * Makefile: add hash.o
8741 * choose.cc: enable "uninstall" option
8742 * download.cc: invert action test to accomodate uninstalling
8743 * ini.h: add ACTION_UNINSTALL
8744 * install.cc: add uninstall functionality
8745 * res.rc: make install tag changeable
8746 * resource.h: add uninstall resources
8748 * res.rc: update mirror list URL
8750 2000-08-24 DJ Delorie <dj@redhat.com>
8752 * log.cc, log.h: new files
8753 * Makefile.in (OBJS): add log.o
8754 * tar.cc: use exit_setup instead of exit
8755 * dialog.cc (fatal): use exit_setup instead of ExitProcess
8756 * msg.cc (fatal): ditto
8757 * install.cc (dialog_cmd): ditto
8758 * ini.cc (do_ini): ditto
8759 * main.cc (main): add logging
8760 * source.cc (do_source): ditto
8761 * root.cc (do_source): ditto
8762 * site.cc (do_site): ditto
8763 * other.cc (do_other): ditto
8764 * net.cc (do_net): ditto
8765 * choose.cc (do_choose): ditto
8766 * download.cc (do_download): ditto
8767 * install.cc (do_install): ditto
8768 * msg.cc (fatal): ditto
8770 * res.rc: mark password boxes as *being* password boxes.
8772 * fromcwd.cc (canonicalize_version): use multiple buffers so that
8773 multiple calls won't use the same buffer.
8774 * choose.cc (create_listview): don't default to full list if no changes
8775 (base): return computed value, not temporary :-(
8776 (do_choose): don't use installed.db if we're only downloading.
8778 2000-08-23 DJ Delorie <dj@redhat.com>
8780 * nio-ie5.cc (NetIO_IE5): Fix authentication logic
8781 * nio-ie5.h (flush_io): new
8782 * netio.cc (load_dialog): note when we're initializing the dialog
8783 box, and ignore changes to the edit fields then.
8785 2000-08-21 DJ Delorie <dj@redhat.com>
8789 * fromcwd.cc (found_file): don't remember the canonicalized version
8791 * choose.cc (paint): print "nothing to do" message when list is empty.
8792 (build_labels): Use version "0.0" if no version is available.
8793 (create_listview): default to full list if nothing to install/update.
8794 (base): new, returns basename of file
8795 (read_installed_db): compare base names, not full paths
8797 2000-08-11 DJ Delorie <dj@redhat.com>
8799 * choose.cc: add new chooser dialog
8800 * fromcwd.cc: use IDD_CHOOSE
8801 * ini.cc: use IDD_CHOOSE
8802 * main.cc: use IDD_CHOOSE
8803 * ini.h: cosmetic changes
8804 * res.rc: add choose dialog, bitmaps
8805 * choose-spin.bmp: new
8806 * choose-rtarrow.bmp: new
8807 * resource.h: add choose dialog controls
8809 * mount.cc: remove debug statement
8811 2000-08-08 DJ Delorie <dj@redhat.com>
8813 * Makefile.in (version.c): make version checking more robust
8814 * splash.cc (load_dialog): handle case where there's no version
8816 2000-08-07 DJ Delorie <dj@redhat.com>
8818 * (all): add cvsid tags
8819 * Makefile.in: generate version.c from ChangeLog, add splash.o
8821 * res.rc: add splash screen
8823 2000-08-02 DJ Delorie <dj@redhat.com>
8825 * net.cc: remove proxy password code
8826 * res.rc: remove proxy user/pass from net, add auth dialogs
8827 * netio.cc,h: add sys/proxy auth methods
8828 * nio-ie5: use them, check for http status codes
8829 * state.h: add system authorization
8831 * concat.cc (concat): canonicalize x:// to x:/ (exception to ://
8834 2000-08-02 Norman Vine <nhv@yahoo,com>
8836 * msg.cc (mbox): added MB_TOPMOST to MessageBox type flags
8838 2000-08-01 DJ Delorie <dj@redhat.com>
8840 * postinstall.cc (each): don't rename files we ignore
8841 (do_postinstall): set CYGWINROOT to root_dir, chdir there
8843 * desktop.cc: have /etc/profile call ~/.profile and ~/.bashrc
8845 2000-07-31 DJ Delorie <dj@redhat.com>
8847 * desktop.cc: reverse PATH so /usr/bin precedes /bin
8849 2000-07-18 DJ Delorie <dj@redhat.com>
8851 * autoload.c: new, autoload dlls that might not be available.
8852 * Makefile.in (OBJS): add autoload.o
8854 * res.rc: rewrite root options (text/binary, system/user) to be
8857 * site.cc (get_site_list): trim displayed URL, sort by domain
8859 * net.cc (do_net): make IE5 default to checked, for now
8861 * choose.cc (do_choose): sort packages correctly
8862 * ini.cc (do_ini): handle parse errors more gracefully
8864 (fprintf): line buffer output
8865 (do_ini): if we can't load setup.ini, go back to the site list.
8866 * ini.h: add "unknown" trust level
8867 * inilex.l: absorb unknown trust levels and key/value pairs,
8868 add line number logic
8869 * iniparse.y: handle parse errors more gracefully.
8870 * install.cc: skip packages with no valid install entry
8872 2000-07-17 DJ Delorie <dj@cygnus.com>
8874 * coding standards fixups, many files
8875 * mkdir.cc: warn about deletions *before* deleting them
8877 2000-07-17 Jeff Juliano <juliano@cs.unc.edu>
8879 * res.rc (IDD_OTHER_URL): reorder to give default focus to entry
8881 * other.cc (dialog_cmd): save download site URL
8882 * site.cc (get_root_dir): new
8883 (save_mirror_site): new
8884 (dialog_cmd): save download site URL
8885 (get_site_list): make list big enough to add prev site
8886 (get_initial_list_idx): new, read last-used URL from file and
8887 append it to site_list
8888 (do_site): call get_initial_list_idx
8890 * concat.cc (concat): avoid segfault when first parm is null
8892 2000-07-13 DJ Delorie <dj@cygnus.com>
8894 * postinstall.cc: new
8895 * Makefile.in: add postinstall.o
8896 * concat.h: add backslash ()
8898 * desktop.cc (etc_profile): don't do postinstall
8899 (backslash): moved to concat.cc
8901 (make_postinstall_script): run directly
8902 (do_desktop): chain to do_postinstall
8903 * dialog.h: add exit_msg, do_postinstall
8904 * download.cc: use exit_msg
8906 * main.cc: add postinstall, exit_msg
8907 * resource.h: add postinstall
8908 * README: add more to-do items
8910 2000-07-12 DJ Delorie <dj@cygnus.com>
8912 * desktop.cc: add /etc/postinstall/ support
8913 * install.cc: add more "standard" directories
8915 2000-07-11 DJ Delorie <dj@cygnus.com>
8917 * desktop.cc: create /etc/profile
8918 * desktop.cc: fix include syntax
8919 * Makefile.in: add auto-dependencies
8920 * root.cc: support system vs user
8928 * desktop.cc: make sure we use backslashes, not slashes.
8929 * desktop.cc: don't set PATH in cygwin.bat, create /etc/passwd
8930 * geturl.cc: change math for percentage to avoid overflow
8932 * download.cc: post "download complete" message.
8933 * root.cc: pre-fill in defaults if needed, don't start
8934 browse at root_dir unless it's set.
8935 * desktop.cc: quote $PATH in case it has spaces in it
8937 2000-07-10 DJ Delorie <dj@cygnus.com>
8939 * Makefile.in: add desktop.o and mklink2.o
8940 * dialog.h: add do_desktop
8941 * install.cc: create standard directories, call do_desktop
8942 * res.rc: add cygwin.ico as a file also
8943 * desktop.cc: new, do shortcuts, batch files, and icons
8944 * mklink2.c: new, for COM
8945 * README: update to-do list
8947 2000-07-10 DJ Delorie <dj@cygnus.com>
8949 * ini.cc (do_ini): don't worry about timestamps if we're not
8950 actually installing.
8952 2000-07-09 DJ Delorie <dj@cygnus.com>
8954 * Makefile.in: add -I$(srcdir) for ini.h
8956 2000-07-06 DJ Delorie <dj@cygnus.com>
8958 * Replace everything with a new GUI version
8959 * zlib/gzio.c: add gzctell() for progress displays
8961 2000-06-22 DJ Delorie <dj@cygnus.com>
8963 * setup.c (tarx): re-add call to write_pkg()
8965 2000-06-07 DJ Delorie <dj@cygnus.com>
8967 * cygcalls.c: new, call cygwin1.dll functions directly
8968 * cygcalls.h: header for same
8969 * Makefile.in: add cygcalls.[ch], remove mount/cygpath/umount
8970 exes, fix cinstall.rc dependencies.
8971 * path.c: remove unneeded code
8972 * setup.c: use cygcalls instead of xcreate_process.
8973 uncompress embedded files with zlib
8974 add "-d" for "download only"
8976 postpone mount changes until very end
8977 add download progress indicators
8978 pack multi-column listings more
8979 auto-delete temp files
8980 customize banner message according to options
8981 prompt user for text/binary mounts
8982 add warnings about empty setup directory, root installs, etc
8984 2000-05-24 DJ Delorie <dj@cygnus.com>
8986 * tar.c: New file; built-in tar using zlib.
8987 * tar.h: New file; header for same.
8988 * ctar.c: New file; test program for same.
8989 * Makefile.in: add built-in tar, remove tar.exe and gzip.exe
8990 * path.c (pathcat): convert slashes and canonicalize, instead of
8992 * setup.c (tarx): add support for built-in tar
8993 (main): accept unix-style slashes, check root dir for drive letters,
8994 warn about installing in /, make sure cwd is empty for internet
8995 installs, defer mounts to end of install, support built-in tar.
8997 Fri May 19 23:44:37 2000 Christopher Faylor <cgf@cygnus.com>
8999 Fix compiler warnings throughout.
9000 * pkg.c (init_pkgs): Make static 'stuff' global_pkgstuff for use in
9002 * setup.c: Make 'root' global.
9003 (istargz): Return pointer to "stem" of matched .tar.gz file.
9004 (tarx): Special case cygwin-20000301 to == cygwin-1.1.0.tar.gz. Remove
9005 bogus check_for_installed check.
9006 (recurse_dirs): Add preliminary support for .bat file execution.
9007 (create_uninstall): Eliminate unneeded parameter.
9008 (do_start_menu): Ditto.
9010 (get_pkg_stuff): Ditto. Check for currently installed cygwin by
9011 scanning for the version number. Eliminate unneeded argument to
9013 (getdownloadsource): Add 'name' to list of names rather than url.
9014 (main): Eliminate unneeded argument in get_pkg_stuff. Eliminate
9015 unneeded argument in mkmount and do_start_menu.
9017 2000-05-18 DJ Delorie <dj@cygnus.com>
9019 * setup.c (optionprompt): allow multi-column, clean up message
9020 about more options, be more robust about user input.
9021 (getdownloadsource): make the mirror URL a macro.
9022 (main): do mounts after done prompting user.
9024 Tue May 2 00:56:41 2000 Christopher Faylor <cgf@cygnus.com>
9026 * setup.c (cleanup): Inverse order of deletion stands a better chance
9027 of deleting cygpath.exe. Still seems to suffer from occasional races,
9029 (cleanup_on_signal): Perform convoluted dance to accomodate win95 and
9031 (output_file): Defend against an unlikely handle leak.
9032 (main): Don't set up signal handling until we have something special to
9035 Mon May 1 17:56:32 2000 Christopher Faylor <cgf@cygnus.com>
9037 * path.c (kill_cygpath): Delete function.
9038 (exit_cygpath): Make more defensive so that it can be called at any
9040 (cygpath_pipe): Don't set up signal here. Do it in main().
9041 * setup.c (istargz): New function.
9042 (recurse_dirs): Look for *.gz pattern rather than *tar.gz since *tar.gz
9043 inexplicably fails on samba mounted partitions. Use istargz to match
9045 (processdirlisting) Use istargz to match tar.gz tail.
9046 (cleanup): Renamed from filedel.
9047 (cleanup_on_signal): New function. Called on CTRL-C.
9048 (main): Record handle of main thread so that it can be suspended when
9049 CTRL-C occurs. Set up cleanup_on_signal signal handler.
9051 Mon May 1 11:05:07 2000 Christopher Faylor <cgf@cygnus.com>
9053 * setup.c (do_start_menu): Don't concatenate paths to already built
9056 Sun Apr 30 22:37:34 2000 Christopher Faylor <cgf@cygnus.com>
9058 * path.c (exit_cygpath): Wait for subprocess to exit before returning.
9059 (cygpath_pipe): Don't call exit_cygpath. Let main atexit routine do
9061 * pkg.c (init_pkgs): Accept root argument. Make registry key "cygwin
9063 * setup.c (filedel): Call exit_cygpath here so that we can be assured
9064 that cygpath subprocess has died. This allows us to delete cygpath.exe
9066 (optionprompt): Initialize response to -1 so that second screen of
9067 mirrors will appear.
9068 (get_pkg_stuff): Don't attempt to use HKCLU. Pass root to init_pkgs.
9069 * setup.h: Reflect init_pkgs prototype change.
9071 Sat Apr 29 23:53:30 2000 Christopher Faylor <cgf@cygnus.com>
9073 * pkg.c (init_pkgs): Accept an argument to control what root registry
9075 * setup.c (get_pkg_stuff): Use HKCLU registry key if default fails.
9076 * setup.h: Reflect init_pkgs prototype change.
9078 Sat Apr 29 23:27:14 2000 Christopher Faylor <cgf@cygnus.com>
9080 * error.c (winerror): Respond to gcc warning.
9081 * path.c (cygpath_pipe): Ditto.
9082 * setup.c (filedel): Call sa_cleanup on deleteme.
9083 (create_shortcut): Coerce argument to eliminate compiler warning.
9084 (tarx): Use installed version of cygwin1.dll, overriding tar file name.
9085 (refmatches): New function. Tests if ref is contained in a list of
9086 packages to install.
9087 (filematches): New function. Tests if filename matches one of a list
9088 of packages to install.
9089 (recurse_dirs): Accept list of packages to install. Generalize tar.gz
9090 test to accomodate _tar.gz.
9091 (prompt): Ensure that stdout is flushed prior to asking for input.
9092 (findhref): Initialize variables to quiet a compiler warning.
9093 (processdirlisting): Accept list of packages to install. Special case
9094 cygwin tar file version number.
9095 (downloaddir): Accept list of packages to install.
9096 (downloadfrom): Ditto.
9097 (create_uninstall): Eliminate unneeded variables. Quote arguments to
9099 (do_start_menu): Don't create uninstall bat file if updating or user
9100 specified a list of packages.
9101 (mkmount): Eliminate unneeded variables.
9102 (get_pkg_stuff): New function. Checks for previous unversioned
9104 (main): Accept -u and -f options and package names on the command line.
9105 Use get_pkg_stuff to initialize package information. Umount /etc.
9106 Call recurse_dirs and downloadfrom with list of package to install.
9107 Ensure that all /usr/local directories are created. Output
9108 installation time to setup.log.
9109 * setup.h: Add some prototypes.
9110 * xsystem.c (xcreate_process): Eliminate unneeded variable.
9112 Sat Apr 29 12:43:08 2000 Christopher Faylor <cgf@cygnus.com>
9114 * setup.c (optionprompt): Don't overlap display of already seen options
9116 (geturl): Print name of site which we're connecting to rather than "ftp
9118 (processdirlisting): Avoid URLs that contain a /. or ./ . Is this
9119 test too simplistic?
9120 (do_start_menu): Use pathcat to build path to <root>\bin to avoid
9121 problems when user chooses x:\ as their root.
9122 (main): For now, default to "non-update" mode. Allow -u option to
9125 Sat Apr 29 00:26:06 2000 Christopher Faylor <cgf@cygnus.com>
9128 * setup.c (tarx): Skip already installed or older packages. Report
9129 when a package has been updated.
9130 (processdirlisting): Skip already installed or older packages.
9131 (main): Detect -f option for forced installation. Initialize pkg stuff
9133 * setup.h: Add pkg definitions.
9135 Thu Apr 27 14:21:30 2000 Christopher Faylor <cgf@cygnus.com>
9137 * setup.c (findhref): Return NULL on empty string. Eat any trailing
9139 (processdirlisting): Attempt to limit recursively processing the same
9142 Thu Apr 27 11:42:23 2000 Christopher Faylor <cgf@cygnus.com>
9144 * setup.c (filedel): New function.
9145 (output_file): Keep track of files extracted from setup.exe for
9146 subsequent deletion.
9147 (tarx): Close process handle of child tar process or suffer handle
9149 (getdownloadsource): Close mirror file so that it can be unlinked.
9150 (processdirlisting): Return total number of files extracted.
9151 (main): Initialize array of files to delete. Ensure that files are
9152 closed on exit. Make the directory that setup.exe is started from ==
9153 the directory where temporary files are placed. Issue an error if no
9154 files were found to download.
9155 * xsystem.c (xcreate_process): Close the thread handle. Close the
9156 process handle if we waited for it to exit.
9158 Thu Apr 27 09:54:19 2000 Christopher Faylor <cgf@cygnus.com>
9160 * setup.c (main): Change version number output.
9162 Thu Apr 27 09:23:17 2000 Christopher Faylor <cgf@cygnus.com>
9164 * setup.c (tarx): Use full path name to tar executable.
9165 (main): Build full pathname to tar executable. Create /usr/local/etc
9168 Wed Apr 26 22:16:57 2000 Christopher Faylor <cgf@cygnus.com>
9170 * setup.c (findhref): Change method for scanning for href= to choose
9171 the last one on the line. This is still not foolproof and probably
9172 will need to be changed eventually. Don't abort if no "size" field is
9174 (processdirlisting): Fix boolean algebra.
9176 Wed Apr 26 01:10:39 2000 Christopher Faylor <cgf@cygnus.com>
9178 * main.c (tarx): Add some code for future task of unmounting
9179 directories encountered in tar file.
9181 Sat Apr 22 16:37:03 2000 Christopher Faylor <cgf@cygnus.com>
9183 * setup.c (findhref): Decode file size, when appropriate.
9184 (needfile): New function. Returns 1 when file should be
9186 (processdirlisting): Always download if file size does not
9187 match. Prompt when download fails for some reason.
9188 (getdownloadsource): Accomodate findhref argument changes.
9190 Sat Apr 22 15:13:42 2000 Christopher Faylor <cgf@cygnus.com>
9192 Throughout, use global session handle rather than reinitializing for
9193 each connect. Don't pass session as an argument to setup.c functions.
9194 * setup.c (geturl): Only issue "Connecting to.." message when using
9195 http or first time for ftp since subsequent connections will be fast.
9196 (processdirlisting): Allocate space for "N" when user has specified
9197 "N"ever option so that it can be subsequently freed.
9198 (main): Abort if we can't get the list of mirrors.
9200 Thu Apr 20 16:41:42 2000 Christopher Faylor <cgf@cygnus.com>
9202 * setup.c (main): Umount /bin and /lib.
9204 Wed Apr 19 13:34:44 2000 Christopher Faylor <cgf@cygnus.com>
9206 * setup.c (main): Create an empty /var/run/utmp.
9208 Tue Apr 18 19:16:56 2000 Christopher Faylor <cgf@cygnus.com>
9210 * Makefile.in: Add umount to list of files to include in setup.exe.
9211 * setup.c (xumount): New function for unmounting directories.
9212 (main): Unmount /usr.
9213 (mkmount): Unmount "unix directory" before trying to figure out where
9214 to create the directory.
9216 Tue Apr 18 17:28:55 2000 Christopher Faylor <cgf@cygnus.com>
9218 * setup.c (mkmount): Use xcreate_process to start mount process,
9220 (main): Don't do buffering on stdout or prompts won't be displayed
9221 correctly if running in a cygwin shell with CYGWIN=tty.
9223 Tue Apr 18 15:35:19 2000 Christopher Faylor <cgf@cygnus.com>
9225 * setup.c (main): Remove the CYGWIN environment variable before
9226 starting any cygwin programs.
9228 Mon Apr 17 19:20:52 2000 Vadim Egorov <egorovv@mailandnews.com>
9230 * setup.c (geturl): Use alternative method for finding filename part of
9232 (processdirlisting): Accomodate strange output from non-MS ftp proxy.
9233 (downloaddir): Unlink file containing dir listing.
9234 (downloadfrom): Ditto.
9236 Mon Apr 17 00:00:49 2000 Christopher Faylor <cgf@cygnus.com>
9238 * setup.c (main): Disallow running setup.exe from the "root".
9240 Sun Apr 16 18:50:58 2000 Christopher Faylor <cgf@cygnus.com>
9242 Use "warning" function, where appropriate, to output warnings.
9243 * setup.c (warning): New function -- outputs warning to console and log
9245 (tarx): Fix index used to reset file protection.
9246 (main): Open the log file earlier so that more stuff can be sent to it.
9248 Sat Apr 15 20:05:33 2000 Christopher Faylor <cgf@cygnus.com>
9250 * setup.c (processdirlisting): Make "N" option a little less aggressive.
9252 Fri Apr 14 11:11:29 2000 Christopher Faylor <cgf@cygnus.com>
9254 * setup.c (tarx): Wait to after tar has completed to reset protections
9255 or suffer races with tar process.
9257 Thu Apr 13 12:51:19 2000 Christopher Faylor <cgf@cygnus.com>
9259 * Makefile.in: Eliminate duplicate -nostdinc from CFLAGS.
9260 * setup.c (create_uninstall): Create the uninstall .bat file in the
9261 "root" so that we can remove the /bin directory. Add bin\cygwin.bat to
9262 list of files to be deleted. Fix directory detection for determining
9263 when to use 'rmdir'.
9264 (do_start_menu): Add /usr/local/bin to the path.
9265 (main): Add slop to files.array allocation so that we don't have to
9266 worry about reallocating the array when it grows too large when doing
9267 some trivial "pushes". Add /tmp and /usr/local/{bin,lib} to list of
9270 Thu Apr 13 01:59:44 2000 Christopher Faylor <cgf@cygnus.com>
9272 * setup.c (processdirlisting): Fix handling of "A" for "A"lways
9275 Thu Apr 13 01:11:45 2000 Christopher Faylor <cgf@cygnus.com>
9277 * path.c (kill_cygpath): New cleanup function.
9278 (exit_cygpath): New cleanup function.
9279 (cygpath_pipe): New function. Sets up cygpath in the background for
9280 translating filenames.
9281 (pathcvt): Use background cygpath for file translation.
9282 * setup.c (tarx): New function. Called to extract tar files, capture
9283 logging output, and translate it to Windows format.
9284 (recurse_dirs): Use 'tarx' function to extract files.
9285 (create_uninstall): Use file list built up by tarx rather than reading
9287 (mkmount): Add ability to mount root.
9288 (main): Track elapsed install time. Mount root.
9289 * starry.h: Add index field to strarry for tracking of tarx's usage of
9291 * xsystem.c (xcreate_process): Return proces handle when not waiting.
9293 Mon Apr 10 22:44:56 2000 Christopher Faylor <cgf@cygnus.com>
9296 (pathfp): New function. Preliminary work for new -f cygpath
9298 * Makefile.in: Add new file.
9299 (pathcvt): Move to new file.
9303 * setup.c (processdirlisting): Always open file in text mode.
9304 (create_uninstall): Ditto.
9305 (getdownloadsource): Ditto.
9308 Mon Apr 10 20:33:40 2000 Christopher Faylor <cgf@cygnus.com>
9310 * xsystem.c: New file.
9311 * Makefile.in: Accomodate new file.
9312 * setup.c (xsystem): Move to new file.
9313 (recurse_dirs): Accept handle to output log file. Don't use ">"
9314 redirection to trap tar output. Use supplied handle instead.
9315 (create_uninstall): Accept FILE pointer to opened log file. Don't
9316 unlink log file here.
9317 (do_start_menu): Accept FILE pointer to pass to create_uninstall.
9318 (main): Open log file here and pass it to various functions. Unlink
9321 Mon Apr 10 17:15:52 2000 Christopher Faylor <cgf@cygnus.com>
9323 Change occurrences of .usr.bin to .bin throughout.
9324 * setup.c (geturl): Increase number of retries to 20. Let user know
9325 what's going on during long connects.
9326 (processdirlisting): Accept "A"lways and "N"ever as update options.
9327 (create_uninstall): Load cygwin1.dll from the current directory rather
9329 (main): Add some expository text.
9331 Sun Apr 9 20:59:15 2000 Christopher Faylor <cgf@cygnus.com>
9333 * Makefile.in: Change method for compressing cygwin1.dll to avoid
9334 creating a cygwin1.dll in the current directory. Ensure the addition
9335 of -nostdinc to MINGW_CFLAGS.
9337 Sun Apr 9 02:15:47 2000 Christopher Faylor <cgf@cygnus.com>
9339 * Makefile.in: Augment clean target.
9341 Fri Apr 7 17:04:02 Ron Parker <rdparker@sourceware.cygnus.com>
9343 * README: Added info about non-working mingw implementation
9344 * gzip.exe.gz: Replace with a version from the same build as the other
9346 * tar.exe.gz: Replace with a version from the same build as the other
9348 * mount.exe.gz: Add to repository until, mingw can build setup.
9349 * cygpath.exe.gz: ditto
9350 * cygwin1.dll.gz: ditto
9351 * setup.c: Overwrite /bin and /lib mounts. Generate working shortcut
9352 for Win9x. Display only a screenfull of options at a time. Call all
9353 tools with an absolute path.
9354 * setup.dsp: Restore the carriage returns, MS Developer Studio needs
9359 Thu Apr 6 19:15:27 2000 Christopher Faylor <cgf@cygnus.com>
9361 * Makefile.in: Add "-nostdinc" to regular CFLAGS. Add target to grab
9362 cygwin1.dll from ../cygwin subdirectory.
9363 * gzip.exe.gz: Update.
9364 * tar.exe.gz: Update.
9366 Wed Apr 5 10:52:08 2000 Christopher Faylor <cgf@cygnus.com>
9368 * Makefile.in: Use ZLIB variable as a target.
9370 Sat Apr 1 22:49:09 2000 Christopher Faylor <cgf@cygnus.com>
9372 * Makefile.in: Eliminate traces of cygwinisms. Don't link with
9373 libmsvcrt.a. It's unneeded. Build .rc file on the fly from various
9375 * configure.in: Locate correct objcopy.
9376 * configure: Regenerate.
9378 Sat Apr 1 20:48:09 2000 Christopher Faylor <cgf@cygnus.com>
9380 * Makefile.in: New file.
9381 * configure.in: New file.
9382 * configure: New file.
9383 * zlib/Makefile.am: New file.
9384 * zlib/configure.in: New file.
9385 * zlib/aclocal.m4: New file.
9386 * zlib/acinclude.m4: New file.
9387 * zlib/configure: Regenerate from configure.in.
9388 * zlib/Makefile.in: Regenerate from Makefile.am