ChangeLog

   1 2006-10-12  Igor Peshansky  <pechtcha@cs.nyu.edu>
   2
   3         * desktop.cc (make_cygwin_bat,save_icon): Capitalize filename.
   4
   5 2006-08-06  Igor Peshansky  <pechtcha@cs.nyu.edu>
   6
   7         * package_version.cc (packageversion::scan): Catch and handle
   8         validation exception.
   9
  10 2006-08-06  Igor Peshansky  <pechtcha@cs.nyu.edu>
  11
  12         * cygpackage.h (filesize): Remove unused field.
  13         (cygpackage::createInstance): Ditto.
  14         * cygpackage.cc (cygpackage::createInstance): Ditto.
  15         * package_db.cc (packagedb::packagedb): Remove unused variables.
  16         Simplify parsing of installed.db.
  17
  18 2006-08-06  Igor Peshansky  <pechtcha@cs.nyu.edu>
  19
  20         * desktop.cc (DesktopSetupPage::OnInit): Remove stray MessageBox.
  21
  22 2006-05-24  Igor Peshansky  <pechtcha@cs.nyu.edu>
  23
  24         * PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView.
  25         * PickView.h (PickView::DrawIcon): Move from PickPackageLine.
  26         (PickView::icon_dc,PickView::bm_icon): New instance field.
  27         (PickView::rect_icon,PickView::bg_fg_brush): Ditto.
  28         * PickCategoryLine.cc (PickCategoryLine::paint): Use
  29         PickView::DrawIcon() instead of BitBlt().
  30         * PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView.
  31         (PickPackageLine::paint): Use PickView::DrawIcon().
  32         * PickView.cc (PickView::~PickView): Delete GDI objects.
  33         (PickView::init): Create icon drawing context.
  34         (PickView::DrawIcon): New function.  Use system default colors to
  35         draw bitmaps.
  36         (PickView::paint): Set background color instead of using transparent
  37         mode.  Create system-colored brush.
  38
  39 2006-04-25  Brian Dessent  <brian@dessent.net>
  40
  41         * COPYING: New file (GPL).
  42         * Makfile.am (EXTRA_DIST): Add COPYING.
  43
  44 2006-04-17  Max Bowsher  <maxb1@ukf.net>
  45
  46         * String++.cc, String++.h: Finally, it's time for the long-awaited
  47         departure of 'class String' from this world. setup.exe can now
  48         happily claim to follow the sane path of using just one general
  49         purpose string class throughout :-)
  50
  51 2006-04-17  Max Bowsher  <maxb1@ukf.net>
  52
  53         * cygpackage.cc, cygpackage.h, package_version.cc, package_version.h:
  54         Do some String to std::string migration.
  55
  56 2006-04-17  Max Bowsher  <maxb1@ukf.net>
  57
  58         * package_meta.cc, package_meta.h, package_source.cc,
  59         package_source.h: Do some String to std::string migration.
  60         * package_db.cc: Small tweak to assist with the above.
  61
  62 2006-04-17  Max Bowsher  <maxb1@ukf.net>
  63
  64         * PickView.cc, PickView.h, package_db.cc, package_db.h:
  65         Do some String to std::string migration.
  66         * package_meta.h: Change a couple of types to assist with the above.
  67
  68 2006-04-17  Max Bowsher  <maxb1@ukf.net>
  69
  70         * IniDBBuilder.cc, IniDBBuilder.h, IniDBBuilderPackage.cc,
  71         IniDBBuilderPackage.h, PickLine.h, PickPackageLine.cc:
  72         Do some String to std::string migration.
  73
  74 2006-04-16  Max Bowsher  <maxb1@ukf.net>
  75
  76         * FindVisitor.cc, FindVisitor.h, IniParseFindVisitor.cc,
  77         IniParseFindVisitor.h, ScanFindVisitor.cc, ScanFindVisitor.h, find.cc,
  78         find.h, fromcwd.cc, ini.cc, ini.h, iniparse.y, postinstall.cc:
  79         Do some String to std::string migration.
  80
  81 2006-04-16  Max Bowsher  <maxb1@ukf.net>
  82
  83         * IOStreamProvider.h, archive.cc, archive.h, archive_tar.cc,
  84         archive_tar.h, io_stream.cc, io_stream.h, io_stream_cygfile.cc,
  85         io_stream_cygfile.h, io_stream_file.cc, io_stream_file.h:
  86         Do some String to std::string migration.
  87
  88 2006-04-16  Max Bowsher  <maxb1@ukf.net>
  89
  90         * desktop.cc, download.cc, install.cc, mount.cc, mount.h, script.cc,
  91         script.h: Do some String to std::string migration.
  92
  93 2006-04-16  Max Bowsher  <maxb1@ukf.net>
  94
  95         * category.cc: Remove source file that contained no code!
  96         * category.h: Delete, moving the single useful line to...
  97         * package_meta.h: ...here. Remove category.h include.
  98         * choose.cc, package_db.h, package_meta.cc: Remove category.h include.
  99         * Makefile.am: Remove references to removed files.
 100
 101 2006-04-15  Max Bowsher  <maxb1@ukf.net>
 102
 103         * ConnectionSetting.cc, ConnectionSetting.h, Exception.cc,
 104         Exception.h, IniParseFeedback.cc, IniParseFeedback.h, LogFile.cc,
 105         LogFile.h, LogSingleton.h, PackageSpecification.cc,
 106         PackageSpecification.h, SourceSetting.cc, SourceSetting.h,
 107         UserSettings.cc, UserSettings.h, dialog.cc, dialog.h, diskfull.cc,
 108         diskfull.h, filemanip.cc, filemanip.h, inilintmain.cc, localdir.cc,
 109         main.cc, nio-file.cc, nio-http.cc, prereq.cc, prereq.h, proppage.cc,
 110         proppage.h, site.cc, site.h, splash.cc, state.cc, state.h, window.cc,
 111         window.h: Do some String to std::string migration.
 112
 113 2006-04-15  Max Bowsher  <maxb1@ukf.net>
 114
 115         * String++.cc, String++.h
 116         (new_cstr_char_array, format_1000s): Migrate String to std::string.
 117         (casecompare_lt_op, std::string operator+): New.
 118
 119 2006-04-06  Max Bowsher  <maxb1@ukf.net>
 120
 121         * String++.h, String++.cc
 122         (String::replace): Remove - usused.
 123         (String::find): Remove - semantics do not match std::string.
 124
 125         * root.cc (directory_is_rootdir): Switch to std::string.find().
 126         * script.cc (Script::baseName): Rewrite use of String.find().
 127
 128 2006-03-30  Max Bowsher  <maxb1@ukf.net>
 129
 130         * String++.cc (replace): New function to take the place of one form
 131         of String::replace method.
 132         * String++.h (replace): Declare.
 133         (String::replace): Make private.
 134
 135         * desktop.cc (make_cygwin_bat): Use new function.
 136         * filemanip.cc (backslash): Use simple loop in place of
 137         String::replace.
 138         * filemanip.h (backslash): Change signature to use std::string in
 139         place of String.
 140
 141 2006-03-30  Max Bowsher  <maxb1@ukf.net>
 142
 143         * String++.cc, String++.h (casecompare): New function replacing
 144         String.casecompare to increase parity with std::string.
 145         (String::casecompare): Make private.
 146
 147         * ConnectionSetting.cc, IniDBBuilderPackage.cc,
 148         IniParseFindVisitor.cc, LogFile.cc, PackageSpecification.cc,
 149         PickView.cc, SourceSetting.cc, String++.cc, String++.h, fromcwd.cc,
 150         io_stream.cc, mount.cc, package_db.cc, package_source.h,
 151         package_version.cc, prereq.h, script.cc:
 152         Use casecompare in place of String::casecompare.
 153
 154 2006-03-30  Max Bowsher  <maxb1@ukf.net>
 155
 156         * String++.cc, String++.h: Remove String(int) constructor, which
 157         was causing dangerously bizarre implicit conversions, and was a point
 158         of disparity between String and std::string.
 159         (stringify): New function to replace functionality removed above.
 160
 161         * PickView.cc (PickView::init_headers),
 162         archive_tar.cc (archive_tar::next_file_name),
 163         cygpackage.cc (cygpackage::setCanonicalVersion):
 164         Make explicit and call out with a FIXME some bizarre behaviour.
 165
 166         * ScanFindVisitor.cc (ScanFindVisitor::visitFile),
 167         filemanip.cc (base), iniparse.y,
 168         threebar.cc (ThreeBarProgressPage::SetBar2):
 169         Make simple adaptations to the changed API.
 170
 171 2006-03-14  Igor Peshansky  <pechtcha@cs.nyu.edu>
 172
 173         * PickView.cc (PickView::setViewMode): Auto-expand category if
 174         its name starts with a dot.
 175
 176 2006-03-14  Dave Korn  <dave.korn@artimi.com>
 177
 178         * String++.cc (new_cstr_char_array):  Handle null input correctly.
 179
 180 2006-03-10  Christopher Faylor  <cgf@timesys.com>
 181
 182         * res.rc: Update copyright.
 183         (IDS_MIRROR_LST): Use cygwin.com for mirror list, not
 184         sources.redhat.com.
 185         * site.cc (NOSAVE1): Use preferred name of sourceware site.
 186         (NOSAVE2): sourceware.cygnus.com -> sources.redhat.com.
 187         (NOSAVE1_LEN): Use just-defined name to determine length.
 188         (NOSAVE2_LEN): Ditto.
 189         (NOSAVE3_LEN): Ditto.
 190
 191 2006-03-10  Bas van Gompel  <patch-cygsup.buzz@bavag.tmfweb.nl>
 192
 193         * res.rc (IDD_DROPPED): New dialog.
 194         * resource.h (IDD_DROPPED): New dialog-id.
 195         (IDC_DROP_MIRRORS, IDC_DROP_NOWARN): New control-ids.
 196         * site.cc: Add enum for response on dropped mirrors.
 197         (cache_is_usable, cache_needs_writing): New bools.
 198         (cache_warn_urls): New string.
 199         (cached_site-list, dropped_site_list): New SiteLists.
 200         (site_list_type::init, site_list_type::site_list_type): Change to four
 201         parameter form.
 202         (site_list_type::site_list_type, site_list_type::operator=) Copy
 203         servername, area and location.
 204         (load_site_list): New function, broken out of get_site_list.  Support
 205         four-parameter site_list_type.
 206         (get_site_list): Break out load_site_list.  Move reading cache earlier.
 207         Don't write new cache.  Set flags to record cache state.  Load both
 208         all_site_list and cached_site_list.
 209         (SiteSetting::registerSavedSite): Use four-parameter site_list_type.
 210         (drop_proc, check_dropped_mirrors, write_cache_list, save_cache_file):
 211         New functions.
 212         (SitePage::OnNext): Check for dropped mirrors and save cache as
 213         appropriate.
 214         (SitePage::OnMessageCmd): Use four-parameter site_list_type.
 215         * site.h
 216         (site_list_type::init, site_list_type::site_list_type): Change to four
 217         parameter form.
 218         (site_list_type): Add servername, area and location members.
 219
 220 2006-03-09  Igor Peshansky  <pechtcha@cs.nyu.edu>
 221
 222         * script.cc (Script::run): Fix inverted test for abnormal exit.
 223
 224 2006-03-09  Bas van Gompel  <patch-cygsup.buzz@bavag.tmfweb.nl>
 225             Max Bowsher  <maxb1@ukf.net>
 226
 227         Provide indication of site that a file is being downloaded from.
 228
 229         * geturl.cc: Use std::string instead of String throughout.
 230         (init_dialog): Put more information into GUI.
 231         Remove unused 'owner' parameter and change all callers.
 232         (progress): Remove spurious \n characters from GUI.
 233         * geturl.h: Use std::string instead of String throughout.
 234         * res.rc (IDD_INSTATUS): Use SS_ENDELLIPSIS.
 235
 236 2006-03-09  Max Bowsher  <maxb1@ukf.net>
 237
 238         * Makefile.am (EXTRA_DIST): Add tree-minus.bmp and tree-plus.bmp.
 239
 240 2006-01-20  Bryan Thrall  <bryan.thrall@flightsafety.com>
 241
 242         * source.cc (SourcePage::OnActivate): Command line takes precedence
 243         over last user selection.
 244
 245 2005-11-30  Max Bowsher  <maxb1@ukf.net>
 246
 247         * res.rc (IDD_ROOT, IDD_LOCAL_DIR): Rearrange some controls a little,
 248         in response to suggestion from Carl Karsten.
 249
 250 2005-11-30  Max Bowsher  <maxb1@ukf.net>
 251
 252         * site.h, site.cc: Use std::string in preference to String.
 253         (site_list_type::init): Convert some painful raw C string work to
 254         STL std::string work.  Stop totally ignoring the result of this
 255         calculation, implementing the (somewhat weird) sort order for sites
 256         that was apparently indented for ages.
 257
 258 2005-10-14  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 259
 260         * io_stream.cc (url_scheme_not_registered): New macro.
 261         (io_stream::open): Better log message on error.
 262         (io_stream::mkpath_p,io_stream::remove,io_stream::mklink): Ditto.
 263         (io_stream::move,io_stream::exists): Ditto.
 264
 265 2005-10-13  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 266
 267         * site.cc (get_site_list): Default to empty mirror list if
 268         server unavailable and none cached, to allow using preferred
 269         mirrors anyway.
 270
 271 2005-09-29  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 272
 273         * package_db.cc (packagedb::packagedb): Remember missing package
 274         database file.
 275
 276 2005-09-29  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 277
 278         * site.cc (get_site_list): Store mirror list locally.
 279         Use local copy if unable to download.
 280
 281 2005-09-27  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 282
 283         * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
 284         Better log message on error.
 285
 286 2005-09-27  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 287
 288         * script.cc (Script::isAScript): Fix string comparison.
 289
 290 2005-09-27  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 291
 292         * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Reconnect on FTP timeout.
 293
 294 2005-09-11  Masayuki FUJII  <boochang@m4.kcn.ne.jp>
 295
 296         * package_meta.cc (packagemeta::ScanDownloadedFiles): Don't use an
 297         invalid iterator.  Fix whitespace.
 298
 299 2005-09-09  Brian Dessent  <brian@dessent.net>
 300
 301         * CHANGES: Document recent updates.
 302         * choose.cc (ChooserPage::OnInit): Add new tooltip.
 303         * res.rc (IDD_CHOOSE): Remove 'administrative' from description.
 304         (IDS_HIDEOBS_TOOLTIP): Add new string for tooltip.
 305         * resource.h (IDS_HIDEOBS_TOOLTIP): Define.
 306         * window.cc (Window::ActivateTooltips): Fix whitespace.  Set tooltip
 307         delay to 30 seconds.
 308
 309 2005-09-09  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 310
 311         * PickView.cc (PickView::paint): Set background mode to transparent.
 312         * PickCategoryLine.cc (PickCategoryLine::paint): Use bitwise AND to
 313         blit bitmaps.
 314         * PickPackageLine.cc (PickPackageLine::paint): Ditto.
 315
 316 2005-09-01  Brian Dessent  <brian@dessent.net>
 317
 318         * package_meta.cc (packagemeta::uninstall): Remove support for
 319         undocumented and dangerous postremove script.
 320
 321 2005-09-01  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 322
 323         * script.cc (run): Change to return the exit code or negative error.
 324         (Script::run): Ditto.
 325         (try_run_script): Receive both filename and extension and run only
 326         one script.  Also return the exit code.
 327         * script.h (try_run_script): Change signature.
 328         (Script::run): Ditto.
 329         * postinstall.cc (RunScript::operator()): Change to return the exit
 330         code or negative error.
 331         * install.cc (Installer::preremoveOne): Pass extension to
 332         try_run_script().
 333
 334 2005-09-01  Eric Blake  <ebb9@byu.net>
 335
 336         * script.cc (shells): Use /bin/bash, not sh, to allow upgrades to
 337         /bin/sh.
 338
 339 2005-09-01  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
 340
 341         * PickView.h (PickView::size_col): New instance variable.
 342         * PickView.cc (pkg_headers, cat_headers): Add size column.
 343         (PickView::set_headers): Initialize size_col.
 344         (PickView::init_headers): Include width of size column.
 345         * PickPackageLine.cc (PickPackageLine::paint): Handle size_col.
 346         * String++.cc (format_1000s): New function.
 347         * String++.h (format_1000s): Declare new function.
 348
 349 2005-09-01  Brian Dessent  <brian@dessent.net>
 350
 351         * Makefile.am (BASECXXFLAGS): Add -Wno-uninitialized to work around
 352         spurious warnings with gcc 3.4.4.
 353
 354 2005-05-22  Brian Dessent  <brian@dessent.net>
 355
 356         * res.rc (IDD_CHOOSE): Change description to include administrative
 357         packages in addition to obsolete.
 358
 359 2005-05-21  Brian Dessent  <brian@dessent.net>
 360
 361         * prereq.cc: New file.
 362         * prereq.h: Ditto.
 363         * tree-minus.bmp: Ditto.
 364         * tree-plus.bmp: Ditto.
 365         * Makefile.am: Add prereq.cc and prereq.h to build.
 366         * PickCategoryLine.cc (PickCategoryLine::paint): Add new parameter and
 367         refactor.  Use bitmap for '+' and '-' indicators.  Draw package lines
 368         column-wise for better drawing efficiency.
 369         (PickCategoryLine::click): Use previously calculated x value.
 370         * PickCategoryLine.h (PickCategoryLine::paint): Update prototype.  Add
 371         'spin_x' member.
 372         * PickLine.h (PickLine:paint): Update prototype.
 373         * PickPackageLine.cc (PickPackageLine::DrawCheck): Remove.
 374         (PickPackageLine::DrawIcon): New function.
 375         (PickPackageLine::paint): Add parameter.  Refactor completely for more
 376         efficient painting.
 377         * PickPackageLine.h (PickPackageLine::DrawIcon): Add prototype.
 378         (PickPackageLine::paint): Update prototype.
 379         (PickPackageLine::DrawCheck): Remove.
 380         * PickView.cc (pkg_headers): Remove unused 'slen' field, add new
 381         'needs_clip' field to signify if clipping is necessary for this column.
 382         (PickView::note_width): Fold long line.  Refactor slightly for
 383         simplicity.
 384         (PickView::set_view_mode): Remove.
 385         (PickView::cycleViewMode): New function.
 386         (PickView::setViewMode): Refactor completely.  Incorporate functionality
 387         of clear_view() here instead.  Simplify package selection into a single
 388         'for' loop rather than repeating code for each type.
 389         (isObsolete): New function, with second overloaded version.
 390         (PickView::setObsolete): New function.
 391         (PickView::insert_pkg): Do not show obsolete packages.  Move
 392         declaration of 'db' lower.  Fix whitespace.
 393         (PickView::insert_category): Do not show obsolete packages.
 394         (PickView::clear_view): Remove.  Moved logic into 'setViewMode'.
 395         (PickView::scroll): Add additional parameter 'howmany' with default
 396         value of 1.  Scroll by 'howmany' lines for SB_LINEDOWN and SB_LINEUP.
 397         (NUM_CATEGORY_COL_WIDTH): Define.
 398         (PickView::init_headers): Fix whitespace.  Add comments.  Ignore
 399         obsolete packages in width calculations.  Add functionality to size
 400         'Category' column so that at least NUM_CATEGORY_COL_WIDTH categories
 401         are displayed for every package.  Ensure that 'new_col' takes into
 402         account all possible labels.
 403         (PickView::PickView): Initialize showObsolete to false.
 404         (PickView::init): Remove unused bitmap bm_rtarrow.  Add new bitmaps
 405         bm_treeplus and bm_treeminus.  Use a macro for better readability.
 406         Fix whitespace formatting.  Remove header computation from here, call
 407         refresh() instead.
 408         (PickView::registerWindowClass): Remove unnecessary background brush.
 409         (PickView::WindowProc): Add support for WM_MOUSEWHEEL message
 410         processing.  Fix indentation.  Reformat for readability.
 411         (PickView::paint): Get the update region before calling BeginPaint.
 412         Fill the update region with the default colors.  Do not do clipping
 413         here.  Pass update region to the PickLine paint function instead.
 414         Free the update region when finished.
 415         (PickView::Create): Fix indentation.
 416         (PickView::defaultTrust): Ditto.
 417         (PickView::refresh): Add column recalculation logic here.
 418         * PickView.h: Fix indentation.
 419         (RTARROW_WIDTH): Remove unused define.
 420         (NEW_COL_SIZE_SLOP): Ditto.
 421         (TREE_INDENT): Define.
 422         (PickView::get_view_mode): Remove.
 423         (PickView::set_view_mode): Rename to setViewMode for consistency.
 424         (PickView::cycleViewMode): Add new function.
 425         (PickView::setObsolete): Ditto.
 426         (PickView::clear_view): Remove.
 427         (PickView::bm_treeplus): Define new member.
 428         (PickView::bm_treeminus): Ditto.
 429         (PickView::scroll): Add parameter.
 430         (PickView::Header::slen): Remove unused member.
 431         (PickView::Header::needs_clip): Define new member.
 432         (PickView::showObsolete): Ditto.
 433         (isObsolete): Add prototype, and for overloaded version as well.
 434         * choose.cc: Add include.
 435         (ChooserControlsInfo): Allow new checkbox to be resized.
 436         (ChooserPage::OnInit): Start dialog with 'Hide obsolete' checked.
 437         (ChooserPage::OnNext): Call the dependency checker, act accordingly.
 438         (ChooserPage::changeTrust): Notify dependency checker of current trust
 439         level when it changes.
 440         (ChooserPage::OnMessageCmd): Just call cycleViewMode instead when
 441         changing the view.  Update the chooser when the user toggles the
 442         'hide obsolete' checkbox.
 443         (ChooserPage::OnMouseWheel): New function.  Pass mouse wheel message
 444         on to chooser.
 445         * choose.h (OnMouseWheel): Add prototype.
 446         * main.cc: Add include.
 447         (main): Define and initialize the PrereqPage object.  Add it into
 448         the property sheet list.
 449         * PropPage.cc (PropertyPage::DialogProc): Add support for WM_MOUSEWHEEL
 450         message processing in derived classes.
 451         (PropertyPage::OnMouseWheel): New function.
 452         * PropPage.h (PropertyPage::OnMouseWheel): Add prototype.
 453         * res.rc (IDD_LOCAL_DIR): Shorten edit box so that pushbutton is not
 454         crowded.
 455         (IDD_SITE): Provide static text with an ID so that it can be resized
 456         properly.  Move pushbutton slightly to right so that it doesn't crowd
 457         edit box.
 458         (IDD_SPLASH): Change copyright displayed on spash screen to be generic
 459         since the actual list of contributors is long.
 460         (IDD_CHOOSE): Add checkbox.  Resize other controls to accomodate.
 461         (IDD_PREREQ): New dialog.
 462         (SPIN): Delete duplicated bitmap resource.
 463         (IDB_RTARROW): Remove unused bitmap resource.
 464         (IDB_TREE_PLUS): Add.
 465         (IDB_TREE_MINUS): Ditto.
 466         (IDS_TRUSTPREV_TOOLTIP): Revise wording to be more concise.
 467         (IDS_TRUSTCURR_TOOLTIP): Ditto.
 468         (IDS_TRUSTEXP_TOOLTIP): Ditto.
 469         (IDS_VIEWBUTTON_TOOLTIP): Ditto.
 470         * resource.h (IDD_PREREQ): Define.
 471         (IDB_RTARROW): Remove.
 472         (IDB_TREE_PLUS): Add, and renumber.
 473         (IDB_TREE_MINUS): Ditto.
 474         (IDC_SITE_USERURL): Define.
 475         (IDC_CHOOSE_HIDE): Ditto.
 476         (IDC_PREREQ_TEXT): Ditto.
 477         (IDC_PREREQ_EDIT): Ditto.
 478         (IDC_PREREQ_CHECK): Ditto.
 479         * site.cc (SiteControlsInfo): Ensure that 'User URL' static text is
 480         properly resized.
 481
 482 2005-05-14  Max Bowsher  <maxb@ukf.net>
 483
 484         "Type" field of packageversions was not even being filled in. Fix.
 485
 486         * cygpackage.h, cygpackage.cc (cygpackage::createInstance):
 487         Make "type" a mandatory parameter of the constructor.
 488         * IniDBBuilderPackage.cc: Adjust callers.
 489
 490 2005-05-14  Bas van Gompel  <patch-cygsup.buzz@bavag.tmfweb.nl>
 491
 492         Fix behaviour of hardlinks in source packages.
 493
 494         * archive.cc (archive::extract_file):
 495         Use prefixPath for link target on hardlinks.
 496
 497 2005-05-14  Max Bowsher  <maxb@ukf.net>
 498
 499         Hopefully, solve the "preremove DLL dependency" bug, by running all
 500         preremove scripts before actually removing any files.
 501
 502         * install.cc
 503         (Installer::preremoveOne): New method. Run preremove scripts here.
 504         (Installer::replaceOne): Remove method.
 505         (num_replacements): Remove variable.
 506         (do_install_thread): Significantly rewrite.
 507         * package_meta.cc (packagemeta::uninstall):
 508         Do not run preremove script here.
 509
 510 2005-05-14  Max Bowsher  <maxb@ukf.net>
 511
 512         * download.cc (do_download_thread):
 513         Do not use packageversion::changeRequested().
 514         * package_version.cc (packageversion::Type):
 515         Implement declared but previously unimplemented method.
 516         (packageversion::changeRequested, _packageversion::changeRequested):
 517         Remove.
 518         * package_version.h
 519         (packageversion::changeRequested, _packageversion::changeRequested):
 520         Remove.
 521         * install.cc (Installer::replaceOne): Simplify, return void, not int.
 522         (installOneSource): Rename to...
 523         (installOne): ...this. Change arguments and return type. Refactor.
 524         (install_one): Remove.
 525         (do_install_thread): Tidying up.
 526
 527 2005-05-07  Max Bowsher  <maxb@ukf.net>
 528
 529         * download.cc (validateCachedPackage): Remove all MD5 checking code.
 530         It is not acceptable to check MD5 sums as part of simply answering
 531         whether a package exists in the local cache or not. It is too slow.
 532         MD5 sums always have been - and will continue to be - checked at
 533         install time.
 534         (NoMD5Option): Remove this option, as the code it controls has been
 535         removed.
 536
 537 2005-05-07  Max Bowsher  <maxb@ukf.net>
 538
 539         * install.cc (md5_one): Make the MD5 checking done at install time
 540         display a progess GUI, as the MD5 checking done at other times does.
 541
 542 2005-05-07  Max Bowsher  <maxb@ukf.net>
 543
 544         * resource.h, res.rc: Followup to recent de-MSVC-ification of
 545         resource.h, by removing a lot from res.rc, and the last few bits
 546         from resource.h.
 547
 548 2005-05-05  Brian Dessent  <brian@dessent.net>
 549
 550         * choose.cc (ChooserPage::OnInit): Initialize tooltips for this
 551         dialog.
 552
 553         * proppage.h (PropertyPage::makeClickable): Update prototype to
 554         reflect same argument name as function.
 555
 556         * proppage.cc (PropertyPage::DialogProc): Remove redundant 'break'
 557         statements that follow 'return's.  Add missing braces to case
 558         statements.  Call handler for TTN_GETDISPINFO.
 559
 560         * res.rc (IDS_TRUSTKEEP_TOOLTIP): Add new STRINGTABLE entry for
 561         tooltip text.
 562         (IDS_TRUSTPREV_TOOLTIP): Ditto.
 563         (IDS_TRUSTCURR_TOOLTIP): Ditto.
 564         (IDS_TRUSTEXP_TOOLTIP): Ditto.
 565         (IDS_TRUSTPREV_TOOLTIP): Ditto.
 566         (IDS_VIEWBUTTON_TOOLTIP): Ditto.
 567
 568         * resource.h: Likewise, add identifiers for tooltip resources.
 569
 570         * window.h: Add includes.
 571         (Window::TooltipHandle): Add new private data structure.
 572         (Window::TooltipStrings): Ditto.
 573         (Window::ActivateTooltips): Define new function to support tooltip
 574         functionality.
 575         (Window::SetTooltipState): Ditto.
 576         (Window::AddTooltip): Ditto.
 577         (Window::TooltipNotificationHandler): Ditto.
 578
 579         * window.cc (Window::Window): Initialize handle to NULL.
 580         (Window::~Window): Call DestroyWindow on tooltip control if it was
 581         activated.
 582         (Window::ActivateTooltips): New function to activate the tooltip
 583         control.
 584         (Window::SetTooltipState): New function to allow toggling of
 585         tooltips.
 586         (Window::AddTooltip): New function that adds a tooltip to a given
 587         control in a given window.  Also implement overloaded versions that
 588         provide simpler interface and the ability to use a string resource.
 589         (Window::TooltipNotificationHandler): New function to handle
 590         TTN_GETDISPINFO notification messages.
 591
 592 2005-05-05  Brian Dessent  <brian@dessent.net>
 593
 594         * resource.h: Reorganize.  Group by type, and give each its own
 595         range of IDs.  Regenerate IDs accordingly.
 596         (IDD_CHOOSER): Remove obsolete and unused symbol.
 597
 598 2005-05-05  Brian Dessent  <brian@dessent.net>
 599
 600         * root.h (class RootPage): Add missing virtual to OnMessageCmd.
 601
 602 2005-05-05  Brian Dessent  <brian@dessent.net>
 603
 604         * root.cc (dialog_cmd): Remove.  Use OnMessageCmd instead.
 605         (RootPage::Create): Accomodate above change.
 606
 607         * root.h (class RootPage): Add prototype for OnMessageCmd.
 608
 609         * res.rc (IDD_ROOT): Fix broken button groups.  Correct the order of
 610         the controls and use of WS_GROUP so that the radio buttons act
 611         correctly.
 612
 613 2005-05-05  Max Bowsher  <maxb@ukf.net>
 614
 615         Bulk rename of String++ member cstr_oneuse () to c_str () for
 616         similarity to std::string.
 617
 618         * Exception.cc
 619         * IniDBBuilderPackage.cc
 620         * IniParseFindVisitor.cc
 621         * LogFile.cc
 622         * PickCategoryLine.cc
 623         * PickPackageLine.cc
 624         * PickView.cc
 625         * String++.cc
 626         * String++.h
 627         * archive.cc
 628         * cygpackage.cc
 629         * desktop.cc
 630         * dialog.cc
 631         * diskfull.cc
 632         * download.cc
 633         * filemanip.cc
 634         * find.cc
 635         * geturl.cc
 636         * ini.cc
 637         * install.cc
 638         * io_stream.cc
 639         * io_stream_cygfile.cc
 640         * io_stream_file.cc
 641         * localdir.cc
 642         * mount.cc
 643         * nio-http.cc
 644         * package_db.cc
 645         * package_meta.cc
 646         * package_source.h
 647         * postinstall.cc
 648         * proppage.cc
 649         * root.cc
 650         * script.cc
 651         * site.cc
 652         * splash.cc
 653         * threebar.cc
 654         * window.cc
 655
 656 2005-05-05  Max Bowsher  <maxb@ukf.net>
 657
 658         Some String++ refactoring, setting out in the general direction of
 659         eventually just using the STL std::string, not our own class.
 660
 661         * String++.cc (String::cstr, String::cstr () const): Remove.
 662         (new_cstr_char_array): New function.
 663         * String++.h: Sync with above.
 664         Remove irrelevant "class io_stream;" declaration.
 665
 666         * cygpackage.h: Add "class io_stream;" declaration, now no longer
 667         being supplied by side-effect.
 668
 669         * filemanip.cc: Remove unneeded includes, add "using namespace std;".
 670         (parse_filename): Exchange some awkward pointer manipulation for
 671         std::string usage. Use new_cstr_char_array ().
 672         * filemanip.h: Sync with above.
 673         (fileparse): Improve style of declaration.
 674
 675         * io_stream_cygfile.cc (io_stream_cygfile::normalise):
 676         Use new_cstr_char_array ().
 677         * site.cc (site_list_type::init, get_site_list): Ditto.
 678
 679 2005-05-05  Brian Dessent  <brian@dessent.net>
 680
 681         * ControlAdjuster.h (enum ControlPosition): Declare new resizing
 682         methods CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, and their
 683         TOP/BOTTOM aliases.
 684
 685         * ControlAdjuster.cc (ControlAdjuster::ControlInfo::adjust):
 686         Implement CP_STRETCH_LEFTHALF and CP_STRETCH_RIGHTHALF, which are
 687         designed to resize elements in a two-column layout.
 688
 689         * localdir.h (class LocalDirPage): Remove constructor implementation
 690         from here...
 691
 692         * localdir.cc (LocalDirPage::LocalDirPage): ...to here, and call
 693         AddControlsInfo on initialization.
 694         (static LocaldirControlsInfo): Add.  Define sizing rules for dialog
 695         elements.
 696
 697         * proppage.h: Add includes.
 698         (PropertyPage::ClickableURL):
 699         Declare new storage type for internal use by class.
 700         (PropertyPage::urls): Likewise.
 701         (PropertyPage::urlWinProc): Add declaration.
 702         (PropertyPage::makeClickable): Likewise.
 703
 704         * proppage.cc: Add includes.
 705         (PropertyPage::DialogProc): Implement handler for WM_CTLCOLORSTATIC
 706         message.  Supports static controls that have been turned into
 707         clickable hyperlinks.
 708         (static PropertyPage::urls): Declare.
 709         (PropertyPage::makeClickable): Implement new member function that
 710         provides user interface for making text into clickable URLs.
 711         (PropertyPage::urlWinProc): Implement new private member function used
 712         as a windowproc for subclassing a static control.
 713
 714         * resource.h (IDC_SPLASH_URL, IDC_FILEMODES_LINK, IDC_ROOTDIR_GRP,
 715         IDC_INSTALLFOR_GRP, IDC_ALLUSERS_TEXT, IDC_JUSTME_TEXT, IDC_MODE_GRP,
 716         IDC_MODE_TEXT, IDC_MODE_BIN, IDC_LOCALDIR_GRP, IDC_SPLASH_TEXT,
 717         IDC_SPLASH_ICON, IDC_SPLASH_COPYR): Add. Replaces anonymous
 718         IDC_STATIC ids, so that controls can be referenced by the resizer.
 719
 720         * res.rc (IDD_LOCAL_DIR): Rearrange controls to match top-down order
 721         in the dialog.  Fold long lines.  Replace anonymous IDC_STATIC ids.
 722         (IDD_ROOT): Reorder in same manner.  Replace anonymous IDC_STATIC ids.
 723         Add descriptive text of each option, and hyperlink for more
 724         information.  Mark suggested choice as "(RECOMMENDED)".  Swap order of
 725         'unix'/'dos' radio buttons so that recommended choice is first in both
 726         columns.
 727         (IDD_SPLASH): Reorder elements to match top-down order of dialog, fold
 728         long lines. Add descriptive paragraph, remove anonymous ids.  Update
 729         copyright text, replace sources.redhat.com with cygwin.com.
 730
 731         * root.h (class RootPage): Remove constructor implementation from
 732         here...
 733
 734         * root.cc: ...to here, and call AddControlInfo.
 735         (static RootControlsInfo): Add.  Populate with resizing data.
 736         (RootPage::OnInit): Make text a clickable hyperlink.
 737
 738         * splash.h (class SplashPage): Likewise, move constructor from
 739         here...
 740
 741         * splash.cc: ...to here.  Call AddControlInfo.
 742         (static SplashControlsInfo): Add and populate.
 743         (SplashPage::Create): Make link on splash page a clickable hyperlink.
 744
 745         * window.h: Add include.
 746         (class Window): Store allocated fonts with a vector instead of fixed
 747         array.  Change indentation of setParent to be consistent.
 748
 749         * window.cc (Window::Window): Remove FontCounter.
 750         (Window::~Window): Likewise.  Iterate over vector of fonts instead.
 751         (Window::SetDlgItemFont): Use vector.
 752
 753 2005-05-05  Max Bowsher  <maxb@ukf.net>
 754
 755         * Makefile.am (EXTRA_DIST, inilint_SOURCES):
 756         Sync with several recent changes.
 757
 758 2005-05-05  Brian Dessent  <brian@dessent.net>
 759
 760         * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Include section
 761         comment.
 762
 763 2005-05-05  Brian Dessent  <brian@dessent.net>
 764
 765         * res.rc: (IDC_CHOOSE): Widen 'view' button by 6px horizontally and
 766         4px vertically.  Adjust other controls to accomodate.
 767         (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that manifest is
 768         included in the binary.
 769
 770         * setup.exe.manifest: New file.  Results in common controls with
 771         themed appearance on modern versions of Windows.
 772
 773 2005-05-05  Brian Dessent  <brian@dessent.net>
 774
 775         * main.cc (WinMain): Change conditional to avoid spurious error
 776         message on success.  Include reason for failure in log message.
 777
 778 2005-05-04  Max Bowsher  <maxb@ukf.net>
 779
 780         * state.cc, state.h (net_method, net_proxy_host, net_proxy_port,)
 781         (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
 782         Inet_ftp_user, net_ftp_passwd):
 783         Move these global variables to be static variables of the NetIO class.
 784
 785         * netio.h, netio.cc (net_method, net_proxy_host, net_proxy_port,)
 786         (net_user, net_passwd, net_proxy_user, net_proxy_passwd,)
 787         net_ftp_user, net_ftp_passwd):
 788         As above.
 789
 790         * ConnectionSetting.cc, net.cc:
 791         Change include, refer to variables in new location.
 792
 793 2005-05-04  Max Bowsher  <maxb@ukf.net>
 794
 795         * PickLine.cc: Remove file - redundant.
 796         * Makefile.am (setup_SOURCES): Adjust.
 797
 798 2005-05-04  Max Bowsher  <maxb@ukf.net>
 799
 800         * package_version.h (packageversion::set_requirements):
 801         Remove deftrust argument default value.
 802
 803 2005-05-04  Max Bowsher  <maxb@ukf.net>
 804
 805         * package_version.cc (DependencyProcessor): Remove trivial class.
 806         (select, processOneDependency): Do not use DependencyProcessor, just
 807         pass parameters normally.
 808
 809 2005-05-04  Brian Dessent  <brian@dessent.net>
 810
 811         Fix bug #820: Clicking Curr, etc., causes some dependencies to not
 812         be installed.
 813
 814         * choose.cc (ChooserPage::changeTrust):
 815         Add a missing "packagedb.markUnVisited ()".
 816
 817 2005-05-03  Max Bowsher  <maxb@ukf.net>
 818
 819         * PickCategoryLine.cc (PickCategoryLine::click):
 820         * PickPackageLine.cc (PickPackageLine::click):
 821         Abandon use of trivial packagemeta::PrepareForVisit() wrapper.
 822
 823         * package_meta.h (packagemeta::PrepareForVisit): Remove.
 824         * package_meta.cc (packagemeta::PrepareForVisit): Remove.
 825
 826 2005-05-03  Max Bowsher  <maxb@ukf.net>
 827
 828         * choose.h (ChooserPage::ifChecked): Remove.
 829         (ChooserPage::changeTrust): Convert from template to ordinary function.
 830         * choose.cc (ChooserPage::changeTrust): As above, plus avoid the use
 831         of custom class SetRequirement, when bind2nd(mem_fun(...),...) can
 832         achieve the same effect.
 833         * package_meta.h (SetRequirement): Remove, now unused.
 834
 835 2005-05-03  Max Bowsher  <maxb@ukf.net>
 836
 837         * package_meta.h (packagemeta::set_requirements):
 838         Remove default argument which seems inappropriate.
 839         * PickPackageLine.cc (PickPackageLine::click):
 840         Make an argument explicit, and not that it seems like the wrong value.
 841
 842 2005-05-03  Brian Dessent  <brian@dessent.net>
 843
 844         Fix part of bug #853 - proxy port not remembered.
 845
 846         * net.cc (doing_loading): New static boolean.
 847         (load_dialog): Use the boolean to prevent save_dialog() from taking
 848         action due to field changes due to initialization.
 849         (save_dialog): Check the boolean and respond appropriately.
 850
 851 2005-04-19  Max Bowsher  <maxb@ukf.net>
 852
 853         * postinstall.cc (RunFindVisitor::visitFile): Fix crash on
 854         encountering a postinstall script with a name of 4 characters or less.
 855         Bug introduced on 2004-12-25.
 856
 857 2005-04-05  Max Bowsher  <maxb@ukf.net>
 858
 859         The Big Cleanup: Phase "rfc1738"
 860
 861         * rfc1738.cc, rfc1738.h: Delete.
 862         * csu_util/rfc1738.cc: Reimport latest version from upstream source.
 863         Make thread-safe. Rewrite C++ wrapper in terms of std::string.
 864         Document the divergences from the upstream source.
 865         * csu_util/rfc1738.h: Recreate for the std::string version of the
 866         C++ wrapper.
 867
 868         * Makefile.am (setup_SOURCES): Sync with added/removed files.
 869         * IniParseFindVisitor.cc: Modify #includes.
 870         (IniParseFindVisitor::visitFile): Change function name, as the new
 871         C++ wrapper does not contain an irregularity that the old one did.
 872         * download.cc: Modify #includes.
 873         * ini.cc: Modify #includes.
 874
 875 2005-04-05  Max Bowsher  <maxb@ukf.net>
 876
 877         Remove setup's internal compression libraries, instead relying on the
 878         mingw-foo packages which have been part of the Cygwin net distribution
 879         for some time now.  At the same time, reorganize the README file to
 880         inform about the change, and make some additional tidy-ups there whilst
 881         working there.
 882
 883         * GUIDELINES: Remove, contents transferred to README.
 884         * README: Add build instructions. Delete unconfirmed and fixed bugs
 885           sections. Incorporate the former contents of GUIDELINES.
 886
 887         * bz2lib/: Remove.
 888         * zlib/: Remove.
 889         * Makefile.am (DIST_SUBDIRS, SUBDIRS):
 890         * configure.in: Remove AC_CONFIG_SUBDIRS for removed subdirs.
 891         * compress_bz.h: Remove complex _WIN32 preprocessor conditional.
 892         * compress_gz.h: Fix #include file name.
 893         * archive_tar_file.cc: Remove unused #include.
 894         * install.cc: Remove unused #include.
 895
 896 2005-01-27  Max Bowsher  <maxb@ukf.net>
 897
 898         Set CYGWIN=nontsec, for postinstall scripts.
 899
 900         * main.cc (main): putenv("CYGWIN=nontsec").
 901
 902 2005-01-27  Bas van Gompel  <patch-cygsup.buzz@bavag.tmfweb.nl>
 903
 904         Fix corrupt display of ini parse percentage in log file.
 905
 906         * ini.cc (GuiParseFeedback): Use a sensible data type for lastpct.
 907
 908 2004-12-29  Max Bowsher  <maxb@ukf.net>
 909
 910         * site.cc (get_site_list): Filter the incoming mirrors list to contain
 911         only URL schemes that we can read.
 912
 913 2004-12-28  Max Bowsher  <maxb@ukf.net>
 914
 915         The Big Cleanup: Phase "hash"
 916
 917         * hash.cc, hash.h: Delete.
 918         * Makefile.am (setup_SOURCES): Sync with deleted files.
 919
 920         * package_mets: Modify includes.
 921         (standard_dirs): Remove.
 922         (hash::add_subdirs): Remove.
 923         (packagemeta::uninstall): Re-implement using STL set instead of
 924         homebrew hash.
 925
 926 2004-12-28  Max Bowsher  <maxb@ukf.net>
 927
 928         * String++.h (operator std::string): Take care to never do
 929         std::string((char*)NULL) - it causes a hang!
 930
 931 2004-12-27  Max Bowsher  <maxb@ukf.net>
 932
 933         The Big Cleanup: Phase "log"
 934
 935         * log.cc, log.h: Delete old C-style compatibility wrapper around the
 936         logging subsystem.
 937         * Makefile.am (setup_SOURCES): Sync with deleted files.
 938
 939         * AntiVirus.cc, archive_tar_file.cc, ini.cc, install.cc,
 940         * io_stream_cygfile.cc, localdir.cc, msg.cc, net.cc, netio.cc,
 941         * netio.h, nio-ftp.cc, nio-ftp.h, root.cc, source.cc:
 942         Throughout, refine includes, and update code using the old
 943         compatibility wrapper to C++ streams style code.
 944
 945 2004-12-27  Max Bowsher  <maxb@ukf.net>
 946
 947         * compress.cc: Refine includes. Remove placeholder function
 948         definitions. Make destructor an empty function.
 949         * compress.h: Refine includes. Make placeholder functions pure
 950         virtual. Add missing const on buffer argument to write function,
 951         to match derived classes.
 952         * compress_bz.cc, compress_gz.cc: Refine includes. Throw exception,
 953         rather than logging and returning an error, when an unimplemented
 954         function is called.
 955         * compress_bz.h, compress_gz.h: Refine includes.
 956
 957 2004-12-26  Max Bowsher  <maxb@ukf.net>
 958
 959         The Big Cleanup: Phase "version"
 960
 961         * String++.h (operator std::string): Add.
 962         * desktop.cc, fromcwd.cc: Remove irrelevant include.
 963
 964         * version.cc, version.h: Delete, replacing all functionality in new
 965         files.
 966
 967         * setup_version.h: Add, taking over declaration of generated version
 968         symbol functionality.
 969
 970         * Makefile.am (setup_SOURCES): Sync with new/deleted files.
 971         (setup_version.c): Rename the symbol 'version' to 'setup_version'.
 972         * main.cc: Modify includes.
 973         (main): Adapt to setup_version rename.
 974         * splash.cc: Modify includes.
 975         (SplashPage::OnInit): Adapt to setup_version rename.
 976
 977         * csu_util/version_compare.cc, csu_util/version_compare.h: Add,
 978         containing a completely rewritten replacement for canonical_version().
 979
 980         * IniDBBuilderPackage.cc: Modify includes.
 981         (IniDBBuilderPackage::buildVersion): Use new version_compare API.
 982         * ini.cc: Modify includes.
 983         (setup_version): Rename...
 984         (ini_setup_version): ...to this.
 985         (do_local_ini, do_remote_ini): Adapt to above change.
 986         (do_ini_thread): Adapt to above change. Use new version_compare API.
 987
 988 2004-12-25  Max Bowsher  <maxb@ukf.net>
 989
 990         * install.cc (Installer::installOneSource): Remove a stray "break;"
 991         left over from the switch-case -> if-else conversion in the previous
 992         change.
 993
 994 2004-12-25  Max Bowsher  <maxb@ukf.net>
 995
 996         The Big Cleanup: Phase "win32"
 997
 998         * win32.h: Major overhaul. Document why we use _WIN32_IE. Move out
 999         fragment dealing with alloca() to the single file in which it is used.
1000         Remove fragment dealing with _MAX_PATH, and convert all uses of it
1001         elsewhere to MAX_PATH. Remove random include of <stdarg.h>. Remove
1002         NOCOMATTRIBUTE, as setup contains no code which it affects. Remove
1003         includes of <wininet.h> and <windowsx.h> - see later in this log.
1004         (IsWindowsNT): New inline function, a much simpler implementation of
1005         Win32::OS().
1006
1007         * win32.cc: Delete.
1008
1009         * Makefile.am (setup_SOURCES): Remove "win32.cc".
1010
1011         * AntiVirus.cc (detect), PickPackageLine.cc (PickPackageLine::paint),
1012         * install.c (Installer::installOneSource):
1013         Use IsWindowsNT(), not Win32::OS().
1014         * main.cc (main): Use IsWindowsNT(), not locally defined iswinnt.
1015
1016         * PickView.cc (PickView::WindowProc), netio.cc (auth_proc),
1017         * proppage.cc (PropertyPage::DialogProc):
1018         Avoid using obfuscating macros from <windowsx.h>.
1019
1020         * archive.cc: Include or #define alloca() in the only file in which
1021         it is used.
1022
1023         * nio-ie5.h: Include <wininet.h> here, where it is actually needed,
1024         rather than in "win32.h" which is included almost everywhere.
1025
1026         * archive_tar.cc, archive_tar.h, cygpackage.cc, cygpackage.h,
1027         * desktop.cc, find.cc, install.cc, main.cc, mklink2.c, mount.cc,
1028         * script.cc: Use MAX_PATH, not _MAX_PATH.
1029
1030 2004-12-25  Max Bowsher  <maxb@ukf.net>
1031
1032         Remove some overcomplications.
1033
1034         * Makefile.am (setup_SOURCES): Remove FilterVisitor.{cc,h}.
1035         * FilterVisitor.cc, FilterVisitor.h: Delete.
1036         * String++.cc (strmatch, String::matches): Remove.
1037         * String++.h (String::matches): Remove.
1038         * postinstall.cc: Do not include "FilterVisitor.h".
1039         (RunFindVisitor): Exclude items with the extension ".done".
1040         (do_postinstall_thread): Remove overcomplicated exclusion of items
1041         with the extension ".done".
1042
1043 2004-12-24  Max Bowsher  <maxb@ukf.net>
1044
1045         * String++.cc, String++.h: Remove unused and incomplete code.
1046         * LogFile.cc (LogFile::log_save): Don't leak memory.
1047         * filemanip.cc, geturl.cc, root.cc, version.cc:
1048         Don't pointlessly create temporary copies strings.
1049
1050 2004-12-23  Max Bowsher  <maxb@ukf.net>
1051
1052         * choose.cc (ChooserPage::OnNext): Relegate some overly verbose
1053         logging to an #ifdef DEBUG section.
1054         * geturl.h (dismiss_url_status_dialog): Remove stale function
1055         declaration, for which there is no definition.
1056         * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile):
1057         Motivated by the recent unexplained hang bug, add some extra logging.
1058
1059 2004-11-22  Max Bowsher  <maxb@ukf.net>
1060
1061         * MD5++.cc, MD5++.h: Remove this class.
1062         * csu_util/MD5Sum.cc, csu_util/MD5Sum.h: New more complete MD5 class.
1063         * Makefile.am (setup_SOURCES): Adjust to new files.
1064         * download.cc (validateCachedPackage): Simplify, using the new class.
1065         * install.cc (md5_one): Ditto.
1066         * package_source.h (packagesource::md5): Change to be an object of the
1067         new class.
1068
1069 2004-11-22  Max Bowsher  <maxb@ukf.net>
1070
1071         * main.cc (main): Fix bug in one of the 2004-11-19 commits.
1072         Avoid referring to the theLog pointer before it is set.
1073
1074 2004-11-20  Max Bowsher  <maxb@ukf.net>
1075
1076         * res.rc (IDD_SOURCE): Clarify the radio-button option descriptions.
1077         Re-layout the radio buttons.
1078
1079 2004-11-20  Max Bowsher  <maxb@ukf.net>
1080
1081         Repair the broken detection of wrongly-sized package files.
1082
1083         * download.cc (validateCachedPackage): Make static, since not used
1084         elsewhere. Improve logging. Migrate file-size tests to here, alongside
1085         the MD5 tests.
1086         (check_for_cached): Remove broken testing of file-size, now covered by
1087         the above. Code cleanups.
1088
1089 2004-11-19  Max Bowsher  <maxb@ukf.net>
1090
1091         * package_version.cc (dumpAndList): Make dependencies much more
1092         readable in full log output.
1093
1094 2004-11-19  Max Bowsher  <maxb@ukf.net>
1095
1096         * proppage.cc (PropertyPage::DialogProc): Wrap in a TOPLEVEL_CATCH
1097         block, since allowing exceptions to unwind into the guts of Windows is
1098         quite disasterous.
1099
1100 2004-11-19  Max Bowsher  <maxb@ukf.net>
1101
1102         * main.cc (main): Move option parsing code earlier - it must execute
1103         before any significant object creations, which might test options in
1104         their initialization.
1105
1106 2004-11-19  Max Bowsher  <maxb@ukf.net>
1107
1108         * main.cc (main): Remove some junk code - either commented out, or
1109         contained within unreachable preprocessor conditional sections.
1110
1111 2004-11-19  Max Bowsher  <maxb@ukf.net>
1112
1113         * install.cc (Installer::installOneSource): Avoid leaking the open
1114         file handles of every tarball that is installed.
1115
1116 2004-11-19  Max Bowsher  <maxb@ukf.net>
1117
1118         * package_source.h (packagesource::Canonical, packagesource::Base)
1119         (packagesource::Filename): Add "const" specification to accessor
1120         methods.
1121
1122 2004-11-18  Max Bowsher  <maxb@ukf.net>
1123
1124         * archive.h (archive::~archive): Define a pure virtual destructor to
1125         enforce the abstract nature of this class.
1126         * archive.cc (archive::~archive): Pure virtual destructors require an
1127         implementation! Add one.
1128         * io_stream.h (io_stream::destroyed): Remove this severely
1129         brain-damaged implementation of a weakly-enforced abstract class.
1130         The pure virtual destructor was strongly enforcing the abstract nature
1131         anyway.
1132         * io_stream.cc (io_stream::~io_stream): Empty out horribly pointless
1133         code from the pure virtual destructor.
1134         * archive_tar.cc (archive_tar::~archive_tar): Remove all
1135         reference to the removed "destroyed" member.
1136         * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
1137         * compress_bz.cc (compress_bz::~compress_bz): Ditto.
1138         * compress_gz.cc (compress_gz::~compress_gz): Ditto.
1139         * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Ditto.
1140         * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
1141         * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
1142
1143 2004-11-17  Max Bowsher  <maxb@ukf.net>
1144
1145         * mount.cc (create_mount): Fix operator precedence error introduced in
1146         first 2004-11-11 commit - warned of by gcc 3.3.3 but not 3.4.1 !
1147
1148 2004-11-13  Max Bowsher  <maxb@ukf.net>
1149
1150         Miscellaneous cleanup.
1151
1152         * geturl.cc (getUrlToStream): Make static.
1153         * geturl.h (getUrlToStream): Remove declaration.
1154
1155         * geturl.cc, geturl.h, netio.cc, netio.h, nio-ftp.cc, nio-ftp.h,
1156         nio-http.cc, nio-http.h:
1157         Remove unused "allow_ftp_auth" flag throughout.
1158
1159 2004-11-11  Max Bowsher  <maxb@ukf.net>
1160
1161         * libmd5-rfc: New directory, to hold code imported from the libmd5-rfc
1162         project in a clearly delineated fashion.
1163         * libmd5-rfc/README: New file.
1164         * md5.c, md5.h: Delete...
1165         * libmd5-rfc/md5.c, libmd5-rfc/md5.h: ...and replace with pristine
1166         versions from upstream (only change is restoration of upstream CVS
1167         keyword expansions).
1168         * libmd5-rfc/md5main.c: New file.
1169         * Makefile.ami (setup_SOURCES): Edit file paths.
1170         * download.cc, install.cc: Edit include paths.
1171
1172 2004-11-11  Max Bowsher  <maxb@ukf.net>
1173
1174         * dialog.cc (fatal): Make capable of handling a passed-in error code,
1175         as an alternative to calling GetLastError().
1176         * dialog.h (fatal): Adjust prototype as above.
1177         * mount.cc (create_mount): Use the above to correctly report errors.
1178
1179 2004-10-28  Max Bowsher  <maxb@ukf.net>
1180
1181         * LogFile.cc (LogFile::getFileName), splash.cc (SplashPage::Create),
1182         threebar.cc (ThreeBarProgressPage::SetBar2):
1183         Migrate from cistring and string resources
1184         to String and string literals.
1185         * localdir.cc: Remove unneeded #include of "cistring.h".
1186         * cistring.cc, cistring.h: Remove this now-redundant class.
1187         * Makefile.am: Remove mention of the above removed files.
1188         * res.rc, resource.h: Remove obsolete strings and IDs, both those
1189         obseleted by and obselete before the above changes.
1190         * res.rc: Merge the 2 adjacent STRINGTABLEs.
1191
1192 2004-10-27  Max Bowsher  <maxb@ukf.net>
1193
1194         * Makefile.am (setup_SOURCES): Add "RECTWrapper.h". It was missing.
1195
1196 2004-10-25  Bas van Gompel  <cygsup-patch.buzz@bavag.tmfweb.nl>
1197
1198         * package_source.cc (packagesource::set_canonical):
1199         Fix one-off in 'base' when ini is in same dir as package.
1200
1201 2004-10-25  Max Bowsher  <maxb@ukf.net>
1202
1203         * main.cc (next_dialog): Remove this legacy global variable.
1204         * download.cc (do_download_thread): Return a value instead of setting
1205         a global variable, then returning void.
1206         (do_download_reflector): Look for the next dialog code as a return
1207         value instead of a global variable.
1208
1209 2004-10-25  Max Bowsher  <maxb@ukf.net>
1210
1211         * port.h: Remove this redundant file - all contained definitions are
1212         duplicated in "win32.h".
1213         * Makefile.am, UserSetting.cc, UserSettings.cc, archive.cc,
1214         archive_tar.cc, archive_tar_file.cc, choose.cc, compress.cc,
1215         compress_bz.cc, compress_gz.cc, desktop.cc, find.cc, fromcwd.cc,
1216         iniparse.y, install.cc, io_stream_cygfile.cc, io_stream_file.cc,
1217         main.cc, netio.cc, site.cc, version.cc:
1218         Remove all references to "port.h".
1219
1220 2004-10-25  Max Bowsher  <maxb@ukf.net>
1221
1222         Fix compilation with w32api 3.1 and later.
1223
1224         * ControlAdjuster.h, RECTWrapper.h, cistring.h, propsheet.h,
1225         window.cc, window.h: Include "win32.h" not <windows.h> directly.
1226         * win32.h (WINBASEAPI): Define to empty string.
1227
1228 2004-09-13  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
1229
1230         * script.cc (run): Kill stdin when running scripts.
1231
1232 2004-09-01  Max Bowsher  <maxb@ukf.net>
1233
1234         * Makefile.am: Oops. Unwanted keyword expansion ate the code of the
1235         previous commit. Restore the code, escaped to not look like a keyword.
1236
1237 2004-09-01  Max Bowsher  <maxb@ukf.net>
1238
1239         * Makefile.am: Simplify the shell incantation for getting the revision
1240         of ChangeLog from grep-and-sed to just sed.
1241
1242 2004-08-31  Max Bowsher  <maxb@ukf.net>
1243
1244         Attain GCC 3.4 compatibility.
1245
1246         * PackageSpecification.h (PackageSpecification): Make the
1247         unnecessarily private copy-constructor public.
1248
1249 2004-08-30  Max Bowsher  <maxb@ukf.net>
1250
1251         Rework the implementation of not including -Werror for specific files,
1252         to a way that does not require hardcoding modified automake output back
1253         into its input.
1254
1255         * Makefile.am (AM_CXXFLAGS, BASECXXFLAGS): Seperate out -Werror.
1256         (autoload.o): Drop this rule, -finline-functions is no longer required
1257         and -Werror is acceptable here now we have __attribute__ ((used)).
1258         (WARNONLY_CFLAGS, inilex.o): Drop these.
1259         (EXTRA_PROGRAMS): Add a fake "warnonly" program.
1260         (warnonly_CXXFLAGS): Set to the $(BASECXXFLAGS).
1261         (warnonly_SOURCES): Set to "inilex.cc".
1262         (EXTRA_setup_SOURCES): Set to $(warnonly_SOURCES).
1263         (setup_SOURCES): Remove "inilex.cc".
1264         (setup_LDADD): Add "warnonly-inilex.o".
1265
1266 2004-08-30  Max Bowsher  <maxb@ukf.net>
1267
1268         Move closer to GCC 3.4 compatibility.
1269
1270         * IOStreamProvider.h, io_stream_cygfile.cc, io_stream_cygfile.h,
1271         io_stream_file.cc: Do not incorrectly use "enum" after it has been
1272         hidden inside a typedef.
1273         * archive.h: In "virtual func() = 0;", the 0 is a language construct,
1274         not some symbol that might evaluate to 0, and gcc 3.4 enforces this.
1275         * autoload.c (DllInfo.name): Silence warning by making const.
1276         (DLL, autoload_common): __attribute__ ((used)) is now required to
1277         prevent gcc being over-eager in it's optimization, and removing these
1278         seemingly-unused (used only from assembly) functions.
1279         Silences some warnings, too.
1280         * Makefile.am (AM_CXXFLAGS, AM_CFLAGS): The options
1281         -Wstrict-prototypes -Wmissing-prototypes do not apply to C++ and
1282         g++ 3.4 complains about them.
1283
1284 2004-08-29  Max Bowsher  <maxb@ukf.net>
1285
1286         * Exception.h: Reformatting, #include more, remove incorrect and
1287         less-than-useful comments.
1288         (TOPLEVEL_CATCH): New preprocessor macro.
1289
1290         * LogFile.cc (LogFile::operator()): Throw an exception object, not a
1291         char* string.
1292
1293         Wrap the top-level of each thread (including the main thread) in a
1294         try...catch block, in order to display a useful error message if an
1295         exception is not caught.
1296         * download.cc (do_download_reflector): Here ...
1297         * ini.cc (do_ini_thread_reflector): ... and here ...
1298         * install.cc (do_install_reflector: ... and here ...
1299         * main.cc (main): ... and here ...
1300         * postinstall.cc (do_postinstall_thread): ... and here ...
1301         * site.cc (do_download_site_info_thread): ... and here!
1302
1303         * msg.h: Include a missing header requirement.
1304         * res.rc (IDS_UNCAUGHT_EXCEPTION, IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO):
1305         New strings.
1306         * resource.h (IDS_UNCAUGHT_EXCEPTION)
1307         (IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO): New IDs.
1308
1309 2004-08-28  Max Bowsher  <maxb@ukf.net>
1310
1311         * res.rc (IDS_WINDOW_INIT_BADMSG): New string.
1312         * resource.h (IDS_WINDOW_INIT_BADMSG): New string resource ID.
1313         * window.cc (Window::FirstWindowProcReflector): Convert an abort()
1314         into a descriptive error.
1315
1316 2004-08-24  Max Bowsher  <maxb@ukf.net>
1317
1318         The Doug Lee replacement malloc was no longer hooked up with the
1319         buildsystem in any way. Pruning the remaining unused file.
1320
1321         * dlmalloc.c: Removed.
1322
1323 2004-08-18  Max Bowsher  <maxb@ukf.net>
1324
1325         "librsync is not wire-compatible with rsync 2.x, and is not likely
1326         to be in the future." -- librsync.sourceforge.net
1327
1328         So, it is of no practical use to setup. Therefore, removing all
1329         rsync related files and code from setup.
1330
1331         * rsync: Directory removed.
1332         * Makefile.am: Remove rsync support from the buildsystem.
1333         * configure.in: Ditto.
1334         * README: Since it seems vanishingly unlikely that it will ever happen,
1335             remove rsync support from the wishlist.
1336         * io_stream_rsync.cc: Remove.
1337         * io_stream_rsync.h: Remove.
1338
1339 2004-04-25  Robert Collins  <rbtcollins@hotmail.com>
1340
1341         * package_meta.cc (packagemeta::set_requirements): fix problem with
1342         libpcre0 not being pulled in automatically.
1343
1344 2004-04-25  Robert Collins  <rbtcollins@hotmail.com>
1345
1346         * IniDBBuilderPackage.cc (dumpAndList):
1347           Move out to packageversion for reuse.
1348         * package_meta.cc (packagemeta::logAllVersions): log dependencies.
1349         * package_version.cc (packageversion::depends):
1350             provide a const accessor.
1351         (dumpAndList): Moved from INIDBBuilder.cc.
1352         * package_version.h: declare new method and function.
1353
1354 2003-12-21  Robert Collins  <rbtcollins@hotmail.com>
1355
1356         * main.cc (main): Update to head libgetopt++ syntax.
1357
1358 2003-11-2  Robert Collins  <rbtcollins@hotmail.com>
1359
1360         * ControlAdjuster.h (ControlPosition::CP_MIDDLE): Rename to
1361         CP_CENTERED.
1362         * ControlAdjuster.cc: Ditto.
1363
1364 2003-10-31  Frank Richter  <frichter@gmx.li>
1365
1366         * localdir.cc (OnNext): When SelectDirectoryA() fails, display a
1367         message with the error returned from the system instead of just
1368         'could not change dir'. Also, offer the user to 'Retry', 'Ignore' the
1369         error or 'Abort' the directory change.
1370
1371 2003-10-31  Frank Richter  <frichter@gmx.li>
1372
1373         * propsheet.cc (PropSheetWndProc): Don't do child resizing if a the
1374         window gets minimized. Otherwise some glitches (e.g. wrong child
1375         sizes) occur.
1376         Added support for WM_GETMINMAXINFO. Prevents the property sheet from
1377         getting smaller than the original size.
1378
1379 2003-11-1  Robert Collins  <rbtcollins@hotmail.com>
1380
1381         * ControlAdjuster.h (ControlDimension): Add.
1382         (ControlAdjuster): Factor adjust functionality into ControlInfo.
1383         * ControlAdjuster.cc (ControlAdjuster::adjust): Ditto.
1384         (ControlAdjuster::ControlInfo::adjust): Ditto.
1385
1386 2003-10-31  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
1387
1388         * ControlAdjuster.h (ControlPosition): New enum type.
1389         (ControlInfo::horizontalPos, ControlInfo::verticalPos): New
1390         instance variables.
1391         (ControlInfo::anchorLeft, ControlInfo::anchorTop,
1392         ControlInfo::anchorRight, ControlInfo::anchorBottom): Remove.
1393         * ControlAdjuster.cc (ControlAdjuster::AdjustControls): Switch to
1394         using position specifiers instead of anchors.
1395         * choose.cc (ChooserControlsInfo): Ditto.
1396         * proppage.cc (DefaultControlsInfo): Ditto.
1397         * propsheet.cc (PropSheetControlsInfo): Ditto.
1398         * site.cc (SiteControlsInfo): Position specifiers for site
1399         selection dialog controls.
1400         * threebar.cc (ThreeBarControlsInfo): Position specifiers for
1401         progress dialog controls.
1402
1403 2003-10-27  Ralf Habacker  <ralf.habacker@freenet.de>
1404
1405         * main.cc (HelpOption): New instance.
1406         (main): Added help command line option handling.
1407         * localdir.cc (LocalDirOption): New instance.
1408         (LocalDirSetting::load): allow setting localdir from command line.
1409
1410 2003-10-16  Frank Richter  <frichter@gmx.li>
1411
1412         * ControlAdjuster.cc: New file, helper to move elements of a dialog
1413         along when the it's resized.
1414         * ControlAdjuster.h: Ditto.
1415         * Makefile.am: Add new source files.
1416         * proppage.cc (PropertyPage::DialogProc): Adjust some common
1417         controls (Cygwin icon top right, separator below) when a page is
1418         resized.
1419         (PropertyPage::PropertyPage): Dito.
1420         * propsheet.cc (IsDialog): New. Test whether a window is a dialog.
1421         Used internally by resize logic.
1422         (EnumPages): New. Used internally by resize logic: resizes the
1423         property sheet's individual pages.
1424         (PropSheetWndProc): New. Hook for the propery sheet window proc.
1425         (PropSheetProc): More style tweaks, add maximize box and thick border
1426         as well. Hook into the property sheet's window proc.
1427         (PropSheet::AdjustPageSize): New. Adjust the metrics of a single page
1428         to fit nicely into the property sheet. Part of resize logic.
1429         * res.rc (All dialogs): The top-right Cygwin icon and top separator
1430         now have IDs distinct from IDC_STATIC, so their metrics can be
1431         adjusted upon a resize. Also, all those Cygwin icons are at the exact
1432         same spot now.
1433         * choose.cc (ChooserPage::ChooserPage): Now the controls on the
1434         chooser page move/size when the page size is changed.
1435         * choose.h: Dito.
1436
1437 2003-10-23  Jerry D. Hedden <jerry@hedden.us>
1438
1439         * ConnectionSetting.cc (ConnectionSetting::load): Load proxysettings.
1440         (ConnectionSetting::save): Save proxy settings.
1441
1442 2003-10-07  Robert Collins <rbtcollins@hotmail.com>
1443
1444         * proppage.h (PropertyPage::wantsActivation): const correctness fix.
1445
1446 2003-08-19  Max Bowsher  <maxb@ukf.net>
1447
1448         * win32.h: Define NOMINMAX only if not already defined - because
1449         libstdc++-v3 3.3.1 defines NOMINMAX itself.
1450
1451 2003-08-03  Max Bowsher  <maxb@ukf.net>
1452
1453         * ChangeLog: Fix broken line-wrapping throughout. Clarify that
1454         "Ran automake" in 2003-07-26 entry was in bz2lib and zlib subdirs.
1455
1456 2003-08-03  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1457
1458         * propsheet.cc (Copyright): Update copyright dates.
1459         (PropSheet::PropSheet): Remove NumPropPages initialization.
1460         (PropSheet::CreatePages): Use PropertyPages.size() instead of
1461         NumPropPages.
1462         (PropSheet::Create): Ditto.
1463         (PropSheet::AddPage): Change to use new PropertyPages std::vector<>.
1464         * propsheet.h (Copyright): Update copyright dates.
1465         (File Scope): Include <vector>.
1466         (PropSheet::PropertyPages): Change from array to vector<>.
1467         (PropSheet::NumPropPages): Remove.
1468
1469 2003-08-02  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1470
1471         Changes modified by Max Bowsher  <maxb@ukf.net>
1472         * splash.cc (Copyright): Update copyright dates.
1473         (SplashPage::OnInit): Remove call to SetDlgItemFont().  Now handled in
1474         base class.
1475         * proppage.h (PropertyPage::setTitleFont): Declare.
1476         * proppage.cc (Copyright): Update copyright dates.
1477         (PropertyPage::DialogProc WM_INITDIALOG): Move all font setting code,
1478         including that from splash.cc into new function...
1479         (PropertyPage::setTitleFont): Create, using moved code. Change font
1480         "MS Sans Serif" to "MS Shell Dlg" in line with recent res.rc change.
1481         Set font for IDC_STATIC_WELCOME_TITLE here, to allow easy re-use of
1482         style for future "Finished" page.
1483
1484 2003-08-02  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1485
1486         * propsheet.cc: Include "resource.h".
1487         (PropSheet::Create): Add the Cygwin icon in the left of the title bar.
1488
1489 2003-08-01  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1490
1491         * proppage.cc (PropertyPage::FirstDialogProcReflector): Modify comment.
1492
1493 2003-08-01  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1494
1495         * proppage.h (Copyright): Update copyright dates.
1496         (PropertyPage): Document OnNext and OnBack.
1497
1498 2003-07-31  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1499
1500         * proppage.cc (PropertyPage::Create): Use more self-documenting
1501         MAKEINTRESOURCE() instead of cast to LPCSTR.
1502
1503 2003-07-31  Robert Collins  <rbtcollins@hotmail.com>
1504
1505         * README: Mark completed items complete.
1506
1507 2003-07-31  Pierre Humblet  <pierre.humblet@ieee.org>
1508
1509         * main.cc (set_default_sec): Set token owner from token user.
1510         Always try to set the token primary group to Users or Admins.
1511
1512 2003-07-30  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
1513
1514         * String++.h (String::replace): New instance functions.
1515         * String++.cc (String::replace): Implement.
1516         * filemanip.cc (backslash): Change to use String::replace.
1517         * desktop.cc (make_cygwin_bat): Escape '%' in path.
1518
1519 2003-07-30  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
1520
1521         * String++.h (TOSTRING): New macro.
1522         * UserSettings.cc (UserSettings::deRegisterSetting): Fix
1523         erroneous __LINE__/__FILE__ usage.
1524         * download.cc (validateCachedPackage, check_for_cached): Ditto.
1525         * geturl.cc (getUrlToStream): Ditto.
1526         * install.cc (md5_one): Ditto.
1527
1528 2003-07-30  Max Bowsher  <maxb@ukf.net>
1529
1530         * ini.cc (do_ini_thread): Return bool.
1531         (do_ini_thread_reflector): Put returned bool in lParam.
1532         * threebar.cc (WM_APP_SETUP_INI_DOWNLOAD_COMPLETE): Rework for new
1533         meaning of lParam. Replace erroneous use of do_fromcwd with
1534         SetActivePageByID (IDD_SOURCE).
1535
1536 2003-07-30  Robert Collins  <rbtcollins@hotmail.com>
1537
1538         * ConnectionSetting.cc: New file, persist connection type selection.
1539         * ConnectionSetting.h: Ditto.
1540         * net.cc: Hold a ConnectionSetting instance to trigger the logic.
1541         (NetPage::OnInit): Don't force net_method to any value.
1542         * Makefile.am: Add new source files.
1543
1544 2003-07-30  Robert Collins  <rbtcollins@hotmail.com>
1545
1546         * SourceSetting.cc: New file, persist source selection.
1547         * SourceSetting.h: Ditto.
1548         * source.cc: Hold a Source setting instance to trigger the logic.
1549         * Makefile.am: Add new source files.
1550
1551 2003-07-30  Robert Collins  <rbtcollins@hotmail.com>
1552
1553         * UserSettings.h (UserSettings::settingFileForLoad): Extracted method
1554         from LocalDirSetting::load().
1555         * UserSettings.cc (UserSettings::settingFileForLoad): Ditto.
1556         * UserSettings.h (UserSettings::settingFileForSave): Extracted method
1557         from LocalDirSetting::save().
1558         * UserSettings.cc (UserSettings::settingFileForSave): Ditto.
1559         * localdir.cc (LocalDirSetting::load): Extract location logic to
1560         UserSettings.
1561         (LocalDirSetting::save): Extract location logic to UserSettings.
1562         * site.cc (SiteSetting::getSavedSites): Use
1563         UserSettings::settingFileForLoad.
1564         (SiteSetting::save): Use UserSettings::settingFileForSave.
1565
1566 2003-07-30  Robert Collins  <rbtcollins@hotmail.com>
1567
1568         * PickView.cc: Adjust ::GetClientRect(..) to the inherited one
1569         throughout.
1570
1571 2003-07-29  Max Bowsher  <maxb@ukf.net>
1572
1573         Based on a patch by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
1574         * AntiVirus.cc (AntiVirusPage::wantsActivation): Define.
1575         * AntiVirus.h (AntiVirusPage::wantsActivation): Declare.
1576         * localdir.cc (LocalDirPage::OnBack): Remove logic subsumed by
1577         RootPage::wantsActivation.
1578         * proppage.cc (PropertyPage::DialogProc): Call wantsActivation(),
1579         and skip to next page in sequence if activation is refused.
1580         * proppage.h (PropertyPage::wantsActivation): Default implementation.
1581         * root.cc (RootPage::wantsActivation): Define.
1582         * root.h (RootPage::wantsActivation): Declare.
1583         * source.cc: Don't include "AntiVirus.h".
1584         (SourcePage::OnNext): Remove logic subsumed by
1585         RootPage::wantsActivation.
1586         (SourcePage::OnBack): Remove logic subsumed by
1587         AntiVirusPage::wantsActivation.
1588         * splash.cc: Don't include "AntiVirus.h" or "dialog.h".
1589         (SplashPage::OnNext): Remove - subsumed by
1590         AntiVirusPage::wantsActivation.
1591         * splash.h (SplashPage::OnNext): Remove declaration.
1592
1593 2003-07-29  Robert Collins  <rbtcollins@hotmail.com>
1594
1595         * PickView.h (PickView::refresh): New method.
1596         * PickView.cc (PickView::refresh): Extracted from various
1597         ChooserPage callers.
1598         * choose.cc: Use PickView::refresh wherever possible.
1599
1600 2003-07-29  Robert Collins  <rbtcollins@hotmail.com>
1601
1602         * choose.h (ChooserPage::createListView): Remove last parameter.
1603         (ChooserPage::getDefaultListViewSize): Extracted method.
1604         * choose.cc (ChooserPage::createListView): Remove last parameter.
1605         (ChooserPage::getDefaultListViewSize): Extracted method.
1606
1607 2003-07-29  Robert Collins  <rbtcollins@hotmail.com>
1608
1609         * choose.cc (ChooserPage::createListView): Remove unneeded
1610         parameter.
1611         * choose.h: Ditto.
1612
1613 2003-07-29  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1614
1615         * dialog.h (do_fromcwd): Change function declaration.
1616         * fromcwd.cc (do_fromcwd): Change return type to bool.  Eliminate
1617         use of next_dialog, return true or false instead.
1618         * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
1619         value instead of next_dialog.
1620
1621 2003-07-29  Robert Collins  <rbtcollins@hotmail.com>
1622
1623         * package_db.h (packagedb::fillMissingCategory): Move from ChooserPage.
1624         * choose.h (ChooserPage::fillMissingCategory): Delete.
1625         * package_db.cc (packagedb::fillMissingCategory): Move from ChooserPage.
1626         * choose.cc (ChooserPage::fillMissingCategory): Delete and adjust
1627         callers.
1628
1629 2003-07-29  Robert Collins  <rbtcollins@hotmail.com>
1630
1631         * PickView.h (CATEGORY_EXPANDED): Move from choose.h
1632         (CATEGORY_COLLAPSED): Move from choose.cc.
1633         (PickView::setViewMode): Move from ChooserPage.
1634         * choose.h (CATEGORY_EXPANDED): Delete.
1635         (CATEGORY_COLLAPSED): Delete.
1636         (ChooserPage::setViewMode): Delete.
1637         * PickView.cc (PickView::setViewMode): Move from ChooserPage.
1638         * chooser.cc (ChooserPage::setViewMode): Delete, and adjust callers
1639         throughout.
1640
1641 2003-07-28  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1642
1643         * AntiVirus.cc (AntiVirusPage::OnNext): Do not explicitly specify the
1644         page to display next, since it follows in the default page ordering
1645         anyway.
1646
1647 2003-07-28  Max Bowsher  <maxb@ukf.net>
1648
1649         * dialog.h: (NEXT): Remove obsolete macro.
1650         * site.cc (save_dialog): Remove use of NEXT(), and non-functional
1651         unnecessary error handler.
1652
1653 2003-07-28  Robert Collins  <rbtcollins@hotmail.com>
1654
1655         * package_meta.h (packagemeta::addToCategoryAll): Declare.
1656         * package_meta.cc (packagemeta::addToCategoryAll): New method,
1657         separated to allow clear iteration.
1658         * choose.cc (ChooserPage::fillMissingCategory): BUGFIX: "all" is
1659         meant to be added unconditionally.
1660
1661 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1662
1663         * Generic.h: New file, home for generic programming tools.
1664         (visit_if): Move here from package_meta.cc.
1665         Adjust to be fully parameterised.
1666         * package_meta.h (packagemeta::hasNoCategories): Query for generic
1667         programming.
1668         (packagemeta::setDefaultCategories): set categories for packages
1669         with none.
1670         * package_meta.cc: Move visit_if out. Adjust users for
1671         full paramterised operation.
1672         (packagemeta::hasNoCategories): Implement.
1673         (packagemeta::setDefaultCategories): Implement.
1674         * choose.cc (ChooserPage::fillMissingCategory): Use visit_if to
1675         reduce duplicate code.
1676         (ChooserPage::setExistence): Delete.
1677         * choose.h (ChooserPage::setExistence): Rename to
1678         packagedb::setExistence.
1679         * package_db.h (packagedb::setExistence): Declare.
1680         * package_db.cc (packagedb::setExistence): Copy from choose.cc
1681
1682 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1683
1684         * localdir.h (LocalDirPage::OnInit): Remove.
1685         * localdir.cc (LocalDirPage::OnInit): Move to LocalDirSetting
1686         ::load().
1687         (LocalDirSetting::load): Copied from LocalDirPage::OnInit.
1688         * site.h (SitePage::OnInit): Remove.
1689         (SitePage::getSavedSites): New member, replaces get_saved_sites.
1690         (SitePage::registerSavedSite): New member, replaces
1691         register_saved_site.
1692         * site.cc (SitePage::OnInit): Move to SiteSetting::load().
1693         (SiteSetting::load): Copied from SitePage::OnInit.
1694         (SitePage::getSavedSites): Renamed from get_saved_sites.
1695         (SitePage::registerSavedSite): Renamed from register_saved_site.
1696         (do_download_site_info_thread): Don't look at the list size for
1697         determining if the download was successful.
1698
1699 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1700
1701         * choose.h (ChooserPage::setViewMode): Remove HWND from
1702         signature.
1703         (ChooserPage::defaultTrust): Ditto.
1704         Move to PickView.
1705         (ChooserPage::ifChecked): Use Window helper function
1706         IsButtonChecked.
1707         * choose.cc (ChooserPage::setViewMode): Use chooser->GetHWND()
1708         throughout.
1709         Update all callers with new signature.
1710         (ChooserPage::defaultTrust): Ditto.
1711         Move to PickView.
1712         * PickView.h (PickView::defaultTrust): Declare.
1713         * PickView.cc (PickView::defaultTrust): Copy from chooser.cc.
1714
1715 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1716
1717         * PickView.h (PickView::lv): Eliminate.
1718         * PickView.cc (PickView::init): Replace use of lv with
1719         GetHWND().
1720         (PickView::list_click): Ditto.
1721         * choose.h (ChooserPage::lv): Eliminate.
1722         * choose.cc: Replace lv with chooser->GetHWND()
1723         throughout.
1724
1725 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1726
1727         * PickView.h (PickView::chooser): Eliminate.
1728         (PickView::list_vscroll): Make non-static.
1729         (PickView::list_hscroll): Ditto.
1730         (PickView::list_click): Ditto.
1731         (PickView::paint): Ditto.
1732         * PickView.cc (PickView::list_vscroll): Eliminate use
1733         of PickView::chooser.
1734         (PickView::list_hscroll): Ditto.
1735         (PickView::list_click): Ditto.
1736         (PickView::paint): Ditto.
1737         * choose.cc (Chooser::createListView): Eliminate use
1738         of PickView::chooser.
1739
1740 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1741
1742         * PickView.h (PickView): Inherit from Window.
1743         (PickView::RegisterWindows): Move from ChooserPage.
1744         (PickView::listview_proc): Likewise.
1745         (PickView::paint): Ditto.
1746         (PickView::list_click): Ditto.
1747         (PickView::list_hscroll): Ditto.
1748         (PickView::list_vscroll): Ditto.
1749         (PickView::lv): Ditto.
1750         (PickView::chooser): Ditto.
1751         (PickView::Create): Override Windows::Create as we migrate.
1752         (PickView::registerWindowClass): Renamed RegisterWindows.
1753         (PickView::WindowClassAtom): Prevent double registration.
1754         (PickView::init): Declare.
1755         * PickView.cc: Adjust for new inheritance.
1756         (PickView::RegisterWindows): Move from ChooserPage.
1757         (PickView::listview_proc): Likewise.
1758         (PickView::paint): Ditto.
1759         (PickView::list_click): Ditto.
1760         (PickView::list_hscroll): Ditto.
1761         (PickView::list_vscroll): Ditto.
1762         (PickView::lv): Ditto.
1763         (PickView::chooser): Ditto.
1764         (PickView::Create): Introduce stub.
1765         (PickView::RegisterWindows): Rename
1766         (PickView::init): Extracted from constructor to allow
1767         reordering.
1768         * chooser.h (ChooserPage::registerWindows): Rename to
1769         PickView::RegisterWindows.
1770         (ChooserPage::listview_proc): Likewise.
1771         (ChooserPage::paint): Ditto.
1772         (ChooserPage::list_click): Ditto.
1773         (ChooserPage::list_hscroll): Ditto.
1774         (ChooserPage::list_vscroll): Ditto.
1775         (ChooserPage::lv): Duplicate into PickView, observe
1776         as non-static.
1777         (ChooserPage::chooser): Ditto.
1778         * chooser.cc (ChooserPage::registerWindows): Delete.
1779         (ChooserPage::listview_proc): Ditto.
1780         (ChooserPage::paint): Ditto.
1781         (ChooserPage::list_click): Ditto.
1782         (ChooserPage::list_hscroll): Ditto.
1783         (ChooserPage::list_vscroll): Ditto.
1784         (ChooserPage::createListView): Create() on PickView.
1785         * window.h (Window::RegisterWindowClass): Make virtual
1786         to allow Create to become a Template Method, and rename
1787         to registerWindowClass as it's not static.
1788         * window.cc (Window::registerWindowClass): Ditto.
1789         (Window::FirstWindowProcReflector): BUGFIX: Set window
1790         handle to prevent races with the window procedure.
1791
1792 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1793
1794         * choose.cc (set_view_mode): Rename to ChooserPage::setViewMode.
1795         (default_trust): Rename to ChooserPage::defaultTrust.
1796         (fill_missing_category): Rename to ChooserPage::fillMissingCategory.
1797         (set_existence): Rename to ChooserPage::setExistence.
1798         (register_windows): Rename to ChooserPage::registerWindows.
1799         (listview_proc): Rename to ChooserPage::listview_proc.
1800         (paint): Rename to ChooserPage::paint.
1801         (list_click): Rename to ChooserPage::list_click.
1802         (list_hscroll): Rename to ChooserPage::list_hscroll.
1803         (list_vscroll): Rename to ChooserPage::list_vscroll.
1804         (lv): Rename to ChooserPage::lv.
1805         (chooser): Rename to ChooserPage::chooser.
1806         * choose.h (ChooserPage::setViewMode): Declare.
1807         (ChooserPage::defaultTrust): Declare.
1808         (ChooserPage::fillMissingCategory): Declare.
1809         (ChooserPage::setExistence): Declare.
1810         (ChooserPage::registerWindows): Declare.
1811         (ChooserPage::listview_proc): Declare.
1812         (ChooserPage::paint): Declare.
1813         (ChooserPage::list_click): Declare.
1814         (ChooserPage::list_hscroll): Declare.
1815         (ChooserPage::list_vscroll): Declare.
1816         (ChooserPage::lv): Declare.
1817         (ChooserPage::chooser): Declare.
1818
1819 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1820
1821         * choose.cc (create_listview): Use for_each instead of explicit
1822         iteration.
1823         (create_listview): Rename to ChooserPage::createListview.
1824         * package_meta.h (packagemeta::set_requirements): Explicitly separate
1825         the 1 and 2 parameter versions.
1826
1827 2003-07-27  Robert Collins  <rbtcollins@hotmail.com>
1828
1829         * String++.h (String::operator !=): Declare for char * and String.
1830         * String++.cc (String::operator !=): Implement.
1831         * package_meta.cc(StringConcatenator): Move above all users.
1832         (_visit_if): Predicate support for visitors.
1833         (packagemeta::getReadableCategoryList): Refactor to use
1834         StringConcatenator with a predicate.
1835         * choose.h: Remove unneeded c++ guards.
1836
1837 2003-07-26  Robert Collins  <rbtcollins@hotmail.com>
1838
1839         * choose.cc (scan_downloaded_files): Rename to
1840         packagemeta::ScanDownloadedFiles.
1841         (scanAVersion): Rename to packageversion::scan.
1842         (GetParentRect): Rename to ChooserPage::getParentRect.
1843         * choose.h (ChooserPage::getParentRect): Declare.
1844         * package_meta.h (packagemeta::ScanDownloadedFiles): Declare.
1845         * package_version.h (packageversion::scan): Declare.
1846         * package_version.cc (packageversion::scan): Move from choose.cc
1847         * package_meta.cc (packagemeta::ScanDownloadedFiles): Move from
1848         choose.cc
1849
1850 2003-07-26  Robert Collins  <rbtcollins@hotmail.com>
1851
1852         * choose.cc (ChooserPage::OnNext): log before starting activity threads.
1853         (ChooserPage::OnInit): Remove temporary variable frame.
1854         (ChooserPage::setPrompt): Extract method from OnInit.
1855         (choose_inst_text): Remove unused variable.
1856         * choose.h(ChooserPage::setPrompt): Declare
1857         * res.rc (IDD_CHOOSE): Bugfix: the chooser was setting a non-present
1858         caption.
1859
1860 2003-07-26  Robert Collins  <rbtcollins@hotmail.com>
1861
1862         Remove package specific code from choose.cc.
1863         Update copyrights where appropriate.
1864         * choose.cc(ChooserPage::OnNext): Extract logging to
1865         packagemeta::logSelectionStatus.
1866         * package_meta.cc(packagemeta::logSelectionStatus): Extract from
1867         ChooserPage::OnNext.
1868         (StringConcatenator): helper for logSelectionStatus.
1869         (action_caption): Make const.
1870         * package_meta.h(packagemeta): Declare logSelectionStatus.
1871         (packagemeta::action_caption): Make const.
1872         * package_version.cc(packageversion::sourcePackage): Make const.
1873         * package_version.h(packageversion::sourcePackage): Make const.
1874
1875 2003-07-26  Robert Collins  <rbtcollins@hotmail.com>
1876
1877         * choose.cc: Update copyright.
1878         (ChooserPage::keepClicked): Extracted from OnMessageCmd.
1879         (ChooserPage::changeTrust): Ditto.
1880         * choose.h (ChooserPage): Declare keepClicked and changeTrust.
1881         (ChooserPage::ifChecked): Extracted from OnMessageCmd.
1882         * package_meta.h (SetRequirement): Adapter for visiting package
1883         collections.
1884
1885 2003-07-26  Max Bowsher  <maxb@ukf.net>
1886
1887         * tests/.cvsignore: New file, listing Makefile.in.
1888
1889 2003-07-26  Robert Collins  <rbtcollins@hotmail.com>
1890
1891         Save used local cache dir from initial run of setup, so the user doesn't
1892         need to retype it.
1893         * localdir.h (LocalDirSetting): UserSetting class for the local cache
1894         dir.
1895         * localdir.cc (LocalDirSetting::save): Replace save_local_dir, and
1896         update callers.
1897
1898 2003-07-26  Robert Collins  <rbtcollins@hotmail.com>
1899
1900         Save used site from initial run of setup, so the user doesn't need to
1901         retype it.
1902         * main.cc (main): Load and save all user settings.
1903         * site.cc (SiteSetting::save): Migrate logic from save_site_url.
1904         (SitePage::OnNext): Use ChosenSites.save() to remove uneeded
1905         save_site_url call.
1906         (save_site_url): Delete.
1907         * site.h (save_site_url): Remove declaration.
1908         * .cvsignore: Update autoconf generated files.
1909
1910 2003-07-26  Robert Collins  <rbtcollins@hotmail.com>
1911
1912         * tests/Makefile.am: Driver for test suite.
1913         * tests/UserSettingTest.cc: Test UserSetting interface.
1914         * tests/UserSettingsTest.cc: Test UserSettings interface.
1915         * Makefile.am: Add the tests dir to recurse into.
1916         * configure.in: Ditto.
1917         * UserSetting.h: Add load and save methods to allow global
1918         serialisation.
1919         Add explicit copy and assignment operators to prevent synthetics.
1920         Make the constructor protected to prevent direct instantiation.
1921         * UserSettings.h (UserSettings::loadAllSettings): New method.
1922         (UserSettings::savedAllSettings): New method.
1923         * UserSettings.cc: Implement new methods.
1924         * site.cc: Implement stubs for new required UserSetting methods.
1925         * site.h (ChosenSite): Ditto.
1926         * bz2lib/: Ran automake.
1927         * zlib/: Ran automake.
1928
1929 2003-07-23  Max Bowsher  <maxb@ukf.net>
1930
1931         * desktop.cc (DesktopSetupPage::OnBack): Remove obsolete use of NEXT().
1932         * root.cc (RootPage::OnNext): Ditto.
1933         (RootPage::OnBack): Ditto.
1934         * install.cc (do_install_thread): Remove obsolete use of next_dialog.
1935         * main.cc (main): Ditto.
1936         * postinstall.cc (do_postinstall_thread): Ditto.
1937
1938 2003-07-23  Max Bowsher  <maxb@ukf.net>
1939
1940         * dialog.h (do_choose, do_desktop, do_local_dir, do_net, do_other)
1941         (do_root, do_site, do_source, do_splash): Remove declarations, since
1942         these functions no longer exist.
1943
1944 2003-07-23  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
1945
1946         * choose.cc (initialized): Remove obsolete file scope variable.
1947
1948 2003-07-18  Max Bowsher  <maxb@ukf.net>
1949
1950         * res.rc: Make caption of every dialog page begin with "Cygwin Setup".
1951         This aids recognition when minimized.
1952         Prompted by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.
1953
1954 2003-07-10  Jeremy White  <jwhite@codeweavers.com>
1955
1956         * mount.cc, root.cc, site.cc:  Make StringOptions required,
1957         thereby making --longopt <parm> behave as a newbie would expect.
1958
1959 2003-07-08  Max Bowsher  <maxb@ukf.net>
1960
1961         * LogFile.h, cistring.h, dialog.h, diskfull.h, filemanip.h, geturl.h,
1962         hash.h, log.h, mkdir.h, mklink2.h, mount.h, msg.h, netio.h, nio-file.h,
1963         nio-ftp.h, nio-http.h, nio-ie5.h, port.h, simpsock.h, state.h,
1964         version.h: Add inclusion guard.
1965         * root.h: Standardize naming of inclusion guard.
1966
1967 2003-06-23  Max Bowsher  <maxb@ukf.net>
1968
1969         * AntiVirus.h, Exception.h, FilterVisitor.h, FindVisitor.h,
1970         IOStreamProvider.h, IniDBBuilder.h, IniDBBuilderPackage.h,
1971         IniParseFeedback.h, IniParseFindVisitor.h, LogSingleton.h, MD5++.h,
1972         PackageSpecification.h, PackageTrust.h, PickCategoryLine.h, PickLine.h,
1973         PickPackageLine.h, PickView.h, RECTWrapper.h, ScanFindVisitor.h,
1974         String++.h, UserSetting.h, UserSettings.h, archive.h, archive_tar.h,
1975         category.h, choose.h, compress.h, compress_bz.h, compress_gz.h,
1976         cygpackage.h, desktop.h, download.h, find.h, ini.h, io_stream.h,
1977         io_stream_cygfile.h, io_stream_file.h, io_stream_memory.h,
1978         io_stream_rsync.h, localdir.h, net.h, package_db.h, package_meta.h,
1979         package_source.h, package_version.h, proppage.h, propsheet.h, script.h,
1980         site.h, source.h, splash.h, threebar.h, win32.h, window.h:
1981         Standardize naming and placement of inclusion guards.
1982
1983 2003-06-22  Benjamin Riefenstahl  <Benjamin.Riefenstahl@epost.de>
1984
1985         * res.rc (all dialogs): Change font from "MS Sans Serif" to
1986         "MS Shell Dlg".
1987
1988 2003-06-22  Max Bowsher  <maxb@ukf.net>
1989
1990         * Makefile.am: Clarify comment.
1991         Derive AM_CFLAGS from AM_CXXFLAGS, rather than the other way around.
1992         (AM_CXXFLAGS): Remove -Wmissing-declarations - it is a C-only warning.
1993         (AM_CFLAGS): Add -Winline, and -Wmissing-declarations.
1994
1995 2003-06-22  Max Bowsher  <maxb@ukf.net>
1996
1997         * rfc1738.cc (rfc1738_do_escape): Eliminate redundant conditional.
1998
1999 2003-06-05  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
2000
2001         * window.h (SETUP_WINDOW_H): Rename multi-include guard.
2002         (Copyright): Update.
2003         (RECTWrapper): New forward declaration.
2004         (Window::Create): Move.
2005         (Window::MoveWindow): New overload declaration.
2006         * window.cc: (RECTWrapper.h) Include.
2007         (Copyright): Update.
2008         (Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
2009         of C-style casts.
2010         (Window::MoveWindow): New overload.
2011
2012 2003-05-31  Max Bowsher  <maxb@ukf.net>
2013
2014         * res.rc: Resize title controls to fully fill available width.
2015
2016 2003-05-07  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
2017
2018         * RECTWrapper.h: New file.
2019
2020 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2021
2022         * script.cc (Script::extension): Extract method from Script::run.
2023         (Script::run): Extract extension generation to Script::extension.
2024         * script.h (Script::extension): Declare.
2025
2026 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2027
2028         * script.cc (run_script): Remove.
2029         (try_run_script): Inline method run_script.
2030         * script.h (run_script): Remove.
2031
2032 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2033
2034         * postinstall.cc (RunScript::operator()): Use new run syntax.
2035         * script.h (Script::run): Eliminate to_log parameter.
2036         * script.cc (Script::run): Ditto.
2037         (run_script): Use new run syntax.
2038
2039 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2040
2041         * script.cc (Script::run): Eliminate temp variable 'f2'.
2042         Rename temp variable 'f2' to 'windowsName' for increased clarity.
2043
2044 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2045
2046         * script.cc (Script::run): Eliminate temp variable 'fname'.
2047
2048 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2049
2050         * script.cc (Script::run): Eliminate temp variable 'dir'.
2051
2052 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2053
2054         * script.cc (run_script): Always pass TRUE to Script::run.
2055         * script.h (run_script): Remove optional to_log parameter.
2056
2057 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2058
2059         * script.cc (run_script): Move functionality into Script.
2060         (Script::run): Absorb run_script.
2061
2062 2003-04-12  Robert Collins  <rbtcollins@hotmail.com>
2063
2064         * PickCategoryLine.cc (PickCategoryLine::click): Tell packagemeta we
2065         are about to perform a visit.
2066         * PickPackageLine.cc (PickPackageLine::click): Tell packagemeta we
2067         are about to perform a visit.
2068         * package_db.cc (packagedb::markUnVisited): Convenience wrapper -
2069         mark all packages as unvisited.
2070         * package_db.h (packagedb::markUnVisited): Declare.
2071         * package_meta.cc (packagemeta::PrepareForVisit): New static method
2072         to prepare for a loop-free visit.
2073         (packagemeta::packagemeta): Adjust for new member.
2074         (packagemeta::set_requirements): Only visit a node once.
2075         (packagemeta::visited): Get and Set methods for new member visited_.
2076         * package_meta.h (packagemeta::PrepareForVisit): Declare.
2077         (packagemeta::visited): Declare.
2078         (packagemeta::visited_): Declare.
2079
2080 2003-04-07  Max Bowsher  <maxb@ukf.net>
2081
2082         * download.cc: Add command line option to suppress MD5 checks.
2083         (validateCachedPackage): Test option and possibly skip.
2084
2085 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2086
2087         Merge in setup-200303-troubleshooting fixes.
2088
2089 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2090
2091         * main.cc (NTSecurity::setDefaultDACL): Reinstate commented code.
2092         (NTSecurity::setDefaultSecurity): Ditto.
2093
2094 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2095
2096         * main.cc (NTSecurity::setDefaultDACL): Use MS calculations for ACL
2097         buffer sizing.
2098
2099 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2100
2101         * main.cc (NTSecurity::setDefaultDACL): Sanity check memory allocation.
2102
2103 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2104
2105         * main.cc (NTSecurity::setDefaultDACL): Adjust commented code for
2106         auto_ptr use.
2107
2108 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2109
2110         * main.cc (NTSecurity::NoteFailedAPI): Helper function.
2111         Use throughout NTSecurity routines.
2112         (NTSecurity::setDefaultDACL): Use dynamic memory for ACL storage.
2113
2114 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2115
2116         * main.cc (NTSecurity::setDefaultDACL): Disable ~ 50% of remaining
2117         active code.
2118
2119 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2120
2121         * main.cc (NTSecurity::GroupInfo): Extract group query code.
2122         (NTSecurity::setDefaultDACL): Disable ~ 50% of code.
2123
2124 2003-04-02  Robert Collins  <rbtcollins@hotmail.com>
2125
2126         * main.cc (NTSecurity::setDefaultSecurity): Disable ~ 50% of security
2127         code.
2128
2129 2003-04-01  Robert Collins  <rbtcollins@hotmail.com>
2130
2131         * main.cc (NTSecurity::setDefaultSecurity): Remove double declaration of
2132         sz. User TokenGroupCollection to abstract token searching logic,
2133         eliminate isadmin and isuser temporary variables.
2134         (TokenGroupCollection): New class for querying token group information.
2135
2136 2003-04-01  Robert Collins  <rbtcollins@hotmail.com>
2137
2138         * main.cc (NTSecurity::setDefaultSecurity): Extract esid initialisation.
2139         Move local variables to just before first use.
2140         SetTokenInformationFailures where being handled inconsistently.
2141         Remove assignments from if statements.
2142         (NTSecurity::esid): Rename to everyOneSID.
2143         (NTSecurity::initialiseEveryOneSID): new method.
2144         (NTSecurity::setDefaultDACL): Extract method for default DACL logic.
2145
2146 2003-04-01  Robert Collins  <rbtcollins@hotmail.com>
2147
2148         * main.cc (SIDWrapper): Manage SID memory.
2149         (HANDLEWrapper): Likewise for HANDLES.
2150         (NTSecurity): Worker class for set_default_sec().
2151         (set_default_sec): Move body into NTSecurity::setDefaultSecurity().
2152         (NTSecurity::setDefaultSecurity): Eliminate goto out: via memory
2153         managing objects.
2154
2155 2003-04-01  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
2156
2157         * cygwin.ico:  Added two new resolutions, 64x64 and 72x72.
2158
2159 2003-03-29  Robert Collins  <rbtcollins@hotmail.com>
2160
2161         * GUIDELINES: New file documenting code guidelines.
2162
2163 2003-03-26  Max Bowsher  <maxb@ukf.net>
2164
2165         * .cvsignore: Add cfgaux.
2166
2167 2003-03-26  Robert Collins  <rbtcollins@hotmail.com>
2168
2169         * package_version.cc (_defaultversion::accessible): Override and make
2170         always false.
2171         (_packageversion::accessible): Fix a couple of logic bugs resulting in
2172         incorrect trues.
2173         * package_version.h (_packageversion::accessible): Make virtual.
2174
2175 2003-03-25  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
2176
2177         * threebar.h (WM_APP_START_POSTINSTALL): New message.
2178         (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message.
2179         * threebar.cc (ThreeBarProgressPage::OnMessageApp):
2180         Add handling for WM_APP_START_POSTINSTALL and
2181         WM_APP_POSTINSTALL_THREAD_COMPLETE.
2182         * install.cc (do_install_thread): Set next_dialog to
2183         IDD_S_POSTINSTALL.
2184         * desktop.cc (DesktopSetupPage::OnFinish): Move the
2185         do_postinstall call to ThreeBarProgressPage::OnMessageApp.
2186         * script.h (Script::fullName): New member function.
2187         (Script::run): New member function.
2188         (Script::ETCPostinstall): New static member constant.
2189         * script.cc (Script::fullName): Implement.
2190         (Script::run): Implement.
2191         (Script::ETCPostinstall): Define.
2192         (Script::isAScript): Use ETCPostinstall instead of a
2193         hardcoded string constant.
2194         (run): Enable "#if 0"'d code.
2195         * postinstall.cc (Progress): New extern variable.
2196         (RunFindVisitor::visitFile): Add script to vector
2197         instead of running.
2198         (RunFindVisitor::_scripts): New member variable.
2199         (RunScript): New helper class for use in for_each.
2200         (do_postinstall_thread): Rename do_postinstall to.  Add
2201         Progress bar and text setting.  Add package count.
2202         (do_postinstall_reflector): New static function.
2203         (do_postinstall): Rename to do_postinstall_thread.
2204         Create a thread instead.
2205
2206 2003-03-18  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
2207
2208         * script.cc (run): Add file_out parameter.
2209         Redirect output of subprocess to file, creating the
2210         path if necessary.  Minimize the script window.
2211         (run_script): Add optional to_log boolean parameter.
2212         If to_log, redirect output to temporary file and then
2213         import it into LOG_BABBLE.
2214         (OutputLog): New helper class.
2215         (operator<<): New operation on OutputLog.
2216         * script.h (run_script): Add optional to_log parameter.
2217         * postinstall.cc (RunFindVisitor::visitFile): Instruct
2218         run_script() to log script output.
2219         (do_postinstall): Ditto.
2220
2221 2003-03-20  Robert Collins  <rbtcollins@hotmail.com>
2222
2223         * package_meta.cc (packagemeta::set_action): The logic
2224         test for the default action was reversed.
2225
2226 2003-03-18  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
2227
2228         * postinstall.cc (do_postinstall): Filter out '*.done'.
2229         * FilterVisitor.h: New header file.  Declare the
2230         FilterVisitor, Filter, and ExcludeNameFilter classes.
2231         * FilterVisitor.cc: New file.  Implement FilterVisitor,
2232         Filter, and ExcludeNameFilter.
2233         * String++.h (String::matches): New instance function.
2234         * String++.cc (String::matches): Implement.
2235         (strmatch) Import and adapt for <buf,len> strings.
2236         * Makefile.am (setup_SOURCES): Add FilterVisitor.cc and
2237         FilterVisitor.h to value.
2238
2239 2002-03-18  Max Bowsher  <maxb@ukf.net>
2240
2241         * LogFile.cc (LogFile::exit): Use CRT exit() instead of ExitProcess().
2242         Use passed exit_code even if been_here.
2243         Remove incorrect _CYGWIN_ preprocessor conditional.
2244
2245 2003-03-16  Robert Collins  <rbtcollins@hotmail.com>
2246
2247         * package_db.h (PackageDBConnectedIterator): Typedef
2248         for connected loop detection collection iterator.
2249         * package_db.cc (ConnectedLoopDetector): An
2250         implementation of R.E. Tarjans strongly connected
2251         set visitor algorithm.
2252         * postinstall.cc (do_postinstall): Use the new iterator
2253         for visiting postinstall scripts.
2254
2255 2003-03-16  Robert Collins  <rbtcollins@hotmail.com>
2256
2257         * install.cc: Introduce Installer class.
2258         (init_dialog): Rename to Installer::initDialog.
2259         (progress): Rename to Installer::progress.
2260         (standard_dirs): Rename to Installer::StandardDirs.
2261         (uninstall_one): Rename to Installer::uninstallOne.
2262         (replace_one): Rename to Installer::replaceOne.
2263         (log_ror_failure): Rename to
2264         Installer::replaceOnRebootFailed.
2265         (log_ror_success): Rename to
2266         Installer::replaceOnRebootSucceeded.
2267         (install_one_source): Rename to Installer::installOneSource.
2268         Note script files as they are installed.
2269         * package_version.cc (packageversion::addScript): Implement.
2270         (packageversion::scripts): Implement.
2271         * package_version.h (packageversion::addScript): Record the
2272         presence of a script.
2273         * script.h (Script): New class to track scripts.
2274         * postinstall.cc (do_postinstall): Iterate through the
2275         package listed scripts before searching for scripts.
2276         * String++.cc (String::substr): Second argument needed to
2277         be signed.
2278         * String++.h (String::substr): Second argument needed to
2279         be signed.
2280
2281 2003-03-16  Max Bowsher  <maxb@ukf.net>
2282
2283         * .cvsignore: Create, to ignore configure, aclocal.m4, Makefile.in and
2284         autom4te.cache.
2285
2286 2003-03-16  Max Bowsher  <maxb@ukf.net>
2287
2288         * UserSettings.cc (UserSettings::Instance): Remove premature return.
2289
2290 2003-03-15  Robert Collins  <rbtcollins@hotmail.com>
2291
2292         * script.cc (run): Rename variable b to createSucceeded.
2293
2294 2003-03-15  Igor Pechtchanski <pechtcha@cs.nyu.edu>
2295
2296         * script.cc (run): Close unneeded handles.
2297
2298 2003-03-15  Robert Collins  <rbtcollins@hotmail.com>
2299
2300         * configure: Remove.
2301         * aclocal.m4: Remove.
2302         * Makefile.in: Remove.
2303         * cfgaux: Remove.
2304         * cfgaux/compile: Remove.
2305         * cfgaux/config.guess: Remove.
2306         * cfgaux/config.sub: Remove.
2307         * cfgaux/depcomp: Remove.
2308         * cfgaux/install-sh: Remove.
2309         * cfgaux/ltmain.sh: Remove.
2310         * cfgaux/missing: Remove.
2311         * cfgaux/mkinstalldirs: Remove.
2312
2313 2003-03-14  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
2314
2315         * install.cc (replace_one): Clear Text3.
2316
2317 2003-03-14  Igor Pechtchanski  <pechtcha@cs.nyu.edu>
2318
2319         * install.cc (install_one_source): Add logging for successful
2320         replace-on-reboot scheduling. Factor out duplicate code.
2321         Set rebootneeded on Win9x.
2322         (log_ror_failure): New static function.
2323         (log_ror_success): New static function.
2324
2325 2003-03-14  Robert Collins  <rbtcollins@hotmail.com>
2326
2327         * choose.cc (ChooserPage::OnNext): Fix iterator bug. Reported by
2328         Igor Pechtchanski  <pechtcha@cs.nyu.edu>.
2329
2330 2003-03-13  Max Bowsher  <maxb@ukf.net>
2331
2332         * Update included zlib to 1.1.4.
2333
2334 2003-03-13  Robert Collins  <rbtcollins@hotmail.com>
2335
2336         * install.cc (do_install_thread): Use a query method rather than temp
2337         variable do_skip.
2338
2339 2003-03-09  Pavel Tsekov  <ptsekov@gmx.net>
2340
2341         * install.cc (do_install_thread): Use IDS_SKIP_PACKAGE
2342         instead of IDS_CORRUPT_PACKAGE when asking the user to take
2343         action if the hash verification check fails for a source package.
2344         Do not increase the value of 'total_bytes' variable if the
2345         user chooses to skip over a package, which failed the hash
2346         verification.
2347
2348 2003-03-10  Max Bowsher  <maxb@ukf.net>
2349
2350         * Makefile.am: Add foreign to AUTOMAKE_OPTIONS.
2351
2352 2003-03-10  Robert Collins  <rbtcollins@hotmail.com>
2353
2354         * UserSettings.cc (UserSettings::init): Really initialize all members.
2355
2356 2003-03-10  Robert Collins  <rbtcollins@hotmail.com>
2357
2358         * Exception.h: Add a logic error exception id.
2359         * Makefile.am: Add new sources.
2360         * UserSettings.cc: New file.
2361         * UserSettings.h: New file.
2362         * UserSetting.cc: New file.
2363         * UserSetting.h: New file.
2364         * site.h: Add a SiteSetting as example of a UserSetting.
2365         * site.cc (ChosenSites): Add a instance of SiteSetting to trigger
2366         registration.
2367
2368 2003-03-10  Robert Collins  <rbtcollins@hotmail.com>
2369
2370         * compress_bz.cc (compress_bz::read): Adjust incorrect assignment of
2371         lasterr.
2372         (compress_bz::error): Return lasterr which will indicate any error.
2373
2374 2003-03-10  Robert Collins  <rbtcollins@hotmail.com>
2375
2376         * choose.h (ChooserPage): Override OnActivate.
2377         * choose.cc (ChooserPage::OnActivate): Refresh the current view when
2378         activating the dialog.
2379
2380 2003-03-09  Robert Collins  <rbtcollins@hotmail.com>
2381
2382         * package_version.cc (_defaultversion::pick(bool)): Override this and
2383         do nothing.
2384         (packageversion::pick(bool): Use a mutator function rather than direct
2385         member access.
2386         * package_version.h (_packageversion::pick(bool)): Move method from
2387         _packageversion.
2388
2389 2003-02-16  Pavel Tsekov  <ptsekov@gmx.net>
2390
2391         * install.cc (install_one_source): Remove the MD5 verification
2392         code.
2393         Delay the creation of the package listing file.
2394         (do_install_thread): Check the hashes for packages which need
2395         to be installed before the uninstall step. Allow the user to
2396         skip over packages, which fail the hash verification.
2397         (md5_one): Define new function.
2398         * res.rc (IDS_SKIP_PACKAGE): New string resource.
2399         * resource.h (IDS_SKIP_PACKAGE): New macro definition.
2400
2401 2003-02-16  Pavel Tsekov  <ptsekov@gmx.net>
2402
2403         * Exception.h: Declare new constructor.
2404         (Exception::_message): Change the type from 'const char *' to
2405         'class String'.
2406         (Exception::~Exception): Implement destructor (make gcc shut up).
2407         * Exception.cc: Implement new constructor.
2408         (Exception::what): Use String::cstr_oneuse ().
2409         * download.cc (validateCachedPackage): Use the constructor, which
2410         takes String& as its second argument, when throwing objects
2411         of type Exception.
2412         (check_for_cached): Ditto.
2413         * install.cc (install_one_source): Ditto.
2414
2415 2003-02-01  Igor Pechtchanski <pechtcha@cs.nyu.edu>
2416
2417         * res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
2418         log filename to %s.
2419         (IDS_MISSING_LOG): New string resource.
2420         * resource.h (IDS_MISSING_LOG): New resource.
2421         * LogFile.cc (LogFile::exit): Pass log filename for
2422         LOG_BABBLE to note().
2423         (LogFile::getFileName): New function.
2424         * LogFile.h (LogFile::getFileName): New function.
2425
2426 2003-02-01  Igor Pechtchanski <pechtcha@cs.nyu.edu>
2427
2428         * String++.cc: Don't include concat.h.
2429         * Makefile.am: Remove concat.cc and concat.h references.
2430         * concat.h: Remove.
2431         * concat.cc: Remove.
2432
2433 2003-03-09  Max Bowsher  <maxb@ukf.net>
2434
2435         * bootstrap.sh: Add sanity check of current directory.
2436         Recurse into libgetopt++ if needed.
2437
2438 2003-03-09  Robert Collins  <rbtcollins@hotmail.com>
2439
2440         * Update readme of bugs and wishes.
2441
2442 2003-03-05  Max Bowsher  <maxb@ukf.net>
2443
2444         * netio.cc (save_dialog): Allocate an empty string if the password is
2445         null, so that an empty password is accepted elsewhere in setup.
2446         (check_if_enable_ok): An empty password is OK.
2447
2448 2003-03-05  Brian Keener  <bkeener@thesoftwaresource.com>
2449
2450         * PickView.cc (PickView::views): Add two new views for Skipped
2451         packages and Installed Packages not requiring update.
2452         (PickView::set_headers () ): Ditto.
2453         (PickView::clear_view (void) ): Ditto.
2454         (PickView::views::caption () ): Add two new captions for the new
2455         views added for Skipped and Installed Packages.
2456         (PickView::scroll () ): Modify Scroll Bar property to Disable
2457         instead of disappearing when there is nothing to Scroll.
2458         * PickView.h: Add two new views for Skipped packages and Installed
2459         packages to public class view.
2460         * choose.cc (list_click () ): Modify Scroll Bar property to Disable
2461         instead of disappearing when there is nothing to Scroll.
2462         (listview_proc () ): Ditto.
2463         (set_view_mode): Add two new views for Skipped Packages and Installed
2464         Packages not requiring update.  Modify Scroll Bar property to Disable
2465         instead of disappearing when there is nothing to scroll.
2466         * res.rc (IDD_CHOOSE): Reposition Radio Buttons, View Selection
2467         Button and View Button Caption to make room for longer captions.
2468
2469 2003-03-04  Max Bowsher  <maxb@ukf.net>
2470
2471         * compress_gz.cc (compress_gz::construct):
2472         Fix broken checkin dated 2002-07-03.
2473
2474 2003-02-28  Max Bowsher  <maxb@ukf.net>
2475
2476         * main.cc (set_default_sec): Add logging.
2477
2478 2003-02-28  Pierre Humblet  <pierre.humblet@ieee.org>
2479
2480         * main.cc (set_default_dacl): Replace with set_default_sec.
2481         (set_default_sec): Attempt to change the default group to
2482         Users or Administrators if it is None, in addition to setting
2483         Everyone in the default DACL.
2484         (main): Call set_default_sec instead of set_default_dacl.
2485
2486 2003-01-31  Max Bowsher  <maxb@ukf.net>
2487
2488         * install.cc (install_one_source): Fix spacing in log message.
2489
2490 2003-01-19  Max Bowsher  <maxb@ukf.net>
2491
2492         * resource.h (IDC_CHOOSE_KEEP): Define.
2493         * res.rc (IDD_CHOOSE): Add radio button IDC_CHOOSE_KEEP.
2494         * choose.cc (create_listview): Add IDC_CHOOSE_KEEP to ta[].
2495         (ChooserPage::OnMessageCmd): Handle new IDC_CHOOSE_KEEP button.
2496
2497 2003-01-15  Max Bowsher  <maxb@ukf.net>
2498
2499         * mkdir.cc [_CYGWIN_]: Implement what was pseudocode.
2500         * io_stream.h [__CYGWIN__]: Don't typedef ssize_t.
2501         * proppage.h: Include "win32.h" instead of <windows.h>.
2502
2503 2003-01-15  Max Bowsher  <maxb@ukf.net>
2504
2505         * mount.cc [MAINTAINER_FEATURES]: Add --override-registry-name option.
2506
2507 2002-12-11  Abraham Backus  <abraham@backus.com>
2508
2509         * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Leave port out of Host header,
2510         unless non-default.
2511
2512 2002-12-11  Max Bowsher  <maxb@ukf.net>
2513
2514         * package_meta.cc: Change 'endl' to 'endLog' as appropriate.
2515         * package_version.cc: Ditto.
2516
2517 2002-09-22  Max Bowsher  <maxb@ukf.net>
2518
2519         * PickView.cc (pkg_headers): Rename column 'Category' to 'Categories'.
2520         * package_meta.h (packagemeta::getReadableCategoryList): Declare.
2521         * package_meta.cc (packagemeta::getReadableCategoryList): Implement.
2522         * PickPackageLine.cc (PickPackageLine::paint): Change to use
2523         getReadableCategoryList.
2524         Fix x2 argument to IntersectClipRect.
2525
2526 2002-11-25  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
2527
2528         * window.h (Window::GetWindowRect): New method declaration.
2529         (Window::GetClientRect): Ditto.
2530         (Window::MoveWindow): Ditto.
2531         (Window::ScreenToClient): Ditto.
2532         * window.cc (REFLECTION_INFO): Remove.
2533         (ReflectionInfo): Remove.
2534         (Window::FirstWindowProcReflector): Use the WM_NCCREATE message instead
2535         of the horrid REFLECTION_INFO hack to hook the Window instance to the
2536         HWND instance.
2537         (Window::WindowProcReflector): Use GetWindowLongPtr() now that it's
2538         available.
2539         (Window::Create): Change to use new WM_NCCREATE reflection procedure
2540         above.
2541         (Window::GetWindowRect): New method.
2542         (Window::GetClientRect): New method.
2543         (Window::MoveWindow): New method.
2544         (Window::CenterWindow): Use new methods, also specify "::" for some non-
2545         member functions with the same names.
2546         (Window::ScreenToClient): New method.
2547
2548 2002-11-26  Robert Collins  <rbtcollins@hotmail.com>
2549
2550         * AntiVirus.cc: Change the short option again! It's now 'A'.
2551         * desktop.cc (etc_profile): Remove.
2552         (make_etc_profile): Remove.
2553         (uexists): Remove.
2554         (make_passwd_group): Remove.
2555         (do_desktop_setup): Don't call removed functions.
2556
2557 2002-11-26  Robert Collins  <rbtcollins@hotmail.com>
2558
2559         * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fix my botched application of
2560         Marcel's patch.
2561
2562 2002-07-08  Marcel Telka  <marcel@telka.sk>
2563
2564         * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Fixed decoding of the FTP
2565         reply (code 227) to the PASV command.
2566
2567 2002-11-26  Robert Collins  <rbtcollins@hotmail.com>
2568
2569         * IniDBBuilderPackage.cc (IniDBBuilderPackage::~IniDBBuilderPackage):
2570         Sort the packages db once all the new packages have been added.
2571         * IniDBBuilderPackage.h (IniDBBuilderPackage::~IniDBBuilderPackage):
2572         Declare this.
2573
2574 2002-11-26  Robert Collins  <rbtcollins@hotmail.com>
2575
2576         * choose.cc (ChooserPage::OnNext): Remove extracted comment.
2577         * package_version.cc (processOneDependency): Return once selecting
2578         a package (bugfix to prevous rework).
2579         Log if the default trust fails the package specification.
2580
2581 2002-11-26  Robert Collins  <rbtcollins@hotmail.com>
2582
2583         * package_meta.h (packagemeta::logAllVersions): Declare.
2584         (packagemeta::trustLabel): Ditto.
2585         * choose.cc (ChooserPage::OnNext): Get each package to log all it's
2586         versions.
2587         * package_meta.cc (packagemeta::logAllVersions): Implement.
2588         (packagemeta::trustLabel): Ditto.
2589
2590 2002-11-25  Robert Collins  <rbtcollins@hotmail.com>
2591
2592         * AntiVirus.cc: Change 'd' to 'D' to fix command line conflict.
2593
2594 2002-11-25  Robert Collins  <rbtcollins@hotmail.com>
2595
2596         * AntiVirus.cc: New file.
2597         * AntiVirus.h: Ditto.
2598         * LogFile.cc: Include AntiVirus.h for class definition.
2599         (LogFile::exit): Trigger AntiVirus::AtExit().
2600         * MakeFile.am(setup_SOURCES): Add AntiVirus files.
2601         * autoload.c: Declare Service Control Manager related API's.
2602         * main.cc: Include AntiVirus.h for class definition.
2603         (main): Add the AntiVirus page in.
2604         * res.rc: Define IDD_VIRUS.
2605         * resource.h: Define IDD_VIRUS related control ID's.
2606         * splash.h: Override OnNext.
2607         * splash.cc: Only show AntiVirus page when one has been detected.
2608         * source.cc: Ditto.
2609
2610 2002-11-25  Robert Collins  <rbtcollins@hotmail.com>
2611
2612         * package_version.cc (DependencyProcessor): Create convenience class.
2613         (select): Extract version selection method.
2614         (processOneDependency): Check for a satisfactory trusted version
2615         first.
2616
2617 2002-11-10  Robert Collins  <rbtcollins@hotmail.com>
2618
2619         * main.cc (main): Use the factory for LogFile.
2620         * String++.cc: Update to use sstream.
2621         (String::String): Use a ostringstream for libC++ 3.2.
2622         * LogFile.h (LogFile): Make createLogFile static.
2623
2624 2002-11-10  Robert Collins  <rbtcollins@hotmail.com>
2625
2626         * main.cc (main): Oops, pass LogSingleton a reference, not a pointer.
2627
2628 2002-11-04  Max Bowsher  <maxb@ukf.net>
2629
2630         * Exception.h (Exception::what): Add throw() specification,
2631         to agree with libstdc++-v3.
2632         * Exception.cc (Exception::what): Ditto.
2633         * IniDBBuilderPackage.h: Add 'std::' where needed.
2634         * PickCategoryLine.h: Ditto.
2635         * category.h: Ditto.
2636         * package_db.h: Ditto.
2637         * package_meta.h: Ditto.
2638         * package_source.h: Ditto.
2639         * package_version.h: Ditto.
2640         * site.h: Ditto.
2641         * win32.h: Define NOMINMAX before including <windows.h>.
2642         * package_meta.cc: Add 'using namespace std;'.
2643         (packagemeta::set_requirements): Remove default parameter values
2644         from definition (gcc3 likes them only in declaration).
2645         * package_version.cc: Add 'using namespace std;'.
2646         (packageversion::set_requirements): Remove default parameter
2647         values from definition (gcc3 likes them only in declaration).
2648
2649 2002-11-10  Robert Collins <rbtcollins@hotmail.com>
2650
2651         * compress_bz.cc: Don't include bzlib.h directly, the compress_bz.h
2652         header includes it.
2653
2654 2002-11-04  Max Bowsher  <maxb@ukf.net>
2655
2656         * compress_bz.h: #undef small before including bzlib.h - if we are
2657         going to hide the fact that we are _WIN32 from bzlib, then we need
2658         to #undef small for it as well (bad windows.h clash).
2659
2660 2002-11-10  Robert Collins  <rbtcollins@hotmail.com>
2661
2662         * localdir.cc: Update the extern LogFile to be a pointer.
2663         (save_local_dir): Change . to -> for the above.
2664         * main.cc (theFile): Change from an instance to a pointer.
2665         (main): Change . to -> for the above.
2666
2667 2002-11-10  Robert Collins  <rbtcollins@hotmail.com>
2668
2669         * LogFile.cc: use 'std::' where needed throughout.
2670         (LogFile::createLogFile): Implement a factory for LogFile.
2671         (LogFile::LogFile): Update for use with the factory, and to
2672         handle the latest g++ library changes.
2673         (LogFile::operator()): Ditto.
2674         (LogFile::endEntry()): Ditto.
2675         * LogFile.h: Ditto.
2676         * LogSingleton.cc: Ditto.
2677         * LogSingleton.h: Ditto.
2678
2679 2002-11-04  Max Bowsher  <maxb@ukf.net>
2680
2681         * String++.h: Add 'std::' where needed.
2682
2683 2002-11-04  Max Bowsher  <maxb@ukf.net>
2684
2685         * IniDBBuilderPackage.cc: Add 'using namespace std;'.
2686         * IniParseFindVisitor.cc: Ditto.
2687         * LogFile.cc: Ditto.
2688         * LogSingleton.cc: Ditto.
2689         * PickView.cc: Ditto.
2690         * String++.cc: Ditto.
2691         * choose.cc: Ditto.
2692         * download.cc: Ditto.
2693         * find.cc: Ditto.
2694         * install.cc: Ditto.
2695         * io_stream.cc: Ditto.
2696         * io_stream_file.cc: Ditto.
2697         * package_db.cc: Ditto.
2698         * root.cc: Ditto.
2699         * site.cc: Ditto.
2700
2701 2002-11-04  Max Bowsher  <maxb@ukf.net>
2702
2703         * LogSingleton.h: Add 'std::' where needed.
2704
2705 2002-11-04  Max Bowsher  <maxb@ukf.net>
2706
2707         * archive_tar_file.cc: Include <algorithm>.
2708         Change min(a,b) to std::min(a,b)
2709         * compress_bz.cc: Ditto.
2710         * compress_gz.cc: Ditto.
2711
2712 2002-11-04  Max Bowsher  <maxb@ukf.net>
2713
2714         * res.rc: Change a #-comment (invalid) to a //-comment.
2715
2716 2002-11-04  Max Bowsher  <maxb@ukf.net>
2717
2718         * Makefile.am (%.o: %.rc): Make windres use $(CC) not hardcoded gcc.
2719         (inilint_LDADD): Remove -lstd++.
2720         (setup_LDADD): Ditto.
2721
2722 2002-09-22  Max Bowsher  <maxb@ukf.net>
2723
2724         * IniDBBuilderPackage.cc: Update DEBUG code to current class
2725         layout.
2726
2727 2002-09-21  Robert Collins  <rbtcollins@hotmail.com>
2728
2729         * choose.h: Add OnUnattended method.
2730         * desktop.cc (DesktopSetupPage::OnInit): Allow fine grained
2731         control via command line options.
2732         (DesktopSetupPage::OnUnattended): Implement.
2733         (DesktopSetupPage::OnMessageApp): Implement.
2734         * desktop.h (DesktopSetupPage::OnUnattended): declare.
2735         (DesktopSetupPage::OnMessageApp): Ditto.
2736         * download.cc (do_download_thread): Support unattended mode.
2737         * install.cc (do_install_thread): Ditto.
2738         * localdir.h: Ditto.
2739         * main.cc (main): Ditto.
2740         * net.cc (NetPage::OnUnattended): Ditto.
2741         * net.h (NetPage::OnUnattended): Declare.
2742         * proppage.cc (PropertyPage::DialogProc): Support unattended mode.
2743         * proppage.h (PropertyPage::OnUnattended): Declare.
2744         * root.cc (RootPage::OnInit): Support unattended mode.
2745         (RootPage::OnUnattended): Implement.
2746         * root.h (RootPage::OnUnattended): Declare.
2747         * site.cc (register_saved_site): Extract Method from get_saved_sites.
2748         (get_saved_sites): Remove common code for adding a site.
2749         (SitePage::OnInit): Support unattended mode.
2750         (SitePage::OnUnattended): Implement.
2751         * site.h (SitePage::OnUnattended): Declare.
2752         * source.cc (SourcePage::OnActivate): Support unattended mode.
2753         (SourcePage::OnUnattended): Implement.
2754         * source.h (SourcePage::OnUnattended): Declare.
2755         * splash.h (SplashPage::OnUnattended): Declare.
2756         * state.cc (unattended_mode): Declare.
2757         * state.h (unattended_mode): Declare.
2758         * threebar.h (ThreeBarProgressPage::OnUnattended): New method.
2759
2760 2002-09-21  Robert Collins  <rbtcollins@hotmail.com>
2761
2762         * res.rc: Commit Harry Johnston's dialog caption patch. From July.
2763
2764 2002-07-15  Robert Collins  <rbtcollins@hotmail.com>
2765
2766         * package_version.cc (packageversion::sources): Implement this.
2767         * download.cc (do_download_thread): Support multiple files per package.
2768
2769 2002-07-15  Robert Collins  <rbtcollins@hotmail.com>
2770
2771         * package_version.h (packageversion::sources): Support multiple files in
2772         a single package version.
2773         * package_version.cc (_packageversion::accessible): Ditto.
2774         (packageversion::source): Ditto.
2775
2776 2002-07-15  Robert Collins  <rbtcollins@hotmail.com>
2777
2778         * iniparse.y: Implement support for multiple source files for a source
2779         package.
2780         * IniDBBuilder.h (IniDBBuilder::buildSourceFile): Ditto.
2781         * IniDBBuilderPackage.h (IniDBBuilder::buildSourceFile): Ditto.
2782         * IniDBBuilder.cc (IniDBBuilder::buildSourceFile): Ditto.
2783         * IniDBBuilderPackage.cc (IniDBBuilder::buildSourceFile): Implement a
2784         stub as preparation.
2785
2786 2002-07-13  Robert Collins  <rbtcollins@hotmail.com>
2787
2788         * PickPackageLine.cc (PickPackageLine::click): Set requirements for
2789         packages under all circumstances - slightly higher overheader, simpler
2790         code.
2791         * download.cc (do_download_thread): Correctly download source
2792         packages.
2793         * package_meta.cc (checkForInstalled): Remove.
2794         (checkForUpgradeable): Ditto.
2795         (checkForSatisfiable): Ditto.
2796         (processOneDependency): Ditto.
2797         (packagemeta::set_requirements): Move guts to packageversion.
2798         * package_version.cc (checkForInstalled): Copied from package_meta.cc.
2799         (checkForUpgradeable): Ditto.
2800         (checkForSatisfiable): Ditto.
2801         (processOneDependency): Ditto.
2802         (packageversion::set_requirements): Ditto.
2803         * package_version.h (packageversion::set_requirements): Declare.
2804
2805 2002-07-13  Robert Collins  <rbtcollins@hotmail.com>
2806
2807         * IniDBBuilder.cc (IniDBBuilder::buildBeginBuildDepends): Implement.
2808         (IniDBBuilder::buildBeginBinary): Implement.
2809         * IniDBBuilder.h (IniDBBuilder::buildBeginBuildDepends): Declare.
2810         (IniDBBuilder::buildBeginBinary): Ditto.
2811         * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildBeginBuildDepends):
2812         Implement.
2813         (IniDBBuilderPackage::buildBeginBinary): Ditto.
2814         * IniDBBuilderPackage.h (IniDBBuilderPackage::buildBeginBuildDepends):
2815         Declare.
2816         (IniDBBuilderPackage::buildBeginBinary): Ditto.
2817         * inilex.l: Recognise Build-Depends-Indep, [,], >, < and remove
2818         T_UNKNOWN.
2819         * iniparse.y: Full support for parsing a debian Sources file in-line in
2820         setup.ini.
2821         * package_version.cc (packageversion::binaries): Implement.
2822         * package_version.h (packageversion::binaries): Declare list of what
2823         packages are created from a given source package.
2824         (_packageversion::binaries): Ditto.
2825
2826 2002-07-10  Robert Collins  <rbtcollins@hotmail.com>
2827
2828         * iniparse.y: Add basis for support for parsing a debian Sources file.
2829         * inilex.l: Ditto.
2830
2831 2002-07-09  Robert Collins  <rbtcollins@hotmail.com>
2832
2833         Change custom container code for packagedb::packages to STL containers
2834         throughout.
2835         * IniDBBuilderPackage.cc: Ditto.
2836         * PickView.cc: Ditto.
2837         * choose.cc: Ditto.
2838         * desktop.cc: Ditto.
2839         * download.cc: Ditto.
2840         * install.cc: Ditto.
2841         * package_db.cc: Ditto.
2842         * package_db.h: Ditto.
2843         * Makefile.am: Remove list.h references.
2844         * list.h: Remove.
2845
2846 2002-07-08  Max Bowsher  <maxb@ukf.net>
2847
2848         * PickView.cc (PickView::PickView): Set font of package list header to
2849         the same as used in the rest of the package list.
2850
2851 2002-07-08  Robert Collins  <rbtcollins@hotmail.com>
2852
2853         * install.cc (NoReplaceOnReboot): New command line option to prevent
2854         replacing in use files.
2855         (install_one_source): Check the option and use it.
2856         * README: Update TODO lists.
2857
2858 2002-07-08  Robert Collins  <rbtcollins@hotmail.com>
2859
2860         * PickCategoryLine.cc: Change bucket to use STL container syntax
2861         throughout.
2862         (PickCategoryLine::paint): Use new Category type syntax.
2863         * PickCategoryLine.h: Use STL vectors rather than custom containers
2864         throughout.
2865         * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageCategory):
2866         Use new add_category syntax.
2867         * PickView.cc (PickView::insert_pkg): Use new Category type syntax.
2868         (PickView::insert_category): Ditto.
2869         (PickView::init_headers): Ditto.
2870         * category.cc: Trim obsolete code.
2871         * category.h: Replace interconnecting class with a typedef to
2872         facilitate leveraging STL maps.
2873         * choose.cc (fill_missing_category): Use updated pkg.add_category
2874         syntax.
2875         (default_trust): Use new Category type syntax.
2876         (set_view_mode): Ditto.
2877         (create_listview): Ditto.
2878         * package_db.cc (categories): Ditto.
2879         * package_db.h: Update headers list to include needed headers.
2880         (packagedb::categories): Replace custom list with STL map.
2881         * package_meta.cc: Use new Category type syntax throughout.
2882         (packagemeta::add_category): Implement new syntax.
2883         * package_meta.h: Remove commented out source.
2884         (packagemeta::add_category): Update syntax to decouple interface from
2885         packagedb.
2886
2887 2002-07-06  Christopher Faylor  <cgf@redhat.com>
2888
2889         * site.cc (do_download_site_info_thread): Correct spelling error.
2890
2891 2002-07-06  Robert Collins  <rbtcollins@hotmail.com>
2892
2893         * PickCategoryLine.h: Include required header list.h.
2894         * PickPackageLine.cc (PickPackageLine::paint): Adjust to use STL
2895         containers for listing of packages per category and vice verca.
2896         * PickView.cc (PickView::insert_pkg): Ditto.
2897         (PickView::insert_category): Ditto.
2898         * String++.h (String::caseless): STL helper to allow trivial containers
2899         of Strings with case insensitive comparisons.
2900         * category.h: Adjust to use STL containers for listing of packages per
2901         category and vice verca.
2902         * choose.cc (fill_missing_category): Ditto.
2903         (default_trust): Ditto.
2904         (ChooserPage::OnNext): Ditto.
2905         * package_meta.cc (CategoryPackage::~CategoryPackage): Remove.
2906         (packagemeta::packagemeta): Adjust for new category list name.
2907         (packagemeta::~packagemeta): Adjust to use STL containers for listing
2908         of packages per category and vice verca.
2909         (packagemeta::set_action): Ditto.
2910         * package_meta.h (CategoryPackage): Remove.
2911         (packagemeta): Adjust to use STL containers for listing of packages per
2912         category and vice verca.
2913
2914 2002-07-05  Robert Collins  <rbtcollins@hotmail.com>
2915
2916         * io_stream.cc: Use STL containers rather than custom ones.
2917         (io_stream::registerProvider): Ditto.
2918         (findProvider): Ditto.
2919
2920 2002-07-05  Robert Collins  <rbtcollins@hotmail.com>
2921
2922         * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
2923         Use STL collections for download site collections.
2924         (IniDBBuilderPackage::add_correct_version): Ditto.
2925         (IniDBBuilderPackage::process_src): Ditto.
2926         * PickPackageLine.cc (PickPackageLine::click): Use the packageversion
2927         accessible() call to abstract package availability.
2928         * choose.cc (scanAVersion): Use STL collections for download site
2929         collections.
2930         * download.cc (check_for_cached): Ditto.
2931         (download_one): Ditto.
2932         * package_meta.cc (packagemeta::set_action): Use the packageversion
2933         accessible() call to abstract package availability.
2934         * package_source.h: Use STL containers rather than custom containers.
2935         (site): Create a == operator to allow STL container use.
2936         (packagesource::sites): Use STL containers rather than custom
2937         containers.
2938         * package_version.cc (_packageversion::accessible): Use STL containers
2939         for download site containers.
2940
2941 2002-07-05  Robert Collins  <rbtcollins@hotmail.com>
2942
2943         * LogFile.cc: Use STL containers rather than custom containers.
2944         (filedef): Create == and < operators for STL use.
2945         (files): Convert to an STL set.
2946         (LogFile::setFile): Use STL operations on files.
2947         (LogFile::exit): Ditto.
2948
2949 2002-07-05  Robert Collins  <rbtcollins@hotmail.com>
2950
2951         * ini.cc (do_remote_ini): Use STL collection for site collection.
2952         * site.cc: Include site.h first to ensure it's parsable standalone.
2953         Use STL algorithms.
2954         (site_list): Convert to an STL container.
2955         (all_site_list): Ditto.
2956         (site_list_type::site_list_type): Implement copy constructor.
2957         (site_list_type::operator=): Implement assignment operator.
2958         (site_list_type::operator ==): Implement.
2959         (site_list_type::operator <): Ditto.
2960         (save_dialog): Use STL collection calls for site collection.
2961         (save_site_url): Ditto.
2962         (get_site_list): Ditto.
2963         (get_saved_sites): Ditto.
2964         (do_download_site_info_thread): Ditto.
2965         (SitePage::OnNext): Ditto.
2966         (SitePage::PopulateListBox): Ditto.
2967         (SitePage::OnMessageCmd): Ditto.
2968         * site.h: Use STL vectors instead of custom code.
2969         (site_list_type::site_list_type): Declare.
2970         (site_list_type::operator=): Ditto.
2971         (site_list_type::operator ==): Ditto.
2972         (site_list_type::operator !=): Ditto.
2973         (site_list_type::operator <): Ditto.
2974         (site_list_type::operator <=): Ditto.
2975         (site_list_type::operator >): Ditto.
2976         (site_list_type::operator >=): Ditto.
2977         (site_list): Convert to an STL container.
2978         (all_site_list): Ditto.
2979
2980 2002-07-05  Robert Collins  <rbtcollins@hotmail.com>
2981
2982         * choose.cc (default_trust): Check package accessibility before
2983         triggering an install. (Suggested by Pavel).
2984
2985 2002-07-03  Pavel Tsekov  <ptsekov@gmx.net>
2986
2987         * compress_gz.cc (compress_gz::construct): Always initialize key members
2988         to ensure the destructor does the right thing.
2989
2990 2002-07-03  Pavel Tsekov  <ptsekov@gmx.net>
2991
2992         * filemanip.cc (parse_filename): Do not try to parse empty
2993         strings (filenames).
2994         * package_db.cc (packagedb::packagedb): For each line check if sscanf()
2995         extracted good package name and filename.
2996
2997 2002-07-03  Robert Collins  <rbtcollins@hotmail.com>
2998
2999         * package_meta.cc (packagemeta::set_requirements): Automatically select
3000         version of dependent packages that satisfies the requirements.
3001         Use processOneDependency to trigger the install of those packages.
3002         (checkForInstalled): Check that the package remains installed.
3003         (processOneDependency): Helper function for dependent packages.
3004         * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackage): Add more
3005         debug information.
3006         Clear out all current state on new packages.
3007         (IniDBBuilderPackage::add_correct_version): Copy the dependency list
3008         across.
3009
3010 2002-07-02  Robert Collins  <rbtcollins@hotmail.com>
3011
3012         * Makefile.am (inilint_SOURCES): Add PackageSpecification sources.
3013         nb: inilint is still incomplete, as the packageversion code is not
3014         ready for database-less linking.
3015         * site.cc (get_site_list): When the same site is reentered by the user
3016         replace the old one. (Suggested by John Marshall).
3017
3018 2002-07-02  Robert Collins  <rbtcollins@hotmail.com>
3019
3020         * IniDBBuilderPackage.cc (IniDBBuilderPackage::buildPackageSource):
3021         Clear out package selections when generating implicit source packages.
3022         * PackageSpecification.cc (PackageSpecification::satisfies): Implement.
3023         (PackageSpecification::_operators::satisfies): Implement.
3024         * PackageSpecification.h (PackageSpecification::_operators::satisfies):
3025         Worker function for testing versions.
3026
3027 2002-07-01  Robert Collins  <rbtcollins@hotmail.com>
3028
3029         * IniDBBuilder.cc (IniDBBuilder::buildPackageRequirement): Remove.
3030         * IniDBBuilder.h (IniDBBuilder::buildPackageRequirement): Ditto.
3031         * IniDBBuilderPackage.cc: Use the STL algorithms.
3032         Change cpv to cbpv throughout. Adjust -> to ., and use the new accessor
3033         functions for the same variable throughout.
3034         (IniDBBuilderPackage::IniDBBuilderPackage): Initialise new members.
3035         (IniDBBuilderPackage::buildPackage): Use new cygpackage syntax,
3036         and set an empty source package.
3037         (IniDBBuilderPackage::buildPackageInstall): Use the new source member
3038         to record an install package.
3039         (IniDBBuilderPackage::buildPackageSource): Move source package logic
3040         out from process_src, as it now occurs at separate times.
3041         (IniDBBuilderPackage::buildPackageRequirement): Remove.
3042         (IniDBBuilderPackage::buildSourceName): Use renamed package
3043         specifiation accessor for clarity.
3044         (IniDBBuilderPackage::buildSourceNameVersion): Ditto.
3045         (IniDBBuilderPackage::add_correct_version): Use STL iterators rather
3046         than custom code.
3047         Remove source package references.
3048         (IniDBBuilderPackage::process_src): Remove source package code as it's
3049         now handled separately.
3050         Set Path information before merging versions, to prevent dangling
3051         pointers.
3052         * IniDBBuilderPackage.h (IniDBBuilderPackage::buildPackageRequirement):
3053         Remove.
3054         (IniDBBuilderPackage::cpv): Remove.
3055         (IniDBBuilderPackage::cbpv): New generic binary working variable.
3056         (IniDBBuilderPackage::cspv): Ditto, but for source packages.
3057         (IniDBBuilderPackage::csp): Source package variable for disjoint
3058         source packages.
3059         * Makefile.am (AM_CFLAGS): Remove -Winline to allow stl set code
3060         to compile. If it compiles cleanly in gcc 3.1, then reinstate.
3061         * PickPackageLine.cc: Adjust packageversion accessors to the new
3062         reference calls. (i.e. -> to .) throughout.
3063         (PickPackageLine::paint): Use accessible() for clarity.
3064         Use new split out source package logic.
3065         (PickPackageLine::click): Ditto.
3066         * PickView.cc (PickView::init_headers): Adjust packageversion accessors
3067         to the new reference calls. (i.e. -> to .) throughout.
3068         Use new split out source package logic.
3069         * choose.cc: Don't depend on a specific package type.
3070         Adjust packageversion accessors to the new reference calls. (i.e. -> to
3071         .) throughout.
3072         (set_existence): Use accessible () for clarity.
3073         (default_trust): Simplify a little.
3074         (scanAVersion): Factored out code from scan_downloaded_files for
3075         clarity.
3076         (scan_downloaded_files): Factor out inner loop for clarity.
3077         (ChooserPage::OnNext): Don't dump the dependency list,
3078         it's parsing is robust now!.
3079         * cygpackage.cc (createInstance): Use a factory method to create new
3080         objects.
3081         (cygpackage::cygpackage): Make this private for use by the factory.
3082         (cygpackage::setCanonicalVersion): Renamed from set_canonical_version.
3083         Remove key usage as it's obsolete.
3084         * cygpackage.h (cygpackage): Inherit from _packageversion, not
3085         packageversion.
3086         (cygpackage::createInstance): New factory.
3087         (cygpackage::cygpackage): Make private.
3088         * desktop.cc (make_passwd_group): Use new packageversion reference.
3089         * download.cc (do_download_thread): Use changeRequested() for clarity.
3090         Use new packageversion reference calls.
3091         * iniparse.y (REQUIRES): Reuse the packageList code and dump the one-off
3092         requires code.
3093         * install.cc: Adjust -> to ., and use the new accessor functions for
3094         packageversion throughout.
3095         * package_db.cc: Adjust -> to ., and use the new accessor functions for
3096         packageversion throughout.
3097         (packagedb::packagedb): Use the new cygpackage factory.
3098         (packagedb::flush): Leverage String to remove buffer overflow chance in
3099         sprintf.
3100         (packagedb::findBinary): Find a binary meta package that has a version
3101         matching a given specification.
3102         (packagedb::findSource): Ditto, but for source.
3103         * package_db.h (packagedb::findBinary): Declare.
3104         (packagedb::findSource): Ditto.
3105         * package_meta.cc: Adjust packageversion accessors to the new
3106         reference calls. (i.e. -> to .) throughout.
3107         Include the package_meta header first to ensure it parses standalone.
3108         Use the STL algorithms.
3109         (packagemeta::packagemeta): Create a copy constructor to allowing
3110         cloning binary package metadata to source package metadata.
3111         (packagemeta::~packagemeta): Use the STL coleltion code rather than
3112         custom  collection code.
3113         (packagemeta::add_version): Ditto.
3114         (packagemeta::set_installed): Ditto.
3115         (packagemeta::SDesc): Ditto.
3116         (hasSDesc): Helper function for find_if.
3117         (checkForInstalled): Ditto.
3118         (checkForUpgradeable): Ditto.
3119         (checkForSatisfiable): Ditto.
3120         (packagemeta::action_caption): Update for split out source packages.
3121         (packagemeta::set_action): Ditto.
3122         (packagemeta::set_requirements): Support multi-valued dependency
3123         lists - a|b & c|d - with versioned package specifications.
3124         (packagemeta::accessible): Helper member to improve abstraction.
3125         (packagemeta::sourceAccessible): Ditto.
3126         * package_meta.h: Adjust packageversion accessors to the new
3127         reference calls. (i.e. "->" to "." and"*" to "" ) throughout.
3128         (packagemeta::packagemeta): Declare copy constructor.
3129         Remove self initialising members.
3130         (packagemeta::set_action): Update parameters for new packageversion.
3131         (packagemeta::trustp): Ditto.
3132         (packagemeta::versions): Becomes an STL set.
3133         * package_source.h (packagesource::Cached): Const correctness change.
3134         * package_version.cc: Rewrite the packageversion interface to remove
3135         the cygpackage nonvirtual members, and provide a copy by value,
3136         pointer semantics reference counting wrapper class to ease use and
3137         comparison of packageversions.
3138         Change existing packageversion class to _packageversion throughout.
3139         (_defaultversion): A trivial concrete class to prevent specialcasing
3140         the default constructor for packageversion;
3141         (packageversion::packageversion): Implement.
3142         (packageversion::~packageversion): Ditto.
3143         (packageversion::operator=): Ditto.
3144         (packageversion::operator !): Ditto.
3145         (packageversion::operator bool): Ditto.
3146         (packageversion::operator ==): Ditto.
3147         (packageversion::operator !=): Ditto.
3148         (packageversion::operator <): Ditto.
3149         (packageversion::Name): Ditto.
3150         (packageversion::Canonical_version): Ditto.
3151         (packageversion::setCanonicalVersion): Ditto.
3152         (packageversion::getfirstfile): Ditto.
3153         (packageversion::getnextfile): Ditto.
3154         (packageversion::SDesc): Ditto.
3155         (packageversion::set_sdesc): Ditto.
3156         (packageversion::LDesc): Ditto.
3157         (packageversion::set_ldesc): Ditto.
3158         (packageversion::sourcePackage): Ditto.
3159         (packageversion::sourcePackageSpecification): Ditto.
3160         (packageversion::setSourcePackageSpecification): Ditto.
3161         (packageversion::depends): Ditto.
3162         (packageversion::predepends): Ditto.
3163         (packageversion::recommends): Ditto.
3164         (packageversion::suggests): Ditto.
3165         (packageversion::replaces): Ditto.
3166         (packageversion::conflicts): Ditto.
3167         (packageversion::provides): Ditto.
3168         (packageversion::picked): Ditto.
3169         (packageversion::pick): Ditto.
3170         (packageversion::changeRequested): Ditto.
3171         (packageversion::uninstall): Ditto.
3172         (packageversion::source): Ditto.
3173         (packageversion::accessible): Ditto.
3174         (_packageversion::sourcePackage): Ditto.
3175         (_packageversion::accessible): Ditto.
3176         (_packageversion::changeRequested): Ditto.
3177         * package_version.h: Rewrite the packageversion interface to remove
3178         the cygpackage nonvirtual members, and provide a copy by value,
3179         pointer semantics reference counting wrapper class to ease use and
3180         comparison of packageversions.
3181         Change existing packageversion class to _packageversion throughout.
3182         (Dependency): Remove.
3183         (packageversion): New wrapper class.
3184         (_packageversion): Renamed from packageversion.
3185         (_packageversion::setCanonicalVersion): New method.
3186         (_packageversion::sourcePackage): Ditto.
3187         (_packageversion::sourcePackageSpecification): Ditto.
3188         (_packageversion::setSourcePackageSpecification): Ditto.
3189         (_packageversion::changeRequested): Ditto.
3190         (_packageversion::bin): Rename to source.
3191         (_packageversion::src): Remove.
3192         (_packageversion::accessible): New method.
3193         (_packageversion::references): Allow reference counting.
3194         (_packageversion::sourceVersion): Cached the best-match source
3195         package version.
3196
3197 2002-06-27  Robert Collins  <rbtcollins@hotmail.com>
3198
3199         * compress_bz.h (compress_bz::position): Track how much has been read.
3200         * compress_bz.cc (compress_bz::compress_bz): And initialise it.
3201         (compress_bz::read): Track amount read by the client.
3202         (compress_bz::tell): And report it when asked.
3203
3204 2002-06-27  Robert Collins  <rbtcollins@hotmail.com>
3205
3206         * Makefile.am (snapshot): Automate snapshot creation some more.
3207
3208 2002-06-27  Robert Collins  <rbtcollins@hotmail.com>
3209
3210         * msg.cc (msg): Use vsnprintf to avoid buffer overflows.
3211         (mbox): Ditto.
3212         * ini.cc (fprintf): Ditto.
3213         * log.cc (log): Ditto.
3214         * package_db.cc (packagedb::sourcePackages): Split out source packages
3215         from binary packages.
3216         * package_db.h: Ditto.
3217
3218 2002-06-27  Robert Collins  <rbtcollins@hotmail.com>
3219
3220         * PackageSpecification.h: New file. Abstracts the ability to refer
3221         to another package, by name, or name and version.
3222         * PackageSpecification.cc: Ditto.
3223         * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Simplify.
3224         (IniDBBuilder::buildPackageSource): Ditto.
3225         (IniDBBuilder::buildBeginDepends): New method for versioned
3226         dependencies.
3227         (IniDBBuilder::buildBeginPreDepends): Likewise, for dependencies to be
3228         satisfied before pre-install.
3229         (IniDBBuilder::buildPriority): New method, for getting the package
3230         Priority.
3231         (IniDBBuilder::buildInstalledSize): How much disk space does it need?
3232         (IniDBBuilder::buildMaintainer): Who maintains the package?
3233         (IniDBBuilder::buildArchitecture): What platform is it for?
3234         (IniDBBuilder::buildInstallSize): How big is the binary download?
3235         (IniDBBuilder::buildInstallMD5): Whats the MD5 on the binary?
3236         (IniDBBuilder::buildSourceMD5): Whats the MD5 on the source package?
3237         (IniDBBuilder::buildBeginRecommends): What other packages are
3238         recommended with this one?
3239         (IniDBBuilder::buildBeginSuggests): And suggested?
3240         (IniDBBuilder::buildBeginReplaces): What packages does this replace?
3241         (IniDBBuilder::buildBeginConflicts): And collide with?
3242         (IniDBBuilder::buildBeginProvides): What virtual packages (or obsolete
3243         package names) does this provide?
3244         (IniDBBuilder::buildDescription): Grab a multi line description one
3245         line at a time.
3246         (IniDBBuilder::buildSourceName): What source package should be used to
3247         install the source for this binary package?
3248         (IniDBBuilder::buildSourceNameVersion): Is a specific version needed?
3249         (IniDBBuilder::buildPackageListAndNode): Add another AND clause to a
3250         list of package specifications.
3251         (IniDBBuilder::buildPackageListOrNode): Add another OR clause.
3252         (IniDBBuilder::buildPackageListOperator): Add a versioning operator
3253         to the current specification.
3254         (IniDBBuilder::buildPackageListOperatorVersion): What version does the
3255         operator act on?
3256         * IniDBBuilder.h: Declare all the IniDBBuilder.cc changes.
3257         * IniDBBuilderPackage.cc: As for IniDBBuilder.cc.
3258         (IniDBBuilderPackage::IniDBBuilderPackage): Iniitialize new members.
3259         (IniDBBuilderPackage::process_src): Streamline and split out
3260         functionality.
3261         (IniDBBuilderPackage::setSourceSize): From process_src.
3262         * IniDBBuilderPackage.h: Declare the IniDBBuilderPackage.cc changes.
3263         (IniDBBuilderPackage::currentSpec): Track the in-progress specifiation.
3264         (IniDBBuilderPackage::currentOrList): Track the current Or list.
3265         (IniDBBuilderPackage::currentAndList): Track the current And list.
3266         * IniParseFeedback.cc (IniParseFeedback::progress): Provide completion
3267         progress on parsing.
3268         (IniParseFeedback::iniName): Tell what ini filename we are currently
3269         processing.
3270         * IniParseFeedback.h: Declare IniParseFeedback.cc changes.
3271         * IniParseFindVisitor.cc (IniParseFindVisitor::IniParseFindVisitor):
3272         Make the feedback object non-const to allow mutating methods which are
3273         needed when the object has state.
3274         (IniParseFindVisitor::visitFile): Tell the caller the name of each
3275         .ini found.
3276         Initialise the parser with the feedback object to allow it to tell of
3277         progress.
3278         * IniParseFindVisitor.h: Declare IniParseFindVisitor.cc changes.
3279         * Makefile.am (inilinst_SOURCES): Add more requisite classes.
3280         (setup_SOURCES): Add the new PackageSpecification sources.
3281         * ScanFindVisitor.cc (ScanFindVisitor::visitFile): Use the new
3282         builder syntax to setup binary package details.
3283         * choose.cc: Use the LogSingleton calls throughout.
3284         * configure.in: Create the INILINT substitution correctly for recent
3285         autotool configurations.
3286         * cygpackage.cc (cygpackage::getfirstfile): Return an empty String
3287         rather than a string built from an int. Thanks to Pavel Tsekov for
3288         identifying the bug.
3289         (cygpackage::getnextfile): Ditto.
3290         * download.cc: Use LogSIngletion calls throughout.
3291         (validateCachedPackage): A refactoring of the
3292         check_for_cached code to eliminate duplciation.
3293         (check_for_cached): Use validateCachedPackage to check packages.
3294         * ini.cc (GuiParseFeedback): Provide gui feedback on ini name and
3295         parsing progress.
3296         (do_remote_ini): Ditto.
3297         * ini.h (ini_init): Pass a IniParseFeedback to the parser, to allow
3298         progress reporting.
3299         * inilex.l: Identify new symbols - operators, and multi line plain text.
3300         Releases files.
3301         * inilintmain.cc (show_help): Provide basic infomation on inilint.
3302         * iniparse.y: Adjust for the new builder syntax, and process debian
3303         Release files.
3304         * io_stream_file.cc: Always include mkdir.h.
3305         * list.h: Factor index location into a private routine.
3306         (list::findindex): Implement this.
3307         * mkdir.cc (mkdir_p): Make the use of WIN32 code conditional on mingw
3308         builds. NB: This breaks cygwin build functionality still.
3309         * package_meta.cc: Use the LogSingleton calls throughout.
3310         (packagemeta::set_requirements): Adjust for object changes in
3311         dependencies.
3312         * package_meta.h (packagemeta::packagemeta): Initialise new members.
3313         (packagemeta::architecture): What platform does this package run on?
3314         This may need to move in the future to a per packagefile object.
3315         (packagemeta::priority): What priority does this package have?
3316         * package_source.h (packagesource::packagesource): Initialise new
3317         members.
3318         (packagesource::installedSize): How much space does the package need?
3319         (packagesource::setInstalledSize): Tell the amount.
3320         (packagesource::_installedSize): And store it.
3321         * package_version.cc (packageversion::sourcePackage): return the
3322         source package.
3323         (packageversion::setSourcePackage): And set it.
3324         * package_version.h: Declare the package_version.cc changes.
3325         (packageversion::depends): New package specification AND list.
3326         (packageversion::predepends): Ditto.
3327         (packageversion::recommends): Ditto.
3328         (packageversion::suggests): Ditto.
3329         (packageversion::replaces): Ditto.
3330         (packageversion::conflicts): Ditto.
3331         (packageversion::provides): Ditto.
3332         (packageversion::sourcePackage): What source package is needed?
3333         * threebar.cc (ThreeBarProgressPage::SetText4): Set the label beside
3334         the bottom bar.
3335         * threebar.h: Declare the threebar.cc change.
3336
3337 2002-06-27  John Marshall  <johnm@falch.net>
3338
3339         * res.rc (SETUPINI_MISSING): Make trailing spaces visible.
3340         * site.cc (SitePage::OnMessageCmd): Ditto
3341
3342 2002-06-15  Robert Collins  <rbtcollins@hotmail.com>
3343
3344         * nio-ie5.cc (NetIO_IE5::NetIO_IE): Allow cached data.
3345
3346 2002-06-15  Robert Collins  <rbtcollins@hotmail.com>
3347
3348         * package_meta.cc (packagemeta::set_action): When installing packages
3349         with no binaries, choose the source package.
3350
3351 2002-06-10  Robert Collins  <rbtcollins@hotmail.com>
3352
3353         * IniParseFindVisitor (IniParseFindVisitor::visitFile): Apply Max
3354         Bowshers fix for the crash with a root level setup.ini.
3355         * README: Update todos.
3356
3357 2002-05-26 Ralf Habacker  <ralf.habacker@freenet.de>
3358
3359         * archive_tar.cc (archive_tar::next_file_name()): fixed broken
3360         GNU long name extension support.
3361
3362 2002-05-27  Robert Collins  <rbtcollins@hotmail.com>
3363
3364         * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Don't
3365         unescape 0 length strings.
3366
3367 2002-05-20  Robert Collins  <rbtcollins@hotmail.com>
3368
3369         * package_meta.cc (packagemeta::set_action): Don't allow reinstall
3370         when local with no cached file, and install the default source if the
3371         default version has no binary.
3372
3373 2002-05-19  Robert Collins  <rbtcollins@hotmail.com>
3374
3375         * IniDBBuilderPackage.cc (IniDBBuilderPackage::IniDBBuilderPackage): New
3376         method.
3377         (IniDBBuilderPackage::buildVersion): Provide a warning when a newer
3378         setup version created the ini file.
3379         * IniDBBuilderPackage.h (IniDBBuilderPackage::IniDBBuilderPackage): New
3380         method.
3381         * IniParseFindVisitor.cc (IniParseFindVisitor::visitFile): Use the new
3382         feedback strategy.
3383         * IniParseFindVisitor.h (IniParseFindVisitor::IniParseFindVisitor):
3384         Require a feedback strategy.
3385         * Makefile.am (setup_SOURCES): Add IniParseFeedback sources.
3386         * Makefile.in: Regenerate.
3387
3388 2002-05-19  Robert Collins  <rbtcollins@hotmail.com>
3389
3390         * io_stream_file.cc (io_stream_file::remove): Use the SetFileAttributes
3391         trick to delete read only files.
3392         * io_stream_cygfile.cc (io_stream_cygfile::remove): Use file:// to
3393         remove files.
3394         * Makefile.am (release): Tweak to be more helpful.
3395         * Makefile.in: Regenerate.
3396
3397 2002-05-19  Robert Collins  <rbtcollins@hotmail.com>
3398
3399         * Makefile.am (release): Tweak to be more helpful.
3400         * Makefile.in: Regenerate.
3401
3402 2002-05-19  Robert Collins  <rbtcollins@hotmail.com>
3403
3404         * Makefile.am (release): Tweak to be more helpful.
3405         * Makefile.in: Regenerate.
3406
3407 2002-05-19  Robert Collins  <rbtcollins@hotmail.com>
3408
3409         * choose.cc (scan_downloaded_files): When a non-installed version
3410         has neither bin nor src cached files for local installs,
3411         remove the version from availability.
3412
3413 2002-05-19  Robert Collins  <rbtcollins@hotmail.com>
3414
3415         * ini.cc (do_remote_ini): Save uncompressed ini's correctly.
3416
3417 2002-05-19  Robert Collins  <rbtcollins@hotmail.com>
3418
3419         * rsync: New support library, contains librsync. This is not (yet)
3420         rsync interoperable.
3421         * configure.in: --with-rsync to enable rsync support. (Not complete).
3422         * Makefile.am: Enable building with rsync.
3423         * Makefile.in: Regenerate.
3424         * configure: Ditto.
3425         * IniDBBuilder.cc (IniDBBuilder::buildPackageInstall): Pass the md5 as
3426         an array.
3427         (IniDBBuilder::buildPackageSource): Ditto.
3428         * IniDBBuilder.h: Ditto.
3429         * IniDBBuilderPackage.cc: Ditto.
3430         * IniDBBuilderPackage.h: Ditto.
3431         * FindVisitor.cc: New file.
3432         * FindVisitor.h: New file, interface for visiting a file system
3433         aggregate.
3434         * IniParseFindVisitor.cc: New file.
3435         * IniParseFindVisitor.h: New file, concrete FindVisitor that parses
3436         found setup.ini's.
3437         * README: Update TODO's.
3438         * String++.cc (String::String): New constructor for <string> inter-
3439         operability.
3440         (String::substr): New method.
3441         * String++.h: Ditto.
3442         * choose.cc (scan2): Remove.
3443         (scan_downloaded_files): Simplify.
3444         * dialog.h: Include parsing pre-requirements.
3445         * download.cc (check_for_cached): Fullname was used incorrectly - fix.
3446         * filemanip.cc (parse_filename): -src packages where incorrectly parsed.
3447         * find.cc: Rewrite. Now uses a Visitor pattern and is re-entrant.
3448         * find.h: Ditto.
3449         * fromcwd.cc: Remove unneeded includes.
3450         (is_test_version): Remove.
3451         (found_file): Remove.
3452         (SetupFindVisitor): Trivial visitor to detect setup.ini's.
3453         (found_ini): Remove.
3454         (do_fromcwd): Remove commented code that has be replaced elsewhere.
3455         * ini.cc (local_ini): Remove.
3456         (findBuilder): Remove.
3457         (find_routine): Remove.
3458         (do_local_ini): Use new IniParseFindVisitor.
3459         * iniparse.y: Typecase MD5 arrays, as we know they are allocated as
3460         unsigned char.
3461         * postinstall.cc: Remove non-core includes.
3462         (run_script_in_postinstall): Remove.
3463         (RunFindVisitor): Trivial Visitor, runs each found script.
3464         (do_postinstall): Use new find syntax.
3465
3466 2002-05-14  Christopher Faylor  <cgf@redhat.com>
3467
3468         * ini.cc (find_routine): Don't clear buffer it it's NULL.
3469
3470 2002-05-14  Christopher Faylor  <cgf@redhat.com>
3471
3472         * filemanip.h (trail): Declare.
3473         * filemanip.cc (trail): New function.
3474         (find_tar_ext): Use trail() instead of strstr().
3475         * fromcwd.cc (check_ini): Ditto.
3476         * ini.cc (find_routine): Ditto.  Don't tack local_dir to path since it
3477         should now be fully qualified.  Set ini_filename.  Reset error_buf and
3478         error_count for any subsequent ini file parsing.
3479         (ini_filename): New static variable for parse error reporting.
3480         (yyerror): Use full path of setup.ini in error message.  Subtract one
3481         from line number if at bol.
3482         * find.cc (found_part): Eliminate.
3483         (find_sub): Call for_each with full path found rather than just file
3484         component.
3485         (find): Don't calculate found_part.
3486         * inilex.l (ini_init): Flush input buffer and reset line number.
3487         (yybol): New function.  Exports YY_AT_BOL.
3488         * iniparse.y: Increase stack depth to allow more tokens to be processed.
3489         (yyparse): Remove newline from error condition to allow subsequent
3490         per-line error processing to proceed normally.
3491
3492 2002-05-14  Christopher Faylor  <cgf@redhat.com>
3493
3494         * find.cc (find_sub): Be more defensive in preserving trailing parts of
3495         components when doing recursive directory searches or calling user
3496         supplied for_each().
3497         * ini.cc (find_routine): Don't assume that any path name with
3498         "setup.ini" in it is actually a setup.ini file.  Only honor trailing
3499         components.  Copy path argument to temporary storage when unescaping
3500         to prevent nuking of argument.
3501
3502 2002-05-12  Robert Collins  <rbtcollins@hotmail.com>
3503
3504         * CONTRIBUTORS: New file.
3505
3506 2002-04-02  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
3507
3508         * choose.cc: Run indent.
3509         (nextbutton): Remove static variable.
3510         (default_trust): Remove use of nextbutton.
3511         (set_view_mode): Ditto.
3512         (create_listview): Add IDC_CHOOSE_PREV and IDC_CHOOSE_NEXT to ta[] so
3513         rbset() sets the prev/next/curr radio buttons properly.
3514         (dialog_cmd): Delete function.
3515         (dialog_proc): Delete function.  Move WM_INITDIALOG functionality to
3516         ChooserPage::OnInit.
3517         (do_choose): Delete function.  Move pre-DialogBox() code to
3518         ChooserPage::OnInit(), post-DialogBox() code to ChooserPage::OnNext.
3519         (WM_APP_START_CHOOSE): Remove define.
3520         (WM_APP_CHOOSE_IS_FINISHED): Remove define.
3521         (do_choose_thread): Delete function.
3522         (ChooserPage::OnActivate): Delete method.
3523         (ChooserPage::OnMessageApp): Delete method.
3524         (ChooserPage::OnInit): New method.
3525         (ChooserPage::OnNext): New method.
3526         (ChooserPage::OnBack): New method.
3527         (ChooserPage::OnMessageCmd): New method.
3528         * choose.h: Run indent.
3529         (ChooserPage::OnMessageApp): Delete declaration.
3530         (ChooserPage::OnActivate): Ditto.
3531         (ChooserPage::OnMessageCmd): New declaration.
3532         (ChooserPage::OnInit): Ditto.
3533         (ChooserPage::OnNext): Ditto.
3534         (ChooserPage::OnBack): Ditto.
3535         * desktop.cc (DesktopSetupPage::OnBack): Replace use of IDD_CHOOSER
3536         with IDD_CHOOSE.
3537         * fromcwd.cc (do_fromcwd): Replace use of IDD_CHOOSER with IDD_CHOOSE.
3538         * ini.cc (do_ini_thread): Replace use of IDD_CHOOSER with IDD_CHOOSE.
3539         * res.rc (IDD_CHOOSE): Remove dialog template.
3540         (IDD_CHOOSER): Alter dialog template to fit wizard size and format.
3541
3542 2002-05-12  Robert Collins  <rbtcollins@hotmail.com>
3543
3544         * LogFile.cc (endLog): Work around an apparent libg++-3 bug causing
3545         corrupt log file entries.
3546         * geturl.cc: Convert to the new LogSingleton logging.
3547
3548 2002-05-12  Robert Collins  <rbtcollins@hotmail.com>
3549
3550         * ini.cc (do_remote_ini): Use setup.bz2 if it exists in preference to
3551         setup.ini.
3552
3553 2002-05-12  Robert Collins  <rbtcollins@hotmail.com>
3554
3555         * geturl.h: Declare getUrlToStream.
3556         * geturl.cc (getUrlToStream):  New function.
3557         (get_url_to_membuf): Refactor to use getUrlToStream.
3558
3559 2002-05-11  Robert Collins  <rbtcollins@hotmail.com>
3560
3561         * Makefile.am: Add a release target to automate some of the routine
3562         work.
3563         * Makefile.in: Regenerate.
3564
3565 2002-05-11  Robert Collins  <rbtcollins@hotmail.com>
3566
3567         * choose.cc (scan_downloaded_files): On local installs remove all
3568         mirror sites if no cached copy of a package is found.
3569
3570 2002-05-10  Robert Collins  <rbtcollins@hotmail.com>
3571
3572         * Makefile.in: Regenerate.
3573         * iniparse.y: Use left recursion, not right in the lines rule to
3574         avoid stack overflows.
3575         * README: Update TODO's.
3576         * io_stream_file.cc: Native builds need to include sys/stat.h
3577
3578 2002-05-06  John Marshall  <jmarshall@acm.org>
3579
3580         * site.cc (SitePage::OnMessageCmd): recalculate navigation
3581         button activation when "Add" is pressed.
3582         (SitePage::CheckControlsAndDisableAccordingly): tweak comment.
3583
3584 2002-05-07 Robert Collins  <rbtcollins@hotmail.com>
3585
3586         * Makefile.am (inlint_SOURCES): Add conditional objects to inilint
3587         depending on platform.
3588         Add file:// support.
3589         * configure.in: Set conditional MINGWTARGET if compiling against mingw
3590         libraries.
3591         * Makefile.in: Regenerate.
3592         * configure: Ditto.
3593         * io_stream_file.cc: Only use win32 calls when building for mingw.
3594
3595 2002-05-05 Robert Collins  <rbtcollins@hotmail.com>
3596
3597         * Makefile.am (noinst_PROGRAMS): Make inilint configurable.
3598         * configure.in: Ditto.
3599         Fix incorrect header checking syntax.
3600         * aclocal.m4: Regenerate.
3601         * configure: Regenerate.
3602         * Makefile.in: Regenerate.
3603         * io_stream.cc: Remove platform specific and provider specific code.
3604         (io_stream::registerProvider): New method, registers a Url provider with
3605         the io_stream code.
3606         Make all methods consistently throw invalid_argument exceptions when
3607         a provider that is requested is not present.
3608         (findProvider): New private function, finds a provider.
3609         * io_stream.h: Declare io_stream::registerProvider.
3610         * io_stream_cygfile.cc: Create a Provider class to register with
3611         io_stream.cc.
3612         * io_stream_file.cc: Ditto.
3613         * archive.cc: Remove unneeded includes.
3614         * archive_tar.cc: Remove unneeded includes.
3615         * archive_tar.h: Add required include.
3616         * archive_tar_file.cc: Remove unneded includes.
3617         * choose.cc: Remove unneeded includes:
3618
3619 2002-05-04 Robert Collins  <rbtcollins@hotmail.com>
3620
3621         * io_stream.cc: Use the new log interface thruout.
3622
3623 2002-05-04 Robert Collins  <rbtcollins@hotmail.com>
3624
3625         * log.cc (log): Reimplement via LogSingleton.
3626         (log_save): Remove.
3627         (exit_setup): Remove.
3628         * log.h (log_save): Remove.
3629         (exit_setup): Remove.
3630         * LogSingleton.cc: New file.
3631         * LogSingleton.h: New file.
3632         * LogFile.cc: New file.
3633         * LogFile.h: New file.
3634         * Makefile.am (inilint_SOURCES): Add the new log interface.
3635         (setup_SOURCES): Add the new log interface and the concrete File
3636         implementation.
3637         * Makefile.in: Regenerate.
3638         * archive.cc: Use the new log interface thruout.
3639         * archive_tar.cc: Ditto.
3640         * main.cc: Ditto.
3641         * dialog.cc (fatal): Use the new log interface.
3642         * ini.cc (do_ini_thread): Use the log interface to exit.
3643         * isntall.cc (do_install_thread): Ditto.
3644         * netio.cc (auth_cmd): Ditto.
3645         * msg.cc (fatal): Ditto.
3646         * localdir.cc (save_local_dir): Save to different files depending on
3647         the mode, and if a root dir exists.
3648
3649 2002-05-04 Robert Collins  <rbtcollins@hotmail.com>
3650
3651         * IniDBBuilder.cc: New file.
3652         * IniDBBuilder.h: New file.
3653         * IniDBBuilderPackage.cc: New file.
3654         * IniDBBuilderPackage.h: New file.
3655         * PackageTrust.h: New file.
3656         * IniState.h: Remove, wasn't thought out well enough.
3657         * Makefile.am (inilint_SOURCES): Add more requirements.
3658         (setup_SOURCES): Add new Builder base and concrete classes.
3659         * Makefile.in: Regenerate.
3660         * String++.cc (String::String): Implement int contructor.
3661         * String++.h (String): Declare int constructor.
3662         * archive_tar.cc (archive_tar::next_file_name): Return String() when
3663         no filename exists.
3664         * archive_tar.h (archive_tar_file): Remove get_next_filename method,
3665         it's not needed.
3666         * ini.cc: Replace IniState wuth IniDBBuilderPacakge.
3667         (find_routine): Use new IniDBBuilder to configure the parser.
3668         (do_local_ini): Ditto.
3669         (do_remote_ini): Ditto.
3670         * ini.h: Use IniDBBuilder to initialise parsing.
3671         * inilex.l (MD5): Parse the MD5 string correctly, we had the nibbles
3672         swapped.
3673         (ini_init): Use an IniDBBuilder rather than static variables.
3674         * iniparse.y: Hand off all the object creation to a builder, rather
3675         than hardcoding the behaviour. This allows run-time configured
3676         behaviour.
3677         * io_stream_cygfile.h (io_stream_cygfile): Remove get_next_filename
3678         method, it's not needed.
3679         * io_stream_file.h (io_stream_file): Ditto.
3680         * mount.cc (cygpath): Return String() for missing mounts.
3681         * package_meta.cc (packagemeta::SDesc): Return String() for blank
3682         descriptions.
3683         * package_meta.h (trusts): Remove - replaced by PackageTrust.h.
3684         (packagemeta::packagemeta): Fix incorrect syntax in String constructor
3685         usage.
3686         * cygpackage.cc (cygpackage::cygpackage): Fix incorrect syntax in
3687         String constructor usage.
3688         * site.h (site_list_type): Ditto.
3689
3690 2002-05-03 Robert Collins  <rbtcollins@hotmail.com>
3691
3692         * String++.h: Declare a << operator that accepts String objects.
3693         * String++.cc: We need iostream for..
3694         (operator <<): this. Provide a << operator that accepts String objects.
3695         * ini.cc (yyerror): Remove the "C" classifier - it's not needed.
3696         Change from vargs to a String parameter.
3697         * inilintmail.cc: Remove the gui related headers.
3698         (yyerror): Implement this for parsing.
3699         * iniparse.y: Use the new yyerror syntax.
3700
3701 2002-05-03 Robert Collins  <rbtcollins@hotmail.com>
3702
3703         * Makefile.am: Add IniState.h.
3704         * Makefile.in: Regenerate.
3705         * IniState.h: New file.
3706         * choose.cc: Don't include ini.h - it's not needed.
3707         * configure: Regenerate.
3708         * desktop.cc: Don't include ini.h - it's not needed.
3709         * download.cc: Ditto.
3710         * fromcwd.cc: Ditto.
3711         * ini.cc: Use IniState.h to track each parsing calling.
3712         (find_routine): Ditto.
3713         (do_remote_ini): Ditto.
3714         (do_ini_thread): Ditto.
3715         * ini.h (ini_init): Adjust parameters to include state object.
3716         * inilex.l: Declare parser state variable.
3717         (ini_init): Adjust parameters to include state object.
3718         * iniparse.y: Remove obsolete setup_timestamp and setup_version
3719         declarations.
3720         (setup_header): Use new state variable to track time and version.
3721         (add_correct_version): Ditto.
3722         * install.cc: Don't include ini.h - it's not needed.
3723
3724 2002-05-03 Robert Collins  <rbtcollins@hotmail.com>
3725
3726         * nio-files.cc (NetIO): Use io_stream syntax for get_file_size.
3727         * io_stream_file.cc: Don't include filemanip.h.
3728         (io_stream_file::get_size): Implement here to remove filemanip
3729         dependency.
3730         * io_stream_cygfile.cc: Don't include filemanip.h.
3731         (io_stream_cygfile::get_size): Implement here to remove filemanip
3732         dependency.
3733         Implement a stat based version for when win32 is not available.
3734         * filemanip.h (get_file_size): Return size_t - it's more appropriate.
3735         * filemanip.cc: Don't include win32.h - be platform independent.
3736         Include strings.h and io_stream.h as part of that.
3737         (get_file_size): Leverage io_streams and remove win32 implementation.
3738         * download.cc (check_for_cached): Use io_stream syntax for
3739         get_file_size.
3740         (download_one): Ditto.
3741
3742 2002-05-02 Robert Collins  <rbtcollins@hotmail.com>
3743
3744         * configure.in: Correct a typo in last change.
3745         * configure: Regenerate.
3746         * Makefile.in: Regenerate.
3747
3748 2002-05-02 Robert Collins  <rbtcollins@hotmail.com>
3749
3750         * configure.in: Check for string.h and string.
3751         * configure: Regenerate.
3752         * Makefile.in: Regenerate.
3753
3754 2002-05-01  Robert Collins  <rbtcollins@hotmail.com>
3755
3756         * res.rc (IDD_SPLASH): Remove white box.
3757
3758 2002-05-01  Robert Collins  <rbtcollins@hotmail.com>
3759
3760         Oops! forgot to list these in the last checkin.
3761         * inilintmain.cc: New file.
3762         * md5.h: New file - imported md5 source, BSD style licence.
3763         * md5.cc: New file - imported md5 source, BSD style licence.
3764         * Exception.cc: New file.
3765         * Exception.h: New file.
3766         * MD5++.cc: New file.
3767         * MD5++.h: New file.
3768
3769 2002-05-01  Robert Collins  <rbtcollins@hotmail.com>
3770
3771         * Makefile.am (AM_CFLAGS): Remove -mwindows, it's a linker flag.
3772         Remove -fno-rtti, we need it for exceptions.
3773         (AM_CXXFLAGS): Ditto.
3774         (WARNONLY_CFLAGS): Ditto.
3775         (EXTRA_PROGRAMS): Add with initial linter sources - not functional yet.
3776         (setup_LDFLAGS): Add and set to -mwindows.
3777         (setup_SOURCES): Add new sources.
3778         * Makefile.in: Regenerate.
3779         * README: Update TODO.
3780         * choose.cc (scan_downloaded_files): Use ini information if it's
3781         available.
3782         * configure: Regenerate.
3783         * download.cc (check_for_cached): Make reusable from elsewhere.
3784         Throw exceptions on errors (as opposed to failures).
3785         Check MD5 sum when it's known.
3786         (download_one): Never force a download.
3787         Handle corrupt package exceptions.
3788         * ini.cc (find_routine): Reverse escape the URL to correctly identify
3789         the site URL.
3790         * inilex.l (MD5): Provide a parsing rule (note: lowercase is required).
3791         * iniparse.y: Allow calculation of MD5 sums, and allow src only
3792         packages.
3793         (process_src): New helper function.
3794         * isntall.cc (install_one_source): Check MD5 sums when possible.
3795         Throw exceptions on errors.
3796         (do_install_thread): Handle exceptions for installation calls.
3797         * package_source.h: Store MD5 information.
3798         * propsheet.cc (PropSheet::Create): Add a useful comment.
3799         * res.rc (IDS_INSTALL_ERROR): Define.
3800         (IDS_CORRUPT_PACKAGE): Define.
3801         * resource.h (IDS_INSTALL_ERROR): Define.
3802         (IDS_CORRUPT_PACKAGE): Define.
3803         * rfc1738.cc (rfc1738_unescape_part): Implement.
3804         * rfc1738.h (rfc1738_unescape_part): Declare.
3805
3806 2002-04-29  Robert Collins  <rbtcollins@hotmail.com>
3807
3808         * Makefile.am: Remove dependecy rules that automake emits.
3809         Correct badly copied dependency info for manually compiled files.
3810         (setup_SOURCES): Add all used headers.
3811         (EXTRA_DIST): Include non compilate but required sources.
3812         (setup_LDADD): Remove mingw32, it is autodetected.
3813         * Makefile.in: Regenerate.
3814         * String++.h: sys/types is a system header.
3815         * choose.cc (do_choose_thread): Make into a Win32 thread routine.
3816         Use ExitThread.
3817         (ChooserPage::OnMessageApp): Use Win32 threads. (_beginthread is not
3818         portable).
3819         * configure: Regenerate.
3820         * configure.in: Check for mingw32/cygwin specific headers and libraries.
3821         * cygpackage.h: Include the win32.h header to get correct macro
3822         definitions in all situations.
3823         * download.cc (do_download_reflector): Make into a Win32 thread routine.
3824         Use ExitThread.
3825         (do_download): Use Win32 threads.
3826         * ini.cc: Ditto.
3827         * install.cc: Ditto.
3828         * (WinMain): Adjust to build valid command line using application
3829         under both mingw32 and cygwin.
3830         * mount.cc (set)cygdrive_flags): Create new system flags if the
3831         user requests system and the value does not exist.
3832         * nio-http.cc: Define a _strnicmp for cygwin.
3833         * package_db.cc: Include <errno.h> if it exists.
3834         * site.cc (do_download_site_info_thread): Make into a Win32 thread
3835         routine.
3836         Use ExitThread.
3837         (do_download_site-Info): Use Win32 threads.
3838         * state.cc: Explicity declare variables to avoid header conflicts
3839         caused by '#define extern" on cygwin.
3840         * win32.h: Include <alloca.h> if it exists.
3841         (_MAX_PATH): Define as MAX_PATH when not defined by windows.h.
3842         (_access): Define as access if not defined by windows.h.
3843
3844 2002-04-27  Robert Collins  <rbtcollins@hotmail.com>
3845
3846         * compress_gz.cc (compress_gz::error): EOF is not an error condition.
3847
3848 2002-04-27  Robert Collins  <rbtcollins@hotmail.com>
3849
3850         * Makefile.am: Add libgetopt++ to the subdirs list.
3851         Search the libgetopt++ header directory.
3852         Link against libgetopt++.la.
3853         (setup_SOURCES): Remove GetOption.cc and getopt.c and Option.cc.
3854         (setup_LDADD): Explicitly include res.o.
3855         * Makefile.in: Regenerate.
3856         * aclocal.m4: Regenerate.
3857         * bootstrap.sh: Call libtoolize.
3858         * configure: Regenerate.
3859         * configure.in: Add libtool support and configure libgetopt++.
3860         * desktop.cc (NoShortcutsOption): Turn into a BoolOption.
3861         (DesktopSetupPage::OnInit): Use the simpler syntax.
3862         * desktop.h: Remove dependency on Option.h, and remove NoShortcustOption
3863         declaration.
3864         * main.cc: Include getopt++/GetOption.h.
3865         (main): Use simpler syntax.
3866         * cdefs.h: Remove.
3867         * getopt.h: Remove.
3868         * getopt.c: Remove.
3869         * GetOption.h: Remove.
3870         * GetOption.cc: Remove.
3871         * Option.h: Remove.
3872         * Option.cc: Remove.
3873
3874 2002-04-26  Robert Collins  <rbtcollins@hotmail.com>
3875
3876         * Makefile.am: Add zlib and bz2lib to SUBDIRS.
3877
3878 2002-04-26  Robert Collins  <rbtcollins@hotmail.com>
3879
3880         * aclocal.m4: New file, cached macros.
3881         * bootstrap.sh: New file, calls required autotools in appropriate
3882         order.
3883         * Makefile.am: New file, input Makefile for automake.
3884         * Makefile,in: Now a generated file - regenerate.
3885         * configure: Regenerate.
3886         * configure.in: Add automake support.
3887         * inilex.l: Change VERSION to PACKAGEVERSION to avoid a collision with
3888         automake's VERSION define.
3889         * iniparse.y: Ditto.
3890
3891 2002-04-26  Robert Collins  <rbtcollins@hotmail.com>
3892
3893         * cdefs.h: New file, imported to allow getopt.c to build without
3894         cygwin headers.
3895         * getopt.h: New file, imported to allow building without cygwin headers.
3896         * getopt.c: Ditto.
3897         * bz2lib: New directory, contains copy of bz2lib.
3898         * cfgaux: New directory, contains autotool helper scripts.
3899         * Makefile,in: Adjust library and target definitions for building
3900         outside the sourceware tree.
3901         * compress_bz.h: Use new bz2lib header location.
3902         * mount.cc: Import key defines and enums to be independent of cygwin
3903         headers.
3904         * configure.in: Update to autoconf 2.53, and to be sourceware
3905         independent.
3906         * configure: Regenerate.
3907
3908 2002-04-12  Robert Collins  <rbtcollins@hotmail.com>
3909
3910         * mklink2.cc (make_link_2): Tweak to work with current w32api
3911         headers.
3912
3913 2002-04-10  Pavel Tsekov  <ptsekov@gmx.net>
3914
3915         * version.cc (canonicalize_version): Fix a call delete[]
3916         to delete the allocated address.
3917
3918 2002-03-29  Robert Collins  <rbtcollins@hotmail.com>
3919
3920         * PickView.cc (PickView::set_headers): Set last_col correctly. Thanks
3921         to Ton van Overbeek for locating the bug area.
3922
3923 2003-03-27  Robert Collins  <rbtcollins@hotmail.com>
3924
3925         * PickView.cc (PickView::insert_pkg): Be more generic with
3926         object use.
3927         (PickView::insert_category): Ditto.
3928         (PickView::~PickView): Create.
3929         * PickView.h (PickView::~PickView): Declare.
3930
3931 2003-03-27  Robert Collins  <rbtcollins@hotmail.com>
3932
3933         * Makefile.in (OBJS): Add new commandline objects.
3934         * desktop.cc (NoShortCutsOption): New option code.
3935         (DesktopSetupPage::OnInit): Check whether to skip shortcuts.
3936         * desktop.h (NoShortCutsOption): New concrete command line option class.
3937         * main.cc (WinMain): Process command line options.
3938         * GetOption.h: New file, singleton command line class.
3939         * GetOption.cc: New file, implementation of the above.
3940         * Option.h : New file, abstract option for GetOption.
3941         * Option.cc: New file, implement constructor and destructor.
3942
3943 2002-03-26  Pavel Tsekov  <ptsekov@gmx.net>
3944
3945         * mkdir.cc (mkdir_p): Stop processing if the path is exhausted.
3946
3947 2002-03-26 Ton van Overbeek  <tvoverbe@cistron.nl>
3948
3949         * PickPackageLine.cc (PickPackageline::paint): Adjust clipping rectangle
3950         to textheight, so large fonts work.
3951
3952 2003-03-26  Robert Collins  <rbtcollins@hotmail.com>
3953
3954         * io_stream_cygfile.cc (io_stream_cygfile::mklink): Don't translate
3955         symlinks.
3956
3957 2003-03-26  Robert Collins  <rbtcollins@hotmail.com>
3958
3959         * io_stream_cygfile.cc (cwd): New static for cwd storage.
3960         (io_stream_cygfile::normalise): New method.
3961         (io_stream_cygfile::io_stream_cygfile): Use it.
3962         (io_stream_cygfile::exists): Ditto.
3963         (io_stream_cygfile::remove): Ditto.
3964         (io_stream_cygfile::mklink): And again.
3965         (cygmkdir_p): Yes, again.
3966         (io_stream_cygfile::move): And once more.
3967         * io_stream_cygfile.h (io_stream_cygfile::normalise): Declare.
3968         (io_stream_cygfile::cwd): Ditto.
3969
3970 2003-03-26  Robert Collins  <rbtcollins@hotmail.com>
3971
3972         * package_meta.cc (package_meta::~package_meta): Remove duplicate.
3973         (CategoryPackage::~CategoryPackage): Ditto. (Thanks to Ton van
3974         Overbeek for the report).
3975         * mklink2.cc: Moved from mklink2.c to avoid 'not a prototype error'.
3976         Make g++ compatible.
3977         * mklink2.c: Remove.
3978         * site.cc (site_list_type::init): Delete the correct memory addres.
3979         Thanks to Pavel Tsekov for tracking this down.
3980
3981 2002-03-20  Robert Collins  <rbtcollins@hotmail.com>
3982
3983         * win32.h: Only define alloca if it's not already.
3984
3985 2002-03-20  Robert Collins  <rbtcollins@hotmail.com>
3986
3987         * package_meta.h (packamgemeta::trustp): Make 'test' choice leave
3988         installed packages alone.
3989         * README: Update with latest requests.
3990         * Various: MTC fixes from setup200202 branch.
3991
3992 2002-03-19  Christopher Faylor  <cgf@redhat.com>
3993
3994         * Makefile.in (setup_version.c): Add back magic which allows detection
3995         of setup.exe version number.
3996
3997 2002-03-17  Robert Collins <rbtcollins@hotmail.com>
3998
3999         * PickPackageLine.cc (PickPackageLine::paint): Fix incorrect clip region
4000         calculation on win9x systems.
4001
4002 2002-03-16  Robert Collins <rbtcollins@hotmail.com>
4003
4004         * install.cc (install_one_source): Write the correct length of a string
4005         to the lst file (Thanks to Pavel Tsekov for reporting the bug).
4006
4007 2002-03-15  Robert Collins <rbtcollins@hotmail.com>
4008
4009         * choose.cc (list_click): Always refresh the entire chooser, as our
4010         package state change mechanism is broken with the new improved list
4011         classes.
4012
4013 2002-03-15  Robert Collins <rbtcollins@hotmail.com>
4014
4015         * desktop.cc (make_passwd_group): Check for .lnk suffix on /etc/passwd
4016         and /etc/group.
4017
4018 2002-03-15  Robert Collins <rbtcollins@hotmail.com>
4019
4020         * PickPackageLine.cc (PickPackageLine::DrawCheck): New method factored
4021         out from paint().
4022         (PickPackageLine::paint): Use DrawCheck to draw the src tick box, and
4023         the new bin tickbox.
4024         (PickPackageLine::click): Handle the new bin tickbox.
4025         * PickPackageLine.h (PickPackageLine::DrawCheck): Declare this.
4026         * PickView.cc (pkg_headers): Add a Bin? column.
4027         (cat_headers): Ditto.
4028         (PickView::set_headers): Ditto.
4029         (PickView::init_headers): Ditto.
4030         * PickView.h (PickView): Ditto.
4031         * choose.cc (list_click): Use the new name for src_col to set the clip
4032         rectangle.
4033
4034 2002-02-24  Michael A Chase <mchase@ix.netcom.com>
4035
4036         * io_stream_cygfile.cc (io_stream_cygfile::mklink): Fix up Robert's
4037         fixup.
4038
4039 2002-02-24  Michael A Chase <mchase@ix.netcom.com>
4040
4041         * desktop.cc (make_link): Add "file://" prefix to io_stream::mkpath_p()
4042         call.
4043         (make_passwd_group): Ditto.
4044         * localdir.cc (save_local_dir): Ditto.
4045         * io_stream_cygfile.cc (io_stream_cygfile::mklink): Wrap long lines.
4046         Add "cygfile://" prefix to io_stream::open() calls.
4047
4048 2002-02-24  Robert Collins <rbtcollins@hotmail.com>
4049
4050         * log.cc (log_save): Fix creating /var/log.
4051         * packate_meta.cc (standard_dirs): Remove duplicate '/''s.
4052
4053 2002-02-24  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
4054
4055         * res.rc (STRINGTABLE): Add IDS_CYGWIN_SETUP and
4056         IDS_CYGWIN_SETUP_WITH_PROGRESS strings.
4057         * resource.h: Add IDS_CYGWIN_SETUP and
4058         IDS_CYGWIN_SETUP_WITH_PROGRESS IDs.
4059
4060         * splash.cc (OnInit): Qualify SetWindowText() call with global scope
4061         operator (::SetWindowText()).
4062
4063         * threebar.cc: Run indent.
4064         (cistring.h): Add include.
4065         (SetText1, SetText2, SetText3): Qualify SetWindowText() call with
4066         global scope operator.
4067         (SetBar2): Add logic for writing percent complete into window title.
4068
4069         * window.h: Run indent.
4070         (SetWindowText): New function.
4071         (String): Add forward declaration.
4072         * window.cc: Run indent.
4073         (String++.h): Add include.
4074         (SetWindowText): New function.
4075
4076 2002-02-24  Robert Collins <rbtcollins@hotmail.com>
4077
4078         * README: Update TODO list.
4079         * install.cc (install_one): Fix src package location.
4080         (do_install_thread): Fix creating directories.
4081
4082 2002-02-19  Robert Collins <rbtcollins@hotmail.com>
4083
4084         * choose.cc: Include cygpackage.h for scan2 use.
4085         (set_existence): Ignore setup.ini mirrors when installing from cwd.
4086         (scan2): Process any valid file.
4087         Add cache entries when a file matching a setup.ini listed version is
4088         found.
4089         * filemanip.cc (parse_filename): Remove pkgtar - not used anywhere else.
4090         * filemanip.h (filemanip::pkgtar): Remove.
4091         * package_meta.cc (CategoryPackage::~CategoryPackage): New method.
4092         (packagemeta::~packagemeta): Move from package_meta.h
4093         Remove and delete all version and category information.
4094         * package_meta.h (CategoryPackage): Create a destructor.
4095         (packagemeta::~packagemeta): Move to .cc file.
4096
4097 2002-02-19  Robert Collins <rbtcollins@hotmail.com>
4098
4099         * install.cc (install_one_source): Make NULL cached package names cause
4100         errors.
4101
4102 2002-02-18  Michael A Chase <mchase@ix.netcom.com>
4103
4104         * desktop.cc (make_passwd_group): Don't create passwd-grp.bat
4105         unnecessarily.
4106
4107 2002-02-18  Michael A Chase <mchase@ix.netcom.com>
4108
4109         * log.cc (log_save): Put "\n" at end of log lines instead of "'".
4110
4111 2002-02-19  Robert Collins <rbtcollins@hotmail.com>
4112
4113         * mount.cc (create_mount): Avoid a const char*->char* warning.
4114         (read_mounts): Ditto.
4115
4116 2002-02-05  Jason Tishler  <jason@tishler.net>
4117
4118         * download.cc (do_download_thread): Fix off-by-one error.
4119
4120 2002-02-19  Robert Collins  <rbtcollins@hotmail.com>
4121
4122         * configure.in (CXXFLAGS): Substitute at configure time, not runtime.
4123         * configure (CXXFLAGS): Regenerate.
4124         * Makefile.in (iniparse.o): Build via default rules - no errors now.
4125         * README: TODO list updates.
4126
4127 2002-02-19  Michael A Chase  <mchase@ix.netcom.com>
4128
4129         * String++.cc (String::concat):: Remove.
4130         (String::vconcat):: Ditto.
4131         * String++.h (String::concat):: Remove.
4132         (String::vconcat):: Ditto.
4133         * archive_tar.cc: Don't include concat.h.
4134         * archive_tar_file.cc: Don't include concat.h.
4135         * compress_bz.cc (compress_bz::peek): Don't log unneeded messages.
4136         (compress_bz::seek): Ditto.
4137         (compress_bz::~compress_bz): Ditto.
4138         * compress_gz.cc (compress_gz::peek): Ditto.
4139         (compress_gz::error): Ditto.
4140         (compress_gz::~compress_gz): Ditto.
4141         * concat.cc (vconcat): Remove.
4142         (concat): Ditto.
4143         * concat.h (vconcat): Remove.
4144         (concat): Ditto.
4145         * desktop.cc (desktop_icon): Use new cygpath.
4146         (make_etc_profile): Ditto.
4147         (uexists): Ditto.
4148         (make_passwd_group): Ditto.
4149         (save_icon): Ditto.
4150         (check_desktop): Remove concat use.
4151         (check_start_menu): Ditto.
4152         * download.cc (download_one): Use new mkpath_p correctly.
4153         Use LOG_PLAIN.
4154         * fromcwd.cc: Don't include concat.h.
4155         * geturl.cc (get_url_to_membuf): Use String log() call.
4156         (get_url_to_file): Ditto.
4157         * install.cc: Don't include concat.h.
4158         (uninstall_one): Use LOG_PLAIN.
4159         (replace_one): Ditto.
4160         (install_one_source): Ditto.
4161         (install_one): More char to String conversion.
4162         (do_install_thread): Use new cygpath.
4163         Use new create_mount.
4164         * io_stream.cc (io_stream::move): Use new log().
4165         * io_stream_cygfile (io_stream_cygfile::io_stream_cygfile): Use new
4166         cygpath.
4167         (io_stream_cygfile::exists): Ditto.
4168         (io_stream_cygfile::remove): Ditto.
4169         (io_stream_cygfile::mklink): Ditto.
4170         (io_stream_cygfile::write): Ditto.
4171         (cygmkdir_p): Ditto.
4172         (io_stream_cygfile::move): Ditto.
4173         * io_stream_file.cc: Don't include log.h.
4174         (io_stream_file::write): Don't log unneeded messages.
4175         * localdir.cc: Don't include concat.h.
4176         (LocalDirPage::OnNext): Use LOG_PLAIN.
4177         * log.cc: Don't include log.h.
4178         (exit_setup): Use new cygpath.
4179         * log.h (log_level): Add new level LOG_PLAIN.
4180         * main.cc (WinMain): Use new log().
4181         * mount.cc (SLASH_P): New macro from concat.h.
4182         (cygpath): Make String version globally visible.
4183         Remove varargs version.
4184         * mount,h: Ditto.
4185         * msg.cc (mbox): Use LOG_PLAIN.
4186         * net.cc (NetPage::OnNext): Ditto.
4187         * nio-ftp.cc (ftp_line): Use new log().
4188         * nio-http.cc: Don't include log.h.
4189         (retry_get): Use alternative url variable.
4190         * package_db.cc: Don't include concat.h.
4191         (packagedb::flush): Don't use concat.
4192         * package_meta.cc: Don't include concat.h.
4193         (packagemeta::uninstall): Use new cygpath.
4194         * postinstall.cc (do_postinstall): Ditto.
4195         * root.cc (RootPage::OnNext): Use LOG_PLAIN.
4196         * script.cc: Don't include concat.h.
4197         (init_run_script): Use new cygpath.
4198         (run_script): More char * to String conversion.
4199         (try_run_script): Ditto.
4200         * site.cc: Don't include concat.h.
4201         (SitePage::OnNext): Use LOG_PLAIN.
4202         (SitePage::OnMessageCmd): Use new log().
4203         * source.cc (SourcePage::OnDeactivate): Use LOG_PLAIN.
4204
4205 2002-02-19  Robert Collins  <rbtcollins@hotmail.com>
4206
4207         * Makefile.in (OBJS): Add new object.
4208         * PickCategoryLine.cc (PickCategoryLine::paint): Print a "+" before the
4209         name.
4210         * PickCategoryLine.h (PickCategoryLine::bucket): Use the String class.
4211         * PickLine.h (Pickline::key): Change to a String to help plug leaks.
4212         (PickLine::Pickline): Accept a String for the key.
4213         * PickPackageLine.cc (PickPackageLine::paint): Convert all char use to
4214         Strings.
4215         * PickPackageLine.h (PickPackageLine::PickPackageLine): The key is
4216         automatically initialised now.
4217         * PickView.cc (PickView::note_width): Convert all char * use to Strings.
4218         (PickView::init_header): Move category length checking out of the inner
4219         loop for efficiency.
4220         Convert all char use to Strings.
4221         * PickView.h: Include the String++ header.
4222         (PickView::note_width): Update the prototype.
4223         * String++.cc: New file, implements a reference counting string class.
4224         * String++.h: New file, declares a reference counting string class.
4225         * archive.cc: Include String++ instead of concat.
4226         (archive::extract_file): Convert char * usage to Strings.
4227         * archive.h: Inlude the String++ header.
4228         (archive::extract_file): Update prototype.
4229         (archive::next_file_name): Convert to a String.
4230         (archive::linktarget): Ditto.
4231         * archive_tar.cc (archive_tar::next_file_name): Convert to String usage.
4232         (archive_tar::linktarget): Ditto.
4233         * arhive_tar.h: Update the copyright.
4234         Explicitly include the relevant headers.
4235         (tar_map_result_type): Convert to String usage.
4236         (archive_tar::next_file_name): Update prototype.
4237         (archive_tar::linktarget): Ditto.
4238         * category.cc (Category::Category): Update initialisers.
4239         Convert to String usage.
4240         (Categorycmp): Update to String usage.
4241         * category.h: Include the String++ header.
4242         (Category::Category): Update to String usage.
4243         (Category::name): Ditto.
4244         (Category::key): Ditto.
4245         * choose.cc: Remove concat.h, it's not needed.
4246         (scan2): Update to String usage.
4247         (do_choose): Ditto.
4248         * cygpackage.cc: Update includes for use of String class.
4249         (cygpackage::cygpackage): Update for String usage.
4250         (cygpackage::set_canonical_version): Ditto.
4251         (cygpackage::destroy): Ditto.
4252         (cygpackage::getfirstfile): Ditto.
4253         (cygpackage::getnextfile): Ditto.
4254         (cygpackage::Name): Ditto.
4255         (cygpackage::Vendor_version): Ditto.
4256         (cygpackage::Package_version): Ditto.
4257         (cygpackage::Canonical_version): Ditto.
4258         (cygpackage::set_sdesc): Ditto.
4259         (cygpackage::set_ldesc): Ditto.
4260         * cygpackage.h: Include String++.h for parsing this file.
4261         (cygpackage::cygpackage): Update for String usage.
4262         (cygpackage::set_canonical_version): Ditto.
4263         (cygpackage::destroy): Ditto.
4264         (cygpackage::getfirstfile): Ditto.
4265         (cygpackage::getnextfile): Ditto.
4266         (cygpackage::Name): Ditto.
4267         (cygpackage::Vendor_version): Ditto.
4268         (cygpackage::Package_version): Ditto.
4269         (cygpackage::Canonical_version): Ditto.
4270         (cygpackage::set_sdesc): Ditto.
4271         (cygpackage::set_ldesc): Ditto.
4272         (cygpackage::name): Ditto.
4273         (cygpackage::vendor): Ditto.
4274         (cygpackage::packagev): Ditto.
4275         (cygpackage::canonical): Ditto.
4276         (cygpackage::fn): Ditto.
4277         (cygpackage::sdesc): Ditto.
4278         (cygpackage::ldesc): Ditto.
4279         * desktop.cc: Update includes for use of String class.
4280         (batname): Update for String usage.
4281         (iconname): Ditto.
4282         (make_link): Ditto.
4283         (start)menu): Ditto.
4284         (desktop_icon): Ditto.
4285         (make_cygwin_bat): Ditto.
4286         (make_etc_profile): Ditto.
4287         (uexists): Ditto.
4288         (make_passwd_group): Ditto.
4289         (save_icon): Ditto.
4290         (check_desktop): Ditto.
4291         (check_startmenu): Ditto.
4292         * dialog.cc (eget): Update for String usage.
4293         (egetString): New function.
4294         (eset): New variant for Strings.
4295         * dialog.h: Include String++.h for parsing this file.
4296         (egetString): New function.
4297         (eset): New variant for Strings.
4298         * diskfull.cc (diskfull): Update for String usage.
4299         * diskfull.h: Include String++.h for parsing this file.
4300         (diskfull): Update for String usage.
4301         * download.cc: Update includes for use of String class.
4302         (check_for_cached): Update for String usage.
4303         (download_one): Ditto.
4304         * filemanip.cc (get_file_size): Ditto.
4305         (base): Ditto.
4306         (parse_filename): Ditto.
4307         (backslash): Ditto.
4308         * filemanip.h: Include String++.h for parsing this file.
4309         (fileparse): Update for String usage.
4310         (base): Ditto.
4311         (parse_filename): Ditto.
4312         Don't consider '_' to be a separator.
4313         (backslash): Ditto.
4314         * find.cc: Update includes for use of String class.
4315         (find_sub): Make more flexible.
4316         (find): Update for String usage.
4317         * find.h (find): Use Strings.
4318         * fromcwd.cc (found_file): Update for String usage.
4319         * geturl.cc: Ditto.
4320         (init_dialog): Ditto.
4321         (get_url_to_membuf): Ditto.
4322         (get_url_to_string): Ditto.
4323         (get_url_to_file): Ditto.
4324         * geturl.h: Ditto.
4325         (get_url_to_membuf): Ditto.
4326         (get_url_to_string): Ditto.
4327         (get_url_to_file): Ditto.
4328         * hash.h: Ditto.
4329         (add_subdirs): Ditto.
4330         * ini.cc: Update includes for String usage.
4331         (find_routine): Update for String usage.
4332         (do_remote_ini): Ditto.
4333         (do_ini_thread): Ditto.
4334         * ini.h (ini_init): Ditto.
4335         * inilex.l: Update includes for String usage.
4336         (ini_init): Update for String usage.
4337         * iniparse.y: Ditto.
4338         (add_correct_version): Ditto.
4339         * install.cc: Update includes for String usage.
4340         (install_one_source): Update for String usage.
4341         (uninstall_one): Ditto.
4342         (replace_one): Ditto.
4343         (install_one_source): Ditto.
4344         (do_install_thread): Ditto.
4345         * io_stream.cc: Update includes for String usage.
4346         (io_stream::open): Update for String usage.
4347         (io_stream::mkpath_p): Ditto.
4348         (io_stream::remove): Ditto.
4349         (io_stream::mklink): Ditto.
4350         (io_stream::move_copy): Ditto.
4351         (io_stream::move): Ditto.
4352         (io_stream::exists): Ditto.
4353         * io_stream.h: Update includes to allow correct parsing.
4354         (io_stream::open): Update for String usage.
4355         (io_stream::mkpath_p): Ditto.
4356         (io_stream::remove): Ditto.
4357         (io_stream::mklink): Ditto.
4358         (io_stream::move_copy): Ditto.
4359         (io_stream::move): Ditto.
4360         (io_stream::exists): Ditto.
4361         * io_stream_cygfile.cc: Update includes for String usage.
4362         (get_root_dir_now): Update for String usage.
4363         (io_stream_cygfile::io_stream_cygfile): Ditto.
4364         (io_stream_cygfile::~io_stream_cygfile): Ditto.
4365         (io_stream_cygfile::exists): Ditto.
4366         (io_stream_cygfile::remove): Ditto.
4367         (io_stream_cygfile::mklink): Ditto.
4368         (cygmkdir_p): Ditto.
4369         (io_stream_cygfile::set_mtime): Ditto.
4370         (io_stream_cygfile::move): Ditto.
4371         (io_stream_cygfile::get_size): Ditto.
4372         * io_stream_cygfile.h: Update includes for String usage.
4373         (io_stream_cygfile::io_stream_cygfile): Update for String usage.
4374         (io_stream_cygfile::~io_stream_cygfile): Ditto.
4375         (io_stream_cygfile::exists): Ditto.
4376         (io_stream_cygfile::remove): Ditto.
4377         (io_stream_cygfile::mklink): Ditto.
4378         (cygmkdir_p): Ditto.
4379         (io_stream_cygfile::set_mtime): Ditto.
4380         (io_stream_cygfile::move): Ditto.
4381         (io_stream_cygfile::get_size): Ditto.
4382         (io_stream_cygfile::fname): Ditto.
4383         (io_stream_cygfile::lmode): Ditto.
4384         * io_stream_file.cc: Update includes for String usage.
4385         (io_stream_file::io_stream_file): Update for String usage.
4386         (io_stream_file::~io_stream_file): Ditto.
4387         (io_stream_file::exists): Ditto.
4388         (io_stream_file::remove): Ditto.
4389         (io_stream_file::mklink): Ditto.
4390         (io_stream_file::set_mtime): Ditto.
4391         (io_stream_file::move): Ditto.
4392         (io_stream_file::get_size): Ditto.
4393         * io_stream_file.h: Update includes for String usage.
4394         * io_stream_file.cc: Update includes for String usage.
4395         (io_stream_file::io_stream_file): Update for String usage.
4396         (io_stream_file::~io_stream_file): Ditto.
4397         (io_stream_file::exists): Ditto.
4398         (io_stream_file::remove): Ditto.
4399         (io_stream_file::mklink): Ditto.
4400         (io_stream_file::set_mtime): Ditto.
4401         (io_stream_file::move): Ditto.
4402         (io_stream_file::get_size): Ditto.
4403         (io_stream_file::fname): Ditto.
4404         (io_stream_file::lmode): Ditto.
4405         * localdir.cc: Update includes for String usage.
4406         (save_local_dir): Update for String usage.
4407         (check_if_enable_next): Ditto.
4408         (load_dialog): Ditto.
4409         (browse_cb): Ditto.
4410         (LocalDirPage::OnInit): Ditto.
4411         (LocalDirPage::OnNext): Ditto.
4412         * log.cc: Update includes for String usage.
4413         (struct LogEnt): Update for String usage.
4414         (log): Ditto.
4415         (log_save): Ditto.
4416         (exit_setup): Ditto.
4417         * log.h: Update includes for String usage.
4418         (log_level): Update for String usage.
4419         (log): Ditto.
4420         (log_save): Ditto.
4421         * main.cc (WinMain): Update for String usage.
4422         * mklink2.c (make_link_2): Update for String usage.
4423         * mklink2.h (make_link_2): Update for String usage.
4424         * mount.cc: Update includes for String usage.
4425         (mount_table): Update for String usage.
4426         (find2): Ditto.
4427         (create_mount): Ditto.
4428         (remove1): Ditto.
4429         (remove_mount): Ditto.
4430         (read_mounts): Ditto.
4431         (set_root_dir): Ditto.
4432         (get_root_dir): Ditto.
4433         (path_prefix_p): Ditto.
4434         (cygpath): Ditto.
4435         * mount.h: Update includes for String usage.
4436         (create_mount): Update for String usage.
4437         (remove_mount): Ditto.
4438         (cygpath): Ditto.
4439         (set_root_dir): Ditto.
4440         (get_root_dir): Ditto.
4441         * msg.cc (mbox): Ditto.
4442         * net.cc (NetPage::OnNext): Ditto.
4443         * package_db.cc (packagedb::flush): Ditto.
4444         (packagedb::packages): Ditto.
4445         (packagedb::categories): Ditto.
4446         * package_db.h: Update includes for String usage.
4447         (packagedb::packages): Update for String usage.
4448         (packagedb::categories): Ditto.
4449         * package_meta.cc: Update includes for String usage.
4450         (hash::add_subdirs): Update for String usage.
4451         (packagemeta::uninstall): Ditto.
4452         (packagemeta::SDesc): Ditto.
4453         (packagemeta::action_caption): Ditto.
4454         * package_meta.h: Update includes for String usage.
4455         (packagemeta::packagemeta): Update for String usage.
4456         (packagemeta::~packagemeta): Ditto.
4457         (packagemeta::uninstall): Ditto.
4458         (packagemeta::SDesc): Ditto.
4459         (packagemeta::action_caption): Ditto.
4460         (package_source.cc site::site): Ditto.
4461         (packagesource::set_canonical): Ditto.
4462         (packagesource::set_cached): Ditto.
4463         * package_source.h: Update includes for String usage.
4464         (site::site): Update for String usage.
4465         (packagesource::set_canonical): Ditto.
4466         (packagesource::set_cached): Ditto.
4467         (packagesource::packagesource): Ditto.
4468         (packagesource::sites): Ditto.
4469         (packagesource::cached): Ditto.
4470         * package_version.h: Update includes for String usage.
4471         (Dependency): Update for String usage.
4472         (packageversion): Ditto.
4473         * postinstall.cc: Update includes for String usage.
4474         (do_postinstall): Update for String usage.
4475         * res.rc (IDD_LOCAL_DIR): Fix typo again!
4476         * rfc1738.cc (rfc1738_escape_part): Update for String usage.
4477         * rfc1738.h: Update includes for String usage.
4478         (rfc1738_escape_part): Update for String usage.
4479         * root.cc: Update includes for String usage.
4480         (check_if_enable_next): Update for String usage.
4481         (save_dialog): Ditto.
4482         (browse_cb): Ditto.
4483         (directory_is_absolute): Ditto.
4484         (directory_is_rootdir): Ditto.
4485         (directory_has_spaces): Ditto.
4486         (RootPage::OnInit): Ditto.
4487         (RootPage::OnNext): Ditto.
4488         * script.cc: Update includes for String usage.
4489         (init_run_script): Update for String usage.
4490         (run): Ditto.
4491         (run_script): Ditto.
4492         (try_run_script): Ditto.
4493         * script.h: Update includes for String usage.
4494         (run_script): Update for String usage.
4495         (try_run_script): Ditto.
4496         * site.cc site_list): Ditto.
4497         (all_site_list): Ditto.
4498         (other_url): Eliminate.
4499         (site_list_type::init): Update for String usage.
4500         (site_list_type::site_list_type): Ditto.
4501         (get_site_list): Ditto.
4502         (get_saved_sites): Ditto.
4503         (do_download_site_info_thread): Ditto.
4504         (SitePage::OnNext): Ditto.
4505         (SitePage::OnActivate): Ditto.
4506         (SitePage::PopulateListBox): Ditto.
4507         (SitePage::OnMessageCmd): Handle empty url's.
4508         * site.h: Update includes for String usage.
4509         (site_list_type::site_list_type): Update for String usage.
4510         (site_list_type::init): Ditto.
4511         (site_list_type::~site_list_type): Ditto.
4512         (site_list_type::url): Ditto.
4513         (site_list_type::displayed_url): Ditto.
4514         (site_list_type::key): Ditto.
4515         * source.cc (SourcePage::OnDeactivate): Ditto.
4516         * state.h: Update includes for String usage.
4517         (local_dir): Update for String usage.
4518         (trust_level): Remove.
4519         * version.cc: Update includes for String usage.
4520         (canonicalize_version): Update for String usage.
4521         * version.h: Update includes for String usage.
4522         (canonicalize_version): Update for String usage.
4523
4524 2002-02-15  Christopher Faylor  <cgf@redhat.com>
4525
4526         * filemanip.c (parse_filename): Revert previous change.
4527
4528 2002-02-14  Christopher Faylor  <cgf@redhat.com>
4529
4530         * filemanip.c (parse_filename): Don't treat '_' as a version number
4531         introducer.
4532
4533 2002-01-29  Christopher Faylor  <cgf@redhat.com>
4534
4535         * configure: Regenerate.
4536
4537 2002-01-27  Robert Collins  <rbtcollins@hotmail.com>
4538
4539         * res.rc (IDD_LOCAL_DIR): Fix typo reported by Rene
4540         <Hoeck@extern.lrz-muenchen.de>
4541
4542 2002-01-27  Robert Collins  <rbtcollins@hotmail.com>
4543
4544         * README: Update Todo's.
4545         * list.h: Run indent.
4546         (list): New methods checksize and insert to reduce code duplication.
4547         (list::registerbykey): Use them.
4548         (list::registerbyobject): Ditto.
4549         (list::removebyindex): Copy each object individually - safe for non
4550         trivial objects.
4551         (list::checksize): Implement.
4552         (list::insert): Implement.
4553
4554 2002-01-27  Robert Collins  <rbtcollins@hotmail.com>
4555
4556         * Makefile.in: Remove the dlmalloc object by default.
4557         * install.cc (do_install_thread): Remove the mallinfo call for 'working
4558         around' the crashing issue.
4559         * package_db.h: Include <string.h> - it's needed to parse this.
4560         * package_source.cc (site::site): Move here from the header file.
4561         * package_source.h (site): Stop the constructor being inlinable.
4562
4563 2002-01-26  Robert Collins  <rbtcollins@hotmail.com>
4564
4565         * filemanip.cc (find_tar_ext): Add a descriptive comment.
4566
4567 2002-01-25  Michael A Chase <mchase@ix.netcom.com>
4568
4569         * filemanip.cc (find_tar_ext): Clean up tests for .tar.gz and .tar.
4570         * fromcwd.cc (do_fromcwd): Expand FIXME comment in source file check.
4571         * install.cc (install_one_source): Add space between words in log()
4572         call.
4573
4574 2002-01-22  Robert Collins  <rbtcollins@hotmail.com>
4575
4576         * log.cc (exit_setup): When saving to the download dir, explicity
4577         specify the path.
4578
4579 2002-01-22  Robert Collins  <rbtcollins@hotmail.com>
4580
4581         * archive.cc (extract_file): Separate out the prefix and the URL
4582         scheme.
4583         * archive.h (archive::extract_file): Ditto.
4584         * install.cc (install_one_source): Ditto.  Use the new
4585         archive::extract_file syntax.
4586         (replace_one): Use the new syntax.
4587         (io_stream.cc): Add some log info for links.
4588
4589 2002-01-22  Robert Collins  <rbtcollins@hotmail.com>
4590
4591         * PickCategoryLine.cc (PickCategoryLine::actiontext): Remove.
4592         (PickCategoryLine::paint): Use the new action method.
4593         (PickCategoryLine::click): Set the action for all children.
4594         (PickCategoryLine::set_action): New method.
4595         * PickCategoryLine.h (PickCategoryLine::-actions): Remove.
4596         (PickCategoryLine::current_default): Use packagemeta _actions class.
4597         * PickLine.h (PickLine::set_action): New abstract method that requires
4598         including package_meta.h.
4599         * PickPackageLine.cc (PickPackageLine::set_action): New method.
4600         * PickPackageLine.h (PickPackageLine::set_action): Declare this.
4601         * list.h (getbykey): A const correctness fix.
4602         * package_meta.cc: Run indent.
4603         (packagemeta::Default_action): New const.
4604         (packagemeta::Install_action): Ditto.
4605         (packagemeta::Reinstall_action): Ditto.
4606         (packagemeta::Uninstall_action): Ditto.
4607         (packagemeta::_actions::caption): New method.
4608         (packagemeta::_actions::operator++): Ditto.
4609         (packagemeta::set_action): New overload.
4610         * package_meta.h (packagemeta::_actions): New class.
4611         (packagemeta::set_action): Declare this.
4612
4613 2002-01-22  Robert Collins  <rbtcollins@hotmail.com>
4614
4615         * Makefile.in (OBJS): Remove supp.o - it appears accidental.
4616         * choose.cc: Don't define alloca anymore, it's done in win32.h
4617
4618 2002-01-22  Robert Collins  <rbtcollins@hotmail.com>
4619
4620         * PickPackageLine.cc: New file.
4621         * PickPackageLine.h: New file.
4622         * PickLine.cc: New file.
4623         * PickLine.h: New file.
4624         * PickCategoryLine.cc: New file.
4625         * PickCategoryLine.h: New file.
4626         * PickView.cc: New file.
4627         * PickView.h: New file.
4628         * Makefile.in: Add new objects to setup.exe.
4629         Backout -fno-exceptions option.
4630         * choose.cc: Include PickView.h.
4631         Remove view related defines and static variables.
4632         (_pkg_headers): Moved to PickView.cc.
4633         (_cat_headers): Ditto.
4634         (view::views::Unknown): Ditto.
4635         (view::views::PackageFull):
4636         (view::views::Package):
4637         (view::views::Category):
4638         (pkgtrustp): Moved to package_meta.cc.
4639         (add_required): Moved to package_meta.cc.
4640         (pick_category_line::empty): Moved to PickCategoryLine.cc
4641         (paint): Adjust for moved static variables.
4642         (view::scroll): Moved to PickView.cc.
4643         (list_vscroll): Adjust for moved static variables.
4644         (list_hscroll): Ditto.
4645         (list_click): Ditto.
4646         (note_width): Moved to PickView.cc.
4647         (view::view): Ditto.
4648         (view::set_view_mode): Ditto.
4649         (view::mode_caption): Ditto.
4650         (view::views::caption): Ditto.
4651         (view::set_headers): Ditto.
4652         (DoInsertItem): Ditto.
4653         (view::init_headers): Ditto.
4654         (view::insert_pkg): Ditto.
4655         (view::insert_category): Ditto.
4656         (view::clear_view): Ditto.
4657         (view::views::operator++): Ditto.
4658         (view::click): Ditto.
4659         (default_trust): Adjust for moved statics.
4660         (pick_pkg_line::paint): Moved to PickPackageLine.cc.
4661         (pick_pkg_line::click): Ditto.
4662         (pick_category_line::actiontext): Moved to PickCategoryLine.cc
4663         (pick_category_line::paint): Ditto.
4664         (pick_category_line::click): Ditto.
4665         (set_view_mode): Adjust for moved statics.
4666         (create_listview): Ditto.
4667         * choose.h: Remove Category and packagemeta forward defines -
4668         not needed.
4669         Don't include unneeded headers list and package_meta.
4670         (_header): Move to PickView.h.
4671         (pick_line): Move to PickLine.h.
4672         (pick_pkg_line): Move to PickPackageLine.h.
4673         (pick_category_line): Move to PickCategoryLine.h.
4674         (view): Move to PickView.h.
4675         * ini.h (trusts): Move to package_meta.h.
4676         * package_meta.h (trusts): New enum.
4677         (packagemeta::set_requirements): New helper method.
4678         (packagemeta::trustp): Ditto.
4679
4680 2002-01-21  Christopher Faylor  <cgf@redhat.com>
4681
4682         * choose.h (view): Move forward declaration of views into public area
4683         or g++ v3 will complain.
4684
4685 2002-01-21  Christopher Faylor  <cgf@redhat.com>
4686
4687         * Makefile.in (CXXFLAGS): Add -fno-exceptions.
4688         * win32.h (alloca): Define as __builtin_alloca.
4689         * io_stream_memory.cc: Add include file.
4690
4691 2002-01-21  Robert Collins  <rbtcollins@hotmail.com>
4692
4693         * archive_tar.cc (archive_tar::~archive_tar): Mark the stream as
4694         destroyed.
4695         * archive_tar_file.cc (archive_tar_file::~archive_tar_file): Ditto.
4696         * compress.cc (compress::~compress): Be less verbose.
4697         * compress_bz.cc (compress_bz::~compress_bz): Ditto.
4698         Mark the stream as destroyed.
4699         * compress_gz.cc (compress_gz::~compress_gz): Mark the stream as
4700         destroyed.
4701         * io_stream.cc (io_stream::~io_stream): Only warn when the stream is not
4702         marked as destroyed.
4703         * io_stream_cygfile.cc (io_stream_cygfile::~io_stream_cygfile): Mark the
4704         stream as destroyed.
4705         * io_stream_file.cc (io_stream_file::~io_stream_file): Ditto.
4706         * io_stream_memory.cc (io_stream_memory::~io_stream_memory): Ditto.
4707
4708 2002-01-21  Robert Collins  <rbtcollins@hotmail.com>
4709
4710         * Makefile.in (CFLAGS): Allow customisable malloc debug flags.
4711         (OBJS): Link in malloc objects.
4712         * category.cc (category): Use new char, not strdup.
4713         * choose.cc (pick_pkg_line::paint): Allow for the regionsize to shrink.
4714         (do_choose): Use new char, not malloc.
4715         * concat.cc (vconcat): Ditto.
4716         * cygpackage.cc (cygpackage): Use new char, not strdup.
4717         (set_canonical_version): Ditto.
4718         (cygpackage::destroy): Use delete[], not free.
4719         * desktop.cc (uexists): Ditto.
4720         * dialog.cc (egest): Use new char, not strdup.
4721         * dlmalloc.c: New file - Doug Lea's malloc 2.7.0
4722         * hash.cc (hash::hash): Use delete instead of free.
4723         (hash::add): Use new char, not strdup.
4724         * ini.cc (do_remote_ini): Use delete[] not free.
4725         * inilex.l: Use new char, not strdup.
4726         (ini_init): Ditto.
4727         * iniparse.y: Ditto.
4728         Use a local package_db rather than a static one.
4729         * install.cc (struct mallinfo): Workaround an apparent dlmalloc bug.
4730         (do_install_thread): Call mallinfo to force a consistency check. Appears
4731         to fix a 'inuse' error in -DDEBUG builds.
4732         Use delete[] for strings.
4733         * io_stream_cygfile.cc (io_stream_cygfile::io_stream_cygfile): Use new
4734         char, not strdup.
4735         (io_stream_cygfile::~io_stream_cygfile): Use delete[], not free.
4736         (io_stream_cygfile::remove): Use new char, not strdup.
4737         * io_stream_file.cc (io_stream_file::io_stream_file): Use new char, not
4738         strdup.
4739         (io_stream_file::io_stream_file): Use delete[], not free.
4740         (io_stream_file::remove): Use new char, not strdup.
4741         * io_stream_memory.cc (memblock::~memblock): Use delete[], not free.
4742         * io_stream_memory.h (memblock): Use new char, not malloc.
4743         * localdir.cc (LocalDirPage::OnInit): Use new char, not strdup.
4744         * main.cc (WinMain): Use new char, not strdup.
4745         * mount.cc (find2): Use new char, not malloc.
4746         (read_mounts): Ditto.
4747         (cygpath): Use new char, not strdup.
4748         * netio.cc (NetIO::~NetIO): Use delete[], not free.
4749         (NetIO::set_url): Use new char, not strdup.
4750         (NetIO::get_ftp_auth): Use delete[], not free.
4751         * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
4752         Use new char instead of strdup.
4753         * nio-http.cc (base64_encode): Use new char, not malloc.
4754         * package_meta.cc (hash::add_subdirs): Use new char instead of strdup.
4755         * package_source.h (~ packagesource): Use delete[] instead of delete.
4756         * port.h (strdup): Deprecate the use of strdup.
4757         * rfc1738.cc (rfc1738_do_escape): Use new char, not calloc.
4758         * script.cc (init_run_script): Us delete[], not free.
4759         (run_script): Ditto.
4760         * simpsock.cc (SimpleSocket::fill): Use new char, not malloc.
4761         (SimpleSocket::invalidate): Use delete[], not free.
4762         * site.cc (site_list_type::init): Use new char instead of strdup.
4763         * site.h (~site_list_type): Use delete[], not free.
4764
4765 2002-01-20  Robert Collins  <rbtcollins@hotmail.com>
4766
4767         * Makefile.in (OBJS): Add win32.o - win32 support functions.
4768         * README: Update todos.
4769         * archive.cc (extract_file): Support a suffix for appending to extracted
4770         files.
4771         * archive.h: Ditto.
4772         * choose.cc (set_view_mode): Use the new view::views class.
4773         (view::views::Unknown): New static for defaulting view::views variables.
4774         (view::views::PackageFull): New static for the current view.
4775         (view::views::Package): Ditto.
4776         (view::views::Category): Ditto.
4777         (topbucket::paint): Remove.
4778         (topbucket::empty): Rename to pick_category_line::empty.
4779         (topbucket::~topbucket): Remove.
4780         (paint): Use the new view::views class.
4781         Don't paint 'all' as a category when showing package categoies.
4782         (pick_category_line::actiontext): New method.
4783         (pick_category_line::paint): Make showing the category optional, and
4784         show the 'category action'.
4785         (pick_category_line::click): Make showing the category optional, and
4786         differentiate between the name being clicked, and the action
4787         description.
4788         (view::view): Use the new view::views class.
4789         (view::set_view_mode): Ditto.
4790         (view::mode_caption): Ditto.
4791         (view::views::caption): New method.
4792         (view::set_headers): Use the new view::views class.
4793         (view::clear_view): Ditto.
4794         (viewsplusplus): Replaced by
4795         (view::views::operator++): New operator.
4796         (set_view_mode): Use the new view::views class.
4797         (create_listview): Ditto.
4798         (dialog_cmd): Ditto.
4799         * choose.h (actions): Remove.
4800         (views): Remove.
4801         (pick_line): Add a new convenience constructor.
4802         (top_bucket): Remove.
4803         (pick_category_line): Reparent under pick_line, and adsorb top_bucket.
4804         (view::views): New class.
4805         * ini.h: Don't include choose.h
4806         (is_download_action): Remove.
4807         (is_upgrade_action): Remove.
4808         (is_uninstall_action): Remove.
4809         (is_full_action): Remove.
4810         * install.cc (num_replacements): New static.
4811         (rebootneeded): Ditto.
4812         (replace_one): Handle upgrades separate from removal or new installs.
4813         (install_one_source): Handle in use files.
4814         (install_one): Don't repeat upgrades.
4815         (do_install_thread): Initialize new statics.
4816         Order actions as uninstall, replace, install.
4817         Warn about rebooting if needed.
4818         * res.rc (IDS_REBOOT_REQUIRED): New string.
4819         * resource.h (IDS_REBOOT_REQUIRED): Give value.
4820         * win32.h: Declare class Win32, and update copyright and intent message.
4821         * win32.cc: New file.
4822
4823 2002-01-15  Corinna Vinschen  <corinna@vinschen.de>
4824
4825         * io_stream.cc (io_stream::gets): Eliminate trailing new line chars.
4826         * package_meta.cc (packagemeta::uninstall): Check for additional
4827         Windows shortcut.  Unset R/O file attribute before trying to delete
4828         file.
4829
4830 2002-01-09  Robert Collins  <rbtcollins@hotmail.com>
4831
4832         * choose.cc (pkgtrustp): Fall back to installed if a package is not
4833         present in the current trust level. For prev, fall back via curr.
4834         (set_existence): Allow sources with no sites, but cached files to be
4835         kept.
4836         (pick_category_line::paint): Start drawing clickable categories.
4837         * fromcwd.cc (found_file): Reinstate local file scanning.
4838
4839 2002-01-07  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
4840
4841         * fromcwd.cc: Run indent.
4842         (do_fromcwd): Reverse sense of comment.  Set next_dialog
4843         to IDD_CHOOSER instead of IDD_CHOOSE.
4844         * ini.cc (find_routine): Remove "/" from "/setup.ini".
4845
4846 2001-01-07  Robert Collins  <rbtcollins@hotmail.com>
4847
4848         * category.cc (Categorycmp): Add a const safe version.
4849         * category.h (Categorycmp): Add a const safe version.
4850         (Category): Add operator ==.
4851         * choose.cc (fill_missing_category): Add every package to "All".
4852         (pick_category_line::paint): Add support for hidden labels, and a tree
4853         depth.
4854         (pick_category_line::click): Ditto.
4855         (view::view): Pass in a top level category to use.
4856         (view::insert_pkg): Special case - skip category "All".
4857         (view::insert_category): Ditto.
4858         (view::clear_view): Set the contents label state.
4859         (create_listview): Pass in a top level category to view().
4860         * choose.h (topbucket): Make bucket available to derived classes.
4861         (pick_category_line):  Add support for hidden labels, and a tree depth.
4862         Remove our second copy of bucket.
4863         (view): Pass in a top level category to the constructor.
4864         Use pick_category_line to allow three level display.
4865
4866 2001-01-06  Robert Collins  <rbtcollins@hotmail.com>
4867
4868         * cygpackage.h (cygpackage): Make set_[s|l]desc virtual.
4869         * iniparse.y (add_correct_version): Copy descriptions across.
4870         * package_meta.cc (SDesc): Iterate through versions, return the first
4871         with a description.
4872         * package_version.h (packageversion): Add new virtuals set_[l|s]desc.
4873
4874 2001-01-04  Robert Collins  <rbtcollins@hotmail.com>
4875
4876         * script.cc (run_script): Change cygpath:// to cygfile://.
4877         * install.cc (do_install_thread): Fix off-by-one errors.
4878
4879 2001-01-04  Robert Collins  <rbtcollins@hotmail.com>
4880
4881         * package_db.cc (packagedb::flush): Fix an off-by-one error.
4882
4883 2002-01-04  Jan Nieuwenhuizen  <janneke@gnu.org>
4884
4885         * Makefile.in (realclean): more clean.
4886         (OBJS): Add script.o.
4887         * postinstall.cc (run_script_in_etc_postinstall): New function.
4888         (do_postinstall): Split off new funtion init_run_script ().
4889         (init_run_script):
4890         (run):
4891         (run_script): Move to script.cc.  Replace some deprecated remove
4892         and move calls.
4893         * script.h:
4894         * script.cc: New file.
4895         * Forward port cygwin-20010707.jcn3.patch.
4896         * package_meta.cc (uninstall): Run pre- and postremove scripts.
4897         * install.cc: Typo fix.
4898         (do_install): Run script initialisation.
4899
4900 2001-01-04  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
4901
4902         * cistring.cc: Run d2u.
4903         * cistring.h: Run d2u.
4904
4905         * desktop.cc (etc_profile): Remove "test -f ./.bashrc && . ./.bashrc"
4906         from the generated /etc/profile.  Bash will source this file
4907         automatically, and having this here merely results in .bashrc being
4908         executed twice. Run d2u.
4909         * desktop.h: Run d2u.
4910
4911         * propsheet.cc: Run d2u.
4912         (PropSheetProc): New function.  Add minimize box here instead of in
4913         PropertyPage::DialogProc.
4914         (PropSheet::Create): Change to use creation callback PropSheetProc.
4915         (DLGTEMPLATEEX): Add 'hidden' Windows struct definition.
4916
4917         * propsheet.h: Run indent, d2u.
4918         * proppage.h: Run indent, d2u.
4919
4920         * proppage.cc: Run d2u.
4921         (PropertyPage::DialogProc): Remove minimize-box-adding
4922         functionality.  Remove commented-out "PropSheet_SetWizButtons" calls.
4923         Add support for calling virtual OnMessageCmd.  Add setting of fonts in
4924         WM_INITDIALOG handler.
4925         (resource.h): New include for resource IDs.
4926
4927         * res.rc: Resize and rearrange property page dialog templates
4928         to bring them in line with "Microsoft's Backward Compatible Wizard 97"
4929         specification.  Run d2u.
4930         (IDD_SITE): Add an edit control and an "Add" button in order to
4931         combine the IDD_SITE and IDD_OTHER_URL functionality onto one page.
4932         (IDD_OTHER_URL): Remove dialog template.
4933         (IDD_DLSTATUS): Remove dialog template.
4934
4935         * site.cc: Run d2u.
4936         (SitePage::OnBack): Remove NEXT() macro invocation.
4937         (SitePage::OnActivate): New member function.
4938         (load_dialog): Remove.  Functionality subsumed into
4939         SitePage::OnActivate.
4940         (save_dialog): Change to support both list and user URLs.  Remove
4941         OTHER_IDX and mirror_idx logic.
4942         (SitePage::PopulateListBox): New member function.
4943         (SitePage::CheckControlsAndDisableAccordingly): New member function.
4944         (SitePage::OnMessageCmd): New override.
4945         (check_if_enable_next): Remove.
4946         (dialog_cmd): Remove.
4947         (do_download_site_info_thread): Remove calls to NEXT() macro.
4948         (SitePage::Create): Call the single-param PropertyPage::Create
4949         overload.
4950         (other_url): New static taken from other.cc.
4951         (SitePage::OnNext): Remove mirror_idx logic.
4952         (SitePage::OnInit): Remove "Other URL" entry from list box.  Remove
4953         list box populating code, now handled in SitePage::PopulateListBox.
4954         (mirror_idx, NO_IDX, OTHER_IDX): Remove.
4955         (save_site_url): Fix potential buffer overflow problem.  Switched to
4956         TCHAR in grossly premature preparation for multilingual support.
4957         * site.h: Run d2u.
4958         (SitePage::OnActivate): New member function.
4959         (SitePage::CheckControlsAndDisableAccordingly) New member.
4960         (SitePage::OnMessageCmd): New override.
4961         (do_download_site_info_thread): Add MessageBox call on failure to
4962         download site list.
4963
4964         * splash.cc: Run d2u.
4965         (SplashPage::OnInit): Set the font for the title.
4966         * splash.h: Run d2u.
4967
4968         * threebar.cc: Run d2u.
4969         * threebar.h: Run d2u.
4970
4971         * window.h: Run d2u.
4972         (Window::IsButtonChecked): New member function declaration.
4973         (Window::OnMessageCmd): New member function.
4974         (Window::SetDlgItemFont): New member function declaration.
4975         (Window::MAXFONTS, Window::Fonts, Window::FontCounter): New data
4976         members.
4977         * window.cc: Run d2u.
4978         (Window::IsButtonChecked): New member function definition.
4979         (Window::SetDlgItemFont): New member function definition.
4980         (Window::Window): Add initialization for FontCounter.
4981         (Window::~Window): Delete any fonts we created.
4982
4983         * geturl.cc: Run d2u.
4984         (progress): Remove the "3" field width from the "%3d"
4985         percent-complete format indicator.  Causes line to not start at
4986         beginning of text box, and does little to help with "jumping", since
4987         the "bytes downloaded so far" field is variable-width anyway.  Change
4988         kb/s format field to "%03.1" to 0-pad the kb/s number in the event of
4989         painfully slow connections, or temporary slowdowns in faster
4990         connections should such more-instantaneous functionality become
4991         available.
4992
4993         * net.h: Run d2u.
4994         (NetPage::OnMessageCmd): New member function declaration.
4995         (NetPage::CheckIfEnableNext): New member function declaration.
4996         * net.cc: Run d2u.
4997         (NetPage::OnMessageCmd): New member function definition.
4998         (dialog_cmd): Remove, subsumed into NetPage::OnMessageCmd.
4999         (check_if_enable_next): Remove.
5000         (NetPage::CheckIfEnableNext): New member function, subsumes
5001         check_if_enable_next.
5002         (propsheet.h): Add include.
5003         (NetPage::Init): Add call to CheckIfEnableNext.
5004         (load_dialog): Remove call to check_if_enable_next.
5005         (NetPage::Create): Call single-template-ID-parameter overload of
5006         PropertyPage::Create instead of three-parameter one.
5007
5008         * Makefile.in (OBJS): Remove other.o.
5009         * other.cc: Remove file.
5010
5011 2002-01-01  Robert Collins  <rbtcollins@hotmail.com>
5012
5013         * README: Update TODO's.
5014         * choose.cc (set_existence): Delete non installed packages with no
5015         mirrors.
5016         (fill_missing_category): Fix an off-by-one error.
5017         (default_trust): Ditto. Also delete any unused categories.
5018         (view::init_headers): Fix an off-by-one error.
5019         (set_view_mode): Ditto.
5020         (set_view_mode): Ditto.
5021         (create_listview): Ditto.
5022         (dialog_cmd): Ditto.
5023         (do_choose): Ditto.
5024         * io_stream.cc: Indent.
5025         * io_stream.h: Ditto.
5026         * package_db.cc: Ditto.
5027         * package_meta.h: Const correctness for SDesc ();
5028         * proppage.cc: Run d2u and indent.
5029         * propsheet.cc: Run d2u and indent.
5030         * window.cc: Run d2u and indent.
5031         * window.h: Run d2u and indent.
5032
5033 2001-12-28  Christopher Faylor  <cgf@redhat.com>
5034
5035         * Makefile.in (iniparse.o): Accommodate newer bisons.
5036
5037 2001-12-23  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
5038
5039         * window.h (Window): New file, new class.
5040         * window.cc (Window): New file, new class.
5041
5042         * threebar.h (ThreeBarProgressPage): New file, new class.
5043         * threebar.cc (ThreeBarProgressPage): New file, new class.
5044
5045         * splash.h (SplashPage): New file, new class.
5046         * splash.cc (SplashPage): Replace file with implementation of new
5047         class.
5048
5049         * source.h (SourcePage): New file, new class.
5050         * source.cc: Run indent.
5051         (SourcePage): Add class implementation to this file.
5052         (do_source): Remove, functionality subsumed by SourcePage::Create()
5053         and SourcePage::OnDeactivate().
5054         (dialog_proc): Remove, functionality subsumed by
5055         SourcePage::OnActivate().
5056
5057         * site.h: Run indent.
5058         (SitePage): Add class declaration.
5059         * site.cc: Run indent.
5060         (SitePage): Add class implementation.
5061         (do_download_site_info_thread): New function.
5062         (context): New var.  Context info for do_download_site_info_thread().
5063         (do_download_site_info): New function.
5064         (SitePage::Create, SitePage::OnInit SitePage::OnNext)
5065         (SitePage::OnBack): SitePage class implementation..
5066         (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers, now handled
5067         by SitePage members.
5068         (dialog_proc): Remove, now handled by SitePage::OnInit and base class
5069         functionality.
5070         (do_site): Remove, now handled by do_download_site_info_thread() and
5071         SitePage::OnNext functionality.
5072         (get_site_list): Remove dismiss_url_status_dialog() call.
5073
5074         * root.h (RootPage): New file, new class.
5075         * root.cc: Run indent.
5076         (dialog_cmd): Pass parent HWND parameter to note(), yesno().
5077         (dialog_proc): Remove.
5078         (do_root): Remove
5079         (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL clauses from switch.
5080         (RootPage::OnInit): New member function.  Move get_root_dir() logic to
5081         here from do_root().
5082         (RootPage::Create): New member function.
5083         (RootPage::OnNext): New member function.  Move IDOK logic from
5084         dialog_cmd() to here.
5085         (RootPage::OnBack): New member function.
5086
5087         * propsheet.h (PropSheet): New file, new class.
5088         * propsheet.cc (PropSheet): New file, new class.
5089
5090         * proppage.h (PropertyPage): New file, new class.
5091         * proppage.cc (PropertyPage): New file, new class.
5092
5093         * postinstall.cc (do_postinstall): Add owner parameter.
5094
5095         * other.cc (do_other): Add owner parameter.
5096
5097         * nio-file.cc (NetIO::Purl): Pass NULL parent param to note().
5098         * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Pass NULL parent param to
5099         get_ftp_auth().
5100         * nio-http.cc (retry_get): Pass NULL parent param to get_auth(),
5101         get_proxy_auth(),
5102         and get_ftp_auth().
5103         * nio-ie5.cc (NetIO::_url): Pass NULL parent param to note(),
5104         get_auth(), get_proxy_auth().
5105
5106         * netio.h (get_auth, get_proxy_auth, get_ftp_auth): Add owner param.
5107         * netio.cc (auth_common, NetIO::get_auth, NetIO::get_proxy_auth,
5108         NetIO::get_ftp_auth)
5109         (auth_common): Add owner param.  Pass owner param to DialogBox.
5110         (NetIO::get_auth, NetIO::get_proxy_auth, NetIO::get_ftp_auth): Pass
5111         owner param to auth_common().
5112
5113         * net.h (NetPage): New file, new class.
5114         * net.cc: Run indent.
5115         (net.h, threebar.h): Add includes.
5116         (Progress): Add extern.
5117         (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, now handled by
5118         property sheet logic.  Saved temporarily for reference.
5119         (NetPage::Create, NetPage::OnInit, NetPage::OnDeactivate,
5120         NetPage::OnNext, NetPage::OnBack):
5121         New implementation of NetPage class members.
5122         (do_net): Remove.
5123         (dialog_proc): Remove.
5124
5125         * msg.h (fatal, note, yesno): Add owner param.
5126         * msg.c (fatal, note, yesno, mbox): Add owner param.
5127         (mbox): Remove MB_TOPMOST from MessageBox call.  Unnecessary and wrong
5128         now that we have a parent.
5129
5130         * main.cc: Run indent.
5131         (commctrl.h, proppage.h, propsheet.h, splash.h, source.h)
5132         (localdir.h, net.h, site.h, choose.h, threebar.h, desktop.h): Include
5133         headers.
5134         (root_dialog_proc): extern into this file.
5135         (Progress): Progress dialog defined here, used in several other files.
5136         (WinMain): Instantiate and create Splash, Source, Root, LocalDir, Net,
5137         Site, Chooser, Desktop pages and MainWindow sheet.  Call
5138         InitCommonControls() to make sure Windows is set up for our use of
5139         property sheets. Add pages to sheet.
5140         Call MainWindow.Create() to "DoModal".  Remove main loop, that logic is
5141         now handled by the PropSheet class.
5142         (root.h): Add include.
5143
5144         * log.cc (log_save): Pass NULL parent to fatal().
5145         (exit_setup): Pass NULL parent to note().
5146
5147         * localdir.h (LocalDirPage): New file, new class.
5148         * localdir.cc:  Run indent.
5149         (localdir.h): New include.
5150         (threebar.h): New include.
5151         (Progress): extern into this file.
5152         (LocalDirPage::Create, LocalDirPage::OnInit, LocalDirPage::OnActivate)
5153         (LocalDirPage::OnNext, LocalDirPage::OnBack): Implementation of
5154         LocalDirPage.
5155         (LocalDirPage::OnNext): Move log() call from do_local_dir() to here.
5156         (dialog_cmd): Remove IDOK, ID_BACK, and IDCANCEL handlers.
5157         (do_local_dir): Remove.
5158         (dialog_proc): Remove.
5159         (cwd): Remove, not used by anything.
5160
5161         * install.cc: Run indent.
5162         (process.h, threebar.h): New includes.
5163         (Progress): extern into this file.
5164         (ins_dialog, ins_action, ins_pkgname, ins_filename, ins_pprogress)
5165         (ins_iprogress, ins_diskfull, init_event): Remove, now handled by
5166         ThreeBarProgressPage.
5167         (dialog_cmd, dialog_proc, dialog): Removed, handled in
5168         ThreeBarProgressPage.
5169         (init_dialog): Remove all mention of the above ins_* handles.  Now
5170         handled in ThreeBarProgressPage.  Altered SetWindowText()s to call
5171         ThreeBarProgressPage instance Progress directly.
5172         (progress): Alter bar update logic to call ThreeBarProgressPage
5173         instance Progress directly.
5174         (uninstall_one): Alter SetWindowText()s to call ThreeBarProgressPage
5175         instance Progress directly.
5176         (install_one_source): Alter SetWindowText()s to call
5177         ThreeBarProgressPage
5178         instance Progress directly. Pass NULL parent to note().
5179         (do_install_thread): Rename from do_install(), added owner param.
5180         Alter SetWindowText()s to call ThreeBarProgressPage instance Progress
5181         directly.
5182         Remove dismiss_url_status_dialog() call, no longer necessary.  Remove
5183         ShowWindow(<hide>) call, also unnecessary now.  Pass owner handle to
5184         fatal().
5185         (do_install_reflector): New function.
5186         (do_install): New function.
5187
5188         * ini.cc (process.h, threebar.h): New includes.
5189         (Progress): externed into this file.
5190         (find_routine): Pass NULL parent to note().
5191         (do_local_ini): Add owner param.
5192         (do_remote_ini): Add owner param.  Pass owner to get_url_to_membuf()
5193         and note().  Remove call to dismiss_url_status_dialog().
5194         (do_ini_thread): Rename from do_ini().  Add owner param.  Pass owner to
5195         do_local_ini(), do_remote_ini(), yesno(), and note().  Set next_dialog
5196         to IDD_CHOOSER on exit.
5197         (do_ini_thread_reflector): New function.
5198         (context): New var.  Context for do_ini_thread.
5199         (do_ini): New function.
5200
5201         * geturl.h (get_url_to_membuf, get_url_to_string, get_url_to_file): Add
5202         owner param.
5203         * geturl.cc (gw_dialog, gw_url, gw_rate, gw_progress, gw_pprogress,
5204         gw_iprogress)
5205         (gw_progress_text, gw_pprogress_text, gw_iprogress_text, init_event):
5206         Removed.
5207         (threebar.h): New include.
5208         (Progress): externed into this file.
5209         (dialog_cmd, dialog_proc, dialog): Removed, handled by
5210         ThreeBarProgressPage now.
5211         (init_dialog): Remove "if (gw_dialog == 0)" clause.  Alter
5212         SetWindowText()s
5213         and bar setting SendMessage()s to call ThreeBarProgressPage instance
5214         Progress directly.  Remove "one bar only" logic, this is now handled
5215         explicitly in the ThreeBarProgressPage class.
5216         (progress): Altered bar and text update logic to call
5217         ThreeBarProgressPage instance Progress directly.  Changed kbps
5218         calculation to floating point and now print out a single decimal
5219         place.
5220         (get_url_to_membuf): Add owner param.  Pass it to init_dialog.
5221         (get_url_to_string): Add owner param.  Pass it to get_url_to_membuf.
5222         (get_url_to_file): Add owner param.  Pass it to init_dialog. Alter bar
5223         update logic to call ThreeBarProgressPage instance Progress directly.
5224         (dismiss_url_status_dialog):  Remove.
5225
5226         * fromcwd.cc (do_fromcwd): Add owner param.  Initialize found_ini to
5227         false, was true.
5228
5229         * download.cc: Run indent.
5230         (process.h, threebar.h): New includes.
5231         (Progress): externed into this file.
5232         (download_one): Add owner param.  Pass it to get_url_to_file().
5233         (do_download_thread): Renamed from do_download.  Add owner param. When
5234         calculating total_download_bytes, take binpicked and srcpicked into
5235         account.  Remove call to dismiss_url_status_dialog(), no longer needed.
5236         Pass owner handle to download_one() and yesno().
5237         (do_download_reflector, do_download): New functions.
5238         (context): New var.  Context for do_download_thread().
5239
5240         * dialog.h (D(x)): Add owner param.
5241
5242         * desktop.h (DesktopSetupPage): New file, new class.
5243         * desktop.cc: Run indent.
5244         (desktop.h): Add include.
5245         (dialog_proc, do_desktop): Remove, now handled in
5246         DesktopSetupPage::OnInit().
5247         (dialog_cmd): Remove IDOK, IDC_BACK, and IDCANCEL cases, handled in
5248         DesktopSetupPage::OnFinish(), DesktopSetupPage::OnBack(), and PropSheet
5249         resp.
5250         (DesktopSetupPage::Create, DesktopSetupPage::OnInit)
5251         (DesktopSetupPage::OnBack, DesktopSetupPage::OnFinish): Implementation
5252         of DesktopSetupPage.
5253
5254         * cistring.h: New file, new class.
5255         * cistring.cc: New file, new class.
5256
5257         * choose.h: Run indent.
5258         (Chooser): New class declaration.
5259         * choose.cc: Run indent.
5260         (do_choose): Add owner param.  Pass it to DialogBox() and
5261         fatal().
5262         (Chooser): New class implementation.
5263
5264         * res.rc (IDS_VERSION_INFO): New string.
5265         (IDD_SOURCE, IDD_LOCAL_DIR, IDD_ROOT, IDD_SITE, IDD_OTHER_URL)
5266         (IDD_DLSTATUS, IDD_INSTATUS, IDD_SPLASH, IDD_CHOOSE, IDD_DESKTOP):
5267         Change WS_POPUP to WS_CHILD.  Numerous positioning/size changes
5268         throughout.
5269         (IDD_CHOOSE): Give template the WS_EX_CONTROLPARENT style to enable
5270         TAB control navigation etc.  Give the controls a reasonable tab order.
5271         Grouped radio buttons.  Something's still not right, can't tab away
5272         from back/next/cancel group reliably.
5273         * resource.h (IDD_CHOOSER): New dialog ID.
5274
5275         * Makefile.in (OBJS): Add cistring.o, proppage.o, propsheet.o,
5276         threebar.o, and window.o.
5277
5278 2001-12-21  Robert Collins  <rbtcollins@hotmail.com>
5279
5280         * choose.cc (listview_proc): Update the scrollbar when the headers are
5281         dragged.
5282         (pick_pkg_line::paint): Clip columns to prevent overlap.
5283
5284 2001-12-20  Robert Collins  <rbtcollins@hotmail.com>
5285
5286         * Makefile.in: Add libcomctl32.a for setup.exe.
5287         * archive.h (archive): Prevent non-child direct creation of the class.
5288         * archive_tar.h (archive_tar): Prevent inaccurate synthetic copy and
5289         assignment.
5290         * choose.cc: Include commctrl for the choose header.
5291         (NEW_COL_SIZE_SLOP): Define without magic numbers.
5292         (pkgtrustp): Convert to function.
5293         (set_action): Remove.
5294         (add_required, fill_missing_category,default_trust): Use list syntax for
5295         package list.
5296         Use new set_action.
5297         (choose_caption): Remove.
5298         (topbucket::paint): New method.
5299         (topbucket::empty): Ditto.
5300         (topbucket::click): Ditto.
5301         (topbucket::~topbucket): Ditto.
5302         (paint): Remove i,ii and p as they are obsolete.
5303         Remove header drawing code.
5304         Use new chooser method to paint the chooser.
5305         Use new chooser itemcount method.
5306         (scroll_common): Rename to view::scroll.
5307         Scroll the header window separately.
5308         (list_vscroll, list_hscroll, list_click): Update for new chooser
5309         methods.
5310         (listview_proc): Look for header messages.
5311         (note_width): Accept stringless calls.
5312         (pick_line::set_line): Remove.
5313         (pick_line::paint): Remove.
5314         (pick_pkg_line::paint): Paint this one line, using the header column
5315         widths.
5316         (pick_category_line::paint): Paint this category, and anything in the
5317         bucket.
5318         (pick_line::click): Remove.
5319         (pick_pkg_line::click): Handle a click.
5320         (pick_category_line::click): Handle a click.
5321         (_view): Rename all to view.
5322         (view::view): Initialise the control contents.
5323         (view::set_headers): Work with the header control.
5324         (view::init_headers): Use list syntax for package list.
5325         Rearrange the width logic a little.
5326         (view::insert_pkg): Update to use the hierarchy.
5327         (view::insert_category): Ditto.
5328         (view::insert_at, view::insert_under): Remove.
5329         (view::clear_view): Update to use the hierarchy.
5330         (view::click): Update to use the hierarchy.
5331         (set_view_mode): Use list syntax for package list.
5332         Update for new chooser methods.
5333         (DoInsertItem): New helper function. (Needs a home somewhere).
5334         (create_listview): Remove choose control code and use the constructor
5335         instead.
5336         (dialog_cmd,scan2,do_choose): Use list syntax for package list.
5337         * choose.h: Include newly required headers list and package_meta.
5338         (_voew): Rename to view.
5339         (pick_line): Convert to an ABC.
5340         (pick_pkg_line): New class.
5341         (pick_catgory_line): New class.
5342         (topbucket): New class.
5343         (view::scroll): New method created from listview_scroll function.
5344         * desktop.cc (make_passwd_group): Use list syntax for package list.
5345         * download.cc (do_download): Use list syntax for package list.
5346         * fromcwd.cc (found_file): Use list syntax for package list.
5347         * iniparse.y (pacakges): Use list syntax for package list.
5348         * install.cc (uninstall_one): Use list syntax for package list.
5349         (do_install): Use list syntax for package list.
5350         * io_stream.h (io_stream): Prevent non-child direct creation of the
5351         class.
5352         Prevent inaccurate synthetic copy and assignment.
5353         * list.h: Include required header stdlib.
5354         Work on const correctness.
5355         * package_db.cc (packagedb::getpackagebyname): Remove.
5356         (packagedb::packagedb): Remove custom list code, and make db a local.
5357         (packagedb::getfirstpackage): Remove.
5358         (packagedb::getnextpackage): Remove.
5359         (packagedb::addpackage): Remove.
5360         (flush): Remove custom list code.
5361         (packagedb::registerpackage): Remove.
5362         (packagedb::packages): New static member.
5363         (packagedb::task): New static member.
5364         * package_db.h (PackageDBActions): New enum.
5365         (packagedb): Remove getfirstpackage, getnextpackage, getpackagebyname,
5366         addpackage, registerpackage, packages, packagecount, curr_package, db.
5367         Add packages, task.
5368         * pacakge_meta.cc: Include package_db.h.
5369         (packagemeta::action_caption): New method.
5370         (packagemeta::set_action): New method.
5371         * package_meta.h (CategoryPackage): Initialise key.
5372         (packagemeta): Initialise key.
5373         Add set_action and action_caption methods.
5374         Prevent inaccurate synthetic copy and assignment.
5375         * resource.h (IDC_CHOOSE_LISTHEADER): New ID.
5376         * source.cc: Include package_db for db manipulation.
5377         (save_dialog): Set the db task.
5378         * win32.h: Tell the w32 include headers what IE version to
5379         expect/require.
5380
5381 2001-12-06  Robert Collins  <rbtcollins@hotmail.com>
5382
5383         * README: Wishlist updates.
5384
5385 2001-12-04  Robert Collins  <rbtcollins@hotmail.com>
5386
5387         * package_db.cc (getnextpackage): Don't overrun the array.
5388
5389 2001-12-04  Robert Collins  <rbtcollins@hotmail.com>
5390
5391         * Makefile.in (OBJS): Add setup_version.o.
5392         (version.c): Rename to setup_version.
5393         * choose.cc (set_action): Prevent NULL pointer dereference.
5394         (package_sort): Remove.
5395         * fromcwd.cc (canonicalize_version): Moved to version.cc.
5396         (check_ini): New function for use with find to see if there is a cached
5397         setup.ini.
5398         (do_fromcwd): Check for a cached setup.ini from any mirror site.
5399         * ini.cc (find_routine): New function, for finding cached setup.ini's.
5400         (do_local_ini): New function, drives parsing of local ini's.
5401         (do_remote_ini): New function, drives parsing and caching of remote
5402         ini's.
5403         (do_ini): Move guts to do_remote_ini and do_local_ini.
5404         * list.h (removebyindex): New method.
5405         * other.cc (save_dialog): Use new site_list and all_site_list to add the
5406         new site to the site picklist.
5407         (dialog_cmd): Only save the dialog when exiting the dialog.
5408         * res.rc (IDD_SITE): Make IDC_URL_LIST a multiple-selection control.
5409         * site.cc (site_list_type): Move to site.h
5410         (site_list): New global, sites chosen by the user.
5411         (all_site_list): New global, all potential sites.
5412         (site_list_type::init): New method, parses a mirror.lst URL string into
5413         a site_list_type object.
5414         (site_list_type::site_list_type): New method.
5415         (check_if_enable_next): Examine the control, not a local variable.
5416         (load_dialog): Select all the user chosen sites by default.
5417         (save_dialog): Adjust for multiple selection semantics.
5418         (save_site_url): Save all user chosen sites.
5419         (dialog_cmd): Don't save the dialog when the listbox recieves a message
5420         - thats not needed.
5421         Remove obsolete other_url reference.
5422         (dialog_proc): Use all_site_list instead of site_list.
5423         (site_sort): Remove.
5424         (get_site_list): Remove malloc use - use list template instead.
5425         Move site_list_type initialisation to site_list_type::init().
5426         (get_initial_list_idx): Renamed to ...
5427         (get_saved_sites): this. Also read in multiple sites to the site_list.
5428         (do_site): Use all_site_list not site_list.
5429         Log all chosen sites.
5430         * site.h: New file, defines site related class, functions and variables.
5431         * state.h: Add comment about use of state.h
5432         (mirror_site): Remove.
5433         (other_url): Remove.
5434         (MIRROR_SITE): Remove.
5435         * version.cc: New file, for version-handling and related functions.
5436
5437 2001-12-02  Robert Collins  <rbtcollins@hotmail.com>
5438
5439         * Makefile.in: Add filemanip.o to setup.
5440         * archive.cc (archive::extract_file): Use new io_stream method 'copy'.
5441         * archive_tar.h (archive_tar_file): Implement get_size virtual.
5442         (archive_tar): Ditto.
5443         * choose.cc (set_action): Use [] operator instead of getnth - its more
5444         readable.
5445         (paint): Ditto.
5446         (_view::init_headers): Ditto.
5447         (_view::insert_pkg): Ditto.
5448         (set_view_mode): Ditto.
5449         (scan2): Ditto.
5450         (do_choose): Ditto.
5451         (base): Moved to filemanip.cc.
5452         (find_tar_ext): Ditto.
5453         (parse_filename): Ditto.
5454         (_Info::_Info): Remove.
5455         * compress_bz.h (compress_bz): Implement get_size virtual.
5456         * compress_gz.h (compress_gz): Implement get_size virtual.
5457         * cygpackage.cc (cygpackage::destroy): Use array delete for char *
5458         objects.
5459         * download.cc (get_file_size): Move to filemanip.cc.
5460         (check_for_cached): Use [] operator instead of getnth - its more
5461         readable.
5462         (download_one): Ditto.
5463         * filemanip.cc: New file.
5464         * geturl.cc (init_dialog): Make url a pointer to const as it is not
5465         modified.
5466         (get_url_to_membuf): New function - contains get_url_to_string worker
5467         code.
5468         (get_url_to_string): Becomes a trivial wrapper to get_url_to_membuf.
5469         * geturl.h: Declare new prototype.
5470         * ini.cc (do_ini): Use get_url_to_membuf and pass ini_init an io_stream.
5471         Tidy up the error code a little.
5472         * ini.h: Remove __cplusplus protection for ini_init.
5473         (_Info): Remove.
5474         * inilex.l: Remove old globals.
5475         (ini_init): Use an io_stream for getting the characters.
5476         (ini_getchar): Ditto.
5477         * iniparse.y: Declare yylex as a C++ function.
5478         (add_correct_version): Use [] operator instead of getnth - its more
5479         readable.
5480         * io_stream.cc (io_stream::move_copy): Use the copy method.
5481         (io_stream::copy): New method to simply copy from one stream to another.
5482         * io_stream.h (io_stream): New static method copy, and virtual method
5483         get_size.
5484         * io_stream_cygfile.cc (io_stream_cygfile::get_size): Implement this.
5485         * io_stream_cygfile.h (io_stream_cygfile::get_size): Declare this.
5486         * io_stream_file.cc (io_stream_file::get_size): Implement this.
5487         * io_stream_file.h (io_stream_file::get_size): Declare this.
5488         * io_stream_memory.h: Include errno as it's neded to parse the header.
5489         (io_stream_memory::get_size): Implement this.
5490         (io_stream_memory::st_size): Delete this.
5491         * list.h: Change getnth into the [] operator.
5492         * netio.cc (NetIO::NetIO): Change prototype to reflect Purl not being
5493         modified.
5494         (NetIO::set_url): Ditto.
5495         (NetIO::open): Ditto.
5496         * netio.h: As for netio.cc.
5497         * nio-file.cc (NetIO_File::NetIO_File): Change prototype to reflect
5498         Purl not being modified.
5499         * nio-file.h: Ditto.
5500         * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Ditto.
5501         * nio-ftp.h (NetIO_FTP::NetIO_FTP): Ditto.
5502         * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Ditto.
5503         * nio-http.h (NetIO_HTTP::NetIO_HTTP): Ditto.
5504         * nio-i5.cc (NetIO_IE5::NetIO_IE5): Ditto.
5505         * nio-i5.h (NetIO_IE5::NetIO_IE5): Ditto.
5506         * package_meta.cc (packagemeta::~packagemeta): Bugfix: use array delete.
5507         * package_source.cc (packagesource::set_canonical): Ditto.
5508         (packagesource::set_cached): Ditto.
5509         * package_source.h (site::~site): Ditto.
5510         * site.cc: Change site_list_type to a class, and search and replace
5511         sort_key to key globally.
5512
5513 2001-12-01  Robert Collins  <rbtcollins@hotmail.com>
5514
5515         * package_source.cc (packagesource::set_canonical): Filename was out by
5516         one.
5517
5518 2001-11-30  Robert Collins  <rbtcollins@hotmail.com>
5519
5520         * Makefile.in (OBJS): Remove category_list - it's not needed.
5521         * README: More wishlist updates.
5522         * category.cc (Category::Category): Initialise new members.
5523         (Categorycmp): New function.
5524         * category.h (Category): New member key for template use.
5525         * category_list.cc: Remove.
5526         * category_list.h: Remove.
5527         (Categorycmp): New function prototype.
5528         * choose.cc: Remove category_list - not needed.
5529         (set_action): Only show the 'source' option when the source is actually
5530         available.
5531         (add_required): Fix recursion limiter to 5.
5532         (fill_missing_category): Use list access.
5533         (default_trust): Ditto.
5534         (pick_line::paint): Ditto.
5535         (_view::init_headers): Ditto.
5536         (_view::insert_pkg): Ditto.
5537         (_view::insert_category): Ditto.
5538         (_view::click): Ditto.
5539         (set_view_mode): Ditto.
5540         (do_choose): Ditto.
5541         * cygpackage.h: Remove category_list - not needed.
5542         * geturl.cc (get_url_to_string): Fix null byte insertion.
5543         * inipatse.y: Remove category_list - not needed.
5544         (categories): Use list access.
5545         * package_db.cc: Ditto.
5546         * package_db.h: Remove category_list - not needed.
5547         (packagedb): Use the list template for categories.
5548         * package_meta.cc (add_category): Ditto.
5549         * package_meta.h (CategoryPackage): Link to the category as well.
5550         (packagemeta): Use a list of CategoryPackages instead of Categories
5551         for more memory efficient cross-referencing.
5552
5553 2001-11-30  Robert Collins  <rbtcollins@hotmail.com>
5554
5555         * package_db.cc (packagedb::flush): Write a canonical version for all
5556         packages irrespective of the media they were installed from.
5557
5558 2001-11-29  Robert Collins  <rbtcollins@hotmail.com>
5559
5560         * Makefile.in (OBJS): Add package_source and rfc1738.
5561         * README: Wishlist update.
5562         * category_list.cc (register_category): Use references.
5563         * category_list.h (CategoryList): Ditto.
5564         * choose.cc (isinstalled): Remove.
5565         (pkgtrustp): New macro.
5566         (set_action): Use packagemeta.
5567         (add_required): Ditto.
5568         (choose_caption): Example package to choose caption, rather than state
5569         flags.
5570         (check_existence): Remove.
5571         (set_existence): Remove old code.
5572         (fill_missing_category): Use packagemeta.
5573         (keep_or_skip): Remove.
5574         (default_trust): Use packagemeta and set trust values directly.
5575         (pick_line::set_line): Use packagemeta.
5576         (_view::insert_pkg): Ditto.
5577         (_view::insert_category): Ditto.
5578         (_view::click): Ditto.
5579         (set_view_mode): Ditto. Also remove "exclude" code.
5580         (create_listview): Use packagemeta.
5581         (dialog_cmd): Ditto.
5582         (getpkgbyname): Remove
5583         (scan2): Use packagemeta. Temporarily comment out the holefinding code.
5584         (read_installed_db): Remove.
5585         (package_sort): Use packagemeta.
5586         (do_choose): Use packagemeta. Don't sort the packages - the db does
5587         that.
5588         * choose.h: Use packagemeta.
5589         * cygpackage.cc (cygpackage::cygpackage): Initialise all variables.
5590         (cygpackage::cygpackage): Ditto.
5591         (cygpackage::set_canonical_version): Copy the passed string.
5592         (cygpackage::~cygpackage): Move cleanup code to destroy().
5593         (cygpackage::destroy): New function.
5594         (cygpackage::getfirstfile): Use a separate buffer.
5595         (cygpackage::getnextfile): Ditto.
5596         (cygpackage::Canonical_version): New function.
5597         (cygpackage::set_sdesc): Ditto.
5598         (cygpackage::set_ldesc): Ditto.
5599         * cygpackage.h (cygpackage::Canonical_version): New method.
5600         (cygpackage::set_sdesc): New method.
5601         (cygpackage::set_ldesc): New method.
5602         (cygpackage::SDesc): New method.
5603         (cygpackage::LDesc): New method.
5604         (cygpackage::set_canonical_version): New method.
5605         * desktop.cc: Include packagedb headers.
5606         (make_password_group): Use packagemeta.
5607         * download.cc: Include packagedb headers.
5608         (check_for_cached): New method to find any cached file and fill out the
5609         database info.
5610         (download_one): Take a packagesource, support multiple mirrors.
5611         (do_download): Use packagemeta.
5612         * from cwd.cc: Include packagedb headers.
5613         (found_file): Use packagemeta.
5614         * ini.cc (do_ini): Beginning of multiple-mirror support.
5615         * ini.h (CategoryPackage): Remove.
5616         (Dependency): Remove.
5617         (Package): Remove.
5618         (new_package,getpkgbyname,getpackagecategorybyname,add_category):
5619         Remove.
5620         * inilex.l: Support multiple mirrors.
5621         * iniparse.y: Include packagedb headers.
5622         (parser): Use packagemeta.
5623         (new_package): Remove.
5624         (add_correct_version): New function.
5625         (new_requirement): Remove.
5626         (add_category): Remove.
5627         * install.cc (uninstall_one): Use packagemeta.
5628         (install_one_source): New function.
5629         (install_one): Use packagemeta.
5630         (do_install): Use packagemeta.
5631         * io_stream.cc (io_stream::move): Bugfix on move/copy case.
5632         * io_stream_cygfile.cc (io-stream_cygfile::set_mtime): Do not reopen the
5633         file after setting the mtime, it makes no sense, and results in 0 length
5634         files.
5635         * io_stream_file.cc (io-stream_file::set_mtime): Ditto.
5636         * list.h: New file, template class for a form of list.
5637         * package_db.cc (packagedb::registerpackage): New function.
5638         * package_db.h (packagedb::npackages ()): New method.
5639         * package_meta.cc (packagemeta::add_version): Use list template.
5640         (packagemeta::set_installed): Ditto.
5641         (packagemeta::add_category): New method.
5642         * package_meta.h: Include necessary headers to parse the class.
5643         (CategoryPackage): New class.
5644         (packagemeta): Initialise all members.
5645         (packagemeta::SDesc): New method.
5646         (packagemeta::Categories): New method.
5647         (packagemeta::add_category): Ditto.
5648         (packagemeta::versions): Change to be a list instance.
5649         * package_source.cc (packagesource::set_canonical): New method.
5650         (packagesource::set_cached): New method.
5651         * package_source.h: Include necessary headers to parse the class.
5652         (site): New class.
5653         (packagesource::packagesource): Initialize all members.
5654         (packagesource): Make this class non-abstract.
5655         * package_version.cc (packageversion::packageversion): New method.
5656         * package_version.h (Dependency): New class.
5657         (packageversion::Canonical_vesion): New method.
5658         (packageversion::SDesc): New method.
5659         (packageversion::LDesc): New method.
5660         (packageversion::new_requirement): Ditto.
5661         (packageversion::srcpicked, binpicked): What to install.
5662         (packageversion::src, bin): Installation source data.
5663         * rfc1738.cc: New file. Escapes special characters in URL's.
5664         * rfc1738.h: Ditto.
5665
5666 2001-11-26  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
5667
5668         * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Stop header parsing when
5669         SimpleSocket::gets() returns a zero-length string, so that we
5670         don't end up eating the entire stream thinking it's all header info.
5671
5672 2001-11-23  Robert Collins  <rbtcollins@hotmail.com>
5673
5674         * install.cc (badrename): Remove.
5675         (do_install): Use packagedb flush method to write
5676         /etc/setup/installed.db.
5677         * io_stream.cc (io_stream::move_copy): New method.
5678         (io_stream::move): New method.
5679         * io_stream.h (io_stream): New methods move and move_copy.
5680         * io_stream_cygfile.cc (io_stream_cygfile::move): New method.
5681         * io_stream_cygfile.h (io_stream_cygfile): New method move.
5682         * io_stream_file.cc (io_stream_file::move): New method.
5683         * io_stream_file.h (io_stream_file): New method move.
5684         * package_db.cc (packagedb::flush): New method.
5685         * package_db.h (packagedb): New method flush.
5686
5687 2001-11-23  Robert Collins  <rbtcollins@hotmail.com>
5688
5689         * Makefile.in (OBJS): Add package_version.
5690         * ategory.cc (Category::Category): Update constructors.
5691         * category_list.cc (CategoryList::register_category): Insert correctly.
5692         * choose.cc: Include package_version.h, not package.h.
5693         * cygpackage.cc: Ditto.
5694         (cygpackage::uninstall): New method.
5695         * cygpackage.h (cygpackage): Rename genericpackage to packageversion.
5696         New method uninstall.
5697         * hash.cc (add, has, enumerate): Change prototype to be accurate.
5698         * hash.h (hash): Change prototypes to be accurate.
5699         * ini.h (_Info): New parameterless constructor.
5700         (CategoryPackage): New constructor.
5701         (Package): Ditto.
5702         * install.cc: Don't include unneeded headers.
5703         Include package database headers.
5704         (hash::add_subdirs): Remove.
5705         (uninstall_one): Use packagemeta->uninstall to perform the
5706         uninstallation. Don't uninstall source packages.
5707         (do_install): Just can uninstall_one once as we ignore source packages
5708         now.  Don't copy the installed.old database accross, instead iterate
5709         through the packagedb packages list and write the installed packages
5710         out.
5711         * package_db.cc: Include package_version.h, not package.h.
5712         (packagedb::packagedb): Never let db be undefined.
5713         Record the installation filename, so we can reconstruct installed.db.
5714         (packagedb::addpackage): Insert packages in alpha sorted order.
5715         (packagedb::categories): Initialise correctly.
5716         * package_meta.cc: Include win32 and mount headers as a workaround to
5717         current io_stream limitations. Include a TODO about that.
5718         (standard_dirs): New, from install.cc.
5719         (hash::add_subdirs): New, from install.cc.
5720         (packagemeta::set_installed): Rename genericpackage to packageversion.
5721         (packagemeta::uninstall): New method.
5722         * package_meta.h: Rename genericpackage to packageversion.
5723         (packagemeta): Update constructor.
5724         (add_version, set_installed): Rename genericpackage to packageversion.
5725         (uninstall): New method.
5726         (installed_from): New member.
5727         * package_source.cc: New file.
5728         * package_source.h: New file.
5729         * package_version.cc: New file.
5730         * package_version.h: New file.
5731         * package.cc: Removed.
5732         * package.h: Removed.
5733
5734 2001-11-21  Robert Collins  <rbtcollins@hotmail.com>
5735
5736         * Makefile.in (OBJS): Add category.o and category_list.o.
5737         * category.h: New file.
5738         * category.cc: New file.
5739         * category_list.h: New file.
5740         * category_list.cc: New file.
5741         * choose.cc: Include category headers.
5742         (fill_missing_category): Use package_db to access global categories.
5743         (_view::insert_pkg): Ditto.
5744         (_view::insert_category): Ditto.
5745         (set_view_mode): Ditto.
5746         (getcategorybyname): Remove.
5747         * cygpackage.h: Include category_list.h to parse this correctly.
5748         (cygpackage): New virtual &Categories.
5749         * ini.h (_CategoryPackage): More C to C++ conversion.
5750         (Category): Remove.
5751         (getcategorybyname): Remove.
5752         (register_category): Remove.
5753         * iniparse.y: Include package db and category headers.
5754         (categories): Use package_db to access global categories.
5755         (category): Remove.
5756         (ncategories): Remove.
5757         (register_category): Remove.
5758         * package.h: New virtual &Categories.
5759         * package_db.cc (packagedb::packagedb): Don't read the installed db
5760         twice.
5761         (packagedb::categories): Declare.
5762         * package_db.h (packagedb): New member categories for global categories
5763         list.
5764
5765 2001-11-21  Robert Collins  <rbtcollins@hotmail.com>
5766
5767         * choose.h: Don't include ini.h
5768         * ini.h: Allow pure c++ in the header file.
5769
5770 2001-11-21  Robert Collins  <rbtcollins@hotmail.com>
5771
5772         * install.cc (do_install): Write a version 2 installed.db file.
5773         * package_db.cc (packagedb::packagedb): Read version 1 and 2
5774         installed.db files.
5775
5776 2001-11-21  Robert Collins  <rbtcollins@hotmail.com>
5777
5778         * Makefile.in (OBJS): Add package abstraction objects.
5779         * choose.cc: Include package abstraction headers.
5780         (read_installed_db): Use packagedb class and ignore installed sources.
5781         * cygpackage.cc: New file.
5782         * cygpackage.h: New file.
5783         * filemanip.h (get_file_size): Use unixy types.
5784         * package.h: New file.
5785         * package.cc: New file.
5786         * package_db.cc: New file.
5787         * package_db.h: New file.
5788         * package_meta.cc: New file.
5789         * package_meta.h: New file.
5790
5791 2001-11-21  Robert Collins  <rbtcollins@hotmail.com>
5792
5793         * REAME: Updates to wishlist.
5794
5795 2001-11-16  Robert Collins  <rbtcollins@hotmail.com>
5796
5797         * README: Updated and added my list of wishlist and todo items.
5798
5799 2001-11-14  Robert Collins  <rbtcollins@hotmail.com>
5800
5801         * Makefile.in (OBJS): Include io_stream_memory in setup.exe.
5802         * archive_tar.cc (archive_tar::write): New prototype.
5803         (archive_tar::seek): New method.
5804         * archive.h (archive_tar_file): Update write() and add seek().
5805         (archive_tar): Ditto.
5806         * archive_tar_file.cc (archive_tar_file::write): New prototype.
5807         (archive_tar_file::seek): New method.
5808         * compress_bz.cc (compress_bz::write): New prototype.
5809         (compress_bz::seek): New function.
5810         * compress_bz.h (compress_bz): Update write() and add seek().
5811         * compress_gz.cc (compress_gz::write): New prototype.
5812         (compress_gz::seek): New function.
5813         * compress_gz.h (compress_gz): Update write() and add seek().
5814         * geturl.cc: Include io_stream headers.
5815         (GUBuf): Remove.
5816         (get_url_to_string): Use a io_stream_memory buffer instead of GUBuf.
5817         * io_stream.h (io_stream_seek_t): New enum.
5818         (io_stream): Update write() and add seek().
5819         * io_stream_cygfile.cc (io_stream_cygfile::write): New prototype.
5820         (io_stream_cygfile::seek): New function.
5821         * io_stream_cygfile.h (io_stream_cygfile): Update write() and add
5822         seek().
5823         * io_stream_file.cc (io_stream_file::write): New prototype.
5824         (io_stream_file::seek): New function.
5825         * io_stream_file.h (io_stream_file): Update write() and add seek().
5826
5827 2001-11-13  Brian Keener  <bkeener@thesoftwaresource.com>
5828
5829         * localdir.cc: Add headers unistd.h and port.h.
5830         (save_local_dir): Expand search logic to include local directory for
5831         location of file last-cache.
5832         (dialog_cmd): Skip IDD_ROOT when downloading and use Back button.
5833         (do_local_dir): Expand search logic to include local directory for file
5834         last-cache.
5835         * res.rc (IDD_CHOOSE_DIALOG): Add hotkey to View button.
5836         * Source.cc (dialog_cmd): Skip IDD_ROOT if select Download from
5837         Internet.
5838         (do_source): Default to Install from Internet on first entry or
5839         previous selection if backing up from IDD_ROOT or IDD_LOCAL_DIR.
5840
5841 2001-11-13  Robert Collins  <rbtcollins@hotmail.com>
5842
5843         * choose.cc (find_tar_ext): Only match at the end of the string.
5844         (getpkgbyname): Prevent NULL pointer dereference.
5845
5846 2001-11-13  Robert Collins  <rbtcollins@hotmail.com>
5847
5848         * Makefile.in (CFLAGS): Add warnings and -Werr.
5849         (WARNONLY_FLAGS): For sources that produce (harmless) errors no matter
5850         what.
5851         (OBJS): Add io_stream class' objects.
5852         (autoload.o): Use WARNONLY_FLAGS.
5853         (inilex.o): Ditto.
5854         (iniparse.o): Ditto.
5855         * archive.cc: New file.
5856         * archive.h: New file.
5857         * archive_tar.cc: New file.
5858         * archive_tar.h: New file.
5859         * archive_tar_file.cc: New file.
5860         * autoload.c: Fix compiler warnings (unused, deprecated conversion).
5861         * choose.cc: Use io_stream.h, not mount.h.
5862         Run indent.
5863         (find_tar_ext): Rewritten to use strstr, and to accept .tar as an
5864         extension.
5865         (read_installed_db): Use io_streams.
5866         * choose.h: Run indent.
5867         * compress.cc: New file.
5868         * compress.h: New file.
5869         * compress_bz.cc: New file.
5870         * compress_bz.h: New file.
5871         * compress_gz.cc: New file.
5872         * compress_gz.h: New file.
5873         * concat.cc: Run indent.
5874         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5875         * concat.h: Run indent.
5876         * desktop.cc: Run indent.
5877         Include mklink2.h rather than redefining by hand.
5878         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5879         (etc_profile): Fix compiler warning (deprecated conversion).
5880         (make_link): Fix compiler warning (deprecated conversion).
5881         Tidy up use of args variable - consolidate into argbuf.
5882         (start_menu): Fix compiler warning (deprecated conversion).
5883         (desktop_icon): Fix compiler warning (deprecated conversion).
5884         (make_etc_profile): Fix compiler warning (deprecated conversion).
5885         (uexists): Fix compiler warning (deprecated conversion).
5886         (check_desktop): Fix compiler warning (deprecated conversion).
5887         (check_startmenu): Fix compiler warning (deprecated conversion).
5888         * dialog.cc: Run indent.
5889         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5890         (fatal): Fix compiler warning (deprecated conversion).
5891         * dialog.h: Run indent.
5892         * diskfull.cc: Run indent.
5893         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5894         * download.cc: Run indent.
5895         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5896         (download_one): Fix compiler warning (signed vs unsigned comparison).
5897         * filemanip.h: Run indent.
5898         * find.cc: Run indent.
5899         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5900         (find): Fix compiler warning (deprecated conversion).
5901         * find.h: Run indent.
5902         * fromcwd.cc: Run indent.
5903         * geturl.cc: Run indent.
5904         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5905         (dialog_cmd): Return a value.
5906         (dialog_proc): Remove unused variables.
5907         Return a value.
5908         (get_url_to_file): Fix compiler warning (deprecated conversion).
5909         * geturl.h: Run indent.
5910         * hash.cc: Run indent.
5911         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5912         * hash.h: Run indent.
5913         * ini.cc: Run indent.
5914         Use io_streams.
5915         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5916         (do_ini): Use io_streams for local io.
5917         * ini.h: Run indent.
5918         * inilex.l (ignore_line): Fix compiler warning (is not a prototype).
5919         Fix compiler warning (brackets for truth assignment).
5920         * install.cc: Run indent.
5921         Fix compiler warning (/* in comment).
5922         Use io_streams.
5923         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5924         (dialog_cmd): Return a value.
5925         (dialog_proc): Return a value.
5926         (start_tics): Deleted - was unused.
5927         (badrename): Fix compiler warnings (unused, deprecated conversion).
5928         (standard_dirs): Fix compiler warning (deprecated conversion).
5929         (exists): Remove.
5930         (uninstall_one): Convert to io_streams.
5931         (install_one): Convert to io_streams.
5932         (do_install): Convert to io_streans.
5933         Fix compiler warning (deprecated conversion).
5934         * io_stream.cc: New file.
5935         * io_stream.h: New file.
5936         * io_stream_cygfile.cc: New file.
5937         * io_stream_cygfile.h: New file.
5938         * io_stream_file.cc: New file.
5939         * io_stream_file.h: New file.
5940         * localdir.cc: Run indent.
5941         Use io_streams.
5942         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5943         (get_root_dir_now): Remove.
5944         (save_local_dir): Convert to io_streams.
5945         (dialog_cmd): Return a value.
5946         (do_local_dir): Convert to io_streams.
5947         (log.cc): Run indent.
5948         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5949         (log): Fix compiler warning (deprecated conversion).
5950         (log_save): Fix compiler warning (deprecated conversion).
5951         * log.h: Run indent.
5952         (log): Fix compiler warning (deprecated conversion).
5953         (log_save): Fix compiler warning (deprecated conversion).
5954         * main.cc: Run indent.
5955         Don't include "netio.h".
5956         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5957         (netio_test): Remove.
5958         (sid_auth): Fix compiler warning (partially bracketed initialiser).
5959         (WinMain): Return a value.
5960         * mkdir.cc: Run indent.
5961         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5962         * mklink2.c: Run indent.
5963         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5964         (mkcygsymlink): New function.
5965         * mklink2.h: New file.
5966         * mount.cc: Run indent.
5967         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5968         (create_mount): Remove unused variables.
5969         (cygpath): Fix compiler warning (signed vs unsigned comparison).
5970         * mount.h: Run indent.
5971         * msg.cc: Run indent.
5972         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5973         (msg): Fix compiler warning (deprecated conversion).
5974         (mbox): Fix compiler warning (deprecated conversion).
5975         * msg.h: Run indent.
5976         (msg): Fix compiler warning (deprecated conversion).
5977         * net.cc: Run indent.
5978         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5979         (dialog_cmd): Return a value.
5980         * netio.cc: Run indent.
5981         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5982         (auth_cmd): Return a value.
5983         * netio.h: Run indent.
5984         * nio-file.cc: Run indent.
5985         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5986         (NetIO_File::NetIO_File): Fix compiler warning (deprecated conversion).
5987         * nio-file.h: Run indent.
5988         * nio-ftp.cc: Run indent.
5989         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5990         * nio-ftp.h: Run indent.
5991         * nio-http.cc: Run indent.
5992         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5993         * nio-http.h: Run indent.
5994         * nio-ie5.cc: Run indent.
5995         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5996         * nio-ie5.h: Run indent.
5997         * other.cc: Run indent.
5998         (cvsid): Fix compiler warnings (unused, deprecated conversion).
5999         (dialog_cmd): Return a value.
6000         * port.h: Run indent.
6001         * postinstall.cc: Run indent.
6002         (cvsid): Fix compiler warnings (unused, deprecated conversion).
6003         (cmd): Fix compiler warning (deprecated conversion).
6004         (eun): Fix compiler warning (deprecated conversion).
6005         * root.cc: Run indent.
6006         (cvsid): Fix compiler warnings (unused, deprecated conversion).
6007         * simpsock.cc: Run indent.
6008         (cvsid): Fix compiler warnings (unused, deprecated conversion).
6009         * simpsock.h: Run indent.
6010         * site.cc: Run indent.
6011         Use io_streams.
6012         (cvsid): Fix compiler warnings (unused, deprecated conversion).
6013         (get_root_dir_now): Remove.
6014         (save_site_url): Convert to io_streams.
6015         (dialog_cmd): Return 0.
6016         (get_initial_list_idx): Convert to io_streans.
6017         * source.cc: Run indent.
6018         (cvsid): Fix compiler warnings (unused, deprecated conversion).
6019         (check_if_enable_next): Remove.
6020         (load_dialog): Remove unused variables.
6021         (save_dialog): Ditto.
6022         (dialog_cmd): Return a value.
6023         * splash.cc: Return a value.
6024         (cvsid): Fix compiler warnings (unused, deprecated conversion).
6025         (dialog_cmd): Return a value.
6026         * state.cc: Run indent.
6027         (cvsid): Fix compiler warnings (unused, deprecated conversion).
6028         * state.h: Run indent.
6029         * tar.h: Remove.
6030         * tar.cc: Remove.
6031
6032 2001-11-12  Christopher Faylor  <cgf@redhat.com>
6033
6034         * desktop.cc (start_menu): Change start menu name to "Cygwin".
6035         (check_startmenu): Ditto.
6036
6037 2001-11-11  Christopher Faylor  <cgf@redhat.com>
6038
6039         * choose.cc (parse_filename): Finish reorganization by correctly
6040         decrementing p in memmove.
6041
6042 2001-11-11  Christopher Faylor  <cgf@redhat.com>
6043
6044         * choose.cc (parse_filename): Reorganize code to work around gcc
6045         optimization problem.
6046
6047 2001-11-09  Gareth Pearce  <tilps@hotmail.com>
6048
6049         * choose.cc (set_action): Allow skip as an option for installed
6050         packages that have version number not listed in setup.ini.
6051
6052 2001-11-10  Robert Collins  <rbtcollins@hotmail.com>
6053
6054         * choose.cc (set_cation): Backout last change.
6055         (choose_caption): Ditto.
6056
6057 2001-11-10  Robert Collins  <rbtcollins@hotmail.com>
6058
6059         * ini.h (actions): Remove - transferred to choose.h.
6060         (views): Ditto.
6061         * choose.h: Protect class's from "C" compilers.
6062          (actions): New enum, from ini.h. This may not be the 'right' place
6063         but that place doesn't exist yet.
6064         (_views): New enum, from ini.h.
6065         * choose.cc (set_action): Handle installed packages with a version not
6066         in setup.ini.
6067         (choose_caption): Ditto.
6068         * iniparse.y: Rearrange header order to handle new ini.h.
6069
6070 2001-11-10  Robert Collins  <rbtcollins@hotmail.com>
6071
6072         * ini.h (_Info): Fix compiler warnings (signed vs unsigned comparison).
6073         (registry_category): Fix compiler warning (deprecated conversion).
6074         * iniparse.y (registry_category): Ditto.
6075         * choose.cc (cvsid): Fix compiler warnings (unused, deprecated
6076         conversion).
6077         (add_requried): Remove unused variable.
6078         (choose_caption): Handle all enumeration values via a default.
6079         (paint): Fix compiler warnings (unused, deprecated conversion).
6080         (scroll_common): Fix compiler warnings (unused, signed vs unsigned
6081         comparison).
6082         (list_clicK): Fix compiler warnings (signed vs unsigned comparison).
6083         (note_width): Fix compiler warnings (deprecated conversion).
6084         (keep_or_skip): Fix compiler warnings (unused).
6085         (_view::mode_caption): Fix compiler warnings (deprecated conversion).
6086         (set_view_mode): Fix compiler warnings (unused).
6087         (create_listview): Fix compiler warnings (unused, incorrect format,
6088         reaches end of function).
6089         (dialog_proc): Fix compiler warnings (unused).
6090         (read_installed_db): Fix compiler warnings (unused, deprecated
6091         conversion).
6092         * choose.h (_header): Fix compiler warnings (deprecated conversion).
6093         (_view): Ditto.
6094
6095 2001-11-08  Pavel Tsekov  <ptsekov@syntrex.com>
6096
6097         * simpsock.h (SimpleSocket::invalidate): Declare new method.
6098         * simpsock.cc (SimpleSocket::invalidate): Implement new method.
6099         (SimpleSocket::SimpleSocket): Initialize buf to zero. Do not allocate
6100         memory for buf in the constructor.
6101         (SimpleSocket::~SimpleSocket): Use SimpleSocket::invalidate().
6102         (SimpleSocket::printf): Use SimpleSocket::write() instead of send().
6103         (SimpleSocket::write): Check object consistency - return -1 on error.
6104         invalidate() the object on socket write error.
6105         (SimpleSocket::fill): Check object consistency - return -1 on error.
6106         invalidate() the object if socket read error is encountered and there
6107         is no more data available in the internal read buffer.
6108         Allocate memory for the internal read buffer.
6109         (SimpleSocket::gets): Return zero (NULL pointer) if error is encountered
6110         during fill() and no more data is available in the internal read buffer.
6111         (SimpleSocket::read): Check object consistency - return -1 on error.
6112         invalidate() the object if socket read error is encountered.
6113         * nio-ftp.cc (NetIO_FTP:NetIO_FTP): Allow 125 as valid response code to
6114         the RETR command (fix for MS IIS ftp server 5 - possibly others too).
6115         (NetIO_FTP::ok): Check if the SimpleSocket object is ok().
6116         (NetIO_FTP::read): Use NetIO_FTP::ok().
6117         * nio-http.cc: Check for valid return value of SimpleSocket::gets().
6118         (NetIO_HTTP::ok): Check if the SimpleSocket object is ok().
6119
6120 2001-11-09  Robert Collins  <rbtcollins@hotmail.com>
6121
6122         * simpsock.cc (cvsid): Avoid compiler warnings (not used, deprecated
6123         conversion).
6124         (SimpleSocket::SimpleSocket): Avoid compiler warnings (deprecated
6125         conversion).
6126         (SimpleSocket::printf): Ditto.
6127         (SimpleSocket::write): Ditto.
6128         * simpsock.h (SimpleSocket): Avoid compiler warnings for constructor,
6129         printf and write.
6130         * nio-ftp.cc (cvsid): Avoid compiler warnings (not used, deprecated
6131         conversion).
6132         (NetIO_FTP::NetIO_FTP): Remove unused variable done.
6133         * nio-http.cc (cvsid): Avoid compiler warnings (not used, deprecated
6134         conversion).
6135
6136 2001-11-07  Charles Wilson  <cwilson@ece.gatech.edu>
6137
6138         * geturl.cc (get_url_to_string): clean up memory leak
6139         (get_url_to_file): ditto
6140
6141 2001-11-06  Robert Collins  <rbtcollins@hotmail.com>
6142
6143         * localdir.cc (dialog_cmd): Go back to IDD_ROOT in every case.
6144         * source.cc (dialog_cmd): Go forward to IDD_ROOT in every case.
6145
6146 2001-11-06  Pavel Tsekov  <ptsekov@syntrex.com>
6147
6148         * fromcwd.cc (found_file): Free() memory containing the version and
6149         filepath information for a given package, before replacing the pointers
6150         which reference this memory.
6151
6152 2001-11-06  Robert Collins  <rbtcollins@hotmail.com>
6153
6154         * fromcwd: Fix compiler warnings for cvsid.
6155         (canonicalize_version): Fix compilter warnings.
6156         (do_fromcwd): Ditto.
6157         * version.h: Fix compiler warnings for canonicalize_version.
6158
6159 2001-11-03  Robert Collins  <rbtcollins@hotmail.com>
6160
6161         * res.rc (IDD_CHOOSE): Move the view caption to the right hand side.
6162
6163 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6164
6165         * res.rc (IDD_CHOOSE): Tweak for use on a 640x480 screen.
6166
6167 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6168
6169         * choose.cc (set_action): Correctly allow skip for any uninstalled
6170         package.
6171
6172 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6173
6174         * choose.cc (default_trust): Change the "Required" forced install
6175         category to "Base".
6176
6177 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6178
6179         * choose.cc: Ran indent.
6180         (set_action): When the requested trust level is missing and the level
6181         was not user requested, set the action to ACTION_SAME_CURR.
6182
6183 2001-11-01  Christopher Faylor  <cgf@redhat.com>
6184
6185         * Makefile.in (mingw_getopt.o): Fix typo in non-verbose compilation.
6186
6187 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6188
6189         * choose.cc (_view::init_headers): Resync with the paint logic.
6190
6191 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6192
6193         * choose.cc (add_required): Allow SKIP and SRC_ONLY for currently
6194         installed packages.
6195
6196 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6197
6198         * choose.cc (default_trust): Autoset currently installed packages per
6199         the user's selection of prev/curr/exp.
6200
6201 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6202
6203         * splash.cc (dialog_proc): Return TRUE as specified in the WIN32 API.
6204
6205 2001-11-02  Pavel Tsekov  <ptsekov@syntrex.com>
6206
6207         * geturl.cc (is_showing): Remove.
6208         (is_local_install): New static variable. Controls whether the
6209         progress dialog and the supporting thread will be created.
6210         (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the WIN32
6211         API.
6212         (init_dialog): Remove usage of SetForegroundWindow and is_showing.
6213         This prevents the progress dialog to gain control over the
6214         application and fixes the "setup.exe going to background" problem.
6215         (progress): Use is_local_install.
6216         (get_url_to_string): Set is_local_install.
6217         (dismiss_url_status_dialog): Use is_local_install.
6218         * install.cc (dialog_proc): Return TRUE as specified in WIN32 API.
6219         (init_dialog): Remove usage of SetForegroundWindow.
6220         This prevents the progress dialog to gain control over the
6221         application and fixes the "setup.exe going to background" problem.
6222
6223 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6224
6225         * choose.cc (list_click): Change r to row for clarity.
6226         When we shrink the list below 1 page, scroll to the top of the list.
6227         (_view::click): Return the actual change for contractions.
6228         (dialog_proc): Return TRUE to WM_INITDIALOG as specified by the Win32
6229         API.
6230
6231 2001-11-02  Robert Collins  <rbtcollins@hotmail.com>
6232
6233         * choose.cc (dialog_cmd): Swap cygwin root selection and local dir
6234         selection order.
6235         * localdir.cc: Ran indent.
6236         (get_root_dir_now): New function.
6237         (save_local_dir): New function.
6238         (dialog_cmd): Use it and swap cygwin root selection and local dir
6239         selection order.
6240         (do_local_dir): If there is a saved local dir, read it in.
6241         * net.cc (dialog_cmd): Swap cygwin root selection and local dir
6242         selection order.
6243         * root.cc (dialog_cmd): Ditto.
6244         * source.cc (dialog_cmd): Ditto.
6245
6246 2001-11-01  Robert Collins  <rbtcollins@hotmail.com>
6247
6248         * choose.cc(list_vscroll): Return 0 as required by win32.
6249         (list_hscroll): Ditto.
6250         (list_click): Ditto.
6251
6252 2001-11-01  Robert Collins  <rbtcollins@hotmail.com>
6253
6254         * argv.cc: Remove.
6255         * argv.h: Remove.
6256         * main.cc(WinMain): Use __argv to retrieve command line parameters.
6257         * Makefile,in: Remove argv.o.
6258
6259 2001-11-01  Matt Hargett  <matt@use.net>
6260
6261         * geturl.cc (progress): Change int to unsigned int to eliminate
6262         lint warnings.
6263         * (get_url_to_string): Check for NULL pointer.
6264         * mount.cc (find2): Use free instead of delete for malloc'd
6265         memory.
6266         * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.
6267
6268 2001-10-31  Robert Collins  <rbtcollins@hotmail.com>
6269
6270         * choose.cc(_view::insert_under): Handle linen > nlines and lines[linen]
6271         with neither a package nor a category. The lines[linen] bug was reported
6272         by Matt (matt@usa.net).
6273         (read_installed_db): Bugfix for testing whether a package has a source
6274         tarball.  Reported by Matt (matt@usa.net).
6275         * geturl.cc(dialog): Rename gw_dialog to local_gw_dialog to avoid
6276         programmer confusion and lint errors. Reported by Matt (matt@usa.net).
6277
6278 2001-10-31  Robert Collins  <rbtcollins@hotmail.com>
6279
6280         * argv.cc: New file, converts arguments for -mwindows
6281         programs. (Simplified derivation from dcrt0.cc.)
6282         * argv.h: New file.
6283         * Makefile,in: Add argv.o and mingw_getopt.o to setup.exe object list.
6284         Add mingw_getopt.o build rule.
6285         * main.cc(WinMain): Initialise argv and argc for use by getopt.
6286
6287 2001-10-27  Christopher Faylor  <cgf@redhat.com>
6288
6289         * res.rc: Rearrange info on top line slightly.
6290
6291 2001-10-27  Christopher Faylor  <cgf@redhat.com>
6292
6293         * desktop.cc (make_passwd_group): Move file creation earlier in the
6294         process to ensure that passwd-grp.bat reflects desired operation.
6295
6296 2001-27-10  Trevor Forbes  <t4bs@hotmail.com>
6297
6298         * postinstall.cc (each): Remove "*.done" file else rename will fail.
6299
6300 2001-10-16  Christopher Faylor  <cgf@redhat.com>
6301
6302         * res.rc: Oops.  Take 640x480 screen size into account.
6303
6304 2001-10-16  Christopher Faylor  <cgf@redhat.com>
6305
6306         * res.rc: Enlarge chooser screen.
6307
6308 2001-10-12  Christopher Faylor  <cgf@redhat.com>
6309
6310         * Makefile.in: Accomodate changes to w32api_include macro.
6311
6312 2001-10-12  Christopher Faylor  <cgf@redhat.com>
6313
6314         * Makefile.in: Use correct flags for windres.
6315
6316 2001-10-12  Christopher Faylor  <cgf@redhat.com>
6317
6318         * Makefile.in (CFLAGS): Remove -nostdinc from CFLAGS.
6319
6320 2001-10-12  Christopher Faylor  <cgf@redhat.com>
6321
6322         * choose.cc (pick_line::paint): Reorganize after botched patch.
6323
6324 2001-10-12  Christopher Faylor  <cgf@redhat.com>
6325
6326         * choose.cc (pick_line::paint): Add missing declaration.
6327
6328 2001-10-10  Ralf Habacker <Ralf.Habacker@freenet.de>
6329
6330         * choose.cc (pick_line::paint): Add package name to sdesc for display.
6331
6332 Wed Sep 26 21:39:00  Robert Collins rbtcollins@hotmail.com
6333
6334         * choose.cc (_view::insert_pkg): Correctly exit loop.
6335         * iniparse.y (register_category): Always insert new categories.
6336
6337 Fri Sep 21 13:56:32 2001  Christopher Faylor <cgf@cygnus.com>
6338
6339         * inilex.l (yylex): For comments, eat all characters up to, but not
6340         including newline.
6341
6342 Sun Aug 26 12:50:01 2001  John Marshall  <jmarshall@acm.org>
6343
6344         * fromcwd.cc (found_file): Use correct package name when adding an
6345         unknown package rather than random stack garbage.
6346
6347 Sun Aug 12 14:25:21 2001  Christopher Faylor <cgf@cygnus.com>
6348
6349         * desktop.cc (make_passwd_group): .bat files need \r\n endings.
6350
6351 Wed Aug  8 13:53:47 2001  Christopher Faylor <cgf@cygnus.com>
6352
6353         * desktop.cc (etc_profile): Leave environment variables untouched.
6354
6355 2001-08-07  Corinna Vinschen  <corinna@vinschen.de>
6356
6357         * autoload.c: Add dynamic load statements for NT/W2K
6358         advapi32 functions not available in 9x/ME.
6359         * main.cc (set_default_dacl): New function.
6360         (WinMain): Call `set_default_dacl' if running on NT/W2K.
6361
6362 Sat Aug  4 21:35:53 2001  Christopher Faylor <cgf@cygnus.com>
6363
6364         * ini.h (_CategoryPackage): Change pkg field to pkgname for
6365         consistency.
6366         * choose.cc: Use pkgname field when referencing _CategoryPackage
6367         throughout.
6368         (fill_missing_category): Don't add excluded packages.
6369         (default_trust): Ditto.
6370         (_view::insert_pkg): Ditto.
6371         * iniparse.y (register_category): Use consistent variable name.
6372
6373 2001-07-09  Egor Duda <deo@logos-m.ru>
6374
6375         * choose.cc: Use system foreground color for text output.
6376
6377 Sat Jul  7 00:40:28 2001  Christopher Faylor <cgf@cygnus.com>
6378
6379         * choose.cc (set_action): Use default trust for determining reinstall
6380         and source only.
6381         (default_trust): Set default trust.
6382         (pick_line::paint): Allow source selection when reinstalling or
6383         retrieving.
6384
6385 Fri Jul  6 18:08:49 2001  Christopher Faylor <cgf@cygnus.com>
6386
6387         * choose.cc (isinstalled): Modify to properly accomodate special case
6388         of "download only".
6389         (set_action): Check downloaded components, not installed components if
6390         "download only".
6391         (set_existence): Always include full list of files when "download
6392         only".
6393
6394 Fri Jul  6 00:37:05 2001  Christopher Faylor <cgf@cygnus.com>
6395
6396         * choose.cc (pick_line::paint): Properly display "na" field when no
6397         source exists.
6398
6399 Thu Jul  5 00:34:23 2001  Christopher Faylor <cgf@cygnus.com>
6400
6401         * choose.cc (scan2): Ensure that older versions do not show up in
6402         "Test" slot.
6403
6404 Mon Jul  2 15:47:59 2001  Christopher Faylor <cgf@cygnus.com>
6405
6406         * choose.cc (set_action): Allow "Skip" action if trust != installed.
6407         * res.rc: Fix copyright.
6408
6409 Sat Jun 30 14:05:21  2001  Michael A Chase <mchase@ix.netcom.com>
6410
6411         * res.rc (IDD_LOCAL_DIR): Change caption to match the other dialog
6412         boxes.
6413         (IDD_CHOOSE): Adjust horizontal size so package names are visible.
6414
6415         * choose.cc: Restore some more changes from 2001-06-25, throughout.
6416         (paint): Wrap some excessively long lines.
6417         (pick_line::paint): Ditto.  Move the arrow in the "Current" column
6418         right to where it belongs.  Move the source checkbox slightly to the
6419         right.
6420         (do_choose): List categories and required packages in setup.log.full.
6421
6422 Sat Jun 30 23:04:59 2001  Christopher Faylor <cgf@cygnus.com>
6423
6424         * choose.cc (scan2): Restore source scanning eliminated by previous
6425         checkin.
6426
6427 Sat Jun 30 15:18:33 2001  Christopher Faylor <cgf@cygnus.com>
6428
6429         * ini.h (struct _Info): Add "derived" element.
6430         * choose.cc (scan2): Try to place unknown tar files into proper slot
6431         when package exists in setup.ini but tar file does not.
6432
6433 Sat Jun 30 13:39:00 2001 Robert Collins <rbtcollins@hotmail.com>
6434
6435         * choose.cc (create_listview): Call set_view_mode with VIEW_CATEGORY.
6436         (do_choose): Log the first category name.
6437
6438 Fri Jun 29 23:07:44 2001  Christopher Faylor <cgf@cygnus.com>
6439
6440         *ini.h: Reapply 2001-06-25 changes.
6441         * choose.cc (add_required): Ditto.  Default to "Keep" state if
6442         UNINSTALL and product is installed.  Default to curr state if SKIP,
6443         etc.
6444         (keep_or_skip): New function.  Returns skip or keep state depending on
6445         installed state of package.
6446         (default_trust): Use keep_or_skip to set state.
6447         (_view::insert_pkg): Use calloc to allocate lines.
6448         (set_view_mode): Adapt 2001-06-25 change to set_full_list here.
6449
6450 Sat Jun 30 11:01:00 2001 Robert Collins <rbtcollins@hotmail.com>
6451
6452         * choose.cc: Remove globals full_list, headers, package_indexes and
6453         nindexes.
6454         Add globals cat_headers, pkg_headers and chooser.
6455         (add_required): New function.
6456         (paint): Use the chooser for header details.
6457         Call into the chooser to paint each line.
6458         (list_click): Use new global variables.
6459         Call into the chooser to handle the click.
6460         Repaint the entire view if packages have been added or removed.
6461         (note_width): Get passed a headers struct rather than using a global
6462         variable.
6463         (fill_missing_category): New function.
6464         (default_trust): Skip non-"Required" or "Misc" packages.
6465         (pick_line::set_line (Package *)): New function.
6466         (pick_line::set_line (Category *)): New function.
6467         (pick_line::paint): New function.
6468         (pick_line::click): New function.
6469         (_view::_view): New function.
6470         (_view::set_view_mode): New function.
6471         (_view::mode_caption): New function.
6472         (_view::set_headers): New function.
6473         (_view::init_header): New function.
6474         (_view::insert_pkg): New function.
6475         (_view::insert_category): New function.
6476         (_view::insert_at): New function.
6477         (_view::insert_under): New function.
6478         (_view::clear_view): New function.
6479         (viewsplusplus): New function.
6480         (_view::client): New function.
6481         (set_view_mode): Use new chooser functionality.
6482         (set_full_list): Use new global variables.
6483         (create_listview): Instantiate chooser.
6484         Remove all hardcoded headers[] code.
6485         (dialog_cmd): On trust changes, check dependencies.
6486         (getcategorybyname): New function.
6487         (getpackagecategorybyname): New function.
6488         (scan2): Use case-insensitive package comparison.
6489         (do_choose): Use fill_missing_category ().
6490         Show some category data.
6491         * ini.h: Protect against multiple inclusion.
6492         (views) New enum.
6493         (_CategoryPackage): New struct.
6494         (_Category): New struct.
6495         (_Package): Change category to Category * from char *.
6496         (extern Category category): New global variable.
6497         (extern in ncategories): Ditto.
6498         (getcategorybyname): New prototype.
6499         (catpackagecategorybyname): New prototype.
6500         (register_category): New prototype.
6501         (add_category): New prototype.
6502         * iniparse.y: Parse multiple categories per package.
6503         (category): New global variable.
6504         (ncategories): New global variable.
6505         (new_package): Compare package against NULL, not 0.
6506         (new_requirement): Source formatting fix.
6507         (register_category): New function.
6508         (add_category): New function.
6509         * res.rc: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
6510         IDC_CHOOSE_VIEWCAPTION: New control.
6511         * resource.h: Change IDC_CHOOSE_FULLPART to IDC_CHOOSE_VIEW.
6512         IDC_CHOOSE_VIEWCAPTION: New control.
6513         Increment _APS_NEXT_CONTROL_VALUE.
6514
6515 Mon Jun 25 00:56:37 2001  Michael A Chase <mchase@ix.netcom.com>
6516
6517         * choose.cc (paint): Wrap excessively long lines.
6518         (list_click): Ditto.
6519         (create_listview): Ditto.
6520         (do_choose): Ditto.  Replace TABs and remove CRs in lines written to
6521         setup.log.full.  Allow "Yes" for source exists in setup.log.full when
6522         installing from local directories.
6523
6524 Mon Jun 25 00:56:37 2001  Christopher Faylor <cgf@cygnus.com>
6525
6526         * choose.cc (set_action): Only clear srcpicked when moving to next
6527         state.  Allow source installation if it exists in the current "trust"
6528         state.  Don't move to skip state when package is installed.
6529         (list_click): Don't allow source clicking when no source is available.
6530         (set_full_list): Display package when not is_full_action.
6531         * ini.h (is_full_action): Define.
6532
6533 Sun Jun 17 12:06:14 2001  Christopher Faylor <cgf@cygnus.com>
6534
6535         * install.cc (check_for_old_cygwin): New function.  First stab at
6536         checking for old cygwin versions.
6537         (do_install): Call check_for_old_cygwin if there were no errors during
6538         the install.
6539
6540 Sat Jun 16 11:33:51  2001  Michael A Chase <mchase@ix.netcom.com>
6541
6542         * choose.cc (_Info::_Info): Test _source paramenter for non-NULL rather
6543         than zeroed "source" element.
6544
6545 Fri Jun 15 20:54:43 2001  Christopher Faylor <cgf@cygnus.com>
6546
6547         * choose.cc (scan2): Insert unknown tar archives, found on disk, into
6548         the highest available "hole" in the trust array.
6549
6550 Fri Jun 15 00:20:48 2001  Christopher Faylor <cgf@cygnus.com>
6551
6552         * choose.cc (set_existence): Use pointer method for indexing in trust
6553         array.
6554         (create_listview): Ditto.
6555         (scan2): Ditto.  Also, use consistent variable name for indexing into
6556         trust array.
6557         * ini.h (Package): Reorganize info array for easier scanning.
6558
6559 Fri Jun 15 00:01:51 2001  Christopher Faylor <cgf@cygnus.com>
6560
6561         * choose.cc (isinstalled): Eliminate special download only test.
6562         (set_action): Don't move to next state if in ACTION_SAME range and not
6563         incrementing.
6564         (choose_caption): Display "Retrieve" rather than "Reinstall" when just
6565         downloading.
6566         (do_choose): Sort packages after all packages have been read.
6567         Accomodate the fact that first element in trust array is empty so that
6568         log files don't report the wrong trust value.
6569         * iniparse.y (new_package): Malloc space for package name or suffer
6570         memory corruption.
6571
6572 Thu Jun 14 22:43:59 2001   Robert Collins <rbtcollins@hotmail.com>
6573
6574         * ini.h (Dependency): New structure.  Declare new function.
6575         * inilex.l (yylex): Detect new setup.ini options - category and
6576         requires.
6577         * iniparse.y: Declare new setup.ini token values.
6578         (yyparse): Parse new token values.
6579         (new_requirement): New function.
6580
6581 Thu Jun 14 22:43:26 2001  Christopher Faylor <cgf@cygnus.com>
6582
6583         * choose.cc (read_installed_db): Eliminate obsolete code.
6584
6585 Thu Jun 14 22:11:53 2001  Christopher Faylor <cgf@cygnus.com>
6586
6587         * choose.cc (set_action): Set trust on "redo".
6588         (_Info::_Info): New constructor.
6589         (read_installed_db): Use new constructor.  Use trusts type for
6590         iterator.
6591         * ini.h (struct _Info): Label struct, add constructor.
6592         (Package): Make installed_ix a type 'trusts.'
6593         * install.cc (uninstall_one): Unset any installed info for current
6594         package.
6595         (install_one): Allocate new Info struct for installed reflecting new
6596         installed info.
6597         (do_install): Don't output line to installed.db if package is being
6598         uninstalled.
6599
6600 Thu Jun 14 20:33:01 2001  Robert Collins <rbtcollins@hotmail.com>
6601
6602         * choose.cc (getpkgbyname): Use consistent method for scanning package
6603         array.
6604
6605 Wed Jun 13 23:33:08 2001  Christopher Faylor <cgf@cygnus.com>
6606
6607         * choose.cc:  Add some comments.
6608         (getpkgbyname): Use strcasecmp for comparisons.
6609
6610 Wed Jun 13 16:07:00 2001  Christopher Faylor <cgf@cygnus.com>
6611
6612         * install.cc (do_install): Avoid checking for download action if
6613         package wasn't currently retrieved.
6614
6615 Wed Jun 13 11:27:22 2001  Christopher Faylor <cgf@cygnus.com>
6616
6617         * choose.cc: Eliminate extra array throughout.  Use element in package
6618         structure instead.  Use pointers rather than array indexes where
6619         appropriate.
6620         (set_action): New function to set next action based on current.
6621         (choose_caption): New function.  Returns display caption.
6622         (check_existence): Change arguments.  Use pointer to 'info' structure.
6623         (set_existence): Use pointer rather than array index.
6624         (default_trust): Use trusts enum for second argument.
6625         (set_full_list): Honor exclude element in package structure.
6626         (build_labels): Eliminate.
6627         (base): Make global.  Use const char * argument.
6628         (get_package_version): Eliminate.
6629         (getpkgbyname): New function.
6630         (read_installed_db): Use parse_filename to get version info.
6631         * desktop.cc (make_passwd_group): Use getpkgbyname function.
6632         * download.cc (get_file_size): const argument.
6633         (do_download): Use is_download_action to determine when something
6634         should be downloaded.
6635         * filemanip.h: Add some functions.
6636         * ini.cc (do_ini): Use NULL rather than 0 for pointer assignment.
6637         * ini.h: Use enums for actions and trusts.
6638         (is_download_action): New macro.
6639         (is_upgrade_action): Ditto.
6640         (is_uninstall_action): Ditto.
6641         (struct Package): Add new fields.
6642         * inilex.l (yylex): Detect new setup.ini options.
6643         * iniparse.y: Declare new tokens.
6644         (yyparse): Detect exclude keyword.  Fill out version field even if
6645         version == 0.
6646         (new_package): Use greater granularity when allocating package array to
6647         avoid repeated calls to realloc.
6648         * install.cc (exists): const argument.
6649         (uninstall_one): Take pkg argument.
6650         (install_one): Ditto.  Eliminate unneeded arguments which can be
6651         derived from package info.
6652         (do_install): Iterate over package array using a pointer.  Use
6653         is_download_action to control when package should be downloaded.
6654         * tar.cc (tar_open): const argument.
6655         * tar.h: Refloect const argument.
6656
6657 2001-05-31  Michael Chase mchase@ix.netcom.com
6658
6659         * main.cc (WinMain): Add setup version to starting setup.log entry
6660
6661 Tue May 29 21:37:58 2001  Yukihiko Sohda <sohda@is.titech.ac.jp>
6662
6663         * inilex.l: Add + to list of valid string characters.
6664
6665 Mon May 28 20:54:50 2001  Christopher Faylor <cgf@cygnus.com>
6666
6667         * Makefile.in: Remove more stuff in the clean target.
6668
6669 Mon May 28 18:24:59 2001  Christopher Faylor <cgf@cygnus.com>
6670
6671         * Makefile.in: Correctly generate iniparse.h.
6672
6673 Tue Mar  6 19:14:00 2001  Corinna Vinschen <corinna@vinschen.de>
6674
6675         * geturl.cc (get_url_to_file): Add parameter `allow_ftp_auth'.
6676         * geturl.h: Change declaration of `get_url_to_file' accordingly.
6677         * netio.cc (NetIO::NetIO): Add parameter `allow_ftp_auth'.
6678         Set member `ftp_auth'.
6679         (NetIO::open): Add parameter `allow_ftp_auth'. Use it in calls
6680         to constructors of derived classes.
6681         (NetIO::get_ftp_auth): New method.
6682         * netio.h: Change class definition accordingly.
6683         * nio-ftp.cc (NetIO_FTP::NetIO_FTP): Add parameter `allow_ftp_auth'.
6684         Take global variables `net_ftp_user' and `net_ftp_passwd' into account.
6685         Add code for ftp authentication retry.
6686         * nio-ftp.h: Change class definition accordingly.
6687         * nio-http.cc (NetIO_HTTP::NetIO_HTTP): Add parameter `allow_ftp_auth'.
6688         Add code for ftp authentication retry in case of proxy connection.
6689         * nio-http.h: Change class definition accordingly.
6690         * res.rc: Add FTP authentication dialog.
6691         * resource.h: Add new constants used in res.rc.
6692         * state.h: Add variables `net_ftp_user' and `net_ftp_passwd'.
6693
6694 Sun May 27 17:12:23 2001  Christopher Faylor <cgf@cygnus.com>
6695
6696         * res.rc (IDD_SPLASH): Add a copyright year.
6697
6698 Sun May 27 15:42:18 2001  Christopher Faylor <cgf@cygnus.com>
6699
6700         * Makefile.in: Make iniparse.y produce a c++ file.
6701         * choose.cc (set_existence): Revert 2001-05-27 change.
6702         * ini.cc: Remove "C" from declaration of yyparse.
6703         * iniparse.y (yyparse): Fill out version field by default when a binary
6704         install is detected and no version has been set yet.
6705         * install.cc (do_install): Mount things earlier so that we can use
6706         proper mount table settings.  Don't remove mounts since they are now
6707         honored.
6708         * mount.cc (create_mount): Reread the mount table after establishing a
6709         new mount.
6710         (read_mounts): Explicitly clear root_here to allow multiple uses of
6711         this function.  Ensure that there is no garbage in the table when we've
6712         exhausted all of the mounts in the registry.
6713         (cygpath): Accomodate ./ in path.
6714
6715 Sun May 27 02:59:07 2001  Christopher Faylor <cgf@cygnus.com>
6716
6717         Use parse_filename method to parse filenames throughout.  Use
6718         get_root_dir to retrieve the current root directory throughout.  Set
6719         const in argument list, where appropriate, throughout.
6720         * choose.cc (set_existence): Detect case of uninstalled package with no
6721         version.
6722         (parse_filename): New function.
6723         * filemanip.h (fileparse): New structure.
6724         * mount.cc (read_mounts): Remember where we found the root mount.
6725         (set_root_dir): New function.
6726         (get_root_dir): Ditto.
6727         * mount.h: Declare new functions.
6728         * site.cc (get_root_dir_now): Renamed from get_root_dir.
6729         (save_site_url): Use new function name.
6730         (get_initial_list_idx): Ditto.
6731
6732 Sat May 26 21:23:59 2001  Christopher Faylor <cgf@cygnus.com>
6733
6734         * choose.cc: Use a constant throughout to deal with chooser icon
6735         length.
6736         * res.rc (IDD_CHOOSE): Increase size of chooser box.
6737
6738 2001-05-07  Brian Keener <bkeener@thesoftwaresource.com>
6739
6740         * choose.cc (do_choose): Fix incorrect assignment of trust setting to
6741         use when Redownload or Sources Only selected.
6742
6743 Thu May 10 22:35:59 2001  Christopher Faylor <cgf@cygnus.com>
6744
6745         Reformat file after botched patch formatting.
6746         * choose.cc (which_trust): Eliminate variable.
6747         (default_trust): Don't set which_trust.
6748         (do_choose): Use selected trust when reinstalling or installing source.
6749
6750 Thu May 10 21:04:18 2001  Christopher Faylor <cgf@cygnus.com>
6751
6752         Change concat to cygpath throughout.
6753         Change map_filename to cygpath throughout.
6754         * concat.cc (vconcat): New function.
6755         (concat): Use vconcat.
6756         * concat.h: Reflect above.
6757         * install.cc (map_filename): Eliminate.
6758         (install_one): Free dest_file.
6759         * mount.cc (find2): Expect input key to be pointing to mount record.
6760         (in_table): New function.
6761         (is_admin): Move from root.cc.
6762         (read_mounts): New function.
6763         (path_prefix_p): New function.
6764         (cygpath): New function.
6765         * mount.h: Define new functions and structure.
6766         * root.cc (in_table): Move to mount.cc.
6767         (do_root): Call read_mounts to initialize root stuff and mount table.
6768         * site.cc (get_root_dir): Ditto.
6769
6770 2001-05-09  Matt Hargett <matt@use.net>
6771
6772         * Makefile.in: Remove *.rc from clean.
6773
6774 Tue May  8 23:33:38 2001  Christopher Faylor <cgf@cygnus.com>
6775
6776         * choose.cc (scan2): Fix incorrect setting of TRUST_CURR rather than
6777         TRUST_PREV which produced "0" versions.
6778
6779 2001-05-07  Brian Keener <bkeener@thesoftwaresource.com>
6780
6781         * resource.h: Add new field IDC_CHOOSE_INST_TEXT.  Modify
6782         _APS_NEXT_CONTROL_VALUE to account for addition of
6783         IDC_CHOOSE_INST_TEXT.
6784         * res.rc (IDD_CHOOSE): Modify choose dialog to use new field
6785         IDC_CHOOSE_INST_TEXT for screen text.  Modify choose Dialog to allow
6786         hot keys to select Prev, Curr, Exp.
6787         * ini.h: Add new actions for ACTION_REDO and ACTION_SRC_ONLY.  Modify
6788         define for LOOP_PACKAGES to include new actions ACTION_REDO and
6789         ACTION_SRC_ONLY.
6790         * choose.cc: Add new Trusts for TRUST_REDO and TRUST_SRC_ONLY.
6791         (paint): Modify to check TRUST_SRC_ONLY when determining Bitmap for
6792         source Checkbox to use.
6793         (build_labels): Add logic to allow for selection of Source only
6794         Download/ReDownload/Install/Reinstall and also to Redownload/Reinstall
6795         current version binary.
6796         (dialog_proc): Add conditional display for file selection prompt based
6797         on download vs install using IDC_CHOOSE_INST_TEXT.
6798         (do_choose): Add new logic for TRUST_REDO and TRUST_SRC_ONLY selection
6799         and modify logic for TRUST_UNINSTALL, TRUST_KEEP, and TRUST_NONE to
6800         handle the instance where Source Download/Install was selected.  Modify
6801         log file to store appropriate information regarding Action selected and
6802         the new actions that were added (I.E.: ACTION_REDO and
6803         ACTION_SRC_ONLY).
6804         * download.cc: Add include for <unistd.h> and "port.h".
6805         (download_one): Modify parameter list to include the selected action
6806         for the file to be downloaded.  Modify size check against expected size
6807         to include check for ACTION_REDO and ACTION_SRC_ONLY.  Modify rename of
6808         .tmp file to also remove the destination file if exists due to ability
6809         to redownload source and binary now.
6810         (do_download): Modify to also use ACTION_REDO and ACTION_SRC_ONLY in
6811         calculation of Download Bytes.  Modify to also use ACTION_REDO and
6812         ACTION_SRC_ONLY in determining files selected for download.
6813         * install.cc (uninstall_one): Add check to treat a Reinstall like an
6814         upgrade so current version will be uninstalled prior to reinstall.
6815         (do_install): Add logic to handle ACTION_REDO and ACTION_SRC_ONLY for
6816         uninstalling and installing binary and source packages.
6817         * desktop.cc (make_passwd_group): Modify logic to account for a Source
6818         only cygwin install when checking for cygwin to determine need for
6819         mkpasswd and mkgroup.
6820
6821 Mon May  7 23:33:30 2001  Matt Hargett <matt@use.net>
6822
6823         * winsup/cinstall/res.rc: Added accelerators and improved focus order.
6824         Removed WS_DISABLED from "OK" buttons to accomodate default focus
6825         changes in net.cc and source.cc.
6826         * winsup/cinstall/net.cc (dialog_proc): If no radio button is selected,
6827         a default is selected.
6828         * winsup/cinstall/source.cc (dialog_proc): Ditto.
6829         (check_if_enable_next): Removed.  No longer needed since a radio button
6830         will always be selected.
6831         (load_dialog): Removed call to check_if_enable_next.
6832         (dialog_cmd): Ditto.  Also added default to switch.
6833
6834 Tue Apr 24 23:42:02 2001  Christopher Faylor <cgf@cygnus.com>
6835
6836         * res.rc: Resize affected text.
6837
6838 Tue Apr 24 23:35:31 2001  Christopher Faylor <cgf@cygnus.com>
6839
6840         * net.cc (do_net): Default to direct download.
6841         * res.rc: Move default selections to the top.
6842
6843 2001-04-18  Earnie Boyd  <earnie@users.sourceforge.net>
6844
6845         * win32.h: Remove the definitions for _UNION_NAME and _STRUCT_NAME.
6846         Must now include <windows.h> and not the pieces.
6847         * choose.cc (create_listview): Clean up type mismatch problems.
6848         * dialog.h (NEXT(id)): Ditto.
6849         * geturl.cc (dialog): Ditto.
6850         * install.cc (dialog): Ditto.
6851         * splash.cc (load_dialog): Ditto.
6852
6853 Wed Apr 18 18:59:21 2001  Christopher Faylor <cgf@cygnus.com>
6854
6855         * tar.cc (class gzbz): Define dummy virtual functions.
6856
6857 Wed Apr 18 16:01:21 2001  Christopher Faylor <cgf@cygnus.com>
6858
6859         * Makefile.in: Add bz2 include/library support.
6860         * filemanip.h: New file.
6861         * choose.cc (find_tar_ext): New function.  Returns TRUE if .tar.gz or
6862         .tar.bz2 found.
6863         (scan2): Reorganize to use find_tar_ext, accomodating .bz2 extension.
6864         (read_installed_db): Ditto.
6865         (do_choose): Ditto.
6866         * fromcwd.cc (found_file): Ditto.
6867         (do_fromcwd): Ditto.
6868         * tar.cc (class gzbz): New super class for uncompression support.
6869         (gz): New class for gzip support.
6870         (bz): New class for bzip2 support.
6871         (tar_open): Use gzbz class to control file opening.
6872         (tar_ftell): Ditto for returning position in file.
6873         (skip_file): Ditto for reading file.
6874         (tar_next_file): Ditto.
6875         (tar_read_file): Ditto.
6876         (tar_close): Ditto for close.
6877
6878         * zlib/configure.in: Force NM substitution.
6879
6880         * source.cc (do_source): Default to "Install from Internet".
6881
6882 2001-03-16  Brian Keener <bkeener@thesoftwaresource.com>
6883
6884         * nio-file.cc (NetIO_File::NetIO_File): Use `get_file_size' instead of
6885         `stat'.
6886         * choose.cc (list_click): Correct inability to select source code for
6887         download.
6888         (scan2): Modify to skip source tarballs when scanning disk for
6889         installable packages.
6890
6891 2001-03-10  Chris Abbey  <chris_abbey@yahoo.com>
6892
6893         * install.cc: install sources into /usr/src instead
6894         of /, also include the sizes of source tarballs
6895         in total_bytes.
6896         * download.cc: include sizes of source tarballs in
6897         total_download_bytes.
6898
6899 Tue Mar  6 19:31:00 2000  Corinna Vinschen <corinna@vinschen.com>
6900
6901         * download.cc (get_file_size): Remove `static'.
6902
6903 Tue Mar  6 19:11:00 2000  Corinna Vinschen <corinna@vinschen.com>
6904
6905         * tar.cc (tar_open): Use `get_file_size' instead of `stat'.
6906
6907 2001-03-06  Brian Keener <bkeener@thesoftwaresource.com>
6908
6909         * choose.cc (paint): Modify message for nothing to download vs
6910         nothing to install/update based on installation method.
6911         (list_click): Modify to skip versions in selection process if
6912         installing from local directory and installation file does not exist.
6913         Also leaves Source Action set to N/A if the source file does not exist
6914         and installing from local directory.
6915         (check_existence): New method to check current existence of installation
6916         files based on selected installation method.
6917         (set_existence): New method to set the current existence of installation
6918         files based on selected installation method.
6919         (best_trust): Modify decision process for best trust to base decision on
6920         current trust selected (IE: Prev, Curr, or Test), existence of file and
6921         installation method selected.
6922         (default_trust): Add logic to capture the current trust level and the
6923         trust selected for the given package.
6924         (set_full_list): Expand decision criteria for displaying a package in
6925         the selection list to include file existence/non-existence and selected
6926         installation method.
6927         (build_labels): Modify criteria for label addition to include
6928         installation method and file existence/non-existence.
6929         (create_listview): Modify to establish package trust level for each
6930         package before setting up the display list.  Also modification to set
6931         current trust button as the default.
6932         (dialog_cmd): Set response for Prev, Curr, Test button push to perform
6933         a reset of the selection list in addition to setting the default trust.
6934         (get_package_version): New method to provide reusable code for
6935         determining the package version from the file name for a specified
6936         trust.
6937         (scan2): Modify to use new method get_package_version and
6938         also enhance handling of the build for the structures package and
6939         extra.
6940         (read_installed_db): Modify to use the new method
6941         get_package_version and also enhance handling of the build for the
6942         structures package and extra.
6943         (do_choose): Add additional initialization of package and extra
6944         structures.  Modify to use read_installed_db all the time despite
6945         install method.  Modify output to setup.log.full log file to increase
6946         readability by adding additional spacing, expanded code and available
6947         versions.
6948         * ini.h: Add new fields install_exists, source_exists and
6949         partial_list_display to the structure definition for package.
6950         * res.rc (IDD_CHOOSE): Modify choose dialog Prev, Curr, and Test
6951         pushbuttons by replacing with Radio Buttons thus allowing the
6952         operator to better determine which is selected.
6953
6954 2001-02-20  Brian Keener <bkeener@thesoftwaresource.com>
6955
6956         * download.cc (do_download): Add new variables total_download_bytes and
6957         total_download_bytes_sofar for download progress meter.  Add loop
6958         to accumulate the total bytes to download from the selected packages.
6959         * geturl.cc: Add state.h and diskfull.h to include list.  Add new
6960         variables gw_iprogress, gw_pprogress, gw_progress_text,
6961         gw_pprogress_text, and gw_iprogress_text to allow for addition of
6962         total packages download progress meter and disk full percent
6963         progress meter.  Add variables total_download_bytes and
6964         total_download_bytes_sofar for use by progress meters.
6965         (dialog_proc): Add new variables gw_iprogress, gw_pprogress,
6966         gw_progress_text, gw_pprogress_text, and gw_iprogress_text to
6967         allow for addition of total packages download progress meter and disk
6968         full percent progress meter.
6969         (init_dialog): Ditto.
6970         (progress): Ditto.
6971         (get_url_to_file): Ditto.
6972         * geturl.h: Add external definition for total_download_bytes and
6973         total_download_bytes_sofar.
6974         * res.rc: Add two additional progress meters (IDC_DLS_IPROGRESS)
6975         and (IDC_DLS_PPROGRESS) and three text objects (IDC_DLS_PROGRESS_TEXT)
6976         and (IDC_DLS_IPROGRESS_TEXT, IDC_DLS_PPROGRESS_TEXT) for use in the
6977         download meters.
6978         * resource.h: Add new fields for progress meters and text and update
6979         _APS_NEXT_CONTROL_VALUE.
6980
6981 Wed Feb 21 13:05:00 2000  Corinna Vinschen <vinschen@redhat.com>
6982
6983         * download.cc (get_file_size): Check for INVALID_HANDLE_VALUE instead
6984         for NULL.
6985
6986 Wed Feb 21 11:21:00 2000  Corinna Vinschen <vinschen@redhat.com>
6987
6988         * download.cc (download_one): Add missing parenthesis.
6989
6990 Mon Feb 19 18:59:00 2000  Corinna Vinschen <vinschen@redhat.com>
6991
6992         * download.cc (get_file_size): New function. Eliminates the need
6993         to call `stat'.
6994         (download_one): Call `get_file_size' instead of `stat'. This
6995         workarounds a problem with mingw's `stat' call.
6996
6997 2001-02-07  Earnie Boyd  <earnie@users.sourceforge.net>
6998
6999         * Makefile.in: (%.o: %.rc): Specify --include-dir $(w32api_include).
7000         This is to allow cinstall to build with 2.95.2-7 and to make the
7001         use of headers consistent.
7002
7003 2000-12-26  Earnie Boyd  <earnie_boyd@yahoo.com>
7004
7005         * Makefile.in (autoload.o): Add target to specify -fno-inline-functions
7006
7007 Tue Dec 26 03:46:00 2000  Matt Hargett  <matt@use.net>
7008
7009         * winsup/cinstall/res.rc: Added accelerators and improved focus
7010         order.
7011
7012 2000-12-10  Egor Duda <deo@logos-m.ru>
7013
7014         * choose.cc (paint): Use system background color for text output.
7015
7016 Sun Dec 10 19:05:25 2000  Christopher Faylor <cgf@cygnus.com>
7017
7018         * Makefile.in: Use CXX for linking and for compiling .cc files.
7019         * configure.in: Find correct c++ compiler.
7020         * configure: Regenerate.
7021
7022 2000-11-17  DJ Delorie  <dj@redhat.com>
7023
7024         * splash.cc (load_dialog): Make message more obvious.
7025         * res.rc: Ditto.
7026
7027 Fri Nov 17 17:15:21 2000  Christopher Faylor <cgf@cygnus.com>
7028
7029         * Makefile.in: Use g++ to link so that libstdc++.a gets used.  This is
7030         necessary for newer compilers.
7031
7032 Wed Nov 9  2:19:00 2000  Corinna Vinschen <vinschen@redhat.com>
7033
7034         * desktop.cc: Include "ini.h" and "version.h".
7035         (make_passwd_group): Skip the function on 9x/ME boxes when an
7036         older version of Cygwin has been installed which doesn't
7037         support mkpasswd/mkgroup on 9x/ME.
7038         * install.cc: Move the `LOOP_PACKAGES' and `pi' macros to...
7039         * ini.h: ...here.
7040
7041 Wed Nov 8 17:10:00 2000  Corinna Vinschen <vinschen@redhat.com>
7042
7043         * desktop.cc (make_passwd_group): Don't exit when started
7044         on 9x/ME since mkpasswd/mkgroup are usable on 9x/ME now.
7045
7046 Sun Nov 5 12:51:42 2000  Jason Tishler  <jt@dothill.com>
7047
7048         * install.cc (do_install): Add call to set_cygdrive_flags to sync
7049         the mount modes.
7050         * mount.cc (set_cygdrive_flags): New function.
7051         (get_cygdrive_flags): Ditto.
7052         (default_cygdrive): Ditto.
7053         (set_cygdrive_flags): Ditto.
7054         * mount.h: Add prototype for set_cygdrive_flags.
7055
7056 2000-10-23  DJ Delorie  <dj@redhat.com>
7057
7058         * ini.h: add source actions
7059         * fromcwd.cc: check for available sources
7060         * res.rc: add checkbox bitmaps
7061         * resource.h: ditto
7062         * check-*.bmp: new
7063         * choose.cc: add source column
7064         * download.cc: download sources if called for
7065         * install.cc: [un]install sources too
7066
7067 2000-10-22  DJ Delorie  <dj@redhat.com>
7068
7069         * choose.cc (build_labels): Don't skip TRUST_PREV completely; only
7070         ignore it wrt full_list if there's already a version installed.
7071         (do_choose): Sort the list.
7072         (package_sort): New.
7073
7074 2000-10-12  DJ Delorie  <dj@redhat.com>
7075
7076         * res.rc: Add more error strings.
7077         * resource.h: Ditto.
7078         * iniparse.y (new_package): re-initialize if needed.
7079         * download.cc (do_download): Keep track of errors; notify and
7080         allow retry.
7081         * install.cc (do_install): Ditto.
7082
7083 2000-10-05  DJ Delorie  <dj@redhat.com>
7084
7085         * Makefile.in: fix %.cc rule
7086
7087 2000-10-04  DJ Delorie  <dj@redhat.com>
7088
7089         * desktop.cc: quote HOME and USER, don't . ./.profile
7090
7091         * choose.cc (build_labels): don't include in partial list just
7092         because there's a *previous* version available.
7093
7094         * install.cc (do_install): if installing from local directory with
7095         setup.ini and the file isn't found, look in "." also.  Note errors.
7096
7097 2000-10-02  DJ Delorie  <dj@redhat.com>
7098
7099         * ini.cc (do_ini): save setup.ini locally
7100
7101 2000-10-02  Chris Abbey  <cabbey@bresnanlink.net>
7102
7103         * desktop.cc: quote escapes in prompt
7104
7105 2000-10-02  Jason Tishler  <jt@dothill.com>
7106
7107         * root.cc (is_admin): New function.
7108         (read_mount_table): Check for administrative priviledges and set
7109         installation scope as appropriate.
7110
7111 2000-09-28  DJ Delorie  <dj@redhat.com>
7112
7113         * nio-ftp.cc (ftp_line): handle continuations more robustly
7114
7115 2000-09-14  Brian Keener  <bkeener@thesoftwaresource.com>
7116
7117         * res.rc: increased the size of the site dialog (IDD_SITE) & the
7118         corresponding list box to provide for more URL's to be listed.
7119         Modified the position of the Back, Next and Cancel buttons to
7120         correspond to the new size of the dialog.
7121
7122 2000-09-13  DJ Delorie  <dj@redhat.com>
7123
7124         * install.cc (do_install): update disk fullness once per package
7125         to improve performance
7126
7127         * choose.cc (create_listview): call ReleaseDC
7128
7129 Mon Sep 11 22:40 2000  Harold L Hunt II <harold@compasstechnologies.com>
7130
7131         * mkdir.cc: Create directories when ERROR_FILE_NOT_FOUND is
7132         returned, as it seems Samba 2.0.6+ returns this instead of
7133         ERROR_PATH_NOT_FOUND
7134
7135 Mon Sep 11 19:35:24 2000  Christopher Faylor <cgf@cygnus.com>
7136
7137         * site.cc (get_initial_list_idx): Don't default to saved URL if it
7138         refers to sources.
7139
7140 2000-09-07  DJ Delorie  <dj@redhat.com>
7141
7142         * splash.cc: use version.h, not local decl
7143         * res.rc: add "old version" message
7144         * resource.h: ditto
7145         * version.h: new
7146         * fromcwd.cc (canonicalize_version): make global
7147         * iniparse.y: add setup-version support, fix bug in blank line
7148         handling
7149
7150         * inilex.l: add [exp] as alias for [test], add setup-version
7151         * Makefile.in (version.c): add setup-version tag
7152
7153         * desktop.cc (do_desktop): remove 1.1 version number
7154         (do_desktop_setup): ditto
7155
7156         * ini.cc (do_ini): zero out package list just in case we redo it.
7157
7158 2000-09-07  Jeffrey Juliano  <juliano@cs.unc.edu>
7159
7160         * choose.cc (list_click): Check for nindexes==0; if so, return.
7161
7162 2000-09-06  Andrej Borsenkow  <Andrej.Borsenkow@mow.siemens.ru>
7163
7164         * localdir.cc: new, local package directory selection dialog; cd
7165         into selected directory
7166         * Makefile.in (OBJS): add localdir.o
7167         * dialog.h: add prototype for do_local_dir
7168         * main.cc (WinMain): initialize local_dir to cwd; add call to
7169         do_local_dir
7170         * net.cc (dialog_cmd): make DO_LOCAL_DIR next dialog
7171         * source.cc (dialog_cmd): ditto
7172         * res.rc: add DO_LOCAL_DIR dialog; remove "current directory" from
7173         presented choices in IDD_SOURCE; add IDS_ERR_CHDIR error string
7174         * resource.h: defines for DO_LOCAL_DIR dialog; define IDS_ERR_CHDIR
7175         * root.cc (dialog_cmd): make DO_LOCAL_DIR previous dialog
7176         * state.h: add local_dir variable
7177
7178 2000-09-06  Brian Keener  <bkeener@thesoftwaresource.com>
7179
7180         * desktop.cc: added logic to handle to the new dialog and to
7181         default the setting for the new checkboxes based on whether the
7182         desktop icon or start menu link already exist.
7183         (desktop_icon): correction to desktop directories for desktop icon
7184         creation.  Additional logic added for Win95 which does not appear
7185         to have Common Directories so if Common selected and null uses
7186         normal directory.
7187         (start_menu): Additional logic added for Win95 which does not
7188         appear to have Common Directories so if Common selected and null
7189         uses normal directory.
7190         (do_desktop_setup): moved the saving of the icon, creation of the
7191         bat file, profile, passwd, Start Menu link and desktop shortcut to
7192         this method from do_desktop.  Made the creation of the desktop
7193         icon and start menu link conditional on settings of new dialog
7194         created for desktop.
7195         * install.cc (do_install): changed next from IDD_S_DESKTOP to
7196         IDD_DESKTOP.
7197         * main.cc (WinMain): changed case IDD_S_DESKTOP to IDD_DESKTOP.
7198         * res.rc: added new resource to create a desktop dialog with 2
7199         checkboxes for creating the desktop icon and start menu link.
7200         * resource.h: changed IDD_S_DESKTOP to IDD_DESKTOP and added two
7201         new controls: IDC_ROOT_MENU and IDC_ROOT_DESKTOP for new dialog.
7202         * state.h: added root_menu and root_desktop for use in dialog.
7203
7204 2000-08-29  DJ Delorie  <dj@redhat.com>
7205
7206         * choose.cc (scan_downloaded_files): scan for existing files, so
7207         that the user only sees new downloads.
7208
7209         * nio-ie5.cc (NetIO_IE5): pre-check for wininet.dll, enable dial-up
7210         * site.cc (do_site): if we can't download the mirror list, go back
7211         to the net setup box to choose another transport.
7212         * autoload.c: add more functions
7213         * Makefile.in (ALL_DEP_LDLIBS): remove wininet.a
7214         * resource.h: add WININET message
7215
7216         * net.cc (do_net): no longer default to IE5
7217         * simpsock.h (class SimpleSocket): new, simplify socket operations
7218         * simpsock.cc: ditto
7219         * nio-http.h: new, for direct http protocol
7220         * nio-http.cc: ditto
7221         * nio-ftp.h: new, for direct http protocol
7222         * nio-ftp.cc: ditto
7223         * netio.cc (set_url): move initialization here to handle redirections
7224         (open): add direct http/ftp
7225         * netio.h (NetIO::set_url): new
7226
7227         * log.cc (log_save): create directory for log if needed
7228
7229         * hash.cc, hash.h: new
7230         * Makefile: add hash.o
7231         * choose.cc: enable "uninstall" option
7232         * download.cc: invert action test to accomodate uninstalling
7233         * ini.h: add ACTION_UNINSTALL
7234         * install.cc: add uninstall functionality
7235         * res.rc: make install tag changeable
7236         * resource.h: add uninstall resources
7237
7238         * res.rc: update mirror list URL
7239
7240 2000-08-24  DJ Delorie  <dj@redhat.com>
7241
7242         * log.cc, log.h: new files
7243         * Makefile.in (OBJS): add log.o
7244         * tar.cc: use exit_setup instead of exit
7245         * dialog.cc (fatal): use exit_setup instead of ExitProcess
7246         * msg.cc (fatal): ditto
7247         * install.cc (dialog_cmd): ditto
7248         * ini.cc (do_ini): ditto
7249         * main.cc (main): add logging
7250         * source.cc (do_source): ditto
7251         * root.cc (do_source): ditto
7252         * site.cc (do_site): ditto
7253         * other.cc (do_other): ditto
7254         * net.cc (do_net): ditto
7255         * choose.cc (do_choose): ditto
7256         * download.cc (do_download): ditto
7257         * install.cc (do_install): ditto
7258         * msg.cc (fatal): ditto
7259
7260         * res.rc: mark password boxes as *being* password boxes.
7261
7262         * fromcwd.cc (canonicalize_version): use multiple buffers so that
7263         multiple calls won't use the same buffer.
7264         * choose.cc (create_listview): don't default to full list if no changes
7265         (base): return computed value, not temporary :-(
7266         (do_choose): don't use installed.db if we're only downloading.
7267
7268 2000-08-23  DJ Delorie  <dj@redhat.com>
7269
7270         * nio-ie5.cc (NetIO_IE5): Fix authentication logic
7271         * nio-ie5.h (flush_io): new
7272         * netio.cc (load_dialog): note when we're initializing the dialog
7273         box, and ignore changes to the edit fields then.
7274
7275 2000-08-21  DJ Delorie  <dj@redhat.com>
7276
7277         * README: Update
7278
7279         * fromcwd.cc (found_file): don't remember the canonicalized version
7280
7281         * choose.cc (paint): print "nothing to do" message when list is empty.
7282         (build_labels): Use version "0.0" if no version is available.
7283         (create_listview): default to full list if nothing to install/update.
7284         (base): new, returns basename of file
7285         (read_installed_db): compare base names, not full paths
7286
7287 2000-08-11  DJ Delorie  <dj@redhat.com>
7288
7289         * choose.cc: add new chooser dialog
7290         * fromcwd.cc: use IDD_CHOOSE
7291         * ini.cc: use IDD_CHOOSE
7292         * main.cc: use IDD_CHOOSE
7293         * ini.h: cosmetic changes
7294         * res.rc: add choose dialog, bitmaps
7295         * choose-spin.bmp: new
7296         * choose-rtarrow.bmp: new
7297         * resource.h: add choose dialog controls
7298
7299         * mount.cc: remove debug statement
7300
7301 2000-08-08  DJ Delorie  <dj@redhat.com>
7302
7303         * Makefile.in (version.c): make version checking more robust
7304         * splash.cc (load_dialog): handle case where there's no version
7305
7306 2000-08-07  DJ Delorie  <dj@redhat.com>
7307
7308         * (all): add cvsid tags
7309         * Makefile.in: generate version.c from ChangeLog, add splash.o
7310         * splash.o: new
7311         * res.rc: add splash screen
7312
7313 2000-08-02  DJ Delorie  <dj@redhat.com>
7314
7315         * net.cc: remove proxy password code
7316         * res.rc: remove proxy user/pass from net, add auth dialogs
7317         * netio.cc,h: add sys/proxy auth methods
7318         * nio-ie5: use them, check for http status codes
7319         * state.h: add system authorization
7320
7321         * concat.cc (concat): canonicalize x:// to x:/ (exception to ://
7322         meaning an url)
7323
7324 2000-08-02  Norman Vine <nhv@yahoo,com>
7325
7326         * msg.cc (mbox): added MB_TOPMOST to MessageBox type flags
7327
7328 2000-08-01  DJ Delorie  <dj@redhat.com>
7329
7330         * postinstall.cc (each): don't rename files we ignore
7331         (do_postinstall): set CYGWINROOT to root_dir, chdir there
7332
7333         * desktop.cc: have /etc/profile call ~/.profile and ~/.bashrc
7334
7335 2000-07-31  DJ Delorie  <dj@redhat.com>
7336
7337         * desktop.cc: reverse PATH so /usr/bin precedes /bin
7338
7339 2000-07-18  DJ Delorie  <dj@redhat.com>
7340
7341         * autoload.c: new, autoload dlls that might not be available.
7342         * Makefile.in (OBJS): add autoload.o
7343
7344         * res.rc: rewrite root options (text/binary, system/user) to be
7345         more obvious.
7346
7347         * site.cc (get_site_list): trim displayed URL, sort by domain
7348
7349         * net.cc (do_net): make IE5 default to checked, for now
7350
7351         * choose.cc (do_choose): sort packages correctly
7352         * ini.cc (do_ini): handle parse errors more gracefully
7353         (yyerror): ditto
7354         (fprintf): line buffer output
7355         (do_ini): if we can't load setup.ini, go back to the site list.
7356         * ini.h: add "unknown" trust level
7357         * inilex.l: absorb unknown trust levels and key/value pairs,
7358         add line number logic
7359         * iniparse.y: handle parse errors more gracefully.
7360         * install.cc: skip packages with no valid install entry
7361
7362 2000-07-17  DJ Delorie  <dj@cygnus.com>
7363
7364         * coding standards fixups, many files
7365         * mkdir.cc: warn about deletions *before* deleting them
7366
7367 2000-07-17  Jeff Juliano  <juliano@cs.unc.edu>
7368
7369         * res.rc (IDD_OTHER_URL): reorder to give default focus to entry
7370
7371         * other.cc (dialog_cmd): save download site URL
7372         * site.cc (get_root_dir): new
7373         (save_mirror_site): new
7374         (dialog_cmd): save download site URL
7375         (get_site_list): make list big enough to add prev site
7376         (get_initial_list_idx): new, read last-used URL from file and
7377         append it to site_list
7378         (do_site): call get_initial_list_idx
7379
7380         * concat.cc (concat): avoid segfault when first parm is null
7381
7382 2000-07-13  DJ Delorie  <dj@cygnus.com>
7383
7384         * postinstall.cc: new
7385         * Makefile.in: add postinstall.o
7386         * concat.h: add backslash ()
7387         * concat.cc: ditto
7388         * desktop.cc (etc_profile): don't do postinstall
7389         (backslash): moved to concat.cc
7390         (uexists): new
7391         (make_postinstall_script): run directly
7392         (do_desktop): chain to do_postinstall
7393         * dialog.h: add exit_msg, do_postinstall
7394         * download.cc: use exit_msg
7395         * install.cc: ditto
7396         * main.cc: add postinstall, exit_msg
7397         * resource.h: add postinstall
7398         * README: add more to-do items
7399
7400 2000-07-12  DJ Delorie  <dj@cygnus.com>
7401
7402         * desktop.cc: add /etc/postinstall/ support
7403         * install.cc: add more "standard" directories
7404
7405 2000-07-11  DJ Delorie  <dj@cygnus.com>
7406
7407         * desktop.cc: create /etc/profile
7408         * desktop.cc: fix include syntax
7409         * Makefile.in: add auto-dependencies
7410         * root.cc: support system vs user
7411         * desktop.cc: ditto
7412         * mount.h: ditto
7413         * mount.cc: ditto
7414         * install.cc: ditto
7415         * res.rc: ditto
7416         * resource.h: ditto
7417         * state.h: ditto
7418         * desktop.cc: make sure we use backslashes, not slashes.
7419         * desktop.cc: don't set PATH in cygwin.bat, create /etc/passwd
7420         * geturl.cc: change math for percentage to avoid overflow
7421         * install.cc: ditto
7422         * download.cc: post "download complete" message.
7423         * root.cc: pre-fill in defaults if needed, don't start
7424         browse at root_dir unless it's set.
7425         * desktop.cc: quote $PATH in case it has spaces in it
7426
7427 2000-07-10  DJ Delorie  <dj@cygnus.com>
7428
7429         * Makefile.in: add desktop.o and mklink2.o
7430         * dialog.h: add do_desktop
7431         * install.cc: create standard directories, call do_desktop
7432         * res.rc: add cygwin.ico as a file also
7433         * desktop.cc: new, do shortcuts, batch files, and icons
7434         * mklink2.c: new, for COM
7435         * README: update to-do list
7436
7437 2000-07-10  DJ Delorie  <dj@cygnus.com>
7438
7439         * ini.cc (do_ini): don't worry about timestamps if we're not
7440         actually installing.
7441
7442 2000-07-09  DJ Delorie  <dj@cygnus.com>
7443
7444         * Makefile.in: add -I$(srcdir) for ini.h
7445
7446 2000-07-06  DJ Delorie  <dj@cygnus.com>
7447
7448         * Replace everything with a new GUI version
7449         * zlib/gzio.c: add gzctell() for progress displays
7450
7451 2000-06-22  DJ Delorie  <dj@cygnus.com>
7452
7453         * setup.c (tarx): re-add call to write_pkg()
7454
7455 2000-06-07  DJ Delorie  <dj@cygnus.com>
7456
7457         * cygcalls.c: new, call cygwin1.dll functions directly
7458         * cygcalls.h: header for same
7459         * Makefile.in: add cygcalls.[ch], remove mount/cygpath/umount
7460         exes, fix cinstall.rc dependencies.
7461         * path.c: remove unneeded code
7462         * setup.c: use cygcalls instead of xcreate_process.
7463         uncompress embedded files with zlib
7464         add "-d" for "download only"
7465         add "-h" for help
7466         postpone mount changes until very end
7467         add download progress indicators
7468         pack multi-column listings more
7469         auto-delete temp files
7470         customize banner message according to options
7471         prompt user for text/binary mounts
7472         add warnings about empty setup directory, root installs, etc
7473
7474 2000-05-24  DJ Delorie  <dj@cygnus.com>
7475
7476         * tar.c: New file; built-in tar using zlib.
7477         * tar.h: New file; header for same.
7478         * ctar.c: New file; test program for same.
7479         * Makefile.in: add built-in tar, remove tar.exe and gzip.exe
7480         * path.c (pathcat): convert slashes and canonicalize, instead of
7481         aborting
7482         * setup.c (tarx): add support for built-in tar
7483         (main): accept unix-style slashes, check root dir for drive letters,
7484         warn about installing in /, make sure cwd is empty for internet
7485         installs, defer mounts to end of install, support built-in tar.
7486
7487 Fri May 19 23:44:37 2000  Christopher Faylor <cgf@cygnus.com>
7488
7489         Fix compiler warnings throughout.
7490         * pkg.c (init_pkgs): Make static 'stuff' global_pkgstuff for use in
7491         get_pkg_stuff.
7492         * setup.c: Make 'root' global.
7493         (istargz): Return pointer to "stem" of matched .tar.gz file.
7494         (tarx): Special case cygwin-20000301 to == cygwin-1.1.0.tar.gz.  Remove
7495         bogus check_for_installed check.
7496         (recurse_dirs): Add preliminary support for .bat file execution.
7497         (create_uninstall): Eliminate unneeded parameter.
7498         (do_start_menu): Ditto.
7499         (mkmount): Ditto.
7500         (get_pkg_stuff): Ditto.  Check for currently installed cygwin by
7501         scanning for the version number.  Eliminate unneeded argument to
7502         create_uninstall.
7503         (getdownloadsource): Add 'name' to list of names rather than url.
7504         (main): Eliminate unneeded argument in get_pkg_stuff.  Eliminate
7505         unneeded argument in mkmount and do_start_menu.
7506
7507 2000-05-18  DJ Delorie  <dj@cygnus.com>
7508
7509         * setup.c (optionprompt): allow multi-column, clean up message
7510         about more options, be more robust about user input.
7511         (getdownloadsource): make the mirror URL a macro.
7512         (main): do mounts after done prompting user.
7513
7514 Tue May  2 00:56:41 2000  Christopher Faylor <cgf@cygnus.com>
7515
7516         * setup.c (cleanup): Inverse order of deletion stands a better chance
7517         of deleting cygpath.exe.  Still seems to suffer from occasional races,
7518         though.
7519         (cleanup_on_signal): Perform convoluted dance to accomodate win95 and
7520         w2k.
7521         (output_file): Defend against an unlikely handle leak.
7522         (main): Don't set up signal handling until we have something special to
7523         do.
7524
7525 Mon May  1 17:56:32 2000  Christopher Faylor <cgf@cygnus.com>
7526
7527         * path.c (kill_cygpath): Delete function.
7528         (exit_cygpath): Make more defensive so that it can be called at any
7529         time.
7530         (cygpath_pipe): Don't set up signal here.  Do it in main().
7531         * setup.c (istargz): New function.
7532         (recurse_dirs): Look for *.gz pattern rather than *tar.gz since *tar.gz
7533         inexplicably fails on samba mounted partitions.  Use istargz to match
7534         tar.gz tail.
7535         (processdirlisting) Use istargz to match tar.gz tail.
7536         (cleanup): Renamed from filedel.
7537         (cleanup_on_signal): New function.  Called on CTRL-C.
7538         (main): Record handle of main thread so that it can be suspended when
7539         CTRL-C occurs.  Set up cleanup_on_signal signal handler.
7540
7541 Mon May  1 11:05:07 2000  Christopher Faylor <cgf@cygnus.com>
7542
7543         * setup.c (do_start_menu): Don't concatenate paths to already built
7544         paths.
7545
7546 Sun Apr 30 22:37:34 2000  Christopher Faylor <cgf@cygnus.com>
7547
7548         * path.c (exit_cygpath): Wait for subprocess to exit before returning.
7549         (cygpath_pipe): Don't call exit_cygpath.  Let main atexit routine do
7550         that.
7551         * pkg.c (init_pkgs): Accept root argument.  Make registry key "cygwin
7552         root"-specific.
7553         * setup.c (filedel): Call exit_cygpath here so that we can be assured
7554         that cygpath subprocess has died.  This allows us to delete cygpath.exe
7555         and cygwin1.dll.
7556         (optionprompt): Initialize response to -1 so that second screen of
7557         mirrors will appear.
7558         (get_pkg_stuff): Don't attempt to use HKCLU.  Pass root to init_pkgs.
7559         * setup.h: Reflect init_pkgs prototype change.
7560
7561 Sat Apr 29 23:53:30 2000  Christopher Faylor <cgf@cygnus.com>
7562
7563         * pkg.c (init_pkgs): Accept an argument to control what root registry
7564         key should be used.
7565         * setup.c (get_pkg_stuff): Use HKCLU registry key if default fails.
7566         * setup.h: Reflect init_pkgs prototype change.
7567
7568 Sat Apr 29 23:27:14 2000  Christopher Faylor <cgf@cygnus.com>
7569
7570         * error.c (winerror): Respond to gcc warning.
7571         * path.c (cygpath_pipe): Ditto.
7572         * setup.c (filedel): Call sa_cleanup on deleteme.
7573         (create_shortcut): Coerce argument to eliminate compiler warning.
7574         (tarx): Use installed version of cygwin1.dll, overriding tar file name.
7575         (refmatches): New function.  Tests if ref is contained in a list of
7576         packages to install.
7577         (filematches): New function.  Tests if filename matches one of a list
7578         of packages to install.
7579         (recurse_dirs): Accept list of packages to install.  Generalize tar.gz
7580         test to accomodate _tar.gz.
7581         (prompt): Ensure that stdout is flushed prior to asking for input.
7582         (findhref): Initialize variables to quiet a compiler warning.
7583         (processdirlisting): Accept list of packages to install.  Special case
7584         cygwin tar file version number.
7585         (downloaddir): Accept list of packages to install.
7586         (downloadfrom): Ditto.
7587         (create_uninstall): Eliminate unneeded variables.  Quote arguments to
7588         regtool.
7589         (do_start_menu): Don't create uninstall bat file if updating or user
7590         specified a list of packages.
7591         (mkmount): Eliminate unneeded variables.
7592         (get_pkg_stuff): New function.  Checks for previous unversioned
7593         installation.
7594         (main): Accept -u and -f options and package names on the command line.
7595         Use get_pkg_stuff to initialize package information.  Umount /etc.
7596         Call recurse_dirs and downloadfrom with list of package to install.
7597         Ensure that all /usr/local directories are created.  Output
7598         installation time to setup.log.
7599         * setup.h: Add some prototypes.
7600         * xsystem.c (xcreate_process): Eliminate unneeded variable.
7601
7602 Sat Apr 29 12:43:08 2000  Christopher Faylor <cgf@cygnus.com>
7603
7604         * setup.c (optionprompt): Don't overlap display of already seen options
7605         on next page.
7606         (geturl): Print name of site which we're connecting to rather than "ftp
7607         site".
7608         (processdirlisting): Avoid URLs that contain a /.  or ./ .  Is this
7609         test too simplistic?
7610         (do_start_menu): Use pathcat to build path to <root>\bin to avoid
7611         problems when user chooses x:\ as their root.
7612         (main): For now, default to "non-update" mode.  Allow -u option to
7613         signify an update.
7614
7615 Sat Apr 29 00:26:06 2000  Christopher Faylor <cgf@cygnus.com>
7616
7617         * pkg.c: New file.
7618         * setup.c (tarx): Skip already installed or older packages.  Report
7619         when a package has been updated.
7620         (processdirlisting): Skip already installed or older packages.
7621         (main): Detect -f option for forced installation.  Initialize pkg stuff
7622         if appropriate.
7623         * setup.h: Add pkg definitions.
7624
7625 Thu Apr 27 14:21:30 2000  Christopher Faylor <cgf@cygnus.com>
7626
7627         * setup.c (findhref): Return NULL on empty string.  Eat any trailing
7628         ";something".
7629         (processdirlisting): Attempt to limit recursively processing the same
7630         directory.
7631
7632 Thu Apr 27 11:42:23 2000  Christopher Faylor <cgf@cygnus.com>
7633
7634         * setup.c (filedel): New function.
7635         (output_file): Keep track of files extracted from setup.exe for
7636         subsequent deletion.
7637         (tarx): Close process handle of child tar process or suffer handle
7638         leak.
7639         (getdownloadsource): Close mirror file so that it can be unlinked.
7640         (processdirlisting): Return total number of files extracted.
7641         (main): Initialize array of files to delete.  Ensure that files are
7642         closed on exit.  Make the directory that setup.exe is started from ==
7643         the directory where temporary files are placed.  Issue an error if no
7644         files were found to download.
7645         * xsystem.c (xcreate_process): Close the thread handle.  Close the
7646         process handle if we waited for it to exit.
7647
7648 Thu Apr 27 09:54:19 2000  Christopher Faylor <cgf@cygnus.com>
7649
7650         * setup.c (main): Change version number output.
7651
7652 Thu Apr 27 09:23:17 2000  Christopher Faylor <cgf@cygnus.com>
7653
7654         * setup.c (tarx): Use full path name to tar executable.
7655         (main): Build full pathname to tar executable.  Create /usr/local/etc
7656         by default.
7657
7658 Wed Apr 26 22:16:57 2000  Christopher Faylor <cgf@cygnus.com>
7659
7660         * setup.c (findhref): Change method for scanning for href= to choose
7661         the last one on the line.  This is still not foolproof and probably
7662         will need to be changed eventually.  Don't abort if no "size" field is
7663         evident.
7664         (processdirlisting): Fix boolean algebra.
7665
7666 Wed Apr 26 01:10:39 2000  Christopher Faylor <cgf@cygnus.com>
7667
7668         * main.c (tarx): Add some code for future task of unmounting
7669         directories encountered in tar file.
7670
7671 Sat Apr 22 16:37:03 2000  Christopher Faylor <cgf@cygnus.com>
7672
7673         * setup.c (findhref): Decode file size, when appropriate.
7674         (needfile): New function.  Returns 1 when file should be
7675         downloaded.
7676         (processdirlisting): Always download if file size does not
7677         match.  Prompt when download fails for some reason.
7678         (getdownloadsource): Accomodate findhref argument changes.
7679
7680 Sat Apr 22 15:13:42 2000  Christopher Faylor <cgf@cygnus.com>
7681
7682         Throughout, use global session handle rather than reinitializing for
7683         each connect.  Don't pass session as an argument to setup.c functions.
7684         * setup.c (geturl): Only issue "Connecting to.." message when using
7685         http or first time for ftp since subsequent connections will be fast.
7686         (processdirlisting): Allocate space for "N" when user has specified
7687         "N"ever option so that it can be subsequently freed.
7688         (main): Abort if we can't get the list of mirrors.
7689
7690 Thu Apr 20 16:41:42 2000  Christopher Faylor <cgf@cygnus.com>
7691
7692         * setup.c (main): Umount /bin and /lib.
7693
7694 Wed Apr 19 13:34:44 2000  Christopher Faylor <cgf@cygnus.com>
7695
7696         * setup.c (main): Create an empty /var/run/utmp.
7697
7698 Tue Apr 18 19:16:56 2000  Christopher Faylor <cgf@cygnus.com>
7699
7700         * Makefile.in: Add umount to list of files to include in setup.exe.
7701         * setup.c (xumount): New function for unmounting directories.
7702         (main): Unmount /usr.
7703         (mkmount): Unmount "unix directory" before trying to figure out where
7704         to create the directory.
7705
7706 Tue Apr 18 17:28:55 2000  Christopher Faylor <cgf@cygnus.com>
7707
7708         * setup.c (mkmount): Use xcreate_process to start mount process,
7709         avoiding the shell.
7710         (main): Don't do buffering on stdout or prompts won't be displayed
7711         correctly if running in a cygwin shell with CYGWIN=tty.
7712
7713 Tue Apr 18 15:35:19 2000  Christopher Faylor <cgf@cygnus.com>
7714
7715         * setup.c (main): Remove the CYGWIN environment variable before
7716         starting any cygwin programs.
7717
7718 Mon Apr 17 19:20:52 2000  Vadim Egorov <egorovv@mailandnews.com>
7719
7720         * setup.c (geturl): Use alternative method for finding filename part of
7721         a URL.
7722         (processdirlisting): Accomodate strange output from non-MS ftp proxy.
7723         (downloaddir): Unlink file containing dir listing.
7724         (downloadfrom): Ditto.
7725
7726 Mon Apr 17 00:00:49 2000  Christopher Faylor <cgf@cygnus.com>
7727
7728         * setup.c (main): Disallow running setup.exe from the "root".
7729
7730 Sun Apr 16 18:50:58 2000  Christopher Faylor <cgf@cygnus.com>
7731
7732         Use "warning" function, where appropriate, to output warnings.
7733         * setup.c (warning): New function -- outputs warning to console and log
7734         file.
7735         (tarx): Fix index used to reset file protection.
7736         (main): Open the log file earlier so that more stuff can be sent to it.
7737
7738 Sat Apr 15 20:05:33 2000  Christopher Faylor <cgf@cygnus.com>
7739
7740         * setup.c (processdirlisting): Make "N" option a little less aggressive.
7741
7742 Fri Apr 14 11:11:29 2000  Christopher Faylor <cgf@cygnus.com>
7743
7744         * setup.c (tarx): Wait to after tar has completed to reset protections
7745         or suffer races with tar process.
7746
7747 Thu Apr 13 12:51:19 2000  Christopher Faylor <cgf@cygnus.com>
7748
7749         * Makefile.in: Eliminate duplicate -nostdinc from CFLAGS.
7750         * setup.c (create_uninstall): Create the uninstall .bat file in the
7751         "root" so that we can remove the /bin directory.  Add bin\cygwin.bat to
7752         list of files to be deleted.  Fix directory detection for determining
7753         when to use 'rmdir'.
7754         (do_start_menu): Add /usr/local/bin to the path.
7755         (main): Add slop to files.array allocation so that we don't have to
7756         worry about reallocating the array when it grows too large when doing
7757         some trivial "pushes".  Add /tmp and /usr/local/{bin,lib} to list of
7758         files.
7759
7760 Thu Apr 13 01:59:44 2000  Christopher Faylor <cgf@cygnus.com>
7761
7762         * setup.c (processdirlisting): Fix handling of "A" for "A"lways
7763         download.
7764
7765 Thu Apr 13 01:11:45 2000  Christopher Faylor <cgf@cygnus.com>
7766
7767         * path.c (kill_cygpath): New cleanup function.
7768         (exit_cygpath): New cleanup function.
7769         (cygpath_pipe): New function.  Sets up cygpath in the background for
7770         translating filenames.
7771         (pathcvt): Use background cygpath for file translation.
7772         * setup.c (tarx): New function.  Called to extract tar files, capture
7773         logging output, and translate it to Windows format.
7774         (recurse_dirs): Use 'tarx' function to extract files.
7775         (create_uninstall): Use file list built up by tarx rather than reading
7776         the log file.
7777         (mkmount): Add ability to mount root.
7778         (main): Track elapsed install time.  Mount root.
7779         * starry.h: Add index field to strarry for tracking of tarx's usage of
7780         this structure.
7781         * xsystem.c (xcreate_process): Return proces handle when not waiting.
7782
7783 Mon Apr 10 22:44:56 2000  Christopher Faylor <cgf@cygnus.com>
7784
7785         * path.c: New file.
7786         (pathfp): New function.  Preliminary work for new -f cygpath
7787         functionality.
7788         * Makefile.in: Add new file.
7789         (pathcvt): Move to new file.
7790         (dtoupath): Ditto.
7791         (utodpath): Ditto.
7792         (pathcat): Ditto.
7793         * setup.c (processdirlisting): Always open file in text mode.
7794         (create_uninstall): Ditto.
7795         (getdownloadsource): Ditto.
7796         (main): Ditto.
7797
7798 Mon Apr 10 20:33:40 2000  Christopher Faylor <cgf@cygnus.com>
7799
7800         * xsystem.c: New file.
7801         * Makefile.in: Accomodate new file.
7802         * setup.c (xsystem): Move to new file.
7803         (recurse_dirs): Accept handle to output log file.  Don't use ">"
7804         redirection to trap tar output.  Use supplied handle instead.
7805         (create_uninstall): Accept FILE pointer to opened log file.  Don't
7806         unlink log file here.
7807         (do_start_menu): Accept FILE pointer to pass to create_uninstall.
7808         (main): Open log file here and pass it to various functions.  Unlink
7809         when done.
7810
7811 Mon Apr 10 17:15:52 2000  Christopher Faylor <cgf@cygnus.com>
7812
7813         Change occurrences of .usr.bin to .bin throughout.
7814         * setup.c (geturl): Increase number of retries to 20.  Let user know
7815         what's going on during long connects.
7816         (processdirlisting): Accept "A"lways and "N"ever as update options.
7817         (create_uninstall): Load cygwin1.dll from the current directory rather
7818         than \bin.
7819         (main): Add some expository text.
7820
7821 Sun Apr  9 20:59:15 2000  Christopher Faylor <cgf@cygnus.com>
7822
7823         * Makefile.in: Change method for compressing cygwin1.dll to avoid
7824         creating a cygwin1.dll in the current directory.  Ensure the addition
7825         of -nostdinc to MINGW_CFLAGS.
7826
7827 Sun Apr  9 02:15:47 2000  Christopher Faylor <cgf@cygnus.com>
7828
7829         * Makefile.in: Augment clean target.
7830
7831 Fri Apr  7 17:04:02  Ron Parker <rdparker@sourceware.cygnus.com>
7832
7833         * README: Added info about non-working mingw implementation
7834         * gzip.exe.gz: Replace with a version from the same build as the other
7835         tools.
7836         * tar.exe.gz: Replace with a version from the same build as the other
7837         tools.
7838         * mount.exe.gz: Add to repository until, mingw can build setup.
7839         * cygpath.exe.gz: ditto
7840         * cygwin1.dll.gz: ditto
7841         * setup.c: Overwrite /bin and /lib mounts.  Generate working shortcut
7842         for Win9x.  Display only a screenfull of options at a time.  Call all
7843         tools with an absolute path.
7844         * setup.dsp: Restore the carriage returns, MS Developer Studio needs
7845         them.
7846         * setup.dsw: ditto
7847         * zlib.dsw: ditto
7848
7849 Thu Apr  6 19:15:27 2000  Christopher Faylor <cgf@cygnus.com>
7850
7851         * Makefile.in: Add "-nostdinc" to regular CFLAGS.  Add target to grab
7852         cygwin1.dll from ../cygwin subdirectory.
7853         * gzip.exe.gz: Update.
7854         * tar.exe.gz: Update.
7855
7856 Wed Apr  5 10:52:08 2000  Christopher Faylor <cgf@cygnus.com>
7857
7858         * Makefile.in: Use ZLIB variable as a target.
7859
7860 Sat Apr  1 22:49:09 2000  Christopher Faylor <cgf@cygnus.com>
7861
7862         * Makefile.in: Eliminate traces of cygwinisms.  Don't link with
7863         libmsvcrt.a.  It's unneeded.  Build .rc file on the fly from various
7864         sources.
7865         * configure.in: Locate correct objcopy.
7866         * configure: Regenerate.
7867
7868 Sat Apr  1 20:48:09 2000  Christopher Faylor <cgf@cygnus.com>
7869
7870         * Makefile.in: New file.
7871         * configure.in: New file.
7872         * configure: New file.
7873         * zlib/Makefile.am: New file.
7874         * zlib/configure.in: New file.
7875         * zlib/aclocal.m4: New file.
7876         * zlib/acinclude.m4: New file.
7877         * zlib/configure: Regenerate from configure.in.
7878         * zlib/Makefile.in: Regenerate from Makefile.am
7879
7880 %%% $Id$
7881 $Revision$