2003-07-27  Robert Collins  <rbtcollins@hotmail.com>

        * PickView.h (PickView::lv): Eliminate.
        * PickView.cc (PickView::init): Replace use of lv with
        GetHWND().
        (PickView::list_click): Ditto.
        * choose.h (ChooserPage::lv): Eliminate.
        * choose.cc: Replace lv with chooser->GetHWND()
        throughout.

2003-07-27  Robert Collins  <rbtcollins@hotmail.com>

* PickView.h (PickView::chooser): Eliminate.
(PickView::list_vscroll): Make non-static.
(PickView::list_hscroll): Ditto.
(PickView::list_click): Ditto.
(PickView::paint): Ditto.
* PickView.cc (PickView::list_vscroll): Eliminate use
of PickView::chooser.
(PickView::list_hscroll): Ditto.
(PickView::list_click): Ditto.
(PickView::paint): Ditto.
* choose.cc (Chooser::createListView): Eliminate use
of PickView::chooser.

2003-07-27  Robert Collins  <rbtcollins@hotmail.com>

* PickView.h (PickView): Inherit from Window.
(PickView::RegisterWindows): Move from ChooserPage.
(PickView::listview_proc): Likewise.
(PickView::paint): Ditto.
(PickView::list_click): Ditto.
(PickView::list_hscroll): Ditto.
(PickView::list_vscroll): Ditto.
(PickView::lv): Ditto.
(PickView::chooser): Ditto.
(PickView::Create): Override Windows::Create as we migrate.
(PickView::registerWindowClass): Renamed RegisterWindows.
(PickView::WindowClassAtom): Prevent double registration.
(PickView::init): Declare.
* PickView.cc: Adjust for new inheritance.
(PickView::RegisterWindows): Move from ChooserPage.
(PickView::listview_proc): Likewise.
(PickView::paint): Ditto.
(PickView::list_click): Ditto.
(PickView::list_hscroll): Ditto.
(PickView::list_vscroll): Ditto.
(PickView::lv): Ditto.
(PickView::chooser): Ditto.
(PickView::Create): Introduce stub.
(PickView::RegisterWindows): Rename
(PickView::init): Extracted from constructor to allow
reordering.
* chooser.h (ChooserPage::registerWindows): Rename to
PickView::RegisterWindows.
(ChooserPage::listview_proc): Likewise.
(ChooserPage::paint): Ditto.
(ChooserPage::list_click): Ditto.
(ChooserPage::list_hscroll): Ditto.
(ChooserPage::list_vscroll): Ditto.
(ChooserPage::lv): Duplicate into PickView, observe
as non-static.
(ChooserPage::chooser): Ditto.
* chooser.cc (ChooserPage::registerWindows): Delete.
(ChooserPage::listview_proc): Ditto.
(ChooserPage::paint): Ditto.
(ChooserPage::list_click): Ditto.
(ChooserPage::list_hscroll): Ditto.
(ChooserPage::list_vscroll): Ditto.
(ChooserPage::createListView): Create() on PickView.
* window.h (Window::RegisterWindowClass): Make virtual
to allow Create to become a Template Method, and rename
to registerWindowClass as it's not static.
* window.cc (Window::registerWindowClass): Ditto.
(Window::FirstWindowProcReflector): BUGFIX: Set window
handle to prevent races with the window procedure.

2003-07-27  Robert Collins  <rbtcollins@hotmail.com>

* choose.cc (set_view_mode): Rename to ChooserPage::setViewMode.
(default_trust): Rename to ChooserPage::defaultTrust.
(fill_missing_category): Rename to ChooserPage::fillMissingCategory.
(set_existence): Rename to ChooserPage::setExistence.
(register_windows): Rename to ChooserPage::registerWindows.
(listview_proc): Rename to ChooserPage::listview_proc.
(paint): Rename to ChooserPage::paint.
(list_click): Rename to ChooserPage::list_click.
(list_hscroll): Rename to ChooserPage::list_hscroll.
(list_vscroll): Rename to ChooserPage::list_vscroll.
(lv): Rename to ChooserPage::lv.
(chooser): Rename to ChooserPage::chooser.
* choose.h (ChooserPage::setViewMode): Declare.
(ChooserPage::defaultTrust): Declare.
(ChooserPage::fillMissingCategory): Declare.
(ChooserPage::setExistence): Declare.
(ChooserPage::registerWindows): Declare.
(ChooserPage::listview_proc): Declare.
(ChooserPage::paint): Declare.
(ChooserPage::list_click): Declare.
(ChooserPage::list_hscroll): Declare.
(ChooserPage::list_vscroll): Declare.
(ChooserPage::lv): Declare.
(ChooserPage::chooser): Declare.

2003-07-27  Robert Collins  <rbtcollins@hotmail.com>

        * choose.cc (create_listview): Use for_each instead of explicit                 iteration.
        (create_listview): Rename to ChooserPage::createListview.
        * package_meta.h (packagemeta::set_requirements): Explicitly separate           the 1 and 2 parameter versions.                                         CVS: ----------------------------------------------------------------------

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

* String++.h (String::operator !=): Declare for char * and String.
* String++.cc (String::operator !=): Implement.
* package_meta.cc(StringConcatenator): Move above all users.
(_visit_if): Predicate support for visitors.
(packagemeta::getReadableCategoryList): Refactor to use
StringConcatenator with a predicate.
* choose.h: Remove unneeded c++ guards.

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

* choose.cc (scan_downloaded_files): Rename to packagemeta::ScanDownloadedFiles.
(scanAVersion): Rename to packageversion::scan.
(GetParentRect): Rename to ChooserPage::getParentRect.
* choose.h (ChooserPage::getParentRect): Declare.
* package_meta.h (packagemeta::ScanDownloadedFiles): Declare.
* package_version.h (packageversion::scan): Declare.
* package_version.cc (packageversion::scan): Move from choose.cc
* package_meta.cc (packagemeta::ScanDownloadedFiles): Move from choose.cc

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

* choose.cc (ChooserPage::OnNext): log before starting activity threads.
(ChooserPage::OnInit): Remove temporary variable frame.
(ChooserPage::setPrompt): Extract method from OnInit.
(choose_inst_text): Remove unused variable.
* choose.h(ChooserPage::setPrompt): Declare
* res.rc (IDD_CHOOSE): Bugfix: the chooser was setting a non-present
caption.

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

Remove package specific code from choose.cc.
Update copyrights where appropriate.
* choose.cc(ChooserPage::OnNext): Extract logging to
packagemeta::logSelectionStatus.
* package_meta.cc(packagemeta::logSelectionStatus): Extract from
ChooserPage::OnNext.
(StringConcatenator): helper for logSelectionStatus.
(action_caption): Make const.
* package_meta.h(packagemeta): Declare logSelectionStatus.
(packagemeta::action_caption): Make const.
* package_version.cc(packageversion::sourcePackage): Make const.
* package_version.h(packageversion::sourcePackage): Make const.

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

* choose.cc: Update copyright.
(ChooserPage::keepClicked): Extracted from OnMessageCmd.
(ChooserPage::changeTrust): Ditto.
* choose.h (ChooserPage): Declare keepClicked and changeTrust.
(ChooserPage::ifChecked): Extracted from OnMessageCmd.
* package_meta.h (SetRequirement): Adapter for visiting package collections.

2003-07-26  Max Bowsher  <maxb@ukf.net>

* tests/.cvsignore: New file, listing Makefile.in.

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

Save used local cache dir from initial run of setup, so the user doesn't
need to retype it.
* localdir.h (LocalDirSetting): UserSetting class for the local cache dir.
* localdir.cc (LocalDirSetting::save): Replace save_local_dir, and update callers.

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

Save used site from initial run of setup, so the user doesn't need to
retype it.
* main.cc (main): Load and save all user settings.
* site.cc (SiteSetting::save): Migrate logic from save_site_url.
(SitePage::OnNext): Use ChosenSites.save() to remove uneeded save_site_url call.
(save_site_url): Delete.
* site.h (save_site_url): Remove declaration.
* .cvsignore: Update autoconf generated files.

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

* tests/Makefile.am: Driver for test suite.
* tests/UserSettingTest.cc: Test UserSetting interface.
* tests/UserSettingsTest.cc: Test UserSettings interface.
* Makefile.am: Add the tests dir to recurse into.
* configure.in: Ditto.
* UserSetting.h: Add load and save methods to allow global serialisation.
Add explicit copy and assignment operators to prevent synthetics.
Make the constructor protected to prevent direct instantiation.
* UserSettings.h (UserSettings::loadAllSettings): New method.
(UserSettings::savedAllSettings): New method.
* UserSettings.cc: Implement new methods.
* site.cc: Implement stubs for new required UserSetting methods.
* site.h (ChosenSite): Ditto.
* Ran automake.

2003-07-26  Robert Collins  <rbtcollins@hotmail.com>

* tests/Makefile.am: Driver for test suite.
* tests/UserSettingTest.cc: Test UserSetting interface.
* tests/UserSettingsTest.cc: Test UserSettings interface.
* Makefile.am: Add the tests dir to recurse into.
* configure.in: Ditto.
* UserSetting.h: Add load and save methods to allow global serialisation.
Add explicit copy and assignment operators to prevent synthetics.
Make the constructor protected to prevent direct instantiation.
* UserSettings.h (UserSettings::loadAllSettings): New method.
(UserSettings::savedAllSettings): New method.
* UserSettings.cc: Implement new methods.
* site.cc: Implement stubs for new required UserSetting methods.
* site.h (ChosenSite): Ditto.
* Ran automake.

2003-07-23  Max Bowsher  <maxb@ukf.net>

* desktop.cc (DesktopSetupPage::OnBack): Remove obsolete use of NEXT().
* root.cc (RootPage::OnNext): Ditto.
(RootPage::OnBack): Ditto.
* install.cc (do_install_thread): Remove obsolete use of next_dialog.
* main.cc (main): Ditto.
* postinstall.cc (do_postinstall_thread): Ditto.

2003-07-23  Max Bowsher  <maxb@ukf.net>

* dialog.h (do_choose, do_desktop, do_local_dir, do_net, do_other)
(do_root, do_site, do_source, do_splash): Remove declarations, since
these functions no longer exist.

2003-07-23  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>

* choose.cc (initialized): Remove obsolete file scope variable.

2003-07-18  Max Bowsher  <maxb@ukf.net>

* res.rc: Make caption of every dialog page begin with "Cygwin Setup".
This aids recognition when minimized.
Prompted by Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>.

2003-07-10  Jeremy White  <jwhite@codeweavers.com>

* mount.cc, root.cc, site.cc:  Make StringOptions required,
thereby making --longopt <parm> behave as a newbie would expect.

2003-07-08  Max Bowsher  <maxb@ukf.net>

* LogFile.h, cistring.h, dialog.h, diskfull.h, filemanip.h, geturl.h,
hash.h, log.h, mkdir.h, mklink2.h, mount.h, msg.h, netio.h, nio-file.h,
nio-ftp.h, nio-http.h, nio-ie5.h, port.h, simpsock.h, state.h,
version.h: Add inclusion guard.
* root.h: Standardize naming of inclusion guard.

2003-06-23  Max Bowsher  <maxb@ukf.net>

* AntiVirus.h, Exception.h, FilterVisitor.h, FindVisitor.h,
IOStreamProvider.h, IniDBBuilder.h, IniDBBuilderPackage.h,
IniParseFeedback.h, IniParseFindVisitor.h, LogSingleton.h, MD5++.h,
PackageSpecification.h, PackageTrust.h, PickCategoryLine.h, PickLine.h,
PickPackageLine.h, PickView.h, RECTWrapper.h, ScanFindVisitor.h,
String++.h, UserSetting.h, UserSettings.h, archive.h, archive_tar.h,
category.h, choose.h, compress.h, compress_bz.h, compress_gz.h,
cygpackage.h, desktop.h, download.h, find.h, ini.h, io_stream.h,
io_stream_cygfile.h, io_stream_file.h, io_stream_memory.h,
io_stream_rsync.h, localdir.h, net.h, package_db.h, package_meta.h,
package_source.h, package_version.h, proppage.h, propsheet.h, script.h,
site.h, source.h, splash.h, threebar.h, win32.h, window.h:
Standardize naming and placement of inclusion guards.

2003-06-22  Benjamin Riefenstahl  <Benjamin.Riefenstahl@epost.de>

* res.rc (all dialogs): Change font from "MS Sans Serif" to
"MS Shell Dlg".

2003-06-22  Max Bowsher  <maxb@ukf.net>

* Makefile.am: Clarify comment.
Derive AM_CFLAGS from AM_CXXFLAGS, rather than the other way around.
(AM_CXXFLAGS): Remove -Wmissing-declarations - it is a C-only warning.
(AM_CFLAGS): Add -Winline, and -Wmissing-declarations.

2003-06-22  Max Bowsher  <maxb@ukf.net>

* rfc1738.cc (rfc1738_do_escape): Eliminate redundant conditional.

2003-06-05  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>

* window.h (SETUP_WINDOW_H): Rename multi-include guard.
(Copyright): Update.
(RECTWrapper): New forward declaration.
(Window::Create): Move.
(Window::MoveWindow): New overload declaration.
* window.cc: (RECTWrapper.h) Include.
(Copyright): Update.
(Window::FirstWindowProcReflector): Use reinterpret_cast<> instead
of C-style casts.
(Window::MoveWindow): New overload.

2003-05-31  Max Bowsher  <maxb@ukf.net>

* res.rc: Resize title controls to fully fill available width.

2003-05-07  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>

* RECTWrapper.h: New file.

update readme

New bug in TODO:

 * Audit rfc1738 code for bad memory/string handling. Example: Crash occurs if
   rfc1738 encoded dirname is truncated in the middle of a %xx sequence.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (Script::extension): Extract method from Script::run.
(Script::run): Extract extension generation to Script::extension.
* script.h (Script::extension): Declare.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (run_script): Remove.
(try_run_script): Inline method run_script.
* script.h (run_script): Remove.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* postinstall.cc (RunScript::operator()): Use new run syntax.
* script.h (Script::run): Eliminate to_log parameter.
* script.cc (Script::run): Ditto.
(run_script): Use new run syntax.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (Script::run): Eliminate temp variable 'f2'.
Rename temp variable 'f2' to 'windowsName' for increased clarity.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (Script::run): Eliminate temp variable 'fname'.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (Script::run): Eliminate temp variable 'dir'.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (run_script): Always pass TRUE to Script::run.
* script.h (run_script): Remove optional to_log parameter.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (run_script): Move functionality into Script.
(Script::run): Absorb run_script.

2003-04-12  Robert Collins  <rbtcollins@hotmail.com>

* PickCategoryLine.cc (PickCategoryLine::click): Tell packagemeta we
are about to perform a visit.
* PickPackageLine.cc (PickPackageLine::click): Tell packagemeta we
are about to perform a visit.
* package_db.cc (packagedb::markUnVisited): Convenience wrapper -
mark all packages as unvisited.
* package_db.h (packagedb::markUnVisited): Declare.
* package_meta.cc (packagemeta::PrepareForVisit): New static method
to prepare for a loop-free visit.
(packagemeta::packagemeta): Adjust for new member.
(packagemeta::set_requirements): Only visit a node once.
(packagemeta::visited): Get and Set methods for new member visited_.
* package_meta.h (packagemeta::PrepareForVisit): Declare.
(packagemeta::visited): Declare.
(packagemeta::visited_): Declare.

2003-04-07  Max Bowsher  <maxb@ukf.net>

* download.cc: Add command line option to suppress MD5 checks.
(validateCachedPackage): Test option and possibly skip.

add bug

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

Merge in setup-200303-troubleshooting fixes.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultDACL): Reinstate commented code.
(NTSecurity::setDefaultSecurity): Ditto.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultDACL): Use MS calculations for ACL
buffer sizing.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultDACL): Sanity check memory allocation.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultDACL): Adjust commented code for auto_ptr use.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::NoteFailedAPI): Helper function.
Use throughout NTSecurity routines.
(NTSecurity::setDefaultDACL): Use dynamic memory for ACL storage.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultDACL): Disable ~ 50% of remaining active code.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::GroupInfo): Extract group query code.
(NTSecurity::setDefaultDACL): Disable ~ 50% of code.

2003-04-02  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultSecurity): Disable ~ 50% of security code.

2003-04-01  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultSecurity): Remove double declaration of sz.
User TokenGroupCollection to abstract token searching logic, eliminate isadmin
and isuser temporary variables.
(TokenGroupCollection): New class for querying token group information.

2003-04-01  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (NTSecurity::setDefaultSecurity): Extract esid initialisation.
Move local variables to just before first use.
SetTokenInformationFailures where being handled inconsistently.
Remove assignments from if statements.
(NTSecurity::esid): Rename to everyOneSID.
(NTSecurity::initialiseEveryOneSID): new method.
(NTSecurity::setDefaultDACL): Extract method for default DACL logic.

2003-04-01  Robert Collins  <rbtcollins@hotmail.com>

* main.cc (SIDWrapper): Manage SID memory.
(HANDLEWrapper): Likewise for HANDLES.
(NTSecurity): Worker class for set_default_sec().
(set_default_sec): Move body into NTSecurity::setDefaultSecurity().
(NTSecurity::setDefaultSecurity): Eliminate goto out: via memory managing objects.

2003-04-01  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>

* cygwin.ico:  Added two new resolutions, 64x64 and 72x72.

2003-03-29  Robert Collins  <rbtcollins@hotmail.com>

* GUIDELINES: New file documenting code guidelines.

2003-03-26  Max Bowsher  <maxb@ukf.net>

* .cvsignore: Add cfgaux.

2003-03-26  Robert Collins  <rbtcollins@hotmail.com>

* package_version.cc (_defaultversion::accessible): Override and make always false.
(_packageversion::accessible): Fix a couple of logic bugs resulting in incorrect trues.
* package_version.h (_packageversion::accessible): Make virtual.

2003-03-25  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

* threebar.h (WM_APP_START_POSTINSTALL): New message.
(WM_APP_POSTINSTALL_THREAD_COMPLETE): New message.
* threebar.cc (ThreeBarProgressPage::OnMessageApp):
Add handling for WM_APP_START_POSTINSTALL and
WM_APP_POSTINSTALL_THREAD_COMPLETE.
* install.cc (do_install_thread): Set next_dialog to
IDD_S_POSTINSTALL.
* desktop.cc (DesktopSetupPage::OnFinish): Move the
do_postinstall call to ThreeBarProgressPage::OnMessageApp.
* script.h (Script::fullName): New member function.
(Script::run): New member function.
(Script::ETCPostinstall): New static member constant.
* script.cc (Script::fullName): Implement.
(Script::run): Implement.
(Script::ETCPostinstall): Define.
(Script::isAScript): Use ETCPostinstall instead of a
hardcoded string constant.
(run): Enable "#if 0"'d code.
* postinstall.cc (Progress): New extern variable.
(RunFindVisitor::visitFile): Add script to vector
instead of running.
(RunFindVisitor::_scripts): New member variable.
(RunScript): New helper class for use in for_each.
(do_postinstall_thread): Rename do_postinstall to.  Add
Progress bar and text setting.  Add package count.
(do_postinstall_reflector): New static function.
(do_postinstall): Rename to do_postinstall_thread.
Create a thread instead.

2003-03-18  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

* script.cc (run): Add file_out parameter.
Redirect output of subprocess to file, creating the
path if necessary.  Minimize the script window.
(run_script): Add optional to_log boolean parameter.
If to_log, redirect output to temporary file and then
import it into LOG_BABBLE.
(OutputLog): New helper class.
(operator<<): New operation on OutputLog.
* script.h (run_script): Add optional to_log parameter.
* postinstall.cc (RunFindVisitor::visitFile): Instruct
run_script() to log script output.
(do_postinstall): Ditto.

2003-03-20  Robert Collins  <rbtcollins@hotmail.com>

* package_meta.cc (packagemeta::set_action): The logic
test for the default action was reversed.

2003-03-19 Robert Collins  <rbtcollins@hotmail.com>

* configure.in: Bump version number.
* Makefile.am: Add DefaultFormatter.h to installed files.
* src/OptionSet.cc (OptionSet::ParameterUsage): Use new
default DefaultFormatter to format parameters.
* include/getopt++/OptionSet.h: Update copyright.
* include/getopt++/DefaultFormatter.h: Format the help from an Option.
* tests/testoption.cc: Include a -h|--help option to test help
formatting.
Insert copyright statement.
* tests/optioniterator.cc: Insert copyright statement.

Remove spurious duplicate files. (Spurios duplicate directories emptied: cvs upd -P advised.)

2003-03-18  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

* postinstall.cc (do_postinstall): Filter out '*.done'.
* FilterVisitor.h: New header file.  Declare the
FilterVisitor, Filter, and ExcludeNameFilter classes.
* FilterVisitor.cc: New file.  Implement FilterVisitor,
Filter, and ExcludeNameFilter.
* String++.h (String::matches): New instance function.
* String++.cc (String::matches): Implement.
(strmatch) Import and adapt for <buf,len> strings.
* Makefile.am (setup_SOURCES): Add FilterVisitor.cc and
FilterVisitor.h to value.

2002-03-18  Max Bowsher  <maxb@ukf.net>

* LogFile.cc (LogFile::exit): Use CRT exit() instead of ExitProcess().
Use passed exit_code even if been_here.
Remove incorrect _CYGWIN_ preprocessor conditional.

2003-03-18  Robert Collins  <rbtcollins@hotmail.com>

* include/getopt++/OptionSet.h (OptionSet): Convert to use a vector.
* src/OptionSet.cc: Convert array to vector use throughout.
(OptionSet::optionsInSet): Implement external access to the available
options.

introduce some linefeeds

2003-03-16  Robert Collins  <rbtcollins@hotmail.com>

* package_db.h (PackageDBConnectedIterator): Typedef for connected loop detection collection iterator.
* package_db.cc (ConnectedLoopDetector): An implementation of R.E. Tarjans strongly connected set visitor algorithm.
* postinstall.cc (do_postinstall): Use the new iterator for visiting postinstall scripts.

2003-03-16  Robert Collins  <rbtcollins@hotmail.com>

* install.cc: Introduce Installer class.
(init_dialog): Rename to Installer::initDialog.
(progress): Rename to Installer::progress.
(standard_dirs): Rename to Installer::StandardDirs.
(uninstall_one): Rename to Installer::uninstallOne.
(replace_one): Rename to Installer::replaceOne.
(log_ror_failure): Rename to Installer::replaceOnRebootFailed.
(log_ror_success): Rename to Installer::replaceOnRebootSucceeded.
(install_one_source): Rename to Installer::installOneSource.
Note script files as they are installed.
* package_version.cc (packageversion::addScript): Implement.
(packageversion::scripts): Implement.
* package_version.h (packageversion::addScript): Record the presence of a script.
* script.h (Script): New class to track scripts.
* postinstall.cc (do_postinstall): Iterate through the package listed scripts before searching for scripts.
* String++.cc (String::substr): Second argument needed to be signed.
* String++.h (String::substr): Second argument needed to be signed.

2003-03-16  Max Bowsher  <maxb@ukf.net>

* .cvsignore: Create, to ignore configure, aclocal.m4, Makefile.in and
autom4te.cache.

2003-03-16  Max Bowsher  <maxb@ukf.net>

* UserSettings.cc (UserSettings::Instance): Remove premature return.

2003-03-15  Robert Collins  <rbtcollins@hotmail.com>

* script.cc (run): Rename variable b to createSucceeded.

2003-03-15  Igor Pechtchanski <pechtcha@cs.nyu.edu>

* script.cc (run): Close unneeded handles.

2003-03-15  Robert Collins  <rbtcollins@hotmail.com>

* configure: Remove.
* aclocal.m4: Remove.
* Makefile.in: Remove.
* cfgaux: Remove.
* cfgaux/compile: Remove.
* cfgaux/config.guess: Remove.
* cfgaux/config.sub: Remove.
* cfgaux/depcomp: Remove.
* cfgaux/install-sh: Remove.
* cfgaux/ltmain.sh: Remove.
* cfgaux/missing: Remove.
* cfgaux/mkinstalldirs: Remove.

Move verified-complete release blockers to the completed section.

2003-03-14  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

* install.cc (replace_one): Clear Text3.

2003-03-14  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

* install.cc (install_one_source): Add logging for successful
replace-on-reboot scheduling. Factor out duplicate code.
Set rebootneeded on Win9x.
(log_ror_failure): New static function.
(log_ror_success): New static function.

2003-03-14  Robert Collins  <rbtcollins@hotmail.com>

* choose.cc (ChooserPage::OnNext): Fix iterator bug. Reported by
Igor Pechtchanski  <pechtcha@cs.nyu.edu>.

Add missing entries recovered from cvs log.

2003-03-13  Max Bowsher  <maxb@ukf.net>

* Update included zlib to 1.1.4.

Tweak timestamps to prevent unneeded rebuild of autotool files.

Merge zlib-1.1.4

This commit was generated by cvs2svn to track changes on a CVS vendor
branch.

Import zlib-1.1.4

Revert accidental loss of end-of-line whitespace from 2000-04-01 commit, to ease merging with upstream sources.

2003-03-13  Robert Collins  <rbtcollins@hotmail.com>

* install.cc (do_install_thread): Use a query method rather than temp variable do_skip.

2003-03-09  Pavel Tsekov  <ptsekov at gmx dot net>

* install.cc (do_install_thread): Use IDS_SKIP_PACKAGE
instead of IDS_CORRUPT_PACKAGE when asking the user to take
action if the hash verification check fails for a source package.
Do not increase the value of 'total_bytes' variable if the
user chooses to skip over a package, which failed the hash
verification.

Regenerate after adding foreign to AUTOMAKE_OPTIONS

Add wishlist item: hold version

2003-03-10  Max Bowsher  <maxb@ukf.net>

* Makefile.am: Add foreign to AUTOMAKE_OPTIONS.

2003-03-10  Robert Collins  <rbtcollins@hotmail.com>

* UserSettings.cc (UserSettings::init): Really initialize all members.

2003-03-10  Robert Collins  <rbtcollins@hotmail.com>

* Exception.h: Add a logic error exception id.
* Makefile.am: Add new sources.
* UserSettings.cc: New file.
* UserSettings.h: New file.
* UserSetting.cc: New file.
* UserSetting.h: New file.
* site.h: Add a SiteSetting as example of a UserSetting.
* site.cc (ChosenSites): Add a instance of SiteSetting to trigger registration.

Update README some more

2003-03-10  Robert Collins  <rbtcollins@hotmail.com>

* compress_bz.cc (compress_bz::read): adjust incorrect assignment of lasterr.
(compress_bz::error): Return lasterr which will indicate any error.

2003-03-10  Robert Collins  <rbtcollins@hotmail.com>

        * choose.h (ChooserPage): Override OnActivate.
* choose.cc (ChooserPage::OnActivate): Refresh the current view when activating the dialog.

Separate out release blocking TODO items

Reformatting, rearranging, 2 items to FIXED, 1 to WISHLIST, one pair of duplicates combined.

2003-03-09  Robert Collins  <rbtcollins@hotmail.com>

* package_version.cc (_defaultversion::pick(bool)): Override this and do nothing.
(packageversion::pick(bool): Use a mutator function rather than direct member access.
* package_version.h (_packageversion::pick(bool)): Move method from _packageversion.

2003-02-16  Pavel Tsekov  <ptsekov@gmx.net>

* install.cc (install_one_source): Remove the MD5 verification
code.
Delay the creation of the package listing file.
(do_install_thread): Check the hashes for packages which need
to be installed before the uninstall step. Allow the user to
skip over packages, which fail the hash verification.
(md5_one): Define new function.
* res.rc (IDS_SKIP_PACKAGE): New string resource.
* resource.h (IDS_SKIP_PACKAG): New macro definition.

2003-02-16  Pavel Tsekov  <ptsekov@gmx.net>

* Exception.h: Declare new constructor.
(Exception::_message): Change the type from 'const char *' to
'class String'.
(Exception::~Exception): Implement destructor (make gcc shut up).
* Exception.cc: Implement new constructor.
(Exception::what): Use String::cstr_oneuse ().
* download.cc (validateCachedPackage): Use the constructor, which
takes String& as its second argument, when throwing objects
of type Exception.
(check_for_cached): Ditto.
* install.cc (install_one_source): Ditto.

2003-02-01  Igor Pechtchanski <pechtcha@cs.nyu.edu>

* res.rc (IDS_INSTALL_INCOMPLETE): Change hard-coded
log filename to %s.
(IDS_MISSING_LOG): New string resource.
* resource.h (IDS_MISSING_LOG): New resource.
* LogFile.cc (LogFile::exit): Pass log filename for
LOG_BABBLE to note().
(LogFile::getFileName): New function.
* LogFile.h (LogFile::getFileName): New function.

ChangeLog:

2003-02-01  Igor Pechtchanski <pechtcha@cs.nyu.edu>

* String++.cc: Don't include concat.h.
* Makefile.am: Remove concat.cc and concat.h references.
* Makefile.in: Regenerate.
* concat.h: Remove.
* concat.cc: Remove.

2003-03-09  Max Bowsher  <maxb@ukf.net>

* bootstrap.sh: Add sanity check of current directory.
Recurse into libgetopt++ if needed.

2003-03-09  Max Bowsher  <maxb@ukf.net>

* bootstrap.sh: Add sanity check of current directory.

2003-03-09  Robert Collins  <rbtcollins@hotmail.com>

       * Update readme of bugs and wishes.

2003-03-05  Max Bowsher  <maxb@ukf.net>

* netio.cc (save_dialog): Allocate an empty string if the password is
null, so that an empty password is accepted elsewhere in setup.
(check_if_enable_ok): An empty password is OK.

2003-03-05  Brian Keener  <bkeener@thesoftwaresource.com>

        * PickView.cc (PickView::views): Add two new views for Skipped
packages and Installed Packages not requiring update.
(PickView::set_headers () ): Ditto.
(PickView::clear_view (void) ): Ditto.
(PickView::views::caption () ): Add two new captions for the new
views added for Skipped and Installed Packages.
(PickView::scroll () ): Modify Scroll Bar property to Disable
        instead of disappearing when there is nothing to Scroll.
* PickView.h: Add two new views for Skipped packages and Installed
packages to public class view.
* choose.cc (list_click () ): Modify Scroll Bar property to Disable
        instead of disappearing when there is nothing to Scroll.
(listview_proc () ): Ditto.
(set_view_mode): Add two new views for Skipped Packages and Installed
Packages not requiring update.  Modify Scroll Bar property to Disable
instead of disappearing when there is nothing to scroll.
* res.rc (IDD_CHOOSE): Reposition Radio Buttons, View Selection
Button and View Button Caption to make room for longer captions.

2003-03-04  Max Bowsher  <maxb@ukf.net>

* compress_gz.cc (compress_gz::construct):
Fix broken checkin dated 2002-07-03.

2003-02-28  Max Bowsher  <maxb@ukf.net>

* main.cc (set_default_sec): Add logging.

2003-02-28  Pierre Humblet  <pierre.humblet@ieee.org>

* main.cc (set_default_dacl): Replace with set_default_sec.
(set_default_sec): Attempt to change the default group to
Users or Administrators if it is None, in addition to setting
Everyone in the default DACL.
(main): Call set_default_sec instead of set_default_dacl.

2003-01-31  Max Bowsher  <maxb@ukf.net>

* install.cc (install_one_source): Fix spacing in log message.

2003-01-19  Max Bowsher  <maxb@ukf.net>

* resource.h (IDC_CHOOSE_KEEP): Define.
* res.rc (IDD_CHOOSE): Add radio button IDC_CHOOSE_KEEP.
* choose.cc (create_listview): Add IDC_CHOOSE_KEEP to ta[].
(ChooserPage::OnMessageCmd): Handle new IDC_CHOOSE_KEEP button.

2003-01-15  Max Bowsher  <maxb@ukf.net>

* mkdir.cc [_CYGWIN_]: Implement what was pseudocode.
* io_stream.h [__CYGWIN__]: Don't typedef ssize_t.
* proppage.h: Include "win32.h" instead of <windows.h>.

2003-01-15  Max Bowsher  <maxb@ukf.net>

* mount.cc [MAINTAINER_FEATURES]: Add --override-registry-name option.

Fix indentation