From f480a7df426ab3d3e2f83b7322ef37ba2ab201de Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Mon, 1 Aug 2016 13:43:34 +0100 Subject: [PATCH] Remove obsolete installed_from member from packagemeta This just stores a made-up tarfile name read from installed.db, and is never used. --- package_db.cc | 2 +- package_meta.cc | 2 +- package_meta.h | 11 ++--------- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/package_db.cc b/package_db.cc index 73dfbf60..87da9226 100644 --- a/package_db.cc +++ b/package_db.cc @@ -96,7 +96,7 @@ packagedb::packagedb () packagemeta *pkg = findBinary (PackageSpecification(pkgname)); if (!pkg) { - pkg = new packagemeta (pkgname, inst); + pkg = new packagemeta (pkgname); packages.insert (packagedb::packagecollection::value_type(pkgname, pkg)); /* we should install a new handler then not check this... */ diff --git a/package_meta.cc b/package_meta.cc index 34ff78c9..21b21efe 100644 --- a/package_meta.cc +++ b/package_meta.cc @@ -91,7 +91,7 @@ packagemeta::_actions::caption () } packagemeta::packagemeta (packagemeta const &rhs) : - name (rhs.name), key (rhs.name), installed_from (), + name (rhs.name), key (rhs.name), categories (rhs.categories), versions (rhs.versions), installed (rhs.installed), prev (rhs.prev), curr (rhs.curr), diff --git a/package_meta.h b/package_meta.h index b24d4fc1..3d6ccd29 100644 --- a/package_meta.h +++ b/package_meta.h @@ -35,17 +35,11 @@ public: static void ScanDownloadedFiles (bool); packagemeta (packagemeta const &); packagemeta (const std::string& pkgname) - : name (pkgname), key(pkgname), installed_from (), user_picked (false), + : name (pkgname), key(pkgname), user_picked (false), architecture (), priority(), visited_(false) { } - packagemeta (const std::string& pkgname, const std::string& installedfrom) - : name (pkgname), key(pkgname), installed_from (installedfrom), - user_picked (false), architecture (), priority(), visited_(false) - { - } - ~packagemeta (); void add_version (packageversion &); @@ -118,8 +112,7 @@ public: std::string name; /* package name, like "cygwin" */ std::string key; - /* legacy variable used to output data for installed.db versions <= 2 */ - std::string installed_from; + /* true if package was selected on command-line. */ bool isManuallyWanted() const; /* true if package was deleted on command-line. */ -- 2.43.5