[Patch, Arm, Readelf] Support for a new pacbti unwind opcode.

Tejas Belagod Tejas.Belagod@arm.com
Tue Nov 2 12:13:53 GMT 2021



> -----Original Message-----
> From: Alan Modra <amodra@gmail.com>
> Sent: Sunday, October 31, 2021 2:51 AM
> To: Tejas Belagod <Tejas.Belagod@arm.com>
> Cc: binutils@sourceware.org; Richard Earnshaw
> <Richard.Earnshaw@arm.com>
> Subject: Re: [Patch, Arm, Readelf] Support for a new pacbti unwind opcode.
> 
> On Fri, Oct 29, 2021 at 02:50:02PM +0000, Tejas Belagod wrote:
> >
> >
> > > -----Original Message-----
> > > From: Alan Modra <amodra@gmail.com>
> > > Sent: Friday, October 29, 2021 11:09 AM
> > > To: Tejas Belagod <Tejas.Belagod@arm.com>
> > > Cc: binutils@sourceware.org; Richard Earnshaw
> > > <Richard.Earnshaw@arm.com>
> > > Subject: Re: [Patch, Arm, Readelf] Support for a new pacbti unwind
> opcode.
> > >
> > > On Thu, Oct 28, 2021 at 02:41:57PM +0000, Tejas Belagod via Binutils
> wrote:
> > > > Ping
> > > >
> > >
> > > Applied.  Would you mind having a look at this fail?
> > >
> > > armeb-linuxeabi  +FAIL: Unwind information for Armv8.1-M.Mainline
> > > PACBTI extension
> > >
> >
> > gas/testsuite/arm/unwind-pacbti-m.d only tests for Little-Endian targets.
> > Disable it for Big-Endian targets.
> 
> Is there a reason the test should not run for BE?  How about this instead?
> 
> 	* testsuite/gas/arm/unwind-pacbti-m.d: Match armeb output.
> 
> diff --git a/gas/testsuite/gas/arm/unwind-pacbti-m.d
> b/gas/testsuite/gas/arm/unwind-pacbti-m.d
> index 584b12037b3..28021758a74 100644
> --- a/gas/testsuite/gas/arm/unwind-pacbti-m.d
> +++ b/gas/testsuite/gas/arm/unwind-pacbti-m.d
> @@ -14,10 +14,10 @@ OFFSET   TYPE              VALUE
> 
> 
>  Contents of section .text:
> - 0000 10b54df8 04cd5df8 04cb10bd  .*
> + 0000 (10b54df8 04cd5df8 04cb10bd|b510f84d cd04f85d cb04bd10)  .*
>  Contents of section .ARM.exidx:
> - 0000 00000000 b0a8b480  .*
> + 0000 00000000 (b0a8b480|80b4a8b0)  .*
>  Contents of section .ARM.attributes:
> - 0000 41290000 00616561 62690001 1f000000  .*
> + 0000 41(290000 00|000000 29)616561 62690001 (1f000000|0000001f)  .*
>   0010 05382e31 2d4d2e4d 41494e00 0615074d  .*
>   0020 09033202 34024a01 4c01               .*
> 

Thanks for the reviews and suggestions. Attached is the patch with review comments incorporated.

gas/testsuite/arm/unwind-pacbti-m.d presently only tests for Little-Endian
targets.  Add support for testing Big-Endian targets.

2021-11-02  Tejas Belagod  <tbelagod@arm.com>

	* testsuite/gas/arm/unwind-pacbti-m.d: Add armeb tests.

Regression tested on armeb-linuxeabi, armeb-none-elf, arm-eabi.  OK for master?

Thanks,
Tejas.

> 
> --
> Alan Modra
> Australia Development Lab, IBM
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pacbti-m-eleb.txt
URL: <https://sourceware.org/pipermail/binutils/attachments/20211102/b1b9aa00/attachment.txt>


More information about the Binutils mailing list