[PATCH v1 1/2] LoongArch: Fix pcaddi format string

Xi Ruoyao xry111@xry111.site
Wed Aug 9 11:48:18 GMT 2023


On Wed, 2023-08-09 at 19:37 +0800, Xi Ruoyao wrote:

> > -  { 0x18000000, 0xfe000000,    "pcaddi",       "r0:5,s5:20",                   0,                      0,      0,      0 },
> > +  { 0x18000000, 0xfe000000,    "pcaddi",       "r0:5,s5:20<<2",                0,                      0,      0,      0 },
> 
> The Linux kernel already uses things like "pcaddi t0, 4".  To me this
> change will break them completely, and fixing it on the kernel side will
> be difficult (we'll need to create some nasty gas version check).
> 
> So I don't think we should make such a backward incompatible change
> without a very compelling reason.  You may argue that "<<2" has a better
> readability, but if we really need the readability we can write
> 
> pcaddi t0, 4 # << 2
> 
> in the code anyway.

CC some kernel developers.

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University


More information about the Binutils mailing list