PR30715, VAX: md_create_long_jump

[Maciej W. Rozycki]

On Sat, 12 Aug 2023, Alan Modra via Binutils wrote:

> >From Kalvis Duckmanton
> 
> 	PR 30715

 It would be good having a change description here.

> diff --git a/gas/config/tc-vax.c b/gas/config/tc-vax.c
> index 50adf532a15..d1a2998cdf5 100644
> --- a/gas/config/tc-vax.c
> +++ b/gas/config/tc-vax.c
> @@ -2178,18 +2178,19 @@ md_create_short_jump (char *ptr,
>  
>  void
>  md_create_long_jump (char *ptr,
> -		     addressT from_addr ATTRIBUTE_UNUSED,
> +		     addressT from_addr,
>  		     addressT to_addr,
> -		     fragS *frag,
> -		     symbolS *to_symbol)
> +		     fragS *frag ATTRIBUTE_UNUSED,
> +		     symbolS *to_symbol ATTRIBUTE_UNUSED)
>  {
>    valueT offset;
>  
> -  offset = to_addr - S_GET_VALUE (to_symbol);
> -  *ptr++ = VAX_JMP;		/* Arbitrary jump.  */
> -  *ptr++ = VAX_ABSOLUTE_MODE;
> +  /* account for 1 byte instruction, 1 byte of address specifier and
> +     4 bytes of offset from PC */

 This doesn't follow the GNU Coding Standards.

  Maciej