[PATCH v4 7/7] MIPS: Fix Irix gas testcases

Jan Beulich jbeulich@suse.com
Tue Aug 15 06:13:16 GMT 2023


On 15.08.2023 06:40, YunQiang Su wrote:
> YunQiang Su <yunqiang.su@cipunited.com> 于2023年6月16日周五 14:41写道:
>>
>> 1. Add -mpdr to some cases.
>>    Gas doesn't generate .pdr section for Irix objects by default.  See
>>    `int mips_flag_pdr` in tc-mips.c.
>>
>> 2. Add irix-no-pdr.d.
>>
>> 3. Add and use call-nonpic-1-irix.d for Irix targets.
>>    Gas doesn't set O32 flags for Irix objects in e_flags.  See
>>    `use_e_mips_abi_o32` in gas/configure.ac.
>>
>> 4. Add mips16-e-irix.d: g1 is marked as O on Irix.
>>    The Irix 5 and 6 assemblers set the type of any common symbol and
>>    any undefined non-function symbol to STT_OBJECT.
>>    See `mips_frob_symbol` in tc-mips.c.
> 
> @Maciej W. Rozycki ping.

>From what I can tell, you've addressed all of Maciej's comments on v1.
On that basis this patch is provisionally approved in case he or
Chenghua don't respond within another two weeks time. Btw., it often
helps to send pings To: the person(s) pinged, not just Cc-ing them.

Jan


More information about the Binutils mailing list