This is the mail archive of the
mailing list for the Cygwin project.
On Wed, Nov 22, 2000 at 04:15:48PM -0500, Charles Wilson wrote:
>Carlos Puig wrote:
>> Note: One small patch is needed to make texinfo-4.0 under cygwin. On line 106
>> of the generated makeinfo/Makefile, add -DWIN32 as follows:
>> DEFS = -DHAVE_CONFIG_H -I. -I$(srcdir) -I..
>> DEFS = -DWIN32 -DHAVE_CONFIG_H -I. -I$(srcdir) -I..
>AArrrrggghhh!!! No. Don't rely on -DWIN32 -- it often turns on too
>many windows specific hacks, and leads to huge troubles later on.
>Cygwin is not windows. What you should do, is inspect every .h and .c
>file, looking for '#ifdef WIN32'. If the block of code 'turned on' by
>the WIN32 flag is truly necessary on cygwin, then change the '#ifdef
> #if defined(WIN32) || defined(__CYGWIN__)
>If the block of code 'turned on' by the WIN32 flag is NOT needed on
>cygwin, then change the '#ifdef WIN32'
> #if defined(WIN32) && !defined(__CYGWIN__)
Right. I would welcome a texinfo update but, if anything it should use
-mno-win32 as an option to avoid Win32'isms.
Do we have a FAQ entry on what it takes to contribute a package? It's
not that hard but this question keeps coming up.