This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: whats left before releasing setup?

On Tue, 2001-11-06 at 23:32, Earnie Boyd wrote:
> Robert Collins wrote:
> > The setup.ini should now be ok,
> > the source discussion, IMO can be done separately from releasing
> > setup.exe.
> If a release includes your changes to the Download Only dialogue
> presenting the setup Cygwin root directory dialogue then I don't think
> it's ready.  This shouldn't happen.  The mail list will complain.  I'm
> only downloading the packages not setting up Cygwin.  I don't want the
> registry infected with Cygwin entries by setup.exe if I'm only
> downloading packages.

I'll happily accept a patch to not write the last-cache file for
download only installs. That combined with an alteration to cygpath I've
prepared to return NULL on failure should allow the cache read routine
to fail safely too. (with a check for NULL of course :]).


This is the patch for

RCS file: /cvs/src/src/winsup/cinstall/,v
retrieving revision 2.6
diff -u -p -r2.6
---	2001/10/31 13:15:05	2.6
+++	2001/11/06 12:44:19
@@ -444,8 +444,11 @@ cygpath (const char *s, ...)
       match = m;
+  if (!match)
+      return NULL;
   char *native;
-  if (max_len == strlen (path))
+  if (max_len == (int) strlen (path))
     native = strdup (match->native);
     native = concat (match->native, "/", path + max_len, NULL);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]