This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [Patch] setup.exe - no skip/keep option buggyness

>----- Original Message -----
>From: "Gareth Pearce" <>
> >
> > hmm I hope you tested my patch, because although I tested it with no
>I did. It seemed fine.
> > problems, if your original patch didnt work - I wouldnt be supprised
> > mine fails for the same reasons...
>Yours works because the state _SKIP is already handled. There is no
>state for 'keep' - just states for PREV/CURR/TEST && a test for those
>being the current installed version.

ahh okay I can see that ...
ugly hack forming in my head which says that since the package cant be 
SAME_PREV SAME_CUR or SAME_TEST - and since SAME_* are just a keep, it could 
be made SAME_TEST without repercussions to the outside world ... and with 
slightly better logic then my UI hack below ... still they are both hacks 
... and a nice clean fix would be nice ...

> > this was what I meant about not knowing
> > why it worked... I also thought being set to unknown should break my
> > ... but only realised that after having tested it and having had it
>work jut
> > fine...
>Have you done much work with FSM's? set_action() is a fairly typically
>FSM transition function.

I know about DFA's which the equivelent pretty much.  and I didnt see 
anywhere that there was a transition to ACTION_SAME - but I didnt look at 
your original patch very closely.

> > if you want it to say keep instead of skip ... under the way my patch
> > works...
>Yes, for the UI that will work, but the internal logic still needs to be
>straightened out. Keeping the gui unfixed will act as a reminder :} .
>Thoughts anyone? For the post-category release I'm hoping to have had a
>chance to do something on this, so that the impact shouldn't be huge.

half a thought above...
> > would submit a patch, but NTFS on win2k being read only mounted is
> > me arround... and I couldnt test it here in debian anyway...
>You might try plex86, I'm intending to use that for testing, if I can
>ever get it to work.

I used to use VMWare ... but free trials run out of time ... annoying 
is plex86 free? I guess I could go find out...
> > cyg-apps for setup/winsup directory stuff? hmmm thought I read
> > that was not right... anyway ... I can do that :P
> > and cautious is a not wanting to tred on toes just yet :P I am sure
> > will change after patch 3 or 4 ... :P
>Oh, don't worry about my toes, on public lists I tend to wear steel caps
steel caps wont survive dynamite...
but I think I can keep from doing that much damage without too much trouble.


Get your FREE download of MSN Explorer at

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]