RE: User URLs in setup.exe

["Robert Collins" <robert dot collins at syncretize dot net>]

> -----Original Message-----
> From: cygwin-apps-owner@cygwin.com 
> [mailto:cygwin-apps-owner@cygwin.com] On Behalf Of John Marshall
> Sent: Thursday, 27 June 2002 4:22 AM

> I'm not sure what the right fix is.  I think probably #2 
> above is right
> (because if http://example.com appears twice in the list but the full
> URLs behind them are different... that's confusing), but #1 and #3 are
> wrong.  I suspect displayed_url for an URL that you type in yourself
> should be the full thing you typed, so that you can see it.  (And then
> #3 would no longer be an issue.)
> 
> If others agree (and want me to back my words with actions :-)), I'll
> send a patch to do this.
 
I always like patches. As for the right thing, how does this sound:
For all urls (i.e. no special cases);
Show one of: 
* a friendly path provided in the mirrors.lst or last-mirror files.
* the entire path

And:
* Use a pop-up box to show the entire path for -every- mirror.
* And generate the unique key based on the entire path not the display
path. 
 
> There is also the question of whether setup User URLs should be
> susceptible to trailing slashes and spaces.  Here's a (ugly and
> untested) patch that strips trailing spaces:

I think this is the wrong thing to do. Us users shouldn't need to
understand url encoding, which is why trailing '/'s and spaces are
currently preserved. (because http://foo.com/cygwin//setup.ini is a
valid URL different from http://foo.com/cygwin/setup.ini).
 
> If that turned out not to be a good idea, it might be worth making the
> spaces visible in the error message, e.g. like this:

Thanks, I'm checking these two changes in.

Rob