This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Fri, 2002-10-18 at 00:02, Igor Pechtchanski wrote: > I changed the subject line to something more appropriate and resent to the > (hopefully) correct list. > Igor Ok, some feedback. Firstly, does this all work happily on win95? With both .bat and .sh scripts? Secondly, please don't pass around char * parameters with new functions. You should pass around the String until you have to pass it to an OS call. Thirdly, could you break up the code a little more? The log file initialisation logic should live in a separate member function, with something like' if (l.size()) prepareForLogging(&LOGHANDLE,...); Rob -- --- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. ---
Attachment:
signature.asc
Description: This is a digitally signed message part
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |