Re: [setup and gcc3] Revised patches - now with ChangeLog!

[Jason Tishler <jason at tishler dot net>]

--vOmOzSkFvhd7u8Ms
Content-Type: multipart/mixed; boundary="XOIedfhf+7KOe/yw"
Content-Disposition: inline


--XOIedfhf+7KOe/yw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Max,

On Mon, Nov 04, 2002 at 05:29:08PM -0000, Max Bowsher wrote:
> >> # fix-gcc3-dodgy-NULL-streambuf.patch
> >>  * LogSingleton.cc (LogSingleton::LogSingleton): Initialize the
> >>  parent ostream with a NULL streambuf pointer. Legal? I don't know,
> >>  but I think it used to be done implicitly, but libstdc++-v3 no
> >>  longer allows that.
> >
> > Someone (for now, not I), needs to read the ostream g++-3 template
> > to see what is done with the streambuf pointer before I'll accept
> > this.
>=20
> Well, maybe when you "*very* soon review / parallel implement a gcc 3
> update to setup" you can do this :-) Seriously, I don't have the
> experience with templates to go wading around in the libstdc++
> internals.  In the meantime, can it be used as an interim kludge to
> allow the rest of my updates to be reviewed?

What about the attached?  Note that I only tested setup.exe under Cygwin
gcc 2.95.3-5 but I also tried something similar under Linux gcc 3.x.

Jason

--=20
GPG key available on key servers or http://www.tishler.net/jason/gpg.txt

--XOIedfhf+7KOe/yw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="LogSingleton.cc.diff"
Content-Transfer-Encoding: quoted-printable

Index: LogSingleton.cc
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/cygwin-apps/setup/LogSingleton.cc,v
retrieving revision 2.1
diff -u -p -r2.1 LogSingleton.cc
--- LogSingleton.cc	4 May 2002 12:15:55 -0000	2.1
+++ LogSingleton.cc	4 Nov 2002 19:37:38 -0000
@@ -30,7 +30,7 @@ ostream& endLog(ostream& outs)
=20
 LogSingleton * LogSingleton::theInstance(0);
=20
-LogSingleton::LogSingleton(){}
+LogSingleton::LogSingleton() : ostream(rdbuf()){}
 LogSingleton::~LogSingleton(){}
=20
 LogSingleton &

--XOIedfhf+7KOe/yw--

--vOmOzSkFvhd7u8Ms
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (Cygwin32)

iD8DBQE9xs6fGv3kzOz0jvYRAuqlAJ4mfHXQ+dvNMBiC6u+gg+BnjMOCQgCfcsK8
UN167lUK1J8Z55v8or/LPCc=
=pVt4
-----END PGP SIGNATURE-----

--vOmOzSkFvhd7u8Ms--