This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Approval?] Revert whitespace-only 20000401 change to setup/zlib


On Mon, 10 Mar 2003, Robert Collins wrote:

> On Mon, 2003-03-10 at 21:30, Max Bowsher wrote:
> > On 20000401, there was a commit to setup/zlib, log message "Eliminate \r
> > in line endings."
> >
> > I hypothesize that the repository files might have been d2u-ed at some
> > point, because there are *no* \r's in any revision.
> >
> > This change also stripped whitespace at the end of lines across many
> > files. I'd like to revert it, so that the merge of zlib 1.1.4 doesn't
> > generate huge amounts of conflicts.
> >
> > NB: I have verified this will NOT introduce \r characters into the files.
>
> MM, it would be easier for you to use patch -l :].

1) patch won't be involved in the process at all

2) I think gratuitous whitespace changes from upstream sources are bad

So, can I revert?

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]