Re: Pending packages status (10 Mar 2003)

["Max Bowsher" <maxb at ukf dot net>]

Volker Quetschke wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi!
>
>>>> 1. grace
>>>>
>>>> date   : 25 Nov 2002
>>>> version: 5.1.12-1
>>>> status : updated package available for review
>>>> notes  : http://www.cygwin.com/ml/cygwin-apps/2002-11/msg00322.html
>>>> reviews: http://www.cygwin.com/ml/cygwin-apps/2003-03/msg00254.html
>>>> votes  : 2 (Lapo and Robert)
>>>> url    : http://www.scytek.de/cygwin/grace-5.1.12-1.tar.bz2
>>>>         http://www.scytek.de/cygwin/grace-5.1.12-1-src.tar.bz2
>>>>         http://www.scytek.de/cygwin/setup.hint
>>>
>>> Max did a review in:
>>> ~ <http://cygwin.com/ml/cygwin-apps/2003-03/msg00267.html>
>>>
>>> and all proposed changes are applied to the packages at the url
>>> mentioned above.
>>
>> OK, I've completed the review I began there. I have the following
>> notes:
>>
>> - The warning about gracerc and gracerc.user being overwritten on
>> reinstall is in the README. I'm not sure very many people will read
>> that. I suggest putting it in the comments actually in the files
>> themselves.
>
> Good idea, done!.

Actually, now Earnie mentions it, someone *might* want to have all-users
configuration.

Better do the "install .default files, and copy into place iff not already
in existance" thing.

>> - You could do change doc to /usr/grace/doc in the README file. This
>> would make it more clear to grace newbies where to find the installed
>> documentation.
>
> I forgot that the README gets copied to /usr/doc/grace-5.1.12/ , its
> original place is /usr/grace/. I will patch /usr/grace/doc into this
> file. Done!

You got one occurrence, but missed the other. 'doc/FAQ.html' should become
'/usr/grace/doc/FAQ.html'

Max.