This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, 19 Mar 2003, Igor Pechtchanski wrote: > This is a preliminary patch that runs postinstall scripts in a thread and > updates the progress bars accordingly. Some parts of it are pretty raw, > and I've hacked up some stuff using existing functionality, as I didn't > want to change some class interfaces. It works, but is open to design > suggestions. I would especially like feedback from people who grok the > PropSheet sequencing code. > Igor > ============================================================================== > ChangeLog: > 2003-03-19 Igor Pechtchanski <pechtcha at cs dot nyu dot edu> > > * threebar.h (WM_APP_START_POSTINSTALL): New message. > (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message. > * threebar.cc (ThreeBarProgressPage::OnMessageApp): > Add handling for WM_APP_START_POSTINSTALL and > WM_APP_POSTINSTALL_THREAD_COMPLETE. > * install.cc (do_install_reflector): Add message > parameter. > (do_install_thread): Remove next_dialog. > * desktop.cc (DesktopSetupPage::OnFinish): Move the > do_postinstall call to ThreeBarProgressPage::OnMessageApp. > * postinstall.cc (Progress): New extern variable. > (numscr,s): New static variables. > (RunFindVisitor::visitFile): Add Progress bar and text > setting. > (CountFindVisitor): New class. > (do_postinstall_thread): Rename do_postinstall to. Add > Progress bar and text setting. Add package count. > (do_postinstall_reflector): New static function. > (do_postinstall): Rename to do_postinstall_thread. > Create a thread instead. Same as above, but regenerated against HEAD. ChangeLog is the same. The only thing about this patch that really makes me uncomfortable is having to run through iterators/FindVisitors twice. Any suggestions for improvement are welcome. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha at cs dot nyu dot edu ZZZzz /,`.-'`' -. ;-;;,_ igor at watson dot ibm dot com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk! -- /usr/games/fortune
Attachment:
setup-postinstall-thread.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |