This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Homogenizing include guards - and copyright comments


Max Bowsher wrote:

OK, I've committed the bulk of these changes - that is, all files which have
both and inclusion guard and a standard-form copyright comment.

Here are some comments on the remainder:

md5.h rfc1738.h: Imported from elsewhere, so I'm not changing them.

Cool.


resource.h: Special case - not changing.

Fine.


LogFile.h cistring.h dialog.h diskfull.h filemanip.h geturl.h hash.h log.h
mkdir.h mount.h msg.h netio.h nio-file.h nio-ftp.h nio-http.h nio-ie5.h
port.h simpsock.h state.h version.h: No include guard.

Please add.


root.h: No copyright comment.

Grep CVS annotate for a list of editors && || the Changelog for the file name. (If we are going to put a list of copyrights in, it should be correct:})


mklink2.h: Neither copyright comment, nor include guard.

Ditto.


I propose to add include guards and copyright comments as mentioned above.


Thanks again, please see above for my suggestions.


Rob




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]