This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] next_dialog micropatch (2)


On Tue, 2003-07-29 at 20:13, Max Bowsher wrote:

> I.e., I'm working on the "global variable" ugliness, not the "returns
> program flow decisions" ugliness. The fact that I am solving the former
> should not compel me to solve the latter simultaneously.
> <cheeky>After all, patches should be modular, and as small as possible!
> :-)</cheeky>

Yes they should be... but they should also all move in the same
direction, not simply shuffle the work around. As you can see from the
example, it is possible with only a touch of extra work to cleanup the
globals without making more work to be tackled later.

Anyway, this one is done to death.. next!

Rob

-- 
GPG key available at: http://members.aardvark.net.au/lifeless/keys.txt.
---

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]