This is the mail archive of the
mailing list for the Cygwin project.
Re: [setup PATCH] Rework do_ini [next_dialog removal (2a)]
Robert Collins wrote:
> On Tue, 2003-07-29 at 23:40, Max Bowsher wrote:
>> Let's see if this approach is more satisfactory...
> We're getting close.
> However, you introduce a regression: currently alocal dir ini failure
> should just bounce em back to the previous screen IIRC, not exit.
First the particular failiure here is that do_local_ini can't find any ini
to parse. BUT do_local_ini will not be called unless do_fromcwd determines
that a setup.ini exists.
This is just as well, since currently if IDD_S_LOAD_INI does got posted back
to threebar.cc, setup hangs on the progress page, since do_fromcwd does not
do what the code in threebar.cc seems to believe it does.
So, I'm adding an exit in a very narrow edge case (and the exit is
implicitly a "FIXME: Use an Exception").