This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH] Incidental setup.exe patches #2: Fix chooser vertical scroll bar.
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Tue, 13 Apr 2010 09:55:55 +0200
- Subject: Re: [PATCH] Incidental setup.exe patches #2: Fix chooser vertical scroll bar.
- References: <4BC397B7.email@example.com>
- Reply-to: cygwin-apps at cygwin dot com
On Apr 12 22:59, Dave Korn wrote:
> Here's another one I noticed: the vertical scroll bar doesn't get adjusted
> when you resize the chooser vertically. It does get reproportioned correctly
> when you click anywhere in the chooser (or change mode or do anything that
> triggers a full redraw), and this patch factors out the code to adjust it into
> a routine that can be called from both clicks and resize operations. While
> it's doing that, it clears up a bit of naming confusion where variables with
> names relating to "ClientRect" are used to store details that are actually
> those returned from GetWindowRect(); I figured that would look doubly
> confusing when I went and introduced an actual GetClientRect() call in the
> same area if I didn't clean it up.
> * PickView.h (PickView::set_vscroll_info): Add prototype.
> (PickView::hasClientRect): Rename from this ...
> (PickView::hasWindowRect): ... to this ...
> (PickView::lastClientRect): ... and from this ...
> (PickView::lastWindowRect): ... to this.
> * PickView.cc (PickView::PickView): Adjust member init to match.
> (PickView::set_vscroll_info): Abstract code to set vertical scroll
> bar proportions from ...
> (PickView::list_click): ... here. Call it. Fix comment typo.
> (PickView::WindowProc): Update all renamed variables in WM_SIZE
> case, and check also for a y delta, calling set_vscroll_info if so.
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com