This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

On Apr 14 18:17, Dave Korn wrote:
> On 14/04/2010 15:41, Dave Korn wrote:
> >   I'll rewrite the comments now I know exactly what's going on and resend it
> > later.
>   Here:
> 	* (RootPage::OnNext): Don't construct a packagedb here nor
> 	do deferred initialisation of static packagedb::task.
> 	* (save_dialog): Don't construct a packagedb here, and
> 	set static packagedb::task directly instead of chosen_db_task.
> 	* (packagemeta::action_caption): Don't bother to
> 	construct a packagedb here, just access packagedb::task directly.
> 	* Move 'static members' comment near static members.
> 	(chosen_db_task): Delete.
> 	* package_db.h (chosen_db_task): Don't declare extern.
> 	(packagedb): Extend comments on class.
>   OK now?

I think so, yes.  Thank you.

Here's a question.  Do you have any idea how much work it would be to
convert the packagedb singleton into an ordinary class with an ordinary
class member which could be constructed and deconstructed at will?  For
instance, if somebody presses "Next" up to the chooser dialog and then
presses "Back" up to the root dir dialog, just to choose another root


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]