This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rebase] Fix build problems in imagehelper


On 6/20/2011 2:52 PM, Corinna Vinschen wrote:
>> Perhaps we should consider using GPLv3+ at this point?  Can we contact
>> Ralf Habacker for permission, with regards to libimagehelp?
> 
> I agree, GPLv3+ would be preferrable.

This can wait until later -- e.g. after we hear back from Ralf.
Besides, it's better to this all at one time (e.g. replace COPYING,
update all the preambles in each source file, etc) as a single-purpose
patch.

> PATH_MAX = 4K should be enough.  I'm not even sure it's really
> necessary.  DLL paths referenced in the PEB can't be longer than
> MAX_PATH, it seems.  But a global static buffer is ok, too.

Ack.

I've committed all of my changes, including some cleanups like d2u
conversion.  Everything should be copacetic now, but I'm afraid it
probably means a lot of your patches need to be redone. :-(

I've tested the build on cygwin (native) but not msys (native) or mingw
(native).  However, it worked in the past, so...

Also, I'm not sure what support I built in last year for cross builds,
but at least this version is no *worse* in that regards than prior to my
patch.

However, I have not implemented the changes (*) you requested; if you
want to do those, great, but otherwise I'll address them in the next day
or two.

(*) cygwin_conv_path vs. cygwin_create_path
    CreateFileW vs. CreateFile

--
Chuck


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]