This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix a cosmetic problem when there are no packages to install

From: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
To: cygwin-apps at cygwin dot com
Date: Mon, 25 Jul 2011 15:45:28 +0100
Subject: Re: [PATCH] Fix a cosmetic problem when there are no packages to install
References: <20110424161351.GC23944@ednor.casa.cgf.cx> <1311339756-504-1-git-send-email-jon.turney@dronecode.org.uk> <20110722141216.GG15150@calimero.vinschen.de>

On 22/07/2011 15:12, Corinna Vinschen wrote:

On Jul 22 14:02, Jon TURNEY wrote:

My previous patch introduces a cosmetic problem when there are no packages
to install.

Calling ThreeBarProgressPage::SetBar2(0, 0) indicates we are -2147483648%
done, while we iterate over all packages looking for packages to md5sum.

So avoid calling SetBar2() in that case.

2011-07-21 Jon TURNEY<jon.turney-GrJqePx9RPPAJUdA+FbntA@public.gmane.org>

	* install.cc (do_install_thread): Fix cosmetic problem when
	there are no packages to install.


Go ahead.  Just change your ChangeLog entry to something more
descriptive, like, say, "Only set progress bar output if at least
one package gets installed."

Done, with that correction.

References:
- [PATCH] Fix a cosmetic problem when there are no packages to install
  - From: Jon TURNEY
- Re: [PATCH] Fix a cosmetic problem when there are no packages to install
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]