This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: x86/ -> ./ symlink


On Jul  1 19:05, Achim Gratz wrote:
> Corinna Vinschen writes:
> > +  if (--level >= 0)
> [...]
> > +  Find(".").accept(found_ini, 2);	// Only search one level deep.
> 
> If you would use post-decrement, then that comment would be a bit less
> puzzling (after the change of 2->1), I'd think.

No, that's a bug.  It should visit two levels (./$target, ./$url/$target).
I started with one level but then screwed up.   Thanks for catching.

> The change itself breaks a few cases that maybe aren't supported,
> but nevertheless worked for quite some time.

What cases?

Just to be clear, the introduction of the target subdirs broke any
former working scenario to install from a local dir, be it a mirror or a
setup.exe install dir.  Both of these cases should work again (assuming
the above is fixed).

I'm not aware of any other scenario besides ./$target and ./$url/$target
we will have to support.  Can you give a brief outline of the scenarios
which aren't supported anymore from your POV?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]