This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH 1/4 setup] package re-/de-installation from CLI
- From: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
- To: cygwin-apps at cygwin dot com
- Date: Mon, 07 Oct 2013 19:08:00 +0100
- Subject: Re: [PATCH 1/4 setup] package re-/de-installation from CLI
- Authentication-results: sourceware.org; auth=none
- References: <87a9lexyk8 dot fsf at Rainer dot invalid> <20130724115129 dot GT9689 at calimero dot vinschen dot de> <874nbjbsbw dot fsf at Rainer dot invalid> <874nbjade0 dot fsf_-_ at Rainer dot invalid> <5252CD17 dot 4080001 at dronecode dot org dot uk> <20131007162108 dot GA3534 at ednor dot casa dot cgf dot cx>
On 07/10/2013 17:21, Christopher Faylor wrote:
> On Mon, Oct 07, 2013 at 04:02:47PM +0100, Jon TURNEY wrote:
>> On 24/07/2013 21:53, Achim Gratz wrote:
>>> From 1686e0beac98867bf1fe358a8fe9a9d8647d4a3a Mon Sep 17 00:00:00 2001
>>> From: Achim Gratz <Stromeko-GL6zORMxvAD+tKtrA809HA-XMD5yJDbdMReXY1tMh2IBg@public.gmane.org>
>>> Date: Fri, 8 Feb 2013 20:58:20 +0100
>>> Subject: [PATCH 1/4] Remove detrimental initialization
>>>
>>> * choose.cc (createListview): Remove superflous and detrimental
>>> default trust setting. This has already been set correctly
>>> in OnInit.
>>> ---
>>> choose.cc | 5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/choose.cc b/choose.cc
>>> index 6d5f3b7..4e0bcd4 100644
>>> --- a/choose.cc
>>> +++ b/choose.cc
>>> @@ -148,11 +148,6 @@ ChooserPage::createListview ()
>>> log (LOG_BABBLE) << "Failed to set View button caption %ld" <<
>>> GetLastError () << endLog;
>>>
>>> - for (packagedb::packagecollection::iterator i = db.packages.begin(); i != db.packages.end(); i++)
>>> - {
>>> - i->second->set_requirements(chooser->deftrust);
>>> - }
>>> -
>>
>> There have been a few reports that setup no longer installs the dependencies
>> of explicitly specified packages in unattended mode, and this seems to be the
>> culprit.
>>
>> A small patch to fix this is attached.
>
> Thanks for finding this. Please check it in and I'll roll out a new version
> of setup.exe.
Checked in (with ChangeLog entry I forgot to put in the email)