This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cygport improvements: upload, fish, src_prep_fini_hook


> > >BTW I see that you commented out the line:
> > >
> > >echo "rm -f !ready || echo -n"
> > >
> > >in the lftp script in __pkg_upload().  That line is there to prevent a race
> > >condition if the maintainer has already made one upload, then later starts
> > >to make another one, at the same time that upset starts to copy files from
> > >the upload area.  In that case, upset could copy partially uploaded or
> > >corrupt files.  To prevent that, we first remove !ready, then put it back
> > >later after the new upload is complete.
> > 
> > Thanks for reminding me: I was wondering if it made more sense to place a
> > !ready file in each top-level package directory, or handle each arch like
> > you have done.  I could see arguments either way, so I'm open to
> > suggestions.
> 
> Isn't a `cygport <cygportfile> upload always per-arch?

It's per-arch and per-package, so the !ready file can go in the $ARCH/$PN
directory, instead of $ARCH.  That's what Yaakov is suggesting.

I think that is better - more specific since uploads are per-package. I'll
make it so.  We still want to remove any exiting $ARCH/$PN/!ready file
first though, to prevent race conditions if a packager decides to re-upload
a package while upset is starting to copy the package files.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]