This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: setup

On Jun 30 06:59, Achim Gratz wrote:
> Corinna Vinschen writes:
> > With `git gui' you can easily split a patch in multiple parts by using
> > the ability to commit single patch hunks.
> I can do this just fine with Emacs and magit.  Again, the problem really
> is that the resulting individual commits would either not compile or not
> work correctly unless I would write and test yet more code to make it
> so.

Ok, for once.  But please make sure that you split the commit into
functional chunks next time it's so large.  And send it to this list, so
code snippets can be referenced in the review.

A few more nits, mostly on style:

- What I'm missing are code comments in do_local_ini and do_remote_ini
  describing what the new methods do.  Yes, the old code didn't have a
  lot of comments either, but it would be nice to have this better
  explained for future reference.

- Do you plan to keep the DEBUG_FROMCWD bracketed code in there?  If so,
  it should probably just use `#if DEBUG' as elsewhere.

- The call to yydebug=1 is almost invisible now.  Please revert that
  to the old 

    [empty line]
    /*yydebug = 1; */
    [empty line]

- ini_decompress as a function name may be a bit misleading.  What
  about decompress_ini_file instead?

Otherwise it looks ok, especially splitting the code into the new
functions ini_decompress/decompress_ini_file and check_ini_sig and
removing IniParseFindVisitor is a blessing.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpLk1XIxAOYq.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]