This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH setup 08/15] Fix comments and indentation in check_for_cached
Jon Turney writes:
> + /* Note that the cache dir is represented by a mirror site of file://local_dir */
> std::string prefix = "file://" + local_dir + "/";
> - /* FIXME: Nullness check can go away once packagesource is properly
> - * std::string-ified, and doesn't use overcomplex semantics. */
> - std::string fullname = prefix +
> - (pkgsource.Canonical() ? pkgsource.Canonical() : "");
> + std::string fullname = prefix + pkgsource.Canonical();
That part of the patch was a bit premature, but I see you've already
fixed it. I found that interestingly it only crashed on 64bit, which
seems a bit odd, but maybe that's Windows for you.
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf Q+, Q and microQ: